--- Log opened Thu Aug 08 00:00:33 2019 00:05 -!- ilyasrid1uan [~ilyasridh@14-203-136-98.tpgi.com.au] has quit [Ping timeout: 248 seconds] 00:23 -!- ilyasrid1uan [~ilyasridh@14-203-136-98.tpgi.com.au] has joined #bitcoin-core-dev 00:24 -!- ilyasrid1uan [~ilyasridh@14-203-136-98.tpgi.com.au] has quit [Client Quit] 00:52 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 260 seconds] 00:55 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 00:55 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 01:00 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 244 seconds] 01:05 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:10 -!- shesek` [~shesek@5.22.134.181] has joined #bitcoin-core-dev 01:12 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:14 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev 01:38 < setpill> what is the recommended way to cleanly shut down bitcoind running in the background? 01:39 < setpill> seems like sending sigterm does an unclean shutdown 01:40 < belcher> setpill this is a question more for #bitcoin than here, but try running `bitcoin-cli stop` 01:40 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:40 < setpill> belcher: it's related to the default systemd service file of bitcoin core not shutting it down cleanly when using `systemctl stop bitcoind.service` 01:43 < setpill> hm it might also be a timeout issue 01:43 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:44 < setpill> ie. systemd going for the sigkill before the db has been flushed to disk 01:55 < jonasschnelli> Unfortunate that our current ChaCha20Poly1305@Bitcoin implementation works on a single buffer. 01:56 < jonasschnelli> Makes it harder to avoid vector::insert's / possible relocations 01:58 < jonasschnelli> Ideally the AEAD would work on three buffers, 1| the "header" (3 byte packet length a.k.a. AD + command), 2| the message payload, 3| the 16byte MAC tag 02:00 -!- Kampala [~Kampala@89.249.74.218] has quit [] 02:02 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 245 seconds] 02:05 -!- kierank1 [~kierank@195.206.169.238] has joined #bitcoin-core-dev 02:07 < provoostenator> setpill: that would be useful to know; I imagine that can cause serious problems for low end devices, e.g. some raspebbery pi that needs to reboot after a system update 02:08 < provoostenator> I use more or less the default systemd example one of my own machines and haven't had issues with unclean shutdowns that I know, but I never stress tested that. 02:15 < setpill> provoostenator: it depends on how big your dbcache is and how much syncing you have done since the last time bitcoind was started 02:16 < setpill> Related to https://github.com/bitcoin/bitcoin/issues/11600 02:17 -!- lalitmee [~lalitmee@49.204.86.234] has joined #bitcoin-core-dev 02:17 < setpill> I just tried `bitcoin-cli stop` (rather than `systemctl stop bitcoind.service`) and it took almost 9 minutes. 02:18 < setpill> But that's with a node that had synced non-stop from ~block 500000 02:18 < setpill> And with a 15GB dbcache 02:22 < setpill> I think setting `TimeoutStopSec=infinity` in the bitcoind.service file should fix it properly (though you'll want to be cognizant that shutdown of your device might take ages) 02:22 < setpill> Will make a PR 02:23 < provoostenator> That seems reasonable at first glance, but I'm no systemd expert. I assume reboot will run out of patience? 02:23 < setpill> Not sure about that, good question. 02:24 < provoostenator> Is it possible to "fail" the stop, instead waiting forever? 02:24 < setpill> Well that's what it does now, I guess. 02:24 < provoostenator> At least it makes sense to ask for the user to intervene if the node doesn't gracefully stop. 02:24 < setpill> Simply sigkills. 02:24 < setpill> It's possible to disable the sigkill at end of timeout. 02:25 < setpill> But imho that's worse because it doesn't properly restart the service. 02:25 < provoostenator> No that's not what I mean. I mean "systemctl stop bitcoind" could return an error without doing sigkill, basically "I can't stop this process" 02:25 < setpill> Ie. `systemctl restart bitcoind.service` is a `stop` followed by a `start` 02:25 < setpill> If the `stop` timeouts without successfully stopping the service, it will not perform the `start` 02:26 < setpill> Which might be worse than the restart happening 10 minutes later than you'd expect, but still as soon as possible. 02:27 < provoostenator> From the docs: "If a service of Type=notify sends "EXTEND_TIMEOUT_USEC=…", this may cause the stop time to be extended" 02:28 -!- rex4539 [~rex4539@2a02:587:3514:c700:6404:39ae:8d8c:accc] has joined #bitcoin-core-dev 02:28 < wumpus> SIGTERM and SIGHUP do a clean shutdown 02:28 < wumpus> @setpill 02:30 < setpill> wumpus: thanks for the confirmation :) 02:30 < wumpus> sorry, SIGTERM and SIGINT 02:30 -!- jpe [~jpe@185.216.35.254] has joined #bitcoin-core-dev 02:31 < wumpus> SIGHUP reopens the debug.log https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L903 02:31 < setpill> provoostenator: that might *also* be an option yes. I will open an issue about this so these points can be recorded for later reference 02:32 < provoostenator> If we wanted to switching from type "forking" to type "notify" that involves changes in the code to use sd_notify. Systemd docs seem to prefer that. 02:32 < setpill> Just feels conceptually "wrong" to let the shutdown timeout when it's still hard at work and has not frozen at all. 02:34 < setpill> Ah, https://github.com/bitcoin/bitcoin/issues/13736 related 02:35 < provoostenator> setpill: that sounds like the right ticket to update 02:41 -!- jpe [~jpe@185.216.35.254] has quit [Remote host closed the connection] 02:42 -!- jpe [~jpe@185.216.35.254] has joined #bitcoin-core-dev 02:45 -!- jpe [~jpe@185.216.35.254] has quit [Remote host closed the connection] 02:45 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 02:49 -!- kcalvinalvin [~calvin@118.131.103.244] has quit [Ping timeout: 245 seconds] 02:51 -!- davex_ [~user@45.74.60.149] has quit [Ping timeout: 246 seconds] 02:52 -!- davex__ [~user@45.74.60.148] has joined #bitcoin-core-dev 02:54 -!- jpe [~jpe@185.216.35.254] has joined #bitcoin-core-dev 02:56 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 03:00 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has quit [Ping timeout: 260 seconds] 03:02 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has joined #bitcoin-core-dev 03:02 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:07 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 03:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:37 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 03:45 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Read error: Connection reset by peer] 03:45 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Read error: Connection reset by peer] 03:45 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 03:50 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Ping timeout: 246 seconds] 03:55 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 03:56 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds] 03:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:14 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 04:21 -!- Aaronvan_ is now known as AaronvanW 04:42 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 04:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 04:43 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has quit [Remote host closed the connection] 04:43 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev 04:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:48 < bitcoin-git> [bitcoin] setpill opened pull request #16569: Disable systemd stop timeout (master...fix-systemd-shutdown) https://github.com/bitcoin/bitcoin/pull/16569 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:00 -!- kierank1 [~kierank@195.206.169.238] has quit [] 05:04 -!- Bille [~Bille@89.238.178.75] has joined #bitcoin-core-dev 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:05 < bitcoin-git> [bitcoin] davereikher opened pull request #16570: Make descriptor tests deterministic (master...make_descriptor_tests_deterministic) https://github.com/bitcoin/bitcoin/pull/16570 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:41 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 05:42 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 05:53 -!- lalitmee [~lalitmee@49.204.86.234] has quit [Ping timeout: 244 seconds] 06:11 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 06:13 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 06:26 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:26 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 06:26 -!- _Sam-- [~greybits@unaffiliated/greybits] has quit [Read error: Connection reset by peer] 06:28 -!- _Sam-- [~greybits@unaffiliated/greybits] has joined #bitcoin-core-dev 06:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 248 seconds] 06:39 -!- davterra [~none@c-73-221-225-225.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:46 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 06:52 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:00 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16571: gui: Make Bitcoin Core logo pure black (master...1908-guiIcoPureBlack) https://github.com/bitcoin/bitcoin/pull/16571 07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:00 -!- lalitmee [~lalitmee@36.255.86.118] has joined #bitcoin-core-dev 07:00 -!- alko [~alko@BSN-77-147-172.static.siol.net] has joined #bitcoin-core-dev 07:03 < MarcoFalke> #proposedmeetingtopic Who wants to volunteer as co-maintainer of the Bitcoin Core flatpak? 07:06 < luke-jr> I tried to make a flatpak but couldn't get it to work :/ 07:10 -!- lightlike [~lightlike@2001:16b8:5747:db00:e40e:2f22:9fe7:c9c5] has joined #bitcoin-core-dev 07:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:32 -!- lalitmee [~lalitmee@36.255.86.118] has quit [Quit: Leaving] 07:37 -!- rex4539 [~rex4539@2a02:587:3514:c700:6404:39ae:8d8c:accc] has quit [Quit: rex4539] 07:41 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds] 07:41 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 244 seconds] 07:45 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:48 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:52 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 07:55 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-xylbruckdqjsoaki] has joined #bitcoin-core-dev 07:58 < elichai2> I added the control block to the `SignatureData` struct, and I'm filling it in `ProduceSignature`(right now it's greedy and takes the first script that it can sign for) but for the signing support itself i'll wait for achow101's native descriptors PR :) until then i'll rebase my psbt stuff to use the new descriptor 07:58 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 08:00 -!- Bille [~Bille@89.238.178.75] has quit [] 08:01 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:01 -!- rajarshi [~quassel@103.24.86.139] has joined #bitcoin-core-dev 08:02 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:03 -!- rajarshi [~quassel@103.24.86.139] has quit [Client Quit] 08:08 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 08:10 -!- kljasdfvv [~flack@p200300D46F0E7800611D199F7B7450EF.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 08:10 -!- kljasdfvv [~flack@p200300D46F0E7800A58A705A909F52DC.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 08:14 -!- flamingspinach [~flamingsp@139.28.218.198] has joined #bitcoin-core-dev 08:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 08:46 -!- ThomasLuong [~ThomasLuo@209.63.53.36] has joined #bitcoin-core-dev 08:47 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: No route to host] 08:48 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 09:02 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 09:03 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:06 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:09 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:13 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has quit [Quit: Leaving] 09:20 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 09:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:36 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 09:38 -!- xzytrewq [~quassel@199.58.187.147] has joined #bitcoin-core-dev 09:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 09:40 -!- hebasto [~hebasto@95.164.65.194] has quit [Read error: Connection reset by peer] 09:40 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 272 seconds] 09:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:42 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 09:43 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 245 seconds] 09:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 09:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:56 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 246 seconds] 10:00 < dongcarl> Wondering anyone had thoughts on a generic feature-signaling message for non-monotonic features that don't fit in the protocol version model 10:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:01 < dongcarl> Has there been prior art? 10:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 10:04 < sipa> BIP 36 perhaps 10:04 < sipa> long ago 10:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:05 < dongcarl> Was there any reason why this wasn't adopted? Or just no one implemented? 10:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:12 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:13 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 10:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:14 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Client Quit] 10:17 < achow101> github has their own CI now https://github.com/features/actions?utm_campaign=1565242028&utm_medium=social&utm_source=twitter&utm_content=1565242028 10:17 < achow101> maybe it will be better than travis? 10:18 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 248 seconds] 10:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds] 10:19 -!- emilengler [~emilengle@v22019078727393219.powersrv.de] has joined #bitcoin-core-dev 10:19 -!- emilengler [~emilengle@v22019078727393219.powersrv.de] has quit [Changing host] 10:19 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 10:20 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Remote host closed the connection] 10:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:21 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:24 < dongcarl> #proposedmeetingtopic [maybe short] generic feature-signaling message for non-monotonic features that don't fit in the protocol version model (like BIP 36) 10:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:25 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 10:25 < sipa> FWIW, i think the "sendX" type negotiation works pretty well 10:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:29 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:33 < dongcarl> sipa: works pretty well = overhead + the extra message types not that big of a deal? 10:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:34 < sipa> they're sent exactly once 10:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:34 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer] 10:36 < dongcarl> true... okay perhaps this isn't that big of a problem. 10:37 * dongcarl wishes there were a #cancelproposedmeetingtopic 10:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:45 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 10:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:52 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection] 10:58 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:00 -!- flamingspinach [~flamingsp@139.28.218.198] has quit [] 11:00 -!- roconnor [~roconnor@host-45-58-228-96.dyn.295.ca] has quit [Ping timeout: 248 seconds] 11:00 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 11:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 11:10 -!- hanhua [68840050@104.132.0.80] has joined #bitcoin-core-dev 11:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:14 -!- mcorpgc [~mcorpgc@178.162.204.238] has joined #bitcoin-core-dev 11:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 11:18 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 11:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 11:26 -!- reallll is now known as belcher 11:29 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:32 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:51 < MarcoFalke> [13:17] github has their own CI now https://github.com/features/actions?utm_campaign=1565242028&utm_medium=social&utm_source=twitter&utm_content=1565242028 11:51 < MarcoFalke> Thanks 11:52 < MarcoFalke> :eyes: 11:54 < sipa> i'd be concerned about centralizing more of our workflow around github, if we'd move from travis to the built-in CI... 11:54 < MarcoFalke> travis only works with GitHub, so I fail to see how it would make anything worse 11:55 < jonasschnelli> I'm also concerned to add more crucial stuff around github 11:55 < MarcoFalke> If it is the same thing with the only difference that we don't have to manually re-run every build, I'd consider it a huge win 11:56 < jonasschnelli> Well,.. don't forget the https://bitcoinbuilds.org/ option. :) 11:56 < jonasschnelli> But I agree that travis, with github only is not much of a difference 11:57 < MarcoFalke> jonasschnelli: It needs some sort of integration with GitHub 11:57 < jonasschnelli> BTW: semaphore2 has now public PR build support 11:57 < jonasschnelli> MarcoFalke: I can integrate it with GitHub's "checks" API. 11:57 < jonasschnelli> Done in 1-2 days... 11:57 < jonasschnelli> But I first want to prove that my CI can run for 2-3 month without issues 11:58 < sipa> i think a self-hosted CI is over time going to be a better solution anyway 11:58 < jonasschnelli> Then a next integration step could be done 11:58 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #bitcoin-core-dev 11:58 < MarcoFalke> jonasschnelli: Also, it needs to be open to the public (forked repos) 11:58 < MarcoFalke> And offer free minutes for open source 11:58 < jonasschnelli> MarcoFalke: it won't 11:58 < jonasschnelli> The CI will only build PRs and master branch (eventually older branches as well at some point) 11:59 < achow101> MarcoFalke: so long as a config file that can be used elsewhere is present, I don't see a problem with also using bitcoinbuilds.org 11:59 < achow101> Why not just have both? 11:59 < MarcoFalke> How would I run all the ci settings when my workstation is a laptop? Create a pull request against core? 12:00 < jonasschnelli> MarcoFalke: the bitcoinbuilds.org CI is our last check. How developers check their work is their thing 12:00 < jonasschnelli> (prior to PR) 12:00 < achow101> jonasschnelli: it's nice to be able to run the CI checks on your own branch before a PR 12:00 < sipa> meeting? 12:00 < MarcoFalke> It takes a long time to compile and run the tests with all possible sanitizer options and configure options 12:01 < wumpus> #startmeeting 12:01 < lightningbot> Meeting started Thu Aug 8 19:01:03 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:01 < moneyball> hi 12:01 < kanzure> hi 12:01 < jnewbery> hi 12:01 < jonasschnelli> hi 12:01 < MarcoFalke> hi 12:01 < achow101> hi 12:01 < ariard> hi 12:01 < sipa> hi 12:01 < phantomcircuit> hi 12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral 12:01 < wumpus> hi 12:01 < fanquake> Hi 12:01 < real_or_random> hi 12:01 < meshcollider> hi 12:02 < MarcoFalke> I'd rather stick with some GitHub specific stuff that works than to ditch GitHub specific stuff and make running the tests harder for developers 12:02 < wumpus> any last-minute proposed topics? 12:02 < aj> hey 12:02 < moneyball> https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a 12:02 < wumpus> there's one by MarcoFalke: Who wants to volunteer as co-maintainer of the Bitcoin Core flatpak 12:02 < dongcarl> wumpus: could you remove my proposed? 12:02 < wumpus> dongcarl: moneyball already did 12:02 < MarcoFalke> We can always keep the bitcoin-builds as a backup fallback ci 12:02 < phantomcircuit> MarcoFalke, it really depends on how powerful their build servers are, for a relatively small price a very powerful server could be acquired and used for builds 12:03 < MarcoFalke> #proposedmeetingtopic GitHub ci 12:03 < wumpus> #topic High priority for review 12:03 < MarcoFalke> phantomcircuit: Not every developer has a credit card, even if they can afford the price of the ci 12:03 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 12:03 < achow101> I don't see why we can't just use both. would it not be possible to make bitcoinbuilds just read the same config file as github's? 12:04 < wumpus> 6 blockers, 6 chasing concept ACKs 12:04 < wumpus> why are we talking about credit cards ? 12:04 < MarcoFalke> Agree with achow101 12:04 < jonasschnelli> (lets take the CI discussion to #bitcoin-builds plz) 12:04 < MarcoFalke> wumpus: Sorry, will shut up now about ci 12:04 < wumpus> I think the BIP9 bury PR is very near merge-ready 12:04 < wumpus> #16060 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/16060 | Bury bip9 deployments by jnewbery · Pull Request #16060 · bitcoin/bitcoin · GitHub 12:05 < wumpus> anything to add/remove/replace from the project? 12:05 < MarcoFalke> It is still in the process of review and some fixups keep getting found 12:05 < MarcoFalke> (re 16060) 12:05 < wumpus> MarcoFalke: mostly small nits on nits about RPC behavior, from what I've seen 12:05 < aj> #8994 can be removed from chasing concept ack? 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub 12:06 < phantomcircuit> MarcoFalke, no what im saying is that we could collectively buy a server that could do the builds, in general things where you're buying "packaged" cpu time from third parties end up being very expensive 12:06 < jnewbery> wumpus: there was at least a bug in the test case which I'm fixing now 12:06 < jnewbery> I would appreciate rereview after I push that fix 12:06 < wumpus> jnewbery: sure 12:07 < MarcoFalke> jnewbery: Will take another look in the next couple of days 12:07 < MarcoFalke> Also, I plan to review sdaftuar's pr (it has been on my list for a while, but I haven't gotten to it yet) 12:08 < wumpus> thanks 12:08 < fanquake> wumpus: first topic? 12:08 < wumpus> we're done with high priority for review? 12:09 * jonasschnelli waves at #16202 (quick review, on the path to p2p encryption) 12:09 < gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub 12:10 < wumpus> #topic Who wants to volunteer as co-maintainer of the Bitcoin Core flatpak (MarcoFalke) 12:10 < achow101> who currently maintains it? 12:10 < jonasschnelli> can someone explain flatpak? 12:10 < MarcoFalke> It isn't created yet 12:10 < MarcoFalke> jonasschnelli: It is like a snap package 12:10 < wumpus> it's a distribution agnostic binary package distribution format 12:10 < MarcoFalke> Different name, though 12:10 < wumpus> for linux 12:11 < jonasschnelli> Okay. Sounds acceptable. 12:11 < wumpus> it's especially good for GUI applications, it has some features like sandboxing and desktop UI integration which simply dropping static binaries has not 12:12 < MarcoFalke> I will be a repository hosted under the flatpak org, so not in our org. Which is why I am asking for co-maintainers. 12:12 < wumpus> see #16550 12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/16550 | Distribute via flatpak · Issue #16550 · bitcoin/bitcoin · GitHub 12:12 < wumpus> i'd love to help but can't promise to have any time and motivation for any extra work at the moment, sorry 12:13 < MarcoFalke> Sure. Maybe jonasschnelli? 12:13 < MarcoFalke> Or fanquake? 12:13 < sipa> it seems flatpak is also usable independent of a central repo 12:13 < sipa> while snap really needs canonical's infrastructure? 12:13 < MarcoFalke> jup, snap needs the Ubuntu infrastructure 12:13 < fanquake> MarcoFalke: what’s required to maintain? Just uploading releases and managing issues? 12:14 < sipa> flatpak has flathub, but it's not required 12:14 < MarcoFalke> fanquake: Only requirement is that you are a less agressive jaywalker 12:14 < sipa> (just reading and learning) 12:14 < fanquake> 👀 12:14 < jonasschnelli> Sorry... already at my timelimit 12:14 < sipa> MarcoFalke: one must know how to spell aggressive correctly, however 12:15 < MarcoFalke> right 12:15 < fanquake> Can’t promise anything 🏃‍♂️ 12:15 < MarcoFalke> Is there an autocorrect for IRC? 12:16 < MarcoFalke> fanquake: Cool, I'll sign you up. 12:16 < wumpus> hehe,switch to matrix, it has message editing 12:17 < fanquake> MarcoFalke: heh, I was worried that just by asking a question that would happen 12:17 < fanquake> wumpus: Next topic then? 12:18 < wumpus> #topic GitHub ci (MarcoFalke) 12:18 < MarcoFalke> fanquake: I expect it will look like this: https://github.com/bitcoin-core/packaging/pulls?q=is%3Apr+author%3AMarcoFalke+is%3Aclosed 12:18 < MarcoFalke> I.e. bump version every 3 months 12:18 < MarcoFalke> So nothing too fancy 12:18 < MarcoFalke> ok, next topic 12:18 < fanquake> MarcoFalke: ok 👍 12:19 -!- fox2p_ [fox2p@gateway/vpn/mullvad/fox2p] has quit [Ping timeout: 244 seconds] 12:19 < MarcoFalke> I think everyone knows by now that travis isn't the most stable ci solution 12:19 < wumpus> PSA: first deadline (soft translation string freeze) for 0.19.0 is in less than a month, 2019-09-01 12:19 -!- fox2p [fox2p@gateway/vpn/mullvad/fox2p] has joined #bitcoin-core-dev 12:20 < MarcoFalke> So in exploring alternatives, the GitHub ci might be a good medium-term replacement 12:20 < wumpus> MarcoFalke: definitely, it's not a good fit for how we're using it at least 12:20 < moneyball> MarcoFalke: is the GitHub CI public info? 12:20 < MarcoFalke> Both, travis and the GitHub ci, will be GitHub-centered. That should be fine, imo. 12:20 < achow101> https://github.com/features/actions 12:20 < moneyball> ah, i see it is 12:20 < achow101> they just announced it today, it's in beta 12:20 < wumpus> I've never heard of github ci 12:20 < MarcoFalke> moneyball: Yes, according to achow101 12:21 < moneyball> when Pieter, Cory, Matt, and I visited GitHub, they demo'd this 12:21 < wumpus> but if it can take over what travis does and does it beter, without too much work from our side, that'd be very useful 12:21 < moneyball> cfields has strong views on this 12:21 < MarcoFalke> wumpus: Jup, agree 12:22 < achow101> moneyball: any opinions about it from the demo you saw? 12:22 < MarcoFalke> moneyball: cfields: Elaborate, pls 12:22 < wumpus> cfields can't be here today afaik 12:22 < jnewbery> moneyball: can you summarise the strong feelings? 12:22 < fanquake> Also agree. 12:22 < achow101> strong feelings in a good or bad way? 12:22 < sipa> bad. 12:22 < moneyball> Concerns about increasing dependence on GitHub/Microsoft 12:23 < jonasschnelli> Yes 12:23 < MarcoFalke> Again, I don't think it gets worse. Also, we can use jonasschnelli's ci as a fallback (running in the background 24/7) 12:23 < fanquake> jonasschnelli: do you want to update on the state of your CI? As an alternative? 12:23 < moneyball> Which I agree is a valid point. My response was "What kind of productivity improvement over Travis would we need to see to want to move in that direction?" but I didn't really get a good answer. So, I'd pose that question here. 12:23 < jonasschnelli> Update on the self hosted custom open source CI (bitcoinbuilds.org): it does now (since a week) successfully builds all PRs, mostly quicker than travis (though less envs). Integration with Github is doable and easy. But first lets see how it runs for at least 2 months. 12:24 < jonasschnelli> Plan is to use the Github checks API when we think it has been proven to be reliable (2 month) 12:24 < wumpus> moneyball: "no false positives" 12:24 < moneyball> Another point made was concern that GitHub 3rd party API might suffer / degrade over time making 3rd party tools like Travis even worse (relative to GitHub CI) 12:24 < wumpus> (or at least, neglible amount of, the problem with travis is false positives) 12:24 < sipa> one point is that it seems to provide far more entry points than a normal CI does (it does much more automation of workflows, not just CI), and starting to depend on those seems like it would make it harder to move away (if ever needed) 12:25 < jonasschnelli> good point 12:25 < MarcoFalke> Yeah, good point. 12:25 < wumpus> I wouldn't want to rely on it for automation of workflows 12:25 < fanquake> Heh. We’ve already got plenty of GH “turned off” as well. 12:25 < moneyball> I'm not sure if their announcement today means anyway can experiment with it not, but if not, then we have an invitation to experiment with it, if anyone is interested. 12:25 < wumpus> just taking over what travis does now 12:25 < jonasschnelli> They tend to mix auto-fix (code format correction and stuff) with CI which is indeed not only good 12:25 < sipa> as long as it's a drop-in replacement of one CI for another, i agree there isn't much impact 12:25 < MarcoFalke> We should only use it for the purpose of ci builds 12:25 < wumpus> auto-fix ? no way 12:26 < MarcoFalke> " You’re in the queue for the beta—we’ll let you know as soon as you have access. " 12:26 < wumpus> that sounds realllllly scary 12:26 < wumpus> damn 12:26 < sipa> that's just an example of something you can configure 12:26 < sipa> not a default thing 12:26 < MarcoFalke> yes, all of the other stuff is just scary 12:26 < wumpus> so now you CI doesn't only have false positives, it can introduce bugs and backdoors into your code ! 12:26 < jonasschnelli> wumpus: https://developer.github.com/apps/quickstart-guides/creating-ci-tests-with-the-checks-api/#step-26-automatically-fixing-rubocop-errors 12:27 < MarcoFalke> Like self-driving cars for software development 12:27 < wumpus> yea, lt's disable it, as fanquake says we have plenty of gh features disabled, what is one more … though it's something to watch 12:27 < wumpus> yes, exactly 12:28 < luke-jr> jonasschnelli: we've "tested" other CIs live - no reason not to do it with our own 12:29 < fanquake> So is the resolution here to just wait until we can look at GH CI properly? Maybe test it in production alongside Travis? 12:29 < wumpus> that sounds good to me 12:29 < jonasschnelli> ack 12:29 < achow101> ack 12:29 < luke-jr> Does GH CI work with non-GH repos? 12:29 < MarcoFalke> no 12:29 < achow101> luke-jr: i highly doubt it 12:29 < wumpus> luke-jr: only if you mirror them to github, I guess 12:29 < sipa> luke-jr: embrace, extend, ... 12:29 < luke-jr> I'm with cfields on that then… 12:29 < MarcoFalke> luke-jr: Does travis work with non-GH repos? 12:30 < luke-jr> I mean, if it's the only thing working, fine temporarily I guess, but I'd rather get away from GH dependency, not more entrenched 12:30 < wumpus> luke-jr: definitely agree on that 12:30 < luke-jr> MarcoFalke: not sure 12:30 -!- rex4539 [~rex4539@2a02:587:3514:c700:10b1:b496:63a9:5684] has joined #bitcoin-core-dev 12:30 < achow101> I really thing we should just do both GH CI and bitcoinbuilds and just have them use the same config file 12:30 < jonasschnelli> It looks like GitHub is taking over Git the same way gmail took over email... be aware 12:30 < moneyball> does anyone want to test the GitHub CI now? let me know and I will introduce 12:30 < luke-jr> achow101: +1 12:30 < luke-jr> I wonder how long until there's some kind of standard for CIs 12:30 < jonasschnelli> Nice centralized development functionality comes at a price 12:31 < achow101> so we aren't entirely dependent on Github, but for individual developers, they can still run CI checks 12:31 < sipa> achow101: i like that idea; it also forces us to keep the configuration to be compatible with non-GH features 12:31 < wumpus> luke-jr: seems no, travis cannot use anything else than github, unless you have the enterprise version 12:31 < luke-jr> moneyball: does it require permission to use? 12:31 < aj> jonasschnelli: could test in production, but have it report "success" or "neutral" rather than "success" or "failure" maybe? 12:31 < sipa> luke-jr: during the beta, yes 12:31 < luke-jr> achow101: "make cichecks" would be nice :D 12:31 < achow101> luke-jr: can't run on all of the platforms on one machine 12:32 < luke-jr> achow101: why not? :\ 12:32 < dongcarl> qemu 12:32 < jonasschnelli> aj: Yes. That would make sense. 12:33 < dongcarl> so, perhaps _someone_ should try out the GitHub CI, and see if it's better than Travis, as a stop gap 12:33 < wumpus> dongcarl: from my testing a few years ago, qemu-user works pretty well for the tests, at least if you stick to platforms with the same endianness 12:33 < luke-jr> it sounds like bitcoinbuilds is further along than GitHub CI? 12:33 < MarcoFalke> Could someone share a writeup of how to run the functional tests in qemu, pls? 12:34 < luke-jr> MarcoFalke: write a shell script that runs the bitcoind bin, and export BITCOIND=/path/to/script 12:34 < achow101> moneyball: you said we have an invitation to experiment with github CI? 12:34 < moneyball> Yes 12:34 < achow101> can we skip the queue? 12:35 < moneyball> Presumably since they offered to let us use it a month ago 12:35 < dongcarl> Is there a zero-effort Travis yml -> GH CI transition? 12:35 < sipa> i doubt that 12:35 < MarcoFalke> dongcarl: no 12:35 < dongcarl> :-/ 12:36 < dongcarl> Why not stick to Travis till bitcoinbuilds is ready? 12:36 < MarcoFalke> But the travis.yml mostly specifies the env, so it shouldn't be too hard either 12:36 < achow101> dongcarl: because travis false positives too much 12:36 < luke-jr> yeah, I imagine at least some of the scripts should be portable 12:36 < MarcoFalke> I'd still like to run a ci with free minutes along of bitcoinbuilds 12:37 < jonasschnelli> Me 2 12:37 < luke-jr> "free minutes along of bitcoinbuilds"? 12:37 < achow101> moneyball: can you ask them let some of us into the beta so we can try it out on our own repos first? 12:37 < MarcoFalke> fee cpu time 12:37 < jonasschnelli> I think centralized development tools are fine as long as there is an alternative running in parallel 12:37 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:37 < MarcoFalke> *free 12:37 < luke-jr> ah 12:37 < luke-jr> I have lots of free ppc64le CPU time I think 12:37 < jonasschnelli> The problem is lock-in, suddenly they charge for it or make it incompatible with your needs, ...and you'r screwed 12:37 < dongcarl> jonasschnelli: Agreed. 12:37 < moneyball> achow101: yes would you like access? 12:38 < achow101> sure 12:38 < phantomcircuit> achow101, travis is mostly hitting fp on resource exhaustion issues 12:38 < luke-jr> moneyball: they can't just enable the entire repo +forks? :/ 12:38 < moneyball> i don't know 12:38 < sipa> yeah, let's ask them how this works 12:38 < moneyball> i will clarify with them 12:38 < achow101> just enable it for anyone in the bitcoin and bitcoin-core orgs :) 12:38 < MarcoFalke> Let's not enable the repo for now and keep testing in forks only 12:38 < jonasschnelli> I'd also hope we consider some ethos and not further extend our reliance on github 12:40 < wumpus> jonasschnelli: I agree, it's just, if we don't rely on anything further then switching from travis to github for CI doesn't make a difference, they're both centralized and githyb only 12:40 < fanquake> wumpus: any other topics? 12:40 < wumpus> nope 12:41 < jonasschnelli> wumpus: There is maybe no technical difference,... but the signal to the community/world is different 12:41 < MarcoFalke> Ok, that is a point I buy. They might say the GitHub ci is "approved by Bitcoin Core" 12:41 < wumpus> Could someone share a writeup of how to run the functional tests in qemu <- I'll try if I get around to it, I think the most difficult part is setting up the faux-root filesystem for the target, though on some distros you can install that as package 12:42 < wumpus> MarcoFalke: yes, that's scary 12:42 < jonasschnelli> "Bitcoin Core implemente GitHub CI after talks with their CEO,... a week after they acted in massive censorship" 12:42 < jonasschnelli> (I know I overstretch it) 12:43 < fanquake> Then we’d all have to jump on Medium and explain our actions in an emoji filled post mortem. 12:43 < luke-jr> might be a harder story to spin if we have our own CI at the same time 12:44 < achow101> we could deploy both github CI and bitcoinbuilds simultaneously? 12:44 < wumpus> haha way to go, fly ahead of the rumors in the meeting 😅 12:44 < luke-jr> "We're migrating to our own CI, but helping GitHub test theirs too" 12:44 < MarcoFalke> I'll experiment with the ci a bit in the coming days to see if it fits our use case. We can discuss more after everyone had a look 12:44 < jonasschnelli> thanks MarcoFalke 12:44 < achow101> +1 12:45 < wumpus> yes, let's try that, maybe it's worse a match for our CI needs than travis is, then it's not even worth discussing further 12:45 < wumpus> #endmeeting 12:45 < lightningbot> Meeting ended Thu Aug 8 19:45:46 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:45 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-08-19.01.html 12:45 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-08-19.01.txt 12:45 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-08-19.01.log.html 12:47 * fanquake back to sleep 12:52 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:57 -!- rapidphase [~trillhc@c-71-232-65-53.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 12:57 < jamesob> sorry I missed the meeting - can I get #16443 thrown on the high prio list? 12:57 < gribble> https://github.com/bitcoin/bitcoin/issues/16443 | refactor: have CCoins* data managed under CChainState by jamesob · Pull Request #16443 · bitcoin/bitcoin · GitHub 12:57 -!- trillhc [~trillhc@c-71-232-65-53.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 12:57 < wumpus> jamesob: sure 12:57 < jamesob> thanks wumpus 12:58 -!- trillhc [~trillhc@c-71-232-65-53.hsd1.ma.comcast.net] has quit [Client Quit] 12:58 < wumpus> HUH did anyone know you can add notes to the project pages? 12:59 < wumpus> this could be useful to add some information, like who proposed a blocker 12:59 < wumpus> (if it's not the author) 12:59 < jamesob> ah that's kind of cool - are the notes themselves separate from the PRs? 13:00 -!- rapidphase [~trillhc@c-71-232-65-53.hsd1.ma.comcast.net] has quit [Client Quit] 13:00 < wumpus> yes they're simply cards like the PRs and issues but aren't actually PRs and issues 13:01 < MarcoFalke> I forgot to raise the topic, but what happened to 0.18.1? can we ship tomorrow? 13:01 < wumpus> so can be used as sub-headers and such 13:02 < aj> oh, if you put the issue number in a note it includes the issue summary info too 13:02 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:02 < wumpus> MarcoFalke: the signatures are uploaded now, I'll upload the binaries shortly 13:03 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 13:03 < aj> ... if you have exactly one issue number, anyway 13:05 -!- rex4539 [~rex4539@2a02:587:3514:c700:10b1:b496:63a9:5684] has quit [Quit: rex4539] 13:06 -!- hanhua [68840050@104.132.0.80] has quit [Remote host closed the connection] 13:07 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:10 -!- owowo [~ovovo@185.183.104.83] has joined #bitcoin-core-dev 13:10 -!- owowo [~ovovo@185.183.104.83] has quit [Changing host] 13:10 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:10 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 13:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 13:56 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:00 -!- mcorpgc [~mcorpgc@178.162.204.238] has quit [] 14:03 -!- popey1 [~popey@141.98.101.133] has joined #bitcoin-core-dev 14:05 -!- lnostdal [~lnostdal@cm-84.208.101.63.getinternet.no] has joined #bitcoin-core-dev 14:06 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 245 seconds] 14:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:15 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 14:24 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 14:34 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds] 14:35 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:49 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 14:49 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 14:51 -!- jpe [~jpe@185.216.35.254] has quit [Ping timeout: 268 seconds] 14:55 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 14:59 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:03 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:17 -!- berndj [~berndj@azna.co.za] has quit [Quit: ZNC - http://znc.in] 15:18 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev 15:18 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 15:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 15:33 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 15:34 -!- jarthur [~jarthur@207.114.244.5] has quit [Read error: Connection reset by peer] 15:34 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 15:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 15:52 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:53 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 15:58 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Quit: ercwl] 16:00 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 16:03 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 244 seconds] 16:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 16:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:09 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds] 16:15 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:16 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev 16:16 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host] 16:16 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 16:20 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Quit: ercwl] 16:20 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 16:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 16:31 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Quit: ercwl] 16:34 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 16:34 -!- ThomasLuong [~ThomasLuo@209.63.53.36] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:37 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #16572: Fix Char as Bool in Wallet (master...fix-wallet-charbool) https://github.com/bitcoin/bitcoin/pull/16572 16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 17:00 -!- popey1 [~popey@141.98.101.133] has quit [] 17:00 -!- pinheadmz [~matthewzi@209.209.238.169] has joined #bitcoin-core-dev 17:04 -!- wright [~wright@185.59.221.95] has joined #bitcoin-core-dev 17:14 -!- lightlike [~lightlike@2001:16b8:5747:db00:e40e:2f22:9fe7:c9c5] has quit [Quit: Leaving] 17:31 -!- pinheadmz_ [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:32 -!- pinheadmz [~matthewzi@209.209.238.169] has quit [Read error: Connection reset by peer] 17:32 -!- pinheadmz_ is now known as pinheadmz 17:43 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Quit: ercwl] 17:44 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 17:47 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:51 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 17:57 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Quit: ercwl] 18:00 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 18:00 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 18:02 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 18:05 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Ping timeout: 268 seconds] 18:21 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 18:26 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Ping timeout: 272 seconds] 19:06 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-xylbruckdqjsoaki] has quit [Quit: Connection closed for inactivity] 19:16 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:17 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 19:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 19:24 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 19:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 19:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:58 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 20:00 -!- wright [~wright@185.59.221.95] has quit [] 20:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:04 -!- serAphim [~serAphim@141.98.102.243] has joined #bitcoin-core-dev 20:04 -!- serAphim is now known as Guest59591 20:18 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ijsgycygcvfvtbdh] has joined #bitcoin-core-dev 20:20 -!- xzytrewq [~quassel@199.58.187.147] has quit [Ping timeout: 245 seconds] 20:25 -!- xzytrewq [~quassel@199.58.187.147] has joined #bitcoin-core-dev 20:31 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:33 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 20:36 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:48 -!- baldur [~baldur@pool-108-29-146-178.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 21:01 -!- baldur [~baldur@pool-108-29-146-178.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 21:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 21:41 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5] 21:55 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 248 seconds] 21:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 22:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:15 < bitcoin-git> [bitcoin] fanquake opened pull request #16573: build: disable building libsecp256k1 benchmarks (master...disable-secp256k1-benchmarks) https://github.com/bitcoin/bitcoin/pull/16573 22:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:27 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has joined #bitcoin-core-dev 22:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds] 22:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 22:33 -!- lalitmee [~lalitmee@49.204.86.234] has joined #bitcoin-core-dev 22:39 -!- StopAndDecrypt_ [~StopAndDe@107.181.189.42] has joined #bitcoin-core-dev 22:39 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 245 seconds] 22:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 22:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 22:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 22:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 22:58 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ijsgycygcvfvtbdh] has quit [Quit: Connection closed for inactivity] 23:00 -!- Guest59591 [~serAphim@141.98.102.243] has quit [] 23:04 -!- fredy1 [~fredy@192.145.126.244] has joined #bitcoin-core-dev 23:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 23:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 258 seconds] 23:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:34 -!- Krellan [~Krellan@2601:640:4100:ac00:f48b:59c9:3a4d:445c] has quit [Remote host closed the connection] 23:35 -!- Krellan [~Krellan@2601:640:4100:ac00:bcf1:d1c0:e737:4194] has joined #bitcoin-core-dev 23:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 23:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:50 -!- lnostdal [~lnostdal@cm-84.208.101.63.getinternet.no] has quit [Remote host closed the connection] 23:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:51 -!- jpe [~jpe@185.216.35.254] has joined #bitcoin-core-dev 23:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:53 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Ping timeout: 260 seconds] 23:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] --- Log closed Fri Aug 09 00:00:35 2019