--- Log opened Fri Aug 09 00:00:35 2019 00:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:17 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:24 -!- lalitmee [~lalitmee@49.204.86.234] has quit [Ping timeout: 245 seconds] 00:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:26 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev 00:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:35 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 00:35 -!- jpe [~jpe@185.216.35.254] has quit [Ping timeout: 268 seconds] 00:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:44 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:23 -!- jb551 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 01:26 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds] 01:28 -!- lalitmee [~lalitmee@106.51.71.179] has joined #bitcoin-core-dev 01:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:36 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 01:36 -!- jl2012 [sid133844@gateway/web/irccloud.com/x-uqtmhlsozrjrnlmh] has left #bitcoin-core-dev [] 01:37 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 02:00 -!- fredy1 [~fredy@192.145.126.244] has quit [] 02:00 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:00 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 02:01 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 244 seconds] 02:04 -!- amcrae [~amcrae@192.145.126.244] has joined #bitcoin-core-dev 02:04 -!- amcrae is now known as Guest53083 02:16 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:19 -!- Victor_sueca is now known as Victorsueca 02:20 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 02:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 02:26 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 03:18 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev 03:22 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving] 03:23 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 03:24 -!- davereik1 [~dave@gateway/tor-sasl/davereikher] has joined #bitcoin-core-dev 03:26 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has quit [Ping timeout: 260 seconds] 03:30 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 03:32 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Client Quit] 03:38 -!- phwalkr [~phwalkr@2001:1284:f019:d699:9d55:6a5d:526b:b59d] has joined #bitcoin-core-dev 03:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:49 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 03:55 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 04:00 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode] 04:01 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev 04:04 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit] 04:06 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev 04:10 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit] 04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:23 < bitcoin-git> [bitcoin] laanwj opened pull request #16574: doc: Add historical release notes for 0.18.1 (master...2019_08_relnot_0_18_1) https://github.com/bitcoin/bitcoin/pull/16574 04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:00 -!- Guest53083 [~amcrae@192.145.126.244] has quit [] 05:03 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 05:03 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 05:06 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev 05:11 < jonasschnelli> Is there a clever way to access private members from a boost unit test? 05:14 -!- Khaytsus1 [~Khaytsus@178.162.204.238] has joined #bitcoin-core-dev 05:16 < jonasschnelli> nm, ... going to try a friendly test struct 05:22 < emilengler> You could use a dirty pointer trick 05:23 < jonasschnelli> Yes. Or that. 05:25 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 05:31 -!- lalitmee [~lalitmee@106.51.71.179] has quit [Quit: Leaving] 05:34 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 05:38 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Quit: ercwl] 05:53 -!- Aaronvan_ is now known as AaronvanW 05:53 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 05:55 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 244 seconds] 06:03 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 06:08 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 06:10 -!- bixus [53d1e211@h83-209-226-17.cust.a3fiber.se] has joined #bitcoin-core-dev 06:12 -!- bixus [53d1e211@h83-209-226-17.cust.a3fiber.se] has quit [Remote host closed the connection] 06:17 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:19 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5fdda68c6d2...32776276ef07 06:19 < bitcoin-git> bitcoin/master 61c5c64 Wladimir J. van der Laan: doc: Add historical release notes for 0.18.1 06:19 < bitcoin-git> bitcoin/master 3277627 fanquake: Merge #16574: doc: Add historical release notes for 0.18.1 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:20 < bitcoin-git> [bitcoin] fanquake merged pull request #16574: doc: Add historical release notes for 0.18.1 (master...2019_08_relnot_0_18_1) https://github.com/bitcoin/bitcoin/pull/16574 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:23 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-wgneqaurzjhyksyt] has joined #bitcoin-core-dev 06:35 -!- dgfhdfg [~hgfdfgh@188.120.116.13] has joined #bitcoin-core-dev 06:38 -!- lightlike [~lightlike@2001:16b8:57f9:bb00:25b7:42e0:7eec:7d42] has joined #bitcoin-core-dev 06:43 -!- davterra [~none@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Quit: Leaving] 06:46 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/32776276ef07...9ab9d6356938 06:49 < bitcoin-git> bitcoin/master b7b9f6e Antoine Riard: Remove p2pEnabled from Chain interface 06:49 < bitcoin-git> bitcoin/master 9ab9d63 MarcoFalke: Merge #16503: Remove p2pEnabled from Chain interface 06:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16503: Remove p2pEnabled from Chain interface (master...2019-07-remove-p2p-chain) https://github.com/bitcoin/bitcoin/pull/16503 06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:55 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Quit: ercwl] 06:55 -!- lalitmee [~lalitmee@36.255.86.118] has joined #bitcoin-core-dev 06:58 -!- davereik1 [~dave@gateway/tor-sasl/davereikher] has quit [Remote host closed the connection] 06:59 -!- davereik1 [~dave@gateway/tor-sasl/davereikher] has joined #bitcoin-core-dev 07:03 -!- xzytrewq [~quassel@199.58.187.147] has quit [Ping timeout: 272 seconds] 07:20 -!- TheHoliestRoger is now known as [monk] 07:23 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Textual IRC Client: www.textualapp.com] 07:36 < BlueMatt> hm, looks like the only dnsseeds resolvable over v6 are mine, jonasschnelli's and emzy's :( 07:36 < emzy> :( 07:37 < BlueMatt> sipa petertodd, cdecker, luke-jr and provoostenator need to fix their shitz 07:37 < jonasschnelli> glad I can claim I did my homework... :) 07:37 < BlueMatt> heh, indeed 07:38 < emzy> ipv4 is only legacy. v6 is the Internet :) 07:40 < provoostenator> TIL mine crawls IPv6 diligently, but can't reached that way :-) 07:40 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev 07:41 -!- dgfhdfg [~hgfdfgh@188.120.116.13] has quit [Read error: Connection reset by peer] 07:41 -!- ptiyoyip [~hgfdfgh@188.120.116.13] has joined #bitcoin-core-dev 07:44 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 07:45 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode] 07:47 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 07:47 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev 07:49 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:54 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode] 08:00 -!- Khaytsus1 [~Khaytsus@178.162.204.238] has quit [] 08:00 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 08:02 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 08:03 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:06 -!- jb551 is now known as jb55 08:09 -!- [monk] is now known as [THR] 08:09 -!- [THR] is now known as [TheHoliestRoger 08:09 -!- [TheHoliestRoger is now known as [Holiest] 08:10 -!- [Holiest] is now known as [poopster] 08:10 < BlueMatt> right :) and there are seriously quite a few v6-only isps in the world these days 08:10 -!- [poopster] is now known as TheHoliestRoger 08:11 -!- lalitmee [~lalitmee@36.255.86.118] has quit [Remote host closed the connection] 08:20 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 08:34 -!- clintbellanger [~clintbell@195.206.169.238] has joined #bitcoin-core-dev 08:35 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:38 < provoostenator> Working on a solution, but the rabbit hole goes deep... 08:41 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds] 08:42 -!- hardforkthis [~hardforkt@li120-195.members.linode.com] has quit [Quit: Ping timeout (120 seconds)] 08:43 -!- hardforkthis [~hardforkt@li120-195.members.linode.com] has joined #bitcoin-core-dev 08:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:48 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:51 -!- jarthur [~jarthur@207.114.244.5] has quit [Client Quit] 08:51 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:00 < sipa> BlueMatt: $ dig -t AAAA seed.bitcoin.sipa.be 09:00 < sipa> works 09:01 < BlueMatt> sipa: the sipa.be ns servers dont have v6 entries 09:02 < BlueMatt> ie the ulyssis.org ones 09:02 < BlueMatt> you want dig -6 +trace seed.bitcoin.sipa.be aaaa 09:02 < sipa> ah 09:02 < sipa> yup 09:02 -!- mdunnio_ [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:16 -!- ptiyoyip [~hgfdfgh@188.120.116.13] has quit [Read error: Connection reset by peer] 09:31 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 09:32 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 09:32 -!- kljasdfvv [~flack@p200300D46F0E7800A58A705A909F52DC.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:33 -!- mdunnio_ [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:36 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 09:45 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has joined #bitcoin-core-dev 09:45 -!- tuirektiujm[m] [tuirektiuj@gateway/shell/matrix.org/x-jgyktqshlcdivytv] has quit [Read error: Connection reset by peer] 09:45 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-cejsvubipywrcjjh] has quit [Read error: Connection reset by peer] 09:45 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-yyjpchmhfkhrasda] has quit [Write error: Connection reset by peer] 09:45 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-twpmeliaoxaxpmac] has quit [Write error: Connection reset by peer] 09:45 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has left #bitcoin-core-dev [] 09:45 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-ghvctomeqayjvadz] has quit [Write error: Connection reset by peer] 09:52 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-slwmpefgcbqzumnj] has joined #bitcoin-core-dev 09:54 < achow101> provoostenator: After actually attempting to make all of the commits in #16341 compile with the whole move instead of copy thing, I don't think it will make it any easier to review, actually probably harder. IMO Having to introduce temporary functions and changes everywhere only to remove them a few commits later makes it way harder to review as some commits basically have no effect on the final product 09:54 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub 09:56 < achow101> I ended up having to introduce several temp functions to expose some internals of LegacyScriptPubKeyMan which resulted in a bunch of changes to CWallet that were basically then removed in the subsequent commit. Having to keep track of all of these temp things and then removing them and restoring the correct behavior is far more work than it's worth IMO 09:56 < achow101> so I'm not going to continue doing that 09:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:59 -!- tuirektiujm[m] [tuirektiuj@gateway/shell/matrix.org/x-obkrvczhqyivlqei] has joined #bitcoin-core-dev 09:59 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-mfrdxfuxneumcbzs] has joined #bitcoin-core-dev 09:59 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-rbdzkjppwtuhzsis] has joined #bitcoin-core-dev 09:59 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-sjptxyhvjczcwhrd] has joined #bitcoin-core-dev 10:00 < provoostenator> That sounds painful indeed 10:00 < provoostenator> Can you push a temp branch somewhere though? 10:00 < provoostenator> Either way, it was worth watching the stream the Wednesday just to see you try :-) 10:01 < gleb> Public bitcoin nodes use about 1200 ASNs. 20 of those ASNs represent 50% of the nodes, and just 3 ASNs represent 25%. This means that suggested ASN-based bucketing bias would make more (potentially, mission-critical) connections to those tiny unpopular ASNs than it is today. Is this well-understood? Is this the effect we want? I'm not sure. 10:03 < provoostenator> BlueMatt: the good news is, this works now: dig -6 -t AAAA seed.bitcoin.sprovoost.nl 10:03 < provoostenator> The bad news is that I probably messed up the DNS for my entire domain in the process, so will clean that up now :-( 10:03 < gleb> The benefit from ASN bucketing is clear from the standpoint of a single node, but for the network overall I dunno. Should we additionally enforce everybody connecting to a random node from top-3 ASNs? 10:05 < sipa> gleb: i'm not sure, but maybe it helps to look at it from the other direction: it's expected that a huge number of nodes right now are on large providers (AWS, large VPS providers, ...); biasing by ASN would significantly reduce the number of connections to those in favor of others, but I think that's desirable 10:06 < sipa> having 100s of nodes on AWS doesn't actually add much partition resistance from the perspective of someone connecting to it 10:09 < BlueMatt> gleb: indeed, what sipa said...last I looked the vast majority of nodes were on a few providers - aws, digitalocean, hertzner and such 10:09 < achow101> provoostenator: https://github.com/achow101/bitcoin/tree/wallet-boxes-2 it's currently broken as I didn't actually finish it 10:09 < BlueMatt> connecting only to those is, thus, likely not an uncommon case 10:09 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:09 < BlueMatt> and is clearly useless 10:10 < sipa> an orthogonal idea may be to have 1 or 2 additional connections within your local network/ASN 10:10 < BlueMatt> I dont know how much "few nodes on an asn" correlates with "small isp in the middle of nowhere which doesn't want to serve a lot of traffic", it probably correlates a bit but I'd presume it correlates more with "residential isp with few hosted nodes" 10:10 < BlueMatt> right, likely want that, too 10:10 < BlueMatt> maybe a third and fourth blocks-only connection or so to local asn 10:11 < gleb> Now it's very possible to connect to only those, which is obviously bad. I'm just saying that ASN bucketing might result in connecting to ONLY pocket vulnerable ISPs 10:12 < gleb> So if the cost of partition is bribing, I think having 7 pocket ISPs + AWS is in this case better than 8 pocket ISPs :) 10:12 < sipa> what is a pocket ISP? 10:12 < gleb> something unpopular and easy to influence 10:13 < gleb> I might be missing the threat model here 10:13 < sipa> actually, the rule "at most one outgoing connection per ASN" isn't quite the same as "connections are uniformly sampled over all ASNs"; larger networks are still more likely to reason connections - just not more than one per outgoing peer 10:14 < sipa> s/reason/receive/ no idea how i made that typo 10:14 * sipa drinks coffee 10:15 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 272 seconds] 10:15 < gleb> Well, that's partially what i'm asking about. I thought the current idea is uniformly random sample over all ASNs, and I questioned this idea. 10:15 < sipa> no, clearly an ASN with no known peers won't get any connections :) 10:16 < sipa> the outgoing connection logic just randomly picks a known peer (with some biases already, like favoring port 8333), and then there is a rejection sampling which throws away results within a "group" we already have an outgoing connection to 10:16 < gleb> I just thought of it this way: take all ASNs you know peers from, sample 8 unique ones, connect to peers from those 8 10:16 < gleb> But I guess we will sample peers first, which would result in connecting to AWS at least once anyways. 10:17 < sipa> right 10:17 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:18 < gleb> Okay, I'll see if there's a good place in the code or PR I can document this observation, because for me it took a while to understand it. 10:18 < sipa> the suggestion is to change the definition of groups to be ASNs 10:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 10:23 < sipa> gleb: https://github.com/bitcoin/bitcoin/blob/v0.18.1/src/net.cpp#L1763L1808 10:23 < sipa> that's the outgoing connection peer selection logic 10:23 < sipa> it's fairly well documented 10:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 10:27 < gleb> I was more worried that if this code is changed we might end up with uniform distribution across all asns due to this new bucket logic 10:27 < gleb> "If changing bucketing code again, don't shoot in your leg" 10:27 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:28 < sipa> if we feel the bias towards small asns is too strong as a result of this, the policy could also be permitting two connections to large asns 10:28 < sipa> or to treat large asns as multiple groups 10:29 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 10:32 < gleb> Now that you mitigated my misunderstanding I think it's fine since we'll very likely to have one connection to large asns and I don't see a huge benefit in having 2 instead of 1 10:34 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 10:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:56 < provoostenator> sipa petertodd, cdecker, luke-jr: to make my seed visible to IPv6-only nodes, I had to do two things: 10:57 < provoostenator> 1. add an AAAA record from seed.bitcoin.sprovoost.nl. to the IPv6 address of the seed 10:58 < provoostenator> 2. make sure all DNS providers starting from my domain registrar can actually handle IPv6 (I had to move stuff for that reason) 10:58 -!- TheHoliestRoger is now known as Testicycle 10:58 -!- LarryRuane [62f5cc94@c-98-245-204-148.hsd1.co.comcast.net] has joined #bitcoin-core-dev 10:59 < provoostenator> "dig -6 -t AAAA +trace seed.bitcoin.sprovoost.nl" can be helpful seeing where the buck stops, ht BlueMatt 10:59 < provoostenator> Where -6 forces going over IPv6 11:00 -!- clintbellanger [~clintbell@195.206.169.238] has quit [] 11:01 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:02 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:04 -!- jackalope [~jackalope@184.75.223.219] has joined #bitcoin-core-dev 11:11 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 11:11 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 11:11 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 11:18 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 11:20 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection] 11:22 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 11:23 -!- reallll is now known as belcher 11:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:26 -!- Testicycle is now known as TheHoliestRoger 11:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 11:27 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 245 seconds] 11:44 -!- davterra [~none@209.58.185.33] has joined #bitcoin-core-dev 11:51 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:52 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 248 seconds] 11:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:58 < bitcoin-git> [bitcoin] LarryRuane opened pull request #16577: util: CBufferedFile fixes and unit test (master...CBufferedFile-fixes) https://github.com/bitcoin/bitcoin/pull/16577 11:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:58 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:59 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9ab9d6356938...e47e36cb4975 11:59 < bitcoin-git> bitcoin/master bf72b8a fanquake: build: disable libsecp256k1 benchmarks 11:59 < bitcoin-git> bitcoin/master e47e36c Wladimir J. van der Laan: Merge #16573: build: disable building libsecp256k1 benchmarks 11:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:59 < bitcoin-git> [bitcoin] laanwj merged pull request #16573: build: disable building libsecp256k1 benchmarks (master...disable-secp256k1-benchmarks) https://github.com/bitcoin/bitcoin/pull/16573 12:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:02 -!- Kitsch [6d948bd9@host109-148-139-217.range109-148.btcentralplus.com] has joined #bitcoin-core-dev 12:02 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 12:17 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 12:18 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 12:25 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 12:27 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:27 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 12:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 12:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 12:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 12:46 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 12:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:52 < bitcoin-git> [bitcoin] achow101 opened pull request #16578: Do not pass in command line arguments to QApplication (master...no-qapp-args) https://github.com/bitcoin/bitcoin/pull/16578 12:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:12 < roasbeef> does everyone use the same software to operate their DNS seed? do they need to be manually updated to respond to queries for "new" service bits? for example, of the seeds i'm aware of, only seed.bitnodes.io responds to queries for teh x49 subdomain (full node, segwit, bip 158) 13:14 < emzy> I think most using sipas dnsseed software, ecexpt one. 13:17 < sipa> my seeder can be configured to support any subset of service bit combinations 13:19 < emzy> I run the default. 13:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:35 -!- nos [~nos@c-24-19-133-234.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:36 -!- Kitsch [6d948bd9@host109-148-139-217.range109-148.btcentralplus.com] has left #bitcoin-core-dev [] 13:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 13:37 -!- nos [~nos@c-24-19-133-234.hsd1.wa.comcast.net] has quit [Client Quit] 13:38 -!- nos2 [~nos2@c-24-19-133-234.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:40 -!- nos2 [~nos2@c-24-19-133-234.hsd1.wa.comcast.net] has quit [Client Quit] 13:40 -!- linkd [~linkd@c-24-19-133-234.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:41 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:42 -!- linkd [~linkd@c-24-19-133-234.hsd1.wa.comcast.net] has quit [Client Quit] 13:42 -!- nos2 [~nos2@c-24-19-133-234.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:44 -!- nos2 [~nos2@c-24-19-133-234.hsd1.wa.comcast.net] has quit [Client Quit] 13:45 < emzy> any recomendation which service bit combinations to enable on the dnsseed? 13:45 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:47 -!- nos [~nos@c-24-19-133-234.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:51 -!- nos [~nos@c-24-19-133-234.hsd1.wa.comcast.net] has quit [Client Quit] 13:52 -!- nos [~nos@c-24-19-133-234.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:52 -!- nos [~nos@c-24-19-133-234.hsd1.wa.comcast.net] has quit [Client Quit] 13:53 -!- nosss2 [~nosss2@c-24-19-133-234.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:54 -!- nosss2 [~nosss2@c-24-19-133-234.hsd1.wa.comcast.net] has quit [Client Quit] 13:56 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 13:58 -!- tuirektiujm[m] [tuirektiuj@gateway/shell/matrix.org/x-obkrvczhqyivlqei] has quit [Quit: Idle kick: User has been idle for 30+ days.] 13:59 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Client Quit] 14:00 -!- jackalope [~jackalope@184.75.223.219] has quit [] 14:00 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 14:00 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 14:01 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 268 seconds] 14:01 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer] 14:01 -!- pinheadmz_ [~matthewzi@209.209.238.167] has joined #bitcoin-core-dev 14:04 -!- KuluBot [~KuluBot@184.75.223.219] has joined #bitcoin-core-dev 14:05 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [] 14:06 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 14:06 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:10 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Client Quit] 14:10 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 14:11 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 14:14 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 14:15 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 272 seconds] 14:15 -!- nosss2_ is now known as nosss2 14:29 -!- Phil48 [6bf2750d@107.242.117.13] has joined #bitcoin-core-dev 14:32 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 14:33 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:38 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 272 seconds] 14:44 -!- Phil48 [6bf2750d@107.242.117.13] has quit [Remote host closed the connection] 14:45 -!- Phil14 [6bf2750d@107.242.117.13] has joined #bitcoin-core-dev 14:46 -!- Phil14 [6bf2750d@107.242.117.13] has quit [Remote host closed the connection] 14:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:05 -!- xzytrewq [~quassel@184.170.247.164] has joined #bitcoin-core-dev 15:07 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 15:16 -!- xzytrewq [~quassel@184.170.247.164] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 15:16 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 272 seconds] 15:17 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 15:18 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 15:19 < roasbeef> emzy: x49? ;) that's bits 1, 3, and 6 15:25 -!- LarryRuane [62f5cc94@c-98-245-204-148.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds] 16:08 -!- davterra [~none@209.58.185.33] has quit [Quit: Leaving] 16:22 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has quit [Remote host closed the connection] 16:23 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev 16:24 -!- MasterdonX [~masterdon@5.226.137.122] has quit [Ping timeout: 245 seconds] 16:31 -!- MasterdonX [~masterdon@titan.zm.is] has joined #bitcoin-core-dev 16:31 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-wgneqaurzjhyksyt] has quit [Quit: Connection closed for inactivity] 16:32 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 17:00 -!- KuluBot [~KuluBot@184.75.223.219] has quit [] 17:04 -!- gchaix [~gchaix@185.204.1.185] has joined #bitcoin-core-dev 17:05 < sipa> roasbeef, emzy: i've updated my seeder code to by default support masks 0x1,0x5,0x9,0xd,0x49,0x400,0x404,0x408,0x40c,0x448 17:05 < sipa> jonasschnelli: ^ also included NODE_NETWORK_LIMITED combinations 17:06 < sipa> provoostenator, jonasschnelli, luke-jr: you may want to update 17:07 -!- lightlike [~lightlike@2001:16b8:57f9:bb00:25b7:42e0:7eec:7d42] has quit [Quit: Leaving] 17:07 < sipa> also another change is that it now sets fRelay=false, as it doesn't care about receiving tx invs 17:08 < sipa> i've only added NODE_COMPACT_FILTER in combination with NODE_WITNESS, and not combined with NODE_BLOOM (no software using BIP157 is non-segwit, or needs BIP37 filters, i think) 17:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:26 < roasbeef> sipa: nice! correct that afaik bip157 and segwit are more or less a pair 17:45 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 17:48 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 245 seconds] 17:50 < luke-jr> sipa: what reason is there to update? 17:51 < luke-jr> I like to keep mine lagged when possible 17:54 < sipa> luke-jr: no strong reason 17:57 < sipa> just support for NODE_NETWORK_LIMITED and NODE_COMPACT_FILTER by default 17:58 < luke-jr> k 17:59 < sipa> (you can also configure those explicitly without code changes) 17:59 < luke-jr> right 18:00 < luke-jr> I should probably PR some fixes I did too 18:00 < luke-jr> the p2p version number it's using is old enough that some other node software rejects it 18:01 < luke-jr> http://luke.dashjr.org/programs/bitcoin/files/charts/services.html 18:01 < luke-jr> hmm, there's only 142 block-filters nodes 18:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 18:14 < roasbeef> it's a start ;) 18:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 245 seconds] 18:54 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Remote host closed the connection] 18:55 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev 19:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:09 -!- philip [~philip@pool-72-77-38-252.pitbpa.fios.verizon.net] has joined #bitcoin-core-dev 19:18 -!- Prophyt [ac625de6@172.98.93.230] has joined #bitcoin-core-dev 19:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 20:00 -!- gchaix [~gchaix@185.204.1.185] has quit [] 20:04 -!- chaosagent [~chaosagen@185.5.172.148] has joined #bitcoin-core-dev 20:08 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 20:09 -!- philip [~philip@pool-72-77-38-252.pitbpa.fios.verizon.net] has quit [Quit: Leaving] 20:15 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 20:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds] 20:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:24 -!- Prophyt [ac625de6@172.98.93.230] has quit [Ping timeout: 260 seconds] 20:30 -!- bitbee [~bitbee@unaffiliated/cryptocat] has quit [Quit: Leaving.] 20:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:44 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:57 -!- mandrew [3244c288@S010600fc8dc59e43.vn.shawcable.net] has joined #bitcoin-core-dev 21:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:15 -!- bitbee [~bitbee@unaffiliated/cryptocat] has joined #bitcoin-core-dev 21:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:34 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 246 seconds] 21:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 248 seconds] 21:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 21:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 21:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 21:54 -!- bitbee [~bitbee@unaffiliated/cryptocat] has quit [Quit: Leaving.] 21:57 -!- jdm [~jdm@unaffiliated/user1138] has joined #bitcoin-core-dev 22:07 -!- davex_ [~user@45.74.60.148] has joined #bitcoin-core-dev 22:07 -!- davex__ [~user@45.74.60.148] has quit [Read error: Connection reset by peer] 22:23 -!- mandrew [3244c288@S010600fc8dc59e43.vn.shawcable.net] has quit [Remote host closed the connection] 22:43 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 22:43 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 23:00 -!- chaosagent [~chaosagen@185.5.172.148] has quit [] 23:04 -!- frankie1 [~frankie@185.204.1.185] has joined #bitcoin-core-dev 23:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:35 < bitcoin-git> [bitcoin] practicalswift closed pull request #16320: ci: Add Travis check to make sure unit test coverage reports stay deterministic (master...test-deterministic-coverage-in-travis) https://github.com/bitcoin/bitcoin/pull/16320 23:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:36 < bitcoin-git> [bitcoin] practicalswift closed pull request #15191: validation: Add missing cs_{LastBlockFile,nBlockSequenceId} locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations. (master...cs_LastBlockFile) https://github.com/bitcoin/bitcoin/pull/15191 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:36 < bitcoin-git> [bitcoin] practicalswift closed pull request #15192: Add missing cs_main locks in ThreadImport(...)/Shutdown(...)/gettxoutsetinfo(...)/InitScriptExecutionCache(). Add missing locking annotations. (master...validation-cs_main) https://github.com/bitcoin/bitcoin/pull/15192 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:40 -!- rex4539 [~rex4539@2a02:587:3514:c700:2177:52b1:3ee4:5619] has joined #bitcoin-core-dev --- Log closed Sat Aug 10 00:00:35 2019