--- Log opened Wed Aug 14 00:00:40 2019
00:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds]
00:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
00:13 -!- lalitmee [~lalitmee@49.204.86.234] has quit [Ping timeout: 268 seconds]
00:19 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
00:34 -!- xzytrewq [~quassel@64.44.80.252] has quit [Ping timeout: 245 seconds]
00:50 -!- kljasdfvv [~flack@p200300D46F0E78000D7DF5E1A3559ACE.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
00:52 -!- kljasdfvv [~flack@p200300D46F0E7800896ABEB827C59029.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:03 -!- lalitmee [~lalitmee@106.51.71.179] has joined #bitcoin-core-dev
01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:14 < bitcoin-git> [bitcoin] fanquake closed pull request #15032: Nit fixes for PR 14565 (master...201812_pr_14565_nits) https://github.com/bitcoin/bitcoin/pull/15032
01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:37 -!- jpe_ [~jpe@185.216.35.254] has joined #bitcoin-core-dev
01:39 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:41 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:42 -!- jpe_ [~jpe@185.216.35.254] has quit [Ping timeout: 245 seconds]
01:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit]
02:00 -!- jonhcw [~jonhcw@184.75.223.219] has quit []
02:01 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:01 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 272 seconds]
02:05 -!- [42]1 [~42]@185.103.96.147] has joined #bitcoin-core-dev
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:07 < bitcoin-git> [bitcoin] fanquake closed pull request #14079: Implement sighash cache in CHECKMULTISIG (master...cms_cache) https://github.com/bitcoin/bitcoin/pull/14079
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:22 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
02:28 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 252 seconds]
02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:37 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05ccbe9a2991...b120645e8cfc
02:37 < bitcoin-git> bitcoin/master fa1e9c6 MarcoFalke: travis: Bump timeout from 50 minutes to 90
02:37 < bitcoin-git> bitcoin/master b120645 Wladimir J. van der Laan: Merge #16595: travis: use extended 90 minute timeout when available
02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:38 < bitcoin-git> [bitcoin] laanwj merged pull request #16595: travis: use extended 90 minute timeout when available (master...1908-travisNoTimeout) https://github.com/bitcoin/bitcoin/pull/16595
02:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:39 < fanquake> I've just closed the 0.18.1 milestone. https://github.com/bitcoin/bitcoin/milestones/41
02:45 < meshcollider> is it too late to add a missing contributor to the 0.18.1 release notes?
02:46 < meshcollider> fanquake: advice? ^
02:47 < fanquake> meshcollider: You could add them to the release notes on GH I guess? Obviously too late for the mailing lists etc
02:47 < meshcollider> ok just wanted to check there wasn't a policy against amending release notes in branches
02:48 < meshcollider> specifically it is the reporter of this issue #16011 who followed up with PR #16012 and helped with 16022 among others
02:48 < gribble> https://github.com/bitcoin/bitcoin/issues/16011 | addmultisigaddress does not fallback to legacy when there are uncompressed public keys in the parameters · Issue #16011 · bitcoin/bitcoin · GitHub
02:48 < gribble> https://github.com/bitcoin/bitcoin/issues/16012 | rpc: addmultisigaddress should fallback to OutputType::LEGACY when uncompressed public keys are provided by ps1dr3x · Pull Request #16012 · bitcoin/bitcoin · GitHub
02:48 < meshcollider> I think he should definitely be acknowledged
02:50 < fanquake> meshcollider fair enough. I don't have a problem with it, and it's right after release. What we don't like it someone turning up and "fixing" typos in the 0.5.x release notes etc
02:50 < meshcollider> fanquake: yeah, makes sense :)
02:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:58 < bitcoin-git> [bitcoin] meshcollider opened pull request #16604: [0.18] Add missing contributor to 0.18.1 release notes (0.18...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16604
02:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:20 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b120645e8cfc...b49e7796c298
03:20 < bitcoin-git> bitcoin/master 3303124 fanquake: build: disable libxcb extensions
03:20 < bitcoin-git> bitcoin/master b49e779 Wladimir J. van der Laan: Merge #16533: build: disable libxcb extensions
03:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:21 < bitcoin-git> [bitcoin] laanwj merged pull request #16533: build: disable libxcb extensions (master...disable_xcb_extensions) https://github.com/bitcoin/bitcoin/pull/16533
03:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:31 -!- jonatack [~jon@82.102.27.195] has joined #bitcoin-core-dev
03:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:41 < bitcoin-git> [bitcoin] meshcollider closed pull request #16604: [0.18] Add missing contributor to 0.18.1 release notes (0.18...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16604
03:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:50 -!- jonatack [~jon@82.102.27.195] has quit [Ping timeout: 245 seconds]
03:52 -!- jonatack [~jon@213.152.162.104] has joined #bitcoin-core-dev
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:03 < bitcoin-git> [bitcoin] meshcollider opened pull request #16605: Add missing contributor to 0.18.1 release notes  (master...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16605
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:04 -!- lnostdal [~lnostdal@62.90-149-73.nextgentel.com] has joined #bitcoin-core-dev
04:08 -!- jonatack [~jon@213.152.162.104] has quit [Quit: WeeChat 2.3]
04:08 -!- jonatack [~jon@213.152.162.104] has joined #bitcoin-core-dev
04:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:08 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/fa27a0760792...bbc2970082a2
04:08 < bitcoin-git> bitcoin/0.18 bbc2970 Wladimir J. van der Laan: doc: Clean out release notes post-0.18.1
04:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:16 < bitcoin-git> [bitcoin] jesuscristincarbajal opened pull request #16606: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16606
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:17 < bitcoin-git> [bitcoin] fanquake closed pull request #16606: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16606
04:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:18 < bitcoin-git> [bitcoin] jesuscristincarbajal opened pull request #16607: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16607
04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:19 < bitcoin-git> [bitcoin] fanquake closed pull request #16607: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16607
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:19 < wumpus> ugh PR spam
04:19 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
04:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
04:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:21 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b49e7796c298...286332495d43
04:21 < bitcoin-git> bitcoin/master 862cbf3 MeshCollider: Add missing contributor to release notes
04:21 < bitcoin-git> bitcoin/master 2863324 Wladimir J. van der Laan: Merge #16605: Add missing contributor to 0.18.1 release notes
04:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:22 < bitcoin-git> [bitcoin] laanwj merged pull request #16605: Add missing contributor to 0.18.1 release notes  (master...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16605
04:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:31 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/286332495d43...e7df1ecd1758
04:31 < bitcoin-git> bitcoin/master 2290269 Sjors Provoost: scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg
04:31 < bitcoin-git> bitcoin/master 2e68ffa Sjors Provoost: [doc] descriptor: explain GetPubKey() usage with cached public key
04:31 < bitcoin-git> bitcoin/master e7df1ec Wladimir J. van der Laan: Merge #14934: Descriptor expansion cache clarifications
04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:31 < bitcoin-git> [bitcoin] laanwj merged pull request #14934: Descriptor expansion cache clarifications (master...2018/12/rename_m_script_arg) https://github.com/bitcoin/bitcoin/pull/14934
04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:32 -!- queip [~queip@unaffiliated/rezurus] has quit [Quit: bye, freenode]
04:33 < fanquake> hopefully he's given up..
04:37 < fanquake> wumpus did that last pr break compiling on master ?
04:37 < fanquake> script/descriptor.cpp:495:13: error: use of undeclared identifier 'm_script_arg'
04:39 < wumpus> oh crap did it?
04:39 < wumpus> will try and revert if so
04:39 < fanquake> I think the fix may be trivial
04:39 < fanquake> just checking
04:40 < fanquake> wumpus: I can pr a fix now, if you'd rather not revert ?
04:42 < wumpus> if it's trivial, sure, if not, we might want to revert and go with this through review again
04:43 < fanquake> Should be a trivial 2-line change, just looks like a missed renaming.
04:43 < wumpus> must be code that was introduced since the PR
04:43 < wumpus> yes, it's pretty much  documentation PR, and a renamed field, you'd say what can go wrong with it, well apparantly something can
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:44 < bitcoin-git> [bitcoin] Sjors opened pull request #16608: [backport] Use wallet RBF default for walletcreatefundedpsbt (0.18...2018/08/backport-wallet-rbf-default) https://github.com/bitcoin/bitcoin/pull/16608
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:49 < provoostenator> wumpus fanquake: I'll take a look
04:49 < fanquake> provoostenator: I'm about to open a PR.
04:49 < wumpus> provoostenator: thanks!
04:49 < provoostenator> Could either revert and then I can rebase, or I make a PR now that fixes the new occurance.
04:50 < provoostenator> Fix appears trivial, just running tests locall now
04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:50 < bitcoin-git> [bitcoin] fanquake opened pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:51 < provoostenator> Oh I see fanquake beat me to it with the exact same change :-)
04:51 < wumpus> at least ACK it then
04:51 < provoostenator> About to
04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:51 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #16584: gui: New filesave icon, updated copyright (master...branch4) https://github.com/bitcoin/bitcoin/pull/16584
04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
04:55 < provoostenator> I would be cool if Drahtbot could detect a silent merge conflict like this one.
04:58 < wumpus> I think it sometimes does re-run travis on PRs that have been open a long time
04:58 < wumpus> that's the only way to 'detect' silent merge conflicts, re-running the build and test suite
04:59 < wumpus> I should have built locally before merging, but this one seemed trivial
05:00 -!- [42]1 [~42]@185.103.96.147] has quit []
05:01 < wumpus> didn't think anything could go wrong, but there you see…
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7df1ecd1758...034575e9c7a3
05:03 < bitcoin-git> bitcoin/master 3963856 fanquake: descriptor: fix missed m_script_arg arg renaming in #14934
05:03 < bitcoin-git> bitcoin/master 034575e MarcoFalke: Merge #16609: descriptor: fix missed m_script_arg arg renaming in #14934
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:03 < provoostenator> When running the functional test suite with --jobs=100 a bunch of tests break because of the 60 second node stop timeout.
05:03 < provoostenator> That should probably be configurable, because CPU and RAM usage weren't particularly bad.
05:03 < wumpus> To github.com:bitcoin/bitcoin
05:03 < wumpus>  ! [rejected]                                                                          master -> master (fetch first)
05:04 < wumpus> error: failed to push some refs to 'git@github.com:bitcoin/bitcoin'
05:04 < wumpus> h
05:04 < wumpus> lol MarcoFalke beat me to merging a millisecond or so
05:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
05:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:09 -!- lightlike [~lightlike@2001:16b8:576b:1f00:6c9c:4821:159a:c840] has joined #bitcoin-core-dev
05:10 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: harrigan]
05:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:13 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/034575e9c7a3...0753c7392796
05:13 < bitcoin-git> bitcoin/master 14f7eec Emil Engler: rpc: Fix getblocktemplate CLI example (#16594)
05:13 < bitcoin-git> bitcoin/master 0753c73 fanquake: Merge #16596: rpc: Fix getblocktemplate CLI example
05:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:14 < bitcoin-git> [bitcoin] fanquake merged pull request #16596: rpc: Fix getblocktemplate CLI example (master...2019-08-helpexamplecli-fix) https://github.com/bitcoin/bitcoin/pull/16596
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:19 -!- omega8cc [~omega8cc@178.162.204.238] has joined #bitcoin-core-dev
05:20 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
05:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:20 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
05:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:23 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 245 seconds]
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0753c7392796...24f29790cd7e
05:28 < bitcoin-git> bitcoin/master fa4ee0d MarcoFalke: build: Remove unused src/obj-test folder
05:28 < bitcoin-git> bitcoin/master 24f2979 MarcoFalke: Merge #16589: build: Remove unused src/obj-test folder
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16589: build: Remove unused src/obj-test folder (master...1908-buildNoSrcObjTest) https://github.com/bitcoin/bitcoin/pull/16589
05:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:30 -!- designwish [~designwis@51.ip-51-68-136.eu] has quit [Quit: ZNC - http://znc.in]
05:31 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Quit: bye]
05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:33 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24f29790cd7e...a7aa80902763
05:33 < bitcoin-git> bitcoin/master 7cd069d Martin Zumsande: Add test for AddTimeData
05:33 < bitcoin-git> bitcoin/master a7aa809 Wladimir J. van der Laan: Merge #16563: test: Add unit test for AddTimeData
05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:35 < bitcoin-git> [bitcoin] laanwj merged pull request #16563: test: Add unit test for AddTimeData (master...201908_test_timedata) https://github.com/bitcoin/bitcoin/pull/16563
05:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:35 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev
05:38 -!- lalitmee [~lalitmee@106.51.71.179] has quit [Ping timeout: 248 seconds]
05:38 -!- designwish [~designwis@51.ip-51-68-136.eu] has joined #bitcoin-core-dev
05:44 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
05:54 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Quit: ZNC 1.7.4 - https://znc.in]
06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:00 < bitcoin-git> [bitcoin] laanwj opened pull request #16611: build: Remove src/obj directory from repository (master...2019_08_srcobj) https://github.com/bitcoin/bitcoin/pull/16611
06:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:15 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
06:19 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
06:20 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
06:25 -!- jonatack [~jon@213.152.162.104] has quit [Ping timeout: 245 seconds]
06:27 -!- bsm1175321 [~mcelrath@c-24-61-184-150.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
06:28 -!- bsm1175321 [~mcelrath@c-24-61-184-150.hsd1.ma.comcast.net] has quit [Client Quit]
06:47 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:51 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/bbc2970082a2...43cf76b19395
06:51 < bitcoin-git> bitcoin/0.18 2c341e3 MarcoFalke: travis: Properly cache and error on timeout
06:51 < bitcoin-git> bitcoin/0.18 5aac5e9 MarcoFalke: travis: Bump second timeout to 33 minutes, Add rationale
06:51 < bitcoin-git> bitcoin/0.18 80cd3f0 MarcoFalke: travis: Bump timeout from 50 minutes to 90
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:57 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 268 seconds]
07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:02 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:03 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
07:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:04 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
07:04 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 248 seconds]
07:05 -!- alko [~alko@BSN-77-147-172.static.siol.net] has joined #bitcoin-core-dev
07:06 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
07:07 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
07:13 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: harrigan]
07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:15 < bitcoin-git> [bitcoin] laanwj opened pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:18 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
07:22 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Quit: WeeChat 2.4]
07:25 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
07:36 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
07:37 -!- seeder [uid377087@gateway/web/irccloud.com/x-vaahynqguqnelwla] has joined #bitcoin-core-dev
07:41 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-rvlwnnvpylfdhovi] has joined #bitcoin-core-dev
07:42 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
07:47 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:50 -!- lalitmee [~lalitmee@36.255.86.115] has joined #bitcoin-core-dev
07:51 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
07:54 -!- gleb [sid306870@gateway/web/irccloud.com/x-ygxmnjkyvaqipiud] has left #bitcoin-core-dev []
07:54 -!- gleb [sid306870@gateway/web/irccloud.com/x-ygxmnjkyvaqipiud] has joined #bitcoin-core-dev
07:57 -!- E_ [~E@196.247.56.22] has joined #bitcoin-core-dev
08:00 -!- omega8cc [~omega8cc@178.162.204.238] has quit []
08:01 -!- E__ [~E@pool-173-56-241-176.nycmny.fios.verizon.net] has quit [Ping timeout: 272 seconds]
08:04 -!- DpEpsilon1 [~DpEpsilon@139.28.218.198] has joined #bitcoin-core-dev
08:05 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:07 < gleb> I want to discuss #16599 sometime at the meeting, but maybe we should start with “needs conceptual review”? Do we have room for this discussion in the conceptual review list?
08:07 < gribble> https://github.com/bitcoin/bitcoin/issues/16599 | ASN-based bucketing of the network nodes · Issue #16599 · bitcoin/bitcoin · GitHub
08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:08 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a7aa80902763...67be6d7a177c
08:08 < bitcoin-git> bitcoin/master e5b26de nicolas.dorier: Make whitebind/whitelist permissions more flexible
08:08 < bitcoin-git> bitcoin/master ecd5cf7 nicolas.dorier: Do not disconnect peer for asking mempool if it has NO_BAN permission
08:08 < bitcoin-git> bitcoin/master d541fa3 nicolas.dorier: Replace the use of fWhitelisted by permission checks
08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:08 < bitcoin-git> [bitcoin] laanwj merged pull request #16248: Make whitebind/whitelist permissions more flexible (master...feature/permissions) https://github.com/bitcoin/bitcoin/pull/16248
08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:10 < wumpus> gleb: sure, willl add it to that
08:21 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
08:22 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
08:23 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
08:25 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
08:26 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
08:27 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Max SendQ exceeded]
08:27 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
08:28 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Max SendQ exceeded]
08:28 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
08:29 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Max SendQ exceeded]
08:30 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
08:30 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Max SendQ exceeded]
08:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:41 < bitcoin-git> [bitcoin] practicalswift closed pull request #16273: refactor: Remove unused includes (master...cut-compilation-bloat) https://github.com/bitcoin/bitcoin/pull/16273
08:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:42 -!- E__ [~E@pool-173-56-241-176.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:46 -!- E_ [~E@196.247.56.22] has quit [Ping timeout: 245 seconds]
08:58 -!- E_ [~E@196.247.56.22] has joined #bitcoin-core-dev
09:02 -!- E__ [~E@pool-173-56-241-176.nycmny.fios.verizon.net] has quit [Ping timeout: 272 seconds]
09:19 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
09:19 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
09:24 -!- michaelfolkson [~textual@bzq-60-168-31-122.red.bezeqint.net] has joined #bitcoin-core-dev
09:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
09:28 -!- E__ [~E@pool-173-56-241-176.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
09:32 -!- E_ [~E@196.247.56.22] has quit [Ping timeout: 248 seconds]
09:32 < luke-jr> kallewoof: it might make sense to split out a couple more changes
09:33 < luke-jr> suggest: fees: FeeModes doc helper function ; RPC/Wallet: Make fee estimate modes case insensitive.
09:42 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
09:46 -!- seeder [uid377087@gateway/web/irccloud.com/x-vaahynqguqnelwla] has quit [Quit: Connection closed for inactivity]
09:48 -!- kljasdfvv [~flack@p200300D46F0E7800896ABEB827C59029.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
09:48 -!- kljasdfvv [~flack@p200300D46F0E780068D7AA7737D81DE7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:52 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has quit [Ping timeout: 245 seconds]
09:59 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has joined #bitcoin-core-dev
10:01 -!- seeder [uid377087@gateway/web/irccloud.com/x-juehsjrxedcjkora] has joined #bitcoin-core-dev
10:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
10:03 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
10:03 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
10:04 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
10:04 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
10:05 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
10:05 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
10:05 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
10:06 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
10:06 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
10:06 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
10:07 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
10:13 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
10:13 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
10:16 -!- pinheadmz [matthewzip@gateway/vpn/nordvpn/pinheadmz] has quit [Quit: pinheadmz]
10:18 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
10:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
10:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
10:26 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
10:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:28 < bitcoin-git> [bitcoin] gapeman opened pull request #16615: doc: Fix typos in COPYRIGHT (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16615
10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:32 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Read error: Connection reset by peer]
10:35 -!- phwalkr_ [~phwalkr@2001:1284:f019:8626:9ac:6d92:eb4:e323] has quit [Quit: Leaving...]
10:35 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
10:37 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: harrigan]
10:38 -!- jarthur [~jarthur@207.114.244.5] has quit [Read error: Connection reset by peer]
10:38 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
10:41 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
10:44 -!- lalitmee [~lalitmee@36.255.86.115] has quit [Quit: Leaving]
10:45 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 245 seconds]
11:00 -!- DpEpsilon1 [~DpEpsilon@139.28.218.198] has quit []
11:03 -!- michaelfolkson [~textual@bzq-60-168-31-122.red.bezeqint.net] has quit [Quit: Sleep mode]
11:04 -!- cmeiklejohn1 [~cmeiklejo@89.249.74.218] has joined #bitcoin-core-dev
11:30 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-rvlwnnvpylfdhovi] has quit [Quit: Connection closed for inactivity]
11:34 -!- peleion [~jeff@76.73.148.34] has quit [Ping timeout: 258 seconds]
11:41 -!- captjakk [~captjakk@2601:280:1:d11e:e164:5c90:a78b:5709] has joined #bitcoin-core-dev
11:44 -!- captjakk_ [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has joined #bitcoin-core-dev
11:45 -!- captjak__ [~captjakk@2601:280:1:d11e:1473:56f:e447:a680] has joined #bitcoin-core-dev
11:48 -!- captjakk [~captjakk@2601:280:1:d11e:e164:5c90:a78b:5709] has quit [Ping timeout: 264 seconds]
11:48 -!- captjakk_ [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has quit [Ping timeout: 248 seconds]
11:53 -!- captjak__ [~captjakk@2601:280:1:d11e:1473:56f:e447:a680] has quit [Remote host closed the connection]
11:55 -!- captjakk [~captjakk@2601:280:1:d11e:96f:29c:d596:f8d0] has joined #bitcoin-core-dev
12:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:02 < bitcoin-git> [bitcoin] dongcarl closed pull request #14856: net: remove more CConnman globals (theuni) (master...2018-12-more-connman-params) https://github.com/bitcoin/bitcoin/pull/14856
12:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:02 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Remote host closed the connection]
12:02 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection]
12:03 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
12:09 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
12:20 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
12:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
12:22 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
12:22 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
12:22 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
12:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer]
12:22 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Write error: Connection reset by peer]
12:22 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Write error: Connection reset by peer]
12:22 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Write error: Connection reset by peer]
12:22 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Write error: Connection reset by peer]
12:22 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Write error: Connection reset by peer]
12:22 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Write error: Connection reset by peer]
12:22 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Write error: Connection reset by peer]
12:23 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev
12:23 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
12:23 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 248 seconds]
12:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
12:24 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
12:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
12:25 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
12:26 -!- seeder [uid377087@gateway/web/irccloud.com/x-juehsjrxedcjkora] has quit [Quit: Connection closed for inactivity]
12:27 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds]
12:28 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
12:43 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
12:51 -!- captjakk [~captjakk@2601:280:1:d11e:96f:29c:d596:f8d0] has quit [Remote host closed the connection]
12:55 < jnewbery> wumpus: would you consider reverting #16248? It's quite a large PR (~450 LOC) with only your ACK. I'm not sure anyone has actually reviewed the parsing code in detail.
12:55 < gribble> https://github.com/bitcoin/bitcoin/issues/16248 | Make whitebind/whitelist permissions more flexible by NicolasDorier · Pull Request #16248 · bitcoin/bitcoin · GitHub
13:02 < wumpus> jnewbery: if you think it's really a risk
13:03 < wumpus> the parsing code looks fine to me
13:03 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
13:04 < wumpus> imo if it causes trouble we can revert it later, before the 0.19 release
13:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds]
13:06 < jnewbery> wumpus: not sure if it's a risk. Just seems under-reviewed to me.
13:06 < wumpus> tbh I was a bit sick of only merging small refactors and documentation changes, seems we have a lot of trouble merging anything more significant lately
13:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:07 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67be6d7a177c...f418c3379cba
13:07 < bitcoin-git> bitcoin/master d6ac25b Carl Dong: autoconf: Sane --enable-debug defaults.
13:07 < bitcoin-git> bitcoin/master f418c33 Jonas Schnelli: Merge #16435: autoconf: Sane `--enable-debug` defaults.
13:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:08 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #16435: autoconf: Sane `--enable-debug` defaults. (master...2019-07-better-debuggability) https://github.com/bitcoin/bitcoin/pull/16435
13:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:09 < wumpus> and this seems pretty straightforward and has tests, anyhow if you really think it should be reverted instead of fixing the issues with it that's fine with me
13:10 < jnewbery> I don't pay as much attention to what's being merged as you, but lowering the review burden doesn't seem like the right fix to interesting things not getting merged (at least not without discussion first)
13:11 < wumpus> it has been open for quite a while
13:11 < jnewbery> like I say, I haven't looked at the PR in great detail, so I can't say whether it's a big risk. It just seemed like the code change:number of ACKs ratio was unusual
13:12 < sipa> Code ACK on the string parsing code in that PR.
13:12 < sipa> there :)
13:14 -!- iamtimmarchant [~iamtimmar@cpe-98-144-60-187.wi.res.rr.com] has joined #bitcoin-core-dev
13:17 < wumpus> I don't know either, sorry okay
13:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
13:20 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving]
13:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
13:22 < wumpus> sipa: thanks!
13:23 < wumpus> that's some forward momentum right there :)
13:27 -!- iamtimmarchant [~iamtimmar@cpe-98-144-60-187.wi.res.rr.com] has quit [Remote host closed the connection]
13:28 < jnewbery> merge driven review :)
13:29 < wumpus> we did that more often in the past
13:32 -!- baldur [~baldur@pool-108-29-146-178.nycmny.fios.verizon.net] has quit [Ping timeout: 245 seconds]
13:32 < wumpus> it's good to be careful, but also, not everything needs the same level of assurance as changes to the consensus code
13:44 -!- captjakk [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has joined #bitcoin-core-dev
13:45 -!- baldur [~baldur@pool-108-29-146-178.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
13:57 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:00 -!- cmeiklejohn1 [~cmeiklejo@89.249.74.218] has quit []
14:02 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:04 -!- dhart [~dhart@185.204.1.185] has joined #bitcoin-core-dev
14:09 -!- hanhua [68850940@104.133.9.64] has joined #bitcoin-core-dev
14:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
14:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
14:22 -!- jarthur [~jarthur@207.114.244.5] has quit []
14:25 < aj> wumpus: oh, i kept putting off doing a proper review/ack for 16248, sorry. moneyball was meant to be pinging people to ACK PRs so we got less bogged down in refactors etc, wonder if he's still doing that
14:27 < moneyball> aj i intend too but sadly have put on back burner as i'm heads down building the square crypto team right now. everyone should bug me again in 1-2 months to make sure i am doing my part to help this project!
14:35 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
14:35 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds]
14:36 < fanquake> aj I’ve been ramping up my pinging / reaching out to people.
14:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
14:46 -!- learning [2d1f60a2@45-31-96-162.lightspeed.iplsin.sbcglobal.net] has joined #bitcoin-core-dev
14:47 -!- learning [2d1f60a2@45-31-96-162.lightspeed.iplsin.sbcglobal.net] has quit [Remote host closed the connection]
14:47 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
14:53 < aj> moneyball: ohoh, fanquake's going to render you obsolete
14:54 < moneyball> fantastic!
15:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:06 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:07 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
15:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
15:11 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Remote host closed the connection]
15:11 -!- lnostdal [~lnostdal@62.90-149-73.nextgentel.com] has quit [Quit: "Fascism, Nazism, Communism and Socialism are only superficial variations of the same monstrous theme—collectivism." -- Ayn Rand]
15:24 -!- KS [2a02e2fc@42-2-226-252.static.netvigator.com] has joined #bitcoin-core-dev
15:32 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:32 -!- KS [2a02e2fc@42-2-226-252.static.netvigator.com] has quit [Remote host closed the connection]
15:36 -!- promag [~promag@92.250.97.46] has joined #bitcoin-core-dev
15:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
15:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
15:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: No route to host]
15:40 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
15:42 -!- hanhua [68850940@104.133.9.64] has quit [Remote host closed the connection]
15:45 -!- pinheadmz [~matthewzi@207.189.24.149] has joined #bitcoin-core-dev
15:57 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection]
16:01 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev
16:08 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
16:10 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-leumsttcdrujgspm] has joined #bitcoin-core-dev
16:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
16:11 -!- profmac [~ProfMac@2001:470:1f0f:226:58f4:b4fd:8a30:eaa7] has quit [Ping timeout: 250 seconds]
16:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
16:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
16:18 -!- captjakk_ [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has joined #bitcoin-core-dev
16:20 -!- captjakk [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has quit [Ping timeout: 258 seconds]
16:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
16:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
16:24 -!- captjakk_ [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has quit [Remote host closed the connection]
16:49 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
16:50 -!- pinheadmz_ [~matthewzi@209.58.132.107] has joined #bitcoin-core-dev
16:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
16:52 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
16:52 -!- pinheadmz [~matthewzi@207.189.24.149] has quit [Ping timeout: 245 seconds]
16:54 -!- pinheadmz_ [~matthewzi@209.58.132.107] has quit [Read error: Connection reset by peer]
16:55 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:55 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 268 seconds]
17:00 -!- dhart [~dhart@185.204.1.185] has quit []
17:01 -!- hanhua [63687d99@99-104-125-153.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
17:04 -!- profmac [~ProfMac@2001:470:1f0f:226:8d4:d764:be8d:874f] has joined #bitcoin-core-dev
17:04 < fanquake> I think this is one of the most explicit "help me create an altcoin" issues we've ever had: #16616
17:04 < gribble> https://github.com/bitcoin/bitcoin/issues/16616 | Technical Issue : rename command ..It is recognized as a file. · Issue #16616 · bitcoin/bitcoin · GitHub
17:04 -!- manuel [~manuel@185.5.172.148] has joined #bitcoin-core-dev
17:09 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Quit: May the Shwartz be with you]
17:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:24 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f418c3379cba...8516285d2ea4
17:24 < bitcoin-git> bitcoin/master 36f7697 Chuf: doc: Fix typos in COPYRIGHT
17:24 < bitcoin-git> bitcoin/master 8516285 fanquake: Merge #16615: doc: Fix typos in COPYRIGHT
17:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:25 < bitcoin-git> [bitcoin] fanquake merged pull request #16615: doc: Fix typos in COPYRIGHT (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16615
17:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:25 < promag> fanquake: github could do that when someone forks the project -> it could ask for altcoin name and then it would rename everything
17:39 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
17:39 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
17:41 < sipa> promag: coingen :)
17:43 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 245 seconds]
17:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:47 < promag> sipa: ah that's a thing already
17:48 < promag> err, fucking libevent
17:48 < sipa> i think it died in 2014
17:49 < promag> `nc localhost 18443` doesn't trigger any callback
17:49 < promag> only if a http request goes through
17:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
17:50 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
17:50 < sipa> promag: there's also forkgen
17:50 < sipa> oh, that died too
17:51 < promag> lol "and the world is kind of sort of back to normal."
18:02 < promag> quoting satoshilite from bitcoincore slack:@fanquake you should point him to https://build-a-co.in/ :)
18:07 < sipa> based on litecoin 0.8.5.1, lol
18:09 < esotericnonsense> lol, that's great (16616). could only be improved slightly if it were an s/bit/something-else. wonder how many important instances of 'bit' are in the code. :P
18:12 -!- hanhua [63687d99@99-104-125-153.lightspeed.sntcca.sbcglobal.net] has quit [Remote host closed the connection]
18:12 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
18:16 -!- joe_land1 [~joe@pool-173-70-79-253.nwrknj.fios.verizon.net] has joined #bitcoin-core-dev
18:17 < phantomcircuit> promag, i assume you're using the libevent http stuff and not the socket handling stuff?
18:18 < promag> phantomcircuit: right
18:19 < promag> phantomcircuit: are you suggesting to create a read event on evhttp_bound_socket_get_fd?
18:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
18:21 -!- joe_land1 [~joe@pool-173-70-79-253.nwrknj.fios.verizon.net] has quit [Ping timeout: 248 seconds]
18:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
18:26 -!- joe_land1 [~joe@pool-173-70-79-253.nwrknj.fios.verizon.net] has joined #bitcoin-core-dev
18:28 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-leumsttcdrujgspm] has quit [Quit: Connection closed for inactivity]
18:29 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 268 seconds]
18:30 -!- promag [~promag@92.250.97.46] has quit [Remote host closed the connection]
18:34 -!- lightlike [~lightlike@2001:16b8:576b:1f00:6c9c:4821:159a:c840] has quit [Quit: Leaving]
18:49 -!- promag [~promag@92.250.97.46] has joined #bitcoin-core-dev
18:49 -!- promag [~promag@92.250.97.46] has quit [Remote host closed the connection]
19:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:03 < bitcoin-git> [bitcoin] fanquake opened pull request #16617: [0.18.2] Backports (0.18...0_18_2_backports) https://github.com/bitcoin/bitcoin/pull/16617
19:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:08 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
19:09 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
19:11 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
19:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:43 < bitcoin-git> [bitcoin] fanquake closed pull request #16541: qt: Add better icon for Open URI (master...2019-08-qt-update-open-uri-icon) https://github.com/bitcoin/bitcoin/pull/16541
19:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:44 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 272 seconds]
19:47 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
19:57 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
19:57 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
19:57 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
20:00 -!- manuel [~manuel@185.5.172.148] has quit []
20:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds]
20:03 -!- clintbellanger [~clintbell@185.204.1.185] has joined #bitcoin-core-dev
20:21 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 244 seconds]
20:23 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
20:33 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
20:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:41 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
20:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:47 -!- bralyclow01 [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
20:48 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
20:50 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Client Quit]
20:51 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
20:51 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 245 seconds]
20:52 -!- bralyclow01 [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 246 seconds]
21:14 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
21:24 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
21:37 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
21:40 -!- peleion [~jeff@76.73.148.34] has joined #bitcoin-core-dev
21:42 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Quit: Leaving...]
21:46 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
21:46 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Read error: Connection reset by peer]
21:48 -!- davex_ [~user@45.74.60.148] has quit [Remote host closed the connection]
21:48 -!- davex_ [~user@45.74.60.148] has joined #bitcoin-core-dev
21:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
21:54 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:08 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Quit: Konversation terminated!]
22:08 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Ping timeout: 248 seconds]
22:09 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:28 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
23:00 -!- clintbellanger [~clintbell@185.204.1.185] has quit []
23:19 -!- pleia21 [~pleia2@89.249.74.218] has joined #bitcoin-core-dev
23:19 -!- fox2p_ [~fox2p@181.215.46.112] has joined #bitcoin-core-dev
23:19 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
23:20 -!- fox2p [~fox2p@177.67.80.187] has quit [Ping timeout: 248 seconds]
23:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
23:39 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
23:39 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
23:41 < kallewoof> luke-jr: splitting out sounds sensible to me
23:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
23:56 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
23:57 < fanquake> Apparently I cannot get the GUI to run at more than 10 FPS.
23:59 -!- Giszmo [~leo@122-58-55-184-vdsl.sparkbb.co.nz] has joined #bitcoin-core-dev
--- Log closed Thu Aug 15 00:00:40 2019