--- Log opened Thu Aug 15 00:00:40 2019
00:03 < wumpus> fanquake: have you tried enabling hardware acceleration :-)
00:09 -!- TheRec [~toto@drupal.org/user/146860/view] has quit []
00:11 < fanquake> wumpus: heh, probably have a better chance of ramping up the FPS by disabling sync.
00:14 < wumpus> qt can render using opengl and even vulkan, a smooth 1000fps should be piece of cake with a decent GPU!
00:16 < wumpus> yes, disabling sync definitely a good start :)
00:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:20 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8516285d2ea4...8fc7f0cba9b1
00:20 < bitcoin-git> bitcoin/master a2714a5 Andrew Chow: Give QApplication dummy arguments
00:20 < bitcoin-git> bitcoin/master 8fc7f0c fanquake: Merge #16578: Do not pass in command line arguments to QApplication
00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:21 < bitcoin-git> [bitcoin] fanquake merged pull request #16578: Do not pass in command line arguments to QApplication (master...no-qapp-args) https://github.com/bitcoin/bitcoin/pull/16578
00:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:25 -!- Giszmo [~leo@122-58-55-184-vdsl.sparkbb.co.nz] has quit [Quit: Leaving.]
00:25 -!- Giszmo [~leo@122-58-55-184-vdsl.sparkbb.co.nz] has joined #bitcoin-core-dev
00:26 -!- Giszmo [~leo@122-58-55-184-vdsl.sparkbb.co.nz] has quit [Client Quit]
00:26 -!- Giszmo [~leo@122-58-55-184-vdsl.sparkbb.co.nz] has joined #bitcoin-core-dev
00:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:30 < bitcoin-git> [bitcoin] fanquake closed pull request #15954: refactor: remove old bootstrap relevant code (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15954
00:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:32 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
00:37 -!- joe_land1 [~joe@pool-173-70-79-253.nwrknj.fios.verizon.net] has quit [Quit: WeeChat 1.9.1]
00:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:37 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #16618: [Fix] Allow connection of a noban banned peer (master...fix/noban-banned) https://github.com/bitcoin/bitcoin/pull/16618
00:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:22 -!- Giszmo [~leo@122-58-55-184-vdsl.sparkbb.co.nz] has quit [Quit: Leaving.]
01:22 -!- Giszmo [~leo@122-58-55-184-vdsl.sparkbb.co.nz] has joined #bitcoin-core-dev
01:24 -!- Giszmo [~leo@122-58-55-184-vdsl.sparkbb.co.nz] has quit [Client Quit]
01:34 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:35 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has quit [Ping timeout: 248 seconds]
01:36 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has joined #bitcoin-core-dev
01:44 < fanquake> Is Travis just having a bad day? Seeing a lot of timeouts like https://travis-ci.org/bitcoin/bitcoin/jobs/572183150
01:45 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 268 seconds]
01:48 < wumpus> oh those dependency fetching timeouts, saw a few yesterday too
01:49 < wumpus> maybe archive.ubuntu.com is getting sick of being continuously hammered by them, i'm really surprised travis don't have their own apt mirror
02:00 -!- pleia21 [~pleia2@89.249.74.218] has quit []
02:02 < fanquake> Has anyone here ever used distcc when building core / depends  etc ?
02:02 < fanquake> https://distcc.github.io/
02:03 -!- mathepauker [~mathepauk@185.204.1.185] has joined #bitcoin-core-dev
02:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
02:16 < wumpus> not me
02:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:21 < fanquake> wumpus #16400 now has 3 ACKs. I'm going to add it to the HPFR list. Maybe we could save merging anything into validation while this gets some final review over today and tomorrow?
02:21 < gribble> https://github.com/bitcoin/bitcoin/issues/16400 | [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts by sdaftuar · Pull Request #16400 · bitcoin/bitcoin · GitHub
02:22 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
02:22 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
02:25 < wumpus> fanquake: SGTM
02:27 < fanquake> I've asked meshcollider for a final look over #15986, he should be able to merge that if he's happy.
02:27 < gribble> https://github.com/bitcoin/bitcoin/issues/15986 | Add checksum to getdescriptorinfo by sipa · Pull Request #15986 · bitcoin/bitcoin · GitHub
02:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:35 -!- alko [~alko@BSN-77-147-172.static.siol.net] has quit [Ping timeout: 245 seconds]
02:49 -!- seeder [uid377087@gateway/web/irccloud.com/x-ercjfyxedaoxgklz] has joined #bitcoin-core-dev
02:57 -!- alko [~alko@BSN-77-147-172.static.siol.net] has joined #bitcoin-core-dev
03:14 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
03:28 -!- promag [~promag@92.250.97.46] has joined #bitcoin-core-dev
03:32 -!- promag [~promag@92.250.97.46] has quit [Ping timeout: 248 seconds]
03:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: harrigan]
03:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:03 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
04:03 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Client Quit]
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:33 < bitcoin-git> [bitcoin] laanwj closed pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:37 < wumpus> gah
04:37 < wumpus> I'm increasingly unable to contribute to opens ource software, I just don't have the energy anymore
04:38 < wumpus> always so many things everyone wants differently, sometimes reasonable, sometimes not, but it's just too busy for me
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8fc7f0cba9b1...e00501e00ccd
04:44 < bitcoin-git> bitcoin/master 37f2784 practicalswift: tests: Use colors and dots in test_runner.py output only if standard outpu...
04:44 < bitcoin-git> bitcoin/master e00501e MarcoFalke: Merge #16561: tests: Use colors and dots in test_runner.py output only if ...
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds]
04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:46 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16561: tests: Use colors and dots in test_runner.py output only if standard output is a terminal (master...parsable) https://github.com/bitcoin/bitcoin/pull/16561
04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:47 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
04:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
04:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:55 < fanquake> wumpus: I know exactly how you're feeling at the moment.
04:55 < wumpus> fanquake: thank you
04:59 -!- seeder [uid377087@gateway/web/irccloud.com/x-ercjfyxedaoxgklz] has quit [Quit: Connection closed for inactivity]
05:00 -!- mathepauker [~mathepauk@185.204.1.185] has quit []
05:00 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
05:04 -!- supaplex1 [~supaplex1@141.98.102.243] has joined #bitcoin-core-dev
05:37 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-chkqjvgluvzddzsc] has joined #bitcoin-core-dev
05:46 -!- lightlike [~lightlike@2001:16b8:571f:c600:f442:737b:d7:3900] has joined #bitcoin-core-dev
06:13 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: harrigan]
06:19 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
06:20 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
06:21 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
06:23 < jonasschnelli> ariard: can you explain that comment further: https://github.com/bitcoin/bitcoin/pull/16562#discussion_r314112055
06:23 < jonasschnelli> I can't follow
06:35 -!- davex_ [~user@45.74.60.148] has quit [Remote host closed the connection]
06:36 -!- davex__ [~user@45.74.60.148] has joined #bitcoin-core-dev
07:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:09 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16620: util: Move ResolveErrMsg to util/error (master...1908-utilErrorResolveErrMsg) https://github.com/bitcoin/bitcoin/pull/16620
07:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:10 -!- davex__ [~user@45.74.60.148] has quit [Quit: Leaving]
07:24 < elichai2> achow101: is there a way for me to sign a psbt using a descriptor with private key instead of the wallet? (I'm doing `utxoupdatepsbt` with it and now i want to do `walletprocesspsbt`, or should I use `importmulti` instead?)
07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:31 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e00501e00ccd...8bd5e0af9983
07:31 < bitcoin-git> bitcoin/master fac3dcf MarcoFalke: test: Generate one block for each send in wallet_import_rescan
07:31 < bitcoin-git> bitcoin/master fa79af2 MarcoFalke: test: Replace fragile "rng" with call to random()
07:31 < bitcoin-git> bitcoin/master fa25668 MarcoFalke: test: Test p2sh-witness and bech32 in wallet_import_rescan
07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465
07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:34 < bitcoin-git> [bitcoin] gapeman opened pull request #16621: doc: add default bitcoin.conf locations (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16621
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:39 < ariard> jonasschnelli: destructor is currently unused for V1, do you plan to use it for V2 serializer?
07:41 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
07:49 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: harrigan]
07:51 < achow101> elichai2: there is not
07:54 < sipa> ariard: i think tha5 whenever you have subclasses stored as pointers to superclass objects, the superclass must have a virtual destructor
07:54 < sipa> even if the subclass types don't define their own destructors
07:54 < jonasschnelli> yes. what sipa said
07:55 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
08:00 -!- supaplex1 [~supaplex1@141.98.102.243] has quit []
08:03 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
08:04 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
08:05 < ariard> good to know, thanks
08:18 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
08:19 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
08:22 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Client Quit]
08:22 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:26 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev
08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:36 < bitcoin-git> [bitcoin] emilengler closed pull request #16590: init: systemd directory fix (master...2019-08-systemd-fix) https://github.com/bitcoin/bitcoin/pull/16590
08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:38 < bitcoin-git> [bitcoin] jonatack opened pull request #16622: autoconf: property tests status and options (master...property-tests-autoconf-improvements) https://github.com/bitcoin/bitcoin/pull/16622
08:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:42 < elichai2> I wish people would've used more switch/case for enums instead of if/else that way the compiler will warn you on all the uses of that enum if you modify it
08:42 -!- secdragon [~secdragon@178.162.204.238] has joined #bitcoin-core-dev
08:53 < jonatack> fanquake, Chris_Stewart_5: rapidcheck seems to be coming back to life a bit https://github.com/emil-e/rapidcheck/commits/master
08:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
09:01 -!- pinheadmz [~matthewzi@209.209.238.159] has joined #bitcoin-core-dev
09:07 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
09:08 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
09:38 -!- pinheadmz [~matthewzi@209.209.238.159] has quit [Quit: pinheadmz]
09:44 -!- pinheadmz [~matthewzi@209.209.238.159] has joined #bitcoin-core-dev
09:44 < provoostenator> I know everyone wants to review the create wallet GUI PR #15450...
09:44 < gribble> https://github.com/bitcoin/bitcoin/issues/15450 | [GUI] Create wallet menu option by achow101 · Pull Request #15450 · bitcoin/bitcoin · GitHub
09:49 -!- pinheadmz [~matthewzi@209.209.238.159] has quit [Ping timeout: 248 seconds]
09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8bd5e0af9983...85883a9f8ea0
09:49 < bitcoin-git> bitcoin/master fae6ab6 James O'Beirne: refactor: pcoinsTip -> CChainState::CoinsTip()
09:49 < bitcoin-git> bitcoin/master 5693530 James O'Beirne: refactor: have CCoins* data managed under CChainState
09:49 < bitcoin-git> bitcoin/master 582d2cd James O'Beirne: Cover UTXO set access with lock annotations
09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:49 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16443: refactor: have CCoins* data managed under CChainState (master...2019-07-au-coins-under-chainstate) https://github.com/bitcoin/bitcoin/pull/16443
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:51 -!- E__ [~E@pool-173-56-241-176.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
09:53 < provoostenator> ^^ *wumpus calls Github CEO: please allow PR owner transfer*
09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/85883a9f8ea0...367b023ae444
09:57 < bitcoin-git> bitcoin/master fafe78f MarcoFalke: ci: Rename .travis/ to ./ci/
09:57 < bitcoin-git> bitcoin/master fa0aac0 MarcoFalke: ci: Add retry
09:57 < bitcoin-git> bitcoin/master fa31bc3 MarcoFalke: ci: Remove dependence on travis, use it as fallback env
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:58 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16582: test: Rework ci (Use travis only as fallback env) (master...1908-ciRework) https://github.com/bitcoin/bitcoin/pull/16582
09:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds]
10:08 -!- pinheadmz [~matthewzi@209.209.238.159] has joined #bitcoin-core-dev
10:12 -!- Krellan_ [~Krellan@2600:1700:be50:323f:9984:a469:7558:b7fd] has joined #bitcoin-core-dev
10:12 -!- pinheadmz [~matthewzi@209.209.238.159] has quit [Ping timeout: 246 seconds]
10:15 -!- Krellan [~Krellan@2601:640:4100:ac00:d531:5eb1:1c47:cfbe] has quit [Ping timeout: 250 seconds]
10:18 -!- pinheadmz [~matthewzi@209.209.238.153] has joined #bitcoin-core-dev
10:27 < emilengler> Can someone restart this? https://travis-ci.org/bitcoin/bitcoin/builds/572354962?utm_source=github_status&utm_medium=notification
10:28 < sipa> emilengler: done
10:28 < emilengler> sipa: thank you
10:42 < gleb> wumpus: I just figured out something, and I feel like we can remove #16599 from "seeking conceptual review" for now to not distract people until I implement something.
10:42 < gribble> https://github.com/bitcoin/bitcoin/issues/16599 | ASN-based bucketing of the network nodes · Issue #16599 · bitcoin/bitcoin · GitHub
10:42 < gleb> Sorry for bothering :)
10:49 < provoostenator> gleb: that's not a bad idea. I'll probably have a stronger opinion (as opposed to no opinion) if I can see the implemations for both options.
10:50 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
10:51 < wumpus> gleb: ok, will remove it
10:54 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:00 -!- secdragon [~secdragon@178.162.204.238] has quit []
11:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:11 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds]
11:14 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Remote host closed the connection]
11:16 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
11:22 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 246 seconds]
11:22 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
11:34 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev
11:35 -!- captjakk [~captjakk@205.209.24.233] has joined #bitcoin-core-dev
11:39 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 258 seconds]
11:42 -!- MichealH-iPod [~MichealH-@185.5.172.148] has joined #bitcoin-core-dev
11:50 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev
11:59 < MarcoFalke> Short update on the ci stuff:
11:59 < MarcoFalke> * GitHub ci is in early beta and there is not much I can evaluate
11:59 < MarcoFalke> They don't have caching, nor can own hardware be attached
12:00 < MarcoFalke> * Travis timeout was bumped to 90 minutes, so we shouldn't see any timeout anymore
12:00 < wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu Aug 15 19:00:21 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < provoostenator> hi
12:00 < jonasschnelli> hi
12:00 < MarcoFalke> (In theory, in practice `apt update` times out ...)
12:00 < MarcoFalke> hi
12:01 < wumpus> yes, that's nice, hopefully the theory starts working out :)
12:01 < real_or_random> hi
12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
12:01 < wumpus> no proposed topics on the weekly meeting list
12:01 < cfields> MarcoFalke: I wasn't here last week to post, but here was my feedback for Github: https://pastebin.com/raw/3PS5rtdN
12:01 < sipa> hi
12:01 < MarcoFalke> But the good news is that the ci can be run locally (or anywhere now). See ./ci/ subfolder
12:01 -!- greypw [~greypw@unaffiliated/greypw] has quit [Ping timeout: 264 seconds]
12:01 < jonasschnelli> nice
12:02 < gleb> hi
12:02 < Chris_Stewart_5>   hi
12:02 < sipa> MarcoFalke: nice
12:02 < cfields> Glad to see you're trying it out, though :)
12:02 < jonasschnelli> Though I still not fully buying into the concept that a CI configuration should be part of the main repository
12:02 < wumpus> right, at least we know its limitations now, thanks!
12:02 < MarcoFalke> cfields: Yeah, I guess in the end we'll go with jonasschnelli's ci
12:03 < jonasschnelli> (once it's mature enough)
12:03 < ryanofsky> fun fact: the ci folder contains 4 mentions of the word "poop"
12:03 < MarcoFalke> jonasschnelli: Why not? travis.yml is part of the main repo
12:03 < achow101> hi
12:03 < jonasschnelli> Just conceptually I don't understand why the CI configuration needs to be part of the project sources
12:03 < jonasschnelli> Could be another repo, config-file, whatever
12:03 < jnewbery> hi
12:04 < MarcoFalke> jonasschnelli: Because the config needs to be updated atomically with the source code
12:04 < jonasschnelli> why?
12:04 < MarcoFalke> Let's say I add a new dependency boost-process, the ci runner needs to install it
12:04 -!- iamtimmarchant [6b4dcfa8@gateway/web/cgi-irc/kiwiirc.com/ip.107.77.207.168] has joined #bitcoin-core-dev
12:04 < jonasschnelli> Yes. But it could be update in that secondary config file / repository then
12:05 -!- iamtimmarchant [6b4dcfa8@gateway/web/cgi-irc/kiwiirc.com/ip.107.77.207.168] has quit [Remote host closed the connection]
12:05 < MarcoFalke> And in the meantime the ci couldn't run?
12:05 < MarcoFalke> Also you couldn't run it on older branches
12:05 < jonasschnelli> Maybe...
12:05 -!- captjakk [~captjakk@205.209.24.233] has quit [Remote host closed the connection]
12:05 < jonasschnelli> It just feels this would not scale with multiple build systems / CI
12:06 < jonasschnelli> With the Appvayor, it's already a problem IMO
12:06 < jonasschnelli> but I'm probably complicating things...
12:06 < MarcoFalke> My plan was to only have one place to put the config and have all build systems use that config
12:06 < MarcoFalke> I tested it with GitHub CI, Cirrus CI, Travis CI. They all use the same config and it works
12:06 < jonasschnelli> Wouldn't that lead to a monotonic CI/test system?
12:07 < MarcoFalke> It includes the whole build matrix. But I agree
12:07 < kanzure> hi
12:07 < ryanofsky> i think it's convenient for things like ci and lint to be in the main repository, it would be a headache to have a change like #16367 that requires a ci update and have to stage it in multiple prs
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/16367 | Multiprocess build support by ryanofsky · Pull Request #16367 · bitcoin/bitcoin · GitHub
12:07 < jonasschnelli> My understanding would be, that there are a bunch of test-systems (call it CIs), running aside of our repo...
12:07 -!- elisheets [~elisheets@rrcs-98-101-181-130.midsouth.biz.rr.com] has joined #bitcoin-core-dev
12:07  * dongcarl enjoyed ryanofsky's fun fact
12:08 < jonasschnelli> They have all their custom setup to test various configurations
12:08 < provoostenator> I'd like to be able to run CI without Docker at some point...
12:08 < jonasschnelli> If we run the same matrix on all CIs,.. seems a bit pointless
12:08 < MarcoFalke> jonasschnelli: Right. Agree on that
12:08 < jonasschnelli> provoostenator: bitcoinbuilds at least runs without docker...
12:08 < MarcoFalke> It is more a plan to not be married to one CI supplier
12:08 < wumpus> dongcarl: same :)
12:09 < jonasschnelli> which is a good point. If we have one CI script that always runs in docker... 
12:09 < MarcoFalke> provoostenator: jonasschnelli: You can also run ./ci/ without docker
12:09 < MarcoFalke> Though that messes up the host (obviously)
12:10 < jonasschnelli> Okay. Let me continue to think about this... but I see the point of convenience 
12:10 < provoostenator> Right, it would be happy to run just one specifiic host
12:10 < provoostenator> E.g. I have a Bionic x86 machine here, or an ARM machine elsewhere. 
12:11 < MarcoFalke> jonasschnelli: Yeah let's continue in #bitcoin-builds or in one of my follow up pull requests that I plan to open soon :)
12:11 < jonasschnelli> ack
12:11 < sipa> proposed topic: libsecp256k1 maintenance
12:11 < MarcoFalke> #topic libsecp256k1 maintenance (sipa)
12:12 < sipa> so, lately i haven't had too much time to deal with maintaining libsecp256k1
12:12 < sipa> and also the other existing maintainers haven't been active
12:13 < sipa> real_or_random has been pretty active, and i'd like to transition to giving him maintainer rights
12:13  * jonasschnelli looks at real_or_random 
12:13 < sipa> but i wanted to bring this up here, as the secp256k1 repo is under the bitcoin-core org
12:13 < MarcoFalke> I was about to suggest the first one to say a word will become the next maintainer
12:14 < real_or_random> glad I haven't said a word
12:14 < instagibbs> congrats... jonasschnelli ;P
12:14 < MarcoFalke> good to hear that real_or_random is volunteering for that position
12:14 < jonasschnelli> ack on real_or_random 
12:14 < jonasschnelli> instagibbs: that was just an irc-action.. :P
12:14 < wumpus> I'd like to volunteer but currently, I'm just not able to
12:15 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer]
12:15 -!- greypw [~greypw@unaffiliated/greypw] has joined #bitcoin-core-dev
12:15 < MarcoFalke> wumpus: We should make a rule that Bitcoin Core maintainers are not allowed to maintain other projects :)
12:15 < nickler> ack real_or_random
12:16 < real_or_random> I think nickler was volunteering too :)
12:16 < wumpus> MarcoFalke: that's okay with me too :)
12:16 < provoostenator> also ack real_or_random
12:16 < MarcoFalke> ack nickler and real_or_random
12:16 < wumpus> *leaves bitcoin core for secp256k1* hehe
12:16 < sipa> also ack nickler from me, obviously :)
12:16 < jonasschnelli> also ack nickler
12:16 < sipa> that was easy.
12:16 < nickler> I'd be happy to help
12:16 < instagibbs> should people be removed? 
12:17 < instagibbs> or is it just too small a number
12:17 < jonasschnelli> I guess greg and sipa?
12:17 < provoostenator> nickler what's your Github name?
12:17 < jonasschnelli> Fine for me to keep it for now
12:17 < sipa> it's andytoshi and me
12:17 < nickler> provoostenator: jonasnick
12:17 < sipa> currently
12:17 < provoostenator> Ah ok, ACK
12:17 < instagibbs> ok ACK
12:18 < wumpus> are you going to add them sipa or should I?
12:18 < sipa> i will.
12:18 < MarcoFalke> Is it that repo: https://github.com/bitcoin-core/secp256k1 ?
12:18 < sipa> correct
12:18 < wumpus> yes
12:18 < jonasschnelli> I think removing is something that could be done after 1y of inactivity or if someone explicitly wants to be removed
12:18 < MarcoFalke> why is the latest merge not signed and done with GitHub?
12:18 < MarcoFalke> (ot)
12:19 < jonasschnelli> valid point... some merge policy would probably be wise
12:19 < sipa> we should probably add merge checks in CI just like in bitcoin core itself
12:19 < real_or_random> MarcoFalke: yeah I think there are a few related issues to  discuss
12:19 < provoostenator> Could reuse some of the Bitcoin Core tools over?
12:19 < sipa> yeah.
12:19 < real_or_random> also e.g., I have an open issue about a security.md file
12:20 < real_or_random> which raises the question who should be in there. secp256k1 maintainers or bitcoin-core maintainers?
12:20  * MarcoFalke has set a bash alias `ghm` for "github-merge.py" that works on any repo
12:21 < real_or_random> and we also don't have super clear guidelines for what should be in the repo and what not (e.g., we have the JNI bindings that we may want to remove)
12:21 < wumpus> we should probably move github-merge.py to maintainer-tools
12:21 < wumpus> instead of having it in the bitcoin core repository
12:21 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:21 < wumpus> that way it's much easier to use it for different projects
12:21 < sipa> i think that libsecp256k1 issues which don't directly affect bitcoin core can be kept inside the secp256k1 project (bitcoin core has no need for JNI... :p)
12:22 < sipa> and discussed on the #secp256k1 channel
12:22 < wumpus> secp256k1 issues should probably be reported to secp256k1 maintainers, in general
12:22 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:22 < sipa> agree; though very serious issues that impact bitcoin could of course also be reported to bitcoin core
12:23 < real_or_random> wumpus: yes this seems sensible they can escalate to core if necessary
12:23 < sipa> wumpus: agree on moving over github-merge to maintainer-tools
12:23 < sipa> i use it for unrelated projects too :)
12:23 < wumpus> yes, if it affects use in bitcoin, or is even an issue that threatens bitcoin, that seems an exception
12:23 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:23 -!- reallll [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds]
12:24 < wumpus> sipa: ok!
12:24 < real_or_random> ack on a using github-merge and/or related tools
12:25 < real_or_random> core vendors secp256k1, so the changes need to be accepted there too
12:25 < wumpus> #action move github-merge.py to bitcoin-maintainer-tools repo
12:25 < sipa> real_or_random: occasionally we open a PR to core that updates the subtree, summarizing the changes
12:25 < real_or_random> but tbh, if we open a large +500/-500 PR from time to time, it's too late to spot weirdnesses
12:26 < sipa> yeah perhaps that's a question whether people here prefer more regular updates of the subtree
12:26 < real_or_random> yes, indeed. I think my point is that these tend to get ACKed with the idea in mind that they're fine because they were merged in secp256k1
12:26 < wumpus> it's another opportunity for review, though yes, if it groups too many different things it'll likely not get more than cursory glances
12:27 < real_or_random> so it makes sense to have the same careful committing/merging process for secp too
12:27 < wumpus> also a lot of bitcoin core reviewers don't have much knowledge of the details of the cryptography and implementation
12:27 < wumpus> yes
12:27 -!- MasterdonX [~masterdon@titan.zm.is] has quit [Read error: Connection reset by peer]
12:27 < real_or_random> right
12:27 < real_or_random> sipa: this question is also related to possible releases
12:28 < real_or_random> AFAIK it was always planned to have releases, we may reconsider that
12:28 < sipa> yeah
12:28 < sipa> i guess not everything needs to be resolved in this meeting
12:28 < real_or_random> sure
12:28 < sipa> but it's good to have some communication
12:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:30 < wumpus> yes, it's fine, it's not like there's other proposed topics for this meeting :) and I don't think sharing a meeting with secp256k1 stuff is that bad so people are aware what is happening there
12:30 < sipa> high priority for review?
12:30 < wumpus> oh yes, we could do that
12:31 < wumpus> #topic High priority for review
12:31 < BlueMatt> an I add #16421 to the list?
12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/16421 | Conservatively accept RBF bumps bumping one tx at the package limits by TheBlueMatt · Pull Request #16421 · bitcoin/bitcoin · GitHub
12:31 < wumpus> sure we can always add more, I'm most interested in whether some things are getting ready for merge though :)
12:32 < aj> BlueMatt: fanquake did that already i thought?
12:32 < jeremyrubin> correct
12:33 < BlueMatt> oh, maybe
12:33 < BlueMatt> I just want to get it in for .19, and its gotten very little review
12:33 < BlueMatt> despite being an incredibly simple pr
12:33 < instagibbs> BlueMatt, will review 
12:33 < MarcoFalke> I think we got three high-prio things merged this week
12:33 < MarcoFalke> maybe even more
12:33 < wumpus> 8 things on the list is a lot though
12:34 < wumpus> oh one is merged, good
12:34 < aj> oh fanquake added 16400
12:35 < MarcoFalke> #16400 should get removed
12:35 < gribble> https://github.com/bitcoin/bitcoin/issues/16400 | [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts by sdaftuar · Pull Request #16400 · bitcoin/bitcoin · GitHub
12:35 < wumpus> so yes, the soft translation string freeze for 0.19 is already in two weeks, the feature freeze in a month
12:35 < MarcoFalke> It needs rebase and I think #15759 was in first
12:35 < gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub
12:36 < wumpus> ok
12:37 < wumpus> 16400 removed from now, let's re-add it after 15759 merged
12:38 < wumpus> anything else to discuss?
12:39 < wumpus> #endmeeting
12:39 < lightningbot> Meeting ended Thu Aug 15 19:39:57 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:39 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-15-19.00.html
12:39 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-15-19.00.txt
12:39 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-15-19.00.log.html
12:40 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
12:45 < wumpus> FWIW https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/28
12:50 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:59 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/367b023ae444...1bf2ff2bf8e8
13:04 < bitcoin-git> bitcoin/master 3862e47 John Newbery: [rpc] Tidy up reporting of buried and ongoing softforks
13:04 < bitcoin-git> bitcoin/master 1c93b9b John Newbery: [Consensus] Bury CSV deployment height
13:04 < bitcoin-git> bitcoin/master 0328dcd John Newbery: [Consensus] Bury segwit deployment
13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16060: Bury bip9 deployments (master...bury_bip9_deployments) https://github.com/bitcoin/bitcoin/pull/16060
13:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:16 -!- greypw [~greypw@unaffiliated/greypw] has quit [Remote host closed the connection]
13:17 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
13:20 -!- greypw [~greypw@unaffiliated/greypw] has joined #bitcoin-core-dev
13:30 -!- MasterdonX [~masterdon@5.226.137.20] has joined #bitcoin-core-dev
13:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
13:39 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 244 seconds]
13:40 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
13:49 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
13:49 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
13:49 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
13:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:53 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16623: ci: Add environment files for all settings (master...1908-ciEnv) https://github.com/bitcoin/bitcoin/pull/16623
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:56 -!- hanhua [68850941@104.133.9.65] has joined #bitcoin-core-dev
13:58 -!- elisheets [~elisheets@rrcs-98-101-181-130.midsouth.biz.rr.com] has quit [Quit: Lost terminal]
14:00 -!- MichealH-iPod [~MichealH-@185.5.172.148] has quit []
14:05 -!- sankarshan1 [~sankarsha@185.204.1.185] has joined #bitcoin-core-dev
14:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:16 < bitcoin-git> [bitcoin] ariard opened pull request #16624: wallet : encapsulate trransactions state (master...2019-08-encapsulate-tx-state) https://github.com/bitcoin/bitcoin/pull/16624
14:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:45 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
14:48 -!- promag [~promag@92.250.97.46] has joined #bitcoin-core-dev
14:51 < fanquake> I put 16400 in there because it had 3 ACKs and was much closer to being merged than 15799 at the time (also didn’t need a rebase). Guess someone merged into validation and broke it.
14:53 < fanquake> I don’t think it should necessarily matter which PR was in there “first”. As there are things that have lingered in HP for weeks. It should also matter what has had recent/active review.
14:54 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
15:04 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:07 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 260 seconds]
15:08 -!- kristapsk_ is now known as kristapsk
15:14 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
15:21 -!- roconnor [~roconnor@host-104-157-195-166.dyn.295.ca] has joined #bitcoin-core-dev
15:22 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
15:22 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:26 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
15:28 -!- jarthur [~jarthur@207.114.244.5] has quit []
15:32 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Remote host closed the connection]
15:32 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
15:33 -!- profmac [~ProfMac@2001:470:1f0f:226:8d4:d764:be8d:874f] has quit [Ping timeout: 250 seconds]
15:33 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:33 < roconnor> Hi all.  After building bitcoin-0.18.0 and bitcoin-0.18.1 when I run the test_bitcoin program it lists a large number of "Error: Specified -walletdir "wallets" is a relative path ... followed by "*** No errors detected".  I didn't have this issue with bitcoin-0.17.1.  Have I made some sort of configuration error here?
15:39 -!- promag_ [~promag@92.250.97.46] has joined #bitcoin-core-dev
15:39 -!- promag [~promag@92.250.97.46] has quit [Ping timeout: 268 seconds]
15:50 -!- profmac [~ProfMac@2001:470:1f0f:226:c0e2:51d0:175f:6988] has joined #bitcoin-core-dev
15:57 < lightlike> roconnor: that was described in #15944 and recently fixed (#16277): as a side effect of a negative test these messages are written to stderr. so it's no problem.
15:57 < gribble> https://github.com/bitcoin/bitcoin/issues/15944 | Path error messages while executing test_bitcoin · Issue #15944 · bitcoin/bitcoin · GitHub
15:57 < gribble> https://github.com/bitcoin/bitcoin/issues/16277 | [Tests] Suppress output in test_bitcoin for expected errors by gertjaap · Pull Request #16277 · bitcoin/bitcoin · GitHub
16:01 < roconnor> Great thanks.  I won't sweat about it then.
16:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
16:21 -!- davterra [~none@209.58.185.33] has quit [Quit: Leaving]
17:00 -!- sankarshan1 [~sankarsha@185.204.1.185] has quit []
17:19 -!- csharpsteen [~csharpste@184.75.223.219] has joined #bitcoin-core-dev
17:21 -!- promag_ [~promag@92.250.97.46] has quit [Remote host closed the connection]
17:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:24 < bitcoin-git> [bitcoin] fanquake opened pull request #16625: scripts: remove github-merge.py (master...remove_github_merge_script) https://github.com/bitcoin/bitcoin/pull/16625
17:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:26 < fanquake> The github-merge.py script has been merged into the maintainer tools repo in: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/28
17:27 -!- promag [~promag@92.250.97.46] has joined #bitcoin-core-dev
17:27 < fanquake> Would anyone be opposed to having the maintainer-tools commits show up here via the bot, if that's possible? Commits are infrequent, but probably interesting to those watching in here.
17:27 -!- promag [~promag@92.250.97.46] has quit [Remote host closed the connection]
17:27 < fanquake> Also since we are moving more important scripts to that repo.
17:34 < fanquake> Opened https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/29 to port the docs, feel free to nit-pick.
17:49 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
17:58 -!- lightlike [~lightlike@2001:16b8:571f:c600:f442:737b:d7:3900] has quit [Quit: Leaving]
18:47 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:51 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
19:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
19:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:10 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
19:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:14 < bitcoin-git> [bitcoin] nilswloewen opened pull request #16626: Fix spelling error chache -> cache. (master...master) https://github.com/bitcoin/bitcoin/pull/16626
19:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:17 -!- nilswloewen [cf065349@d207-6-83-73.bchsia.telus.net] has joined #bitcoin-core-dev
19:17 < fanquake> I'm messaging some users in here directly about review and re-review (don't want to spam the channel). If you'd rather not hear from me, just let me know.
19:18 -!- PaulTroon [~paultroon@2604:2000:e09d:a900:a97f:ac30:1a52:45df] has joined #bitcoin-core-dev
19:27 -!- StopAndDecrypt [~StopAndDe@107.181.189.42] has joined #bitcoin-core-dev
19:27 -!- StopAndDecrypt [~StopAndDe@107.181.189.42] has quit [Changing host]
19:27 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
19:27 -!- StopAndDecrypt_ [~StopAndDe@107.181.189.42] has quit [Ping timeout: 245 seconds]
19:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:34 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bf2ff2bf8e8...14982b87e945
19:34 < bitcoin-git> bitcoin/master f9d40ce Nils Loewen: Fix spelling error chache -> cache.
19:34 < bitcoin-git> bitcoin/master 14982b8 fanquake: Merge #16626: doc: Fix spelling error chache -> cache.
19:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:35 < bitcoin-git> [bitcoin] fanquake merged pull request #16626: doc: Fix spelling error chache -> cache. (master...master) https://github.com/bitcoin/bitcoin/pull/16626
19:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:43 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
19:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:45 < bitcoin-git> [bitcoin] kallewoof opened pull request #16628: refactor: remove redundant pindexPrev from TestBlockValidity (master...2019-08-tbv-nopi) https://github.com/bitcoin/bitcoin/pull/16628
19:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:52 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/14982b87e945...95a5918c9059
19:52 < bitcoin-git> bitcoin/master 6576a87 Antoine Riard: doc: Improve versionbits.h documentation
19:52 < bitcoin-git> bitcoin/master 95a5918 fanquake: Merge #16587: doc: Improve versionbits.h documentation
19:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:53 < bitcoin-git> [bitcoin] fanquake merged pull request #16587: doc: Improve versionbits.h documentation (master...2019-08-docs-versionbits) https://github.com/bitcoin/bitcoin/pull/16587
19:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:55 -!- nilswloewen [cf065349@d207-6-83-73.bchsia.telus.net] has quit [Ping timeout: 260 seconds]
20:00 -!- csharpsteen [~csharpste@184.75.223.219] has quit []
20:19 -!- tummy [~tummy@141.98.102.243] has joined #bitcoin-core-dev
20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:56 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/95a5918c9059...0d65106dce28
20:56 < bitcoin-git> bitcoin/master a50d9e6 William Casarin: rpcwallet: default include_watchonly to true for watchonly wallets
20:56 < bitcoin-git> bitcoin/master 003a3c7 William Casarin: rpcwallet: document include_watchonly default for watchonly wallets
20:56 < bitcoin-git> bitcoin/master 72ffbdc William Casarin: doc: add release note for include_watchonly default changes
20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:56 < bitcoin-git> [bitcoin] fanquake merged pull request #16383: rpcwallet: default include_watchonly to true for watchonly wallets (master...20190713-watchonly-defaults) https://github.com/bitcoin/bitcoin/pull/16383
20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:02 < fanquake> harding: Would you be interested in doing another release notes roll-up, similar to what you did in #15081? Currently 17 fragments floating around the repo. Note that one is actually in the doc/release-notes/ folder.
21:02 < gribble> https://github.com/bitcoin/bitcoin/issues/15081 | Doc: Update release notes for master through to 2019-01-01 by harding · Pull Request #15081 · bitcoin/bitcoin · GitHub
21:03 -!- PaulTroon [~paultroon@2604:2000:e09d:a900:a97f:ac30:1a52:45df] has quit [Remote host closed the connection]
21:14 -!- PaulTroon [~paultroon@2604:2000:e09d:a900:a97f:ac30:1a52:45df] has joined #bitcoin-core-dev
21:19 -!- PaulTroon [~paultroon@2604:2000:e09d:a900:a97f:ac30:1a52:45df] has quit [Ping timeout: 250 seconds]
21:31 < harding> fanquake: yes, definitely interested.  I'll try to get a PR opened by early next week.  Thanks for suggesting it (and for the note about the one in doc/release-notes---I would've missed that).
21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
21:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 268 seconds]
21:35 < fanquake> harding: Awesome, thanks for that.
21:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:37 < bitcoin-git> [bitcoin] kallewoof closed pull request #16628: refactor: remove redundant pindexPrev from TestBlockValidity (master...2019-08-tbv-nopi) https://github.com/bitcoin/bitcoin/pull/16628
21:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:43 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #16629: [Doc] Add documentation for the new whitelist permissions (master...doc/permissions) https://github.com/bitcoin/bitcoin/pull/16629
21:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:47 < bitcoin-git> [bitcoin] kallewoof opened pull request #16630: consensus: skip genesis block POW check (master...2019-08-validation-skip-genesis-pow) https://github.com/bitcoin/bitcoin/pull/16630
21:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:00 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer]
22:49 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
22:56 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
22:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
23:00 -!- tummy [~tummy@141.98.102.243] has quit []
23:04 -!- josevalim1 [~josevalim@139.28.218.198] has joined #bitcoin-core-dev
23:07 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-chkqjvgluvzddzsc] has quit [Quit: Connection closed for inactivity]
23:20 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
23:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
23:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:24 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d65106dce28...93bacb8cc9c0
23:24 < bitcoin-git> bitcoin/master 390874c Wladimir J. van der Laan: qt: Remove menu icons
23:24 < bitcoin-git> bitcoin/master 93bacb8 Jonas Schnelli: Merge #16612: qt: Remove menu icons
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:26 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
23:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:30 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
23:35 -!- jungly [~quassel@79.8.200.97] has quit [Ping timeout: 245 seconds]
23:36 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
23:59 -!- promag [~promag@92.250.97.46] has joined #bitcoin-core-dev
--- Log closed Fri Aug 16 00:00:42 2019