--- Log opened Thu Aug 29 00:00:54 2019
00:05 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Quit: jonatack]
00:09 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
00:10 -!- ykns [~yax@85.203.46.58] has quit [Ping timeout: 245 seconds]
00:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:13 < bitcoin-git> [bitcoin] sipsorcery opened pull request #16750: msbuild: adds bench_bitcoin to auto generated project files (master...autogen_bench) https://github.com/bitcoin/bitcoin/pull/16750
00:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:16 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
00:18 -!- Lord1 [~Lord@195.206.169.238] has joined #bitcoin-core-dev
00:24 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
00:26 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
00:35 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
00:39 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
00:48 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
00:55 -!- lalitmee [~lalitmee@106.51.71.179] has quit [Ping timeout: 268 seconds]
01:05 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
01:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:10 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
01:20 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer]
01:35 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:38 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
01:39 -!- lalitmee [~lalitmee@106.51.71.179] has joined #bitcoin-core-dev
01:39 -!- jonatack [~jon@213.152.161.138] has joined #bitcoin-core-dev
01:41 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
01:46 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
02:00 -!- Lord1 [~Lord@195.206.169.238] has quit []
02:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
02:02 -!- jonatack [~jon@213.152.161.138] has quit [Ping timeout: 272 seconds]
02:06 -!- jonatack [~jon@abayonne-654-1-57-120.w86-222.abo.wanadoo.fr] has joined #bitcoin-core-dev
02:06 -!- jonatack [~jon@abayonne-654-1-57-120.w86-222.abo.wanadoo.fr] has quit [Client Quit]
02:08 -!- jonatack [~jon@109.232.227.133] has joined #bitcoin-core-dev
02:17 -!- pwgn [~pwgn@184.75.223.235] has joined #bitcoin-core-dev
02:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:25 < bitcoin-git> [bitcoin] michaelfolkson opened pull request #16752: doc: Replace stale URL in test README with alternative Boost resource (master...20190829-boost-url) https://github.com/bitcoin/bitcoin/pull/16752
02:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:26 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
02:29 -!- Victor_sueca is now known as Victorsueca
02:33 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:37 < wumpus> fanquake: I guess the idea was to do 0.17.2 soon
02:37 < fanquake> wumpus: Yes I think so.
02:37 < wumpus> is 16638 held up on me?
02:38 < fanquake> wumpus: It probably needs your sign-off / look over again. 
02:38 < wumpus> okay!
02:38 < fanquake> I re-pulled some translations, but nothing major.
02:43 < wumpus> it looks good to me
02:46 < fanquake> wumpus: 👍
02:53 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
02:54 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
02:54 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
02:56 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
02:56 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:57 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 272 seconds]
02:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:59 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to 0.17: https://github.com/bitcoin/bitcoin/compare/c165df198d6e...01a1537fe02d
02:59 < bitcoin-git> bitcoin/0.17 b4472f5 fanquake: build: bump version to 0.17.2
02:59 < bitcoin-git> bitcoin/0.17 c56c9ad fanquake: doc: update manpages for 0.17.2
02:59 < bitcoin-git> bitcoin/0.17 6b42df8 fanquake: qt: 0.17.2 translation update
02:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:59 < bitcoin-git> [bitcoin] laanwj merged pull request #16638: [0.17] Release preparations for 0.17.2 (0.17...0-17-2-release-prep) https://github.com/bitcoin/bitcoin/pull/16638
02:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:02 < promag> kallewoof: ping
03:02 < provoostenator> Lol, the merge script caught an @ sjors because it was right behind an ACK: https://github.com/syscoin/syscoin/commit/ab294f70a18ea1141a26ec3d25ffb028ae4d9842
03:03 < promag> sorry provoostenator :/
03:03 < promag> there's always a corner case
03:04 -!- alin39 [4f770e0d@79.119.14.13] has joined #bitcoin-core-dev
03:04 < promag> kallewoof: for explicit fee modes conf_target should be required no?
03:05 < wumpus> promag: whoops
03:05 < wumpus> I mean, provoostenator
03:05 < wumpus> I don't think it checks there for @, no
03:06 < wumpus> likely it should :)
03:06 < provoostenator> Next time I'll just say: "ACK, don't at me"
03:06 < promag> it that case it should drop @
03:06 < wumpus> haha "be careful what you say after/before an ACK, the whole line will be in git history forever"
03:07 < wumpus> promag: yes, throwing away the @'s would likely be fine there
03:08 < fanquake> can't stop the spam
03:08 < wumpus> \o/
03:19 -!- jonatack [~jon@109.232.227.133] has quit [Ping timeout: 258 seconds]
03:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
03:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
03:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
03:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:27 < provoostenator> Now that the Github CEO has our ear, we could also just ask them to fix this.
03:28 < wumpus> I think they see it as a feature
03:28 < wumpus> it would be a useful per-user setting maybe, "don't notify me when my name appears in commits"
03:29 < wumpus> (thinking of it, their almost total lack of notification settings already came up before)
03:33 < provoostenator> They should also find a way to discourage recency-bias. The notifications page strongly pushes for a bias to reacting to new stuff
03:33 < provoostenator> The blue dot makes that worse
03:33 < wumpus> yes, though I think this is a problem with the whole internet
03:33 < provoostenator> Sure, fix the internet as well :-)
03:34 < provoostenator> In fact, I'd say it's human nature.
03:34 < wumpus> I mean, they use kind of default user conventions which don't get much thought
03:35 < wumpus> let's fix human nature, now you're talking xD
03:36 < TheHoliestRoger> is there a discussion open about algorithm/mining at all?
03:37 < TheHoliestRoger> just out of curiosity, i'm not trying to troll or shill anything
03:39 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
03:39 -!- kcalvinalvin [~calvin@211.216.14.199] has joined #bitcoin-core-dev
03:39 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer]
03:40 < wumpus> TheHoliestRoger: the bitcoin-dev mailing list archives would be the place to look for that
03:41 < TheHoliestRoger> thanks wumpus, is it a discussion still ongoing or is it put to bed?
03:41 -!- lightlike [~lightlike@2001:16b8:57fb:9000:4ddc:f363:a929:253c] has joined #bitcoin-core-dev
03:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
03:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
03:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
03:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:44 < wumpus> TheHoliestRoger: I'm sure people are still talking about it somewhere, but not sure anything changed for years regarding that
03:46 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:52 < TheHoliestRoger> wumpus: just been reading the list, i see various people trying to talk about eco friendly options but they're just met with resistance explaining the flaws rather than ideas of hwo to make it viable
03:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
03:52 < TheHoliestRoger> it's a shame, we can't keep doing this forever
03:53 < TheHoliestRoger> (i am all for btc btw, i'm just losing faith in cryptocurrency in general)
03:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:53 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fc5b756bae26...1f77c5c3e7c0
03:53 < bitcoin-git> bitcoin/master fa60583 MarcoFalke: ci: Pass down $MAKEJOBS to test_runner.py
03:53 < bitcoin-git> bitcoin/master fa27372 MarcoFalke: ci: Move CCACHE_DIR and test_runner tmp dir into ./ci/scratch/
03:53 < bitcoin-git> bitcoin/master 1f77c5c Wladimir J. van der Laan: Merge #16739: ci: Pass down $MAKEJOBS to test_runner.py, other improvement...
03:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:54 < wumpus> nothing can be done forever, things always change, circumstances always change, who says it's needed forever ? in any case, this is not the place for such discussions, the channel is for day-to-day development of the code base
03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:54 < bitcoin-git> [bitcoin] laanwj merged pull request #16739: ci: Pass down $MAKEJOBS to test_runner.py, other improvements (master...1908-ciScratch) https://github.com/bitcoin/bitcoin/pull/16739
03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:55 < TheHoliestRoger> fair enough, apologies
03:55 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
03:59 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
04:05 < promag> feature_block.py keeps failing
04:06 < fanquake> promag: also #16744
04:06 < gribble> https://github.com/bitcoin/bitcoin/issues/16744 | test: feature_block exits successfully even on failure · Issue #16744 · bitcoin/bitcoin · GitHub
04:07 < promag> ah
04:09 < fanquake> hebasto: What looks wrong in #16752? Looks fine to me?
04:09 < gribble> https://github.com/bitcoin/bitcoin/issues/16752 | doc: Delete stale URL in test README by michaelfolkson · Pull Request #16752 · bitcoin/bitcoin · GitHub
04:09 < promag> can someone chime in #16285
04:09 < gribble> https://github.com/bitcoin/bitcoin/issues/16285 | rpc: Improve scantxoutset response and help message by promag · Pull Request #16285 · bitcoin/bitcoin · GitHub
04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:10 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f77c5c3e7c0...aca76b9ee89e
04:10 < bitcoin-git> bitcoin/master 2e1455c Hennadii Stepanov: Replace obsolete functions of QSslSocket
04:10 < bitcoin-git> bitcoin/master aca76b9 Wladimir J. van der Laan: Merge #16708: qt: Replace obsolete functions of QSslSocket
04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:11 < bitcoin-git> [bitcoin] laanwj merged pull request #16708: qt: Replace obsolete functions of QSslSocket (master...20190824-obsolete-qssl) https://github.com/bitcoin/bitcoin/pull/16708
04:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:15 -!- kcalvinalvin [~calvin@211.216.14.199] has quit [Ping timeout: 248 seconds]
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:16 < bitcoin-git> [bitcoin] laanwj closed pull request #16381: Set minimum required Boost to 1.53.0 (master...20190713-bump-minimum-boost) https://github.com/bitcoin/bitcoin/pull/16381
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:16 -!- kcalvinalvin [~calvin@203.234.129.229] has joined #bitcoin-core-dev
04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:18 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aca76b9ee89e...b7ff38972c39
04:18 < bitcoin-git> bitcoin/master 41d484d Michael Folkson: doc: Delete stale URL in test README
04:18 < bitcoin-git> bitcoin/master b7ff389 fanquake: Merge #16752: doc: Delete stale URL in test README
04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:19 < bitcoin-git> [bitcoin] fanquake merged pull request #16752: doc: Delete stale URL in test README (master...20190829-boost-url) https://github.com/bitcoin/bitcoin/pull/16752
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:21 -!- kcalvinalvin [~calvin@203.234.129.229] has quit [Ping timeout: 268 seconds]
04:23 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
04:29 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:33 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7ff38972c39...dcfd85acb428
04:33 < bitcoin-git> bitcoin/master d53d591 Aaron Clauson: Added the bench_bitcoin project to the list automatically produced by the ...
04:33 < bitcoin-git> bitcoin/master dcfd85a fanquake: Merge #16750: msbuild: adds bench_bitcoin to auto generated project files
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:34 < bitcoin-git> [bitcoin] fanquake merged pull request #16750: msbuild: adds bench_bitcoin to auto generated project files (master...autogen_bench) https://github.com/bitcoin/bitcoin/pull/16750
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:35 -!- alin39 [4f770e0d@79.119.14.13] has quit [Remote host closed the connection]
04:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:40 < bitcoin-git> [bitcoin] theStack opened pull request #16753: wallet: extract PubKey from P2PK script with Solver (master...extractpubkey_with_solver) https://github.com/bitcoin/bitcoin/pull/16753
04:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:42 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:43 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
04:48 -!- lalitmee [~lalitmee@106.51.71.179] has quit [Remote host closed the connection]
04:49 < wumpus> FYI #16754, this has been dragging on for multiple releases, I think it's time to change to a new transifex org if this can't be resolves. So please: if anyone knows seone, or can contact them, let me know
04:49 < gribble> https://github.com/bitcoin/bitcoin/issues/16754 | Transifex organization issues · Issue #16754 · bitcoin/bitcoin · GitHub
04:50 < fanquake> #proposedmeetingtopic transifex org discussion
04:51 < fanquake> Just realised the meeting is tonight. Likely wont be there so someone else can discuss.
04:52 < wumpus> well can bring it up at least
04:53 < luke-jr> #proposedmeetingtopic macOS/GNOME developers pushing their UI on everyone else
04:54 < luke-jr> though I have to pick kids up at school during meeting as usual :x
04:54 -!- hhhhhhhhhhh [~awesome-d@183.129.132.171] has quit [Ping timeout: 268 seconds]
05:00 -!- pwgn [~pwgn@184.75.223.235] has quit []
05:01 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
05:02 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
05:05 < promag> luke-jr: imho we have so few menu items - in contrast to other apps like design/3d/video/music/word where the icons help moving fast - that icons don't really matter and they don't improve accessibility that much either
05:06 < luke-jr> promag: yet they are part of KDE/Windows UI design, and someone is willing to maintain them
05:07 < promag> yeah kde/win support icons but it's optional
05:08 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 248 seconds]
05:09 < promag> fwiw I don't care that much if icons are added back, but its like jonasschnelli said, there's a lot of ui/ux improvements and icons seem the wrong place to spend energy
05:10 < luke-jr> if nobody wants to do it, I don't care, but in fact someone does
05:10 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has joined #bitcoin-core-dev
05:10 < wumpus> it kind of only makes sense if it'd use icons from the system theme
05:11 < wumpus> bitcoin-qt using its own menu icons was kind of silly, and doesn't help at all with the purpose of icons to make things more familiar
05:11 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
05:13 < luke-jr> KDE HIG: "Provide icons for all menu items. Don’t re-use the same icon for multiple items."
05:13 < luke-jr> https://hig.kde.org/components/navigation/menubar.html
05:14 < wumpus> so now you're trying to push the KDE interface guidelines on everyone else, how is that better :)
05:14 < promag> energy spent bikeshedding UI by category: labels:1 layouts:10 colors:100 shortcuts:1000 icons:>9000
05:14 < luke-jr> wumpus: I imagine Qt has a way to get at theme icons
05:14 < wumpus> the GUI maintainer should make a decision about this
05:14 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 245 seconds]
05:14 < wumpus> and that's it, cant accomodate everyone
05:14 < luke-jr> wumpus: no, Qt adapts to macOS/GNOME themes as already noted
05:14 < promag> wumpus: I think he did
05:15 < wumpus> we're not going to reconsider this every time
05:15 < wumpus> promag: right
05:15 < luke-jr> promag: icons come up maybe once a year at most
05:15 < promag> luke-jr: they will come no more X)
05:16 < fanquake> https://github.com/bitcoin/bitcoin/pull/16729#issuecomment-524967201
05:17 -!- Lauwenmark [~Lauwenmar@192.145.126.115] has joined #bitcoin-core-dev
05:18 < promag> luke-jr: kidding.. I just think the common denominator and the least controversial choice is to have no icons 
05:18 < wumpus> no *menu* icons
05:18 < luke-jr> GUI maintainer forcing his particular platform's HIG on everyone else, is an abuse of position
05:18 < wumpus> I don't think anyone is arguing to remove all icons
05:19 < luke-jr> promag: people who don't want icons don't see them
05:20 < luke-jr> Qt deals with this already
05:21 < wumpus> it's just giving way too much discussion, especially if you'd want to follow the KDE guideline to have an icon for every item
05:22 < wumpus> I mean there was a PR disussing whether to use a box with an arrow or floppy for a save action
05:22 < luke-jr> then ignore those PRs..
05:22 < wumpus> how is that in any way conductvie to this project
05:22 < luke-jr> using theme icons will reduce that kind of debate too
05:22 < wumpus> it's just not worth it, I'm sure you'll want to do it differently in knots, that's fine :)
05:23 -!- jtimon [~quassel@76.85.11.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:23 < luke-jr> actually, I can't easily add icons to Knots because they're binary files and Core doesn't do SVGs.
05:24 < luke-jr> for some minor things, I have some tooling to render SVGs at build time, but doing it for all the menu icons would be sufficiently painful that I probably just won't
05:24 < wumpus> yes, I think using theme icons would be considerably better, the problem is that once you do that, you can only use theme icons because any custom ones will always conflict with the theme
05:25 < wumpus> I think it was even tried once to replace the icons by theme ones, but there were some issues, like the theme icons not being the same ones nor available on all platforms, it's not as easy and consistent as it sounds
05:26 < wumpus> but you're welcome to try, I mean, fall back to no icons if they're not available in the theme is fine I guess
05:26 < wumpus> (as this is basically to accomodate KDE now)
05:27 < luke-jr> Windows also
05:27 < wumpus> windows definitely has no theme icons
05:27 < wumpus> that's a linux distribution thing
05:29 < luke-jr> anyway, my point isn't to get into the details here - just to get past blocking it because their particular platform doesn't use it
05:32 < wumpus> I just mean: if you can make a  patch to add back icons for KDE, taken from the theme, so it doesn't have to clutter the repo nor generate discussion about particular icons, it'll probably be an easy ACK for me
05:33 < wumpus> if ont, it's not worth discussing
05:38 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
05:38 -!- gelmutshmidt [~gelmutshm@188.113.6.134] has joined #bitcoin-core-dev
05:42 < luke-jr> looks like Qt supports Windows icons too: https://doc.qt.io/archives/qt-4.8/qstyle.html#StandardPixmap-enum
05:42 < luke-jr> hopefully QIcon::fromTheme can handle it by now :/
05:50 -!- jonatack [~jon@abayonne-654-1-57-120.w86-222.abo.wanadoo.fr] has joined #bitcoin-core-dev
05:51 -!- jonatack [~jon@abayonne-654-1-57-120.w86-222.abo.wanadoo.fr] has quit [Client Quit]
05:51 -!- jonatack [~jon@abayonne-654-1-57-120.w86-222.abo.wanadoo.fr] has joined #bitcoin-core-dev
05:54 < jonasschnelli> Are we really having ultra long discussions about icon? Most users are not willing to run core because of fundamental UX issues.
05:54 < jonasschnelli> *icons*
05:55 < wumpus> I agree, for example that it still hangs the GUI thread while syncing
05:55 < jonasschnelli> Yes.
05:56 < jonasschnelli> Or that most systems are basically not usable with default configurations during IBD (due to maximising usage of system resources)
05:56 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
05:56 < jonasschnelli> Bring the icons back, I don't care.
05:57 < jonasschnelli> But don't expect that users will use or not-use core because of that.
05:57 < fanquake> Core running on a *fairly* powerful macbook is just about unusable during IBD. Constant beachballing / lag in the GUI.
05:57 < fanquake> jonasschnelli: I'm also in agreement with you.
05:58 < luke-jr> the guy working on icons, isn't capable of lag stuff AFAICT
05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:58 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dcfd85acb428...d20d171f26c2
05:58 < bitcoin-git> bitcoin/master 1260ecd Hennadii Stepanov: qt: Add TextWidth() wrapper
05:58 < bitcoin-git> bitcoin/master c6dd32d Hennadii Stepanov: qt: Replace obsolete functions of QDesktopWidget
05:58 < bitcoin-git> bitcoin/master d20d171 Wladimir J. van der Laan: Merge #16701: qt: Replace functions deprecated in Qt 5.13
05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:59 < bitcoin-git> [bitcoin] laanwj merged pull request #16701: qt: Replace functions deprecated in Qt 5.13 (master...20190823-qt13-deprecated) https://github.com/bitcoin/bitcoin/pull/16701
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:59 < wumpus> luke-jr: maybe, but it elevates the noise thrshold for everyone, I think it is good to take away things that create a culture in the project of bikeshedding
06:01 < luke-jr> maybe a separate UX-specific repo that UX-concerned people can work at, with a per-release PR to the main repo?
06:03 < wumpus> I don't think anyone is interested in going that far
06:04 < wumpus> I mean, I'm not against anyone doing that, if they can make it work, but it seems a lot of coordination and work for something pretty far down the ladder of concerns for the project overall
06:05 < wumpus> (I remember something like that was tried for "trivial" PRs once, like those that fix typos in comments and such, but it broke down pretty quickly)
06:06 < wumpus> anyhow, if someone *would* solve long running, fundamental issues like the UI lag issue I'd be very inclined to pay more heed to their ideas about icons as well :)
06:07 < luke-jr> seems like two things at fundamentally different skill levels :/
06:07 < wumpus> it's true, but one is a path toward UI maintainer, the other is not, I mean
06:07 < luke-jr> already too many people get the impression contributing to Core requires high skill
06:08 < promag> not "different skill levels", just "different skills"
06:08 < wumpus> sure, and that again is still a very different kind of skill than say, contributing to consensus code
06:09 < promag> good icons are made by skilled designers
06:09 < wumpus> this isn't about icon design really
06:11 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
06:12 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: No route to host]
06:12 -!- promag [~promag@2.80.22.20] has joined #bitcoin-core-dev
06:13 < wumpus> I thnk if you'd really want a designer involved with bitcoin's gui you'd want to start from the top, the layout and such, not from minimal things like the icons ... but usability is more important than design that's clear, it's what people actually struggle with now
06:15 < promag> it's what people actually struggle with now -> is there a place to see the complaints?
06:15 < wumpus> heck even the developers stuggle with the lag issue
06:16 < wumpus> anyhow I"m tired of this, no longer going to argue, it just goes on and on and on
06:16 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
06:17 < jonasschnelli> Regardless of icons yes or now. There is a very low probability that we revert something we jjust got 7 acks for. That's the reason why I closed the PR.
06:17 < wumpus> yes
06:18 < jonasschnelli> If one has a new approach, better, that is not just reverting a 7-ack PR, bring it!
06:18 < promag> regarding UI lag -> #16261 
06:18 < gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
06:18 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
06:18 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
06:18 < jonasschnelli> Everything else is a waste of everyones time
06:18 < jonasschnelli> Thanks promag: will test asap
06:18 < fanquake> yes I should review that, givens it's also the base of create wallet
06:19 -!- gelmutshmidt [~gelmutshm@188.113.6.134] has quit [Remote host closed the connection]
06:19 < promag> jonasschnelli: well maybe after 0.19?
06:19 < promag> or createwallet if for 0.19?
06:19 < promag> *is for
06:20 < fanquake> it should be for 0.19.0
06:20 < jonasschnelli> Lets try.
06:20 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
06:21 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
06:24 < promag> MarcoFalke: why does DrahtBot makes links that redirect?
06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:25 < bitcoin-git> [bitcoin] GChuf opened pull request #16755: [0.17.2] Fix translations (0.17...0.17.2.fix) https://github.com/bitcoin/bitcoin/pull/16755
06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:27 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
06:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
06:29 < tryphe> jonasschnelli, personally i'm not even sure why icons even matter when most of the gui UX seems in infacy still. to me it's a stylistic but non-functional change, sorta like changing a bunch of code from snake case to camel case because it looks cooler for some undetermined minority.
06:30 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
06:30 < jonasschnelli> Yeah
06:30 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
06:30 < wumpus> tryphe: I think we yet again all agree except for luke-jr :)
06:30 < jonasschnelli> I vaguely remember luke-jr did also raise concerns when we change the icon to the bw-icons back in 2013.
06:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
06:32 -!- Giszmo [~leo@2407:7000:9d28:5100:8de1:da9d:15e7:2581] has quit [Read error: Connection reset by peer]
06:32 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
06:34 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has joined #bitcoin-core-dev
06:36 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
06:36 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds]
06:37 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
06:39 < tryphe> wumpus, jonasschnelli: and on the topic of accessbility, i don't think icons ultimately matter too much since there are already accessibility tools offered by most OS. for example, if the person has dyslexia, there's already fonts out there for that. and if they are blind they could use Linux Screen Reader. 
06:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:39 < bitcoin-git> [bitcoin] laanwj closed pull request #15965: check bad-prevblk is right error for invalid descendants (master...bad-prevblk) https://github.com/bitcoin/bitcoin/pull/15965
06:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:44 < jonasschnelli> tryphe: if one can't read the text next to icons, how should one manage to send or receive coins?
06:44 < jonasschnelli> :-)
06:45 < jonasschnelli> (I mean without further accessibility tools like screen readers, etc.)
06:46 < tryphe> jonasschnelli, yeah, and Qt is extensible enough to where even if they couldn't read the text, they could modify their OS settings so they can (assuming they know how to read)
06:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:47 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d20d171f26c2...1f8378508acf
06:47 < bitcoin-git> bitcoin/master d75e704 Jonas Schnelli: Add log output during initial header sync
06:47 < bitcoin-git> bitcoin/master 1f83785 Wladimir J. van der Laan: Merge #15615: Add log output during initial header sync
06:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:48 < bitcoin-git> [bitcoin] laanwj merged pull request #15615: Add log output during initial header sync (master...2019/03/hdr_sync) https://github.com/bitcoin/bitcoin/pull/15615
06:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:48 < tryphe> jonasschnelli, there's even this checklist which doesn't even mention icons: https://doc.qt.io/qt-5/accessible.html
06:49 < tryphe> to me, something much better would be supporting something like QAccessibleActionInterface
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.17: https://github.com/bitcoin/bitcoin/compare/01a1537fe02d...ed65d1483466
06:50 < bitcoin-git> bitcoin/0.17 b30b713 GChuf: [0.17.2] Fix translations
06:50 < bitcoin-git> bitcoin/0.17 ed65d14 Wladimir J. van der Laan: Merge #16755: [0.17.2] Fix translations
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:51 < bitcoin-git> [bitcoin] laanwj merged pull request #16755: [0.17.2] Fix translations (0.17...0.17.2.fix) https://github.com/bitcoin/bitcoin/pull/16755
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:52 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:52 < bitcoin-git> [bitcoin] mzumsande opened pull request #16756: test: Connection eviction ligc tests (master...201908_test_eviction) https://github.com/bitcoin/bitcoin/pull/16756
06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:53 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
06:55 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-kuancgppawrpwrow] has quit [Ping timeout: 248 seconds]
06:56 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
06:58 -!- Deadhand [~deadhand@kntaon1614w-grc-09-74-15-95-144.dsl.bell.ca] has quit [Ping timeout: 248 seconds]
07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:00 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f8378508acf...75142ece6b66
07:00 < bitcoin-git> bitcoin/master 9e0c1d6 Hennadii Stepanov: qt: Remove QSignalMapper from RPCConsole
07:00 < bitcoin-git> bitcoin/master 0912134 Hennadii Stepanov: qt: Remove QSignalMapper from TransactionView
07:00 < bitcoin-git> bitcoin/master 75142ec Wladimir J. van der Laan: Merge #16706: qt: Replace deprecated QSignalMapper by lambda expressions
07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:01 < bitcoin-git> [bitcoin] laanwj merged pull request #16706: qt: Replace deprecated QSignalMapper by lambda expressions (master...20190824-obsolete-qsignalmapper) https://github.com/bitcoin/bitcoin/pull/16706
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:01 -!- Deadhand [~deadhand@kntaon1614w-grc-09-74-15-95-144.dsl.bell.ca] has joined #bitcoin-core-dev
07:01 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
07:01 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-lscjehmtoqorwlyv] has joined #bitcoin-core-dev
07:04 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 260 seconds]
07:19 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
07:24 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
07:25 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
07:36 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
07:38 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
07:39 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-qoablqmrrerdoldj] has joined #bitcoin-core-dev
07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:42 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75142ece6b66...d8fc9979130a
07:42 < bitcoin-git> bitcoin/master d48c1e8 Jonathan "Duke" Leto: Add window final block height to getchaintxstats
07:42 < bitcoin-git> bitcoin/master d8fc997 Wladimir J. van der Laan: Merge #16695: rpc: Add window final block height to getchaintxstats
07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:43 < bitcoin-git> [bitcoin] laanwj merged pull request #16695: rpc: Add window final block height to getchaintxstats (master...getchaintxstats_height) https://github.com/bitcoin/bitcoin/pull/16695
07:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:44 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 260 seconds]
07:49 -!- xzytrewq [~quassel@199.58.187.147] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
07:49 -!- profmac [~ProfMac@2001:470:1f0f:226:b176:78f7:894f:24cf] has joined #bitcoin-core-dev
07:59 -!- jonatack [~jon@abayonne-654-1-57-120.w86-222.abo.wanadoo.fr] has quit [Ping timeout: 245 seconds]
08:00 -!- Lauwenmark [~Lauwenmar@192.145.126.115] has quit []
08:14 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Quit: WeeChat 2.4]
08:16 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
08:17 -!- justMaD [~justMaD@139.28.218.198] has joined #bitcoin-core-dev
08:29 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:36 -!- alko [~alko@BSN-77-147-172.static.siol.net] has quit [Ping timeout: 272 seconds]
08:44 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has quit [Quit: Leaving.]
08:50 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:05 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16757: doc: ActivateBestChainStep return value (master...1909-docValABCS) https://github.com/bitcoin/bitcoin/pull/16757
09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:05 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev
09:13 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
09:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:27 < bitcoin-git> [bitcoin] hebasto opened pull request #16758: qt: Replace QFontMetrics::width() with TextWidth() (master...20190829-pr16701-followup) https://github.com/bitcoin/bitcoin/pull/16758
09:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:28 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
09:30 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]
09:30 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev
09:34 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 260 seconds]
09:35 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
09:35 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:36 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d8fc9979130a...bcf7004a8945
09:36 < bitcoin-git> bitcoin/master c536677 Hennadii Stepanov: qt: Remove obsolete QModelIndex::child()
09:36 < bitcoin-git> bitcoin/master bcf7004 Jonas Schnelli: Merge #16707: qt: Remove obsolete QModelIndex::child()
09:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:37 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #16707: qt: Remove obsolete QModelIndex::child() (master...20190824-qmodelindex-child) https://github.com/bitcoin/bitcoin/pull/16707
09:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:38 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:50 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds]
09:55 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
09:55 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
09:55 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
09:56 -!- seeder [uid377087@gateway/web/irccloud.com/x-qndftaijbvbcovpu] has joined #bitcoin-core-dev
10:05 -!- Highway62 [~Thunderbi@96.44.189.130] has joined #bitcoin-core-dev
10:05 -!- Highway61 [~Thunderbi@ip184-186-21-239.no.no.cox.net] has quit [Ping timeout: 245 seconds]
10:05 -!- Highway62 is now known as Highway61
10:14 -!- emilengler_ is now known as emilengler
10:22 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
10:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:33 < bitcoin-git> [bitcoin] emilengler opened pull request #16759: doc: Fix table syntax (master...2019-08-bitcoin-conf-table) https://github.com/bitcoin/bitcoin/pull/16759
10:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:34 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:44 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 248 seconds]
10:51 -!- kcalvina_ [~calvin@223.62.22.220] has joined #bitcoin-core-dev
10:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds]
10:54 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
10:55 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Ping timeout: 245 seconds]
10:59 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
11:00 -!- justMaD [~justMaD@139.28.218.198] has quit []
11:01 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection]
11:15 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:17 -!- derek1 [~derek@141.98.102.235] has joined #bitcoin-core-dev
11:30 < warren> FYI ... libfaketime-0.9.8 is released upstream. It works with newer glibc Linux distros out of the box. But ppc64le and aarch64 require you to build it with non-default flags to use different ifdefs in order to workaround issues. Upstream lacks automake/autoconf so it can't detect if it needs those ifdefs are needed automatically.
11:33 < wumpus> we don't build faketime from source, do we? at least not in depends
11:34 < warren> dunno, we blindly using the version in Ubuntu? we should build it ourselves because it intercepts a bunch of syscalls during build
11:35 < wumpus> I don't think that matters for gitian, maybe for guix
11:38 < warren> dongcarl: let me know when libfaketime is being updated for guix, due to the lack of auto* tooling it needs different build flags for different archs =(
11:39 < dongcarl> warren: We don't need libfaketime at all for guix
11:39 < warren> dongcarl: oh, good.
11:40 -!- unawake [~unawake@184-23-190-229.vpn.dynamic.sonic.net] has joined #bitcoin-core-dev
11:40 < dongcarl> maybe for the win/osx builds tho, still working thru windows
11:41 < wumpus> oh that's very good
11:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:42 < wumpus> with tools becoming deterministic, the need for faketime should be less and less
11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:50 < bitcoin-git> [bitcoin] GChuf opened pull request #16760: [qt] Change uninstall icon on Windows (master...uninstall-icon) https://github.com/bitcoin/bitcoin/pull/16760
11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:54 < dongcarl> wumpus: for sure! Also standardization of `SOURCE_DATE_EPOCH` should help a bunch too
11:56  * warren grumble ... libfaketime is broken if your glibc is too new
11:58 < wumpus> oh no not another icon PR
11:58 < wumpus> oh it's simply a setting, phew :<
11:59 -!- iamtimmarchant [~iamtimmar@2600:380:6b13:fe05:a483:ca18:6c83:331] has joined #bitcoin-core-dev
12:00 < wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu Aug 29 19:00:21 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < jonasschnelli> hi
12:00 < kanzure> hi
12:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
12:00 < sipa> hi
12:00 < achow101> hi
12:00 < meshcollider> hi
12:00 < jeremyrubin> hi
12:01 < phantomcircuit> hi
12:01 < wumpus> no proposed topics in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a, anyone have any last minute topics?
12:01 < meshcollider> wumpus isn't invisible this week \o/
12:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
12:01 < jtimon> hi
12:01 < wumpus> meshcollider: hah
12:01 < wumpus> I have one about #16754
12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/16754 | Transifex organization issues · Issue #16754 · bitcoin/bitcoin · GitHub
12:02 < dongcarl> fanquake: Are you here?
12:02 < wumpus> #topic High priority for review
12:02 < wumpus> https://github.com/bitcoin/bitcoin/projects/8  5 blockers, 6 chasing concept ACK
12:02 < provoostenator> hi
12:03 < wumpus> anything to add/remove, or ready for merge?
12:03 < dongcarl> Can we add #16392
12:03 < provoostenator> #15450
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16392 | WIP build: macOS toolchain update by fanquake · Pull Request #16392 · bitcoin/bitcoin · GitHub
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15450 | [GUI] Create wallet menu option by achow101 · Pull Request #15450 · bitcoin/bitcoin · GitHub
12:04 < wumpus> I don't think adding a WIP PR makes sense?
12:04 < wumpus> it's either WIP or ready for review, not both
12:04 < wumpus> or do you mean to chasing concept ACK?
12:04 < provoostenator> Although achow101 already has a PR...
12:04 < dongcarl> Yeah chasing concept ACK
12:05 < dongcarl> Would like some discussion around updating the OS X SDK
12:05 < warren> hi
12:06 < wumpus> provoostenator: well you're proposing this one and you don't have one of your own so I guess that's okay
12:07 < provoostenator> Awesome. It reduces the rebase hell I'm in for hardware wallet GUI.
12:07 < provoostenator> And it's pretty much done anyway
12:08 < wumpus> great !
12:09 < wumpus> #topic Transifex organization issues
12:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:09 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
12:09 < wumpus> so basically I don't have full access to the organization under which bitcoin core's translations are, on transifex
12:10 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
12:10 < wumpus> none of us has, only the person who orignally created it, 'seone', does anyone perhaps know them?
12:10 < wumpus> #16754
12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/16754 | Transifex organization issues · Issue #16754 · bitcoin/bitcoin · GitHub
12:10 < jonasschnelli> Could contacting transiflex eventually help?
12:11 < jonasschnelli> They may help in such cases when the administrator left...
12:11 < sipa> never heard of that person
12:11 < wumpus> I don't know, my proposal is to move the translations to the bitcoincore org, which already has the website translations
12:11 < wumpus> or at least, create them there starting with 0.19
12:11 < jonasschnelli> would loosing contributors be a problem? or any other downside when moving to bitcoincore?
12:11 < sipa> well would there be any overhead from the transition?
12:11 < wumpus> contacting transifex might help, but may take a long time to resolve
12:12 < wumpus> we're losing contributors now because I don't have access to the team page
12:12 < wumpus> and can't set language coordinators andsuch
12:12 < jonasschnelli> Oh. Good point.
12:12 -!- kcalvina_ [~calvin@223.62.22.220] has quit [Remote host closed the connection]
12:12 < jonasschnelli> ack on moving from my side
12:12 < provoostenator> ACK on moving or starting from scratch
12:13 -!- pinheadmz [~matthewzi@181.215.110.149] has joined #bitcoin-core-dev
12:13 < wumpus> I had hoped someone simply knew seone, I've tried contacting them through the site a few times but I think their last activity was in 2017 or so
12:13 < meshcollider> You could contact transifex and just give it 3 days or so just to see what happens without waiting forever
12:13 < wumpus> not aware of any IRC or github nicks
12:13 < warren> In the past I knew the owner of Transifex personally but we haven't talked for years, maybe I can get his attention now.
12:14 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev
12:14 < wumpus> oh someone on the inside of transifex would also help
12:14 -!- jamesob [sid180710@gateway/web/irccloud.com/x-qvrdpfkaojpaouet] has left #bitcoin-core-dev []
12:14 < warren> let's set a timeout, if we can't get help by _______ then we move 
12:14 -!- jamesob [sid180710@gateway/web/irccloud.com/x-qvrdpfkaojpaouet] has joined #bitcoin-core-dev
12:14 < wumpus> the problem is that 0.19 translations are supposed to open in 3 days
12:15 < wumpus> so that means we skip this for 0.19, which is fine, I guess we can mess around as we did for another release
12:17 < wumpus> so are you sure enough this will work warren that it's worth that?
12:17 < warren> wumpus: I don't know, I haven't tried to talk to him for many years now. Transifex started as a Fedora project over a decade ago, that's how I know him.
12:17 < wumpus> oh!
12:17 < warren> actually we talked maybe 4 years ago
12:18 < warren> would it be a pain to move to the other org? would it confuse people?
12:18 < wumpus> that's longer ago than when I talked to seone :-)
12:18 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Ping timeout: 246 seconds]
12:18 < provoostenator> So we wait 3 days to see if move can happy quckly, otherwise do 0.19 from a fresh account (maybe a day or two delayed)?
12:19 < wumpus> nah, could just throw a notification in the old organisation that the translations have opened, in another place
12:19 < provoostenator> Given that we have to handle backports for a while, it's nice to do 0.19 the righ tway
12:19 < wumpus> I think a notification on transifex results in a mail for everyone that participates
12:20 < wumpus> but yes, let's wait a week then
12:20 < warren> wumpus: it's thursday now. if I can't get a response by end of Friday then assume we won't get an answer in time and plan on moving?
12:20 < wumpus> any other topics?
12:20 < wumpus> warren: sounds good to me!
12:20 < warren> a week? OK i'll try
12:20 < wumpus> yeah it's not a problem to open the translation a few days later, that's definitely happened before
12:21 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:22 < wumpus> no other topics, going to close the meeting then, thanks everyone
12:23 < wumpus> #endmeeting
12:23 < lightningbot> Meeting ended Thu Aug 29 19:23:10 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:23 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-29-19.00.html
12:23 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-29-19.00.txt
12:23 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-29-19.00.log.html
12:25 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
12:27 < provoostenator> A made a PR on bitcoin.org to remove a few dead torrent trackers: https://github.com/bitcoin-dot-org/bitcoin.org/pull/3087
12:28 < provoostenator> It would be nice if Gitian / guix also generated that torrent file, in particular the info hash.
12:28 < wumpus> FWIW I don't use that script to generate the torrent anymore
12:28 < wumpus> it used to be that bitcoin.org automatically generated and seeded the torrent file
12:28 < wumpus> but that hasn't been the case for years
12:28 < provoostenator> Ah I figured it still worked that way
12:29 < wumpus> no, bitcoin.org is not even the preferred download site anymore
12:29 -!- belcher_ is now known as belcher
12:29 < provoostenator> I couldn't find an equivalent script on bitcoincore.org repo
12:29 < wumpus> there isn't one
12:29 < wumpus> bitcoincore.org doesn't generate the torrent file / magnet link, I do that myself
12:30 < wumpus> if you have an up to date list of trackers I'm happy to use them next time thogh
12:31 -!- iamtimmarchant [~iamtimmar@2600:380:6b13:fe05:a483:ca18:6c83:331] has quit [Remote host closed the connection]
12:33 < wumpus> this is what I've been using: https://gist.github.com/laanwj/dcc0f30d52fdeeed57689e1edf6cc7f5
12:34 < provoostenator> wumpus: zer0day.ch is gone
12:34 < provoostenator> The first 3 still work
12:35 < wumpus> this seems a useful list https://github.com/ngosang/trackerslist/blob/master/trackers_best.txt
12:35 < wumpus> thanks, will replace that one
12:36 < harding> On BitcoinCore.org, I can make the &tr=blah;&tr=blah part of the URI a part of the template so wumpus doesn't need to provide it and it can be updated across the whole site with just a +1/-1 diff.
12:37 < wumpus> harding: oh sounds like a good idea, ah yes for magnet URIs it's not encoded but simply appended to the URI
12:39 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-qoablqmrrerdoldj] has quit [Quit: Connection closed for inactivity]
12:39 < wumpus> though I'm not sure that will work 
12:39 < provoostenator> Also, as I pointed out in the github issue, I made my own tracker: udp://tracker.bitcoin.sprovoost.nl:6969  Happy to whitelist releases.
12:39 < wumpus> don't I have to announce to the trackers?
12:40 < wumpus> simply replacing the trackers in the URI, replacing them with others, might mean they don't know about it? (sorry I know very little about how torrent works so may be wrong)
12:40 < wumpus> provoostenator: let's use that one too then :)
12:41 < provoostenator> Thanks, just note that it's whitelisted, because I'm not in Pirate Bay mood.  So just ping me the info hash of each release.
12:42 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Ping timeout: 245 seconds]
12:42 < harding> wumpus: anyone who is seeding announces it to the trackers, I believe.
12:43 < harding> wumpus: oh, I see what you're saying.
12:44 -!- pinheadmz_ [~matthewzi@208.69.41.101] has joined #bitcoin-core-dev
12:44 < wumpus> I'm the initial seeder :)
12:44 < harding> Maybe we just keep doing it the current way.  Currently, BitcoinCore.org only shows the magnet for the latest version, so just updating the tracker list at each release (if any of them die) is probably fine.  There's no old magnet links with all dead trackers to worry about.
12:45 < provoostenator> I can seed them as well, but I set an obnoxious low upload speed limit.
12:45 -!- pinheadmz [~matthewzi@181.215.110.149] has quit [Ping timeout: 248 seconds]
12:45 -!- pinheadmz_ is now known as pinheadmz
12:45 -!- seeder [uid377087@gateway/web/irccloud.com/x-qndftaijbvbcovpu] has quit [Quit: Connection closed for inactivity]
12:46 < wumpus> I use a VPS with pretty fast network for seeding so it's ok
12:46 -!- Highway61 [~Thunderbi@96.44.189.130] has quit [Remote host closed the connection]
12:47 -!- Highway61 [~Thunderbi@96.44.189.130] has joined #bitcoin-core-dev
12:47 < wumpus> though it never hurts if more people do so
12:47 < wumpus> harding: agreed
12:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:48 < bitcoin-git> [bitcoin] emilengler opened pull request #16761: trivial: Add blockpause (master...2019-08-blockpause) https://github.com/bitcoin/bitcoin/pull/16761
12:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:51 < provoostenator> I use a VPS as well, but transmission only lets me configure a limit per second, not something more intelligent.
12:51 < provoostenator> An traffic shaping IP tables is a bit above my paygrade
12:54 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:54 -!- promag [~promag@2.80.22.20] has quit [Read error: Connection reset by peer]
12:58 < phantomcircuit> provoostenator, im not sure the download size is large enough to justify a torrent really
12:59 < wumpus> people use the torrent, it has existed since 2011 or so, there's no need to 'justify' it
12:59 < phantomcircuit> wumpus, im genuinely surprised anybody uses it
12:59 < wumpus> it's good to have alternative download places than one little server
13:00 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 248 seconds]
13:00 < provoostenator> They also have the nice property of having a single identifying hash
13:00 < provoostenator> Hency my suggestion to sign that in the gitian / guix process. 
13:00 < wumpus> also it gives you all the files at once, instead of having to download them one by one
13:01 < wumpus> I don't think that can work
13:01 < provoostenator> And most torrent clients let you pick which specific files you want, e.g. your own distro
13:01 < wumpus> the signature includes the torrent file, and the torrent file includes the hash
13:01 < wumpus> would create a circular dependency :)
13:02 < provoostenator> SegWit for torrents?
13:04 -!- Highway62 [~Thunderbi@96.44.189.130] has joined #bitcoin-core-dev
13:04 -!- Highway61 [~Thunderbi@96.44.189.130] has quit [Ping timeout: 248 seconds]
13:04 -!- Highway62 is now known as Highway61
13:05 < wumpus> heh
13:12 < fanquake> dongcarl: hello
13:17 < dongcarl> fanquake: got OSX into chasing concept ack
13:17 < dongcarl> If we don’t get some kind of consensus on the ticket perhaps we’ll bring it up as meeting topic sometime
13:18 < fanquake> dongcarl: 👍
13:18 -!- MasterdonX [~masterdon@5.226.137.20] has quit [Read error: Connection reset by peer]
13:19 -!- MasterdonX [~masterdon@5.226.137.20] has joined #bitcoin-core-dev
13:20 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
13:23 -!- BeautifulPeople [44866fec@pool-68-134-111-236.bltmmd.fios.verizon.net] has joined #bitcoin-core-dev
13:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:31 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16762: Rust-based Backup over-REST block downloader (master...2019-08-rusty-block-download) https://github.com/bitcoin/bitcoin/pull/16762
13:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:33 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:33 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Client Quit]
13:34 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:34 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Client Quit]
13:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
13:34 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:34 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
13:34 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Client Quit]
13:35 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:35 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Client Quit]
13:35 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:35 < provoostenator> Looks like big seeders do get (succesfully) attacked by copyright actors: https://torrentfreak.com/popular-zer0day-torrent-tracker-taken-offline-by-mass-copyright-complaint-171014/
13:36 < provoostenator> But ultimately what seems to matter is whether the VPS provider, and/or domain registrar has spine.
13:39 < provoostenator> Some of these trackers come and go without us even noticing :-) https://en.wikipedia.org/wiki/OpenBitTorrent
13:42 < provoostenator> OpenTracker (the tracker, not the software by the same name) has a whopping $1 / month Patreon support. That should help their  "goal is to create a torrent tracker that will stay alive"
13:44 < provoostenator> So we could probably use a few more bitcoin specific torrent trackers.
13:49 -!- unawake [~unawake@184-23-190-229.vpn.dynamic.sonic.net] has quit [Ping timeout: 245 seconds]
13:51 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
13:51 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 248 seconds]
13:58 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:00 -!- derek1 [~derek@141.98.102.235] has quit []
14:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
14:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:17 < warren> anyone know what is wumpus' transifex username?
14:17 -!- billstclair1 [~billstcla@192.145.126.115] has joined #bitcoin-core-dev
14:19 -!- chainhead [~chainhead@108.61.159.53] has quit [Ping timeout: 245 seconds]
14:22 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
14:23 < instagibbs> just a heads up, I've been granted merge permissions on HWI
14:24 -!- chainhead [~chainhead@2001:19f0:5:e14:5400:ff:fe77:e3d4] has joined #bitcoin-core-dev
14:25 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
14:26 < warren> found his transifex account name
14:30 -!- BeautifulPeople [44866fec@pool-68-134-111-236.bltmmd.fios.verizon.net] has quit [Remote host closed the connection]
14:35 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
14:40 < warren> Wrote e-mail to Transifex CEO. If I don't hear back by Monday I'll try to call and/or stop by their office nearby.
14:41 -!- thenry28 [~thenry28@97-92-244-143.dhcp.stls.mo.charter.com] has quit [Ping timeout: 246 seconds]
14:42 -!- thenry28 [~thenry28@97-92-244-143.dhcp.stls.mo.charter.com] has joined #bitcoin-core-dev
14:46 < warren> LOL he responded in our github ticket and already fixed now.
14:53 -!- thenry28 [~thenry28@97-92-244-143.dhcp.stls.mo.charter.com] has quit [Quit: Leaving]
15:16 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 260 seconds]
15:21 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
15:22 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 245 seconds]
15:28 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 245 seconds]
15:34 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
15:34 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:35 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
15:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
15:43 < meshcollider> Well that's very good news :)
15:43 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
15:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 246 seconds]
15:47 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
16:07 -!- pinheadmz [~matthewzi@208.69.41.101] has quit [Quit: pinheadmz]
16:09 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
16:10 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
16:34 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
16:35 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
16:44 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:47 -!- Giszmo [~leo@143.120.252.27.dyn.cust.vf.net.nz] has joined #bitcoin-core-dev
16:49 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
16:49 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 268 seconds]
16:54 -!- lightlike [~lightlike@2001:16b8:57fb:9000:4ddc:f363:a929:253c] has quit [Quit: Leaving]
16:57 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
17:00 -!- billstclair1 [~billstcla@192.145.126.115] has quit []
17:17 -!- limpkin1 [~limpkin@141.98.102.235] has joined #bitcoin-core-dev
17:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:29 < bitcoin-git> [bitcoin] fanquake closed pull request #16759: doc: Fix table syntax (master...2019-08-bitcoin-conf-table) https://github.com/bitcoin/bitcoin/pull/16759
17:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:32 < fanquake> instagibbs: hope you've got that merge script worked out
17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:47 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bcf7004a8945...74da99e01074
17:47 < bitcoin-git> bitcoin/master fa0b910 MarcoFalke: [doc] chain: Declare BLOCK_VALID_HEADER reserved
17:47 < bitcoin-git> bitcoin/master 74da99e fanquake: Merge #14862: doc: Declare BLOCK_VALID_HEADER reserved
17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:47 < bitcoin-git> [bitcoin] fanquake merged pull request #14862: doc: Declare BLOCK_VALID_HEADER reserved (master...Mf1812-validationDocBLOCK_VALID_HEADER) https://github.com/bitcoin/bitcoin/pull/14862
17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:49 < fanquake> meshcollider: Want to take a look at / merge #16753
17:49 < gribble> https://github.com/bitcoin/bitcoin/issues/16753 | wallet: extract PubKey from P2PK script with Solver by theStack · Pull Request #16753 · bitcoin/bitcoin · GitHub
17:54 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has joined #bitcoin-core-dev
17:54 -!- StopAndDecrypt_ [~StopAndDe@107.181.189.42] has quit [Ping timeout: 268 seconds]
17:56 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
17:56 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
17:57 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 272 seconds]
18:01 -!- Giszmo [~leo@143.120.252.27.dyn.cust.vf.net.nz] has quit [Quit: Leaving.]
18:06 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has joined #bitcoin-core-dev
18:10 < fanquake> Thanks sipa
18:16 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Ping timeout: 260 seconds]
18:18 -!- pinheadmz [~matthewzi@209.58.135.89] has joined #bitcoin-core-dev
18:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:20 < instagibbs> fanquake, im pretty much a pro don't worry
18:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
18:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:23 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74da99e01074...a8ecd0dadaab
18:23 < bitcoin-git> bitcoin/master 798a589 Sebastian Falbesoner: wallet: extract PubKey from P2PK script with Solver
18:23 < bitcoin-git> bitcoin/master a8ecd0d fanquake: Merge #16753: wallet: extract PubKey from P2PK script with Solver
18:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:23 < meshcollider> fanquake: Oh I was just about to review it haha
18:23 < meshcollider> 👍
18:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:23 < bitcoin-git> [bitcoin] fanquake merged pull request #16753: wallet: extract PubKey from P2PK script with Solver (master...extractpubkey_with_solver) https://github.com/bitcoin/bitcoin/pull/16753
18:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:25 < fanquake> meshcollider: hah sorry. If you still want something to review I'd suggest #16724 instead.
18:25 < gribble> https://github.com/bitcoin/bitcoin/issues/16724 | wallet: Remove redundant wpkh script import by bhinesley · Pull Request #16724 · bitcoin/bitcoin · GitHub
18:34 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
18:35 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
18:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:52 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev
19:02 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
19:06 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
19:08 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 245 seconds]
19:16 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
19:23 -!- Highway61 [~Thunderbi@96.44.189.130] has quit [Ping timeout: 272 seconds]
19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:28 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a8ecd0dadaab...f5db3f2128f0
19:28 < bitcoin-git> bitcoin/master 8b6f5aa Hennadii Stepanov: qt: Replace QFontMetrics::width() with TextWidth()
19:28 < bitcoin-git> bitcoin/master f5db3f2 fanquake: Merge #16758: qt: Replace QFontMetrics::width() with TextWidth()
19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:29 < bitcoin-git> [bitcoin] fanquake merged pull request #16758: qt: Replace QFontMetrics::width() with TextWidth() (master...20190829-pr16701-followup) https://github.com/bitcoin/bitcoin/pull/16758
19:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:34 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
19:35 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
19:36 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
19:42 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
19:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
19:45 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
19:46 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
19:47 -!- seeder [uid377087@gateway/web/irccloud.com/x-ywsexjegudqjeksz] has joined #bitcoin-core-dev
20:00 -!- limpkin1 [~limpkin@141.98.102.235] has quit []
20:13 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Remote host closed the connection]
20:21 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev
20:31 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
20:34 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
20:35 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
20:36 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
20:40 -!- tryphe_ is now known as tryphe
20:44 -!- wez [~wez@141.98.102.235] has joined #bitcoin-core-dev
20:45 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Ping timeout: 258 seconds]
20:57 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
21:01 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev
21:08 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
21:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 248 seconds]
21:12 -!- hhhhhhhhhhh [~awesome-d@183.129.132.171] has joined #bitcoin-core-dev
21:13 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Remote host closed the connection]
21:19 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 252 seconds]
21:31 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev
21:32 -!- xzytrewq [quassel@gateway/vpn/nordvpn/nptm] has joined #bitcoin-core-dev
21:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
21:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
21:36 -!- jtimon [~quassel@76.85.11.37.dynamic.jazztel.es] has quit [Ping timeout: 272 seconds]
21:43 -!- hhhhhhhhhhh [~awesome-d@183.129.132.171] has quit [Read error: Connection reset by peer]
21:43 -!- hhhhhhhhhhh [~awesome-d@183.129.132.171] has joined #bitcoin-core-dev
21:57 -!- seeder [uid377087@gateway/web/irccloud.com/x-ywsexjegudqjeksz] has quit [Quit: Connection closed for inactivity]
22:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
22:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
22:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
22:59 -!- Highway61 [~Thunderbi@96.44.189.130] has joined #bitcoin-core-dev
23:00 -!- wez [~wez@141.98.102.235] has quit []
23:00 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has joined #bitcoin-core-dev
23:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
23:16 -!- devdsp [~devdsp@141.98.102.235] has joined #bitcoin-core-dev
23:35 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
23:36 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 272 seconds]
23:36 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Client Quit]
23:55 -!- ExEric3 [~exeric3@dbox.reneunion.eu] has quit [Ping timeout: 252 seconds]
23:55 -!- ExEric3 [~exeric3@dbox.reneunion.eu] has joined #bitcoin-core-dev
23:56 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
--- Log closed Fri Aug 30 00:00:55 2019