--- Log opened Fri Sep 13 00:00:09 2019
00:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
00:08 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:10 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
00:11 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
00:19 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
00:23 -!- Victor_sueca is now known as Victorsueca
00:26 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
00:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds]
00:31 -!- ccdle12 [~ccdle12@83.219.62.136] has joined #bitcoin-core-dev
00:39 -!- kljasdfvv [~flack@p200300D46F0E78009053F7AE70D6ABED.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:03 -!- kcalvinalvin [~calvin@175.115.177.37] has joined #bitcoin-core-dev
01:11 -!- Giszmo [~leo@2407:7000:9d28:5100:d06e:7d80:bad7:22f7] has quit [Quit: Leaving.]
01:15 -!- Giszmo [~leo@2407:7000:9d28:5100:1501:e6d4:1652:9480] has joined #bitcoin-core-dev
01:15 -!- Giszmo [~leo@2407:7000:9d28:5100:1501:e6d4:1652:9480] has quit [Client Quit]
01:18 -!- ccdle12 [~ccdle12@83.219.62.136] has quit [Remote host closed the connection]
01:21 -!- ccdle12 [~ccdle12@83.219.62.136] has joined #bitcoin-core-dev
01:31 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:35 -!- ccdle12 [~ccdle12@83.219.62.136] has quit [Remote host closed the connection]
01:47 -!- kcalvinalvin [~calvin@175.115.177.37] has quit [Ping timeout: 245 seconds]
01:51 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:55 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has joined #bitcoin-core-dev
02:00 -!- dvratil [~dvratil@94.229.74.91] has quit []
02:01 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:17 -!- whartung1 [~whartung@141.98.102.235] has joined #bitcoin-core-dev
03:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
03:06 -!- ccdle12 [~ccdle12@92.40.248.154.threembb.co.uk] has joined #bitcoin-core-dev
03:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
03:10 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 276 seconds]
03:15 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
03:16 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
03:46 -!- kcalvinalvin [~calvin@175.115.177.37] has joined #bitcoin-core-dev
03:49 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds]
03:58 -!- ccdle12 [~ccdle12@92.40.248.154.threembb.co.uk] has quit [Remote host closed the connection]
04:03 -!- kcalvina_ [~calvin@175.115.177.37] has joined #bitcoin-core-dev
04:03 -!- kcalvinalvin [~calvin@175.115.177.37] has quit [Read error: Connection reset by peer]
04:18 -!- ccdle12 [~ccdle12@212.140.138.201] has joined #bitcoin-core-dev
04:20 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:20 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds]
04:34 -!- promag [~promag@92.250.103.134] has joined #bitcoin-core-dev
04:41 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
04:49 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 276 seconds]
04:51 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
04:53 < promag> what's blocking #16414 merge?
04:53 < gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
04:54 -!- ccdle12 [~ccdle12@212.140.138.201] has quit [Remote host closed the connection]
04:55 < promag> and #15204
04:55 < gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
05:00 -!- whartung1 [~whartung@141.98.102.235] has quit []
05:05 -!- kcalvina_ [~calvin@175.115.177.37] has quit [Ping timeout: 265 seconds]
05:09 -!- kcalvinalvin [~calvin@175.115.177.37] has joined #bitcoin-core-dev
05:17 -!- tadeo [~tadeo@141.98.102.235] has joined #bitcoin-core-dev
05:22 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:28 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Quit: jonatack]
05:30 -!- mutatrum [4d5ef728@40.247-94-77.subs.global-e.nl] has quit [Ping timeout: 260 seconds]
05:42 < promag> jonasschnelli, fanquake: take a look at #15204
05:42 < gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
05:42 < promag> thanks
05:56 -!- promag [~promag@92.250.103.134] has quit [Remote host closed the connection]
06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:16 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a199f7522589...102998ea03f6
06:16 < bitcoin-git> bitcoin/master 376f492 fanquake: build: disable BIP70 support by default
06:16 < bitcoin-git> bitcoin/master e09913f fanquake: doc: specify protobuf as optional in build docs
06:16 < bitcoin-git> bitcoin/master 102998e Wladimir J. van der Laan: Merge #15584: build: disable BIP70 support by default
06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:16 < bitcoin-git> [bitcoin] laanwj merged pull request #15584: build: disable BIP70 support by default (master...disable-bip70-by-default) https://github.com/bitcoin/bitcoin/pull/15584
06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:33 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/102998ea03f6...fb4f5beb6ede
06:33 < bitcoin-git> bitcoin/master f390d85 Steven Roose: Prevent UpdateTip log message from being broken up
06:33 < bitcoin-git> bitcoin/master fb4f5be Wladimir J. van der Laan: Merge #16854: Prevent UpdateTip log message from being broken up
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:33 < bitcoin-git> [bitcoin] laanwj merged pull request #16854: Prevent UpdateTip log message from being broken up (master...log-break-updatetip) https://github.com/bitcoin/bitcoin/pull/16854
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:59 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
07:00 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
07:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:27 < bitcoin-git> [bitcoin] darosior opened pull request #16863: NIT: Add a missing closing parenthesis in the bitcoin-wallet's help (master...bitcoin_wallet_nit) https://github.com/bitcoin/bitcoin/pull/16863
07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:41 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
07:42 -!- e4xit [~e4xit@95.211.225.220] has quit [Quit: WeeChat 2.5]
07:47 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-uoedvggqaregeizh] has joined #bitcoin-core-dev
07:55 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:55 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
07:57 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
08:00 -!- tadeo [~tadeo@141.98.102.235] has quit []
08:04 -!- tsujp [~tsujp@pa49-196-7-178.pa.vic.optusnet.com.au] has joined #bitcoin-core-dev
08:05 -!- tsujp [~tsujp@pa49-196-7-178.pa.vic.optusnet.com.au] has quit [Client Quit]
08:07 -!- willcl_ark [~quassel@95.211.225.220] has joined #bitcoin-core-dev
08:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:07 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.17: https://github.com/bitcoin/bitcoin/compare/40b47d539991...e149cbe5c790
08:07 < bitcoin-git> bitcoin/0.17 fb9bade fanquake: doc: integrate release notes from #16639
08:07 < bitcoin-git> bitcoin/0.17 e149cbe Wladimir J. van der Laan: Merge #16861: [0.17] doc: Remove release note fragment from #16639
08:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:07 < bitcoin-git> [bitcoin] laanwj merged pull request #16861: [0.17] doc: Remove release note fragment from #16639 (0.17...remove_release_note_fragment) https://github.com/bitcoin/bitcoin/pull/16861
08:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:12 < bitcoin-git> [bitcoin] instagibbs opened pull request #16864: Add python bech32 impl round-trip test (master...bech32_encode_test) https://github.com/bitcoin/bitcoin/pull/16864
08:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:14 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
08:19 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
08:20 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
08:29 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
08:30 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
08:30 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Read error: Connection reset by peer]
08:31 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
08:31 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev
08:44 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
08:45 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
08:47 -!- Leo_Verto1 [~Leo_Verto@192.145.126.115] has joined #bitcoin-core-dev
08:48 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
08:51 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 260 seconds]
08:52 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds]
08:53 -!- kljasdfvv [~flack@p200300D46F0E78009053F7AE70D6ABED.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:59 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
09:00 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
09:19 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
09:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
09:20 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
09:21 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:23 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
09:24 -!- face [~face@80.72.82.160.coresnet.bg] has quit [Ping timeout: 265 seconds]
09:29 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
09:30 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
09:32 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev
09:33 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:36 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
09:38 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has joined #bitcoin-core-dev
09:42 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:04 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:07 < bitcoin-git> [bitcoin] soroosh-sdi opened pull request #16865: test: add some unit tests for merkle.cpp (master...13-09-19-merkle-unit-tests) https://github.com/bitcoin/bitcoin/pull/16865
10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:08 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has quit [Quit: gone]
10:09 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 240 seconds]
10:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
10:27 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds]
10:37 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:37 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
10:38 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:40 -!- m1rror8 [~m1rror@91.177.121.173] has quit [Quit: The Lounge - https://thelounge.chat]
10:40 -!- m1rror8 [~m1rror@91.177.121.173] has joined #bitcoin-core-dev
10:47 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
10:55 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 246 seconds]
10:55 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has quit [Remote host closed the connection]
10:58 -!- yarwn [~yarwn@x4dbf730f.dyn.telefonica.de] has quit [Remote host closed the connection]
11:00 -!- Leo_Verto1 [~Leo_Verto@192.145.126.115] has quit []
11:17 -!- ByronT [~ByronT@139.28.218.198] has joined #bitcoin-core-dev
11:19 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
11:22 -!- santo [~santo@91.214.169.69] has joined #bitcoin-core-dev
11:28 -!- Highway62 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
11:29 -!- Highway61 [~Thunderbi@96.44.190.42] has quit [Ping timeout: 240 seconds]
11:29 -!- Highway62 is now known as Highway61
11:33 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
11:38 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
11:45 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
11:51 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
11:58 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
12:00 < meshcollider> #startmeeting
12:00 < lightningbot> Meeting started Fri Sep 13 19:00:33 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
12:00 < achow101> hi
12:00 < instagibbs> oh hi
12:01 < fanquake> hi
12:01 < meshcollider> Topics this week?
12:01 < jonatack> hi
12:01 < sipa> hi
12:01 < kanzure> hi
12:01 < instagibbs> Last minute feature pushes? :P 
12:01 < sipa> miniscript pretty please?
12:01 < jb55> hi
12:01 < achow101> let's merge #16341 :p
12:01  * sipa hides
12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
12:01 < instagibbs> sipa, haha
12:02 < instagibbs> oh yeah #16341: I'd really like that in in not forever. It's a lot of manual looking, but not hard to track imo
12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
12:02 < meshcollider> lol
12:02 < luke-jr> I have to go get kids at school, but how about #15987 
12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/15987 | Wallet, GUI: Warn when sending to already-used Bitcoin addresses by luke-jr · Pull Request #15987 · bitcoin/bitcoin · GitHub
12:03 < instagibbs> I kind of forgot to hound people for review before feature freeze, but #16727 is pretty easy
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16727 | wallet: Explicit feerate for bumpfee by instagibbs · Pull Request #16727 · bitcoin/bitcoin · GitHub
12:03 < achow101> luke-jr: feature freeze is probably too close for that
12:03 < meshcollider> #15204 is the only wallet PR tagged as 0.19 at the moment I think
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
12:05 < achow101> although, looking at it gives me an idea: what if we used a bloom filter for descriptor wallet ismine rather than generating and loading every scriptpubkey?
12:05 < meshcollider> Basically none of these PRs have any review yet so if you want one of these in, go review it :)
12:05 < instagibbs> false positives lol
12:05 < jonatack> meshcollider: PR #16822 is tagged for 0.19
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/16822 | gui: Create wallet menu option follow-ups by jonatack · Pull Request #16822 · bitcoin/bitcoin · GitHub
12:05 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
12:06 < sipa> achow101: or BIP158 filter
12:06 < sipa> achow101: you'd generate the bloom filter on the fly from the scriptPubKeys i guess, still?
12:06 < achow101> on second thought, it probably wouldn't work. we still need a map of scriptPubKeys to descriptor indexes in order to be able to get the keys to sign them
12:07 < sipa> and false positives are not a problem; you do a full check for every match
12:08 < achow101> is it really that much benefit to have both a filter and all of thes scriptpubkeys?
12:08 < sipa> it may be much faster
12:08 < sipa> though, that's a question for later
12:08 < achow101> yes
12:08 < sipa> just having an explicit set of scriptPubKeys to IsMineness will be much faster than the current IsMine logic already
12:09 < instagibbs> good point
12:09 < achow101> yes
12:10 < achow101> although now I kinda want to know how long it takes IsMine to check that 2 GB testnet wallet that may or may not still exist
12:12 < meshcollider> Just checking whether a key is in a map is not that slow is it?
12:12 < achow101> I think std::map is O(nlog(n))
12:13 < instagibbs> log(n) access...
12:13 < sipa> std::unordered_map is O(1) (ignoring the fact that pointer size eventually has to grow O(log n) with the size of the table)
12:14 < meshcollider> Yeah that's a hash map right sipa?
12:15 < achow101> instagibbs: oh right. std::map is log(n) everything
12:16 < meshcollider> So I think an unordered_map of your scriptPubKeys is efficient enough without worrying about filters or whatever 
12:18 < achow101> cool. I hadn't realized c++ actually provided a hash map
12:18 < tryphe> unordered map averages amort O(1) for operations, which can initially be O(n), but ordered map is always O(log n), so it really depends on how you use it.
12:18 < instagibbs> we're using chains of addresses we control, so hash collisions should be extremely rare?
12:18 < achow101> tryphe: it depends on whether there are collisions, no? or resizing, but size can be set initially
12:19 < achow101> not that it really matters, whatever we use will be faster than current IsMine
12:20 < tryphe> achow101, iirc, it does something to prevent collisions (maybe i am thinking of just QHash<>),, but i think you are right
12:22 < meshcollider> Yeah I think the O(n) is only the case where all n elements have the same hash and it has to linearly search through them all
12:22 < sipa> indeed
12:22 < achow101> let's just tell it to use sha256 :p
12:22 < sipa> we use salted siphash for hashmaps elsewhere
12:23 < instagibbs> more than sufficient considering wallet will control inputs
12:23 < sipa> which is just as good as sha256 truncated to 64 bit output
12:23 < instagibbs> (I think)
12:23 < achow101> instagibbs: people could import some weird shit
12:23 < instagibbs> SFTL :P
12:23 < achow101> actually, that wouldn't matter since each import would be its own scriptpubkeyman and thus have it's own map
12:24 < meshcollider> If people want to slow their own wallet down deliberately, let them :p
12:24 < instagibbs> actually it's a reasonable point, never know how people are going to use thew allet
12:25 < meshcollider> So anyway yeah in terms of PRs for 0.19, any other begs for review?
12:25 < meshcollider> Nothing seems particularly pushed-for at the moment
12:25 < meshcollider> And any other topics for today?
12:26 < achow101> any suggestions for having the gui inform the wallet that it's done loading transactions?
12:26 < achow101> context: the stuff I'm working on to not load every tx into memory
12:27 < achow101> the gui does some thing where it reads through every txout in order to build the transactions list. i would like it to not hammer the disk so it should do it when the transactions are initially loaded into the wallet before they are kicked out later
12:30 < meshcollider> It just does it once right
12:30 < achow101> yes
12:34 < meshcollider> I don't know off the top of my head but can't you do a callback thingy
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:35 < bitcoin-git> [bitcoin] jnewbery opened pull request #16866: [wallet] Rename 'decode' argument in gettransaction method to 'verbose' (master...2019-09-change-gettransaction-arg-name) https://github.com/bitcoin/bitcoin/pull/16866
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:36 < achow101> I guess I could just use a signal. there's some things with async that I'm not sure about (GUI has it's own thread, so may be ready before wallet is?)
12:38 < achow101> any other topics?
12:39 < meshcollider> Doesn't look like it :)
12:39 < meshcollider> #endmeeting
12:39 < lightningbot> Meeting ended Fri Sep 13 19:39:20 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:39 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-13-19.00.html
12:39 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-13-19.00.txt
12:39 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-13-19.00.log.html
12:40 < meshcollider> So yeah if you want 15204, 16727 or 16822 in 0.19, please go and review them
12:45 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
12:50 -!- captjakk [~captjakk@66.28.185.222] has joined #bitcoin-core-dev
12:51 -!- captjakk_ [~captjakk@178.128.232.240] has joined #bitcoin-core-dev
12:55 -!- captjakk [~captjakk@66.28.185.222] has quit [Ping timeout: 265 seconds]
13:02 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
13:03 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:04 -!- mdunnio_ [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:05 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
13:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:06 < bitcoin-git> [bitcoin] theuni opened pull request #16867: release: Update the Windows Codesigning certificate (0.17...0.17) https://github.com/bitcoin/bitcoin/pull/16867
13:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:07 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
13:07 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 245 seconds]
13:08 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
13:14 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Ping timeout: 240 seconds]
13:23 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev
13:37 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
13:38 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds]
13:38 -!- mdunnio_ [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
13:41 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-lwsfjsjibrnviswa] has quit [Remote host closed the connection]
13:41 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-gybjrodoxiatbsib] has quit [Write error: Connection reset by peer]
13:42 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-uvstfaxuyrfvxvkj] has quit [Read error: Connection reset by peer]
13:42 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-hoqrtctsfvrhjoua] has quit [Read error: Connection reset by peer]
13:42 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-zgdvhrfjpyblnzaz] has quit [Write error: Broken pipe]
13:45 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:48 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-smdvwykpdahznbgp] has joined #bitcoin-core-dev
13:55 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-mefmkxfcspwgrkbi] has joined #bitcoin-core-dev
13:55 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-akshkiaqrhkoyyye] has joined #bitcoin-core-dev
13:55 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-qozlxvhbseoglzzz] has joined #bitcoin-core-dev
13:55 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-pkiwoanzxhhesnep] has joined #bitcoin-core-dev
13:57 -!- Highway62 [~Thunderbi@104.129.29.42] has joined #bitcoin-core-dev
13:57 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Ping timeout: 240 seconds]
13:57 -!- Highway62 is now known as Highway61
14:00 -!- ByronT [~ByronT@139.28.218.198] has quit []
14:00 -!- santo [~santo@91.214.169.69] has quit [Quit: Leaving]
14:02 -!- Salve [~salve@2001:1948:212:b220:fd83:f726:154b:2d5b] has quit []
14:17 -!- JesusFreke [~JesusFrek@192.145.126.244] has joined #bitcoin-core-dev
14:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
14:26 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
14:27 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 265 seconds]
14:34 -!- tryphe_ is now known as tryphe
14:42 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:47 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
14:48 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
14:55 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
14:56 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
14:56 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
15:07 -!- goatpig [~goat@aaubervilliers-652-1-90-222.w83-114.abo.wanadoo.fr] has quit [Ping timeout: 265 seconds]
15:14 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
15:17 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:24 -!- captjakk_ [~captjakk@178.128.232.240] has quit [Remote host closed the connection]
15:30 -!- goatpig [~goat@aaubervilliers-652-1-90-222.w83-114.abo.wanadoo.fr] has joined #bitcoin-core-dev
15:30 < emilengler> How do I add a file to the autotools makefile?
15:33 < emilengler> Problem solved!
15:33 < emilengler> See src/Makefile.am
15:45 -!- Highway62 [~Thunderbi@104.129.29.42] has joined #bitcoin-core-dev
15:48 -!- Highway61 [~Thunderbi@104.129.29.42] has quit [Ping timeout: 264 seconds]
15:48 -!- Highway62 is now known as Highway61
15:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:55 < bitcoin-git> [bitcoin] emilengler opened pull request #16868: Add specific envvar system (master...2019-09-specific-envvar) https://github.com/bitcoin/bitcoin/pull/16868
15:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:17 < bitcoin-git> [bitcoin] kristapsk opened pull request #16869: Add missing walletconflicts to the help output of gettransaction and listtrasactions (master...help-walletconflicts) https://github.com/bitcoin/bitcoin/pull/16869
16:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:18 < bitcoin-git> [bitcoin] fanquake closed pull request #16869: Add missing walletconflicts to the help output of gettransaction and listtrasactions (master...help-walletconflicts) https://github.com/bitcoin/bitcoin/pull/16869
16:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:33 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-uoedvggqaregeizh] has quit [Quit: Connection closed for inactivity]
16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:37 < bitcoin-git> [bitcoin] fanquake opened pull request #16870: build: update boost macros to latest upstream for improved error reporting (master...pull_upstream_boost_m4) https://github.com/bitcoin/bitcoin/pull/16870
16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:39 -!- xzytrewq [~quassel@196.245.9.52] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
17:00 -!- JesusFreke [~JesusFrek@192.145.126.244] has quit []
17:16 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 246 seconds]
17:17 -!- nhandler1 [~nhandler@84.39.116.180] has joined #bitcoin-core-dev
17:20 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 240 seconds]
17:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
17:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
17:58 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 276 seconds]
18:05 -!- xzytrewq [~quassel@192.200.24.3] has joined #bitcoin-core-dev
18:45 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
19:00 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev
19:08 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 246 seconds]
19:13 -!- xzytrewq [~quassel@192.200.24.3] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
19:18 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
19:24 -!- kcalvinalvin [~calvin@175.115.177.37] has quit [Remote host closed the connection]
19:52 -!- StopAndDecrypt_ [~StopAndDe@107.181.189.36] has joined #bitcoin-core-dev
19:53 -!- joe_land1 [~joe_land1@pool-173-70-79-253.nwrknj.fios.verizon.net] has joined #bitcoin-core-dev
19:53 -!- joe_land1 [~joe_land1@pool-173-70-79-253.nwrknj.fios.verizon.net] has quit [Client Quit]
19:54 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 276 seconds]
20:00 -!- nhandler1 [~nhandler@84.39.116.180] has quit []
20:06 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has quit [Ping timeout: 246 seconds]
20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:13 < bitcoin-git> [bitcoin] fanquake opened pull request #16871: build: make building protobuf optional in depends (master...depends_no_protobuf_by_default) https://github.com/bitcoin/bitcoin/pull/16871
20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:15 < bitcoin-git> [bitcoin] fanquake closed pull request #15445: [0.17] backport #14409 (0.17...20190219-backport-pr14409) https://github.com/bitcoin/bitcoin/pull/15445
20:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:15 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
20:17 -!- xzytrewq [~quassel@192.200.24.3] has joined #bitcoin-core-dev
20:17 -!- ThunderChicken [~ThunderCh@141.98.102.235] has joined #bitcoin-core-dev
20:24 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
20:25 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
21:03 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has joined #bitcoin-core-dev
21:15 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has quit [Ping timeout: 276 seconds]
21:24 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
21:26 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds]
21:28 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev
21:31 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 276 seconds]
21:32 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
22:07 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
22:12 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
22:14 -!- davterra [~none@84.39.112.22] has quit [Remote host closed the connection]
22:22 -!- reallll is now known as belcher
23:00 -!- ThunderChicken [~ThunderCh@141.98.102.235] has quit []
23:08 -!- face [~face@80.72.82.160.coresnet.bg] has joined #bitcoin-core-dev
23:08 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
23:08 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
23:17 -!- dgilmore1 [~dgilmore@89.238.178.75] has joined #bitcoin-core-dev
23:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
23:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
23:49 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
23:50 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
23:51 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
23:52 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
23:53 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Quit: jb55]
23:54 -!- face [~face@80.72.82.160.coresnet.bg] has quit [Ping timeout: 246 seconds]
--- Log closed Sat Sep 14 00:00:10 2019