--- Log opened Tue Sep 17 00:00:14 2019 00:00 -!- rwang [uid386281@gateway/web/irccloud.com/x-todklpocqqzrtbyc] has quit [Quit: Connection closed for inactivity] 00:00 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Ping timeout: 276 seconds] 00:03 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 265 seconds] 00:03 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 00:03 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 00:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 00:11 -!- tryphe_ is now known as tryphe 00:24 -!- marcoagner [~user@2001:8a0:6a53:2e00:1967:22be:ad77:2d5] has joined #bitcoin-core-dev 00:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 276 seconds] 00:55 -!- promag [~promag@a89-152-187-241.cpe.netcabo.pt] has joined #bitcoin-core-dev 01:00 -!- promag [~promag@a89-152-187-241.cpe.netcabo.pt] has quit [Ping timeout: 265 seconds] 01:03 -!- jonatack [~jon@37.173.200.138] has joined #bitcoin-core-dev 01:12 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:15 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:18 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 01:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:27 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:4dd9:b7f:9c43:a846] has joined #bitcoin-core-dev 01:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:30 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 01:31 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 01:38 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:4dd9:b7f:9c43:a846] has quit [Quit: Sleep mode] 01:40 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 01:41 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 276 seconds] 01:43 -!- tryphe_ is now known as tryphe 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:45 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/92f35acb3ba0...f18a9065e911 01:45 < bitcoin-git> bitcoin/master 6aab764 Jon Layton: doc: Fix whitespace errs in .md files, bitcoin.conf, Info.plist.in, and fi... 01:45 < bitcoin-git> bitcoin/master f18a906 fanquake: Merge #16812: doc: Fix whitespace errs in .md files, bitcoin.conf, and Inf... 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:45 < bitcoin-git> [bitcoin] fanquake merged pull request #16812: doc: Fix whitespace errs in .md files, bitcoin.conf, and Info.plist.in (master...docs/lint-markdown) https://github.com/bitcoin/bitcoin/pull/16812 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:46 < fanquake> I'll never merge a whitespace related PR ever again. 01:48 -!- jonatack [~jon@37.173.200.138] has quit [Ping timeout: 240 seconds] 01:59 -!- m1rror8 [~m1rror@91.177.121.173] has quit [Ping timeout: 246 seconds] 01:59 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 265 seconds] 02:00 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:04 -!- laptop500 [~laptop@host86-134-43-42.range86-134.btcentralplus.com] has joined #bitcoin-core-dev 02:04 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Ping timeout: 260 seconds] 02:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:06 < bitcoin-git> [bitcoin] ch4ot1c opened pull request #16893: doc: Fix datadir path in 0.18.0 release notes (master...doc/release-notes-0.18.0-fix) https://github.com/bitcoin/bitcoin/pull/16893 02:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 02:27 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:4dd9:b7f:9c43:a846] has joined #bitcoin-core-dev 02:30 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev 02:33 -!- kcalvina_ [~calvin@114.202.232.195] has joined #bitcoin-core-dev 02:33 -!- kcalvinalvin [~calvin@114.202.232.195] has quit [Read error: Connection reset by peer] 02:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 245 seconds] 02:37 -!- kcalvina_ [~calvin@114.202.232.195] has quit [Ping timeout: 240 seconds] 02:56 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Quit: jonatack] 02:56 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev 02:57 < wumpus> warren: oh, awesome! 02:57 < wumpus> #proposedtopic making better use of Transifex 03:03 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:4dd9:b7f:9c43:a846] has quit [Quit: Sleep mode] 03:04 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:4dd9:b7f:9c43:a846] has joined #bitcoin-core-dev 03:07 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 03:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 03:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:18 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:23 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 03:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:27 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:31 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:33 < Chris_Stewart_5> is there a guide to building statically linked binaries anywhere for mac osx ? Or at least a specific place i should be looking ? 03:35 -!- lightlike [~lightlike@2001:16b8:57c2:7200:70e4:eafc:f0a8:5f11] has joined #bitcoin-core-dev 03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:43 < bitcoin-git> [bitcoin] Sjors opened pull request #16895: External signer multisig support (master...2019/09/hww-multisig) https://github.com/bitcoin/bitcoin/pull/16895 03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:44 < provoostenator> ^ WIP but it "works" 03:49 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:51 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has joined #bitcoin-core-dev 03:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 268 seconds] 03:54 -!- litenull [~litenull@192.145.126.115] has joined #bitcoin-core-dev 03:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:57 -!- kcalvinalvin [~calvin@222.111.133.183] has joined #bitcoin-core-dev 04:08 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 04:17 -!- unk [~unk@tranoo.com] has quit [Quit: Leaving] 04:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:33 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16892: validation: find witness commitment header using memcmp() instead of byte-by-byte comparison (master...20190917-validation-find_witness_commitment_with_memcmp) https://github.com/bitcoin/bitcoin/pull/16892 04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:33 < bitcoin-git> [bitcoin] renepickhardt opened pull request #16896: replaced hard coded folders with os.path.join & replaced os.path.sep (master...patch-seperator) https://github.com/bitcoin/bitcoin/pull/16896 04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 04:35 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has quit [Quit: WeeChat 2.6] 04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:43 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16893: doc: Fix datadir path in 0.18.0 release notes (master...doc/release-notes-0.18.0-fix) https://github.com/bitcoin/bitcoin/pull/16893 04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:00 -!- litenull [~litenull@192.145.126.115] has quit [] 05:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:05 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ufbuuohedpaijmwm] has quit [Quit: Connection closed for inactivity] 05:05 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:13 -!- kcalvina_ [~calvin@1.210.180.10] has joined #bitcoin-core-dev 05:15 -!- kcalvinalvin [~calvin@222.111.133.183] has quit [Ping timeout: 265 seconds] 05:17 -!- rhauch [~rhauch@141.98.102.235] has joined #bitcoin-core-dev 05:18 -!- kcalvina_ [~calvin@1.210.180.10] has quit [Ping timeout: 245 seconds] 05:25 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:29 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 05:29 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:34 -!- d3spwn [~d3spwn@unaffiliated/d3spwn] has left #bitcoin-core-dev [] 05:35 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 05:45 -!- reallll is now known as belcher 05:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 05:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:58 -!- Highway61 [~Thunderbi@167.160.174.10] has joined #bitcoin-core-dev 06:32 -!- ajonas [uid385278@gateway/web/irccloud.com/x-czyqwrfwhrvwxwjz] has joined #bitcoin-core-dev 06:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 06:35 -!- TheCharlatan [~TheCharla@109.236.87.57] has quit [Read error: Connection reset by peer] 06:36 -!- TheCharlatan [~TheCharla@109.236.87.57] has joined #bitcoin-core-dev 06:37 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:40 < wumpus> fanquake | I'll never merge a whitespace related PR ever again. <- same 06:42 < wumpus> provoostenator: nice! 06:43 < provoostenator> I did it mostly to see if I was missing anything in the single-key setup, but I think that works fine as is. 06:44 < provoostenator> I still haven't read up on miniscript / policy language. I wonder how that fits into things. 06:46 < provoostenator> sipa: would each hardware wallet provide its own "policy" that when combined results in a multisig (or something equivalent but more efficient)? 06:52 -!- tsujp [~tsujp@pa49-196-35-238.pa.vic.optusnet.com.au] has joined #bitcoin-core-dev 06:54 -!- designwish [~designwis@51.ip-51-68-136.eu] has quit [Quit: ZNC - http://znc.in] 06:55 -!- tsujp [~tsujp@pa49-196-35-238.pa.vic.optusnet.com.au] has quit [Client Quit] 06:56 < instagibbs> it would be helpful for the hww to report what it type of policies it can sign 06:56 < instagibbs> right now that kind of list is assembled by hand 06:57 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Quit: bye] 06:59 < instagibbs> e.g., does the Trezor allow 2of3 or csv and 1of1 type policies to be signed 06:59 -!- designwish [~designwis@51.ip-51-68-136.eu] has joined #bitcoin-core-dev 07:01 -!- b10c [~b10c@2001:16b8:2e66:1700:7fc0:feea:c92f:7c41] has joined #bitcoin-core-dev 07:02 -!- tsujp [~tsujp@pa49-196-35-238.pa.vic.optusnet.com.au] has joined #bitcoin-core-dev 07:03 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-mbllckwzvznfnark] has joined #bitcoin-core-dev 07:03 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev 07:07 < instagibbs> of just twist people's arms until it'll sign generic scriptcodes like ledger... 07:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:12 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:4dd9:b7f:9c43:a846] has quit [Quit: Sleep mode] 07:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 07:17 < provoostenator> So something similar to the getdescriptors call, which currently returns the list of single-signature descriptors it likes (although we hardcoded that in HWI) 07:28 -!- tsujp [~tsujp@pa49-196-35-238.pa.vic.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:29 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 276 seconds] 07:31 -!- emilengler_ is now known as emilengler 07:35 -!- tsujp [~tsujp@pa49-196-35-238.pa.vic.optusnet.com.au] has joined #bitcoin-core-dev 07:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:47 -!- tsujp [~tsujp@pa49-196-35-238.pa.vic.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:47 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:49 -!- b10c [~b10c@2001:16b8:2e66:1700:7fc0:feea:c92f:7c41] has quit [Quit: Leaving] 07:49 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:51 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has joined #bitcoin-core-dev 07:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 08:00 -!- rhauch [~rhauch@141.98.102.235] has quit [] 08:09 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has quit [Remote host closed the connection] 08:16 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:17 -!- funkyb [~funkyb@185.204.1.185] has joined #bitcoin-core-dev 08:43 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 08:45 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:01 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:02 -!- krypx [542cba76@cable-84-44-186-118.nc.de] has joined #bitcoin-core-dev 09:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:10 < sipa> provoostenator: i haven't really thought about hos to assess compatibility of hardware wallets 09:11 < sipa> hopefully if miniscript becomes a bit more common, hw wallets will just support all of it 09:11 < provoostenator> We can manually tell HWI what each hardware wallet is capable of. 09:12 < provoostenator> But to communicate that, maybe we need some sort of wildcard in miniscript / policy language level. 09:13 < sipa> miniscript; not policy 09:14 < sipa> policy is compiled to miniscript, which is a many-to-many relation 09:14 < provoostenator> Plus one flag to indicate that the hardware wallet understands miniscript, which then implies the other wallets in a "multisig" can do whatever they want. 09:14 < sipa> miniscript is just a different way of representing script 09:14 < provoostenator> If one of the wallets doesn't support miniscript, then that constrains the others, depending on the sequence. 09:16 -!- krypx [542cba76@cable-84-44-186-118.nc.de] has quit [Remote host closed the connection] 09:19 < provoostenator> The policiy language seems a more useful level of abstraction, e.g. and(pk(hww1_key),pk(hww2_key)) 09:20 < provoostenator> Though that compiles to something no current hardware wallet will understand: OP_CHECKSIGVERIFY OP_CHECKSIG 09:20 < provoostenator> But in miniscript it does make sense: and_v(vc:pk(key_1),c:pk(key_2)) 09:21 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:21 < provoostenator> So I guess the hardware wallet itself needs to understand miniscript, whereas the tools we use to setup should understand the policy language? 09:22 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:22 < sipa> only the compiler needs to support the policy language 09:23 < sipa> provoostenator: different compilers can map the same policy to distinct miniscripts 09:23 < sipa> as there are various optional optimization steps involved 09:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:26 < provoostenator> So what is a hardware wallet that sees the above miniscript supposed to do? It knows it has key_1, so it infers that it can sign the first part of the AND condition. 09:26 < provoostenator> As for the second part, I guess it's happy as long as the change output has the same policy? 09:27 < sipa> change detection is a hard problem 09:27 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds] 09:27 < provoostenator> Indeed, it's pretty poorly supported by hardware wallets at the moment. 09:27 < sipa> and detecting that something is the same policy is not enough; there may be dozens of ways to implement a particular policy in script 09:28 < sipa> using an unusual one may be indiscoverae 09:28 < sipa> *indiscoverable 09:28 < sipa> non-discoverable? 09:28 < sipa> undiscoverable? 09:28 < provoostenator> I think this conservative rule is fine though: it's OK if the policy for the change address doesn't change and derives from the same set of xpubs. 09:28 < sipa> it should just be the same miniscript 09:29 < sipa> with different pubkeys from the same xpubs 09:29 < provoostenator> * not policy but script 09:30 < provoostenator> Oh and the derivation index should be identical for all signers and not a crazy high value. 09:30 < sipa> in short: same descriptor, different index 09:31 < provoostenator> yes 09:32 < provoostenator> So what is it that each hardware wallet should communicate during the setup? "pk(key_1)" 09:32 < sipa> what is setup? 09:32 < provoostenator> E.g. in the draft PR I made, Bitcoin Core could call HWI on all wallets 09:33 < sipa> nothing except compilers should deal with policies 09:33 < provoostenator> Asking each to return a piece of miniscript, then combine those with AND. 09:33 < sipa> generally it's the user or the software tha5 chooses the desired policy/script 09:34 < sipa> and the HW wallet supports it or not 09:35 < instagibbs> yes I'd expect Core/user to determine what type of policies it supports, then a "whitelist" of hww that support such a configuration 09:35 < sipa> the hardware wallet is a signer device, it supports signing 09:35 < sipa> it's not "exposing" a policy or a script; that's up to its user 09:35 < provoostenator> I'm thinking of two use cases: 1) I have a bunch of hardware wallets, plug them all in at once to setup some multisig 09:36 < sipa> then you should just use multisig 09:36 < provoostenator> 2) I and my "friends" each run Bitcoin Core with one or more wallets and want to setup a joint thing 09:36 < sipa> no need for miniscript in that case 09:36 < sipa> yes 09:36 < sipa> in which case you'd gather the xpubs, every user constructs a policy they like 09:36 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds] 09:36 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 09:36 < sipa> share the policy with others 09:36 < sipa> run the compiler once 09:37 < sipa> everyone can see that the policy of the output matches their part 09:37 < sipa> and then import a descriptor for it in their wallets 09:38 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:38 < sipa> i don't expect stuff like that to be usable or user friendly anytime soon 09:43 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 276 seconds] 09:50 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:52 < achow101> Is #16512 RTM? 09:52 < gribble> https://github.com/bitcoin/bitcoin/issues/16512 | Shuffle inputs and outputs after joining psbts by achow101 · Pull Request #16512 · bitcoin/bitcoin · GitHub 09:57 < sipa> rtm? 09:57 < sipa> ah, ready to merge 10:01 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 10:02 < instagibbs> did that PR read the manual 10:02 < instagibbs> achow101, I don't see any fresh ACKs, I can re-review 10:03 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16898: test: Remove connect_nodes_bi (master...1908-testConnectNodes) https://github.com/bitcoin/bitcoin/pull/16898 10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:05 < instagibbs> achow101, I'd just make some nitty changes since no fresh acks anyways 10:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 10:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:12 < bitcoin-git> [bitcoin] jamesob opened pull request #16899: UTXO snapshot creation (dumptxoutset) (master...2019-09-au-dumptxoutset) https://github.com/bitcoin/bitcoin/pull/16899 10:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:13 < achow101> current nits are too nitty for me 10:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 10:16 < cubancorona> AtomicLedger!63 10:17 < cubancorona> lol sorry 10:18 < sipa> hunter2 10:18 < cubancorona> exactly 10:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 10:24 -!- rwang [uid386281@gateway/web/irccloud.com/x-rchenusazlcqvwoa] has joined #bitcoin-core-dev 10:32 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 10:34 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:38 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f18a9065e911...318890b1ee3c 10:38 < bitcoin-git> bitcoin/master fa502cb MarcoFalke: test: Bump timeouts in slow running tests 10:38 < bitcoin-git> bitcoin/master 318890b MarcoFalke: Merge #16888: test: Bump timeouts in slow running tests 10:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16888: test: Bump timeouts in slow running tests (master...1909-testBumpTimeouts) https://github.com/bitcoin/bitcoin/pull/16888 10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:42 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 10:43 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds] 10:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:49 < achow101> provoostenator: half of the comments that you made on #16341 are on comments that I can't figure out whree they are, so I'm not going to respond to them unless we can figure out an easier way to make these conversations easier to find and respond to 10:49 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub 11:00 -!- funkyb [~funkyb@185.204.1.185] has quit [] 11:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 11:17 -!- true-asset [~true-asse@141.98.102.235] has joined #bitcoin-core-dev 11:18 -!- ajonas [uid385278@gateway/web/irccloud.com/x-czyqwrfwhrvwxwjz] has quit [Quit: Connection closed for inactivity] 11:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/318890b1ee3c...99beda47f56a 11:25 < bitcoin-git> bitcoin/master ae0add8 Gregory Sanders: Add python bech32 impl round-trip test 11:25 < bitcoin-git> bitcoin/master 99beda4 MarcoFalke: Merge #16864: test: Add python bech32 impl round-trip test 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:25 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16864: test: Add python bech32 impl round-trip test (master...bech32_encode_test) https://github.com/bitcoin/bitcoin/pull/16864 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:28 -!- Highway62 [~Thunderbi@162.219.178.10] has joined #bitcoin-core-dev 11:30 -!- Highway61 [~Thunderbi@167.160.174.10] has quit [Ping timeout: 245 seconds] 11:30 -!- Highway62 is now known as Highway61 11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/99beda47f56a...b3067f4338d9 11:30 < bitcoin-git> bitcoin/master 8573429 soroosh-sdi: test: add some unit tests for merkle.cpp 11:30 < bitcoin-git> bitcoin/master b3067f4 MarcoFalke: Merge #16865: test: add some unit tests for merkle.cpp 11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:30 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16865: test: add some unit tests for merkle.cpp (master...13-09-19-merkle-unit-tests) https://github.com/bitcoin/bitcoin/pull/16865 11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:32 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 11:32 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 11:48 -!- ajonas [uid385278@gateway/web/irccloud.com/x-pvciypzvonimmobt] has joined #bitcoin-core-dev 11:50 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 11:50 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds] 11:51 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Ping timeout: 245 seconds] 11:52 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has joined #bitcoin-core-dev 11:52 -!- tnaka [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Ping timeout: 264 seconds] 11:52 -!- tnaka_ [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has joined #bitcoin-core-dev 11:52 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:56 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16900: doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util (master...1909-docRpcUtil) https://github.com/bitcoin/bitcoin/pull/16900 11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:56 < cubancorona> sipa: May I message you privately about a possible vulnerability in the bitcoin light client neutrino? 11:57 < sipa> i'm not the right person to talk to 11:57 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 265 seconds] 12:01 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 12:02 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 12:04 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 12:05 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 240 seconds] 12:05 -!- jarthur_ is now known as jarthur 12:14 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:15 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 12:16 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 12:25 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 12:26 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:30 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 12:32 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 12:33 -!- tochka4 [~tochka4@109.195.21.38] has joined #bitcoin-core-dev 12:40 -!- cubancorona2 [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev 12:42 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Ping timeout: 265 seconds] 12:43 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 12:48 -!- vfP56jSe_ is now known as vfP56jSe 12:56 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 12:56 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 250 seconds] 13:07 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 13:10 -!- cubancorona2 [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Quit: Leaving] 13:10 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev 13:22 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:46 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:55 -!- Highway62 [~Thunderbi@96.44.145.114] has joined #bitcoin-core-dev 13:57 -!- Highway61 [~Thunderbi@162.219.178.10] has quit [Ping timeout: 265 seconds] 13:57 -!- Highway62 is now known as Highway61 14:00 -!- true-asset [~true-asse@141.98.102.235] has quit [] 14:02 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:07 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds] 14:13 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds] 14:13 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 14:14 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:14 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 14:17 -!- bpalmer1 [~bpalmer@185.169.255.76] has joined #bitcoin-core-dev 14:18 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:19 < achow101> any idea why changing mapWallet from std::map to std::unordered_map would cause the qt wallet tests to fail? afaict, we don't rely on the order of txs in mapWallet ever 14:25 -!- shesek [~shesek@141.226.218.61] has joined #bitcoin-core-dev 14:25 -!- shesek [~shesek@141.226.218.61] has quit [Changing host] 14:25 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:26 < phantomcircuit> achow101, possibly the tests do 14:27 < achow101> the tests don't access mapwallet directly 14:28 < achow101> and the order would be based on txid, which changes with each run, so depending on that order doesn't make any sense 14:33 < phantomcircuit> achow101, neat, you found a bug then 14:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 14:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:54 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 15:06 < achow101> ffs the gui relies on the list of txs to be sorted 15:11 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 15:19 < meshcollider> lol 15:31 < promag> achow101: where? 15:32 < achow101> transactiontablemodel. See cachedWallet 15:32 < achow101> I'm making it not sorted 15:35 < promag> achow101: sort them in WalletImpl::getWalletTxs 15:36 < promag> anyway this might be something worth improving 15:36 < promag> it shouldn't be necessary a copy of the wallet in the model 15:36 -!- marcoagner [~user@2001:8a0:6a53:2e00:1967:22be:ad77:2d5] has quit [Ping timeout: 276 seconds] 15:37 < promag> just those that are displayed 15:38 < achow101> i've added a sort 15:39 < achow101> I put it in TransactionTablePriv::refreshWallet rather than getWalletTxs since that's where the sorting matters. nothing else uses getWalletTxs, and if we add something that does, I would prefer that it not rely on sorting 15:40 < promag> ok 15:41 < promag> why the change to mapWallets btw? 15:41 < promag> performance improvement? 15:41 < achow101> yeah 15:41 < achow101> I made a large wallet for testing my memory reduction stuff, and I decided to take a look at the loading times too 15:42 < achow101> noticed it spent quite a while inserting things into various maps 15:42 < promag> for daemon only then :P because I guess that change only has impact with big wallets, and that new sorting probably makes it worse 15:42 < achow101> right, which is why I was thinking about making it non-sorted 15:46 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 276 seconds] 15:47 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:17 -!- vincenzopalazzo [~vincenzop@2.226.158.237] has joined #bitcoin-core-dev 16:17 -!- fox2p_ [~fox2p@185.212.170.163] has quit [Ping timeout: 276 seconds] 16:17 -!- vincenzopalazzo [~vincenzop@2.226.158.237] has quit [Client Quit] 16:17 -!- fox2p [~fox2p@185.9.18.115] has joined #bitcoin-core-dev 16:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 16:28 -!- ajonas [uid385278@gateway/web/irccloud.com/x-pvciypzvonimmobt] has quit [Quit: Connection closed for inactivity] 16:33 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 16:37 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Read error: Connection reset by peer] 16:38 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 16:40 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:45 < bitcoin-git> [bitcoin] ch4ot1c opened pull request #16901: test: Add markdownlint rules (master...doc/markdown-linter) https://github.com/bitcoin/bitcoin/pull/16901 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:47 -!- Highway61 [~Thunderbi@96.44.145.114] has quit [Ping timeout: 265 seconds] 16:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:00 -!- bpalmer1 [~bpalmer@185.169.255.76] has quit [] 17:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 17:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 17:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds] 17:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 17:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:36 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev 17:46 -!- jmp-TOK [~jmp-TOK@139.28.218.198] has joined #bitcoin-core-dev 17:52 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:00 -!- lightlike [~lightlike@2001:16b8:57c2:7200:70e4:eafc:f0a8:5f11] has quit [Quit: Leaving] 18:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 18:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 18:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:55 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 19:09 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 276 seconds] 19:11 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 19:20 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 19:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:27 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b3067f4338d9...cc1d7fd57c9e 19:27 < bitcoin-git> bitcoin/master 4d45577 fanquake: build: remove unnecessary macOS qt patching 19:27 < bitcoin-git> bitcoin/master 93995c2 fanquake: build: remove unnecessary qt xcb patching 19:27 < bitcoin-git> bitcoin/master cc1d7fd fanquake: Merge #16879: build: remove redundant sed patching 19:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:27 < bitcoin-git> [bitcoin] fanquake merged pull request #16879: build: remove redundant sed patching (master...messy_depends) https://github.com/bitcoin/bitcoin/pull/16879 19:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:30 -!- xzytrewq [~quassel@192.200.24.3] has quit [Ping timeout: 258 seconds] 19:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 19:33 -!- xzytrewq [~quassel@192.200.24.3] has joined #bitcoin-core-dev 19:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:53 < bitcoin-git> [bitcoin] sipa opened pull request #16902: [POC] O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation (master...201909_o1nestedifs) https://github.com/bitcoin/bitcoin/pull/16902 19:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:00 -!- jmp-TOK [~jmp-TOK@139.28.218.198] has quit [] 20:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 20:16 -!- DARKNE55 [~DARKNE55@141.98.102.235] has joined #bitcoin-core-dev 20:19 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 20:33 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 20:36 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 20:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 21:03 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has joined #bitcoin-core-dev 21:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 21:46 -!- ppisati [~ppisati@net-188-153-155-81.cust.vodafonedsl.it] has quit [Quit: leaving] 21:53 -!- ppisati [~ppisati@net-188-216-11-64.cust.vodafonedsl.it] has joined #bitcoin-core-dev 21:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 22:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:10 < bitcoin-git> [bitcoin] fanquake closed pull request #14245: Minimize vfExec counting in script handling (master...fexec) https://github.com/bitcoin/bitcoin/pull/14245 22:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:20 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 22:53 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Remote host closed the connection] 23:00 -!- DARKNE55 [~DARKNE55@141.98.102.235] has quit [] 23:00 -!- Highway61 [~Thunderbi@96.44.145.114] has joined #bitcoin-core-dev 23:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 23:12 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 23:15 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:17 -!- Nipo1 [~Nipo@84.39.116.180] has joined #bitcoin-core-dev 23:20 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 23:33 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 23:34 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds] 23:38 -!- seeder [uid377087@gateway/web/irccloud.com/x-kcnkbnpbhdwcvxkk] has joined #bitcoin-core-dev 23:38 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:42 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 23:43 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:44 < provoostenator> achow101: I made them per commit, which is probably what confuses Github 23:45 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 245 seconds] 23:46 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 23:47 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 23:56 -!- kcalvinalvin [~calvin@121.162.198.124] has joined #bitcoin-core-dev --- Log closed Wed Sep 18 00:00:14 2019