--- Log opened Fri Oct 25 00:00:44 2019 00:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 00:17 -!- marcoagner [~user@2001:8a0:6a5f:5700:7bb3:6296:d274:7295] has joined #bitcoin-core-dev 00:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 00:30 -!- baldur [~baldur@pool-100-2-132-165.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 00:30 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 252 seconds] 00:43 -!- Stasik [b22e9f9b@178.46.159.155] has joined #bitcoin-core-dev 00:44 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 276 seconds] 00:50 -!- baldur [~baldur@pool-100-2-132-165.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 00:52 -!- Stasik [b22e9f9b@178.46.159.155] has quit [Remote host closed the connection] 01:01 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:24 -!- ppisati [~ppisati@net-188-218-183-152.cust.vodafonedsl.it] has quit [Quit: leaving] 01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:30 < bitcoin-git> [bitcoin] Sjors opened pull request #17246: wallet: avoid knapsack when there's no change (master...2019/10/less-knapsack) https://github.com/bitcoin/bitcoin/pull/17246 01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:31 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:31 -!- ppisati [~ppisati@net-5-95-174-18.cust.vodafonedsl.it] has joined #bitcoin-core-dev 01:35 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 01:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 01:48 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:49 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:49 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 01:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:54 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds] 02:00 -!- gnomus [~gnomus@185.103.96.143] has quit [] 02:00 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:01 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 264 seconds] 02:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 02:09 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has joined #bitcoin-core-dev 02:27 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 245 seconds] 02:36 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has quit [Ping timeout: 268 seconds] 02:39 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has joined #bitcoin-core-dev 02:42 < wumpus> let's try to have some more ACKs on #17165 soon 02:42 < gribble> https://github.com/bitcoin/bitcoin/issues/17165 | Remove BIP70 support by fanquake . Pull Request #17165 . bitcoin/bitcoin . GitHub 02:42 < wumpus> (not only concept, please) 02:47 -!- AimHere1 [~AimHere@141.98.102.235] has joined #bitcoin-core-dev 02:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 02:54 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds] 03:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:01 < bitcoin-git> [bitcoin] laanwj closed pull request #15140: test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (master...test_20190110) https://github.com/bitcoin/bitcoin/pull/15140 03:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:03 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fce7c7542234...366753e46e1f 03:03 < bitcoin-git> bitcoin/master 50037e9 Cory Fields: depends: fix boost mac cross build with clang 9+ 03:03 < bitcoin-git> bitcoin/master 366753e Wladimir J. van der Laan: Merge #17231: depends: fix boost mac cross build with clang 9+ 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:03 -!- jonatack [~jon@213.152.161.234] has joined #bitcoin-core-dev 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:03 < bitcoin-git> [bitcoin] laanwj merged pull request #17231: depends: fix boost mac cross build with clang 9+ (master...fix-boost-clang9) https://github.com/bitcoin/bitcoin/pull/17231 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:04 -!- wullon [~wullon@241.243.86.88.rdns.comcable.net] has quit [Read error: Connection reset by peer] 03:04 -!- wullon [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev 03:13 -!- scopeh [~scopeh@148.253.169.2] has quit [Read error: Connection reset by peer] 03:14 -!- scopeh [~scopeh@148.253.169.2] has joined #bitcoin-core-dev 03:21 < wumpus> what was the flag to make bitcoind log the IPs it's trying to connect to again? 03:22 < wumpus> #17247 is strange, I'm trying to figure out if they're somehow connecting to false peer addresses or that their ISP is resetting bitcoin connections 03:22 < gribble> https://github.com/bitcoin/bitcoin/issues/17247 | socket recv error Connection reset by peer (104) . Issue #17247 . bitcoin/bitcoin . GitHub 03:26 < wumpus> looks like they're in China, too 03:26 < wumpus> might be a censorship issue @ BlueMatt 03:29 < wumpus> anyone else from China here experiencing similar problems? 03:29 < wumpus> or another country for that matter 03:32 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 03:37 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 03:37 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 03:38 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 03:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:49 -!- halseth [~root@138.68.141.217] has joined #bitcoin-core-dev 03:50 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 03:52 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has quit [Quit: Sleep mode] 03:58 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 250 seconds] 04:06 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has joined #bitcoin-core-dev 04:26 -!- JeremyCrookshank [d589196a@213.137.25.106] has joined #bitcoin-core-dev 04:34 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 04:40 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds] 04:48 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has joined #bitcoin-core-dev 04:48 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/366753e46e1f...90ed98ae9a2a 04:48 < bitcoin-git> bitcoin/master fa92813 MarcoFalke: consensus: Explain why fCheckDuplicateInputs can not be skipped and remove... 04:48 < bitcoin-git> bitcoin/master 90ed98a Wladimir J. van der Laan: Merge #17080: consensus: Explain why fCheckDuplicateInputs can not be skip... 04:48 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has left #bitcoin-core-dev [] 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:48 < bitcoin-git> [bitcoin] laanwj merged pull request #17080: consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it (master...1909-docCheckInputs) https://github.com/bitcoin/bitcoin/pull/17080 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 04:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:56 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/90ed98ae9a2a...37855ec9df57 04:56 < bitcoin-git> bitcoin/master b05ec41 marcaiaf: Add unit testing for the CompressScript functions 04:56 < bitcoin-git> bitcoin/master 37855ec Wladimir J. van der Laan: Merge #17220: tests: Add unit testing for the CompressScript function 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:56 < bitcoin-git> [bitcoin] laanwj merged pull request #17220: tests: Add unit testing for the CompressScript function (master...add_compress_test_cases) https://github.com/bitcoin/bitcoin/pull/17220 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:59 < wumpus> added 0.19.0 milestone to #17135 and removed it from #17035 (bumped to 0.19.1) 04:59 < gribble> https://github.com/bitcoin/bitcoin/issues/17135 | gui: Make polling in ClientModel asynchronous by promag . Pull Request #17135 . bitcoin/bitcoin . GitHub 04:59 < gribble> https://github.com/bitcoin/bitcoin/issues/17035 | qt: Fix text display when state of prune button is changed by emilengler . Pull Request #17035 . bitcoin/bitcoin . GitHub 04:59 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has joined #bitcoin-core-dev 05:00 -!- AimHere1 [~AimHere@141.98.102.235] has quit [] 05:01 < fanquake> ACK 05:01 < fanquake> I will take a look at 17135 this morning 05:02 < provoostenator> wumpus: the Great Firewall is known to reset connections for stuff it doesn't like; it creates the perception of a crappy website. 05:02 < wumpus> fanquake: great! we've been making it less scary 05:03 < provoostenator> But this is the same peer (104) over and over again. 05:03 < wumpus> provoostenator: yes, I've seen this behavior for other things for the Chinese firewall, which is why it worried me 05:04 < wumpus> provoostenator: but I'm no longer so worried, there have been no other reports, something like this would be massive 05:05 < provoostenator> Would be useful if debug=net were to log the IP along with the peer number... 05:05 < wumpus> yes, that's why I asked, I know there's a setting to enable logging of IPs of the peers it connects to, this would hav allowed me to try the peers myself and see if they have the same behavior from here 05:06 < wumpus> e.g. to see if it is a *peer problem* or a network problem 05:07 -!- JJ [d589196a@213.137.25.106] has joined #bitcoin-core-dev 05:07 < wumpus> provoostenator: (104) is not the peer number but the error number 05:08 < wumpus> errno -l|grep 104 05:08 < wumpus> ECONNRESET 104 Connection reset by peer 05:08 -!- JJ [d589196a@213.137.25.106] has quit [Remote host closed the connection] 05:12 -!- JJ [d589196a@213.137.25.106] has joined #bitcoin-core-dev 05:13 < wumpus> found it, it's `-logips` 05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:14 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/37855ec9df57...48cb468ce3f5 05:14 < bitcoin-git> bitcoin/master 0a433fc John Newbery: [validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCac... 05:14 < bitcoin-git> bitcoin/master 48cb468 fanquake: Merge #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMe... 05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:15 < bitcoin-git> [bitcoin] fanquake merged pull request #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache (master...2019-10-checkinputsfrommempool) https://github.com/bitcoin/bitcoin/pull/17242 05:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:15 -!- JJ [d589196a@213.137.25.106] has quit [Remote host closed the connection] 05:17 -!- porvak [~porvak@77.243.177.38] has joined #bitcoin-core-dev 05:20 -!- Aaronvan_ is now known as AaronvanW 05:22 < provoostenator> Is there a command line incantation (for macOS) to reset an outbound connection? 05:25 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has quit [Remote host closed the connection] 05:25 < wumpus> tcpkill ftw 05:25 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev 05:25 < wumpus> (no idea if that's still a thing tbh :) 05:27 -!- jonatack [~jon@213.152.161.234] has quit [Ping timeout: 268 seconds] 05:32 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 05:37 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 250 seconds] 05:38 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 05:49 < provoostenator> This seems similar: https://github.com/google/tcp_killer/pull/1 05:50 < provoostenator> But it causes a graceful disconnect, so I need to tweak it somehow. 05:51 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 05:52 -!- JeremyCrookshank [d589196a@213.137.25.106] has quit [Remote host closed the connection] 05:52 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev 05:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 05:55 -!- jonatack [~jon@37.164.227.124] has joined #bitcoin-core-dev 05:58 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 265 seconds] 06:05 -!- halseth [~root@138.68.141.217] has quit [Quit: leaving] 06:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:11 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has joined #bitcoin-core-dev 06:12 -!- halseth [~root@138.68.141.217] has joined #bitcoin-core-dev 06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:14 < bitcoin-git> [bitcoin] jbeich opened pull request #17249: Unbreak build with boost 1.72 (master...boost) https://github.com/bitcoin/bitcoin/pull/17249 06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:19 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17250: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip (master...1910-NoWrongGuess) https://github.com/bitcoin/bitcoin/pull/17250 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:23 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has quit [Ping timeout: 240 seconds] 06:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 06:32 -!- JJ [d589196a@213.137.25.106] has joined #bitcoin-core-dev 06:32 < wumpus> injecting a call to close() seems risky; after that, the fd could be reused for something else (say, a new connection ,or a file), and the program doesn't know 06:32 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Remote host closed the connection] 06:32 < wumpus> provoostenator: then again it's only for testing one particular thing, I suppose 06:33 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev 06:33 < provoostenator> It's just to test stuff, maybe the Google folks have a better idea:https://github.com/google/tcp_killer/pull/2 06:34 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has quit [Quit: Sleep mode] 06:35 < wumpus> it's just, it can result in nasty corruptions, if say, leveldb decides to open a file next and the P2P layer keeps writing into the fd that's now owned by the file 06:35 -!- Stas13 [b22e9f9b@178.46.159.155] has joined #bitcoin-core-dev 06:35 < wumpus> but you'll have backups I guess 06:35 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 06:35 -!- Stas13 [b22e9f9b@178.46.159.155] has quit [Remote host closed the connection] 06:36 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 06:37 -!- michaelfolkson [~textual@host109-150-22-219.range109-150.btcentralplus.com] has joined #bitcoin-core-dev 06:38 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 06:39 < provoostenator> Oh that's not healthy indeed... 06:40 -!- jonatack [~jon@37.164.227.124] has quit [Read error: Connection reset by peer] 06:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:41 < bitcoin-git> [bitcoin] Sjors opened pull request #17251: net: SocketHandler logs peer id for close and disconnect (master...2019/10/net-socket-peer) https://github.com/bitcoin/bitcoin/pull/17251 06:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:41 < provoostenator> I put a warning in the PR description 06:42 -!- halseth [~root@138.68.141.217] has quit [Quit: leaving] 06:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:43 < wumpus> I don't know a good solution that can work from the process itself 06:54 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 06:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 06:54 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:54 -!- sdaftuar_ is now known as sdaftuar 06:56 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Ping timeout: 260 seconds] 06:56 < instagibbs> sdaftuar_, these slides are actually more complete than I expected, useful resource for starting to understand mempool stuff 06:57 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 06:57 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 264 seconds] 06:58 < fanquake> instagibbs is there a public link? 06:58 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev 06:58 < instagibbs> he shared on gdrive, with permission I can upload the pdf somewhere? 06:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:59 < bitcoin-git> [bitcoin] promag opened pull request #17252: 0.19: gui: Make polling in ClientModel asynchronous (0.19...2019-10-backport-17135) https://github.com/bitcoin/bitcoin/pull/17252 06:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:01 -!- halseth [~root@138.68.141.217] has joined #bitcoin-core-dev 07:01 < sdaftuar> instagibbs: please do 07:01 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds] 07:01 < sdaftuar> if someone wants to turn that into a wiki page, that might be best? 07:02 < instagibbs> I could strip mine the slides, stick it on the wiki 07:02 < instagibbs> :P 07:02 -!- thoragh [~victor@37.120.156.178] has joined #bitcoin-core-dev 07:03 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 268 seconds] 07:09 < instagibbs> fanquake, https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Mempool-and-mining 07:10 < instagibbs> this can obviously be cleaned up. I have at least one clarifying question 07:10 < fanquake> instagibbs well formatted I see 07:10 < sdaftuar> lol 07:10 < instagibbs> i went and added extra lines to break up the slides 07:11 < instagibbs> pretty much hero level editing 07:11 < fanquake> Looks good though. Will read through this arvo 07:11 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 07:13 -!- lightlike [~lightlike@2001:16b8:571b:d400:f1b9:bff9:dd64:db66] has joined #bitcoin-core-dev 07:16 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 07:21 -!- michaelfolkson [~textual@host109-150-22-219.range109-150.btcentralplus.com] has quit [Quit: Sleep mode] 07:22 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 276 seconds] 07:25 -!- thoragh [~victor@37.120.156.178] has left #bitcoin-core-dev [] 07:27 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has joined #bitcoin-core-dev 07:28 -!- thoragh [~victor@37.120.156.178] has joined #bitcoin-core-dev 07:28 < luke-jr> sdaftuar: https://github.com/bitcoin/bitcoin/pull/15660#issuecomment-476006719 is that patch posted anywhere? 07:29 < luke-jr> (maybe the original PR should be reopened with it?) 07:29 < sdaftuar> oy, i can try to find it 07:33 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:35 < luke-jr> maybe useful: git reflog show --format='%<|(30)%cd %h %gs' 07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:35 < bitcoin-git> [bitcoin] elichai opened pull request #17253: Remove boost from time.cpp (master...2019-10-boost_sleep_time) https://github.com/bitcoin/bitcoin/pull/17253 07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:36 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:36 * luke-jr ponders if there's a way to get the ref change date 07:38 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds] 07:39 < sdaftuar> thanks for that command, but can't seem to find it. i'll spend a couple minutes and see how hard it is to redo (since the point of the cleanup was to make it easy) 07:54 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 07:57 < elichai2> wumpus: so basically I should steer away from anything related to threads? 07:58 -!- thoragh [~victor@37.120.156.178] has left #bitcoin-core-dev [] 07:58 < wumpus> elichai2: nah, not specifically: I think the high-level thing is that all the low-hanging boost replacements have been done, and everything that's left has probably been tried to replace over the last few years but failed, be sure to do some research into previous PRs or ask around first 07:59 < elichai2> yeah. I didn't know that was the case. next time i'll search the github before 07:59 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has quit [Quit: Sleep mode] 07:59 < wumpus> e.g. there's probably some annoying death-by-a-thousand-cuts reason why it's still there 07:59 < elichai2> especially with the note in the scheduler 07:59 < elichai2> `// boost::thread / boost::chrono should be ported to std::thread / std::chrono // when we support C++11.` 08:00 -!- porvak [~porvak@77.243.177.38] has quit [] 08:00 < elichai2> so it makes it sound like the only reason is no one cared enough :) 08:00 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds] 08:00 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 08:02 < wumpus> elichai2: that, or the comment was over-optimistic :) 08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:02 < bitcoin-git> [bitcoin] elichai closed pull request #17253: utils: Remove boost from time.cpp (master...2019-10-boost_sleep_time) https://github.com/bitcoin/bitcoin/pull/17253 08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:02 < wumpus> I, really really wish we could get rid of the boost::sleep madness and it wasn't like this 08:03 < wumpus> I vaguely remember cfields once did a full replacement of the boost chrono/sleep stuff, including handling thread group interrupts, but even he had to give up ! 08:04 < instagibbs> elichai2, I recommend opening an issue with your sad news. Open issues make problems easier to track 08:04 < elichai2> :( 08:05 < elichai2> wumpus: but about the times. isn't it enough to assert now > 0? why was #16117 completley closed? 08:05 < gribble> https://github.com/bitcoin/bitcoin/issues/16117 | util: Replace boost:: with std:: in utiltime by MarcoFalke . Pull Request #16117 . bitcoin/bitcoin . GitHub 08:05 < sdaftuar> luke-jr: i think something like this works https://github.com/sdaftuar/bitcoin/commits/test-15633-2 . 08:05 < wumpus> elichai2: it probably didn't seem worth it anymore after the bad news 08:05 < elichai2> instagibbs: yeah, I might start with an issue(if doesn't exist yet, I won't make this mistake twice heh) that lists all the known boost right now. and people can comment (and i'll search) for why haven't we replaced them yet. for future references 08:06 < wumpus> opening an issue is probably a good idea, too many people stepped into this trap 08:07 < instagibbs> I'm a fan of opening an issue when closing PRs, if the problem is real, but solution somehow insufficient 08:07 < instagibbs> (if the PR doesn't already link an issue, of course!) 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48cb468ce3f5...693e40090ae7 08:08 < bitcoin-git> bitcoin/master dc2fdb9 practicalswift: tests: Add fuzzing harness for various CScript related functions 08:08 < bitcoin-git> bitcoin/master 693e400 MarcoFalke: Merge #17083: tests: Add fuzzing harness for various CScript related funct... 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:08 < wumpus> yes that'd be the ideal case, that a PR fixes an existing issue 08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17083: tests: Add fuzzing harness for various CScript related functions (master...fuzzers-script) https://github.com/bitcoin/bitcoin/pull/17083 08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:09 < wumpus> 'replace boost' isn't really an issue in itself (though there's a project that groups issues and PRs around it) 08:13 < wumpus> maybe "replace the boost thread interrupt system" 08:13 < wumpus> I think it'd be a partial redesign of things, not necessarily a one to one change 08:16 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 08:17 -!- laxanofido [~laxanofid@141.98.102.179] has joined #bitcoin-core-dev 08:18 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:22 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 08:23 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 268 seconds] 08:26 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 08:28 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 08:34 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-dev 08:39 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 08:45 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev 08:45 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host] 08:45 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 08:47 < luke-jr> fwiw, added a %rd format for git-reflog http://dpaste.com/3BPT9GY 08:49 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 08:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 08:54 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 08:57 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 264 seconds] 08:58 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 08:59 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 09:00 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 264 seconds] 09:01 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 268 seconds] 09:08 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 245 seconds] 09:19 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:19 < bitcoin-git> [bitcoin] adamjonas opened pull request #17254: test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (master...2019-10-missing-OP_PUSHBACK-test) https://github.com/bitcoin/bitcoin/pull/17254 09:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:21 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 09:21 < luke-jr> sdaftuar: now I'm pondering what a non-segwit peer with CBv2 means :P 09:23 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 09:25 -!- JJ [d589196a@213.137.25.106] has quit [Remote host closed the connection] 09:26 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:27 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:30 < sipa> luke-jr: spy node? 09:31 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 09:33 < luke-jr> sipa: well, sdaftuar changed gmax's check for NODE_SEGWIT to CBv2, I assume for a reason 09:33 -!- Honthe [~Honthe@s91904421.blix.com] has joined #bitcoin-core-dev 09:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 09:40 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:43 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 240 seconds] 09:44 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 245 seconds] 09:45 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 09:47 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 09:49 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev 09:51 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection] 09:54 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 09:56 < cfields> wumpus: fwiw, it wasn't that I gave up, it's that the end-result was very, very non-c++11-like. 09:56 < cfields> Ended up having to resort to a bunch of c api's afterall. 09:57 < cfields> Pretty sure it's still floating around in a branch somewhere, it's just arguably no better than using boost :( 09:59 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 10:01 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds] 10:03 < cfields> Oh, sorry, this was about the threading interrupt stuff, not wall clock stuff. 10:04 < cfields> Different branch, but similar outcome :) 10:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] emilengler opened pull request #17256: doc: Change apt-get to apt (master...2019-10-apt-get-to-apt) https://github.com/bitcoin/bitcoin/pull/17256 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:12 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 10:16 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:20 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 10:20 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:22 -!- Victor_sueca is now known as Victorsueca 10:26 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 10:27 < jamesob> man, PRs that are like 300+ line changes that aren't scripted diffs considered harmful. having to re-review (and re-review) a giant changeset because review has gone on for another month and a rebase has happened is a drag. 10:30 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:31 < luke-jr> typically I do re-review by comparing the diffs 10:32 -!- thoragh [~victor@37.120.156.178] has joined #bitcoin-core-dev 10:33 < instagibbs> 300 lines? you're like a baby :) 10:33 * instagibbs ducks 10:34 < luke-jr> gdd() { local A="$1"; shift local B="$1"; shift gd "$A" "$@" >/tmp/a gd "$B" "$@" >/tmp/b diff /tmp/{a,b} -u | less } 10:34 < luke-jr> newlines not included 10:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:36 < bitcoin-git> [bitcoin] fanquake opened pull request #17257: gui: disable font antialiasing for QR image address (master...disable_qr_font_antialiasing) https://github.com/bitcoin/bitcoin/pull/17257 10:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:37 < fanquake> jamesob 2100 lines waiting for you in 17165 10:38 < fanquake> although they are easy to review 10:39 < provoostenator> These "connection reset" log entries look more like a probing attack to me: https://github.com/bitcoin/bitcoin/issues/17247#issuecomment-546444882 10:43 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 10:43 < sdaftuar> luke-jr: see the comment on gmax's original PR. the code he had there wasn't right 10:44 < BlueMatt> wumpus: are you sure those connections arent incoming? 10:44 < ryanofsky> provoostenator, did you ever implement, or start implementing that optionsmodel test? i might pick up on that if you started something 10:44 < BlueMatt> provoostenator: yes, it is. 10:44 < provoostenator> ryanofsky: nope, go for it 10:48 -!- lightlike [~lightlike@2001:16b8:571b:d400:f1b9:bff9:dd64:db66] has quit [Remote host closed the connection] 10:53 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:55 < jamesob> luke-jr: yup that's what I'll do, but still think that giant PRs are in most cases an antipattern 11:00 -!- laxanofido [~laxanofid@141.98.102.179] has quit [] 11:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:02 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has joined #bitcoin-core-dev 11:02 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 276 seconds] 11:03 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 11:04 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 260 seconds] 11:10 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 240 seconds] 11:11 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 11:11 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...] 11:13 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:15 -!- lightlike [~lightlike@2001:16b8:571b:d400:f1b9:bff9:dd64:db66] has joined #bitcoin-core-dev 11:15 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 11:17 -!- NikolaiToryzin [~NikolaiTo@172.83.40.52] has joined #bitcoin-core-dev 11:26 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...] 11:28 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:28 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:29 -!- rex4539 [~rex4539@ppp-2-87-182-24.home.otenet.gr] has joined #bitcoin-core-dev 11:29 -!- rex4539 [~rex4539@ppp-2-87-182-24.home.otenet.gr] has quit [Client Quit] 11:29 -!- rex4539 [~rex4539@ppp-2-87-182-24.home.otenet.gr] has joined #bitcoin-core-dev 11:30 -!- rex4539 [~rex4539@ppp-2-87-182-24.home.otenet.gr] has quit [Client Quit] 11:30 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:32 -!- rex4539 [~rex4539@2a02:587:3514:c700:9902:5798:6618:ea35] has joined #bitcoin-core-dev 11:34 -!- rex4539 [~rex4539@2a02:587:3514:c700:9902:5798:6618:ea35] has quit [Client Quit] 11:37 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 264 seconds] 11:39 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 11:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 11:53 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 11:58 -!- thoragh [~victor@37.120.156.178] has quit [Read error: Connection reset by peer] 12:00 < meshcollider> #startmeeting 12:00 < lightningbot> Meeting started Fri Oct 25 19:00:21 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < provoostenator> wallet meeting? 12:00 < jnewbery> hi 12:00 < provoostenator> hi 12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball 12:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 12:00 < fanquake> hi 12:00 < instagibbs> hi 12:00 < meshcollider> Topics? 12:00 < digi_james> hi 12:01 < achow101> hi 12:01 -!- thoragh [~victor@37.120.156.178] has joined #bitcoin-core-dev 12:01 < provoostenator> Not really. Lots of review work out there, just do it :-) 12:01 < BlueMatt> now that bitcoin core is defaulting to segwit more, I wonder if it would make sense to change the default on spending unconfirmed change to not spend non-segwit unconfirmed change due to malleability. 12:02 < instagibbs> BlueMatt, hmm 12:02 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 12:02 < instagibbs> achow101, you mentioned something about wanting to work on coin selection again, if you want to mention it here? (I don't know what you were thinking) 12:02 < provoostenator> Coin selection already prefers confirmed coins, so that seems a bit overkill. 12:02 < instagibbs> true, it heavily tries deeply-then-shallow-confirmed 12:03 < achow101> instagibbs: yes, planning on doing some coin selection stuff and reviving SRD 12:03 < meshcollider> Thanks to everyone who has been reviewing #16341, it's getting very close now which is awesome :) 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 . Pull Request #16341 . bitcoin/bitcoin . GitHub 12:03 < provoostenator> I went down the coin selection rabbit hole yesterday. Happy to review attemps by others :-) 12:03 < instagibbs> Sorry I haven't had time to re-review SPKM PR :/ 12:04 < instagibbs> Honestly knapsack has to die 12:04 < achow101> BlueMatt: would there even be non-segwit unconfirmed change unless the wallet is configured to addresstype=legacy? 12:05 < instagibbs> Previously I had tried working on the wallet again, and threw my hands up in dispair because of the knapsack loop behavior 12:05 < achow101> errr changetype=legacy.. I don't think we make non-segwit change anymore? 12:05 < BlueMatt> achow101: no, you need to avoid spending any change that came from a transaction with non-segwit inputs 12:05 < BlueMatt> cause that underlying tx is malleable 12:05 < achow101> oh right 12:06 < instagibbs> achow101, so personally speaking, I'd strong concept ACK killing off knapsack if the UTXO simulation story doesn't look awful 12:06 < instagibbs> imo it's limped along by fear of removing the current UTXO vacuum(that doesn't benefit small wallets anyways!) 12:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:08 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/693e40090ae7...25d7e2e78137 12:08 < bitcoin-git> bitcoin/master 04dbdd6 Sjors Provoost: [net] SocketHandler: log peer id for close and disconnect 12:08 < bitcoin-git> bitcoin/master 25d7e2e fanquake: Merge #17251: net: SocketHandler logs peer id for close and disconnect 12:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:08 < provoostenator> Yeah that loop is horrible. It doesnt' even really start at the top: splitting the fee amongst outputs is done at the top, based on the last iteration. 12:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:08 < bitcoin-git> [bitcoin] fanquake merged pull request #17251: net: SocketHandler logs peer id for close and disconnect (master...2019/10/net-socket-peer) https://github.com/bitcoin/bitcoin/pull/17251 12:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:08 < provoostenator> ^ yolo merge, before Travis ready :-) 12:08 < instagibbs> It makes improvements to the wallet basically impossible :( 12:08 < instagibbs> some improvements* 12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:09 < bitcoin-git> [bitcoin] adamjonas opened pull request #17258: Fix issue with conflicted mempool tx in listsinceblock (master...listsinceblock-filter-conflicts) https://github.com/bitcoin/bitcoin/pull/17258 12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:09 < instagibbs> anyways, stepping off soapbox 12:09 < instagibbs> f.e., having the wallet implicitly CPFP 12:10 < provoostenator> instagibbs: you'll like #17246 12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/17246 | wallet: avoid knapsack when theres no change by Sjors . Pull Request #17246 . bitcoin/bitcoin . GitHub 12:10 < achow101> BlueMatt: I suppose that idea is reasonable. but, on the topic of unconfirmed change, how do we handle fee bumping a tx from which we've spent the unconfirmed change? 12:10 < provoostenator> (or some variant thereof) 12:10 < instagibbs> provoostenator, right, CPFP would have worked for me... only for CPFP case :) 12:10 < BlueMatt> you dont 12:10 < BlueMatt> you bump the next one up 12:10 < BlueMatt> cpfp :) 12:10 < instagibbs> but I felt that wasn't worth it 12:11 < jnewbery> topic request: #16341 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 . Pull Request #16341 . bitcoin/bitcoin . GitHub 12:11 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...] 12:12 < achow101> BlueMatt: true. I was about to suggest that maybe we shouldn't allow unconfirmed change at all 12:12 < achow101> And with upcoming more complex scripts, maybe we shouldn't, because we aren't necessarily the sole owner of those outputs 12:13 < provoostenator> Instead of spending unconfirmed change, we could RBF and add an output? 12:14 < provoostenator> That would be a nice fee saving UX improvment. 12:14 < provoostenator> (though non trivial if the pre-RBF transactions gets mined) 12:14 < instagibbs> that's the sticky part 12:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:15 < provoostenator> You can sign two variants and start broadcasting the fallback if needed. 12:15 < provoostenator> But that's less of a set-and-forget than we have now. 12:15 < instagibbs> our wallet is very "transactional" i nthe wrong sense currently 12:15 < provoostenator> set-and-quit-and-forget I mean 12:15 < instagibbs> transaction as in CTransaction rather than logical transaction :) 12:18 < achow101> next topic? 12:18 < meshcollider> #topic SPKM PR #16341 (jnewbery) 12:18 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 . Pull Request #16341 . bitcoin/bitcoin . GitHub 12:18 < achow101> ack 'n merge pls 12:18 < meshcollider> Go and bug sipa first, he said he wanted to review it 12:19 < jnewbery> I'd like to help but there's no way I have time to review the PR in the way that it's structured 12:19 < provoostenator> jnewbery: did you also look at ryanofsky's variant, with the same end result? 12:19 < jnewbery> I'm particularly concerned about ryanofsky's comment here: https://github.com/bitcoin/bitcoin/pull/16341#issuecomment-541330425 12:19 < achow101> jnewbery: do you want me to use ryanofsky's structure? 12:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 12:19 < provoostenator> I found it useful to review achow101's version first, and then ryanofsky's version 12:19 < jnewbery> provoostenator achow101: I haven't looked at Russ's version yet 12:20 < jnewbery> it's mostly about the volume of changes 12:20 < provoostenator> But I wouldn't either is ideal. Russ' version does a _lot_ of stuff in big increments in the beginning. But his later commits are perhaps better. 12:20 < jnewbery> I know it'd take me at least a week to review so much code and satisfy myself that there aren't bugs 12:21 < provoostenator> It's a huge PR indeed. But it's not obvious how to refactor the giant ball of spaghetti in multiple steps 12:21 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 12:21 < ryanofsky> just catching up but my branch has two big commits at the beginning. one is 100% moveonly. one is a bunch of renames 12:21 < ryanofsky> every other commit is small 12:22 < meshcollider> Yeah this has come up in discussion a few times, noone has come up with an alternative to either this or more massive commits 12:22 < jnewbery> ryanofsky: would only merging those first two commits leave us in a bad state (would it be possible to slice those off in their own PR)? 12:23 < jnewbery> I can definitely review move-only/rename commits 12:23 < ryanofsky> merging those two commits would be fine, as far as i know 12:23 < jnewbery> achow101: what do you think about that approach? 12:24 < meshcollider> If we are going to split this PR up a bit, maybe we should feature-freeze the wallet until all the parts are in to avoid things getting messy half way 12:24 < achow101> jnewbery: I haven't looked at russ's branch in detail 12:24 < provoostenator> Maybe the "Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes" can split into one commit that introduces the class, and one that moves the methods over? 12:24 < instagibbs> that's the other thing true, you're going to force people to rebase 2+ times 12:24 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 12:24 < instagibbs> in serious ways 12:25 < meshcollider> Well they can just wait til it's all in ^ 12:25 < ryanofsky> just to clarify my github comment from a few weeks ago, i'm fine if achow's pr is merged as is, i just wouldn't want my ack to be a deciding factor 12:26 < ryanofsky> it's too many scattered changes that i don't fully understand to be confident about all of them 12:26 < jnewbery> That's my main concern (separate from not being able to review it myself):I'm worried that due to the size of this PR, other people who have reviewed it haven't been able to do so in sufficient detail to avoid merging bugs 12:26 < achow101> ryanofsky: I think the only reason acks came in quickly after yours is because they were just waiting for you to be done asking for changes before commenting 12:26 < meshcollider> Yeah it is enormous, I'm feeling the same way 12:27 < ryanofsky> achow101, yes you're right i probably misinterpreted the timing 12:27 < meshcollider> That's why I want to merge it early on in the 0.20 release cycle so we have plenty of time to identify bugs before we get close to a release 12:27 < instagibbs> Yes, I had reviewed once, then waited for velocity to stop, then reviewed the diff between the version I'd reviewed and tip. That said, it deserves more eyes 12:27 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 265 seconds] 12:28 < meshcollider> Smaller PRs would definitely encourage more reviews too 12:28 < ryanofsky> meshcollider, i don't think this has to be an all or nothing thing merged early in the release cycle. you could merge the moves early, and then let all the little behavior changes get reviewed as normal 12:28 < provoostenator> For release cycle it doesn't matter much if we wait another week or two for proof-of-newbery 12:29 < jnewbery> I'm raising it because I'm not getting the sense from any of the reviewers who have ACKed that they're super confident 12:29 < achow101> I can try to break it up further based on ryanofsky's branch as it seems like people are okay with some big moveonlys and renames 12:30 < jnewbery> achow101: thanks! I'll also try to take a look at ryanofsky's version next week 12:30 < achow101> if we want to do it in smaller prs, then I think we should feature freeze the wallet 12:30 < sipa> (speaking as someone who has not looked at the changes in detail, but plans to) big moveonlys are still fairly mechanically verifiable, regardless of size 12:31 < ryanofsky> yeah i think the first big commit which is completely moveonly is basically trivial 12:31 < achow101> (now I just need to find ryanofsky's branch, I seem to be clikcing all the wrong "Load more comments..") 12:31 < ryanofsky> the second big commit which is the "rename" commit is kind of eyeglazing but still boring and reviewable i think 12:31 < MarcoFalke> Can this channel be opened again or at least mention in the title that log in is required? 12:31 < MarcoFalke> People keep running into this issue 12:32 < meshcollider> achow101: I'm happy to do that for a while because otherwise this is going to take forever to get in 12:33 < provoostenator> achow101: https://github.com/ryanofsky/bitcoin/commits/pr/keyman 12:33 < instagibbs> if feature freeze is the plan, I think people should be allowed a window to squeeze in near-merged features :) 12:33 < instagibbs> with heads up 12:34 < instagibbs> unless the freeze is like... a week 12:34 < achow101> I think some large-ish changes could also become scripted-diffs, so that will help review 12:34 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 12:34 < ryanofsky> i'm fine with a feature freeze, but not sure what a feature freeze would be doing... 12:35 -!- JeremyCrookshank [c4c4c03c@196.196.192.60] has joined #bitcoin-core-dev 12:35 < jnewbery> If ryanofsky's branch really is two big commits (that become the first PR) and then a bunch of small commits, I also don't understand the need for a feature freeze 12:35 < jnewbery> it sounds like the disruptive rebasey part would be those first two commits 12:35 < sipa> i think it's simpler to have reviewers lined up for a "it will be merged on day X", and then the PR author can rebase that day exactly, everyone give a final ack, and it's merged 12:35 < jnewbery> and once they're in they're in 12:35 -!- jarthur [~jarthur@207.114.244.5] has quit [Quit: BBL, haircut] 12:35 < ryanofsky> yeah exactly all the commits are small and normal except 2 12:37 < instagibbs> ok provided you think it's only 1 painful break, fine 12:37 < ryanofsky> if the concern is difficulty rebasing the 2 big commits, i've done than several times, and it hasn't been a big deal. can continue to do it if desired 12:37 < instagibbs> let's just do that 12:37 < meshcollider> Alright achow101 happy? 12:37 < achow101> ok 12:38 < meshcollider> Sweet, any other topics? 12:38 < provoostenator> achow101: if you're replacing the branch, please make a new PR... 12:38 < achow101> yes, new prs will be opened 12:38 < jnewbery> thanks! 12:38 < provoostenator> Great, so I don't have to write a Chrome plugin to auto-click "Load More..." 12:38 < meshcollider> Please do that anyway :p 12:39 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds] 12:39 < JeremyCrookshank> Hello? 12:40 < instagibbs> since #16944 got un-scope-creeped, I think it's close to merge (selfish reminder) 12:40 < gribble> https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors . Pull Request #16944 . bitcoin/bitcoin . GitHub 12:40 -!- JJ [c4c4c03c@196.196.192.60] has joined #bitcoin-core-dev 12:40 < instagibbs> JeremyCrookshank, pong 12:40 < JeremyCrookshank> Oh thankgod people can see my messages now 12:40 < JeremyCrookshank> :) 12:40 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Remote host closed the connection] 12:41 -!- JJ [c4c4c03c@196.196.192.60] has quit [Remote host closed the connection] 12:41 < meshcollider> Yep I'm going to take a look at that today instagibbs 12:41 < meshcollider> #endmeeting 12:41 < lightningbot> Meeting ended Fri Oct 25 19:41:15 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:41 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-25-19.00.html 12:41 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-25-19.00.txt 12:41 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-25-19.00.log.html 12:41 < provoostenator> Yes, it can be merged independent of the keypool stuff; it just won't work for keypool-less watch-only wallets. 12:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 12:43 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 12:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:44 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 12:45 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 12:45 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 12:46 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:46 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...] 12:47 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 12:47 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 12:47 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 12:48 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 240 seconds] 12:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:49 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 265 seconds] 12:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 12:49 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 12:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:50 < JeremyCrookshank> How often are the meetings? 12:51 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 12:51 < instagibbs> JeremyCrookshank, wallet meetings i think are every-other Friday, beginning of this hour 12:51 < instagibbs> main meeting is weekly, Thursday, same time 12:51 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:52 < JeremyCrookshank> Thank you :) 12:52 < jnewbery> (scheduled in UTC, so it might be a different local time for you next week depending on where you live) 12:52 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 12:52 < instagibbs> right, iceland time ;) 12:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:53 < achow101> My main concern with using ryanofsky's commits is the second one, it's not just a rename as it does introduce LegacyScriptPubKeyMan and changes some wallet things to use that 12:54 < achow101> maybe it can be broken down further? 12:54 < ryanofsky> for reference, this is https://github.com/ryanofsky/bitcoin/commit/96beb6b80aed453d30f217481dfc10f14c87d200 12:54 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 12:54 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 12:54 < ryanofsky> yes it could be broken down, sjors has suggested doing rpc file separately for example 12:55 < ryanofsky> but everything there is a mechanical change, renaming, wrapping aliasing, no changes in behavior. it's just big 12:55 < ryanofsky> easiest way to see that is to run the git diff commands in the commit description 12:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 13:02 < provoostenator> And maybe also have one commit that introduces the (Legacy)ScriptPubKeyMan class itself 13:03 < achow101> eyeglazing is an understatement for that commit 13:03 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 13:05 -!- ajonas [uid385278@gateway/web/irccloud.com/x-wexulqonszkziral] has joined #bitcoin-core-dev 13:05 < achow101> how many PRs do people want? 2? more? 13:06 < ryanofsky> provoostenator, i wasn't sure what you meant there. the class without the methods would just be an empty class declaration 13:07 < ryanofsky> achow, one awkward thing is those 4 commits before the 2 big ones 13:07 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds] 13:07 < achow101> ryanofsky: yeah, I was going to see if I could break this up such that those 4 would slide in before whatever changes they are required for 13:08 < achow101> may need 4 PRs for that 13:08 < ryanofsky> looking 13:10 < ryanofsky> i wonder if we could just merge those now 13:10 < achow101> I'm also looking to drop or merge together the "unsure if necessary" commits with other commits 13:10 < achow101> also gonna base on mater 13:10 < achow101> *master 13:11 < ryanofsky> otherwise i can update my branch to just put the two big commits first 13:12 < achow101> ryanofsky: I'm pretty sure they can fit in other places. They originally were placed before the commits that required them but moved because semi-unrelated 13:12 < ryanofsky> which "unsure if necessary" commits do you think are good? 13:12 < achow101> https://github.com/ryanofsky/bitcoin/commit/a9ee4ca8060f71b8edc2b4aff685f9dbc3841488 and https://github.com/ryanofsky/bitcoin/commit/0a036d2c4af9ee6b40a2028a789c32bc36b1464a 13:13 < achow101> ScriptPubKeyMan unique_ptr and include 13:14 -!- JeremyCrookshank [c4c4c03c@196.196.192.60] has quit [Remote host closed the connection] 13:14 < ryanofsky> ok why the unique pointer one? it just seems to create a dummy wrapper that doesn't do anything 13:16 < achow101> wrong commit, nvm 13:16 < achow101> include functional is the only one to keep 13:18 < ryanofsky> got it, i understand that one now 13:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:18 < provoostenator> ryanofsky: I meant class with function defitions and maybe noop methods. That way the function bodies can move from one structure to another. But ignore if impractical. 13:19 -!- za-kk [~za_kk@84.246.203.120] has joined #bitcoin-core-dev 13:25 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 245 seconds] 13:26 < ryanofsky> achow101 just updated https://github.com/ryanofsky/bitcoin/commits/pr/keyman, no big change 13:27 < ryanofsky> i just moved the two big commits earlier. i think the first three commits would make a good pr: two moveonlys and the eyeglazing rename 13:29 < ryanofsky> compilation and tests should still pass the whole way through but can reconfirm 13:33 -!- JeremyCrookshank [c4c4c00c@196.196.192.12] has joined #bitcoin-core-dev 13:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:34 < JeremyCrookshank> ping 13:38 < ryanofsky> pong 13:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 13:41 < sipa> pang 13:41 < za-kk> peng 13:45 -!- Hazle51Lowe [~Hazle51Lo@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 13:50 -!- Hazle51Lowe [~Hazle51Lo@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds] 13:52 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 14:00 -!- NikolaiToryzin [~NikolaiTo@172.83.40.52] has quit [] 14:00 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 265 seconds] 14:00 -!- thoragh [~victor@37.120.156.178] has quit [Ping timeout: 276 seconds] 14:02 -!- thoragh [~victor@37.120.156.178] has joined #bitcoin-core-dev 14:03 -!- dviola [~diego@187.39.23.112] has joined #bitcoin-core-dev 14:04 -!- jkczyz_ [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 14:05 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Read error: Connection reset by peer] 14:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:08 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 14:08 -!- dviola [~diego@187.39.23.112] has quit [Changing host] 14:08 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 14:08 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...] 14:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 14:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:09 < bitcoin-git> [bitcoin] achow101 closed pull request #16341: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) (master...box-the-wallet) https://github.com/bitcoin/bitcoin/pull/16341 14:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 14:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:11 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:11 < bitcoin-git> [bitcoin] achow101 opened pull request #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (master...wallet-box-pr-1) https://github.com/bitcoin/bitcoin/pull/17260 14:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:12 < bitcoin-git> [bitcoin] emilengler closed pull request #17256: doc: Change apt-get to apt (master...2019-10-apt-get-to-apt) https://github.com/bitcoin/bitcoin/pull/17256 14:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:12 < achow101> ^^ 1st pr open 14:15 < ryanofsky> thanks, easy ack for me. need to silence the linters thought, i guess 14:17 -!- lahwran [~lahwran@185.103.96.143] has joined #bitcoin-core-dev 14:18 -!- jkczyz_ [~jkczyz@135.84.132.56] has quit [Quit: leaving] 14:18 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:18 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 14:28 < jonatack> JeremyCrookshank: Bitcoin Core IRC meetings info here https://github.com/jonatack/bitcoin-development/blob/master/bitcoin-core-dev-irc-meetings.txt 14:31 < jonatack> JeremyCrookshank: also https://github.com/fanquake/core-review/blob/master/irc.md 14:33 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 264 seconds] 14:34 < achow101> ryanofsky: not all commits compile, so gonna have to make a few changes 14:34 < achow101> also doing some reordering 14:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:35 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 14:38 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...] 14:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 14:42 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 265 seconds] 14:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 14:47 -!- Highway61 [~Thunderbi@96.44.189.138] has joined #bitcoin-core-dev 14:47 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 268 seconds] 15:02 -!- rex4539 [~rex4539@2a02:587:3514:c700:9902:5798:6618:ea35] has joined #bitcoin-core-dev 15:07 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 15:19 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:25 -!- ajonas [uid385278@gateway/web/irccloud.com/x-wexulqonszkziral] has quit [Quit: Connection closed for inactivity] 15:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 15:27 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:29 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 15:31 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:32 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:34 -!- marcoagner [~user@2001:8a0:6a5f:5700:7bb3:6296:d274:7295] has quit [Ping timeout: 245 seconds] 15:40 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 16:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 16:07 -!- ImAFreek [~jonathan@37.183.21.180] has joined #bitcoin-core-dev 16:13 -!- thoragh [~victor@37.120.156.178] has quit [Ping timeout: 240 seconds] 16:16 < JeremyCrookshank> thank you jona 16:16 < JeremyCrookshank> :) 16:17 -!- ImAFreek [~jonathan@37.183.21.180] has quit [Quit: WeeChat 1.9.1] 16:21 -!- JeremyCrookshank [c4c4c00c@196.196.192.12] has quit [Remote host closed the connection] 16:22 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 16:26 -!- za-kk [~za_kk@84.246.203.120] has quit [] 16:31 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Quit: May the Shwartz be with you] 16:33 -!- luigi_ [~luigi@ip68-228-80-222.oc.oc.cox.net] has joined #bitcoin-core-dev 16:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:38 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 16:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 16:54 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 268 seconds] 16:56 -!- lightlike [~lightlike@2001:16b8:571b:d400:f1b9:bff9:dd64:db66] has quit [Quit: Leaving] 16:59 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev 17:00 -!- lahwran [~lahwran@185.103.96.143] has quit [] 17:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:11 -!- Highway61 [~Thunderbi@96.44.189.138] has quit [Ping timeout: 276 seconds] 17:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:17 -!- RC-3004 [~RC-3004@185.103.96.143] has joined #bitcoin-core-dev 17:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 17:18 -!- luigi_ [~luigi@ip68-228-80-222.oc.oc.cox.net] has quit [Read error: Connection reset by peer] 17:22 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 17:22 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 17:23 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has joined #bitcoin-core-dev 17:29 < jeremyrubin> Hey 17:29 < jeremyrubin> I think I found a bug in DynamicUsage 17:29 < jeremyrubin> for unordered_map and unordered_set 17:29 < jeremyrubin> The STL on my machine does an optimization where there's always one bucket (like a prevector) 17:30 < jeremyrubin> This leads to double counting when you have a larger map 17:30 < jeremyrubin> Trying to think of a x-platform way to deal with it... 17:32 < jeremyrubin> this sounds like a thing for sipa to look at :) 17:34 < jeremyrubin> This leads to a nasty-ish bug where when you're trying to track the internal memory of things, you can get an accounting deficit 17:35 < sipa> jeremyrubin: DynamicUsage is inevitaby an approximation on some sysyems 17:36 < sipa> improvememts welcome of course, but it's not possible in general (i think) to exactly know the size of data structures every STL implementation uses 17:36 < sipa> i guess maybe with a custom allocator it could 17:36 < jeremyrubin> One reasonable solution then is to use bucket_count -1 17:36 < sipa> hmm, using a custom allocator to trakc this stuff should be easy 17:37 < jeremyrubin> It will only ever be "off by one" so shouldn't matter too much, but would accurately report 0 allocation for a newly created set 17:37 < jeremyrubin> sipa: I looked at that I don't think it is 17:37 < jeremyrubin> but could be wrong 17:44 < jeremyrubin> I guess something like bucket_count() - (bucket_count() == 1) 17:46 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has quit [Ping timeout: 265 seconds] 17:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 17:57 < jeremyrubin> confirm that that approach fixes *my problem* :) 17:58 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has quit [Quit: Sleep mode] 18:15 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 268 seconds] 18:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 18:32 < luke-jr> sipa: sizeof? 18:36 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 18:36 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:37 < jeremyrubin> sizeof? 18:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 268 seconds] 18:37 < luke-jr> whatever size STL uses, you should be able to get usage using sizeof I would think 18:39 < jeremyrubin> huh 18:39 < jeremyrubin> I don't think so 18:39 < luke-jr> why not? 18:39 < jeremyrubin> So you want to know the size on the stack 18:39 < jeremyrubin> you use sizeof 18:39 < jeremyrubin> but what we want to know is the size of the allocation 18:40 < jeremyrubin> And the reason it's difficult is because there's no way to tell if elements claimed by bucket_count() are on the stack or in the allocation 18:41 < jeremyrubin> When you create a new unordered_map, bucket_count() is not nesc 0 18:41 < jeremyrubin> e.g., implementations can optimize a pre-allocated bucket 18:41 < jeremyrubin> that is a pointer for a single bucket that, once allocated, becomes the pointer for the allocation 18:41 < jeremyrubin> or something like that 18:43 < luke-jr> &(&object)[1] - &object ? 18:44 < jeremyrubin> where object is what? 18:47 < jeremyrubin> the map may be empty... 18:52 < sipa> luke-jr: you don't know what the map allocates 18:52 < luke-jr> hmm 18:52 < sipa> it may allocate a struct { yourtype a; metadata b } object 18:53 < sipa> or it may allocate those in arrays 18:53 < luke-jr> C++ should add something :p 18:53 < sipa> well, allocators 18:53 < sipa> they let you observe the allocations STL containers make (and modify their behabior? 18:53 < sipa> ) 18:54 -!- arik_ [~arik@135.84.132.144] has joined #bitcoin-core-dev 18:55 < luke-jr> hmm 18:55 < jeremyrubin> I think I heard there's an issue with allocators being assumed to be copyable or something funky like that, which can mess with collecting stats from one 18:55 < jeremyrubin> But I don't recall what the issue is 18:59 -!- z56 [1816b470@c-24-22-180-112.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:59 -!- z56 [1816b470@c-24-22-180-112.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 18:59 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 19:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:01 -!- dviola is now known as Guest81850 19:02 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 19:02 -!- arik_ [~arik@135.84.132.144] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...] 19:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 19:08 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 19:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 19:40 -!- felixfoertsch23 [~felixfoer@92.117.52.117] has joined #bitcoin-core-dev 19:41 -!- felixfoertsch [~felixfoer@2001:16b8:5062:400:10ba:d356:7a1b:7ccb] has quit [Ping timeout: 264 seconds] 19:55 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.6] 20:00 -!- RC-3004 [~RC-3004@185.103.96.143] has quit [] 20:01 -!- felixfoertsch [~felixfoer@92.117.61.41] has joined #bitcoin-core-dev 20:04 -!- felixfoertsch23 [~felixfoer@92.117.52.117] has quit [Ping timeout: 268 seconds] 20:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:09 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has joined #bitcoin-core-dev 20:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 20:17 -!- mkrautz1 [~mkrautz@77.243.177.38] has joined #bitcoin-core-dev 20:26 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has quit [Quit: Konversation terminated!] 20:37 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:37 -!- scopeh [~scopeh@148.253.169.2] has quit [Read error: Connection reset by peer] 20:38 -!- scopeh [~scopeh@148.253.169.2] has joined #bitcoin-core-dev 20:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:41 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 20:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 21:04 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 276 seconds] 21:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:13 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection] 21:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 21:20 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 21:24 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 240 seconds] 21:31 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:35 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-ovhvncabocskwwsp] has quit [Quit: Connection closed for inactivity] 21:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 21:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 21:35 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 21:36 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 21:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 22:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:16 < bitcoin-git> [bitcoin] achow101 opened pull request #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple (master...wallet-box-pr-2) https://github.com/bitcoin/bitcoin/pull/17261 22:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 22:27 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 22:28 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 22:46 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 22:53 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds] 22:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:00 -!- mkrautz1 [~mkrautz@77.243.177.38] has quit [] 23:00 < achow101> ryanofsky: I remember now, the unique_ptr signingprovider commit was for descriptor wallets to work 23:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 23:08 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 23:08 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 23:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 23:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 23:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 23:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 23:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 23:17 -!- torax [~torax@185.169.255.76] has joined #bitcoin-core-dev 23:21 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-aeheombnlxewejfr] has joined #bitcoin-core-dev 23:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:39 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 23:43 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 23:44 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 23:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds] --- Log closed Sat Oct 26 00:00:45 2019