--- Log opened Wed Oct 30 00:00:49 2019
00:01 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
00:02 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
00:10 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
00:17 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
00:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:25 < bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17311: build: macOS fix background.svg (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17311
00:25 -!- captjakk [~captjakk@174-16-221-137.hlrn.qwest.net] has joined #bitcoin-core-dev
00:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:25 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
00:37 -!- kabaum [~kabaum@ec2-52-212-246-229.eu-west-1.compute.amazonaws.com] has joined #bitcoin-core-dev
00:53 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 252 seconds]
00:54 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
00:56 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
00:59 -!- kabaum [~kabaum@ec2-52-212-246-229.eu-west-1.compute.amazonaws.com] has quit [Ping timeout: 268 seconds]
01:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:12 -!- kabaum [~kabaum@185.224.57.161] has joined #bitcoin-core-dev
01:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds]
01:20 -!- marcoagner [~user@2001:8a0:6a5f:5700:7bb3:6296:d274:7295] has joined #bitcoin-core-dev
01:22 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 250 seconds]
01:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
01:36 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
01:36 -!- kabaum [~kabaum@185.224.57.161] has quit [Ping timeout: 240 seconds]
01:46 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Quit: Defeated by Superior]
01:47 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
02:00 -!- Guest58618 [~nighmi@139.28.218.198] has quit []
02:08 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
02:10 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:18 -!- jbarnette [~jbarnette@172.83.40.52] has joined #bitcoin-core-dev
02:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:19 < bitcoin-git> [bitcoin] laanwj opened pull request #17312: Improve tracethread usability and trace loadblk thread (master...2019_10_tracedthread) https://github.com/bitcoin/bitcoin/pull/17312
02:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:21 -!- kabaum [~kabaum@93.182.128.34] has joined #bitcoin-core-dev
02:23 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 265 seconds]
02:24 -!- jonatack [~jon@213.152.161.219] has joined #bitcoin-core-dev
02:30 -!- jonatack_ [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
02:30 -!- jonatack [~jon@213.152.161.219] has quit [Ping timeout: 276 seconds]
02:33 -!- jonatack_ [~jon@54.76.13.109.rev.sfr.net] has quit [Client Quit]
02:34 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
02:38 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 252 seconds]
02:39 < wumpus> argh, how do I pass a const std::string to util::ThreadRename(std::string&& name)? https://github.com/bitcoin/bitcoin/pull/17312#pullrequestreview-309065741
02:40 < wumpus> in rust you'd add something like .clone()
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:43 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ecad0a8019fb...5728f88d645c
02:43 < bitcoin-git> bitcoin/master f3b51eb Wladimir J. van der Laan: Fix occurences of c_str() used with size() to data()
02:43 < bitcoin-git> bitcoin/master 5728f88 Wladimir J. van der Laan: Merge #17280: refactor: Change occurences of c_str() used with size() to d...
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:43 < bitcoin-git> [bitcoin] laanwj merged pull request #17280: refactor: Change occurences of c_str() used with size() to data() (master...2019_10_c_str_size) https://github.com/bitcoin/bitcoin/pull/17280
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:44 < elichai2> wumpus: you could "clone" it like `std::string str2(str1);` (pretty sure that will clone the data)
02:44 < wumpus> there must be a 'proper' way right?
02:45 < wumpus> hm maybe just wrapping in std::string(...) would do it
02:45 < elichai2> if you ever find a guide for "idiomatic" C++ please tell me :)
02:46 < wumpus> point taken
02:47 < wumpus> I don't understand why ThreadRename would take a move argument anyhow, it seems a pointless case of over-optimization
02:47 < wumpus> but not going to address that here
02:53 < elichai2> i like that the rust `.clone()` makes it really easy to see all the allocations going on, while in C++ it's way more subtle
02:54 -!- siom_ [~siom@81.92.203.214] has joined #bitcoin-core-dev
02:54 < wumpus> yes, in general rust seems to be better thought out
02:57 -!- tsujp_ [~tsujp@27-33-228-156.tpgi.com.au] has quit [Ping timeout: 240 seconds]
02:59 -!- Highway61 [~Thunderbi@96.44.143.234] has quit [Remote host closed the connection]
02:59 -!- Highway61 [~Thunderbi@96.44.143.234] has joined #bitcoin-core-dev
03:02 -!- tsujp [~tsujp@209.58.131.42] has joined #bitcoin-core-dev
03:05 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
03:14 -!- kabaum [~kabaum@93.182.128.34] has quit [Ping timeout: 276 seconds]
03:15 -!- Highway61 [~Thunderbi@96.44.143.234] has quit [Quit: Highway61]
03:15 -!- Highway61 [~Thunderbi@96.44.143.234] has joined #bitcoin-core-dev
03:24 < wumpus> I guess its whole point is to make it harder to make subtle mistakes and avoid all C++'s footguns
03:26 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
03:27 -!- kabaum [~kabaum@ec2-52-212-246-229.eu-west-1.compute.amazonaws.com] has joined #bitcoin-core-dev
03:30 -!- Highway61 [~Thunderbi@96.44.143.234] has quit [Quit: Highway61]
03:30 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 250 seconds]
03:35 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
03:40 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
03:42 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-lnyvsfuluhmnppdc] has quit [Write error: Connection reset by peer]
03:42 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-mydscrxvgmacwusp] has quit [Write error: Connection reset by peer]
03:43 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-fhnpiotpucahmwmd] has quit [Read error: Connection reset by peer]
03:43 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-syrukgdwexzixmdj] has quit [Remote host closed the connection]
03:43 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-grgltyetnmpqhkvr] has quit [Read error: Connection reset by peer]
03:44 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 240 seconds]
03:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:46 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev
03:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:53 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5728f88d645c...6daddc449555
03:53 < bitcoin-git> bitcoin/master dd94cc4 fanquake: contrib: remove accounts from bash completion
03:53 < bitcoin-git> bitcoin/master 6daddc4 Wladimir J. van der Laan: Merge #17282: contrib: remove accounts from bash completion
03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:54 < bitcoin-git> [bitcoin] laanwj merged pull request #17282: contrib: remove accounts from bash completion (master...update_bash_completion) https://github.com/bitcoin/bitcoin/pull/17282
03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
04:03 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-fdnbpmmhtqyslczq] has joined #bitcoin-core-dev
04:09 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
04:10 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-oqbedvnfddfgeqtr] has joined #bitcoin-core-dev
04:10 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-gfqmdohnpbmclltq] has joined #bitcoin-core-dev
04:10 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-jjdwklahpetblzye] has joined #bitcoin-core-dev
04:10 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-rbspeattjwmleaxm] has joined #bitcoin-core-dev
04:15 -!- kabaum [~kabaum@ec2-52-212-246-229.eu-west-1.compute.amazonaws.com] has quit [Ping timeout: 240 seconds]
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:23 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6daddc449555...f129170b8592
04:23 < bitcoin-git> bitcoin/master 37b8475 Jorge Timon: Chainparams: Use name constants in chainparams initialization
04:23 < bitcoin-git> bitcoin/master f129170 Wladimir J. van der Laan: Merge #17306: refactor: Use name constants in chainparams initialization
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:24 < bitcoin-git> [bitcoin] laanwj merged pull request #17306: refactor: Use name constants in chainparams initialization (master...b20-chain-constants) https://github.com/bitcoin/bitcoin/pull/17306
04:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:34 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
04:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:36 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/f129170b8592...471e5f882907
04:36 < bitcoin-git> bitcoin/master 301bd41 Russell Yanofsky: scripted-diff: Rename InitInterfaces to NodeContext
04:36 < bitcoin-git> bitcoin/master 4d5448c Russell Yanofsky: MOVEONLY: Move NodeContext struct to node/context.h
04:36 < bitcoin-git> bitcoin/master e6f4f89 Russell Yanofsky: Pass NodeContext, ConnMan, BanMan references more places
04:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:36 < bitcoin-git> [bitcoin] laanwj merged pull request #16839: Replace Connman and BanMan globals with NodeContext local (master...pr/noglob) https://github.com/bitcoin/bitcoin/pull/16839
04:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:38 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/471e5f882907...edd9d0781b96
04:38 < bitcoin-git> bitcoin/master 3187934 Wladimir J. van der Laan: cli: Add "headers" and "verificationprogress" to -getinfo
04:38 < bitcoin-git> bitcoin/master edd9d07 Wladimir J. van der Laan: Merge #17302: cli: Add "headers" and "verificationprogress" to -getinfo
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:39 < bitcoin-git> [bitcoin] laanwj merged pull request #17302: cli: Add "headers" and "verificationprogress" to -getinfo (master...2019_10_getinfo) https://github.com/bitcoin/bitcoin/pull/17302
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:44 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-dev
04:53 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
04:53 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has joined #bitcoin-core-dev
04:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
05:00 -!- jbarnette [~jbarnette@172.83.40.52] has quit []
05:03 -!- ExtraCrispy [~ExtraCris@109.163.233.87] has joined #bitcoin-core-dev
05:07 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
05:12 < setpill> wumpus: re #16994 there is no status label that can be applied to "blocked" or "waiting" PRs? not sure how differentiation between "abandoned" and "will be picked up later again after external issues are resolved" is made if both are closed without label.
05:12 < gribble> https://github.com/bitcoin/bitcoin/issues/16994 | contrib: replace deprecated PermissionsStartOnly in systemd init by setpill . Pull Request #16994 . bitcoin/bitcoin . GitHub
05:13 < wumpus> no, there's no label for that; I'm asking you to close the PR instead of doing it myself, because then you can open it again when you deem the time is there
05:13 < setpill> ack
05:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:13 < bitcoin-git> [bitcoin] setpill closed pull request #16994: contrib: replace deprecated PermissionsStartOnly in systemd init (master...fix-deprecated-permissionsstartonly) https://github.com/bitcoin/bitcoin/pull/16994
05:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:14 < wumpus> I guess I can add milestone 'future'
05:15 < wumpus> it's the closest thing, it basically means that it should be revisited at some unspecified time in the future
05:15 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 245 seconds]
05:16 < setpill> personally prefer terminology like "blocked" to indicate this kind of situation. "future" has prioritization connotations that don't really apply to a project like this where people are welcomed to just pop in and out to contribute whatever they feel like contributing :)
05:17 < wumpus> but 'blocked' has 'we should first do some other work' connotations (e.g. "blockers" in high priority for review), usually things are blocked on other things that need to be done
05:17 -!- othe1 [~othe@139.28.218.198] has joined #bitcoin-core-dev
05:18 < setpill> ah, fair point
05:19 < setpill> either is probably fine, before you know it you have 10 different labels for all the subtle variations of this kind of situation
05:20 < setpill> anyway, closed for now, let's hope i remember to revisit it (:
05:22 < wumpus> yes, though I'm sure someone will pick it up as soon as systemd starts rejecting the setting :)
05:26 -!- kabaum [~kabaum@185.224.57.161] has joined #bitcoin-core-dev
05:30 -!- sosthene [~sosthene@88.191.20.124] has quit [Ping timeout: 244 seconds]
05:40 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:45 < jtimon> I've been rebasing a commit similar to https://github.com/bitcoin/bitcoin/pull/16681 for years (which is a bit annoying as new instances appeared) and people are still complaining because it is not complete and more instances may appear.
05:45 < jtimon> On the other hand I created https://github.com/bitcoin/bitcoin/pull/17306 and it was merged in 16 hours, being incomplete and with a nit on it.
05:45 < jtimon> Sometimes I really don't understand the criteria, guys. Not a big deal, but it doesn't seem consistent.
05:46 -!- Highway61 [~Thunderbi@96.44.143.234] has joined #bitcoin-core-dev
05:46 < wumpus> I'm sorry for the whitespace nit but I disagree it is  'incomplete', it's a small change that makes sense
05:47 < wumpus> as I've commented in the PR I think it's a bad idea if you have conceptual and code review on a PR, and two ACKs, to extend the scope, feel free to do the rest in a new PR
05:49 < wumpus> if you did replace all the other occcurences it could have easily have been drawn out to a PR that takes months, because there would be a discussion about what to change and whatnot
05:49 < wumpus> in this case there was general agreement
05:50 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
05:50 < wumpus> maybe you could learn from it and do more small, targeted PRs :)
05:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
05:58 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 245 seconds]
06:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:02 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
06:07 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
06:07 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 240 seconds]
06:10 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
06:10 -!- brianhoffman_ [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has joined #bitcoin-core-dev
06:10 -!- brianhoffman [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has quit [Ping timeout: 265 seconds]
06:10 -!- brianhoffman_ is now known as brianhoffman
06:17 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
06:19 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:29 < bitcoin-git> [bitcoin] laanwj opened pull request #17316: refactor: Replace all uses of boost::optional with our own Optional type (master...2019_10_optional) https://github.com/bitcoin/bitcoin/pull/17316
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:36 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: Connection reset by peer]
06:37 -!- kabaum [~kabaum@185.224.57.161] has quit [Ping timeout: 268 seconds]
06:39 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
06:44 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: Connection reset by peer]
06:47 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
06:48 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: No route to host]
06:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection]
06:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:55 -!- greypw [~greypw@unaffiliated/greypw] has quit [Ping timeout: 265 seconds]
06:55 -!- greypw [~greypw@unaffiliated/greypw] has joined #bitcoin-core-dev
06:55 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has quit [Ping timeout: 264 seconds]
06:57 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has joined #bitcoin-core-dev
06:58 -!- rex4539 [~rex4539@2a02:587:3508:9d00:25be:864b:8144:d2d] has quit [Ping timeout: 276 seconds]
07:00 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev
07:05 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has quit [Ping timeout: 276 seconds]
07:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:06 < bitcoin-git> [bitcoin] adamjonas opened pull request #17318: replace asserts in RPC code with CHECK_NONFATAL and add linter (master...replace-rpc-asserts-for-CHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17318
07:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:12 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
07:15 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
07:15 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/edd9d0781b96...341e8d355d1a
07:21 < bitcoin-git> bitcoin/master d5dbb48 practicalswift: tests: Add fuzzing harness for ISO-8601 related functions
07:21 < bitcoin-git> bitcoin/master 595cc9b practicalswift: docs: Add undefined to --with-sanitizers=fuzzer,address
07:21 < bitcoin-git> bitcoin/master 341e8d3 MarcoFalke: Merge #17291: tests: Add fuzzing harness for ISO-8601 related functions
07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17291: tests: Add fuzzing harness for ISO-8601 related functions (master...fuzzers-parse_iso8601) https://github.com/bitcoin/bitcoin/pull/17291
07:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:23 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/341e8d355d1a...cab94cc07489
07:23 < bitcoin-git> bitcoin/master fa144e6 MarcoFalke: rpc: Add generatetodescriptor
07:23 < bitcoin-git> bitcoin/master cab94cc Wladimir J. van der Laan: Merge #16943: test: Add generatetodescriptor RPC
07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:23 < bitcoin-git> [bitcoin] laanwj merged pull request #16943: test: Add generatetodescriptor RPC (master...1909-rpcMiningDescriptor) https://github.com/bitcoin/bitcoin/pull/16943
07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:36 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:38 < bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/cab94cc07489...3c40bc6726b6
07:38 < bitcoin-git> bitcoin/master a27a295 John Newbery: [validation] Add CValidationState subclasses
07:38 < bitcoin-git> bitcoin/master 067981e John Newbery: [validation] Tidy Up ValidationResult class
07:38 < bitcoin-git> bitcoin/master 1a37de4 John Newbery: [validation] Remove error() calls from Invalid() calls
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:38 < bitcoin-git> [bitcoin] laanwj merged pull request #15921: validation: Tidy up ValidationState interface (master...2019-04-pr15141-cleanups) https://github.com/bitcoin/bitcoin/pull/15921
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:42 -!- rex4539 [~rex4539@2a02:587:3508:9d00:3559:5ec9:a1e8:9b82] has joined #bitcoin-core-dev
07:44 -!- lightlike [~lightlike@2001:16b8:5728:f700:60f7:e4ab:9b1b:7bbf] has joined #bitcoin-core-dev
07:47 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
07:48 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:50 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
07:57 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 268 seconds]
07:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:58 < bitcoin-git> [bitcoin] jnewbery opened pull request #17319: Tests: remove bignum module (master...2019-10-bignum) https://github.com/bitcoin/bitcoin/pull/17319
07:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:59 -!- diogosergio [~diogoserg@195.206.183.104] has joined #bitcoin-core-dev
08:00 -!- othe1 [~othe@139.28.218.198] has quit []
08:08 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
08:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:17 -!- rex4539 [~rex4539@2a02:587:3508:9d00:3559:5ec9:a1e8:9b82] has quit [Quit: rex4539]
08:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:27 -!- diogosergio [~diogoserg@195.206.183.104] has quit [Ping timeout: 252 seconds]
08:28 -!- captjakk [~captjakk@174-16-221-137.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
08:30 -!- diogosergio [~diogoserg@195.206.183.104] has joined #bitcoin-core-dev
08:32 -!- rex4539 [~rex4539@2a02:587:3508:9d00:3559:5ec9:a1e8:9b82] has joined #bitcoin-core-dev
08:34 -!- diogosergio [~diogoserg@195.206.183.104] has quit [Ping timeout: 268 seconds]
08:34 -!- diogoser1io [~diogoserg@195.206.183.104] has joined #bitcoin-core-dev
08:35 -!- otium [~otium@2a01:e35:8b86:2800:607e:a1dd:abc2:fd3a] has joined #bitcoin-core-dev
08:35 -!- otium [~otium@2a01:e35:8b86:2800:607e:a1dd:abc2:fd3a] has quit [Remote host closed the connection]
08:39 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
08:41 -!- davterra [~none@195.242.213.120] has quit [Ping timeout: 246 seconds]
08:43 -!- jarthur [~jarthur@207.114.244.5] has quit [Client Quit]
08:43 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
08:43 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-dev
08:47 < wumpus> rc3 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.19.0/test.rc3/
08:48 < fanquake> ?
08:50 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
08:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
08:55 -!- rex4539 [~rex4539@2a02:587:3508:9d00:3559:5ec9:a1e8:9b82] has quit [Quit: rex4539]
08:57 -!- mdunnio_ [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
08:58 -!- mdunnio_ [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:00 -!- mdunnio_ [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
09:01 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 264 seconds]
09:05 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]
09:10 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:11 < bitcoin-git> [bitcoin] practicalswift opened pull request #17320: Make compiler warn about tautological comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:15 -!- b_b1 [~b_b@185.169.255.76] has joined #bitcoin-core-dev
09:16 -!- JeremyCrookshank [d589196a@213.137.25.106] has joined #bitcoin-core-dev
09:16 < JeremyCrookshank> Hello :)
09:16 < wumpus> hello !
09:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:19 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3c40bc6726b6...a6abc94e9307
09:19 < bitcoin-git> bitcoin/master 1cf9b35 Wladimir J. van der Laan: doc: Add developer note on c_str()
09:19 < bitcoin-git> bitcoin/master a6abc94 Wladimir J. van der Laan: Merge #17281: doc: Add developer note on c_str()
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:19 < JeremyCrookshank> What is the community's consensus on Core GUI? Changing design ect? I saw a few PR's in the past aimed at improving it
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:19 < bitcoin-git> [bitcoin] laanwj merged pull request #17281: doc: Add developer note on c_str() (master...2019_10_c_str_note) https://github.com/bitcoin/bitcoin/pull/17281
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:19 < JeremyCrookshank> or using more advanced QT features?
09:22 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:23 < luke-jr> JeremyCrookshank: minimum Qt version needs to be something available on stable releases of major distros (typically RHEL or Debian are the bottlenecks)
09:23 < luke-jr> and if some people might consider it worse than before, you might have an issue
09:24 < luke-jr> but otherwise should be same as any other improvement: slow moving, but eventually get in
09:24 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
09:25 < sipa> JeremyCrookshank: hard to discuss without knowing what you're talking about
09:25 < wumpus> do you have any specific thing you'd like to work on?
09:25 < wumpus> what kind of more advanced qt features? there's a PR that adds qr code recognition (and would need qtmultimedia), as well as one adding a qml-based GUI for android
09:25 < wumpus> nothing is ruled out if you have a good reason'
09:26 < JeremyCrookshank> I don't have specifics but noted the general design hasn't really changed(not a bad thing). I would love to work on the GUI but still a c++ noob :p
09:26 < luke-jr> I think it's just lack of people focussed on it
09:26 < luke-jr> although otoh someone recently tried to revamp icons and ended up with all of them removed entirely :/
09:26 -!- Highway61 [~Thunderbi@96.44.143.234] has quit [Ping timeout: 276 seconds]
09:26 < JeremyCrookshank> I would love something small to work on on the side on the GUI which would be useful
09:26 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
09:26 < luke-jr> menu icons*
09:26 < JeremyCrookshank> Yeah I saw icons went, quite liked them :)
09:27 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has joined #bitcoin-core-dev
09:27 < wumpus> be careful to not fall into the trap of trying to make a 'cool gui', that's not the point of it, akin to industrial UIs the important thing is that it's hard to make mistakes
09:28 < wumpus> because payments are inherently irreversible
09:28 < luke-jr> wumpus: arguably reversible payments could be done, just nobody cares to :p
09:29 < wumpus> it could be done as a layer on top, but yeah, that's not my point here :)
09:29 < luke-jr> eg, BIP70-workalike + time locked tx
09:31 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
09:32 < JeremyCrookshank> wumpus I understand
09:33 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has quit [Ping timeout: 240 seconds]
09:33 -!- mdunnio_ [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:38 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
09:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:39 < bitcoin-git> [bitcoin] practicalswift closed pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
09:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:42 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
09:48 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:51 -!- rex4539 [~rex4539@2a02:587:3508:9d00:3559:5ec9:a1e8:9b82] has joined #bitcoin-core-dev
09:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:52 < bitcoin-git> [bitcoin] practicalswift reopened pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
09:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:55 -!- ajonas [uid385278@gateway/web/irccloud.com/x-xnlguzztavtmbbma] has joined #bitcoin-core-dev
09:56 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
10:01 -!- diogoser1io [~diogoserg@195.206.183.104] has left #bitcoin-core-dev []
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:01 < bitcoin-git> [bitcoin] instagibbs opened pull request #17322: Fix input size assertion in wallet_bumpfee.py (master...w_bp_assert) https://github.com/bitcoin/bitcoin/pull/17322
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:02 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit []
10:03 < wumpus> the best way to help with the GUI if you're not writing code is probably to help testing open PRs, such as #16966
10:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16966 | ui: make send a wizard by Sjors . Pull Request #16966 . bitcoin/bitcoin . GitHub
10:04 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e5f7:5b8e:caec:35a0] has joined #bitcoin-core-dev
10:05 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
10:05 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
10:05 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
10:10 -!- rex4539 [~rex4539@2a02:587:3508:9d00:3559:5ec9:a1e8:9b82] has quit [Quit: rex4539]
10:11 -!- rex4539 [~rex4539@2a02:587:3508:9d00:3559:5ec9:a1e8:9b82] has joined #bitcoin-core-dev
10:14 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Ping timeout: 260 seconds]
10:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
10:18 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:20 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev
10:20 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
10:20 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:21 < BlueMatt> dongcarl: lol, stop telling me how to fix build system shit...I dont know what any of your comments mean
10:22 -!- JeremyCrookshank [d589196a@213.137.25.106] has quit [Remote host closed the connection]
10:22 < dongcarl> BlueMatt: Lol they were more for cfields and fanquake than for you (since we decided to work on the build system changes on ur PR instead of a separate one)
10:22 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
10:24 < moneyball> I tried to install RC3 but get this message. Anyone else successfully install on Catalina? https://usercontent.irccloud-cdn.com/file/fXdVFAmw/Screen%20Shot%202019-10-30%20at%2010.15.40%20AM.png
10:24 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
10:24 < BlueMatt> I think that gets fixed during the release process via the signing? cfields?
10:26 < jtimon> wumpus: fair enough, makes sense to me
10:27 < moneyball> I've been able to install and run RCs in the past. And, how is a person supposed to test RCs if they cannot run them?
10:27 < BlueMatt> moneyball: you'll probably have to disable some apple security garbage (maybe by installing xcode?)
10:29 < moneyball> BlueMatt: thx will try that. i see i haven't reinstalled xcode after my numerous recent hard drive failures 
10:30 < BlueMatt> moneyball: I mean google it first. gotta indicate to some apple subsystem that you're a developer, I'm sure...
10:31 < moneyball> ok yeah this is a new catalina thing. if you "right click" on the app binary then choose "Open" it will let you run the app
10:33 < moneyball> fyi in case this is useful to cfields or dongcarl when building the signed release version https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution
10:34 < wumpus> I think #15774 is related
10:34 < gribble> https://github.com/bitcoin/bitcoin/issues/15774 | macOS App Notarization . Issue #15774 . bitcoin/bitcoin . GitHub
10:36 < moneyball> that issue was punted to the next release. at minimum we should test the signed final release of .19 on MacOS 
10:36 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 276 seconds]
10:38 < wumpus> I don't think this is a rc versus final issue, the rcs are signed in the same way as final
10:38 < wumpus> you might want to post that screenshot in the issue
10:38 < dongcarl> Yeah my subconscious has been blocking this problem... It seems Apple has gone mad with platform power...
10:39 < wumpus> one of these days it's just not possible to distribute binaries anymore for open source software
10:41 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Read error: Connection reset by peer]
10:43 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
10:45 < dongcarl> So, after a cursory glance... It seems like if we don't want to have to tell users to right click > open, we need to use OSX-only tools...
10:45 < sipa> ugh.
10:46 -!- siom_ [~siom@81.92.203.214] has quit [Ping timeout: 265 seconds]
10:49 < dongcarl> wumpus: I'm not sure if Apple's notarization tools care about reproducibility... So in the worst case it seems we will end up with 2 binary dists for osx: One which is reproducible, but not notarized, and another one which is non-reproducible, but notarized...
10:49 < wumpus> awesome, that'd rule out cross-platform deterministic builds for OSX
10:50 < wumpus> I'm unwilling to upload non-reproducible builds to bitcoin(core).org
10:50 < wumpus> so that's the end of OSX support
10:51 < dongcarl> wumpus: Perhaps we shall discuss this in the meeting tomorrow?
10:51 < wumpus> sure
10:54 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:55 < sipa> dongcarl: can we submit our build for notarization? or does the whole building process need to be built inside the Reality Distortion Field?
10:56 < achow101> I think there's a decent chance that our binaries get rejected by their automatic scanner for being "crypto mining malware"
10:56 < sipa> won't hurt to try
10:57 < sipa> worst case it fails, and we ignore it?
10:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:57 < bitcoin-git> [bitcoin] practicalswift closed pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
10:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:57 -!- Highway61 [~Thunderbi@96.44.143.234] has joined #bitcoin-core-dev
10:57 < dongcarl> sipa: I'm looking into the process right now... I think we can. ryanofsky mentioned that _if_ we can prove to the users that the output of the notarization process comes from our reproducible build process, then it might be okay, since anyone running a Mac is trusting Apple anyway
10:58 -!- setpill [~setpill@unaffiliated/setpill] has left #bitcoin-core-dev ["o/"]
10:58 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
10:58 < sipa> dongcarl: or have a simple way to strip the notarization out, back to the binary that can be compared to the reproducible buils
10:59 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
11:00 -!- b_b1 [~b_b@185.169.255.76] has quit []
11:02 < dongcarl> "After uploading your app, the notarization process typically takes less than an hour."
11:04 < wumpus> I guess the notarization data itself could be handled in the same way detached signatures are handled now
11:04 < wumpus> assuming it's like an additional signature of apple
11:04 < fanquake> Me and Cory have been looking at macOS toolchain issues all day. Can add this to the TODO list..
11:05 < wumpus> the extra waiting time isn't really ap roblem
11:06 < dongcarl> Oh it seems like GateKeeper will contact Apple for the notarization if we don't staple it to the app itself
11:06 < wumpus> (assuming a normal release cycle like this)
11:07 < dongcarl> We _should_ staple it though, for offline people
11:07 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
11:07 < wumpus> so getting apple to greenlight the thing is first priority...
11:07 -!- oriondeimos [~DeimosOri@h104-218-60-117.ip4.unmetered.zone] has joined #bitcoin-core-dev
11:08 < dongcarl> wumpus: yup. Perhaps someone should submit the RC just to see what Apple says?
11:11 < fanquake> Just discussed with Cory and he said "we'll deal with it tomorrow". Might be something to fix for 0.19.1.
11:12 < wumpus> I guess people installing the old releases run into the same problem? or is it based on the signing timestamp?
11:15 -!- oriondeimos [~DeimosOri@h104-218-60-117.ip4.unmetered.zone] has quit [Quit: Leaving]
11:15 < dongcarl> It seems like if you notarize old releases then try to run them, Apple will tell you to update to the latest release: https://developer.apple.com/documentation/xcode/notarizing_your_app_before_distribution#3087722
11:15 < gribble> https://github.com/bitcoin/bitcoin/issues/3087722 | HTTP Error 404: Not Found
11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:20 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a6abc94e9307...08e29473126d
11:20 < bitcoin-git> bitcoin/master d314e8a Wladimir J. van der Laan: refactor: Replace all uses of boost::optional with our own Optional type
11:20 < bitcoin-git> bitcoin/master 08e2947 fanquake: Merge #17316: refactor: Replace all uses of boost::optional with our own O...
11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:21 < bitcoin-git> [bitcoin] fanquake merged pull request #17316: refactor: Replace all uses of boost::optional with our own Optional type (master...2019_10_optional) https://github.com/bitcoin/bitcoin/pull/17316
11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:33 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e5f7:5b8e:caec:35a0] has quit [Quit: Sleep mode]
11:37 -!- mdunnio_ [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
11:40 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 265 seconds]
11:43 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
11:48 -!- slewis [~slewis@141.98.102.235] has joined #bitcoin-core-dev
11:53 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]
11:57 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:00 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
12:02 -!- reallll is now known as belcher
12:04 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
12:09 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
12:11 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Quit: jonatack]
12:11 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
12:14 -!- ExtraCrispy [~ExtraCris@109.163.233.87] has quit [Ping timeout: 276 seconds]
12:14 -!- davterra [~none@195.242.213.120] has quit [Remote host closed the connection]
12:15 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-dev
12:16 -!- davterra [~none@195.242.213.120] has quit [Remote host closed the connection]
12:19 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
12:34 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Read error: Connection reset by peer]
12:37 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-dev
12:38 -!- davterra [~none@195.242.213.120] has quit [Remote host closed the connection]
12:40 -!- adembudak [b0db6428@176.219.100.40] has joined #bitcoin-core-dev
12:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:41 < bitcoin-git> [bitcoin] Sjors closed pull request #17301: gui: enable RPC server by default (master...2019/10/gui-server) https://github.com/bitcoin/bitcoin/pull/17301
12:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:53 -!- diogosergio [~diogoserg@195.206.183.104] has joined #bitcoin-core-dev
13:00 -!- diogosergio [~diogoserg@195.206.183.104] has quit [Quit: leaving]
13:02 -!- diogosergio [~diogoserg@195.206.183.104] has joined #bitcoin-core-dev
13:03 < fanquake> https://pastebin.com/2bkRNMbd
13:04 < fanquake> eh. Wrong window.
13:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
13:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
13:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
13:05 -!- diogosergio [~diogoserg@195.206.183.104] has quit [Client Quit]
13:06 -!- diogosergio [~diogoserg@195.206.183.104] has joined #bitcoin-core-dev
13:06 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
13:09 -!- ajonas [uid385278@gateway/web/irccloud.com/x-xnlguzztavtmbbma] has quit [Quit: Connection closed for inactivity]
13:11 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
13:12 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
13:13 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
13:16 -!- ajonas [uid385278@gateway/web/irccloud.com/x-tajqitbeahtbcgrd] has joined #bitcoin-core-dev
13:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:26 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17324: Update univalue subtree (master...1910-updateUnivalue) https://github.com/bitcoin/bitcoin/pull/17324
13:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:30 < bitcoin-git> [bitcoin] hebasto opened pull request #17325: log: Fix log message for -par=1 (master...20191030-fix-par-log) https://github.com/bitcoin/bitcoin/pull/17325
13:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:31 -!- diogosergio [~diogoserg@195.206.183.104] has quit [Quit: leaving]
13:32 -!- diogosergio [~diogoserg@195.206.183.104] has joined #bitcoin-core-dev
13:40 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.4 - https://znc.in]
13:44 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
13:51 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
13:55 -!- captjakk_ [~captjakk@2607:fb90:6c20:5f25:1128:e009:7b1c:e481] has joined #bitcoin-core-dev
13:59 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 265 seconds]
14:00 -!- slewis [~slewis@141.98.102.235] has quit []
14:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds]
14:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 276 seconds]
14:10 -!- freedomcode [~reardenco@shrugged.reardencode.com] has joined #bitcoin-core-dev
14:11 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
14:11 -!- reardencode [~reardenco@shrugged.reardencode.com] has quit [Ping timeout: 268 seconds]
14:13 -!- adembudak [b0db6428@176.219.100.40] has quit [Remote host closed the connection]
14:13 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
14:16 -!- alko [~alko@cpe-85-10-28-138.static.amis.net] has quit [Ping timeout: 240 seconds]
14:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]
14:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
14:18 -!- alko [~alko@cpe-85-10-28-138.static.amis.net] has joined #bitcoin-core-dev
14:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
14:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
14:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
14:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
14:20 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
14:20 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
14:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
14:23 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
14:23 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
14:31 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has quit [Ping timeout: 276 seconds]
14:33 -!- roconnor [~roconnor@host-104-157-224-248.dyn.295.ca] has joined #bitcoin-core-dev
14:35 -!- davterra [~none@89.187.165.157] has joined #bitcoin-core-dev
14:44 -!- mdunnio_ [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
14:47 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
14:48 -!- Tabmow [~Tabmow@77.243.177.38] has joined #bitcoin-core-dev
14:48 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
14:48 -!- Tabmow is now known as Guest18567
14:51 -!- captjakk_ [~captjakk@2607:fb90:6c20:5f25:1128:e009:7b1c:e481] has quit [Ping timeout: 264 seconds]
14:52 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 268 seconds]
14:53 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving]
15:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
15:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:07 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
15:15 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
15:21 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
15:25 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
15:28 < moneyball> wumpus: i just tried installing .18.1 and it installed without an issue. so only the new signed binaries are affected. (also i don't see the google advanced protection warning with .18.1 like i do with .19.* RCs)
15:28 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 240 seconds]
15:30 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Ping timeout: 276 seconds]
15:32 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:35 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:41 -!- alko [~alko@cpe-85-10-28-138.static.amis.net] has quit [Read error: Connection reset by peer]
15:42 -!- alko [~alko@cpe-85-10-28-138.static.amis.net] has joined #bitcoin-core-dev
15:46 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 250 seconds]
15:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
15:48 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
15:48 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
15:56 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
16:06 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
16:07 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has quit [Quit: gone]
16:08 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
16:08 -!- diogosergio [~diogoserg@195.206.183.104] has quit [Quit: leaving]
16:09 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
16:09 -!- diogosergio [~diogoserg@195.206.183.104] has joined #bitcoin-core-dev
16:48 -!- diogosergio [~diogoserg@195.206.183.104] has quit [Ping timeout: 265 seconds]
16:48 -!- marcoagner [~user@2001:8a0:6a5f:5700:7bb3:6296:d274:7295] has quit [Ping timeout: 264 seconds]
17:00 -!- Guest18567 [~Tabmow@77.243.177.38] has quit []
17:07 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
17:12 -!- Highway61 [~Thunderbi@96.44.143.234] has quit [Ping timeout: 276 seconds]
17:17 -!- krazyj [~krazyj@172.83.40.52] has joined #bitcoin-core-dev
17:19 -!- Netsplit *.net <-> *.split quits: mariorz
17:24 -!- Netsplit over, joins: mariorz
17:30  * luke-jr wonders if it would help to get force-pushes announced here. otoh, might get spammy
17:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
17:45 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
17:55 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
17:56 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:02 -!- davterra [~none@89.187.165.157] has quit [Quit: Leaving]
18:11 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
18:12 -!- captjakk [~captjakk@174-16-221-137.hlrn.qwest.net] has joined #bitcoin-core-dev
18:12 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
18:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:16 -!- oneark [uid254801@gateway/web/irccloud.com/x-uurvwnknmfayorun] has joined #bitcoin-core-dev
18:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
18:23 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
18:49 -!- lightlike [~lightlike@2001:16b8:5728:f700:60f7:e4ab:9b1b:7bbf] has quit [Quit: Leaving]
19:03 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has quit [Ping timeout: 260 seconds]
19:05 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev
19:09 -!- ajonas [uid385278@gateway/web/irccloud.com/x-tajqitbeahtbcgrd] has quit [Quit: Connection closed for inactivity]
19:16 -!- jarthur [~jarthur@2605:6000:1019:4971:c03b:6b82:27bf:8999] has joined #bitcoin-core-dev
19:23 -!- m1rror8955363887 [~m1rror@109.134.206.46] has quit [Quit: Ping timeout (120 seconds)]
19:24 -!- m1rror8955363887 [~m1rror@109.134.206.46] has joined #bitcoin-core-dev
19:25 -!- captjakk [~captjakk@174-16-221-137.hlrn.qwest.net] has quit [Remote host closed the connection]
19:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
19:46 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com]
19:48 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
19:54 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
20:00 -!- krazyj [~krazyj@172.83.40.52] has quit []
20:03 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
20:09 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 240 seconds]
20:09 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
20:17 -!- HaeB1 [~HaeB@139.28.218.198] has joined #bitcoin-core-dev
20:19 -!- felixfoertsch [~felixfoer@i6DFA6414.versanet.de] has joined #bitcoin-core-dev
20:20 -!- felixfoertsch23 [~felixfoer@i6DFA67F9.versanet.de] has quit [Ping timeout: 240 seconds]
20:30 -!- jarthur [~jarthur@2605:6000:1019:4971:c03b:6b82:27bf:8999] has quit [Remote host closed the connection]
20:32 -!- jarthur [~jarthur@2605:6000:1019:4971:c03b:6b82:27bf:8999] has joined #bitcoin-core-dev
21:13 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
21:16 < BlueMatt> uhhhh...hopefully there re exactly 0?
21:28 < jeremyrubin> I force push all the time :| How else do you rebase?
21:28 < BlueMatt> I figured he meant to the repo itself
22:07 -!- jarthur [~jarthur@2605:6000:1019:4971:c03b:6b82:27bf:8999] has quit []
22:09 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
22:17 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
22:20 < sipa> jeremyrubin: what BlueMatt said
22:27 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
22:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
22:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 268 seconds]
22:44 -!- rex4539 [~rex4539@2a02:587:3508:9d00:3559:5ec9:a1e8:9b82] has quit [Quit: rex4539]
23:00 -!- HaeB1 [~HaeB@139.28.218.198] has quit []
23:17 -!- zxiiro_ [~zxiiro_@141.98.102.235] has joined #bitcoin-core-dev
23:33 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
--- Log closed Thu Oct 31 00:00:38 2019