--- Log opened Fri Nov 08 00:00:02 2019
00:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:12 < bitcoin-git> [bitcoin] laanwj opened pull request #17411: doc: Add some better examples for scripted diff (master...2019_11_scripted_diff_examples) https://github.com/bitcoin/bitcoin/pull/17411
00:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:17 -!- chile [54a9f249@p54A9F249.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:18 -!- chile [54a9f249@p54A9F249.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
00:18 -!- chile [54a9f249@p54A9F249.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:24 -!- chile [54a9f249@p54A9F249.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
00:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:25 < bitcoin-git> [bitcoin] Sjors opened pull request #17412: Add Boost::Process to AppVeyor dependencies (master...2019/11/msvc_boost_process) https://github.com/bitcoin/bitcoin/pull/17412
00:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:27 -!- b10c [~Thunderbi@2001:16b8:2ef4:3000:cc07:78de:5a5d:4009] has joined #bitcoin-core-dev
00:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:35 -!- marcoagner [~user@2001:8a0:6a5f:5700:7bb3:6296:d274:7295] has joined #bitcoin-core-dev
00:57 -!- murray [~murray@static.56.37.130.94.clients.your-server.de] has joined #bitcoin-core-dev
00:57 -!- murray is now known as Guest60388
00:57 -!- Guest60388 [~murray@static.56.37.130.94.clients.your-server.de] has left #bitcoin-core-dev []
00:58 -!- murrayn [~murray@unaffiliated/murrayn] has joined #bitcoin-core-dev
01:00 -!- armin76 [~armin76@195.206.169.238] has quit []
01:02 < wumpus> so yes maybe it's better to sort out the linters instead of moving around things in the tree, trying with "good first issue"... https://github.com/bitcoin/bitcoin/issues/17413
01:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:12 < wumpus> is there a way to see what appveyor is currently doing? I see only 'queued' PRs, even under history
01:13 < wumpus> "Current build" is in queued state too
01:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
01:24 < wumpus> BlueMatt:  https://github.com/bitcoin/bitcoin/pull/15382#issuecomment-551451359 kind of reminds me what has bothing me about the rust stuff; I think the build system there also needs to focus on features, not "use rust or not", don't group them on programmings language/dependency; if someone wants to enable a feature that happens to be implemented in rust, request them to install a rust compiler :)
01:25 < wumpus> this is also why we have with-gui, not with-qt
01:28 < wumpus> though admittedly, the default there is auto, which sets it to enabled or not based on whether qt development package is installed, which is used as a proxy for 'is this a headless server or a desktop', I guess ...
01:29 < wumpus> as said I'm somewhat skeptical at those kinds of attempts to detect what the user wants
01:34 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:42 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:45 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:48 -!- n3glv1 [~n3glv@77.243.177.38] has joined #bitcoin-core-dev
02:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:04 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
02:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds]
02:19 < elichai2> wumpus: I actually don't completely on that. for a long time I didn't understood a thing about bitcoin's build system and/or code and I liked that it installed basically everything I could manage (I'm one of those freaks who likes the GUI :) )
02:19 < elichai2> I think currently the build system is bloated with options such that there's no way for a naive user to even *know* what he can enable/disable
02:20 < elichai2> (though maybe auto detection isn't the right answer but splitting features into "normal" and "advanced" is the better answer )
02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:23 < bitcoin-git> [bitcoin] meshcollider pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/2fb6140d585f...99ab3a72c5ff
02:23 < bitcoin-git> bitcoin/master 10b4729 Antoine Riard: Pass block height in Chain::BlockConnected/Chain::BlockDisconnected
02:23 < bitcoin-git> bitcoin/master 5aacc3e Antoine Riard: Add m_last_block_processed_height field in CWallet
02:23 < bitcoin-git> bitcoin/master 9700fcb Antoine Riard: Replace CWalletTx::SetConf by Confirmation initialization list
02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:24 < bitcoin-git> [bitcoin] meshcollider merged pull request #15931: Remove GetDepthInMainChain dependency on locked chain interface (master...2019-04-remove-external-locking) https://github.com/bitcoin/bitcoin/pull/15931
02:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:25 < wumpus> elichai2: sure, but  how does features things based on what dependencies you happen to have installed help with that?
02:26 < wumpus> picking features*
02:26 < elichai2> wumpus: that you somehow ends up with a lot of features that at least some of them you want? :P
02:27 < elichai2> (i.e. I remember installing qt and then compiling core so I can get the GUI, and if I didn't get it I knew my QT is missing)
02:27 < wumpus> like, for example the wallet, we assume someone wants a wallet unless --disable-wallet is provided. I think that is great.
02:27 < wumpus> wouldn't it be wtf if it was determined based on whether someone has bdb headers installed
02:28 < wumpus> no, if you don't have bdb headers installed, and don't provide --disable-wallet, you get a clear message
02:28 < wumpus> so you can choose, you want a wallet and install the headers, or disable it and don't
02:30 < wumpus> a bloated build system is a different problem, and I agree it wouldn't be great if you would have to do that for 500 different things, but choosing automatically based on the phase of the moon just *hides* that problem
02:30 < elichai2> yeah but I think for the wallet 90% of users want it. GUI 50%, and then the rest idk (even those this is 100% guess according to users I know heh)
02:33 < wumpus> for a while I was frustrated that for example, tor wouldn't pass configure unless some documentation building thing is installed, or --no-docs is passed. But I think it makes sense now. Most people (should) want documentation, and having *random documentation generator* not installed doesn't automatically mean you don't.
02:35 < wumpus> and if you really don't, then tell it...
02:35 -!- davterra [~none@195.242.213.120] has quit [Ping timeout: 250 seconds]
02:37 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-dev
02:38 < wumpus> the only thing that makes this behavior somewhat acceptable is the summary at the end of configure :)
02:41 < wumpus> because at least you see what automatic choices it made, before you start building and conclude you're building a GUI you don't want, for ex.
02:48 < elichai2> yeah. if you're already venting, I hate that setting CFLAGS/CPPFLAGS/CC/CXX can sometimes break the configure
02:49 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
02:49 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
02:49 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
02:49 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
03:08 < wumpus> well if you set some insane flags like --no-stdlib that's expected :)
03:34 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Read error: Connection reset by peer]
03:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:57 < elichai2> It happened to me a when I tried to switch a linker but ???
03:58 -!- lightlike [~lightlike@2001:16b8:57ff:c500:3196:c35a:76ec:9c3e] has joined #bitcoin-core-dev
03:59 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has joined #bitcoin-core-dev
04:00 -!- n3glv1 [~n3glv@77.243.177.38] has quit []
04:05 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has quit [Quit: Sleep mode]
04:08 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has joined #bitcoin-core-dev
04:17 -!- hmachado [~hmachado@89.238.178.75] has joined #bitcoin-core-dev
04:41 -!- bastion-tester [~satoshi@pool-108-21-84-253.nycmny.fios.verizon.net] has quit [Quit: ZNC 1.7.4 - https://znc.in]
04:43 -!- bastion-tester [~satoshi@pool-108-21-84-253.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
04:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
04:46 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
04:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:00 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has quit [Quit: Sleep mode]
05:01 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has joined #bitcoin-core-dev
05:13 -!- pinheadmz [~matthewzi@184.75.212.188] has joined #bitcoin-core-dev
05:15 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds]
05:15 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.6]
05:17 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
05:31 -!- pinheadmz [~matthewzi@184.75.212.188] has quit [Quit: pinheadmz]
05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:42 < bitcoin-git> [bitcoin] sipsorcery opened pull request #17416: Appveyor improvement - adds check for all required vcpkg packages (master...check-missing-vcpkgs) https://github.com/bitcoin/bitcoin/pull/17416
05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:45 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99ab3a72c5ff...4a3b6f47cd75
05:45 < bitcoin-git> bitcoin/master 01f45dd Joao Barbosa: wallet: Avoid recursive lock in CWallet::SetUsedDestinationState
05:45 < bitcoin-git> bitcoin/master 0b75a7f Joao Barbosa: wallet: Reuse existing batch in CWallet::SetUsedDestinationState
05:45 < bitcoin-git> bitcoin/master 4a3b6f4 fanquake: Merge #17354: wallet: Tidy CWallet::SetUsedDestinationState
05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:45 < bitcoin-git> [bitcoin] fanquake merged pull request #17354: wallet: Tidy CWallet::SetUsedDestinationState (master...2019-11-setuseddestinationstate) https://github.com/bitcoin/bitcoin/pull/17354
05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:01 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a3b6f47cd75...8021392b825c
06:01 < bitcoin-git> bitcoin/master fad1de6 MarcoFalke: wallet: Remove unused boost::this_thread::interruption_point
06:01 < bitcoin-git> bitcoin/master 8021392 fanquake: Merge #17405: wallet: Remove unused boost::this_thread::interruption_point...
06:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:01 < bitcoin-git> [bitcoin] fanquake merged pull request #17405: wallet: Remove unused boost::this_thread::interruption_point (master...1911-walletNoBoost) https://github.com/bitcoin/bitcoin/pull/17405
06:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:14 < bitcoin-git> [bitcoin] fanquake opened pull request #17417: [0.19] cli: fix -getinfo output when compiled with no wallet (0.19...backport_17368_019) https://github.com/bitcoin/bitcoin/pull/17417
06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:21 < bitcoin-git> [bitcoin] fanquake closed pull request #17412: Add Boost::Process to AppVeyor dependencies (master...2019/11/msvc_boost_process) https://github.com/bitcoin/bitcoin/pull/17412
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:24 < bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17418: Build: add REPO_SLUG to fix errors in forked builds (master...repo-slug) https://github.com/bitcoin/bitcoin/pull/17418
06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:24 -!- shesek [~shesek@185.3.145.80] has joined #bitcoin-core-dev
06:24 -!- shesek [~shesek@185.3.145.80] has quit [Changing host]
06:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
06:27 -!- diogosergio [~diogoserg@176.24.23.243] has joined #bitcoin-core-dev
06:32 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
06:47 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
06:47 -!- Sk8M8 [~jrb@x590e1f00.dyn.telefonica.de] has joined #bitcoin-core-dev
06:48 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
06:53 < michaelfolkson> With the PR review club we often need to look back on old PRs that have been merged (in some cases years ago). Any thoughts (especially from maintainers, long term contributors) on asking questions or adding links/resources on a closed PR for educational purposes? Or is this too noisy and you'd prefer to not have activity on PRs once merged/closed?
06:54 < michaelfolkson> An alternative would be to ask a question on StackExchange referring to a particular PR. That would be preferable right?
06:55 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
06:55 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
06:58 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
06:59 -!- diogosergio [~diogoserg@176.24.23.243] has quit [Ping timeout: 240 seconds]
07:00 -!- hmachado [~hmachado@89.238.178.75] has quit []
07:01 < emilengler> michaelfolkson: We could create a masterthread issue on the main repo
07:01 < emilengler> And then we could link older PRs as well
07:02 < emilengler> If you look the older PR you will se that it got mentioned but IIRC no party will get a notification
07:02 < emilengler> And it is not counted as activity in that PR as well IIRC
07:03 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 246 seconds]
07:06 < michaelfolkson> The no notifications sounds good. What is a masterthread issue though? A issue label "masterthread" which doesn't notify anyone? You'd set up a new issue each time you have a question on a PR? Or an issue is set up mapping to one particular PR and then all discussion for that PR is on that one issue?
07:09 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:14 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
07:16 < michaelfolkson> For anybody who knows about policy language, Miniscript just posted this on Bitcoin StackExchange https://bitcoin.stackexchange.com/questions/91565/what-does-bitcoin-policy-language-offer-the-developer-that-miniscript-doesnt-w
07:16 < instagibbs> ##miniscript is the place 
07:17 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:17 < instagibbs> x-posted the link there
07:17 < michaelfolkson> Ah cool thanks <instagibbs>
07:17 -!- zleap [~zleap@77.243.177.38] has joined #bitcoin-core-dev
07:19 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
07:25 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit []
07:30 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
07:31 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: No route to host]
07:33 -!- kljasdfvv [~flack@p200300D46F014C00E46E11D27C10417E.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
07:38 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds]
08:15 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
08:18 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
08:20 < Bullit> Where Bernstein was a conglomerate in Aberdeen
08:20 -!- diogosergio [~diogoserg@176.24.23.243] has joined #bitcoin-core-dev
08:26 -!- diogosergio [~diogoserg@176.24.23.243] has quit [Ping timeout: 265 seconds]
08:30 -!- 07IAC4NHA [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
08:36 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has quit [Quit: Sleep mode]
08:38 -!- kljasdfvv [~flack@p200300D46F014C0028A0C7B9C0CAF101.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
08:39 < BlueMatt> wumpus: hmmm...could do a experimental-anticensorship-features or so, but there was some discussion of doing a gbt replacement in rust, too
08:39 < BlueMatt> which....
08:40 < BlueMatt> so, leaves me without a *great* name for it
08:40 < BlueMatt> but happy to rename it to something else if you have an idea
08:40 -!- kljasdfvv [~flack@p200300D46F014C0028A0C7B9C0CAF101.dip0.t-ipconnect.de] has quit [Client Quit]
08:44 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has joined #bitcoin-core-dev
08:46 -!- sipsorcery [~sipsorcer@37.228.253.95] has joined #bitcoin-core-dev
08:48 < sipsorcery> @fanquake you around? PR's #17412 and #17416 are a little bit orthogonal.
08:48 < gribble> https://github.com/bitcoin/bitcoin/issues/17412 | Add Boost::Process to AppVeyor dependencies by Sjors . Pull Request #17412 . bitcoin/bitcoin . GitHub
08:49 < gribble> https://github.com/bitcoin/bitcoin/issues/17416 | Appveyor improvement - adds check for all required vcpkg packages by sipsorcery . Pull Request #17416 . bitcoin/bitcoin . GitHub
08:49 < fanquake> sipsorcery: yea
08:50 < sipsorcery> 17416 is a fix to allow new vcpkg's to be added without needing the appveyor cache to be invalidated.
08:50 < sipsorcery> 17412 is adding the specific package boost-process to the list of packages.
08:51 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 276 seconds]
08:52 < fanquake> Yes, but isn't the reason 17412 is required because of the issue 17416 is fixing? Otherwise I don't understand why the boost packages need to be added in advance.
08:52 < sipsorcery> no. at least I don't think so.
08:52 < fanquake> I'd rather not do that, or modify the build docs until the feature that requires them is actually merged.
08:53 < fanquake> Right. So does this mean that you can basically smash appveyors global cache and break all other PR builds just buy opening a new PR with a new dependency?
08:53 < fanquake> *by
08:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:55 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
08:56 < sipsorcery> actually boost-process is being added in 15382. so 17412 seems to be a pre-emptive add to avoid future cache invalidations.
08:56 < sipsorcery> i think i understand what you're getting at now.
08:57 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
08:57 < sipsorcery> as far as the appveyor cache goes it's going to get regularly invalidated due to changes to the build
08:57 < sipsorcery> so it's not something that has to be avoided. it's something to minimise.
08:58 < sipsorcery> so 17416 will allow new packages to be added without manual intervention and avoid unnecessary vcpkg operations when there are no new packages.
08:59 < fanquake> That sounds like an improvement
08:59 < sipsorcery> the addition of boost-process looks like it can wait for 15382.
08:59 < sipsorcery> and 17412 can stay closed.
08:59 < sipsorcery> all good now, thx.
08:59 < fanquake> ?
09:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
09:04 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 250 seconds]
09:08 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
09:08 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
09:08 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
09:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds]
09:25 -!- shesek [~shesek@185.3.145.80] has joined #bitcoin-core-dev
09:25 -!- shesek [~shesek@185.3.145.80] has quit [Changing host]
09:25 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
09:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:26 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #17418: Build: add REPO_SLUG to fix errors in forked builds (master...repo-slug) https://github.com/bitcoin/bitcoin/pull/17418
09:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 265 seconds]
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:31 < bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17389: build: add background.tiff and .pngs to "make clean" (master...make-clean-tiff) https://github.com/bitcoin/bitcoin/pull/17389
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:35 -!- sipsorcery [~sipsorcer@37.228.253.95] has quit [Ping timeout: 240 seconds]
09:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:36 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17420: travis: Rework CACHE_ERR_MSG (master...1911-docTravis) https://github.com/bitcoin/bitcoin/pull/17420
09:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:38 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
09:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:40 < bitcoin-git> [bitcoin] sdaftuar closed pull request #17332: p2p: Proof-of-concept: Improve DoS-resistance to low-work headers chains (master...2019-10-no-checkpoints-cleanedup) https://github.com/bitcoin/bitcoin/pull/17332
09:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:41 -!- sipsorcery [~sipsorcer@37.228.253.95] has joined #bitcoin-core-dev
09:51 -!- 07IAC4NHA [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:59 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
10:00 -!- zleap [~zleap@77.243.177.38] has quit []
10:06 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
10:06 -!- IGHOR [~quassel@93.178.216.72] has quit [Client Quit]
10:08 -!- b10c [~Thunderbi@2001:16b8:2ef4:3000:cc07:78de:5a5d:4009] has quit [Remote host closed the connection]
10:12 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
10:12 -!- IGHOR [~quassel@93.178.216.72] has quit [Client Quit]
10:17 -!- rex4539 [~rex4539@2a02:587:350c:a800:d863:82b4:cc17:157d] has joined #bitcoin-core-dev
10:17 -!- suriro [~suriro@139.28.218.198] has joined #bitcoin-core-dev
10:17 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
10:20 -!- rex4539 [~rex4539@2a02:587:350c:a800:d863:82b4:cc17:157d] has quit [Client Quit]
10:26 -!- b10c [~Thunderbi@2001:16b8:2ef4:3000:28da:8b3c:4dd5:3c6f] has joined #bitcoin-core-dev
10:38 -!- Sk8M8_ [~jrb@x590e1f00.dyn.telefonica.de] has joined #bitcoin-core-dev
10:41 -!- Sk8M8 [~jrb@x590e1f00.dyn.telefonica.de] has quit [Ping timeout: 264 seconds]
10:41 -!- b10c [~Thunderbi@2001:16b8:2ef4:3000:28da:8b3c:4dd5:3c6f] has quit [Quit: b10c]
10:47 -!- b10c [~Thunderbi@2001:16b8:2ef4:3000:28da:8b3c:4dd5:3c6f] has joined #bitcoin-core-dev
10:48 -!- JamesAU [~jamesau@37.75.49.116] has joined #bitcoin-core-dev
10:55 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
10:56 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:56 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
10:58 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has quit [Quit: Konversation terminated!]
10:58 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
10:59 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
10:59 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:59 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
11:00 < meshcollider> #startmeeting
11:00 < lightningbot> Meeting started Fri Nov  8 19:00:13 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
11:00 < achow101> hi
11:00 < jonatack> hi
11:00 < kanzure> hi
11:00 < meshcollider> Topics?
11:00 < jnewbery> hi
11:00 < achow101> how goes the wallet boxes review?
11:01 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
11:02 < jonatack> Suggested topic: deprecating getaddressinfo label in favor of labels, and adding multiple labels associated with an address (currently only one)
11:02 < phantomcircuit> hi
11:03 < achow101> jonatack: is it useful to have multiple labels with an address?
11:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds]
11:03 < meshcollider> #topic deprecating getsddressinfo label (jonatack)
11:04 < instagibbs> oh yeah, clocks changed
11:04 < jonatack> achow101: it seems to have been planned to be done
11:04 < jonatack> being the reason for adding the labels field?
11:04 < jonatack> in addition to the label field
11:04 < jonatack> which causes app developer confusion
11:04 < jonatack> see rationale in https://github.com/bitcoin/bitcoin/pull/17283/
11:05 < achow101> oh, i see
11:05 < jonatack> app devs wonder which field should be consumed, label or labels[]
11:05 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds]
11:05 -!- lightlike [~lightlike@2001:16b8:57ff:c500:3196:c35a:76ec:9c3e] has quit [Remote host closed the connection]
11:06 < sipa> oh
11:06 < meshcollider> I didn't even notice labels was added
11:07 < luke-jr> me either
11:07 < jonatack> was added by jnewbery i believe? https://github.com/bitcoin/bitcoin/pull/12892
11:07 < jonatack> er, label
11:08 < jonatack> right, label[] has no tests, so added in 17283
11:08 < jonatack> labels[]*
11:08 < achow101> ack deprecating label
11:08 < sipa> is there a use case for having multiple labels per address?
11:09 < meshcollider> jnewbery: what use case did you have in mind
11:09 < sipa> i don't object, but just because we merged an API that is extensible enough to support it doesn't mean it's needed
11:09 < sipa> as in: support can be added whenever there is a use case for it
11:09 < jnewbery> meshcollider: just refreshing my memory now!
11:10 < jnewbery> logically to me, it makes sense to be able to associate multiple labels to an address
11:10 < jnewbery> From 12892: "labels are
11:10 < jnewbery> associated with addresses, instead of addresses associated with labels. (unlike
11:10 < jnewbery> with accounts.)"
11:11 < jnewbery> I picked up that work from an older wumpus PR, and I can't remember all the details right now
11:11 < luke-jr> I mean, it makes sense if people want to do short labels like GitHub does for PRs
11:11 < jonatack> some reasons in https://github.com/bitcoin/bitcoin/pull/12892#issuecomment-379016369
11:11 < jnewbery> I'll review jonatack's suggested changes in #17283
11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/17283 | rpc: improve getaddressinfo test coverage, help, code docs by jonatack . Pull Request #17283 . bitcoin/bitcoin . GitHub
11:11 < meshcollider> Yeah that's true actually
11:11 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
11:12 < luke-jr> when I do my taxes, I take the label and match multiple regexs to extract metadata - having separate labels could simplify it
11:12 < meshcollider> if it's not an enormous change to support multiple labels then concept ack
11:12 < luke-jr> that being said, there is always a primary label, so maybe we should keep / should have kept it
11:12 < jnewbery> There's no concept of a primary label
11:12 < luke-jr> eg, "bought my pet hamster" isn't likely to have more than one tx
11:12 < luke-jr> jnewbery: maybe there should be
11:13 < meshcollider> Depends if label is for categorising or label is for describing I guess
11:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
11:14 < luke-jr> I've always used it for the latter, with the former thrown in
11:14 < luke-jr> categories without a description has limited usability
11:15 < luke-jr> I'd suggest instead a "notes" with the description part, but .. we've had label for years
11:15 < jnewbery> jonatack: I'll take a look at the PR and give concept feedback
11:15 < jonatack> luke-jr: say, ability to designate one of the labels as a primary, and one only? 
11:15 < achow101> I think having multiple labls would be somewhat invasive due to all of the legacy accounts stuff associated with labels
11:15 < jonatack> jnewbery: ty
11:16 < meshcollider> I mean, I don't think it matters if the distinction is in the code. Supporting multiple labels allows the user to do whatever they like with them, I don't think it needs a "primary" one
11:17 < meshcollider> Ok yeah this can be discussed in the PR
11:17 < meshcollider> Other topics?
11:17 < jonatack> a) it seems we should decide re multiple labels before deprecating
11:17 < luke-jr> jonatack: maybe
11:18 < luke-jr> achow101: maybe rename "labels" to "tags"?
11:18 < jonatack> b) back to a) :D
11:18 < meshcollider> Please not another rename lol
11:19 < luke-jr> what's the "labels" PR?
11:19 < sipa> #12892
11:19 < gribble> https://github.com/bitcoin/bitcoin/issues/12892 | [wallet] [rpc] introduce label API for wallet by jnewbery . Pull Request #12892 . bitcoin/bitcoin . GitHub
11:19 < luke-jr> PR description doesn't suggest it does that.. :/
11:21 < achow101> luke-jr: i don't think there's a PR yet
11:21 < luke-jr> ok, so it adds a "labels" array with only one possible value
11:21 < jnewbery> next topic?
11:22 < meshcollider> achow101: is there anything you want to discuss about boxes or just review beg?
11:22 < achow101> review beg
11:22 < jonatack> (yes it is indeed https://github.com/bitcoin/bitcoin/pull/12892 despite the PR name)
11:23 < jonatack> luke-jr: right
11:23 < meshcollider> #16944 is finally nearly ready too which is nice, hopefully we can get it in after provoostenator rebases 
11:23 < gribble> https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors . Pull Request #16944 . bitcoin/bitcoin . GitHub
11:24 < meshcollider> Alright no other topics then :)
11:24 < meshcollider> #endmeeting
11:24 < lightningbot> Meeting ended Fri Nov  8 19:24:49 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:24 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-08-19.00.html
11:24 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-08-19.00.txt
11:24 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-08-19.00.log.html
11:26 < jnewbery> thanks for merging 15931 meshcollider!
11:26 < jnewbery> next one in that sequence is #16426, which ariard can rebase now
11:26 < gribble> https://github.com/bitcoin/bitcoin/issues/16426 | Reverse cs_main, cs_wallet lock order and reduce cs_main locking by ariard . Pull Request #16426 . bitcoin/bitcoin . GitHub
11:26 < jnewbery> it's a really fun change to reverse the cs_main-cs_wallet lock order
11:26 < jonatack> achow101: review beg for https://github.com/bitcoin/bitcoin/pull/17261 ?
11:27 < meshcollider> jonatack: review beg for all his open wallet PRs :p
11:27 < achow101> #17373
11:27 < gribble> https://github.com/bitcoin/bitcoin/issues/17373 | wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet by achow101 . Pull Request #17373 . bitcoin/bitcoin . GitHub
11:28 < meshcollider> jnewbery: sounds good, review beg for that too then 
11:28 < jonatack> thanks
11:28 < achow101> it'd be nice to merge these so I don't have to rebase the same PRs every day
11:29 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has quit [Quit: Sleep mode]
11:32 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
11:33 < ryanofsky> i have never understood what "labels are associated with addresses, instead of addresses associated with labels" means
11:33 < ryanofsky> "bob is associated with mary, but mary is not associated with bob." huh?
11:34 < meshcollider> It means it's not bijective, there is no well defined label -> address map
11:35 < meshcollider> Because multiple addresses can have the same label
11:35 < sipa> meshcollider: that was the case with accounts too
11:35 < meshcollider> Yeah
11:36 < jnewbery> one address couldn't have multiple accounts. It was always intended that one address could have multiple labels
11:36 < sipa> i always assumed it meant "you should think as labels being the property of an address" rather than "a label is a collection of addresses"
11:36 < jnewbery> sipa: +1
11:38 < ryanofsky> so "X is associated with Y" means "a Y can only have one X"
11:38 < meshcollider> Who knows, associated probably isn't the best word 
11:38 < jnewbery> ryanofsky: if the 'associated with' doesn't make sense for you, just use sipa's definition
11:39 < ryanofsky> of course, yeah, i was just wondering how that associated thing that i see repeated made sense to anyone
11:41 < jnewbery> I copied it in my PR descript from wumpus's original PR because it made sense to me, but I don't think it's used in any user-facing documentation
11:41 < jonatack> I saw it as analogous to relational databases: has one relation vs belongs to relation
11:41 < jnewbery> release notes are here: https://github.com/bitcoin/bitcoin/blob/8021392b825c74312173f15eb937ba6d4aec3841/doc/release-notes/release-notes-0.17.0.md#L149
11:43 -!- b10c [~Thunderbi@2001:16b8:2ef4:3000:28da:8b3c:4dd5:3c6f] has quit [Ping timeout: 250 seconds]
11:43 < jamesob> sounds like an indexing thing: you can look up the labels associated with an address easily, but you cannot look up the addresses associated with a label easily (even though in reality it's probably quick to build that index ad hoc depending on the size of the wallet)
11:44 < luke-jr> jamesob: that's the technical side
11:44 < luke-jr> on the abstract side, a label isn't a container; it doesn't "have" transactions/addresses
11:44 < luke-jr> it's a property of those transactions
11:44 < luke-jr> so you can conceptually search for all transactiosn with a label, but not view the contents of a label
11:45 < jamesob> curious, what're the contents of a label if not the associated txns?
11:45 < jnewbery> luke-jr: yep, labels don't have a balance
11:45 < luke-jr> there are no contents, that's the point
11:45 < jamesob> gotcha
11:45 < luke-jr> it's like putting a sticker on something
11:46 < luke-jr> sure, you can find all objects with the sticker, but asking for the contents of such a sticker is silly
11:48 < meshcollider> So a sticker is associated with the thing it's stuck on, but the thing it's stuck on isn't associated with the  sticker
11:54 -!- Sk8M8 [~jrb@x590e1f00.dyn.telefonica.de] has joined #bitcoin-core-dev
11:58 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 276 seconds]
11:58 -!- Sk8M8_ [~jrb@x590e1f00.dyn.telefonica.de] has quit [Ping timeout: 276 seconds]
12:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:12 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/7358ae6d71cd...84908668a0a8
12:12 < bitcoin-git> bitcoin/0.19 2a15679 fanquake: doc: reintegrate release notes from wiki
12:12 < bitcoin-git> bitcoin/0.19 8bca3ce fanquake: doc: add macOS DMG opening note to release notes
12:12 < bitcoin-git> bitcoin/0.19 8490866 Wladimir J. van der Laan: Merge #17403: doc: reintegrate 0.19.0 release notes
12:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:12 < bitcoin-git> [bitcoin] laanwj merged pull request #17403: doc: reintegrate 0.19.0 release notes (0.19...reintegrate_relnotes_019) https://github.com/bitcoin/bitcoin/pull/17403
12:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:16 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/84908668a0a8...42414bfd0547
12:16 < bitcoin-git> bitcoin/0.19 42414bf Wladimir J. van der Laan: build: set CLIENT_VERSION_RC to 0 pre-final
12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:17 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
12:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:19 < bitcoin-git> [bitcoin] laanwj pushed tag v0.19.0: https://github.com/bitcoin/bitcoin/compare/v0.19.0
12:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:20 -!- Cordia59Bahringe [~Cordia59B@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
12:20 < fanquake> ?
12:20 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
12:22 < jonatack> \o/
12:27 -!- Cordia59Bahringe [~Cordia59B@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds]
12:29 -!- Casper39Mertz [~Casper39M@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
12:29 -!- davterra [~none@195.242.213.120] has quit [Ping timeout: 240 seconds]
12:29 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
12:34 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Read error: Connection reset by peer]
12:37 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
12:37 -!- Casper39Mertz [~Casper39M@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 276 seconds]
12:40 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:44 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
12:47 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving]
12:53 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
12:59 -!- reallll is now known as belcher
13:00 -!- suriro [~suriro@139.28.218.198] has quit []
13:04 < MarcoFalke> \o/
13:04 < MarcoFalke> Could add the release notes to https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.19.0.md ?
13:08 < wumpus> yes, that's one of the next steps, I usually do that before the uploading the binaries (e.g. after the gitian process), but it doesn't really matter if it's a little sooner I guess
13:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:10 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8021392b825c...9e0aabe50cbb
13:10 < bitcoin-git> bitcoin/master fa56bcb MarcoFalke: ci: Run CI_WAIT only on travis
13:10 < bitcoin-git> bitcoin/master fa8a60b MarcoFalke: ci: Run non-cross-compile builds natively
13:10 < bitcoin-git> bitcoin/master faf757a MarcoFalke: ci: Guess the native host when not cross compiling
13:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:10 < bitcoin-git> [bitcoin] laanwj merged pull request #17367: ci: Run non-cross-compile builds natively (master...1911-ciNative) https://github.com/bitcoin/bitcoin/pull/17367
13:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:14 -!- Highway61 [~Thunderbi@96.44.189.90] has joined #bitcoin-core-dev
13:15 -!- Sk8M8_ [~jrb@x590e1f00.dyn.telefonica.de] has joined #bitcoin-core-dev
13:18 -!- Sk8M8 [~jrb@x590e1f00.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
13:19 < fanquake> wumpus I'll save you the trouble
13:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:21 < bitcoin-git> [bitcoin] fanquake opened pull request #17422: doc: add historical 0.19.0 release notes (master...add_019_relnotes) https://github.com/bitcoin/bitcoin/pull/17422
13:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:24 -!- Sk8M8_ [~jrb@x590e1f00.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
13:32 < wumpus> fanquake: thanks!
13:37 -!- pinheadmz [~matthewzi@23.226.129.174] has joined #bitcoin-core-dev
13:44 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
13:50 -!- tomatopotato [~tomatopot@139.28.218.198] has joined #bitcoin-core-dev
13:51 -!- lightlike [~lightlike@2001:16b8:57ff:c500:3196:c35a:76ec:9c3e] has joined #bitcoin-core-dev
14:00 -!- pinheadmz [~matthewzi@23.226.129.174] has quit [Quit: pinheadmz]
14:02 -!- pinheadmz [~matthewzi@23.226.129.174] has joined #bitcoin-core-dev
14:06 < jnewbery> wumpus fanquake MarcoFalke: I think #15934 is ready for merge. ACKs on the head commit 083c954 from ariard, jamesob and jnewbery. Also ACKs on previous versions from fjahr and jonatack.
14:06 < gribble> https://github.com/bitcoin/bitcoin/issues/15934 | Merge settings one place instead of five places by ryanofsky . Pull Request #15934 . bitcoin/bitcoin . GitHub
14:09 < jamesob> not to mention 15934 is tested to death
14:12 -!- Highway61 [~Thunderbi@96.44.189.90] has quit [Ping timeout: 246 seconds]
14:16 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
14:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
14:19 -!- pinheadmz [~matthewzi@23.226.129.174] has quit [Quit: pinheadmz]
14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:21 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e0aabe50cbb...adceca2ba56a
14:21 < bitcoin-git> bitcoin/master fec230e fanquake: doc: add historical 0.19.0 release notes
14:21 < bitcoin-git> bitcoin/master adceca2 Wladimir J. van der Laan: Merge #17422: doc: add historical 0.19.0 release notes
14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:21 < bitcoin-git> [bitcoin] laanwj merged pull request #17422: doc: add historical 0.19.0 release notes (master...add_019_relnotes) https://github.com/bitcoin/bitcoin/pull/17422
14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:23 < bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/adceca2ba56a...a7aec7ad9794
14:23 < bitcoin-git> bitcoin/master dc8e1e7 Russell Yanofsky: Clarify emptyIncludeConf logic
14:23 < bitcoin-git> bitcoin/master 5a84aa8 Russell Yanofsky: Rename includeconf variables for clarity
14:23 < bitcoin-git> bitcoin/master e2e37cf Russell Yanofsky: Remove includeconf nested scope
14:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:24 < bitcoin-git> [bitcoin] laanwj merged pull request #15934: Merge settings one place instead of five places (master...pr/mergeset) https://github.com/bitcoin/bitcoin/pull/15934
14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:26 < jnewbery> thanks wumpus!
14:28 < wumpus> thanks for improving the horror that is bitcoin core option parsing a bit :)
14:29 < midnight> inb4 option parsing gets its own scripting language
14:33 < wumpus> midnight: hah, I know you're joking, but I don't think a lack of flexibility was ever the problem, just that the code is a mess and problems are silently ignored... but also we've come a long way from #1044
14:33 < gribble> https://github.com/bitcoin/bitcoin/issues/1044 | Problems with command-line options silently ignored . Issue #1044 . bitcoin/bitcoin . GitHub
14:35  * jamesob waits for TheBlueMatt to suggest porting options parsing to rust
14:35 < wumpus> it's, a good lesson for new projects, get these things designed well in the first release, if not you're going to spend years cleaning up the mess while competing with PRs that add functionality etc
14:38 < wumpus> jamesob: lol
14:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:39 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17423: ci: Make ci system read-only on the git work tree (master...1911-ciRo) https://github.com/bitcoin/bitcoin/pull/17423
14:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:47 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:52 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 240 seconds]
14:54 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
14:55 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
14:56 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
14:56 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
15:01 -!- murrayn [~murray@unaffiliated/murrayn] has quit [Ping timeout: 268 seconds]
15:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
15:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
15:16 -!- jungly [~quassel@79.8.200.97] has quit [Ping timeout: 264 seconds]
15:26 < harding> FYI, BitcoinCore.org isn't updating when new commits are merged.  I DM'd BlueMatt a while ago, but I guess he's not around.  I'm not sure who else has access to the server to debug it (this happens from time to time, but I'm not sure what can BlueMatt usually kicks to get things restarted).
15:33 < midnight> wumpus: Only half joking. Complex options are heading that way, it seems to me. At some point *behaviour* of programs with complex options it seems to me might be helpful to be reactive or capable of simple decision-making
15:34  * midnight shudders at the future
15:38 < wumpus> harding: strange, I don't have access immediately either but probably we need to poke whatever does updates
15:39 < emilengler> harding: Btw why is bitcoincore.org not hosted at github
15:40 < harding> BlueMatt: is looking into it now.
15:40 < wumpus> emilengler: cuuursed idea
15:41 < emilengler> What's wrong with GH pages? It adds an extra layer of transparency
15:41 < emilengler> Well you can't really do server side stuff though
15:42 < sipa> emilengler: we really don't want to rely on github's security for distribution of binaries
15:43 < sipa> if anything, the degree to which we depend on github already is scary
15:43 < wumpus> midnight: I don't know, I dont' think *that* is so bad with bitcoin core. I do have experiences like that with things like printer settings though, where the software tries to 'intelligently' guess what your're trying to do, correcting for some settings, so at some point you need to make second-order guesses so that the software will make the correct guess and eventually send the right value to the
15:43 < wumpus> hardware
15:43 < emilengler> sipa: +1 but GH can't fake PGP signatures and if the users aren't verifying it it is pretty much their own fault IMO
15:44 < sipa> emilengler: whether you like it or not, reality is that very few users verify PGP signatures
15:45 < harding> emilengler: I don't have any data on BitcoinCore.org, but back when the binaries were exclusively hosted on Bitcoin.org, there was less than 1% as many downloads of SHA256SUMS.asc than there was of the binary files.
15:45 < wumpus> but no, we're not going to trust github for hosting the website as well as hosting the repository
15:45 < wumpus> one thing is enough
15:46 < emilengler> Btw why isn't the repo hosted on the server then
15:46 < wumpus> probably too much, anyhow, but let's not argue for making things worse
15:46 < emilengler> ok
15:47 < wumpus> in a far future I'm imagine we can reduce our dependency on github.com, but we're at least not trying to increase it
15:49 < wumpus> (and yes, the bitcoincore.org server update verifies GPG signatures on commits independently, so someone compromising the github repository doesn't automatically compromise the website)
15:52 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
15:56 < midnight> neat
15:57 < midnight> I verify PGP signatures (most of the time!)
16:00 -!- tomatopotato [~tomatopot@139.28.218.198] has quit []
16:05 < emilengler> IMO we should add a fat red banner to tell the users that they should really verify there downloads
16:05 < harding> wumpus: FYI, release PR for BitcoinCore.org: https://github.com/bitcoin-core/bitcoincore.org/pull/679
16:12 -!- marcoagner [~user@2001:8a0:6a5f:5700:7bb3:6296:d274:7295] has quit [Ping timeout: 264 seconds]
16:17 -!- variable [~variable@139.28.218.198] has joined #bitcoin-core-dev
16:18 -!- variable is now known as Guest32262
16:47 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:10 < bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17424: doc:Travis CI note on Build Timeouts (master...travis-note) https://github.com/bitcoin/bitcoin/pull/17424
17:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:17 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
17:27 -!- murray [~murray@static.56.37.130.94.clients.your-server.de] has joined #bitcoin-core-dev
17:27 -!- murray is now known as Guest69470
17:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:28 -!- Guest69470 [~murray@static.56.37.130.94.clients.your-server.de] has left #bitcoin-core-dev []
17:28 -!- murrayn [~murray@unaffiliated/murrayn] has joined #bitcoin-core-dev
17:29 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
17:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:33 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds]
18:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
18:02 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:06 -!- lightlike [~lightlike@2001:16b8:57ff:c500:3196:c35a:76ec:9c3e] has quit [Quit: Leaving]
18:06 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 276 seconds]
18:07 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]
18:21 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
18:25 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
18:36 -!- Deacydal is now known as deacyde
18:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
18:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
18:52 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 252 seconds]
19:00 -!- Guest32262 [~variable@139.28.218.198] has quit []
19:11 -!- felixfoertsch23 [~felixfoer@2001:16b8:5067:1900:7da1:821:357:7d39] has joined #bitcoin-core-dev
19:12 -!- felixfoertsch [~felixfoer@2001:16b8:50c1:f100:7da1:821:357:7d39] has quit [Ping timeout: 245 seconds]
19:15 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
19:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:17 -!- greynix [~greynix@172.83.40.52] has joined #bitcoin-core-dev
19:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
19:22 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
19:27 -!- echonaut2 [~echonaut@46.101.192.134] has quit [Remote host closed the connection]
19:27 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 265 seconds]
19:27 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev
19:28 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
19:31 -!- JamesAU [~jamesau@37.75.49.116] has quit [Remote host closed the connection]
19:33 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 250 seconds]
19:38 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
19:47 -!- JamesAU [~jamesau@37.75.49.116] has joined #bitcoin-core-dev
19:48 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Read error: Connection reset by peer]
19:48 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
19:52 -!- JamesAU [~jamesau@37.75.49.116] has quit [Ping timeout: 265 seconds]
20:17 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]
20:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
20:30 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
20:46 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
20:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
21:16 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 276 seconds]
21:19 -!- felixfoertsch23 [~felixfoer@2001:16b8:5067:1900:7da1:821:357:7d39] has quit [Quit: ZNC 1.7.3 - https://znc.in]
21:19 -!- felixfoertsch [~felixfoer@2001:16b8:5067:1900:75b5:5215:ae89:a6cb] has joined #bitcoin-core-dev
21:25 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has quit [Ping timeout: 260 seconds]
21:27 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev
21:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
21:45 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
21:45 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has joined #bitcoin-core-dev
21:45 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
22:00 -!- greynix [~greynix@172.83.40.52] has quit []
22:00 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has quit [Quit: Sleep mode]
22:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
22:17 -!- spake [~spake@141.98.102.235] has joined #bitcoin-core-dev
22:20 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
22:24 -!- qubenix [~qubenix@66.172.11.228] has quit [Quit: quit]
22:30 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
22:36 -!- qubenix [~qubenix@66.172.11.228] has joined #bitcoin-core-dev
22:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
22:50 -!- qubenix [~qubenix@66.172.11.228] has quit [Quit: quit]
23:06 -!- qubenix [~qubenix@66.172.11.228] has joined #bitcoin-core-dev
23:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:18 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 240 seconds]
23:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]
23:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
--- Log closed Sat Nov 09 00:00:02 2019