--- Log opened Sat Nov 23 00:00:17 2019
00:03 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
00:04 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds]
00:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
00:14 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
00:14 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 250 seconds]
00:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
00:28 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
00:28 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit]
00:29 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
00:29 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
00:30 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
00:30 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
00:34 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
00:34 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
00:37 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
00:41 -!- reallll is now known as belcher
00:41 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Ping timeout: 240 seconds]
00:41 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
00:42 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
00:44 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
00:44 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit]
00:51 < meshcollider> achow101: I'm not sure why my test passes but yours doesn't 
00:52 < meshcollider> I'm sure I've built the right one and running the right test ?
00:52 < meshcollider> Can someone else test #17568 quickly pls
00:52 < gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 . Pull Request #17568 . bitcoin/bitcoin . GitHub
00:55 -!- sipsorcery [~sipsorcer@37.228.255.208] has joined #bitcoin-core-dev
00:58 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
00:59 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
01:00 -!- mmf [~mmf@185.204.1.185] has quit []
01:00 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
01:01 -!- schmidty [sid297174@gateway/web/irccloud.com/x-xuurqbzdynbubgql] has quit [Ping timeout: 264 seconds]
01:03 -!- midnight [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
01:04 -!- schmidty [sid297174@gateway/web/irccloud.com/x-iawktsydxwbwzjlt] has joined #bitcoin-core-dev
01:10 < wumpus> sure i'll test
01:12 < wumpus> meshcollider: I get "test_framework.authproxy.JSONRPCException: Fee exceeds maximum configured by -maxtxfee (-4)" on master with the new test
01:13 < meshcollider> Hmm ok it must be something on my end then
01:13 < wumpus> isn't that what you expected?
01:14 < meshcollider> It's what is supposed to happen yeah, but it passed when I ran it lol
01:14 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
01:14 < wumpus> strange!
01:14 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
01:15 < wumpus> now tried to run it a few times, it seems reproducible, rpc_fundrawtransaction.py fails every time
01:16 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
01:17 -!- aljungberg [~aljungber@139.28.218.198] has joined #bitcoin-core-dev
01:19 < wumpus> after recompiling with #17568 it passes
01:19 < gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 . Pull Request #17568 . bitcoin/bitcoin . GitHub
01:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
01:23 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
01:27 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
01:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
01:28 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 252 seconds]
01:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:33 < bitcoin-git> [bitcoin] laanwj opened pull request #17569: build: Allow export of environ symbols (master...2019_11_environ) https://github.com/bitcoin/bitcoin/pull/17569
01:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:33 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
01:34 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 252 seconds]
01:36 < wumpus> fanquake: hopefully #17569 is the last step
01:36 < gribble> https://github.com/bitcoin/bitcoin/issues/17569 | build: Allow export of environ symbols by laanwj . Pull Request #17569 . bitcoin/bitcoin . GitHub
01:38 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
01:38 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
01:40 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 252 seconds]
01:42 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 245 seconds]
01:49 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
01:49 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Read error: Connection reset by peer]
02:00 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:02 < bitcoin-git> [bitcoin] KaanKC opened pull request #17570: test: add unit test for non-standard txs w/ too large tx size (master...test_unit_IsStandardTx_tx-size) https://github.com/bitcoin/bitcoin/pull/17570
02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:04 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:04 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
02:05 -!- marcoagner [~user@bl11-16-162.dsl.telepac.pt] has joined #bitcoin-core-dev
02:05 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 250 seconds]
02:10 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:10 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 250 seconds]
02:12 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
02:16 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 246 seconds]
02:19 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds]
02:19 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:22 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
02:25 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
02:26 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
02:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:27 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds]
02:28 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
02:29 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
02:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:30 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
02:31 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:32 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
02:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]
02:36 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:37 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
02:37 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
02:38 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
02:40 -!- JeremyCrookshank [~general@196.196.193.230] has joined #bitcoin-core-dev
02:41 < JeremyCrookshank> Morning, is there a handy guide for developing the GUI using QT? I swear i've seen one but can't find it
02:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
02:43 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Ping timeout: 276 seconds]
02:43 < sipsorcery> JeremyCrookshank: only one I've seen is readme at https://github.com/bitcoin/bitcoin/tree/master/src/qt
02:44 < sipsorcery> someone else asked the same question here last week.
02:44 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
02:44 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Read error: Connection reset by peer]
02:45 < JeremyCrookshank> Perfect cheers
02:45 < emilengler> How can I execute multiple tests in one file?
02:45 < emilengler> Adding the second class to main does not work :/
02:49 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 265 seconds]
02:51 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:51 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
02:56 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
02:57 < wumpus> JeremyCrookshank: there's a lot of documentation on the Qt site, I think you need to be more specific in your question; FWIW, you can open the .ui files in qt designer
02:57 < wumpus> emilengler: which kind of tests? unit or functional?
02:58 < emilengler> wumpus: Functional
02:59 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
02:59 < jonatack> emilengler: did you have a look at test/functional/example_test.py?
03:00 < emilengler> jonatack: Sure
03:00 < emilengler> In #17536 it was said that it is possible to add multiple *.main() calls to the main function and then execute them
03:00 < gribble> https://github.com/bitcoin/bitcoin/issues/17536 | test: Add test for rpc_whitelist by emilengler . Pull Request #17536 . bitcoin/bitcoin . GitHub
03:00 < wumpus> emilengler: you should only have one class per implementation file there; I'm not sure why you'd want multiple, some bigger tests do logical separateion of parts by having more methods and calling them in turn
03:00 < emilengler> But it does not work, also a "tail test/functional/*" does not show this aprroach for any other file (as far as I looked so far)
03:01 < emilengler> wumpus: I need to test two states of a cli arg
03:01 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 265 seconds]
03:01 < emilengler> foo=0 and foo=1
03:01 < emilengler> As bitcoind needs a restart for it I thought about doing it in 2 files
03:01 < wumpus> you can restart bitcoind from your test, no problem
03:02 < emilengler> Or in one file with multiple classes which seem to not work
03:02 < emilengler> wumpus: Really? How?
03:02 < wumpus> there's plenty of tests that check different argument combinations, the easiest way is to have it spawn multiple bitcoind nodes initially, but if that's too much combinations, you can always start and stop nodes on request
03:03 < emilengler> Ok I will try, thanks :)
03:03 < wumpus> stop_node, restart_node,..
03:03 < jonatack> emilengler: test_framework.py:445:    def restart_node(self, i, extra_args=None):
03:04 < jonatack> emilengler: (git grep "def restart")
03:08 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
03:09 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
03:11 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
03:14 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
03:14 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Read error: Connection reset by peer]
03:16 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
03:17 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
03:17 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
03:18 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 240 seconds]
03:26 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
03:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
03:28 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
03:29 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
03:32 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
03:32 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
03:37 < wumpus> AppVeyor is failing on "bench_verify_script.obj : error LNK2001: unresolved external symbol "struct CMutableTransaction __cdecl BuildSpendingTransaction(class CScript const &,struct CScriptWitness const &,class CTransaction const &)" (?BuildSpendingTransaction@@YA?AUCMutableTrans"
03:37 < wumpus> did anyone forget to update the MSVC build system?
03:37 < sipsorcery> wumpus: on master?
03:38 < wumpus> I think so, I'm seeing the same error in many PRs, even #17561 which only updates docs
03:38 < gribble> https://github.com/bitcoin/bitcoin/issues/17561 | doc: Changed MiniUPnPc link to https in dependencies.md by sandakersmann . Pull Request #17561 . bitcoin/bitcoin . GitHub
03:39 < sipsorcery> will check with a local msvc build (otherwise it's a 1hr turn around time for appveyor)
03:39 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 252 seconds]
03:40 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
03:41 < wumpus> I think #17542 is most likely to have introduced it of recent changes
03:41 < gribble> https://github.com/bitcoin/bitcoin/issues/17542 | build: Create test utility library from src/test/util/ by brakmic . Pull Request #17542 . bitcoin/bitcoin . GitHub
03:42 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
03:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:46 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 245 seconds]
03:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
03:51 < sipsorcery> wumpus: yes the msvc build of bench_bitcoin is failing on master. i will investigate.
03:52 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
03:52 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
03:56 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
03:56 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Read error: Connection reset by peer]
03:58 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:00 -!- aljungberg [~aljungber@139.28.218.198] has quit []
04:00 -!- nosss2_ [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 240 seconds]
04:06 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
04:06 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]
04:06 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:08 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
04:10 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
04:13 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
04:15 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
04:15 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
04:16 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
04:17 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 246 seconds]
04:21 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
04:23 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:23 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
04:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:27 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
04:28 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
04:30 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
04:30 < wumpus> sipsorcery: thanks!
04:32 < sipsorcery> wumpus: np. you were correct the new libtest_util lib from #17452 is not part of the msvc build config. i've added and will submit PR imminently.
04:32 < gribble> https://github.com/bitcoin/bitcoin/issues/17452 | lib: update fuzz directory in .gitignore by jonatack . Pull Request #17452 . bitcoin/bitcoin . GitHub
04:34 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 240 seconds]
04:35 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
04:35 < darosior> meshcollider, wumpus, achow101: The test added in #17568 pass on master for me as well..
04:35 < gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 . Pull Request #17568 . bitcoin/bitcoin . GitHub
04:39 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
04:39 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:40 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 276 seconds]
04:42 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
04:44 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:45 < bitcoin-git> [bitcoin] sipsorcery opened pull request #17571: WIP: Add libtest_util library to msvc build configuration (master...msvc_libtestutil) https://github.com/bitcoin/bitcoin/pull/17571
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:47 -!- ButterflyOfFire [~Butterfly@89.238.178.75] has joined #bitcoin-core-dev
04:48 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 240 seconds]
04:48 -!- cryptoIn_ [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
04:49 -!- cryptoIn_ [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
04:54 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds]
04:54 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
04:55 < JeremyCrookshank> Anyone know why Qt-creator says the Bitcoin form .h files aren't part of the project? Not able to add slots because of it
04:55 < JeremyCrookshank> Doesn't do it on the sample project
04:57 < wumpus> the .pro isn't a suitable build system for building the project, it simply collects the form files for editing in qt creator / designer, it might be that some advanced functionality doesn't work
04:59 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
04:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:59 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Remote host closed the connection]
04:59 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
04:59 -!- jonatack_ [~jon@37.167.26.27] has joined #bitcoin-core-dev
05:00 < JeremyCrookshank> Hmm okay so i'll have to code in slots manually as the qt-creator option doesn't work
05:00 -!- misterwhatever [~misterwha@static-176-185-227-206.ftth.abo.bbox.fr] has joined #bitcoin-core-dev
05:00 < wumpus> yes
05:01 < JeremyCrookshank> Thats annoying :p
05:01 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 265 seconds]
05:03 -!- jonatack [~jon@37.171.25.26] has quit [Ping timeout: 276 seconds]
05:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
05:04 < wumpus> yes it is, but it's also not really worth it to maintain another build system for it, and I think most devs prefer implementing the hooks and such manually to have more control over what happens
05:05 -!- gelmutshmidt [~gelmutshm@188.113.2.235] has joined #bitcoin-core-dev
05:05 < wumpus> also .pro is very limited as build systems go, I don't think it'd even be possible to use it anymore to build the full project. ofc, your could simply add the .h files to it and see that helps.
05:06 < wumpus> if it's just a matter of the IDE needing to find the code
05:06 -!- gelmutshmidt [~gelmutshm@188.113.2.235] has quit [Remote host closed the connection]
05:06 -!- gelmutshmidt [~gelmutshm@188.113.2.235] has joined #bitcoin-core-dev
05:08 < JeremyCrookshank> Yeah tried that already unfortunately
05:08 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
05:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:11 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
05:15 -!- MrPaz [~MrPaz@24.14.251.223] has joined #bitcoin-core-dev
05:19 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
05:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
05:20 -!- misterwhatever [~misterwha@static-176-185-227-206.ftth.abo.bbox.fr] has quit [Remote host closed the connection]
05:23 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 240 seconds]
05:27 -!- Highway61 [~Thunderbi@96.44.145.34] has joined #bitcoin-core-dev
05:28 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
05:40 -!- rex4539 [~rex4539@2a02:587:350d:3000:3128:9ff2:490e:2ac3] has quit [Quit: rex4539]
05:42 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
05:42 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
05:48 -!- MrPaz [~MrPaz@24.14.251.223] has quit [Quit: Leaving]
05:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
05:57 -!- Highway62 [~Thunderbi@96.44.145.34] has joined #bitcoin-core-dev
05:57 < fanquake> wumpus hopefully ?
05:57 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 240 seconds]
05:59 -!- Highway61 [~Thunderbi@96.44.145.34] has quit [Ping timeout: 265 seconds]
05:59 -!- Highway62 is now known as Highway61
06:10 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
06:13 -!- pinheadmz [~matthewzi@91.132.137.236] has quit [Ping timeout: 240 seconds]
06:13 -!- pinheadmz_ is now known as pinheadmz
06:20 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
06:22 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
06:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:26 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
06:28 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
06:34 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 260 seconds]
06:36 < wumpus> at least locally it seems to make the gitian linux build pass again
06:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds]
06:47 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
06:47 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
06:57 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
06:58 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
07:00 -!- ButterflyOfFire [~Butterfly@89.238.178.75] has quit []
07:00 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
07:01 -!- JamesAU [~jamesau@195.74.55.88] has joined #bitcoin-core-dev
07:04 -!- nik-j [~nik-j@37.120.157.44] has quit [Remote host closed the connection]
07:07 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
07:07 -!- Aaronvan_ is now known as AaronvanW
07:17 -!- dvratil [~dvratil@84.39.117.57] has joined #bitcoin-core-dev
07:19 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
07:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
07:28 < wumpus> or not, I get a NX failure after "Checking binary security" for RISC-V now, wtf
07:31 < wumpus> crap, after a failed build it doesn't cache the dependencies, so it needs to build qt all over again next time...
07:33 < fanquake> ugh
07:35 < wumpus> I wonder what broke the rv64 build, it might well be another change entirely, or something is messed up here locally
07:36 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 240 seconds]
07:38 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #bitcoin-core-dev
07:38 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
07:41 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
07:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:46 -!- alex911kz [~alex9kz@95.56.139.244] has joined #bitcoin-core-dev
07:50 -!- Highway61 [~Thunderbi@96.44.145.34] has quit [Ping timeout: 240 seconds]
07:50 -!- Highway61 [~Thunderbi@96.44.145.34] has joined #bitcoin-core-dev
07:52 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
07:57 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:02 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
08:05 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
08:07 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
08:07 -!- Highway61 [~Thunderbi@96.44.145.34] has quit [Quit: Highway61]
08:10 -!- spinza [~spin@102.132.245.16] has quit [Remote host closed the connection]
08:12 -!- jonatack_ [~jon@37.167.26.27] has quit [Read error: Connection reset by peer]
08:13 -!- nik-j [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
08:13 -!- jonatack_ [~jon@37.167.26.27] has joined #bitcoin-core-dev
08:16 -!- nik-j [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
08:22 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:25 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
08:25 -!- pinheadmz_ is now known as pinheadmz
08:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:30 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0b79caf65801...33c103e2fe67
08:30 < bitcoin-git> bitcoin/master 794fe91 Hennadii Stepanov: doc: Update and improve Developer Notes
08:30 < bitcoin-git> bitcoin/master 33c103e fanquake: Merge #17539: doc: Update and improve Developer Notes
08:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:31 < bitcoin-git> [bitcoin] fanquake merged pull request #17539: doc: Update and improve Developer Notes (master...20191120-developer-notes) https://github.com/bitcoin/bitcoin/pull/17539
08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:31 -!- emil__ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
08:35 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 276 seconds]
08:36 -!- JamesAU [~jamesau@195.74.55.88] has quit [Remote host closed the connection]
08:38 < achow101> meshcollider: darosior: it consistently fails for me on master
08:38 -!- adiabat [~adiabat@63.209.32.102] has quit [Ping timeout: 276 seconds]
08:41 < wumpus> same here
08:42 < cfields> jonasschnelli: Looks like your macos sig is invalid :(
08:42 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
08:42 < cfields> cory@Macbook:~/dev/bitcoin$ spctl --assess -vv /Volumes/Bitcoin-Core/Bitcoin-Qt.app
08:42 < cfields> /Volumes/Bitcoin-Core/Bitcoin-Qt.app: invalid Info.plist (plist or signature have been modified)
08:44 < cfields> Oh wait, might be my local problem.
08:47 -!- nik-j_ [~nik-j@072-239-143-095.res.spectrum.com] has joined #bitcoin-core-dev
08:48 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
08:50 < cfields> Yup, all good.
08:51 < fanquake> ?
08:51 < cfields> Gitian builders: detached sigs for v0.19.0.1 are up
08:51 -!- nik-j_ [~nik-j@072-239-143-095.res.spectrum.com] has quit [Ping timeout: 240 seconds]
08:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:51 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #17573: Seed RNG with precision timestamps on receipt of net messages. (master...2019-11-rng-netmsg) https://github.com/bitcoin/bitcoin/pull/17573
08:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:52 -!- jonatack_ [~jon@37.167.26.27] has quit [Quit: jonatack_]
08:52 -!- jonatack [~jon@37.167.26.27] has joined #bitcoin-core-dev
08:53 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 265 seconds]
09:04 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
09:07 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
09:11 < wumpus> cfields: jonasschnelli: great, thanks!
09:20 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
09:27 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
09:28 -!- alex911_kz [~alex9kz@95.56.139.244] has joined #bitcoin-core-dev
09:28 -!- gelmuth_ [~gelmutshm@188.113.60.127] has joined #bitcoin-core-dev
09:30 -!- alex911kz [~alex9kz@95.56.139.244] has quit [Ping timeout: 276 seconds]
09:30 -!- gelmutshmidt [~gelmutshm@188.113.2.235] has quit [Ping timeout: 276 seconds]
09:30 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
09:33 -!- nik-j [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
09:38 -!- nik-j [~nik-j@37.120.157.44] has quit [Ping timeout: 265 seconds]
09:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:39 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/33c103e2fe67...2c98e2024d52
09:39 < bitcoin-git> bitcoin/master b509554 Aaron Clauson: Added libtest_util library to msvc build configuration.
09:39 < bitcoin-git> bitcoin/master 2c98e20 fanquake: Merge #17571: Add libtest_util library to msvc build configuration
09:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:39 < bitcoin-git> [bitcoin] fanquake merged pull request #17571: Add libtest_util library to msvc build configuration (master...msvc_libtestutil) https://github.com/bitcoin/bitcoin/pull/17571
09:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:49 -!- Highway61 [~Thunderbi@144.178.1.38] has joined #bitcoin-core-dev
09:54 -!- jonatack [~jon@37.167.26.27] has quit [Read error: Connection reset by peer]
09:54 -!- Highway61 [~Thunderbi@144.178.1.38] has quit [Client Quit]
10:00 -!- dvratil [~dvratil@84.39.117.57] has quit []
10:00 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
10:00 -!- JamesAU [~jamesau@2a00:23c5:e0ac:bd00:f8e6:419a:9f11:d3b6] has joined #bitcoin-core-dev
10:01 -!- cryptoIn_ [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
10:10 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
10:10 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
10:16 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
10:16 -!- zone117x1 [~zone117x@172.83.40.52] has joined #bitcoin-core-dev
10:18 -!- spinza [~spin@102.132.245.16] has quit [Remote host closed the connection]
10:18 -!- gelmuth_ [~gelmutshm@188.113.60.127] has quit [Remote host closed the connection]
10:20 -!- cryptoIn_ [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
10:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
10:31 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
10:31 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
10:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
10:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
10:44 < provoostenator> ^ rebase time!
10:45 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
10:47 -!- Tommy19 [5c153188@host-92-21-49-136.as13285.net] has joined #bitcoin-core-dev
10:50 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
10:57 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
10:58 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
11:02 -!- JeremyCrookshank [~general@196.196.193.230] has quit [Ping timeout: 246 seconds]
11:02 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 265 seconds]
11:02 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
11:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]
11:14 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
11:17 -!- sipsorcery [~sipsorcer@37.228.255.208] has quit [Ping timeout: 240 seconds]
11:17 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
11:22 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Read error: Connection reset by peer]
11:23 -!- fox2p [~fox2p@cpe-66-108-40-154.nyc.res.rr.com] has joined #bitcoin-core-dev
11:33 < wumpus> the gitian RV64 check failure is not caused by #17270, it appears, but some later change, I'm bisecting
11:33 < gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa . Pull Request #17270 . bitcoin/bitcoin . GitHub
11:34 -!- nik-j [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
11:34 < sipa> wumpus: strange
11:35 -!- nik-j_ [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
11:35 -!- nik-j [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
11:37 -!- nik-j_ [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
11:40 < wumpus> i suspect it's some build system change that makes it eat a required flag
11:42 -!- cino94 [2574e9c6@net-37-116-233-198.cust.vodafonedsl.it] has joined #bitcoin-core-dev
11:46 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 265 seconds]
11:47 -!- cino94 [2574e9c6@net-37-116-233-198.cust.vodafonedsl.it] has quit [Ping timeout: 260 seconds]
11:49 -!- llfsdfsdfsfs [d92b6e84@host217-43-110-132.range217-43.btcentralplus.com] has joined #bitcoin-core-dev
11:53 -!- llfsdfsdfsfs [d92b6e84@host217-43-110-132.range217-43.btcentralplus.com] has quit [Remote host closed the connection]
11:58 -!- cino94 [2574e9c6@net-37-116-233-198.cust.vodafonedsl.it] has joined #bitcoin-core-dev
12:03 -!- cino94 [2574e9c6@net-37-116-233-198.cust.vodafonedsl.it] has quit [Remote host closed the connection]
12:05 < fanquake> wumpus maybe it was broken when we removed OpenSSL ?
12:07 < wumpus> definitely possible !
12:14 -!- nik-j_ [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
12:19 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
12:19 -!- nik-j_ [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
12:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
12:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds]
12:27 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
12:28 -!- alex911kz [~alex9kz@95.56.139.244] has joined #bitcoin-core-dev
12:31 -!- alex911_kz [~alex9kz@95.56.139.244] has quit [Ping timeout: 265 seconds]
12:33 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
12:33 < fanquake> "PS this seems to be causing a noise inversely proportional to the complexity of the change" https://github.com/bitcoin/bitcoin/pull/17563#issuecomment-557829862
12:33 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
12:33 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
12:33 < fanquake> What else was he expecting when he PR'd an initially poorly explained change to the ifdef hackery inside random.cpp
12:35 < wumpus> we're pretty consistent in this, too, I've closed PRs of myself too when 'working around a warning' was just not worth the mess
12:37 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 240 seconds]
12:37 < fanquake> The initial change just felt like a Debian OpenSSL Valgrind scenario
12:40 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
12:47 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
12:50 < wumpus> bisected it to b49b6b0f7090cc15860d815fb0ef306ddfc718ba, so indeed seems that the change has to do with openssl removal, very curious
12:54 < fanquake> interesting
12:54 < wumpus> it's not even a build system change, just the last change that causes no symbols from openssl to be used anymore
12:54 < sipa> heh
12:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:54 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev
12:55 < wumpus> it looks like we never explicitly pass -Wl,--noexecstack except to openssl
12:56 < meshcollider> darosior: thanks for testing, good to know it's not just me haha. I'll try and investigate today
12:56 < wumpus> all the other architectures default to it, though, so might as well be an ubuntu compiler issue
12:56 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
12:57 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 265 seconds]
12:57 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
12:59 < potatoe_face> %
13:00 -!- zone117x1 [~zone117x@172.83.40.52] has quit []
13:01 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
13:01 -!- spinza [~spin@102.132.245.16] has quit [Client Quit]
13:04 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:10 -!- potatoe_face [~potatoe_f@157.230.27.253] has quit [Quit: leaving]
13:11 -!- potatoe_face [~potatoe_f@157.230.27.253] has joined #bitcoin-core-dev
13:16 -!- potatoe_face [~potatoe_f@157.230.27.253] has quit [Client Quit]
13:16 -!- potatoe_face [~potatoe_f@157.230.27.253] has joined #bitcoin-core-dev
13:17 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
13:18 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
13:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]
13:39 -!- potatoe_face [~potatoe_f@157.230.27.253] has quit [Quit: leaving]
13:40 -!- potatoe_face [~potatoe_f@157.230.27.253] has joined #bitcoin-core-dev
13:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
13:42 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 246 seconds]
13:43 -!- potatoe_face [~potatoe_f@157.230.27.253] has quit [Client Quit]
13:43 -!- potatoe_face [~potatoe_f@157.230.27.253] has joined #bitcoin-core-dev
13:43 -!- alex911kz [~alex9kz@95.56.139.244] has quit [Ping timeout: 240 seconds]
13:47 -!- MaddinSM [~MaddinSM@184.75.223.235] has joined #bitcoin-core-dev
13:48 < wumpus> it's good that we have the security check or we'd never have noticed; the workaround of adding  -Wl,-z,noexecstack explicitly on RISC-V in the descriptor seems to work, but I'm still trying to figure out why it doesn't get set automatically there
13:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
14:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
14:18 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.6]
14:25 < fanquake> wumpus good hunting
14:30 < wumpus> thanks! this one was very sneaky; hopefully this was the last problem and we can start using gitian again
14:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:37 -!- Tommy19 [5c153188@host-92-21-49-136.as13285.net] has quit [Remote host closed the connection]
14:44 -!- b10c [~Thunderbi@mue-88-130-54-050.dsl.tropolys.de] has joined #bitcoin-core-dev
14:54 -!- jonatack [~jon@37.167.71.155] has joined #bitcoin-core-dev
15:01 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
15:02 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
15:04 < achow101> meshcollider: are you sure you have an updated master? The issue was only after #17290 was merged
15:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 . Pull Request #17290 . bitcoin/bitcoin . GitHub
15:08 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
15:10 < meshcollider> well yeah I merged it haha
15:11 < achow101> could be an old branch/ different worktree, i dunno
15:11 < meshcollider> Yeah I'll double check later and recompile fresh master
15:23 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
15:28 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Remote host closed the connection]
15:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:34 -!- b10c [~Thunderbi@mue-88-130-54-050.dsl.tropolys.de] has quit [Ping timeout: 240 seconds]
15:49 -!- Giszmo [~leo@122-58-98-6-adsl.sparkbb.co.nz] has joined #bitcoin-core-dev
15:50 -!- Giszmo [~leo@122-58-98-6-adsl.sparkbb.co.nz] has quit [Client Quit]
15:51 -!- emil__ [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
15:58 -!- nik-j [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
16:00 -!- MaddinSM [~MaddinSM@184.75.223.235] has quit []
16:04 -!- nik-j [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
16:08 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
16:12 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Ping timeout: 240 seconds]
16:17 -!- MononcQc1 [~MononcQc@185.204.1.185] has joined #bitcoin-core-dev
16:40 -!- sipsorcery [~sipsorcer@37.228.255.208] has joined #bitcoin-core-dev
16:44 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
16:49 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Ping timeout: 252 seconds]
17:00 -!- jonatack_ [~jon@37.164.33.234] has joined #bitcoin-core-dev
17:03 -!- jonatack [~jon@37.167.71.155] has quit [Ping timeout: 276 seconds]
17:08 -!- jonatack_ [~jon@37.164.33.234] has quit [Read error: Connection reset by peer]
17:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:16 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
17:23 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
17:28 -!- nik-j [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
17:28 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 276 seconds]
17:28 -!- nik-j_ [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
17:31 -!- nik-j_ [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
17:32 -!- nik-j [~nik-j@37.120.157.44] has quit [Ping timeout: 240 seconds]
17:36 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev
17:36 -!- DougieBot5000 is now known as Guest32712
17:36 -!- Guest32712 [~DougieBot@unaffiliated/dougiebot5000] has quit [Killed (card.freenode.net (Nickname regained by services))]
17:36 -!- DougieBot5000_ is now known as DougieBot5000
17:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
17:43 -!- JamesAU [~jamesau@2a00:23c5:e0ac:bd00:f8e6:419a:9f11:d3b6] has quit [Remote host closed the connection]
17:59 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
18:01 -!- alex911kz [~alex9kz@95.56.139.244] has joined #bitcoin-core-dev
18:06 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds]
18:08 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
18:33 -!- marcoagner [~user@bl11-16-162.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
18:34 -!- Krellan [~Krellan@2601:640:4100:e:547a:7b6c:de07:187] has joined #bitcoin-core-dev
18:34 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
18:38 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Ping timeout: 240 seconds]
18:51 -!- nik-j [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
18:51 -!- nik-j_ [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
18:52 -!- nik-j [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
18:56 -!- nik-j_ [~nik-j@37.120.157.44] has quit [Ping timeout: 240 seconds]
19:00 -!- MononcQc1 [~MononcQc@185.204.1.185] has quit []
19:05 -!- felixfoertsch23 [~felixfoer@2001:16b8:500d:c500:1ae:1f0:8bde:999f] has joined #bitcoin-core-dev
19:05 -!- felixfoertsch [~felixfoer@92.117.35.245] has quit [Ping timeout: 240 seconds]
19:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:08 < bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17430: build:fix "make clean" darwin build (master...fix-darwin-make-clean) https://github.com/bitcoin/bitcoin/pull/17430
19:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:08 < bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17558: build: organize tests by goal (master...2019/325/order-by-goal) https://github.com/bitcoin/bitcoin/pull/17558
19:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:17 -!- Tobbi1 [~Tobbi@84.39.116.180] has joined #bitcoin-core-dev
19:26 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
19:27 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
19:28 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
19:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 276 seconds]
19:31 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
20:01 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
20:03 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
20:07 -!- spinza [~spin@102.132.245.16] has quit [Client Quit]
20:08 < fanquake> wumpus: looks like your noexecstack fix is only being applied to bitcoind. Or did the bot build an outdated branch?
20:12 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 276 seconds]
20:22 -!- fox2p [~fox2p@cpe-66-108-40-154.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
20:25 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev
20:27 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 265 seconds]
20:31 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
20:35 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
20:39 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Ping timeout: 245 seconds]
20:42 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
20:46 -!- youssefnotes [~Mohamed@bb121-6-182-56.singnet.com.sg] has joined #bitcoin-core-dev
20:47 -!- youssefnotes [~Mohamed@bb121-6-182-56.singnet.com.sg] has quit [Client Quit]
20:48 -!- youssefnotes [~Mohamed@bb121-6-182-56.singnet.com.sg] has joined #bitcoin-core-dev
20:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:52 -!- nik-j [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
20:58 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
20:58 -!- nik-j [~nik-j@37.120.157.44] has quit [Ping timeout: 276 seconds]
20:58 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
21:06 -!- felixfoertsch23 [~felixfoer@2001:16b8:500d:c500:1ae:1f0:8bde:999f] has quit [Quit: ZNC 1.7.3 - https://znc.in]
21:06 -!- felixfoertsch [~felixfoer@2001:16b8:500d:c500:4d6b:c1c9:837c:8651] has joined #bitcoin-core-dev
21:25 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
21:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:27 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2c98e2024d52...9cbd87d8ee29
21:27 < bitcoin-git> bitcoin/master 3ed5e68 Hennadii Stepanov: refactor: Nuke coincontrol circular dependency
21:27 < bitcoin-git> bitcoin/master 9cbd87d Samuel Dobson: Merge #17518: refactor, wallet: Nuke coincontrol circular dependency
21:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:27 < bitcoin-git> [bitcoin] meshcollider merged pull request #17518: refactor, wallet: Nuke coincontrol circular dependency (master...20191119-coincontrol-dep) https://github.com/bitcoin/bitcoin/pull/17518
21:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:32 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
21:37 -!- youssefnotes [~Mohamed@bb121-6-182-56.singnet.com.sg] has quit []
21:40 -!- agiledeveloper [~quassel@bb121-6-182-56.singnet.com.sg] has joined #bitcoin-core-dev
21:40 -!- agiledeveloper [~quassel@bb121-6-182-56.singnet.com.sg] has quit [Client Quit]
21:41 -!- youssefnotes [~quassel@bb121-6-182-56.singnet.com.sg] has joined #bitcoin-core-dev
21:41 -!- youssefnotes [~quassel@bb121-6-182-56.singnet.com.sg] has quit [Client Quit]
21:44 -!- youssefnotes [~quassel@bb121-6-182-56.singnet.com.sg] has joined #bitcoin-core-dev
21:47 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
21:48 -!- youssefnotes [~quassel@bb121-6-182-56.singnet.com.sg] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
21:49 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
21:52 -!- youssefnotes [~quassel@bb121-6-182-56.singnet.com.sg] has joined #bitcoin-core-dev
21:55 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Ping timeout: 240 seconds]
21:58 -!- spinza [~spin@102.132.245.16] has quit [Remote host closed the connection]
22:00 -!- Tobbi1 [~Tobbi@84.39.116.180] has quit []
22:01 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
22:02 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
22:18 -!- Kater1 [~Kater@84.39.116.180] has joined #bitcoin-core-dev
22:45 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
22:48 -!- deadlysin [~txt@unaffiliated/deadlysin] has joined #bitcoin-core-dev
22:55 -!- nik-j [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
22:56 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
22:56 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-khyflumzlurejotc] has quit [Remote host closed the connection]
22:56 -!- nik-j [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
22:56 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
23:01 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 265 seconds]
23:03 -!- reallll is now known as belcher
23:06 -!- nik-j_ [~nik-j@072-239-143-095.res.spectrum.com] has joined #bitcoin-core-dev
23:12 -!- nik-j_ [~nik-j@072-239-143-095.res.spectrum.com] has quit [Ping timeout: 250 seconds]
23:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:19 -!- nik-j_ [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
23:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
23:22 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-tgjcvkmjdhcajvfh] has joined #bitcoin-core-dev
23:22 -!- nik-j_ [~nik-j@37.120.157.44] has quit [Read error: Connection reset by peer]
23:24 -!- rex4539 [~rex4539@2a02:587:350d:3000:cdbc:9d2a:3cd8:a27a] has joined #bitcoin-core-dev
23:26 -!- nik-j_ [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
23:26 -!- nik-j_ [~nik-j@37.120.157.44] has quit [Remote host closed the connection]
23:27 -!- nik-j_ [~nik-j@37.120.157.44] has joined #bitcoin-core-dev
23:43 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
23:51 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 240 seconds]
--- Log closed Sun Nov 24 00:00:17 2019