--- Log opened Mon Dec 09 00:00:31 2019
00:03 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Ping timeout: 268 seconds]
00:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
00:24 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has joined #bitcoin-core-dev
00:25 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
00:26 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
00:26 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
00:30 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
00:31 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
00:32 < wumpus> fanquake: yes, I'd really prefer switching to C++17, if we bump
00:34 < wumpus> though unless there's a way to install a newer compiler on F7, we've just made this a lot more difficult with #17635
00:34 < gribble> https://github.com/bitcoin/bitcoin/issues/17635 | ci: Add CentOS 7 build by hebasto . Pull Request #17635 . bitcoin/bitcoin . GitHub
00:35 < aj> F7?
00:36 < aj> for RHEL 7/CentOS 7 software collections should be the answer
00:36 < wumpus> I mean CentOS
00:37 < aj> (centos 7 is based on rhel 7 is based on fedora 19 i think)
00:37 < wumpus> I confuse those all the time :)
00:40 < wumpus> it's something to consider for 0.21
00:42 < aj> then another few years and maybe we'll have c++20 with designated initialisers
00:45 < sipa> calm down, it's not even 2020 yet
00:49 -!- kljasdfvv [~flack@p200300D46F014C00C13F170F965DACDF.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:50 -!- marcoagner [~user@bl11-16-162.dsl.telepac.pt] has joined #bitcoin-core-dev
00:51 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
00:52 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
00:53 < aj> sipa: i like that they waited until C99's designated initializers were old enough to drink before getting them involved in c++
01:00 -!- MacYET2 [~MacYET2@217.151.98.168] has quit []
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:03 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb03765e2d55...b6fb899ead9b
01:03 < bitcoin-git> bitcoin/master 0ccad08 Pieter Wuille: Make env data logging optional
01:03 < bitcoin-git> bitcoin/master b6fb899 Wladimir J. van der Laan: Merge #17699: Make env data logging optional
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:03 < bitcoin-git> [bitcoin] laanwj merged pull request #17699: Make env data logging optional (master...201912_randlog) https://github.com/bitcoin/bitcoin/pull/17699
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:07 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b6fb899ead9b...91559da683db
01:07 < bitcoin-git> bitcoin/master ba0cad2 fanquake: build: pass -dead_strip_dylibs to ld on macOS
01:07 < bitcoin-git> bitcoin/master 2359a47 fanquake: depends: don't use OpenGL in Qt on macOS
01:07 < bitcoin-git> bitcoin/master 91559da Wladimir J. van der Laan: Merge #17676: depends: don't use OpenGL in Qt on macOS
01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:07 < bitcoin-git> [bitcoin] laanwj merged pull request #17676: depends: don't use OpenGL in Qt on macOS (master...macos_no_opengl) https://github.com/bitcoin/bitcoin/pull/17676
01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:09 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:10 < wumpus> apparently, the only platform that uses OpenGL now is android
01:13 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 250 seconds]
01:14 -!- Kiminuo [~mix@141.98.103.86] has quit [Ping timeout: 250 seconds]
01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:14 < bitcoin-git> [bitcoin] brakmic opened pull request #17700: cli: add -generate option (master...resurrect-generate-method) https://github.com/bitcoin/bitcoin/pull/17700
01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:16 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev
01:17 -!- dhart [~dhart@217.151.98.168] has joined #bitcoin-core-dev
01:37 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
01:40 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 260 seconds]
01:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:46 < bitcoin-git> [bitcoin] gou-anlin opened pull request #17701: GAL--ANLIN (0.14...master) https://github.com/bitcoin/bitcoin/pull/17701
01:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:58 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:01 < bitcoin-git> [bitcoin] laanwj closed pull request #17701: GAL--ANLIN (0.14...master) https://github.com/bitcoin/bitcoin/pull/17701
02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:03 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 240 seconds]
02:04 -!- jonatack [~jon@213.152.161.35] has joined #bitcoin-core-dev
02:10 -!- b10c [~Thunderbi@mue-88-130-54-060.dsl.tropolys.de] has joined #bitcoin-core-dev
02:16 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-zspurxezndzxttqx] has quit [Quit: killed]
02:16 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-hlrnjrnodoaglhbs] has quit [Quit: killed]
02:16 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-iydihdzkmxnbgebj] has quit [Quit: killed]
02:16 -!- castlenine[m] [castlenine@gateway/shell/matrix.org/x-opggamlxmbhfknpl] has quit [Quit: killed]
02:16 -!- transist0[m] [transist0m@gateway/shell/matrix.org/x-bmkcrvpvtefywbmr] has quit [Quit: killed]
02:16 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-hdrpwcfnomtklspv] has quit [Quit: killed]
02:16 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-ryoynkydptscroby] has quit [Quit: killed]
02:16 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-tndppiefxzqirhgj] has quit [Quit: killed]
02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:23 < bitcoin-git> [bitcoin] laanwj opened pull request #17702: gui: Move static placeholder texts to forms (master...2019_12_qt_placeholders) https://github.com/bitcoin/bitcoin/pull/17702
02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:32 < wumpus> aj: if C99 hadn't been blcked by Microsoft for more than a decade we could have been much further along
02:40 < wumpus> (for years MS didn't believe in C, nor C++ anymore, there was this fashion for managed languages like C# so they were basically on life support, at least that has changed!)
02:46 -!- promag [~promag@83.223.251.59] has joined #bitcoin-core-dev
02:47 -!- sipsorcery [~sipsorcer@37.228.255.208] has quit [Read error: Connection reset by peer]
02:52 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-ifkcvjejbfejtdgi] has joined #bitcoin-core-dev
02:52 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-xqcwxwyeaicqcoyn] has joined #bitcoin-core-dev
02:52 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-zrpkzfvzhbmutpcs] has joined #bitcoin-core-dev
02:52 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-qecgjnmarvmriufr] has joined #bitcoin-core-dev
02:52 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-psnkpjkmwszrqqoi] has joined #bitcoin-core-dev
02:52 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-wqqidciwzwqkrxbi] has joined #bitcoin-core-dev
02:52 -!- transist0[m] [transist0m@gateway/shell/matrix.org/x-pqsfberxxsqpkeyh] has joined #bitcoin-core-dev
02:52 -!- castlenine[m] [castlenine@gateway/shell/matrix.org/x-wrdxwxxvrnkcsilo] has joined #bitcoin-core-dev
02:56 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
02:57 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-dev
03:04 -!- Asa3Connelly [~Asa3Conne@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:07 -!- sipsorcery [~sipsorcer@37.228.255.208] has joined #bitcoin-core-dev
03:08 -!- Asa3Connelly [~Asa3Conne@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 246 seconds]
03:15 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:16 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
03:27 -!- Kiminuo [~mix@141.98.103.86] has joined #bitcoin-core-dev
03:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:33 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
03:33 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
03:39 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
03:39 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
03:41 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
03:43 < jonatack> instagibbs: done, reviewed 16373, 17621 and 17677
03:44 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 252 seconds]
03:44 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 252 seconds]
03:44 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
04:00 -!- dhart [~dhart@217.151.98.168] has quit []
04:09 -!- promag [~promag@83.223.251.59] has quit [Remote host closed the connection]
04:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
04:14 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has joined #bitcoin-core-dev
04:17 -!- reset1 [~reset@195.206.183.79] has joined #bitcoin-core-dev
04:20 -!- promag [~promag@83.223.251.59] has joined #bitcoin-core-dev
04:28 -!- promag [~promag@83.223.251.59] has quit [Remote host closed the connection]
04:35 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
04:41 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:44 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
04:48 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Client Quit]
04:54 -!- Highway61 [~Thunderbi@96.44.189.170] has joined #bitcoin-core-dev
04:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds]
04:57 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:06 -!- thelounge2467250 [~m1rror@109.134.206.46] has quit [Quit: Ping timeout (120 seconds)]
05:07 -!- thelounge2467250 [~m1rror@109.134.206.46] has joined #bitcoin-core-dev
05:36 < fanquake> Did our Appveyor job split in two or something?
05:37 < fanquake> I now see "branch" and "pr" CIs
05:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/91559da683db...1ebf6402fc7c
05:39 < bitcoin-git> bitcoin/master a5a705b nijynot: lcov: filter depends from coverage report
05:39 < bitcoin-git> bitcoin/master f736f69 nijynot: lcov: filter /usr/lib64 from coverage report
05:39 < bitcoin-git> bitcoin/master 1ebf640 MarcoFalke: Merge #17647: lcov: filter depends from coverage reports
05:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17647: lcov: filter depends from coverage reports (master...fix/lcov-depends) https://github.com/bitcoin/bitcoin/pull/17647
05:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:50 -!- reallll is now known as belcher
05:58 -!- bitcoinjoe [uid307760@gateway/web/irccloud.com/x-lmmdjelcygwggiyg] has joined #bitcoin-core-dev
06:05 < instagibbs> jonatack, awesome, thanks
06:20 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 276 seconds]
06:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Remote host closed the connection]
06:21 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:24 -!- jonatack [~jon@213.152.161.35] has quit [Read error: Connection reset by peer]
06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:35 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ebf6402fc7c...c8e65ade095b
06:35 < bitcoin-git> bitcoin/master d65fafc fanquake: gui: disable File->CreateWallet during startup
06:35 < bitcoin-git> bitcoin/master c8e65ad fanquake: Merge #17695: gui: disable File->CreateWallet during startup
06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:36 < bitcoin-git> [bitcoin] fanquake merged pull request #17695: gui: disable File->CreateWallet during startup (master...disable_early_create_wallet) https://github.com/bitcoin/bitcoin/pull/17695
06:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
06:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:55 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c8e65ade095b...05c23488c2ce
06:55 < bitcoin-git> bitcoin/master 48a5c92 Harris: ui: disable 3rd-party tx-urls when wallet disabled
06:55 < bitcoin-git> bitcoin/master 05c2348 fanquake: Merge #17694: ui: disable 3rd-party tx-urls when wallet disabled
06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:55 < bitcoin-git> [bitcoin] fanquake merged pull request #17694: ui: disable 3rd-party tx-urls when wallet disabled (master...options-display-dialog) https://github.com/bitcoin/bitcoin/pull/17694
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:00 -!- reset1 [~reset@195.206.183.79] has quit []
07:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Remote host closed the connection]
07:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
07:16 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 245 seconds]
07:17 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 268 seconds]
07:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:17 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05c23488c2ce...ac09180128a1
07:17 < bitcoin-git> bitcoin/master c966ff1 willyk: gitian: fixed SC2001 regex
07:17 < bitcoin-git> bitcoin/master ac09180 Wladimir J. van der Laan: Merge #17680: gitian: fixed SC2001 regex
07:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:17 < bitcoin-git> [bitcoin] laanwj merged pull request #17680: gitian: fixed SC2001 regex (master...patch-2) https://github.com/bitcoin/bitcoin/pull/17680
07:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
07:34 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has quit [Ping timeout: 252 seconds]
07:37 -!- pinheadmz [~matthewzi@135-180-1-212.static.sonic.net] has joined #bitcoin-core-dev
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:38 < bitcoin-git> [bitcoin] fanquake opened pull request #17703: build: Improve configure.ac formatting (master...configure_ac_formatting) https://github.com/bitcoin/bitcoin/pull/17703
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:46 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
07:47 -!- luto1 [~luto@141.98.102.235] has joined #bitcoin-core-dev
07:47 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
07:51 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
07:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:55 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
07:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:59 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
08:00 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
08:07 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
08:08 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 240 seconds]
08:13 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
08:17 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
08:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
08:34 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:36 -!- michaelfolkson [~textual@host-92-13-61-152.as43234.net] has joined #bitcoin-core-dev
08:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds]
08:46 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
08:47 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
08:47 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:47 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
08:48 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
08:48 -!- michaelfolkson [~textual@host-92-13-61-152.as43234.net] has quit [Quit: Sleep mode]
08:49 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
08:50 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
08:50 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
08:51 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
08:52 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
08:52 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
08:55 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
08:57 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:58 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
09:01 -!- michaelfolkson [~textual@host-92-13-61-152.as43234.net] has joined #bitcoin-core-dev
09:02 -!- michaelfolkson [~textual@host-92-13-61-152.as43234.net] has quit [Client Quit]
09:04 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds]
09:05 -!- davterra [~dulyNoded@104.140.15.19] has quit [Remote host closed the connection]
09:06 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 245 seconds]
09:08 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
09:13 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
09:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
09:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
09:26 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:27 -!- laptop500 [~laptop@212.203.87.198] has joined #bitcoin-core-dev
09:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 250 seconds]
09:44 -!- michaelfolkson [~textual@host-92-13-61-152.as43234.net] has joined #bitcoin-core-dev
09:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ac09180128a1...1d6fda65dd41
09:50 < bitcoin-git> bitcoin/master 989fd53 Luke Dashjr: depends: Support for 64-bit POWER targets
09:50 < bitcoin-git> bitcoin/master 1111324 MarcoFalke: depends: Support for S390X targets
09:50 < bitcoin-git> bitcoin/master 1d6fda6 MarcoFalke: Merge #17678: depends: Support for S390X and POWER targets
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17678: depends: Support for S390X and POWER targets (master...1912-dependsNewTargets) https://github.com/bitcoin/bitcoin/pull/17678
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:50 -!- michaelfolkson [~textual@host-92-13-61-152.as43234.net] has quit [Quit: Sleep mode]
09:52 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:54 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
09:54 -!- Highway61 [~Thunderbi@96.44.189.170] has quit [Ping timeout: 265 seconds]
09:56 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
10:00 -!- luto1 [~luto@141.98.102.235] has quit []
10:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:16 -!- michaelfolkson [~textual@host-92-13-61-152.as43234.net] has joined #bitcoin-core-dev
10:16 -!- michaelfolkson [~textual@host-92-13-61-152.as43234.net] has quit [Client Quit]
10:21 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:24 -!- pinheadmz [~matthewzi@135-180-1-212.static.sonic.net] has quit [Quit: pinheadmz]
10:27 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
10:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:31 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:33 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Ping timeout: 276 seconds]
10:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:35 -!- Kiminuo [~mix@141.98.103.86] has quit [Ping timeout: 268 seconds]
10:44 -!- laptop500 [~laptop@212.203.87.198] has quit [Quit: Leaving]
10:47 -!- edit_21 [~edit_21@172.83.40.52] has joined #bitcoin-core-dev
10:48 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
10:49 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:51 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1d6fda65dd41...03e781ff4fd7
10:51 < bitcoin-git> bitcoin/master 67f36e0 Wladimir J. van der Laan: gui: Move static placeholder texts to forms
10:51 < bitcoin-git> bitcoin/master a652dc5 Wladimir J. van der Laan: qt: Normalize placeholder to avoid using "address book" in sendcoinsentry
10:51 < bitcoin-git> bitcoin/master 03e781f MarcoFalke: Merge #17702: gui: Move static placeholder texts to forms
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:52 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17702: gui: Move static placeholder texts to forms (master...2019_12_qt_placeholders) https://github.com/bitcoin/bitcoin/pull/17702
10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/03e781ff4fd7...df2b74375969
10:54 < bitcoin-git> bitcoin/master 993e38a practicalswift: tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such
10:54 < bitcoin-git> bitcoin/master 5ac804a practicalswift: tests: Use a default of supports_cli=True (instead of supports_cli=False)
10:54 < bitcoin-git> bitcoin/master df2b743 MarcoFalke: Merge #17675: tests: Enable tests which are incorrectly skipped when runni...
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:54 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17675: tests: Enable tests which are incorrectly skipped when running test_runner.py --usecli (master...dash-dash-usecli) https://github.com/bitcoin/bitcoin/pull/17675
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
11:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:30 -!- jarthur [~jarthur@207.114.244.5] has quit []
11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/df2b74375969...5bf1909dd933
11:39 < bitcoin-git> bitcoin/master 978b255 Wladimir J. van der Laan: util: Update tinyformat to upstream
11:39 < bitcoin-git> bitcoin/master 5bf1909 MarcoFalke: Merge #17682: util: Update tinyformat to upstream
11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17682: util: Update tinyformat to upstream (master...2019_12_tinyformat) https://github.com/bitcoin/bitcoin/pull/17682
11:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:42 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
11:44 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
11:49 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
11:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:52 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17704: depends: Set default depends fallback url to drahtbot.space (master...1912-dependsDrahtBot) https://github.com/bitcoin/bitcoin/pull/17704
11:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5bf1909dd933...74c6ad3aabdd
12:08 < bitcoin-git> bitcoin/master 709afb2 practicalswift: tests: Test serialisation as part of deserialisation fuzzing. Test round-t...
12:08 < bitcoin-git> bitcoin/master 74c6ad3 MarcoFalke: Merge #17225: tests: Test serialisation as part of deserialisation fuzzing...
12:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17225: tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. (master...fuzzers-deserialize-with-roundtrip) https://github.com/bitcoin/bitcoin/pull/17225
12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:12 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
12:13 -!- Kiminuo [~mix@141.98.103.86] has joined #bitcoin-core-dev
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/74c6ad3aabdd...347dd76ec87d
12:13 < bitcoin-git> bitcoin/master ce93529 practicalswift: tests: Add fuzzing harness for various CTxIn related functions
12:13 < bitcoin-git> bitcoin/master e75ecb9 practicalswift: tests: Add fuzzing harness for various CTxOut related functions
12:13 < bitcoin-git> bitcoin/master d5766f2 practicalswift: tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missi...
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:13 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17093: tests: Add fuzzing harness for various CTx{In,Out} related functions (master...fuzzers-txin-txout) https://github.com/bitcoin/bitcoin/pull/17093
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:13 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:18 -!- Highway61 [~Thunderbi@96.44.189.170] has joined #bitcoin-core-dev
12:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:18 < bitcoin-git> [bitcoin] fanquake opened pull request #17705: test: re-enable CLI test support by using EncodeDecimal in json.dumps() (master...test_framework_json_dumps) https://github.com/bitcoin/bitcoin/pull/17705
12:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:22 -!- jpe_ [jpe@gateway/vpn/nordvpn/jpe] has joined #bitcoin-core-dev
12:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:23 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/347dd76ec87d...1189b6acab11
12:23 < bitcoin-git> bitcoin/master 575383b practicalswift: tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missi...
12:23 < bitcoin-git> bitcoin/master 597d10c practicalswift: tests: Add fuzzing harness for various functions consuming only integrals
12:23 < bitcoin-git> bitcoin/master 1189b6a MarcoFalke: Merge #17109: tests: Add fuzzing harness for various functions consuming o...
12:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17109: tests: Add fuzzing harness for various functions consuming only integrals (master...fuzzers-integrals) https://github.com/bitcoin/bitcoin/pull/17109
12:24 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev
12:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:25 -!- jpe__ [~jpe@2001:16b8:5cff:6600:95fe:33d0:62be:926e] has quit [Ping timeout: 250 seconds]
12:28 -!- jpe__ [~jpe@89.187.178.33] has joined #bitcoin-core-dev
12:29 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:29 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:30 -!- jpe_ [jpe@gateway/vpn/nordvpn/jpe] has quit [Ping timeout: 265 seconds]
12:32 -!- Highway62 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
12:32 -!- tsujp [~tsujp@61-69-140-107.tpgi.com.au] has quit [Ping timeout: 250 seconds]
12:33 -!- Highway61 [~Thunderbi@96.44.189.170] has quit [Ping timeout: 240 seconds]
12:33 -!- Highway62 is now known as Highway61
12:35 -!- tsujp [~tsujp@194-223-94-55.tpgi.com.au] has joined #bitcoin-core-dev
12:39 -!- pinheadmz [~matthewzi@107.181.166.205] has joined #bitcoin-core-dev
12:48 -!- jpe__ [~jpe@89.187.178.33] has quit [Ping timeout: 240 seconds]
12:48 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
12:49 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
12:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 245 seconds]
12:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
12:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:00 -!- edit_21 [~edit_21@172.83.40.52] has quit []
13:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
13:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
13:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
13:06 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
13:09 -!- pinheadmz [~matthewzi@107.181.166.205] has quit [Quit: pinheadmz]
13:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
13:37 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 260 seconds]
13:46 -!- mreider [~mreider@185.169.255.76] has joined #bitcoin-core-dev
13:59 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has quit [Ping timeout: 245 seconds]
14:06 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:23 -!- baldur [~baldur@pool-100-2-132-165.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds]
14:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
14:32 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
14:33 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has joined #bitcoin-core-dev
14:36 -!- brakmic [~brakmic@185.183.85.108] has quit []
14:38 -!- baldur [~baldur@pool-100-2-132-165.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:46 -!- calvz14 [aedb2260@96.sub-174-219-34.myvzw.com] has joined #bitcoin-core-dev
14:52 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev
14:53 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Remote host closed the connection]
14:56 -!- Highway62 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
14:57 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Ping timeout: 250 seconds]
14:57 -!- Highway62 is now known as Highway61
15:02 -!- brakmic [~brakmic@185.183.85.108] has quit []
15:02 -!- b10c [~Thunderbi@mue-88-130-54-060.dsl.tropolys.de] has quit [Ping timeout: 268 seconds]
15:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:11 -!- calvz14 [aedb2260@96.sub-174-219-34.myvzw.com] has quit [Remote host closed the connection]
15:12 < fanquake> Is this Appveyor build stalled/broken, or just lacking output: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/29422651 ?
15:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
15:13 < fanquake> Regardless, I guess we could opt out of whatever tracking Microsoft is doing, and fix the boost path length stuff if that is actually an issue..
15:18 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Remote host closed the connection]
15:25 -!- Kiminuo [~mix@141.98.103.86] has quit [Ping timeout: 276 seconds]
15:26 -!- shaunsun__ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
15:26 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
15:26 -!- bitcoinjoe [uid307760@gateway/web/irccloud.com/x-lmmdjelcygwggiyg] has quit [Quit: Connection closed for inactivity]
15:26 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:28 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
15:28 -!- marcoagner [~user@bl11-16-162.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
15:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:31 -!- shaunsun__ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 240 seconds]
15:31 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 250 seconds]
15:31 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
15:43 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
15:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:46 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 265 seconds]
15:55 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
16:00 -!- mreider [~mreider@185.169.255.76] has quit []
16:10 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Read error: Connection reset by peer]
16:11 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
16:12 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
16:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:30 -!- sipsorcery [~sipsorcer@37.228.255.208] has quit [Ping timeout: 252 seconds]
16:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:38 -!- sipsorcery [~sipsorcer@37.228.255.208] has joined #bitcoin-core-dev
16:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 245 seconds]
16:44 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
16:44 -!- sipsorcery [~sipsorcer@37.228.255.208] has quit [Remote host closed the connection]
16:44 -!- sipsorcery [~sipsorcer@37.228.255.208] has joined #bitcoin-core-dev
16:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
16:48 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
16:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
16:56 -!- calvz14 [805c7893@128-092-120-147.biz.spectrum.com] has joined #bitcoin-core-dev
16:59 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
17:00 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
17:03 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Ping timeout: 246 seconds]
17:09 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:12 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 240 seconds]
17:12 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 276 seconds]
17:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
17:16 -!- SukhE1 [~SukhE@185.204.1.185] has joined #bitcoin-core-dev
17:20 -!- sipsorcery [~sipsorcer@37.228.255.208] has quit [Ping timeout: 268 seconds]
17:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
17:34 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:34 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
17:34 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
17:34 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
17:34 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
17:34 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
17:35 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
17:42 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
17:43 -!- calvz14 [805c7893@128-092-120-147.biz.spectrum.com] has quit [Ping timeout: 260 seconds]
17:51 -!- gouhobandgraw [~gouhoband@24.20.197.238] has left #bitcoin-core-dev ["Later, nerds."]
18:11 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:37 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]
18:38 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:42 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
18:44 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 240 seconds]
18:44 -!- wullon [~wullon@241.243.86.88.rdns.comcable.net] has quit [Quit: Ping timeout (120 seconds)]
18:46 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-zkumkkdiuqvwshpb] has quit [Ping timeout: 244 seconds]
18:46 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-mgaytoxyychnoeff] has joined #bitcoin-core-dev
18:47 -!- wullon [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev
18:47 < wumpus> the path length is not actually an issue, it's just a general warning that it always throws
18:49 < wumpus> it's kind of annoying but only in the way that it's overly apparent in the log so it's always a false lead when something goes wrong in appveyor
18:49 < fanquake> wumpus ah ok. Having trouble keeping up with Appveyor changes.
18:54 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 268 seconds]
18:55 < wumpus> the build is based on some package system (vcproj) which has its own breaking changes all the time, I don't know if it offers something like version pinning (it would avoid things randomly breaking on one hand, on the other it'd be one more set of dependency versions to keep up to date...)
18:56 -!- davterra [~dulyNoded@104.140.15.11] has joined #bitcoin-core-dev
18:56 -!- dviola [~diego@187.39.20.207] has joined #bitcoin-core-dev
18:57 < luke-jr> why can't Appveyor just use autotools?
18:57 < wumpus> anyhow I don't know if the new error is caused by that or some change of our own this time: "C:\projects\bitcoin\src\sync.h(139,23): error C2220: the following warning is treated as an error [C:\projects\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj]"
18:57 < wumpus> because eeeeveryone likes to do things their own way
19:00 -!- SukhE1 [~SukhE@185.204.1.185] has quit []
19:00 < wumpus> the last change in sync.h was in september
19:02 < wumpus> "Tries to lock the mutex. Returns immediately. On successful lock acquisition returns true, otherwise returns false. "
19:03 < wumpus> I wonder why we're ignoring that return value and using Base::owns_lock instead
19:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:15 < bitcoin-git> [bitcoin] laanwj opened pull request #17707: util: Use try_lock return value in UniqueLock::TryEnter (master...2019_12_try_lock_returnval) https://github.com/bitcoin/bitcoin/pull/17707
19:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:31 < wumpus> ^^ the other option would be to disable the warning, but I think avoiding unnecessary calls to owns_lock is better
19:33 < wumpus> cfields_: BlueMatt: we should make sure https://bitcoincore.org/depends-sources is up to date
19:47 -!- cmn1 [~cmn@192.145.126.115] has joined #bitcoin-core-dev
19:49 < wumpus> looks like more things broke in appveyor, fixed one warning and a new batch appears
19:52 -!- felixfoertsch23 [~felixfoer@92.117.53.249] has joined #bitcoin-core-dev
19:55 -!- felixfoertsch [~felixfoer@92.117.56.84] has quit [Ping timeout: 276 seconds]
20:07 < wumpus> is #17530 serious UB or should I just close it?
20:07 < gribble> https://github.com/bitcoin/bitcoin/issues/17530 | Use natural alignment for prevector by laanwj . Pull Request #17530 . bitcoin/bitcoin . GitHub
20:09 < wumpus> I have very little interest in language lawyering but AFAIK misaligned integers/pointers can sometimes lead to real issues
20:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
20:22 < sipa> wumpus: i suspect little impact right now in production
20:23 < sipa> becaus epretty much all modern platforms don't care about alignment (at worst it's a performance issue), and for cases where alignment is actually necessary, it'd be an immediate trap rather than misbehavior
20:23 < sipa> but i think there is a concern that compilers may misoptimize in the futurr
20:25 < sipa> and of course it interferes with sanitizers that correctly detect misaligned access...
20:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:28 < wumpus> ok but an immediate trap is also bad
20:28 < wumpus> we don't want the software to crash right?
20:30 < wumpus> do we, in general, try to avoid unalgned accesses in the code?
20:32 < wumpus> (this is the only use of pragma(pack) FWIW)
20:35 < wumpus> I think it's safer to remove it
20:39 < sipa> i'm very surprised that pragma pack actually makes the compiler generate code it considers itself incorrect
20:39 < wumpus> FWIW it's the same in rust, pragma(pack) is a cesspool of UB
20:40 < sipa> looking at the actual chabge
20:40 < sipa> change
20:41 < wumpus> it's for when a data structure needs to be tightly packed in memory, but those are really exceptional, generally mis-informed protocol parsing and such
20:42 < wumpus> I don't think that's the case here, none of that code relies on the struct's binary layout
20:43 < sipa> yeah, my only question is if this significantly changes the size of CScript
20:43 < sipa> as doing so may affect the performance of CCoinsCache
20:44 < sipa> if it doesn't affect it significantly we should just remove the pragma
20:44 < wumpus> but using UB to get a speedup is a bit questionable
20:44 < sipa> oh absolutely!
20:44 < wumpus> I think that's over the line that is reasonable for a probject like this
20:44 < sipa> we need to get rid of the pack regardless, if it causes invalid code
20:45 < sipa> but if just removing it causes a cache impact, we should perhaps look for another solution to get better memory usage
20:46 < wumpus> sure, that's always a good thing
21:01 -!- diogosergio [~diogoserg@176.24.23.243] has joined #bitcoin-core-dev
21:06 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev
21:08 < aj> CScriptBase goes from 32 to 40 bytes for me on clang, after dropping the pragma :(
21:08 -!- diogosergio [~diogoserg@176.24.23.243] has quit [Ping timeout: 240 seconds]
21:11 < wumpus> same in gcc
21:12 < wumpus> I do not really understand why, though
21:15 -!- dandelionLyy [4131268e@65.49.38.142] has joined #bitcoin-core-dev
21:18 < wumpus> let's try shuffling the fields inside prevector
21:19 < aj> i think having the pointer in the union is forcing it to be aligned and/or padded, but shuffling isn't fixing it for me (yet at least)
21:21 < wumpus> I've moved the char* pointer first, then the capacity, then the size
21:21 < wumpus> (but it has to recompile almost everything...)
21:22 < aj> wumpus: yeah, me too. i'm getting the union as 32 bytes despite the array being 28 bytes and the struct having 8+4 bytes
21:22 < wumpus> oh
21:22 < aj> or is sizeof automatically a multiple of alignof? yeah that's it isn't it?
21:24 < wumpus> yes, I think so
21:26 < wumpus> I wonder if there's a way to express not wanting to waste unnecessary bytes in/after the union but still putting everything at the required alignment
21:29 < wumpus> the final word only needs 4-byte alignment not 8-byte
21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
21:32 -!- dandelionLyy [4131268e@65.49.38.142] has quit [Ping timeout: 260 seconds]
21:32 < wumpus> (... putting the size *inside* the union might solve it, but would be even scarier because it'd rely on the two union members overlapping in a certain way)
21:34 < aj> wumpus: could move the pragma to only be around the union declaration, i think that works and would fix the observed bugs, but wouldn't quite guarantee that it was aligned at 8 bytes
21:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 276 seconds]
21:35 < wumpus> it wouldn't fully solve the problem either
21:36 < wumpus> exactly, the outer structure would then get an alignment of 4 instead of 8, I suppose
21:37 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
21:39 < aj> putting size inside the union looks like it'd just invoke other sets of undefined behaviour
21:40 < wumpus> yes
21:40 < wumpus> it's aliasing
21:40 < sipa> hmm, maybe the better question is the sizeof of CCoin
21:40 < sipa> there is a lot more in there than just a CScript
21:45 < sipa> #17060 contains a commit that changes the prevector layout as well, and iirc also removes the pragma pack
21:45 < gribble> https://github.com/bitcoin/bitcoin/issues/17060 | Cache 26% more coins: Reduce CCoinsMap::value_type from 96 to 76 bytes by martinus . Pull Request #17060 . bitcoin/bitcoin . GitHub
21:46 < wumpus> it doesn't seem to remove the pragma pack
21:47 < sipa> oh, then i misremember
21:47 < wumpus> it does put a size inside the union, in addition to the size outside it (which is a smaller type)
21:48 < wumpus> it was worth checking :)
21:53 < aj> oh, there's an alignos specifier in c++11? maybe combine that with pragma pack on just the union? https://en.cppreference.com/w/cpp/language/alignas
21:54 < aj> #pragma pack union d_o_i { }; #pragma pack(pop) alignas(alignof(char*)) d_o_i _union = {}; size_type _size = 0;   with char*indirect before size_type capacity; seems to work
21:55 < sipa> will that not generate unaligned access toi?
21:55 < sipa> too?
21:56 < wumpus> if you can reliably control the alignment of the outer structure, you can pack the fields so that no unaligned access happens
21:56 < wumpus> (I think that's already OK with current prevector, if it happens to end up on a 8-aligned address)
21:57 < aj> sipa: if you used direct_or_indirect elsewhere you could, but alignas() forces _union to be aligned right, and that forces CScritBase to also require 8 byte alignment everywhere it's used, which should fix things i think
21:57 < wumpus> yes, forcing prevctor at align(sizeof(char*)) should do it
21:58 < sipa> ah
21:59 < wumpus> e.g. the current inside of a prevector is, in the indirect case: uint32_t uint32_t char*   ... which is ok, at least for architetectures with 32 and 64 bit pointers, to be even more sure move the char* to the beginning and the size to the end
22:00 -!- cmn1 [~cmn@192.145.126.115] has quit []
22:04 < aj> wumpus: posted a diff in the PR that seems like it works right for me
22:06 < wumpus> that's quite a bigger change than I expected
22:07 < aj> it's mostly comments and static_asserts
22:07 < wumpus> shouldn't you alignas the *outer* structure?
22:08 < wumpus> I'm giving up here, I admit I don't know enough about C++ compilers to do this safely
22:08 < aj> i think you could `class alignas(alignof(char*)) prevector { .. }`
22:08 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 265 seconds]
22:09 < aj> could probably *just* do that and not change the pack pragma or reorder anything even
22:11 < sipa> aj: but what is the resulting impact on CCoinCacheEntry or whatever it is called?
22:11 < sipa> maybe that still grows?
22:12 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 276 seconds]
22:15 < wumpus> I doubt it
22:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:16 < bitcoin-git> [bitcoin] laanwj closed pull request #17530: Use natural alignment for prevector (master...2019_11_prevector) https://github.com/bitcoin/bitcoin/pull/17530
22:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:17 -!- smibarber [~smibarber@217.151.98.168] has joined #bitcoin-core-dev
22:23 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
22:24 < wumpus> aj: ok, looking at your diff more I think putting the #pragma pack(push,1)  inside the structure is a good idea, it makes sure that the size_type size is still aligned correctly no matter what sizeof(T)*N is
22:25 < wumpus> aj: can't find anything wrong with it, I think it would even work out for 128 bit pointers
22:27 < wumpus> e.g. the beginning of _union is aligned to alignas(alignof(char*)), which is where the pointer is
22:27 < wumpus> alignas(char*) seems to work too 
22:28 < aj> so it does!
22:28 -!- smibarber [~smibarber@217.151.98.168] has quit [Remote host closed the connection]
22:30 < aj> before:  Coin: 48,8 CCoinsCacheEntry: 56,8, CScript: 32,1    after:  48,8 56,8 32,8
22:31 < wumpus> that's sizeof(X),alignof(X)?
22:31 < aj> (that's `class alignas(char*) prevector { .. }`, so it seems to work right)
22:31 < aj> yeah, sizeof,alignof
22:32 < wumpus> LGTM then, that should solve the alignment issue without increasing the size of any of the structures
22:33 < sipa> nice!
22:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
22:40 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 250 seconds]
22:50 -!- madwoota1 [~madwoota@185.169.255.76] has joined #bitcoin-core-dev
23:08 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has quit [Ping timeout: 250 seconds]
23:12 -!- Kiminuo [~mix@141.98.103.86] has joined #bitcoin-core-dev
23:20 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
23:36 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
23:36 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev
23:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:48 -!- vasild_ is now known as vasild
23:49 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Quit: leaving]
23:50 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
23:53 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
--- Log closed Tue Dec 10 00:00:33 2019