--- Log opened Thu Dec 12 00:00:34 2019 00:13 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 00:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:33 -!- designwi- [~designwis@51.ip-51-68-136.eu] has quit [Ping timeout: 240 seconds] 00:54 -!- Kiminuo [~mix@141.98.103.126] has joined #bitcoin-core-dev 00:57 -!- designwish [~designwis@51.ip-51-68-136.eu] has joined #bitcoin-core-dev 01:00 -!- csharpsteen [~csharpste@195.206.169.238] has quit [] 01:02 -!- promag [~promag@83.223.234.58] has joined #bitcoin-core-dev 01:03 -!- MasterdonX [~masterdon@104.200.131.6] has quit [Ping timeout: 268 seconds] 01:05 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds] 01:05 < wumpus> heh importing remote desktop services doesn't really make me happy either 01:07 -!- MasterdonX [~masterdon@45.9.250.100] has joined #bitcoin-core-dev 01:10 -!- kanzure [~kanzure@unaffiliated/kanzure] has quit [Ping timeout: 246 seconds] 01:12 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 01:12 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 01:13 -!- promag_ [~promag@188.250.106.244] has joined #bitcoin-core-dev 01:13 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 01:14 -!- promag_ [~promag@188.250.106.244] has quit [Remote host closed the connection] 01:15 -!- promag_ [~promag@188.250.106.244] has joined #bitcoin-core-dev 01:17 < sipsorcery> wumpus: I'll check the msvc build with #17730, hopefully the Wtsapi32.lib can be removed. 01:17 -!- jwheare1 [~jwheare@192.145.126.115] has joined #bitcoin-core-dev 01:18 < gribble> https://github.com/bitcoin/bitcoin/issues/17730 | depends: remove Qt networking features by fanquake . Pull Request #17730 . bitcoin/bitcoin . GitHub 01:18 -!- promag [~promag@83.223.234.58] has quit [Remote host closed the connection] 01:19 -!- promag [~promag@83.223.234.58] has joined #bitcoin-core-dev 01:20 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 01:21 -!- promag [~promag@83.223.234.58] has quit [Remote host closed the connection] 01:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:24 -!- promag [~promag@83.223.234.58] has joined #bitcoin-core-dev 01:26 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:30 -!- promag [~promag@83.223.234.58] has quit [Remote host closed the connection] 01:31 -!- promag [~promag@83.223.234.58] has joined #bitcoin-core-dev 01:37 -!- b10c [~Thunderbi@mue-88-130-54-134.dsl.tropolys.de] has joined #bitcoin-core-dev 01:37 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 01:37 -!- promag [~promag@83.223.234.58] has quit [Remote host closed the connection] 01:38 -!- promag [~promag@83.223.234.58] has joined #bitcoin-core-dev 01:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 260 seconds] 01:43 < wumpus> thanks! 01:44 -!- promag [~promag@83.223.234.58] has quit [Ping timeout: 250 seconds] 01:46 -!- promag [~promag@83.223.251.180] has joined #bitcoin-core-dev 01:49 < wumpus> I really like PEP 540, 'ignore locale settings, just make everything UTF-8 already' 01:50 < wumpus> everyone gets the locale wrong on UNIX platforms anyway 01:50 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 01:50 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 01:51 < wumpus> time to just standardize on UTF-8 and not look back... 01:56 -!- hofuv [~hofuv@89.121.200.102] has quit [Remote host closed the connection] 01:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:57 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3f1966ead6b2...3914e877c476 01:57 < bitcoin-git> bitcoin/master 2bcf1fc Pieter Wuille: Pass a maximum output length to DecodeBase58 and DecodeBase58Check 01:57 < bitcoin-git> bitcoin/master 5909bcd Pieter Wuille: Add bounds checks in key_io before DecodeBase58Check 01:57 < bitcoin-git> bitcoin/master 3914e87 Wladimir J. van der Laan: Merge #17511: Add bounds checks before base58 decoding 01:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:58 < bitcoin-git> [bitcoin] laanwj merged pull request #17511: Add bounds checks before base58 decoding (master...201911_boundedbase58) https://github.com/bitcoin/bitcoin/pull/17511 01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:59 -!- promag__ [~promag@188.250.106.244] has joined #bitcoin-core-dev 01:59 -!- promag_ [~promag@188.250.106.244] has quit [Read error: Connection reset by peer] 02:08 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 02:12 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 02:12 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 02:15 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 02:18 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 245 seconds] 02:41 -!- b10c [~Thunderbi@mue-88-130-54-134.dsl.tropolys.de] has quit [Remote host closed the connection] 02:41 -!- b10c [~Thunderbi@2001:16b8:2ea2:e00:bdc2:7225:1152:ec29] has joined #bitcoin-core-dev 02:43 -!- Kiminuo [~mix@141.98.103.126] has quit [Ping timeout: 250 seconds] 02:43 -!- vasild_ is now known as vasild 02:54 -!- marcoagner [~user@2001:8a0:6a55:8f00:81e3:c539:c514:2d18] has joined #bitcoin-core-dev 03:03 -!- Rafaela42Renner [~Rafaela42@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:08 -!- Rafaela42Renner [~Rafaela42@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds] 03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:17 < bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/3914e877c476...0192bd065230 03:17 < bitcoin-git> bitcoin/master fd9d6ee Andrew Chow: Add GetEncryptionKey() and HasEncryptionKeys() to WalletStorage 03:17 < bitcoin-git> bitcoin/master e576b13 Andrew Chow: Replace LegacyScriptPubKeyMan::vMasterKey with GetDecryptionKey() 03:17 < bitcoin-git> bitcoin/master 97c0374 Andrew Chow: Move Unlock implementation to LegacyScriptPubKeyMan 03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:18 < bitcoin-git> [bitcoin] laanwj merged pull request #17369: Refactor: Move encryption code between KeyMan and Wallet (master...wallet-box-pr-4) https://github.com/bitcoin/bitcoin/pull/17369 03:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:26 -!- promag [~promag@83.223.251.180] has quit [Remote host closed the connection] 03:31 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 265 seconds] 03:32 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 268 seconds] 03:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:54 -!- jonatack [~jon@213.152.162.104] has joined #bitcoin-core-dev 04:00 -!- jwheare1 [~jwheare@192.145.126.115] has quit [] 04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:02 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0192bd065230...75a2a4f35744 04:02 < bitcoin-git> bitcoin/master fabd5b4 MarcoFalke: ci: Use python 3.7 on Windows Github Actions 04:02 < bitcoin-git> bitcoin/master 75a2a4f fanquake: Merge #17726: ci: Use python 3.7 on Windows Github Actions 04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:02 < bitcoin-git> [bitcoin] fanquake merged pull request #17726: ci: Use python 3.7 on Windows Github Actions (master...1912-ciGitHubWindows) https://github.com/bitcoin/bitcoin/pull/17726 04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:06 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75a2a4f35744...8a01450b642a 04:06 < bitcoin-git> bitcoin/master fab2f35 MarcoFalke: doc: Update release process with latest changes 04:06 < bitcoin-git> bitcoin/master 8a01450 fanquake: Merge #17598: doc: Update release process with latest changes 04:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:07 < bitcoin-git> [bitcoin] fanquake merged pull request #17598: doc: Update release process with latest changes (master...1911-docRelNotes) https://github.com/bitcoin/bitcoin/pull/17598 04:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:09 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:20 -!- promag [~promag@83.223.251.180] has joined #bitcoin-core-dev 04:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:24 < bitcoin-git> [bitcoin] brakmic opened pull request #17732: test: check for valgrind presence and set appropriate exit flags (master...valgrind-detection) https://github.com/bitcoin/bitcoin/pull/17732 04:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 04:46 -!- beaups1 [~beaups@195.206.169.238] has joined #bitcoin-core-dev 04:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:55 -!- promag [~promag@83.223.251.180] has quit [Remote host closed the connection] 04:56 -!- Highway61 [~Thunderbi@184.75.209.90] has joined #bitcoin-core-dev 04:56 -!- promag__ [~promag@188.250.106.244] has quit [Remote host closed the connection] 05:00 -!- Highway61 [~Thunderbi@184.75.209.90] has quit [Ping timeout: 250 seconds] 05:03 -!- Goosie [d97a64a2@217-122-100-162.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:05 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8a01450b642a...cf2f43987696 05:05 < bitcoin-git> bitcoin/master 034561f Harris: cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice 05:05 < bitcoin-git> bitcoin/master cf2f439 fanquake: Merge #17687: cli: fix Fatal LevelDB error when specifying -blockfilterind... 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:05 < bitcoin-git> [bitcoin] fanquake merged pull request #17687: cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (master...blockfilter-index-error) https://github.com/bitcoin/bitcoin/pull/17687 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:07 -!- Highway61 [~Thunderbi@184.75.221.138] has joined #bitcoin-core-dev 05:12 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer] 05:21 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 05:25 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 05:26 -!- Goosie [d97a64a2@217-122-100-162.cable.dynamic.v4.ziggo.nl] has quit [Remote host closed the connection] 05:32 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 276 seconds] 05:36 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 05:39 -!- promag [~promag@83.223.251.180] has joined #bitcoin-core-dev 05:48 -!- jonatack [~jon@213.152.162.104] has quit [Ping timeout: 240 seconds] 05:53 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has quit [Ping timeout: 260 seconds] 05:54 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev 06:05 -!- Kiminuo [~mix@141.98.103.126] has joined #bitcoin-core-dev 06:09 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev 06:09 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host] 06:09 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 06:10 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 265 seconds] 06:10 -!- roconnor [~roconnor@host-23-91-187-201.dyn.295.ca] has joined #bitcoin-core-dev 06:19 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 06:26 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-mgaytoxyychnoeff] has quit [Remote host closed the connection] 06:26 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-opikjujzgvysaenu] has joined #bitcoin-core-dev 06:35 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-opikjujzgvysaenu] has quit [Ping timeout: 244 seconds] 06:37 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-kpgrwgxqqsjiuugp] has joined #bitcoin-core-dev 06:38 -!- Kiminuo [~mix@141.98.103.126] has quit [Ping timeout: 268 seconds] 06:58 -!- jonatack [~jon@37.166.226.254] has joined #bitcoin-core-dev 07:00 -!- beaups1 [~beaups@195.206.169.238] has quit [] 07:00 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 07:04 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 07:04 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 07:08 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 240 seconds] 07:09 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 276 seconds] 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:12 < bitcoin-git> [bitcoin] brakmic opened pull request #17735: build: fix typo (master...github-workflow) https://github.com/bitcoin/bitcoin/pull/17735 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:16 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 07:17 -!- Dimlock [~Dimlock@141.98.102.235] has joined #bitcoin-core-dev 07:18 -!- promag [~promag@83.223.251.180] has quit [Remote host closed the connection] 07:29 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has joined #bitcoin-core-dev 07:33 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:33 -!- jnewbery [~john@4.53.92.114] has quit [Read error: Connection reset by peer] 07:39 -!- jnewbery [~john@4.53.92.114] has joined #bitcoin-core-dev 07:39 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:46 -!- promag [~promag@83.223.251.180] has joined #bitcoin-core-dev 07:48 < wumpus> this almost has to be the OOM killer right ? #17733 07:48 < gribble> https://github.com/bitcoin/bitcoin/issues/17733 | bitcoin-qt does not start, terminates with "Killed" and exit code 137 . Issue #17733 . bitcoin/bitcoin . GitHub 07:50 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:53 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:53 -!- jnewbery [~john@4.53.92.114] has quit [Read error: Connection reset by peer] 07:53 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:53 -!- jonatack [~jon@37.166.226.254] has quit [Read error: Connection reset by peer] 07:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:54 -!- davterra [~dulyNoded@104.140.15.11] has quit [Quit: Leaving] 07:54 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Read error: Connection reset by peer] 07:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:55 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf2f43987696...54e11a39e14d 07:56 < bitcoin-git> bitcoin/master 5096baf Harris: build: fix typo 07:56 < bitcoin-git> bitcoin/master 54e11a3 MarcoFalke: Merge #17735: ci: fix typo 07:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:56 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17735: ci: fix typo (master...github-workflow) https://github.com/bitcoin/bitcoin/pull/17735 07:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:56 < wumpus> oh noo you broke #17727 07:56 < gribble> https://github.com/bitcoin/bitcoin/issues/17727 | WIP: Update msvc build to ignore warning and bump Qt version to 5.12.6. by sipsorcery . Pull Request #17727 . bitcoin/bitcoin . GitHub 07:57 < fanquake> yea I'm not sure why 17735 was merged 07:57 < fanquake> Could have at least asked for a proper commit message as well 07:58 -!- jnewbery [~john@4.53.92.114] has joined #bitcoin-core-dev 07:59 < fanquake> As for 17727, if we need to "make appveyor green", can we pull out the part of that PR that will actually make that happen. Rather than rushing through a qt bump that pulls in a bunch of new dependencies. 08:00 < wumpus> the problem is that the old qt vcpkg is not built with the new version of msvc 08:00 < wumpus> so it forces a qt bump indirectly... 08:01 < fanquake> ugh 08:01 < wumpus> but yeah we'd never let travis determine our dependency versions for the autotools build system 08:02 < wumpus> we could give up on appveyor, I think sipsorcery prefers moving to a github action as well 08:02 < wumpus> getting red crosses for every commit is getting kind of annoying so I understand the desire to make it green 08:03 < wumpus> also *other* changes that break MSVC will now sneak through 08:03 < fanquake> Sure. It's very annoying. The other concern is that we tell people to use the precompiled qt binaries to test things on windows, while at the same time are supposedly going to merge changes to the windows (MSVC) build system without even testing/checking them. 08:03 < wumpus> in some ways a faulty CI is worse than no CI at all 08:04 < wumpus> well there's a difference in maturity there: the precompiled binaries are the only supported ones, the MSVC build system is extra and experimental 08:05 < wumpus> it doesn't have nearly the amount of testing the gitian-built executables have 08:05 < fanquake> I'd be happy if just dropped support for all the "other" ways to build on windows aside from the Ubuntu cross-compiling 08:06 < wumpus> I think the only reason to support MSVC is to give windows developers an easier way to build and contribute 08:06 < wumpus> not to actually se MSVC-built bitcoin in production 08:06 < wumpus> also testing with another compiler has turned up some bugs in the past 08:07 < wumpus> which is a sensible reason to do a CI run with it 08:07 < wumpus> (though, this worked just as well without qt) 08:08 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:09 < fanquake> Yes, the introduction of the precompiled qt is where potential issues are. 08:09 < fanquake> One being that if no one is going to bother to check the precompiled binaries, while at the same time, windows build system changes are pushed through with no review just to make the CI green. I'm imaging a worst case scenario where it turns out the new qt is malicious, and coupled with something like linking against the Remote Desktop API, bad things may happen. 08:10 < fanquake> Obviously we do call out that the qt binaries should never be used with funds, testing only etc etc 08:13 < wumpus> at some point you start to wonder how much time is spent making linters, parallel build systems, CI, etc happy versus solving actual end user issues :) 08:14 < wumpus> yes, good point w/ pre-built qt 08:16 < fanquake> > at some point you start to wonder how much time +1 08:18 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Remote host closed the connection] 08:18 < sipsorcery> in the recent past it's been a LOT of time to sort out msvc CI issues (on top of the time PR authors spend looking into CI failures) 08:18 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 08:19 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev 08:20 < sipsorcery> the Qt version bump is a separate issue. Concerns about switching to a new version, even for experimental builds, are fair. 08:22 < wumpus> so we might want to temporarily (or permanently, to replace with github actions) disable appveyor instead 08:22 < wumpus> instead of doing the qt upgrade just because appveyor forces us to 08:23 < sipsorcery> well appveyor didn't force a Qt upgrade, it forced a Qt recompile, and I was seeking to kill two birds with one stone. 08:24 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Remote host closed the connection] 08:24 < sipsorcery> github actions is faster and for that reason it'd get my vote to replace appveyor. 08:25 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev 08:27 < sipsorcery> the advantage travis has had over appveyor, in terms of stability, is the dependencies being locked down 08:28 < sipsorcery> if the installed vcpkg libraries were built and cached externally to the job (same as Qt currently is) it would make them equivalent. 08:28 < ryanofsky> dependencies not being locked down could also be an advantage if we want to know about upcoming breakages 08:29 < ryanofsky> wouldn't it be easy to just ignore all appveyor errors in pull requests if appveyor on master is also broken? 08:30 < sipsorcery> true but to date it's been about a 50% (guess) hit rate on dependency changes being a genuine issue as compared to the package being tinkered with 08:31 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 08:32 < sipsorcery> e.g. the libevent package build was changed to disable threads by default which broke the appveyor build. 08:33 < ryanofsky> sipsorcery, was the libevent problem something appveyor specific that wouldn't affect someone who was trying to use msvc? 08:33 < sipsorcery> no it wasn't appveyor specific 08:34 < sipsorcery> anyone following the instructions and using vcpkg to install libevent would have had the same issue 08:34 < sipsorcery> appveyor updating the build image to use a new version of Visual Studio is the same thing. 08:35 < sipsorcery> anyone who currently attempts to build bitcoin core with Visual Studio 2019 v16.4 will get a compilation error. 08:36 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds] 08:36 < ryanofsky> yeah so all of that stuff seems useful to know about and fix as long as there is an msvc build. and i think it's ok if PR authors see red if their PR breaks the MSVC build 08:36 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 08:36 < ryanofsky> but i don't think PR authors should see red if master is also red 08:37 < ryanofsky> because that is much more likely to be wasting their time 08:37 -!- Krellan [~Krellan@2601:640:4100:e:b1ce:a7af:c031:6a0] has quit [Remote host closed the connection] 08:38 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has joined #bitcoin-core-dev 08:42 < sipsorcery> yeah it'd be nice if the build icon could show yellow or orange if master is broken 08:43 < sipsorcery> i doubt there's a hook in GitHub to control that though 08:43 < ryanofsky> it's another thing we could ask for an as a workaround (though i'd prefer grey to really be able to ignore it) 08:44 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:44 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has quit [Ping timeout: 245 seconds] 08:44 < ryanofsky> as a workaround, maybe if appveyor is failing on a pull request, have it retry the build on master and just show green if both are broken 08:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:46 < bitcoin-git> [bitcoin] sipsorcery closed pull request #17727: WIP: Update msvc build to ignore warning and bump Qt version to 5.12.6. (master...msvc_qtupdate) https://github.com/bitcoin/bitcoin/pull/17727 08:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:49 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Ping timeout: 276 seconds] 08:55 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:56 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev 08:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:00 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Client Quit] 09:01 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev 09:07 -!- promag [~promag@83.223.251.180] has quit [Remote host closed the connection] 09:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:16 < sipsorcery> moneyball: #proposedmeetingtopic appveyor CI future 09:23 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev 09:24 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Ping timeout: 252 seconds] 09:24 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev 09:44 < wumpus> the thing is, CI should be reliable, yes dependenies not being locked down shows about upcoming breakages but that's not something you want to be confronted with while focusining on other things 09:45 < wumpus> it's intrusive and that's annoying, we should set our own priorities based on what is merged and not have it break randomly "oh now you need to stop what you're doing and fix another CI isuse" 09:46 < luke-jr> can we set some CI instances to only warn? 09:46 < luke-jr> I guess ultimately, issues with new deps is really a master/branches-only thing, not PRs 09:46 < wumpus> I don't particularly want all new PRs to fail because there happens to have been a MSVC version that adds a new warning (which wouldn't even be fatal to normal builders) 09:47 < luke-jr> maybe it's a bad fit for CI 09:47 < luke-jr> or can CI instances be only for master/stable branches maybe? 09:47 < wumpus> failing on master it's annoying because it causes *all* PRs to fail, irrespective of that they do 09:47 < luke-jr> not if it doesn't run for PRs? 09:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:48 < wumpus> if it doesn't run for PRs it's pointlessbecause you don't know when it legitimately breaks the build 09:49 < luke-jr> ? 09:49 < luke-jr> I mean have the current CI instances with locked down versions, and new master/stable-only instances that use the latest.. 09:49 < wumpus> the idea of doing a MSVC run is that you can be sure that a PR will work with MSVC, you don't only want to discover that after merge 09:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:50 < luke-jr> I mean, we either run PRs with latest versions or we don't.. 09:51 < wumpus> sure, people are free to run master on whatever platform / library / compiler combinations they want 09:51 < luke-jr> I suppose if we manually check for and fail on warnings, we could exclude ones seen on master 09:56 < sipa> there is also something to be said about warnings/errors from msvc forcing us to maintain better code 09:56 < sipa> but if it's a pain to maintain the CI for it to get a good signal, that's probably not worth the effort 09:56 < wumpus> I don't think anyone is arguing not doing a MSVC build, but it should be stable dependency-wise like the travis one 09:56 -!- lio17 [~lio17@80.ip-145-239-89.eu] has quit [Quit: lio17] 09:57 -!- lio17 [~lio17@80.ip-145-239-89.eu] has joined #bitcoin-core-dev 09:58 < wumpus> all in all we've spent way too much time with CI broken lately, and only a few of those things were due to actual problems introduced in PRs 09:58 < luke-jr> wumpus: so why can't we do that, and add a master-only unstable build so we get alerted to new issues? 09:58 < jeremyrubin> I don't have anything technical to add; but I find it really annoying because it takes up a lot of mental space to get the "build broken" emails just for it to be another dumb msvc issue 09:58 < wumpus> jeremyrubin: same 10:00 -!- Dimlock [~Dimlock@141.98.102.235] has quit [] 10:02 -!- Krellan [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:02 -!- Highway62 [~Thunderbi@96.44.148.114] has joined #bitcoin-core-dev 10:03 -!- Highway61 [~Thunderbi@184.75.221.138] has quit [Ping timeout: 252 seconds] 10:03 -!- Highway62 is now known as Highway61 10:06 < jonatack> agree. when we see 2-3 maintainers and several contributors spending a considerable amount of their time dealing with ci issues i'm thinking of the opportunity cost (and motivation cost) 10:07 < jonatack> make that 4 maintainers actually, just remembered bitcoinbuilds.org 10:07 -!- Krellan [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 10:08 < luke-jr> I think there's probably unanimity on that :P 10:17 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:17 -!- mackr [~mackr@195.206.183.79] has joined #bitcoin-core-dev 10:20 -!- Highway61 [~Thunderbi@96.44.148.114] has quit [Remote host closed the connection] 10:25 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 10:30 < wumpus> heh 10:31 < ryanofsky> i think the compromise for appveyor i was suggesting (show red on a PR if the PR appveyor fails and master passes, green if both pass or both fails) has the best of all worlds 10:31 < ryanofsky> it gives the windows maintainer time to fix problems if anything breaks, while not bothering anybody else, and still showing red if a PR would break the windows build 10:31 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:32 -!- Highway61 [~Thunderbi@96.44.148.114] has joined #bitcoin-core-dev 10:33 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 10:33 < wumpus> yes, I guess "it's not getting worse" as a measure would work 10:33 < jeremyrubin> One thing that's annoying about that in terms of diagnosing errors is that given how checkered failures are, there ends up being an assumption of being rebased on master 10:34 < wumpus> though it could still happen, if the dependency drift still happens, that they change between the run on master (whichwas still succesful) and the PR 10:36 < wumpus> that assumption is already there, AFAIK the CI always runs on the PR merged into master 10:36 < ryanofsky> wumpus, i think that could be addressed by writing the appveyor script as: (git checkout pr && make check) || (git checkout master && ! make check) 10:37 < wumpus> ryanofsky: yes, that would work (though mind, appveyor is already slower than travis) 10:37 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:38 < wumpus> that's why some want to switch to github actions 10:39 < wumpus> (while others, in the past, have expressed to not want to use github actions, for ex. because it is even more vendor lock-in to github) 10:39 < wumpus> but for just the MSVC build it'd not be that bad, I think 10:47 < jtimon> re-review-beg https://github.com/bitcoin/bitcoin/pull/17037 10:50 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Remote host closed the connection] 10:52 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:52 < bitcoin-git> [bitcoin] sipsorcery opened pull request #17736: Update msvc build for Visual Studio 2019 v16.4 (master...msvc_fix_vs2019) https://github.com/bitcoin/bitcoin/pull/17736 10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:00 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has joined #bitcoin-core-dev 11:01 < wumpus> #startmeeting 11:01 < lightningbot> Meeting started Thu Dec 12 19:01:20 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:01 < emilengler> hi 11:01 < moneyball> hi 11:01 < amiti> hi 11:01 < sipa> hi 11:01 < sipsorcery> hi 11:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo 11:01 < wumpus> marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack 11:01 < fanquake> hi 11:01 < jeremyrubin> hi 11:01 < jonatack> hi 11:02 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:02 < fjahr> hi 11:02 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:02 < wumpus> one proposed topic for this week in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a : appveyor CI future 11:02 < fanquake> cc sipsorcery 11:02 < achow101> hi 11:03 < sipsorcery> my suggestion is to switch from appveyor to github actions (which is Azure CI under the hood) purely for speed 11:03 < emilengler> I personally think we should use Cirrus CI only as it supports Windows, Linux, macOS and also FreeBSD 11:03 < wumpus> sorry, that was not the start of the topic 11:04 < wumpus> this is still the "propose your topics" phase of the meeting, then we'll start with high priority for review 11:04 < gwillen> I am hoping to get some feedback this week on #17717 11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17717 | Proposed PSBT sign/broadcast flow . Issue #17717 . bitcoin/bitcoin . GitHub 11:04 < kanzure> HI 11:04 < emilengler> oh sorry 11:04 < sipsorcery> oops sorry 11:04 < wumpus> gwillen: ok, let's addd that as topic then 11:04 < wumpus> #topic High priority for review 11:05 < jeremyrubin> #proposedmeetingtopic finish up #12763 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/12763 | Add RPC Whitelist Feature from #12248 by JeremyRubin . Pull Request #12763 . bitcoin/bitcoin . GitHub 11:05 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 8 blockers, 7 chasing concept ACK 11:05 < jeremyrubin> oh sorry *not* high priority 11:05 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev 11:06 < wumpus> anything to add/remove or that is ready for merge? 11:06 < achow101> #17537 for hi prio 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/17537 | wallet: Cleanup and move opportunistic and superfluous TopUp()s by achow101 . Pull Request #17537 . bitcoin/bitcoin . GitHub 11:06 < nehan> hi 11:07 < wumpus> achow101: for blockers I guess? 11:07 < achow101> yes 11:07 < wumpus> ok, added 11:08 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 276 seconds] 11:08 < wumpus> #topic appveyor CI future (sipsorcery) 11:08 < emilengler> Like I said, I personally think we should use Cirrus CI only as it supports Windows, Linux, macOS and also FreeBSD 11:08 < wumpus> sipsorcery | my suggestion is to switch from appveyor to github actions (which is Azure CI under the hood) purely for speed 11:08 < sipsorcery> second suggestion is to cache the vcpkg dependencies in a .zip file to avoid failures unrelated to PR's. 11:09 < luke-jr> emilengler: ppc64? 11:10 < emilengler> luke-jr: I'm not sure about that but we keep using travis for this purpose only 11:10 < wumpus> I don't think MarcoFalke is here 11:10 < emilengler> could keep* 11:10 < wumpus> is anyone against moving to github actions for just the MSVC build? 11:10 < luke-jr> emilengler: what about distros? 11:10 < wumpus> (there is no question of moving *all*CI to github actions, to be clear) 11:10 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 11:11 < jeremyrubin> wumpus: given that github is a microsoft product seems reasonable :p 11:11 < wumpus> jeremyrubin: heh! 11:11 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Ping timeout: 276 seconds] 11:11 < fanquake> As long as that involves removing all Appveyor usage. 11:11 < emilengler> luke-jr: I'm not sure about distros 11:12 < wumpus> fanquake: yes, it would 11:12 < emilengler> But anyway, I believe that we should use Cirrus CI in the long term. Maybe only for FreeBSD? 11:12 < emilengler> But that's anotehr topic 11:12 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 11:12 < wumpus> fanquake: this would be about replacing appveyor 11:13 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 11:13 < fanquake> wumpus great. If it's faster, and isn't going to be broken seemingly every thrid day for reasons outside our control. 11:13 < wumpus> I can't comment on that 11:13 < fanquake> Maybe the vcpkg maintainers will stop randomly slicing up their packages. 11:14 < MarcoFalke> I got the appveyor timeout back to 90 minutes 11:14 < MarcoFalke> Anything else needs to be fixed? 11:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 11:14 < sipa> but is the issue with appveyor itself, or the fact that vcpkg changes out from under us all the time? 11:14 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev 11:14 < jeremyrubin> My understanding was that it's vcpkg 11:15 < wumpus> both, appveyor is slow and has a low timeout, and the packages switch under us all the time 11:15 < jeremyrubin> But that actions will make it less annoying for non windows maintainers 11:15 < fanquake> There's a good summary of some of the issues in #17736 11:15 < gribble> https://github.com/bitcoin/bitcoin/issues/17736 | Update msvc build for Visual Studio 2019 v16.4 by sipsorcery . Pull Request #17736 . bitcoin/bitcoin . GitHub 11:15 < sipa> okay, so there are two independent issues to be fixed 11:15 < fanquake> 3 if you include the compiler issues. 11:15 < wumpus> yes, I'm not sure in how far they're correlated 11:16 < ryanofsky> well my earlier suggestion for dealing with vcpkg issues will not work if appveyor is too slow 11:16 < sipsorcery> at a guesstimate on appveyor failures: 5% genuinely relate to PR's, 30% vcpkg, 25% python functional tests, 5% appveyor image, 30% appveyor timeout, 5% other. 11:16 < fanquake> a literal roulette wheel 11:17 < sipsorcery> suspect GitHub, Cirrus or Circle could all be the same excepting the timeouts. 11:18 < sipsorcery> assuming similar reliability, my vote would go to whichever one is fastest 11:18 < wumpus> yes 11:19 < sipsorcery> GitHub is substantially faster than appveyor. I haven't tested any other but would be happy to do so if it would help? 11:19 < luke-jr> speed seems likely to be dependent on how many projects are using them 11:19 < luke-jr> ie, if we switch, it will get slow :P 11:20 < wumpus> fair enough, our test suite is pretty heavy! 11:20 < wumpus> sipsorcery: let's just try github next imo 11:20 < wumpus> sipsorcery: no one was strongly against trying them 11:20 < MarcoFalke> What about #17736 ? 11:20 < gribble> https://github.com/bitcoin/bitcoin/issues/17736 | Update msvc build for Visual Studio 2019 v16.4 by sipsorcery . Pull Request #17736 . bitcoin/bitcoin . GitHub 11:21 < wumpus> #17736 would be necessary no matter the CI I think 11:21 < gribble> https://github.com/bitcoin/bitcoin/issues/17736 | Update msvc build for Visual Studio 2019 v16.4 by sipsorcery . Pull Request #17736 . bitcoin/bitcoin . GitHub 11:21 < sipsorcery> if appveyor is being canned 17736 is not required (at least until GitHub upgrade). 11:21 < wumpus> oh 11:21 < MarcoFalke> Has anyone tested the GitHub CI and found any issues? 11:22 < MarcoFalke> I merged it a few days ago 11:22 < fanquake> I didn't realise that Github seems to automatically turn the CI on for any repos that have the config file? Had to turn it off for my own fork. 11:22 < fanquake> Didn't realise until a build had failed and it emailed me. 11:23 < MarcoFalke> Huh 11:23 < MarcoFalke> It was turned off for bitcoin/bitcoin 11:23 < sipa> fanquake: maybe you're part of a weird opt in program? 11:23 < MarcoFalke> ^ 11:23 < fanquake> Yea I'm not talking about bitcoin/bitcoin. Which we had tried to turn "Actions" off for. This was one my fanquake/bitcoin fork. 11:24 < fanquake> sipa could be 11:24 < wumpus> someone, not me at least turned 'actions' back on for bitcoin/bitcoin (which is okay if we're going to use it) 11:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:24 < bitcoin-git> [bitcoin] jamesob opened pull request #17737: Add ChainstateManager, remove BlockManager global (master...2019-12-au.chainman) https://github.com/bitcoin/bitcoin/pull/17737 11:24 < fanquake> wumpus Yea I was wondering how that happened 11:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:25 < wumpus> in any case, let'stest it and talk about it next meeting or so 11:25 < MarcoFalke> Ok, so unless there are objections: Merge #17736 as short term fix, and then (next week maybe) switch to GitHub Actions CI? 11:25 < gribble> https://github.com/bitcoin/bitcoin/issues/17736 | Update msvc build for Visual Studio 2019 v16.4 by sipsorcery . Pull Request #17736 . bitcoin/bitcoin . GitHub 11:25 < sipsorcery> +1 11:25 < fanquake> +1 11:25 < wumpus> ack 11:25 < emilengler> +1 11:25 < wumpus> #topic Proposed PSBT sign/broadcast flow (gwillen) 11:26 < wumpus> #17717 11:26 < gribble> https://github.com/bitcoin/bitcoin/issues/17717 | Proposed PSBT sign/broadcast flow . Issue #17717 . bitcoin/bitcoin . GitHub 11:26 < sipa> yay, PSBT guis 11:27 < gwillen> this is building on top of Sjors' #17509 which is not merged yet 11:27 < gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors . Pull Request #17509 . bitcoin/bitcoin . GitHub 11:27 < gwillen> my general sense is, once we can load PSBTs, the next step is "what are the operations we support on them" 11:27 < gwillen> so I think introducing a simple dialog to analyze them, sign them, broadcast them, and save them is a good next step 11:28 < gwillen> (this is simpler than the dialog from my old branch, for those of you who saw that, but it will reuse a lot of the parts) 11:28 < emilengler> ack 11:28 < sipa> i agree with the observation that an explicit update step is probably unnecessary 11:28 < gwillen> yeah my approach has always been to automatically update the PSBT eagerly when loading it, and that seems to produce good results 11:29 < achow101> seems reasonable 11:29 < gwillen> anyway I'm trying to make this a small and uncontroversial step, so feedback welcomed on the issue, there will be a PR soon, thanks! 11:29 < sipa> the only reason why you'd want that to be explicit is because of privacy concerns (you may not want to reveal bip32 paths you know about keys used), but the sentiment in #17264 seems to be that that needs to be solved differently anyway 11:29 < gribble> https://github.com/bitcoin/bitcoin/issues/17264 | rpc: set default bip32derivs to true for psbt methods by Sjors . Pull Request #17264 . bitcoin/bitcoin . GitHub 11:29 < gwillen> sipa: hmm *nod*, will go read the notes on that 11:29 < instagibbs> yeah making PSBT private is not super well defined to begin with, you need additional roles 11:31 -!- phwalkr [~phwalkr@187.39.241.208] has joined #bitcoin-core-dev 11:31 < instagibbs> especially as more special-case fields are entered into it 11:31 < luke-jr> "update"? 11:31 < instagibbs> luke-jr, filling fields like hd derivation path, etc 11:31 < luke-jr> not signing, though, right? 11:31 < gwillen> luke-jr: it's possible to have a PSBT that doesn't have things like P2SH redeemscripts, witnessscripts, etc. that are required for signing 11:32 < gwillen> I would never have the UI sign automatically, no 11:32 < achow101> luke-jr: correct. update is done before signing 11:32 -!- brakmic [~brakmic@185.183.85.108] has quit [] 11:32 < sipa> luke-jr: BIP 174 updating is filling in UTXOs/prevtxs, bip32 paths, scripts used 11:32 < gwillen> thanks for noting that clarification 11:32 < gwillen> signing is always a big red button that's explicit 11:32 < luke-jr> hmm 11:32 < instagibbs> updating is done to "guide" signing, especially for dumb signers 11:32 < luke-jr> exposing redeemscripts is arguably partially a signature? 11:33 < gwillen> well the design of PSBT in Core is such that the wallet creating the tx will already include them if it knows them 11:33 < sipa> luke-jr: it doesn't involve private keys 11:33 < gwillen> the "update" step only ever occurs separately in unusual cases I think 11:33 < luke-jr> sipa: I'm thinking the script itself is part of the private key 11:33 < jb55> oh that's probably why I could never get rawtx to psbt conversion to work, I probably needed to call utxoupdatepsbt? 11:33 < instagibbs> that conversion is sketchy :) 11:33 < sipa> luke-jr: it should not be considered that way 11:33 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 252 seconds] 11:33 < sipa> luke-jr: as security should not ever depend on keeping scripts private 11:34 < luke-jr> hmm 11:34 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 11:34 < sipa> (it may matter for privacy to keep them secret, but that's a much more complicated issue to solve if desired) 11:34 < gwillen> given that PSBT is pretty dependent on the current workflow, I think the workflow is maybe outside the scope of my specific change 11:34 < achow101> if you want privacy of scripts and derivations paths, psbt ain't it 11:34 < gwillen> but might be worth having a discussion about it at some point 11:34 < luke-jr> I guess the scripts are strictly less a concern than derivation paths 11:35 < jeremyrubin> sipa: it's sometimes possible to compress a HTLC in a taproot branch I think 11:36 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:36 < achow101> jeremyrubin: taproot will have it's own set of fields that hopefully better preserve privacy 11:36 < jb55> should the ui give a privacy warning when copying psbts to clipboard/saving when there's derivation paths included? 11:36 < instagibbs> you'll still need additional roles/flows imo 11:36 < sipa> jb55: imho, no - it's generally not actionable 11:36 < instagibbs> better to me to actually define common flows, and design for those, rather than just guessing 11:37 < sipa> jb55: you have the choice between private and broken, and non-private and functional 11:37 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:37 < gwillen> I think in general PSBTs are also never intended to be published, they are intended to be shared only with required signers 11:37 < instagibbs> hww<->host<->curious co-signer, things like that 11:37 < gwillen> I suspect this really mutes a lot of the privacy issues that could otherwise exist 11:37 < instagibbs> but there's no RPC flow for this 11:37 < gwillen> for most people the required signers will only ever be themselves 11:37 < achow101> gwillen: the main privacy concern is for coinjoins 11:37 < gwillen> or people they already trust with their privacy 11:37 < gwillen> *nod* 11:38 < gwillen> I have not thought a lot about the coinjoin case 11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:38 < bitcoin-git> [bitcoin] fanquake opened pull request #17738: build: remove linking librt for backwards compatibility (master...remove_librt_back_compat) https://github.com/bitcoin/bitcoin/pull/17738 11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:38 < instagibbs> depends on what co-signers require to sign, there can be additional proof data etc 11:38 < achow101> in coinjoins you don't know or trust the other participants. deriv path and scripts could provide an easy way for a coinjoin participant to deanonymize other coinjoin participatns 11:38 < sipa> yeah, the (interesting) privacy issues appear when you're combinging multi-party signing for some inputs, and distinct signers for other inputs 11:39 < sipa> there could be some best effort where we remove bip32 derivation info from finalized inputs 11:39 < gwillen> we may already do that 11:39 < achow101> pretty sure we do 11:39 < gwillen> I know that we strip partial signatures from finalized inputs once we combine them 11:39 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 11:40 < achow101> I think the spec for finalizer says drop everything but final sig/witness and utxo 11:40 < sipa> oh, ok 11:40 < sipa> achow101: i vaguely remember that indeed 11:40 < instagibbs> oh that's not too bad then for most uses already 11:41 < achow101> I think the workflow we should be going for is really the hardware wallet/cold storage one 11:41 < jb55> I still wish there was some hrp that I could glance at the various states a psbt is in, but I guess that ship has sailed 11:41 < instagibbs> well that one can be very naive 11:42 < gwillen> jb55: can you expand "hrp" 11:42 < achow101> human readable aprt 11:42 < achow101> *part 11:43 < gwillen> there is the analyzepsbt rpc which produces what you want, I think 11:43 < sipa> the stage depends on the input... 11:43 -!- phwalkr [~phwalkr@187.39.241.208] has quit [Remote host closed the connection] 11:43 < gwillen> and my goal is for my UI to also expose as much of that as makes sense 11:43 < jb55> yeah perhaps thats just difficulties arising from copying and pasting psbts and the cli, but ui could help a lot here 11:43 < gwillen> I don't think it would make sense to put an hrp in the PSBT itself, you could attack people by having it be secretly out of sync with the rest 11:43 < instagibbs> jb55, different signers may expect different input, so it's kind of hard to say. e.g., one may expect xpub for multisig detection, other may not 11:46 < jeremyrubin> Anything else on this topic? 11:46 < gwillen> I think further comments on my proposal can go on the issue 11:46 < wumpus> #topic RPC Whitelist Feature (jeremyrubin) 11:47 < jeremyrubin> I think this is more or less ready to merge 11:47 < emilengler> The test (#17536) is also rebased on the squashed commit 11:47 < jeremyrubin> It adds the ability to whitelist certain RPCs for credentials for those unfamiliar 11:47 < gribble> https://github.com/bitcoin/bitcoin/issues/17536 | test: Add test for rpc_whitelist by emilengler . Pull Request #17536 . bitcoin/bitcoin . GitHub 11:48 < instagibbs> could you snipe the test? :) if that's ok emilengler 11:48 < emilengler> instagibbs: What do you mean? 11:48 < jeremyrubin> snipe meaning put onto the same branch? I could, I just didn't want to unfairly steal emilengler's merge stats ;) 11:49 < emilengler> jeremyrubin: It's fine 11:49 < instagibbs> emilengler, can jeremy cherry-pick into his branch? I don't like features without tests :) 11:49 < jeremyrubin> big credit to emilengler for putting in the effort to get the tests over the line 11:49 < emilengler> sure 11:49 < wumpus> just make sure to keep the author data the same 11:49 < instagibbs> +1 11:49 < emilengler> Would be nice if you colud put me into the longer commit description 11:50 < jeremyrubin> will do 11:50 < instagibbs> will review 11:50 < emilengler> thanks :) 11:50 < luke-jr> do it without an @ or he'll get spammed by altcoins 11:50 < emilengler> Will close the PR then 11:50 < luke-jr> (usually just maintaining the Author field is enough?) 11:51 < jonatack> will review 11:52 < instagibbs> 8 minutes, any other topics? 11:52 < wumpus> thanks everyone, I don't think we have any more topics so that concludes the meeting 11:52 < instagibbs> kk 11:52 < wumpus> #endmeeting 11:52 < lightningbot> Meeting ended Thu Dec 12 19:52:49 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 11:52 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-12-12-19.01.html 11:52 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-12-12-19.01.txt 11:52 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-12-12-19.01.log.html 11:52 < emilengler> Thanks everyone 11:55 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:55 < instagibbs> MarcoFalke, is there hidden meanings in your signed emojis on PRs :) 11:56 < MarcoFalke> instagibbs: ? 11:59 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 12:00 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 12:02 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:04 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has quit [Ping timeout: 250 seconds] 12:18 -!- b10c [~Thunderbi@2001:16b8:2ea2:e00:bdc2:7225:1152:ec29] has quit [Ping timeout: 250 seconds] 12:22 -!- jpe_ [~jpe@2001:16b8:5c14:ff00:5c0b:9ac:3b11:3dbf] has joined #bitcoin-core-dev 12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:29 < bitcoin-git> [bitcoin] instagibbs closed pull request #17712: sendmany/bumpfee: Avoid address reuse and partial spends as per walle... (master...avoid_reuse_sm_bf) https://github.com/bitcoin/bitcoin/pull/17712 12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:29 -!- jpe_ [~jpe@2001:16b8:5c14:ff00:5c0b:9ac:3b11:3dbf] has quit [Ping timeout: 250 seconds] 12:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:50 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 12:52 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 12:54 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54e11a39e14d...c5e318aea6ad 12:57 < bitcoin-git> bitcoin/master 75d9317 Aaron Clauson: Update msvc build for Visual Studio 2019 v16.4 12:57 < bitcoin-git> bitcoin/master c5e318a MarcoFalke: Merge #17736: Update msvc build for Visual Studio 2019 v16.4 12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17736: Update msvc build for Visual Studio 2019 v16.4 (master...msvc_fix_vs2019) https://github.com/bitcoin/bitcoin/pull/17736 12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 12:58 -!- Aaronvan_ is now known as AaronvanW 13:00 -!- mackr [~mackr@195.206.183.79] has quit [] 13:00 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:00 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 13:11 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:15 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 13:17 -!- SLot [~SLot@217.151.98.168] has joined #bitcoin-core-dev 13:23 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 13:24 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 13:33 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has joined #bitcoin-core-dev 13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 260 seconds] 13:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 13:47 -!- brakmic_ [~brakmic@ip-176-198-40-235.hsi05.unitymediagroup.de] has joined #bitcoin-core-dev 13:50 -!- brakmic [~brakmic@185.183.85.108] has quit [Ping timeout: 240 seconds] 14:06 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:06 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has quit [Ping timeout: 245 seconds] 14:14 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has quit [Ping timeout: 252 seconds] 14:18 -!- Agent69 [~Agent69@105.103.49.62] has joined #bitcoin-core-dev 14:22 -!- Agent69 [~Agent69@105.103.49.62] has left #bitcoin-core-dev [] 14:22 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has quit [Ping timeout: 252 seconds] 14:31 -!- EvaristeGalois [~quassel@unaffiliated/evaristegalois] has joined #bitcoin-core-dev 14:38 -!- b10c [~Thunderbi@mue-88-130-54-134.dsl.tropolys.de] has joined #bitcoin-core-dev 14:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:46 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has joined #bitcoin-core-dev 14:53 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has quit [Ping timeout: 276 seconds] 14:57 -!- Kiminuo [~mix@141.98.103.126] has joined #bitcoin-core-dev 15:03 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 15:07 -!- brakmic_ [~brakmic@ip-176-198-40-235.hsi05.unitymediagroup.de] has quit [] 15:08 -!- Kiminuo [~mix@141.98.103.126] has quit [Ping timeout: 268 seconds] 15:08 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 15:08 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 15:08 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 15:09 -!- raj_149 [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has quit [Read error: Connection reset by peer] 15:09 -!- achow101_ [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 15:09 -!- MasterdonX [~masterdon@45.9.250.100] has quit [Quit: ZNC 1.7.4 - https://znc.in] 15:10 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Read error: Connection reset by peer] 15:10 -!- SLot [~SLot@217.151.98.168] has quit [Ping timeout: 268 seconds] 15:10 -!- exhoplex_ [~exhoplex@btc.tfuel.video] has quit [Ping timeout: 268 seconds] 15:10 -!- murrayn [~murray@unaffiliated/murrayn] has quit [Quit: ZNC 1.7.4 - https://znc.in] 15:10 -!- raj_149 [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 15:10 -!- MasterdonX [~masterdon@45.9.250.100] has joined #bitcoin-core-dev 15:10 -!- exhoplex_ [~exhoplex@btc.tfuel.video] has joined #bitcoin-core-dev 15:10 -!- murray [~murray@static.56.37.130.94.clients.your-server.de] has joined #bitcoin-core-dev 15:11 -!- murray is now known as Guest47752 15:13 -!- darkbot-rc4 [~darkbot-r@141.98.102.179] has joined #bitcoin-core-dev 15:19 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 15:19 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 15:21 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 15:24 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 245 seconds] 15:24 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 245 seconds] 15:24 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 15:27 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:32 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has joined #bitcoin-core-dev 15:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 15:46 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has quit [Ping timeout: 252 seconds] 15:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:56 -!- b10c [~Thunderbi@mue-88-130-54-134.dsl.tropolys.de] has quit [Ping timeout: 276 seconds] 16:00 -!- darkbot-rc4 [~darkbot-r@141.98.102.179] has quit [] 16:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:14 -!- Highway61 [~Thunderbi@96.44.148.114] has quit [Ping timeout: 276 seconds] 16:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 16:17 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 16:17 -!- zombor [~zombor@185.204.1.185] has joined #bitcoin-core-dev 16:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:29 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:36 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-kpgrwgxqqsjiuugp] has quit [Ping timeout: 244 seconds] 16:37 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-onhvpguyocblenzv] has joined #bitcoin-core-dev 16:37 -!- phwalkr [~phwalkr@2001:1284:f01c:beec:2d33:d886:b066:aead] has joined #bitcoin-core-dev 16:37 -!- Guest47752 [~murray@static.56.37.130.94.clients.your-server.de] has left #bitcoin-core-dev [] 16:39 -!- murrayn [~murray@unaffiliated/murrayn] has joined #bitcoin-core-dev 16:41 -!- phwalkr [~phwalkr@2001:1284:f01c:beec:2d33:d886:b066:aead] has quit [Client Quit] 17:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 17:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 17:06 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 17:11 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 246 seconds] 17:21 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 17:22 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 17:29 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 17:34 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 17:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 17:42 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has joined #bitcoin-core-dev 17:47 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has quit [Ping timeout: 276 seconds] 18:09 -!- Tic [~Tic@3.131.23.93.rev.sfr.net] has joined #bitcoin-core-dev 18:11 -!- Tic [~Tic@3.131.23.93.rev.sfr.net] has left #bitcoin-core-dev [] 18:22 -!- Tic [~Tic@3.131.23.93.rev.sfr.net] has joined #bitcoin-core-dev 18:23 -!- Tic [~Tic@3.131.23.93.rev.sfr.net] has quit [Client Quit] 18:24 -!- Tic [~Tic@3.131.23.93.rev.sfr.net] has joined #bitcoin-core-dev 18:31 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:43 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has joined #bitcoin-core-dev 18:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:47 < bitcoin-git> [bitcoin] fanquake opened pull request #17740: build: remove configure checks for win libraries we don't link against (master...remove_windll_configure_checks) https://github.com/bitcoin/bitcoin/pull/17740 18:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:48 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has quit [Ping timeout: 246 seconds] 18:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 18:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 18:51 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 18:51 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 18:51 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 18:55 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 19:00 -!- zombor [~zombor@185.204.1.185] has quit [] 19:06 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 245 seconds] 19:06 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 268 seconds] 19:07 -!- felixfoertsch23 [~felixfoer@2001:16b8:50d3:400:e9e7:d484:5c6c:5266] has joined #bitcoin-core-dev 19:09 -!- felixfoertsch [~felixfoer@92.117.47.103] has quit [Ping timeout: 250 seconds] 19:17 -!- marcoagner [~user@2001:8a0:6a55:8f00:81e3:c539:c514:2d18] has quit [Ping timeout: 252 seconds] 19:17 -!- alexbrown [1b48680f@27.72.104.15] has joined #bitcoin-core-dev 19:17 < alexbrown> hi all 19:17 -!- bugbot1 [~bugbot@141.98.102.235] has joined #bitcoin-core-dev 19:19 < alexbrown> i'm new to bitcoin, i'm trying to send bitcoin from account to an address with rpc method `sendfrom` but it throw an error says ` error: -32: sendfrom is deprecated and will be removed in V0.21. To use this command, start bitcoind with -deprecatedrpc=accounts.` I don't want to use `-deprecatedrpc=accounts` when runs a node. which method should i 19:19 < alexbrown> use? 19:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 19:19 < alexbrown> many thanks 19:21 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has joined #bitcoin-core-dev 19:24 < luke-jr> alexbrown: #bitcoin 19:26 < alexbrown> luke-jr do you mean i should ask in #bitcoin channel? 19:26 < luke-jr> yes 19:26 < luke-jr> it's not a development topic 19:26 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has quit [Ping timeout: 276 seconds] 19:27 < alexbrown> luke-jr i'm doing your suggest, thank you 19:33 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 19:37 -!- Thyla [~Mannaja@179.127.238.216] has joined #bitcoin-core-dev 19:46 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer] 19:47 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has joined #bitcoin-core-dev 19:56 -!- Tic [~Tic@3.131.23.93.rev.sfr.net] has quit [Remote host closed the connection] 20:00 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [] 20:03 -!- Thyla [~Mannaja@179.127.238.216] has quit [Quit: Leaving] 20:05 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 20:05 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 268 seconds] 20:05 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:06 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has joined #bitcoin-core-dev 20:16 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has quit [Ping timeout: 250 seconds] 20:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 20:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 20:22 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has quit [Quit: Textual IRC Client: www.textualapp.com] 20:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds] 20:28 -!- rex4539 [~rex4539@2a02:587:350d:f000:a82b:5a72:4600:8a1d] has joined #bitcoin-core-dev 20:28 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 20:29 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 20:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:58 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 20:59 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 21:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds] 21:08 -!- felixfoertsch23 [~felixfoer@2001:16b8:50d3:400:e9e7:d484:5c6c:5266] has quit [Quit: ZNC 1.7.3 - https://znc.in] 21:08 -!- felixfoertsch [~felixfoer@2001:16b8:50d3:400:5dcc:d5e3:e436:aee9] has joined #bitcoin-core-dev 21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 250 seconds] 21:37 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has joined #bitcoin-core-dev 21:41 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has quit [Ping timeout: 250 seconds] 21:43 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 21:49 -!- alexbrown [1b48680f@27.72.104.15] has quit [Remote host closed the connection] 21:55 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds] 22:00 -!- bugbot1 [~bugbot@141.98.102.235] has quit [] 22:11 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 22:15 -!- Thyla [~Mannaja@179.127.238.216] has joined #bitcoin-core-dev 22:16 -!- hmachado [~hmachado@195.206.183.79] has joined #bitcoin-core-dev 22:31 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 22:44 -!- Thyla [~Mannaja@179.127.238.216] has quit [Quit: Leaving] 23:03 -!- felixfoertsch [~felixfoer@2001:16b8:50d3:400:5dcc:d5e3:e436:aee9] has quit [Quit: ZNC 1.7.3 - https://znc.in] 23:03 -!- felixfoertsch [~felixfoer@2001:16b8:50d3:400:c5b5:e92:2d65:22cd] has joined #bitcoin-core-dev 23:12 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:17 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 23:24 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has joined #bitcoin-core-dev 23:29 -!- Krellan [~Krellan@2601:640:4100:e:f4ba:4573:976a:e6de] has quit [Ping timeout: 250 seconds] 23:41 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 23:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 23:53 -!- Kiminuo [~mix@141.98.103.126] has joined #bitcoin-core-dev 23:53 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 23:53 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 23:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 276 seconds] 23:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev --- Log closed Fri Dec 13 00:00:32 2019