--- Log opened Thu Jan 16 00:00:07 2020
00:03 -!- nejon [uid38993@gateway/web/irccloud.com/x-qlmbhmcjoajedcwm] has joined #bitcoin-core-dev
00:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:13 -!- amiti [sid373138@gateway/web/irccloud.com/x-gpgwtttcmjqraxjw] has joined #bitcoin-core-dev
00:14 -!- cfields [~cfields@unaffiliated/cfields] has quit [Remote host closed the connection]
00:15 -!- cfields [~cfields@unaffiliated/cfields] has joined #bitcoin-core-dev
00:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
00:20 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
00:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
00:22 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
00:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:58 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]
01:00 -!- vkmc [~vkmc@89.238.178.75] has quit []
01:15 -!- volbil [~volbil@211.248.183.246] has quit []
01:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:17 -!- hali [~hali@195.206.169.238] has joined #bitcoin-core-dev
01:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
01:28 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
01:34 -!- vasild_ is now known as vasild
01:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
01:46 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:51 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
01:53 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:58 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac61ec9da679...4e8b564df0d4
01:58 < bitcoin-git> bitcoin/master f117fb0 Elichai Turkel: Replace coroutine with async def in p2p_invalid_messages.py
01:58 < bitcoin-git> bitcoin/master 4e8b564 fanquake: Merge #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because...
01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:58 -!- marcoagner [~user@bl8-87-213.dsl.telepac.pt] has joined #bitcoin-core-dev
01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:58 < bitcoin-git> [bitcoin] fanquake merged pull request #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of warning (master...2020-01-coroutine) https://github.com/bitcoin/bitcoin/pull/17931
01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:02 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 272 seconds]
02:02 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
02:03 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Ping timeout: 260 seconds]
02:04 -!- kexkey [~kexkey@37.120.205.233] has quit [Ping timeout: 260 seconds]
02:08 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:09 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
02:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
02:11 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
02:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
02:20 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
02:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
02:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:29 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
02:34 < meshcollider> promag: will do, I'll have time tomorrow
02:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
02:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:49 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
02:54 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 245 seconds]
03:03 -!- Gaylord25Block [~Gaylord25@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:16 -!- Gaylord25Block [~Gaylord25@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds]
03:18 -!- Guest83_ [~textual@45.32.255.149] has joined #bitcoin-core-dev
03:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
03:48 -!- Guest83_ [~textual@45.32.255.149] has quit [Ping timeout: 268 seconds]
03:52 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 272 seconds]
03:53 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Quit: leaving]
03:56 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:56 -!- marcoagner [~user@bl8-87-213.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
03:58 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
04:00 -!- hali [~hali@195.206.169.238] has quit []
04:01 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
04:08 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
04:08 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
04:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:10 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
04:11 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
04:14 -!- jonatack [~jon@37.173.53.30] has joined #bitcoin-core-dev
04:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
04:17 -!- kees1 [~kees@141.98.102.227] has joined #bitcoin-core-dev
04:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:32 -!- turbo_choo [~turbo_cho@221.0.26.87] has joined #bitcoin-core-dev
04:41 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:49 -!- jcoe [~seru@217.138.196.19] has joined #bitcoin-core-dev
04:54 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
04:56 -!- Kiminuo [~mix@141.98.103.206] has joined #bitcoin-core-dev
05:06 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
05:07 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
05:11 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
05:11 -!- Highway62 [~Thunderbi@173.254.251.234] has joined #bitcoin-core-dev
05:12 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Ping timeout: 272 seconds]
05:12 -!- Highway62 is now known as Highway61
05:17 -!- jonatack [~jon@37.173.53.30] has quit [Ping timeout: 258 seconds]
05:21 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
05:27 < luke-jr> any objections to adding "don't rebase if you don't need to" to developer docs? :x
05:29 < sipa> i think that's good advice
05:29 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-ebiutqgonrirlend] has joined #bitcoin-core-dev
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:30 < bitcoin-git> [bitcoin] Sjors opened pull request #17939: gui: Remove warning "unused variable 'wallet_model'" (master...2020/01/disable-wallet-unused-variable) https://github.com/bitcoin/bitcoin/pull/17939
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:36 < wumpus> I don't think that's useful, in itself, the people doing rebases probably perceive it as needing to, what would be more useful is to list concretely when to rebase and when not
05:38 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
05:38 < sipa> right; but i think it's easy to enumerate the cases when you need to: the PR no longer applies cleanly (=github complains) or (very rarely) a fresh merge succeeds but is incorrect
05:38 < luke-jr> wumpus: sure, I was just being brief on IRC :p
05:38 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Quit: Lost terminal]
05:38 < luke-jr> making sure others agreed before I went to the trouble to write up something
05:38 < wumpus> ok, that makes sense
05:39 < sipa> for a while i would rebase the whole PR any time i made any changs to it... which isn't very compatible with all review workflows
05:40 < sipa> luke-jr: to be clear, by rebase you actually changing the base of the PR, not any invocation of the "git rebase" command
05:40 < luke-jr> sipa: yes
05:40 < sipa> in that case, agreed
05:41 < luke-jr> I'll be clear that fixups and such are fine
05:43 < wumpus> I usually rebase the PR for every change when the PR is new, to avoid 'messy' commits, but when there has been review, it's better to minimise rebases
05:44 < sipa> right
05:44 < wumpus> it really depends on the PR though, sometimes it is even requested by reviewers to split things into (atomic) commits
05:45 < luke-jr> would be nice if more people would do daggy fixes too :x
05:45 < wumpus> I think it's not very easy to enumerate in pracice
05:45 < sipa> daggy?
05:45 < luke-jr> sipa: bugfixes having a base of the commit introducing the bug, unless it makes problems
05:46 < sipa> luke-jr: ugh, not a fan of that :)
05:46 < luke-jr> no downsides, and it means it's a clean merge to all affected branches
05:47 < wumpus> I'm not sure about that, and that's also too much to ask from most people I think regarding git skills
05:47 < luke-jr> hmm
05:47 < luke-jr> still, even if not in docs, would be nice to see people do it more ;)
05:48 < sipa> luke-jr: i guess i haven't even noticed you doing that, which must mean i can't complain
05:48 < luke-jr> usually the only thing noticable is my PR comment like "this is a clean merge to x, y, z" or such
05:52 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Ping timeout: 268 seconds]
05:53 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 268 seconds]
05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:56 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4e8b564df0d4...a9c789ed964d
05:56 < bitcoin-git> bitcoin/master 486f510 Harris: gui: hide HD & encryption icons when no wallet loaded
05:56 < bitcoin-git> bitcoin/master a9c789e fanquake: Merge #17935: gui: hide HD & encryption icons when no wallet loaded
05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:56 < bitcoin-git> [bitcoin] fanquake merged pull request #17935: gui: hide HD & encryption icons when no wallet loaded (master...hdwallet-icon-handling) https://github.com/bitcoin/bitcoin/pull/17935
05:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:57 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-dev
05:59 -!- Highway62 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
06:00 -!- Highway61 [~Thunderbi@173.254.251.234] has quit [Ping timeout: 258 seconds]
06:00 -!- Highway62 is now known as Highway61
06:19 -!- Highway62 [~Thunderbi@173.254.252.130] has joined #bitcoin-core-dev
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:21 < bitcoin-git> [bitcoin] luke-jr opened pull request #17940: doc: Rebasing, when and when not to do it (master...devnotes_rebasing) https://github.com/bitcoin/bitcoin/pull/17940
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:21 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Ping timeout: 265 seconds]
06:21 -!- Highway62 is now known as Highway61
06:22 -!- Highway61 [~Thunderbi@173.254.252.130] has quit [Remote host closed the connection]
06:23 -!- Highway61 [~Thunderbi@173.254.252.130] has joined #bitcoin-core-dev
06:25 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
06:32 -!- turbo_choo [~turbo_cho@221.0.26.87] has quit [Ping timeout: 260 seconds]
06:33 -!- turbo_choo [~turbo_cho@221.0.26.87] has joined #bitcoin-core-dev
06:33 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:51 < bitcoin-git> [bitcoin] Sjors opened pull request #17941: depends: update to Boost 1.72 (master...2020/01/boost-bump) https://github.com/bitcoin/bitcoin/pull/17941
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:00 -!- kees1 [~kees@141.98.102.227] has quit []
07:12 -!- Skirmant [~Skirmant@78-56-81-100.static.zebra.lt] has joined #bitcoin-core-dev
07:17 -!- maop [~maop@141.98.102.227] has joined #bitcoin-core-dev
07:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
07:24 -!- Kiminuo [~mix@141.98.103.206] has quit [Ping timeout: 268 seconds]
07:24 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.7]
07:26 -!- Skirmant [~Skirmant@78-56-81-100.static.zebra.lt] has quit [Ping timeout: 272 seconds]
07:28 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
07:33 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
07:36 -!- justan0theruser is now known as justanotheruser
07:38 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:04 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Remote host closed the connection]
08:05 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev
08:05 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
08:28 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
08:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
08:34 -!- turbo_choo [~turbo_cho@221.0.26.87] has quit [Ping timeout: 240 seconds]
08:35 < elichai2> meta question: free function vs methods?
08:39 -!- turbo_choo [~turbo_cho@221.0.26.87] has joined #bitcoin-core-dev
08:40 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
08:51 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
08:52 -!- abrissbi1ne is now known as abrissbirne
08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:54 < bitcoin-git> [bitcoin] fjahr opened pull request #17942: doc: Improve fuzzing docs for macOS users (master...fuzzing_docs) https://github.com/bitcoin/bitcoin/pull/17942
08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:56 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
09:02 -!- hznc [~hznc@95.164.65.194] has joined #bitcoin-core-dev
09:04 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
09:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
09:10 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:25 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
09:36 < wumpus> elichai2: if it needs to access properties or other methods of the class it should be a method, if it is a pure function the a function is better
09:39 -!- MrPaz [~MrPaz@84.39.112.89] has joined #bitcoin-core-dev
09:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds]
09:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
10:00 -!- maop [~maop@141.98.102.227] has quit []
10:01 < sipa> elichai2: functions are more composable
10:02 < sipa> say you want to have some function that operates on a CTransaction, if you add it as a method, you're forcing every user of CTransaction to depend on your new code
10:02 < sipa> as a free function, implemented where you need it (unless it's very fundamental) can avoid annoying dependency cycles
10:02 < wumpus> also a good point
10:03 < sipa> (^ my personal opinion, which not everyone always agrees with)
10:11 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
10:15 < wumpus> I agree "is it fundamental" is the right question there
10:15 < sipa> right, i guess the differences in opinion aren't so much the principle, but what people consider fundamental
10:15 < wumpus> true
10:17 -!- sirkitree [~sirkitree@89.238.178.75] has joined #bitcoin-core-dev
10:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:24 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a9c789ed964d...f018d0c9cd7f
10:24 < bitcoin-git> bitcoin/master 4b8f1e9 Gregory Sanders: IsUsedDestination shouldn't use key id as script id for ScriptHash
10:24 < bitcoin-git> bitcoin/master 6dd59d2 Gregory Sanders: Don't allow implementers to think ScriptHash(Witness*()) results in nestin...
10:24 < bitcoin-git> bitcoin/master f018d0c Wladimir J. van der Laan: Merge #17924: Bug: IsUsedDestination shouldn't use key id as script id for...
10:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:24 < bitcoin-git> [bitcoin] laanwj merged pull request #17924: Bug: IsUsedDestination shouldn't use key id as script id for ScriptHash (master...reuse_regression) https://github.com/bitcoin/bitcoin/pull/17924
10:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:31 -!- Highway61 [~Thunderbi@173.254.252.130] has quit [Ping timeout: 260 seconds]
10:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:52 < bitcoin-git> [bitcoin] hebasto opened pull request #17943: qt, refactor: Remove never used default parameter (master...20200116-message-parameter) https://github.com/bitcoin/bitcoin/pull/17943
10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:58 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Jan 16 19:00:20 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < hebasto> hi
11:00 < emilengler> hi
11:00 < kanzure> hi
11:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
11:00 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
11:00 < jonatack> hi
11:00 < achow101> hi
11:00 < instagibbs> hi
11:00 < sipa> hi
11:00 < nehan_> hi
11:00 < meshcollider> hi
11:00 < fjahr> hi
11:00 < wumpus> there have been no proposed topics in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a, any last minute proposals?
11:00 < andytoshi> hi
11:01 < adiabat> hi
11:01 < jamesob> hi
11:01 < wumpus> re: 0.19.1, we've made some progress, but there's still 3 PRs that need to be reviewed merged 
11:02 < wumpus> #topic High priority for review
11:02 < wumpus> at the moment, 8 blockers, 3 bugfixes, 6 chasing concept ACK: https://github.com/bitcoin/bitcoin/projects/8   
11:03 < wumpus> the bugfixes are for 0.19 backport, and would be good to have in 0.19.1
11:03 < sipa> what's blocking 0.19.1?
11:04 < wumpus> #17897 definitely needs more review, by someone that understands the indexing code closely
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo . Pull Request #17897 . bitcoin/bitcoin . GitHub
11:04 < jamesob> can I request we add #17737? as an aside, assumeutxo is in pretty good shape - I think it's got pretty broad concept ACK and the prototype branch seems to be working well. if I can get some help with review and testing, we might be able to `loadtxoutset` by the end of the year... and then we can start thinking about (and whether or not it's worth it) to propagate utxo snapshots through the p2p network
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17737 | Add ChainstateManager, remove BlockManager global by jamesob . Pull Request #17737 . bitcoin/bitcoin . GitHub
11:04 < wumpus> sipa: #17897 #17892 and #17887
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo . Pull Request #17897 . bitcoin/bitcoin . GitHub
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof . Pull Request #17892 . bitcoin/bitcoin . GitHub
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17887 | bug-fix macos: give free bytes to F_PREALLOCATE by kallewoof . Pull Request #17887 . bitcoin/bitcoin . GitHub
11:04 < wumpus> the latter two are to work around a macosx bug with preallocating files
11:05 < sipa> ok, that doesn't look too daunting
11:05 -!- jcoe [~seru@217.138.196.19] has quit [Ping timeout: 265 seconds]
11:05 < wumpus> last week there seemed to be agreement that this was important for 0.19.1, I'm somewhat sceptical about working around an OS bug at our side, but they're not terrile backs
11:06 < jamesob> I'll take a look at 17897
11:06 < wumpus> jamesob: great to hear that assumeutxo is on the right track!
11:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:07 < instagibbs> jamesob, is 15606 actually the "child" PR? 
11:07 < instagibbs> or mothership, I dunno
11:07 < jamesob> instagibbs: yep
11:07 < jamesob> more mothership than child
11:08 < jamesob> but all the assumeutxo code is there
11:08 < wumpus> added 17737
11:08 < instagibbs> cool, will review
11:08 < wumpus> please also review #16702, it seems to be pretty close to mergable
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
11:09 < jamesob> instagibbs: thanks! recent utxo snapshots for testing are available here: https://github.com/bitcoin/bitcoin/pull/15606#issuecomment-555213164
11:09 < sipa> #17896 is close too, i think
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/17896 | Serialization improvements (step 2) by sipa . Pull Request #17896 . bitcoin/bitcoin . GitHub
11:09 < jnewbery> hi
11:10 < wumpus> sipa: ah yes, clearly
11:11 < wumpus> the review load is extremely high as usual :)
11:11 < jnewbery> #suggestedtopic Bitcoin Core contributor survey
11:11 < wumpus> #topic Bitcoin Core contributor survey (jnewbery)
11:11 < jnewbery> Thanks wumpus!
11:12 < jnewbery> we're having our next coredev irl meeting soonish
11:12 < promag> hi
11:12 < jnewbery> I'm going to send around a few questions to active contributors before the meeting, and then present the summary at the coredev meeting
11:13 < kanzure> regarding that meeting, i plan to once again collect topics (or maybe someone else will)- so send topic proposals that you'd like to see discussed or that you would like to discuss yourself
11:13 < jnewbery> so expect that in your inbox soon. It shouldn't take too long to fill out
11:13 < jnewbery> that's all I had. Feel free to message me if you have any questions or thoughts about that
11:13 < kanzure> is this meeting related or bitcoin core contributor quality of life questions?
11:13 < wumpus> ok, good to know
11:14 < jnewbery> kanzure: a bit of both. Trying to find out what people's priorities are and if they have any suggestions about the Bitcoin Core process, and then we can talk about them at the meeting
11:14 < kanzure> cool. makes sense.
11:15 < kanzure> maybe add some topic-collection questions too so i can minimize my workload :) not required though!
11:15 < luke-jr> hi
11:16 < luke-jr> jnewbery: do you want those of us who won't make it to do the survey?
11:16 < jnewbery> yes please! Looking for input from anyone who's active in the project.
11:17 < jnewbery> kanzure: good idea. I'll add a topic-collection question and share results with you
11:17 < kanzure> thank you
11:17 < wumpus> thanks jnewbery 
11:18 < wumpus> any other topics for today?
11:20 < wumpus> ok, have a good week then everyone, hope we can get some more of the high priority PRs merged
11:20 < wumpus> #endmeeting
11:20 < lightningbot> Meeting ended Thu Jan 16 19:20:40 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:20 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.html
11:20 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.txt
11:20 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.log.html
11:21 < instagibbs> boxing the wallet is very close :)
11:21 < kanzure> anyone should feel free to pm/email me topic ideas for physical meeting. i was just thinking that something about fuzzing would be a fun topic....
11:21 < kanzure> (or the mutation testing technique for that matter.)
11:22 < luke-jr> jnewbery: btw, by soon just how soon do you mean?
11:22 < instagibbs> oh, I missed the pr review club on fuzzing. :( i even did my homework
11:23 < jonatack> wallet meeting tomorrow, yes?
11:23 < instagibbs> jonatack, yep
11:25 < instagibbs> MarcoFalke, Seems like no one figured out how to run `test_runner.py` for the fuzzer?
11:25 < instagibbs> at least in pr club notes
11:30 < jonatack> instagibbs: nope. still trying to catch the bad-txns-inputs-duplicate cve with that fuzz test PR and the check removed from CheckTransaction().
11:35 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
11:40 -!- Highway61 [~Thunderbi@96.44.143.82] has joined #bitcoin-core-dev
11:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:46 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:54 -!- Highway61 [~Thunderbi@96.44.143.82] has quit [Ping timeout: 260 seconds]
11:55 < instagibbs> I ran it overnight and decided it wasn't getting enough runs per second to be worth it for me
12:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
12:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
12:08 -!- hznc [~hznc@95.164.65.194] has quit [Quit: Leaving]
12:13 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
12:15 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!]
12:17 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer]
12:18 -!- Highway61 [~Thunderbi@96.44.143.82] has joined #bitcoin-core-dev
12:22 < MarcoFalke> instagibbs: The test_runner is mostly for travis
12:23 < MarcoFalke> It is meant to run over existing seeds
12:23 < MarcoFalke> Not really meant to create new inputs
12:24 -!- Kiminuo [~mix@141.98.103.206] has joined #bitcoin-core-dev
12:24 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f018d0c9cd7f...218274de7d1f
12:25 < bitcoin-git> bitcoin/master 42ec499 Jon Atack: doc: developer notes guideline on RPCExamples addresses
12:25 < bitcoin-git> bitcoin/master 218274d MarcoFalke: Merge #17819: doc: developer notes guideline on RPCExamples addresses
12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17819: doc: developer notes guideline on RPCExamples addresses (master...rpc-examples-use-invalid-addresses) https://github.com/bitcoin/bitcoin/pull/17819
12:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:36 -!- Highway61 [~Thunderbi@96.44.143.82] has quit [Ping timeout: 265 seconds]
12:38 -!- jeremyrubin [~jr@4.53.92.114] has joined #bitcoin-core-dev
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/218274de7d1f...ec9b964cc998
12:43 < bitcoin-git> bitcoin/master 1be0b1f Sebastian Falbesoner: test: add functional test for non-standard bare multisig txs
12:43 < bitcoin-git> bitcoin/master ec9b964 MarcoFalke: Merge #17541: test: add functional test for non-standard bare multisig txs...
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17541: test: add functional test for non-standard bare multisig txs (master...20191120-test-for-bare-multisig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17541
12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:44 -!- rex4539 [~rex4539@2a02:587:3514:7a00:c9d4:6ab2:4490:1e46] has joined #bitcoin-core-dev
12:44 < jnewbery> luke-jr: today or tomorrow
12:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec9b964cc998...2aaeca50b22d
12:49 < bitcoin-git> bitcoin/master ef63f5f Sebastian Falbesoner: ci: Combine 32-bit build with CentOS 7 build
12:49 < bitcoin-git> bitcoin/master 2aaeca5 MarcoFalke: Merge #17900: ci: Combine 32-bit build with CentOS 7 build
12:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:49 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17900: ci: Combine 32-bit build with CentOS 7 build (master...20200108-ci-add-32-bit-centos-build) https://github.com/bitcoin/bitcoin/pull/17900
12:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:54 < bitcoin-git> [bitcoin] dongcarl opened pull request #17944: netaddress: Simplify reachability logic (master...2020-01-simplify-reachability) https://github.com/bitcoin/bitcoin/pull/17944
12:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:57 -!- Highway61 [~Thunderbi@96.44.143.82] has joined #bitcoin-core-dev
13:00 -!- sirkitree [~sirkitree@89.238.178.75] has quit []
13:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2aaeca50b22d...95ca6aeec7b8
13:00 < bitcoin-git> bitcoin/master 071f2fc Hennadii Stepanov: script: Add ability to insert copyright to *.sh
13:00 < bitcoin-git> bitcoin/master 1998152 Hennadii Stepanov: script: Add empty line after C++ copyright
13:00 < bitcoin-git> bitcoin/master 6fde9d5 Hennadii Stepanov: script: Update EXLUDE list in copyright_header.py
13:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:01 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17691: doc: Add missed copyright headers (master...20191207-copyright-headers) https://github.com/bitcoin/bitcoin/pull/17691
13:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:08 -!- Highway62 [~Thunderbi@96.44.143.82] has joined #bitcoin-core-dev
13:08 -!- Highway61 [~Thunderbi@96.44.143.82] has quit [Read error: Connection reset by peer]
13:08 -!- Highway62 is now known as Highway61
13:10 < luke-jr> jnewbery: I mean the coredev.tech IRL meetup
13:13 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:29 -!- Guyver2_ [~Guyver@2001:985:f3f:1:d1cf:4ce:bd19:34f8] has joined #bitcoin-core-dev
13:31 -!- Guyver2_ [~Guyver@2001:985:f3f:1:d1cf:4ce:bd19:34f8] has quit [Client Quit]
13:33 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds]
13:33 < jamesob> man my logs are packed with `Feeding [x] bytes of dynamic environment data into RNG`. wonder if we should move that to a debug level.
13:35 -!- MrPaz [~MrPaz@84.39.112.89] has quit [Ping timeout: 272 seconds]
13:36 < sipa> jamesob: update master
13:37 < jamesob> ah, testing a branch.
13:38 < jonatack> jamesob: pull in commit 0ccad08
13:38 < jamesob> jonatack: thanks
13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
13:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
13:46 -!- reeiiko [~reeiiko@141.98.102.227] has joined #bitcoin-core-dev
13:49 -!- rex4539 [~rex4539@2a02:587:3514:7a00:c9d4:6ab2:4490:1e46] has quit [Remote host closed the connection]
14:04 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Quit: jb55]
14:05 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
14:18 -!- jeremyrubin [~jr@4.53.92.114] has quit [Quit: Konversation terminated!]
14:25 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!]
14:27 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
14:27 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
14:27 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
14:28 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 268 seconds]
14:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds]
14:49 -!- swamp [~swamp@tranoo.com] has joined #bitcoin-core-dev
14:55 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
14:59 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
15:08 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
15:16 -!- MrPaz [~MrPaz@84.39.112.88] has joined #bitcoin-core-dev
15:16 -!- MrPaz [~MrPaz@84.39.112.88] has quit [Client Quit]
15:16 -!- hex17or [~hex17or@HSI-KBW-091-089-197-016.hsi2.kabel-badenwuerttemberg.de] has quit [Ping timeout: 268 seconds]
15:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
15:20 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:21 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:24 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Quit: Leaving]
15:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
15:27 -!- pinheadmz [~matthewzi@45.83.89.180] has quit [Read error: Connection reset by peer]
15:43 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
15:51 -!- jarthur [~jarthur@207.114.244.5] has quit []
15:58 < meshcollider> yep let's have the first wallet meeting of 2020 tomorrow for those who want to attend :)
15:59 < fanquake> #tooearlyinthemorning
16:00 -!- reeiiko [~reeiiko@141.98.102.227] has quit []
16:02 < fanquake> meshcollider: can you look at #17889 when available
16:02 < gribble> https://github.com/bitcoin/bitcoin/issues/17889 | wallet: Improve CWallet:MarkDestinationsDirty by promag . Pull Request #17889 . bitcoin/bitcoin . GitHub
16:05 -!- turbo_choo [~turbo_cho@221.0.26.87] has quit [Ping timeout: 268 seconds]
16:12 < meshcollider> Yep :)
16:12 < fanquake> ?
16:16 -!- justmay [~justmay@141.98.102.243] has joined #bitcoin-core-dev
16:17 -!- justmay is now known as Guest95916
16:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:32 -!- ExEric3 [~exeric3@178.132.3.92] has quit [Ping timeout: 252 seconds]
16:33 -!- Eric3 [~exeric3@178.132.3.92] has joined #bitcoin-core-dev
16:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.6]
16:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:10 < promag> meshcollider: i can fix the typo
17:11 < meshcollider> alright I'll wait :)
17:13 < promag> meshcollider: done https://github.com/bitcoin/bitcoin/compare/fd6d0679e7c3a956afc273fa38f64dab3f0ed223..2b1641492fbf81e2c5a95f3e580811ca8700adc5
17:14 < meshcollider> thanks!
17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:16 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/95ca6aeec7b8...7fb94c0ed418
17:16 < bitcoin-git> bitcoin/master 2b16414 Joao Barbosa: wallet: Improve CWallet:MarkDestinationsDirty
17:16 < bitcoin-git> bitcoin/master 7fb94c0 Samuel Dobson: Merge #17889: wallet: Improve CWallet:MarkDestinationsDirty
17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:16 < bitcoin-git> [bitcoin] meshcollider merged pull request #17889: wallet: Improve CWallet:MarkDestinationsDirty (master...2020-01-wallettx-iscacheempty) https://github.com/bitcoin/bitcoin/pull/17889
17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:16 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
17:26 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
17:26 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 265 seconds]
17:27 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
17:49 -!- Highway61 [~Thunderbi@96.44.143.82] has quit [Ping timeout: 258 seconds]
17:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:54 < meshcollider> ah sorry achow101, another rebase on the boxes :'(
17:55 < meshcollider> its one of my priorities this week to try and get that in though
18:06 < promag> meshcollider: I believe a rebase was already necessary, https://github.com/bitcoin/bitcoin/pull/17261/commits/b92575c5a838709e00f90d49bc377e68b5683e9a is already in master :/
18:09 < achow101> how'd that commit sneak in? I guess my last rebase got screwed up somewhere
18:11 < achow101> meshcollider: rebased it. hurry up and merge it please :)
18:13 -!- greypw [~greypw@unaffiliated/greypw] has quit [Remote host closed the connection]
18:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:26 < bitcoin-git> [bitcoin] Empact opened pull request #17945: doc: Fix doxygen errors (master...2020-01-wdocumentation) https://github.com/bitcoin/bitcoin/pull/17945
18:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
18:31 -!- pinheadmz [~matthewzi@45.83.89.180] has joined #bitcoin-core-dev
18:32 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
18:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:33 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
18:38 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
18:38 < luke-jr> ugh, GBT is broken in 0.19?
18:41  * luke-jr facepalms putting such a bug in release notes rather than just fixing it
18:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
18:45 < aj> luke-jr: ?
18:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:45 < luke-jr> aj: "rules" with csv & segwit is absolutely needed
18:46 < luke-jr> without it, miners have no way to know what rules are being used and might produce invalid blocks
18:46 < luke-jr> the BIP is perfectly clear :/
18:49 < aj> ah, i did raise that https://github.com/bitcoin/bitcoin/pull/16060#discussion_r309036184 and https://github.com/bitcoin/bitcoin/pull/16060#issuecomment-520900105 but took your lack of more explicit objection as an okay
18:55 -!- pinheadmz [~matthewzi@45.83.89.180] has quit [Quit: pinheadmz]
18:56 -!- lio17 [~lio17@80.ip-145-239-89.eu] has quit [Ping timeout: 250 seconds]
18:56 -!- lio17 [~lio17@80.ip-145-239-89.eu] has joined #bitcoin-core-dev
19:00 -!- Guest95916 [~justmay@141.98.102.243] has quit []
19:01 -!- abrissbi1ne [~abrissbir@unaffiliated/abrissbirne] has joined #bitcoin-core-dev
19:03 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Quit: The Lounge - https://thelounge.chat]
19:03 < luke-jr> aj: I don't think I saw it
19:04 < aj> yeah, you replied on that first thread, but doesn't look like you looked in any detail
19:04 -!- abrissbirne [~abrissbir@unaffiliated/abrissbirne] has quit [Ping timeout: 256 seconds]
19:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:08 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev
19:17 -!- kutio [~kutio@141.98.101.133] has joined #bitcoin-core-dev
19:21 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Quit: The Lounge - https://thelounge.chat]
19:35 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 265 seconds]
19:36 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
19:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
19:49 -!- pinheadmz [~matthewzi@45.83.89.180] has joined #bitcoin-core-dev
19:50 -!- volbil [~volbil@211.248.183.246] has joined #bitcoin-core-dev
19:55 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
20:01 -!- felixfoertsch [~felixfoer@2001:16b8:5032:f00:b59e:afaa:3ca7:858d] has joined #bitcoin-core-dev
20:03 -!- felixfoertsch23 [~felixfoer@92.117.62.201] has quit [Ping timeout: 260 seconds]
20:11 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-dev
20:15 -!- krvopije [~krvopije@185.106.109.144] has quit [Quit: Leaving]
20:23 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-dev
20:23 -!- krvopije [~krvopije@185.106.109.144] has quit [Remote host closed the connection]
20:23 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-dev
20:24 -!- krvopije [~krvopije@185.106.109.144] has quit [Remote host closed the connection]
20:24 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-dev
20:32 -!- krvopije [~krvopije@185.106.109.144] has quit [Quit: Leaving]
20:33 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-dev
20:34 -!- krvopije [~krvopije@185.106.109.144] has quit [Client Quit]
20:34 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-dev
20:35 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
20:36 -!- krvopije [~krvopije@185.106.109.144] has quit [Client Quit]
20:45 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
21:13 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
21:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
21:18 -!- Kiminuo [~mix@141.98.103.206] has quit [Ping timeout: 272 seconds]
21:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:35 < bitcoin-git> [bitcoin] luke-jr opened pull request #17946: Fix GBT: Restore "!segwit" and "csv" to "rules" key (master...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/17946
21:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
21:53 -!- ppisati [~ppisati@net-5-94-131-100.cust.vodafonedsl.it] has quit [Quit: leaving]
22:00 -!- kutio [~kutio@141.98.101.133] has quit []
22:00 -!- ppisati [~ppisati@net-47-53-205-12.cust.vodafonedsl.it] has joined #bitcoin-core-dev
22:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
22:17 -!- dfj1 [~dfj@139.28.218.198] has joined #bitcoin-core-dev
22:28 -!- Kiminuo [~mix@141.98.103.206] has joined #bitcoin-core-dev
22:58 -!- hex17or [~hex17or@HSI-KBW-091-089-169-130.hsi2.kabel-badenwuerttemberg.de] has joined #bitcoin-core-dev
22:59 -!- Highway61 [~Thunderbi@96.44.143.82] has joined #bitcoin-core-dev
23:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:03 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7fb94c0ed418...2ddf041a8d5e
23:03 < bitcoin-git> bitcoin/master 22c5a98 Peter Bushnell: depends: Consistent use of package variable
23:03 < bitcoin-git> bitcoin/master 2ddf041 fanquake: Merge #17928: depends: Consistent use of package variable
23:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:03 < bitcoin-git> [bitcoin] fanquake merged pull request #17928: depends: Consistent use of package variable (master...patch-4) https://github.com/bitcoin/bitcoin/pull/17928
23:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:13 -!- ariard_ [~ariard@167.99.46.220] has joined #bitcoin-core-dev
23:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:16 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in]
23:16 -!- warren_ [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev
23:17 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
23:18 -!- Netsplit *.net <-> *.split quits: tecnovert, Nebraskka, Madars, ariard, sez, warren, ensign, chjj, jimpo, adiabat
23:18 -!- Nebraskka_ [~Nebraskka@178.62.130.190] has joined #bitcoin-core-dev
23:18 -!- Nebraskka_ [~Nebraskka@178.62.130.190] has quit [Remote host closed the connection]
23:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
23:20 -!- Netsplit over, joins: Nebraskka
23:21 -!- cdecker [~cdecker@mail.snyke.net] has quit [Ping timeout: 240 seconds]
23:23 -!- cdecker [~cdecker@mail.snyke.net] has joined #bitcoin-core-dev
23:39 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:43 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in]
23:44 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
--- Log closed Fri Jan 17 00:00:09 2020