--- Log opened Mon Jan 20 00:00:14 2020 00:12 -!- berndj [~berndj@azna.co.za] has quit [Ping timeout: 260 seconds] 00:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:16 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev 00:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 00:47 -!- kljasdfvv [~flack@p200300D46F0B2500ED9CFA6C20FB8E41.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:53 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds] 00:56 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 01:00 -!- joeykrim1 [~joeykrim@141.98.101.133] has quit [] 01:16 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Remote host closed the connection] 01:17 -!- michal_kubenka [~michal_ku@185.204.1.185] has joined #bitcoin-core-dev 01:17 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 268 seconds] 01:18 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev 01:28 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:29 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 01:32 < promag> wumpus: regarding https://github.com/bitcoin/bitcoin/pull/17965#issuecomment-576008959, do you mean 0.19.2? 01:37 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 01:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 01:57 < fanquake> If anyone disagrees with my comments, please let me know: https://github.com/bitcoin/bitcoin/pull/17958#issuecomment-576196490 02:11 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 02:12 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 02:12 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 02:24 -!- jonatack [~jon@109.232.227.133] has joined #bitcoin-core-dev 02:26 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 240 seconds] 02:30 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev 02:36 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev 02:48 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:03 -!- Greta16Luettgen [~Greta16Lu@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:19 -!- Greta16Luettgen [~Greta16Lu@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 272 seconds] 03:21 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:26 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 03:30 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 03:30 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 04:00 -!- michal_kubenka [~michal_ku@185.204.1.185] has quit [] 04:04 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 04:17 -!- cpow [~cpow@141.98.102.243] has joined #bitcoin-core-dev 04:26 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Read error: Connection reset by peer] 04:26 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 04:27 -!- fanquake [sid369002@gateway/web/irccloud.com/x-xjowvshfejhxjnna] has quit [Read error: Connection reset by peer] 04:27 -!- fanquake [sid369002@gateway/web/irccloud.com/x-zkuwftvtortbmdik] has joined #bitcoin-core-dev 04:27 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Quit: bye] 04:27 -!- paracyst_ [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 04:35 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 240 seconds] 04:42 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 05:16 -!- harrigan_ [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 05:16 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 05:17 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 272 seconds] 05:20 < wumpus> promag: no, I mean 0.20, this bug isn't in 0.19 right? 05:20 < promag> nope 05:22 < promag> I tend to agree with jonasschnelli comment there, but I also think that until split off we can fix without reverting hebasto pr 05:25 < wumpus> fanquake: I completely agree with you there 05:26 -!- masterdonx2 [~masterdon@45.248.79.86] has joined #bitcoin-core-dev 05:26 < wumpus> fanquake: we should try to avoid re-introducing getinfo, if there's additional info that needs to be exposed on RPC, it's best to group it in into one of the existing categories 05:26 < wumpus> if that's *really* not possible, it'd be fine to add a category 05:27 -!- MasterdonX [~masterdon@45.9.250.100] has quit [Ping timeout: 260 seconds] 05:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:28 -!- turbo_choo [~turbo_cho@221.0.24.163] has joined #bitcoin-core-dev 05:29 < wumpus> but "general" is very aspecific and meh 05:29 -!- jonatack [~jon@109.232.227.133] has quit [Read error: Connection reset by peer] 05:35 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev 06:04 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Quit: ZNC 1.7.5 - https://znc.in] 06:05 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 06:08 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 06:19 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 06:22 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Read error: Connection reset by peer] 06:22 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 06:24 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Read error: Connection reset by peer] 06:25 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 06:28 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 06:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 06:33 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 06:45 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 06:48 -!- masterdonx2 [~masterdon@45.248.79.86] has quit [Quit: ZNC 1.7.4 - https://znc.in] 06:49 -!- MasterdonX [~masterdon@45.248.79.86] has joined #bitcoin-core-dev 06:50 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 258 seconds] 06:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 06:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:00 -!- cpow [~cpow@141.98.102.243] has quit [] 07:11 -!- tsujp [~tsujp@110-175-55-149.tpgi.com.au] has joined #bitcoin-core-dev 07:15 -!- morcos_ [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 07:19 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds] 07:19 -!- morcos_ is now known as morcos 07:22 < wumpus> congrats on getting #17896 merged, I've added #17957 to high priority for review instead 07:22 < gribble> https://github.com/bitcoin/bitcoin/issues/17896 | Serialization improvements (step 2) by sipa . Pull Request #17896 . bitcoin/bitcoin . GitHub 07:22 < gribble> https://github.com/bitcoin/bitcoin/issues/17957 | Serialization improvements step 3 (compression.h) by sipa . Pull Request #17957 . bitcoin/bitcoin . GitHub 07:28 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!] 07:31 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 268 seconds] 07:38 < sipa> wumpus: thanks! 07:41 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:46 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving] 07:47 -!- lunaphyte_ [~lunaphyte@89.238.178.75] has joined #bitcoin-core-dev 07:53 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 07:55 -!- turbo_choo [~turbo_cho@221.0.24.163] has quit [Ping timeout: 268 seconds] 07:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 08:00 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev 08:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 08:03 < wumpus> it looks like 0.19.1 is kind of dead in the water, because #17897 #17892 #17887 (all to fix MacOS issues I suppose?) are not really getting reviews or tested ACKs 08:03 < gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo . Pull Request #17897 . bitcoin/bitcoin . GitHub 08:03 < gribble> https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof . Pull Request #17892 . bitcoin/bitcoin . GitHub 08:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17887 | bug-fix macos: give free bytes to F_PREALLOCATE by kallewoof . Pull Request #17887 . bitcoin/bitcoin . GitHub 08:04 < wumpus> FWIW I think it's worth doing 0.19.1 without them if this takes too long 08:04 < wumpus> we had plans to make the release *soon* two weeks ago in the meeting 08:07 -!- thor [~thor@114.252.91.241] has quit [Quit: Konversation terminated!] 08:10 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:13 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 268 seconds] 08:14 < wumpus> if you use macos, please help 08:31 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 08:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 08:47 < hebasto> promag: what do you thing about https://github.com/bitcoin/bitcoin/pull/17965#issuecomment-576045548 ? 08:49 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 08:52 < hebasto> the closed #17035 was added to the 0.19 milestone. Is it worth to add its replacement, #17453, to the 0.20 milestone? 08:52 < gribble> https://github.com/bitcoin/bitcoin/issues/17035 | qt: Fix text display when state of prune button is changed by emilengler . Pull Request #17035 . bitcoin/bitcoin . GitHub 08:52 < gribble> https://github.com/bitcoin/bitcoin/issues/17453 | gui: Fix intro dialog labels when the prune button is toggled by hebasto . Pull Request #17453 . bitcoin/bitcoin . GitHub 08:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:14 < luke-jr> wumpus: might be a good idea to add #17946 to 0.19.1 too; not sure how dangerous the current situation is, but fixing it should be harmless at least 09:14 < gribble> https://github.com/bitcoin/bitcoin/issues/17946 | Fix GBT: Restore "!segwit" and "csv" to "rules" key by luke-jr . Pull Request #17946 . bitcoin/bitcoin . GitHub 09:16 < luke-jr> (that is, I'm suggesting a github tag for 0.19.1 and merging it in if it manages to beat rc1 into master) 09:17 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:18 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:18 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] 09:19 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 09:49 < wumpus> if it's critical we should add it, but at the current pace, the list of PRs for 0.19.1 is growing faster than they're reviewed 09:49 < wumpus> if it can wait for 0.19.2 it's probably better to postpone it 09:57 < luke-jr> I haven't heard of any real-world problems, but I don't know if that's because miners are unaffected in practice, or because they haven't upgraded yet 09:58 < luke-jr> wumpus: if it's just macos stuff lacking reviews, though, this one isn't macos :) 09:58 * luke-jr wonders how many devs use mac 10:00 -!- lunaphyte_ [~lunaphyte@89.238.178.75] has quit [] 10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:04 < bitcoin-git> [bitcoin] hebasto opened pull request #17968: qt: Ensure that ModalOverlay is resized properly (master...20200120-fix-modaloverlay) https://github.com/bitcoin/bitcoin/pull/17968 10:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:09 < wumpus> luke-jr: dunno it seems to be getting attention but no ACKs yet 10:10 < promag> I'm on macos 10:10 < promag> #17897 is not macos specific 10:10 < gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo . Pull Request #17897 . bitcoin/bitcoin . GitHub 10:11 -!- moneyball [sid299869@gateway/web/irccloud.com/x-robisjyjfvphumsd] has quit [Read error: Connection reset by peer] 10:11 < promag> hebasto: will look later 10:11 -!- moneyball [sid299869@gateway/web/irccloud.com/x-ovnazfnmowvbxxke] has joined #bitcoin-core-dev 10:11 < hebasto> promag: ty 10:11 -!- Lexyon___ [sid402723@gateway/web/irccloud.com/x-wcrzpqpngovxwnjy] has quit [Read error: Connection reset by peer] 10:11 -!- Lexyon___ [sid402723@gateway/web/irccloud.com/x-pcosbhmudrtbglex] has joined #bitcoin-core-dev 10:15 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:17 -!- fancyremarker [~fancyrema@139.28.218.198] has joined #bitcoin-core-dev 10:20 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 10:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:40 < bitcoin-git> [bitcoin] laanwj pushed 10 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/bb123c6527c0...98159132c3e7 10:40 < bitcoin-git> bitcoin/0.19 179d55f Joao Barbosa: zmq: Fix due to invalid argument and multiple notifiers 10:40 < bitcoin-git> bitcoin/0.19 7e66d04 Russell Yanofsky: Drop signal CClientUIInterface::LoadWallet 10:40 < bitcoin-git> bitcoin/0.19 eafcea7 Joao Barbosa: gui: Fix duplicate wallet showing up 10:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:40 < bitcoin-git> [bitcoin] laanwj merged pull request #17792: 0.19: Backports (0.19...2019-12-backports) https://github.com/bitcoin/bitcoin/pull/17792 10:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:41 < promag> please add 17457 to project 2 10:43 < promag> 13339 15202 17878 too 10:43 < promag> not sure why I can't do it 10:48 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 10:54 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Remote host closed the connection] 11:04 -!- msafi [~msafi@50.233.1.98] has quit [Remote host closed the connection] 11:04 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 11:07 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 268 seconds] 11:10 -!- msafi [~msafi@50.233.1.98] has quit [Ping timeout: 258 seconds] 11:10 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 11:11 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:25 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a654626f076a...7e841f3f9b6c 11:25 < bitcoin-git> bitcoin/master e1c582c Sanjay K: contrib: makeseeds: Read suspicious hosts from a file instead of hardcoding 11:25 < bitcoin-git> bitcoin/master 7e841f3 Wladimir J. van der Laan: Merge #17823: scripts: Read suspicious hosts from a file instead of hardco... 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:25 < bitcoin-git> [bitcoin] laanwj merged pull request #17823: scripts: Read suspicious hosts from a file instead of hardcoding (master...master) https://github.com/bitcoin/bitcoin/pull/17823 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:26 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 11:29 -!- msafi [~msafi@50.233.1.98] has quit [Remote host closed the connection] 11:30 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 11:30 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:32 -!- Highway62 [~Thunderbi@173.254.255.34] has joined #bitcoin-core-dev 11:32 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Ping timeout: 268 seconds] 11:32 -!- Highway62 is now known as Highway61 11:34 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 260 seconds] 11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:35 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7e841f3f9b6c...5d2ff75e2070 11:35 < bitcoin-git> bitcoin/master 297e098 Ben Woosley: Fix doxygen errors 11:35 < bitcoin-git> bitcoin/master 5d2ff75 Wladimir J. van der Laan: Merge #17945: doc: Fix doxygen errors 11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:36 < bitcoin-git> [bitcoin] laanwj merged pull request #17945: doc: Fix doxygen errors (master...2020-01-wdocumentation) https://github.com/bitcoin/bitcoin/pull/17945 11:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:39 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5d2ff75e2070...daae6403d8bd 11:39 < bitcoin-git> bitcoin/master bcad014 practicalswift: tests: Add fuzzing harness for DecodeHexTx(...) 11:39 < bitcoin-git> bitcoin/master 3f95fb0 practicalswift: build: Sort fuzzing harnesses to avoid future merge conflicts 11:39 < bitcoin-git> bitcoin/master daae640 Wladimir J. van der Laan: Merge #17777: tests: Add fuzzing harness for DecodeHexTx(...) 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:39 < bitcoin-git> [bitcoin] laanwj merged pull request #17777: tests: Add fuzzing harness for DecodeHexTx(...) (master...fuzzers-decode_tx) https://github.com/bitcoin/bitcoin/pull/17777 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:43 -!- msafi [~msafi@50.233.1.98] has quit [Ping timeout: 240 seconds] 11:45 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:52 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 11:52 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:54 -!- alex_post [2332046a@35.50.4.106] has joined #bitcoin-core-dev 11:55 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:55 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/daae6403d8bd...631df3ee87ec 11:55 < bitcoin-git> bitcoin/master f2645c2 fanquake: windows: Enable heap terminate-on-corruption 11:55 < bitcoin-git> bitcoin/master 3d5d7aa fanquake: windows: remove call to SetProcessDEPPolicy 11:55 < bitcoin-git> bitcoin/master 631df3e Wladimir J. van der Laan: Merge #17916: windows: Enable heap terminate-on-corruption 11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:56 < bitcoin-git> [bitcoin] laanwj merged pull request #17916: windows: Enable heap terminate-on-corruption (master...win_set_heap_terminate_on_corruption) https://github.com/bitcoin/bitcoin/pull/17916 11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:56 -!- LuftyLuft [2e61a896@46.97.168.150] has joined #bitcoin-core-dev 11:56 -!- tryphe_ is now known as tryphe 11:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:00 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 12:05 -!- aerth [sid386971@gateway/web/irccloud.com/x-kmjbhuukdflhyzrn] has quit [Changing host] 12:05 -!- aerth [sid386971@unaffiliated/aerth] has joined #bitcoin-core-dev 12:05 -!- aerth [sid386971@unaffiliated/aerth] has quit [Changing host] 12:05 -!- aerth [sid386971@gateway/web/irccloud.com/x-kmjbhuukdflhyzrn] has joined #bitcoin-core-dev 12:06 -!- msafi [~msafi@50.233.1.98] has quit [Ping timeout: 268 seconds] 12:11 -!- LuftyLuft [2e61a896@46.97.168.150] has quit [Remote host closed the connection] 12:12 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 12:14 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 12:15 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 12:17 -!- msafi [~msafi@50.233.1.98] has quit [Ping timeout: 268 seconds] 12:23 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Read error: Connection reset by peer] 12:23 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-dev 12:24 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 12:28 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 12:33 -!- msafi [~msafi@50.233.1.98] has quit [Ping timeout: 268 seconds] 12:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 12:45 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 12:52 -!- msafi [~msafi@50.233.1.98] has quit [Ping timeout: 240 seconds] 12:52 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 13:00 -!- fancyremarker [~fancyrema@139.28.218.198] has quit [] 13:04 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!] 13:08 -!- msafi [~msafi@50.233.1.98] has quit [Remote host closed the connection] 13:08 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 13:11 -!- msafi [~msafi@50.233.1.98] has quit [Remote host closed the connection] 13:11 -!- msafi [~msafi@50.233.1.98] has joined #bitcoin-core-dev 13:17 -!- DJWillis1 [~DJWillis@195.206.169.238] has joined #bitcoin-core-dev 13:17 -!- nullptr_ [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in] 13:18 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 13:18 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has joined #bitcoin-core-dev 13:22 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 13:28 -!- rex4539 [~rex4539@2a02:587:3514:7a00:6496:14ef:d21c:5d5e] has joined #bitcoin-core-dev 13:28 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 13:31 -!- alex_post [2332046a@35.50.4.106] has quit [Remote host closed the connection] 13:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 13:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 13:54 -!- roconnor [~roconnor@host-104-157-187-25.dyn.295.ca] has joined #bitcoin-core-dev 14:25 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 14:38 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 15:05 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 15:07 -!- k3tan [ketan@gateway/vpn/protonvpn/k3tan] has joined #bitcoin-core-dev 15:14 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 15:50 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Ping timeout: 265 seconds] 16:00 -!- DJWillis1 [~DJWillis@195.206.169.238] has quit [] 16:12 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:14 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds] 16:15 -!- jimmy90 [49beac58@c-73-190-172-88.hsd1.tn.comcast.net] has joined #bitcoin-core-dev 16:17 -!- MalekAlrwily [~MalekAlrw@195.206.183.79] has joined #bitcoin-core-dev 16:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 17:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 17:22 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev 17:27 < fanquake> promag: I've added them. Adding/removing things from the project boards requires permissions that also let you do a bunch of other things on the repository, that we don't need everyone having access too. 17:29 -!- msafi [~msafi@50.233.1.98] has quit [Remote host closed the connection] 17:37 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:27 -!- thelounge2467250 [~m1rror@109.134.206.46] has quit [Quit: Ping timeout (120 seconds)] 18:28 -!- thelounge2467250 [~m1rror@109.134.206.46] has joined #bitcoin-core-dev 18:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 18:37 -!- thor [~thor@114.252.99.86] has joined #bitcoin-core-dev 18:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 18:47 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 260 seconds] 18:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:00 -!- MalekAlrwily [~MalekAlrw@195.206.183.79] has quit [] 19:01 -!- abrissbi1ne [~abrissbir@unaffiliated/abrissbirne] has joined #bitcoin-core-dev 19:02 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 260 seconds] 19:04 -!- abrissbirne [~abrissbir@unaffiliated/abrissbirne] has quit [Ping timeout: 256 seconds] 19:05 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev 19:17 -!- csslayer1 [~csslayer@141.98.102.227] has joined #bitcoin-core-dev 19:38 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 19:38 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 19:52 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:56 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 268 seconds] 19:58 -!- felixfoertsch [~felixfoer@2001:16b8:50c2:f400:dd0:37a4:bf22:a1fd] has joined #bitcoin-core-dev 19:59 -!- felixfoertsch23 [~felixfoer@2001:16b8:501d:9300:7c6a:9a42:6257:ed30] has quit [Ping timeout: 252 seconds] 20:25 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 20:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:47 -!- msafi [~msafi@2601:647:5a01:8730:d5fa:8c9a:e65f:cfb2] has joined #bitcoin-core-dev 20:48 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 268 seconds] 20:50 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 258 seconds] 20:51 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev 20:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 21:02 -!- thor [~thor@114.252.99.86] has quit [Quit: Konversation terminated!] 21:02 -!- thor [~thor@114.249.51.42] has joined #bitcoin-core-dev 21:03 -!- thor [~thor@114.249.51.42] has quit [Client Quit] 21:04 -!- thor [~thor@114.249.51.42] has joined #bitcoin-core-dev 21:04 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-peewdyazmopwzjvg] has quit [Ping timeout: 248 seconds] 21:22 < ossifrage> wow, bitcoin seems to run much faster on a mdraid10+xfs vs btrfs+raid1 21:23 < ossifrage> (same drives) 21:23 < ossifrage> it has been grinding through 11 weeks of mainnet blocks at a nice rate 21:24 < BlueMatt> btrfs eats databases cause cow/checksumming, also raid1 vs raid10.... 21:26 -!- turbo_choo [~turbo_cho@60.208.181.200] has joined #bitcoin-core-dev 21:27 < ossifrage> BlueMatt, only 2 disks 21:28 < ossifrage> I had a drive get knocked off the bus due to some 'event' and the recovery was a torture, never had the same problems with mdraid 21:29 < BlueMatt> point being apples != oranges. 21:29 -!- thor [~thor@114.249.51.42] has left #bitcoin-core-dev [] 21:29 < ossifrage> btrfs seems to have bugs related to it throwing ENOSPC and getting in a state where you can't mount it rw anymore (and no recovery path) 21:30 -!- meshcollider [meshcollid@209.141.50.204] has joined #bitcoin-core-dev 21:31 < ossifrage> BlueMatt, it is effectively the same mirrored disk layout, I just used the raid10 driver because it did a good job at starting the array in a degraded state 21:31 < BlueMatt> google cow/btrfs checksumming 21:32 < ossifrage> Yeah I had btrfs screw up all the checksums when doing CoW + vmware 21:32 < BlueMatt> btrfs is verrryyyy different than xfs 21:32 < ossifrage> but I was committed to it at that point, didn't have enough space to recover 21:32 < ossifrage> this failure mode gave me a chance to dump btrfs 21:33 < ossifrage> (mounted half the btrfs and created half a mdraid+xfs, copied the data over and then rebuilt the array) 21:34 -!- turbo_choo [~turbo_cho@60.208.181.200] has quit [Ping timeout: 272 seconds] 21:34 < ossifrage> But I did get bitten by dedupe, I forgot I had deduped the btrfs volume and when copying over the data I tarballed some of the stuff and ended up using 50G more 21:35 < ossifrage> Crap: 2020-01-21T05:25:47.282128Z *** Disk space is too low! 21:36 < ossifrage> huh, the bitcoin-qt UI won't raise after throwing the low disk space error 21:43 -!- turbo_choo [~turbo_cho@60.208.181.200] has joined #bitcoin-core-dev 21:48 -!- turbo_choo [~turbo_cho@60.208.181.200] has quit [Ping timeout: 268 seconds] 21:56 < luke-jr> BlueMatt: ZFS does CoW/checksumming and doesn't perform terrible FWIW 21:58 < ossifrage> one really annoying thing with btrfs is it doesn't spread raid1 reads uniformly over both drives 21:58 < ossifrage> it does some stupid pid&1 thing to figure which drive gets the io 22:00 -!- csslayer1 [~csslayer@141.98.102.227] has quit [] 22:00 < ossifrage> The bitcoin-qt UI really didn't like running out of disk, I wasn't able to raise it and I ended up having to do a hard kill to get it to exit 22:00 -!- ooblockchain [~thor@114.249.51.42] has joined #bitcoin-core-dev 22:00 < luke-jr> if it ran out of space, it should be shutting down 22:00 < luke-jr> which can take some time 22:01 < ossifrage> it didn't seem to be making any progress shutting down (or any sign in the log that it was trying) 22:01 < luke-jr> might be a bug 22:01 < luke-jr> or if the disk was completely full, it might have been blocking 22:01 < ossifrage> (I freed up 12G right away) 22:02 < ossifrage> after the 'too low' message all I got was ping and socket send timeouts in the log 22:02 < luke-jr> anyway, I definitely wouldn't advise using btrfs. I still have some, and almost always regret not migrating it, when I access it 22:02 < ossifrage> luke-jr, I was happy to finally get rid of it 22:03 < ossifrage> but the process was rather painful (especially when it turned out nothing was wrong with the drive) 22:09 -!- ooblockchain is now known as thor 22:09 -!- thor is now known as saintthor 22:12 -!- saintthor is now known as ooblockchain 22:17 -!- tasmo [~tasmo@77.243.177.38] has joined #bitcoin-core-dev 22:17 -!- tasmo is now known as Guest12657 22:35 -!- msafi [~msafi@2601:647:5a01:8730:d5fa:8c9a:e65f:cfb2] has quit [] 22:42 -!- Guest12657 [~tasmo@77.243.177.38] has quit [Remote host closed the connection] 22:47 -!- ooblockchain [~thor@114.249.51.42] has quit [Quit: Konversation terminated!] 22:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:58 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev 23:18 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 23:20 -!- itnet7 [~itnet7@84.39.117.57] has joined #bitcoin-core-dev 23:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 23:32 -!- itnet7 [~itnet7@84.39.117.57] has quit [] 23:50 -!- Gunni1 [~Gunni@141.98.102.227] has joined #bitcoin-core-dev 23:50 < kallewoof> I just realized that both of the two macos fixes I have PR:s for will, combined, fix the APFS pre-allocation issue. As long as you ftruncate to the pre-allocated size, the system will successfully reclaim space when you shrink the file later. I.e. preallocate 1 mb; truncate 128 b -> 1 mb file, whereas preallocate 1 mb, truncate 1 mb, truncate 128 b -> 4 k (or whatever the sector (?) size happens to be). 23:52 < kallewoof> Actually, even better.. the F_PREALLOCATE fix alone will fix it, since it does the truncation correctly. 23:56 < kallewoof> Actually#2, it seems like you don't even need to ftruncate to the file size in question, you just need to be near it. Which is good, since we are over-pre-allocating by up to . 23:56 < gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value . Issue #2 . bitcoin/bitcoin . GitHub --- Log closed Tue Jan 21 00:00:15 2020