--- Log opened Thu Jan 30 00:00:24 2020
00:07 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:09 -!- cryptoIndio [~cryptoInd@49.145.111.146] has quit [Remote host closed the connection]
00:09 -!- cryptoIndio [~cryptoInd@49.145.111.146] has joined #bitcoin-core-dev
00:09 -!- cryptoIndio [~cryptoInd@49.145.111.146] has quit [Remote host closed the connection]
00:10 -!- cryptoIndio [~cryptoInd@49.145.111.146] has joined #bitcoin-core-dev
00:11 < aj> wtf
00:11 < aj> fanquake: this seems to be a bug in tx deserialisation ever since segwit has existed?
00:12 < aj> oh no that's too strong, i can't compile the segwit PR. hmm
00:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
00:33 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has quit [Quit: ZNC 1.7.5 - https://znc.in]
00:33 -!- real_or_random [~real_or_r@173.249.7.254] has joined #bitcoin-core-dev
01:00 -!- Mark_Cockrell [~Mark_Cock@141.98.101.133] has quit []
01:03 < aj> fanquake: #18028 should be the problem, completely unrelated if so
01:03 < gribble> https://github.com/bitcoin/bitcoin/issues/18028 | Some transactions cant be decoded from hex strings . Issue #18028 . bitcoin/bitcoin . GitHub
01:04 < fanquake> aj: thanks for following up! Looks like a pretty rare failure then
01:11 -!- promag [~promag@83.223.251.99] has joined #bitcoin-core-dev
01:13 -!- chief19831 [~chief1983@141.98.101.133] has joined #bitcoin-core-dev
01:28 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]
01:29 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:38 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-yrjzcjsccopsosvz] has quit [Quit: Connection closed for inactivity]
01:43 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
01:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:02 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
02:05 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Ping timeout: 240 seconds]
02:10 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
02:34 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds]
02:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
03:04 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-mroisfihdsoblqpq] has left #bitcoin-core-dev []
03:07 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev
03:14 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-flpqfkzkgmrswliu] has quit [Quit: User has been idle for 30+ days.]
03:14 -!- transist0[m] [transist0m@gateway/shell/matrix.org/x-ujdtxoklapuasdjg] has quit [Quit: User has been idle for 30+ days.]
03:14 -!- castlenine[m] [castlenine@gateway/shell/matrix.org/x-bizkjhbuhkdudisz] has quit [Quit: User has been idle for 30+ days.]
03:20 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection]
03:20 -!- braydonf_ [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
03:34 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:40 -!- jonatack [~jon@109.202.103.170] has joined #bitcoin-core-dev
03:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
03:57 -!- promag [~promag@83.223.251.99] has quit [Remote host closed the connection]
04:00 -!- chief19831 [~chief1983@141.98.101.133] has quit []
04:02 -!- tecnecio_ [~tecnecio_@92.58.58.54] has quit [Remote host closed the connection]
04:03 -!- tecnecio_ [~tecnecio_@92.58.58.54] has joined #bitcoin-core-dev
04:07 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:14 -!- larsivi [~larsivi@184.75.223.227] has joined #bitcoin-core-dev
04:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:18 -!- promag [~promag@31.22.201.128] has joined #bitcoin-core-dev
04:40 -!- jonatack [~jon@109.202.103.170] has quit [Ping timeout: 246 seconds]
04:43 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
04:47 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
04:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
04:48 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer]
05:04 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
05:09 -!- promag [~promag@31.22.201.128] has quit [Remote host closed the connection]
05:20 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Ping timeout: 265 seconds]
05:21 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev
05:24 -!- pkr [~pkr@45.92.32.3] has joined #bitcoin-core-dev
05:25 < kallewoof> If people have time, energy, effort, will, and patience, please review the signet BIP? It feels like it's frozen in place! #16411
05:25 < gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof . Pull Request #16411 . bitcoin/bitcoin . GitHub
05:26 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
05:37 -!- pkr [~pkr@45.92.32.3] has quit [Remote host closed the connection]
05:38 -!- pkr [~pkr@45.92.32.3] has joined #bitcoin-core-dev
05:42 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
05:45 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
05:48 -!- pkr [~pkr@45.92.32.3] has quit []
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:53 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/44c2400bccbc...0130abbdb7f5
05:53 < bitcoin-git> bitcoin/master 1b96a3c fanquake: tests: reset fIsBareMultisigStd after bare-multisig tests
05:53 < bitcoin-git> bitcoin/master 0130abb MarcoFalke: Merge #18018: tests: reset fIsBareMultisigStd after bare-multisig tests
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18018: tests: reset fIsBareMultisigStd after bare-multisig tests (master...fix_p2sh_tests_failure) https://github.com/bitcoin/bitcoin/pull/18018
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:57 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0130abbdb7f5...7fcaa8291c6e
05:59 < bitcoin-git> bitcoin/master 6ef0491 practicalswift: tests: Update FuzzedDataProvider.h from upstream (LLVM)
05:59 < bitcoin-git> bitcoin/master ccc3c76 practicalswift: tests: Add fuzzer strprintf to FUZZERS_MISSING_CORPORA (temporarily)
05:59 < bitcoin-git> bitcoin/master cc668d0 practicalswift: tests: Add fuzzing harness for strprintf(...)
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18009: tests: Add fuzzing harness for strprintf(...) (master...fuzzers-strprintf) https://github.com/bitcoin/bitcoin/pull/18009
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:02 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev
06:32 -!- davterra [~dulyNoded@172.98.86.80] has quit [Ping timeout: 265 seconds]
06:32 -!- davterra [~dulyNoded@209.58.134.48] has joined #bitcoin-core-dev
06:32 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
06:41 -!- davterra [~dulyNoded@209.58.134.48] has quit [Quit: Leaving]
06:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
06:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:42 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7fcaa8291c6e...3b69310beb17
06:42 < bitcoin-git> bitcoin/master faf4081 MarcoFalke: test: Make msg_tx a witness tx
06:42 < bitcoin-git> bitcoin/master fa6b57b MarcoFalke: test: Fix whitespace in p2p_permissions.py
06:42 < bitcoin-git> bitcoin/master aaaae4d MarcoFalke: test: Add p2p test for forcerelay permission
06:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:42 < bitcoin-git> [bitcoin] laanwj merged pull request #17984: test: Add p2p test for forcerelay permission (master...2001-qaTxForceRelay) https://github.com/bitcoin/bitcoin/pull/17984
06:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:46 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]
06:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:58 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:00 -!- larsivi [~larsivi@184.75.223.227] has quit []
07:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
07:01 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
07:05 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
07:08 < wumpus> kallewoof: I'll take a look at it
07:09 < kallewoof> wumpus: Appreciate it :) (And I meant PR, not BIP)
07:16 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
07:17 -!- justMaD [~justMaD@77.243.177.38] has joined #bitcoin-core-dev
07:28 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
07:33 -!- kexkey [~kexkey@37.120.205.233] has joined #bitcoin-core-dev
07:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:48 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
07:49 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 268 seconds]
07:55 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
08:01 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
08:06 -!- thor_ [~thor@114.252.126.154] has joined #bitcoin-core-dev
08:06 -!- Isthmus [uid302307@gateway/web/irccloud.com/x-cakqnohmcueznnch] has joined #bitcoin-core-dev
08:06 -!- thor [~thor@114.252.126.154] has quit [Ping timeout: 260 seconds]
08:07 -!- thor_ [~thor@114.252.126.154] has quit [Client Quit]
08:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:11 < bitcoin-git> [bitcoin] practicalswift opened pull request #18029: tests: Add fuzzing harness for AS-mapping (asmap) (master...fuzzers-asmap) https://github.com/bitcoin/bitcoin/pull/18029
08:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:16 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:31 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
08:47 -!- tsujp [~tsujp@115-64-137-22.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
08:47 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
08:51 -!- tsujp [~tsujp@194-223-88-148.tpgi.com.au] has joined #bitcoin-core-dev
08:55 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection]
09:10 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
09:10 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:18 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
09:19 < gwillen> so I got an email about my PR, saying that "bitcoin-core-ci" failed -- is this an experimental alternative to Travis and Appveyor? Is it known-broken? It appears to have failed due to reasons unrelated to the PR.
09:20 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
09:21 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
09:22 < hebasto> gwillen: could be useful https://github.com/bitcoin/bitcoin/issues/17803
09:25 -!- morcos_ [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
09:28 < hebasto> begging devs, who is interested in GUI i18n, for reviewing of #16224
09:28 < gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto . Pull Request #16224 . bitcoin/bitcoin . GitHub
09:29 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds]
09:29 -!- morcos_ is now known as morcos
09:37 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
09:42 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
09:43 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
09:50 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
10:00 -!- justMaD [~justMaD@77.243.177.38] has quit []
10:14 -!- Amanda1 [~Amanda@185.204.1.185] has joined #bitcoin-core-dev
10:22 -!- cryptoIndio [~cryptoInd@49.145.111.146] has quit [Quit: Leaving...]
10:24 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
10:25 -!- Aaronvan_ is now known as AaronvanW
10:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:31 < bitcoin-git> [bitcoin] Sjors opened pull request #18030: doc: Coin::IsSpent() can also mean never existed (master...2020/01/doc_is_spent) https://github.com/bitcoin/bitcoin/pull/18030
10:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:32 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:35 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
10:40 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Ping timeout: 268 seconds]
10:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:48 < bitcoin-git> [bitcoin] sipsorcery opened pull request #18031: Remove GitHub Actions CI workflow. (master...remove-ghaction) https://github.com/bitcoin/bitcoin/pull/18031
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:49 < wumpus> we disabled actions so you shouldn't be getting mails from that
10:49 < wumpus> not recently at least
10:50 < sipa> i get those for every PR i open
10:50 < sipa> the past days
10:50 -!- lightlike [~lightlike@p200300C7EF18640088CA903BA173634E.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
10:50 < gwillen> this was last night
10:50 < gwillen> so they're definitely not disabled
10:50 < wumpus> where is the mail coming from?
10:52 < gwillen> From: notifications@github.com, [gwillen/bitcoin] Run failed: bitcoin-core-ci - feature-psbt-ops-dialog (b58e6f7)
10:52 < gwillen> cc: ci_activity@noreply.github.com
10:52 < gwillen> "Workflow: bitcoin-core-ci
10:52 < emilengler> gwillen: This is in your fork, I believe you can disable this
10:52 < sipa> yeah, same (but sipa/bitcoin)
10:52 < gwillen> I mean, I never intentionally enabled it
10:52 < wumpus> ohh maybe github actions is enabled for your clone
10:52 < emilengler> gwillen: The featrue is new, it was enabled for everyone
10:52 < gwillen> like, I cloned while it was enabled, and now it will stay enabled until I remove it?
10:52 < emilengler> Well it's not that new anymore
10:53 < sipsorcery> PR has been added to remove the GitHub Actions job see #17803.
10:53 < gribble> https://github.com/bitcoin/bitcoin/issues/17803 | ci: Migration from AppVeyor to GitHub Actions . Issue #17803 . bitcoin/bitcoin . GitHub
10:53 < emilengler> gwillen: Go to Settings > Notifications > GitHub actions
10:53 < sipa> ah, and having the github actions files in the bitcoin/bitcoin repo they end up in our repos too, where github automatically picks it up?
10:53 < sipa> ok, disabled
10:53 < wumpus> sipa: yes, exactly, sipsorcery's PR would remove it so it's no longer picked up
10:54 < gwillen> oh, and it runs based on the existence of the ci.yml file in the branch being PR'ed?
10:54 < gwillen> so once that file is gone in master this will stop happening
10:55 < sipsorcery> yes
10:55 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
10:57 < gwillen> sipsorcery: how do I disable it?
10:57 < gwillen> er sorry, sipa: ^
10:58 < gwillen> I can see a list of "actions" on my fork, but I see no way to remove or disable one (while the file exists)
10:58 < sipa> settings -> actions -> actions permissions -> "Disable actions for this repository"
10:59 < sipa> it's actually under settings
10:59 < sipa> not the top bar actions menu
11:00 < gwillen> thanks
11:00 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:00 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Jan 30 19:00:49 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < provoostenator> hi
11:00 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:00 < sipa> hi
11:01 < fjahr> hi
11:01 < emilengler> hi
11:01 < sipsorcery> hi
11:01 < promag> hi
11:01 < hebasto> hi
11:01 < gwillen> hi
11:01 < nehan_> hi
11:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
11:01 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
11:01 < jonasschnelli> hi
11:01 < meshcollider> hi
11:02 < jonatack> hi
11:02 < wumpus> one pre-proposed topic in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a: topic idea collection for physical meeting (kanzure)
11:02 < elichai2> Hi
11:02 < wumpus> PSA: 0.19.1rc1 was released, please help testing and report any issues you find to the bug tracker
11:04 < jeremyrubin> Hiya!
11:04 < wumpus> also, the 0.20 feature freeze is in one and a half month (see #17432)
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17432 | Release schedule for 0.20.0 . Issue #17432 . bitcoin/bitcoin . GitHub
11:04 < wumpus> any last minute topic proposals?
11:04 < jeremyrubin> #proposedmeetingtopic I'd love to chat about the mempool project and share trajectory
11:04 < wumpus> thanks
11:05 < wumpus> let's start with the usual then
11:05 < wumpus> #topic High priority for review
11:06 < achow101> #16528 pls
11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/16528 | Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101 . Pull Request #16528 . bitcoin/bitcoin . GitHub
11:06 < wumpus> we've managed to merge a few things this week! the first PR for the asmap-based clustering of peers went in, and step 3 of sipa's serialization improvements
11:07 < wumpus> that leaves 7 blockers, 1 bugfix and 6 items chasing concept ACKs
11:07 < jeremyrubin> #17925 I think is more or less RTM, and there's a lot of work waiting on it. Not sure it needs to go in high prio since things seem to be moving that way.
11:07 < sipa> and the wallet boxes
11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/17925 | Improve UpdateTransactionsFromBlock with Epochs by JeremyRubin . Pull Request #17925 . bitcoin/bitcoin . GitHub
11:07 < wumpus> sipa: yes!
11:07 < fanquake> hi
11:08 < wumpus> added #16528 and #17925
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/16528 | Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101 . Pull Request #16528 . bitcoin/bitcoin . GitHub
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/17925 | Improve UpdateTransactionsFromBlock with Epochs by JeremyRubin . Pull Request #17925 . bitcoin/bitcoin . GitHub
11:09 < jeremyrubin> thanks -- will share more details when it's my topics turn
11:09 < jeremyrubin> #proposedmeetingtopic nanobench
11:09 < wumpus> FWIW kallewoof has the idea review kind of ground to a halt on signet (#16411) and is looking for more reviewers
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof . Pull Request #16411 . bitcoin/bitcoin . GitHub
11:11 < wumpus> #topic mempool project (jeremyrubin)
11:11 < jeremyrubin> Howdy!
11:11 < jeremyrubin> So I've been working on a bunch of improvements to the Mempool with a few other contributors
11:11 < jeremyrubin> We have a project allocated here https://github.com/bitcoin/bitcoin/projects/14
11:12 < jeremyrubin> to triage work on the MemPool
11:12 < jnewbery> hi
11:12 < jeremyrubin> The general goal is to get these changes reviewed and merged in a more orderly fashion
11:13 < jeremyrubin> And prevent things from suffering the tradeoffs of small PRs and big PRs by more clearly presenting what the projects are
11:13 < kanzure> hi.
11:13 < wumpus> thanks for the explanation,  I found "mempool improvements" is a bit vague for a project name as it doesn't really aim at a specific goal
11:13 < jeremyrubin> One of the first projects is to refactor almost every traversal algorithm in the mempool to use Epochs
11:14 < jeremyrubin> This should be an enormous performance improvement, but the goal is not to improve performance nescessarily, but rather to permit larger descendants limits
11:15 < wumpus> awesome!
11:15 < jeremyrubin> Increasing the descendants limits (or making some new policys) is going to be neccessary to make Lightning-y stuff work better (and CTV)
11:15 < jeremyrubin> Because currently there are issues with "pinning" caused by descendants limits
11:16 < wumpus> you also might want to write this up somewhere else than IRC so it doesn't get lost :)
11:16 < hebasto> what is an estimation of future descendants limits?
11:16 < wumpus> maybe the project description
11:16 < jeremyrubin> None at present
11:16 < jeremyrubin> wumpus: will do
11:16 < jeremyrubin> In conjunction with/after the epoch mempool improvements, it then becomes possible to make a lot of the mempool algorithms have no "short lived" allocations
11:17 < fjahr> jeremyrubin: cool that you are coordinating this but is there an endgame to this or is the plan to keep this open indefinitely? Just curious...
11:17 < jeremyrubin> We allocate a ton of memory in mempool traversal, these allocations can basically go to zero in a lot of places by having some preserved scratch space
11:18 < jeremyrubin> fjahr: It's sort of indefinite, but I would like to get all the changes through to the point that we solve these higher order goals, but then maybe we won't need more stuff in the mempool
11:18 < jeremyrubin> * major changes == stuff
11:18 < jeremyrubin> Also as a part of this work we've lumped in amiti's rebroadcasting and sdaftuar's packagerelay work
11:19 < jeremyrubin> Both of these should greatly help with making the mempool more rational, and better traversal algorithms help package relay be less DoS-able
11:19 < wumpus> well, closing projects is a whole different issue, we still have "libconsensus" and "P2P refactor" open despite not having had work in progress for quite some time
11:19 < jeremyrubin> There are also, looking forwards, some more changes inspecting the interface between mempool mining and validation
11:20 < jeremyrubin> There's a general notion of figuring out a "streaming createnewblock" algorithm that always immediately returns the best block but does constant gradient descent to find better ones
11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:20 < bitcoin-git> [bitcoin] jonatack closed pull request #17535: test: add block height test to listsinceblock.py  (master...rpc-wallet-blockheight-followups) https://github.com/bitcoin/bitcoin/pull/17535
11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:21 < jeremyrubin> This in general can allow us to have more expensive to traverse mempool graphs (so we can not have restrictions that create pinning)
11:21 < jeremyrubin> But when mining we can still quickly return "good" blocks
11:21 < jeremyrubin> There are a few other projects being considered, such as Child*ren* pay for parent, Cousin-RBF (instead of Conflict-RBF), and some other optimizations
11:22 < jeremyrubin> As a bedrock to some of this, we need to have much better instrumentation and testing of the mempool
11:22 < jeremyrubin> There are a lot of edge cases currently not tested anywhere
11:22 < jeremyrubin> We should test these!
11:22 < jeremyrubin> We also don't have a good asymptotic framework for microbenches\
11:23 < jeremyrubin> We should do that (see nanobench)
11:23 < jeremyrubin> So to summarize a bit (and then maybe more questions):
11:23 < jeremyrubin> 1) There's a lot of exciting work being shaped out & plotted for the mempool
11:23 < jeremyrubin> 2) If you're excited about the design space/working on this, please let me know
11:24 < jeremyrubin> 3) Key to making this happen is clear communication, but also keeping review motivated for sometimes small PRs as a part of a bigger picture
11:25 < jeremyrubin> 4) keeping non-functional PRs (or other mempool work) limited in scope/in consultation with the project, to keep prioritization in focus & not cause a crapload of rebase hell as these projects will have potentially a lot of un-PR'd code
11:25 < jeremyrubin> If you disagree with 4 it's fine, ultimately up to the contributors & maintainers, but I'm trying to chart a course that's going to keep these projects moving forward
11:26 < jeremyrubin> We could maybe open a sub-channel for this stuff on IRC if people want Yet Another IRC Channel
11:26 < jeremyrubin> Any questions?
11:27 < jonasschnelli> as for testing, I think kallewoof has some recordings and a test framework (AFAIK)
11:27 < wumpus> it's not like a lot of discussion is happening in this channel lately, IMO it's fine (and preferable) to do so here
11:28 < wumpus> you can always decide to create another channel if it reall yends up monopolizing the channel (e.g. I guess that's why #bitcoin-builds is separate)
11:28 < wumpus> it's up to you of course
11:28 < fanquake> What do you mean by non-functional PRs in 4)? Is there a specific set of things that you'd like to have done for 0.20.0?
11:29 < jeremyrubin> Things which should have no user observable change
11:29 < MarcoFalke> I think for 0.20.0 we should focus on amiti's rebroadcast stuff
11:29 < jeremyrubin> E.g., moveonly
11:29 < jeremyrubin> renaming variables
11:29 < wumpus> MarcoFalke: agree, it wold be really nice to get the mempool privacy in
11:29 < amiti> :D 
11:30 < jeremyrubin> I agree modulo concerns raised by some about needing more understanding of it. 
11:30 < sipa> jeremyrubin: are there any PRs being merged that are just moveonly/variable rename stuff? that shouldn't be the case
11:30 < jeremyrubin> sipa: there are
11:30 < MarcoFalke> sipa: I removed a bunch of ::mempool
11:30 < MarcoFalke> I think jeremyrubin is referring to that
11:31 < jeremyrubin> there are other ones too that have a lot of acks and stuff not yet merged
11:31 < jeremyrubin> I guess it would be nice to have sort of the expectation that stuff isn't getting merged for now
11:31 < wumpus> please be more specific
11:31 < jeremyrubin> sure, didn't want to pick on anyone's PR but will give an example
11:32 < jeremyrubin> https://github.com/bitcoin/bitcoin/pull/17786
11:32 < wumpus> FWIW I try to mostly focus on "high priority for review" as for what to merge lately, there's just too many PRs 
11:32 < jnewbery> I think removing ::mempool in order to clarify initialization order is a sensible project
11:32 < jonasschnelli> 17786 has a single ack
11:32 < wumpus> #17786
11:32 < gribble> https://github.com/bitcoin/bitcoin/issues/17786 | refactor: Nuke policy/fees->mempool circular dependencies by hebasto . Pull Request #17786 . bitcoin/bitcoin . GitHub
11:33 < wumpus> also: feel free to comment these kind of things *in* the PRs
11:33 < wumpus> if something has a lot of ACKs and no one is pseaking against it, it tends to get merged
11:33 < jeremyrubin> jnewbery: I agree, but the point is that if we're maintaining a few different complex projects on mempool stuff, and we're trying to slice it into many PRs to make review easier, it just becomes a headache
11:33 < MarcoFalke> Yeah, maybe we could postpone 17786 for until after the functional/user-facing mempool changes got in?
11:33 < sipa> yeah, if there are obvious things that interfere, it's best to discuss in the PR itself; maybe one of the authors has no problem rebasing on top of the other for example
11:33 < sipa> or discuss what can wait
11:33 < wumpus> yes, what sipa says
11:34 < sipa> but it's hard to discuss a blanket "please don't do things that interfere with my work"
11:34 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has joined #bitcoin-core-dev
11:34 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has quit [Client Quit]
11:34 < MarcoFalke> I think we can have a rough sketch in what order things should be merged. It can always be amended as needed
11:34 < wumpus> right
11:35 < jeremyrubin> Yeah it's fine, this is part of the goal of the mempool project
11:35 < sipa> ok
11:35 < provoostenator> It's useful to make Draft PR's so that Drahtbot can warn others about overlap.
11:35 < jeremyrubin> to triage the priority of these things
11:35 < wumpus> yes, makes sense
11:36 < wumpus> but please:  comment these things on github on the issue too, otherwise it'll likely be forgotten at some point
11:36 < jeremyrubin> fanquake: I'd like to get Amiti's stuff improved. I'd really like to get package relay shipped. And I think it's possible to do enough work on the Epoch Mempool to bump the descendants limit by 2x.
11:36 < MarcoFalke> agree with wumpus
11:37 < jeremyrubin> amiti and I are discussing how to chop up her work to get the PR complexity down, I think the worry is that the earlier PRs don't do anything "useful", except to make the later work easier (things like new testing harnesses)
11:37 < fanquake> jeremyrubin: ok. Re the non-PR'd/WIP changes, are they linked to from the project as well?
11:37 < jeremyrubin> fanquake: yes, in general
11:37 < jeremyrubin> If there's code
11:37 < jeremyrubin> Things that are still design stage not really
11:38 < fanquake> Given the amount of basic fuzzing harnesses we're adding at the moment, I don't think a mempool test harness would be rejected
11:39 < wumpus> more fuzzing harnesses is good
11:39 < jeremyrubin> I think it's possible it would be bikeshedded though, which I'd want to avoid
11:39 < MarcoFalke> left a comment here: https://github.com/bitcoin/bitcoin/pull/17786#issuecomment-580419545
11:39 < fanquake> wumpus yes
11:40 < MarcoFalke> jeremyrubin: if you refer to style feedback with "bikeshedding", keep in mind that a valid response to style feedback is a simple "no, I like the current style because I don't see the benefit of switching to something else"
11:40 < wumpus> which reminds me, we need to merge the examples in the -qa repository
11:40 < MarcoFalke> wumpus: Already did
11:40 < fanquake> I think that has been done
11:40 < wumpus> MarcoFalke: thanks
11:40 < jeremyrubin> MarcoFalke: in this case more of a "we could also Mock out XXXX in this harness too!"
11:40 < jeremyrubin> Whereas for the testing harness we need to just introduce YYYY
11:41 < MarcoFalke> In general I am not a fan of mocking all the stuff
11:41 < MarcoFalke> If it can be tested reasonably without mocking, it should be done without
11:42 < jeremyrubin> MarcoFalke: fair, which is sort of what I'm pointing to? 
11:42 < MarcoFalke> I guees, yes
11:42 < jeremyrubin> I.e., do we need to mock this? What if we do x y z instead?
11:42 < jeremyrubin> But amiti has already done a lot of hard work in making a mock framework and writing tests against that framework
11:42 < sipa> this is a very abstract discussion
11:42 < jeremyrubin> oops I went concrete
11:43 < amiti> yeah... it seems like we're discussing my proposal to mock the scheduler, which marco and jeremy are both aware of... I think this convo makes more sense for when I open an actual PR 
11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:43 < jeremyrubin> sgtm
11:43 < wumpus> we still have two topocs to go and about 15 minutes
11:43 < sipa> and the question of mocking vs testing things otherwise seems very much a case by case discussion
11:43 < jeremyrubin> yeah
11:43 < MarcoFalke> Yes, it is case-by-case
11:43 < MarcoFalke> ok, other topics?
11:43 < jeremyrubin> we can move on unless there's a new question unanswered, I'll also be online after meeting
11:44 < wumpus> #topic propose physical meeting topics (kanzure)
11:44 < kanzure> just the topic collection topic.
11:44 < jeremyrubin> So not actual topics?
11:44 < kanzure> right, so, i'd like suggestions so i can write a document giving an overview of what people would like to hear
11:45 < kanzure> for the physical IRL meeting
11:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:45 < kanzure> these are just suggestions and not actually a schedule or anything draconian like that.
11:45 < jeremyrubin> Where should we send them? Is there a google form or just email you?
11:45 < provoostenator> I think jnewbery has been collecting topics too.
11:45 < kanzure> just send em to me.
11:45 < jeremyrubin> kanzure: I wouldn't *mind* a schedule ;)
11:45 < kanzure> right or him
11:45 < fanquake> kanzure will this be public somewhere before the meetup?
11:46 < kanzure> well in the past they have been semi-public (link circulated) but not actually public
11:46 < kanzure> i think that's up to the group really. do you prefer public or private topic suggestions?
11:46 < fanquake> Sure, semi-public
11:46 < jeremyrubin> public; I can't remember which ones I already submitted
11:46 < jnewbery> yeah, I've also sent out a survey to some people. Thanks to everyone who responded (which is most!)
11:47 < kanzure> anyway, for topics, it's not just what you have been working on, but also things that you think the group would benefit from hearing from someone else
11:47 < provoostenator> jeremyrubin: downside of doing open source work where everything is logged is that you tend to develop a write-only memory :-)
11:48 < wumpus> hehe
11:48  * jeremyrubin searches for my memex
11:49 < kanzure> that's all i have.
11:49 < wumpus> #topic nanobench (jeremyrubin)
11:50 < jeremyrubin> So I'm not the maintainer of nanobench
11:50 < jeremyrubin> but I really like it
11:50 < jeremyrubin> I think if we can do a cursory check it's not actually malware
11:50 < jeremyrubin> we should just merge it
11:50 < wumpus> general question: why do people want to switch to another benchmarking framework?
11:50 < wumpus> what's wrong with the current one?
11:50 < jeremyrubin> a few things:
11:50 < wumpus> a while ago there was a PR to switch it to boost::test, now yet another dependency
11:50 < jeremyrubin> 1) It's slow
11:51 < wumpus> is there anything they do that we cannot do?
11:51 < MarcoFalke> Yeah, I think we need to take a closer look to see where they differ and what they improve. To make sure there are no regressions
11:51 < jeremyrubin> 2) there's no support for testing asymptotics
11:51 < wumpus> what makes it so slow? it's very simple
11:51 < MarcoFalke> For example, a lot of tools rely on the output format of the current bench framework
11:51 < wumpus> it should hardly have any overhead
11:51 < jeremyrubin> I think it runs too many trials
11:51 < wumpus> then reduce that?
11:51 < jonasschnelli> which could be changed,... right?
11:51 < jeremyrubin> I beleive nanobench autodetects variance or something
11:52 < jeremyrubin> martinus also claims it's more accurate -- less variance than with old benching framework
11:52 < wumpus> so does it use a different clock?
11:52 < jeremyrubin> It also measures more things
11:52 < wumpus> how can accuracy differ?
11:53 < wumpus> or does it do CPU/OS-specific cache flushing?
11:53 < sipa> i think the current code we have is kinda crap; it started off being kinda general and automatically measuring things, and when it was shown that it introduces inaccuracies, it was changed to needing iterations counts in the code itself
11:54 < sipa> wumpus: i think it's mostly due to some tests running far longer than necessary, resulting in getting OS interrupts etc inside of them
11:54 < jeremyrubin> w.r.t. output and tooling, nanobench also outputs new information (e.g., instructions, cycles, branches, ips, branch misses)
11:54 < jeremyrubin> so we'd fundamentally need some new tools.
11:54 < jnewbery> is there anything that needs discussing here that isn't covered in the PR? I think the only action is to review that if you're interested, no? (#18011)
11:54 < gribble> https://github.com/bitcoin/bitcoin/issues/18011 | Replace current benchmarking framework with nanobench by martinus . Pull Request #18011 . bitcoin/bitcoin . GitHub
11:54 < wumpus> we used to measure cycles, this was removed at some point
11:54 < sipa> yeah let's discuss in the PR
11:55 < jeremyrubin> Sounds good -- my point in making it a topic was that it's relatively low risk to adopt as nothing really relies heavily on the benching
11:55 < wumpus> sounds good to me, I was just curious why everyone wants to replace the benchmark framework (with different things)
11:55 < jeremyrubin> and being able to write asymptotic benches is going to be a big help
11:55 < wumpus> but if the current one is crap that's clear :)
11:55 < jeremyrubin> Because we need that for the mempool work
11:56 < jeremyrubin> And I tried to introduce it in a since-closed PR, but it seemed we needed a more thought out approach
11:56 < jeremyrubin> and nanobench has that
11:56 < jeremyrubin> fin
11:57 < wumpus> #endmeeting
11:57 < lightningbot> Meeting ended Thu Jan 30 19:57:07 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:57 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-30-19.00.html
11:57 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-30-19.00.txt
11:57 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-30-19.00.log.html
11:57 < kanzure> send me a message if you want a link to the topic collection file i am preparing.
11:58 < wumpus> at least nanobench is only one cpp+header file (right?), that's nice
11:58 < sipa> yeah
11:58 < jeremyrubin> yeah
11:58 < jeremyrubin> I also like that we have an active maintainer for it
11:58 < jeremyrubin> e.g., it's written by martinus 
11:58 < wumpus> would dread to depend on the google monstrosity
11:58 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
11:58 < wumpus> yes!
11:58 < sipa> wumpus: our current bench framework was based on google's :)
11:59 < jeremyrubin> One interesting thing is if it's hard to backport nanobench
11:59 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
11:59 < jeremyrubin> Then collect nanobenches from prior releases
12:00 < wumpus> sipa: true, but I meant subtreeing it
12:00 < jeremyrubin> But that sounds annoying
12:00 < jeremyrubin> wumpus: I suggested that martinus make it a subtree; which it sounds like he could use a bit of guidance on how best to do that
12:00 < wumpus> jeremyrubin: backporting tests and benchmarks is ok with me if you want to, it's outside the things we normally backport (bugfixes) but also has zero risk for users
12:01 < jonasschnelli> I guess there is no need to backport it for a release
12:01 < jonasschnelli> A local backport should be enough to collect and compare
12:01 < jeremyrubin> jonasschnelli: yeah that's what I meant
12:01 < wumpus> the thing with subtrees is that we end up with all kinds of unnecessary stuff in our tree
12:01 < wumpus> esp. if it is only a cpp/h pair, we don't subtree tinyformat for a similar reason
12:02 < jeremyrubin> Maybe martinus can make a new git repo which is just the header
12:02 < jonasschnelli> just copy it in?
12:02 < jeremyrubin> and then make the nanobench repo with build stuff have a subtree of that
12:02 < wumpus> jonasschnelli: this is what he did right now and that's ok imo
12:02 < jeremyrubin> and then subtree the repo that's just the header
12:02 < jeremyrubin> wumpus: yeah if you're good with copy'd in then let's go that way.
12:03 < jeremyrubin> I think we just want to avoid diverging from upstream
12:03 < jonasschnelli> a subtree needs also maintenance and pulling
12:04 < sipa> unrelatedly, should we work on moving all subtrees to a single location? (e.g. src/subtrees/...) ?
12:04 < jeremyrubin> diverge meaning adding special cased stuff into nanobench rather than having a general feature that gets upstreamed/reviewed by other nanobench users
12:04 < wumpus> sipa: I don't know
12:04 < fanquake> I think we've got an issue open for the sun tree consolidation
12:04 < fanquake> *subtree
12:04 < wumpus> yes, looking for it
12:05 < jeremyrubin> wumpus: maybe just tell martinus that copied in is fine for now, and we can consider subtreeing later?
12:05 < wumpus> #17413
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/17413 | Subtree exclude mess in linters and update scripts . Issue #17413 . bitcoin/bitcoin . GitHub
12:05 < wumpus> jeremyrubin: sounds good to me
12:05 < wumpus> sipa: it would definitely make some things easier, but it'd also be quite a bit of disruption 
12:06 < jeremyrubin> I'll leave a comment on the PR.
12:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:09 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
12:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
12:15 -!- hanhua [68850952@104.133.9.82] has joined #bitcoin-core-dev
12:15 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:18 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
12:22 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Remote host closed the connection]
12:30 < wumpus> anyone oppposed to cleaning up the projects list a bit and closing "P2P refactor" and "libconsensus"? the former is finished, AFAIK, the latter has not had any active work for more than a year
12:31 < wumpus> they can always be reopened if needed
12:33 < sipa> sure
12:33 < sipa> i mean, not opposed
12:35 -!- Netsplit *.net <-> *.split quits: lightningbot, midnight
12:36 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
12:37 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev
12:41 < sdaftuar> sipa: any further thoughts on #17951?  would like to know if that is ready for merge, i have a wtxid-based-inv proposal ready to follow that up
12:41 < gribble> https://github.com/bitcoin/bitcoin/issues/17951 | Use rolling bloom filter of recent block txs for AlreadyHave() check by sdaftuar . Pull Request #17951 . bitcoin/bitcoin . GitHub
12:41 < sipa> sdaftuar: yeah, let's improve the wiping later
12:41 < sipa> will will review after lunch
12:41 < sdaftuar> thanks!
12:48 -!- pncl [~pncl____@5.132.220.2] has joined #bitcoin-core-dev
13:00 -!- Amanda1 [~Amanda@185.204.1.185] has quit []
13:02 -!- lightlike [~lightlike@p200300C7EF18640088CA903BA173634E.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
13:17 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
13:17 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!]
13:17 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
13:24 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
13:25 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
13:26 -!- pncl [~pncl____@5.132.220.2] has quit [Ping timeout: 240 seconds]
13:29 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
13:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:33 < jeremyrubin> sdaftuar: worth noting that your parameter selection puts you above the max filter size I think
13:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:42 -!- ajbiz11 [~ajbiz11@184.75.223.227] has joined #bitcoin-core-dev
13:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:56 < bitcoin-git> [bitcoin] achow101 opened pull request #18032: Output a descriptor in createmultisig and addmultisigaddress (master...createms-descriptor) https://github.com/bitcoin/bitcoin/pull/18032
13:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:03 -!- pncl [~pncl____@5.132.220.2] has joined #bitcoin-core-dev
14:05 < elichai2> Saw the thing MarcoFalke said about tools relying on the output of the benchmark utility, should I drop the commit that tries to make it more readable then? https://github.com/bitcoin/bitcoin/pull/18014
14:11 < jeremyrubin> probably? also it's likely that we'll soon replace bench, so might be wasted effort anyways? is the outup still intelligible?
14:13 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3b69310beb17...1d1f8bbf5711
14:14 < bitcoin-git> bitcoin/master b951b09 Larry Ruane: on startup, write config options to debug.log
14:14 < bitcoin-git> bitcoin/master 1d1f8bb MarcoFalke: Merge #16115: On bitcoind startup, write config args to debug.log
14:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:15 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16115: On bitcoind startup, write config args to debug.log (master...args-to-debug-log) https://github.com/bitcoin/bitcoin/pull/16115
14:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:28 -!- kexkey [~kexkey@37.120.205.233] has quit [Read error: Connection reset by peer]
14:28 < elichai2> jeremyrubin: only changed spacings so the columns will be readable for humans 
14:32 < fanquake> wumpus I agree
14:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:34 < bitcoin-git> [bitcoin] achow101 closed pull request #16528: Native Descriptor Wallets using DescriptorScriptPubKeyMan (master...wallet-of-the-glorious-future) https://github.com/bitcoin/bitcoin/pull/16528
14:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:35 < bitcoin-git> [bitcoin] achow101 reopened pull request #16528: Native Descriptor Wallets using DescriptorScriptPubKeyMan (master...wallet-of-the-glorious-future) https://github.com/bitcoin/bitcoin/pull/16528
14:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:42 -!- hanhua [68850952@104.133.9.82] has quit [Remote host closed the connection]
14:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
14:45 -!- tecnecio_ [~tecnecio_@92.58.58.54] has quit [Ping timeout: 260 seconds]
14:47 < fanquake> review beg #18003
14:47 < gribble> https://github.com/bitcoin/bitcoin/issues/18003 | build: remove --large-address-aware linker flag by fanquake . Pull Request #18003 . bitcoin/bitcoin . GitHub
14:56 < jeremyrubin> sipa: I fixed my comments!
15:01 -!- pncl [~pncl____@5.132.220.2] has quit [Read error: Connection reset by peer]
15:01 -!- pncl [~pncl____@5.132.220.2] has joined #bitcoin-core-dev
15:07 -!- Skirmant [~Skirmant@mobile-access-2e842c-83.dhcp.inet.fi] has joined #bitcoin-core-dev
15:16 -!- Skirmant [~Skirmant@mobile-access-2e842c-83.dhcp.inet.fi] has quit [Quit: (?-?-) zzz..]
15:38 -!- pncl [~pncl____@5.132.220.2] has quit [Remote host closed the connection]
15:41 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
15:41 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:41 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:42 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
15:43 -!- pncl [~pncl____@5.132.220.2] has joined #bitcoin-core-dev
15:52 < jeremyrubin> Can anyone clarify/point to documentation on when cleanstack gets applied?
15:52 < jeremyrubin> I couldn't find anything fleshed out
15:52 < jeremyrubin> (other than,,, the code
15:53 -!- inoor [~inoor@c-73-25-245-244.hsd1.or.comcast.net] has joined #bitcoin-core-dev
15:53 < sipa> jeremyrubin: bip62 rule 6 is implemented as a standardness rule
15:54 < sipa> it's also required (as a consensus rule) in p2wsh
15:55 < jeremyrubin> Interesting.
15:55 < jeremyrubin> There's a kind of nice script I'm looking at for CTV which is
15:56 < jeremyrubin> <t1> ... <tn> <N> OP_ROLL OP_ROLL OP_CTV
15:56 < jeremyrubin> So I would need to follow it by a bunch of op_drops then?
15:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:57 < sipa> seems silly to use that post taproot
15:57 < jeremyrubin> someone asked :)
15:59 < jeremyrubin> Which is fine, no cleanstack works in v2  bare script transactions right?
16:00 -!- ajbiz11 [~ajbiz11@184.75.223.227] has quit []
16:00 < sipa> bare script transactions are nonstandard to begin with
16:00 < sipa> except p2sh/p2pk/p2pkh/multisig
16:01 < jeremyrubin> Ah fair, I guess if I make a new standard type I can set whatever rules I want anyways
16:01 < sipa> anything but <constant> OP_CTV as standard seems crazy
16:02 < jeremyrubin> not planning on doing that, just more out of intellectual curiosity
16:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:12 < bitcoin-git> [bitcoin] achow101 opened pull request #18034: Get the OutputType for a descriptor (master...desc-getoutputtype) https://github.com/bitcoin/bitcoin/pull/18034
16:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:15 < bitcoin-git> [bitcoin] promag opened pull request #18035: gui: Drop BanTableModel dependency to ClientModel (master...2020-01-bantablemodel) https://github.com/bitcoin/bitcoin/pull/18035
16:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:17 -!- inoor [~inoor@c-73-25-245-244.hsd1.or.comcast.net] has quit [Quit: inoor]
16:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:21 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1d1f8bbf5711...d176aeafde29
16:21 < bitcoin-git> bitcoin/master 085423b Aaron Clauson: Remove GitHub Actions CI workflow.
16:21 < bitcoin-git> bitcoin/master d176aea fanquake: Merge #18031: Remove GitHub Actions CI workflow.
16:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:22 < bitcoin-git> [bitcoin] fanquake merged pull request #18031: Remove GitHub Actions CI workflow. (master...remove-ghaction) https://github.com/bitcoin/bitcoin/pull/18031
16:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:24 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Read error: Connection reset by peer]
16:24 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-pptklemplnuepsuh] has quit [Ping timeout: 260 seconds]
16:25 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
16:25 -!- abacus [abacus@gateway/shell/blinkenshell.org/x-lmomaglahwbbfhwu] has joined #bitcoin-core-dev
16:27 -!- pncl [~pncl____@5.132.220.2] has quit [Quit: Leaving]
16:27 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
16:28 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
16:30 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
16:31 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 272 seconds]
16:32 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Ping timeout: 268 seconds]
16:38 -!- pncl [~pncl____@5.132.220.2] has joined #bitcoin-core-dev
16:42 -!- Eramdam1 [~Eramdam@185.169.255.76] has joined #bitcoin-core-dev
16:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:44 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d176aeafde29...3e1bf71064cc
16:44 < bitcoin-git> bitcoin/master c7ec9a1 Andrew Toth: Add missing supported rpcs to doc/descriptors.md
16:44 < bitcoin-git> bitcoin/master 3e1bf71 fanquake: Merge #18025: doc: Add missing supported rpcs to doc/descriptors.md
16:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:44 < bitcoin-git> [bitcoin] fanquake merged pull request #18025: doc: Add missing supported rpcs to doc/descriptors.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18025
16:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:49 -!- cryptoIndio [~cryptoInd@49.145.111.146] has joined #bitcoin-core-dev
16:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:56 < bitcoin-git> [bitcoin] promag opened pull request #18036: gui: Drop ShutdownWindow dependency to BitcoinGUI (master...2020-01-utilitydialog) https://github.com/bitcoin/bitcoin/pull/18036
16:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:00 -!- pncl [~pncl____@5.132.220.2] has quit [Ping timeout: 240 seconds]
17:13 -!- cryptoIndio [~cryptoInd@49.145.111.146] has quit [Quit: Leaving...]
17:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
18:03 -!- Madars [~null@unaffiliated/madars] has quit [Quit: reboot]
18:08 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
18:09 -!- pkr [~pkr@158.140.254.215] has joined #bitcoin-core-dev
18:15 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
18:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:32 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
18:32 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.7]
18:54 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
19:00 -!- Eramdam1 [~Eramdam@185.169.255.76] has quit []
19:01 -!- abrissbirne [~abrissbir@unaffiliated/abrissbirne] has joined #bitcoin-core-dev
19:04 -!- abrissbi1ne [~abrissbir@unaffiliated/abrissbirne] has quit [Ping timeout: 256 seconds]
19:14 -!- Isthmus [uid302307@gateway/web/irccloud.com/x-cakqnohmcueznnch] has quit [Quit: Connection closed for inactivity]
19:17 -!- jaekwon [~jaekwon@84.39.117.57] has joined #bitcoin-core-dev
19:25 -!- roconnor [~roconnor@host-104-157-187-25.dyn.295.ca] has quit [Quit: Konversation terminated!]
19:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
20:06 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:07 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
20:13 -!- felixfoertsch23 [~felixfoer@2001:16b8:507b:6000:655c:a676:294e:501d] has joined #bitcoin-core-dev
20:14 -!- felixfoertsch [~felixfoer@92.117.46.2] has quit [Ping timeout: 265 seconds]
20:50 -!- jarthur [~jarthur@2605:6000:1019:4971:1cd0:ec2a:4a88:d402] has joined #bitcoin-core-dev
20:55 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
21:01 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 260 seconds]
21:18 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
21:18 -!- jarthur [~jarthur@2605:6000:1019:4971:1cd0:ec2a:4a88:d402] has quit [Remote host closed the connection]
21:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:52 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #18037: Util: Allow scheduler to be mocked  (master...2020-01-mock-scheduler) https://github.com/bitcoin/bitcoin/pull/18037
21:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:52 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #18038: P2P: Mempool tracks locally submitted transactions to improve privacy (master...2020-01-unbroadcast) https://github.com/bitcoin/bitcoin/pull/18038
21:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:00 -!- jaekwon [~jaekwon@84.39.117.57] has quit []
22:06 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
22:07 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 265 seconds]
22:11 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
22:14 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds]
22:15 -!- jesusabdullah [~jesusabdu@185.189.112.11] has joined #bitcoin-core-dev
22:23 -!- BlackWhite [~black@212.237.255.227] has joined #bitcoin-core-dev
22:25 -!- BlackWhite [~black@212.237.255.227] has quit []
22:28 -!- jarthur [~jarthur@2605:6000:1019:4971:a557:deff:acc7:c4d1] has joined #bitcoin-core-dev
22:31 -!- tecnecio_ [~tecnecio_@92.58.58.54] has joined #bitcoin-core-dev
22:32 -!- jarthur [~jarthur@2605:6000:1019:4971:a557:deff:acc7:c4d1] has quit [Remote host closed the connection]
22:34 -!- jarthur [~jarthur@2605:6000:1019:4971:a557:deff:acc7:c4d1] has joined #bitcoin-core-dev
22:49 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
22:54 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
22:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
22:55 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
22:57 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
22:57 -!- jarthur [~jarthur@2605:6000:1019:4971:a557:deff:acc7:c4d1] has quit [Remote host closed the connection]
23:02 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 268 seconds]
23:04 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has quit [Ping timeout: 248 seconds]
23:04 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has quit [Ping timeout: 248 seconds]
23:05 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has joined #bitcoin-core-dev
23:05 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has quit [Ping timeout: 250 seconds]
23:10 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:11 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
23:11 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has joined #bitcoin-core-dev
23:13 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has joined #bitcoin-core-dev
23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
23:42 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
23:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
23:50 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-knydeigrlzsmvavn] has quit [Quit: Connection closed for inactivity]
--- Log closed Fri Jan 31 00:00:24 2020