--- Log opened Thu Feb 20 00:00:59 2020 00:06 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 00:10 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:11 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 00:20 -!- Kiminuo [~mix@141.98.103.124] has quit [Quit: Leaving] 00:23 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:34 -!- nirved [~nirved@2a02:8071:b58a:3c00:3ca6:9fb9:2e23:4e12] has quit [Ping timeout: 272 seconds] 00:46 -!- nirved [~nirved@2a02:8071:b58a:3c00:3ca6:9fb9:2e23:4e12] has joined #bitcoin-core-dev 00:55 -!- marcoagner [~user@bl11-16-246.dsl.telepac.pt] has joined #bitcoin-core-dev 01:00 -!- rawtaz1 [~rawtaz@195.206.183.79] has quit [] 01:17 -!- ron1 [~ron@195.206.183.79] has joined #bitcoin-core-dev 01:21 -!- rex4539 [~rex4539@2a02:587:350c:a200:f47f:12b5:91ff:9cf4] has quit [] 01:27 -!- cataly5m2 [~cataly5m@static.65.177.203.116.clients.your-server.de] has quit [Quit: The Lounge - https://thelounge.chat] 01:27 -!- cataly5m [~cataly5m@static.65.177.203.116.clients.your-server.de] has joined #bitcoin-core-dev 01:33 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 01:44 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 248 seconds] 01:50 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 01:58 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 02:04 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Remote host closed the connection] 02:04 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 02:04 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 02:23 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:39 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:59 -!- vincenzopalazzo [~vincent@95.239.19.21] has joined #bitcoin-core-dev 03:03 -!- Neha3Carroll [~Neha3Carr@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:05 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 272 seconds] 03:15 < darosior> Hi, https://github.com/bitcoin/bitcoin/blob/eddcbfb109e592fdf39ea2c38c4d7ba183de3e34/src/script/interpreter.cpp#L938-L941 means that the script execution will stop on a failing CHECKSIG (and not CHECKSIGVERIFY), right ? If so what is the reason behind this (non-mandatory) rule ? 03:17 -!- Neha3Carroll [~Neha3Carr@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 03:33 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 03:50 < darosior> Found the reason.. https://github.com/bitcoin/bitcoin/pull/8634 04:00 -!- ron1 [~ron@195.206.183.79] has quit [] 04:18 -!- Suntop1 [~Suntop@104.254.90.235] has joined #bitcoin-core-dev 04:20 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 04:21 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 04:27 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 260 seconds] 04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:29 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eddcbfb109e5...56fc2dfcc3e6 04:29 < bitcoin-git> bitcoin/master 7f1475c Sebastian Falbesoner: rpc: update validateaddress RPCExamples to bech32 04:29 < bitcoin-git> bitcoin/master 56fc2df fanquake: Merge #18122: rpc: update validateaddress RPCExamples to bech32 04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:29 < bitcoin-git> [bitcoin] fanquake merged pull request #18122: rpc: update validateaddress RPCExamples to bech32 (master...20200211-rpc-update-validateaddress-rpcexamples-to-bech32) https://github.com/bitcoin/bitcoin/pull/18122 04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:30 -!- pinheadmz [~matthewzi@23.226.131.230] has joined #bitcoin-core-dev 04:30 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev 04:33 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 04:34 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 04:42 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:51 -!- pinheadmz [~matthewzi@23.226.131.230] has quit [Quit: pinheadmz] 04:52 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 04:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:57 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/56fc2dfcc3e6...eb3c6b091234 04:57 < bitcoin-git> bitcoin/master 63ce882 Gastón I. Silva: doc: link to homebrew's troubleshooting page 04:57 < bitcoin-git> bitcoin/master eb3c6b0 fanquake: Merge #18070: doc: add note about `brew doctor` 04:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:57 < bitcoin-git> [bitcoin] fanquake merged pull request #18070: doc: add note about `brew doctor` (master...documentation) https://github.com/bitcoin/bitcoin/pull/18070 04:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:02 -!- pinheadmz [~matthewzi@23.226.131.230] has joined #bitcoin-core-dev 05:15 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 05:30 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 05:32 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 05:44 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 05:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:56 -!- promag [~promag@83.223.249.184] has joined #bitcoin-core-dev 05:57 -!- pinheadmz [~matthewzi@23.226.131.230] has quit [Quit: pinheadmz] 05:57 -!- pinheadmz [~matthewzi@23.226.131.230] has joined #bitcoin-core-dev 05:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 06:01 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 06:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:03 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 06:08 -!- braydonf_ [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 06:08 -!- promag [~promag@83.223.249.184] has quit [Remote host closed the connection] 06:09 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:10 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 06:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 06:14 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 06:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 06:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 06:18 -!- promag [~promag@188.250.106.244] has quit [Ping timeout: 258 seconds] 06:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds] 06:21 -!- braydonf_ [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 06:24 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 06:37 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Quit: Gone frying asparagus or my Windows had a BSOD] 06:44 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 06:45 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 07:00 -!- Suntop1 [~Suntop@104.254.90.235] has quit [] 07:12 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 07:18 -!- omega8cc [~omega8cc@141.98.101.133] has joined #bitcoin-core-dev 07:23 < provoostenator> Quick and easy review beg for #17264; would be nice to change that default in 0.20 (cc meshcollider) 07:23 < gribble> https://github.com/bitcoin/bitcoin/issues/17264 | rpc: set default bip32derivs to true for psbt methods by Sjors · Pull Request #17264 · bitcoin/bitcoin · GitHub 07:24 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:47 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:50 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:53 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 268 seconds] 08:00 -!- Guyver2_ is now known as Guyver2 08:03 < jonatack> provoostenator: looking 08:08 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:09 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:09 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 08:11 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 08:13 < provoostenator> I saw one person on Twitter and one on IRC in the last couple of days who got confused by the current default :-) 08:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:14 -!- shesek [~shesek@185.3.145.161] has joined #bitcoin-core-dev 08:14 -!- shesek [~shesek@185.3.145.161] has quit [Changing host] 08:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:32 < jonatack> provoostenator: acked, do you think we need a deprecation period for the change? 08:33 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.7] 08:34 < provoostenator> I think that's overkill. 08:35 < provoostenator> A PSBT without bip32 info is generally useless. 08:36 < jonatack> right. this fixes an annoyance 08:36 < provoostenator> It makes sense to "fake" the info for privacy reasons, e.g. in a coinjoin, but to leave it out it's very hard to sign. 08:47 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 08:55 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 08:56 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:57 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] 08:57 < emilengler> Will probably join the meeting a few minutes later. Have an offline meeting which ends exactly at 18:00 UTC 08:58 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:20 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:21 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:28 -!- jrawsthorne [jrawsthorn@gateway/vpn/privateinternetaccess/jrawsthorne] has joined #bitcoin-core-dev 09:31 -!- jrawsthorne_ [jrawsthorn@gateway/vpn/privateinternetaccess/jrawsthorne] has quit [Ping timeout: 268 seconds] 09:36 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 09:37 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 265 seconds] 09:43 -!- drizztbsd is now known as timothy 09:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:58 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 10:00 -!- omega8cc [~omega8cc@141.98.101.133] has quit [] 10:01 -!- nullptr_ [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has joined #bitcoin-core-dev 10:01 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:02 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has quit [Ping timeout: 240 seconds] 10:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 10:14 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:18 -!- feb1 [~feb@89.249.74.213] has joined #bitcoin-core-dev 10:30 < dongcarl> jonasschnelli: Looking at BIP324... The session ID is supposed to be provided OOB? 10:38 < sipa> dongcarl: session id is derived from the ECDH outcome 10:39 < dongcarl> sipa: Right, but the two peers need to exchange the session ID somehow right? And if it's in-band then it defeats the purpose? 10:39 < sipa> dongcarl: ECDH establishes the session id 10:39 < sipa> it's not communicated 10:39 < sipa> that's what diffie-hellman does, establish a secure shared secret over a cleartext channel (as long as it has no active MitM) 10:40 < dongcarl> right... but in jonas' breaking bitcoin talk... he mentions resistance against handshake MITM by comparing session IDs... 10:40 < sipa> ah! 10:40 < sipa> yes 10:41 < sipa> of course, you can establish authenticity by comparing session ids out of band 10:41 < sipa> but that inherently requires a preestablished identity (e.g. a phone number of who you're trying to connect to) 10:41 < sipa> or if it is yourself, it's easy :) 10:43 -!- Highway61 [~Thunderbi@155.94.244.74] has quit [Remote host closed the connection] 10:43 < instagibbs> yes, it's useful for setups like neutrino(or related) to self-owned node at home 10:44 < dongcarl> if it's your own node... why not make it easy to pair by using something like noise protocol IK? 10:44 < sipa> dongcarl: what yiu need is an authentication scheme 10:45 < sipa> which can run on top of bip 324 10:45 < sipa> we've been working on a really cool one :) 10:45 < instagibbs> dongcarl, if the tooling exists seems silly to create yet another tool 10:45 < instagibbs> create/integrate/whatever 10:45 < sipa> the most naive one you can construct is simply sending a signature of the session id 10:45 < dongcarl> sipa: where can I find info about this? I've been talking with ariard_ about this 10:46 < sipa> dongcarl: well bip 150 was an early idea 10:46 < sipa> the fancy private authentication i've talked about before, bit nothing really written up 10:47 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 10:47 < sipa> dongcarl: the problem is that bitcoin nodes don't have, and shouldn't have, any observable identity 10:47 < sipa> that could be used to track them around 10:48 < dongcarl> Okay, will read BIP150 10:48 -!- MarcoFalkeWifi10 [4441a997@gateway/web/cgi-irc/kiwiirc.com/ip.68.65.169.151] has joined #bitcoin-core-dev 10:49 < sipa> dongcarl: for a better idea of what is possible: https://gist.github.com/sipa/d7dcaae0419f10e5be0270fada84c20b 10:49 < sipa> but the actual protocol there is outdated 10:50 < dongcarl> Gotchu 11:00 < achow101> meeting? 11:00 < wumpus> #startmeeting 11:00 < lightningbot> Meeting started Thu Feb 20 19:00:21 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:00 < kanzure> hi 11:00 < achow101> hi 11:00 < jonasschnelli> hi 11:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr 11:00 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55 11:00 < jonatack> hi 11:00 < ariard_> hi 11:00 < elichai2> hi 11:01 < meshcollider> hi 11:02 < promag> hi 11:02 < wumpus> no proposed topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt (as I understand it) 11:02 < kanzure> no new entries in proposedmeetingtopics.txt http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 11:02 < wumpus> ha thanks kanzure 11:02 < hebasto> hi 11:03 < wumpus> any last minute proposals? 11:04 < wumpus> FWIW the 0.20 feature freeze is in less than a month (2020-03-15) 11:04 < wumpus> see #17432 11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17432 | Release schedule for 0.20.0 · Issue #17432 · bitcoin/bitcoin · GitHub 11:04 < wumpus> #topic High priority for review 11:04 < wumpus> 8 blockrers, 1 bugfix, 6 chasing concept ACK 11:04 < elichai2> Reviews for #18014 will be appreciated (not sure if high priority is appropriate though) 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/18014 | lib: Optimizing siphash implementation by elichai · Pull Request #18014 · bitcoin/bitcoin · GitHub 11:05 < wumpus> anyone have suggestions for things to add/remove/merge? 11:05 < wumpus> elichai2: does it block other work for you? 11:05 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev 11:05 < achow101> merge #18034? 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/18034 | Get the OutputType for a descriptor by achow101 · Pull Request #18034 · bitcoin/bitcoin · GitHub 11:05 < elichai2> wumpus: nope 11:05 < jonatack> #17812 may be rfm 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/17812 | config, net, test: asmap functional tests and feature refinements by jonatack · Pull Request #17812 · bitcoin/bitcoin · GitHub 11:06 < wumpus> thanks achow101 jonatack 11:06 < gwillen> #17509 is already high-prio but nobody's reviewed since it was added there, perhaps take a look? :-) 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub 11:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:06 < bitcoin-git> [bitcoin] icota closed pull request #18179: Add Lightning Network support (master...2020-01-core-lightning) https://github.com/bitcoin/bitcoin/pull/18179 11:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:07 < wumpus> elichai2: to be clear I'm ok with adding it if you want, but the blockers list is meant for PRs that block other work 11:07 < achow101> add #17577 to blockers? 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub 11:08 < meshcollider> achow101: 18034 needs another review imo, I'll review it this afternoon 11:08 < achow101> meshcollider: great! 11:08 < elichai2> wumpus: yeah makes sense. Just wanted to ask for people to review :) 11:09 < wumpus> achow101: #18115 is based on it? 11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub 11:09 < achow101> wumpus: yes 11:10 < wumpus> ok, added 11:10 < elichai2> gwillen: Does it need code review or testing the gui? 11:11 < gwillen> provoostenator: it's your PR, opinion? ^ 11:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:12 < bitcoin-git> [bitcoin] Mentors4EDU opened pull request #18186: Stage and add commits behind (master...master) https://github.com/bitcoin/bitcoin/pull/18186 11:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:12 < gwillen> I've never been totally clear on what the requirements are before something can be merged :-) 11:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:12 < bitcoin-git> [bitcoin] Mentors4EDU closed pull request #18186: Stage and add commits behind (master...master) https://github.com/bitcoin/bitcoin/pull/18186 11:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:12 < gwillen> I did gui testing to my own satisfaction at least 11:12 < instagibbs> gwillen, it's fuzzy "I know it when I see it" :P 11:13 < gwillen> yeah, *nod*. I did both a code review and GUI testing, I imagine it just needs "more eyes", so ideally both 11:13 < wumpus> gwillen: pretty much: if the maintainer of the part of the code has enough confidence in it, you can help this by adding reviews / test reports 11:13 < instagibbs> I can definitely take a look at that PR 11:13 < gwillen> much appreciated 11:13 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 11:14 < wumpus> it can differ very much by part of the code changed what kind and how much review/manual testing/fuzzing/analysis/etc is needed 11:14 < instagibbs> what subsystems it touches, can people lose money if you're wrong, etc 11:14 < wumpus> exactly 11:15 < wumpus> I guess for PSBT GUI the most important thing is that people test it manually and it works as expected 11:15 < promag> I'll see 17509 too 11:16 < hebasto> btw, which devs reviews are more valuable for autotools related PRs? 11:16 < wumpus> cfields_ dongcarl 11:16 < wumpus> maybe luke-jr 11:16 < hebasto> wumpus: ty 11:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:17 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #18187: Add --options runtime (runtime hardening) to macOS codesign (master...2020/02/macos_runtime_hardening) https://github.com/bitcoin/bitcoin/pull/18187 11:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:18 < wumpus> I understand it enough to understand what the script does but not what's a good/least messy way of structuring autotools scripts, so definitely don't go by only my review there 11:19 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 11:19 < wumpus> any other topics? 11:19 < jonatack> #17208 could use review; this would allow us to build with -fsanitize=undefined 11:19 < gribble> https://github.com/bitcoin/bitcoin/issues/17208 | Make all tests pass UBSan without using any UBSan suppressions by practicalswift · Pull Request #17208 · bitcoin/bitcoin · GitHub 11:19 < fanquake> I take it no one has found any new issues with rc2? I haven’t seen anything reported 11:20 < elichai2> jonatack: will review it! 11:20 * dongcarl back, looking 11:20 < wumpus> oh that one looks a lot less scary than I expected, mostly affect progress reporting code 11:21 < wumpus> the nBlocksTotal change in validation.cpp needs some eyes on it 11:21 < instagibbs> yeah was about to say 11:22 < jonatack> yes, that's the key change 11:22 < wumpus> but there was also a previous PR that changed a lot of signed/unsigned integer arithmetic all over the place, glad it's not that 11:23 < wumpus> fanquake: haven't seen anything reported either 11:23 < wumpus> I guess we can tag 0.19.1 final fairly soon 11:23 < wumpus> are the release notes ready? 11:23 < instagibbs> wumpus, oh you told me another PR was going in, so I closed my 3 line fix for it :P 11:23 < fanquake> Sure. There’s a few more things tagged for backport for 0.19, but I’m not convinced they are required for 0.19.1 11:24 < fanquake> Unsure about the release notes though 11:24 < wumpus> instagibbs: I don't remember having said that, which one? 11:25 < wumpus> instagibbs: you mean I said I wanted to merge another PR for 0.19.1? 11:25 < instagibbs> the UB PR, I had a 3 line fix, closed for later closed PR (not important just noting I had a similar fix) 11:26 < wumpus> instagibbs: oh, a 3 line fix instead of #17208? 11:26 < gribble> https://github.com/bitcoin/bitcoin/issues/17208 | Make all tests pass UBSan without using any UBSan suppressions by practicalswift · Pull Request #17208 · bitcoin/bitcoin · GitHub 11:26 < instagibbs> right 11:26 < wumpus> depending on what the changed lines are that would be even better? 11:28 < wumpus> 0.19.1 changelog looks ok, no "Notable changes", but that happens more often for minor releases as it's bugfixes not features: https://github.com/bitcoin/bitcoin/blob/0.19/doc/release-notes.md 11:29 < fanquake> Yea looks ok 11:29 < wumpus> thanks 11:30 < wumpus> I guess that concludes the meeting for today, happy reviewing everyone :) 11:30 < wumpus> #endmeeting 11:30 < lightningbot> Meeting ended Thu Feb 20 19:30:56 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 11:30 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-02-20-19.00.html 11:30 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-02-20-19.00.txt 11:30 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-02-20-19.00.log.html 11:31 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:33 -!- MarcoFalkeWifi10 [4441a997@gateway/web/cgi-irc/kiwiirc.com/ip.68.65.169.151] has quit [Remote host closed the connection] 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:39 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18188: test: Bump process time in scheduler_tests to avoid race (master...2002-testBumpSched) https://github.com/bitcoin/bitcoin/pull/18188 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:41 < bitcoin-git> [bitcoin] Empact closed pull request #13949: Introduce MempoolObserver interface to break "policy/fees -> txmempool -> policy/fees" circular dependency (master...mempool-observer) https://github.com/bitcoin/bitcoin/pull/13949 11:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:42 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18188: test: Bump process time in scheduler_tests to avoid race (master...2002-testBumpSched) https://github.com/bitcoin/bitcoin/pull/18188 11:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:43 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 11:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 11:47 -!- oguzkoroglu [~ogu@94.54.224.17] has joined #bitcoin-core-dev 11:49 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:50 < bitcoin-git> [bitcoin] practicalswift closed pull request #17208: Make all tests pass UBSan without using any UBSan suppressions (master...ubsan-warnings) https://github.com/bitcoin/bitcoin/pull/17208 11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:54 < bitcoin-git> [bitcoin] instagibbs reopened pull request #15283: log: Fix UB with bench on genesis block (master...ub_genesis_bench) https://github.com/bitcoin/bitcoin/pull/15283 11:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:59 -!- oguzkoroglu [~ogu@94.54.224.17] has quit [Quit: Leaving] 12:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 12:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 12:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:06 < provoostenator> elichai2: re #1750 is the bare bones UI so let's not bike-shed it, gwillen has a pretty PR on top. But it does need testing and code review. 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/1750 | Some JSON values dont work in the GUI console · Issue #1750 · bitcoin/bitcoin · GitHub 12:07 < instagibbs> #17509 12:07 < gwillen> that's #17509, but yeah, my pretty PR on top is #18027 12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub 12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub 12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/18027 | "PSBT Operations" dialog by gwillen · Pull Request #18027 · bitcoin/bitcoin · GitHub 12:07 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 12:34 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 12:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 12:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:57 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Remote host closed the connection] 13:00 -!- feb1 [~feb@89.249.74.213] has quit [] 13:03 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds] 13:08 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:11 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:12 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:12 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 13:16 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 13:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:17 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:18 -!- elsimio [~elsimio@141.98.101.133] has joined #bitcoin-core-dev 13:38 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:42 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 14:06 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has joined #bitcoin-core-dev 14:12 -!- Kleene [ac3aab6d@172.58.171.109] has joined #bitcoin-core-dev 14:18 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 14:19 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 14:32 -!- Kleene [ac3aab6d@172.58.171.109] has quit [Remote host closed the connection] 14:33 -!- zero1729 [81cd71fb@129.205.113.251] has joined #bitcoin-core-dev 14:35 -!- zero1729 [81cd71fb@129.205.113.251] has quit [Remote host closed the connection] 14:36 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 268 seconds] 14:49 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:58 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 15:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:17 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Remote host closed the connection] 15:39 -!- vincenzopalazzo [~vincent@95.239.19.21] has quit [Remote host closed the connection] 15:45 < hebasto> dongcarl: mind testing #18077 on OpenBSD gateway router? 15:45 < gribble> https://github.com/bitcoin/bitcoin/issues/18077 | net: Add NAT-PMP port forwarding support by hebasto · Pull Request #18077 · bitcoin/bitcoin · GitHub 15:46 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 260 seconds] 15:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:50 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 15:55 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 15:56 -!- pinheadmz [~matthewzi@23.226.131.230] has quit [Ping timeout: 240 seconds] 15:56 -!- pinheadmz [~matthewzi@23.226.131.230] has joined #bitcoin-core-dev 15:57 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 268 seconds] 15:59 -!- marcoagner [~user@bl11-16-246.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 16:00 -!- elsimio [~elsimio@141.98.101.133] has quit [] 16:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:18 -!- IOMonster1 [~IOMonster@77.243.177.38] has joined #bitcoin-core-dev 16:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:41 < bitcoin-git> [bitcoin] fanquake closed pull request #18171: build: add macOS signing entitlements to macdeploy (master...macos_signing_requirements) https://github.com/bitcoin/bitcoin/pull/18171 16:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:43 -!- rjected [~rjected@50-204-66-177-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 16:54 < yevaud> I'm running rc2 on armv7/armv8 in a few weird setups. haven't seen anything noticeably wrong. 16:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:12 -!- amiti [sid373138@gateway/web/irccloud.com/x-gvzntudmmqkanyuv] has quit [Ping timeout: 246 seconds] 17:12 -!- valwal [sid334773@gateway/web/irccloud.com/x-wajfhrtqsoyaplll] has quit [Ping timeout: 246 seconds] 17:12 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 17:12 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 248 seconds] 17:12 -!- wumpus2 [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 17:14 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Ping timeout: 246 seconds] 17:15 -!- amiti [sid373138@gateway/web/irccloud.com/x-vgsjhmimihbqrmxs] has joined #bitcoin-core-dev 17:17 -!- valwal [sid334773@gateway/web/irccloud.com/x-yzuurchofjnijfpl] has joined #bitcoin-core-dev 17:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:35 < fanquake> yevaud: thanks for testing 17:39 -!- pinheadmz_ [~matthewzi@23.226.131.230] has joined #bitcoin-core-dev 17:41 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 17:41 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 17:42 -!- pinheadmz [~matthewzi@23.226.131.230] has quit [Ping timeout: 258 seconds] 17:42 -!- pinheadmz_ is now known as pinheadmz 17:43 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 17:46 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds] 17:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:58 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 18:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 18:04 -!- pinheadmz [~matthewzi@23.226.131.230] has quit [Ping timeout: 240 seconds] 18:08 -!- pinheadmz [~matthewzi@23.226.131.230] has joined #bitcoin-core-dev 18:10 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Ping timeout: 260 seconds] 18:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 18:37 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:39 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 18:56 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 18:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds] 19:00 -!- IOMonster1 [~IOMonster@77.243.177.38] has quit [] 19:01 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 19:04 -!- pinheadmz [~matthewzi@23.226.131.230] has quit [Ping timeout: 260 seconds] 19:04 -!- pinheadmz_ is now known as pinheadmz 19:12 < kallewoof> If anyone is up for reviewing the Signet pull request (#16411) I'm willing to answer questions and stuff. :) Even feedback on whether to use a static genesis block or a dynamic one would be helpful. Would love to get this merged before 0.20 release. 19:12 < gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub 19:17 -!- mota [~mota@77.243.177.38] has joined #bitcoin-core-dev 19:35 -!- francisco__ [uid418144@gateway/web/irccloud.com/x-zbwwjfjqwpafzpzi] has quit [Quit: Connection closed for inactivity] 19:45 -!- felixfoertsch [~felixfoer@2001:16b8:5019:e100:45b:c911:e68a:6397] has joined #bitcoin-core-dev 19:46 -!- felixfoertsch23 [~felixfoer@i6DFA6266.versanet.de] has quit [Ping timeout: 258 seconds] 19:53 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 255 seconds] 20:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:16 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 20:16 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:19 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 20:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 21:10 < fanquake> Just about finished tracking down the race in #16307 ! 21:10 < gribble> https://github.com/bitcoin/bitcoin/issues/16307 | scheduler: crash after releasing wallet · Issue #16307 · bitcoin/bitcoin · GitHub 21:18 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 21:23 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 22:00 -!- mota [~mota@77.243.177.38] has quit [] 22:09 < aj> fanquake: !! 22:11 < jeremyrubin> nice! 22:13 -!- francisco___ [uid418144@gateway/web/irccloud.com/x-sjfsreijckoftuop] has joined #bitcoin-core-dev 22:18 -!- kutio [~kutio@141.98.101.133] has joined #bitcoin-core-dev 22:25 < fanquake> From what I currently understand, it's a race where if BlockConnected() is called just after BlockUntilSyncedToCurrentChain in UnloadWallet, the scheduler thread is looping in SyncTransaction -> AddToWalletIfInvolvingMe, which grabs the cs_wallet lock each time, but then we try and delete the wallet (and lock) and blow up 22:36 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 22:37 < fanquake> The more logging I add to try and diagnose, the less frequent the crash seems to be. 22:41 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 22:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:59 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev 23:03 -!- rjected [~rjected@50-204-66-177-static.hfc.comcastbusiness.net] has quit [Ping timeout: 258 seconds] 23:05 -!- rjected [~rjected@50-204-66-177-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 23:07 -!- Oblo [~Okr@91.98.34.139] has joined #bitcoin-core-dev 23:07 -!- Oblo [~Okr@91.98.34.139] has left #bitcoin-core-dev [] 23:11 -!- Chetoe [~sw@181.119.112.188] has joined #bitcoin-core-dev 23:11 -!- Chetoe [~sw@181.119.112.188] has left #bitcoin-core-dev [] 23:14 -!- Cegre [~igla@179.97.244.93] has joined #bitcoin-core-dev 23:14 -!- Cegre [~igla@179.97.244.93] has left #bitcoin-core-dev [] 23:16 -!- aphoi [~Oqebliy@c-73-107-69-142.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 23:16 -!- aphoi [~Oqebliy@c-73-107-69-142.hsd1.fl.comcast.net] has left #bitcoin-core-dev [] 23:18 -!- droklatek [~Ifakoo@201.175.51.16] has joined #bitcoin-core-dev 23:18 -!- droklatek [~Ifakoo@201.175.51.16] has left #bitcoin-core-dev [] 23:19 -!- pocajic [~obloswa@103.90.231.73] has joined #bitcoin-core-dev 23:19 -!- pocajic [~obloswa@103.90.231.73] has left #bitcoin-core-dev [] 23:20 -!- aceoleeye [~Ej@179.83.45.77] has joined #bitcoin-core-dev 23:20 -!- aceoleeye [~Ej@179.83.45.77] has left #bitcoin-core-dev [] 23:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 23:29 < fanquake> So that's definitely the problem. We are trying to delete the cs_wallet lock that's being held by the scheduler thread. Shoddy debugging notes: https://gist.github.com/fanquake/a2dc2cddc153e07c077cd67653f3350d 23:37 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:46 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 272 seconds] 23:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev --- Log closed Fri Feb 21 00:00:59 2020