--- Log opened Tue Feb 25 00:00:04 2020
00:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:05 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
00:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:17 -!- okeyzc [~okeyzc@49.79.185.25] has joined #bitcoin-core-dev
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:18 < bitcoin-git> [bitcoin] practicalswift opened pull request #18206: tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter) (master...fuzzers-bloom_filter) https://github.com/bitcoin/bitcoin/pull/18206
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:33 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
00:39 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 255 seconds]
00:51 -!- sdjkertuz [~flack@p200300D46F149D002D5122D962F3B8A2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:53 -!- okeyzc [~okeyzc@49.79.185.25] has left #bitcoin-core-dev []
00:55 -!- kljasdfvv [~flack@p200300D46F149D00B09F415CFF6C6879.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
00:58 -!- marcoagner [~user@bl11-16-246.dsl.telepac.pt] has joined #bitcoin-core-dev
01:00 -!- kermit2 [~kermit@176.113.74.179] has quit []
01:01 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]
01:02 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
01:03 -!- rafalcpp [~racalcppp@ip-178-211.ists.pl] has joined #bitcoin-core-dev
01:16 -!- Dieterbe1 [~Dieterbe@77.243.177.38] has joined #bitcoin-core-dev
01:30 -!- side^effects [~al|iss@gateway/tor-sasl/aliss/x-63218493] has joined #bitcoin-core-dev
01:31 -!- side^effects [~al|iss@gateway/tor-sasl/aliss/x-63218493] has quit [Client Quit]
01:38 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:42 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:57 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
02:01 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
02:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds]
02:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:30 < bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a674e89d2771...03f98b15ad4f
02:30 < bitcoin-git> bitcoin/master 2ce3447 Vasil Dimov: Deduplicate the message verifying code
02:30 < bitcoin-git> bitcoin/master f8f0d98 Vasil Dimov: Deduplicate the message signing code
02:30 < bitcoin-git> bitcoin/master e193a84 Jeffrey Czyz: Refactor message hashing into a utility function
02:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:31 < bitcoin-git> [bitcoin] meshcollider merged pull request #17577: refactor: deduplicate the message sign/verify code (master...message-dedup) https://github.com/bitcoin/bitcoin/pull/17577
02:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:33 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds]
02:46 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
02:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:51 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/03f98b15ad4f...31c0006a6cd5
02:51 < bitcoin-git> bitcoin/master 29a21c9 Sjors Provoost: [rpc] set default bip32derivs to true for psbt methods
02:51 < bitcoin-git> bitcoin/master 5bad792 Sjors Provoost: [test] PSBT RPC: check that bip32_derivs are present by default
02:51 < bitcoin-git> bitcoin/master 31c0006 Samuel Dobson: Merge #17264: rpc: set default bip32derivs to true for psbt methods
02:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:52 < bitcoin-git> [bitcoin] meshcollider merged pull request #17264: rpc: set default bip32derivs to true for psbt methods (master...2019/10/bip32_derivs) https://github.com/bitcoin/bitcoin/pull/17264
02:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:56 < provoostenator> AppVeyor is in a bad mood again.
03:03 -!- Keven34Dooley [~Keven34Do@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
03:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
03:37 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:40 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 268 seconds]
03:44 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 260 seconds]
04:00 -!- Dieterbe1 [~Dieterbe@77.243.177.38] has quit []
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:03 < bitcoin-git> [bitcoin] sipsorcery opened pull request #18207: WIP: Touch appveyor vcpkg file to force refresh (master...appveyor-force-refresh) https://github.com/bitcoin/bitcoin/pull/18207
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
04:04 < provoostenator> Surprising number of "needs rebase" after #17577, even though most of those PRs built right on top of it.
04:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
04:07 -!- Kiminuo [~mix@141.98.103.118] has quit [Ping timeout: 258 seconds]
04:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
04:29 -!- rafalcpp [~racalcppp@ip-178-211.ists.pl] has quit [Ping timeout: 265 seconds]
04:34 -!- Kiminuo [~mix@141.98.103.118] has joined #bitcoin-core-dev
04:35 -!- rafalcpp [~racalcppp@ip-178-211.ists.pl] has joined #bitcoin-core-dev
04:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
04:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
04:43 -!- Ceriand [~Ceriand@185.169.255.76] has joined #bitcoin-core-dev
04:51 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
05:00 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
05:02 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
05:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
05:20 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
05:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:22 < bitcoin-git> [bitcoin] sipsorcery closed pull request #18207: WIP: Touch appveyor vcpkg file to force refresh (master...appveyor-force-refresh) https://github.com/bitcoin/bitcoin/pull/18207
05:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:42 -!- Highway61 [~Thunderbi@96.44.189.170] has joined #bitcoin-core-dev
05:51 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Ping timeout: 255 seconds]
05:51 < instagibbs> yeah annoying, but review should be pretty simply
05:51 < instagibbs> simple
05:58 < vasild> I just checked #18115 for example. It is "based" on #17577 but the commit ids are different: https://0bin.net/paste/ZgRPbnAXjrPZvk9Q#KZaaPhwa3QeB34w8wMdr5JVyKwkl+WaVI9rcjfb5H7z 
05:58 < gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
05:58 < gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
05:59 < vasild> so, from git perspective #18115 is not based on #17577
05:59 < gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
05:59 < gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
06:13 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
06:19 < vasild> I tried to rebase achow101/sign-in-spkman on top of bitcoin/master and got a conflict not related to 17577, but due to #17264 which modified src/wallet/psbtwallet.h (git show 29a21c906 -- src/wallet/psbtwallet.h) and 18115 deleted the file. To resolve, I replayed the change on wallet.h: git rebase bitcoin/master ; git rm src/wallet/psbtwallet.h ; sed -i '' 's/bip32derivs = false/bip32derivs = 
06:19 < gribble> https://github.com/bitcoin/bitcoin/issues/17264 | rpc: set default bip32derivs to true for psbt methods by Sjors · Pull Request #17264 · bitcoin/bitcoin · GitHub
06:19 < vasild> true/' src/wallet/wallet.h ; git add src/wallet/wallet.h ; git rebase --continue
06:19 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!]
06:26 -!- Keven34Dooley [~Keven34Do@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 258 seconds]
06:37 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
06:37 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
06:37 -!- Kiminuo [~mix@141.98.103.118] has quit [Ping timeout: 260 seconds]
07:00 -!- Ceriand [~Ceriand@185.169.255.76] has quit []
07:14 -!- Kiminuo [~mix@141.98.103.174] has joined #bitcoin-core-dev
07:15 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has quit [Quit: brianhoffman]
07:15 -!- NilsHitze [~NilsHitze@104.254.90.235] has joined #bitcoin-core-dev
07:18 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has joined #bitcoin-core-dev
07:26 -!- pinheadmz [~matthewzi@5.181.234.220] has quit [Read error: Connection reset by peer]
07:26 -!- pinheadmz [~matthewzi@5.181.234.220] has joined #bitcoin-core-dev
07:26 -!- t420babe [~t420babe@141.149.53.225] has quit [Quit: Ping timeout (120 seconds)]
07:27 -!- t420babe [~t420babe@141.149.53.225] has joined #bitcoin-core-dev
07:27 -!- adam3us [~adam3us@unaffiliated/adam3us] has quit [Quit: QUIT]
07:27 -!- nsh [~lol@wikipedia/nsh] has quit [Remote host closed the connection]
07:29 -!- adam3us [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev
07:45 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev
07:47 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:03 -!- ahmed_ [uid14086@gateway/web/irccloud.com/x-tvhjclaldvpybspd] has joined #bitcoin-core-dev
08:09 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Remote host closed the connection]
08:13 < sdaftuar> sipa: around?  i was just discussing wtxid-relay with gleb, he brought up that the erlay proposal included a 128-bit wtxid-relay component as well, which made me think that if we wanted to go that route, i should just update my proposal for wtxid-relay to do that
08:13 < sipa> sdaftuar: yeah, that seems reasonable
08:14 < sdaftuar> sipa: but that made me wonder if 128-bit commitments are secure enough for transaction relay; seems like in protocols where multiple parties are jointly constructing transactions, you only get 64-bit security against collisions, which could be used to interfere with relay?
08:14 < sipa> hmm
08:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
08:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
08:16 < sipa> 2^64 is still an enormous amount of work... not "impossible", but it's still several days with a modern ASIC miner
08:17 < gleb> For the context, there's no real need to use 128-bit in Erlay, it's just an additional bandwidth saving, maybe about 5% of the overall bandwidth a node consumes.
08:17 < sipa> (assuming an ASIC could even be used for that purpose of course)
08:18 < sipa> and at those cost levels there are probably easier ways to interfere with relay
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:18 < bitcoin-git> [bitcoin] yusufsahinhamza opened pull request #18208: rpc: Fix RPCExamples (master...fix-rpc-examples) https://github.com/bitcoin/bitcoin/pull/18208
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:18 < sdaftuar> right, and maybe protocols today work in such a way to make this not really an issue, just hard for me to reason about it 
08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:19 < bitcoin-git> [bitcoin] yusufsahinhamza closed pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:56 < sipa> sdaftuar: like... you could just create a double spend instead
08:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:56 < bitcoin-git> [bitcoin] yusufsahinhamza reopened pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
08:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:56 < sipa> so i think the goal is making sure relay isn't worse accidentally
08:56 < sipa> rather tha  intentionally
08:57 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]
09:03 < MarcoFalke> PSA to review locally. GitHub is again serving corrupt pull requests on the website
09:07 < achow101> vasild: usually when I base a PR on other commits, we just cherry pick those commits and base the whole thing on whatever the master was at that time
09:07 < achow101> so the commit hashes won't match, but the diffs do
09:07 < achow101> then during a rebase, those commits can be dropped and the overall diff stays the same
09:10 < vasild> achow101: I see, github nevertheless, still prints "This branch has conflicts that must be resolved ... src/util/message.h" even though when I tried the rebase there was not a conflict in src/util/message.h
09:11 < MarcoFalke> vasild: GitHub backend is down or lagging, so that might be the issue
09:12 < sdaftuar> sipa: not sure i follow... are there protocols where you and i might produce a multisig transaction (signing a shared output i can't double-spend),but where interfering with the relay of that jointly-constructed transaction is beneficial to me somehow?
09:12 < sdaftuar> ie in lightning
09:12 < achow101> It's normal for github to say there's a merge conflict when the files that were modified by the base PR gets merged
09:12 < sdaftuar> this might be easier for me to talk about if i actually had any idea how lightning works, let me ask someone here :)
09:14 < sipa> sdaftuar: oh good point, let me think more
09:15 < vasild> achow101: yes, all good
09:16 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:17 < sipa> sdaftuar: somehow i thought a collision would need multiple parties to collaborate; need more caffeine
09:19 < sdaftuar> i just talked it through with matt and he seems to believe that what i'm saying would be a concern in lightning (at least theoretically -- as a practical matter i have no idea)
09:20 < sipa> another possibility is just skipping 128-bit wtxid for now, and doing it as a later step (orthogonal to wtxid and erlay)
09:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
09:22 < sipa> or not
09:25 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 260 seconds]
09:36 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-dev
09:37 -!- krvopije [~krvopije@185.106.109.144] has quit [Remote host closed the connection]
09:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds]
09:50 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
09:56 < gleb> I'm afraid that means that final potential version will have to support txid, wtxid, and trunc-wtxid, so 3 different filters?
10:00 -!- NilsHitze [~NilsHitze@104.254.90.235] has quit []
10:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:02 < bitcoin-git> [bitcoin] yusufsahinhamza closed pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
10:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:07 -!- spinny [55f248bc@bl9-72-188.dsl.telepac.pt] has joined #bitcoin-core-dev
10:07 < sipa> gleb: at least with ordered indexes, one index suffices for both 128-bit and 256-bit lookups
10:07 < sipa> ah, but the current mempool index is not ordered
10:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:16 -!- StephenS1 [~StephenS@185.204.1.185] has joined #bitcoin-core-dev
10:22 -!- ahmed_ [uid14086@gateway/web/irccloud.com/x-tvhjclaldvpybspd] has quit [Quit: Connection closed for inactivity]
10:34 -!- theoRem_ [~theorem@p5DD91D60.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
10:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
10:34 -!- theoRem_ is now known as Guest52093
10:34 < sdaftuar> my instinct is that for a 5% bandwidth savings (once we have erlay), it's not really worth the effort to try to convince ourselves that the truncated hash is safe, but i feel a bit bad being a defeatist
10:43 -!- Guest52093 [~theorem@p5DD91D60.dip0.t-ipconnect.de] has quit []
10:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
10:44 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
10:45 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:55 < gleb> Yeah, at this point I'd also prefer to stick with 256-bit ids, for the reason suhas points out. I also bet someone smart would decide to waste their time to write a paper about attacking bitcoin with this thing :)
11:02 < sipa> maybe that's indeed best
11:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:07 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
11:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
11:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:15 < bitcoin-git> [bitcoin] kiminuo opened pull request #18210: Type hints in Python tests (master...feature/type-hint-minimum) https://github.com/bitcoin/bitcoin/pull/18210
11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:21 < instagibbs> gleb, another way to look at it is including truncated wtxid may slow down erlay, which has asymptotic win, not just %
11:21 < instagibbs> wrt number of peers
11:21 < instagibbs> slow down acceptance of erlay*
11:22 < gleb> instagibbs: Why would it slow down the acceptance of erlay?
11:26 < instagibbs> another bikeshedding/discussion, just like here :)
11:26 < instagibbs> maybe I'm wrong, then nevermind me
11:27 < sipa> instagibbs: that's boring, sure you're not up for a trial by combat to determine who is right?
11:28 < gleb> instagibbs: In this particular case I was less optimistic about people caring, but yeah, you're right in that sense.
11:32 -!- mk_ [uid422927@gateway/web/irccloud.com/x-hsgxxhpypyhkipgq] has quit [Quit: Connection closed for inactivity]
11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:38 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/31c0006a6cd5...c3b471592346
11:38 < bitcoin-git> bitcoin/master 2a6a6ea practicalswift: tests: Add fuzzing harness for bloom filter class CBloomFilter
11:38 < bitcoin-git> bitcoin/master eabbbe4 practicalswift: tests: Add fuzzing harness for rolling bloom filter class CRollingBloomFil...
11:38 < bitcoin-git> bitcoin/master c3b4715 MarcoFalke: Merge #18206: tests: Add fuzzing harness for bloom filter classes (CBloomF...
11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18206: tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter) (master...fuzzers-bloom_filter) https://github.com/bitcoin/bitcoin/pull/18206
11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:57 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 252 seconds]
12:16 < sdaftuar> jeremyrubin: around?
12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:29 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18211: test: Work around scheduler_tests intermittent failures (take 2) (master...2002-testSchedulerWorkaround) https://github.com/bitcoin/bitcoin/pull/18211
12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:32 -!- guest534543 [~mix@141.98.103.214] has joined #bitcoin-core-dev
12:35 -!- Kiminuo [~mix@141.98.103.174] has quit [Ping timeout: 260 seconds]
12:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer]
12:49 -!- guest534543 [~mix@141.98.103.214] has quit [Quit: Leaving]
12:49 -!- Kiminuo [~mix@141.98.103.214] has joined #bitcoin-core-dev
12:52 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:00 -!- StephenS1 [~StephenS@185.204.1.185] has quit []
13:20 -!- spinny [55f248bc@bl9-72-188.dsl.telepac.pt] has quit [Remote host closed the connection]
13:35 -!- ghost1 [~ghost1@c-73-245-52-228.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
13:37 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
13:39 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 265 seconds]
13:45 -!- mikeyman77 [~mikeyman7@176.113.74.179] has joined #bitcoin-core-dev
13:57 -!- ghost1 [~ghost1@c-73-245-52-228.hsd1.fl.comcast.net] has quit [Quit: ghost1]
14:02 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
14:04 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
14:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
14:14 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:16 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
14:16 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds]
14:29 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
14:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:40 -!- djpeen [uid424290@gateway/web/irccloud.com/x-raqrxbgdvchfwslh] has joined #bitcoin-core-dev
14:41 -!- djpeen [uid424290@gateway/web/irccloud.com/x-raqrxbgdvchfwslh] has quit [Client Quit]
14:42 -!- djpeen_ [uid424290@gateway/web/irccloud.com/x-wbasuwzquxdktyts] has joined #bitcoin-core-dev
14:42 -!- djpeen_ [uid424290@gateway/web/irccloud.com/x-wbasuwzquxdktyts] has quit [Client Quit]
14:43 -!- djpeen [uid424290@gateway/web/irccloud.com/x-luobenmryebbjwoh] has joined #bitcoin-core-dev
14:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
14:58 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:00 < achow101> what would cause std::map to not find an element that's definitely there?
15:00 < achow101> examining in gdb tells me the element is there and the key I'm searching with is correct. but it always returns end()
15:02 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
15:03 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit]
15:07 < sipa> achow101: was the key elememt modified after inserting?
15:07 < achow101> no
15:07 < sipa> what is the key type?
15:08 < achow101> KeyOriginInfo. I added an operator<
15:08 < sipa> what pr?
15:09 < achow101> I haven't pushed it yet. it's supposed to be a modification to #18204
15:09 < gribble> https://github.com/bitcoin/bitcoin/issues/18204 | descriptors: improve descriptor cache and cache xpubs by achow101 · Pull Request #18204 · bitcoin/bitcoin · GitHub
15:09 < sipa> ok link to code/branchm
15:09 < sipa> ?
15:09 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:10 < achow101> https://github.com/achow101/bitcoin/tree/desc-xpub-cache2
15:11 < achow101> descriptor_tests fails currently due to that maps thing
15:11 < sipa> your operator< is inconsistent
15:11 < achow101> it is?
15:12 < sipa> if a.fingerprint > b.fingerprint you have to return false
15:12 < sipa> even if a.path < b.path
15:13 < achow101> ah
15:13 < sipa> the general structure of such comparators is something like: if a.x < b.x return true; if a.x > b.x return false; if a.x == b.x fall through to next tie breaker
15:15 < achow101> I guess that explains why it only failed with the multi descriptors too
15:15 < achow101> when I had more than one xpub in the map
15:16 < sipa> right
15:19 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:21 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
15:31 -!- wullon5 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Quit: The Lounge - https://thelounge.chat]
15:35 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has quit [Ping timeout: 258 seconds]
15:49 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:50 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has joined #bitcoin-core-dev
16:00 -!- mikeyman77 [~mikeyman7@176.113.74.179] has quit []
16:16 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
16:17 -!- aqu4 [~aqu4@141.98.101.133] has joined #bitcoin-core-dev
16:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
16:28 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
16:31 -!- marcoagner [~user@bl11-16-246.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
16:45 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
16:54 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
16:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]
17:16 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:33 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
17:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:41 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:42 -!- promag__ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:43 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
17:46 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 255 seconds]
18:00 < fanquake> promag: does #18160 actually fix a bug, like incorrect balances, or just improves on "a waste of resources"? If it's the later, it's unlikely it'd be backported.
18:01 < gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
18:02 < fanquake> Generally we only want to backport actual bug/security fixes. Making some poll/loop in the GUI slightly more efficient doesn't really qualify. Unless I'm missing something of course.
18:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
18:08 -!- promag__ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
18:16 -!- Highway61 [~Thunderbi@96.44.189.170] has quit [Ping timeout: 258 seconds]
18:55 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
19:00 -!- aqu4 [~aqu4@141.98.101.133] has quit []
19:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:01 < bitcoin-git> [bitcoin] luke-jr closed pull request #17213: gui: Add Windows taskbar progress (master...win_taskbar_progress) https://github.com/bitcoin/bitcoin/pull/17213
19:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:01 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
19:01 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
19:07 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
19:17 -!- Lord1 [~Lord@37.120.217.243] has joined #bitcoin-core-dev
19:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:30 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
19:31 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
19:40 -!- felixfoertsch [~felixfoer@2001:16b8:507f:6500:50b5:9df8:654c:ee60] has quit [Ping timeout: 272 seconds]
19:40 -!- felixfoertsch23 [~felixfoer@92.117.56.33] has joined #bitcoin-core-dev
19:40 < meshcollider> fanquake: I think it's the latter
19:47 -!- dingus is now known as grubles
19:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]
20:13 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
20:24 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
20:26 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
20:30 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 258 seconds]
21:10 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has quit [Ping timeout: 260 seconds]
21:24 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has joined #bitcoin-core-dev
21:44 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
21:49 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
21:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:00 -!- Lord1 [~Lord@37.120.217.243] has quit []
22:17 -!- jchris [~jchris@185.204.1.185] has joined #bitcoin-core-dev
22:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
22:52 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
22:53 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
22:54 -!- Kiminuo [~mix@141.98.103.214] has quit [Ping timeout: 260 seconds]
22:59 -!- Highway61 [~Thunderbi@96.44.189.170] has joined #bitcoin-core-dev
23:05 -!- Kiminuo [~mix@141.98.103.180] has joined #bitcoin-core-dev
23:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
23:20 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds]
23:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
23:43 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
23:44 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Ping timeout: 260 seconds]
23:53 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
23:56 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds]
--- Log closed Wed Feb 26 00:00:05 2020