--- Log opened Wed Mar 04 00:00:12 2020 00:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 00:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:09 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 00:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:15 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 00:40 -!- promag [~promag@31.22.202.122] has joined #bitcoin-core-dev 00:44 -!- promag [~promag@31.22.202.122] has quit [Remote host closed the connection] 01:00 -!- SukhE1 [~SukhE@176.113.74.179] has quit [] 01:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 01:05 -!- jplix7k [6ab40c47@KD106180012071.au-net.ne.jp] has quit [Remote host closed the connection] 01:09 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 01:10 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:11 -!- jonatack [~jon@37.171.110.92] has joined #bitcoin-core-dev 01:12 -!- tylerlevine6 [~hardforkt@li120-195.members.linode.com] has joined #bitcoin-core-dev 01:13 -!- tylerlevine [~hardforkt@li120-195.members.linode.com] has quit [Read error: Connection reset by peer] 01:13 -!- marcoagner [~user@dsl-48-120.bl26.telepac.pt] has joined #bitcoin-core-dev 01:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 258 seconds] 01:20 -!- dvratil1 [~dvratil@195.206.183.79] has joined #bitcoin-core-dev 01:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:26 < provoostenator> Or the lazy version if Github is still up to date and you trust them: git reset --hard origin/my-precious-branch 01:26 < provoostenator> * origin -> your github remote 01:29 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:33 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:33 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev 01:40 -!- turbo_choo [~turbo_cho@223.73.43.194] has quit [Ping timeout: 255 seconds] 01:45 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 01:53 -!- turbo_choo [~turbo_cho@223.73.43.194] has joined #bitcoin-core-dev 02:00 -!- jonatack_ [~jon@37.167.199.192] has joined #bitcoin-core-dev 02:03 -!- jonatack [~jon@37.171.110.92] has quit [Ping timeout: 258 seconds] 02:04 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 02:04 -!- kexkey [~kexkey@37.120.205.237] has quit [Ping timeout: 256 seconds] 02:09 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 02:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:20 < kallewoof> prob is, i checked out from master into a new branch, did a bunch of stuff, and then screwed up when I meant to do git checkout -B OVERWRITE_THIS by instead checking out OVERWRITE_THIS branch and doing git checkout -B MYCHANGES... 02:20 < kallewoof> I think my brain decided that checkout -B meant "checkout whatever is on the branch and use that as the new head for this branch".. 02:22 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 02:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 03:02 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev 03:02 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 03:03 -!- jonatack_ [~jon@37.167.199.192] has quit [Ping timeout: 265 seconds] 03:03 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 03:03 -!- Rudy3Heaney [~Rudy3Hean@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:04 -!- jonatack_ [~jon@213.152.161.25] has joined #bitcoin-core-dev 03:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:36 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 03:41 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 03:50 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 03:52 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 03:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 03:54 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:58 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 04:00 -!- dvratil1 [~dvratil@195.206.183.79] has quit [] 04:05 < wumpus> shall I tag v0.19.1? 04:06 < wumpus> I guess I forgot about it a bit and no one reminded me. I don't think anything critical has come up with rc2? 04:09 < fanquake> wumpus: sounds good 04:09 < fanquake> I haven't seen anything re rc2 04:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:15 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/a28ea316ed47...58ba7c314d55 04:15 < bitcoin-git> bitcoin/0.19 58ba7c3 Wladimir J. van der Laan: build: Bump version for 0.19.1 final 04:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:16 < bitcoin-git> [bitcoin] laanwj pushed tag v0.19.1: https://github.com/bitcoin/bitcoin/compare/v0.19.1 04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:20 -!- jonatack_ [~jon@213.152.161.25] has quit [Ping timeout: 256 seconds] 04:20 -!- phyll1s_work [~phyll1s_w@195.206.169.238] has joined #bitcoin-core-dev 04:22 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 04:22 -!- jonatack_ [~jon@37.167.220.16] has joined #bitcoin-core-dev 04:25 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 04:29 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 04:32 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 04:34 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 04:54 -!- CodeShark__ [sid126576@gateway/web/irccloud.com/x-zfaaqxmwsbclwhye] has quit [Read error: Connection reset by peer] 04:54 -!- arik__ [sid402902@gateway/web/irccloud.com/x-evhbfsozdxtfdipd] has quit [Ping timeout: 252 seconds] 04:54 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-gixycdnhlfkurqrj] has quit [Read error: Connection reset by peer] 04:54 -!- CodeShark__ [sid126576@gateway/web/irccloud.com/x-znyiwxyzpspwnjea] has joined #bitcoin-core-dev 04:55 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-udnkezyauyabrwwv] has joined #bitcoin-core-dev 04:55 -!- arik__ [sid402902@gateway/web/irccloud.com/x-aoehrcvgeqodfrcf] has joined #bitcoin-core-dev 04:56 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Read error: Connection reset by peer] 05:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:06 -!- Giderey36 [~Giderey36@213.232.87.92] has joined #bitcoin-core-dev 05:11 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 05:13 -!- Highway61 [~Thunderbi@192.252.213.238] has quit [Quit: Highway61] 05:14 -!- Highway61 [~Thunderbi@192.252.213.238] has joined #bitcoin-core-dev 05:16 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 05:18 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/088604221b4a...a71c34742c24 05:18 < bitcoin-git> bitcoin/master fa7d050 MarcoFalke: rpc: Move OuterType enum to header 05:18 < bitcoin-git> bitcoin/master fa6b061 MarcoFalke: rpc: Auto-format RPCResult 05:18 < bitcoin-git> bitcoin/master a71c347 MarcoFalke: Merge #17809: rpc: Auto-format RPCResult 05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:18 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17809: rpc: Auto-format RPCResult (master...1906-rpcResult) https://github.com/bitcoin/bitcoin/pull/17809 05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:19 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 05:19 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 05:23 -!- arik__ [sid402902@gateway/web/irccloud.com/x-aoehrcvgeqodfrcf] has quit [Ping timeout: 240 seconds] 05:23 -!- arik__ [sid402902@gateway/web/irccloud.com/x-smlrwlozrxhsmqmw] has joined #bitcoin-core-dev 05:23 -!- valwal [sid334773@gateway/web/irccloud.com/x-yzuurchofjnijfpl] has quit [Ping timeout: 240 seconds] 05:24 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 258 seconds] 05:25 -!- valwal [sid334773@gateway/web/irccloud.com/x-fjwyjmifqhyhulwf] has joined #bitcoin-core-dev 05:25 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 05:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:33 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 05:34 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 05:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 05:36 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 05:37 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 05:38 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 05:48 -!- turbo_choo [~turbo_cho@223.73.43.194] has quit [Ping timeout: 255 seconds] 05:50 -!- turbo_choo [~turbo_cho@223.73.43.194] has joined #bitcoin-core-dev 05:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:58 -!- promag [~promag@a89-152-187-241.cpe.netcabo.pt] has joined #bitcoin-core-dev 05:59 -!- turbo_choo [~turbo_cho@223.73.43.194] has quit [Ping timeout: 256 seconds] 06:02 -!- promag [~promag@a89-152-187-241.cpe.netcabo.pt] has quit [Ping timeout: 255 seconds] 06:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:08 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 06:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 06:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:25 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 06:30 -!- turbo_choo [~turbo_cho@223.73.43.194] has joined #bitcoin-core-dev 06:35 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 06:35 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 06:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:36 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18164: rpc: generalize address in decoderawtransaction RPCResult (master...20200216-rpc-remove-concrete-address-from-rpcresult) https://github.com/bitcoin/bitcoin/pull/18164 06:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:40 -!- turbo_choo [~turbo_cho@223.73.43.194] has quit [Ping timeout: 255 seconds] 06:53 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 06:58 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:00 -!- phyll1s_work [~phyll1s_w@195.206.169.238] has quit [] 07:01 < harding> wumpus: FYI, 0.19.1 release stuff for the website: https://github.com/bitcoin-core/bitcoincore.org/pull/698 07:01 -!- Giderey36 [~Giderey36@213.232.87.92] has quit [Ping timeout: 260 seconds] 07:04 -!- Rudy3Heaney [~Rudy3Hean@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 07:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:06 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18259: doc: Merge release notes for 0.20.0 release (master...2003-docMergeRel) https://github.com/bitcoin/bitcoin/pull/18259 07:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:06 -!- turbo_choo [~turbo_cho@223.73.43.194] has joined #bitcoin-core-dev 07:17 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 07:21 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Quit: pinheadmz] 07:22 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:22 -!- Kiminuo [~mix@141.98.103.172] has quit [Ping timeout: 265 seconds] 07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/58ba7c314d55...05f5dd96c71e 07:24 < bitcoin-git> bitcoin/0.19 1964561 fanquake: build: don't embed a build-id when building libdmg-hfsplus 07:24 < bitcoin-git> bitcoin/0.19 48fef5e Russell Yanofsky: gui: Fix race in WalletModel::pollBalanceChanged 07:24 < bitcoin-git> bitcoin/0.19 05f5dd9 MarcoFalke: Merge #18218: [0.19] Further 0.19 backports 07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18218: [0.19] Further 0.19 backports (0.19...futher-0-19-backports) https://github.com/bitcoin/bitcoin/pull/18218 07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:26 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!] 07:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:34 -!- Giderey36 [~Giderey36@213.232.87.92] has joined #bitcoin-core-dev 07:41 < jonatack_> Re-kick appveyor for #17812 please 07:41 < gribble> https://github.com/bitcoin/bitcoin/issues/17812 | config, net, test: asmap feature refinements and functional tests by jonatack · Pull Request #17812 · bitcoin/bitcoin · GitHub 07:41 -!- Giderey36 [~Giderey36@213.232.87.92] has quit [Ping timeout: 256 seconds] 07:44 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:49 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 07:51 -!- jonatack_ [~jon@37.167.220.16] has quit [Quit: jonatack_] 07:51 -!- jonatack [~jon@37.167.220.16] has joined #bitcoin-core-dev 07:55 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:56 -!- grafa [~grafa@185.169.255.76] has joined #bitcoin-core-dev 08:02 -!- turbo_choo [~turbo_cho@223.73.43.194] has quit [Ping timeout: 268 seconds] 08:03 < instagibbs> sipa, https://github.com/bitcoin/bitcoin/pull/18204#discussion_r387761668 mind just giving an straw function of inputs to "key expressions numbers"? 08:06 < sipa> instagibbs: sh(multi(2,xpubA...,xpubB,xpubC)) 08:06 < sipa> xpubA would be 0 08:06 < sipa> xpubB woukd be 1 08:06 < sipa> xoubC would be 2 08:11 < instagibbs> ah. Slightly different abstraction than I was thinking 08:28 < sipa> for hardened paths you'd still need a pubkey per derivation as well 08:29 < luke-jr> MarcoFalke: how does the boost bug tested in #18232 affect us? 08:29 < gribble> https://github.com/bitcoin/bitcoin/issues/18232 | test: Check that wait_until returns if time point is in the past by MarcoFalke · Pull Request #18232 · bitcoin/bitcoin · GitHub 08:36 -!- vincenzopalazzo [~vincent@2607:fb90:4e35:422e:71d9:a300:270d:9a99] has joined #bitcoin-core-dev 08:51 -!- vincentpalazzo [~vincent@wsip-66-210-1-242.ph.ph.cox.net] has joined #bitcoin-core-dev 08:54 -!- vincenzopalazzo [~vincent@2607:fb90:4e35:422e:71d9:a300:270d:9a99] has quit [Ping timeout: 240 seconds] 08:54 -!- Kiminuo [~mix@141.98.103.76] has joined #bitcoin-core-dev 08:59 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 09:04 -!- lightlike [~lightlike@p200300C7EF0EC400657752C6D67C6B18.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:05 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 09:06 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 09:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:07 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:16 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 09:18 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 240 seconds] 09:19 < MarcoFalke> luke-jr: I don't think it affects us 09:20 < MarcoFalke> Well, it might if you change your time zone or system time. But I think Bitcoin Core does not support that anyway?! 09:21 < MarcoFalke> Or if you schedule something with a timestamp in the past. I think we don't do that either 09:21 < luke-jr> then why test it? 09:22 < luke-jr> no reason to create hurdles to tests passing, if they don't affect us.. 09:22 < MarcoFalke> It does happen in unit tests or functional test, because there we schedule things in the past (for testing reasons) 09:22 < luke-jr> hmm 09:23 < luke-jr> well, we still should be able to test on current systems IMO 09:23 < MarcoFalke> Yeah, which is why the mockscheduler test is disabled 09:24 < MarcoFalke> I think the only feasible solution is to remove boost 09:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:24 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18232: WIP test: Check that wait_until returns if time point is in the past (master...2002-debugBoost) https://github.com/bitcoin/bitcoin/pull/18232 09:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:25 < luke-jr> or handle the exception? 09:30 -!- vincentpalazzo [~vincent@wsip-66-210-1-242.ph.ph.cox.net] has quit [Quit: Leaving] 09:31 < MarcoFalke> How would you handle it and then proceed with execution? 09:31 < MarcoFalke> The next call would throw the same exception 09:32 < MarcoFalke> And if the exception is handled in the scheduler, it seems overkill to modify Bitcoin Core code for purly (unit) testing needs 09:32 < MarcoFalke> *purely 09:32 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has joined #bitcoin-core-dev 09:33 * MarcoFalke lunch 09:33 < luke-jr> MarcoFalke: if the exception is thrown, check manually if the time is past; if not, rethrow 09:33 < luke-jr> if so, nothing more to do 09:37 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Remote host closed the connection] 09:39 -!- rafalcpp_ [~racalcppp@ip-178-211.ists.pl] has quit [Ping timeout: 255 seconds] 09:41 -!- rafalcpp_ [~racalcppp@ip-178-211.ists.pl] has joined #bitcoin-core-dev 09:42 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 09:49 -!- lightlike [~lightlike@p200300C7EF0EC400657752C6D67C6B18.dip0.t-ipconnect.de] has left #bitcoin-core-dev ["Leaving"] 09:57 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 10:00 -!- grafa [~grafa@185.169.255.76] has quit [] 10:11 < MarcoFalke> Jup, in that case it would need to be handled in the scheduler, which I'd rather not for the reason just mentioned 10:21 -!- dougvann [~dougvann@185.169.255.76] has joined #bitcoin-core-dev 10:21 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:22 < nothingmuch> MarcoFalke: i think the currently disabled test can be made robust to the failure by deducting a delta that doesn't go too far into the past, i'm attempting that now 10:23 < nothingmuch> the mockforward test, that is 10:23 < MarcoFalke> I know. But that still doesn't *solve* the problem 10:24 < MarcoFalke> If you reboot your machine and have the tests already compiled it will still fail, even with a minimal delta 10:24 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 10:24 < nothingmuch> oh! 10:24 < nothingmuch> i didn't realize that =( 10:24 < MarcoFalke> Basically any delta that is larger than the time it took you to start your machine 10:25 < nothingmuch> oh, ok that's how i understood it before... just to make sure - the time of compilation itself doesn't factor in, right? it's that if the compilation is fast? 10:25 < nothingmuch> what i was going to do is just compute a delta for mockforward that is enough to be in the past, but no further in the past than the start of the test 10:25 < MarcoFalke> The boost::internal_clock (whatever that is) starts to count when you start your computer 10:26 < MarcoFalke> if boot+compile takes 2 minutes, the clock will show 2 minutes 10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:26 < bitcoin-git> [bitcoin] rex4539 closed pull request #17839: build: depends macOS: hide linker visibility warnings (master...hide-warnings) https://github.com/bitcoin/bitcoin/pull/17839 10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:27 < MarcoFalke> The unit test should fully run in 2 milliseconds, so I don't think you can use the start of the test as a useful reference time 10:29 < nothingmuch> because such a test would be too slow to be acceptable? i was going to reduce the 5 minutes by a few orders of magnitude 10:30 < nothingmuch> i.e. t0 = now; microsleep; dt = now-t0; schedule for dt from now; mock forward by 2*dt 10:31 < MarcoFalke> The test is disabled now, so it doesn't do any harm. Long term we should focus on #18234 10:31 < gribble> https://github.com/bitcoin/bitcoin/issues/18234 | refactor: Replace boost::mutex,condition_var,chrono with std equivalents in scheduler by ajtowns · Pull Request #18234 · bitcoin/bitcoin · GitHub 10:31 < MarcoFalke> 18234 also fixes the bug, by removing boost 10:31 < nothingmuch> fair enough, though i didn't feel qualified to review that 10:35 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev 10:37 -!- ak [b6461218@182.70.18.24] has joined #bitcoin-core-dev 10:39 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 10:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:53 < bitcoin-git> [bitcoin] Empact opened pull request #18260: refactor: Fix implicit value conversion in formatPingTime (master...2020-03-ping-time) https://github.com/bitcoin/bitcoin/pull/18260 10:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:59 -!- ak [b6461218@182.70.18.24] has quit [Ping timeout: 260 seconds] 11:07 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:11 < jonasschnelli> 0.19.1 detached sigs are up: https://github.com/bitcoin-core/bitcoin-detached-sigs/commits/0.19 11:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 11:21 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 11:22 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 11:22 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 11:22 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Ping timeout: 256 seconds] 11:22 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 11:23 < cfields_> jonasschnelli: need to tag first ;) 11:23 < cfields_> tagging now 11:23 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:23 < jonasschnelli> cfields_: oh. Right. Thanks... 11:24 < jonasschnelli> cfields_: whats sigs would it take if there is no tag? Just the head of the 0.19 branch? 11:24 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 11:25 < cfields_> jonasschnelli: it tries to checkout a ref with the same name as the release. So 'git reset --hard v0.19.1' (or something like that) would just fail. 11:26 < cfields_> ok, gitian builders: detached sigs for v0.19.1 are up 11:27 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Client Quit] 11:27 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 255 seconds] 11:28 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 11:29 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Client Quit] 11:32 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 11:40 -!- sdddddd [~fa@101.229.164.18] has quit [Ping timeout: 240 seconds] 11:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 11:41 -!- sdddddd [~fa@101.229.164.18] has joined #bitcoin-core-dev 11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 11:57 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds] 11:58 -!- vasild_ is now known as vasild 11:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:01 < bitcoin-git> [bitcoin] naumenkogs opened pull request #18261: Erlay: bandwidth-efficient transaction relay protocol (master...erlay) https://github.com/bitcoin/bitcoin/pull/18261 12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:02 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:06 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Ping timeout: 256 seconds] 12:06 -!- jonatack [~jon@37.167.220.16] has quit [Read error: Connection reset by peer] 12:12 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 12:14 < instagibbs> luke-jr, unless I have serious misunderstandings, erlay shouldn't really effected anymore than flooding relay with respect to diverse network policies 12:14 < instagibbs> it's basically a batching of INVs you would have sent your peer, then compact exchange of that difference 12:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:16 < bitcoin-git> [bitcoin] luke-jr reopened pull request #15600: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps or forked process memory spaces (master...lockedpool_dontdump) https://github.com/bitcoin/bitcoin/pull/15600 12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:22 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 12:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:28 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 256 seconds] 12:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:42 -!- Guyver2_ is now known as Guyver2 12:45 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 12:49 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 255 seconds] 12:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 12:54 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 12:55 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 12:57 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Ping timeout: 265 seconds] 12:58 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:00 -!- dougvann [~dougvann@185.169.255.76] has quit [] 13:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 256 seconds] 13:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 255 seconds] 13:12 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 13:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:38 < bitcoin-git> [bitcoin] achow101 opened pull request #18262: bnb: exit selection when best_waste is 0 (master...bnb-waste-zero) https://github.com/bitcoin/bitcoin/pull/18262 13:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:39 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:41 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 13:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 13:56 -!- Dantman [~Dantman@195.206.183.79] has joined #bitcoin-core-dev 13:59 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 14:02 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 240 seconds] 14:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:08 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 14:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:12 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:13 -!- as_pnn [~pierreirc@119.192.247.147] has quit [Read error: Connection reset by peer] 14:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 14:14 -!- roconnor [~roconnor@host-104-157-187-25.dyn.295.ca] has joined #bitcoin-core-dev 14:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds] 14:17 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:25 < bitcoin-git> [bitcoin] gzhao408 opened pull request #18263: rpc change setmocktime check to use IsMockableChain (master...rpc-setmocktime-check) https://github.com/bitcoin/bitcoin/pull/18263 14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:31 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:32 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [] 14:34 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 258 seconds] 14:36 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 14:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:40 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 14:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 256 seconds] 14:50 -!- as_pnn [~pierreirc@119.192.247.147] has joined #bitcoin-core-dev 14:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 14:51 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 15:02 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 15:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:15 -!- YoungWoma [YoungWoma@222.red-88-14-117.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 15:18 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 15:19 -!- YoungWoma [YoungWoma@222.red-88-14-117.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 15:23 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 15:23 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has quit [Quit: Sleep mode] 15:23 -!- francisco______ [uid418144@gateway/web/irccloud.com/x-zctuokqwxkkwrget] has joined #bitcoin-core-dev 15:38 -!- marcoagner [~user@dsl-48-120.bl26.telepac.pt] has quit [Ping timeout: 268 seconds] 15:38 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Ping timeout: 272 seconds] 15:41 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev 15:44 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:55 -!- jarthur [~jarthur@207.114.244.5] has quit [] 16:00 -!- Dantman [~Dantman@195.206.183.79] has quit [] 16:01 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev 16:05 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Ping timeout: 256 seconds] 16:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:07 < bitcoin-git> [bitcoin] fanquake closed pull request #17795: gui: Shortcut to close RPC Console (master...2019-12-gui-close-rpcconsole-shortcut) https://github.com/bitcoin/bitcoin/pull/17795 16:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:10 < bitcoin-git> [bitcoin] fanquake closed pull request #18252: gui: fix compiler warning in formatPingTime() (master...implicit-change-formatPingTime) https://github.com/bitcoin/bitcoin/pull/18252 16:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:18 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 16:19 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 16:22 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 16:23 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 16:28 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 16:29 -!- Highway61 [~Thunderbi@192.252.213.238] has quit [Ping timeout: 268 seconds] 16:33 -!- harrigan_ [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 16:35 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 16:35 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 16:36 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 240 seconds] 16:44 -!- pinheadmz [~matthewzi@45.83.89.68] has joined #bitcoin-core-dev 16:49 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:55 -!- codestr0m [~codestr0m@139.28.218.198] has joined #bitcoin-core-dev 16:57 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 16:58 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 16:58 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 16:58 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 16:59 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Quit: pinheadmz] 17:06 -!- anditto [~anditto@240d:1a:29:b700:940f:87df:b1e:52f7] has joined #bitcoin-core-dev 17:15 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Ping timeout: 240 seconds] 17:18 -!- alec [~alec@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 17:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:23 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:24 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:25 -!- pinheadmz [~matthewzi@45.83.89.68] has joined #bitcoin-core-dev 17:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 17:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 18:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 18:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:10 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 18:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:13 < bitcoin-git> [bitcoin] fanquake opened pull request #18264: [WIP] build: Remove Boost Chrono (master...dump_boost_chrono) https://github.com/bitcoin/bitcoin/pull/18264 18:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:14 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Quit: pinheadmz] 18:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 18:16 -!- Highway61 [~Thunderbi@192.252.213.238] has joined #bitcoin-core-dev 18:19 -!- Highway62 [~Thunderbi@208.131.139.133] has joined #bitcoin-core-dev 18:21 -!- Highway61 [~Thunderbi@192.252.213.238] has quit [Ping timeout: 260 seconds] 18:21 -!- Highway62 is now known as Highway61 18:22 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 18:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:26 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a71c34742c24...2492dc0068f8 18:26 < bitcoin-git> bitcoin/master fa8b602 MarcoFalke: doc: Merge release notes for 0.20.0 release 18:26 < bitcoin-git> bitcoin/master 2492dc0 fanquake: Merge #18259: doc: Merge release notes for 0.20.0 release 18:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:26 < bitcoin-git> [bitcoin] fanquake merged pull request #18259: doc: Merge release notes for 0.20.0 release (master...2003-docMergeRel) https://github.com/bitcoin/bitcoin/pull/18259 18:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:29 -!- pinheadmz [~matthewzi@45.83.89.68] has joined #bitcoin-core-dev 18:40 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:40 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Quit: pinheadmz] 18:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:46 -!- Highway61 [~Thunderbi@208.131.139.133] has quit [Quit: Highway61] 18:47 -!- Highway61 [~Thunderbi@208.131.139.133] has joined #bitcoin-core-dev 18:56 -!- Highway61 [~Thunderbi@208.131.139.133] has quit [Remote host closed the connection] 18:57 -!- Highway61 [~Thunderbi@208.131.139.133] has joined #bitcoin-core-dev 19:00 -!- codestr0m [~codestr0m@139.28.218.198] has quit [] 19:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 19:21 -!- tss1 [~tss@185.204.1.185] has joined #bitcoin-core-dev 19:28 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 20:00 -!- akionak [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev 20:00 -!- felixfoertsch23 [~felixfoer@92.117.39.73] has joined #bitcoin-core-dev 20:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:01 -!- felixfoertsch [~felixfoer@i6DFA6845.versanet.de] has quit [Ping timeout: 240 seconds] 20:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 20:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 20:19 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 20:25 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 20:30 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 20:35 -!- Highway61 [~Thunderbi@208.131.139.133] has quit [Ping timeout: 268 seconds] 21:06 < aj> kallewoof: *wave* 21:07 < kallewoof> hi :) 21:08 < kallewoof> If anyone has topics they wanna talk about, we could gather those and bring them up after the next PR review, assuming people are up for doing more. I'm not actually sure how #bitcoin-core-dev maintains meeting topic proposals tho. 21:09 < fanquake> kallewoof: I'ts pretty adhoc, but: https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a 21:11 < aj> kallewoof: so i saw signet on hi-pri and thought it'd be fun to discuss, but i see you posted about bip322/msg signing yesterday, so could do that instead? 21:12 < kallewoof> aj: to be honest, I'd love to focus on signet. the msg signing stuff is more a "is this really bad, and people just don't want to hurt my feelings" kind of stage 21:13 < aj> kallewoof: for me, msg signing is "this is cool, but none of the ideas seem quite like the right thing, so i dunno" 21:14 < kallewoof> yeah, that seems to be most people's opinion. i'm gonna let that ML post sit and focus on signet. after signet, i'll probably go and ultra-simplify the proposal to single-proof no-extensibility case. at least that gives us a starting point.. 21:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:15 < aj> ugh, clicking "xxx hidden items Load More" repeatedly is lame 21:15 < kallewoof> aj: that aside, yes, i'd love to discuss signet. I'd love to do a PR review ON signet, but either I wake up in the middle of the night to do both ends, or I find someone on EU/US-land willing to host the main one... 21:16 -!- pinheadmz [~matthewzi@45.83.89.68] has joined #bitcoin-core-dev 21:16 < aj> kallewoof: if you write up notes for it, i think it'd be pretty easy for someone else to run the actual meeting 21:17 < kallewoof> aj: Yeah and it oges in the wrong order too.. If I want to see the *latest* hidden comments I have to click on it untli the end... 21:17 < aj> kallewoof: might be complicated to do in a single meeting though? don't know 21:17 < aj> kallewoof: *EXACTLY* 21:17 < aj> https://github.com/sindresorhus/refined-github/issues/1892 -- javascript hackery to automate it, might be useful 21:19 < aj> kallewoof: so, was wondering where you were at with the common-genesis, diverge at block #1 idea? that's where the PR comments seem to trail off? 21:19 < gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub 21:19 < aj> dammit gribble 21:20 < kallewoof> aj: everyone seems to like the static genesis block idea, except for one or two people, who thinks it will make testing multi-chain stuff harder. I honestly just wanted to get *something* merged, even if it is patched later, so I was hesitant to change anything but maybe I should go ahead and do that. 21:21 < aj> https://github.com/lightningnetwork/lightning-rfc/blob/master/00-introduction.md#glossary-and-terminology-guide re: jtimon's comment about lightning wanting different chain_hash's, bolt-00 says it's only *usually* the genesis hash, so that seems fine 21:21 < kallewoof> I think multi chain testing can be done by simply changing the genesis hash for the other chain(s) manually since you'llbe doing other stuff anyway. 21:21 < kallewoof> right. so you agree with the static hash idea? 21:22 < aj> well, common genesis means you can grind it manually which seems like a simplification? 21:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 21:23 < kallewoof> the one icky thing is if a light client accidentally connects to a different signet with longer chain. since they won't validate the block sig, they will (I think) wipe out their whole chain and replace with the other one. but it looks increasingly like we'll msotly have a single signet running for the most time, so probably not a big deal 21:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 21:23 < kallewoof> aj: yeah. the signet genesisnonce goes away which is great. 21:26 < aj> kallewoof: well pchMessageStart = sha256d(sn_chal) fixes the accidentally one, and light clients that don't check signet sigs and aren't just connected to a trusted node are trivially attackable no matter what, so that seems fine? 21:26 < kallewoof> Yeah, makes sense 21:32 -!- anditto [~anditto@240d:1a:29:b700:940f:87df:b1e:52f7] has quit [Remote host closed the connection] 21:32 -!- anditto [~anditto@240d:1a:29:b700:940f:87df:b1e:52f7] has joined #bitcoin-core-dev 21:37 -!- anditto [~anditto@240d:1a:29:b700:940f:87df:b1e:52f7] has quit [Ping timeout: 256 seconds] 21:38 < aj> oh, what's with enforcescript vs blockscript for reorg mode? 21:40 < kallewoof> basically, you can have the main signet require a 2-of-2 and then you can have a "fake" signet requiring a 1-of-2 where the keys are the same.. if you accept the 1-of-2 case (enforce) you can get reorgs every X blocks, whereas the 2-of-2 chain will never (or rarely) reorg 21:41 < aj> so you'd replace 2 a b 2 checkmultisig with... "depth dup 1 GT VERIFY a b 2 checkmultisig" ? 21:42 < kallewoof> actually hm... i think it would have to do something tricky to allow both, yeah. i hadn't thought about that. I think BlueMatt and/or gmax were talking about this idea on the mailing list before. 21:42 < kallewoof> Will have to find that again 21:44 < aj> oh, DUP 2 B DUP 2 CHECKMULTISIG would probably do 21:44 < aj> what? no it wouldn't grr 21:45 < aj> maybe "verificationprogress" should be a mainnet only thing? 21:46 < kallewoof> 2-of-2 case: 2 2 cms; 1-or-2-of-2 case: depth 8 equal if <2 of 2> else <1 of 2> endif... i think? 21:47 < kallewoof> that makes sense to me (verificationprogress mainnet only), yeah 21:47 < aj> depth 3 equal -- you've only got the 2 sigs and the null on the stack at that point 21:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 21:48 < kallewoof> oh, right 21:48 < aj> so "depth 2 equal if 2 else 1 endif A B 2 cms" 21:48 < aj> 3 equal 21:48 < aj> grr 21:49 < kallewoof> looks good yeah! 21:49 < aj> "depth 2 equal 1add A B 2 cms" even :) 21:49 < aj> oh ffs, depth 3 equal 21:50 < kallewoof> lol 21:50 < aj> so light clients will see all the reorgs this way i guess 21:51 < aj> if they happen to connect to a reorg aware node anyway 21:52 < kallewoof> right. i guess the big problem is, how do you prevent nodes from banning each other when they use different enforcements.. 21:52 < aj> oh, eww, good point 21:53 < aj> i don't think that approach works with taproot either, you could change the sPK, but without ANYPREVOUT every sig commits to the sPK anyway 21:55 < aj> reserve one of the bip320 miner-roll versionbits to signal "this block will get reorged out" instead maybe? 21:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:57 < bitcoin-git> [bitcoin] kallewoof opened pull request #18265: build: add data.h dependency to raw files (master...2003-makefile-bench-data) https://github.com/bitcoin/bitcoin/pull/18265 21:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:58 < kallewoof> aj: I think it would require some logic in the block validation where it silently rejects without punishing when the solution contains the same keys somehow. 21:59 < kallewoof> Perhaps I shoudl remove the enforcescript flag until this all has been sorted out. It's not really needed for signet v1 I think. 21:59 < aj> kallewoof: could set the error as BLOCK_RECENT_CONSENSUS_CHANGE in theory 21:59 -!- soju [uid403160@gateway/web/irccloud.com/x-dsbyvqasqhkaetyq] has joined #bitcoin-core-dev 21:59 < kallewoof> ohh... true. 22:00 -!- tss1 [~tss@185.204.1.185] has quit [] 22:06 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Quit: pinheadmz] 22:11 < kallewoof> with schnorr, it would probably be "if sigs = 0, block is REALLY invalid and peer should be punished; if 0 < sigs < threshold, do BLOCK_RECENT_CONSENSUS_CHANGE; if sigs >= threshold, accept. 22:11 < kallewoof> I mean, wit script v1 22:14 -!- jarthur [~jarthur@2605:6000:1019:4971:58d:3f9f:711b:8742] has joined #bitcoin-core-dev 22:15 < aj> haven't looked at the contrib/signet/ bits, but the other commits all look respectable fwiw 22:18 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Ping timeout: 240 seconds] 22:19 < aj> hmm, i guess with schnorr/tapscript you'd need to work out what you're signing, since there's not really a transaction to apply the specced signature digest algo to, and then we're back to the signed-message debate 22:20 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev 22:21 -!- Inigo_Montoya1 [~Inigo_Mon@185.204.1.185] has joined #bitcoin-core-dev 22:22 -!- anditto [~anditto@240d:1a:29:b700:940f:87df:b1e:52f7] has joined #bitcoin-core-dev 22:37 < kallewoof> i haven't really given schnorr/tap* a lot of thought wrt signet. other than "signet should help with testing taproot" 22:38 < kallewoof> I made a PR to the signet BIP, describing the genesis block and message start: https://github.com/bitcoin/bips/pull/900 22:39 < kallewoof> aj: thanks for reviewing btw. I am probably going to strip that down to MVP and split into multiple PR's. I think I was a bit optimistic when I hoped it could be reviewed in its current state.. 22:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 22:46 < aj> kallewoof: sounds great 22:50 -!- Kiminuo [~mix@141.98.103.76] has quit [Ping timeout: 265 seconds] 23:01 -!- Kiminuo [~mix@141.98.103.180] has joined #bitcoin-core-dev 23:05 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 23:05 -!- tsujp [~tsujp@60-241-185-101.tpgi.com.au] has joined #bitcoin-core-dev 23:11 -!- anditto [~anditto@240d:1a:29:b700:940f:87df:b1e:52f7] has quit [] 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:16 < bitcoin-git> [bitcoin] kallewoof opened pull request #18267: BIP-325: Signet [consensus] (master...2003-signet-consensus) https://github.com/bitcoin/bitcoin/pull/18267 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:16 < kallewoof> 406 lines. Still a lot, but better than 1.2k... 23:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 23:29 -!- jarthur [~jarthur@2605:6000:1019:4971:58d:3f9f:711b:8742] has quit [Quit: good night] 23:31 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 23:33 -!- tsujp [~tsujp@60-241-185-101.tpgi.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev --- Log closed Thu Mar 05 00:00:12 2020