--- Log opened Thu Mar 05 00:00:12 2020
00:03 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
00:09 < kallewoof> Managed to get it down to +358 -26. Hopefully this is reviewable.
00:15 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
00:17 -!- vasild_ is now known as vasild
00:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]
00:26 -!- marcoagner [~user@dsl-58-207.bl26.telepac.pt] has joined #bitcoin-core-dev
00:37 -!- tsujp [~tsujp@60-241-185-101.tpgi.com.au] has joined #bitcoin-core-dev
00:38 -!- soju [uid403160@gateway/web/irccloud.com/x-dsbyvqasqhkaetyq] has quit [Quit: Connection closed for inactivity]
00:55 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Ping timeout: 256 seconds]
00:56 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
00:59 -!- mantoshelis [~mmatuzas@2001:1ab8:1001:a010:127b:44ff:fef0:334b] has joined #bitcoin-core-dev
00:59 < mantoshelis> Hello, can someone share testnet bitcoins with me? My address is: my5rQeSvwpjF4ssSBrD5PcGx3hRakXCHgF 
01:00 -!- Inigo_Montoya1 [~Inigo_Mon@185.204.1.185] has quit []
01:04 < provoostenator> mantoshelis: done
01:05 < mantoshelis> Thanks a lot
01:06 < mantoshelis> If there is a possibility to get more tBTC please share with me up to 100. It is for testing purposes, especially load testing.
01:07 < provoostenator> Why not use regtest for load testing?
01:07 -!- Netsplit *.net <-> *.split quits: thaumavorio, mael-rolland[m], commavir, real_or_random, jonatack, _flow_, earlz, kljasdfvv, wumpus, Processus42,  (+3 more, use /NETSPLIT to show all of them)
01:07 < provoostenator> Or Signet
01:07 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:09 < provoostenator> (regtest is great if you test inside your own network, (a custom) signet is more suitable if you need to interact with others.
01:09 -!- Netsplit over, joins: oguzkoroglu_
01:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:16 < mantoshelis> We created a custom fork of bitcoinj to support database based wallet so we need to test it with interraction with others on testnet.
01:16 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
01:17 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
01:20 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev
01:21 -!- Morgon1 [~Morgon@184.75.223.219] has joined #bitcoin-core-dev
01:22 < provoostenator> mantoshelis: testnet is pretty terrible in general. It might be worth looking into adding Signet support to BitcoinJ. Should be pretty easy: https://en.bitcoin.it/wiki/Signet
01:25 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
01:31 < mantoshelis> It's good idea but unfortunately we don't have enough time resources to implement this. As a result, we choose to perform tests on official Bitcoin testnet. :(
01:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
01:35 -!- jnewbery_ [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev
01:35 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
01:35 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev
01:38 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
01:38 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection]
01:38 -!- jnewbery [~john@4.53.92.114] has quit [Ping timeout: 248 seconds]
01:43 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev
01:43 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
01:43 -!- mael-rolland[m] [mael-rolla@gateway/shell/matrix.org/x-pljpvfzlmzotalil] has joined #bitcoin-core-dev
01:43 -!- Henry151 [~bishop@ns3007530.ip-151-80-44.eu] has joined #bitcoin-core-dev
01:43 -!- kljasdfvv [~flack@p200300D46F149D00846911E14503A3BA.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:43 -!- thaumavorio [~thaumavor@thaumavor.io] has joined #bitcoin-core-dev
01:43 -!- real_or_random [~real_or_r@173.249.7.254] has joined #bitcoin-core-dev
01:43 -!- commavir [~vir@23.226.237.192] has joined #bitcoin-core-dev
01:43 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev
01:43 -!- earlz [~earlz@earlz.net] has joined #bitcoin-core-dev
01:43 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
01:43 -!- Processus42 [~leo@unaffiliated/processus42] has joined #bitcoin-core-dev
01:56 < goatpig> hello
01:57 < goatpig> is there an equivelant to sendrawtransactions to broadcast a batch of transactions through the RPC?
01:58 < jonatack> kallewoof: could be a good PR for the review club, want to host?
01:59 < kallewoof> jonatack: I would love to do that, but it's in the middle of the night for me. :o Would you be up for doing it?
01:59 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev
01:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:01 < jonatack> oh that's right. sure, why not.
02:01 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection]
02:03 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
02:03 -!- jnewbery_ [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Read error: Connection reset by peer]
02:08 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev
02:09 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
02:09 -!- jnewbery [~john@4.53.92.114] has joined #bitcoin-core-dev
02:11 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection]
02:15 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:24 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev
02:25 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection]
02:26 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev
02:32 < kallewoof> nice! :) I'll see about making notes and such
02:34 < provoostenator> I don't know if this is safe, but it's awesome (syntax highlight for git diffs): https://github.com/dandavison/delta
02:43 < provoostenator> goatpig: there isn't. Transactions are only considered individually anyway, see #14895.
02:43 < gribble> https://github.com/bitcoin/bitcoin/issues/14895 | Package relay design questions · Issue #14895 · bitcoin/bitcoin · GitHub
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:43 < bitcoin-git> [bitcoin] docallag opened pull request #18268: rpcdoc: Remove redundant type from description #18258 (master...#18258_rpc_doc_type_cleanup) https://github.com/bitcoin/bitcoin/pull/18268
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:02 -!- hex17or [~hex17or@HSI-KBW-46-223-238-38.hsi.kabel-badenwuerttemberg.de] has quit [Ping timeout: 260 seconds]
03:03 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
03:03 -!- Jason5Abbott [~Jason5Abb@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:06 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:14 -!- hex17or [~hex17or@HSI-KBW-46-223-238-38.hsi.kabel-badenwuerttemberg.de] has joined #bitcoin-core-dev
03:31 -!- Jason5Abbott [~Jason5Abb@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds]
03:32 < goatpig> @provoostenator: thanks
03:43 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection]
03:44 -!- someone235 [uid419897@gateway/web/irccloud.com/x-quxwdfigjpujzgby] has joined #bitcoin-core-dev
03:46 < someone235> Hi, did someone benchmark what is the validation time of a full non-compact block?
03:46 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has joined #bitcoin-core-dev
03:47 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has quit [Client Quit]
03:56 < jonatack> kallewoof: notes would be great!
03:58 < jonatack> provoostenator: interesting
04:00 -!- Morgon1 [~Morgon@184.75.223.219] has quit []
04:11 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev
04:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:14 < bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/cbc32d67dc0c...d0601e67f151
04:14 < bitcoin-git> bitcoin/master 08b9926 Jon Atack: test: add feature_asmap functional tests
04:14 < bitcoin-git> bitcoin/master fbe9b02 Jon Atack: config: use default value in -asmap config
04:14 < bitcoin-git> bitcoin/master 81c38a2 Jon Atack: config: enable passing -asmap an absolute file path
04:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:14 < bitcoin-git> [bitcoin] fanquake merged pull request #17812: config, net, test: asmap feature refinements and functional tests (master...feature-asmap) https://github.com/bitcoin/bitcoin/pull/17812
04:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:21 -!- neutraltc [~neutraltc@185.189.112.19] has joined #bitcoin-core-dev
04:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:27 -!- filchef [~filchef@212.104.97.177] has quit [Read error: Connection reset by peer]
04:40 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection]
04:41 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
04:45 < stevenroose> Q about relaying: If you've broadcasted a tx that is not relayed by standard nodes. But a few of your peers do accept/relay it (even though all their peers won't accept it so their "relay" is futile). So this means that that tx is in the mempool of those few nodes. Now lets say after some time, more nodes have been configured to accept this kind of tx; how can I get my earlier tx to
04:45 < stevenroose> broadcast again without personally connecting to new nodes?
04:45 < stevenroose> I.e. can I get those few peers that know about the tx to re-relay it somehow?
04:46 < stevenroose> IIRC nodes don't do any effort to make txs in their mempool discoverable by peers. Like mempool reconciliation, that doesn't happen (yet?), right?
04:47 -!- Highway61 [~Thunderbi@208.131.139.133] has joined #bitcoin-core-dev
04:51 < goatpig> stevenroose: my experience with the p2p interface is that you'll get the inv for a tx only once, and a node you connected to will not try to inv its mempool to you, so basically you are the only who'd know to rebroadcast your tx to other nodes
04:51 < goatpig> other nodes on the network will not do this for you
04:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds]
04:52 < stevenroose> Yeah but if you rebroadcast it, your peers that already accepted the tx previous time won't relay it again, right?
04:53 < goatpig> no, they won't even send you the getdata packet to get the tx body
04:53 < stevenroose> Even though at this time, *their* peers might accept it while they did not the time before that.
04:53 < stevenroose> Kay, yeah that's what I thought.
04:55 < goatpig> i dont think there's any mechanism for a node to keep track of its peers mempool filters either
04:55 < stevenroose> This is quite an annoring aspect of trying to make certain tx standard again or f.e. lowering the minrelayfee. It only makes sense if a bunch of nodes do it together. If say 20% of the network accept lower-fee txs, there's a good chance your tx won't reach those 20% ever, even if after some time ,that 20% increases
04:56 < goatpig> if you expect your tx to be below the network's relay floor, you're best bet is to connect to known miners
04:56 < stevenroose> goatpig: no of course there is not, and I do agree it doesn't make sense to even assume their mempool filter might have changed in any way, so it's correct for them to not rebroadcast.
04:56 < stevenroose> goatpig: yeah true
04:57 < goatpig> you can setup strategies to know if your tx has propagated if you're willing to run several nodes
04:58 < stevenroose> goatpig: hmm, I just notice that peers actually do communicate minfeefilters: "minfeefilter": 1e-06. But I'm sure there's no code that detects changes in that field.
04:58 < stevenroose> Anyway, thanks :) Got my suspicion confirmed.
04:59 -!- kim58 [3b1b6a93@59.27.106.147] has joined #bitcoin-core-dev
04:59 < goatpig> that's to filter what they ought to inv to the peer, i doubt there's a feedback loop to rebroadcast existing mempool entries
05:19 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection]
05:20 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev
05:24 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
05:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:34 < bitcoin-git> [bitcoin] dangershony closed pull request #18223: Add new filter type v0 for segwit only Scripts to blockfilterindex (master...nutrino-p2wpkh-filters) https://github.com/bitcoin/bitcoin/pull/18223
05:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:54 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:55 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
05:55 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
05:59 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection]
05:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
05:59 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
06:02 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
06:03 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
06:06 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has joined #bitcoin-core-dev
06:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds]
06:17 < instagibbs> stevenroose, amiti has a PR that would result in unstuckness in these kind of situations. 
06:18 < instagibbs> changing feefilter is done on restart for Core so would only be announced after re-connect
06:18 < instagibbs> but by then I don't think you'll send the INV
06:19 -!- molly [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]
06:25 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:26 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 240 seconds]
06:28 < instagibbs> 10 days until feature freeze, get those reviews in folks
06:32 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev
06:37 < stevenroose> instagibbs: PR?
06:41 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Ping timeout: 255 seconds]
06:41 < instagibbs> https://github.com/bitcoin/bitcoin/pull/16698
06:42 < instagibbs> it basically makes any topology more robust for non-standard-ish transactions
06:42 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
06:48 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
06:49 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
06:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds]
06:59 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has quit [Quit: Sleep mode]
07:00 -!- neutraltc [~neutraltc@185.189.112.19] has quit []
07:01 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has joined #bitcoin-core-dev
07:06 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds]
07:09 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Ping timeout: 255 seconds]
07:12 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
07:19 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:21 -!- Y_Ichiro [~Y_Ichiro@195.206.183.79] has joined #bitcoin-core-dev
07:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
07:29 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:31 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 240 seconds]
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:34 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d0601e67f151...a2a77ba34f71
07:34 < bitcoin-git> bitcoin/master 2a95c7c Emil Engler: ci: Check for submodules
07:34 < bitcoin-git> bitcoin/master a2a77ba Wladimir J. van der Laan: Merge #18056: ci: Check for submodules
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:34 < bitcoin-git> [bitcoin] laanwj merged pull request #18056: ci: Check for submodules (master...2020-02-submodule-linter-check) https://github.com/bitcoin/bitcoin/pull/18056
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:38 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
07:38 < amiti> stevenroose: lmk if you have any thoughts / questions. I'm also interested in hearing about your angle / use cases. feel free to DM me :) 
07:38 < amiti> instagibbs: thanks for sharing 
07:40 -!- promag [~promag@92.250.100.33] has joined #bitcoin-core-dev
07:53 -!- Kiminuo [~mix@141.98.103.180] has quit [Ping timeout: 258 seconds]
07:58 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has quit [Quit: Sleep mode]
08:01 -!- Kiminuo [~mix@141.98.103.94] has joined #bitcoin-core-dev
08:09 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has joined #bitcoin-core-dev
08:09 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has quit [Client Quit]
08:10 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has joined #bitcoin-core-dev
08:20 -!- captjakk_ [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
08:20 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:21 < harding> stevenroose: what do you mean "I'm sure there's no code that detects changes in that [minfeefilter] field"?  Are you familar with BIP133?  The whole point of that is to allow peers to detect changes to a peer's minfeefilter and avoid relaying transactions to a peer that won't accept them.
08:22 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 268 seconds]
08:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
08:25 < sipa> the feefilter is also re-sent from time to time, i think
08:25 < sipa> if the minfeerate of the receiver mempool changes
08:29 -!- captjakk_ [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
08:29 -!- kim58 [3b1b6a93@59.27.106.147] has quit [Ping timeout: 260 seconds]
08:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
08:34 -!- Aaronvan_ is now known as AaronvanW
08:39 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev
08:45 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:47 -!- harrigan_ [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has left #bitcoin-core-dev []
08:50 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:53 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 240 seconds]
09:13 < stevenroose> harding: well that's used generally right after the handshake, right?
09:14 < stevenroose> What I mean was that a node that sees the minfee from a peer go from 10 to 20 won't relay all mempool txs it has between 10 and 20.
09:15 < stevenroose> Unless I'm mistaken. But IIRC the minfee is more a static thing that just gets updated when the message is received and checked only on newly received txs.
09:16 < instagibbs> sipa, ah of course it does change over the lifecycle of a node
09:16 < harding> I think you mean 20 to 10, but yeah, AFAIK mempool txes that were not relayed previously won't be relayed just because the min rate dropped.
09:17 < instagibbs> again, rebroadcast being reworked would fundamentally fix these edge cases
09:17 -!- pinheadmz [~matthewzi@45.83.89.68] has joined #bitcoin-core-dev
09:18 < harding> stevenroose: my point was that feefilter is sent when a node changes its min, not just once during initial negotiation.
09:18 < harding> (In theory; it's not like we've had a  full mempool in two years to demonstrate that.  :-)
09:18 < stevenroose> harding: yeah I realize that. My statement "it doesn't detect changes" should have been "doesn't act retroactively on txs when it detects a change". Sorry
09:19 < stevenroose> harding: ah yeah 20 to 10 lol
09:19 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
09:27 -!- promag [~promag@92.250.100.33] has quit [Remote host closed the connection]
09:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds]
09:31 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Quit: pinheadmz]
09:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:49 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:50 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:52 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
09:54 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
09:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
09:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
09:58 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:00 -!- Y_Ichiro [~Y_Ichiro@195.206.183.79] has quit []
10:04 -!- tsujp [~tsujp@60-241-185-101.tpgi.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:10 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has quit [Quit: Sleep mode]
10:10 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:14 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
10:21 -!- gholms1 [~gholms@185.204.1.185] has joined #bitcoin-core-dev
10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a2a77ba34f71...96488e678479
10:41 < bitcoin-git> bitcoin/master 2455aa5 Gloria Zhao: [rpc] changed MineBlocksOnDemand to IsMockableChain
10:41 < bitcoin-git> bitcoin/master 96488e6 MarcoFalke: Merge #18263: rpc: change setmocktime check to use IsMockableChain
10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:41 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18263: rpc: change setmocktime check to use IsMockableChain  (master...rpc-setmocktime-check) https://github.com/bitcoin/bitcoin/pull/18263
10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:44 < moneyball> #proposedmeetingtopic CoreDev SF
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:51 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/96488e678479...aaf09469fb2c
10:51 < bitcoin-git> bitcoin/master b054c46 Ben Woosley: refactor: Convert ping time from double to int64_t
10:51 < bitcoin-git> bitcoin/master e6fc63e Ben Woosley: refactor: Convert min ping time from double to int64_t
10:51 < bitcoin-git> bitcoin/master 7a810b1 Ben Woosley: refactor: Convert ping wait time from double to int64_t
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18260: refactor: Fix implicit value conversion in  formatPingTime (master...2020-03-ping-time) https://github.com/bitcoin/bitcoin/pull/18260
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:52 -!- Highway61 [~Thunderbi@208.131.139.133] has quit [Remote host closed the connection]
10:52 < jonasschnelli> fanquake: I saw that your tx for the coredev.tech refund has been final-signed and broacasted: 31ee555fc1f92fc0ef834fb49b8087e3f33a44efa47b1fc5ff8a3c920a48b783
10:52 < jonasschnelli> omg!
10:53 -!- lightlike [~lightlike@p200300C7EF140100F849411C4B2846C5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
10:54 -!- Highway61 [~Thunderbi@208.131.139.133] has joined #bitcoin-core-dev
10:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:56 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/aaf09469fb2c...727857d12d04
10:56 < bitcoin-git> bitcoin/master 3ca574c Pieter Wuille: Convert CCompactSize to proper formatter
10:56 < bitcoin-git> bitcoin/master 56dd9f0 Russell Yanofsky: Make VectorFormatter support stateful formatters
10:56 < bitcoin-git> bitcoin/master 1063339 Russell Yanofsky: Add DifferenceFormatter
10:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:57 < bitcoin-git> [bitcoin] laanwj merged pull request #18112: Serialization improvements step 5 (blockencodings) (master...202002_noncastserial_5) https://github.com/bitcoin/bitcoin/pull/18112
10:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
10:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Mar  5 19:00:13 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
11:00 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
11:00 < emilengler> hi
11:00 < kanzure> hi
11:00 < elichai2> Hi
11:00 < jonasschnelli> hi
11:00 < sipsorcery> hi
11:00 < hebasto> hi
11:00 < jkczyz> hi
11:00 < jonatack> hi
11:01 < moneyball> hi
11:01 < wumpus> one proposed meeting topic in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt : Coredev SF (moneyball)
11:02 < luke-jr> hi
11:02 < wumpus> PSA: 0.19.1 has been tagged, please gitian build if you haven't yet :)
11:03 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-fliqnewyacvxaztl] has quit [Quit: Updating details, brb]
11:03 < wumpus> the 0.20.0 feature freeze is in roughly a week, see https://github.com/bitcoin/bitcoin/issues/17432, I think it makes sense to focus review on the feature PRs that have a chance to still make it in
11:03 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-plguiblqaomplirx] has joined #bitcoin-core-dev
11:04 < fjahr> hi
11:04 < nehan_> hi
11:04 < wumpus> there's a few PRs tagged for 0.20, but this list likely needs cleaning up: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.20.0
11:04 < wumpus> for example, I don't think the rust stuff is going to make 0.20, unfortunately
11:04 < elichai2> Where are we stuck in regards to the rust stuff? 
11:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:05 < elichai2> I'd really like to push it for 0.21
11:05 < wumpus> I'm not entirely sure, but it's a bad idea to merge it last minute before a relase
11:05 < wumpus> agree
11:05 < wumpus> lack of ACKs I suppose
11:06 < wumpus> does anyone have suggestions for things that should have a 0.20 tag but doesn't?
11:06 < emilengler> Maybe #17636
11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/17636 | qt: Add -guisettingsdir option by emilengler · Pull Request #17636 · bitcoin/bitcoin · GitHub
11:07 < luke-jr> wumpus: still a Concept NACK on any rust stuff..
11:07 < wumpus> some of the things currently on high priority for review, for example
11:08 < ariard> elichai2: IIRC lack of review by people understanding both Rust and code affected but people would like to raise the subject at coming physical meetup
11:08 < luke-jr> elichai2: still not practical to securely bootstrap Rust, and it has ABI issues
11:08 < wumpus> no, I don't think any of the features in https://github.com/bitcoin/bitcoin/projects/8 's blockers will be ready for 0.20
11:09 < elichai2> ariard: k, will talk with people privately about it 
11:09 < jonasschnelli> on 17646, would be good to get ryanofsky's ack
11:09 < wumpus> luke-jr: rust will not be required for anything necessary, it will remain optional
11:09 < kanzure> ariard: i'll add it to the topic reminder list
11:09 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
11:09 < jonasschnelli> *17636
11:09 < wumpus> but not the time to discuss that now
11:10 < luke-jr> started 0.19.1 PPA builds
11:11 < jonatack> wrt blockers, #16411 may have been superseded by #18267
11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/18267 | BIP-325: Signet [consensus] by kallewoof · Pull Request #18267 · bitcoin/bitcoin · GitHub
11:12 < wumpus> jonatack: ok, will replace it
11:13 < jeremyrubin> hi
11:13 < jnewbery> hi
11:13 < luke-jr> might be nice to get #15987 in
11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/15987 | Wallet, GUI: Warn when sending to already-used Bitcoin addresses by luke-jr · Pull Request #15987 · bitcoin/bitcoin · GitHub
11:14 < luke-jr> #15600 seems to be of interest (we have a IMO-bogus CVE assigned about it), and very simple
11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/15600 | lockedpool: When possible, use madvise to avoid including sensitive information in core dumps by luke-jr · Pull Request #15600 · bitcoin/bitcoin · GitHub
11:15 < wumpus> adding 0.20 milestone to those, hopefully they can get enough review in time
11:16 < luke-jr> shoot, the first one needs rebasing again - will try to get to that later today
11:18 < wumpus> I think that concludes the 0.20.0 / high priority for review topic
11:18 < wumpus> #topic Coredev SF (moneyball)
11:19 < moneyball> We need to discuss cancelling/postponing CoreDev SF. There are numerous reasons why. There is risk of getting stuck / quarantined and not be able to return home in a timely fashion. There is of course a real health risk and the logic to reduce the speed of spreading coronavirus. And there is the actions of many other organizations such as SF and California declaring states of emergencies, with Square, 
11:19 < moneyball> Coinbase, Stripe, Microsoft, Twitter all strongly encouraging working from home. Lastly, there is a high probability Bitcoin 2020 will be postponed.
11:19 < moneyball> What do others think? Is there an argument to be made to continue holding it?
11:19 < moneyball> Would there be interest in a remote/virtual CoreDev? IMO the biggest value of the CoreDev _is_ the f2f interactions, so we'd be losing out on that. However, it may be interesting to experiment with a 1 day virtual format and see how it goes. Maybe we could get Udi to do a VR thing(?!).
11:20 < kanzure> when will we know about bitcoin2020?
11:20 < luke-jr> is there free software VR stuff?
11:20 < BlueMatt> it sounds like bitcoin2020 is going ahead
11:20 < BlueMatt> unless the city of sf tells them they have to cancel, that is
11:20 < jeremyrubin> i heard recent rumour it's cancelled
11:20 < luke-jr> O.O
11:21 < BlueMatt> they were pretty adament it was going ahead, like, three days ago, so dunno about rumors
11:21 < jeremyrubin> Or that they at least advised some people to  delay booking travel
11:21 < jeremyrubin> As of today
11:21 < jeremyrubin> I saw their message in the telegram a few days ago
11:21 < moneyball> For the purpose of this discussion, let's say it is a very high probability that Bitcoin 2020 conference may be postponed.
11:22 < kanzure> my only concern with coredev.tech would be if we have nearly ~everyone which is ungood for the usual reasons
11:23 < achow101> I think some people already said they weren't going
11:23 < wumpus> I don't think cancelling it is a bad idea, there's a large chance things will become more complicated in the next weeks, at least I'm not going to make the trip.
11:23 < luke-jr> kanzure: I wasn't going to make it regardless
11:23 < jonasschnelli> Agree with wumpus. I'm also not tthere.
11:23 < luke-jr> but even still, a majority of devs getting badly ill could be a bad idea :p
11:23 < jonatack> i was keen to go but atm it's a no-go... i'd be for holding off until we more clarity on the situation
11:23 < kanzure> luke-jr: are you prepared to continue the project without us? (kidding)
11:24 < BlueMatt> right, i guess the question is - things may be completely fine in two weeks, or ca will be telling everyone to not go outside. and we need to decide ~now for travel booking
11:24 < kanzure> are these things even refundable... i already booked.
11:24  * BlueMatt will be in sf either way
11:24 < luke-jr> kanzure: Core's current policy doesn't make it possible for a one-man show :P
11:24 < wumpus> could still organise something for the people in SF I guess
11:24 < BlueMatt> kanzure: they are not (yet), though some airlines are starting to change, at least alaska/virgin is refunding anything you want to cancel iiuc
11:25 < luke-jr> BlueMatt: considering the ridiculous lack of preventative measures by the US government, I expect things to only get worse in the coming weeks
11:25 < kanzure> that's helpful
11:25 < BlueMatt> I would not hold your breath if you're booked on the US Big Three airlines, though
11:26 < BlueMatt> sounds like cancel/postpone/anyone whos in sf anyway can get a drink through their face masks. any nacks?
11:26 < jnewbery> moneyball: I agree that the sensible thing to do is cancel if Bitcoin2020 is cancelled. I'm personally not interested in a remote/virtual coredev. I think it's very difficult to make it fair/convenient for people in different timezones. Much better to just reschedule a coredev in three-six months time.
11:26 < elichai2> FWIW even though no one from Israel is coming the official Israel health minister guidelines from a few days ago are not to fly anywhere if it's not an emergency and if you came from a conference you must be in 14 days isolation, 
11:26 < elichai2> So I can expect other countries to start doing the same soon enough 
11:27 < wumpus> yes, I very much doubt this will be cleared up in two weeks
11:27 < achow101> I think we'd have significantly reduced attendance so it probably isn't as useful
11:27 < jonasschnelli> I doubt it is cleared up in months. :)
11:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:27 < luke-jr> jonasschnelli: ☹ I'm reverse-quarantined until it's cleared up
11:27 < BlueMatt> wumpus: especially not in the us. its spreading fast in some areas and no testing means no followup/monitoring. its just getting started here :/
11:28 < jeremyrubin> kanzure: looking at what people submitted as topics to cover do you think there might be a useful remote agenda? Maybe we can just do daily morning/afternoon IRC meetings for a few days
11:29 < kanzure> jeremyrubin: sure... maybe zoom for presentations, otherwise just hang out on irc?
11:29 < kanzure> will pm you the link
11:29 < luke-jr> Zoom appears to work in free software HTML5 browsers if you jump through some hoops FWIW
11:30 < wumpus> trying to do something remote sounds good to me, would be good to coordinate more around the 0.20.0 feature freeze and release anyway--haven't ever used VR so can't comment on that
11:30 < kanzure> OK, well, if we want a remote event then let's decide (doesn't have to be right now) whether we just want people to commit to being online, or if we want to schedule presentations / specific discussions on a conference video tool
11:30 < kanzure> s/conference/meeting
11:32 < kanzure> no whiteboards though... hm.
11:32 < luke-jr> wumpus: maybe take #15987 out of 0.20 - just remembered I was waiting on #18192 to re-do it without the bloom stuff
11:32 < gribble> https://github.com/bitcoin/bitcoin/issues/15987 | Wallet, GUI: Warn when sending to already-used Bitcoin addresses by luke-jr · Pull Request #15987 · bitcoin/bitcoin · GitHub
11:32 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
11:33 < moneyball> schmidty and i can send out a survey with some options. if the majority want to do virtual we can help organize. if just a few, i'd suggest self-organizing.
11:33 < kanzure> anyway, it would be helpful if coredev.tech can send out an email once someone learns about bitcoin2020's decision
11:33 < luke-jr> kanzure: screen sharing in Zoom as whiteboarD?
11:33 < wumpus> luke-jr: ok
11:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
11:33 < moneyball> yes i will send an email, and i will include a survey for people to indicate preferences for doing virtual or nothing at all
11:34 < achow101> moneyball: ack
11:34 < jeremyrubin> I'd do a virtual thing but I don't own any vr hardware -- do most devs these days?
11:34 < wumpus> moneyball: thanks!
11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:34 < bitcoin-git> [bitcoin] luke-jr closed pull request #15987: Wallet, GUI: Warn when sending to already-used Bitcoin addresses (master...wallet_no_reuse) https://github.com/bitcoin/bitcoin/pull/15987
11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:34 < luke-jr> moneyball: nothing | video conf | VR
11:35 < kanzure> luke-jr: or... blockchain?
11:35 < luke-jr> jeremyrubin: I suspect you're not alone; video conf seems more logical IMO anyway
11:35 < moneyball> i mean i joined udi's VR thing without a headset. 
11:35 < moneyball> i'm not advocating VR, just saying a headset isn't needed to participate
11:35 < achow101> jeremyrubin: I don't, but valve index is supposed to be back in stock Monday. I'm planning on getting one of those
11:36 < luke-jr> moneyball: it is if it's anything liek Sword Art Online 8)
11:37 < sipa> hi!
11:37 < wumpus> anything else to discuss today?
11:38 < sipa> fwiw, i'll be in the sf area for coredev, so happy to meet up with whoever is there
11:39 < wumpus> #endmeeting
11:39 < lightningbot> Meeting ended Thu Mar  5 19:39:52 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:39 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-05-19.00.html
11:39 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-05-19.00.txt
11:39 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-05-19.00.log.html
11:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:45 < kanzure>  /win 5
11:45 < kanzure> whoops.
11:47 -!- vasild_ is now known as vasild
11:48 < hebasto> devs who are interested in GUI internationalization, please review #16224, the first part of which is already in 0.19
11:48 < gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub
11:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:48 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16762: Rust-based Backup over-REST block downloader (master...2019-08-rusty-block-download) https://github.com/bitcoin/bitcoin/pull/16762
11:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:48 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16834: Fetch Headers over DNS (master...2019-09-rusty-dns-headers) https://github.com/bitcoin/bitcoin/pull/16834
11:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:49 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #17376: Add Parallel P2P Client in Rust (master...2019-10-rusty-p2p) https://github.com/bitcoin/bitcoin/pull/17376
11:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:50 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
11:54 < wumpus> BlueMatt: sorry to see you closing the rust PRs due to lack of interest
11:56 < BlueMatt> eh, happens. not everything makes it through
11:56 < BlueMatt> and there was a definite lack of interest on those.
12:02 < luke-jr> BlueMatt: there's been some interest in keeping the PPA using the bitcoin/bitcoin URI; can you add me to the org?
12:02 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
12:04 < BlueMatt> luke-jr: if someone wants to replace the ppa with something that checks gitian signatures and downloads official binaries, as I've been saying needs to happen ~forever, then maybe its worth maintinaing again. but no one has ever shown a desire to do that, and the ppa has had many issues due to ubuntu insanity. its definitely a bad idea to use those build scripts for bitcoin nodes.
12:05 < luke-jr> gitian binaries are not comparable
12:06 < luke-jr> BlueMatt: I respect your decision to not maintain it; but are you really suggesting you should decide for everyone else?
12:07 < sipa> if we as a project want to support PPAs again that's perhaps something to do discuss 
12:08 < BlueMatt> luke-jr: bitcoin core, as a project, maintains packaging scripts for fetching official release binaries and suggests users run those. if you disagree and want to start suggesting users run packages linked against os libs that have a long history of only half-working, its probably something that needs to be discussed as a project, not the two of us.
12:09 < BlueMatt> I got tired of doing it, in large part, because they broke very regularly due to different dependencies than upstream supported. imo it only makes sense to ship the release binaries, but, again, that can be a broader discussion if you want to open it.
12:09 < luke-jr> the ideal is users compiling their own; after that, PPAs are next best for Ubuntu; gitian binaries are nice to have as downloads, but in their current form not a good recommendation
12:09 < BlueMatt> maybe next weeks meeting
12:09 < luke-jr> I'm not asking you to do it
12:09 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/727857d12d04...891464950b07
12:09 < bitcoin-git> bitcoin/master 470e2ac practicalswift: tests: Avoid hitting some known minor tinyformat issues when fuzzing strpr...
12:09 < bitcoin-git> bitcoin/master 8914649 MarcoFalke: Merge #18109: tests: Avoid hitting some known minor tinyformat issues when...
12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18109: tests: Avoid hitting some known minor tinyformat issues when fuzzing strprintf(...) (master...fuzzers-strprintf-errata) https://github.com/bitcoin/bitcoin/pull/18109
12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:10 < BlueMatt> I'm not not doing it cause it took some small amount of effort, I'm not doing it cause things were failing test suite left and right and I felt like that was an unacceptable risk to user funds. I dont think you nor I have enough info by ourselves to decide otherwise. we can discuss it at the next meeting, if you want.
12:11 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
12:13 < luke-jr> there's no reason it should require anything more than someone willing to do the work. and the tests _aren't_ failing (except on old platforms, which simply don't end up with packages).
12:14 < BlueMatt> they were at the time i stopped. sounds like you want to discuss it at the next meeting, so lets do that.
12:14 < luke-jr> #proposedmeetingtopic PPA URI
12:15 < luke-jr> hmm, why didn't that work? :/
12:15 < sipa> why do you assume it didn't work?
12:15 < luke-jr> it's not in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 
12:15 < sipa> i think it's just updated manually
12:16 < luke-jr> i c
12:17 < sipa> wumpus: thanks for the serialization 5 merge, we're almost there :)
12:19 < kanzure> luke-jr: it's on a timer.
12:20 < kanzure> luke-jr: it runs every 6 hours and then a few minutes before each meeting.
12:22 < sipa> oh, fancy
12:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:26 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/891464950b07...d7134b306a17
12:26 < bitcoin-git> bitcoin/master 4a7fd7a practicalswift: tests: Add amount compression/decompression fuzzing to existing fuzzing ha...
12:26 < bitcoin-git> bitcoin/master 7e9c711 practicalswift: compressor: Make the domain of CompressAmount(...) explicit
12:26 < bitcoin-git> bitcoin/master d7134b3 MarcoFalke: Merge #17917: tests: Add amount compression/decompression fuzzing to exist...
12:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:27 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17917: tests: Add amount compression/decompression fuzzing to existing fuzzing harness (master...amount-compression-roundtrip) https://github.com/bitcoin/bitcoin/pull/17917
12:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:29 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has joined #bitcoin-core-dev
12:38 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving]
12:42 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has quit [Quit: Sleep mode]
12:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d7134b306a17...a2b5aae9f347
12:42 < bitcoin-git> bitcoin/master c2bd588 practicalswift: Add missing includes
12:42 < bitcoin-git> bitcoin/master 3c82b92 practicalswift: tests: Add fuzzing harness for functions taking floating-point types as in...
12:42 < bitcoin-git> bitcoin/master 8f6fb0a practicalswift: tests: Add serialization/deserialization fuzzing for integral types
12:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:43 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17996: tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals (master...fuzzers-float) https://github.com/bitcoin/bitcoin/pull/17996
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:43 < bitcoin-git> [bitcoin] practicalswift opened pull request #18270: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero) (master...parsemoney-followup) https://github.com/bitcoin/bitcoin/pull/18270
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:48 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has joined #bitcoin-core-dev
12:50 < sipa> MarcoFalke: it seems my bitcoind (commit a71c34742) died with boost::condition_variable::do_wait_until failed in pthread_cond_timedwait: Invalid argument  in debug.log
12:51 < MarcoFalke> Did you close your laptop and open it after some time passed?
12:51 < sipa> after waking up from standby
12:51 < sipa> for 14.5 hours
12:51 < sipa> yeah
12:52 < MarcoFalke> This is the same bug we are seeing in the mockscheduler test
12:52 < MarcoFalke> (I think)
12:52 < sipa> Right, that's why i'm mentioning it... we thought it only affected tests, no?
12:53 < MarcoFalke> #16027
12:53 < gribble> https://github.com/bitcoin/bitcoin/issues/16027 | client 0.18.0 crashes when computer wakes up from hibernation · Issue #16027 · bitcoin/bitcoin · GitHub
12:53 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:55fc:f43c:fed0:4fc6] has quit [Quit: Sleep mode]
12:54 < luke-jr> bleh
12:54 < MarcoFalke> I hope we can do #18234 for 0.20
12:54 < gribble> https://github.com/bitcoin/bitcoin/issues/18234 | refactor: Replace boost::mutex,condition_var,chrono with std equivalents in scheduler by ajtowns · Pull Request #18234 · bitcoin/bitcoin · GitHub
12:55 < luke-jr> does the boost<1.50 code work on newest boost versions?
12:55 < luke-jr> (timed_wait)
13:00 -!- gholms1 [~gholms@185.204.1.185] has quit []
13:00 < luke-jr> maybe we should just remove the wait_until version for now?
13:00 < MarcoFalke> I am pretty sure the 1.49 code is untested as well at this point. So instead of replacing one broken boost code with other broken boost code, we better remove boost
13:01 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
13:01 < luke-jr> MarcoFalke: I'm not sure that's a good approach for backports
13:04 < MarcoFalke> How far should this be backported? All currently supported versions of Bitcoin Core are affected.
13:07 -!- michaelfolkson [~textual@host86-177-156-70.range86-177.btcentralplus.com] has joined #bitcoin-core-dev
13:07 -!- michaelfolkson [~textual@host86-177-156-70.range86-177.btcentralplus.com] has quit [Client Quit]
13:08 < luke-jr> MarcoFalke: as far back as we still support, afaik just 0.18?
13:08 < luke-jr> and even 0.18 might not see another release
13:10 < MarcoFalke> Given that the issue happens only on machines that are human-attended (hibernate, standby), I'd say it is likely that when they upgrade they upgrade to the latest version, which would be 0.20
13:11 -!- pinheadmz [~matthewzi@45.83.89.68] has joined #bitcoin-core-dev
13:12 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 256 seconds]
13:14 < luke-jr> looks like timed_wait is implemented using the same code as wait_until
13:14 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:14 < MarcoFalke> ouch
13:14 < luke-jr> humans do not necessarily want to upgrade to the latest branch
13:16 < luke-jr> also, we have wait_until in other places with no <1.50 conditional.. do we actually still work wtih boost<1.50? O.o
13:16 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
13:19 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds]
13:20 -!- suldev [~suldev@c-69-242-62-131.hsd1.pa.comcast.net] has joined #bitcoin-core-dev
13:20 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
13:21 -!- suldev [~suldev@c-69-242-62-131.hsd1.pa.comcast.net] has quit [Client Quit]
13:22 -!- netsoundW1 [~netsoundW@77.243.177.38] has joined #bitcoin-core-dev
13:23 -!- suldev [~suldev@c-69-242-62-131.hsd1.pa.comcast.net] has joined #bitcoin-core-dev
13:25 < luke-jr> MarcoFalke: I don't understand https://github.com/bitcoin/bitcoin/issues/18227#issuecomment-592992100
13:25 < MarcoFalke> we only support boost-1.53 (through centos 7) and up
13:25 < luke-jr> MarcoFalke: pthread_cond_timedwait takes an absolute time, NOT a time delta
13:25 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:25 < MarcoFalke> We have no infrastucture to support boost older than 1.53
13:25 < luke-jr> MarcoFalke: dependencies.md says 1.47
13:26 < MarcoFalke> luke-jr: It will add the delta to the "internal clock" first
13:26 < luke-jr> MarcoFalke: it seems that passing a negative time to pthread_cond_timedwait SHOULD always be an error..
13:27 < MarcoFalke> luke-jr: Not sure about that. Is there documentation available? I couldn't find any.
13:27 < MarcoFalke> The problem might just be that nsecs is negative
13:28 < luke-jr> oh, the monotonic clock might start at 0 when the boot happens
13:28 < luke-jr> yes, nsecs negative is no doubt the issue
13:28 < luke-jr> my manpage says       EINVAL The abstime argument specified a nanosecond value less than zero or greater than or equal to 1000 million.
13:28 < MarcoFalke> luke-jr: https://github.com/bitcoin/bitcoin/pull/16381#issuecomment-522800024
13:29 < luke-jr> unfortunately, this is internal to boost, so we can't just check for <0
13:30 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 255 seconds]
13:38 < luke-jr> MarcoFalke: how about something like this until the std stuff is merged? http://dpaste.com/3YVVNBM
13:38 < luke-jr> or rather http://dpaste.com/13NZMJG
13:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a2b5aae9f347...3f826598a42d
13:44 < bitcoin-git> bitcoin/master f4691b6 practicalswift: tests: Add fuzzing harness for CKey related functions
13:44 < bitcoin-git> bitcoin/master 3f82659 MarcoFalke: Merge #17972: tests: Add fuzzing harness for CKey and key related function...
13:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17972: tests: Add fuzzing harness for CKey and key related functions (master...fuzzers-key) https://github.com/bitcoin/bitcoin/pull/17972
13:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:47 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
13:59 -!- suldev [~suldev@c-69-242-62-131.hsd1.pa.comcast.net] has quit [Quit: Leaving]
14:00 < hebasto> wumpus: mind re-opening #16381 ?
14:00 < gribble> https://github.com/bitcoin/bitcoin/issues/16381 | Set minimum required Boost to 1.53.0 by hebasto · Pull Request #16381 · bitcoin/bitcoin · GitHub
14:02 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Quit: Leaving]
14:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:07 < bitcoin-git> [bitcoin] fanquake reopened pull request #16381: Set minimum required Boost to 1.53.0 (master...20190713-bump-minimum-boost) https://github.com/bitcoin/bitcoin/pull/16381
14:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:07 < fanquake> hebasto: make sure you rebase on top of all the other boost sleep related PRs, so what should be left in 16381 is very minimal changes.
14:07 < hebasto> fanquake: ok
14:08 < luke-jr> well, it makes sense to drop compat stuff too
14:08 < fanquake> yea, but that's already in #16117
14:08 < gribble> https://github.com/bitcoin/bitcoin/issues/16117 | util: Replace boost sleep with std sleep by MarcoFalke · Pull Request #16117 · bitcoin/bitcoin · GitHub
14:08 < luke-jr> true
14:09 < luke-jr> heh, I wonder if 16117 restores compat with older boost XD
14:10 < fanquake> I did think that the more Boost we remove, the more likely we are to be compatible with older Boost
14:10 < hebasto> fanquake: :)
14:11 < luke-jr> hehe
14:12 < sipa> so you're saying that if we reimplement boost from scratch ourselves, we'll no longer have these problems? ;)
14:14 < fanquake> sipa: yes, assigning that task to you
14:14 < MarcoFalke> > [16:38] <luke-jr> or rather http://dpaste.com/13NZMJG
14:15 < MarcoFalke> I am fine with that, but I won't open the pull for it
14:15 < fanquake> hebasto: btw, if you want to base on top of #18264, I've solved the merge conflicts already.
14:15 < gribble> https://github.com/bitcoin/bitcoin/issues/18264 | [WIP] build: Remove Boost Chrono by fanquake · Pull Request #18264 · bitcoin/bitcoin · GitHub
14:16 < hebasto> fanquake: let me see..
14:16 < fanquake> You'll still need the change in the linter though, as that's not in 16117
14:18 < luke-jr> MarcoFalke: making a helper function to handle all locations
14:22 < luke-jr> oh
14:22 < luke-jr> those other wait_untils are std
14:22 < luke-jr> so maybe older boost does work
14:25 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 255 seconds]
14:28 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
14:37 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
14:42 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:43 -!- someone235 [uid419897@gateway/web/irccloud.com/x-quxwdfigjpujzgby] has quit [Quit: Connection closed for inactivity]
14:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:44 < bitcoin-git> [bitcoin] luke-jr opened pull request #18271: scheduler: Workaround negative nsecs bug in boost's wait_until (master...wrkarnd_boost_wait_until) https://github.com/bitcoin/bitcoin/pull/18271
14:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:44 -!- zavan [~textual@2a02:8084:a080:a900:3004:fc3c:a558:7cfc] has joined #bitcoin-core-dev
14:46 -!- captjakk_ [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
14:49 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 256 seconds]
14:53 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
14:58 -!- zavan [~textual@2a02:8084:a080:a900:3004:fc3c:a558:7cfc] has quit [Quit: Textual IRC Client: www.textualapp.com]
14:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:58 < bitcoin-git> [bitcoin] Shmug5525 opened pull request #18272: Create Shmugi (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18272
14:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:59 < bitcoin-git> [bitcoin] fanquake closed pull request #18272: Create Shmugi (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18272
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:59 < bitcoin-git> [bitcoin] Shmug5525 opened pull request #18273: Create Shmugi (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18273
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:05 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Ping timeout: 258 seconds]
15:06 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:06 < bitcoin-git> [bitcoin] fanquake closed pull request #18273: Create Shmugi (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18273
15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:06 < fanquake> sipa: can you block Shmug5525
15:07 < fanquake> Don't think the links are malware, just off to some random consulting company..
15:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
15:29 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev
15:35 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:36 < sipa> fanquake: can't right now
15:41 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:44 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
15:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
15:45 -!- marcoagner [~user@dsl-58-207.bl26.telepac.pt] has quit [Ping timeout: 260 seconds]
15:45 -!- mryandao_ is now known as mryandao
15:48 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:57 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
16:00 -!- netsoundW1 [~netsoundW@77.243.177.38] has quit []
16:00 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:01 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 258 seconds]
16:02 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Ping timeout: 256 seconds]
16:04 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Ping timeout: 256 seconds]
16:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds]
16:13 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
16:15 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
16:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]
16:35 -!- lightlike [~lightlike@p200300C7EF140100F849411C4B2846C5.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
16:51 -!- anditto [~anditto@240d:1a:29:b700:cce6:1705:7b34:c816] has joined #bitcoin-core-dev
16:54 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving]
16:55 -!- Spanktar [~Spanktar@184.75.223.219] has joined #bitcoin-core-dev
17:18 -!- captjakk_ [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
17:19 -!- pinheadmz_ [~matthewzi@45.83.89.68] has joined #bitcoin-core-dev
17:21 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Ping timeout: 258 seconds]
17:21 -!- pinheadmz_ is now known as pinheadmz
17:48 -!- pinheadmz_ [~matthewzi@45.83.89.68] has joined #bitcoin-core-dev
17:49 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Ping timeout: 260 seconds]
17:49 -!- pinheadmz_ is now known as pinheadmz
17:51 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:52 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
17:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer]
17:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
18:07 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
18:42 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 260 seconds]
18:51 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
18:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
19:00 -!- Spanktar [~Spanktar@184.75.223.219] has quit []
19:06 < luke-jr> aj: yt?
19:07 < aj> luke-jr: yo
19:08 < luke-jr> re https://github.com/bitcoin/bitcoin/pull/18271#issuecomment-595571229
19:08 < luke-jr> wouldn't checking before wait_until result in a race?
19:08 < luke-jr> eg, sleep after the check, then resume before wait_until?
19:08 < luke-jr> the Travis thing is weird - it's crashing the entire VM somehow :/
19:09 < aj> yes, i think you're right there'd still be that window for the bug
19:10 < aj> the travis thing is just causing the test to hang until the travis timeout hits, isn't it?
19:10 < luke-jr> the entire VM hangs
19:10 < luke-jr> I'm running it in debug mode so I can strace/top/etc, and I can't even open a new tmux window
19:11 < aj> wtf
19:11 < aj> does that mean it's busy looping and using all cpu then?
19:11 < luke-jr> that shouldn't be possible unless it was setting realtime prio or something stupid
19:11 < luke-jr> trying catch (boost::thread_interrupted) { throw; } now
19:12 < kallewoof> Anyone got any hints or ideas on why appveyor is complaining here? https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/31265297 (it's from #16411)
19:12 < gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
19:12 < kallewoof> It doesn't seem to like my RPCResult expressions, but they are identical to the other ones I see... 
19:14 < cncr04s> I really miss getinfo
19:14 < luke-jr> why?
19:15 < luke-jr> bitcoin-cli -getinfo
19:15 < cncr04s> i have to type 3 api commands instead of just 1. 
19:16 < luke-jr> or just use -getinfo
19:16 < cncr04s> This call was removed in version 0.16.0. Use the appropriate fields from:
19:17 < luke-jr> -
19:20 < aj> kallewoof: i think you need to rebase and update to match #17809 ?
19:20 < gribble> https://github.com/bitcoin/bitcoin/issues/17809 | rpc: Auto-format RPCResult by MarcoFalke · Pull Request #17809 · bitcoin/bitcoin · GitHub
19:21 < kallewoof> aj: Ahh! Okay, thanks, will do
19:22 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
19:39 < kallewoof> aj: That was it. Thanks for the nudge. Will try to remember to rebase on master next time I see a weird error like that.
19:41 < luke-jr> aj: looks like the extra catch and throw fixes it
19:44 < kallewoof> Huh. I actually didn't realize there was a -getinfo command that was not deprecated. Thanks, luke-jr
19:45 < luke-jr> np
19:45 < luke-jr> tbh, I probably opposed it, but as long as it's there, might as well use it
19:45 < kallewoof> cncr04s: in case you didn't get what he was saying, use a minus sign and it's still there.
19:46 < kallewoof> luke-jr: i never really looked into why people were against getinfo in the first place
19:46 < luke-jr> kallewoof: it did too much, took too many locks, etc and usually you only need a few things
19:46 < luke-jr> makes more sense to just batch a bunch of requests together
19:47 < kallewoof> ahh
19:47 < luke-jr> also my perspective is that the RPC is for scripts/code to use, not humans ;P
19:48 < kallewoof> luke-jr: i don't use GUI's if i can avoid it...
19:48 < luke-jr> kallewoof: someone made a curses frontend for the RPC IIRC
19:49 < kallewoof> i kinda just like the terminal experience without curses and such.
19:49 < kallewoof> command. enter. result. rinse
19:55 -!- vinai [~vinai@176.113.74.179] has joined #bitcoin-core-dev
19:55 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev
19:57 -!- felixfoertsch [~felixfoer@i6DFA6AC9.versanet.de] has joined #bitcoin-core-dev
19:59 -!- felixfoertsch23 [~felixfoer@92.117.39.73] has quit [Ping timeout: 256 seconds]
20:29 -!- jarthur [~jarthur@2605:6000:1019:4971:9de8:d781:9bc8:5678] has joined #bitcoin-core-dev
20:40 -!- xavier_fabric [~xavierfab@209.6.219.248] has joined #bitcoin-core-dev
20:50 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 255 seconds]
20:51 -!- xavier_fabric [~xavierfab@209.6.219.248] has quit [Quit: Leaving]
20:51 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
20:53 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
20:55 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
20:56 -!- baldur [~baldur@pool-100-2-132-165.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
20:57 -!- jimmysong_ [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev
20:58 -!- baldur [~baldur@pool-100-2-132-165.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
20:58 -!- stevenroose [~steven@irc.roose.io] has quit [Remote host closed the connection]
20:59 -!- stevenroose [~steven@irc.roose.io] has joined #bitcoin-core-dev
21:00 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Ping timeout: 255 seconds]
21:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:05 < bitcoin-git> [bitcoin] kallewoof opened pull request #18274: wallet: set nFeeRet to 0 to avoid garbage value upon error (master...2003-reset-nfeeret) https://github.com/bitcoin/bitcoin/pull/18274
21:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:05 -!- reardencode [~reardenco@shrugged.reardencode.com] has quit [Ping timeout: 260 seconds]
21:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:12 < bitcoin-git> [bitcoin] kallewoof opened pull request #18275: wallet: error if an explicit fee rate was given but the needed fee rate differed (master...2003-wallet-error-on-feechange) https://github.com/bitcoin/bitcoin/pull/18275
21:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:18 -!- jarthur [~jarthur@2605:6000:1019:4971:9de8:d781:9bc8:5678] has quit [Remote host closed the connection]
21:18 -!- jarthur [~jarthur@2605:6000:1019:4971:9de8:d781:9bc8:5678] has joined #bitcoin-core-dev
21:38 -!- francisco______ [uid418144@gateway/web/irccloud.com/x-zctuokqwxkkwrget] has quit [Quit: Connection closed for inactivity]
21:47 -!- Highway61 [~Thunderbi@208.131.139.133] has quit [Ping timeout: 255 seconds]
21:50 -!- sdddddd [~fa@101.229.164.18] has quit [Ping timeout: 260 seconds]
21:57 -!- reardencode [~reardenco@shrugged.reardencode.com] has joined #bitcoin-core-dev
22:00 -!- vinai [~vinai@176.113.74.179] has quit []
22:13 -!- pinheadmz [~matthewzi@45.83.89.68] has quit [Quit: pinheadmz]
22:21 -!- PeErLesS [~PeErLesS@185.189.112.19] has joined #bitcoin-core-dev
22:22 -!- PeErLesS is now known as Guest92974
22:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:41 < bitcoin-git> [bitcoin] yashpatel20 opened pull request #18276: doc: rpcdoc remove redundant type from description#18258 (master...issue#18258) https://github.com/bitcoin/bitcoin/pull/18276
22:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:45 < bitcoin-git> [bitcoin] fanquake closed pull request #18276: doc: rpcdoc remove redundant type from description#18258 (master...issue#18258) https://github.com/bitcoin/bitcoin/pull/18276
22:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:59 -!- Highway61 [~Thunderbi@208.131.139.133] has joined #bitcoin-core-dev
23:08 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
23:12 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev
23:21 -!- anditto [~anditto@240d:1a:29:b700:cce6:1705:7b34:c816] has quit [Remote host closed the connection]
23:28 -!- anditto [~anditto@240d:1a:29:b700:cce6:1705:7b34:c816] has joined #bitcoin-core-dev
23:29 -!- jinping [65e6d362@101.230.211.98] has joined #bitcoin-core-dev
23:35 -!- noeyprincess [c4cfa5be@196.207.165.190] has joined #bitcoin-core-dev
23:36 -!- jinping [65e6d362@101.230.211.98] has quit [Ping timeout: 260 seconds]
23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
23:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:41 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3f826598a42d...97aadf98d0b8
23:41 < bitcoin-git> bitcoin/master fa4620b MarcoFalke: util: Add UnintrruptibleSleep
23:41 < bitcoin-git> bitcoin/master fa9af06 MarcoFalke: scripted-diff: Replace MilliSleep with UninterruptibleSleep
23:41 < bitcoin-git> bitcoin/master fae86c3 MarcoFalke: util: Remove unused MilliSleep
23:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:42 < bitcoin-git> [bitcoin] fanquake merged pull request #16117: util: Replace boost sleep with std sleep (master...1905-noBoostUtilTime) https://github.com/bitcoin/bitcoin/pull/16117
23:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
23:43 -!- vasild_ is now known as vasild
23:54 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Ping timeout: 258 seconds]
--- Log closed Fri Mar 06 00:00:18 2020