--- Log opened Tue Mar 31 00:00:38 2020 00:01 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 00:02 < wumpus> vasild: yup tarballs work fine for 'orphaned' commits, downloading patches/diffs also works, but never found a trick to be able to do it with git itself 00:06 -!- lucaferr [~l@90.129.219.1] has joined #bitcoin-core-dev 00:10 -!- lucaferr [~l@90.129.219.1] has quit [Remote host closed the connection] 00:12 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 00:21 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 240 seconds] 00:22 < wumpus> (or alternatively, to download a tarball w/ .git directory, or say, a git bundle for a commit range) 00:22 < vasild> https://stackoverflow.com/questions/28958327/does-github-remember-commit-ids/28958418#28958418 is relevant. It's like gwillen's way, but using the github api. Requires write permissions though, to create a new branch from the orphaned commit. 00:22 < gribble> https://github.com/bitcoin/bitcoin/issues/28958418 | HTTP Error 404: Not Found 00:24 < vasild> I have already forked the repo in my github account, so I cannot fork it a second time to check whether the orphaned commits will be copied into my fork (where I would have write permissions) 00:24 -!- lucaferr [~lucaferr@2a00:801:3c5:8f9:10f3:1435:7a84:dfe] has joined #bitcoin-core-dev 00:25 < wumpus> oh interesting! that's at least something, though, I'd most frequently wanted it for other people's commits and don't tend to have write access to them 00:25 < lucaferr> How does peer protocol command "notfound" behave when a "getdata" request only partially matches. Will it return a partial result plus "notfound", or will it only return "notfound"? 00:25 < wumpus> haaaah fork their repository first, of course 00:26 < wumpus> lucaferr: it either returns a (partial) result or "notfound" never both IIRC 00:26 < lucaferr> wumpus: great, thank you 00:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:43 < vasild_> wumpus: but when I go to https://github.com/practicalswift/bitcoin and try to "Fork" it into my account I am redirected to vasild/bitcoin (nothing gets forked) 00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:44 -!- vasild_ is now known as vasild 00:51 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 00:58 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 00:59 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 01:00 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Quit: bye] 01:01 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 01:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 01:12 < jonasschnelli> Can we consider #18160 a bugfix? I'd like to get that into 0.20? 01:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub 01:13 < sipa> lucaferr: it wul 01:14 < sipa> lucaferr: it will respond with tx/blocks for the found things, and a notfound for the rest 01:15 < lucaferr> sipa: ah, ok. So the arity will match between the requested inventory vectors and the notfound inventory plus data messages (tx or block)? 01:17 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev 01:20 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:23 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Quit: bye] 01:29 -!- kljasdfvv [~flack@p200300D46F0C14006C614F3EC40BD204.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 01:31 -!- kljasdfvv [~flack@p200300D46F0C1400D14D52BE67A3933C.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:49 < wumpus> sipa: oh you're right, I was confused with how 'reject' messages used to be handled 01:50 -!- g0000n [~dixon@141.98.255.151] has joined #bitcoin-core-dev 02:00 -!- flukiluke1 [~flukiluke@176.113.74.179] has quit [] 02:02 < lucaferr> wumpus, sipa: thanks to both for replying :) 02:13 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 02:14 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:14 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 02:17 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 02:18 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 02:21 -!- DarTar [~DarTar@184.75.221.163] has joined #bitcoin-core-dev 02:23 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:23 < bitcoin-git> [bitcoin] theStack opened pull request #18481: test: add BIP37 'filterclear' test to p2p_filter.py (master...20200330-test-add-BIP37-filterclear-message) https://github.com/bitcoin/bitcoin/pull/18481 02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:24 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 02:33 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 02:37 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 02:40 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 246 seconds] 02:40 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 02:40 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:43 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 03:00 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Remote host closed the connection] 03:04 -!- Jed4Koelpin [~Jed4Koelp@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:10 -!- jtimon [~quassel@206.160.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 03:10 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 03:14 < wumpus> jonasschnelli: yes, I think it's a fix of some kind 03:15 < wumpus> jonasschnelli: I was holding it off because of the idea to merge #17905 first, which isn't merged yet, seems too late to merge both now (and do a last-minute rebase of the latter) 03:15 < gribble> https://github.com/bitcoin/bitcoin/issues/17905 | gui: Avoid redundant tx status updates by ryanofsky · Pull Request #17905 · bitcoin/bitcoin · GitHub 03:16 < wumpus> so I don't know what's best now 03:23 < promag> #18338 #18160 03:23 < gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub 03:23 < gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub 03:23 < promag> these should be ready to merge 03:24 < wumpus> ok! 03:24 < promag> #16923 another fix that could also go 03:24 < gribble> https://github.com/bitcoin/bitcoin/issues/16923 | wallet: Handle duplicate fileid exception by promag · Pull Request #16923 · bitcoin/bitcoin · GitHub 03:25 < promag> #18160 is easer to backport to 0.19 without 17905 03:25 < gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub 03:25 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 03:35 -!- theStack [51dfa506@81.223.165.6] has joined #bitcoin-core-dev 03:36 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 03:36 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 03:45 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 03:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:55 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 04:00 -!- apaval_ [~apaval@124.108.23.110] has quit [Remote host closed the connection] 04:00 -!- apaval_ [~apaval@124.108.23.110] has joined #bitcoin-core-dev 04:37 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 04:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 04:46 -!- theStack [51dfa506@81.223.165.6] has quit [Remote host closed the connection] 05:00 -!- DarTar [~DarTar@184.75.221.163] has quit [] 05:04 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 240 seconds] 05:04 < wumpus> looking at them now, doesn't help that my main computer's case fan decided to die today 05:08 -!- Jed4Koelpin [~Jed4Koelp@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 05:11 < luke-jr> :| 05:22 -!- FenderQ1 [~FenderQ@84.39.117.57] has joined #bitcoin-core-dev 05:22 < wumpus> ordered a new one and it'll probably get here tomorrow, but who knows these days 05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:24 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/965c0c37d54c...f2880e21eff2 05:24 < bitcoin-git> bitcoin/master 0933a37 João Barbosa: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged 05:24 < bitcoin-git> bitcoin/master f2880e2 Wladimir J. van der Laan: Merge #18160: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceCha... 05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:24 < bitcoin-git> [bitcoin] laanwj merged pull request #18160: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (master...2020-02-avoid-getbalance) https://github.com/bitcoin/bitcoin/pull/18160 05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:25 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 05:25 < luke-jr> even though it's internal to the PC, I'd take precautions to sanitize it somehow 05:25 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 05:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 05:28 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:29 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:30 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 05:30 -!- theStack [51dfa506@81.223.165.6] has joined #bitcoin-core-dev 05:34 -!- theStack [51dfa506@81.223.165.6] has quit [Remote host closed the connection] 05:37 < wumpus> yeah 05:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 06:03 -!- Highway61 [~Thunderbi@104.223.94.42] has quit [Quit: Highway61] 06:03 -!- Guyver2_ is now known as Guyver2 06:06 -!- lucaferr [~lucaferr@2a00:801:3c5:8f9:10f3:1435:7a84:dfe] has quit [Ping timeout: 246 seconds] 06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:07 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f2880e21eff2...9a2b5f22c1f6 06:07 < bitcoin-git> bitcoin/master ab31b9d Russell Yanofsky: Fix wallet unload race condition 06:07 < bitcoin-git> bitcoin/master 41b0baf João Barbosa: gui: Handle WalletModel::unload asynchronous 06:07 < bitcoin-git> bitcoin/master 9a2b5f2 Wladimir J. van der Laan: Merge #18338: Fix wallet unload race condition 06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:07 < bitcoin-git> [bitcoin] laanwj merged pull request #18338: Fix wallet unload race condition (master...notify-shared) https://github.com/bitcoin/bitcoin/pull/18338 06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:09 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:16 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 06:16 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 06:20 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 06:21 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 06:22 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection] 06:24 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 06:26 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 250 seconds] 06:29 -!- per [~per@gateway/tor-sasl/wsm] has quit [Ping timeout: 240 seconds] 06:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:36 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9a2b5f22c1f6...d52ba21dfff9 06:36 < bitcoin-git> bitcoin/master 0055922 Sebastian Falbesoner: test: add BIP37 'filterclear' test to p2p_filter.py 06:36 < bitcoin-git> bitcoin/master d52ba21 MarcoFalke: Merge #18481: test: add BIP37 'filterclear' test to p2p_filter.py 06:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:37 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18481: test: add BIP37 'filterclear' test to p2p_filter.py (master...20200330-test-add-BIP37-filterclear-message) https://github.com/bitcoin/bitcoin/pull/18481 06:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:48 -!- g0000n [~dixon@141.98.255.151] has quit [Ping timeout: 256 seconds] 07:02 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 07:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 07:05 -!- g0000n [~dixon@45.83.220.174] has joined #bitcoin-core-dev 07:21 -!- Highway61 [~Thunderbi@104.223.95.34] has joined #bitcoin-core-dev 07:29 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Disconnected by services] 07:30 -!- promag_ is now known as promag 07:30 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:32 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 252 seconds] 07:34 -!- BamBaRay36 [~2BamBaRay@95.174.67.132] has quit [Ping timeout: 256 seconds] 07:38 < emilengler> By the way, is someone working on the switch from C++11 to C++17 right now? Like #17904? Otherwise I would try to pick it up 07:38 < gribble> https://github.com/bitcoin/bitcoin/issues/17904 | [wip] build: Switch from C++11 to C++17 by practicalswift · Pull Request #17904 · bitcoin/bitcoin · GitHub 07:39 -!- Kiminuo [~mix@141.98.103.206] has quit [Ping timeout: 265 seconds] 07:39 < provoostenator> emilengler: usually we have to wait for ancient distros to support it, luke-jr tends to be up to date on those... 07:40 < aj> i thought we were just deferring 'til 0.20 was done? 07:40 < emilengler> aj: It has the milestone of 0.21 07:40 < aj> #16684 has info about distros 07:40 < gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub 07:43 < emilengler> The only problem was CentOS 7 then but CentOS 8 is already out 08:00 -!- FenderQ1 [~FenderQ@84.39.117.57] has quit [] 08:01 < promag> so how about #16923? 08:01 < gribble> https://github.com/bitcoin/bitcoin/issues/16923 | wallet: Handle duplicate fileid exception by promag · Pull Request #16923 · bitcoin/bitcoin · GitHub 08:12 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:21 -!- tomkap1 [~tomkap@139.28.218.198] has joined #bitcoin-core-dev 08:24 -!- theStack [51dfa506@81.223.165.6] has joined #bitcoin-core-dev 08:26 -!- Kiminuo [~mix@141.98.103.102] has joined #bitcoin-core-dev 08:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:43 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 08:44 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 09:04 < luke-jr> dongcarl: for #16684, note Gentoo is at 9.2.0 09:04 < gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub 09:13 -!- guest534543 [~mix@141.98.103.126] has joined #bitcoin-core-dev 09:16 -!- Kiminuo [~mix@141.98.103.102] has quit [Ping timeout: 256 seconds] 09:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:25 < jonatack> promag: re-acked #16923. lone travis failure (mempool_reorg.py) is unrelated 09:25 < gribble> https://github.com/bitcoin/bitcoin/issues/16923 | wallet: Handle duplicate fileid exception by promag · Pull Request #16923 · bitcoin/bitcoin · GitHub 09:27 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 09:29 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 09:29 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 09:34 -!- Randolf [~randolf@184.70.10.189] has joined #bitcoin-core-dev 09:34 -!- Randolf is now known as LumberCartel 09:35 -!- LumberCartel is now known as Randolf 09:38 < wumpus> yes maybe with 0.21 we can switch to c++17, I hope so 09:39 < wumpus> restarted travis run for 16923 09:39 -!- seddd [~user@gateway/tor-sasl/seddd] has joined #bitcoin-core-dev 09:40 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 09:40 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:46 -!- seddd [~user@gateway/tor-sasl/seddd] has quit [Quit: WeeChat 2.7.1] 10:02 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:02 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 240 seconds] 10:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 10:34 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 10:34 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 10:38 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 10:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:45 < bitcoin-git> [bitcoin] achow101 opened pull request #18484: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484 10:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:56 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 11:00 -!- tomkap1 [~tomkap@139.28.218.198] has quit [] 11:08 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has joined #bitcoin-core-dev 11:21 -!- furkanmustafa [~furkanmus@195.206.183.79] has joined #bitcoin-core-dev 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:31 < bitcoin-git> [bitcoin] hebasto opened pull request #18485: test: Add mempool_updatefromblock.py (master...20200331-test-mempool) https://github.com/bitcoin/bitcoin/pull/18485 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:33 -!- g0000n [~dixon@45.83.220.174] has left #bitcoin-core-dev [] 11:43 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev 11:51 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 12:00 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 12:11 -!- Highway61 [~Thunderbi@104.223.95.34] has quit [Remote host closed the connection] 12:11 -!- Highway61 [~Thunderbi@104.223.95.34] has joined #bitcoin-core-dev 12:35 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 252 seconds] 12:38 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d52ba21dfff9...72ef36656439 12:40 < bitcoin-git> bitcoin/master fa3cc0b MarcoFalke: test: Remove unsafe BOOST_TEST_MESSAGE 12:40 < bitcoin-git> bitcoin/master 72ef366 MarcoFalke: Merge #18472: test: Remove unsafe BOOST_TEST_MESSAGE 12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18472: test: Remove unsafe BOOST_TEST_MESSAGE (master...2003-testNoBoost) https://github.com/bitcoin/bitcoin/pull/18472 12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:42 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:44 -!- vasild_ is now known as vasild 12:47 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 12:50 < hebasto> travis did not handle #18485. Could reopening help? Or just wait? 12:50 < gribble> https://github.com/bitcoin/bitcoin/issues/18485 | test: Add mempool_updatefromblock.py by hebasto · Pull Request #18485 · bitcoin/bitcoin · GitHub 12:51 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 240 seconds] 13:06 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 13:08 < jeremyrubin> hebasto: good work on that test! 13:11 < hebasto> jeremyrubin: how large tx graph do you suggest? 13:11 < jeremyrubin> Up to you -- You can see the code in the ComplexMempool benchmark for "generate a large tx graph" idiom. 13:11 < jeremyrubin> I think the question is less so largeness but the 'weirdness' of the structure 13:12 < jeremyrubin> You want it to have a lot of stuff where a child is also a grandchild 13:12 < hebasto> "child is also a grandchild" included already :) 13:12 < jeremyrubin> Ah let me re-check 13:13 < jeremyrubin> Maybe some ascii art :) 13:14 < jeremyrubin> ok so TX 0 pays into tx 1 and into tx2 and tx3 13:14 < jeremyrubin> Tx 1 pays into tx 2 13:14 < jeremyrubin> gotcha 13:14 < hebasto> what are our rules: an arrow from a parent to a child or opposite? 13:14 < jeremyrubin> I see 13:15 < jeremyrubin> For ascii? I think there are arguments for both arrow directions 13:15 < hebasto> if don't mind, let skip ascii :) 13:15 < jeremyrubin> Personally I've always preferred arrow to parent conceptually, but arrow to child makes more sense to people intuitively 13:16 < hebasto> it seems I tend to agree with your point 13:17 < jeremyrubin> yeah arrow to parent makes sense because it's a pointer and the parent is immutable 13:17 < jeremyrubin> But value "flows" from parent to child 13:17 < hebasto> sure 13:18 < jeremyrubin> I'll think if there's cases that wouldn't be caught here. 13:18 < hebasto> maybe just add a note that a complete graph is used? 13:18 < hebasto> https://en.wikipedia.org/wiki/Complete_graph 13:18 < jeremyrubin> I think making it bigger (e.g., 50 txns) would be useful 13:18 < jeremyrubin> because then you will trip over the mempool descendants and ancestors limits 13:18 < jeremyrubin> So you check that they aren't being enforced during reorg 13:18 < hebasto> yeah, limits... 13:19 < jeremyrubin> can be done as follow up work tho 13:19 < jeremyrubin> test is fine as is IMO 13:20 < hebasto> "they aren't being enforced during reorg" mind pointing me to code? 13:21 < jeremyrubin> UpdateTransactionsFromBlock 13:21 < hebasto> ty 13:21 < hebasto> oh, I know that part of code ;) 13:21 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has quit [Remote host closed the connection] 13:22 < jeremyrubin> yeah we're just not checking things like "how many descendants does a tx have" here 13:22 < hebasto> I see 13:22 < jeremyrubin> So by doing your test with 50 things you would confirm that we aren't eviciting stuff even if not re-mined 13:23 < jeremyrubin> (which can be a potential problem, and behavior we'd want to change, but... let's skip that for now) 13:24 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 13:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:27 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18486: doc: Explain new test logging (master...2004-docTestLogging) https://github.com/bitcoin/bitcoin/pull/18486 13:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:32 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 256 seconds] 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:36 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/72ef36656439...d2db25233cf0 13:36 < bitcoin-git> bitcoin/master fac3716 MarcoFalke: test: check that peer is connected when calling sync_* 13:36 < bitcoin-git> bitcoin/master d2db252 MarcoFalke: Merge #18474: test: check that peer is connected when calling sync_* 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:36 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18474: test: check that peer is connected when calling sync_* (master...2003-qaCheckConnSync) https://github.com/bitcoin/bitcoin/pull/18474 13:36 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Remote host closed the connection] 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:37 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Remote host closed the connection] 13:41 -!- theStack [51dfa506@81.223.165.6] has quit [Remote host closed the connection] 13:46 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has joined #bitcoin-core-dev 13:59 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 14:00 -!- furkanmustafa [~furkanmus@195.206.183.79] has quit [] 14:03 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:04 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 14:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 14:15 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has quit [Remote host closed the connection] 14:17 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has joined #bitcoin-core-dev 14:19 -!- hebasto [~hebasto@95.164.65.194] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.2 - http://znc.in] 14:21 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 14:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:23 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 14:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 252 seconds] 14:30 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has quit [Remote host closed the connection] 14:41 -!- RandolfR [~randolf@184.70.10.188] has joined #bitcoin-core-dev 14:42 -!- Randolf [~randolf@184.70.10.189] has quit [Ping timeout: 250 seconds] 14:48 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 14:52 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 252 seconds] 14:55 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:55 -!- glidenote1 [~glidenote@195.206.183.79] has joined #bitcoin-core-dev 14:57 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 15:02 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 15:11 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has joined #bitcoin-core-dev 15:15 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has quit [Remote host closed the connection] 15:17 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has joined #bitcoin-core-dev 15:22 -!- jarthur [~jarthur@2605:6000:1019:4971:784a:c5b6:c7af:9840] has quit [Remote host closed the connection] 15:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 15:43 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 15:46 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 15:54 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 15:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:55 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 15:55 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 15:57 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 15:57 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 15:59 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Remote host closed the connection] 16:00 -!- apaval_ [~apaval@124.108.23.110] has quit [Read error: Connection reset by peer] 16:00 -!- apaval_ [~apaval@124.108.23.110] has joined #bitcoin-core-dev 16:04 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 16:04 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 260 seconds] 16:09 -!- filchef [~filchef@212.104.97.177] has quit [Read error: Connection reset by peer] 16:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 16:16 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:20 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 16:26 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 16:26 -!- promag__ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:27 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 16:28 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 16:29 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 16:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:31 < bitcoin-git> [bitcoin] promag opened pull request #18487: wip: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487 16:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:32 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:37 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 16:48 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:49 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 16:51 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Remote host closed the connection] 16:51 < promag> I'd like to consider #18487 for 0.20 16:51 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | wip: rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub 16:51 < promag> at worst case it doesn't fix the issue and only reduces the lock scopes 16:53 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 17:00 -!- glidenote1 [~glidenote@195.206.183.79] has quit [] 17:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 17:11 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 252 seconds] 17:12 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:14 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 17:15 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 17:19 -!- ThaDon [~ThaDon@141.98.102.235] has joined #bitcoin-core-dev 17:19 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 250 seconds] 17:21 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 17:25 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 252 seconds] 17:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 17:26 -!- shesek [~shesek@5.22.135.144] has joined #bitcoin-core-dev 17:26 -!- shesek [~shesek@5.22.135.144] has quit [Changing host] 17:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 17:47 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 17:59 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 17:59 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 18:04 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 18:04 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 18:08 -!- Randolf [~randolf@184.70.10.189] has joined #bitcoin-core-dev 18:10 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 256 seconds] 18:10 -!- RandolfR [~randolf@184.70.10.188] has quit [Ping timeout: 256 seconds] 18:10 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 18:12 -!- Randolf [~randolf@184.70.10.189] has quit [Ping timeout: 256 seconds] 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:15 < bitcoin-git> [bitcoin] promag closed pull request #18487: wip: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:15 < bitcoin-git> [bitcoin] promag reopened pull request #18487: wip: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:31 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 18:32 -!- t420babe [~t420babe@141.149.53.225] has quit [Ping timeout: 258 seconds] 18:35 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 18:39 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 18:41 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 18:47 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection] 18:48 -!- Highway61 [~Thunderbi@104.223.95.34] has quit [Remote host closed the connection] 18:48 -!- Highway62 [~Thunderbi@104.223.95.34] has joined #bitcoin-core-dev 18:50 -!- Highway62 is now known as Highway61 19:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 19:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:07 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has joined #bitcoin-core-dev 19:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 19:14 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 19:16 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:18 -!- jtimon [~quassel@206.160.134.37.dynamic.jazztel.es] has quit [Ping timeout: 258 seconds] 19:18 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 19:22 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 19:24 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:30 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 246 seconds] 19:44 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:48 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 19:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:53 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d2db25233cf0...eb773f106314 19:53 < bitcoin-git> bitcoin/master 7777703 MarcoFalke: doc: Explain new test logging 19:53 < bitcoin-git> bitcoin/master eb773f1 MarcoFalke: Merge #18486: doc: Explain new test logging 19:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18486: doc: Explain new test logging (master...2004-docTestLogging) https://github.com/bitcoin/bitcoin/pull/18486 19:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:53 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has joined #bitcoin-core-dev 19:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eb773f106314...67a72466e1c0 19:54 < bitcoin-git> bitcoin/master fa90647 MarcoFalke: test: Wait for both veracks in add_p2p_connection 19:54 < bitcoin-git> bitcoin/master faf1d04 MarcoFalke: test: Remove redundant sync_with_ping after add_p2p_connection 19:54 < bitcoin-git> bitcoin/master 67a7246 MarcoFalke: Merge #18247: test: Wait for both veracks in add_p2p_connection 19:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:55 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18247: test: Wait for both veracks in add_p2p_connection (master...2003-qaMininodeVerackRace) https://github.com/bitcoin/bitcoin/pull/18247 19:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:58 -!- Krellan_ [~Krellan@2601:640:4100:e:e4c9:efaf:ebdd:ea56] has quit [Ping timeout: 252 seconds] 20:00 -!- ThaDon [~ThaDon@141.98.102.235] has quit [] 20:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:01 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18489: Rebrand to Bitcoin Corrr (master...2004-rebrandCorrr) https://github.com/bitcoin/bitcoin/pull/18489 20:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:06 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 20:11 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 264 seconds] 20:20 -!- nerdboy1 [~nerdboy@84.39.116.180] has joined #bitcoin-core-dev 20:54 -!- wxss [~user@mail.deeplinkmedia.com] has quit [Ping timeout: 265 seconds] 20:54 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 20:55 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 20:56 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 20:58 < phantomcircuit> Client: HexChat 2.14.2 • OS: Debian 10.3 • CPU: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (800MHz) • Memory: Physical: 15.1 GiB Total (14.0 GiB Free) Swap: 15.4 GiB Total (15.4 GiB Free) • Storage: 778.7 GB / 1.9 TB (1.2 TB Free) • VGA: 8086:5917 @ 8086:5914 • Uptime: 11h 21m 47s 20:58 < phantomcircuit> oops 20:59 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 20:59 < sipa> "VGA" 21:01 < luke-jr> lol 21:01 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 21:01 < luke-jr> OS: GNU/Linux 4.19.112-gentoo-64kPages/ppc64le - KDE Plasma 5.18.3 - CPU: 64x IBM POWER9 (DD2.3) - Processes: 962 - Uptime: 8d 2h 34m - Users: 57 - Load Average: 1.00 - Memory Usage: 43869MB/65219MB (67%) 21:02 < phantomcircuit> i wonder where it got that screen resolution from 21:02 < luke-jr> looks more like a PCI id? 21:08 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 21:25 < phantomcircuit> luke-jr, indeed 21:27 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 21:32 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds] 22:07 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 22:08 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 22:12 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 22:12 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 256 seconds] 22:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 22:29 -!- gleb6 [~gleb@cpe-67-244-100-77.nyc.res.rr.com] has joined #bitcoin-core-dev 22:31 -!- gleb [~gleb@cpe-67-244-100-77.nyc.res.rr.com] has quit [Ping timeout: 256 seconds] 22:31 -!- gleb6 is now known as gleb 22:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:39 < bitcoin-git> [bitcoin] luke-jr opened pull request #18490: Bugfix: Check PE libraries case-insensitively (master...bugfix_symcheck_pe_case) https://github.com/bitcoin/bitcoin/pull/18490 22:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 22:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 22:56 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 22:59 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 23:00 -!- nerdboy1 [~nerdboy@84.39.116.180] has quit [] 23:00 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 23:00 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 23:10 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 23:10 -!- guest534543 [~mix@141.98.103.126] has quit [Ping timeout: 256 seconds] 23:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:21 -!- shazow [~shazow@176.113.74.179] has joined #bitcoin-core-dev 23:49 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 23:49 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 23:49 -!- apaval_ [~apaval@124.108.23.110] has quit [Remote host closed the connection] 23:50 -!- apaval_ [~apaval@124.108.23.110] has joined #bitcoin-core-dev 23:50 -!- gleb [~gleb@cpe-67-244-100-77.nyc.res.rr.com] has quit [Quit: Ping timeout (120 seconds)] 23:50 -!- gleb [~gleb@cpe-67-244-100-77.nyc.res.rr.com] has joined #bitcoin-core-dev 23:51 -!- nsh [~lol@wikipedia/nsh] has quit [Remote host closed the connection] 23:51 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 265 seconds] 23:53 -!- shazow [~shazow@176.113.74.179] has quit [Ping timeout: 265 seconds] 23:53 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 23:54 -!- z3232 [~z323@ec2-54-234-151-68.compute-1.amazonaws.com] has quit [Ping timeout: 265 seconds] 23:54 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 265 seconds] 23:54 -!- sturles [~sturles@ulrik.uio.no] has joined #bitcoin-core-dev 23:54 -!- sturles [~sturles@ulrik.uio.no] has quit [Changing host] 23:54 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 23:56 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev 23:57 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 23:57 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev --- Log closed Wed Apr 01 00:00:10 2020