--- Log opened Wed Apr 01 00:00:10 2020 --- Day changed Wed Apr 01 2020 00:00 -!- z3232 [~z323@ec2-54-234-151-68.compute-1.amazonaws.com] has joined #bitcoin-core-dev 00:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:01 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67a72466e1c0...b97e3a73498b 00:01 < bitcoin-git> bitcoin/master faa9491 MarcoFalke: ci: Use Focal for fuzzers 00:01 < bitcoin-git> bitcoin/master b97e3a7 fanquake: Merge #18477: ci: Use Focal for fuzzers 00:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:01 < bitcoin-git> [bitcoin] fanquake merged pull request #18477: ci: Use Focal for fuzzers (master...2003-ciFixFocalForFuzz) https://github.com/bitcoin/bitcoin/pull/18477 00:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:03 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 00:06 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 00:07 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 250 seconds] 00:08 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 00:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 00:23 -!- Kabaka [~Kabaka@195.206.169.238] has joined #bitcoin-core-dev 00:33 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 00:38 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 00:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:44 -!- vasild_ is now known as vasild 00:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 00:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 01:02 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 01:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds] 01:28 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:29 -!- jtimon [~quassel@206.160.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:30 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 01:35 -!- Kiminuo [~mix@141.98.103.78] has joined #bitcoin-core-dev 01:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:45 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 01:54 -!- Kabaka [~Kabaka@195.206.169.238] has quit [Ping timeout: 250 seconds] 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:01 < bitcoin-git> [bitcoin] pierreN opened pull request #18491: tests: add fuzing harness for custom abs value functions (master...test-abs-ub) https://github.com/bitcoin/bitcoin/pull/18491 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:03 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:11 < promag> wumpus: please #18487 02:11 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub 02:11 < promag> it's a simple change 02:12 < promag> just release cs_main and cs_wallet before calling rpcRunLater 02:13 -!- asdf49 [030d4d28@ec2-3-13-77-40.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 02:13 < promag> and I'm pretty confident that it avoids a deadlock case (makes node dead) 02:26 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev 02:27 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 02:28 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 02:30 -!- asdf49 [030d4d28@ec2-3-13-77-40.us-east-2.compute.amazonaws.com] has left #bitcoin-core-dev [] 02:34 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 02:38 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Quit: bye] 02:39 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 02:43 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 02:44 < wumpus> okay, thanks for investigating that one, added 0.20 milestone 02:47 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 02:48 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 02:48 -!- itnet7 [~itnet7@84.39.116.180] has joined #bitcoin-core-dev 02:48 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev 02:48 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 02:50 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 256 seconds] 02:50 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds] 02:50 -!- masterdonx2 [~masterdon@213.183.54.167] has joined #bitcoin-core-dev 02:51 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 02:51 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev 02:54 -!- MasterdonX [~masterdon@103.108.117.132] has quit [Ping timeout: 256 seconds] 03:06 -!- Sage53Beatty [~Sage53Bea@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:18 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 03:18 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 03:19 -!- binary01 [~binary01@cpe-74-71-15-170.nyc.res.rr.com] has joined #bitcoin-core-dev 03:25 < promag> thanks wumpus 03:32 < binary01> hello- does anyone know how to get ripemd160 hash using python3 hashlib? 03:39 < jonasschnelli> binary01: AFAIK hashlib does not support Rimemd160 03:39 < jonasschnelli> *ripemd160 03:39 < jonasschnelli> anyhow,... question is offtopic 03:41 < jonasschnelli> binary01: I guess you can use the OpenSSL provided algorithms: 03:41 < jonasschnelli> (with new) 03:41 < jonasschnelli> h = hashlib.new('ripemd160') 03:42 < binary01> hi jonas. thanks for your reply. i am trying that but getting incorrect hash 03:43 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 03:45 < jonasschnelli> binary01: incorrect hash sound strange. Byteorder? 03:46 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:46 < darosior> hashlib does support it 03:46 < darosior> But you need to use new('ripemd160') :-) 03:48 < binary01> when i try to to h.update on the hash i get error.. Unicode-objects must be encoded before hashing 03:48 < binary01> so i add .encode('utf-8') at the end 03:48 < binary01> hash doesnt match 03:48 < darosior> You need to pass bytes 03:49 < darosior> But let's get to #bitcoin as it's not core-related 03:49 < binary01> so i tried putting 'b' in front 03:50 < binary01> still getting wrong hash 03:50 -!- Sage53Beatty [~Sage53Bea@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds] 03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:54 < bitcoin-git> [bitcoin] laanwj opened pull request #18492: qt: Translations update pre-branch (master...2020_04_pre_branch_translations) https://github.com/bitcoin/bitcoin/pull/18492 03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:00 -!- apaval_ [~apaval@124.108.23.110] has quit [Remote host closed the connection] 04:00 -!- apaval_ [~apaval@124.108.23.110] has joined #bitcoin-core-dev 04:01 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:12 < elichai2> wumpus: Trying to understand the change that a lot of languages got their `_CountryCode` removed (ie `bitcoin_nl_NL.ts` or `bitcoin_he_IL.ts`) 04:12 < elichai2> were they duplicates and now removed? something else? 04:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 04:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:15 < wumpus> elichai2: a lot of pseudo-languages were removed, this was already a while ago, but was never applied to master 04:16 < wumpus> e.g. there were a lot of dialects that didn't make sense, or had no signifiant translations, or were completely faulty 04:19 < wumpus> nl_NL for example makes no sense that's simply the main language 04:20 < wumpus> and "nl" is used as fallback for say, nl_BE 04:23 < wumpus> binary01: if you're doing bitcoin things with python it makes sense to take a look at python-bitcoinlib, they've been doing this for ages and implemented all the hash and script stuff in python 04:23 < wumpus> (but they too use hashlib.new('ripemd160'), that must work) 04:24 < elichai2> wumpus: make sense. Thanks! 04:34 < binary01> wumpus, thanks but i got it working with hashlib 04:52 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 04:54 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 05:00 -!- itnet7 [~itnet7@84.39.116.180] has quit [] 05:00 -!- lucaferr [~lucaferr@2a00:801:3c5:8f9:3d0f:2e59:d43f:a710] has joined #bitcoin-core-dev 05:05 < wumpus> ok great! 05:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:11 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b97e3a73498b...41fa2926d86a 05:11 < bitcoin-git> bitcoin/master 740614e Wladimir J. van der Laan: qt: Translations update pre-branch 05:11 < bitcoin-git> bitcoin/master 41fa292 Wladimir J. van der Laan: Merge #18492: qt: Translations update pre-branch 05:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:12 < bitcoin-git> [bitcoin] laanwj merged pull request #18492: qt: Translations update pre-branch (master...2020_04_pre_branch_translations) https://github.com/bitcoin/bitcoin/pull/18492 05:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:18 -!- ferringb [~ferringb@192.145.126.115] has joined #bitcoin-core-dev 05:21 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 05:26 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:27 < bitcoin-git> [bitcoin] vasild opened pull request #18493: rpc: Remove deprecated "size" from mempool txs (master...remove_deprecated_rpc_tx_size) https://github.com/bitcoin/bitcoin/pull/18493 05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:30 < fanquake> vasild: I doubt that change is going into 0.20, so you won’t need to add release notes to the wiki. 05:31 < vasild> in general, am I supposed to edit the wiki myself? 05:32 < fanquake> Although I do see we said it would be removed, so I guess it was forgotten about. 05:32 < fanquake> Yes you should be able to edit it to add release notes. 05:32 < vasild> yes, I think it was forgotten. In any case, if not in 0.20 (too late?), then we remove it in 0.21 05:33 < vasild> fanquake: ack, about editing the wiki, I presume after a given PR gets merged :) 05:34 < fanquake> Is that the only RPC with a 0.20 notice? 05:34 < vasild> a few are already mentioned in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft#updated-rpcs 05:35 < fanquake> I meant left in the code that we said would be removed in 0.20 05:35 < vasild> wait, you mean the only rpc that is supposed to be deleted in 0.20? 05:37 < vasild> there is also this: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/rawtransaction.cpp#L838 05:37 < vasild> (and same on line 914 too) 05:38 < fanquake> Probably worth adding an additional commit(s) to take care of those TODOs and can be discussed in the PR 05:41 < vasild> I havent looked at those TODO comments yet, but they look unrelated to the "size" removal. Better deal with them in a separate PR. 05:45 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 06:45 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:50 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 06:59 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 06:59 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:18 < wumpus> heh yes, please edit the wiki only after something is merged, let's not get ahead of things 07:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 07:21 < wumpus> removing deprecated things is not really a hurry so i'd also say let's delay that to after the branch-off 07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:23 < bitcoin-git> [bitcoin] jonatack opened pull request #18494: test: replace (send_message + sync_with_ping) with send_and_ping (master...send_and_ping) https://github.com/bitcoin/bitcoin/pull/18494 07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:24 < bitcoin-git> [bitcoin] vasild opened pull request #18495: rpc: Remove deprecated migration code (master...remove_deprecated_migration_code) https://github.com/bitcoin/bitcoin/pull/18495 07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:24 < bitcoin-git> [bitcoin] jonatack opened pull request #18496: test: remove redundant sync_with_ping after add_p2p_connection (master...remove-redundant-sync_with_ping-calls) https://github.com/bitcoin/bitcoin/pull/18496 07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:26 < wumpus> I'll hold off the actual branch off / rc1 until after the meeting tomorrow, so we can discuss last-minute fixes 07:31 < vasild> wumpus: I agree, none of #18493 or #18495 code removals seem to classify for a "last minue sneak in" 07:31 < gribble> https://github.com/bitcoin/bitcoin/issues/18493 | rpc: Remove deprecated "size" from mempool txs by vasild · Pull Request #18493 · bitcoin/bitcoin · GitHub 07:31 < gribble> https://github.com/bitcoin/bitcoin/issues/18495 | rpc: Remove deprecated migration code by vasild · Pull Request #18495 · bitcoin/bitcoin · GitHub 07:31 -!- Kiminuo [~mix@141.98.103.78] has quit [Ping timeout: 258 seconds] 07:42 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 07:46 < luke-jr> IMO the build issue should probably be a blocker 07:46 < luke-jr> #18465 07:46 < gribble> https://github.com/bitcoin/bitcoin/issues/18465 | bitcoin-tx (and probably others) fails to build without libevent · Issue #18465 · bitcoin/bitcoin · GitHub 07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:48 < bitcoin-git> [bitcoin] jonatack opened pull request #18498: test: enable opening partial p2p connections where useful (master...allow-peer-conn-sans-sync) https://github.com/bitcoin/bitcoin/pull/18498 07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:52 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 07:52 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 08:00 -!- ferringb [~ferringb@192.145.126.115] has quit [] 08:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 08:14 -!- apaval_ [~apaval@124.108.23.110] has quit [Ping timeout: 265 seconds] 08:15 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:18 -!- kwm1 [~kwm@185.204.1.185] has joined #bitcoin-core-dev 08:37 -!- lucaferr [~lucaferr@2a00:801:3c5:8f9:3d0f:2e59:d43f:a710] has quit [Ping timeout: 272 seconds] 08:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 08:50 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:11be:312f:adcf:42dd] has joined #bitcoin-core-dev 08:51 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 08:54 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 08:55 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 08:57 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 08:58 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 08:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:02 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:08 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 09:09 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 09:13 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 09:19 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 09:19 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 09:22 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 252 seconds] 09:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:24 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18499: rpc: Make rpc documentation not depend on rpc args (master...2004-rpcStaticDoc) https://github.com/bitcoin/bitcoin/pull/18499 09:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:24 -!- jonatack [~jon@37.171.65.83] has joined #bitcoin-core-dev 09:57 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev 10:05 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 10:18 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 10:18 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 10:20 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 10:23 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 10:25 -!- dimac [~dc@2a01:d0:e3dd:0:f178:c6a1:9cf3:e1b6] has joined #bitcoin-core-dev 10:25 -!- jonatack_ [~jon@37.173.127.56] has joined #bitcoin-core-dev 10:25 -!- dimac [~dc@2a01:d0:e3dd:0:f178:c6a1:9cf3:e1b6] has quit [Client Quit] 10:25 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:26 -!- jonatack_ [~jon@37.173.127.56] has quit [Client Quit] 10:26 -!- jonatack_ [~jon@37.173.127.56] has joined #bitcoin-core-dev 10:28 -!- jonatack [~jon@37.171.65.83] has quit [Ping timeout: 265 seconds] 10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:30 < bitcoin-git> [bitcoin] dongcarl closed pull request #18478: build: Automatically include both `git`-tracked and bootstrapped files. (master...2020-03-adventures-in-reconciling-automake-and-git) https://github.com/bitcoin/bitcoin/pull/18478 10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:31 -!- Guyver2_ is now known as Guyver2 10:38 -!- jarthur [~jarthur@2605:6000:1019:4971:d92b:645d:968b:6713] has joined #bitcoin-core-dev 10:52 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 10:52 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 10:54 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [] 10:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:56 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 11:00 -!- kwm1 [~kwm@185.204.1.185] has quit [] 11:02 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has quit [Quit: r251d] 11:03 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 11:11 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 11:22 -!- edunham1 [~edunham@184.75.221.163] has joined #bitcoin-core-dev 11:22 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 11:22 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:26 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:37 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18500: chainparams: Bump assumed valid hash (master...2004-chainparamsBump) https://github.com/bitcoin/bitcoin/pull/18500 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:40 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:41 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:11be:312f:adcf:42dd] has quit [Quit: Sleep mode] 11:42 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 12:00 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 12:09 -!- Kiminuo [~mix@141.98.103.110] has joined #bitcoin-core-dev 12:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 12:17 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 12:17 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 12:18 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 12:22 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:22 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 12:25 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 12:28 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:35 -!- oguzkoroglu [~ogu@176.88.44.188] has joined #bitcoin-core-dev 12:36 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving] 12:37 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 12:40 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 12:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:44 -!- vasild_ is now known as vasild 12:50 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 13:04 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 13:08 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Ping timeout: 264 seconds] 13:08 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 13:15 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 13:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 13:22 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 13:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 13:37 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 13:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 13:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 13:44 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:45 -!- jtimon [~quassel@206.160.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 13:50 < Kiminuo> Hi, is Practicalswift (https://github.com/practicalswift) here by any chance under some other nickname? Well heck, I'll just ask right away. I have tried to run `src/test/fuzz/process_message qa-assets/fuzz_seed_corpus/process_message/` as explained here https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md#fuzzing-harnesses-fuzzing-output-and-fuzzing-corpora. I got some some new coverages. Is that valuable enough to make a PR? Still I 13:50 < Kiminuo> should probably learn more about fuzzing first here https://llvm.org/docs/LibFuzzer.html ... 13:53 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 265 seconds] 14:00 -!- edunham1 [~edunham@184.75.221.163] has quit [] 14:05 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 14:10 -!- owowo [~ovovo@s91904425.blix.com] has joined #bitcoin-core-dev 14:10 -!- owowo [~ovovo@s91904425.blix.com] has quit [Changing host] 14:10 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 14:20 -!- kenperkins [~kenperkin@84.39.116.180] has joined #bitcoin-core-dev 14:30 -!- Highway62 [~Thunderbi@192.252.213.14] has joined #bitcoin-core-dev 14:32 -!- Highway61 [~Thunderbi@104.223.95.34] has quit [Ping timeout: 264 seconds] 14:32 -!- Highway62 is now known as Highway61 14:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 14:35 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Quit: ZNC - https://znc.in] 14:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 14:44 -!- oguzkoroglu [~ogu@176.88.44.188] has quit [Ping timeout: 265 seconds] 14:52 < jonatack_> Kiminuo: there is also doc/fuzzing.md as a resource, if you haven't seen it yet. It was recently updated 14:52 < jonatack_> https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md 14:52 < Kiminuo> jonatack_, it's in my previous message ...? 14:53 < Kiminuo> :) 14:53 < Kiminuo> Yeah, well, I guess, I'll have to read more about it 14:53 < jonatack_> heh, long message, didn't see that far :) 14:54 < Kiminuo> Age of tweets :-(( 14:55 < ariard> if you try to ibd between 2 regtest nodes, CanDirectFetch fails because time of mined block is far ahead of genesis, is this intentional and known? 15:00 -!- ysangkok [janus@anubis.0x90.dk] has left #bitcoin-core-dev [] 15:00 -!- ryanofsky_ [~russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev 15:02 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 15:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 15:06 -!- cdecker_ [~cdecker@mail.snyke.net] has joined #bitcoin-core-dev 15:06 -!- amiller_ [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 15:08 -!- Netsplit *.net <-> *.split quits: cdecker, ryanofsky, esotericnonsense, amiller, infernix 15:10 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 15:11 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev 15:12 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 15:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 15:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 15:14 -!- michaelfolkson [~textual@host86-132-64-99.range86-132.btcentralplus.com] has joined #bitcoin-core-dev 15:15 -!- Netsplit over, joins: esotericnonsense 15:15 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 15:18 -!- michaelfolkson [~textual@host86-132-64-99.range86-132.btcentralplus.com] has quit [Client Quit] 15:20 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 15:21 -!- filchef [~fiilchef@212.104.97.177] has joined #bitcoin-core-dev 15:22 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 15:23 -!- filchef [~fiilchef@212.104.97.177] has quit [Client Quit] 15:24 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 15:31 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 15:33 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev 15:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 15:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 16:02 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:02 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 16:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:08 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:14 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 16:16 -!- Highway61 [~Thunderbi@192.252.213.14] has quit [Ping timeout: 250 seconds] 16:16 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 16:33 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 16:35 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:38 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 16:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 252 seconds] 16:38 -!- Highway61 [~Thunderbi@192.252.213.14] has joined #bitcoin-core-dev 16:40 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:43 -!- Highway61 [~Thunderbi@192.252.213.14] has quit [Ping timeout: 256 seconds] 16:45 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 16:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:00 -!- kenperkins [~kenperkin@84.39.116.180] has quit [] 17:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 17:19 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 256 seconds] 17:22 -!- Wolfy87 [~Wolfy87@176.113.74.179] has joined #bitcoin-core-dev 17:23 < instagibbs> achow101, re https://github.com/bitcoin/bitcoin/pull/16528#issuecomment-607520569 17:24 < instagibbs> We should think long and hard about use-cases that don't involve importing addresses. I think importing "mixed" descriptors where you own some privkeys but not all seems like something to look at? 17:26 < achow101> instagibbs: sure 17:26 < instagibbs> i dont think the "mutation" is as bad provided the user is asking for those sigs 17:26 < instagibbs> fwiw 17:26 < instagibbs> the ismine cleanup is much more important, making sure you don't think you got paid at an address you gave to someone 17:27 < achow101> i guess we want the wallet to behave in two different ways: 1) deal with scripts and track transactions related to those scripts; and 2) be a signer that has keys and just signs things ignoring the scripts 17:27 < instagibbs> sign loosely(provided user knows what they are signing), accept strictly 17:29 < instagibbs> So I think it's probably ok to eagerly sign whatever you can when asked, and separately support importing descriptors where you don't have all the keys(this should just make signing easier?) 17:29 < achow101> right 17:30 < instagibbs> Hm, something to mull over. 17:30 < achow101> there's also a bunch of places in the tests that use dumpprivkey to just get a private key for imports and stuff 17:30 < instagibbs> Is it too asinine to only allow xpubs, then multiwallet to have the xprv in another wallet? 17:31 < instagibbs> but yeah no export 17:31 < instagibbs> that's the rub eh 17:31 < achow101> but no export means those don't work 17:31 < achow101> i suppose we could add something to the test framework to generate private keys 17:31 < instagibbs> It seems like a very reasonable use-case to support. 17:32 < instagibbs> Core-generated key being in a multisig :) 17:32 < achow101> my original thoughts about the multisig stuff would be you have 2 wallets, one generated normally, and another watch only one for the multisig. so you then use psbt and multiwallet 17:33 < instagibbs> what's the hold-up on export? feature creep? 17:33 < achow101> security questions about unhardened derivation 17:34 < instagibbs> oh im overthinking, use-case is supported, *if* you can get the account-level xpub 17:34 < instagibbs> i can't recall what your PR supports 17:34 < achow101> currently no exports at all whatoever 17:35 < instagibbs> ok so I think public descriptor export is a thing we'd want to support 17:35 < achow101> yeah 17:35 < achow101> that'll be next 17:38 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 17:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 17:45 < sipa> achow101: i don't think being able to sign for non-"ismine" things is a problem 17:45 < sipa> as long as they're not counted 17:49 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 18:15 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 18:17 -!- Highway61 [~Thunderbi@192.252.213.14] has joined #bitcoin-core-dev 18:22 -!- Highway61 [~Thunderbi@192.252.213.14] has quit [Ping timeout: 265 seconds] 18:29 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 18:29 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Quit: ZNC - https://znc.in] 18:32 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev 18:46 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 18:51 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 265 seconds] 18:59 -!- Highway61 [~Thunderbi@192.252.213.14] has joined #bitcoin-core-dev 19:04 -!- Highway61 [~Thunderbi@192.252.213.14] has quit [Ping timeout: 256 seconds] 19:07 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:08 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 19:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:15 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Quit: ZNC - https://znc.in] 19:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 19:24 -!- Highway61 [~Thunderbi@192.252.213.14] has joined #bitcoin-core-dev 19:24 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 19:30 -!- Highway61 [~Thunderbi@192.252.213.14] has quit [Ping timeout: 240 seconds] 19:43 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:48 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 19:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 19:53 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Ping timeout: 250 seconds] 19:54 -!- promag__ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 20:00 -!- Wolfy87 [~Wolfy87@176.113.74.179] has quit [] 20:48 -!- xrogaan [~xrogaan@77.243.177.38] has joined #bitcoin-core-dev 20:49 -!- xrogaan is now known as Guest17873 20:53 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds] 20:56 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 21:05 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 21:30 -!- oguzkoroglu [~ogu@176.88.44.188] has joined #bitcoin-core-dev 21:41 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 21:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:15 -!- oguzkoroglu [~ogu@176.88.44.188] has quit [Ping timeout: 256 seconds] 22:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 22:25 -!- jonatack__ [~jon@37.170.215.215] has joined #bitcoin-core-dev 22:25 -!- oguzkoroglu [~ogu@176.88.44.188] has joined #bitcoin-core-dev 22:27 -!- ogu [~ogu@213.74.213.65] has joined #bitcoin-core-dev 22:28 -!- jonatack_ [~jon@37.173.127.56] has quit [Ping timeout: 256 seconds] 22:30 -!- oguzkoroglu [~ogu@176.88.44.188] has quit [Ping timeout: 256 seconds] 22:32 -!- ogu [~ogu@213.74.213.65] has quit [Quit: Leaving] 22:33 -!- ogu [~ogu@213.74.213.65] has joined #bitcoin-core-dev 22:33 -!- ogu [~ogu@213.74.213.65] has quit [Remote host closed the connection] 22:33 -!- oguzkoroglu [~ogu@213.74.213.65] has joined #bitcoin-core-dev 22:48 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 22:48 < fanquake> wumpus / sipa: can you block Angelika1920 22:52 -!- Kiminuo [~mix@141.98.103.110] has quit [Ping timeout: 256 seconds] 22:53 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 250 seconds] 22:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:59 < bitcoin-git> [bitcoin] fanquake closed pull request #18489: Rebrand to Bitcoin Corrr (master...2004-rebrandCorrr) https://github.com/bitcoin/bitcoin/pull/18489 22:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:00 -!- Guest17873 [~xrogaan@77.243.177.38] has quit [] 23:00 -!- Kiminuo [~mix@141.98.103.174] has joined #bitcoin-core-dev 23:07 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 23:19 -!- michal_kubenka [~michal_ku@176.113.74.179] has joined #bitcoin-core-dev 23:32 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 23:32 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection] 23:32 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 23:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 23:52 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev --- Log closed Thu Apr 02 00:00:40 2020