--- Log opened Mon Apr 06 00:00:44 2020
00:01 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:19 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
00:23 -!- anditto [~anditto@240d:1a:29:b700:450f:d014:769a:551] has joined #bitcoin-core-dev
00:27 -!- anditto [~anditto@240d:1a:29:b700:450f:d014:769a:551] has quit [Ping timeout: 265 seconds]
00:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
00:35 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
00:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 260 seconds]
00:40 -!- anditto [~anditto@240d:1a:29:b700:450f:d014:769a:551] has joined #bitcoin-core-dev
00:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
00:42 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
00:44 -!- vasild_ is now known as vasild
00:44 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:45 < sipa>  fanquake: done
01:00 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:01 < bitcoin-git> [bitcoin] fanquake opened pull request #18535: build: remove -Qunused-arguments workaround for clang + ccache (master...dont_quash_unused_driver_arguments) https://github.com/bitcoin/bitcoin/pull/18535
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:07 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
01:13 -!- irc_user826134 [~irc_user8@ip5650b10d.direct-adsl.nl] has joined #bitcoin-core-dev
01:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:28 -!- kljasdfvv [~flack@p200300D46F0C1400C165798E68F0FBAF.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
01:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:49 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection]
01:49 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
01:54 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
01:57 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
01:57 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
02:00 -!- leoburd [~leoburd@2.58.47.203] has quit []
02:16 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
02:17 < aj> huh, when trying to reference a pr in github, you can type "#" then some text from the topic and press enter on the one you want, and it'll replace the text you typed with the correct pr number. convenient!
02:19 < fanquake> very
02:20 -!- feb [~feb@176.113.74.179] has joined #bitcoin-core-dev
02:20 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
02:21 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #bitcoin-core-dev
02:33 -!- anditto [~anditto@240d:1a:29:b700:450f:d014:769a:551] has quit [Remote host closed the connection]
02:38 -!- sonofhan [~sonofhan@ip72-193-7-145.lv.lv.cox.net] has joined #bitcoin-core-dev
02:41 -!- cajetanp [~cajetan@5.151.46.31] has joined #bitcoin-core-dev
02:49 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
02:50 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
02:52 -!- cajetanp [~cajetan@5.151.46.31] has quit [Quit: WeeChat 2.8]
02:53 -!- someone235 [uid419897@gateway/web/irccloud.com/x-ubqjsfjotlcznuft] has joined #bitcoin-core-dev
02:56 -!- hkjn0 [~hkjn@163.172.184.153] has quit [Ping timeout: 256 seconds]
03:03 -!- Miller30Fritsch [~Miller30F@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:11 -!- anditto [~anditto@240d:1a:29:b700:450f:d014:769a:551] has joined #bitcoin-core-dev
03:15 -!- anditto [~anditto@240d:1a:29:b700:450f:d014:769a:551] has quit [Ping timeout: 260 seconds]
03:27 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds]
03:35 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
03:35 -!- sonofhan [~sonofhan@ip72-193-7-145.lv.lv.cox.net] has quit [Quit: Leaving...]
03:38 < wumpus> oh good find!
03:47 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
03:50 -!- Miller30Fritsch [~Miller30F@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds]
03:51 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
03:54 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev
03:57 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
04:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:17 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
04:22 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
04:28 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:30 < wumpus> I guess it's time to branch off and wrap up 0.20.0rc1 today
04:31 < instagibbs> \o/
04:32 -!- anditto [~anditto@240d:1a:29:b700:450f:d014:769a:551] has joined #bitcoin-core-dev
04:32 -!- anditto [~anditto@240d:1a:29:b700:450f:d014:769a:551] has quit [Client Quit]
04:37 < luke-jr> wumpus: #18192 has some potential improvements, but also 3 ACKs, so hesitant to touch it - seems better to follow up with the rest in another PR
04:37 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:39 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/516ebe8a62de...adac12ae73e8
04:39 < bitcoin-git> bitcoin/master 0eeb046 Wladimir J. van der Laan: net: Hardcoded seeds update for 0.20
04:39 < bitcoin-git> bitcoin/master adac12a Wladimir J. van der Laan: Merge #18506: net: Hardcoded seeds update for 0.20
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:39 < bitcoin-git> [bitcoin] laanwj merged pull request #18506: net: Hardcoded seeds update for 0.20 (master...2020_04_hardcoded_seeds) https://github.com/bitcoin/bitcoin/pull/18506
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:41 < wumpus> why did #18524 get added to 0.20?
04:41 < gribble> https://github.com/bitcoin/bitcoin/issues/18524 | refactor: drop boost::signals2 in validationinterface by ryanofsky · Pull Request #18524 · bitcoin/bitcoin · GitHub
04:43 < wumpus> seems a good change but why do such a (potentialy risky) refactor last-minute before a release
04:45 < instagibbs> luke-jr, imo adding the test(as new commit) is fine to get merged if 3 acks sans test was enough :)
04:51 -!- ryanofsky_ [~russ@jumpy.yanofsky.org] has left #bitcoin-core-dev []
04:51 -!- ryanofsky [~russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev
04:51 < ryanofsky> wumpus, i don't know if it should be added to 0.20, but it fixes a hang #18517 caused by #18338 that happens with old boost versions
04:51 < gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
04:51 < gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
04:51 < ryanofsky> alternative would be to revert #18338
04:51 < gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
04:52 < wumpus> ryanofsky: let's label it as a bugfix then
04:54 < ryanofsky> that's fine. it is a refactor with new versions of boost, a bugfix with old versions of boost
04:55 < wumpus> a fix for a hang caused by a fix for another hang
04:55 < wumpus> well if it is boost versions that are still supported that's kind of important
04:57 < wumpus> in any case, independent of that PR, it might be that we don't have enough active reviewers to really do a 0.20 release right now
04:58 < wumpus> this is what I was afraid of about a month ago
04:58 < luke-jr> could still spin a rc1
04:59 < ryanofsky> i would just revert #18517, a bugfix for a rare bug caused a more serious bug, so drop it
04:59 < gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
04:59 < ryanofsky> revert #18338 I mean
04:59 < gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
05:00 -!- feb [~feb@176.113.74.179] has quit []
05:00 < wumpus> ryanofsky: maybe revert it after the 0.20 branch? then go forward with your PR on master
05:02 < wumpus> I mean, it still makes sense as a refactor
05:02 < ryanofsky> i don't know how things are normally done. i'd revert it on master for but some reason bitcoin projects treats reverts as more of a big deal than other projects i've worked on
05:03 < wumpus> but does your PR solve the original issue that #18338 solved, too?
05:03 < gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
05:04 < wumpus> it seems that not fixing that issue at all (in master, at least) is strictly worse
05:05 < ryanofsky> no, my pr is really just a refactor that doesn't change bitcoin behavior. #18338 is an actual bugfix but the implementation relies on behavior only implemented in new boost versions
05:05 < gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
05:06 < ryanofsky> #18338 is a weird corner case issue that's been around for a few releases, while #18517 is a serious new regression
05:06 < gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
05:06 < gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
05:07 < ryanofsky> if you want to fix both reverting won't work, but the issue 18338 fixes is a crash that happens when loading and unloading the same wallet repeatedly in a loop
05:08 < ryanofsky> the issue 18338 causes is a hang on shutdown with ctrl-c, though only with old boost versions
05:09 < ryanofsky> reverting might not be appropriate here because we rarely revert
05:09 < wumpus> yes, so I think reverting the fix for the weird corner case on 0.20 is acceptable to solve the more serious issue there, but if your refactor (which will go into master) solves the ensuing issue I don't see the point of reverting it on master too
05:10 < wumpus> alternatively we should just merge your PR into 0.20 too
05:10 < wumpus> I mean it has ACKs, more than some other 0.20-tagged things
05:11 < ryanofsky> yep, either way is reasonable
05:21 -!- defnordic [~defnordic@185.169.255.76] has joined #bitcoin-core-dev
05:33 < fanquake> ryanofsky: you don’t necessarily need to be loading and unloading in a loop. The wallet crash can happen with just a wallet close/unload.
05:35 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.8]
05:36 -!- irc_user826134 [~irc_user8@ip5650b10d.direct-adsl.nl] has quit [Ping timeout: 265 seconds]
05:37 -!- irc_user826134 [~irc_user8@ip5650b10d.direct-adsl.nl] has joined #bitcoin-core-dev
05:56 -!- irc_user826134 [~irc_user8@ip5650b10d.direct-adsl.nl] has quit []
06:01 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev
06:08 -!- Highway61 [~Thunderbi@161.129.71.58] has quit [Quit: Highway61]
06:11 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds]
06:11 -!- morcos_ [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
06:12 -!- morcos_ is now known as morcos
06:15 -!- Highway61 [~Thunderbi@104.223.94.250] has joined #bitcoin-core-dev
06:25 < jonatack> fwiw i'll be reviewing 0
06:25 < jonatack> prs tagged v0.20 today, priority guidance welcome 
06:26 < jonatack> among the list at https://github.com/bitcoin/bitcoin/milestone/42
06:26 < luke-jr> zero PRs? :x
06:26 < jonatack> s/0/0.20/ :x
06:28 -!- promag_ is now known as promag
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/adac12ae73e8...299544f9c537
06:29 < bitcoin-git> bitcoin/master c0c43ae fanquake: test: skip backwards compat tests if not compiled with wallet
06:29 < bitcoin-git> bitcoin/master 299544f MarcoFalke: Merge #18534: test: skip backwards compat tests if not compiled with walle...
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18534: test: skip backwards compat tests if not compiled with wallet (master...skip_feature_compat_no_wallet) https://github.com/bitcoin/bitcoin/pull/18534
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:31 < jonatack> luke-jr: are you planning to update #18192 (3 acks) with the test addition and review comments?
06:31 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
06:32 < promag> wumpus, ryanofsky: how about updating minimum boost version?
06:32 < promag> depends uses 1.70.0
06:33 < luke-jr> jonatack: don't want to lose the ACKs
06:33 < promag> not against merging ryanofsky refactor
06:33 < luke-jr> jonatack: feel free to re-ACK the test commit too, though, in case a merge-person wants me to include that
06:33 < promag> which seems fine btw
06:40 < fanquake> promag why update minimum boost?
06:42 < promag> #18517 only happens with boost < 1.59.0 
06:42 < gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
06:47 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
06:47 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
06:52 < hebasto> promag: #16381
06:52 < gribble> https://github.com/bitcoin/bitcoin/issues/16381 | Set minimum required Boost to 1.53.0 by hebasto · Pull Request #16381 · bitcoin/bitcoin · GitHub
06:54 < promag> hebasto: thanks!
06:55 < hebasto> it seems boost 1.59+ is not a choice for Centos 7 and ubuntu xenial
06:56 < promag> so from fanquake comment, Jessie, Xenial, Trusty OpenBSD have <1.59 ?
06:56 < promag> oh and centos7
06:57 < hebasto> https://packages.ubuntu.com/xenial/libboost-dev
06:58 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
06:58 < promag> ok ¯\_(ツ)_/¯
07:08 < wumpus> promag: I have a slight preference to solve the problem instead of burying it that way
07:10 < promag> when you say "solve" you mean ditch boost
07:10 < wumpus> in the long run but I really meant merging ryanofsky 's refactor/fix
07:11 < promag> because the problem is solved in boost>1.58
07:11 < wumpus> but we have that PR already that fixes the problem
07:12 < promag> yeah, I ack that. just saying that we can hit this problem again in other boost signals2 usage
07:12 < wumpus> then let's move away from signals2 use
07:12 < wumpus> I think there's already been movement in that direction in other places
07:13 < promag> sure sgtm
07:14 < wumpus> for example, another thing people have een complaining about boost::signals2 is terribly noisy gdb backtraces
07:17 < wumpus> I only asked why #18524 was added to 0.20 because I was genuinely suprised a refactor was added, that was cleared up quickly, I like the PR itself, I don't particularly think we need an alternative solution
07:17 < gribble> https://github.com/bitcoin/bitcoin/issues/18524 | refactor: drop boost::signals2 in validationinterface by ryanofsky · Pull Request #18524 · bitcoin/bitcoin · GitHub
07:18 < promag> yeah, sad behavior change with < 1.59.0
07:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
07:29 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
07:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
07:38 -!- Kiminuo [~mix@141.98.103.142] has quit [Ping timeout: 240 seconds]
07:42 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:45 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
07:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:46 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/299544f9c537...fdeb445a34a9
07:46 < bitcoin-git> bitcoin/master d6815a2 Russell Yanofsky: refactor: drop boost::signals2 in validationinterface
07:46 < bitcoin-git> bitcoin/master fdeb445 Wladimir J. van der Laan: Merge #18524: refactor: drop boost::signals2 in validationinterface
07:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:47 < bitcoin-git> [bitcoin] laanwj merged pull request #18524: refactor: drop boost::signals2 in validationinterface (master...pr/nosig) https://github.com/bitcoin/bitcoin/pull/18524
07:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:49 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
07:51 < luke-jr> speaking of unnecessary refactors <.<
07:51 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds]
07:52 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
07:53 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
07:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
07:55 -!- jarthur [~jarthur@2605:6000:1019:4971:4895:9243:5704:7e8b] has joined #bitcoin-core-dev
07:56 -!- jarthur [~jarthur@2605:6000:1019:4971:4895:9243:5704:7e8b] has quit [Remote host closed the connection]
07:57 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #bitcoin-core-dev
07:57 < wumpus> this one is necessary, see above discussion
07:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:58 < wumpus> it's a bugfix and should probably have been called that but with so many ACKs it's abad idea to start changing commit messages
07:59 < luke-jr> ah
08:00 < luke-jr> I saw that, just didn't make the connection XD
08:00 -!- defnordic [~defnordic@185.169.255.76] has quit []
08:01 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
08:08 < ryanofsky> it is a refactor if you're using a new boost version, a change in behavior / bugfix if using an old boost
08:10 < wumpus> right
08:11 < wumpus> it's a refactor that moves a potentially buggy dependency out of the way
08:20 -!- jes1 [~jes@185.204.1.185] has joined #bitcoin-core-dev
08:23 -!- jarthur [~jarthur@2605:6000:1019:4971:4895:9243:5704:7e8b] has joined #bitcoin-core-dev
08:23 -!- Aaronvan_ is now known as AaronvanW
08:28 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds]
08:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:37 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18471: qa: Test shared validation interface (master...2020-03-test-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18471
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:37 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18471: qa: Test shared validation interface (master...2020-03-test-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18471
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fdeb445a34a9...425a7f900ed8
08:39 < bitcoin-git> bitcoin/master 25e03ba Jon Atack: test: relax bumpfee dust_to_fee txsize an extra vbyte
08:39 < bitcoin-git> bitcoin/master 425a7f9 MarcoFalke: Merge #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte
08:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte (master...relax-dust_to_fee-test) https://github.com/bitcoin/bitcoin/pull/18516
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:40 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
08:42 -!- Pierre25Hilll [~Pierre25H@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
08:48 < MarcoFalke> > [04:56] <luke-jr> Is there a reason we don't gitian-sign each individual file in addition to the packaged/tar files?
08:48 < MarcoFalke> The tar is a concatenation of the individual files, so the signature on it includes the individual files already
08:48 < MarcoFalke> > [06:25] <luke-jr> right now, we have zero way for users to verify snap installs
08:49 < MarcoFalke> ^ So this is not true
08:49 < luke-jr> MarcoFalke: short of redownloading and comparing the tarball binaries..
08:50 < luke-jr> also see our website
08:50 < luke-jr> "While the Snap packages use the deterministically generated executables, the Snap tool itself does not provide a streamlined way to reveal the contents of a Snap package. Thus, the Bitcoin Core project does not have the information necessary to help you verify the Bitcoin Core Snap packages."
08:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:51 < bitcoin-git> [bitcoin] practicalswift opened pull request #18539: Avoid using locale-dependent boost trim functions in RPCAuthorized(…) and bitcoin-tx (master...avoid-locale-dependent-trim) https://github.com/bitcoin/bitcoin/pull/18539
08:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:51 -!- Pierre25Hilll [~Pierre25H@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds]
09:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
09:04 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
09:20 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:21 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
09:25 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
09:26 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
09:34 -!- Kiminuo [~mix@141.98.103.142] has joined #bitcoin-core-dev
09:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
09:36 < wumpus> can we have some more review on  #18484 please
09:36 < gribble> https://github.com/bitcoin/bitcoin/issues/18484 | rpc: Correctly compute redeemScript from witnessScript for signrawtransaction by achow101 · Pull Request #18484 · bitcoin/bitcoin · GitHub
09:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:40 < bitcoin-git> [bitcoin] jonatack opened pull request #18540: test: wallet_bumpfee assertion fixup (master...bumpfee-test-assertion-fixup) https://github.com/bitcoin/bitcoin/pull/18540
09:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:49 < jonatack> wumpus: thanks, looking at 18484 
09:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:56 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18541: rpc: Make verifychain default values static, not depend on global args (master...2004-rpcStaticDefaults) https://github.com/bitcoin/bitcoin/pull/18541
09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:59 < wumpus> thanks! it's a one-line change, apart from test changes
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:01 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/425a7f900ed8...c0b389b33516
10:01 < bitcoin-git> bitcoin/master cd3b156 Andrew Chow: Correctly compute redeemScript from witnessScript for signrawtransaction
10:01 < bitcoin-git> bitcoin/master c0b389b MarcoFalke: Merge #18484: rpc: Correctly compute redeemScript from witnessScript for s...
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:01 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:06 -!- RubenSomsen_ is now known as RubenSomsen
10:07 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:09 < bitcoin-git> [bitcoin] promag opened pull request #18542: 0.19: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (0.19...2020-04-backport-18160) https://github.com/bitcoin/bitcoin/pull/18542
10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:12 < luke-jr> wumpus: how should I wrap up #18192?
10:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:14 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18543: test: Properly sync utxo set to avoid race (master...2004-testFixes) https://github.com/bitcoin/bitcoin/pull/18543
10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
10:16 < MarcoFalke> PSA: If you see an (intermittent) test failure, please open a bug report with a link to the log.
10:17 < MarcoFalke> Just resetting the build will make all intermittent failures accumulate and put the test suite in an unusable state where all failures are ignored and just re-run.
10:21 < sipa> MarcoFalke: ack
10:21 < sipa> (i occasionally did reset build failures)
10:34 -!- binarybonanza [~binarybon@91.92.244.11] has joined #bitcoin-core-dev
10:48 -!- modfort [5a2e6615@lfbn-idf3-1-1030-21.w90-46.abo.wanadoo.fr] has joined #bitcoin-core-dev
10:48 -!- Highway62 [~Thunderbi@96.44.142.186] has joined #bitcoin-core-dev
10:49 -!- Highway61 [~Thunderbi@104.223.94.250] has quit [Ping timeout: 250 seconds]
10:49 -!- Highway62 is now known as Highway61
10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:59 < bitcoin-git> [bitcoin] theStack opened pull request #18544: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear') (master...20200406-net-limit_bip37_filter_lifetime) https://github.com/bitcoin/bitcoin/pull/18544
10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:00 -!- jes1 [~jes@185.204.1.185] has quit []
11:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:05 -!- wumpus2 [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
11:05 -!- modfort [5a2e6615@lfbn-idf3-1-1030-21.w90-46.abo.wanadoo.fr] has quit [Ping timeout: 240 seconds]
11:06 -!- nejon_ [sid38993@gateway/web/irccloud.com/x-jmkhusdnnwcdprrk] has joined #bitcoin-core-dev
11:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
11:08 -!- nejon [sid38993@gateway/web/irccloud.com/x-dizitmwvtssjoouv] has quit [Ping timeout: 246 seconds]
11:08 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Read error: Connection reset by peer]
11:08 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 246 seconds]
11:08 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds]
11:08 -!- nejon_ is now known as nejon
11:08 -!- jonatack_ [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
11:08 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev
11:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:22 -!- FalconKirtaran [~FalconKir@141.98.101.133] has joined #bitcoin-core-dev
11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:23 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b389b33516...54d5ba3d9cb4
11:23 < bitcoin-git> bitcoin/master b224b4e Jon Atack: test: wallet_bumpfee assertion fixup
11:23 < bitcoin-git> bitcoin/master 54d5ba3 MarcoFalke: Merge #18540: test: wallet_bumpfee assertion fixup
11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:23 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18540: test: wallet_bumpfee assertion fixup (master...bumpfee-test-assertion-fixup) https://github.com/bitcoin/bitcoin/pull/18540
11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:26 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:26 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:30 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54d5ba3d9cb4...75021e80ee44
11:30 < bitcoin-git> bitcoin/master 7b8e157 João Barbosa: rpc: Fix rpcRunLater race in walletpassphrase
11:30 < bitcoin-git> bitcoin/master 75021e8 Wladimir J. van der Laan: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:30 < bitcoin-git> [bitcoin] laanwj merged pull request #18487: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:36 -!- jarthur [~jarthur@2605:6000:1019:4971:4895:9243:5704:7e8b] has quit [Remote host closed the connection]
11:36 -!- jarthur [~jarthur@2605:6000:1019:4971:e06c:b522:dfd9:7f9f] has joined #bitcoin-core-dev
11:37 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
12:01 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:03 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
12:04 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
12:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:06 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75021e80ee44...c31bcaf203b5
12:06 < bitcoin-git> bitcoin/master fa36965 MarcoFalke: net: Add missing cs_vNodes lock
12:06 < bitcoin-git> bitcoin/master c31bcaf Wladimir J. van der Laan: Merge #18458: net: Add missing cs_vNodes lock
12:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:07 < bitcoin-git> [bitcoin] laanwj merged pull request #18458: net: Add missing cs_vNodes lock (master...2003-netLock) https://github.com/bitcoin/bitcoin/pull/18458
12:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:07 -!- wumpus2 is now known as wumpus
12:09 < wumpus> MarcoFalke: I generally do that, unless it's something clearly travis related like a timeout in fetching packages
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:13 < bitcoin-git> [bitcoin] jonatack opened pull request #18545: test: refactor rpc_signrawtransaction and add logging (master...refactor-rpc_signrawtransaction) https://github.com/bitcoin/bitcoin/pull/18545
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:14 < wumpus> as it's often is
12:15 < wumpus> luke-jr: I agree with jnewbery's comment, if there's an actual error return mechanism that's better than asserting
12:19 < wumpus> I think asserts (and other "crash the program now") should be used in cases the client is really in a unrecoverable, buggy state, I'm not sure that's the case here
12:21 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
12:27 < luke-jr> well, it's a code error if we get there
12:32 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
12:40 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Quit: ZNC 1.7.5 - https://znc.in]
12:40 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev
12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
12:46 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
12:46 -!- rjected_ [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Quit: ZNC 1.7.4+deb0+disco0 - https://znc.in]
12:47 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
12:49 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
12:50 -!- jarthur [~jarthur@2605:6000:1019:4971:e06c:b522:dfd9:7f9f] has quit []
12:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/c31bcaf203b5...c5966a87d1fd
12:52 < bitcoin-git> bitcoin/master b86cd15 Luke Dashjr: scripted-diff: Wallet: Rename mapAddressBook to m_address_book
12:52 < bitcoin-git> bitcoin/master 144b2f8 Luke Dashjr: Wallet: Require usage of new CAddressBookData::setLabel to change label
12:52 < bitcoin-git> bitcoin/master 65b6bdc Luke Dashjr: Wallet: Add CAddressBookData::IsChange which returns true iff label has ne...
12:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:54 < luke-jr> doh
12:54 < luke-jr> I had just done that change >_<
12:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:54 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18192: Bugfix: Wallet: Safely deal with change in the address book (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18192
12:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:55 < MarcoFalke> Whoopsie
12:56 < MarcoFalke> Missed the message on IRC
12:57 < MarcoFalke> At least the three ACKs weren't invalidated 😅
12:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:58 < bitcoin-git> [bitcoin] luke-jr opened pull request #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2] (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18546
12:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:02 -!- jarthur [~jarthur@2605:6000:1019:4971:99bd:b501:ca26:4cf4] has joined #bitcoin-core-dev
13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:23 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5966a87d1fd...abc145c9a4ae
13:23 < bitcoin-git> bitcoin/master fa2251d MarcoFalke: test: Use one node to avoid a race due to missing sync in rpc_signrawtrans...
13:23 < bitcoin-git> bitcoin/master abc145c MarcoFalke: Merge #18543: test: Use one node to avoid a race due to missing sync in rp...
13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:23 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18543: test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction (master...2004-testFixes) https://github.com/bitcoin/bitcoin/pull/18543
13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:26 -!- Krellan_ [~Krellan@2601:640:4100:e:99eb:1dee:4c68:31b9] has quit [Remote host closed the connection]
13:26 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:26 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has joined #bitcoin-core-dev
13:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
13:32 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has quit [Ping timeout: 265 seconds]
13:42 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
13:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
13:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:51 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18507: test: Check that calling walletpasshprase does not freeze the node (master...2004-qaWalletFreeze) https://github.com/bitcoin/bitcoin/pull/18507
13:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:54 < MarcoFalke> ok, we fixed all bugs! Ship it!?!
13:59 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #bitcoin-core-dev
13:59 < sipa> MarcoFalke: do we use -use_value_profile=1 anywhere in fuzzing?
14:00 -!- FalconKirtaran [~FalconKir@141.98.101.133] has quit []
14:02 < MarcoFalke> sipa: It is a run-time flag you can enable when searching for seeds. It doesn't help when merely iterating over existing seeds (this is what travis is doing)
14:02 < sipa> MarcoFalke: sure
14:02 < sipa> but the seeds we have in in qa-assets directory, are they produced with that option enabled?
14:03 < MarcoFalke> I didn't know the option exists until you told me about it ;)
14:03 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving]
14:03 < sipa> it seems oss-fuzz uses it for a percentage of their runs
14:03 < sipa> and always when -merge=1'ing
14:04 < MarcoFalke> oh, hmm
14:05 < MarcoFalke> We don't so we should maybe fix that: use_value_profile
14:05 < sipa> with the fuzzer for asmap i've been working on, it seems that without that option, you very quickly converge on a set of seeds where no NEW lines appear anymore (or very rarely)
14:06 < sipa> my intuition is that for actual testing this option isn't very useful
14:06 < MarcoFalke> https://github.com/bitcoin/bitcoin/blob/abc145c9a4aef8ec269b7e0a3e9403cff9970fe4/test/fuzz/test_runner.py#L149
14:06 < MarcoFalke> This is what I wanted to copy-paste
14:06 < MarcoFalke> For some reason I can only copy one thing with the clipboard and then have to restart :thinking:
14:06 < sipa> but it may help find "intermediate" fuzzer inputs that have a better chance of being mutated into useful ones
14:08 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 256 seconds]
14:08 < MarcoFalke> Yes, I suspect it should help with structs that have state and already full line coverage
14:09 < sipa> the default feature set tracker (without -use_value_profile) is already much wider than just coverage in the typical sense, i believe
14:09 < sipa> use_value_profile expands it further
14:14 < luke-jr> ugh, moving on, I'm beginning to question that address book bugfix (it's still safe/good, but not something we can rely on really)
14:16 -!- jarthur [~jarthur@2605:6000:1019:4971:99bd:b501:ca26:4cf4] has quit [Remote host closed the connection]
14:18 -!- jarthur [~jarthur@2605:6000:1019:4971:99bd:b501:ca26:4cf4] has joined #bitcoin-core-dev
14:20 < MarcoFalke> Just used use_value_profile on a toy example and it seems to slow down the fuzzing and make it take longer to find my hidden crash. Obviously my toy example isn't representative, but it shouldn't be enabled for all searches.
14:21 < sipa> agree
14:21 -!- nevada-smith [~nevada-sm@195.206.169.238] has joined #bitcoin-core-dev
14:21 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
14:28 -!- jarthur [~jarthur@2605:6000:1019:4971:99bd:b501:ca26:4cf4] has quit [Remote host closed the connection]
14:34 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
14:40 -!- jarthur [~jarthur@2605:6000:1019:4971:99bd:b501:ca26:4cf4] has joined #bitcoin-core-dev
14:42 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has joined #bitcoin-core-dev
14:42 < sipa> ryanofsky: making sure you don't miss this: https://github.com/bitcoin/bitcoin/pull/18524/files#r404395685
14:44 < ryanofsky> thanks, will fix
14:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:47 < bitcoin-git> [bitcoin] hebasto opened pull request #18549: qt: Fix Window -> Minimize menu item (master...20200406-fix-minimize) https://github.com/bitcoin/bitcoin/pull/18549
14:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:48 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
14:48 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
14:49 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has quit [Ping timeout: 260 seconds]
14:49 < hebasto> promag: ^
14:51 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
14:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
14:59 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
15:09 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.8]
15:11 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
15:11 -!- wullon [~wullon@241.243.86.88.rdns.comcable.net] has quit [Quit: Ping timeout (120 seconds)]
15:13 -!- wullon [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev
15:28 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
15:28 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
15:35 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has joined #bitcoin-core-dev
15:42 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has quit [Ping timeout: 260 seconds]
15:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]
15:57 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
16:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
16:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
16:06 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
16:08 -!- murray [~murray@static.56.37.130.94.clients.your-server.de] has joined #bitcoin-core-dev
16:08 -!- murray is now known as Guest73993
16:10 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
16:11 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
16:12 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds]
16:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:14 -!- Guest73993 [~murray@static.56.37.130.94.clients.your-server.de] has left #bitcoin-core-dev []
16:14 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has joined #bitcoin-core-dev
16:14 -!- murrayn [~murray@unaffiliated/murrayn] has joined #bitcoin-core-dev
16:18 -!- owowo [~ovovo@s91904424.blix.com] has joined #bitcoin-core-dev
16:18 -!- owowo [~ovovo@s91904424.blix.com] has quit [Changing host]
16:18 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
16:21 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has quit [Ping timeout: 260 seconds]
16:23 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
16:23 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
16:32 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds]
16:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:40 < bitcoin-git> [bitcoin] luke-jr opened pull request #18550: Store destdata for change in separate key for backward compatibility (master...changedata) https://github.com/bitcoin/bitcoin/pull/18550
16:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:41 < luke-jr> ^ this feels like it really needs tests, but I'm not sure what the best way to do that is, since it's all about compatibility with older versions
16:51 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has joined #bitcoin-core-dev
17:00 -!- nevada-smith [~nevada-sm@195.206.169.238] has quit []
17:02 -!- Krellan_ [~Krellan@2601:640:4100:e:ec9b:b457:c0be:5a0f] has quit [Ping timeout: 260 seconds]
17:03 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
17:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
17:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
17:13 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
17:16 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
17:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 260 seconds]
17:21 -!- jayg [~jayg@84.39.117.57] has joined #bitcoin-core-dev
18:13 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 256 seconds]
18:25 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
18:30 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]
18:35 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
18:36 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
18:37 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
18:37 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
18:37 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
18:38 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
18:39 -!- jarthur [~jarthur@2605:6000:1019:4971:99bd:b501:ca26:4cf4] has quit []
18:42 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
18:43 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
18:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
18:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
18:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
18:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
19:02 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
19:03 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
19:08 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds]
19:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:18 < bitcoin-git> [bitcoin] sipa opened pull request #18551: Do not clear validationinterface entries being executed (master...202004_fix_validation_notify_clear) https://github.com/bitcoin/bitcoin/pull/18551
19:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:00 -!- jayg [~jayg@84.39.117.57] has quit []
20:13 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
20:18 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
20:22 -!- paultag [~paultag@84.39.117.57] has joined #bitcoin-core-dev
20:22 -!- paultag is now known as Guest3220
20:28 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com]
20:33 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:34 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
20:37 -!- Highway61 [~Thunderbi@96.44.142.186] has quit [Ping timeout: 250 seconds]
20:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
20:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
20:53 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
20:57 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
21:01 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
21:06 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Ping timeout: 260 seconds]
21:12 < fanquake> Have moved #15774 from 0.20.0 to the future milestone. Shouldn't be anything more than needs doing there for this release.
21:12 < gribble> https://github.com/bitcoin/bitcoin/issues/15774 | macOS App Notarization · Issue #15774 · bitcoin/bitcoin · GitHub
21:14 < fanquake> Moved #17020 from 0.20.0 to 0.21.0. While those might all be nice improvements, nothing specific that should be blocking 0.20.0 at this stage.
21:15 < gribble> https://github.com/bitcoin/bitcoin/issues/17020 | contrib: makeseeds.py improvements · Issue #17020 · bitcoin/bitcoin · GitHub
21:18 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
21:18 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
21:20 < fanquake> sipa: could you take a look at #18456 and see if there is anything *obvious* that could be the problem?
21:20 < gribble> https://github.com/bitcoin/bitcoin/issues/18456 | bitcoin-qt/bitcoind crashes upon startup of crypto/sha256_shani. Illegal instruction · Issue #18456 · bitcoin/bitcoin · GitHub
21:31 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
21:57 -!- ppisati [~ppisati@net-93-65-52-137.cust.vodafonedsl.it] has quit [Quit: leaving]
22:00 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Quit: ZNC 1.7.5 - https://znc.in]
22:00 < aj> fanquake: the configure test doesn't check that particular call, i guess? but _mm_set_epi64x is supposed to be part of sse2 so seems pretty weird
22:00 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev
22:04 -!- ppisati [~ppisati@net-37-119-21-5.cust.vodafonedsl.it] has joined #bitcoin-core-dev
22:04 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
22:05 < sipa> the configure check is irrelevant
22:05 < fanquake> sipa: btw can you block SatoshiNakamotogmx 
22:05 < sipa> that's testing whether your compiler supports that function, which it clearly does (otherwise the code would not have compiled)
22:06 < sipa> the problem is that it's calling _mm_set_epi64x during global initialization, before any runtime checks are done
22:06 < sipa> that's a bug, i think, because it would definitely fail on a system without sse2
22:06 < sipa> (i still don't understand why it fails on *his* system, because it supports sse2...)
22:08 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
22:09 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
22:09 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
22:14 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds]
22:17 < aj> sipa: the backtrace includes sha256_shani::Transform, which shouldn't get referenced unless have_sse4 is set unless i'm misreading?
22:21 < sipa> fanquake: done
22:22 < sipa> aj: i think it may just be "global initializer for"
22:22 < fanquake> sipa: thanks. I couldn’t quite make out the Adobe photo..
22:23 < aj> sipa: ah, yeah, it also references line 19 which is INIT0 def
22:24 < sipa> aj: trying something
22:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:28 < bitcoin-git> [bitcoin] sipa opened pull request #18553: Avoid non-trivial global constants in SHA-NI code (master...202004_no_global_init_shani) https://github.com/bitcoin/bitcoin/pull/18553
22:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:29 < aj> +inline __m128i MASK() { return _mm_set_epi64x(0x0c0d0e0f08090a0bULL, 0x0405060700010203ULL); }
22:29 < aj> sipa: ^ ?
22:30 < sipa> yeah that could also work
22:32 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
22:47 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 260 seconds]
23:00 -!- Guest3220 [~paultag@84.39.117.57] has quit []
23:00 < sipa> ah, what i suspect is going on: even though the intrinsic is an SSE2 one, it is executed in a compilation unit compiled for SSE4+SHA-NI, which means it's not impossible that that intrinsic is actually compiled to an SSE4 instruction for him
23:00 < sipa> and then executed at startup before checking that SSE4 is available
23:03 < fanquake> sipa: would that be as part of some random usage before AppInitSanityChecks() is called?
23:05 < sipa> fanquake: no, a global initializer
23:05 < sipa> before main() runs
23:06 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Remote host closed the connection]
23:07 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:07 < fanquake> right, I thought one of those required some randomness. Will have to look again.
23:08 < sipa> fanquake: no, look at the code in sha256_shani.cpp
23:08 < sipa> the initializer for MASK, INIT0, INIT1
23:08 < sipa> they require running code
23:09 < sipa> there are global initializers for randomness too which are annoying, but that's unrelated to this
23:10 < fanquake> ah ok, that's what I was thinking off. I see the calls in sha256_shani
23:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
23:13 -!- shesek [~shesek@185.3.145.121] has joined #bitcoin-core-dev
23:13 -!- shesek [~shesek@185.3.145.121] has quit [Changing host]
23:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
23:17 -!- AmberJ_ [~AmberJ_@185.204.1.185] has joined #bitcoin-core-dev
23:49 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
23:49 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
23:50 < aj> sipa: hmm, that makes sense, though not seeing what sse4 or avx instruction it could be. there's some "more efficient" variants in sse3 that could do it maybe
23:52 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
23:53 -!- dviola [~diego@189.7.70.120] has joined #bitcoin-core-dev
--- Log closed Tue Apr 07 00:00:45 2020