--- Log opened Wed Apr 15 00:00:26 2020 --- Day changed Wed Apr 15 2020 00:00 -!- jonatack [~jon@37.170.227.51] has joined #bitcoin-core-dev 00:11 -!- lightlike_ [~lightlike@p200300C7EF10B500CCE41A8C08B0A787.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:17 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/903be99ee654...ae486b263c22 00:17 < bitcoin-git> bitcoin/master b8b050a fanquake: build: add linker optimization flags to gitian descriptors 00:17 < bitcoin-git> bitcoin/master f2b5b0a fanquake: build: add linker optimization flags to guix 00:17 < bitcoin-git> bitcoin/master ae486b2 fanquake: Merge #17929: build: add linker optimisation flags to gitian & guix (Linux... 00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:18 < bitcoin-git> [bitcoin] fanquake merged pull request #17929: build: add linker optimisation flags to gitian & guix (Linux) (master...pass_optimizations_to_linker) https://github.com/bitcoin/bitcoin/pull/17929 00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:19 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:21 -!- vincenzopalazzo [~vincent@153.33.4.22] has quit [Remote host closed the connection] 00:29 -!- jonatack_ [~jon@37.173.103.51] has joined #bitcoin-core-dev 00:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:31 < bitcoin-git> [bitcoin] fanquake closed pull request #18490: Bugfix: devtools/symbol-check: Check PE libraries case-insensitively (master...bugfix_symcheck_pe_case) https://github.com/bitcoin/bitcoin/pull/18490 00:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:32 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ae486b263c22...5447d57bfff9 00:32 < bitcoin-git> bitcoin/master c47adf8 Stephan Oeste: Added my fingerprint Stephan Oeste (Emzy) 00:32 < bitcoin-git> bitcoin/master 5447d57 fanquake: Merge #18624: Added my fingerprint Stephan Oeste (Emzy) 00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:32 < bitcoin-git> [bitcoin] fanquake merged pull request #18624: Added my fingerprint Stephan Oeste (Emzy) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18624 00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:32 -!- jonatack [~jon@37.170.227.51] has quit [Ping timeout: 240 seconds] 00:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:38 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5447d57bfff9...e831f18b1ed3 00:38 < bitcoin-git> bitcoin/master 905e2e8 Jon Atack: gitian: add jonatack gpg key fingerprint 00:38 < bitcoin-git> bitcoin/master e831f18 fanquake: Merge #18619: gitian: add jonatack gpg key fingerprint 00:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:38 < bitcoin-git> [bitcoin] fanquake merged pull request #18619: gitian: add jonatack gpg key fingerprint (master...gitian-jonatack-gpg-key-fingerprint) https://github.com/bitcoin/bitcoin/pull/18619 00:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:40 -!- mol_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 00:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:44 -!- vasild_ is now known as vasild 00:45 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 00:46 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 00:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:47 < bitcoin-git> [bitcoin] fanquake opened pull request #18646: gui: use PACKAGE_NAME in exception message (master...use_package_name_in_exception) https://github.com/bitcoin/bitcoin/pull/18646 00:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:50 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 00:56 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 01:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:25 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 01:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:40 -!- Jackielove4u_ [uid43977@gateway/web/irccloud.com/x-bgntuuwpekckguoj] has joined #bitcoin-core-dev 01:41 -!- Jackielove4u_ [uid43977@gateway/web/irccloud.com/x-bgntuuwpekckguoj] has quit [Client Quit] 01:41 -!- Jackielove4u_ [uid43977@gateway/web/irccloud.com/x-ultqhrhlbjxkeltu] has joined #bitcoin-core-dev 01:42 -!- Jackielove4u_ [uid43977@gateway/web/irccloud.com/x-ultqhrhlbjxkeltu] has quit [Client Quit] 01:42 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-lrnsjvfkedukqqhl] has joined #bitcoin-core-dev 01:43 -!- Kiminuo [~mix@141.98.103.148] has quit [Read error: Connection reset by peer] 01:43 -!- guest534543 [~mix@141.98.103.148] has joined #bitcoin-core-dev 01:44 -!- amsudeep [~sudeep@1.39.151.249] has joined #bitcoin-core-dev 01:51 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:54 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 01:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 02:00 -!- vexed[vexed] [~vexedvexe@217.146.82.122] has quit [] 02:05 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 02:08 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:13 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 02:13 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 02:14 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 02:14 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 02:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 02:22 -!- quaid1 [~quaid@89.40.181.148] has joined #bitcoin-core-dev 02:28 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds] 02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:43 < bitcoin-git> [bitcoin] brakmic opened pull request #18647: rpc: remove g_rpc_node (master...remove-global-node-ctx) https://github.com/bitcoin/bitcoin/pull/18647 02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:46 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 02:51 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has joined #bitcoin-core-dev 02:51 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 03:03 -!- Yasmeen65Pouros [~Yasmeen65@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:08 -!- Yasmeen65Pouros [~Yasmeen65@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 03:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:12 < bitcoin-git> [bitcoin] practicalswift opened pull request #18649: tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh (master...locale-dependent-functions) https://github.com/bitcoin/bitcoin/pull/18649 03:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:13 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 03:15 -!- jonatack__ [~jon@37.172.252.66] has joined #bitcoin-core-dev 03:18 -!- jonatack_ [~jon@37.173.103.51] has quit [Ping timeout: 260 seconds] 03:28 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 03:30 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 03:37 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 03:38 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 03:45 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 03:45 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 03:53 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:00 -!- jonatack__ [~jon@37.172.252.66] has quit [Read error: Connection reset by peer] 04:01 -!- jonatack__ [~jon@37.172.252.66] has joined #bitcoin-core-dev 04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:02 < bitcoin-git> [bitcoin] practicalswift opened pull request #18650: qt: Make bitcoin.ico non-executable (master...bitcoin.ico-executable-flag) https://github.com/bitcoin/bitcoin/pull/18650 04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:17 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Remote host closed the connection] 04:23 -!- alec [~alec@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 04:25 -!- mytwocen_ [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 04:27 -!- yevaud [~yevaud@163.172.159.188] has quit [Quit: yevaud] 04:27 -!- yevaud [~yevaud@163.172.159.188] has joined #bitcoin-core-dev 04:28 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Ping timeout: 258 seconds] 04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e831f18b1ed3...18f11fb24b47 04:32 < bitcoin-git> bitcoin/master 1b04302 fanquake: gui: use PACKAGE_NAME in exception message 04:32 < bitcoin-git> bitcoin/master 18f11fb MarcoFalke: Merge #18646: gui: use PACKAGE_NAME in exception message 04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18646: gui: use PACKAGE_NAME in exception message (master...use_package_name_in_exception) https://github.com/bitcoin/bitcoin/pull/18646 04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:40 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 04:40 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 04:44 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:44 -!- promag__ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:47 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 04:49 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:52 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 250 seconds] 04:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:00 -!- quaid1 [~quaid@89.40.181.148] has quit [] 05:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:07 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:08 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:09 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:21 -!- gac410 [~gac410@195.206.183.79] has joined #bitcoin-core-dev 05:22 -!- gac410 is now known as Guest84865 05:27 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:28 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/18f11fb24b47...20c0e2e0f04f 05:28 < bitcoin-git> bitcoin/master fa4c29b MarcoFalke: test: Add various low-level p2p tests 05:28 < bitcoin-git> bitcoin/master 20c0e2e MarcoFalke: Merge #18628: test: Add various low-level p2p tests 05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:28 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18628: test: Add various low-level p2p tests (master...2004-qaP2Pvar) https://github.com/bitcoin/bitcoin/pull/18628 05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:33 -!- jonatack__ [~jon@37.172.252.66] has quit [Quit: jonatack__] 05:34 -!- jonatack [~jon@37.172.252.66] has joined #bitcoin-core-dev 05:41 -!- mytwocen_ [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 05:42 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 05:43 -!- theStack [~theStack@81.223.165.6] has joined #bitcoin-core-dev 05:44 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:c828:aba9:8f63:78f3] has joined #bitcoin-core-dev 05:44 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:c828:aba9:8f63:78f3] has quit [Client Quit] 06:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:04 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 06:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:06 -!- mol_ [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 06:26 -!- guest534543 [~mix@141.98.103.148] has quit [Remote host closed the connection] 06:26 -!- guest534543 [~mix@141.98.103.148] has joined #bitcoin-core-dev 06:26 -!- thunderbiscuit[m [thunderbis@gateway/shell/matrix.org/x-gtzhgwejuxfcahep] has joined #bitcoin-core-dev 06:34 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 06:48 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 06:48 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:53 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 06:56 < jnewbery> MarcoFalke fanquake: if you're looking for more to merge, I think #18401 is ready 06:56 < gribble> https://github.com/bitcoin/bitcoin/issues/18401 | Refactor: Initialize PrecomputedTransactionData in CheckInputScripts by jnewbery · Pull Request #18401 · bitcoin/bitcoin · GitHub 06:59 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 06:59 -!- diogorsergio [~diogorser@90.212.31.7] has quit [Ping timeout: 260 seconds] 07:04 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 07:13 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 07:16 -!- theStack [~theStack@81.223.165.6] has quit [Remote host closed the connection] 07:17 -!- theStack [~theStack@81.223.165.6] has joined #bitcoin-core-dev 07:23 -!- theStack [~theStack@81.223.165.6] has quit [Remote host closed the connection] 07:25 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has joined #bitcoin-core-dev 07:34 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Quit: leaving] 07:35 -!- guest534543 [~mix@141.98.103.148] has quit [Ping timeout: 250 seconds] 07:36 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has joined #bitcoin-core-dev 07:39 < theStack> i'm just running the fuzz test from #17860 07:39 < gribble> https://github.com/bitcoin/bitcoin/issues/17860 | fuzz: BIP 42, BIP 30, CVE-2018-17144 by MarcoFalke · Pull Request #17860 · bitcoin/bitcoin · GitHub 07:40 < theStack> can anyone tell me how i know if the fuzz test found something significant? (as far as i remember the fuzz test never stops, i.e. only after receiving CTRL+C) 07:42 < jonatack> theStack: you'll see a crash like https://github.com/bitcoin/bitcoin/pull/18521#issuecomment-610826738 07:43 -!- lucaferr [~lucaferr@2a00:801:420:525d:a950:8687:28c8:580e] has quit [] 07:43 < jonatack> (you are correct that the fuzzer runs indefinitely until halted) 07:45 < jonatack> (and on encountering an error, the fuzzer halts) 07:45 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 07:48 -!- vincenzopalazzo [~vincent@153.33.4.22] has joined #bitcoin-core-dev 07:49 < theStack> jonatack: so after this crash the fuzz test process would just stop? 07:50 < jonatack> theStack: yes (this was my first question with the fuzzer, too :) 07:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 07:50 < theStack> jonatack: thanks, good to know. i thought it *really* runs indefinitely in all cases and e.g. writes out a file in case of crashes 07:51 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 07:54 < theStack> what if the error we want to trigger is not a crash? If we take BIP 42, that doesn't result in a crash, but inflation 07:54 < theStack> how would the fuzzer know the condition of an, i call it "significant event"? 07:56 < jonatack> theStack: the fuzzer may have an option to do that... i don't see one like that in test/fuzz/test_runner.py, but you can set -loglevel)# 07:56 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds] 07:57 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:58 < andrewtoth> theStack that specific inflation condition is asserted here https://github.com/bitcoin/bitcoin/pull/17860/files#diff-7a6cf1c54083f72e3110c6a049e26842R77 08:00 -!- Guest84865 [~gac410@195.206.183.79] has quit [] 08:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 08:01 < andrewtoth> so I guess the fuzz harness should consider all "significant events" and assert them 08:01 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 08:01 < theStack> jonatack: oh, i didn't even use the fuzz test-runner yet, but rather called the binaries in src/test/fuzz/ directly 08:02 < theStack> andrewtoth: ah, just by using assertions -- that makes sense 08:02 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:03 < jonatack> theStack: that's probably best, i haven't got the runner to work yet and iiuc it's for the ci. was just looking in https://github.com/google/afl for more info on configurations 08:04 < jonatack> theStack: calling directly like you're doing is more useful for testing PRs with new harnesses 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:08 < bitcoin-git> [bitcoin] jonatack opened pull request #18653: test: add coverage for bitcoin-cli -rpcwait (master...rpcwait-test-coverage) https://github.com/bitcoin/bitcoin/pull/18653 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:08 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 08:10 < theStack> jonatack: it seems like test_runner.py was mentioned in doc/fuzzing.md some weeks ago but now it's not anymore 08:13 < jonatack> theStack: makes sense, i seem to recall MarcoFalke saying the runner script was really for the ci, after instagibbs and i were trying to run it unsuccessfully a couple months ago 08:13 < jonatack> i was just peeking inside to see the config options 08:14 < MarcoFalke> test_runner is for running over all inputs, which is useful for running against every commit 08:15 < MarcoFalke> So mostly ci, not for extending fuzz coverage 08:22 < theStack> jonatack: MarcoFalke: ok, so i will ignore that script for now 08:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 08:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 08:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:53 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:55 -!- carldani [~carldani@185.204.1.185] has joined #bitcoin-core-dev 08:55 -!- diogorsergio [~diogorser@176.252.195.205] has joined #bitcoin-core-dev 09:06 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 09:06 -!- as_pnn [~pierreirc@119.192.247.147] has joined #bitcoin-core-dev 09:10 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 09:15 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 09:15 -!- lightlike [~lightlike@p200300C7EF10B5001179462A28E4675A.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:17 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 09:18 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 09:18 -!- Kiminuo [~mix@141.98.103.118] has joined #bitcoin-core-dev 09:20 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:22 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 09:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [] 09:23 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 09:23 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 09:25 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 09:27 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 09:28 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 256 seconds] 09:28 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 260 seconds] 09:34 -!- marcus47 [58c4d36e@110-211-196-88.dyn.estpak.ee] has joined #bitcoin-core-dev 09:43 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:44 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev 09:45 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:51 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:c828:aba9:8f63:78f3] has joined #bitcoin-core-dev 09:59 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving] 09:59 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 10:28 -!- marcus47 [58c4d36e@110-211-196-88.dyn.estpak.ee] has quit [Remote host closed the connection] 10:43 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 10:51 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 10:52 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 10:54 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 11:00 -!- carldani [~carldani@185.204.1.185] has quit [] 11:04 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 11:05 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 11:06 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 11:07 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 11:07 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 11:08 -!- jarthur [~jarthur@2605:6000:1019:4971:80d6:5714:3803:2f80] has joined #bitcoin-core-dev 11:09 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:20 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 11:22 -!- Mikaela1 [~Mikaela@89.40.181.148] has joined #bitcoin-core-dev 11:23 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has quit [Quit: brianhoffman] 11:24 -!- mol_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:26 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has joined #bitcoin-core-dev 11:27 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 11:33 -!- amsudeep [~sudeep@1.39.151.249] has quit [Read error: Connection reset by peer] 11:35 -!- as_pnn [~pierreirc@119.192.247.147] has quit [Read error: Connection reset by peer] 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:37 < bitcoin-git> [bitcoin] theStack closed pull request #16922: net: filteradd message: update bloom filter empty/full flags after adding (master...20190919-net-update_empty_full_after_adding_filter) https://github.com/bitcoin/bitcoin/pull/16922 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:39 -!- Highway61 [~Thunderbi@104.129.24.138] has quit [Ping timeout: 256 seconds] 11:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20c0e2e0f04f...4bd6bc5cb4f3 11:40 < bitcoin-git> bitcoin/master fa176e2 MarcoFalke: test: Avoid accessing free'd memory in validation_chainstatemanager_tests 11:40 < bitcoin-git> bitcoin/master 4bd6bc5 MarcoFalke: Merge #18615: test: Avoid accessing free'd memory in validation_chainstate... 11:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:40 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 11:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18615: test: Avoid accessing free'd memory in validation_chainstatemanager_tests (master...2004-testNoAccessFreeMem) https://github.com/bitcoin/bitcoin/pull/18615 11:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:44 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Quit: Lost terminal] 11:44 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has quit [Quit: Leaving] 11:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:53 < bitcoin-git> [bitcoin] achow101 opened pull request #18654: rpc: separate bumpfee' (master...psbtbumpfee) https://github.com/bitcoin/bitcoin/pull/18654 11:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:55 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has quit [Ping timeout: 260 seconds] 11:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:58 < bitcoin-git> [bitcoin] achow101 opened pull request #18655: gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior (master...split-bumpfeeaction) https://github.com/bitcoin/bitcoin/pull/18655 11:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:00 < bitcoin-git> [bitcoin] achow101 opened pull request #18656: gui: Add a `Make unsigned` button next to `Send` (master...make-unsigned-button) https://github.com/bitcoin/bitcoin/pull/18656 12:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:01 < bitcoin-git> [bitcoin] achow101 closed pull request #18627: rpc: gui: Don't change behavior based on private keys disabled, instead add new buttons/rpcs/menu items (master...split-watchonly) https://github.com/bitcoin/bitcoin/pull/18627 12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:06 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:c828:aba9:8f63:78f3] has quit [Quit: Sleep mode] 12:07 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 12:08 -!- kabaum [~kabaum@2001:9b1:efd:9b00::c45] has joined #bitcoin-core-dev 12:10 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:c828:aba9:8f63:78f3] has joined #bitcoin-core-dev 12:10 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:c828:aba9:8f63:78f3] has quit [Client Quit] 12:11 -!- Highway61 [~Thunderbi@104.129.24.138] has joined #bitcoin-core-dev 12:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:26 -!- masterdonx2 [~masterdon@144.48.39.84] has quit [Quit: ZNC 1.7.5 - https://znc.in] 12:27 -!- MasterdonX [~masterdon@144.48.39.84] has joined #bitcoin-core-dev 12:28 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:29 -!- en1on is now known as en10n 12:35 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:38 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:38 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:46 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:52 -!- ghost1 [~ghost1@c-73-245-52-228.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 12:56 < vasild> dongcarl: If you use `-onlynet=torv3`, then there is no way that you would connect to an old node that does not understand `addrv2` because such node cannot exist - there is no way that it can advertise its `torv3` address using the old `addr` messages. 12:56 < vasild> Or am I totally confused? (wrt https://github.com/bitcoin/bips/pull/766#issuecomment-614141273) 12:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:59 < bitcoin-git> [bitcoin] practicalswift opened pull request #18657: chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found (master...out-parameters-in-findCommonAncestor) https://github.com/bitcoin/bitcoin/pull/18657 12:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:00 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds] 13:00 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has quit [Quit: brianhoffman] 13:02 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:03 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 250 seconds] 13:03 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 13:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 13:11 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 13:12 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 13:18 < elichai2> ariard told me there is past interaction with oss-fuzz and it was decided that the disclosure policy doesn't fit Core, is that right? I'm interested to hear about it :) 13:19 < sipa> ping BlueMatt 13:20 < sipa> though if i remember correctly, at the time there also was no (meaningful) fuzzers for bitcoin core, so it was mostly a philosophical point 13:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4bd6bc5cb4f3...6db8ef2431ac 13:21 < bitcoin-git> bitcoin/master fac0c8d MarcoFalke: appveyor: Remove clcache 13:21 < bitcoin-git> bitcoin/master 6db8ef2 MarcoFalke: Merge #18640: appveyor: Remove clcache 13:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:22 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18640: appveyor: Remove clcache (master...2004-appveyorNoSlowCache) https://github.com/bitcoin/bitcoin/pull/18640 13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6db8ef2431ac...e84a5f000493 13:32 < bitcoin-git> bitcoin/master 808ef36 John Newbery: [doc] Update thread information in developer docs 13:32 < bitcoin-git> bitcoin/master e84a5f0 MarcoFalke: Merge #18645: [doc] Update thread information in developer docs 13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18645: [doc] Update thread information in developer docs (master...2020-04-doc-threads) https://github.com/bitcoin/bitcoin/pull/18645 13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:35 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 13:36 -!- per [~per@gateway/tor-sasl/wsm] has quit [Ping timeout: 240 seconds] 13:36 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 13:39 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 13:44 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 13:44 -!- ctrlbreak_MAD is now known as ctrlbreak 13:45 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 13:47 -!- diogorsergio [~diogorser@176.252.195.205] has quit [Ping timeout: 256 seconds] 13:58 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 14:00 -!- Mikaela1 [~Mikaela@89.40.181.148] has quit [] 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:02 < bitcoin-git> [bitcoin] practicalswift closed pull request #18657: chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found (master...out-parameters-in-findCommonAncestor) https://github.com/bitcoin/bitcoin/pull/18657 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:04 -!- jonatack [~jon@37.172.252.66] has quit [Ping timeout: 260 seconds] 14:05 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has joined #bitcoin-core-dev 14:06 -!- jonatack [~jon@37.171.222.247] has joined #bitcoin-core-dev 14:08 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving] 14:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:10 < bitcoin-git> [bitcoin] ryanofsky opened pull request #18660: test: Verify findCommonAncestor always initializes outputs (master...pr/commoninit) https://github.com/bitcoin/bitcoin/pull/18660 14:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:19 < BlueMatt> elichai2: yea, oss-fuzz has some rather-strict rules about how they will disclose issues publicly after N days of reporting them. 14:19 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 14:20 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 14:20 < BlueMatt> elichai2: at the time, and imo quite reasonably, we decided that was completely unacceptable for a p2p consensus system which may, depending on the type of failure, require network-wide update for something to be safe, and some rapid disclosure policy is not compatible with that 14:20 < BlueMatt> elichai2: also note that oss-fuzz primarily just provides cpu hours, it doesn't do any actual implementation work for you, and getting access to a few hundred cores for bitcoin core fuzzing is rather easy :p 14:21 < sipa> BlueMatt: on the other hand, we currently have fuzzers for the codebase (yay), and we can't prevent anyone from running them secretly on a massive cluster 14:21 < BlueMatt> (as a reminder: lots of cpu cores are available in a few locations for those doing bitcoin open source work) 14:21 < BlueMatt> sipa: sadly they're mostly all kinda boring targets :( 14:21 < BlueMatt> but we *have* a few rather reasonably-sized clusters in various places... 14:22 < sipa> BlueMatt: have you paid attention to the more recently added ones? 14:22 < BlueMatt> dont think any are currently fuzzing core, but... 14:22 -!- Frost1 [~Frost@178.162.204.214] has joined #bitcoin-core-dev 14:22 < BlueMatt> ah, marco's fuzz stuff got merged! I missed that. 14:23 < sipa> so perhaps... either we keep the more delicate ones private (how?), or we're ok with having the ones we have publicly participate in oss-fuzz? 14:23 < BlueMatt> well, someone should give them more cpu hours. afair marco had previously done stuff, but... 14:24 < sipa> of course - we can also just increase how much cpu we spend ourselves 14:24 < BlueMatt> or we could, you know, use the cluster(s) we have to get fuzz hours :) 14:24 < sipa> well, or both 14:24 < BlueMatt> there's probably at least 120 cpu cores lying around for such usage, just need someone to step up and write scripts 14:24 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 250 seconds] 14:26 < BlueMatt> i mean how many cpu hours does oss-fuzz provide? I cant imagine it is anything significantly more than the 100 cores/project full-time that we already have? 14:26 < BlueMatt> and the tradeoffs for using it...kinda suck 14:28 < sipa> that's a great question 14:29 < BlueMatt> we could also ask osuosl if heir CI cluster has free cores: https://osuosl.org/services/hosting/details/ 14:29 < sipa> if it's indeed not (significantly more than) 100 cores, there isn't much to be gained from using it 14:29 < BlueMatt> a few bitcoin groups gave them some funds afaiu 14:29 < BlueMatt> but, you know, we should probably use our own cpus first. 14:30 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:30 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:30 < BlueMatt> anyway, really just need someone to step up and manage VMs that run fuzzing. I can help a bit, I have it all set up for rust-lightning and regularly pull ~100 cores for that, but I dont really have the bandwidth to manage that all the time, let alone also for core. 14:30 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 14:30 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:31 < BlueMatt> someone just let me or dongcarl know and we can get you set up with a few VMs with a bunch of cores, I presume there's soeone at blockstream who can do the same 14:33 < elichai2> BlueMatt: are these bare metal? because running something like this to detect improvements/regressions can be very helpful: https://perf.rust-lang.org/ 14:34 < BlueMatt> kvm, but there are separate bare-metal servers intended for benchmarking cc jamesob 14:34 < BlueMatt> (which are slower, but bare-metal and more 'average-grade' hardware) 14:34 < elichai2> yeah but sadly you need bare metal for profiling, VMs are too dynamic for that AFAIK 14:35 < BlueMatt> right, kvm just for non-benchmark things 14:35 < BlueMatt> we have ~9 servers which are provisioned bare-metal for benchmarking 14:35 < BlueMatt> 9 being 8-outbound-1-target for ibd benchmarking :) 14:35 < BlueMatt> though you'd have to ask james as to the status of those 14:36 < elichai2> I have my own PC dedicated for profiling benchmarking, trying different system wide changes to Bitcoin Core 14:36 < BlueMatt> anyway, hardware/cpu resources isnt the issue, just gotta have someone write bash scripts :) 14:36 < BlueMatt> well, and babysit to watch for errors 14:38 < elichai2> BlueMatt: from what I looked in oss-fuzz it looks really simple, You write a simple dockerfile to compile and run and that's about it https://github.com/google/oss-fuzz/blob/master/projects/libsodium/Dockerfile 14:39 < BlueMatt> well by the time you've done that much work you might as well run it on our own hardware (without the aggressive public-disclosure timelines that may put bitcoin users at risk...) 14:39 < elichai2> and if I understand correctly Google will actually pay you if you integrate into oss-fuzz https://github.com/bitcoin-core/secp256k1/issues/739 "We want to stress that anyone who meets the eligibility criteria and integrates a project with OSS-Fuzz is eligible for a reward." 14:39 < elichai2> BlueMatt: right. the disclosure thing is a problem, I think they're saying either 90 days from finding or 30 days from fixing 14:40 < BlueMatt> lol, thats kinda obnoxious that they're auto-opening issues on open source projects. 14:40 < BlueMatt> isnt that against the github tos? 14:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e84a5f000493...544709763e1f 14:43 < bitcoin-git> bitcoin/master fad4fa7 MarcoFalke: node: Add args alias for gArgs global 14:43 < bitcoin-git> bitcoin/master fa0cbd4 MarcoFalke: test: Add optional extra_args to testing setup 14:43 < bitcoin-git> bitcoin/master fa69f88 MarcoFalke: fuzz: Disable debug log file 14:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18571: fuzz: Disable debug log file (master...2004-testLogExtraArgs) https://github.com/bitcoin/bitcoin/pull/18571 14:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:45 -!- someone235 [uid419897@gateway/web/irccloud.com/x-mtyuqoltebsjctue] has quit [Quit: Connection closed for inactivity] 14:55 -!- jonatack [~jon@37.171.222.247] has quit [Ping timeout: 265 seconds] 14:56 -!- jonatack [~jon@213.152.162.69] has joined #bitcoin-core-dev 15:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:02 < bitcoin-git> [bitcoin] mikispag opened pull request #18661: Compress PNG images with `zopflipng`. (master...master) https://github.com/bitcoin/bitcoin/pull/18661 15:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:12 < fanquake> jnewbery: ok 15:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 15:44 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 15:45 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 15:49 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 15:49 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 15:50 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Client Quit] 15:50 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 15:52 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 15:54 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 16:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:08 -!- diogorsergio [~diogorser@90.211.210.58] has joined #bitcoin-core-dev 16:11 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 272 seconds] 16:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:26 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18662: refactor: Replace gArgs with local argsman in all utility tools (master...2004-toolsArgsman) https://github.com/bitcoin/bitcoin/pull/18662 16:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:32 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has quit [] 16:56 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 16:59 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 16:59 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 17:00 -!- Frost1 [~Frost@178.162.204.214] has quit [] 17:12 -!- mol_ [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 17:13 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 17:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:21 -!- jscarmona1 [~jscarmona@195.206.169.238] has joined #bitcoin-core-dev 17:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:40 < bitcoin-git> [bitcoin] saahilshangle opened pull request #18663: doc: Adding hyperlink to INSTALL.md in README.md (master...readme-build-instructions) https://github.com/bitcoin/bitcoin/pull/18663 17:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:53 -!- promag__ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:53 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:03 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 18:08 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:14 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:16 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 18:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:32 -!- mol_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 18:32 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 18:33 -!- lightlike [~lightlike@p200300C7EF10B5001179462A28E4675A.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 18:33 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 18:46 -!- unruly247 [~unruly247@104.194.248.178] has joined #bitcoin-core-dev 18:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 18:57 -!- Highway61 [~Thunderbi@104.129.24.138] has quit [Ping timeout: 240 seconds] 19:03 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 19:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 19:08 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:08 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 19:08 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:16 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds] 19:20 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 19:21 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 19:27 -!- unruly247 [~unruly247@104.194.248.178] has quit [Remote host closed the connection] 19:29 -!- unruly247 [~unruly247@104.194.248.178] has joined #bitcoin-core-dev 19:53 < meshcollider> So #18572 and #18550 are talking about being included in 0.20, but they're obviously not in rc1, so what exactly is happening there? 19:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18572 | Wallet: Accept "changedata" db key as an alias to "destdata" by luke-jr · Pull Request #18572 · bitcoin/bitcoin · GitHub 19:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18550 | Store destdata for change in separate key for backward compatibility by luke-jr · Pull Request #18550 · bitcoin/bitcoin · GitHub 20:00 -!- jscarmona1 [~jscarmona@195.206.169.238] has quit [] 20:14 -!- go1111111 [~go1111111@104.156.98.86] has quit [Quit: Leaving] 20:22 -!- frank001 [~frank001@139.28.218.198] has joined #bitcoin-core-dev 20:22 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 20:36 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Quit: Quit] 20:36 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev 20:37 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Client Quit] 20:37 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev 20:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 20:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 21:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 21:29 -!- jarthur_ [~jarthur@2605:6000:1019:4971:30d5:ccb0:2203:a753] has joined #bitcoin-core-dev 21:29 -!- jarthur_ [~jarthur@2605:6000:1019:4971:30d5:ccb0:2203:a753] has quit [Remote host closed the connection] 21:33 -!- jarthur [~jarthur@2605:6000:1019:4971:80d6:5714:3803:2f80] has quit [Ping timeout: 256 seconds] 21:49 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 21:50 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] 22:08 -!- robot-visions [ac5c056c@172.92.5.108] has joined #bitcoin-core-dev 22:14 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 258 seconds] 22:15 -!- robot-visions [ac5c056c@172.92.5.108] has quit [Remote host closed the connection] 22:15 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 22:29 -!- MarcoFalke [~none@198.12.116.246] has quit [Read error: Connection reset by peer] 22:30 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev 22:38 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 22:39 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 22:43 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 22:48 -!- vincenzopalazzo [~vincent@153.33.4.22] has quit [Remote host closed the connection] 23:00 -!- frank001 [~frank001@139.28.218.198] has quit [] 23:04 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving] 23:12 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 23:19 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 23:21 -!- nighmi [~nighmi@139.28.218.198] has joined #bitcoin-core-dev 23:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:21 -!- nighmi is now known as Guest89944 23:24 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 23:24 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 23:24 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 23:29 -!- amsudeep [~sudeep@1.39.173.89] has joined #bitcoin-core-dev 23:36 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Ping timeout: 240 seconds] 23:37 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 23:49 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] --- Log closed Thu Apr 16 00:00:53 2020