--- Log opened Wed Apr 29 00:00:06 2020
00:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 244 seconds]
00:31 -!- jonatack_ [~jon@37.165.16.42] has joined #bitcoin-core-dev
00:34 -!- jonatack [~jon@37.165.71.66] has quit [Ping timeout: 264 seconds]
00:39 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
00:44 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 246 seconds]
00:48 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:51 -!- as_pnn [~pierreirc@119.192.247.147] has joined #bitcoin-core-dev
00:59 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
01:00 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Quit: Highway61]
01:00 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
01:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:02 < bitcoin-git> [bitcoin] bttd opened pull request #18813: 0.20 (master...0.20) https://github.com/bitcoin/bitcoin/pull/18813
01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:05 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
01:06 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 252 seconds]
01:08 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
01:08 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
01:10 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev
01:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:10 < bitcoin-git> [bitcoin] fanquake closed pull request #18813: 0.20 (master...0.20) https://github.com/bitcoin/bitcoin/pull/18813
01:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:14 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
01:18 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 260 seconds]
01:18 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
01:27 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
01:30 -!- lucaferr [~lucaferr@2a00:801:2d6:dff5:a434:9426:5d55:f340] has joined #bitcoin-core-dev
01:31 -!- lucaferr [~lucaferr@2a00:801:2d6:dff5:a434:9426:5d55:f340] has quit [Remote host closed the connection]
01:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:33 < bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/ba348dbc518b...0ef0d33f7562
01:33 < bitcoin-git> bitcoin/master 89eeb4a Amiti Uttarwar: [mempool] Track "unbroadcast" transactions
01:33 < bitcoin-git> bitcoin/master 7e93eec Amiti Uttarwar: [util] Add method that returns random time in milliseconds
01:33 < bitcoin-git> bitcoin/master e25e42f Amiti Uttarwar: [p2p] Reattempt initial send of unbroadcast transactions
01:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:34 < bitcoin-git> [bitcoin] fanquake merged pull request #18038: P2P: Mempool tracks locally submitted transactions to improve wallet privacy (master...2020-01-unbroadcast) https://github.com/bitcoin/bitcoin/pull/18038
01:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:35 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:36 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:38 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in]
01:40 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
01:41 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has joined #bitcoin-core-dev
01:41 -!- lucaferr [~lucaferr@m90-129-204-112.cust.tele2.se] has joined #bitcoin-core-dev
01:43 < lucaferr> Has mempool p2p command been deprecated? The information I can find online indicates it should reply with an inv, however in integration tests it seems to disconnect. Is it only working for SPV clients as of now?
01:49 -!- amsudeep [~sudeep@171.61.73.192] has joined #bitcoin-core-dev
01:50 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:00 -!- gchaix [~gchaix@84.39.117.57] has quit []
02:08 -!- kljasdfvv [~flack@p200300D46F079C008842B9735477632E.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
02:10 -!- kljasdfvv [~flack@p200300D46F079C004D99554E023E6BB5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
02:13 -!- mytwocentimes [~mytwocent@178.197.225.204] has quit [Remote host closed the connection]
02:21 -!- c9sloud [~c9sloud@185.103.96.151] has joined #bitcoin-core-dev
02:29 -!- mytwocentimes [~mytwocent@178.197.226.112] has joined #bitcoin-core-dev
02:32 -!- amsudeep [~sudeep@171.61.73.192] has quit [Ping timeout: 260 seconds]
02:33 -!- sudeep_ [~sudeep@171.61.73.192] has joined #bitcoin-core-dev
02:34 -!- sudeep_ [~sudeep@171.61.73.192] has quit [Client Quit]
02:36 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving]
02:37 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-bpcwviszrtxkeuul] has joined #bitcoin-core-dev
02:38 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
02:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:48 < bitcoin-git> [bitcoin] promag opened pull request #18814: rpc: Relock wallet only if most recent callback (master...2020-04-rpc-wallet-relock) https://github.com/bitcoin/bitcoin/pull/18814
02:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:51 -!- sonofhan [~sonofhan@104.238.46.201] has quit [Ping timeout: 256 seconds]
03:00 -!- sonofhan [~sonofhan@104.238.46.201] has joined #bitcoin-core-dev
03:01 -!- brakmic [brakmic@gateway/vpn/nordvpn/brakmic] has joined #bitcoin-core-dev
03:07 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
03:21 -!- mytwocentimes [~mytwocent@178.197.226.112] has quit [Ping timeout: 260 seconds]
03:24 -!- ccdle12_ [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
03:25 -!- ccdle12_ [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
03:39 -!- someone235 [uid419897@gateway/web/irccloud.com/x-cozyovyucxatuwhd] has quit [Quit: Connection closed for inactivity]
03:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
03:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:44 -!- vasild_ is now known as vasild
03:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
03:46 -!- as_pnn [~pierreirc@119.192.247.147] has quit [Quit: killed]
03:47 -!- as_pnn [~pierreirc@119.192.247.147] has joined #bitcoin-core-dev
03:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:58 -!- mytwocentimes [~mytwocent@178.197.226.112] has joined #bitcoin-core-dev
03:59 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has quit [Quit: Leaving]
03:59 -!- frogar [~frogar_@w.x.y.z.mooo.com] has quit [Ping timeout: 256 seconds]
04:10 -!- mytwocentimes [~mytwocent@178.197.226.112] has quit [Remote host closed the connection]
04:13 -!- LuisAranguren [quassel@88s6l9d9m1hyljqp9fbs.ip6.superloop.com] has joined #bitcoin-core-dev
04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:30 < bitcoin-git> [bitcoin] rebroad closed pull request #18760: Disconnect nodes with bad messages during IBD (master...IBDDisconnectBadChecksum) https://github.com/bitcoin/bitcoin/pull/18760
04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:34 -!- frogar [~frogar_@w.x.y.z.mooo.com] has joined #bitcoin-core-dev
04:38 -!- sonofhan [~sonofhan@104.238.46.201] has quit [Ping timeout: 240 seconds]
04:41 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
04:45 -!- as_pnn [~pierreirc@119.192.247.147] has quit [Quit: killed]
04:45 -!- jonatack_ [~jon@37.165.16.42] has quit [Read error: Connection reset by peer]
04:46 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
04:46 -!- jonatack [~jon@213.152.161.25] has joined #bitcoin-core-dev
04:47 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-bpcwviszrtxkeuul] has quit [Quit: Connection closed for inactivity]
04:47 -!- jonatack [~jon@213.152.161.25] has quit [Read error: Connection reset by peer]
04:51 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
04:53 -!- jonatack [~jon@37.165.16.42] has joined #bitcoin-core-dev
04:55 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
04:57 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
04:58 -!- jonatack [~jon@37.165.16.42] has quit [Ping timeout: 256 seconds]
04:59 -!- jonatack [~jon@109.232.227.149] has joined #bitcoin-core-dev
05:00 -!- c9sloud [~c9sloud@185.103.96.151] has quit []
05:16 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
05:22 -!- Vogone [~Vogone@84.39.116.180] has joined #bitcoin-core-dev
05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0ef0d33f7562...ecca2ea1d5f6
05:24 < bitcoin-git> bitcoin/master fcb7261 Russell Yanofsky: Prevent valgrind false positive in rest_blockhash_by_height
05:24 < bitcoin-git> bitcoin/master ecca2ea MarcoFalke: Merge #18785: Prevent valgrind false positive in rest_blockhash_by_height
05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18785: Prevent valgrind false positive in rest_blockhash_by_height (master...pr/grind) https://github.com/bitcoin/bitcoin/pull/18785
05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:31 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ecca2ea1d5f6...af2ec6b03745
05:31 < bitcoin-git> bitcoin/master fabe44e MarcoFalke: bench: Start nodes with -nodebuglogfile
05:31 < bitcoin-git> bitcoin/master af2ec6b MarcoFalke: Merge #18759: bench: Start nodes with -nodebuglogfile
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:31 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18759: bench: Start nodes with -nodebuglogfile (master...2004-benchNoDebugLog) https://github.com/bitcoin/bitcoin/pull/18759
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:38 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:40 -!- molakala [~sumanth.b@2601:192:4701:87f0:257a:5b91:a1f4:3f48] has joined #bitcoin-core-dev
05:41 -!- whythat [whythatmat@gateway/shell/matrix.org/x-ucouhznhwoghjuwk] has left #bitcoin-core-dev ["Kicked by @appservice-irc:matrix.org  : issued !quit command"]
05:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds]
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:53 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18815: bench: Add logging benchmark (master...2004-benchLog) https://github.com/bitcoin/bitcoin/pull/18815
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:54 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
06:02 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
06:08 -!- cryptoIndio [~cryptoInd@49.145.96.152] has quit [Remote host closed the connection]
06:10 -!- cryptoIndio [~cryptoInd@49.145.96.152] has joined #bitcoin-core-dev
06:14 -!- cryptoIndio [~cryptoInd@49.145.96.152] has quit [Ping timeout: 264 seconds]
06:20 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 240 seconds]
06:27 -!- cryptoIndio [~cryptoInd@49.145.96.152] has joined #bitcoin-core-dev
06:28 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
06:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
06:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
06:35 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
06:36 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
06:42 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
06:46 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 246 seconds]
06:55 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:04 < vasild> wumpus: While looking at the addrv2/BIP155 wip PR #16748 I realized that in CSubNet we support netmasks that have 0-bits followed by 1-bits, e.g. /255.255.0.255.
07:04 < gribble> https://github.com/bitcoin/bitcoin/issues/16748 | [WIP] Add support for addrv2 (BIP155) by dongcarl · Pull Request #16748 · bitcoin/bitcoin · GitHub
07:05 < vasild> We even have test for that: https://github.com/bitcoin/bitcoin/blob/master/src/test/netbase_tests.cpp#L280-L283 which was added by you via https://github.com/bitcoin/bitcoin/pull/6315#issuecomment-115169435
07:05 < dongcarl> vasild: I apologize for not responding in time to the reviews, it's on my list now :-)
07:05 < vasild> I am just wondering - why do we support such strange (invalid) netmasks and can we drop that support?
07:07 < vasild> dongcarl: no problem, I got distracted by the netmasks and dived into some CSubNet cleanup that would drop support for netmasks like /255.255.0.255.
07:07 < dongcarl> vasild: I'm guessing you're thinking just have a uint type that specifies the prefix length?
07:08 < vasild> dongcarl: you read my thoughts!
07:09 < dongcarl> Hmm... well are there legitimate cases where a netmask can have 0's in the middle?
07:09 < vasild> replace the `uint8_t netmask[16];` in CSubNet with `uint8_t cidr;` which can be in [0, 32] for ipv4 and [0, 128] for ipv6.
07:11 < vasild> dongcarl: right, I do not know, but to me that contradicts with the idea of subnetting
07:11 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:12 < vasild> I was thinking that this is just some unintended side effect, but then found a deliberate test cases that expect such support (above link ^), so I decided to ask :)
07:12 -!- cryptoIndio [~cryptoInd@49.145.96.152] has quit [Remote host closed the connection]
07:14 -!- lucaferr [~lucaferr@m90-129-204-112.cust.tele2.se] has quit []
07:15 < dongcarl> vasild: I think it'd probably be good to leave as is, mostly because the contiguous-ness is not really enforced in the RFCs, and it seems more flexible for the future. Will look into it though.
07:15 < vasild> dongcarl: It is!
07:15 < vasild> I read it somewhere, let me find it...
07:16 -!- mrwhythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev
07:17 -!- mrwhythat is now known as whythat
07:18 -!- cryptoIndio [~cryptoInd@49.145.96.152] has joined #bitcoin-core-dev
07:19 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Client Quit]
07:19 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev
07:23 -!- cryptoIndio [~cryptoInd@49.145.96.152] has quit [Ping timeout: 258 seconds]
07:23 < vasild> dongcarl: https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#Subnet_masks 
07:23 < vasild> "Subnet masks were allowed by RFC 950[5] to specify non-contiguous bits until RFC 4632[4]:Section 5.1 stated that the mask must be left contiguous. Given this constraint, a subnet mask and CIDR notation serve exactly the same function."
07:26 < vasild> indeed https://tools.ietf.org/html/rfc4632#section-5.1 says "The only outstanding constraint is that the
07:27 < vasild>    mask must be left contiguous.
07:27 < wumpus> vasild: it doesn't matter too much to me, but if you have a good reason to remove that support it's OK with me
07:27 < wumpus> just doing it for the sake of it seems useless, it doesn't hurt to support more than strictly expected
07:29 < wumpus> I don't think it has any impact on addrv2, AFAIK we never send subnets over the P2P
07:30 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:31 < vasild> yes, I agree - "for the sake of it" is useless. The main reason I started looking into it was that it would simplify addrv2 changes: https://github.com/bitcoin/bitcoin/pull/16748#discussion_r414663229 
07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:31 < bitcoin-git> [bitcoin] practicalswift closed pull request #17895: build: Enable Clang's -Wconditional-uninitialized to warn on potential uninitialized reads (master...continue-killing-of-uninitialized-reads) https://github.com/bitcoin/bitcoin/pull/17895
07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:32 < vasild> this modification fiddles with the `uint8_t netmask[16];` array
07:34 < vasild> and having to increase that to netmask[32] would be far from perfect, given that it can be just a single byte.
07:36 < dongcarl> vasild: Working on sth else right now but will take a look today. One thing that came to mind when I last looked into this: the NetMask code looks like it was written with the assumption that all CNetAddrs would be addresses in address families where netmasks made sense... With the addition of tor, that's not the case anymore
07:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
07:39 < vasild> Right! Netmasks do not make any sense in the new types too: torv3, i2p, cjdns.
07:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:40 < bitcoin-git> [bitcoin] practicalswift closed pull request #18147: qt: Kill the locale dependency bug class by not allowing Qt to mess with LC_NUMERIC (master...kill-locale-dependency-bug-class) https://github.com/bitcoin/bitcoin/pull/18147
07:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:42 < bitcoin-git> [bitcoin] practicalswift closed pull request #18124: init: Clarify C and C++ locale assumptions. Add locale sanity checks to verify assumptions at run-time. (master...LocaleSanityCheck) https://github.com/bitcoin/bitcoin/pull/18124
07:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
07:44 < vasild> I will leave the "uint8_t netmask[16]" -> "uint8_t cidr" change away for now. Ideally we shouldn't be using netmasks for e.g. torv3 at all, or we just use one special mask which denotes "matches just one address"
07:45 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
07:46 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
07:46 < dongcarl> vasild: Sounds good, always good to explore the options :-) I'll take a closer look at your comments today
07:49 < vasild> dongcarl: btw, I rebased the PR on latest master (required some non-trivial conflict resolution) and fixed the failing unit tests.
07:49 < dongcarl> vasild: Oh yeah? Do you have a branch up?
07:50 < vasild> dongcarl: not pushed on gh, I was wondering how to proceed with that...
07:51 < wumpus> agree, netmasks make no sense for non-hierarchical addresses types
07:51 < dongcarl> vasild: Well, if it's acceptable to you, you should put yourself as co-author on the commits, and push as a branch to your remote on github e.g. `vaslid/bitcoin`, and I'll get those commits into my branch/PR
07:52 < wumpus> and the cidr-based notation is more compact, though it might be more expensive to match against? I'm not sure
07:54 < vasild> dongcarl: makes sense, I will clean up a bit and push to gh.
07:55 < dongcarl> vasild: Many thanks!
07:55 < vasild> yw :)
07:58 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:00 -!- Vogone [~Vogone@84.39.116.180] has quit []
08:02 < vasild> wumpus: more compact and the only valid representation for ipv6, as for speed of matching - we have to compare the first `cidr` bits, I don't think it will make a difference wrt performance.
08:04 < vasild> btw our current implementation https://github.com/bitcoin/bitcoin/blob/master/src/netaddress.cpp#L815 is checking all 16 bytes unnecessary - it could stop checking (break; from the loop) as soon as it finds a 0 byte in the netmask. E.g. with a netmask like /255.0.0.0 we don't need to check whether `(addr.ip[x] & netmask[x]) != network.ip[x]` is true or false for the last 3 bytes
08:05 < wumpus> yes, I'm fairly sure it can be optimized to be just as fast or even faster, without converting to an and-mask inbetween
08:05 < wumpus> no need for constant time matching here
08:05 < vasild> this is all minor, low-priority I guess
08:05 < wumpus> correct
08:05 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
08:06 < wumpus> though some people have extremely large ban lists :)
08:06 < vasild> how large?
08:07 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
08:07 < wumpus> ~1000 entries
08:07 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
08:08 < vasild> hmm
08:08 < wumpus> not something any CPU capable of running a bitcoin node in the first place will have any trouble with I guess, it's only per-incoming-connection not per packet
08:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af2ec6b03745...e302830faed0
08:10 < bitcoin-git> bitcoin/master 66fe7b1 Harris: test: added test for upgradewallet RPC
08:10 < bitcoin-git> bitcoin/master e302830 MarcoFalke: Merge #18774: test: added test for upgradewallet RPC
08:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:10 < vasild> seems like a minor / low priority performance improvement can be done in the subnet matching code wrt that. Also the size of CSubNet would be reduced with 15 bytes, 15*1000 bytes is nothing in RAM or on disk
08:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18774: test: added test for upgradewallet RPC (master...upgradewallet-tests) https://github.com/bitcoin/bitcoin/pull/18774
08:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:11 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
08:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:11 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
08:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:11 < vasild> wumpus: dongcarl: anyway, I plan to spend full time on BIP155/addrv2/torv3/i2p/cjdns, modulo distractions :)
08:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e302830faed0...ab91a0e0fc6e
08:15 < bitcoin-git> bitcoin/master 45615de Hennadii Stepanov: ci: Fix default retry script usage
08:15 < bitcoin-git> bitcoin/master ab91a0e MarcoFalke: Merge #18798: ci: Fix default retry script usage
08:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:15 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18798: ci: Fix default retry script usage (master...200428-ci-retry) https://github.com/bitcoin/bitcoin/pull/18798
08:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:18 < wumpus> vasild: awesome!
08:20 -!- cryptoIndio [~cryptoInd@49.145.96.152] has joined #bitcoin-core-dev
08:22 -!- Dogechain [~Dogechain@139.28.218.198] has joined #bitcoin-core-dev
08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:25 < bitcoin-git> [bitcoin] practicalswift opened pull request #18817: doc: Document differences in bitcoind and bitcoin-qt locale handling (master...bitcoin-qt-vs-bitcoind-locale) https://github.com/bitcoin/bitcoin/pull/18817
08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:26 < bitcoin-git> [bitcoin] luke-jr opened pull request #18818: Fix release tarball generated by gitian (master...fix_gitian_src_202004) https://github.com/bitcoin/bitcoin/pull/18818
08:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:27 -!- sonofhan [~sonofhan@104.238.46.201] has joined #bitcoin-core-dev
08:29 -!- sonofhan [~sonofhan@104.238.46.201] has quit [Client Quit]
08:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]
08:44 -!- quixote911 [9d2dba1d@157.45.186.29] has joined #bitcoin-core-dev
08:46 -!- quixote911 [9d2dba1d@157.45.186.29] has quit [Remote host closed the connection]
08:53 < luke-jr> ^ should also get tagged for 0.20
08:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab91a0e0fc6e...978c5a212240
09:08 < bitcoin-git> bitcoin/master 8098dea Hennadii Stepanov: test: Add mempool_updatefromblock.py
09:08 < bitcoin-git> bitcoin/master 978c5a2 MarcoFalke: Merge #18485: test: Add mempool_updatefromblock.py
09:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18485: test: Add mempool_updatefromblock.py (master...20200331-test-mempool) https://github.com/bitcoin/bitcoin/pull/18485
09:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:09 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Remote host closed the connection]
09:12 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
09:12 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:12 -!- jarthur [~jarthur@2605:6000:1019:4971:950d:1aa9:16ee:c195] has joined #bitcoin-core-dev
09:13 -!- cryptoIndio [~cryptoInd@49.145.96.152] has quit [Remote host closed the connection]
09:15 -!- cryptoIndio [~cryptoInd@49.145.96.152] has joined #bitcoin-core-dev
09:23 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
09:26 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:29 -!- cryptoIndio [~cryptoInd@49.145.96.152] has quit [Remote host closed the connection]
09:30 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:30 -!- cryptoIndio [~cryptoInd@49.145.96.152] has joined #bitcoin-core-dev
09:33 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
09:37 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:2576:934:d62b:3df0] has joined #bitcoin-core-dev
09:41 -!- cryptoIndio [~cryptoInd@49.145.96.152] has quit [Remote host closed the connection]
09:46 -!- cryptoIndio [~cryptoInd@49.145.96.152] has joined #bitcoin-core-dev
09:48 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Quit: Highway61]
09:51 -!- cryptoIndio [~cryptoInd@49.145.96.152] has quit [Ping timeout: 256 seconds]
09:53 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
10:06 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
10:14 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds]
10:15 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:16 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds]
10:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:18 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
10:18 -!- pinheadmz_ is now known as pinheadmz
10:18 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
10:29 -!- Highway61 [~Thunderbi@2607:fb90:ca8:b03b:f196:8595:fef9:f041] has joined #bitcoin-core-dev
10:30 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
10:30 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev
10:38 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds]
10:39 -!- cryptoIndio [~cryptoInd@49.145.96.152] has joined #bitcoin-core-dev
10:41 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
10:45 -!- Highway62 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
10:45 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev
10:46 -!- Highway61 [~Thunderbi@2607:fb90:ca8:b03b:f196:8595:fef9:f041] has quit [Ping timeout: 240 seconds]
10:46 -!- Highway62 is now known as Highway61
10:47 -!- jarthur [~jarthur@2605:6000:1019:4971:950d:1aa9:16ee:c195] has quit [Remote host closed the connection]
10:56 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds]
11:00 -!- Dogechain [~Dogechain@139.28.218.198] has quit []
11:01 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
11:02 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:03 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 265 seconds]
11:05 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev
11:07 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
11:07 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
11:08 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
11:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
11:11 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
11:13 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
11:17 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
11:20 -!- brrr [~brrr@217.146.82.122] has joined #bitcoin-core-dev
11:20 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 256 seconds]
11:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:33 < achow101> does anyone know what nWalletMaxVersion is for? and why it's distinct from nWalletVersion
11:33 < achow101> I think we should be able to consolidate these. which would also make upgradewallet less confusing
11:38 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds]
11:40 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
11:40 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:44 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection]
11:45 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
11:50 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
11:52 < phantomcircuit> it seems at some point in the (probably distant) past the "settings" key for the wallet db was called "setting"
11:53 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
11:53 < phantomcircuit> which is now causing the unknown key counter to go up
11:53 < phantomcircuit> however i cannot find any evidence of when that was
11:54 < sipa> settings like the position and dimension of the UI screen were once upon a time stored in the wallet
11:55 < phantomcircuit> there's a "settings" key which is only "known" to avoid the unknown flag, but no "setting" key
11:56 < phantomcircuit> sipa, interesting
11:56 < phantomcircuit> this is probably irrelevant to like 99.99% of people since this wallet is a mega old testnet wallet
11:57 < sipa> heh
11:57 < sipa> i wonder if settings got turned into setting in some refactor and nobody ever noticed
11:57 < sipa> or the other way around
11:59 -!- Guyver2__ is now known as Guyver2
12:06 < phantomcircuit> sipa, possibly only in master and not a release even
12:06 < sipa> heh
12:13 < luke-jr> achow101: upgradewallet doesn't actually do the upgrade until the new features are needed
12:14 -!- timothy [~tredaelli@redhat/timothy] has quit [Read error: Connection reset by peer]
12:14 < luke-jr> so it increases max version immediately, and the actual version gets bumped no higher than that on demand
12:14 < sipa> yes, exactly
12:15 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
12:15 < achow101> luke-jr: would it be reasonable to break that with the new upgradewallet rpc? That kind of makes sense for the -upgradewallet option, but for a RPC, the upgrade is explicitly being done so bumping the version regardless seems reasonable to me
12:15 < sipa> it used to be the case that upgradewallet would permit the use of compressed keys, but only once you actually created a compressed key was the wallet marked as a new version
12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:16 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18819: net: Remove unused cs_feeFilter (master...2004-netNoRecursiveMutex) https://github.com/bitcoin/bitcoin/pull/18819
12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:16 < sipa> that mechanism wasn't used for encryption, where encrypting would automatically and immediately upgrade iirc
12:16 < achow101> this nWalletMaxVersion thing is also only being applied to FEATURE_WALLETCRYPT and FEATURE_COMPRPUBKEY which were introduced ages ago
12:17 < sipa> if that mechanism isn't used anymore it may make sense to get rid of it
12:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
12:17 < sipa> compressed keys was 0.5 iirc
12:18 < sipa> in 2011...
12:18 < achow101> it only makes sense if you expect the user to downgrade after doing an upgradewallet. and that really doesn't make sense with upgradewallet now being a rpc as its even more explicit
12:19 < luke-jr> achow101: frankly, I'm stuck on 0.13 for my wallet because I dislike the direction the wallet is going.. so I'm not sure my opinion counts.
12:20 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:20 < luke-jr> also, our efforts to keep backward compatibility without upgradewallet have failed anyway.. so
12:21 < achow101> also there seems to be a nasty bug in SetMinVersion if your wallet was older than FEATURE_WALLETCRYPT and then you encrypted it, the version would jump to the latest. That's a problem as the wallet would have the indications to be HD without actually being HD
12:21 < luke-jr> (eg, inclusion of segwit txs in old wallets)
12:21 < luke-jr> achow101: encrypting the wallet would make it HD tho, no?
12:22 < achow101> luke-jr: maybe?
12:22 < achow101> I was just looking at SetMinVersion and this looked like it could be a huge problem as it was just unconditionally jumping to FEATURE_LATEST
12:22 < luke-jr> could be
12:23 -!- jarthur [~jarthur@2605:6000:1019:4971:950d:1aa9:16ee:c195] has joined #bitcoin-core-dev
12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/978c5a212240...0f204dd3f21b
12:25 < bitcoin-git> bitcoin/master 7918c1b Russell Yanofsky: test: Add CreateWalletFromFile test
12:25 < bitcoin-git> bitcoin/master 0f204dd MarcoFalke: Merge #18727: test: Add CreateWalletFromFile test
12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:25 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Quit: Highway61]
12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:25 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18727: test: Add CreateWalletFromFile test (master...pr/create) https://github.com/bitcoin/bitcoin/pull/18727
12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:25 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
12:27 -!- jarthur [~jarthur@2605:6000:1019:4971:950d:1aa9:16ee:c195] has quit [Client Quit]
12:30 -!- brrr [~brrr@217.146.82.122] has quit [Ping timeout: 246 seconds]
12:33 -!- jonatack [~jon@109.232.227.149] has quit [Ping timeout: 244 seconds]
12:33 -!- yzernik [~yzernik@2600:1700:dc40:3dd0:fc26:d98b:95c6:f84] has joined #bitcoin-core-dev
12:34 -!- sonofhan [~sonofhan@104.238.46.201] has joined #bitcoin-core-dev
12:35 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
12:35 -!- jonatack [~jon@37.170.24.56] has joined #bitcoin-core-dev
12:36 -!- sonofhan [~sonofhan@104.238.46.201] has quit [Read error: Connection reset by peer]
12:51 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
12:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:58 -!- ccallahan1 [~ccallahan@77.243.177.38] has joined #bitcoin-core-dev
13:00 -!- kexkey [~kexkey@37.120.205.236] has joined #bitcoin-core-dev
13:01 -!- kristapsk_ is now known as kristapsk
13:02 -!- sonofhan [~sonofhan@104.238.46.201] has joined #bitcoin-core-dev
13:04 -!- sonofhan [~sonofhan@104.238.46.201] has quit [Client Quit]
13:12 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Quit: Leaving...]
13:14 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
13:14 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
13:20 -!- lightlike [~lightlike@p200300C7EF1696001100EF75637AF363.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
13:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
13:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
13:34 -!- brakmic_ [~brakmic@185.183.85.108] has joined #bitcoin-core-dev
13:34 -!- jonatack [~jon@37.170.24.56] has quit [Quit: jonatack]
13:36 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Remote host closed the connection]
13:36 -!- mrwhythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev
13:36 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Quit: jb55]
13:36 -!- Krellan_ [~Krellan@2601:640:4100:e:9867:7f67:a9cc:3327] has joined #bitcoin-core-dev
13:36 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
13:38 -!- brakmic [brakmic@gateway/vpn/nordvpn/brakmic] has quit [Ping timeout: 260 seconds]
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:43 < bitcoin-git> [bitcoin] dongcarl opened pull request #18820: build: Propagate well-known vars into depends (master...2020-04-improve-depends-hosts2) https://github.com/bitcoin/bitcoin/pull/18820
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:46 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
14:00 -!- ccallahan1 [~ccallahan@77.243.177.38] has quit []
14:20 -!- yzernik [~yzernik@2600:1700:dc40:3dd0:fc26:d98b:95c6:f84] has quit [Quit: Quit]
14:20 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:22 -!- phyll1s_work [~phyll1s_w@104.254.90.203] has joined #bitcoin-core-dev
14:24 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
14:25 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
14:29 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
14:31 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
14:32 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:32 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
14:33 -!- molakala [~sumanth.b@2601:192:4701:87f0:257a:5b91:a1f4:3f48] has quit [Ping timeout: 244 seconds]
14:36 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
14:36 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
14:41 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:2576:934:d62b:3df0] has quit [Quit: Sleep mode]
14:43 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:2576:934:d62b:3df0] has joined #bitcoin-core-dev
14:53 -!- mrwhythat is now known as whythat
14:56 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 256 seconds]
14:59 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
14:59 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Quit: whythat]
15:00 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
15:00 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
15:14 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
15:15 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 256 seconds]
15:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds]
15:21 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:2576:934:d62b:3df0] has quit [Ping timeout: 272 seconds]
15:37 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:37 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:39 -!- soju [uid403160@gateway/web/irccloud.com/x-wzjtboigpqexgdoh] has joined #bitcoin-core-dev
15:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:45 -!- vasild_ is now known as vasild
15:51 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
15:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/0f204dd3f21b...95a9165016ec
15:55 < bitcoin-git> bitcoin/master a19598c practicalswift: tests: Add fuzzing harness for functions in system.h (ArgsManager)
15:55 < bitcoin-git> bitcoin/master a4e3d13 practicalswift: tests: Add fuzzing coverage for StringForFeeReason(...)
15:55 < bitcoin-git> bitcoin/master 90b635e practicalswift: tests: Add fuzzing coverage for CHECK_NONFATAL(...)
15:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:56 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18736: test: Add fuzzing harnesses for various classes/functions in util/ (master...fuzzers-2020-04-21) https://github.com/bitcoin/bitcoin/pull/18736
15:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/95a9165016ec...36c0abd8f61b
15:57 < bitcoin-git> bitcoin/master cd543d9 Danny Lee: test: check misbehavior more independently in p2p_filter.py
15:57 < bitcoin-git> bitcoin/master 36c0abd MarcoFalke: Merge #18726: test: check misbehavior more independently in p2p_filter.py
15:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:58 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18726: test: check misbehavior more independently in p2p_filter.py (master...p2p-filter) https://github.com/bitcoin/bitcoin/pull/18726
15:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:03 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
16:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
16:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:24 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving]
16:27 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
16:38 -!- lightlike [~lightlike@p200300C7EF1696001100EF75637AF363.dip0.t-ipconnect.de] has quit [Quit: Leaving]
16:43 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
16:56 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
16:59 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
17:00 -!- phyll1s_work [~phyll1s_w@104.254.90.203] has quit []
17:00 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
17:00 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
17:01 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
17:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
17:09 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
17:10 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
17:19 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
17:21 -!- KuluBot [~KuluBot@195.206.169.238] has joined #bitcoin-core-dev
17:34 -!- brakmic_ [~brakmic@185.183.85.108] has quit []
17:38 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Remote host closed the connection]
17:38 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
17:38 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
17:48 -!- soju [uid403160@gateway/web/irccloud.com/x-wzjtboigpqexgdoh] has quit [Quit: Connection closed for inactivity]
17:49 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Ping timeout: 260 seconds]
17:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
18:01 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
18:09 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
18:17 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 246 seconds]
18:17 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
18:17 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
18:17 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
18:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds]
18:52 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
19:58 -!- midnight is now known as midnightmagic
19:59 -!- midnightmagic is now known as midnight
20:00 -!- KuluBot [~KuluBot@195.206.169.238] has quit []
20:05 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 260 seconds]
20:06 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
20:21 -!- Seran1 [~Seran@77.243.177.38] has joined #bitcoin-core-dev
20:22 -!- yzernik [~yzernik@2600:1700:dc40:3dd0:fc26:d98b:95c6:f84] has joined #bitcoin-core-dev
20:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
20:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
20:48 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
20:51 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
21:14 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
21:15 -!- Technoprenerd [~Technopre@212.182.169.185] has quit [Ping timeout: 260 seconds]
21:16 -!- Technoprenerd [~Technopre@212.182.169.185] has joined #bitcoin-core-dev
21:28 < kallewoof> Fjahr and jonatack have both done great reviews on #18267. Would hate to see that effort go wasted, so please review if time permits.
21:28 < gribble> https://github.com/bitcoin/bitcoin/issues/18267 | BIP-325: Signet [consensus] by kallewoof · Pull Request #18267 · bitcoin/bitcoin · GitHub
22:06 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
22:18 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
22:23 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
22:36 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
22:41 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
22:42 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
22:50 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
22:55 -!- whjms [~whjms@c-24-4-128-103.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:55 -!- whjms [~whjms@c-24-4-128-103.hsd1.ca.comcast.net] has left #bitcoin-core-dev []
23:00 -!- Seran1 [~Seran@77.243.177.38] has quit []
23:21 -!- alct [~alct@185.103.96.151] has joined #bitcoin-core-dev
23:56 -!- frogar [~frogar_@w.x.y.z.mooo.com] has quit [Ping timeout: 256 seconds]
--- Log closed Thu Apr 30 00:00:08 2020