--- Log opened Mon May 04 00:00:10 2020 00:02 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:20 < bitcoin-git> [bitcoin] sipa opened pull request #18861: Do not answer GETDATA for to-be-announced tx (master...202004_private_getdata) https://github.com/bitcoin/bitcoin/pull/18861 00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:24 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 256 seconds] 00:30 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 00:38 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 00:51 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 01:01 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Read error: Connection reset by peer] 01:01 -!- Highway62 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev 01:04 -!- Highway62 is now known as Highway61 01:06 -!- davterra [~dulyNoded@172.98.86.80] has joined #bitcoin-core-dev 01:14 -!- davterra [~dulyNoded@172.98.86.80] has quit [Ping timeout: 256 seconds] 01:14 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 01:15 -!- davterra [~dulyNoded@178.128.106.205] has joined #bitcoin-core-dev 01:16 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:16 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 256 seconds] 01:18 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 01:42 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 01:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:44 < bitcoin-git> [bitcoin] fanquake opened pull request #18862: Remove fdelt_chk back-compat code and sanity check (master...remove_fdelt_chk_back_compat) https://github.com/bitcoin/bitcoin/pull/18862 01:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:44 -!- brakmic [brakmic@gateway/vpn/nordvpn/brakmic] has joined #bitcoin-core-dev 01:47 -!- Krellan_ [~Krellan@2601:640:4100:e:8cd1:509d:ab81:ba9f] has quit [Quit: Leaving...] 01:48 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 01:54 -!- Kirk28Emmerich [~Kirk28Emm@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 02:00 -!- hack_bot [~hack_bot@195.206.169.238] has quit [] 02:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:05 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 02:07 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 02:10 -!- Kirk28Emmerich [~Kirk28Emm@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds] 02:10 -!- ghostlaptop [627f1983@098-127-025-131.res.spectrum.com] has joined #bitcoin-core-dev 02:18 -!- ghostlaptop [627f1983@098-127-025-131.res.spectrum.com] has quit [Remote host closed the connection] 02:20 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 02:21 -!- vancoder [~vancoder@217.146.82.122] has joined #bitcoin-core-dev 02:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:37 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has quit [Ping timeout: 246 seconds] 02:38 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has joined #bitcoin-core-dev 02:42 -!- wullon5 [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev 02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:54 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e6a16b968a9...afa577c323dc 02:54 < bitcoin-git> bitcoin/master f5a3a5b Miguel Herranz: gui: Add close window shortcut 02:54 < bitcoin-git> bitcoin/master afa577c Jonas Schnelli: Merge #15768: gui: Add close window shortcut 02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:55 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:55 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #15768: gui: Add close window shortcut (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768 02:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:06 < bitcoin-git> [bitcoin] promag opened pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863 03:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:07 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 03:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 03:27 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 03:33 -!- Homelander [7ca9cba8@124-169-203-168.dyn.iinet.net.au] has quit [Ping timeout: 240 seconds] 03:34 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 03:35 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 03:37 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 03:38 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 03:39 < elichai2> Is practicalswift on IRC? 03:42 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds] 03:44 < elichai2> I'm trying to figure out some fuzzing best practices, is it ok to reuse the same fuzzing input on multiple functions or should I "pull" more data for each function I call? (cc BlueMatt ) should I minimize the amount of fuzzing input I'm using or maximize it? 03:45 < jonasschnelli> elichai2: he is sometimes. But no bouncer I guess. 04:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:07 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 04:08 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 04:10 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 244 seconds] 04:12 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 264 seconds] 04:18 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 04:27 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 04:29 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Read error: Connection reset by peer] 04:30 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 04:34 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds] 04:34 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:41 < bitcoin-git> [bitcoin] Sjors opened pull request #18864: Add v0.16.3 backwards compatibility test, bump v0.19.0.1 to v0.19.1 (master...2020/05/backwards_compat) https://github.com/bitcoin/bitcoin/pull/18864 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:42 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 04:45 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection] 04:45 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 04:45 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds] 04:47 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 04:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 04:50 < elichai2> I'm looking here: https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/netaddress.cpp#L27 and if I understand https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/FuzzedDataProvider.h#L41 correctly then it might not always return 16 bytes 04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/afa577c323dc...74a1152f2581 04:50 < bitcoin-git> bitcoin/master b56607a practicalswift: Remove CCoinsViewCache::GetValueIn(...) 04:50 < bitcoin-git> bitcoin/master 74a1152 MarcoFalke: Merge #18859: Remove CCoinsViewCache::GetValueIn(...) 04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859 04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:58 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 05:00 -!- vancoder [~vancoder@217.146.82.122] has quit [] 05:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:01 < bitcoin-git> [bitcoin] promag opened pull request #18865: gui: Refactor WalletFrame to extend QStackView (master...2020-05-walletframe) https://github.com/bitcoin/bitcoin/pull/18865 05:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:02 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:06 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 05:20 -!- chmac [~chmac@217.146.82.122] has joined #bitcoin-core-dev 05:25 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 05:28 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 240 seconds] 05:34 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:35 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 05:37 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 05:37 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 05:38 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 05:40 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 240 seconds] 05:42 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 272 seconds] 05:51 -!- mol [~mol@unaffiliated/molly] has quit [Remote host closed the connection] 05:52 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:57 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18866: test: Fix verack race to avoid intermittent test failures (master...2005-qaVerackRace) https://github.com/bitcoin/bitcoin/pull/18866 05:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:00 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 06:03 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 06:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:03 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 06:03 -!- timothy [~tredaelli@redhat/timothy] has quit [Disconnected by services] 06:03 -!- drizztbsd is now known as timothy 06:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 06:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:04 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 244 seconds] 06:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74a1152f2581...0a729b0e42fa 06:04 < bitcoin-git> bitcoin/master 38e49de practicalswift: tests: Add fuzzing harness for MessageSign, MessageVerify and other functi... 06:04 < bitcoin-git> bitcoin/master 0a729b0 MarcoFalke: Merge #18783: tests: Add fuzzing harness for MessageSign, MessageVerify an... 06:04 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18783: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h (master...fuzzers-message) https://github.com/bitcoin/bitcoin/pull/18783 06:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:06 < bitcoin-git> [bitcoin] practicalswift opened pull request #18867: tests: Add fuzzing harness for CCoinsViewCache (master...fuzzers-coins_view) https://github.com/bitcoin/bitcoin/pull/18867 06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:07 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 265 seconds] 06:09 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 06:15 -!- davterra [~dulyNoded@178.128.106.205] has quit [Ping timeout: 265 seconds] 06:15 -!- smolakala [~sumanth.b@2601:192:4701:87f0:14c3:3458:88a7:2e1d] has joined #bitcoin-core-dev 06:16 -!- davterra [~dulyNoded@c-73-221-225-225.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:18 < wumpus> so apparently I wasted my time with #18851 :/ 06:18 < gribble> https://github.com/bitcoin/bitcoin/issues/18851 | refactor: Replace thread_local use with a mutex-protected map by laanwj · Pull Request #18851 · bitcoin/bitcoin · GitHub 06:23 -!- Guest35617 [~0803543c@188.166.122.41] has quit [K-Lined] 06:28 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 06:30 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 256 seconds] 06:32 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 272 seconds] 06:38 < willcl_ark> Wondering if #7601 ever got picked up by anyone after close? 06:38 < gribble> https://github.com/bitcoin/bitcoin/issues/7601 | [WIP] HTLC implementation in the wallet by ebfull · Pull Request #7601 · bitcoin/bitcoin · GitHub 06:43 < wumpus> I don't think so, feel free to pick it up 06:51 < willcl_ark> thanks wumpus 06:54 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 06:59 < promag> is there a way to know what variables could be made const? 07:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 07:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:05 < bitcoin-git> [bitcoin] laanwj closed pull request #18851: refactor: Replace thread_local use with a mutex-protected map (master...2020_05_replace_threadlocal) https://github.com/bitcoin/bitcoin/pull/18851 07:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:06 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:07 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a729b0e42fa...42fd5038197d 07:07 < bitcoin-git> bitcoin/master faec3dc MarcoFalke: init: Remove boost from ThreadImport 07:07 < bitcoin-git> bitcoin/master 42fd503 Wladimir J. van der Laan: Merge #18786: init: Remove boost from ThreadImport 07:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:07 < bitcoin-git> [bitcoin] laanwj merged pull request #18786: init: Remove boost from ThreadImport (master...2004-noBoostInitThreadImport) https://github.com/bitcoin/bitcoin/pull/18786 07:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:08 < wumpus> promag: try to make them const and see if it still compiles? 07:08 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:08 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 07:08 < promag> wumpus: ok, see you next year :D 07:10 < wumpus> what are you trying to do in the first place? while writing the code you have an idea what could be const and what not I guess? 07:10 < promag> no compiler flag? no smartass tool? just curious 07:11 < promag> nothing in particular, lots of variables could be made const and that's a good practice no? 07:11 < wumpus> please don't make a "make everything const that can be const for const's sake" PR 07:11 < promag> wumpus: nope I promise 07:12 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Remote host closed the connection] 07:12 < promag> just came across https://dev.to/fenbf/please-declare-your-variables-as-const 07:14 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:14 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 07:19 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 07:23 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 07:26 -!- Guyver2_ is now known as Guyver2 07:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:29 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/42fd5038197d...23c926d859c6 07:29 < bitcoin-git> bitcoin/master fae51a5 MarcoFalke: wallet: Avoid translating RPC errors when loading wallets 07:29 < bitcoin-git> bitcoin/master fae7776 MarcoFalke: wallet: Avoid translating RPC errors when creating txs 07:29 < bitcoin-git> bitcoin/master fa59cc1 MarcoFalke: wallet: Report full error message in wallettool 07:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:30 < bitcoin-git> [bitcoin] laanwj merged pull request #18699: wallet: Avoid translating RPC errors (master...1908-walletErrorSegfault) https://github.com/bitcoin/bitcoin/pull/18699 07:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:31 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23c926d859c6...b549cb1bd2cc 07:31 < bitcoin-git> bitcoin/master f852030 Vasil Dimov: lockedpool: avoid sensitive data in core files (FreeBSD) 07:31 < bitcoin-git> bitcoin/master b549cb1 Wladimir J. van der Laan: Merge #18443: lockedpool: avoid sensitive data in core files (FreeBSD) 07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:32 < bitcoin-git> [bitcoin] laanwj merged pull request #18443: lockedpool: avoid sensitive data in core files (FreeBSD) (master...madvise) https://github.com/bitcoin/bitcoin/pull/18443 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:32 < elichai2> promag: wumpus adding `const` and checking if compiling won't work if anyone is casting const away anywhere 07:32 < elichai2> Look at the output and try removing the const qualifier from `a` https://godbolt.org/z/VZXfVJ 07:32 < promag> elichai2: true 07:53 < wumpus> elichai2: correct, const is always advisory in c++ anyway 07:53 < elichai2> wumpus: you mean as function input, not variable declaration, right? 07:54 < elichai2> (or as pointer qualifier or however you want to call that hehe) 07:54 < wumpus> I mean in general, you can always cast it away (of course it's a bad idea) 08:00 -!- chmac [~chmac@217.146.82.122] has quit [] 08:00 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:07 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:08 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:08 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863 08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:10 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 08:10 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 08:10 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 08:21 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 08:22 -!- Shabbypenguin [~Shabbypen@185.204.1.185] has joined #bitcoin-core-dev 08:23 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 08:27 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 08:32 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 272 seconds] 08:32 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 08:34 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 08:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 08:35 < luke-jr> wumpus: I'm not sure you are guaranteed that? 08:35 < luke-jr> IIRC string literals at least can't just be cast away constness 08:40 < BlueMatt> elichai2: its mostly a chance-of-crash per input bit thing - the fuzzer can only try X input bits per time, so if you get more of a chance of a crash from being less verbose, do it (of course it also depends on the type of input - i have a bunch of fuzz targets that don't do well with fuzzer's traditional input bit permutations that focus on arithmetic etc) 08:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:51 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:56 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 08:56 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:57 -!- enasigurd [enasigurd@gateway/shell/xshellz/x-fkzpdtjmgsfvxbrc] has joined #bitcoin-core-dev 09:08 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 09:12 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 09:17 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 09:19 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:22 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:23 -!- vasild_ is now known as vasild 09:24 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev 09:36 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Ping timeout: 256 seconds] 09:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:45 -!- brakmic [brakmic@gateway/vpn/nordvpn/brakmic] has quit [Ping timeout: 272 seconds] 09:45 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has joined #bitcoin-core-dev 09:46 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has quit [Read error: Connection reset by peer] 09:46 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev 09:46 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Quit: Highway61] 09:46 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has joined #bitcoin-core-dev 09:53 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection] 09:53 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Remote host closed the connection] 09:59 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 09:59 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 10:05 -!- brakmic_ [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 10:07 -!- jarthur [~jarthur@2605:6000:1019:4971:4cd2:984d:9b46:7486] has joined #bitcoin-core-dev 10:08 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has quit [Ping timeout: 240 seconds] 10:17 -!- lightlike [~lightlike@p200300C7EF125500B9C6871FCAC5CC1F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 10:18 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 10:26 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 10:28 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Quit: Leaving] 10:29 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has joined #bitcoin-core-dev 10:32 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 10:33 -!- brakmic_ [~brakmic@185.183.85.108] has quit [Ping timeout: 260 seconds] 10:33 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 10:35 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 10:38 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 265 seconds] 10:46 < wumpus> did we change anything to linking of the tests recently? re #18869 10:46 < gribble> https://github.com/bitcoin/bitcoin/issues/18869 | Build of tests fails on FreeBSD · Issue #18869 · bitcoin/bitcoin · GitHub 10:46 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 10:50 < wumpus> luke-jr: my point wasn't that it would be safe to do so 10:52 < sipa> wumpus: const is not always advisory in C++ 10:52 < wumpus> okay 10:52 < sipa> if you have a const-declared variable (not just a const reference/pointer to it), then modifying it is UB 10:53 < wumpus> I wasn't planning to do anything like that 10:53 < sipa> i believe the spec says that modifying through a const pointer/reference is legal only if you know something else in the program holds a non-const reference to the variable 10:54 < wumpus> I'm aware the compiler can make all kinds of optimizations based on const 10:54 < sipa> usually it can't, actually 10:54 < luke-jr> sipa: interesting, so a compiler that tagged const references and aborted if you tried to remove the constness, would be non-compliant? 10:55 < sipa> luke-jr: removing the constness is always fine; modifying through a const-reference casted to non-const is UB if no other non-const references exist 10:56 < sipa> but say you have a struct X { const int c; X(int v) : c(v) {} };... then modifying c would always be UB 10:56 < wumpus> so does anyone have an idea about the link issue? 10:57 < sipa> sorry, no :) 11:00 -!- Shabbypenguin [~Shabbypen@185.204.1.185] has quit [] 11:01 < wumpus> bisect time then :) 11:06 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Quit: whythat] 11:15 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has quit [Ping timeout: 244 seconds] 11:21 -!- torax [~torax@139.28.218.198] has joined #bitcoin-core-dev 11:23 -!- brakmic_ [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 11:25 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has quit [Ping timeout: 240 seconds] 11:29 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18730: wallet: Remove -upgradewallet from dummywallet (master...2004-walletNoUpgrade) https://github.com/bitcoin/bitcoin/pull/18730 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:48 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:48 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 11:49 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has joined #bitcoin-core-dev 11:53 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 260 seconds] 12:04 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 12:08 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 12:14 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:15 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:15 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:18 -!- jarthur_ [~jarthur@2605:6000:1019:4971:2865:7abf:a84d:95ca] has joined #bitcoin-core-dev 12:21 -!- jarthur [~jarthur@2605:6000:1019:4971:4cd2:984d:9b46:7486] has quit [Ping timeout: 260 seconds] 12:35 < provoostenator> Github lets you mark an exiting pull request as draft now. 12:39 < jb55> ohhh awesome that was super annoying 12:45 -!- brakmic_ [~brakmic@185.183.85.108] has quit [] 12:46 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 12:57 -!- go11111111111 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev 13:00 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 256 seconds] 13:07 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 13:09 -!- jonatack [~jon@213.152.161.149] has joined #bitcoin-core-dev 13:12 -!- jarthur_ is now known as jarthur 13:20 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 13:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.7.1] 13:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:29 -!- IPGlider [~IPGlider@45.76.34.219] has joined #bitcoin-core-dev 13:36 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #bitcoin-core-dev 13:36 < jeremyrubin> luke-jr: you may want to chime in on https://github.com/bitcoin/bitcoin/issues/12248#issuecomment-622270497 if you're looking at RPC whitelist/permissions for core 13:37 < jeremyrubin> I think it looks like maybe there is disagreement on utility in core but maybe could be something to build for knots and then roll into core if it works well 13:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:37 < bitcoin-git> [bitcoin] achow101 opened pull request #18870: build: Allow BDB between 4.7 and 5.3 without --with-incompatible-bdb (master...allow-other-bdb) https://github.com/bitcoin/bitcoin/pull/18870 13:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:38 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Client Quit] 13:55 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Quit: Leaving...] 13:55 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 13:57 < luke-jr> jeremyrubin: I tend to agree it sounds like overkill - but if you want to maintain it for Knots, I guess there's no hurt experimenting 14:00 -!- torax [~torax@139.28.218.198] has quit [] 14:02 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 14:03 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 14:04 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 14:06 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 14:07 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 14:08 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Read error: Connection reset by peer] 14:12 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 260 seconds] 14:17 -!- jarthur [~jarthur@2605:6000:1019:4971:2865:7abf:a84d:95ca] has quit [Remote host closed the connection] 14:18 -!- jarthur [~jarthur@2605:6000:1019:4971:dd2d:30df:873:23a7] has joined #bitcoin-core-dev 14:22 -!- fredy1 [~fredy@84.39.116.180] has joined #bitcoin-core-dev 14:41 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 14:46 -!- smolakala [~sumanth.b@2601:192:4701:87f0:14c3:3458:88a7:2e1d] has quit [Ping timeout: 240 seconds] 14:51 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 14:52 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 15:08 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:16 < bitcoin-git> [bitcoin] brakmic opened pull request #18871: rpc: prevent circular deps by extracting into separate include (master...prevent-circular-deps) https://github.com/bitcoin/bitcoin/pull/18871 15:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:18 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 264 seconds] 15:22 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 15:24 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 15:25 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 15:26 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 15:26 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 272 seconds] 15:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:38 < bitcoin-git> [bitcoin] achow101 closed pull request #18844: wallet: build: Don't write BDB logs and bump BDB to 5.3 (master...bdb-5.3) https://github.com/bitcoin/bitcoin/pull/18844 15:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:53 -!- lightlike [~lightlike@p200300C7EF125500B9C6871FCAC5CC1F.dip0.t-ipconnect.de] has quit [Quit: Leaving] 15:58 -!- jonatack [~jon@213.152.161.149] has quit [Ping timeout: 246 seconds] 15:58 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 16:01 -!- jonatack [~jon@37.167.8.190] has joined #bitcoin-core-dev 16:01 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 16:01 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 16:03 -!- brakmic [~brakmic@185.183.85.108] has quit [] 16:05 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds] 16:07 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 16:09 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 16:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 16:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 16:28 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 16:32 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 16:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:42 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:43 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 16:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:44 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b549cb1bd2cc...e727c2bdcab3 16:44 < bitcoin-git> bitcoin/master 5d49999 DesWurstes: prevector: Avoid unnamed struct, which is a GNU extension 16:44 < bitcoin-git> bitcoin/master 49f6178 Ben Woosley: Drop unused LOG_TIME_MICROS helper 16:44 < bitcoin-git> bitcoin/master 3a0fd77 Ben Woosley: Remove use of non-standard zero variadic macros 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:45 < bitcoin-git> [bitcoin] fanquake merged pull request #18088: build: ensure we aren't using GNU extensions (master...no_gnu_extensions) https://github.com/bitcoin/bitcoin/pull/18088 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:48 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:48 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18873: test: Fix intermittent sync_blocks failures (master...2005-testSyncBlocks) https://github.com/bitcoin/bitcoin/pull/18873 16:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:53 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 17:00 -!- fredy1 [~fredy@84.39.116.180] has quit [] 17:00 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 17:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:00 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18875: fuzz: Stop nodes in process_message* fuzzers (master...2005-fuzzStopNodes) https://github.com/bitcoin/bitcoin/pull/18875 17:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:21 -!- unknown1 [~unknown@185.204.1.185] has joined #bitcoin-core-dev 17:37 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 17:39 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 17:40 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 17:46 -!- mol [~mol@unaffiliated/molly] has quit [Read error: No route to host] 17:47 -!- smolakala [~sumanth.b@2601:192:4701:87f0:14c3:3458:88a7:2e1d] has joined #bitcoin-core-dev 17:52 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 17:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 17:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:00 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 18:07 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev 18:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 18:21 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Read error: Connection reset by peer] 18:22 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 18:22 -!- Technoprenerd [~Technopre@212.182.169.185] has quit [Ping timeout: 260 seconds] 18:32 -!- Technoprenerd [~Technopre@212.182.169.185] has joined #bitcoin-core-dev 18:39 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 18:40 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 18:45 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 18:46 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 18:47 -!- Technoprenerd [~Technopre@212.182.169.185] has quit [Ping timeout: 272 seconds] 18:48 -!- Technoprenerd [~Technopre@212.182.169.185] has joined #bitcoin-core-dev 18:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 18:50 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 19:09 -!- Technoprenerd [~Technopre@212.182.169.185] has quit [Ping timeout: 240 seconds] 19:11 -!- Technoprenerd [~Technopre@212.182.169.185] has joined #bitcoin-core-dev 19:11 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 19:29 -!- mol_ [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 19:34 < meshcollider> maybe #9381 should go on high priority just to get it in finally, it has been sitting around for years with some decent review between rebases, if a few people reviewed it this week before it requires rebase again, it could definitely go in 19:34 < gribble> https://github.com/bitcoin/bitcoin/issues/9381 | Remove CWalletTx merging logic from AddToWallet by ryanofsky · Pull Request #9381 · bitcoin/bitcoin · GitHub 19:34 < meshcollider> at least, review beg ^ 19:34 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 19:35 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:35 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:37 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-njxicmssnodokxmn] has joined #bitcoin-core-dev 19:40 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 19:40 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:43 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 19:47 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 19:52 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 19:53 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:55 < bitcoin-git> [bitcoin] jnewbery opened pull request #18876: Serve BIP 157 compact filters (master...pr16442.3) https://github.com/bitcoin/bitcoin/pull/18876 19:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:56 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 19:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:58 < bitcoin-git> [bitcoin] jnewbery opened pull request #18877: Serve cfcheckpt requests (master...2020-04-serve-getcfcheckpt) https://github.com/bitcoin/bitcoin/pull/18877 19:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:00 -!- unknown1 [~unknown@185.204.1.185] has quit [] 20:03 -!- smolakala [~sumanth.b@2601:192:4701:87f0:14c3:3458:88a7:2e1d] has quit [Ping timeout: 244 seconds] 20:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:09 < bitcoin-git> [bitcoin] fanquake closed pull request #16442: Serve BIP 157 compact filters (master...bip157-net) https://github.com/bitcoin/bitcoin/pull/16442 20:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:09 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 20:11 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 20:14 -!- go11111111111 [~go1111111@104.156.98.86] has quit [Ping timeout: 264 seconds] 20:20 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 20:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:21 < bitcoin-git> [bitcoin] ryanofsky opened pull request #18878: test: Add test for conflicted wallet tx notifications (master...pr/nonot) https://github.com/bitcoin/bitcoin/pull/18878 20:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:21 -!- davterra [~dulyNoded@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 20:21 -!- davterra [~dulyNoded@c-73-221-225-225.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 20:22 -!- ironmarx [~ironmarx@84.39.116.180] has joined #bitcoin-core-dev 20:25 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 260 seconds] 20:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:33 < bitcoin-git> [bitcoin] fanquake opened pull request #18879: valgrind: remove outdated suppressions (master...remove_outdated_supp) https://github.com/bitcoin/bitcoin/pull/18879 20:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:51 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:55 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds] 20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:56 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e727c2bdcab3...ec79b5f86b22 20:56 < bitcoin-git> bitcoin/master ff046ae practicalswift: wallet: Make sure no DescriptorScriptPubKeyMan members are uninitialized a... 20:56 < bitcoin-git> bitcoin/master 2a78098 practicalswift: wallet: Make sure no WalletDescriptor members are uninitialized after cons... 20:56 < bitcoin-git> bitcoin/master ec79b5f Samuel Dobson: Merge #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDesc... 20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:56 < bitcoin-git> [bitcoin] meshcollider merged pull request #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction (master...uninitialized-members) https://github.com/bitcoin/bitcoin/pull/18782 20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:00 -!- tryphe__ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 21:03 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 21:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:09 < bitcoin-git> [bitcoin] luke-jr opened pull request #18880: [0.20] wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (0.20...pr18671-0.20) https://github.com/bitcoin/bitcoin/pull/18880 21:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:16 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds] 21:16 -!- ppisati [~ppisati@net-93-66-50-11.cust.vodafonedsl.it] has quit [Quit: leaving] 21:16 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 21:19 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:22 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:22 -!- vasild_ is now known as vasild 21:23 -!- ppisati [~ppisati@net-47-53-118-140.cust.vodafonedsl.it] has joined #bitcoin-core-dev 21:28 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 21:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 21:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 21:42 < achow101> #proposedwalletmeetingtopic Moving to a new storage database for descriptor wallets 21:44 < sipa> reviving #5686? 21:44 < gribble> https://github.com/bitcoin/bitcoin/issues/5686 | [Wallet] replace BDB with internal append only (logdb) backend by jonasschnelli · Pull Request #5686 · bitcoin/bitcoin · GitHub 21:45 < achow101> possibly 21:45 < achow101> or something else entirely. that's for us to discuss/bikeshed I guess 21:47 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-njxicmssnodokxmn] has quit [Quit: Connection closed for inactivity] 21:47 < sipa> sqlite has been suggested as well before 21:48 < achow101> that was one option I was looking at 21:48 < achow101> another was lmdb 21:53 < sipa> lmdb is very performant, but has an architecture-dependent format 21:53 < sipa> also, all of this is overkill - we don't need a database 21:53 < sipa> just a list of key value pairs that are loaded at startup and occasionally overwritten 21:54 < achow101> yeah but I don't want to write/review something from scratch 21:54 < sipa> so it's not worth making many convenience compromises for 21:54 < sipa> that's very reasonable 21:55 < achow101> one thing that I would like to do is to have each ScriptPubKeyMan manage its own storage. and that would be achievable through giving each a table or subdatabase (that's a think in bdb and lmdb) 21:55 < sipa> why? 21:55 < sipa> as in separate files? 21:55 < achow101> no in the same file 21:55 < sipa> what does that mean/accomplish? 21:56 < achow101> but the specifics of how stuff is stored and what is stored is self contained within a ScriptPubKeyMan's module 21:56 < achow101> i guess it's bringing the encapsulation of the code to the storage layer as well 21:56 < sipa> that could be done by just giving each a unique prefix for its keys 21:58 < achow101> i guess... 21:58 < sipa> i meam, if the db system used exposes a feature to do this more natively, sure use it 21:59 < sipa> but i don't think it's worth picking one db system over another for, or at least not if it comes with other compromises 21:59 < sipa> compatibility of wallet files i think would be a dealbreaker for lmdb 21:59 < achow101> right 22:00 < achow101> i've been primarily looking for things that are self contained single files, platform independent, and not likely to have changing formtas 22:00 < sipa> sqlite seems to match that 22:00 < achow101> lmdb has some build options that make it independent of bitness, but not endianness 22:00 < sipa> or text files ;) 22:01 < achow101> apparently monero uses lmdb for something and the guy that wrote/writes/maintains lmdb contributes there 22:01 < sipa> yes 22:02 < sipa> but lmdb is very focused on performance 22:02 < sipa> for the wallet we couldn't care less about that 22:02 < achow101> well I'd like to care about performace :) 22:02 < sipa> why? 22:03 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 22:03 < achow101> there was that one time importmulti would take so long writing everthing to disk that the RPC would timeout before it finished 22:04 < sipa> that was just due to silliness of flushing in between any two records writte 22:04 < sipa> no. 22:04 < sipa> ? 22:04 < sipa> if writing a few kb takes more than milliseconds it's not a fault of the db system 22:05 < achow101> it was. but a performant db system means I can do dumb things like that and not have a noticeable impact on the user experince :p 22:06 < sipa> no 22:06 < sipa> this is literally not something any db system could make reasnable 22:06 < achow101> I was really only looking at lmdb since it seemed to be almost a drop in replacement for bdb 22:06 < achow101> yeah, i know. i'm just trolling you 22:07 < sipa> okay :D 22:10 < achow101> i'm not sure that a key-value store is really what we want though. what we have now just feels like jamming separate values to fit into a key-value store. we have a bunch of records that are multiple values that could fit better into table 22:11 < achow101> although I would agree with a relation db system is way overkill 22:11 < sipa> well, you're right that it's not quite exactly a key-value store 22:11 < sipa> but it is how it works now 22:12 < sipa> changing the organization of the data as well as the backend storage is a way bigger change 22:12 < achow101> that was part of the plan 22:12 < sipa> even things like google's bigtable is effectively leveldb but with keys that are sort of a hierarchy of fields 22:12 < sipa> ugh :) 22:13 < sipa> seems unnecesary 22:16 < achow101> I would like to do some things like consolidated address book data and changing unenecrypted privkey storage format that would make it diverge from what we currently have 22:17 -!- tryphe__ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 22:17 -!- tryphe__ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:17 < sipa> you can do that without changing the organization or the storage format 22:18 < achow101> address book stuff would be different records entirely so that's changing the organization 22:19 < sipa> i mean: it doesn't require moving away from a key-value store 22:20 < achow101> nothing strictly requires one or the other so it's just a function of how much work you want to do 22:20 < sipa> as little as possible :) 22:21 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:21 -!- enasigurd [enasigurd@gateway/shell/xshellz/x-fkzpdtjmgsfvxbrc] has quit [Ping timeout: 260 seconds] 22:21 -!- enasigurd [enasigurd@gateway/shell/xshellz/x-siqhnvpsupmbmnyf] has joined #bitcoin-core-dev 22:24 -!- tryphe__ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 23:00 -!- ironmarx [~ironmarx@84.39.116.180] has quit [] 23:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:05 < bitcoin-git> [bitcoin] hebasto opened pull request #18881: Prevent UB in DeleteLock() function (master...200505-cofu) https://github.com/bitcoin/bitcoin/pull/18881 23:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:16 -!- jarthur_ [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 23:20 -!- jarthur [~jarthur@2605:6000:1019:4971:dd2d:30df:873:23a7] has quit [Ping timeout: 260 seconds] 23:21 -!- jarthur_ [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Ping timeout: 272 seconds] 23:22 -!- silvers- [~silvers-@141.98.102.235] has joined #bitcoin-core-dev 23:25 -!- Landryl4 [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev 23:26 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: Ping timeout (120 seconds)] 23:26 -!- Landryl4 is now known as Landryl 23:31 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 23:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:45 < jonasschnelli> achow101: what would speak against a simple append only file-format? Keep all the wallets in memory for fast performance. And if memory gets a concern, load the transactions when required. 23:45 < jonasschnelli> I'd say even for large wallets, that should be reasonable fast. 23:46 < achow101> jonasschnelli: i don't think we should do append only. we currently do things that would not work well with append only and it seems reasonable that we would do things similarly in the future 23:47 < achow101> for example UpgradeKeyMetadata modifies CKeyMetadata and doing this in an append only format would not be ideal 23:47 < jonasschnelli> If one wants to increase the performance of tx loading / decomposing, one could implement kinda subtotals... which would reduce the balance algorithms to not always scan the whole tx database 23:47 < jonasschnelli> achow101: just write the new records as append only,... which would internally overwrite the old recods... 23:47 < jonasschnelli> just disk size and loading time would increase 23:48 < jonasschnelli> until one performs a compact-save (write 100% again) 23:48 < achow101> well yeah, that's the problem 23:48 < jonasschnelli> what? the compact write? 23:48 < achow101> the duplicate records which impacts disk size and loading times 23:48 < jonasschnelli> or the disk size? 23:49 < jonasschnelli> who cares about disk size if you have 300GB+ blockchain data? :-) 23:49 < jonasschnelli> and if you care, do a compact-save 23:49 < jonasschnelli> (optimizewallet call or so) 23:49 < jonasschnelli> and you could write special "overwrite" records for things that happen often and use little space. 23:49 < jonasschnelli> Not often. but take abandontransaction as example. 23:50 < jonasschnelli> just write a special record type that abandons a tx id rather than stroing the whole tx stucture again. 23:50 < jonasschnelli> (would only be required if you care about disk size though) 23:51 < achow101> a compact save seems like a possibility to lose data 23:51 < achow101> and I don't really want the user to have to manually initiate one, doesn't feel like good ux 23:51 < jonasschnelli> achow101: not if done right... compact write to a second file, validate integrity, atomic swap 23:52 < jonasschnelli> achow101: you could calculate the % overhead on each load,.. if to large, compact save. 23:52 < jonasschnelli> is matters of milliseconds. 23:52 < jonasschnelli> integrity can be guaranteed if done right 23:52 < jonasschnelli> no external dependencies.... 23:52 < jonasschnelli> sha256 hash per record to have a database "made" for secrets 23:53 < sipa> yeah, that's what logdb did 23:53 < jonasschnelli> I would avoid getting caught in sqlite3 or lmdb pitfalls 23:53 < jonasschnelli> sipa: exactly 23:54 < jonasschnelli> the only question for me is, if it is acceptable to have everything in memory and if not, how hard it would be to have a disk based tx decomposer 23:54 < sipa> i'd be ok with sqlite 23:54 < jonasschnelli> yeah,... for the tx history,... but just for the keys, scripts, it seems to be an overkill 23:55 < sipa> it's absolutely overkill 23:55 < achow101> jonasschnelli: it's slightly difficult for right now to not have all the txs in memory 23:55 < achow101> bunch of gui stuff relies on that fact 23:55 < achow101> i have a branch that attempted to load txs on demand and it was kinda awful 23:55 < sipa> but it's also a well-tested existing standalone library that does what we need - and a lot we don't need 23:55 < jonasschnelli> achow101: indeed. Optimizing performance would require some sub-total (balance-up-to-this-tx) cache 23:55 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-xurpobhjeosdspnh] has joined #bitcoin-core-dev 23:56 < sipa> i would avoid lmdb, it seems designed for very different goals 23:56 < jonasschnelli> Yes. Makes little sense for a wallet IMO 23:57 < achow101> IIRC Armory is using/was going to use lmdb for the wallet. dunno how far that got 23:57 < achow101> but yeah, after looking at lmdb, it doesn't seem like a good fit, particularly the arch dependent format 23:59 < achow101> bikeshedding over what format to use can come later though. I first want to know if trying to do this now will even get anywhere 23:59 < jonasschnelli> first it would be good to layer out bdb... --- Log closed Tue May 05 00:00:11 2020