--- Log opened Wed May 13 00:00:19 2020 00:08 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 00:10 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 00:18 -!- exhoplex1 [~exhoplex@btc.tfuel.video] has quit [Ping timeout: 240 seconds] 00:18 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 00:19 -!- exhoplex [~exhoplex@btc.tfuel.video] has quit [Ping timeout: 272 seconds] 00:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:19 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8da1e43b63cb...219c55da752d 00:19 < bitcoin-git> bitcoin/master de5e91c Hennadii Stepanov: refactor: Add BerkeleyDatabaseVersion() function 00:19 < bitcoin-git> bitcoin/master 839add1 Hennadii Stepanov: build: Enable -Wsuggest-override 00:19 < bitcoin-git> bitcoin/master 219c55d fanquake: Merge #16710: build: Enable -Wsuggest-override if available 00:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:20 < bitcoin-git> [bitcoin] fanquake merged pull request #16710: build: Enable -Wsuggest-override if available (master...20190824-consistent-override) https://github.com/bitcoin/bitcoin/pull/16710 00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:36 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 00:36 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 00:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds] 00:43 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds] 00:46 -!- tmoc [~textual@c-73-41-135-128.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:50 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 01:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:05 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 01:07 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 01:10 -!- go11111111111 [~go1111111@104.156.98.86] has quit [Ping timeout: 256 seconds] 01:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:13 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/219c55da752d...8d17f8dc1773 01:13 < bitcoin-git> bitcoin/master e8123ea João Barbosa: gui: Fix itemWalletAddress leak when not tree mode 01:13 < bitcoin-git> bitcoin/master 8d17f8d Jonas Schnelli: Merge #18578: gui: Fix leak in CoinControlDialog::updateView 01:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:14 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #18578: gui: Fix leak in CoinControlDialog::updateView (master...2020-fix-coincontroldialog-leak) https://github.com/bitcoin/bitcoin/pull/18578 01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:16 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d17f8dc1773...246e878e7845 01:16 < bitcoin-git> bitcoin/master a8b5f1b João Barbosa: gui: Fix manual coin control with multiple wallets loaded 01:16 < bitcoin-git> bitcoin/master 246e878 Jonas Schnelli: Merge #18894: gui: Fix manual coin control with multiple wallets loaded 01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:16 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #18894: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725.2) https://github.com/bitcoin/bitcoin/pull/18894 01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:27 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:27 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 01:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:48 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:57 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 02:00 -!- Greedi [~Greedi@178.162.204.214] has quit [] 02:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 02:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 02:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:12 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 02:21 -!- fajro [~fajro@84.39.116.180] has joined #bitcoin-core-dev 02:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Quit: Gone frying asparagus or my Windows had a BSOD] 02:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:36 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/246e878e7845...a33901cb6d82 02:36 < bitcoin-git> bitcoin/master a2e6db5 João Barbosa: rpc: Add mutex to guard deadlineTimers 02:36 < bitcoin-git> bitcoin/master 9f59dde João Barbosa: rpc: Relock wallet only if most recent callback 02:36 < bitcoin-git> bitcoin/master a33901c fanquake: Merge #18814: rpc: Relock wallet only if most recent callback 02:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:36 < bitcoin-git> [bitcoin] fanquake merged pull request #18814: rpc: Relock wallet only if most recent callback (master...2020-04-rpc-wallet-relock) https://github.com/bitcoin/bitcoin/pull/18814 02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:52 -!- cataly5m7 [~cataly5m@static.65.177.203.116.clients.your-server.de] has quit [Quit: The Lounge - https://thelounge.chat] 02:53 -!- cataly5m [~cataly5m@static.65.177.203.116.clients.your-server.de] has joined #bitcoin-core-dev 02:54 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 02:54 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:01 -!- cataly5m is now known as m1rror 03:02 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 03:03 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 03:09 < midnight> sipa: I'm getting a kick out of how you're just did it in Perl and C. 03:14 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 03:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 03:27 -!- Rikudouainsoph [29be0391@41.190.3.145] has joined #bitcoin-core-dev 03:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 03:43 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 03:45 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 03:55 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 04:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 04:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:05 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 04:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 04:07 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 04:13 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 04:16 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 04:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 04:20 -!- Izl [~Izl@unaffiliated/aru01] has joined #bitcoin-core-dev 04:21 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 04:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 04:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 04:48 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 04:52 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 04:53 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:56 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:00 -!- fajro [~fajro@84.39.116.180] has quit [] 05:02 -!- Rikudouainsoph [29be0391@41.190.3.145] has quit [Ping timeout: 245 seconds] 05:05 -!- thanks [c5d22e39@197.210.46.57] has joined #bitcoin-core-dev 05:07 -!- thanks [c5d22e39@197.210.46.57] has quit [Remote host closed the connection] 05:09 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 05:11 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev 05:13 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:14 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 05:21 -!- kierra [~kierra@89.249.74.218] has joined #bitcoin-core-dev 05:22 -!- kierra is now known as Guest67738 05:22 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:34 -!- Rikudouainsoph [29be0391@41.190.3.145] has joined #bitcoin-core-dev 05:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 05:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 05:50 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 05:50 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 05:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds] 05:53 < wumpus> meshcollider: I think the run-time "is this WSL" detection raised a few eyebrows 06:02 < jonasschnelli> Wasn't #18877 rather a quick merge for a impactful p2p change? Just a 7 day window? 06:02 < gribble> https://github.com/bitcoin/bitcoin/issues/18877 | Serve cfcheckpt requests by jnewbery · Pull Request #18877 · bitcoin/bitcoin · GitHub 06:03 < wumpus> it's a fast turnaround for sure 06:03 < wumpus> though otoh it did get a lot of review, and it's an optional thing disabled by default 06:04 < jonasschnelli> Yes. I agree. Just it looks like there is no clear conceptual ACK on serving filters after BIP157 (don't get me wrong, I'm all for serving BIP157). 06:04 < jonasschnelli> I just think 6 days was to short for a reasonable discussion 06:05 -!- Rikudouainsoph [29be0391@41.190.3.145] has quit [Ping timeout: 245 seconds] 06:05 < wumpus> but it's sure very fast given that we're kind of in slow times 06:08 < fanquake> 🏎️ 06:09 < fanquake> One thing that's not getting faster is how long it takes to run all 160 tests of the functional test suite 06:09 < wumpus> luke-jr: look, I disagree, personally I'd prefer not to include to autogenerated cruft at all, and there's more people that don't, so I don't see it as a regression. Spliting up the PR makes sure there is at least progress on parts that we do agree on. IF that isn't a positive thing I honestly don't know. 06:10 -!- Highway61 [~Thunderbi@104.223.94.82] has quit [Quit: Highway61] 06:10 < jonasschnelli> 🐌🔑 06:11 < jonatack> jonasschnelli: the conceptual discussion is ongoing (at least for me) on bip157, but the changes in that PR didn't seem dangerous on their own after reviewing them, and reversible before the next release 06:12 < jonasschnelli> jonatack: I agree. Though an progressive merge behaviour is usually not the mode the project has worked in the past 06:12 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 06:12 < wumpus> this is not very welcoming to new contributors: https://github.com/bitcoin/bitcoin/pull/18965#issuecomment-627972210 please make sure that TODOs in the code are actual TODOs 06:13 < wumpus> I think maybe we shouldn't include TODOs in the code at all and open a github issue instead, this is easier to manage 06:13 < jonatack> jonasschnelli: i can understand that. there is also an opportunity cost in review resources. 06:13 -!- molakala [~sumanth.b@2601:192:4701:87f0:248b:8db4:3f75:79fa] has joined #bitcoin-core-dev 06:14 < jonasschnelli> jonatack: Yes. Agree. I just think leaving it open for a while would not have had an big impact on resources. 06:14 < jonasschnelli> (have more feedback, improve quality and get a conceptual agreement) 06:15 < fanquake> wumpus: Could do. Although looks like most are in validation & net processing, so might not be great as "good first issues" 06:16 < wumpus> fanquake: they don't strictly need to be "good first issues", usually it's just a way to mark technical debt I guess :) 06:16 < jonatack> jonasschnelli: can't disagree with that. and at some point the conceptual issuens need to be addressed. belcher's ML post about it today is interesting. 06:16 < wumpus> it's fine to have them if they're actually TODOs but such opinions tend to change over time, while they languish in the source code 06:16 < wumpus> (e.g. it was an opinion of one developer that it was a TODO at the time the code was originally written) 06:17 < fanquake> heh. There are definitely opinionated TODOs 06:17 < fanquake> "// TODO: Handle this much more gracefully (10 DoS points is super arbitrary)" 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:17 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a33901cb6d82...6c647c89db28 06:17 < bitcoin-git> bitcoin/master 0c63f80 Hennadii Stepanov: build: Suppress -Wdeprecated-copy warnings 06:17 < bitcoin-git> bitcoin/master 6c647c8 fanquake: Merge #18738: build: Suppress -Wdeprecated-copy warnings 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:17 < bitcoin-git> [bitcoin] fanquake merged pull request #18738: build: Suppress -Wdeprecated-copy warnings (master...200422-qt-warn) https://github.com/bitcoin/bitcoin/pull/18738 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:18 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 06:19 < wumpus> I think that's an okay one, it could be written as "This could be handlded much more gracefully" without losing it's meaning, it's not like the one in the tests a fragment "todo: def base58 decoding" *why* 06:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 06:37 < jnewbery> jonasschnelli: 18877 is the first 3 commits from 16442, which has been open for almost a year. It had 7 ACKs + 2 implicit ACKs from jimpo and me + 6 concept ACKs. How can one year and 15 [concept] ACKs possibly be considered too short or not enough discussion? 06:38 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 06:41 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 06:46 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev 06:47 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 06:51 -!- cryptoIndio [~cryptoInd@49.145.111.18] has quit [Quit: Leaving...] 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c647c89db28...99c03728c07c 06:53 < bitcoin-git> bitcoin/master f963a68 Russell Yanofsky: test: Add test for conflicted wallet tx notifications 06:53 < bitcoin-git> bitcoin/master 99c0372 Wladimir J. van der Laan: Merge #18878: test: Add test for conflicted wallet tx notifications 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:53 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] laanwj merged pull request #18878: test: Add test for conflicted wallet tx notifications (master...pr/nonot) https://github.com/bitcoin/bitcoin/pull/18878 06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:58 < jonasschnelli> jnewbery: good point. The PR description was not refering to 16442. I missed that. I just think we need to make sure everyone has been heard and ideally agrees on the concept. 06:58 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 06:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:59 < jonasschnelli> Dont get me wrong. I’m totally pro BIP157. 06:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 06:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:00 -!- Guest67738 [~kierra@89.249.74.218] has quit [Ping timeout: 260 seconds] 07:03 < wumpus> psa: please do not add anything to the 0.20.0 milestone anymore unless it's a critical bugfix for a regression, at this pace we're noever going to be able to do rc2 let alone a release 07:05 < wumpus> everything else (if it needs to go into 0.20 at all) can go into 0.20.1 07:05 < instagibbs> unless it's a weird concept or lots of code I see no harm in the base58_decode PR :shrug: 07:05 < instagibbs> agree in general TODOs need to be motivated 07:05 < wumpus> no harm but also no gain unless you see a use case? 07:06 < wumpus> we shouldn't just randomly add functions, it needs to be motivated 07:07 < instagibbs> i kind of disagree, unless you think there's just no useful test to write with it 07:07 < wumpus> that's not the point 07:07 < instagibbs> (maybe not!) 07:07 < wumpus> it can be added when a test needs it 07:07 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:07 < wumpus> the library is wholly to support our own use case, there shouldn't be anything 'just in case' in there 07:08 < wumpus> I mean, otherwise I'm sure in half a year or less someone will go through it and helpfully remove unused functions and we're round 07:08 < wumpus> in any case if *you* need it for a test it's good to add it 07:09 < instagibbs> tell him to add a test then? :) 07:09 < instagibbs> I did 07:10 < wumpus> a test for bitcoind that uses it, to be clear, not just a test for the function itself :) 07:11 < instagibbs> anyways, if I ever need it I'll just try to remember the future-ly closed PR and cherry-pick 07:12 < wumpus> fair enough 07:12 < ryanofsky> i definitely think #18965 is useful in its current form, even without a round trip test, though a round trip test would be useful 07:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18965 | tests: implement base58_decode by 10xcryptodev · Pull Request #18965 · bitcoin/bitcoin · GitHub 07:13 < ryanofsky> i spent an embarrasing amount of time trying to debug byte_to_base58 recently for what turned out to be a byte order issue in #18878 07:13 < gribble> https://github.com/bitcoin/bitcoin/issues/18878 | test: Add test for conflicted wallet tx notifications by ryanofsky · Pull Request #18878 · bitcoin/bitcoin · GitHub 07:14 < ryanofsky> having a decode function could have saved me going that that rabbit hole 07:15 < theStack> given that base58_decoded is needed, for me it seems kind of nonsensical to reinvent the wheel and manually code it out again; that's as absurd as if someone would implemented sha256 by hand in the test suite 07:15 < theStack> of course base58 is not part of the python standard library, but i'd either use a tested widespread library, or (if we 07:15 < theStack> don't want dependencies) copy it from that library 07:30 < jnewbery> jonasschnelli: ah, you're right. I should have linked back to the full PR in 18877. The last comment before merge lists out all the places that people have [concept] ACKed. 07:30 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:33 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 07:35 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 07:54 < promag> MarcoFalke: 18964 is not for 0.20 is it? 08:03 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev 08:04 < jnewbery> I don't think it's unreasonable to add a decode function if the encode function is there. At least that means we can test the encoder with round-trips. 08:05 < jnewbery> (but agree that we should remove TODOs if they're of only marginal benefit to the project. The issue system seems like a more appropriate place for those) 08:06 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 08:08 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:10 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:11 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Read error: Connection reset by peer] 08:11 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Read error: Connection reset by peer] 08:11 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:14 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 08:15 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:20 -!- veleiro [~user@fsf/member/veleiro] has joined #bitcoin-core-dev 08:21 -!- ThunderChicken1 [~ThunderCh@195.206.183.79] has joined #bitcoin-core-dev 08:23 -!- rmoura [~rmoura@114.52.115.89.rev.vodafone.pt] has joined #bitcoin-core-dev 08:23 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 08:24 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 08:24 -!- rmoura [~rmoura@114.52.115.89.rev.vodafone.pt] has quit [Client Quit] 08:27 -!- rmoura [~rmoura@114.52.115.89.rev.vodafone.pt] has joined #bitcoin-core-dev 08:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 08:36 -!- veleiro` [~user@ip-99-203-17-85.pools.cgn.spcsdns.net] has joined #bitcoin-core-dev 08:38 -!- veleiro [~user@fsf/member/veleiro] has quit [Ping timeout: 258 seconds] 08:42 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 08:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 08:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 08:45 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 08:50 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 08:51 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:52 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 08:52 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Read error: Connection reset by peer] 08:53 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 08:57 -!- proofofk_ [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 08:57 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 09:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:11 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 09:11 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 09:13 -!- EagleTM is now known as Eagle[TM] 09:14 -!- Eagle[TM] is now known as EagleTM 09:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 09:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 09:19 -!- nehan [~nehan@41.213.196.104.bc.googleusercontent.com] has quit [Quit: leaving] 09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:20 -!- nehan [~nehan@41.213.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 09:20 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 09:20 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection] 09:20 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Client Quit] 09:21 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 09:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 09:21 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Quit: Ping timeout (120 seconds)] 09:21 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev 09:22 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:23 -!- vasild_ is now known as vasild 09:25 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 09:25 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 09:26 -!- lightlike [~lightlike@p200300C7EF1A0F00E55E228E8DC90D42.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:38 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 09:39 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 09:42 -!- veleiro`` [~user@ip-108-121-142-247.ekrgmd.spcsdns.net] has joined #bitcoin-core-dev 09:43 -!- veleiro` [~user@ip-99-203-17-85.pools.cgn.spcsdns.net] has quit [Ping timeout: 246 seconds] 09:45 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 09:46 -!- veleiro`` [~user@ip-108-121-142-247.ekrgmd.spcsdns.net] has left #bitcoin-core-dev [] 09:47 -!- veleiro [~user@fsf/member/veleiro] has joined #bitcoin-core-dev 09:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 09:50 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:79fa:9bdf:6272:bed7] has joined #bitcoin-core-dev 09:52 -!- b10c [~b10c@2001:16b8:2e12:8c00:6403:a492:9cfe:36ca] has joined #bitcoin-core-dev 09:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 09:56 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 09:57 -!- veleiro` [~user@184-15-29-150.dr01.chtn.wv.frontiernet.net] has joined #bitcoin-core-dev 09:59 -!- veleiro [~user@fsf/member/veleiro] has quit [Ping timeout: 265 seconds] 10:00 -!- Processus42 [~leo@unaffiliated/processus42] has quit [Ping timeout: 256 seconds] 10:00 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 10:00 -!- Processus42 [~leo@unaffiliated/processus42] has joined #bitcoin-core-dev 10:03 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev 10:04 -!- michaelf_ [~textual@2a00:23c5:be01:b201:85d2:62f:72a7:cf48] has joined #bitcoin-core-dev 10:05 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:79fa:9bdf:6272:bed7] has quit [Ping timeout: 246 seconds] 10:05 -!- michaelf_ [~textual@2a00:23c5:be01:b201:85d2:62f:72a7:cf48] has quit [Client Quit] 10:06 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:85d2:62f:72a7:cf48] has joined #bitcoin-core-dev 10:09 -!- jarthur [~jarthur@2605:6000:1019:4971:80b1:4d3a:6e1f:4635] has joined #bitcoin-core-dev 10:13 -!- michaelf_ [~textual@2a00:23c5:be01:b201:6c2c:5858:1258:3ac8] has joined #bitcoin-core-dev 10:15 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:85d2:62f:72a7:cf48] has quit [Ping timeout: 265 seconds] 10:16 -!- michaelf_ [~textual@2a00:23c5:be01:b201:6c2c:5858:1258:3ac8] has quit [Client Quit] 10:17 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:6c2c:5858:1258:3ac8] has joined #bitcoin-core-dev 10:25 -!- michaelf_ [~textual@2a00:23c5:be01:b201:88e5:5024:9021:20fc] has joined #bitcoin-core-dev 10:26 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:6c2c:5858:1258:3ac8] has quit [Ping timeout: 244 seconds] 10:28 -!- michaelf_ [~textual@2a00:23c5:be01:b201:88e5:5024:9021:20fc] has quit [Client Quit] 10:29 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:88e5:5024:9021:20fc] has joined #bitcoin-core-dev 10:29 -!- michaelfolkson is now known as michaelfolkson2 10:31 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:32 -!- michaelfolkson2 is now known as michaelfolkson 10:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:36 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99c03728c07c...5d18c0ae1827 10:36 < bitcoin-git> bitcoin/master 8bf1540 fanquake: build: remove fdelt_chk backwards compatibility code 10:36 < bitcoin-git> bitcoin/master df6bde0 fanquake: test: remove glibc fdelt sanity check 10:36 < bitcoin-git> bitcoin/master 5d18c0a Wladimir J. van der Laan: Merge #18862: Remove fdelt_chk back-compat code and sanity check 10:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:36 < bitcoin-git> [bitcoin] laanwj merged pull request #18862: Remove fdelt_chk back-compat code and sanity check (master...remove_fdelt_chk_back_compat) https://github.com/bitcoin/bitcoin/pull/18862 10:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:38 -!- rmoura [~rmoura@114.52.115.89.rev.vodafone.pt] has quit [Quit: buy some bitcoin. bye bye] 10:40 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:40 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 10:41 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:41 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 10:55 -!- rmoura [~rmoura@114.52.115.89.rev.vodafone.pt] has joined #bitcoin-core-dev 10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:59 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968 10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:00 -!- ThunderChicken1 [~ThunderCh@195.206.183.79] has quit [] 11:03 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has quit [Quit: r251d] 11:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 11:09 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Quit: Lost terminal] 11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:15 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/5d18c0ae1827...fc895d7700f9 11:15 < bitcoin-git> bitcoin/master 1e06bb6 Hennadii Stepanov: Drop unused CLIENT_VERSION_SUFFIX macro 11:15 < bitcoin-git> bitcoin/master dc1fba9 Hennadii Stepanov: scripted-diff: Rename share/genbuild.sh macros to more meaningful ones 11:15 < bitcoin-git> bitcoin/master 35f1189 Hennadii Stepanov: build: Rename BUILD_* macros and the code self-descriptive 11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:15 < bitcoin-git> [bitcoin] laanwj merged pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616 11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:22 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:31 < bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/fc895d7700f9...51825aea7fa0 11:31 < bitcoin-git> bitcoin/master fe05dd0 Hennadii Stepanov: util: Enhance bilingual_str 11:31 < bitcoin-git> bitcoin/master 4c9b9a4 Hennadii Stepanov: util: Enhance Join() 11:31 < bitcoin-git> bitcoin/master da16f95 Hennadii Stepanov: gui: Do not translate InitWarning messages in debug.log 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:31 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #18922: gui: Do not translate InitWarning messages in debug.log (master...200509-initwarn) https://github.com/bitcoin/bitcoin/pull/18922 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:40 < MarcoFalke> [23:19] would be nice if Travis sent an email to the PR creator when it failed :x 11:40 < MarcoFalke> You can enable travis in your own repo to get emails 11:53 -!- ecrist1 [~ecrist@178.162.209.171] has joined #bitcoin-core-dev 11:56 < MarcoFalke> Btw, I have a lot of good first issues to work on. If someone is out there that wants them, please contact me. If I don't hear back, I will put them on the main repo maybe next week. 11:59 < shesek> how do conflicting transactions fit into the most recent sorting of listttransactions? do they get sorted as the most recent like the negative confirmations number might imply? or at their original height? also, are there any guarantees for the ordering of unconfirmed transactions among themselves? 12:12 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 12:15 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 12:30 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds] 12:35 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:38 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51825aea7fa0...a9a6d946e41b 12:38 < bitcoin-git> bitcoin/master faa26d3 MarcoFalke: test: Remove RPCOverloadWrapper boilerplate 12:38 < bitcoin-git> bitcoin/master a9a6d94 MarcoFalke: Merge #18888: test: Remove RPCOverloadWrapper boilerplate 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:38 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18888: test: Remove RPCOverloadWrapper boilerplate (master...2005-testNoBoilerplate) https://github.com/bitcoin/bitcoin/pull/18888 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:40 -!- b10c [~b10c@2001:16b8:2e12:8c00:6403:a492:9cfe:36ca] has quit [Quit: Leaving] 12:48 -!- Kiminuo [~mix@141.98.103.230] has joined #bitcoin-core-dev 13:00 < MarcoFalke> begging for one or two more ACKs on #18742 . I think we should make some progress on rc2 13:00 < gribble> https://github.com/bitcoin/bitcoin/issues/18742 | miner: Avoid stack-use-after-return in validationinterface by MarcoFalke · Pull Request #18742 · bitcoin/bitcoin · GitHub 13:12 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:88e5:5024:9021:20fc] has quit [Ping timeout: 256 seconds] 13:15 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 13:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:20 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9a6d946e41b...04c09553d898 13:20 < bitcoin-git> bitcoin/master a30b0a2 Vasil Dimov: build: enable -Werror=gnu 13:20 < bitcoin-git> bitcoin/master 04c0955 Wladimir J. van der Laan: Merge #18887: build: enable -Werror=gnu 13:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:21 < bitcoin-git> [bitcoin] laanwj merged pull request #18887: build: enable -Werror=gnu (master...add_Werror_gnu) https://github.com/bitcoin/bitcoin/pull/18887 13:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:40 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Quit: Textual IRC Client: www.textualapp.com] 13:40 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 13:43 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Client Quit] 13:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 13:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 13:47 -!- michaelfolkson [~michaelfo@2a03:b0c0:1:e0::23d:d001] has joined #bitcoin-core-dev 13:49 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 13:50 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 13:51 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has quit [Remote host closed the connection] 13:55 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Quit: Textual IRC Client: www.textualapp.com] 13:57 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 13:57 -!- Kiminuo [~mix@141.98.103.230] has quit [Ping timeout: 256 seconds] 14:00 -!- ecrist1 [~ecrist@178.162.209.171] has quit [] 14:03 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:04 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:04 -!- nubescaeli [~10402C85B@95.245.163.112] has joined #bitcoin-core-dev 14:04 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 14:07 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Client Quit] 14:08 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 14:08 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 258 seconds] 14:11 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Client Quit] 14:11 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 14:13 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Client Quit] 14:13 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 14:17 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 14:18 -!- Steini- [~Steini-@84.39.116.180] has joined #bitcoin-core-dev 14:20 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:20 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 14:22 -!- Izl [~Izl@unaffiliated/aru01] has quit [Ping timeout: 260 seconds] 14:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 14:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:24 -!- Kiminuo [~mix@141.98.103.230] has joined #bitcoin-core-dev 14:24 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: leaving] 14:26 -!- molakala [~sumanth.b@2601:192:4701:87f0:248b:8db4:3f75:79fa] has quit [Ping timeout: 244 seconds] 14:27 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 14:29 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:29 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 14:41 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:46 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:49 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 14:53 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 14:53 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 14:58 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:59 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 15:00 -!- veleiro`` [~user@184-15-18-160.dr01.chtn.wv.frontiernet.net] has joined #bitcoin-core-dev 15:01 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has joined #bitcoin-core-dev 15:04 -!- veleiro` [~user@184-15-29-150.dr01.chtn.wv.frontiernet.net] has quit [Ping timeout: 256 seconds] 15:05 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Remote host closed the connection] 15:05 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 258 seconds] 15:05 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev 15:06 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 15:07 -!- Anduck [~Anduck@unaffiliated/anduck] has quit [Ping timeout: 258 seconds] 15:08 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 15:20 -!- tmoc [~textual@c-73-41-135-128.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.7.1] 15:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:34 -!- michael__ [~textual@2a00:23c5:be01:b201:51f:ad4a:41c4:e367] has joined #bitcoin-core-dev 15:34 -!- michaelf_ [~textual@2a00:23c5:be01:b201:807:4839:1991:9221] has quit [Ping timeout: 272 seconds] 15:38 -!- michael__ [~textual@2a00:23c5:be01:b201:51f:ad4a:41c4:e367] has quit [Client Quit] 15:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:47 < bitcoin-git> [bitcoin] promag closed pull request #18791: wip: Only support shared validation interfaces (master...2020-04-only-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18791 15:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:55 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 15:58 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Read error: Connection reset by peer] 16:14 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 16:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 16:30 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 16:31 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:36 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 260 seconds] 16:37 -!- lightlike [~lightlike@p200300C7EF1A0F00E55E228E8DC90D42.dip0.t-ipconnect.de] has quit [Quit: Leaving] 16:38 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving] 16:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 16:56 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 16:58 -!- tryphe_ is now known as tryphe 17:00 -!- Steini- [~Steini-@84.39.116.180] has quit [] 17:02 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 17:02 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 17:03 -!- Guest75362 [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:04 < bitcoin-git> [bitcoin] achow101 opened pull request #18971: wallet: Refactor the classes in wallet/db.{cpp/h} (master...refactor-storage) https://github.com/bitcoin/bitcoin/pull/18971 17:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:07 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 272 seconds] 17:08 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 17:09 -!- veleiro`` [~user@184-15-18-160.dr01.chtn.wv.frontiernet.net] has left #bitcoin-core-dev [] 17:10 -!- veleiro [~user@fsf/member/veleiro] has joined #bitcoin-core-dev 17:20 -!- jden [~jden@139.28.218.198] has joined #bitcoin-core-dev 17:25 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:26 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:28 -!- veleiro` [~user@50-110-108-202.blfd.wv.frontiernet.net] has joined #bitcoin-core-dev 17:32 -!- veleiro [~user@fsf/member/veleiro] has quit [Ping timeout: 265 seconds] 17:34 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 17:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:36 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 256 seconds] 17:42 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 17:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:48 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 17:49 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 18:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 18:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:32 < bitcoin-git> [bitcoin] luke-jr opened pull request #18972: WIP: net: Add blockfilters white{bind,list} permission flag (master...neutrino_whitelist) https://github.com/bitcoin/bitcoin/pull/18972 18:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:42 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 260 seconds] 18:43 -!- Guest75362 [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 18:44 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 18:46 -!- Guest75362 [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 19:18 -!- desperad0 [7ac73ee0@122-199-62-224.ip4.superloop.com] has joined #bitcoin-core-dev 19:30 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 19:32 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 19:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:38 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev 19:38 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 19:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 19:47 -!- Pasha is now known as Cory 20:00 -!- jden [~jden@139.28.218.198] has quit [] 20:03 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Read error: Connection reset by peer] 20:19 -!- Kiminuo [~mix@141.98.103.230] has quit [Ping timeout: 265 seconds] 20:24 -!- Kiminuo [~mix@141.98.103.230] has joined #bitcoin-core-dev 20:40 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 20:40 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 20:40 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.8] 20:45 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds] 20:53 -!- greynix [~greynix@195.206.183.79] has joined #bitcoin-core-dev 20:55 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 20:55 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 20:55 -!- go11111111111 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev 20:58 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 264 seconds] 21:19 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:23 -!- vasild_ is now known as vasild 21:32 -!- Guest75362 is now known as justanotheruser 21:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:37 < bitcoin-git> [bitcoin] fanquake opened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973 21:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:58 -!- Kiminuo [~mix@141.98.103.230] has quit [Ping timeout: 265 seconds] 23:00 -!- greynix [~greynix@195.206.183.79] has quit [] 23:03 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 23:05 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-vraowspxdppwvmxy] has joined #bitcoin-core-dev 23:18 -!- Kiminuo [~mix@141.98.103.230] has joined #bitcoin-core-dev 23:20 -!- MarconM [~MarconM@137.63.71.51] has joined #bitcoin-core-dev 23:28 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 260 seconds] 23:29 -!- MarconM [~MarconM@137.63.71.51] has quit [Ping timeout: 260 seconds] 23:36 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 23:37 -!- Kiminuo [~mix@141.98.103.230] has quit [Ping timeout: 256 seconds] 23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:46 < bitcoin-git> [bitcoin] elichai closed pull request #17953: refactor: Abstract boost::variant out (master...2020-01-variant) https://github.com/bitcoin/bitcoin/pull/17953 23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:48 -!- Cory is now known as Pasha 23:49 -!- Pasha [~Cory@071-013-023-252.res.spectrum.com] has quit [] 23:53 -!- OneFixt [~OneFixt@139.28.218.198] has joined #bitcoin-core-dev 23:57 -!- Cory [~Cory@071-013-023-252.res.spectrum.com] has joined #bitcoin-core-dev --- Log closed Thu May 14 00:00:20 2020