--- Log opened Mon May 25 00:00:30 2020 00:02 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 00:06 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 00:26 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 00:56 -!- kljasdfvv [~flack@p200300d46f079c00a9ddae03b700ad2c.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 01:27 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 01:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 01:49 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 02:00 -!- jaqque1 [~jaqque@195.206.169.238] has quit [] 02:00 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 02:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 02:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 02:12 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:21 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Quit: Leaving] 02:22 -!- jscarmona1 [~jscarmona@195.206.183.79] has joined #bitcoin-core-dev 02:44 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 02:47 -!- tarboss [~tarboss@p54a0340e.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 02:48 -!- tarboss [~tarboss@p54a0340e.dip0.t-ipconnect.de] has quit [Client Quit] 02:50 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 02:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 03:03 -!- Elizabeth33Barte [~Elizabeth@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:06 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 03:07 -!- Elizabeth33Barte [~Elizabeth@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 03:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:21 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 03:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:21 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 03:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:32 < harding> provoostenator_: there's an item in the 0.20 release notes draft starting with "Transactions which do not produce change outputs can still be created even if a change address cannot be fetched.". MarcoFalke queried about which PR that belongs to and I believe it's #17219, which is in master but not in 0.20 AFAICT. I'm going to drop it from the draft, but please let me know if that's wrong and I'll restore it. I can also open a 03:32 < harding> PR adding it to the release notes in master, unless you want to do that. 03:32 < gribble> https://github.com/bitcoin/bitcoin/issues/17219 | wallet: allow transaction without change if keypool is empty by Sjors · Pull Request #17219 · bitcoin/bitcoin · GitHub 03:33 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 03:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 03:38 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:46 < shesek> is it a known issue that importing an address doesn't track its existing mempool transactions until they get confirmed? or am I missing something? here's a reproduction script and the output I'm seeing: https://gist.github.com/shesek/9c82c0e50f3d2f44f36078dd8daed280 03:48 -!- provoostenator_ [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 03:51 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 04:00 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Ping timeout: 272 seconds] 04:01 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 04:04 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev 04:08 < elichai2> shesek: hmm idk about known issue, but it looks like the code only does a rescan of the chain and not a rescan of the mempool 04:11 < elichai2> I don't mind working on this, but I'll first let someone who knows the wallet better to respond :) if it's actually missing, should this be part of the existing rescan or a new type of rescan? (sipa achow101 ) 04:14 < fjahr> Is this the same issue? https://github.com/bitcoin/bitcoin/issues/18954 04:19 < elichai2> yep :) 04:19 < elichai2> at least it looks like it 04:20 < elichai2> shesek: feel free to test this https://github.com/bitcoin/bitcoin/pull/18964 (promag ) 04:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:23 < shesek> I will try this and report back, thanks! 04:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:26 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:30 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 04:34 -!- Victor_sueca is now known as Victorsueca 04:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:37 -!- jscarmona1 [~jscarmona@195.206.183.79] has quit [Ping timeout: 256 seconds] 04:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:59 -!- Guest32100 [~ao2@217.138.204.89] has joined #bitcoin-core-dev 05:00 -!- Guest32100 [~ao2@217.138.204.89] has quit [] 05:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds] 05:07 -!- drbrule [sid395654@gateway/web/irccloud.com/x-spubiqgnxgdxhodb] has quit [Ping timeout: 260 seconds] 05:10 -!- drbrule [sid395654@gateway/web/irccloud.com/x-vqcbtdzyxhuumfbq] has joined #bitcoin-core-dev 05:16 -!- feb1 [~feb@185.204.1.185] has joined #bitcoin-core-dev 05:30 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 05:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Quit: Leaving] 05:39 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 05:42 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 265 seconds] 05:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 05:51 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev 05:54 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 05:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:58 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:59 < bitcoin-git> [bitcoin] fanquake closed pull request #18151: build: replace libdmg and genisoimage with xorriso (master...xorriso_replaces_libdmg_genisoimage) https://github.com/bitcoin/bitcoin/pull/18151 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:59 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 06:02 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 06:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds] 06:06 -!- jonatack [~jon@184.75.221.3] has joined #bitcoin-core-dev 06:15 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 240 seconds] 06:27 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 06:40 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:48 -!- shesek [~shesek@5.102.222.33] has joined #bitcoin-core-dev 06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:54 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 240 seconds] 07:05 -!- shesek [~shesek@5.102.222.33] has quit [Quit: Leaving] 07:05 -!- shesek [~shesek@5.102.222.33] has joined #bitcoin-core-dev 07:05 -!- shesek [~shesek@5.102.222.33] has quit [Read error: Connection reset by peer] 07:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Quit: Gone frying asparagus or my Windows had a BSOD] 07:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:11 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 07:21 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 07:25 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 07:52 < wumpus> this is strange: #19066 -- are there any conditions where bad_alloc can still be thrown when a new_handler is set? 07:52 < gribble> https://github.com/bitcoin/bitcoin/issues/19066 | corruption due to lack of memory is not handled · Issue #19066 · bitcoin/bitcoin · GitHub 07:55 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 07:56 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 07:59 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 08:00 -!- feb1 [~feb@185.204.1.185] has quit [] 08:00 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 08:03 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 08:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:07 < bitcoin-git> [bitcoin] practicalswift opened pull request #19067: tests: Add fuzzing harness for CNode (master...fuzzers-2020-05-25) https://github.com/bitcoin/bitcoin/pull/19067 08:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:12 -!- tarboss [54a0340e@gateway/web/cgi-irc/kiwiirc.com/ip.84.160.52.14] has joined #bitcoin-core-dev 08:15 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 272 seconds] 08:15 -!- tarboss [54a0340e@gateway/web/cgi-irc/kiwiirc.com/ip.84.160.52.14] has left #bitcoin-core-dev [] 08:16 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 08:18 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 08:21 -!- wotwot1 [~wotwot@84.39.116.180] has joined #bitcoin-core-dev 08:24 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 08:24 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds] 08:35 -!- shesek [~shesek@5.102.222.33] has joined #bitcoin-core-dev 08:35 -!- shesek [~shesek@5.102.222.33] has quit [Changing host] 08:35 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:49 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 08:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 08:54 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:55 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 09:10 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:20 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: Lost terminal] 09:20 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection] 09:20 -!- tarboss [~tarboss@p54a0340e.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:21 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 09:23 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:23 -!- vasild_ is now known as vasild 09:32 -!- Mariam [46351e76@otwaon237cw-lp130-01-70-53-30-118.dsl.bell.ca] has joined #bitcoin-core-dev 09:41 -!- tarboss [~tarboss@p54a0340e.dip0.t-ipconnect.de] has quit [] 09:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:45 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 10:11 -!- Mariam [46351e76@otwaon237cw-lp130-01-70-53-30-118.dsl.bell.ca] has quit [Remote host closed the connection] 10:18 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 10:19 -!- timothy [~tredaelli@redhat/timothy] has quit [Read error: Connection reset by peer] 10:20 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 10:21 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 10:39 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection] 10:39 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 10:40 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 10:40 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 10:46 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 10:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:53 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:54 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 10:54 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 10:59 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 11:00 -!- wotwot1 [~wotwot@84.39.116.180] has quit [] 11:02 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds] 11:07 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:10 -!- tarboss [~tarboss@p54a0340e.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:11 -!- tarboss [~tarboss@p54a0340e.dip0.t-ipconnect.de] has quit [Client Quit] 11:21 -!- nigel_c [~nigel_c@139.28.218.198] has joined #bitcoin-core-dev 11:27 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 11:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 11:31 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 11:36 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 11:51 -!- b10c [~b10c@2001:16b8:2ea3:1200:bd04:9e3b:eaf9:3abb] has joined #bitcoin-core-dev 11:54 -!- _joerodgers [4c7d53bf@c-76-125-83-191.hsd1.ar.comcast.net] has quit [Remote host closed the connection] 12:03 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 12:07 -!- _joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has joined #bitcoin-core-dev 12:08 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 265 seconds] 12:10 -!- _joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has quit [Quit: Leaving] 12:15 -!- _joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has joined #bitcoin-core-dev 12:15 -!- _joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has quit [Client Quit] 12:17 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has joined #bitcoin-core-dev 12:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:33 -!- farukterzioglu [5f004b8b@95.0.75.139] has joined #bitcoin-core-dev 12:36 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 12:39 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has quit [Quit: Leaving] 12:41 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 264 seconds] 12:45 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev 12:45 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 12:45 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 12:54 -!- b10c [~b10c@2001:16b8:2ea3:1200:bd04:9e3b:eaf9:3abb] has quit [Ping timeout: 260 seconds] 12:57 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has joined #bitcoin-core-dev 12:59 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 13:01 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 13:12 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 13:17 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 13:22 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 258 seconds] 13:23 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 13:28 -!- b10c [~b10c@2001:16b8:2ea3:1200:bd04:9e3b:eaf9:3abb] has joined #bitcoin-core-dev 13:30 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 13:30 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 13:31 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 13:33 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 13:33 -!- b10c [~b10c@2001:16b8:2ea3:1200:bd04:9e3b:eaf9:3abb] has quit [Quit: Leaving] 13:41 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 13:41 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 13:41 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 13:44 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 14:00 -!- nigel_c [~nigel_c@139.28.218.198] has quit [] 14:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 14:01 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 14:02 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Read error: Connection reset by peer] 14:05 -!- Squidicc [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 14:05 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer] 14:08 -!- kendzalo [~Thunderbi@92.241.156.49] has joined #bitcoin-core-dev 14:13 -!- jeremyrubin [~jr@67.180.60.249] has joined #bitcoin-core-dev 14:18 -!- jonatack [~jon@184.75.221.3] has quit [Ping timeout: 258 seconds] 14:20 -!- kers [~kers@104.254.90.243] has joined #bitcoin-core-dev 14:20 -!- jonatack [~jon@37.170.134.59] has joined #bitcoin-core-dev 14:23 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection] 14:23 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 14:25 -!- Squidicc [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds] 14:27 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 14:30 -!- shesek` [~shesek@185.3.145.28] has joined #bitcoin-core-dev 14:37 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 14:38 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 15:00 -!- shesek` [~shesek@185.3.145.28] has left #bitcoin-core-dev [] 15:01 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 15:02 -!- farukterzioglu [5f004b8b@95.0.75.139] has quit [Ping timeout: 245 seconds] 15:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 15:05 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 15:09 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:13 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 15:13 -!- kendzalo [~Thunderbi@92.241.156.49] has quit [Ping timeout: 272 seconds] 15:26 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: Connection reset by peer] 15:28 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 15:29 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Quit: Leaving] 15:44 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 258 seconds] 15:45 < fanquake> Anyone have anything rc2 related to report? 15:45 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 16:07 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 244 seconds] 16:07 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Ping timeout: 246 seconds] 16:07 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 16:09 -!- stevenroose [~steven@irc.roose.io] has quit [Quit: ZNC 1.7.4 - https://znc.in] 16:11 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 16:11 -!- stevenroose [~steven@irc.roose.io] has joined #bitcoin-core-dev 16:18 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 16:22 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 272 seconds] 16:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 16:39 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:53 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 16:57 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 16:58 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 16:59 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 256 seconds] 17:00 -!- kers [~kers@104.254.90.243] has quit [] 17:13 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving] 17:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:13 -!- jeremyrubin [~jr@67.180.60.249] has quit [Ping timeout: 258 seconds] 17:14 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 17:18 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds] 17:21 -!- zpao [~zpao@195.206.169.238] has joined #bitcoin-core-dev 17:22 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 17:25 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 17:29 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 17:35 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:38 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 17:40 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 17:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:55 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24f70290642c...14f844777746 17:55 < bitcoin-git> bitcoin/master 69bfcac fanquake: gui: update Qt base translations for macOS release 17:55 < bitcoin-git> bitcoin/master 14f8447 fanquake: Merge #19059: gui: update Qt base translations for macOS release 17:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:56 < bitcoin-git> [bitcoin] fanquake merged pull request #19059: gui: update Qt base translations for macOS release (master...macdeploy_translations) https://github.com/bitcoin/bitcoin/pull/19059 17:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:01 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 18:27 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 18:29 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 18:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:38 -!- hex17or [~hex17or@HSI-KBW-46-223-238-38.hsi.kabel-badenwuerttemberg.de] has quit [Ping timeout: 272 seconds] 18:39 -!- hex17or [~hex17or@HSI-KBW-46-223-238-38.hsi.kabel-badenwuerttemberg.de] has joined #bitcoin-core-dev 18:48 -!- ensign [~ensign@integer.musalbas.com] has quit [Quit: ZNC - http://znc.in] 18:49 -!- ensign_ [~ensign@integer.musalbas.com] has joined #bitcoin-core-dev 19:08 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 19:13 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 19:48 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 19:49 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 20:00 -!- zpao [~zpao@195.206.169.238] has quit [] 20:01 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has quit [Quit: Leaving] 20:07 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 20:12 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 20:13 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-rqvyjjlwqqisisoh] has quit [Quit: Connection closed for inactivity] 20:17 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds] 20:22 -!- efge [~efge@184.75.221.179] has joined #bitcoin-core-dev 20:38 < achow101> for sqlite wallet, what do people think about keeping the name "wallet.dat" for them? 20:38 < achow101> I'm inclined to say that that's a bad idea, but it does make things a lot easier 20:40 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 20:43 < fanquake> achow101: what are you thinking instead? 20:44 < achow101> fanquake: just keeping them named wallet.dat 20:44 < achow101> it's trivial to discover the file type by checking magic numbers 20:44 < achow101> my current implementation names them wallet.sqlite but that requires many checks in different places 20:46 < achow101> it works but there's probably some edge cases and gotchas that'll break something 20:47 -!- efge [~efge@184.75.221.179] has quit [Ping timeout: 265 seconds] 21:06 < tryphe> achow101, i think it's fine. it's unlikely they'll need to know the underlying format, and seems easier for when they backup (if the new file has a different name, they might get confused about support for old bdb backup compatability, which name their wallet should have, etc.) 21:18 < luke-jr> sqlite wallets don't need a directory, right? 21:18 < achow101> luke-jr: no, but keeping that for consistency 21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:22 < achow101> actually, we probably still need to keep it to prevent 2 bitcoinds from opening the same wallet file 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:23 -!- vasild_ is now known as vasild 21:27 < tryphe> ah, the bdb can be opened concurrently? i think bdb supports it but didn't know bitcoind would let you 21:28 < achow101> bitcoind doesn't let you 21:28 < tryphe> ahh 21:28 < achow101> we have our own directory lock thing to stop that 21:31 -!- lugosi1 [~lugosi@141.98.102.243] has joined #bitcoin-core-dev 21:31 < tryphe> what about multiple daemons running with -wallet=/home/user/wallet.dat? 21:31 < achow101> they shouldn't start 21:31 < tryphe> not that most people would try that... 21:57 -!- ppisati [~ppisati@net-37-116-44-224.cust.vodafonedsl.it] has quit [Remote host closed the connection] 22:04 -!- ppisati [~ppisati@net-188-216-88-162.cust.vodafonedsl.it] has joined #bitcoin-core-dev 22:05 < luke-jr> achow101: file locks should work fine? 22:06 < achow101> luke-jr: file locks? 22:06 < achow101> not sure how to detect if a file is opened by another process 22:06 < luke-jr> flock 22:08 < achow101> hmm 22:08 < luke-jr> not even sure how one would lock a directory O.o 22:08 < achow101> we make a .walletlock file and check it's existence before doing anything in that directory 22:08 < achow101> same thing happens for a datadir 22:45 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 22:54 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 22:57 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 23:00 -!- lugosi1 [~lugosi@141.98.102.243] has quit [] 23:10 < gwillen> I think portable file locking is a giant nightmare, probably lockfiles are still the way to go in 2020, sadly 23:11 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 23:21 -!- hwangjy9 [~hwangjy9@195.206.169.238] has joined #bitcoin-core-dev 23:27 -!- yancy [~root@2400:8902::f03c:92ff:fe70:a5ac] has quit [Ping timeout: 246 seconds] 23:27 -!- yancy [~root@2400:8902::f03c:92ff:fe70:a5ac] has joined #bitcoin-core-dev 23:31 -!- noganoo [uid146237@gateway/web/irccloud.com/x-mgqvzpwucgpatvmu] has joined #bitcoin-core-dev 23:38 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 23:39 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 23:40 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:40 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 23:41 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev --- Log closed Tue May 26 00:00:31 2020