--- Log opened Fri May 29 00:00:36 2020
00:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:00 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #12833: [qt] move QSettings to bitcoin_rw.conf where possible (master...2018/03/bitcoin-conf-rw) https://github.com/bitcoin/bitcoin/pull/12833
00:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:17 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:22 < jonasschnelli> promag_: #15202 could use a rebase
00:22 < gribble> https://github.com/bitcoin/bitcoin/issues/15202 | gui: Add Close All Wallets action by promag · Pull Request #15202 · bitcoin/bitcoin · GitHub
00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:24 < bitcoin-git> [bitcoin] rajarshimaitra closed pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:25 < bitcoin-git> [bitcoin] rajarshimaitra reopened pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
00:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:29 < jonasschnelli> ryanofsky: I guess #15935 could be taken out of draft
00:29 < gribble> https://github.com/bitcoin/bitcoin/issues/15935 | WIP: Add /settings.json persistent settings storage by ryanofsky · Pull Request #15935 · bitcoin/bitcoin · GitHub
00:30 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev
00:32 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:33 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #16876: gui: Drop calls to QCoreApplication::processEvents (master...2019-09-drop-processevents) https://github.com/bitcoin/bitcoin/pull/16876
00:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:41 -!- as_pnn [~pierreirc@119.192.247.147] has quit [Quit: killed]
00:44 -!- as_pnn [~pierreirc@119.192.247.147] has joined #bitcoin-core-dev
00:45 < jonasschnelli> MarcoFalke: can you ack/nack/comment on #17227 (contains [squashes]commits of yours)
00:45 < gribble> https://github.com/bitcoin/bitcoin/issues/17227 | Qt: Add Android packaging support by icota · Pull Request #17227 · bitcoin/bitcoin · GitHub
01:02 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Quit: Highway61]
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:03 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5f75c5e7df14...343169998193
01:03 < bitcoin-git> bitcoin/master 68288ef Hennadii Stepanov: qt: Overhaul ReceiveRequestDialog
01:03 < bitcoin-git> bitcoin/master 73529f0 Hennadii Stepanov: qt: Rename slot to updateDisplayUnit()
01:03 < bitcoin-git> bitcoin/master 3431699 Jonas Schnelli: Merge #17597: qt: Fix height of QR-less ReceiveRequestDialog
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:03 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:04 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:07 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
01:12 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
01:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:20 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/343169998193...c2c15ea54eb1
01:20 < bitcoin-git> bitcoin/master 1122817 Hennadii Stepanov: qt: Remove QFont warnings with QPA=minimal
01:20 < bitcoin-git> bitcoin/master c2c15ea Jonas Schnelli: Merge #17908: qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal
01:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:21 -!- kristapsk_ is now known as kristapsk
01:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:21 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #17908: qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal (master...20200111-qttest-minimal-warn) https://github.com/bitcoin/bitcoin/pull/17908
01:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:23 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2c15ea54eb1...a9024a42fcec
01:23 < bitcoin-git> bitcoin/master c4ea501 Emil Engler: qt: Hide non PKHash-Addresses in signing address book
01:23 < bitcoin-git> bitcoin/master a9024a4 Jonas Schnelli: Merge #17918: qt: Hide non PKHash-Addresses in signing address book
01:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:24 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #17918: qt: Hide non PKHash-Addresses in signing address book (master...2020-01-hide-non-pkhash-addresses) https://github.com/bitcoin/bitcoin/pull/17918
01:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:29 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9024a42fcec...0d5c18204b73
01:29 < bitcoin-git> bitcoin/master 2b18fd2 Kristaps Kaupe: Disable unavailable context menu items in transactions tab
01:29 < bitcoin-git> bitcoin/master 0d5c182 Jonas Schnelli: Merge #17956: gui: Disable unavailable context menu items in transactions ...
01:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:30 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #17956: gui: Disable unavailable context menu items in transactions tab (master...tx-menu-disable) https://github.com/bitcoin/bitcoin/pull/17956
01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:30 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d5c18204b73...beb3844c45c5
01:30 < bitcoin-git> bitcoin/master 4fc1df4 Hennadii Stepanov: qt: Track QEvent::Resize during animation
01:30 < bitcoin-git> bitcoin/master beb3844 Jonas Schnelli: Merge #17968: qt: Ensure that ModalOverlay is resized properly
01:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:31 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #17968: qt: Ensure that ModalOverlay is resized properly (master...20200120-fix-modaloverlay) https://github.com/bitcoin/bitcoin/pull/17968
01:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:32 -!- jarthur_ [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Remote host closed the connection]
01:54 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
01:55 -!- provoostenator_ [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
01:59 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
01:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Disconnected by services]
02:00 -!- Antonet [~Antonet@217.138.204.90] has quit []
02:00 -!- promag_ is now known as promag
02:00 < promag> jonasschnelli: +1
02:00 < jonasschnelli> spring cleaning... 
02:00 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
02:00 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:00 < promag> jonasschnelli: \o/
02:01 < promag> #17355 needs rebase
02:01 < gribble> https://github.com/bitcoin/bitcoin/issues/17355 | gui: grey out used address in address book by za-kk · Pull Request #17355 · bitcoin/bitcoin · GitHub
02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:01 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/beb3844c45c5...f4b603cff63a
02:01 < bitcoin-git> bitcoin/master 2f86720 furszy: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals.
02:01 < bitcoin-git> bitcoin/master a06e845 furszy: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTi...
02:01 < bitcoin-git> bitcoin/master f4b603c Jonas Schnelli: Merge #17993: gui: Balance/TxStatus polling update based on last block has...
02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:02 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #17993: gui: Balance/TxStatus polling update based on last block hash. (master...2020_avoid_unnecessary_lock_in_balance_polling) https://github.com/bitcoin/bitcoin/pull/17993
02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:06 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f4b603cff63a...de369c7ea577
02:06 < bitcoin-git> bitcoin/master cea91a1 Luke Dashjr: Bugfix: GUI: Use unsigned long long type to avoid implicit conversion of M...
02:06 < bitcoin-git> bitcoin/master c31bc5b Luke Dashjr: Consolidate service flag bit-to-name conversion to a shared serviceFlagToS...
02:06 < bitcoin-git> bitcoin/master de369c7 Jonas Schnelli: Merge #18165: Consolidate service flag bit-to-name conversion to a shared ...
02:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:07 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #18165: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function (master...svcflags2str) https://github.com/bitcoin/bitcoin/pull/18165
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:08 < bitcoin-git> [bitcoin] promag opened pull request #19104: gui, test: Fix Cannot queue arguments of type size_t (master...2020-05-register-metatypes) https://github.com/bitcoin/bitcoin/pull/19104
02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:09 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/de369c7ea577...d7f5e01e3093
02:09 < bitcoin-git> bitcoin/master 8e08d00 Hennadii Stepanov: qt: Use parent-child relation to manage lifetime of OptionsModel object
02:09 < bitcoin-git> bitcoin/master d7f5e01 Jonas Schnelli: Merge #18424: qt: Use parent-child relation to manage lifetime of OptionsM...
02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:10 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #18424: qt: Use parent-child relation to manage lifetime of OptionsModel object (master...20200324-options-model) https://github.com/bitcoin/bitcoin/pull/18424
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:14 -!- |Kin| [~|Kin|@217.138.204.90] has joined #bitcoin-core-dev
02:14 < hebasto> jonasschnelli: mind looking into ##17127 which is alternative to #13389 ?
02:14 < gribble> https://github.com/bitcoin/bitcoin/issues/17127 | util: Correct permissions for datadir and wallets subdir by hebasto · Pull Request #17127 · bitcoin/bitcoin · GitHub
02:15 < gribble> https://github.com/bitcoin/bitcoin/issues/13389 | Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() by n2yen · Pull Request #13389 · bitcoin/bitcoin · GitHub
02:17 < jonasschnelli> hebasto: thanks for pointing that to me. Since this is not GUI only,... it needs more review before we can merge this.
02:17 < hebasto> jonasschnelli: sure
02:18 < jonasschnelli> hebasto, promag: maybe interested to fix #19103?
02:18 < gribble> https://github.com/bitcoin/bitcoin/issues/19103 | QRCode address in image is not readable · Issue #19103 · bitcoin/bitcoin · GitHub
02:18 < jonasschnelli> Make sure it respects HiDPI
02:18 < promag> I was going to see if changing font fixes it
02:19 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
02:19 < hebasto> jonasschnelli: not sure if I could test on my equipment
02:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]
02:31 -!- provoostenator_ [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
02:31 < jonasschnelli> hebasto: good point. I wonder if the issue is also present on HiDPI ubuntu
02:32 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
02:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
02:43 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
02:44 < promag> jonasschnelli: I can test that
02:45 < promag> I'm getting
02:45 < promag> CoreText note: Client requested name ".SFNSMono-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
02:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:03 -!- Jany7Nader [~Jany7Nade@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:10 -!- Jany7Nader [~Jany7Nade@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
03:15 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
03:16 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
03:16 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:18 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
03:18 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
03:19 -!- thunderbiscuit[m [thunderbis@gateway/shell/matrix.org/x-kotuhurevbosmyzz] has left #bitcoin-core-dev []
03:21 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 258 seconds]
03:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:24 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d7f5e01e3093...73407ff65cef
03:24 < bitcoin-git> bitcoin/master fa5894f Anthony Towns: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known
03:24 < bitcoin-git> bitcoin/master 96954d1 Anthony Towns: DNS seeds: don't query DNS while network is inactive
03:24 < bitcoin-git> bitcoin/master 73407ff fanquake: Merge #16939: p2p: Delay querying DNS seeds
03:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:26 < bitcoin-git> [bitcoin] fanquake merged pull request #16939: p2p: Delay querying DNS seeds (master...201909-avoid-dns-if-addrman-populated) https://github.com/bitcoin/bitcoin/pull/16939
03:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:31 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: No Ping reply in 180 seconds.]
03:33 -!- jarthur [~jarthur@2605:6000:1019:4971:5c3e:70ab:3ef0:551c] has joined #bitcoin-core-dev
03:34 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
03:35 -!- timothy [~tredaelli@host126-159-dynamic.2-87-r.retail.telecomitalia.it] has joined #bitcoin-core-dev
03:36 -!- timothy [~tredaelli@host126-159-dynamic.2-87-r.retail.telecomitalia.it] has quit [Changing host]
03:36 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
03:36 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit]
03:37 -!- jarthur [~jarthur@2605:6000:1019:4971:5c3e:70ab:3ef0:551c] has quit [Ping timeout: 260 seconds]
03:38 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Quit: Leaving]
03:53 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving]
04:08 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
04:23 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
04:31 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
04:31 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
04:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
04:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
04:41 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:58 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #17355: gui: grey out used address in address book (master...oct-19-17174) https://github.com/bitcoin/bitcoin/pull/17355
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:58 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17355: gui: grey out used address in address book (master...oct-19-17174) https://github.com/bitcoin/bitcoin/pull/17355
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:00 -!- |Kin| [~|Kin|@217.138.204.90] has quit []
05:06 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has joined #bitcoin-core-dev
05:06 < bitcoin-git> [bitcoin] fjahr opened pull request #19105: Add Muhash3072 implementation in Python (master...csi-2-muhash-py) https://github.com/bitcoin/bitcoin/pull/19105
05:06 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has left #bitcoin-core-dev []
05:15 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
05:18 -!- boily [~boily@139.28.218.198] has joined #bitcoin-core-dev
05:35 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
05:36 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:42 < bitcoin-git> [bitcoin] jonasschnelli reopened pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
05:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:43 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/73407ff65cef...f2e2c5ebcccf
05:43 < bitcoin-git> bitcoin/master 9760293 Ben Carman: wallet: Fix for exported confirmation field in payment to self transactions
05:43 < bitcoin-git> bitcoin/master f2e2c5e Jonas Schnelli: Merge #14988: wallet: Fix for confirmed column in csv export for payment t...
05:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:44 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:46 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
06:30 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 264 seconds]
06:37 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has joined #bitcoin-core-dev
06:42 -!- igr [56ad4dc7@host86-173-77-199.range86-173.btcentralplus.com] has joined #bitcoin-core-dev
06:48 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f2e2c5ebcccf...e4bfd51acc11
06:50 < bitcoin-git> bitcoin/master da73f15 Hennadii Stepanov: qt: Fix shutdown when waitfor* cmds are called from RPC console
06:50 < bitcoin-git> bitcoin/master e4bfd51 Jonas Schnelli: Merge #18452: qt: Fix shutdown when waitfor* cmds are called from RPC cons...
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #18452: qt: Fix shutdown when waitfor* cmds are called from RPC console (master...20200327-waitfor) https://github.com/bitcoin/bitcoin/pull/18452
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:52 -!- waxwing_ [~waxwing@193.29.57.116] has left #bitcoin-core-dev []
06:53 -!- waxwing [~waxwing@unaffiliated/waxwing] has joined #bitcoin-core-dev
06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:57 < bitcoin-git> [bitcoin] vasild opened pull request #19106: util: simplify the interface of serviceFlagToStr() (master...serviceFlagToStr) https://github.com/bitcoin/bitcoin/pull/19106
06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:00 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
07:01 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
07:04 < instagibbs> oh hey I can restart travis jobs again
07:12 -!- igr [56ad4dc7@host86-173-77-199.range86-173.btcentralplus.com] has quit [Remote host closed the connection]
07:27 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
07:27 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev
07:30 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:30 -!- kexkey [~kexkey@37.120.205.235] has joined #bitcoin-core-dev
07:33 -!- jarthur [~jarthur@2605:6000:1019:4971:5c3e:70ab:3ef0:551c] has joined #bitcoin-core-dev
07:37 -!- jarthur [~jarthur@2605:6000:1019:4971:5c3e:70ab:3ef0:551c] has quit [Ping timeout: 260 seconds]
07:39 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
07:39 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
07:44 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 258 seconds]
07:55 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat]
08:00 -!- boily [~boily@139.28.218.198] has quit []
08:02 -!- kljasdfvv [~flack@p200300d46f079c00450a6a91a9b10a2b.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
08:16 -!- maop [~maop@185.204.1.185] has joined #bitcoin-core-dev
08:18 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
08:18 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
08:21 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
08:21 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Client Quit]
08:25 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
08:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4bfd51acc11...c19fd96694d1
08:29 < bitcoin-git> bitcoin/master fa2ca0c MarcoFalke: test: Fix intermittent failure in feature_dbcrash
08:29 < bitcoin-git> bitcoin/master c19fd96 MarcoFalke: Merge #19022: test: Fix intermittent failure in feature_dbcrash
08:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19022: test: Fix intermittent failure in feature_dbcrash (master...2005-testFixIntermittentFailDbCrash) https://github.com/bitcoin/bitcoin/pull/19022
08:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:32 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
08:36 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
08:41 -!- owowo [~ovovo@193.32.127.160] has joined #bitcoin-core-dev
08:41 -!- owowo [~ovovo@193.32.127.160] has quit [Changing host]
08:41 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:46 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:54 < bitcoin-git> [bitcoin] troygiorshev opened pull request #19107: p2p: Refactor, move all header verification into the network layer, without changing behavior (master...p2p-refactor-header) https://github.com/bitcoin/bitcoin/pull/19107
08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:56 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 272 seconds]
08:58 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev
09:05 -!- MarcoFalke [~none@198.12.116.246] has quit [Ping timeout: 256 seconds]
09:08 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
09:09 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
09:15 -!- Guest7387 [cf26ed2d@gateway/web/cgi-irc/kiwiirc.com/ip.207.38.237.45] has joined #bitcoin-core-dev
09:16 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
09:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
09:24 -!- vasild_ is now known as vasild
09:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
09:28 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
09:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
09:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:44 -!- Elsie85Block [~Elsie85Bl@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
09:48 -!- Elsie85Block [~Elsie85Bl@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds]
09:52 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
09:54 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
09:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
09:54 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
09:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
09:55 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds]
09:55 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
09:59 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
10:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
10:05 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
10:05 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
10:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
10:09 -!- drizztbsd is now known as timothy
10:12 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 258 seconds]
10:21 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
10:22 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
10:24 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds]
10:32 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:32 < bitcoin-git> [bitcoin] hebasto opened pull request #19108: qt, refactor: Drop unneeded Q_DECLARE_METATYPE (master...200529-metatype) https://github.com/bitcoin/bitcoin/pull/19108
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:36 -!- jarthur [~jarthur@2605:6000:1019:4971:991d:d19:9c32:9231] has joined #bitcoin-core-dev
10:39 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
10:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:43 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c19fd96694d1...8ad5f1c376fe
10:43 < bitcoin-git> bitcoin/master fbacad1 Vasil Dimov: util: simplify the interface of serviceFlagToStr()
10:43 < bitcoin-git> bitcoin/master 189ae0c Vasil Dimov: util: dedup code in callers of serviceFlagToStr()
10:43 < bitcoin-git> bitcoin/master 8ad5f1c Jonas Schnelli: Merge #19106: util: simplify the interface of serviceFlagToStr()
10:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:43 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #19106: util: simplify the interface of serviceFlagToStr() (master...serviceFlagToStr) https://github.com/bitcoin/bitcoin/pull/19106
10:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:53 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: Lost terminal]
10:54 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
11:00 -!- maop [~maop@185.204.1.185] has quit []
11:01 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
11:18 -!- Windurr [~Windurr@178.162.204.238] has joined #bitcoin-core-dev
11:18 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 272 seconds]
11:24 -!- ryzeb [~ryzeb@c-73-83-51-196.hsd1.wa.comcast.net] has quit []
11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8ad5f1c376fe...cb88de3e3d37
11:25 < bitcoin-git> bitcoin/master 357f02b glowang: Create a local class inherited from BasicTestingSetup with a localized arg...
11:25 < bitcoin-git> bitcoin/master f871f15 glowang: scripted-diff: replace gArgs with argsman
11:25 < bitcoin-git> bitcoin/master cb88de3 MarcoFalke: Merge #18926: test: Pass ArgsManager into getarg_tests
11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:25 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18926: test: Pass ArgsManager into getarg_tests (master...replace_global_gArgs_with_local_argsman) https://github.com/bitcoin/bitcoin/pull/18926
11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:27 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Quit: lehnberg]
11:32 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
11:33 -!- kristapsk_ is now known as kristapsk
11:34 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev
11:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.7.1]
11:38 -!- troygiorshev [~troygiors@72.139.204.106] has joined #bitcoin-core-dev
11:38 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Ping timeout: 256 seconds]
11:39 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev
11:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
11:42 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev
11:52 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Quit: lehnberg]
11:54 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
11:55 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev
11:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
11:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:01 < bitcoin-git> [bitcoin] sipa opened pull request #19109: Only allow getdata of recently announced invs (master...202005_bloom_relay) https://github.com/bitcoin/bitcoin/pull/19109
12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:04 -!- tylerdmace [~tyler@136.36.154.185] has quit [Ping timeout: 265 seconds]
12:05 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Quit: lehnberg]
12:06 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
12:07 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
12:07 < vasild> Assertion failed: detected inconsistent lock order at /home/vd/gh/bitcoin/bitcoin/src/sync.cpp:128, details in debug log.
12:07 < vasild> Abort trap (core dumped)
12:07 < vasild> hmm
12:07 -!- troygiorshev [~troygiors@72.139.204.106] has quit [Ping timeout: 246 seconds]
12:07 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev
12:09 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
12:10 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Client Quit]
12:10 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
12:11 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
12:11 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Client Quit]
12:11 -!- tylerdmace [~tyler@136.36.154.185] has joined #bitcoin-core-dev
12:15 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Quit: lehnberg]
12:15 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
12:15 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
12:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
12:18 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev
12:19 -!- kristapsk_ is now known as kristapsk
12:25 < dongcarl> Hey jonasschnelli, I wanted to confirm my overall understanding of the topology of the open PRs related to BIP324. Here?s my understanding:
12:25 < dongcarl> - #14032 is an old PR that has many of its changes already merged, is superseded by jonasschnelli:2019/08/net_v2, and could potentially be closed. Question here: is there anything there that isn?t in jonasschnelli:2019/08/net_v2?
12:25 < dongcarl> - #18242 -> #14032 seems to be the main line of progression
12:25 < dongcarl> - #15197 + #15206 seem to be additional improvements that 1. Can be merged independently of the main line of progression, 2. Can help/simplify the implementation of BIP324. Question here: Could you give concrete examples as to how they help/simplify the implementation?
12:25 < gribble> https://github.com/bitcoin/bitcoin/issues/14032 | Add p2p layer encryption with ECDH/ChaCha20Poly1305 by jonasschnelli · Pull Request #14032 · bitcoin/bitcoin · GitHub
12:25 < gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
12:25 < gribble> https://github.com/bitcoin/bitcoin/issues/14032 | Add p2p layer encryption with ECDH/ChaCha20Poly1305 by jonasschnelli · Pull Request #14032 · bitcoin/bitcoin · GitHub
12:25 < gribble> https://github.com/bitcoin/bitcoin/issues/15197 | Refactor and slightly stricter p2p message processing by jonasschnelli · Pull Request #15197 · bitcoin/bitcoin · GitHub
12:25 < gribble> https://github.com/bitcoin/bitcoin/issues/15206 | Immediately disconnect on invalid net message checksum by jonasschnelli · Pull Request #15206 · bitcoin/bitcoin · GitHub
12:26 < dongcarl> Sorry, some of my apostrophes got converted to question marks. *shakes fist at Synergy*
12:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:33 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19110: test: Explain that a bug should be filed when the tests fail (master...2005-testBug) https://github.com/bitcoin/bitcoin/pull/19110
12:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:37 -!- Guest7387 [cf26ed2d@gateway/web/cgi-irc/kiwiirc.com/ip.207.38.237.45] has quit [Quit: Connection closed]
12:45 < jonasschnelli> dongcarl: 14032 was an overview/concept. The only relevant PR now is 18242
12:46 < jonasschnelli> 15206/15197 are now BIP324 irrelevant
12:47 < jonasschnelli> So as for BIP342, just focus on #18242
12:47 < gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
12:47 < jonasschnelli> The rest are just relicts that might be a refactor/improvement on its own.
12:48 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Quit: lehnberg]
12:48 < jonasschnelli> Once 18242 is merged,... I would like to "complete" it with the ECDH handshake (another mid size PR).
12:50 < jonasschnelli> After that,... i could be enabled behind an experimental off-by-default runtime argument
12:51 < dongcarl> jonasschnelli: I see, so after #18242, we need #14049, and then BIP324 handshake + BIP324 ECDH calc + BIP324 HKDF key deriv (last few commits from 2019/08/net_v2)?
12:51 < gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
12:51 < gribble> https://github.com/bitcoin/bitcoin/issues/14049 | Enable libsecp256k1 ecdh module, add ECDH function to CKey by jonasschnelli · Pull Request #14049 · bitcoin/bitcoin · GitHub
12:52 < jonasschnelli> Yeah. It needs 14049 with some actual handshake implementation. My remote branch you may look at could be outdated and if recent, it may only be the concept.
12:53 < dongcarl> Sounds good, I think we're on the same page
12:53 < jonasschnelli> HKDF is already implemented,... but not the actually symmetric key derivation from the ecdh_secret
12:53 < jonasschnelli> But...
12:53 < jonasschnelli> (there is always a but)
12:53 < dongcarl> haha
12:54 < jonasschnelli> BIP342 is still in discussion.
12:54 < jonasschnelli> Questions came up about the missing MAC of the encrypted length field
12:54 < jonasschnelli> https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52#gistcomment-3295536
12:54 < jonasschnelli> (sipa eventually likes to take a deeper look)
12:55 < jonasschnelli> I think it is fine since we use a different encryption context for it.
12:55 < jonasschnelli> then... secondly, there are discussions about possible handshake upgrades with downgrade protection (which are currently not directly supported by the bip).
12:56 < jonasschnelli> Thats the main reason why the BIP is still not submitted
12:56 < jonasschnelli> (as well as the fact that the implementation often reveals conceptual issues)
12:57 < jonasschnelli> despite the – eventually –  altering BIP324, I think we can finalise the implementation and hide it behind an experimental runtime parameter.
12:58 < jonasschnelli> (which will still allow changing it without users getting mad)
12:58 < dongcarl> I see I see, I didn't see that discussion in the gist before, will take a closer look there.
12:59 < dongcarl> any links to the discussions about downgrade protection?
13:00 < jonasschnelli> I guess it is email only,... mainly real_or_random and sipa
13:00 < sipa> i need to respond :)
13:00 < jonasschnelli> We hoped for a coredev meeting to tackle it.
13:00 < jonasschnelli> sipa: no hurry.
13:00 < sipa> we've been talking to boneh about our authentication scheme as well
13:00 < sipa> (a week or two ago)
13:01 < jonasschnelli> the blind auth scheme?
13:01 < sipa> yeah
13:01 < jonasschnelli> okay... thats next step of next step. :)
13:01 < jonasschnelli> sipa: do you think it could have implications for v2/BIP342?
13:02 < jonasschnelli> or would it be more "on the top"?
13:02 < sipa> it's why we think we need an upgrade mechanism in BIP342
13:02 < sipa> so that the authentication can be done as part of the handshake, rather than as a application level thing later on
13:02 < jonasschnelli> ah.. i see
13:03 < sipa> but i think the upgrade mechanism can be very simple; just the connecting party sending a "i'm done; here is my hash of the session key"
13:03 < jonasschnelli> Yeah. Would be great to have a place/time to discuss the upgrade mechanism
13:03 < sipa> and the other side responding "ok, here is my hash"
13:04 < dongcarl> is the blind auth scheme you guys are talking about just the new version of the single-party countersign?
13:04 < sipa> anything else would be left unspecified, and close the connection
13:04 < sipa> dongcarl: yes
13:06 < jonasschnelli> I'll take it up soon (the upgrade mechanism) and will bother sipa and real_or_random with a concrete BIP change
13:08 < dongcarl> 👍
13:16 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev
13:16 -!- shesek [~shesek@185.3.145.28] has quit [Changing host]
13:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:17 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
13:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]
13:25 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
13:33 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 258 seconds]
13:34 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
13:34 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
13:34 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
13:35 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
13:38 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 240 seconds]
13:47 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
14:00 -!- Windurr [~Windurr@178.162.204.238] has quit []
14:17 -!- ghghjghjghjghjgh [0250c854@bl19-200-84.dsl.telepac.pt] has joined #bitcoin-core-dev
14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:26 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19111: Limit scope of all global std::once_flag (master...2005-NoGlobalOnce) https://github.com/bitcoin/bitcoin/pull/19111
14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:32 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
14:32 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
14:37 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 256 seconds]
14:45 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has quit [Ping timeout: 272 seconds]
14:49 -!- PeErLesS [~PeErLesS@84.39.116.180] has joined #bitcoin-core-dev
14:50 -!- ghghjghjghjghjgh [0250c854@bl19-200-84.dsl.telepac.pt] has quit [Remote host closed the connection]
15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:06 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19112: rpc: Remove special case for unknown service flags (master...2005-rpcServiceFlagsUnknown) https://github.com/bitcoin/bitcoin/pull/19112
15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:12 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:16 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 240 seconds]
15:17 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:18 < ariard> jonasschnelli: fyi will host a Review Club session on seralizer/deserializer commits of #18242 in 2 weeks
15:19 < gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
15:19 < ariard> will dig into the rational of MACIng the encrypted length field or not for the occasion
15:33 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
15:34 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:34 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:38 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
15:38 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 246 seconds]
15:44 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 264 seconds]
15:57 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:58 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:58 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
16:02 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 246 seconds]
16:10 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
16:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds]
16:23 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving]
16:23 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
16:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:36 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
16:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:40 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 240 seconds]
16:42 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
16:47 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
16:57 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:00 -!- PeErLesS [~PeErLesS@84.39.116.180] has quit []
17:00 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
17:01 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 272 seconds]
17:09 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 258 seconds]
17:10 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 272 seconds]
17:12 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Remote host closed the connection]
17:15 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
17:16 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
17:17 -!- vancoder [~vancoder@178.162.204.238] has joined #bitcoin-core-dev
17:21 -!- jarthur [~jarthur@2605:6000:1019:4971:991d:d19:9c32:9231] has quit []
17:33 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has joined #bitcoin-core-dev
17:34 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:42 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:42 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:42 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
17:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
17:54 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
18:33 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
18:44 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
18:46 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
18:48 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
18:54 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has quit [Remote host closed the connection]
18:57 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
19:08 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has joined #bitcoin-core-dev
19:25 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:28 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:42 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:44 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 256 seconds]
19:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
20:00 -!- vancoder [~vancoder@178.162.204.238] has quit []
20:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:15 < bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/cb88de3e3d37...98ebe7896dab
20:15 < bitcoin-git> bitcoin/master 3d6603e Carl Dong: depends: Propagate well-known vars into depends
20:15 < bitcoin-git> bitcoin/master 2d4e480 Carl Dong: depends: boost: Specify toolset to bootstrap.sh
20:16 < bitcoin-git> bitcoin/master 1ce74bc Carl Dong: depends: boost: Split target-os from toolset
20:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:16 < bitcoin-git> [bitcoin] fanquake merged pull request #18820: build: Propagate well-known vars into depends (master...2020-04-improve-depends-hosts2) https://github.com/bitcoin/bitcoin/pull/18820
20:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:20 -!- kermit1 [~kermit@185.204.1.185] has joined #bitcoin-core-dev
20:28 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
20:35 -!- Highway61 [~Thunderbi@209.95.56.142] has joined #bitcoin-core-dev
21:00 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
21:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
21:11 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has quit [Read error: Connection reset by peer]
21:11 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has joined #bitcoin-core-dev
21:16 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has quit [Ping timeout: 260 seconds]
21:18 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
21:19 -!- Highway61 [~Thunderbi@209.95.56.142] has quit [Ping timeout: 260 seconds]
21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
21:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
21:24 -!- vasild_ is now known as vasild
21:38 -!- yojoots [~justin@2600:1700:19e0:4b10:d84a:bd97:7a44:67ab] has quit [Ping timeout: 260 seconds]
21:39 -!- yojoots [~justin@2600:1700:19e0:4b10:8c9:5a78:b065:b884] has joined #bitcoin-core-dev
21:41 -!- yojoots [~justin@2600:1700:19e0:4b10:8c9:5a78:b065:b884] has quit [Remote host closed the connection]
22:07 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has joined #bitcoin-core-dev
22:39 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has quit [Remote host closed the connection]
22:39 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has joined #bitcoin-core-dev
22:45 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has quit [Ping timeout: 260 seconds]
22:45 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
22:50 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 265 seconds]
23:00 -!- kermit1 [~kermit@185.204.1.185] has quit []
23:07 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
23:10 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
23:11 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
23:12 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer]
23:13 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
23:15 -!- jarthur [~jarthur@2605:6000:1019:4971:61ec:9f97:de20:1bea] has joined #bitcoin-core-dev
23:21 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev
23:21 -!- I440r [~I440r@185.189.114.11] has joined #bitcoin-core-dev
23:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:46 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
23:46 -!- berndj [~berndj@azna.co.za] has quit [Quit: ZNC - http://znc.in]
23:47 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev
23:48 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
23:48 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
23:55 < jonasschnelli> ariard: thanks for informing me! Will try to take part.
23:58 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
--- Log closed Sat May 30 00:00:37 2020