--- Log opened Sun Jun 07 00:00:43 2020 00:29 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 00:35 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 00:51 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer] 01:17 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 01:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 01:23 -!- ccook_ [sid271969@gateway/web/irccloud.com/x-qmdioqhwnlwdkkmw] has joined #bitcoin-core-dev 01:23 -!- ccook [sid271969@gateway/web/irccloud.com/x-uvczjjbgkbnptyoy] has quit [Ping timeout: 256 seconds] 01:23 -!- ccook_ is now known as ccook 01:25 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 01:25 -!- marcinja [~marcinja@2604:a880:400:d1::89a:e001] has quit [Ping timeout: 256 seconds] 01:25 -!- marcinja [~marcinja@2604:a880:400:d1::89a:e001] has joined #bitcoin-core-dev 01:35 -!- Netsplit *.net <-> *.split quits: sanket1729, pinheadmz, cncr04s 01:36 -!- Netsplit over, joins: pinheadmz 01:36 -!- Netsplit over, joins: cncr04s, sanket1729 01:48 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds] 02:00 -!- jaekwon [~jaekwon@185.204.1.185] has quit [] 02:03 -!- Kiminuo [~mix@141.98.103.196] has quit [Ping timeout: 272 seconds] 02:22 -!- nickr [~nickr@84.39.116.180] has joined #bitcoin-core-dev 02:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:34 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 02:37 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 260 seconds] 02:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:57 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 03:02 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 03:03 -!- Myra34Moore [~Myra34Moo@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:03 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 03:08 -!- Myra34Moore [~Myra34Moo@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds] 03:27 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 03:28 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 03:31 -!- jarthur [~jarthur@2605:6000:1019:4971:2d03:6ee8:5c6:c7a7] has quit [] 03:38 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat] 03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b1b173994406...1b90a7b61a37 03:43 < bitcoin-git> bitcoin/master 501e6ab Calvin Kim: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call 03:43 < bitcoin-git> bitcoin/master 1b90a7b MarcoFalke: Merge #19005: doc: Add documentation for 'checklevel' argument in 'verifyc... 03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC… (master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005 03:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:21 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 04:26 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 04:28 -!- Highway61 [~Thunderbi@104.223.94.122] has joined #bitcoin-core-dev 04:43 -!- pretyflaco [~k3m@2001:a61:4e3:7701:8872:e4e1:6370:d4ed] has joined #bitcoin-core-dev 04:44 -!- pretyflaco1 [~k3m@185.213.155.164] has joined #bitcoin-core-dev 04:45 -!- pretyflaco [~k3m@2001:a61:4e3:7701:8872:e4e1:6370:d4ed] has quit [Disconnected by services] 04:54 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 04:56 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Client Quit] 04:58 -!- Kiminuo [~mix@141.98.103.196] has joined #bitcoin-core-dev 05:00 -!- nickr [~nickr@84.39.116.180] has quit [] 05:01 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 05:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 05:17 -!- pretyflaco1 is now known as pretyflaco 05:21 -!- ski1 [~ski@139.28.218.198] has joined #bitcoin-core-dev 05:30 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 05:40 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 05:48 -!- pretyflaco [~k3m@185.213.155.164] has quit [Quit: Leaving.] 05:50 -!- pretyflaco [~k3m@185.213.155.164] has joined #bitcoin-core-dev 06:03 -!- pretyflaco [~k3m@185.213.155.164] has quit [Quit: Leaving.] 06:07 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev 06:41 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:44 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19198: test: Check that peers with forcerelay permission are not asked to feefilter (master...2006-testForcerelayFeefilter) https://github.com/bitcoin/bitcoin/pull/19198 06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:05 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 07:08 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 07:09 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 07:09 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 272 seconds] 07:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:09 < bitcoin-git> [bitcoin] jonatack opened pull request #19200: rpc: remove deprecated getaddressinfo fields (master...remove-deprecated-getaddressinfo-fields) https://github.com/bitcoin/bitcoin/pull/19200 07:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:10 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 07:16 -!- looping747 [588a2a14@20.42.138.88.rev.sfr.net] has joined #bitcoin-core-dev 07:17 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:19 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 07:23 -!- looping747 [588a2a14@20.42.138.88.rev.sfr.net] has quit [Remote host closed the connection] 07:24 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:26 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:30 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:32 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19201: ci: Switch to bitcoincore.org download (master...2006-ci404) https://github.com/bitcoin/bitcoin/pull/19201 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:34 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:37 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 07:42 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1b90a7b61a37...43695b0cf851 07:42 < bitcoin-git> bitcoin/master fa4cd1f MarcoFalke: ci: Switch to bitcoincore.org download 07:42 < bitcoin-git> bitcoin/master 43695b0 MarcoFalke: Merge #19201: ci: Switch to bitcoincore.org download 07:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:43 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19201: ci: Switch to bitcoincore.org download (master...2006-ci404) https://github.com/bitcoin/bitcoin/pull/19201 07:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:51 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 07:52 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:52 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 240 seconds] 08:00 -!- ski1 [~ski@139.28.218.198] has quit [] 08:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:18 -!- someone235 [uid419897@gateway/web/irccloud.com/x-rswzpvieqxeaqqbx] has quit [Quit: Connection closed for inactivity] 08:21 -!- k0da [~k0da@195.206.183.79] has joined #bitcoin-core-dev 08:26 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection] 08:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:32 < bitcoin-git> [bitcoin] jonatack opened pull request #19202: log: remove deprecated `db` log category (master...remove-deprecated-db-log-category) https://github.com/bitcoin/bitcoin/pull/19202 08:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:33 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 08:54 -!- Kad34 [62b479ae@ip98-180-121-174.ga.at.cox.net] has joined #bitcoin-core-dev 08:55 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 08:56 -!- Kad34 [62b479ae@ip98-180-121-174.ga.at.cox.net] has quit [Remote host closed the connection] 09:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:12 -!- XORder [d13a8161@209.58.129.97] has joined #bitcoin-core-dev 09:16 -!- davterra [~dulyNoded@104.140.18.131] has quit [Ping timeout: 272 seconds] 09:17 -!- Luke [~Luke@bitnomial/staff/luke] has joined #bitcoin-core-dev 09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:23 -!- vasild_ is now known as vasild 09:32 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/43695b0cf851...b3091b2be7d1 09:32 < bitcoin-git> bitcoin/master 4c0c893 Jon Atack: log: remove deprecated `db` log category 09:32 < bitcoin-git> bitcoin/master c514a4f Jon Atack: doc: release note for `db` log category removal 09:32 < bitcoin-git> bitcoin/master b3091b2 MarcoFalke: Merge #19202: log: remove deprecated `db` log category 09:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19202: log: remove deprecated `db` log category (master...remove-deprecated-db-log-category) https://github.com/bitcoin/bitcoin/pull/19202 09:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:37 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 09:46 -!- Luke [~Luke@bitnomial/staff/luke] has quit [Quit: sleep] 09:49 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 09:51 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 246 seconds] 09:57 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection] 09:58 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 10:02 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 10:03 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Quit: Defeated by Superior] 10:03 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 10:10 -!- pretyflaco [~k3m@77.243.183.203] has joined #bitcoin-core-dev 10:15 < phantomcircuit> sipa, can i get all of the subnets in an asn from the asmap? 10:15 < sipa> not without decoding the entire thing 10:15 < phantomcircuit> it looks like no 10:15 < sipa> but that's still pretty fast 10:15 < phantomcircuit> that makes adding asn based bans much harder but yeah definitely still doable 10:16 < sipa> ah i see 10:16 < sipa> you want to translate banned ASes to subnets 10:16 < phantomcircuit> would it be reasonable to do that when adding asn bans? cause that changes it to like two lines of code from many more 10:17 < luke-jr> maybe the banlist should support ASNs directly? 10:17 < sipa> that would certainly be cleaner 10:17 < sipa> but i see how that would be harder to implement 10:18 < sipa> i think if banlists on disk supported ASes natively, but at runtime they're converted to subnets, maybe it's ok? 10:18 < phantomcircuit> i can definitely support asn's directly instead, it's not something where one approach is obviously better to me though 10:18 < sipa> so that they correctly persist across restarts if asmap gets updated 10:20 < phantomcircuit> adding support naively will break backwards compat with banlist.dat though 10:20 < luke-jr> sipa: nah imo 10:21 < luke-jr> sipa: setban should support adding/removing AS bans, without affecting overlapping subnet bans, IMO 10:21 < sipa> luke-jr: that's reasonable 10:21 < luke-jr> plus we might want to update ASmaps at runtime someday 10:21 -!- davterra [~dulyNoded@104.200.129.62] has joined #bitcoin-core-dev 10:22 < sipa> phantomcircuit: i think it's expected that banlist.dat compatibility breaks when you ban an AS - there is no way for an old version to behave correctly 10:22 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 10:22 < sipa> you wouldn't want to run with a partial set of bans 10:22 < phantomcircuit> sipa, no i mean doing this naively would mean clearing all your old bans 10:22 < sipa> why? 10:22 < luke-jr> hmm 10:23 < luke-jr> sipa: do we have a way to sanely handle an incompatible banlist in current/old versions? 10:23 < sipa> no clue 10:23 < luke-jr> losing the banlist entirely would be strictly worse than just losing AS bans 10:23 < sipa> i have never looked at its serialization 10:24 < sipa> agree 10:24 < sipa> well 10:24 < phantomcircuit> sipa, banlist.dat is basically just a serialized banmap_t which is a map of subnets 10:24 < sipa> i think that if you add an AS ban, you should not lose existing subnet bans 10:25 < sipa> but if you add an AS ban, and then downgrade to a version that does not support AS bans, ideally it just fails to start 10:25 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 10:25 < sipa> phantomcircuit: banlist serialized entries have a version number 10:26 < sipa> so there is no problem 10:26 < sipa> just increment the version number of AS-based bans; but keep supporting the old subnet-only one in the deserializer 10:27 < sipa> unfortunately the version number is not enforced 10:27 < sipa> so old versions with read corrupted data 10:28 < luke-jr> looks like if we change the root type (currently map) old versions should refuse to load it 10:28 < phantomcircuit> that means changing a bunch of the logic for serialize/deserialize 10:28 < luke-jr> and refuse to start 10:28 < phantomcircuit> or i could just map asn's to subnet and it's potentially much less code and compatible... 10:28 < luke-jr> sipa: there's a checksum to stop corrupted data 10:29 < luke-jr> phantomcircuit: could make a new type that serialises the same for subnets? 10:29 < luke-jr> and just serialise ::0/0 followed by AS info for anAS ban 10:30 < luke-jr> the checksum should stop it from loading that as ::0/0 in old versions 10:30 < luke-jr> (possibly stored as ::ASN/0 in memory to avoid wasting extra RAM 10:30 < sipa> phantomcircuit: i'll have a look at making the ser/deser code more upgradable 10:32 < phantomcircuit> sipa, the addrdb and bandb share the ser/deser logic to do this they probably just need to be split 10:32 < sipa> phantomcircuit: perhaps 10:32 < sipa> phantomcircuit: std::map is serialized with a size prefix 10:33 < sipa> so we could change the serialization to stary with a giant number 10:33 < sipa> to indicate a new version 10:33 < sipa> so that it will fail to load on old versions 10:33 < sipa> *start 10:34 < phantomcircuit> just start with a dummy db that has a bad checksum 10:34 < sipa> that's also possible 10:35 < phantomcircuit> that seems like it would be more obvious 10:35 -!- XORder [d13a8161@209.58.129.97] has quit [Ping timeout: 245 seconds] 10:37 < phantomcircuit> also changing banmap_t is going to effect a whole bunch of logic 10:38 < sipa> i know 10:38 < sipa> but that code is due for a cleanup anyway, o think 10:39 < sipa> *i 10:40 < luke-jr> … 10:41 < luke-jr> these all sound much more complex than what I just suggested :P 10:42 < sipa> which is? 10:45 < luke-jr> [17:29:56] and just serialise ::0/0 followed by AS info for anAS ban 10:46 < sipa> that won't work 10:47 < luke-jr> why not? 10:47 < sipa> it will result in old software reading corrupted datae 10:47 < luke-jr> which will fail the checksum 10:47 < sipa> ah, indeed! 10:47 -!- Sylveste [51f047c2@194.71-240-81.adsl-dyn.isp.belgacom.be] has joined #bitcoin-core-dev 10:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 10:48 < sipa> so you'd need a new data type instead of CSubNet to use as key in the map 10:48 < sipa> which can represent either a CSubNet or an ASN 10:49 < luke-jr> yes 10:49 < sipa> and csubnet's remain serialized as-is 10:49 < luke-jr> exactly 10:49 -!- pretyflaco [~k3m@77.243.183.203] has quit [Quit: Leaving.] 10:49 -!- pretyflaco [~k3m@77.243.183.203] has joined #bitcoin-core-dev 10:50 < sipa> and ASN are serialized as some sentinel value that's unlikely to be already present in banmans (::0/0 seems right as luke-jr suggests) + version number + ASN 10:50 -!- Sylveste [51f047c2@194.71-240-81.adsl-dyn.isp.belgacom.be] has quit [Remote host closed the connection] 10:51 < luke-jr> I mean, we could use the CSubNet part for ASN data too, so long as we don't end up with the same length 10:51 < sipa> it needs to be recognizable as an AS entry to the deserializer 10:51 < sipa> CSubNets do not have an explicit length in their serialization afaik 10:52 < luke-jr> ah 10:59 < phantomcircuit> uh whuch checksum would that fail? 10:59 < phantomcircuit> i dont see any reason that would fail the checksum in DeserializeDB 11:00 -!- k0da [~k0da@195.206.183.79] has quit [] 11:00 < sipa> phantomcircuit: because the data deserialized wouldn't match 11:00 < sipa> so it would read a checksum in the wrong place 11:01 < phantomcircuit> i mean we can just append the asn stuff then and the checksum will be wrong that way to 11:02 < sipa> yes, but how would a deserializer notice that there is more stuff to follow? 11:02 < sipa> it would need to distinguish ban entries from the checksum... 11:05 < phantomcircuit> start/data/data/hash and try to read data as both a hash and a map of asns 11:06 < sipa> that's pretty ugly i think, but yes it will work 11:06 < sipa> i think it's a bigger change 11:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:09 < phantomcircuit> sipa, could equally just have v1/v2 deserializers 11:09 < sipa> phantomcircuit: and try both? 11:10 < phantomcircuit> yeah 11:10 < sipa> well, see it this way: i think you're going to need a data type that represents "subnet or ASN" anyway, to put in the banmap map as key 11:11 < sipa> if you give that data type a serialization that's identical to a subnet's for subsets, and to some sentinal + ASN for asns, you have no other serialization issues 11:12 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 11:12 < sipa> *sentinel 11:14 < phantomcircuit> yeah that's a good point 11:14 < phantomcircuit> why is it `using banman_t = std::map...` and not a typedef ? 11:15 < sipa> using is the newer syntax 11:15 < sipa> it does the same as a typedef, but is more flexible 11:16 < sipa> https://stackoverflow.com/questions/10747810/what-is-the-difference-between-typedef-and-using-in-c11 11:20 < phantomcircuit> ok so they can still be templated where typedef cannot be 11:20 < phantomcircuit> interesting 11:20 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 11:22 -!- Bille [~Bille@84.39.116.180] has joined #bitcoin-core-dev 11:24 < phantomcircuit> sipa, oh CSubNet has a bool is valid flag 11:24 -!- davterra [~dulyNoded@104.200.129.62] has quit [Remote host closed the connection] 11:25 -!- davterra [~dulyNoded@104.200.129.62] has joined #bitcoin-core-dev 11:25 < sipa> oh, and it's serialized! 11:37 < sipa> so all you need to do is serialize ASN entries as something that gets read as valid=false by old nodes, and has a different length 11:39 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 11:43 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Client Quit] 11:44 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 11:47 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 12:02 -!- davterra [~dulyNoded@104.200.129.62] has quit [Quit: Leaving] 12:06 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:07 < luke-jr> nice 12:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.7.1] 12:20 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 12:22 -!- adiabat [~adiabat@63.209.32.102] has quit [Remote host closed the connection] 12:22 < phantomcircuit> CSubNetOrAsn ? 12:23 < phantomcircuit> CNetworkBlock? 12:23 < sipa> BanMatch ? 12:23 < phantomcircuit> im bad at naming things 12:23 < sipa> (no more C prefix for classes) 12:23 < phantomcircuit> banmatch is good 12:24 < phantomcircuit> asn's are being represented just as a 32bit number right 12:24 < sipa> yeah 12:25 -!- owowo [~ovovo@193.32.127.155] has joined #bitcoin-core-dev 12:25 -!- owowo [~ovovo@193.32.127.155] has quit [Changing host] 12:25 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:32 -!- jarthur [~jarthur@2605:6000:1019:4971:a125:88eb:55f5:36be] has joined #bitcoin-core-dev 13:06 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 13:06 -!- guest534543 [~mix@141.98.103.196] has joined #bitcoin-core-dev 13:07 -!- sanket1729 [~sanket172@ec2-34-232-77-204.compute-1.amazonaws.com] has quit [Ping timeout: 256 seconds] 13:07 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 13:08 -!- sanket1729 [~sanket172@ec2-34-232-77-204.compute-1.amazonaws.com] has joined #bitcoin-core-dev 13:09 -!- Kiminuo [~mix@141.98.103.196] has quit [Ping timeout: 256 seconds] 13:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 13:21 -!- jonatack_ [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 13:21 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 256 seconds] 13:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:24 < bitcoin-git> [bitcoin] practicalswift opened pull request #19203: tests/net: Add regression fuzz harness for CVE-2017-18350. Add FuzzedSocket. Add thin SOCKET wrapper. (master...fuzzers-Socks5) https://github.com/bitcoin/bitcoin/pull/19203 13:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:25 -!- jarthur_ [~jarthur@2605:6000:1019:4971:a125:88eb:55f5:36be] has joined #bitcoin-core-dev 13:28 -!- jarthur [~jarthur@2605:6000:1019:4971:a125:88eb:55f5:36be] has quit [Read error: Connection reset by peer] 13:51 -!- ppisati [~ppisati@net-188-218-147-167.cust.vodafonedsl.it] has quit [Quit: leaving] 13:58 -!- ppisati [~ppisati@net-188-216-96-104.cust.vodafonedsl.it] has joined #bitcoin-core-dev 14:00 -!- Bille [~Bille@84.39.116.180] has quit [] 14:06 -!- jarthur [~jarthur@2605:6000:1019:4971:f493:af92:a4fe:ef8] has joined #bitcoin-core-dev 14:10 -!- jarthur_ [~jarthur@2605:6000:1019:4971:a125:88eb:55f5:36be] has quit [Ping timeout: 272 seconds] 14:13 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:21 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 14:22 -!- kaeru [~kaeru@195.206.183.79] has joined #bitcoin-core-dev 14:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 14:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 14:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 14:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:33 -!- davterra [~dulyNoded@172.83.40.74] has joined #bitcoin-core-dev 14:39 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:48 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 14:48 -!- davterra [~dulyNoded@172.83.40.74] has quit [Ping timeout: 256 seconds] 14:51 -!- ilu [d537a698@213.55.166.152] has joined #bitcoin-core-dev 14:52 -!- davterra [~dulyNoded@193.32.127.226] has joined #bitcoin-core-dev 14:53 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has quit [Read error: Connection reset by peer] 14:53 -!- Netsplit *.net <-> *.split quits: peltre, valwal_, meshcollider, bosma, digi_james, baldur, tryphe, nullptr|, NicolasDorier, provoostenator, (+1 more, use /NETSPLIT to show all of them) 14:54 -!- Netsplit over, joins: meshcollider, NicolasDorier, digi_james, valwal_, fanquake, provoostenator, bosma, baldur, tryphe, peltre (+1 more) 14:54 -!- Netsplit *.net <-> *.split quits: ilu 14:54 -!- peltre [sid268329@gateway/web/irccloud.com/x-ovktzdniqlmsirdm] has quit [Max SendQ exceeded] 14:54 -!- Netsplit over, joins: ilu 14:54 -!- ilu [d537a698@213.55.166.152] has quit [Remote host closed the connection] 14:55 -!- Netsplit *.net <-> *.split quits: DougieBot5000, takinbo, enasigurd_, hex17or, a5m0_, wraithm, MarcoFalke, isis_, IPGlider, esotericnonsense, (+8 more, use /NETSPLIT to show all of them) 14:55 -!- Netsplit over, joins: takinbo, asoltys, waxwing, GAit, isis_, a5m0_, enasigurd_, DougieBot5000, esotericnonsense, CubicEarth (+8 more) 14:55 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Max SendQ exceeded] 14:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 14:55 -!- Netsplit *.net <-> *.split quits: mrostecki[m] 14:56 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 14:56 -!- Netsplit over, joins: mrostecki[m] 14:56 -!- Netsplit *.net <-> *.split quits: TheFuzzStone[m], jorijn, windsok 14:56 -!- davterra [~dulyNoded@193.32.127.226] has quit [Ping timeout: 246 seconds] 14:56 -!- mrostecki[m] [mrosteckim@gateway/shell/matrix.org/x-uebcwpjignixusai] has quit [Ping timeout: 252 seconds] 14:57 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:57 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 14:57 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev 14:57 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 14:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:57 -!- Netsplit *.net <-> *.split quits: kinlo, mmitech_, nejon 14:57 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 14:58 -!- Netsplit over, joins: mmitech_, nejon, kinlo 14:58 -!- windsok [~windsok@rarepepe.cash] has joined #bitcoin-core-dev 14:58 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host] 14:58 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-dev 14:58 -!- Netsplit *.net <-> *.split quits: gwillen, dlb76, wxss, sturles, z3232, rhiaro, thaumavorio, wullon5, bsm117532, Lightsword, (+9 more, use /NETSPLIT to show all of them) 14:58 -!- Netsplit over, joins: jorijn 14:59 -!- Netsplit over, joins: luke-jr, Lightsword, willcl_ark, sturles, wullon5, instagibbs, bsm117532, chjj, raj_149, dlb76 (+9 more) 15:00 -!- davterra [~dulyNoded@185.212.170.229] has joined #bitcoin-core-dev 15:00 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 15:00 -!- Henry151 [~bishop@ns3007530.ip-151-80-44.eu] has quit [Max SendQ exceeded] 15:01 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 15:01 -!- Henry151 [~bishop@ns3007530.ip-151-80-44.eu] has joined #bitcoin-core-dev 15:01 -!- peltre [sid268329@gateway/web/irccloud.com/x-fnyhlqregvovpeyf] has joined #bitcoin-core-dev 15:09 -!- guest534543 [~mix@141.98.103.196] has quit [Quit: Leaving] 15:19 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-aafujfhmpwartlae] has joined #bitcoin-core-dev 15:22 -!- mrostecki[m] [mrosteckim@gateway/shell/matrix.org/x-umxghbugprkvbmcl] has joined #bitcoin-core-dev 15:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:55 -!- kvaciral [~kvaciral@185.198.57.211] has quit [Quit: Lost terminal] 16:04 -!- jarthur [~jarthur@2605:6000:1019:4971:f493:af92:a4fe:ef8] has quit [Remote host closed the connection] 16:04 -!- jarthur [~jarthur@2605:6000:1019:4971:602f:9489:8607:1a29] has joined #bitcoin-core-dev 16:10 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev 16:35 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 16:45 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev 16:50 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 16:51 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 16:51 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection] 16:52 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 16:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:52 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19204: p2p: Reduce inv traffic during IBD (master...2006-netInvWaste) https://github.com/bitcoin/bitcoin/pull/19204 16:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:56 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 17:00 -!- kaeru [~kaeru@195.206.183.79] has quit [] 17:31 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.8] 17:33 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 17:35 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection] 17:35 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 17:40 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 17:43 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving] 17:57 -!- hack_bot [~hack_bot@195.206.169.238] has joined #bitcoin-core-dev 18:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:01 < bitcoin-git> [bitcoin] bliotti opened pull request #19205: script: previous_release.sh rewritten in python (master...previous-release-py) https://github.com/bitcoin/bitcoin/pull/19205 18:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:05 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Remote host closed the connection] 18:05 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 18:06 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 18:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:16 < phantomcircuit> currently the ScanForWalletTransactions function handles keypool TopUp implicitly, since it's checking every output with the Solver, i'd like to have the wallet set a flag when the keypool has been topped up and just do the entire scan again until it's not topping up anymore 18:16 < phantomcircuit> for the current logic this wouldn't be good, but using block filter indexes with per node siphash parameters it wouldn't be that bad 18:17 < phantomcircuit> doing this would make handling having different sets of filters much easier, that way i can just as the chain implementation for blocks it thinks match against a list of script pubkeys 18:17 < phantomcircuit> instead of having all the chain walking logic in the wallet 18:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 18:19 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 18:41 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 18:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:45 -!- jarthur [~jarthur@2605:6000:1019:4971:602f:9489:8607:1a29] has quit [] 18:46 < phantomcircuit> MarcoFalke, ^ any opinion? 18:55 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 19:01 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection] 19:01 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 19:06 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 19:08 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 264 seconds] 19:11 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 19:16 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 19:26 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 19:27 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 20:00 -!- hack_bot [~hack_bot@195.206.169.238] has quit [] 20:19 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:20 -!- Leo-WAC-WAC [~Leo-WAC-W@84.39.116.180] has joined #bitcoin-core-dev 20:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 21:06 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 21:10 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:25 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:41 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 21:43 < phantomcircuit> also i noticed that absolutely everything that calls ScanForWalletTransactions looks up the block hash by height just before calling it 21:45 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 21:47 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 21:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 21:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:49 -!- Randolf [~randolf@d207-216-81-185.bchsia.telus.net] has joined #bitcoin-core-dev 21:51 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 21:55 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Quit: tryphe] 22:01 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:03 < sipa> phantomcircuit: if it's through CChain, that's O(1) thankfully 22:05 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds] 22:07 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 22:09 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 22:11 < phantomcircuit> sipa, yeah just saying there's no reason for it to have the weird block_hash/block_height dual argument 22:13 < sipa> ah 22:16 < phantomcircuit> it also simplifies the handling of the reorg stuff if the first block can't be a reorg 22:17 < luke-jr> trying to think of a case where you'd want to use a non-main-chain block, but can't :/ 22:19 < phantomcircuit> yeah neither can i 22:34 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 22:36 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [] 22:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:48 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b3091b2be7d1...807b9f811479 22:48 < bitcoin-git> bitcoin/master fa16e78 MarcoFalke: build: Add -Wshadow-field 22:48 < bitcoin-git> bitcoin/master fac6b9b MarcoFalke: test: Avoid overwriting the NodeContext member of the testing setup 22:48 < bitcoin-git> bitcoin/master 807b9f8 fanquake: Merge #19188: test: Avoid overwriting the NodeContext member of the testin... 22:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:48 < bitcoin-git> [bitcoin] fanquake merged pull request #19188: test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field] (master...2006-testNoShadowField) https://github.com/bitcoin/bitcoin/pull/19188 22:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:53 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 22:55 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Client Quit] 22:55 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 22:56 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 23:00 -!- Leo-WAC-WAC [~Leo-WAC-W@84.39.116.180] has quit [] 23:00 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Quit: ZNC 1.8.0 - https://znc.in] 23:02 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 23:21 -!- matp [~matp@37.120.217.243] has joined #bitcoin-core-dev 23:55 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev --- Log closed Mon Jun 08 00:00:44 2020