--- Log opened Wed Jun 10 00:00:24 2020 --- Day changed Wed Jun 10 2020 00:00 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:01 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 260 seconds] 00:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 00:14 -!- MasterdonX [~masterdon@103.39.132.190] has quit [Ping timeout: 265 seconds] 00:17 -!- MasterdonX [~masterdon@66.115.175.41] has joined #bitcoin-core-dev 00:30 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 00:36 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 00:50 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:54 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 00:55 -!- dr-orlovsky [~Dr_Orlovs@31.14.40.19] has joined #bitcoin-core-dev 01:02 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 01:05 -!- Guyver2_ is now known as Guyver2 01:07 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 260 seconds] 01:08 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 01:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:44 -!- kljasdfvv [~flack@p200300d46f11fb00b9257c41477f9fe0.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 01:44 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 01:45 -!- kljasdfvv [~flack@p200300d46f11fb00dcb8a3046bb0dcd5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:50 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 240 seconds] 01:50 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds] 01:51 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 01:54 -!- peltre [sid268329@gateway/web/irccloud.com/x-fnyhlqregvovpeyf] has quit [Ping timeout: 256 seconds] 01:55 -!- peltre [sid268329@gateway/web/irccloud.com/x-uilwmmlwtxvoszuv] has joined #bitcoin-core-dev 01:58 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Quit: ZNC 1.8.1 - https://znc.in] 02:00 -!- hollisb [~hollisb@84.39.116.180] has quit [] 02:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:10 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 02:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:13 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8364df25070...20e95313790c 02:13 < bitcoin-git> bitcoin/master 948f113 fanquake: gui: add missing translation.h include to fix build 02:13 < bitcoin-git> bitcoin/master 20e9531 fanquake: Merge #19231: gui: add missing translation.h include to fix build 02:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:13 < bitcoin-git> [bitcoin] fanquake merged pull request #19231: gui: add missing translation.h include to fix build (master...translations_gui_fixup) https://github.com/bitcoin/bitcoin/pull/19231 02:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:14 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 02:15 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 02:16 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Quit: Defeated by Superior] 02:20 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 02:22 -!- Sho_1 [~Sho_@195.206.183.79] has joined #bitcoin-core-dev 02:31 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 02:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:40 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev 02:43 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 02:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 02:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:49 < bitcoin-git> [bitcoin] hebasto opened pull request #19233: Make SetMiscWarning() accept bilingual_str argument (master...200610-bi-warn) https://github.com/bitcoin/bitcoin/pull/19233 02:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:52 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 02:54 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 03:00 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 03:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:03 -!- Evangeline12Mill [~Evangelin@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:08 -!- Evangeline12Mill [~Evangelin@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 03:12 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 03:18 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 265 seconds] 03:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 03:24 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 03:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 04:00 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 04:02 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Client Quit] 04:07 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 04:08 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 240 seconds] 04:08 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 04:10 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 04:10 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 04:24 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 04:32 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 256 seconds] 04:43 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev 04:50 -!- dr-orlovsky [~Dr_Orlovs@31.14.40.19] has quit [Ping timeout: 260 seconds] 04:51 < shesek> 0.20.0 does not appear to report descriptor information in getaddressinfo. is this a known bug? or am I missing something? here's a simple reproduction script (basically a simple `importmulti` followed by a `getaddressinfo`) and the output I'm seeing for 0.19.1 and 0.20.0: https://gist.github.com/shesek/cecfe7f154f7a0356d8882f694713e20 04:52 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 04:55 < shesek> oh wait, I'm using pk() and treating it as a base58 address, which it isn't 04:56 < harding> Yeah, I think the question is why bitcoin-cli -regtest deriveaddresses 'pk(0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798)#gn28ywm7' returns a P2PKH address. 04:57 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds] 04:59 < shesek> is that for 0.19, 0.20 or both? 05:00 -!- Sho_1 [~Sho_@195.206.183.79] has quit [] 05:00 < harding> Both 0.19.0.1 and 0.20.0 (just tested). 05:00 < shesek> the missing descriptor info was indeed due to using pk() and then requesting the base58 address, it does work as expected with pkh() 05:01 < shesek> harding, yes, it definitely shouldn't do that :) 05:01 -!- riordant [~riordant@1.53.75.82] has quit [] 05:03 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds] 05:04 < shesek> so what changed between 0.19 and 0.20? it seems like something in 0.20 no longer considers pk() to be p2pkh-like-base58-encodeable 05:10 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 05:12 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 260 seconds] 05:22 -!- RiscTaker1 [~RiscTaker@84.39.116.180] has joined #bitcoin-core-dev 05:22 < shesek> not treating p2pk as base58 encodable in esplora is probably the #1 cause for complaints I'm hearing from people, especially around times when old stashes move around and everyone wants to look them up on the explorers. its hard enough to explain that other block explorers are wrong, but bitcoind doing it too makes this quite more challenging :p (in some other places too) 05:22 < gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub 05:23 -!- Kiminuo [~mix@141.98.103.180] has joined #bitcoin-core-dev 05:25 < shesek> harding, oddly enough, it seems like importing a pk() descriptor with a label on 0.20, then calling getaddressesbylabel with that label, does return the p2pkh address. and the label does show up in `getaddressinfo` for the p2pkh address, while the `ismine`/`iswatchonly` fields are set to `false` 05:27 < shesek> importing with a label and using getaddressesbylabel is actually how I found myself using the p2pkh address format of a p2pk script in the first place 05:40 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 05:43 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 264 seconds] 05:44 < wumpus> fanquake: thanks for fixing the build after #19176, it's kind of strange, pretty sure the PR passed all the checks 05:45 < gribble> https://github.com/bitcoin/bitcoin/issues/19176 | refactor: Error message bilingual_str consistency by laanwj · Pull Request #19176 · bitcoin/bitcoin · GitHub 05:50 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 05:55 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 05:55 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 05:55 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 05:58 < fanquake> wumpus: no worries 👍 05:58 -!- fvccvncvnbsfg [~flack@p200300d46f11fb00dcb8a3046bb0dcd5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 06:01 -!- Netsplit *.net <-> *.split quits: _flow_, kljasdfvv, windsok, TheFuzzStone[m], cncr04s 06:01 -!- pretyflaco [~k3m@185.213.155.164] has joined #bitcoin-core-dev 06:02 -!- Highway61 [~Thunderbi@104.223.94.18] has joined #bitcoin-core-dev 06:07 -!- Netsplit over, joins: TheFuzzStone[m], windsok, cncr04s 06:20 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 06:22 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:25 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20e95313790c...bc933aeaf044 06:25 < bitcoin-git> bitcoin/master fa7b46c MarcoFalke: test: Add BerkeleyDatabase tsan suppression 06:25 < bitcoin-git> bitcoin/master bc933ae Wladimir J. van der Laan: Merge #19226: test: Add BerkeleyDatabase tsan suppression 06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:26 < bitcoin-git> [bitcoin] laanwj merged pull request #19226: test: Add BerkeleyDatabase tsan suppression (master...2006-ciTsanSupWallet) https://github.com/bitcoin/bitcoin/pull/19226 06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:34 < bitcoin-git> [bitcoin] Sjors closed pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818 06:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 06:38 < provoostenator> Review nag for #18030; one of those situations where just documenting the confusion seems faster than fixing it :-) 06:38 < gribble> https://github.com/bitcoin/bitcoin/issues/18030 | doc: Coin::IsSpent() can also mean never existed by Sjors · Pull Request #18030 · bitcoin/bitcoin · GitHub 06:41 < provoostenator> Somehwat similar, though this one requires action within the next decade :-) #13875 06:41 < gribble> https://github.com/bitcoin/bitcoin/issues/13875 | [doc] nChainTx needs to become a 64-bit earlier due to SegWit by Sjors · Pull Request #13875 · bitcoin/bitcoin · GitHub 06:51 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 06:51 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc933aeaf044...371a73e94043 06:52 < bitcoin-git> bitcoin/master 38e33aa Hennadii Stepanov: refactor: Make GetWarnings() bilingual_str aware internally 06:52 < bitcoin-git> bitcoin/master d1ae7c0 Hennadii Stepanov: Make GetWarnings() return bilingual_str 06:52 < bitcoin-git> bitcoin/master d49612f Hennadii Stepanov: Make SetMiscWarning() accept bilingual_str argument 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19233: Make SetMiscWarning() accept bilingual_str argument (master...200610-bi-warn) https://github.com/bitcoin/bitcoin/pull/19233 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:55 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev 07:04 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 07:05 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 07:06 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 256 seconds] 07:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:09 < shesek> harding, I reported this at https://github.com/bitcoin/bitcoin/issues/19236 07:13 -!- lightlike [~lightlike@2a02:810d:b80:c2c:39dc:f255:f31e:6ac8] has joined #bitcoin-core-dev 07:15 < shesek> is there a customary notation for referring to the nth script of a descriptor identified by its checksum? something like /, akin to /? 07:19 < provoostenator> Hardware wallet support write up: https://gist.github.com/Sjors/29d06728c685e6182828c1ce9b74483d 07:19 -!- lightlike [~lightlike@2a02:810d:b80:c2c:39dc:f255:f31e:6ac8] has quit [Remote host closed the connection] 07:23 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Ping timeout: 256 seconds] 07:25 -!- Kiminuo [~mix@141.98.103.180] has quit [Ping timeout: 256 seconds] 07:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/371a73e94043...6762a627ecb8 07:25 < bitcoin-git> bitcoin/master c75de5d Pieter Wuille: [TESTS] Move base58 to own module to break circular dependency 07:25 < bitcoin-git> bitcoin/master 6762a62 MarcoFalke: Merge #19230: [TESTS] Move base58 to own module to break circular dependen... 07:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19230: [TESTS] Move base58 to own module to break circular dependency (master...202006_addr_base58) https://github.com/bitcoin/bitcoin/pull/19230 07:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:26 -!- jarthur [~jarthur@2605:6000:1019:63cd:39b7:ba25:cb26:bae9] has joined #bitcoin-core-dev 07:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 07:30 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 07:34 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds] 07:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:40 < bitcoin-git> [bitcoin] elichai opened pull request #19237: Check size after unserializing a pubkey (master...2020-06-pubkey) https://github.com/bitcoin/bitcoin/pull/19237 07:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:41 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Ping timeout: 260 seconds] 07:54 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev 07:55 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 07:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 08:00 -!- RiscTaker1 [~RiscTaker@84.39.116.180] has quit [] 08:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:24 < provoostenator> For some reason Travis isn't running on #15382, but I don't think my account is flagged (this time)... 08:24 < gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub 08:24 < wumpus> provoostenator: nice, thanks for writing that up 08:26 < jonatack> thanks provoostenator 08:29 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 08:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 08:35 -!- owowo [~ovovo@82.102.24.187] has joined #bitcoin-core-dev 08:35 -!- owowo [~ovovo@82.102.24.187] has quit [Changing host] 08:35 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:40 < bitcoin-git> [bitcoin] hebasto opened pull request #19238: refactor: Replace RecursiveMutex with Mutex in CAddrMan (master...200610-addrman-mx) https://github.com/bitcoin/bitcoin/pull/19238 08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:42 -!- Kiminuo [~mix@141.98.103.180] has joined #bitcoin-core-dev 08:43 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 08:56 < Kiminuo> wumpus, Hi, I have been investigating std::filesystem in c++17 a bit (see https://github.com/bitcoin/bitcoin/pull/19183#issuecomment-641321318) and I would like to lay the groundwork for a worthy PR. I'm just wondering whether you would be willing to answer a few questions along the way - given that you know the old issues with boost::filesystem. 08:56 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev 08:57 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 09:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:02 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:13 < bitcoin-git> [bitcoin] jnewbery opened pull request #19239: tests: move generate_wif_key to wallet_util.py (master...2020-06-generate-wif-key) https://github.com/bitcoin/bitcoin/pull/19239 09:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:23 -!- proofofk_ [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:24 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 09:25 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 09:35 < wumpus> Kiminuo: sure! though, I'm not sure I'm aware of all the old issues with boost::filesystem, just that there's a long history of them 09:37 < wumpus> (and as said I'm most worried about windows support, it tends to be that the mingw c++ library support lags beind unix/linux — but if it passes all the unit and functional tests even on that platform it's a good indication at least ) 09:45 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:53 < Kiminuo> wumpus, well, I have two projects in MSVS, one with boost and one with c++17 and so far I have problems with unicode in boost project but c++17 & unicode works well for me - I use fs::u8path (https://en.cppreference.com/w/cpp/filesystem/path/u8path) and not fs::path. This makes me believe that c++17 may actually help with unicode issues. No guarantees at this point though. It's just it may not be that crazy idea to change fs::path -> fs:u8path. 09:53 < Kiminuo> But it's very hard for me to assess whether it's a good idea or not and if it sounds good whether there are corner cases (different platforms, different Bitcoin features,...) 09:56 < Kiminuo> One notable new issue with c++17 is that fs::unique_path is not implemented because https://stackoverflow.com/questions/43316527/what-is-the-c17-equivalent-to-boostfilesystemunique-path 09:57 < Kiminuo> However, the implementation is not that hard https://github.com/boostorg/filesystem/blob/boost-1.73.0/src/unique_path.cpp#L127 09:57 < Kiminuo> Lot's of things :) 09:57 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 10:02 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 265 seconds] 10:02 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving] 10:02 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 10:03 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 10:05 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 10:11 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 258 seconds] 10:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:17 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev 10:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 10:48 < sipsorcery> Kiminuo: If you need I can check/help with changes to the file path logic on Windows. 10:49 < sipsorcery> iirc there were a few PR's to fix some Windows unicode issues a year or so ago. 10:49 < Kiminuo> sipsorcery, great! I'll try to prepare a draft PR in coming days and it will be great to collaborate on that then :-) 10:50 < Kiminuo> sipsorcery, if you know about any of that issue, could you send a link? It would be helpful to compile a list of those issues to make review easier 10:50 < sipa> Kiminuo: i briefly looked into replacing fs with something std::filesystem based, but didn't get very far 10:51 < sipa> i did notice that it'd require a separate unique_path 10:51 < sipsorcery> It'd be great to get rid of the Win32 CreateDirectoryA/CreateDirectoryW etc calls and replace with std library calls. 10:51 < sipsorcery> I'll dig up the PR's. 10:51 < Kiminuo> sipa, Yes, it's true about the unique_path, unfortunately. But given a random generator, one can generate a random file name, right? 10:52 < sipa> sure 10:52 < Kiminuo> sipsorcery, thank you 10:53 < sipsorcery> https://github.com/bitcoin/bitcoin/issues/13103 10:53 < sipsorcery> https://github.com/bitcoin/bitcoin/pull/13787 10:55 < provoostenator> #13103 #13787 (for previews) 10:55 < gribble> https://github.com/bitcoin/bitcoin/issues/13103 | Invalid wallet path with Chinese characters in windows · Issue #13103 · bitcoin/bitcoin · GitHub 10:55 < gribble> https://github.com/bitcoin/bitcoin/issues/13787 | Test for Windows encoding issue by ken2812221 · Pull Request #13787 · bitcoin/bitcoin · GitHub 10:56 < Kiminuo> I know about this: https://github.com/bitcoin/bitcoin/pull/6093 it's very old though 10:58 < sipsorcery> Upstream PR from leveldb that has been merged into Bitcoin Core https://github.com/google/leveldb/pull/760 11:02 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Quit: Leaving] 11:02 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 260 seconds] 11:06 -!- lightlike [~lightlike@2a02:810d:b80:c2c:39dc:f255:f31e:6ac8] has joined #bitcoin-core-dev 11:09 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev 11:10 -!- MM77788811 [~MM7778881@195.206.104.107] has joined #bitcoin-core-dev 11:13 -!- MM77788811 [~MM7778881@195.206.104.107] has quit [Remote host closed the connection] 11:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:22 -!- zepheiryan [~zepheirya@217.138.204.90] has joined #bitcoin-core-dev 11:32 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 11:33 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 11:42 -!- peechay [~peechay@KD118156134106.ppp-bb.dion.ne.jp] has joined #bitcoin-core-dev 11:42 -!- peechay [~peechay@KD118156134106.ppp-bb.dion.ne.jp] has left #bitcoin-core-dev [] 11:47 -!- lightlike [~lightlike@2a02:810d:b80:c2c:39dc:f255:f31e:6ac8] has quit [Quit: Leaving] 11:52 < Kiminuo> *thumbs up* 11:56 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 11:56 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 12:15 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:15 -!- pretyflaco1 [~k3m@2001:a61:4e3:7701:a4f8:3391:dadd:31fe] has joined #bitcoin-core-dev 12:19 -!- pretyflaco [~k3m@185.213.155.164] has quit [Ping timeout: 265 seconds] 12:23 -!- lightlike [~lightlike@2a02:810d:b80:c2c:39dc:f255:f31e:6ac8] has joined #bitcoin-core-dev 12:26 -!- Highway61 [~Thunderbi@104.223.94.18] has quit [Remote host closed the connection] 12:27 -!- Highway61 [~Thunderbi@104.223.94.18] has joined #bitcoin-core-dev 12:31 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.8] 12:32 -!- Highway61 [~Thunderbi@104.223.94.18] has quit [Remote host closed the connection] 12:32 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 12:33 -!- Highway61 [~Thunderbi@104.223.94.18] has joined #bitcoin-core-dev 12:38 < achow101> i have a possibly very dumb idea: hack sqlite's btree module to use the bdb file format 12:45 < sipa> why...? 12:48 < achow101> to keep backwards compatibility and avoid all of the issues with refactoring existing bdb handling code 12:48 < achow101> i also haven't thought this through at all 12:48 < sipa> it sounds like combining the worst of all worlds :) 12:49 < sipa> bdb dependency, complexity of sqlite, and still have a new file format that's not compatible with old software 12:50 < achow101> I think it would be compatible with old software and still remove the bdb dependency 12:50 < luke-jr> O.o 12:50 < achow101> the only reason I thought of this was because I found sqlightning which is sqlite but using lmdb as the btree module 12:51 < luke-jr> so you mean reimplementing bdb? 12:51 < achow101> only the file format 12:51 < luke-jr> also, bdb has no concept of tables/etc 12:52 < luke-jr> 2) sqlite doesn't accept outside patches, 3) it would take years for distros to release this version 12:52 < sipa> if you seriously want to implement bdb's file format, please revive logdb instead 12:53 < achow101> the idea was to just be able to toss out the existing bdb handling code without breaking existing compatibility 12:54 < sipa> i'm very confused by what you're suggesting then 12:54 < achow101> basically use sqlite but have it read and write bdb format files. so new wallets can still be opened by old software and old wallets opened by new 12:55 < achow101> so we can use sqlite's acid guarantees and easier implementation but still remain compatible 12:55 < achow101> and not have to maintain the separate stuff to deal with bdb 12:56 < achow101> that was the half baked idea 12:59 < luke-jr> achow101: I don't see how sqlite is easier to implement.. or what problems we have from bdb 12:59 < luke-jr> it seems to be working fine 13:00 < achow101> luke-jr: in the refactor to prepare for other db systems, there's a few questions about whether that has introduced regressions because it's difficult to work out the exact flushing and closing behavior 13:00 < sipa> achow101: i'm baffled how you think introducing sqlite would not break compatibility 13:00 < achow101> sipa: because we would be modifying it to write data in the same way bdb does 13:00 < luke-jr> achow101: okay, but the fact is right now we have years of no problems 13:01 < achow101> luke-jr: no? 13:01 < sipa> achow101: then what's the point? 13:01 < sipa> that seems like a huge task for no gain 13:01 < luke-jr> achow101: ? 13:01 < achow101> sipa: then old software would still be able to read those files 13:01 < sipa> achow101: i must be missing something 13:02 < achow101> sipa: sqlite does a bunch of other things unrelated to the storage format to guarantee consistency 13:02 < achow101> so we would be able to take advantage of those 13:02 < achow101> and just have a different file format 13:03 < sipa> it seems the cost/benefit of such an effort are about 100x worse than staying with bdb, or switching to logdb 13:05 -!- MM77788811 [~MM7778881@190.14.1.3] has joined #bitcoin-core-dev 13:05 < achow101> it seemed to me to be easier to implement/copy a file format implementation than to logic my way through when and how to flush and close bdb for the refactor 13:05 < luke-jr> achow101: what problems do you think need solving? 13:06 < sipa> making (a) a new backend to sqlite and (b) making and keeping it compatible with bdb eaxh individually seem like far more work (in implementation+testing/qa combined) then just creating a dumb key/value store from scratch 13:07 -!- MM77788811 [~MM7778881@190.14.1.3] has quit [Client Quit] 13:07 < sipa> the advantage of sqlite is getting a well-tested robust format and implementation for free; if it needs large customization, i don't see why we'd even pick it in the first place 13:07 -!- lightlike [~lightlike@2a02:810d:b80:c2c:39dc:f255:f31e:6ac8] has quit [Remote host closed the connection] 13:08 -!- lightlike [~lightlike@2a02:810d:b80:c2c:39dc:f255:f31e:6ac8] has joined #bitcoin-core-dev 13:08 < luke-jr> sipa: bdb4.8 is currently/already well-tested and robust in our usage though 13:08 < luke-jr> only point in switching to sqlite IMO is if we want to use the relational features 13:11 < achow101> sipa: to take advantage of how they do atomic commits, do locking and concurrency, etc. the things which are independent of the file format itself. 13:11 < sipa> i don't comprehend how that can seem worth it 13:13 < achow101> for example, sqlite flushes to the database file after every write. this behavior is independent of the database file. because it does this, we could remove the need for PeriodicFlush. We would remove the need for WalletDatabase::Flush entirely 13:13 < sipa> ok? 13:14 < sipa> and that's worth a huge engineering effort to develop and maintain a new backend to sqlite? 13:14 < sipa> to avoid a wrapper in our logic? 13:15 < luke-jr> one advantage of bdb is since it isn't maintained, what we learn about its inner workings *won't* change :p 13:15 < achow101> depends on how huge the engineering effort is 13:15 < achow101> we have a lot of very confusing logic in our code related to flushing 13:15 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer] 13:15 < luke-jr> achow101: we *could* just flush on every change to bdb 13:15 < luke-jr> there might be reasons we don't, but if so, then switching to sqlite would have the same problems 13:16 < achow101> and the flushing logic is the cause of a lot of confusion in the refactor 13:16 < sipa> i'm sure we'll get through that 13:16 < achow101> luke-jr: we do "flush", but it flushes to the transaction log, not the database file 13:16 < wumpus> I like using sqlite, to be honest, I don't think rolling a new database just for bitcoin core's database is a good idea, yes a dumb store would be enough for key storage, but for transactions it's likely that some more advanced query functionality would be useful at some point 13:17 < sipa> wumpus: i just sqlite because it's so well tested 13:17 < sipa> *like 13:17 < achow101> and getting it to flush into the database file is, apparently, a major task and pain in the ass 13:17 < achow101> but trivial for sqlite 13:17 < wumpus> it's also very well tested 13:17 < wumpus> agree 13:18 < luke-jr> sipa: but so is db4.8 specifically in our use 13:19 < sipa> and maintained 13:19 < wumpus> achow101: yes, the flush has never really been a flush but 'database consolidation' 13:19 < wumpus> (which happens to also do a flush, but that's not the point, the point was to have things in one file) 13:20 < luke-jr> if you want things in one file, look at what backupwallet does 13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:22 < bitcoin-git> [bitcoin] dongcarl opened pull request #19240: 2020 06 macos sdkgen simplify (master...2020-06-macos-sdkgen-simplify) https://github.com/bitcoin/bitcoin/pull/19240 13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:24 -!- lightlike [~lightlike@2a02:810d:b80:c2c:39dc:f255:f31e:6ac8] has quit [Quit: Leaving] 13:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:25 < bitcoin-git> [bitcoin] dongcarl closed pull request #18072: Use `libc++` headers from macOS SDK instead of from clang (master...2020-01-macos-sdk-with-headers) https://github.com/bitcoin/bitcoin/pull/18072 13:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:31 -!- ycshao [~ycshao@190.14.1.3] has joined #bitcoin-core-dev 13:32 < ycshao> Anyone has suggestions to how to fix travis failure of https://github.com/bitcoin/bitcoin/pull/19208? I took a look and don't think the failure is caused by my change. 13:36 -!- ycshao [~ycshao@190.14.1.3] has quit [Remote host closed the connection] 13:37 -!- ycshao [~ycshao@190.14.1.3] has joined #bitcoin-core-dev 13:38 < ycshao> A related question is do all CIs have to pass before PR can be merged? I saw a few PRs merged with failed CI, like this one https://github.com/bitcoin/bitcoin/pull/19201#partial-pull-merging 13:39 < sipa> ycshao: there currently are two unrelated issues that break CI regularly in master 13:39 < sipa> they'll be fixed soon 13:39 < sipa> they're not your fault 13:40 < ycshao> Got it sipa. 13:45 < ycshao> I always got disconnected from the channel after some time. Is this a channel setting or on my client side? 13:47 < sipa> it seems like a problem on your side 13:49 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:50 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 246 seconds] 13:53 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 13:54 -!- ycshao [~ycshao@190.14.1.3] has quit [Remote host closed the connection] 13:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 13:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:00 -!- zepheiryan [~zepheirya@217.138.204.90] has quit [] 14:22 -!- Kiminuo [~mix@141.98.103.180] has quit [Quit: Leaving] 14:22 -!- flo1 [~flo@94.229.74.91] has joined #bitcoin-core-dev 14:23 -!- ycshao [~ycshao@190.14.1.3] has joined #bitcoin-core-dev 14:24 -!- ycshao [~ycshao@190.14.1.3] has quit [Remote host closed the connection] 14:26 -!- ycshao [~ycshao@190.14.1.3] has joined #bitcoin-core-dev 14:28 -!- ycshao [~ycshao@190.14.1.3] has quit [Remote host closed the connection] 14:32 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:32 -!- ycshao [~ycshao@190.14.1.3] has joined #bitcoin-core-dev 14:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 14:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:26 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 15:26 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev 15:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 15:31 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 260 seconds] 15:31 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving] 15:34 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:39 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 256 seconds] 15:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 15:48 -!- ycshao [~ycshao@190.14.1.3] has quit [Remote host closed the connection] 15:49 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 15:57 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 15:57 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 16:09 -!- ycshao [~ycshao@209.122.245.10] has joined #bitcoin-core-dev 16:10 -!- ycshao [~ycshao@209.122.245.10] has quit [Remote host closed the connection] 16:10 -!- ycshao [~ycshao@93.177.72.218] has joined #bitcoin-core-dev 16:15 -!- ycshao [~ycshao@93.177.72.218] has quit [Remote host closed the connection] 16:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:59 < fanquake> ycshao: if you rebase on master both of those issues should now be fixed 17:00 -!- flo1 [~flo@94.229.74.91] has quit [] 17:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:00 < bitcoin-git> [bitcoin] luke-jr opened pull request #19241: help: Generate checkpoint height from chainparams (master...help_checkpoint_num) https://github.com/bitcoin/bitcoin/pull/19241 17:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:14 -!- proofofk_ [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection] 17:15 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 17:16 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Read error: Connection reset by peer] 17:17 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 17:21 -!- pretyflaco1 [~k3m@2001:a61:4e3:7701:a4f8:3391:dadd:31fe] has quit [Quit: Leaving.] 17:22 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 17:30 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 17:41 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection] 17:42 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 17:46 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 17:52 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 17:56 -!- Eartaker [~Eartaker@94.229.74.91] has joined #bitcoin-core-dev 18:05 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev 18:06 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Remote host closed the connection] 18:07 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 18:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:16 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 18:21 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 18:25 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 18:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:32 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 18:35 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 18:36 < sipa> fanquake: can you mark your "changes requested" as resolved on #19228 ? 18:36 < gribble> https://github.com/bitcoin/bitcoin/issues/19228 | Update libsecp256k1 subtree by sipa · Pull Request #19228 · bitcoin/bitcoin · GitHub 18:37 < fanquake> sipa: sure 18:41 < fanquake> Flat out confusing myself with the GH UI, but managed to get it sorted 18:43 < luke-jr> more like it managed to get you sorted :P 18:44 < fanquake> heh. Managed to re-request a review from myself 18:44 < luke-jr> XD 18:44 < sipa> fanquake is now known as aaefknqu 18:44 < luke-jr> lol 18:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:57 -!- thaumavorio [~thaumavor@thaumavor.io] has quit [Quit: ZNC 1.7.1 - https://znc.in] 18:58 -!- thaumavorio [~thaumavor@thaumavor.io] has joined #bitcoin-core-dev 19:04 -!- Highway61 [~Thunderbi@104.223.94.18] has quit [Ping timeout: 265 seconds] 19:07 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 19:09 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 19:20 -!- Highway61 [~Thunderbi@104.223.94.18] has joined #bitcoin-core-dev 19:22 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 19:24 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Client Quit] 19:26 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:28 < bitcoin-git> [bitcoin] luke-jr opened pull request #19242: Add -uaappend option to append a literal string to user agent (master...uaappend) https://github.com/bitcoin/bitcoin/pull/19242 19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:33 < aj> luke-jr: shouldn't uaappends be separated by "; " or something? 19:50 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection] 19:51 < luke-jr> aj: '/', but I'm assuming the using application knows that 19:51 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 19:51 < luke-jr> -uaappend 'foo:1.0/' 19:51 < luke-jr> -uaappend 'foo:1.0/bar:9999/' 19:55 < aj> luke-jr: i would have expected use more like -uappend=foo:1.0 -uappend=bar:9999 19:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 19:55 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 246 seconds] 19:56 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 19:56 < aj> apparently the double-a is hard for me 19:56 < luke-jr> aj: but then you can't reliably predict order 19:59 < aj> luke-jr: sure, but don't see why order matters much? (and if it does, then allowing many uaappend's doesn't seem right?) 20:00 -!- Eartaker [~Eartaker@94.229.74.91] has quit [] 20:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:16 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:17 < luke-jr> aj: maybe it does, maybe not *shrug* 20:17 < luke-jr> we don't act on it, but others might 20:18 < luke-jr> probably shouldn't I guess, but it's also nice for consistency :x 20:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 20:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 20:22 -!- meltheadorable [~meltheado@37.120.203.188] has joined #bitcoin-core-dev 20:22 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 20:25 < luke-jr> I guess always ensuring there's a / at the end makes sense 20:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:21 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:23 -!- vasild_ is now known as vasild 21:31 -!- ppisati [~ppisati@net-188-216-96-104.cust.vodafonedsl.it] has quit [Quit: leaving] 21:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 21:36 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev 21:36 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 21:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 21:38 -!- ppisati [~ppisati@net-188-153-161-130.cust.vodafonedsl.it] has joined #bitcoin-core-dev 21:57 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 21:57 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 21:58 -!- jarthur_ [~jarthur@2605:6000:1019:63cd:5bc:1f88:8104:f97d] has joined #bitcoin-core-dev 22:01 -!- jarthur [~jarthur@2605:6000:1019:63cd:39b7:ba25:cb26:bae9] has quit [Ping timeout: 256 seconds] 22:03 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 22:03 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 22:08 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds] 22:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:32 < bitcoin-git> [bitcoin] hebasto closed pull request #19238: refactor: Replace RecursiveMutex with Mutex in CAddrMan (master...200610-addrman-mx) https://github.com/bitcoin/bitcoin/pull/19238 22:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:32 < bitcoin-git> [bitcoin] hebasto reopened pull request #19238: refactor: Replace RecursiveMutex with Mutex in CAddrMan (master...200610-addrman-mx) https://github.com/bitcoin/bitcoin/pull/19238 22:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:37 -!- endogenic [sid145991@gateway/web/irccloud.com/x-pkicajnmgoqvpaje] has quit [Read error: Connection reset by peer] 22:37 -!- CodeShark___ [sid126576@gateway/web/irccloud.com/x-wkedzmnpynbhlsdg] has quit [Read error: Connection reset by peer] 22:38 -!- endogenic [sid145991@gateway/web/irccloud.com/x-roxkyzxfevjijczc] has joined #bitcoin-core-dev 22:38 -!- CodeShark___ [sid126576@gateway/web/irccloud.com/x-bsuypremvluwtcpt] has joined #bitcoin-core-dev 22:38 -!- digi_james [sid281632@gateway/web/irccloud.com/x-ixyargxtdibxiafd] has quit [Read error: Connection reset by peer] 22:38 -!- digi_james [sid281632@gateway/web/irccloud.com/x-doxceqxpvlfgpgsj] has joined #bitcoin-core-dev 23:00 -!- meltheadorable [~meltheado@37.120.203.188] has quit [] 23:21 -!- engil1 [~engil@94.229.74.91] has joined #bitcoin-core-dev 23:28 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 23:28 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 23:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 23:34 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 23:39 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 23:39 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds] 23:39 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 23:55 -!- stackingcore21_ [~stackingc@157.230.135.166] has joined #bitcoin-core-dev 23:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 23:56 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has quit [Ping timeout: 244 seconds] --- Log closed Thu Jun 11 00:00:46 2020