--- Log opened Thu Jul 09 00:00:13 2020 00:01 -!- Pavlenex [~Thunderbi@185.245.85.251] has joined #bitcoin-core-dev 00:11 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 00:15 -!- zaff [~zaff@d111-50.icpnet.pl] has joined #bitcoin-core-dev 00:18 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 00:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:22 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:23 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 00:29 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 00:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:33 < bitcoin-git> [bitcoin] hebasto opened pull request #19473: net: Add -networkactive option (master...200709-setnet) https://github.com/bitcoin/bitcoin/pull/19473 00:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:35 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 00:35 -!- gleb [~gleb@159.224.16.138] has quit [Ping timeout: 240 seconds] 00:37 -!- Pavlenex1 [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 00:39 -!- Pavlenex [~Thunderbi@185.245.85.251] has quit [Ping timeout: 240 seconds] 00:39 -!- Pavlenex1 is now known as Pavlenex 00:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 01:03 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-jemghwveerkpnejh] has quit [Ping timeout: 246 seconds] 01:04 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-yzbbwfcgdklrktij] has joined #bitcoin-core-dev 01:09 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 01:09 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 01:19 < fanquake> jonatack: are you using the (I assume self-built) Clang master branch for development/review? 01:21 < jonatack> fanquake: i changed from using debian stable to debian testing and added "deb http://apt.llvm.org/unstable/ llvm-toolchain main" to etc/apt/sources.list 01:23 < fanquake> Right. Why not use Clang 9/10 though? 01:25 < jonatack> No strong opinion yet, updated only last weekend. Which do you think is best for development/review? 01:27 < jonatack> My motivation was for testing the cfields' span PR with -Wdangling and have clang-format work again (it's currently broken for clang < 9) 01:27 < fanquake> Preferably a compiler that in not unreleased/WIP. 9 or 10 shouldn't make much difference. I was just curious after seeing your review comments. 01:29 < jonatack> Ok. FWIW #19454 fixes .clang-format for clang < 9, e.g. Debian stable 01:29 < gribble> https://github.com/bitcoin/bitcoin/issues/19454 | tools: `.clang-format` compat with clang versions < 9 by jonatack · Pull Request #19454 · bitcoin/bitcoin · GitHub 01:29 < jonatack> Will go for 10. 01:41 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 01:51 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 260 seconds] 01:52 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 01:58 -!- dr_orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:58 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has joined #bitcoin-core-dev 02:00 -!- kirkland1 [~kirkland@185.189.114.11] has quit [] 02:04 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 02:04 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 02:18 -!- someone235 [uid419897@gateway/web/irccloud.com/x-juugkzenlmbvmjsk] has joined #bitcoin-core-dev 02:19 < someone235> Hi, does bitcoin core keep node ban score even if it reconnects (even if it's below the ban threshold)? 02:19 < sipa> no 02:21 -!- bitprophet1 [~bitprophe@77.243.177.38] has joined #bitcoin-core-dev 02:30 -!- Highway61 [~Thunderbi@192.252.213.70] has joined #bitcoin-core-dev 02:34 < someone235> Thanks! 02:34 < someone235> What's the reasoning behind it? 02:35 < someone235> I would expect it to be kept so you reconnect each time your ban score is 90 02:36 < sipa> ban score logic doesn't prevent attacks 02:36 < sipa> it prevents wasting connection slots on broken software 02:36 < someone235> Sorry, I mean, so you *wont* reconnect each time your ban score is 90 02:37 < sipa> and i think ban scores as a concept should just go away 02:37 < someone235> Why? 02:38 < jonatack> someone235: good explanation why here: https://github.com/bitcoin/bitcoin/pull/19219#issuecomment-652684340 02:38 < sipa> if a client miabehaves they should be disconnected and/or banned immediately 02:38 < sipa> if they don't, we ahouldn't confuse things by maybe later doing that when some threshold is reached 02:38 < sipa> it just obscores things for no benefit 02:39 < someone235> Yeah, if we're talking about not talking with broken nodes I tend to agree 02:39 < sipa> yeah see jonatack's link 02:42 < someone235> But how will you deal with attackers? Like people who sends you full invalid blocks? 02:42 < someone235> *send 02:43 < sipa> ban them 02:43 < sipa> immediately 02:43 < someone235> oh right 02:43 < sipa> but also 02:43 < someone235> and bans are kept between reconnects 02:44 < someone235> and restarts 02:44 < sipa> there are plenty of ways to trivially DoS attack nodes by doing completely legitimate things 02:44 < sipa> that we can't ban for 02:45 < sipa> the eventual way to deal with that imho is tracking how muxh resources we spend on behalf of each peer 02:46 < sipa> and if we run out, deprioritize or disconnect the worst offenders (without banning) 02:49 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:52 -!- zaff [~zaff@d111-50.icpnet.pl] has quit [Remote host closed the connection] 02:52 -!- zaff [~zaff@d111-50.icpnet.pl] has joined #bitcoin-core-dev 03:03 -!- Parker32Connelly [~Parker32C@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:10 -!- Parker32Connelly [~Parker32C@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds] 03:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 03:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:25 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 03:25 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 03:28 -!- Highway61 [~Thunderbi@192.252.213.70] has quit [Read error: Connection reset by peer] 03:28 -!- Highway61 [~Thunderbi@192.252.213.70] has joined #bitcoin-core-dev 03:32 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 03:33 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:40 < bitcoin-git> [bitcoin] kiminuo closed pull request #19466: Use operator/ in fs::absolute to prepare for C++17 (master...feature/2020-07-08-fs-paths) https://github.com/bitcoin/bitcoin/pull/19466 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:52 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f7c19e829eca...c4a44186d816 03:55 < bitcoin-git> bitcoin/master e846a2a John Newbery: refactor: clean up PeriodicFlush() 03:55 < bitcoin-git> bitcoin/master c4a4418 MarcoFalke: Merge #19085: Refactor: clean up PeriodicFlush() 03:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:56 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 03:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:56 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19085: Refactor: clean up PeriodicFlush() (master...2020-05-refactor-periodic-flush) https://github.com/bitcoin/bitcoin/pull/19085 03:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:03 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 04:03 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 04:18 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 04:19 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 04:19 -!- reallll is now known as belcher 04:20 -!- Relis [~Relis@148.252.129.194] has joined #bitcoin-core-dev 04:43 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 04:43 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 04:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:48 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:56 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 04:56 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:59 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c4a44186d816...6b48c30541e4 04:59 < bitcoin-git> bitcoin/master b9253c7 Jon Atack: tools: clang-format 6 compatibility 04:59 < bitcoin-git> bitcoin/master 6b48c30 fanquake: Merge #19454: tools: `.clang-format` compat with clang versions < 9 04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:00 -!- bitprophet1 [~bitprophe@77.243.177.38] has quit [] 05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:00 < bitcoin-git> [bitcoin] fanquake merged pull request #19454: tools: `.clang-format` compat with clang versions < 9 (master...clang-6-compatibility) https://github.com/bitcoin/bitcoin/pull/19454 05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:08 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 240 seconds] 05:09 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 05:22 -!- sora_h [~sora_h@178.162.204.238] has joined #bitcoin-core-dev 05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:30 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b48c30541e4...e3b31255c5ad 05:30 < bitcoin-git> bitcoin/master 0b8ba84 fanquake: banlist: log post-swept banlist size at startup 05:30 < bitcoin-git> bitcoin/master e3b3125 fanquake: Merge #19470: banlist: log post-swept banlist size at startup 05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:30 < bitcoin-git> [bitcoin] fanquake merged pull request #19470: banlist: log post-swept banlist size at startup (master...log_post_sweep_banlist_size) https://github.com/bitcoin/bitcoin/pull/19470 05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:31 < bitcoin-git> [bitcoin] fanquake closed pull request #18239: wip: gui: Refactor to drop client and wallet models setters (master...2020-03-drop-setmodel) https://github.com/bitcoin/bitcoin/pull/18239 05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:36 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:39 < bitcoin-git> [bitcoin] fanquake closed pull request #17611: gui: Make send and receive widgets extend QWidget (master...2019-11-send-receive-widgets) https://github.com/bitcoin/bitcoin/pull/17611 05:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:44 -!- zaff [~zaff@d111-50.icpnet.pl] has quit [Ping timeout: 258 seconds] 05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:51 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3b31255c5ad...64bf5d64dfbf 05:51 < bitcoin-git> bitcoin/master 1e9bfd4 Hennadii Stepanov: qt: Reset toolbar after all wallets are closed 05:51 < bitcoin-git> bitcoin/master 64bf5d6 fanquake: Merge #18896: qt: Reset toolbar after all wallets are closed 05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:52 < bitcoin-git> [bitcoin] fanquake merged pull request #18896: qt: Reset toolbar after all wallets are closed (master...200506-toolbar) https://github.com/bitcoin/bitcoin/pull/18896 05:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:53 -!- Evel-Knievel [~Evel-Knie@188.188.113.157] has quit [Ping timeout: 256 seconds] 05:53 -!- Evel-Knievel [~Evel-Knie@188.189.113.122] has joined #bitcoin-core-dev 05:56 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 06:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:02 < bitcoin-git> [bitcoin] fanquake closed pull request #17966: qt, refactor: Optimize signal-slot connections logic (master...20200119-gui-walletframe) https://github.com/bitcoin/bitcoin/pull/17966 06:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:05 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:05 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:07 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:07 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:08 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:08 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-tsrtqsybwagbjglr] has joined #bitcoin-core-dev 06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:08 < bitcoin-git> [bitcoin] fanquake closed pull request #18618: gui: Drop RecentRequestsTableModel dependency to WalletModel (master...2020-04-review-18608) https://github.com/bitcoin/bitcoin/pull/18618 06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:08 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:09 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:09 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:10 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:10 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:11 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:11 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:11 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64bf5d64dfbf...21028ce9ffb8 06:11 < bitcoin-git> bitcoin/master 4b5ac25 Hennadii Stepanov: Drop unused CDBWrapper methods 06:11 < bitcoin-git> bitcoin/master 21028ce Wladimir J. van der Laan: Merge #19468: refactor: Drop unused CDBWrapper methods 06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:11 < bitcoin-git> [bitcoin] laanwj merged pull request #19468: refactor: Drop unused CDBWrapper methods (master...200708-dbwrapper) https://github.com/bitcoin/bitcoin/pull/19468 06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:12 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:12 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:13 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:13 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:14 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:14 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:15 < bitcoin-git> [bitcoin] fanquake closed pull request #17955: gui: Paste button in Open URI dialog (master...2020-01-paste-bitcoin-uri-button) https://github.com/bitcoin/bitcoin/pull/17955 06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:16 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:17 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:17 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:22 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/21028ce9ffb8...fc8da23fbe58 06:22 < bitcoin-git> bitcoin/master 2894e94 Aaron Clauson: Updates msvc build to use ISO standard C++17. 06:22 < bitcoin-git> bitcoin/master fc8da23 Wladimir J. van der Laan: Merge #19445: build: Update msvc build to use ISO standard C++17 06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:22 < bitcoin-git> [bitcoin] laanwj merged pull request #19445: build: Update msvc build to use ISO standard C++17 (master...msvc_cpp17) https://github.com/bitcoin/bitcoin/pull/19445 06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:25 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fc8da23fbe58...45f58dbc9b45 06:25 < bitcoin-git> bitcoin/master 2b78a11 nsa: doc: afl fuzzing comment about afl-gcc and afl-g++ 06:25 < bitcoin-git> bitcoin/master 45f58db fanquake: Merge #19452: doc: afl fuzzing comment about afl-gcc and afl-g++ 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:25 < bitcoin-git> [bitcoin] fanquake merged pull request #19452: doc: afl fuzzing comment about afl-gcc and afl-g++ (master...afl_gcc_0705) https://github.com/bitcoin/bitcoin/pull/19452 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:31 < bitcoin-git> [bitcoin] fanquake closed pull request #18865: gui: Refactor WalletFrame to extend QStackView (master...2020-05-walletframe) https://github.com/bitcoin/bitcoin/pull/18865 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 06:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 06:42 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:46 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has quit [Read error: Connection reset by peer] 06:50 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 06:52 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:52 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:53 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:53 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:55 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has joined #bitcoin-core-dev 06:56 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 06:56 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:04 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45f58dbc9b45...9a3c7afe290f 07:04 < bitcoin-git> bitcoin/master c858302 jmorgan: Change format of log2_work for uniform output (zero-padded) 07:04 < bitcoin-git> bitcoin/master 9a3c7af Wladimir J. van der Laan: Merge #19317: Add a left-justified width field to log2_work component for ... 07:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:05 -!- roconnor [~roconnor@host-45-58-208-39.dyn.295.ca] has joined #bitcoin-core-dev 07:13 < willcl_ark> Is it possible to build the fuzzing harness (only) with gcc rather than clang? 07:17 < MarcoFalke> willcl_ark: Yes, e.g. with afl-gcc 07:17 < MarcoFalke> see doc/fuzzing.md 07:19 < MarcoFalke> #19452 07:19 < gribble> https://github.com/bitcoin/bitcoin/issues/19452 | doc: afl fuzzing comment about afl-gcc and afl-g++ by Crypt-iQ · Pull Request #19452 · bitcoin/bitcoin · GitHub 07:19 < willcl_ark> MarcoFalke: Right. I'm looking at #19388 a bit more, and it seems to me undesirable that we'd now require e.g. afl-gcc for all the gcc builds if fuzzing harnesses were built by default. 07:19 < gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub 07:20 < MarcoFalke> Oh, if you don't need instrumentation, you should be able to use any cpp compiler 07:21 < MarcoFalke> The fuzz engine only provides the main function, but the individual fuzz tests don't know that. They can be compiled with any cpp compiler 07:21 < willcl_ark> OK, that's what I understood too (from Practicalswift's comments in https://github.com/bitcoin/bitcoin/pull/19366#issue-438840241), but i've been struggling with gcc. If it should be possible I'll keep grappling :) 07:21 < willcl_ark> My issues are mainly with the linking 07:22 < MarcoFalke> Yes, there might be issues linking the main function 07:23 < willcl_ark> Yeah that's the general complaint 07:25 < MarcoFalke> I'd have to look at the code or failure to say more, but generally it should be possible 07:27 < willcl_ark> OK thanks, perhaps I'll ping you in the issue when I have a clearer error to look at 07:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 07:27 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:28 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9a3c7afe290f...22ccc27046a8 07:29 < bitcoin-git> bitcoin/master fc6a637 10xcryptodev: qt: increase console command max length 07:29 < bitcoin-git> bitcoin/master 22ccc27 fanquake: Merge #18993: qt: increase console command max length 07:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:29 -!- murrayn [~murray@unaffiliated/murrayn] has quit [Read error: Connection reset by peer] 07:29 -!- murray_ [~murray@static.56.37.130.94.clients.your-server.de] has joined #bitcoin-core-dev 07:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:29 < bitcoin-git> [bitcoin] fanquake merged pull request #18993: qt: increase console command max length (master...202005-increase-console-command) https://github.com/bitcoin/bitcoin/pull/18993 07:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:30 -!- victorSN7 [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 07:30 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Read error: Connection reset by peer] 07:30 -!- victorSN7 is now known as victorSN 07:32 < fanquake> I've swapped out my current high-prio PR for #19224. 07:32 < gribble> https://github.com/bitcoin/bitcoin/issues/19224 | [0.20] Backports by fanquake · Pull Request #19224 · bitcoin/bitcoin · GitHub 07:32 < fanquake> Review-beg if you have a PR that is being back-ported there. 07:44 -!- owowo [~ovovo@185.9.18.115] has joined #bitcoin-core-dev 07:44 -!- owowo [~ovovo@185.9.18.115] has quit [Changing host] 07:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 07:48 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 07:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:51 < bitcoin-git> [bitcoin] dongcarl closed pull request #17099: depends: Eliminate hard dependency on Ubuntu-ABI specific clang (master...2019-09-no-clang-download) https://github.com/bitcoin/bitcoin/pull/17099 07:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:56 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22ccc27046a8...0d69fdb9a0e3 07:56 < bitcoin-git> bitcoin/master 1cabbdd Aaron Hook: refactor: Use uint16_t instead of unsigned short 07:56 < bitcoin-git> bitcoin/master 0d69fdb Wladimir J. van der Laan: Merge #19314: refactor: Use uint16_t instead of unsigned short 07:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:56 < bitcoin-git> [bitcoin] laanwj merged pull request #19314: refactor: Use uint16_t instead of unsigned short (master...akh_uint16_t) https://github.com/bitcoin/bitcoin/pull/19314 07:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:57 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Remote host closed the connection] 07:58 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 08:00 -!- sora_h [~sora_h@178.162.204.238] has quit [] 08:03 < instagibbs> suggested topic: unified zmq stream + mempool sequence number https://github.com/bitcoin/bitcoin/pull/19462#issuecomment-656140421 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:05 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d69fdb9a0e3...cc9d09e73de0 08:05 < bitcoin-git> bitcoin/master fa0540c MarcoFalke: net: Extract download permission from noban 08:05 < bitcoin-git> bitcoin/master cc9d09e MarcoFalke: Merge #19191: net: Extract download permission from noban 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:05 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19191: net: Extract download permission from noban (master...2006-netPerDow) https://github.com/bitcoin/bitcoin/pull/19191 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:11 -!- yudan [2d4dac61@45.77.172.97] has joined #bitcoin-core-dev 08:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:12 < bitcoin-git> [bitcoin] fanquake closed pull request #19001: qt: bugfix unsupported QLocale languages (master...202005-bugfix-qlocale) https://github.com/bitcoin/bitcoin/pull/19001 08:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:16 -!- rawtaz1 [~rawtaz@185.244.214.217] has joined #bitcoin-core-dev 08:17 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:17 < bitcoin-git> [bitcoin] fanquake closed pull request #18604: Display command line usage to console without requiring X Windows (master...UsageToConsoleIfNotWin32) https://github.com/bitcoin/bitcoin/pull/18604 08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:18 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:30 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 08:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 08:34 -!- vasild_ is now known as vasild 08:35 -!- shuckc [51bb0813@19.8.187.81.in-addr.arpa] has joined #bitcoin-core-dev 08:35 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 08:40 -!- zaff [~zaff@d111-50.icpnet.pl] has joined #bitcoin-core-dev 08:43 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Quit: I'm out.] 08:44 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev 08:47 -!- jarthur_ is now known as jarthur 08:47 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 08:47 -!- yudan [2d4dac61@45.77.172.97] has quit [Remote host closed the connection] 08:48 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has quit [Read error: Connection reset by peer] 08:48 -!- dr_orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has joined #bitcoin-core-dev 08:49 -!- zaff [~zaff@d111-50.icpnet.pl] has quit [Ping timeout: 256 seconds] 08:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:50 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19474: doc: Use precise permission flags where possible (master...2007-docPerm) https://github.com/bitcoin/bitcoin/pull/19474 08:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:53 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cc9d09e73de0...fd9db45c3ea1 08:53 < bitcoin-git> bitcoin/master a4a3fc4 Sjors Provoost: doc: improve subtree check instructions 08:53 < bitcoin-git> bitcoin/master fd9db45 Wladimir J. van der Laan: Merge #19258: doc: improve subtree check instructions 08:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:53 < bitcoin-git> [bitcoin] laanwj merged pull request #19258: doc: improve subtree check instructions (master...2020/06/subtree-docs) https://github.com/bitcoin/bitcoin/pull/19258 08:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:58 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 08:58 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 09:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:08 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 264 seconds] 09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:12 < bitcoin-git> [bitcoin] Mohamed-94 opened pull request #19475: script: Speed up default time-out and Container CPU usage (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19475 09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:14 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 09:14 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:15 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:17 < luke-jr> https://twitter.com/RainDogDance/status/1281260787475021826 09:17 < luke-jr> apparently there's a market for TNBTC 09:18 < luke-jr> kindof. 09:36 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 09:37 < instagibbs> it's hard to get your hands on large amounts unless you "know people" 09:40 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Remote host closed the connection] 09:40 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 09:43 < phantomcircuit> instagibbs, it's extremely easy to mine a huge amount of tnbtc if you modify a stratum proxy very slightly 09:47 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 09:47 -!- corollari_ [sid405633@gateway/web/irccloud.com/x-dpccvivkslsxrlqe] has joined #bitcoin-core-dev 09:48 -!- hebasto_ [sid449604@gateway/web/irccloud.com/x-enophmnkhwgchotz] has joined #bitcoin-core-dev 09:48 -!- mmitech__ [sid446259@gateway/web/irccloud.com/x-uacbazwzaxgcdmnb] has joined #bitcoin-core-dev 09:48 -!- ryanofsky_ [russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev 09:50 < instagibbs> someone is warp mining this morning AFAICT 09:50 -!- commavir_ [~vir@23.226.237.192] has joined #bitcoin-core-dev 09:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:51 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 09:51 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:51 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 09:52 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:52 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:55 -!- meshcoll- [meshcollid@gateway/shell/ircnow/x-mckvnhdqwkgowycq] has joined #bitcoin-core-dev 09:55 -!- Netsplit *.net <-> *.split quits: da2ce7_, meshcollider, hebasto, mmitech_, gribble, corollari, NicolasDorier, ryanofsky 09:56 -!- Netsplit *.net <-> *.split quits: commavir 09:56 -!- hebasto_ is now known as hebasto 09:56 -!- commavir_ is now known as commavir 09:56 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-ptpgapsyqbthygsg] has quit [Read error: Connection reset by peer] 09:56 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-fqksvbhhzduvxwrs] has quit [Read error: Connection reset by peer] 09:56 -!- mrostecki [mrosteckim@gateway/shell/matrix.org/x-wsdwvjaqefffwimy] has quit [Remote host closed the connection] 09:56 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-gmubhmkwglaavlyf] has quit [Write error: Connection reset by peer] 09:56 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-gcyknawatdezynha] has quit [Write error: Connection reset by peer] 09:57 -!- infamously[m] [infamously@gateway/shell/matrix.org/x-qkqvzwfkypgkuswr] has quit [Remote host closed the connection] 09:58 -!- Netsplit over, joins: NicolasDorier, da2ce7_ 10:02 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-pktspyzlzrprxqfn] has joined #bitcoin-core-dev 10:03 -!- dr_orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has quit [Read error: Connection reset by peer] 10:04 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has joined #bitcoin-core-dev 10:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 10:05 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 10:07 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 10:08 < cfields> jonatack: that warning has me completely stumped, and now I'm curious. Building clang from source now to play along. 10:10 < jonatack> cfields: idk if it's worth it. i didn't install from source. added "deb http://apt.llvm.org/unstable/ llvm-toolchain main" to my etc/apt/sources.list 10:10 < cfields> ack 10:10 < jonatack> fanquake suggested this am that i move back to clang stable 9 or 10 for reviewing purposes 10:10 < cfields> jonatack: do you get a ton of warnings? Or just that one? 10:11 < jonatack> just the one. i agree with you that it doesn't make sense. 10:11 < cfields> you actually checked out the commit, right? Didn't c/p from github? 10:12 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 10:12 < jonatack> yes, i always do. build several times with make distclean to be sure it was really doing that, and also compared with a clean gcc 9.3 build 10:12 < jonatack> built* 10:12 < cfields> So weird! 10:13 < cfields> We'll see if I can reproduce from a git build. 10:13 < sipa> jonatack: and you only get the warning on the new code introducsd to attrihutes.h? 10:13 < sipa> not anywhere else? 10:13 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:14 < jonatack> I'm afraid I've led you into a goosechase cfields. sipa: correct, but i've only been reviewing with this version of clang since sunday. 10:14 < cfields> jonatack: no worries, I needed to build llvm to test recent lld anyway. That's the only reason I jumped to compile so quickly. 10:15 < jonatack> i was on debian clang 6 which does not have -Wdangling and wanted to test cory's PR 10:15 < jonatack> cfields: yes. LMK 10:20 -!- Highway62 [~Thunderbi@67.215.228.90] has joined #bitcoin-core-dev 10:21 < jonatack> rebuilt just now again, saw it again. but also apt-update has new clang updates. installing and rebuilding. 10:21 -!- Highway61 [~Thunderbi@192.252.213.70] has quit [Ping timeout: 240 seconds] 10:21 -!- Highway62 is now known as Highway61 10:22 -!- mrostecki [mrosteckim@gateway/shell/matrix.org/x-kbccsswkjxvcucoe] has joined #bitcoin-core-dev 10:22 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-czrtxzzkgklghjat] has joined #bitcoin-core-dev 10:22 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-exnzviktmkgochsp] has joined #bitcoin-core-dev 10:22 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-cpieoczekxvjpqlj] has joined #bitcoin-core-dev 10:22 -!- infamously[m] [infamously@gateway/shell/matrix.org/x-tbndpauwqrrcbpky] has joined #bitcoin-core-dev 10:26 -!- someone235 [uid419897@gateway/web/irccloud.com/x-juugkzenlmbvmjsk] has quit [Quit: Connection closed for inactivity] 10:34 -!- Highway61 [~Thunderbi@67.215.228.90] has quit [Remote host closed the connection] 10:35 -!- Highway61 [~Thunderbi@67.215.228.90] has joined #bitcoin-core-dev 10:35 -!- Evel-Knievel [~Evel-Knie@188.189.113.122] has quit [Ping timeout: 256 seconds] 10:36 -!- Evel-Knievel [~Evel-Knie@188.188.112.5] has joined #bitcoin-core-dev 10:38 < jonatack> cfields: upgraded from 11.0.0-++20200708111116+1f84ace3c72-1~exp1~20200708091733.3345 to 11.0.0-++20200709111134+dc4a6f5db4f-1~exp1~20200709091753.3347 and the warning is gone. 10:42 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 10:42 < sipa> chased goose is best goose 10:42 < jonatack> :D 10:42 < cfields> jonatack: heh, well that's rather unsatisfying 10:47 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Remote host closed the connection] 10:47 -!- Evel-Knievel [~Evel-Knie@188.188.112.5] has quit [Ping timeout: 240 seconds] 10:47 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 10:55 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Ping timeout: 256 seconds] 11:00 -!- rawtaz1 [~rawtaz@185.244.214.217] has quit [] 11:02 -!- zaff [~zaff@d111-50.icpnet.pl] has joined #bitcoin-core-dev 11:06 < cfields> jonatack: igoring all that, thanks for jumping through hoops to test :) 11:14 < jeremyrubin> #proposedmeetingtopic small clarification on the goals of the mempool project (cap at 5 mins meeting time) 11:18 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 11:18 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 11:18 -!- vincenzopalazzo [~vincent@153.33.4.26] has joined #bitcoin-core-dev 11:20 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 11:21 -!- Xing`1 [~Xing`@185.189.114.11] has joined #bitcoin-core-dev 11:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:26 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd9db45c3ea1...2aaff4813cc3 11:26 < bitcoin-git> bitcoin/master fa6d5ab MarcoFalke: refactor: Remove unused BlockAssembler::pblock member var 11:26 < bitcoin-git> bitcoin/master 2aaff48 MarcoFalke: Merge #19283: refactor: Remove unused BlockAssembler::pblock member var 11:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19283: refactor: Remove unused BlockAssembler::pblock member var (master...2006-minerPblock) https://github.com/bitcoin/bitcoin/pull/19283 11:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:31 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 11:35 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Ping timeout: 240 seconds] 11:42 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 11:43 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 11:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:46 < bitcoin-git> [bitcoin] promag opened pull request #19476: wip, rpc: Add mempoolchanges (master...2020-07-rpc-mempoolchanges) https://github.com/bitcoin/bitcoin/pull/19476 11:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:53 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:54 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 11:54 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:55 < promag_> instagibbs: #19476 11:55 < gribble> https://github.com/bitcoin/bitcoin/issues/19476 | wip, rpc: Add mempoolchanges by promag · Pull Request #19476 · bitcoin/bitcoin · GitHub 11:55 < instagibbs> promag_, yeah saw that 11:56 < instagibbs> can someone give shuckc voice? 11:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Disconnected by services] 11:56 -!- promag_ is now known as promag 11:56 < sipa> shuckc voice? 11:57 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:57 < instagibbs> i am not irc wizard, he says he cannot say anything here 11:57 < achow101> pretty sure you need to be registered 11:57 < instagibbs> ah ok 11:57 < aj> yeah 11:57 < aj> register with nickserv 11:58 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev 11:58 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Remote host closed the connection] 11:59 < wumpus> there should be no reason to deal out voice manually here, it's not a +m channel, but yes, registering with nickserv is required 11:59 < instagibbs> he's not registered, mystery solved 11:59 < MarcoFalke> Can someone edit the topic to say that register with nicksers is needed? 11:59 < wumpus> FWIW we've tried to remove that requirement many times and every time immediately some spam appeared 11:59 < MarcoFalke> I am not an IRC wizard either and I was muted at least twice in a meeting and didn't notice 12:00 < wumpus> I've been caught by that as well the feedback is pretty bad 12:00 < troygiorshev> we don't have +r though, so why is that happenin? 12:00 < shuckc> better? 12:00 < wumpus> shuckc: yes 12:00 < luke-jr> MarcoFalke: not sure topic change will help that.. 12:00 < instagibbs> shuckc, see you 12:00 < luke-jr> MarcoFalke: especially if you don't notice the error that your msg didn't go 12:00 < promag> meeting? 12:00 < achow101> meeting? 12:00 < wumpus> #startmeeting 12:00 < MarcoFalke> ahoi 12:00 < lightningbot> Meeting started Thu Jul 9 19:00:52 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < hebasto> hi 12:00 < achow101> hi 12:00 < troygiorshev> hi 12:01 < jnewbery> hi 12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr 12:01 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2 12:01 < jb55> hi 12:01 < fjahr> hi 12:01 < amiti> hi 12:01 < luke-jr> ih 12:01 < promag> hi 12:01 < kanzure> hi 12:01 < jonasschnelli> hi 12:01 < jeremyrubin> hola 12:02 < gwillen> hi 12:02 < cfields> hi 12:02 < sipa> hi 12:02 < wumpus> one proposed meeting topic: small clarification on the goals of the mempool project (jeremyrubin) 12:02 < wumpus> any last minute topics? 12:02 < phantomcircuit> hi 12:02 < sipa> another short one: can we drop gcc 4.8? 12:02 -!- gzhao408 [49fcfb03@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 12:03 < wumpus> ok 12:03 < instagibbs> proposed topic: new zmq notifications, or something else https://github.com/bitcoin/bitcoin/pull/19462#issuecomment-656140421 and https://github.com/bitcoin/bitcoin/pull/19476 12:03 < luke-jr> sipa: not sure that's a good meeting topic; it just needs someone to investigate distros? 12:03 < ariard> hi 12:03 < elichai2> hu 12:04 < wumpus> #topic High priority for review 12:04 < MarcoFalke> can i haz #19386 12:04 < achow101> #19325 pls 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/19386 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (server) by MarcoFalke · Pull Request #19386 · bitcoin/bitcoin · GitHub 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/19325 | wallet: Refactor BerkeleyDatabase to introduce DatabaseBatch abstract class by achow101 · Pull Request #19325 · bitcoin/bitcoin · GitHub 12:04 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 13 blockers, 1 bugfix, 3 chasing concept ACK 12:04 < wumpus> please don't add any more before removing any xD 12:04 < jamesob> hi 12:04 < ariard> you can drop #18787, after talking with few people, a libstandardness would be more accurate 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/18787 | wallet: descriptor wallet release notes and cleanups by achow101 · Pull Request #18787 · bitcoin/bitcoin · GitHub 12:04 -!- pinheadmz1 [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 12:05 < ariard> #18797 sorry 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/18797 | Export standard Script flags in bitcoinconsensus by ariard · Pull Request #18797 · bitcoin/bitcoin · GitHub 12:05 < jeremyrubin> removing #18191 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/18191 | Change UpdateForDescendants to use Epochs by JeremyRubin · Pull Request #18191 · bitcoin/bitcoin · GitHub 12:05 -!- meshcoll- [meshcollid@gateway/shell/ircnow/x-mckvnhdqwkgowycq] has quit [Quit: ZNC 1.7.5 - https://znc.in] 12:06 < jonatack> hi 12:06 < promag> please see #19033, its for 0.20.1 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/19033 | http: Release work queue after event base finish by promag · Pull Request #19033 · bitcoin/bitcoin · GitHub 12:06 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-otyqznegmsqkmiol] has joined #bitcoin-core-dev 12:06 < wumpus> ariard, achow101 done 12:07 < wumpus> jeremyrubin: ok 12:07 < luke-jr> would be nice to get the build tarballs fixed finally too <.< 12:07 < meshcollider> hi 12:08 < pinheadmz1> hi 12:09 < wumpus> #topic clarification on the goals of the mempool project (jeremyrubin) 12:09 < jeremyrubin> Yeah just quick; 12:10 < jeremyrubin> So I think that there's some confusion or at least co-mingling of concerns based on how I've presented things 12:10 -!- ryanofsky_ [russ@jumpy.yanofsky.org] has left #bitcoin-core-dev [] 12:10 -!- ryanofsky [russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev 12:10 < jeremyrubin> A lot of the motivation is to reduce the memory usage in the mempool 12:10 < jeremyrubin> and to better bound the algorithmic complexity on functions 12:11 < jeremyrubin> So that one day, maybe, we could lift some restrictions (e.g., descendents) 12:11 < jeremyrubin> It's less so "make mempool faster now" performance motivation. 12:12 < wumpus> ok good to know 12:12 < jeremyrubin> In a lot of cases I think it would be fine to accept a *slower* score on some benchmark (or at least the same) when the goal of the PR is reducing memory 12:12 < jeremyrubin> especially in cases where there may be a distant invariant which is currently protecting us from a "crash the network" style DoS 12:12 < luke-jr> if those are the goals, I wonder if it might make sense to move complexity into the miner 12:13 < wumpus> we could have benchmarks that measure memory usage I suppose 12:13 < luke-jr> but that could interfere with compact blocks 12:13 < jeremyrubin> luke-jr: this does make sense for certain things. 12:13 < luke-jr> I wonder if it'd be possible to support a build without mining support that performs better 12:14 < jeremyrubin> I think one of the things that is difficult in particular is that we don't have a great set of adversarial benches for the mempool 12:14 < jeremyrubin> And you need both whole-system and unit tests for the functions 12:14 < wumpus> I think there's something of a conflict there, miners want the block selection to be as fast as possible, while other node users would want to reduce memory usage for the mempool as much as possible 12:14 < jeremyrubin> And both asymptotic and bounded size 12:14 < cfields> wumpus: +1 12:15 < luke-jr> wumpus: by making mining build-time-optional, we could possibly get both cheaply? 12:15 < ariard> I'm not sure about reducing the memory usage, what the relation between size of your mempool and perf of fee estimation ? 12:15 < luke-jr> I wonder if there's a way to change class sizes at runtime in C++ 12:16 < jeremyrubin> Reducing memory usage is related to DoS primarily 12:16 < wumpus> that's kind of annoying for testing but yes 12:16 < jeremyrubin> So the goal is to eliminate the class of vuln 12:16 < luke-jr> jeremyrubin: eh? users can always adjust their mempool size 12:16 < jeremyrubin> I don't care about performance here that much, even a 2x slower mempool with less DoS surface is probably fine 12:16 < wumpus> it doesn't help if only the miners would have the vulnerability though 12:16 < sipa> mempool size _predictability_ is a DoS concern 12:16 < jeremyrubin> luke-jr: no for the algorithms themselves 12:16 < luke-jr> reducing mem usage would just mean more txs per MB 12:17 < jeremyrubin> not for the mempool size itself 12:17 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:17 < ariard> I think there is a confusion there with memory usage of caching data structure for update and overall mempool size 12:17 < sipa> e.g. improving average memory usage on average, but worsening it under a particular edge case might constitute a vulnerability 12:17 < jeremyrubin> Mostly fixing short-lived allocations 12:17 < nehan> jeremyrubin: what is your expected memory usage improvement? 12:17 < luke-jr> sipa: but there's no vuln with zero mempool… 12:18 < jeremyrubin> nehan: it's a project with a bunch of algorithm improvements based on epochs for traversal instead of sets 12:18 < aj> (5min cap exceeded fwiw) 12:18 < jeremyrubin> ah yeah didn't mean to turn this into an ordeal, just trying to clarify 12:19 < luke-jr> not like we have any other topics? 12:19 < sipa> perhaps just document this as a summary on the relevant PRs? 12:19 < jeremyrubin> happy to move on if there's other things to discuss 12:19 < sipa> unless it already is 12:19 < wumpus> luke-jr: we do, sipa had a topic 12:19 < luke-jr> oh 12:19 < sipa> nothing important 12:19 < luke-jr> right 12:19 < wumpus> #topic can we drop gcc 4.8 (sipa) 12:19 < MarcoFalke> why? 12:19 < wumpus> just something to annoy fanquake 12:19 < wumpus> :) 12:19 < luke-jr> lol 12:19 < cfields> lol 12:20 < sipa> so, i was looking at #18086 again 12:20 < gribble> https://github.com/bitcoin/bitcoin/issues/18086 | Accurately account for mempool index memory by sipa · Pull Request #18086 · bitcoin/bitcoin · GitHub 12:20 < sipa> and was trying to make the accounting allocator not track copies of containers, which is a feature of the C++11 allocator infrastructure 12:20 < wumpus> I *really* think we should wait with bumping gcc versions until c++17 requirement 12:20 < sipa> but it seems gcc 4.8 ignores it or otherwise fails to implement it correctly 12:20 < wumpus> which isn't too far away, just one major version 12:20 < sipa> yeah 12:21 < luke-jr> sipa: not the end of the world if it's wrong? 12:21 < sipa> but i've just noticed at appveyor also fails at it :s 12:21 < sipa> luke-jr: could cause UB 12:21 < luke-jr> hmm 12:21 < sipa> if used in totally reasonable ways 12:21 < sipa> (but probably not in my actual PR) 12:21 < wumpus> not that I'm opposed to bumping it sooner if it's eally required for something, but it seems a waste of time to discuss minor version bumps if a big one is around the cornr :) 12:21 < luke-jr> when C++20? :p 12:22 < wumpus> in 2025 12:22 * luke-jr found C++20 to be required for totally obvious/expected features the other day :/ 12:22 < sipa> luke-jr: hard to talk about things that don't exist 12:22 < cfields> luke-jr: get sipa to backport for you like Span :p 12:22 < luke-jr> cfields: can't backport syntax 12:22 < MarcoFalke> Only 3.6 months till branch off: https://github.com/bitcoin/bitcoin/issues/18947 12:23 < luke-jr> struct type var = { .a = 1, .b = 2 } 12:23 < jnewbery> sipa: can you #ifdef support for accounting allocators for only certain versions of gcc until we move to c++ 17? 12:23 < wumpus> jnewbery: +1! 12:23 < sipa> jnewbery: ugh 12:23 < aj> luke-jr: omg, don't tease things like that 12:23 < sipa> that's horrendous 12:23 < luke-jr> aj: it's common C99, no clue why C++ forbids it :/ 12:24 < cfields> luke-jr: juse use unnamed initializers ? 12:24 < luke-jr> cfields: but the whole point is the names! 12:24 < wumpus> I mean, accurate memory accounting is nice but not critical I suppose, not enough reason to really forbid building on a platform 12:24 < luke-jr> cfields: I ended up putting defaults for every member, and just setting the ones I care about after init 12:25 < sipa> wumpus: it would mean ifdefs all over to maintain to old heuristics for every data structure, plus a accounting based one 12:25 < luke-jr> https://github.com/bitcoin/bitcoin/pull/19463/files#diff-b2bb174788c7409b671c46ccc86034bdR291 12:25 < sipa> so i guess i'd just wait instead 12:25 < wumpus> anyhow according to #16684 the minimum gcc version will go to 8.3 12:25 < gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub 12:25 < sipa> or try to minimize the risk of copying 12:25 < cfields> sipa: can you point to exactly what old gcc gets wrong? I'm just curious to see. 12:26 < jnewbery> sipa: ah ok. If it's super invasive to do, then not worth it 12:26 < sipa> cfields: have a container with an accounting allocator, encapsulated in some class 12:26 < sipa> return a copy of it for public consumption 12:26 < wumpus> is changing this really urgent or can it wait until after 0.21? 12:26 < sipa> now any changes to that copy need to lock the origin datastructure's accounting variable 12:27 < luke-jr> 8.3 sounds pretty recent; is it already a sure thing major distros will have it in their stable releases? 12:27 < sipa> because they're shared 12:27 < MarcoFalke> gcc 7 is enough: https://github.com/bitcoin/bitcoin/pull/19183/files#diff-0c8311709d11060c5156268e58f5f209R14 12:27 < wumpus> MarcoFalke: okay maybe I'm misreading the issue then 12:27 < aj> 8.3 is in debian stable as the default gcc, only gcc 6 in oldstable 12:28 < luke-jr> aj: RHEL tends to be the bottleneck 12:28 < wumpus> in any case there is going to be a large bump 12:28 < MarcoFalke> sipa: Maybe rebase to see if msvc can compile it with C++17. If not, there is something else to look into first anyway. Pretty sure the 3 months will pass quickly ;) 12:28 < aj> luke-jr: it has software collections now so you get new gcc/clang on old rhel pretty easy 12:28 < sipa> RHEL8 has gcc 8.2 12:28 < luke-jr> aj: oh! 12:29 < sipa> RHEL7 uses gcc 4.8 by default 12:29 < luke-jr> do we care about old stables now? 12:29 < sipa> (we've strayed a bit from the topic, but that's ok unless someone has something else) 12:30 < aj> https://www.softwarecollections.org/en/scls/rhscl/devtoolset-8/ -- gcc 8 for rhel 6 and 7 12:30 < instagibbs> mempool delta notifications topic 12:30 < wumpus> can always cross-compile anyway 12:30 < luke-jr> wumpus: that's a bit much for most users 12:30 < wumpus> #topic mempool delta notifications (instagibbs) 12:30 < cfields> sipa: I was under the impression you weren't supposed to inherit from std::allocator in c++11. 12:31 < cfields> ok, will look more after the meeting. 12:31 < instagibbs> Ok, so recently I wrote a one-off zmq notification for mempool evictions, which are currently not covered. Other people have more exntensive ideas: https://github.com/bitcoin/bitcoin/pull/19476 12:31 < instagibbs> shuckc, can you speak to motivation/usage? 12:31 < wumpus> luke-jr: maybe, it's not that much more difficult, especially nowadays with the extreme availability of VMs etc 12:31 < sipa> cfields: ah, i can try avoiding that 12:31 < instagibbs> promag also made a WIP mempool delta RPC as another possible option https://github.com/bitcoin/bitcoin/pull/19476 12:32 < cfields> sipa: no idea if that's useful, need to spend a whole lot more time understanding what you're doing :) 12:32 < shuckc> We track a huge number of wallets, keeping mempool contents synchronised is tricky given incomplete notifications, and difficult to sychronise between api and zmq notifications 12:33 < shuckc> seems like an opportunity to cover off a lot of the edge cases in one go 12:33 < instagibbs> so ideally you could getrawmempool like once, then use zmq notifications to track delta, then maybe call getrawmempool when something drops for whatever reason, and be able to figure out "where" in that notification stream the snapshot is from 12:33 < luke-jr> instagibbs: you linked the same PR twice 12:33 < instagibbs> oh woops 12:34 < instagibbs> https://github.com/bitcoin/bitcoin/pull/19462#issueacomment-656140421 12:34 < luke-jr> instagibbs: ZMQ is very unreliable.. 12:34 < wumpus> instagibbs: that makes sense 12:34 < wumpus> no, ZMQ is not very unreliable 12:34 < instagibbs> sure luke-jr so alternative would likely look like promag pr i linked 12:34 < instagibbs> maybe long polling 12:34 < wumpus> only in pretty extreme circumstances it sometimes drops a packet 12:35 < sipa> ZMQ has no reliability _guarantees_ 12:35 < wumpus> and in that case there needs to be a way to resynchronize, anyway, as instagibbs says 12:35 < luke-jr> wumpus: I used it for low traffic on a reliable network, and it still lost stuff regularly 12:35 < sipa> but absent overflow conditiins, it is very reliable 12:35 < wumpus> notifications have sequence numbers to be able to detect that 12:35 < sipa> luke-jr: hmm, ok 12:35 < instagibbs> and avoiding "lots" of getrawmempools I guess is hte biggest goal 12:35 < wumpus> sipa: yes, in the general case it is very reliable 12:35 < promag> the biggest problem if you have to take the client offline for a bit 12:35 < shuckc> ZMQ generally work as well as any other pubsub system so long as you have the high watermark set sufficiently high, and you are not trying to consume slower than the publisher is producing. I don't see that as a particular obstancle 12:36 < wumpus> unless your client is not consuming the notifications reliably: there can't be an infinite buffer 12:36 < wumpus> (unless you'd spool to disk or something like that) 12:36 < promag> shuckc: zmq pub doesn't hold msg if client is offline. 12:36 < wumpus> but I don't think adding yet another notifications system with mail-like reliablity is really what we want 12:37 < shuckc> if your client goes away, you are going to have to hit getrawmempools for sure. but would like to avoid those calls in the general case as big result set (even when brief) 12:37 < wumpus> I mean there's mq systems like rabbitmq that guarantee 100% reliability 12:37 < promag> the approach in #19476 avoids periodic getrawmempools 12:37 < gribble> https://github.com/bitcoin/bitcoin/issues/19476 | wip, rpc: Add mempoolchanges by promag · Pull Request #19476 · bitcoin/bitcoin · GitHub 12:38 < jnewbery> why not have ZMQ log every txid it sends a notification for along with seq number. If your client detects a drop it can consult the log and query the mempool for that txid? 12:38 < wumpus> but I mean, how many of these things do you want to integrate with 12:38 < instagibbs> promag, your rpc could be maybe generalized into block hash announcements too, connect/disconnect 12:38 < instagibbs> jnewbery, it has as seq number 12:38 < instagibbs> but right now it's a hodgepodge of endpoints 12:38 < wumpus> yes, it has a seq number 12:38 < instagibbs> and missing eviction entirely 12:39 < jnewbery> right, we're talking about two things here. Let's assume that your eviction PR is merged 12:39 < wumpus> all the zmq endpoints have seq numbers 12:39 < shuckc> if eviction PR is merged, the remaining issues are: 12:39 < wumpus> I'mnot sure these are actually useful because people keep complaining about this 12:39 < promag> wumpus: you don't know at what sequence corresponds a getrawmempool response 12:40 < wumpus> no, indeed you don't 12:40 < shuckc> I cannot know for sure if the txn hash broadcasts are adds or block removals, as they don't specify, and I can't for sure know how it lines up with the results of getrawmempool 12:40 < jnewbery> for reliability, ZMQ can log seq_num:txid to file every time a notification is sent. If a client detects a missing seq_num, you consult the log and query the mempool rpc for that file 12:40 -!- Evel-Knievel [~Evel-Knie@188.189.112.16] has joined #bitcoin-core-dev 12:40 < wumpus> zmq logging to file? taht sounds really at odd with low-latency 12:40 < jnewbery> *for that txid 12:40 < luke-jr> wumpus: mkfifo ☺ 12:40 < wumpus> luke-jr: fifo is one to one, not one to many 12:40 < luke-jr> not sure why ZMQ is involved at that point lol 12:40 < luke-jr> true 12:41 < wumpus> luke-jr: if only UNIX had a one to many notification mechanism 12:41 < wumpus> except for mail 12:41 < luke-jr> dbus? 12:41 < sipa> wumpus: oh you can have many writers and many readers for one fifo just fine ;) and no guarantee which write goes to which read 12:41 < aj> wumpus: wall(1) :) 12:41 * luke-jr is not sure dbus actually has this 12:41 < luke-jr> aj: lol 12:41 < wumpus> no, dbus doesn't have it either 12:41 -!- shuckc [51bb0813@19.8.187.81.in-addr.arpa] has quit [Remote host closed the connection] 12:41 < wumpus> dbus is one to one, it has no realible multi consumer broadcase 12:42 < luke-jr> I suppose you could just use a tmpfs file 12:42 < wumpus> it's a difficult issue in general 12:42 < wumpus> because some consumer might always be lagging 12:42 < luke-jr> and punch holes at the start as desired 12:42 < wumpus> this can potentially result in infinitely much storage needed 12:42 < luke-jr> or store to disk and let Linux's buffers handle it 12:42 < wumpus> rabbitmq is pretty good if you really need this 12:44 -!- shuckc [51bb0813@19.8.187.81.in-addr.arpa] has joined #bitcoin-core-dev 12:45 < instagibbs> Well aside from fixing infinite buffer problems, I think it'd be good to improve where we can. When there's a failure there's always the fallback of getrawmempool for example 12:45 < jnewbery> wumpus: zmq already logs (if -logging=zmq is enabled). It just doesn't log the seq num, so it's not easy for a client to tell which messages were dropped 12:45 < instagibbs> I was joking that you could also do minisketch for set reconciliation of mempool views 12:45 < sipa> haha 12:45 < luke-jr> jnewbery: I'm not sure we want to encourage software to parse debug.log … 12:45 < instagibbs> zmq to keep difference small ;) 12:46 < wumpus> jnewbery: I don't think clients can ever know what message is dropped; usually, missing a sequnence number means having to resyncronize in some way (e.g.e query the entire mempool) 12:46 < wumpus> luke-jr: exactly 12:46 < wumpus> I don't think 'parse the log' is a good option, though it serves one-to-many notification perfectly 12:46 < wumpus> mq is essentially a log 12:46 < wumpus> until your disk is full 12:46 < luke-jr> a dedicated, well-defined-format log might be okay 12:47 < wumpus> it's also a high latency option but that might not matter 12:47 < luke-jr> but something needs to do hole-punching to clean it up before disk fills 12:47 < luke-jr> wumpus: why is it high latency? 12:47 < wumpus> yes, but if you do tha, some clients might miss messages 12:47 < sipa> luke-jr: bitcoind will already shut down when disk is full 12:47 < sipa> :) 12:47 < luke-jr> depends on who does it 12:47 < wumpus> unless they tell you they read up until that far 12:47 < luke-jr> sipa: yes, but you don't want that 12:47 < wumpus> luke-jr: because disk/block devices are slow, compared to networking, latency wise 12:48 < luke-jr> wumpus: Linux at least has buffers 12:48 < wumpus> even with that 12:48 < luke-jr> :/ 12:48 < luke-jr> the write/read won't even need to hit disk 12:48 * luke-jr wonders if you can tell Linux to never flush to disk unless it has to 12:48 < luke-jr> per-device* 12:48 < luke-jr> per-file would also be nice :P 12:49 < wumpus> yes, there's an option for that afaik, but it also means in case of power loss... 12:49 -!- gzhao408 [49fcfb03@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 12:49 < jnewbery> shuckc: it sounded like you were going to mention more issues. Was there anything else? 12:49 < wumpus> reliable delivery of messages to multiple consumers is a difficult topic 12:50 < sipa> we need a blockchain 12:50 < wumpus> sipa: :-) 12:50 < instagibbs> so i think the biggest oustanding issue(if evictions are announced and we're ok with drops once i na while) is being able to line up getrawmempool results with the notifications 12:50 < wumpus> yes, at least the blockchain always allows going back i time... well unless pruning 12:50 < wumpus> pruning is kind of the 'what if not all consumers have seen this yet' problem 12:50 < shuckc> the sequence number on the response to getrawmempool 12:51 < shuckc> obviously has backward compatibility concerns, and other suggestions? 12:51 < sipa> shuckc: hmm? 12:51 < luke-jr> wumpus: there is an option for that? what? :o 12:51 < instagibbs> sipa, he wants to know where the mempool "snapshot" came from 12:51 < sipa> does getrawmempool report a sequence number now? 12:51 < instagibbs> no 12:51 < wumpus> it doesn't 12:51 < shuckc> no, I'm suggeting it should 12:51 < sipa> and adding one would help? 12:51 < shuckc> yes 12:51 < sipa> oh, ok 12:52 < instagibbs> so you don't know if the getrawmempool result is stale or from "future" wrt zmq reports 12:52 < sipa> what would be the reason not to? 12:52 < shuckc> because you can't tell which delta(s) have already been added 12:52 < wumpus> I guess it could prove that there were no updates in between 12:52 < sipa> adding new fields has no backward compatibility concerns 12:52 < instagibbs> sipa, I think you'd have to add *all* the zmq notification seq numbers 12:52 < sipa> ah 12:52 < instagibbs> well it's an array result ; 12:52 < instagibbs> ;) 12:52 < promag> can bnly be added if verbose=true in getrawmempool 12:52 < instagibbs> but like I said I think optional arg -> json object 12:52 < wumpus> I wonder why every zmq message has its own sequence number 12:52 < wumpus> couldn't it be just one increasing atomic? 12:52 < shuckc> unless you have one single notifier that you use for all the messages you need to sync with 12:52 < instagibbs> wumpus, it's a local member of hte notification, for whatever reason 12:53 < promag> wumpus: a client knows if he missed anything 12:53 < wumpus> promag: oh, true 12:53 < shuckc> it's only a mess if need to track lots of notifiers 12:53 < wumpus> yes, makes sense, a client is generally interested in only a subset of message kinds 12:53 < instagibbs> shuckc, shouldn't be too bad, you just grab the one you care about 12:53 < wumpus> so a global sequence number would be useless 12:54 < promag> wumpus: not really, that number should be exposed in both rpc response and zmq message 12:54 < wumpus> in any case getmempool would only need the mempool related numbers... 12:54 < promag> but I'm not fond of that.. 12:54 < wumpus> it seems like some kind of layer violation 12:54 < wumpus> having RPC query ZMQ 12:54 < promag> because as a client, you need to use rpc AND zmq 12:54 < wumpus> yes 12:55 < instagibbs> otherwise you need to somehow ask for unique snapshot 12:55 < promag> hence my draft PR 12:55 < instagibbs> of the mempool 12:55 < instagibbs> but yes, it's a light violation at least 12:55 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds] 12:55 < phantomcircuit> shuckc, zmq can and will silently drop messages, unless you have sequence numbers in the application layer you cannot detect that 12:55 < shuckc> My suggestion includes connectblock and disconnect block notifications on the same new channel, because they allow you to keep your local mempool up to date and equally you need to know where in the stream of deltas they arrived 12:56 < wumpus> of course, that could be worked around by having both RPC and ZMQ query another source for sequence numbers 12:56 < jnewbery> how about if the mempool itself had a seq number that is incremented on every add/remove? 12:56 < wumpus> right 12:56 < instagibbs> jnewbery, that's promag's pr pretty much-ish 12:56 < wumpus> I think that would make sense 12:57 < instagibbs> 3 minutes 12:57 < wumpus> so +1 on jnewbery/promag's idea then 12:57 < shuckc> with promags suggestion, bitcoind has to keep state/buffer for each consumer, the zmq model makes it state-less, and promag you also need to poll for new messages which is something of a step backwatfs 12:58 < wumpus> I didn't understand it like that 12:58 < promag> note that in my PR, the "stream" will be upper bounded in size, so no OOM concerns 12:58 < luke-jr> shuckc: not if he adds longpolling 12:58 < wumpus> the mempool itself would keep the seq number 12:58 < wumpus> not per consumer 12:58 < promag> shuckc: ill add long poll 12:58 < wumpus> it's kind of strange if different consumers have differnt seq ids 12:58 < shuckc> do any other commands use long polling? 12:58 < wumpus> because this is global state we're exposing 12:58 < luke-jr> GBT 12:58 < phantomcircuit> wumpus, if zmq is using a global sequence number for all messages, i'd suggest just adding that to rpc as a header or something 12:58 < promag> shuckc: yes 12:58 < instagibbs> getblocktemplate <--- GBT 12:59 -!- Evel-Knievel [~Evel-Knie@188.189.112.16] has quit [Ping timeout: 272 seconds] 12:59 < promag> I don't like longpoll that much tbh, at least in json rpc 12:59 < promag> especially because of libevent, timeouts etcetc 12:59 < promag> but "poll and wait up to n secs" if fine imo 12:59 < wumpus> I don't think adding a different notification mechanism will really solve the 'clients could stop consuming and keep behind' problem 13:00 < luke-jr> promag: same thing? :P 13:00 < wumpus> it would mean accumulating in memory in that case? 13:00 < promag> luke-jr: n secs < timeoud (: 13:00 < promag> wumpus: yes 13:00 < fjahr> I guess I am the hammer that sees nails everywhere, but how about a hash (muhash) for the mempool states instead of a sequence number? but not sure i grasp the problem completely yet... 13:00 < promag> but thats's fine 13:00 < luke-jr> fjahr: then you need to log the hash.. 13:00 < promag> if the client doensn't pull the stream, the stream will be terminated 13:00 < wumpus> no, I don't think that's fine, if there's no limit a client could forget to connect and fill your memory entirely 13:01 < instagibbs> fjahr, even more ridiculous than my minisketch idea ;P 13:01 < wumpus> promag: that's just another "lose notifications" then 13:01 < fjahr> hehe 13:01 < luke-jr> wumpus: it's one thing to begin dropping stuff after N minutes of downtime; another to lose them randomly as a normal event 13:01 < wumpus> reliable notification is really a non-trivial issue :) 13:01 < promag> wumpus: no, the stream will be terminated, the client starts over and gets a fresh stream 13:01 < wumpus> in any case, it's time 13:02 < aj> instagibbs: (minisketch is a great idea!) 13:02 < wumpus> #endmeeting 13:02 < lightningbot> Meeting ended Thu Jul 9 20:02:11 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 13:02 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-09-19.00.html 13:02 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-09-19.00.txt 13:02 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-09-19.00.log.html 13:02 < luke-jr> promag: maybe this should be part of getrawmempool? 13:02 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:02 < instagibbs> aj, just need the tool in -cli, I think :D 13:02 < shuckc> if the longpoll machinery all works, then I don't have any reason why not to use it. So long as it can be sequenced with repect to the getrawmempool calls and covers all the removals/additions cases 13:02 < promag> luke-jr: meh, let's not overload, at least for the momemnt 13:02 < wumpus> it has the same problems I think 13:03 < luke-jr> promag: well, they need to interact.. 13:03 < instagibbs> shuckc, I think the idea would be you'd replace getrawmempool entirely with this new call 13:03 < wumpus> it's another method to receive notifications but doesn't avoid any of the problems, the HTTP buffer can also be full 13:03 < promag> shuckc: you won't use getrawmempool anymore 13:03 < luke-jr> wumpus: forever buffer vs limited buffer vs no buffer 13:03 < shuckc> I kind of like that. getrawmempool could give the snapshot and then if you've got longpool flag then it continues to stream modifications 13:03 < wumpus> luke-jr: zmq has a limited buffer, like anything 13:03 < luke-jr> wumpus: not in my experience 13:03 < wumpus> you can even set it with some option 13:03 < promag> wumpus: you call "mempoolchanges " 13:04 < promag> wumpus: so you don't worry about http response size etc 13:04 < luke-jr> promag: s/stream id/last update id/ 13:04 < wumpus> what if it exceeds the number of entries then? 13:05 < promag> the concept is pretty much like postgres write-ahead-log and replication slots 13:05 < luke-jr> promag: and for timeout, the client can just disconnect? 13:05 < luke-jr> wumpus: then you need to get the entire mempool and start over 13:05 < promag> luke-jr: no, stream id - you can have multiple clients, each with their own stream 13:05 < luke-jr> (which is another reason to overload getrawmempool?) 13:05 < wumpus> exactly as with zmq notifications if you miss a sequence number 13:05 < luke-jr> promag: they shouldn't have separate streams 13:06 < luke-jr> wumpus: except you're less likely to miss one 13:06 < wumpus> I really don't see how a different notificatoin mechanism solves the underlying problems, but ok, if you belive so, go ahead 13:06 < wumpus> 'less likely' is no guarantee! 13:06 < promag> need to afk, please view my PR code, it's very small/simple 13:06 < luke-jr> wumpus: it doesn't need to be a guarantee to work well 13:06 < wumpus> if losing a notification is a critical issue, a smaller chance of it is better but still a critical problem 13:06 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:07 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:07 < luke-jr> it's not critical, just something you'd prefer to avoid 13:07 < instagibbs> hopefully not critical anywhere 13:07 < shuckc> I'll review it promag and see if it covers all our uses 13:07 < wumpus> how do you mean 'work well' then, not lose money for *most* users? 13:07 < luke-jr> wumpus: it's an optimisation 13:07 < luke-jr> you *could* always just getrawmempool constantly, but it'd be slow 13:07 < wumpus> you need to setup your client code to handle missing notifications in any case 13:08 < luke-jr> yes, and hopefully it won't happen often 13:08 < wumpus> you can increase the zmq buffer size for that 13:08 < instagibbs> miss message -> patch with getrawmempool-like response 13:08 < instagibbs> keep that infrequent, it's a win 13:08 < wumpus> people have been discussing this since 2012 or so since zmq notifications were added 13:09 < instagibbs> and yet, we don't have eviction notifications at all :P 13:09 < wumpus> I wish we never did fwiw 13:09 < instagibbs> understood though im sure it's tiring 13:09 < luke-jr> wumpus: admittedly I haven't used ZMQ since these problems, but it didn't work for me 13:09 < wumpus> it's only been like this every time 13:09 < wumpus> ZMQ IS UNRELIABLE 13:09 < wumpus> ITS USELESS 13:09 < wumpus> yeshh 13:09 < wumpus> like let's just remove it 13:09 < aj> could convert mempool entry's nTime to a monotonic clock, and use that as a sequence? "getrawmempool -- but only entries added since time X" maybe 13:09 < instagibbs> well, it's being used in the wild, SFYL 13:10 < instagibbs> LND uses it too 13:10 < instagibbs> (don't know why exactly, just does) 13:10 < wumpus> instagibbs: I know 13:10 < promag> wumpus: too late, sorry for that honestly X) 13:10 < wumpus> instagibbs: I know it's actually used by peple in production, but the discussions are always the same 13:10 < instagibbs> understood 13:10 < promag> #6103 :shame: 13:11 < gribble> https://github.com/bitcoin/bitcoin/issues/6103 | Add ZeroMQ notifications by promag · Pull Request #6103 · bitcoin/bitcoin · GitHub 13:11 < wumpus> sorry :) 13:11 < promag> cheers 13:11 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:12 < wumpus> I think it was like 'zmq is even used by high frequency traders and such it's probably useful for us' 13:12 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:13 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:13 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:14 -!- Evel-Knievel [~Evel-Knie@188.189.112.16] has joined #bitcoin-core-dev 13:14 < cfields> sipa: I suppose the old gcc issue is that the propagate_on_container_* aren't respected ? 13:15 < sipa> cfields: possibly 13:15 < sipa> but it looks like that 13:15 < wumpus> every time anyone mentions zmq it's: but it's unreliable!!! which is true, it's optimized for low latency, not reliability, all other mq products that historically were optimized for reliability, zmq intentionally made this trade-off 13:17 < jnewbery> In general, I don't think we should add yet another notification system to work around a supposed shortcoming in ZMQ. Then we just have an additional notification system to maintain 13:17 < wumpus> one other common reliable mq notification system nowadays is Apache Kafka 13:18 < jnewbery> if ZMQ is really unfit for purpose it should be removed and replaced 13:18 < wumpus> I agree 13:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 13:18 < instagibbs> If you waved away the getrawmempool thing, I think it's probably fine enough 13:19 < instagibbs> block notifications are very cheap to "heal", 300MB mempool is not 13:20 < cfields> sipa: from libstdc++ 4.8 release docs "23.2.1 General container requirements Partial Only vector and forward_list meet the requirements relating to allocator use and propagation." 13:20 < sipa> cfields: ah 13:25 < cfields> sipa: if it makes you feel any better, looks like support for all standard containers didn't exist until 6.x. 13:25 < instagibbs> jnewbery, so I think you'd still need to make a layer violation(or replace getrawmempool with set reconciliation protocol) to smoothly use zmq, even with logging backing. I think that's two complementary improvements. 13:26 < instagibbs> if you're going to have to use RPC, might as well use RPC? 13:26 < wumpus> instagibbs: I guess it could be cheaper by using some binary format for the mempool; but in practice, losing messages should be rae, when I still used zmq for some notificaiton system I don't remember ever losing a message, just make sure that's a thread in the client that keeps reading 13:27 < sipa> cfields: seems i may just need to give up on the no-propagate-on-copy, and add a big disclaimer 13:28 < cfields> sipa: that's really a shame. I remember spending a few days banging my head against the wall trying to make scoped_allocator_adaptor do something interesting. I now see that it was probably just quietly broken under the hood the whole time. 13:28 < wumpus> in any case, adding a sequence number to getrawmempool to that the full dump can be reconciled with updates makes sense 13:28 < wumpus> independent of the notification system 13:28 < instagibbs> wumpus, yeah, just saying aside from mempool sync protocol I think we need to tell the consumer where raw mempool responses work 13:29 -!- pinheadmz1 [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: WeeChat 2.8] 13:30 < sipa> cfields: also now i remember the reason why i made it inherit from std::allocator 13:30 < sipa> old libstdc++ doesn't implement allocator_traits, so you need all dozen trivial functions and types on it 13:30 < cfields> oh, heh, yeah, that'd be a problem. 13:30 < sipa> it's just inconvenient 13:31 < wumpus> it's much more practical to have a system that can handle (but generally doesn't need to handle) going out of sync than something that can guarantee 100% delivery, so if adding a update sequence # to the mempool solves that that'd be preferable imo 13:31 < sipa> cfields: https://github.com/bitcoin/bitcoin/pull/18086/commits/378bbcd271734665b973351bf3862b3943b10ffc 13:31 < instagibbs> ok! 13:34 < cfields> sipa: when I said "you're not supposed to inherit from std::allocator in c++11", I just meant that IIRC you're supposed to lean on allocator_traits instead. So yeah, without that, I see why you just inherited. 13:35 < cfields> sipa: but given that support is missing from the containers themselves, I doubt that change will change anything for the better :( 13:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:36 < cfields> sipa: also, nit, isn't std::allocator guaranteed stateless? Can't you just call its static members? 13:37 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 13:41 < cfields> nm, obviously not. 13:41 -!- zaff [~zaff@d111-50.icpnet.pl] has quit [Ping timeout: 258 seconds] 13:52 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:54 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #19478: Kill mapLinks data structure in Mempool (master...epoch-mempool-clean-split-3) https://github.com/bitcoin/bitcoin/pull/19478 13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:58 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:00 -!- Xing`1 [~Xing`@185.189.114.11] has quit [] 14:02 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Remote host closed the connection] 14:03 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 14:06 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Remote host closed the connection] 14:06 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 14:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 14:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 14:17 -!- shuckc [51bb0813@19.8.187.81.in-addr.arpa] has quit [Remote host closed the connection] 14:18 -!- Randolf [~randolf@184.70.10.189] has joined #bitcoin-core-dev 14:22 -!- KindOne1 [~KindOne@178.162.209.171] has joined #bitcoin-core-dev 14:27 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:29 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 14:29 -!- Randolf [~randolf@184.70.10.189] has quit [Quit: Leaving] 14:31 < cfields> llvm's lld (in master, not released) is complete enough as of this week to link a working bitcoind for macos from linux, without having to resort to building apple's custom ld64 :) 14:31 < cfields> jonatack: thanks for the motivation to build llvm today, I really wanted to test ^^ 14:32 < cfields> No idea how well at works, but "./bitcoind --help" works, at least. 14:34 < promag> cfields: nice, builds qt too? 14:35 < cfields> promag: heh, no clue. I didn't want to end up deep in qt link issues... 14:36 < cfields> I should though. This work is active on lld right now. Good time for us to be reporting issues/patches. 14:43 -!- lnostdal [~lnostdal@cable-84-43-233-231.mnet.bg] has quit [Ping timeout: 258 seconds] 14:45 -!- Evel-Knievel [~Evel-Knie@188.189.112.16] has quit [Read error: No route to host] 14:46 -!- Evel-Knievel [~Evel-Knie@188.189.112.16] has joined #bitcoin-core-dev 14:48 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Remote host closed the connection] 14:54 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 14:55 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 14:55 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:55 -!- lnostdal [~lnostdal@cable-84-43-233-231.mnet.bg] has joined #bitcoin-core-dev 15:06 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Remote host closed the connection] 15:07 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 15:07 < cfields> promag: yeah, it doesn't know how to find .tbd frameworks yet, so no qt. 15:07 < cfields> I'll check to see if that _should_ be working yet and report it upstream if so. 15:13 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 15:23 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Quit: Bye] 15:25 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 15:32 -!- IGHOR [~quassel@176.121.4.135] has quit [Read error: Connection reset by peer] 15:32 -!- marcoagner [~user@2001:8a0:6a5e:bd00:ffc1:99f7:23a:1565] has quit [Ping timeout: 244 seconds] 15:33 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 15:34 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 15:34 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 15:35 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 15:48 < phantomcircuit> wumpus, you can just go to the zmq docs and see that it's not reliable, it's all about "implementing patterns" to achieve some kind of reliability 15:48 < phantomcircuit> i've used it before but only with the knowledge that it's basically udp 15:50 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Quit: Leaving] 16:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:01 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-184-23.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:08 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:13 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 16:22 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 16:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 16:26 -!- Relis [~Relis@148.252.129.194] has quit [Ping timeout: 260 seconds] 16:33 -!- Relis [~Relis@85.255.234.58] has joined #bitcoin-core-dev 16:39 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 16:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:44 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 16:44 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 16:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:47 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:51 -!- jarthur [~jarthur@2605:6000:1019:48d9:349a:5444:c6c7:647c] has quit [] 16:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:00 -!- KindOne1 [~KindOne@178.162.209.171] has quit [] 17:09 -!- Relis [~Relis@85.255.234.58] has quit [Quit: This computer has gone to sleep] 17:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:21 < bitcoin-git> [bitcoin] freenancial opened pull request #19480: build: Only use `@` prefix for `echo` command in Makefiles (master...remove_at_sign_makefile) https://github.com/bitcoin/bitcoin/pull/19480 17:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:21 -!- Beetstra [~Beetstra@77.243.177.38] has joined #bitcoin-core-dev 17:23 -!- Relis [~Relis@85.255.234.58] has joined #bitcoin-core-dev 17:39 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 17:39 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 17:46 -!- jarthur [~jarthur@2605:6000:1019:48d9:349a:5444:c6c7:647c] has joined #bitcoin-core-dev 17:47 -!- Relis [~Relis@85.255.234.58] has quit [Quit: This computer has gone to sleep] 18:03 -!- Relis [~Relis@85.255.234.58] has joined #bitcoin-core-dev 18:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:03 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 18:05 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 18:05 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 18:12 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 18:12 -!- Relis [~Relis@85.255.234.58] has quit [Quit: This computer has gone to sleep] 18:13 -!- Relis [~Relis@85.255.234.58] has joined #bitcoin-core-dev 18:25 -!- murray_ [~murray@static.56.37.130.94.clients.your-server.de] has left #bitcoin-core-dev [] 18:25 -!- murrayn [~murray@unaffiliated/murrayn] has joined #bitcoin-core-dev 18:28 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 18:28 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 18:32 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 18:44 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 18:46 -!- mdunnio_ [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 18:48 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 18:50 -!- Luke [~Luke@bitnomial/staff/luke] has joined #bitcoin-core-dev 18:51 -!- mdunnio_ [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 18:56 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 19:01 -!- Relis [~Relis@85.255.234.58] has quit [Quit: This computer has gone to sleep] 19:18 -!- Highway61 [~Thunderbi@67.215.228.90] has quit [Ping timeout: 246 seconds] 19:22 -!- shesek [~shesek@5.22.128.126] has quit [Read error: Connection reset by peer] 19:22 -!- shesek [~shesek@5.22.128.126] has joined #bitcoin-core-dev 19:25 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 19:27 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 19:29 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 19:44 -!- diogorsergio [~diogorser@05401448.skybroadband.com] has quit [Ping timeout: 260 seconds] 19:56 -!- diogorsergio [~diogorser@054014e0.skybroadband.com] has joined #bitcoin-core-dev 19:58 -!- Luke [~Luke@bitnomial/staff/luke] has quit [Quit: sleep] 19:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 20:00 -!- Beetstra [~Beetstra@77.243.177.38] has quit [] 20:02 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 20:02 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 20:15 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 20:15 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 20:19 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:24 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 256 seconds] 20:25 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer] 20:26 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 20:28 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Remote host closed the connection] 20:28 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has joined #bitcoin-core-dev 20:28 -!- nik-j [~nik-j@072-239-128-183.res.spectrum.com] has quit [Remote host closed the connection] 20:30 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 20:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 20:34 -!- vasild_ is now known as vasild 20:53 -!- whartung1 [~whartung@84.39.116.180] has joined #bitcoin-core-dev 21:08 -!- Netsplit *.net <-> *.split quits: petezz4_, DougieBot5000, luke-jr, CodeShark___, Mercury_Vapor, dkrm, nullptr|, fanquake, qubenix, endogenic, (+206 more, use /NETSPLIT to show all of them) 21:08 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Max SendQ exceeded] 21:11 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-xakextsjllqfoobo] has quit [Ping timeout: 246 seconds] 21:11 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 21:14 -!- Netsplit over, joins: justinmoon, aj, waxwing, takinbo, meshcollider, _0x0ff, marcinja, RubenSomsen, digi_james, Jackielove4u (+47 more) 21:14 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-hlgxykdssqxqgbcb] has joined #bitcoin-core-dev 21:14 -!- Netsplit over, joins: kanzure, adam3us, frogar, tripleslash, go11111111111, Eliel, Anduck, da2ce7_, NicolasDorier, infamously[m] (+7 more) 21:14 -!- esotericnonsense [~esotericn@static.116.206.47.78.clients.your-server.de] has joined #bitcoin-core-dev 21:14 -!- Netsplit over, joins: berndj 21:14 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 21:14 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-wyvwkaodsnvypzae] has joined #bitcoin-core-dev 21:14 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 21:14 -!- Netsplit over, joins: harding, arik__, felixweis, amiti, fjahr, jonatack, lightningbot, michaelfolkson, BlueMatt, Nebraskka (+41 more) 21:14 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 21:14 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 21:14 -!- Netsplit over, joins: nickler, achow101, ghost43, moneyball, schmidty, fanquake, ajonas, CubicEarth, jeremyrubin, midnight (+54 more) 21:14 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-exnzviktmkgochsp] has quit [Ping timeout: 244 seconds] 21:15 -!- lesderid_ [~lesderid@anna.lesderid.net] has joined #bitcoin-core-dev 21:15 -!- Netsplit over, joins: jnewbery, Madars, aqua42, Zenton, rabidus, qubenix, ppisati, bosma, promag_, Mercury_Vapor (+3 more) 21:15 -!- drbrule [sid395654@gateway/web/irccloud.com/session] has joined #bitcoin-core-dev 21:15 -!- infamously[m] [infamously@gateway/shell/matrix.org/x-tbndpauwqrrcbpky] has quit [Ping timeout: 246 seconds] 21:15 -!- drbrule [sid395654@gateway/web/irccloud.com/session] has quit [Changing host] 21:15 -!- drbrule [sid395654@gateway/web/irccloud.com/x-aekdipbsimdsvche] has joined #bitcoin-core-dev 21:15 -!- peltre [sid268329@gateway/web/irccloud.com/x-hhkboztfjjqjctaj] has joined #bitcoin-core-dev 21:15 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-sofhgbgipqnwccsq] has joined #bitcoin-core-dev 21:16 -!- digi_james [sid281632@gateway/web/irccloud.com/x-acapbubtjyrfcjrf] has quit [Ping timeout: 245 seconds] 21:17 -!- Klox04 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev 21:17 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-yzbbwfcgdklrktij] has quit [Ping timeout: 260 seconds] 21:17 -!- amiti [sid373138@gateway/web/irccloud.com/x-ufqeiiiqpjmxxnfp] has quit [Ping timeout: 260 seconds] 21:17 -!- digi_james [sid281632@gateway/web/irccloud.com/x-qxgppfsjpuhvoxcs] has joined #bitcoin-core-dev 21:17 -!- prusnak [sid403625@gateway/web/irccloud.com/x-jkkdrhexfjeswscd] has quit [Ping timeout: 272 seconds] 21:18 -!- so [~so@unaffiliated/so] has quit [Ping timeout: 246 seconds] 21:18 -!- prusnak [sid403625@gateway/web/irccloud.com/x-gcivvuybaramuwjp] has joined #bitcoin-core-dev 21:19 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-wjisgovswawuiiap] has joined #bitcoin-core-dev 21:20 -!- amiti [sid373138@gateway/web/irccloud.com/x-xxenphispxqqcfhv] has joined #bitcoin-core-dev 21:22 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-kukqnmhlcpysjxii] has joined #bitcoin-core-dev 21:23 -!- so [~so@unaffiliated/so] has joined #bitcoin-core-dev 21:29 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 21:36 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 258 seconds] 21:38 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 21:41 -!- mrostecki [mrosteckim@gateway/shell/matrix.org/x-mfunmjkjdtsfhfrj] has joined #bitcoin-core-dev 21:41 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-mceojjdmcgxxvrfm] has joined #bitcoin-core-dev 21:41 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-vnobvuelrvelegtq] has joined #bitcoin-core-dev 21:41 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-yqzafokmnnbggzty] has joined #bitcoin-core-dev 21:42 -!- infamously[m] [infamously@gateway/shell/matrix.org/x-lfxftreahqdqphpb] has joined #bitcoin-core-dev 21:43 -!- vincenzopalazzo [~vincent@153.33.4.26] has quit [Ping timeout: 240 seconds] 21:45 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 21:45 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 21:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:46 < bitcoin-git> [bitcoin] fanquake pushed 16 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/cd32134bda3e...01c563708f32 21:46 < bitcoin-git> bitcoin/0.20 0596a6e MIZUTA Takeshi: util: Don't reference errno when pthread fails. 21:46 < bitcoin-git> bitcoin/0.20 c219d21 sachinkm77: build: improved output of configure for build OS 21:46 < bitcoin-git> bitcoin/0.20 5c7151a fanquake: gui: update Qt base translations for macOS release 21:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:46 < bitcoin-git> [bitcoin] fanquake merged pull request #19224: [0.20] Backports (0.20...0_20_1_backports) https://github.com/bitcoin/bitcoin/pull/19224 21:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:52 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 246 seconds] 21:55 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 22:09 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 22:09 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 22:20 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 260 seconds] 22:27 -!- Davterra [~tralfaz@104.200.129.62] has quit [Remote host closed the connection] 22:28 -!- MasterdonX [~masterdon@185.246.211.104] has quit [Ping timeout: 240 seconds] 22:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:30 < bitcoin-git> [bitcoin] fanquake closed pull request #18729: GUI/Intro: Never change the prune checkbox after the user has touched it (master...intro_dont_change_user_prune) https://github.com/bitcoin/bitcoin/pull/18729 22:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:31 -!- MasterdonX [~masterdon@192.154.254.136] has joined #bitcoin-core-dev 22:38 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 22:44 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 256 seconds] 22:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:46 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2aaff4813cc3...a4eb6a51a7f6 22:46 < bitcoin-git> bitcoin/master 8c7647b Jon Atack: rpc: deprecate banscore field in rpc getpeerinfo 22:46 < bitcoin-git> bitcoin/master dd54e37 Jon Atack: test: getpeerinfo banscore deprecation test 22:46 < bitcoin-git> bitcoin/master 41d55d3 Jon Atack: doc: getpeerinfo banscore deprecation release note 22:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:46 < bitcoin-git> [bitcoin] fanquake merged pull request #19469: rpc: deprecate banscore field in getpeerinfo (master...deprecate-getpeerinfo-banscore) https://github.com/bitcoin/bitcoin/pull/19469 22:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:51 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 22:57 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 22:58 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 22:58 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 23:00 -!- whartung1 [~whartung@84.39.116.180] has quit [] 23:03 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 258 seconds] 23:04 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 23:05 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 23:05 -!- trash_mapache [~trash_map@2600:380:cc78:f4ae:9b8a:ba6c:9bb0:764c] has joined #bitcoin-core-dev 23:06 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 23:14 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 23:18 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 23:18 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 23:18 -!- trash_mapache [~trash_map@2600:380:cc78:f4ae:9b8a:ba6c:9bb0:764c] has quit [Quit: Leaving] 23:18 -!- trash_mapache [~trash_map@2600:380:cc78:f4ae:9b8a:ba6c:9bb0:764c] has joined #bitcoin-core-dev 23:20 -!- trash_mapache [~trash_map@2600:380:cc78:f4ae:9b8a:ba6c:9bb0:764c] has quit [Client Quit] 23:20 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 23:22 -!- Gaz [~Gaz@184.75.221.35] has joined #bitcoin-core-dev 23:24 -!- marcoagner [~user@bl4-76-62.dsl.telepac.pt] has joined #bitcoin-core-dev 23:34 -!- Davterra [~tralfaz@104.200.129.62] has joined #bitcoin-core-dev 23:35 -!- berndj [~berndj@197.242.93.82] has quit [Quit: ZNC - http://znc.in] 23:37 -!- Gaz [~Gaz@184.75.221.35] has quit [Ping timeout: 265 seconds] 23:53 -!- zaff [~zaff@d111-50.icpnet.pl] has joined #bitcoin-core-dev 23:54 -!- marcoagner [~user@bl4-76-62.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 23:55 -!- multichill [~multichil@77.243.177.38] has joined #bitcoin-core-dev 23:55 -!- vincenzopalazzo [~vincent@153.33.4.33] has joined #bitcoin-core-dev 23:55 -!- jarthur [~jarthur@2605:6000:1019:48d9:349a:5444:c6c7:647c] has quit [] 23:56 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 264 seconds] 23:58 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev --- Log closed Fri Jul 10 00:00:14 2020