--- Log opened Fri Jul 31 00:00:35 2020 00:15 -!- IGHOR [~quassel@176.121.4.135] has quit [Ping timeout: 240 seconds] 00:20 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 00:30 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:40 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 00:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 00:57 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 01:01 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 246 seconds] 01:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:05 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds] 01:07 -!- arowser_ [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 01:12 -!- arowser_ [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 01:14 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:21 < jonatack> i'm interested in these meetings (core dev weekly, wallet, p2p, review club) but they are currently during sleep hours, which made for grouchy participation and low productivity the next day... i concluded it's best to abstain ;) 01:23 < jonatack> I like MarcoFalke's suggestion to toggle between two times 01:35 < jonatack> at any rate, I read the logs to catch up the next day :) 01:39 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 01:57 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 02:00 -!- Fiver [~Fiver@185.204.1.185] has quit [] 02:01 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 02:02 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 02:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 02:05 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 02:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 02:21 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:21 -!- jtk [~jtk@178.162.209.171] has joined #bitcoin-core-dev 02:23 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 02:27 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 02:44 -!- gankmove [uid454881@gateway/web/irccloud.com/x-ygkxzutlakdutjes] has joined #bitcoin-core-dev 02:58 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 03:00 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 03:01 -!- bizmindx [~textual@197.210.29.222] has joined #bitcoin-core-dev 03:02 -!- bizmindx [~textual@197.210.29.222] has quit [Client Quit] 03:02 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 03:03 -!- Kirsten15Nader [~Kirsten15@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:13 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:17 -!- Kirsten15Nader [~Kirsten15@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 03:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 03:42 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 03:43 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 03:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 03:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:58 -!- vasild_ is now known as vasild 04:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:02 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 04:03 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 04:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 04:05 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 04:17 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds] 04:19 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 04:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:36 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 04:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 04:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 04:42 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 04:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 04:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:52 < bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/a63a26f04213...f7c73b03d975 04:52 < bitcoin-git> bitcoin/master d362f19 Pieter Wuille: doc: list support for BIP 339 in doc/bips.md 04:52 < bitcoin-git> bitcoin/master 9efd86a Pieter Wuille: refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic 04:52 < bitcoin-git> bitcoin/master 900d7f6 Pieter Wuille: p2p: enable fetching of orphans from wtxid peers 04:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:53 < bitcoin-git> [bitcoin] fanquake merged pull request #19569: Enable fetching of orphan parents from wtxid peers (master...202007_wtxid_followup) https://github.com/bitcoin/bitcoin/pull/19569 04:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:55 < jnewbery> I'm pretty against having an alternating meeting time for a couple of reasons: 04:55 < jnewbery> 1) it's confusing. People will inevitably show up at the wrong time on the wrong day or miss meetings and get annoyed. 04:55 < jnewbery> 2) I'd need to find a host for the opposite time meeting. In my experience from PR review club, people are keen to host one or two and then lose interest. 04:57 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 04:59 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 05:00 -!- jtk [~jtk@178.162.209.171] has quit [] 05:00 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer] 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:05 < bitcoin-git> [bitcoin] laanwj pushed tag v0.20.1: https://github.com/bitcoin/bitcoin/compare/v0.20.1 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:06 < hebasto> \o/ 05:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:06 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/6acb21e724e3...7ff64311bee5 05:06 < bitcoin-git> bitcoin/0.20 7ff6431 Wladimir J. van der Laan: build: Bump version to 0.20.1-final 05:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:06 < wumpus> yes, I think that's also why the main meeting was never changed to alternating times, even though it was considered a few times 05:08 < wumpus> btw, we don't even mention the wallet meeting yet on https://bitcoincore.org/en/meetings/, would make sense to do so, or at least have a page that mentions all the meetings in one place 05:09 < wumpus> could also link to the PR review meetings 05:14 < wumpus> and the 2018- meeting summaries could move to something like 'historical meeting summaries' 05:21 -!- CjNr11 [~CjNr11@77.243.177.38] has joined #bitcoin-core-dev 05:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 246 seconds] 05:25 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 05:38 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:40 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 05:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:57 < aj> jnewbery: "people will .. miss meetings and get annoyed" oh, look, there's the box i'm in 06:01 < jonatack> jnewbery: lately there's almost been a surplus of review club hosts? slots backed up, etc, not including others who might be interested in hosting at a different time 06:03 < jonatack> anyway... in general (not just the review club) it may be worthwhile to try and see if people are confused by alternating slots. 06:04 < jonatack> the benefit might be a greater diversity of input at the meetings. geographic diversity is interesting. but i won't go on further about it. 06:06 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:06 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:07 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:07 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:09 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:09 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:10 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:10 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:12 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:12 * troygiorshev proposes to randomize the time each week so that people are forced to check when it is 06:12 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:15 < jonatack> :D 06:38 < provoostenator> hebasto beat me to it by 17 minutes for Gitian signatures. I should automate the PR part... 06:38 < hebasto> still using LXC :) 06:39 < provoostenator> Oh it was done much earlier; I just didn't watch the terminal window 06:39 < hebasto> provoostenator: have you already automate tagging part? 06:44 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:44 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:45 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:57 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 07:03 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 07:03 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 07:04 < jonatack> If anyone wants to build gitian sigs for the first time for 0.20.1, I just updated this guide: https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md 07:07 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 07:08 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 07:12 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 07:14 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 07:15 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:23 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Remote host closed the connection] 07:28 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 07:31 -!- andreaca_ [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 07:31 -!- andreaca_ [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 07:32 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 07:38 -!- onokatio [~Thunderbi@240d:1a:833:e500:515e:e817:5d4:9918] has joined #bitcoin-core-dev 07:39 -!- onokatio [~Thunderbi@240d:1a:833:e500:515e:e817:5d4:9918] has quit [Quit: onokatio] 07:39 -!- onokatio [~Thunderbi@240d:1a:833:e500:515e:e817:5d4:9918] has joined #bitcoin-core-dev 07:40 -!- onokatio [~Thunderbi@240d:1a:833:e500:515e:e817:5d4:9918] has quit [Client Quit] 07:41 -!- onokatio [~Thunderbi@240d:1a:833:e500:515e:e817:5d4:9918] has joined #bitcoin-core-dev 08:00 -!- CjNr11 [~CjNr11@77.243.177.38] has quit [] 08:06 < emzy> provoostenator: I had to delete gitian-builder/cache to get the hash of MacOSX10.14.sdk.tar.gz right and compile again. But you are faster anyway. 08:14 -!- gankmove [uid454881@gateway/web/irccloud.com/x-ygkxzutlakdutjes] has quit [Quit: Connection closed for inactivity] 08:20 -!- tlockney [~tlockney@89.47.234.28] has joined #bitcoin-core-dev 08:36 < provoostenator> hebasto: no automation, but I highlight "pushed tag" on IRC (ht achow101) 08:37 < achow101> automation is hard 08:37 < provoostenator> Also probably not ideal to automate, in case someone kidnaps me just before an evil release 08:47 -!- mutatrum [~quassel@172.200.122.78.rev.sfr.net] has joined #bitcoin-core-dev 08:56 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:11 < hebasto> provoostenator :D 09:13 < hebasto> agree, automated gitian builds as well as automated client updates are not for bitcoin 09:15 < hebasto> anyway kidnapping has no point as an adversary has no ability to *sign* your gitian builds 09:19 < jnewbery> jonatack: there hasn't been a surplus of review club hosts. I'm always looking for people to volunteer to host. 09:20 < jnewbery> I think maybe you underestimate the effort required to make sure this thing runs regularly. 09:20 < jnewbery> I'm very open to other people hosting review club meetings for different time zones. My experience has been that people don't stick with it for very long. 09:21 < jonatack> jnewbery: indeed, i reckoned i was underestimating that. it may have been a one-off backlog. 09:22 < jnewbery> It's not a backlog. I schedule hosts in advance to make sure that we always have something lined up 09:23 < jonatack> jnewbery: i'm not convinced that second meetings are very exciting for people. i don't think alternate times for the main meeting have been tried. 09:25 < jnewbery> there are many people who join every week at 17:00 UTC on weds because that's part of their schedule. I'm not going to stop holding meetings at that time. I'm very open to you or anyone else holding a meeting at a time that's more suitable for other time zones though. 09:26 < jonatack> that said, i don't want to be overbearing about mono-meeting times and i'm happy with reading the logs the next day and learning from them. 09:26 < jnewbery> I think we're offtopic here. If you want to discuss more, let's use #bitcoin-core-pr-reviews 09:27 < jonatack> my point was about the diversity of input at meetings in general, not only review club. 09:28 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 09:29 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 09:29 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 09:31 < jnewbery> ok. I just wanted to make sure that people in this room didn't think that we have a surplus of hosts. I'm always looking for hosts, and I think everyone who's done it has found it a worthwhile use of their time. 09:31 < jonatack> +1 09:34 < jonatack> if anyone is curious, here are the people who have hosted review clubs so far: https://bitcoincore.reviews/meetings-hosts 09:35 < pinheadmz> thats cool jonatack ! 09:39 < achow101> provoostenator: osx mismatch, did you clear your gitian cache? 09:39 < achow101> - 61a385c6836240224dafa06f19c0f5b9bea1215852c318fd6bd1e2f7baeb856e bitcoin-0.20.1-osx-unsigned.tar.gz 09:39 < achow101> + fdffff0e6b956ffa51b0a01f04b9e9cff2a658589116a911c322a94855feeeac bitcoin-0.20.1-osx-unsigned.tar.gz 09:40 < provoostenator> I didn't, which incantation? 09:40 < achow101> rm -r gitian-builder/cache 09:40 < provoostenator> And did my 0.20.1rc1 build also mismatch? 09:40 < achow101> yes, mismatch for rc1 too 09:41 < provoostenator> Doing a new build, will make another PR with that. 09:41 < provoostenator> Did we backport the SDK upgrade? 09:41 < provoostenator> Or is this an unrelated problem? 09:41 < achow101> unrelated 09:42 < jonatack> achow101: when is that spell needed? have never cleared the cache 09:42 < achow101> jonatack: usually it isn't needed as the cache should clear/not be used when a dependency updates 09:43 < achow101> but somtimes a dependency's binary will change because some build tooling changes and that makes cached builds vs non-cached builds differ 09:43 < achow101> so in those cases (like now) it's just easier to ask everyone to clear their cache before building so we all arrive at the same result 09:43 < jonatack> ok thanks 09:47 -!- mutatrum [~quassel@172.200.122.78.rev.sfr.net] has quit [Ping timeout: 246 seconds] 09:59 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 09:59 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 10:06 < provoostenator> Oh I guess I didn't have to rebuild Linux and Windows... 10:16 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 10:17 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 10:22 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 265 seconds] 10:31 -!- jarthur [~jarthur@2605:6000:1019:48d9:9934:a21a:6649:7fd5] has joined #bitcoin-core-dev 10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:35 < bitcoin-git> [bitcoin] justinmoon opened pull request #19634: rpc: Document getwalletinfo's unlocked_until field as optional (master...getwalletinfo) https://github.com/bitcoin/bitcoin/pull/19634 10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:35 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 10:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:47 < jeremyrubin> hebasto: for #18710 do you have a plan to get cross platform testing? It might help to ask some specific people to run benches. But also if you read the article that I shared on boost:: vs std:: it's unclear that our current bench would even capture it... 10:47 < gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub 10:48 < jeremyrubin> hebasto: I think what you might want to add is a new bench which is just testing different threading primitives out, and show there's no regression there? 10:48 < jeremyrubin> I can also send the article to martinus and ask if there are any features in nanobench that can help diagnose such a regression 10:59 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 10:59 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 11:00 -!- tlockney [~tlockney@89.47.234.28] has quit [] 11:11 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 11:17 < hebasto> jeremyrubin: which threading primitives do you mean for benchmarking? 11:17 < provoostenator> OTOH wiping the cache changed some linux details too 11:17 < hebasto> yes, martinus' help would be valuable 11:18 < provoostenator> (but not the end result) 11:19 < sipa> figure out how to turn of cpu frequency scaling if you benchmark 11:20 < sipa> on my laptop's i7 cpu that means booting with intel_pstate=disable on the kernel command line 11:20 < hebasto> some tools are mentioned here https://wiki.archlinux.org/index.php/CPU_frequency_scaling 11:20 -!- vBm1 [~vBm@178.162.209.171] has joined #bitcoin-core-dev 11:31 < jeremyrubin> from martinus: 11:31 < jeremyrubin> Hi, I think a good way to expose variance is to reduce the number of iterations. Usually nanobench tries to find a reasonable number of iterations depending on clock accuracy, but running many iterations per measurement means that it will become smoothed. So I'd do something like this: 11:32 < jeremyrubin> ankerl::nanobench::Bench().epochIterations(1).epochs(10000).run( 11:32 < jeremyrubin> "expose variance", [&] { /* whatever */ }); 11:32 < jeremyrubin> that forces only a single iteration per measurement(epoch), so this maximizes variance. The disadvantage is that time measurements will be less accurate. 11:32 < jeremyrubin> To visualize the fluctiation you can generate boxplots: 11:32 < jeremyrubin> std::ofstream html("out.html"); 11:32 < jeremyrubin> bench.render(ankerl::nanobench::templates::htmlBoxplot(), html); 11:32 < jeremyrubin> its probably best to play a bit with epochIterations() and epochs() argument to get reasonable visualization and result 11:33 < jeremyrubin> if you look at my comment https://github.com/bitcoin/bitcoin/pull/18710#issuecomment-640095382 11:33 < jeremyrubin> ^^^ back to non martinus 11:33 < jeremyrubin> https://codesequoia.wordpress.com/2013/03/27/condition-variables-performance-of-boost-win32-and-the-c11-standard-library/ 11:34 < jeremyrubin> this shows that std's condvar is defective 11:34 < jeremyrubin> so what im asking to test is that whichever primitive were using is not defective 11:36 < jeremyrubin> idk if it's an issue in that particular environment 11:36 < jeremyrubin> or an issue with c++11 generally 11:36 < jeremyrubin> but the checkqueue would be prett sensitive to something like this, and is perf critical 11:37 < hebasto> this article did not mention c++ library version 11:37 < sipa> "Visual Studio 2012 Express" 11:38 < jeremyrubin> so i'd prefer not leaving unless we have confidence the defect doesnt exist in our supported platforms 11:38 < sipa> i suspect is the c++ library version :) 11:38 < jeremyrubin> sipa: correct 11:38 < jeremyrubin> and the issue isnt avg perf, it's the variance 11:39 < jeremyrubin> which is why current bench doesnt inform much 11:40 < hebasto> so the goal is to compare boost:: and std:: condvar performance variances? 11:40 < jeremyrubin> fwiw there could be a legit reason to prefer the slower one -- maybe it delegates to the OS more and it's a thread priority issue 11:40 < jeremyrubin> but idk, and i'd be nervous to make a change without being sure 11:41 < jeremyrubin> hebasto: yes, in addition to actual performance 11:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 11:41 < hebasto> yes, we must be sure before making changes 11:42 < dburkett> https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L729-L730 11:43 < dburkett> If a block is part of the active chain, or we have the data in blk*.dat, in what cases would we not have tx data downloaded? 11:43 -!- mutatrum [~quassel@172.200.122.78.rev.sfr.net] has joined #bitcoin-core-dev 11:43 < jeremyrubin> hebasto: this one is just particularly annoying :/ i suspect that this issue has been fixed or doesnt exist on non windows but who knows. 11:44 < jeremyrubin> if it were only a regression on windows i'd still favor the patch 11:44 < sipa> dburkett: when it's pruned, i think 11:44 < jeremyrubin> but with condvars its both a hardware and system issue 11:44 < sipa> dburkett: ah, no 11:45 < jeremyrubin> so you should engage e.g. wumpus on what's a reasonable set to test 11:45 < sipa> dburkett: HaveTxDownloaded() means that a block and _all its parents_ have been downloaded 11:47 < dburkett> Ah, that makes sense! I knew it wasn't the case of pruned, because the docs specifically state that returning true doesn't mean txs haven't been pruned. 11:47 < dburkett> I forgot nChainTx is the number of txs in the entire chain up to that point. Makes sense now. Thanks sipa 11:49 < sipa> HAVE_BLOCK_DATA is unset when a block is pruned 11:49 < sipa> but nTx/nChainTx remain 11:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:54 < dburkett> Got it. There's a lot of possible states these indices can be in. It's sometimes hard for me to keep track of all of them :) 12:00 < achow101> wallet meeting? 12:01 < provoostenator> I'm around 12:01 < achow101> #startmeeting 12:01 < lightningbot> Meeting started Fri Jul 31 19:01:14 2020 UTC. The chair is achow101. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:01 < provoostenator> hi 12:01 < achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr 12:02 < provoostenator> Review nag for #15382 which is hopefully pretty close 12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add RunCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub 12:02 < achow101> that's on my review queue 12:02 < achow101> the main sqlite wallet pr is now ready for review 12:03 < provoostenator> Nice, will move on to that after I'm done with a Taproot excursion 12:03 < achow101> I was also wondering whether we wanted to do #19619 before it though 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/19619 | Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp by ryanofsky · Pull Request #19619 · bitcoin/bitcoin · GitHub 12:05 < achow101> no topics today? 12:05 < provoostenator> Not much news from my end 12:06 < provoostenator> 0.20.1 has the PSBT change, that's all we needed there? 12:06 < achow101> yes 12:06 < provoostenator> sipa: when miniscript? 12:06 < achow101> also #19602 is legacy to descriptor wallet migration 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub 12:07 < provoostenator> Shouldn't that go in the wallet tool? 12:07 < provoostenator> At least until we really insist on an upgrade? 12:07 < achow101> it could 12:08 < achow101> i made it a separate RPC, but it could also be rolled into upgradewallet 12:08 < provoostenator> And even if we insist on an upgrade, only the GUI would need access to this code, client users can use wallettool 12:09 < achow101> sure 12:10 < achow101> however it is useful to not have to unload and reload a wallet in order to migrate it 12:12 < achow101> #endmeeting 12:12 < lightningbot> Meeting ended Fri Jul 31 19:12:31 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:12 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-31-19.01.html 12:12 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-31-19.01.txt 12:12 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-31-19.01.log.html 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:15 < bitcoin-git> [bitcoin] Saibato opened pull request #19635: param: add bool parameter -ephemeraltoronion to generate ephemeral tor addreses (master...ephemeral-tor-onion) https://github.com/bitcoin/bitcoin/pull/19635 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:23 < jonasschnelli> 0.20.1 detached signatures are up and tagged 12:23 < achow101> gitian builders ^ 12:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection] 12:59 -!- notmandatory [~steve@cpe-72-134-225-83.natsow.res.rr.com] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in] 13:00 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 13:01 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 13:14 -!- notmandatory [~notmandat@li979-119.members.linode.com] has joined #bitcoin-core-dev 13:18 -!- notmandatory [~notmandat@li979-119.members.linode.com] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 13:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:19 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev 13:33 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 13:34 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 13:39 -!- mutatrum [~quassel@172.200.122.78.rev.sfr.net] has quit [Ping timeout: 240 seconds] 13:48 < meshcollider> Oh no totally forgot the meeting this morning! Thanks achow101 13:48 < meshcollider> Looks like a short one anyway 13:49 < meshcollider> 12:57 AM jnewbery: "people will .. miss meetings and get annoyed" oh, look, there's the box i'm in 13:49 < meshcollider> :) 13:55 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:00 -!- vBm1 [~vBm@178.162.209.171] has quit [] 14:09 < jeremyrubin> sipa: is this proven: not exists tx tx2. txid(tx) == wtxid(tx2) && tx != tx2 14:10 < sipa> jeremyrubin: yes, assuming double-sha256 collision resistance that statement is equivalent to ser_without_witness(tx) == ser_with_witness(tx2) 14:11 < sipa> either both tx and tx2 don't have a witness, and the statement is obviously false 14:11 < sipa> or tx2 has a witness, in which case the serialization definitely differs, due to the flag byte 14:13 < jeremyrubin> but it's not possible in tx2 that the flag + marker can be read as the length field for the txins? 14:13 < jeremyrubin> because a leading 0 byte means it can't be a length right? 14:13 < jeremyrubin> in which case it would be marker and not flag that guarantees uniqueness? 14:15 < sipa> a valid transactions cannot have 0 inputs 14:15 < sipa> the witness serialization is intended to be unambiguously different from the old serialization 14:15 < sipa> (except that we later discovered that people do pass around transactions with 0 inputs, where things break... but that's not relevant for valid network transactions)( 14:17 < jeremyrubin> gotcha. and the unambiguity is because it's a compactsize field preceding the vIn 14:18 < jeremyrubin> so 0 is always read as a 1 byte number in any context 14:18 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 14:19 < sipa> indeed 14:21 -!- alexsuraci [~alexsurac@178.239.168.171] has joined #bitcoin-core-dev 14:27 < harding> wumpus: FYI, 0.20.1 website PR: https://github.com/bitcoin-core/bitcoincore.org/pull/711 14:32 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 14:39 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 14:40 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:41 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 14:51 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:55 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 15:02 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:05 < bitcoin-git> [bitcoin] achow101 opened pull request #19636: doc: Update 0.20.1 release notes with psbt changes (0.20...0.20.1-psbt-relnotes) https://github.com/bitcoin/bitcoin/pull/19636 15:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:43 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 15:44 < luke-jr> oops? too late? 15:47 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Quit: Leaving] 15:49 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 16:01 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 16:02 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 16:09 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 16:17 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 16:25 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:25 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 16:25 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 16:33 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 16:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 16:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 16:40 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 16:41 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 16:44 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:00 -!- alexsuraci [~alexsurac@178.239.168.171] has quit [] 17:01 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has left #bitcoin-core-dev [] 17:01 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev 17:19 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 17:21 -!- notmandatory [~notmandat@shindig.notmandatory.org] has joined #bitcoin-core-dev 17:21 -!- BlaDe^ [~BlaDe^@178.162.209.171] has joined #bitcoin-core-dev 17:26 -!- notmandatory [~notmandat@shindig.notmandatory.org] has quit [Client Quit] 17:27 -!- notmandatory [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev 17:28 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:30 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:42 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Quit: May the Shwartz be with you] 17:47 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:14 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 18:17 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 18:17 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 18:22 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 18:32 -!- yolo7190 [492aad96@c-73-42-173-150.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:34 -!- yolo7190 [492aad96@c-73-42-173-150.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 18:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 19:33 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 19:35 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 19:45 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 19:45 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 19:45 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 19:48 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 264 seconds] 20:00 -!- BlaDe^ [~BlaDe^@178.162.209.171] has quit [] 20:03 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 20:03 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 20:03 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 20:04 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 20:05 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 20:21 -!- matael1 [~matael@217.146.82.202] has joined #bitcoin-core-dev 20:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 21:01 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 21:02 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 21:03 -!- onokatio [~Thunderbi@240d:1a:833:e500:515e:e817:5d4:9918] has quit [Quit: onokatio] 21:06 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 21:10 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 21:10 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 21:13 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 21:22 -!- roconnor [~roconnor@host-45-58-209-205.dyn.295.ca] has quit [Ping timeout: 240 seconds] 21:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 21:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 22:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 22:45 -!- isis is now known as isis_ 23:00 -!- matael1 [~matael@217.146.82.202] has quit [] 23:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 23:11 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Quit: Ping timeout (120 seconds)] 23:11 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 23:18 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 23:19 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 23:24 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 23:53 -!- Eprom [~Eprom@185.189.114.11] has joined #bitcoin-core-dev 23:55 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] --- Log closed Sat Aug 01 00:00:36 2020