--- Log opened Thu Aug 13 00:00:41 2020
--- Day changed Thu Aug 13 2020
00:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
00:01 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has joined #bitcoin-core-dev
00:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:02 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
00:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:09 -!- trash_mapache [~trash_map@2600:100e:b035:d3e4:3dde:70cc:ac61:513c] has quit [Quit: Leaving]
00:13 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3dd1:e688:7d38:e372] has joined #bitcoin-core-dev
00:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:13 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548
00:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:14 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3dd1:e688:7d38:e372] has quit [Remote host closed the connection]
00:15 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Remote host closed the connection]
00:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:15 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360
00:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:25 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds]
00:33 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
00:33 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
00:36 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
00:39 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 246 seconds]
00:40 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
00:44 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has joined #bitcoin-core-dev
00:50 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
00:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
01:07 -!- jonatack [~jon@213.152.162.84] has joined #bitcoin-core-dev
01:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:30 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 264 seconds]
01:37 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
01:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:39 < bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8a85377cd0b6...1052b09031c6
01:39 < bitcoin-git> bitcoin/master 25e1d0b Jonas Schnelli: RPCConsole, take initial chaintip data as parameter
01:39 < bitcoin-git> bitcoin/master b354a14 Jonas Schnelli: Add BlockAndHeaderTipInfo to the node interface/appInit
01:39 < bitcoin-git> bitcoin/master d42cb79 Jonas Schnelli: Optionally populate BlockAndHeaderTipInfo during AppInitMain
01:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:40 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
01:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:40 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
01:40 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
01:41 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
01:41 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
01:43 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
01:48 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
02:00 -!- directhex1 [~directhex@184.75.223.227] has quit []
02:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
02:32 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
02:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:34 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 256 seconds]
02:35 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
02:40 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
02:44 -!- jonatack [~jon@213.152.162.84] has quit [Ping timeout: 246 seconds]
02:48 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
02:49 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
02:49 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 260 seconds]
02:50 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
02:54 -!- vBm1 [~vBm@89.47.234.28] has joined #bitcoin-core-dev
03:03 -!- Phoebe89Zulauf [~Phoebe89Z@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
03:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
03:10 -!- Phoebe89Zulauf [~Phoebe89Z@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds]
03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:13 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1052b09031c6...6757b3ac8f67
03:13 < bitcoin-git> bitcoin/master c133cdc Adam Stein: Cap listsinceblock target_confirmations param
03:13 < bitcoin-git> bitcoin/master 6757b3a Wladimir J. van der Laan: Merge #19655: rpc: Catch listsinceblock target_confirmations exceeding blo...
03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:14 < bitcoin-git> [bitcoin] laanwj merged pull request #19655: rpc: Catch listsinceblock target_confirmations exceeding block count (master...listsinceblock_rpc) https://github.com/bitcoin/bitcoin/pull/19655
03:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:33 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
03:38 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
03:40 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
03:41 -!- T3 [~T3@173.231.109.130] has quit [Read error: Connection reset by peer]
03:41 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-dev
03:42 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
03:44 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
03:50 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
03:54 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 240 seconds]
03:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
03:55 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
03:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:58 -!- vasild_ is now known as vasild
04:02 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
04:14 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
04:14 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
04:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
04:26 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
04:26 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 256 seconds]
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:34 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:42 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
04:42 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
04:52 -!- vBm1 [~vBm@89.47.234.28] has quit [Remote host closed the connection]
04:55 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Quit: leaving]
04:55 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
04:56 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Ping timeout: 265 seconds]
04:57 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
04:58 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
05:09 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 246 seconds]
05:09 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
05:20 -!- tadeo [~tadeo@37.120.203.188] has joined #bitcoin-core-dev
05:20 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
05:24 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 265 seconds]
05:25 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 256 seconds]
05:25 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
05:25 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
05:27 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
05:31 -!- face [~face@80.72.82.160.coresnet.bg] has joined #bitcoin-core-dev
05:33 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 256 seconds]
05:35 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 264 seconds]
05:35 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
05:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:44 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 246 seconds]
05:45 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
05:49 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
05:50 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
06:00 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 265 seconds]
06:00 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
06:00 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
06:06 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:06 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:07 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:07 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:08 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:08 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:09 -!- MDrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has quit [Ping timeout: 240 seconds]
06:09 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:14 -!- mdrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has joined #bitcoin-core-dev
06:15 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:16 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
06:18 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
06:21 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
06:23 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
06:26 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:31 < bitcoin-git> [bitcoin] hebasto opened pull request #19709: test: Fix 'make cov' with clang (master...200813-lcov) https://github.com/bitcoin/bitcoin/pull/19709
06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
06:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
06:44 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Remote host closed the connection]
06:44 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
06:45 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:45 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6757b3ac8f67...b4d0366b47dd
06:45 < bitcoin-git> bitcoin/master b3fbc94 John Newbery: Apply cfilters review fixups
06:45 < bitcoin-git> bitcoin/master 132b30d Jim Posen: [net] Signal NODE_COMPACT_FILTERS if we're serving compact filters.
06:45 < bitcoin-git> bitcoin/master f5c003d Jim Posen: [test] Add test for NODE_COMPACT_FILTER.
06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:46 < bitcoin-git> [bitcoin] laanwj merged pull request #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS (master...2020-05-node-compact-filters) https://github.com/bitcoin/bitcoin/pull/19070
06:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
06:51 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
06:55 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:59 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds]
07:12 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
07:12 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
07:14 -!- vincenzopalazzo [~vincent@host-87-20-89-251.retail.telecomitalia.it] has joined #bitcoin-core-dev
07:15 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
07:18 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
07:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:26 < bitcoin-git> [bitcoin] hebasto opened pull request #19710: bench: Prevent thread oversubscription and decreases the variance of result values (master...200813-var) https://github.com/bitcoin/bitcoin/pull/19710
07:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:27 < bitcoin-git> [bitcoin] jnewbery closed pull request #18876: [WIP] Serve BIP 157 compact filters (master...pr16442.3) https://github.com/bitcoin/bitcoin/pull/18876
07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:32 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 264 seconds]
07:33 -!- Davterra [~Davterra@89.45.90.22] has quit [Quit: Leaving]
07:33 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
07:38 -!- bizmindx [~textual@197.210.64.143] has joined #bitcoin-core-dev
07:53 -!- nickbtc63 [25c9e211@aftr-37-201-226-17.unity-media.net] has joined #bitcoin-core-dev
07:57 -!- nickbtc63 [25c9e211@aftr-37-201-226-17.unity-media.net] has quit [Remote host closed the connection]
07:59 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
07:59 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
08:00 -!- tadeo [~tadeo@37.120.203.188] has quit []
08:00 -!- bizmindx [~textual@197.210.64.143] has quit [Quit: Textual IRC Client: www.textualapp.com]
08:01 -!- platesondeck [63e13623@CPE105611af685f-CM105611af685d.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
08:04 -!- platesondeck [63e13623@CPE105611af685f-CM105611af685d.cpe.net.cable.rogers.com] has quit [Remote host closed the connection]
08:05 -!- palazzovincenzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has joined #bitcoin-core-dev
08:05 -!- palazzovincenzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Client Quit]
08:07 -!- vincenzopalazzo [~vincent@host-87-20-89-251.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds]
08:09 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Remote host closed the connection]
08:16 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 260 seconds]
08:17 -!- dviola [~diego@189.7.69.189] has joined #bitcoin-core-dev
08:17 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
08:18 -!- waldoirc_ [~Android@2607:fb90:6434:ddcb:3cff:71d3:35cc:39fb] has joined #bitcoin-core-dev
08:18 -!- waldoirc_ [~Android@2607:fb90:6434:ddcb:3cff:71d3:35cc:39fb] has quit [Excess Flood]
08:19 -!- waldoirc_ [~Android@2607:fb90:6434:ddcb:3cff:71d3:35cc:39fb] has joined #bitcoin-core-dev
08:19 -!- waldoirc_ [~Android@2607:fb90:6434:ddcb:3cff:71d3:35cc:39fb] has quit [Excess Flood]
08:19 -!- waldoirc_ [~Android@172.58.188.8] has joined #bitcoin-core-dev
08:19 -!- waldoirc_ [~Android@172.58.188.8] has quit [Excess Flood]
08:19 -!- waldoirc_ [~Android@172.58.188.8] has joined #bitcoin-core-dev
08:19 -!- waldoirc_ [~Android@172.58.188.8] has quit [Excess Flood]
08:20 -!- waldoirc_ [~Android@172.58.188.8] has joined #bitcoin-core-dev
08:20 -!- waldoirc_ [~Android@172.58.188.8] has quit [Excess Flood]
08:21 -!- waldoirc [~Android@pool-108-28-58-104.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds]
08:22 -!- pav5088 [~pav5088@178.162.212.214] has joined #bitcoin-core-dev
08:22 < fjahr> #19528 seems RFM
08:22 < gribble> https://github.com/bitcoin/bitcoin/issues/19528 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) by MarcoFalke · Pull Request #19528 · bitcoin/bitcoin · GitHub
08:27 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Remote host closed the connection]
08:59 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
09:04 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
09:12 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
09:12 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
09:16 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:19 < bitcoin-git> [bitcoin] hebasto closed pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:19 < bitcoin-git> [bitcoin] hebasto reopened pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:22 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in]
09:24 < fjahr> re loading all GH comments: I remember having that discussion here as well back then (probably when fanquake made the comment). There is a browser extension that offers that functionality and it worked well but seemed stupid to keep it just for that and some of the other functionality is annoying: https://github.com/sindresorhus/refined-github
09:24 < fjahr> If you are really desperate you may paste this into your js console: https://gist.github.com/fjahr/bfaf119dddae37c490a4949e956b3b7a It works for me.
09:26 < achow101> there's no way to turn off the annoying features?
09:27 < luke-jr> I wonder if there's a non-browser GH open source app
09:27 < fjahr> achow101: i didn't look into it that deeply but maybe (https://github.com/sindresorhus/refined-github#customization). I just try to keep my use of extensions at a minimum.
09:28 < luke-jr> maybe it could even work with GitLab too so someday we can get off GitHub :P
09:28 < achow101> luke-jr: there's a github android app now. I don't know if it's open source
09:29 < luke-jr> I mean Qt or such
09:29 < achow101> fjahr: seems like you can turn on and off features
09:30 < achow101> luke-jr: they have an open source desktop app for windows and mac
09:30 < achow101> electron based though, so bleh
09:31 < fjahr> achow101: yeah, I don't remember seeing that, so maybe worth another try
09:34 -!- proofofkeags [~proofofke@2601:280:c280:e500:9051:c453:335b:833b] has joined #bitcoin-core-dev
09:35 -!- proofofkeags [~proofofke@2601:280:c280:e500:9051:c453:335b:833b] has quit [Remote host closed the connection]
09:36 < luke-jr> achow101: that's just a browser wrapper afaik
09:39 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 240 seconds]
09:42 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev
09:43 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Remote host closed the connection]
09:44 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
09:46 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
09:46 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
09:46 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
09:53 -!- mr_burdell_ [~mr_burdel@bounce.cryptolabs.net] has joined #bitcoin-core-dev
09:53 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-dev
09:53 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Read error: Connection reset by peer]
10:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
10:26 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Read error: Connection reset by peer]
10:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
10:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:50 -!- Highway62 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
10:50 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Read error: Connection reset by peer]
10:50 -!- Highway62 is now known as Highway61
10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:52 < bitcoin-git> [bitcoin] Crypt-iQ opened pull request #19713: fuzz: fix -fsanitize=integer complaints (master...fuzz_supp_0813) https://github.com/bitcoin/bitcoin/pull/19713
10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:52 < jeremyrubin> btw interesting article for the rust folks https://people.gnome.org/~federico/blog/rust-stable-abi.html
10:53 < jeremyrubin> elichai2: luke-jr michaelfolkson
10:55 -!- lightlike [~lightlike@p200300c7ef191700552fb2a9e7e2b18e.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
11:00 -!- pav5088 [~pav5088@178.162.212.214] has quit []
11:05 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
11:08 < luke-jr> jeremyrubin: tl;dr: no solutions
11:08 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
11:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
11:14 -!- dviola [~diego@189.7.69.189] has left #bitcoin-core-dev []
11:15 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
11:17 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
11:21 -!- [RuCTFE]tswr [~RuCTFE]ts@185.244.214.217] has joined #bitcoin-core-dev
11:47 < michaelfolkson> tl;dr Rust does not have a stable ABI
11:49 < michaelfolkson> .. but we can override this
11:49 < luke-jr> frankly it'd probably be good enough if they simply limit ABI breakage to minor (major?) version bumps
11:49 < luke-jr> so you could dynamic link stuff so long as you kept the same compiler
11:49 < luke-jr> michaelfolkson: having to annotate every interface in code isn't a solution
11:50 < luke-jr> especially when it's losing features (eg, Rust's decision to sort fields a certain optimal way)
11:51 < luke-jr> the template/generic point does seem fundamentally unsolvable, though
11:53 < luke-jr> a real world point on the topic: it's frustrating when Chromium releases new security fixes, and I have to forego having a browser for 48 hours while the entire thing recompiles.. if it was using proper shared libraries, I could just rebuild the affected one(s) and go.
11:54 < luke-jr> (Chromium isn't Rust, but this is a static compiling/linking issue, not a Rust issue specifically)
11:57 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 256 seconds]
11:58 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
12:00 < wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu Aug 13 19:00:07 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < jnewbery> hi
12:00 < jonasschnelli> Hi
12:00 < troygiorshev> hi
12:00 < hebasto> hi
12:00 < luke-jr> hi
12:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
12:00 < wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
12:00 < sipsorcery> hi
12:00 < achow101> hi
12:00 < jamesob> hi
12:01 < aj> hi
12:01 < fjahr> hi
12:01 < wumpus> one proposed topic in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt: Can we recreate bitcoin-core/gui (Luke-jr)
12:01 < wumpus> any last minute topic proposals?
12:01 < jeremyrubin> hi
12:01 < ajonas> hi
12:01 < sipa> hi
12:02 < wumpus> #topic High priority for review
12:02 < wumpus> https://github.com/bitcoin/bitcoin/projects/8   10 blockers, 1 bugfix, 3 chasing conept
12:02 < jonatack> hi
12:02 < wumpus> anything to add/remove or that is probably ready for merge?
12:03 < luke-jr> …
12:03 < jonatack> i'd like to nominate #19628 for blockers
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
12:03 < wumpus> luke-jr: ?
12:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
12:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:04 < wumpus> jonatack: added
12:05 < jnewbery> #11082 is the only one that needs rebase. There was discussion last week about whether it was even needed anymore now that we have the settings file
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
12:06 < wumpus> let's remove it for now
12:06 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
12:07 < wumpus> I see the other ones were rebased, great
12:08 < wumpus> ok, that concludes the topic if no one else has suggestions
12:08 < wumpus> #topic Can we recreate bitcoin-core/gui (Luke-jr)
12:09 -!- Highway62 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
12:09 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 260 seconds]
12:09 -!- Highway62 is now known as Highway61
12:09 < luke-jr> sorry, my IRC flaked out (I saw nothing for 5 minutes)
12:09 < wumpus> I'd personally rather not, just now that all kinds of issues and PRs were moved there
12:09 < jeremyrubin> To be clear
12:09 < jeremyrubin> This is for a repo
12:09 < michaelfolkson> What was the motivation for wanting this? Sorry missing context
12:10 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
12:10 < jeremyrubin> not for the actual QT impl
12:10 -!- luke-jr_ [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:10 < luke-jr_> Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
12:10 < wumpus> he wants to inherit it from bitcoin/bitcoin I think instead of having it as completely disparate repo
12:10 < luke-jr_> Or Maybe our contacts at GitHub can just link it?
12:10 < wumpus> I'm not convinced
12:10 < luke-jr_> As things are, every dev needs to create a new fork to make PRs on it
12:11 < achow101> I'm not sure that's possible by ourselves
12:11 < wumpus> yes, that is true, though if they drift further apart in the future, that's what you'll need to do anyway
12:11 < achow101> we may need to ask github support to do that
12:11 < luke-jr_> achow101: we could delete, refork, and rename; but probably better if GitHub just links it
12:11 < hebasto> hope, that gui repo would be interested for just created designers community.
12:11 < jeremyrubin> michaelfolkson: I think it was to allow more focus on the gui work in the gui subrepo
12:11 < jnewbery> wumpus: if you push a branch to <developer>/bitcoin , then you can't open a PR against bitcoin-core/gui because they don't share a common fork in gitub
12:12 < wumpus> right now they're basically the same, but it's not clear that will always be the case, e.g. after process separation there might be repo separation as well
12:12 < jeremyrubin> oops I hit enter late XD
12:12 < jnewbery> if we delete bitcoin-core/gui and then recreate it as a fork of bitcoin/bitcoin, you'd be able to
12:12 < luke-jr_> I suppose if the thought is to remove core code from /gui, and remove GUI from the core codebase, then it makes sense to leave it alone..
12:12 < wumpus> then again if a lot of people feel like it would be easier if it's a bitcoin/bitcoin fork we could try asking github
12:12 < jonatack> I agree that it's annoying friction, and things seems quiet in GUI-land.
12:13 < luke-jr_> but I think we've been planning that for years, and progress is slow
12:13 < wumpus> deleting the repo right now sounds like a bad plan to me, just now that eerything was set up there
12:13 < wumpus> might as well move things back to the main repo and delete it and give up on the idea then
12:13 < luke-jr_> also, while it used to be possible to have multiple forks under the same org (so bitcoin-core/gui and bitcoin-core/foobar), GitHub seems to have removed that possibility too
12:14 < jnewbery> wumpus: I don't think so
12:14 < jnewbery> just because things aren't perfect the first time doesn't mean you should give up on the idea
12:14 < wumpus> luke-jr_: that seems another issue, would make it imopssible to move bitcoin itself there
12:14 < luke-jr_> wumpus: right, that's my concern with that
12:14 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
12:15 < wumpus> jnewbery: it's just that it's not clear that the idea will work at all, causing the people that spent lots of time movign issues around extra work by doing it again seems terrible
12:15 < michaelfolkson> It seems to me that the experiment has been very short. I will try to find out if there is genuine interest in contributing, reviewing on that Bitcoin Design Slack
12:15 < wumpus> fanquake is not here but I think he'd agree
12:15 < jeremyrubin> Maybe a magic friend at github can help us add a feature for this?
12:16 < aj> yeah, isn't at least asking someone at github to tweak the database worthwhile?
12:16 < hebasto> michaelfolkson: great!
12:16 < wumpus> also some GUI people have created issues there, would you have them make them again?
12:16 < wumpus> it just seems nasty to me, sorry
12:16 < jnewbery> aj: yes. I think moneyball and fanquake are the most likely to know someone at github
12:16 < luke-jr_> wumpus: I agree recreating is probably a bad approach, but IF we wanted to do it, better sooner than later
12:17 < michaelfolkson> The motivations for it were attracting more contributors/reviewers and reducing noise for those not interested in GUI. I think the rationale made sense and it hasn't been given enough time at this stage
12:17 < luke-jr_> probably the best approach would be to allow PRs across code "networks"
12:17 < luke-jr_> if GitHub could add that, it'd be nice
12:17 < wumpus> michaelfolkson: I agree
12:18 < jeremyrubin> Let's ask github if they can tweak it first before doing anything?
12:18 < wumpus> I don't actually want to give up the idea, just don't want to take drastic measures like that
12:18 < luke-jr> jeremyrubin: +1
12:18 < sipa> i certainly like it, it means i can mute the gui PR mails/notofications :)
12:18 < luke-jr> sipa: well, procmail can do that much :P
12:18 < wumpus> sipa: wait, you can't do that now?
12:19 < moneyball> let's see if fanquake will follow-up with github as he's had the most recent contact with them. if not, i am happy to
12:19 < wumpus> how does it make a difference for notifications?
12:19 < sipa> wumpus: i can do that since the gui repo is split up
12:19 < ajonas> michaelfolkson: there are designers interested in the slack group. I put them in touch with hebasto, but they are looking for other devs to connect with.
12:19 < wumpus> sipa: ohh right
12:19 < luke-jr> wumpus: sipa means not giving up the idea; it's the same whether the repos are linked or not AFAIK
12:19 < sipa> wumpus: sorry, i was talking about the split itself; not the recreatio 
12:19 < wumpus> yes, makes sense then
12:19 -!- luke-jr_ [~luke-jr@unaffiliated/luke-jr] has quit [Quit: leaving]
12:20 < michaelfolkson> ajonas: We set up a separate Slack channel and have notifications set up from GitHub
12:20 < luke-jr> (still here)
12:20 < jeremyrubin> Are there other topics? moneyball's suggestion sounds like a concrete next step and revisit next week if no word back
12:20 < wumpus> I don't think there are any other topics
12:21 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:21 < wumpus> unless anyone has one now
12:21 < jnewbery> I have a quick proposed topic
12:22 < jnewbery> moving functions in net_processing into PeerLogicValidation
12:22 < jeremyrubin> is there a relevant PR?
12:22 < wumpus> #topic Moving functions from net_processing to PeerLogicValidation (jnewbery)
12:22  * luke-jr wishes C++ allowed for private methods to not be in the header
12:22 < jnewbery> currently, most of the logic and much of the state in net_processing is static functions and globals
12:22 < jeremyrubin> #19704
12:22 < gribble> https://github.com/bitcoin/bitcoin/issues/19704 | Net processing: move ProcessMessage() to PeerLogicValidation by jnewbery · Pull Request #19704 · bitcoin/bitcoin · GitHub
12:23 < jnewbery> on a recent PR of mine, several reviewers suggested making new state a member of PLV rather than a global
12:23 < jnewbery> doing so would involve moving almost all of net_processing into PLV
12:23 < jnewbery> is that a sensible thing to do, or do people have strong objections to that?
12:23 < aj> luke-jr: you can get most of the way by moving the private members into a friend class
12:23 < jamesob> doesn't sound worth the churn unless there are big benefits to fuzzing/testability
12:24 < wumpus> luke-jr: the usual way to do that is a private implementation class (pimpl) pattern
12:24 < luke-jr> yes, just feels ugly
12:25 < jnewbery> MarcoFalke sdaftuar and theuni were the reviewers who suggested this
12:25 < wumpus> luke-jr: maybe, but a lot of software e.g. qt does it everywhere
12:25 < luke-jr> to be clear, I don't object to doing this, just find C++ a bit annoying in this regard
12:26 < jnewbery> jamesob: I think removing globals and better encapsulation benefits testability, no?
12:27 < wumpus> I'm not sure really it's worth changing around just for code organization, there's nothing wrong with functinos
12:27 < wumpus> not everythign has to be an object or a method
12:27 < jamesob> jnewbery: yeah I agree if what we're talking about is replacing global state with something that's more tightly scoped, but if it's mostly a matter of functions vs. methods I think the difference is pretty negligible. but haven't looked at it in a while...
12:28 < wumpus> agree wrt global state
12:28 < jamesob> it'd be nice if people could motivate changes like these with large draft branches that demonstrate better testability
12:28 < jnewbery> I'm not so interested in opinions like "I'm not sure if it's worth it". More looking for "this is a bad idea and we do it this way because..."
12:28 < jnewbery> (if you're not sure it's worth it, just don't review it)
12:29 < wumpus> okay sorry...
12:29 < jeremyrubin> It sounds like these changes are requested by reviewers already of other work that is made better by it, right jnewbery
12:29 < wumpus> will not give my oopinion on this again
12:29 < jamesob> wumpus: that was probably mostly directed at me
12:29 < jnewbery> jeremyrubin: exactly
12:31 < cfields> jnewbery: I didn't look too deeply into it when I +1'd. I certainly didn't realize it'd be a big change.
12:32 < cfields> I figured it made sense logically to be there, but yeah, if it means moving everything in, that wouldn't make much sense.
12:32 < jeremyrubin> jnewbery: do you feel it's blocking for the other work?
12:32 < aj> "not worth it -> don't review" seems like a bad idea?
12:32 < jnewbery> it's not blocking. I can abandon it.
12:33 < jnewbery> It just seems like it's a better design and allows better testing
12:33 < aj> just seems like it'd result in only interested people review, lots of shallow acks, stuff gets merged without deep review
12:33 < michaelfolkson> I know video calls (especially when livestreamed, transcribed) aren't for everyone. But if anyone wants to chat Signet this is scheduled for next Wednesday: https://www.meetup.com/BitDevsLDN/events/272121581/
12:33 < luke-jr> aj: that already happens I think
12:34 < luke-jr> aj: though usually the result is more of "not enough reviews to get merged"
12:34 < aj> jnewbery: (agree it's a better design, not sure it's worth it, think doing tx relay overhaul and separating that chunk of code into a separate file might be a start)
12:34 -!- Pedromvpg [~pedromvpg@cpe-67-245-40-43.nyc.res.rr.com] has joined #bitcoin-core-dev
12:35 < jonatack> jnewbery: i don't know how much work it entails, but sometimes seeing the actual code helps to resolve these questions, as well as looking at if it's a priority worth attempting to do so before writing the code
12:35 < jeremyrubin> jnewbery: I'd like to see how it interacts with turning the individual handlers into functions as well. I could see it being good or bad for that.
12:35 < jnewbery> aj: that seems tangentially related
12:37 < jnewbery> jonatack: 19704 is the first step
12:37 < jeremyrubin> jnewbery: it seems this would make it easier to do that right? Less argument passing all over
12:37 < jeremyrubin> But then those funcs would also have to methods on the class
12:37 < jeremyrubin> So maybe might make sense to encapsulate it in a separate class?
12:37 < jnewbery> yes, instead of every function in net_processing having 10 arguments for passing params and connman and banman and ....., they're methods
12:38 < cfields> jnewbery: as a concrete answer: it makes sense to me as part of an effort to encapsulate and enhance what an instance of plv can do by itself, primarily for testing.
12:38 < jnewbery> cfields: that's how I feel too, which is why I went ahead after you, Marco and Suhas suggested it
12:38 < cfields> but absent that greater effort, it doesn't do much good.
12:38 < jnewbery> The reason I raised it here was to poll if there was a good reason that it's the way it is now
12:38 < dongcarl> cfields: is there a particular test you have in mind that this would enable?
12:38 < jeremyrubin> I think it sounds like a general "we're slow to make changes, so this won't have impact because we won't do the follow up for a while"
12:39 < jeremyrubin> But at some point we need to make a step
12:39 < jeremyrubin> dongcarl: imagine writing individual unit tests for message handlers
12:39 < jnewbery> jeremyrubin: +1. We've got to do something eventually instead of always saying that things don't seem worth it
12:39 < cfields> dongcarl: I've always, for ex, wanted to be able to run instances of our net/net_processing against themselves.
12:40 < jamesob> I think in general for issues like these, someone should come up with a branch that implements (i) the necessary changes and (ii) the new tests that we'd like to be able to do. seeing the tests motivates the changes.
12:40 < cfields> (that was the primary goal with CConnman, which never fully worked out :( )
12:40 < jeremyrubin> I think there's a balance to that. If the work is huge like this, it sounds like setting jnewbery up for rebase hell
12:40 < jnewbery> jamesob: I'm not looking for motivation. I'm looking for anti-motivation, ie is there a strong reason not to do it
12:41 < jamesob> the strong motivation not to do it would be a continuation of death-by-a-thousand-small-refactorings going on in the repo
12:41 < aj> jnewbery: "we've got to do something" -- work on the things that are clearly worth it?
12:41 < jeremyrubin> jnewbery: I think you're inadvdertently asking people what color the shed should be :P
12:41 < jnewbery> aj: I think better encapsulated code is worth it
12:41 < cfields> jnewbery: I think this was actually the intention for PLV.
12:42 < jnewbery> cfields: ah. That makes sense. I haven't looked at the history.
12:42 < sipa> is the question if those fields should move into PLV at all, or if they that should happen now?
12:43 < jeremyrubin> BTW here's a concrete motivation: Makes it easier to do individual function handlers. Function handlers can be dispatched in O(1), we currently do O(N) string matches to process a message. Concrete motivation for this step in that direction.
12:43 < sipa> i think my answers are (1) yes (2) don't care
12:43 < jnewbery> The question is "Is there a good reason _not_ to move these functions and data into PLV?"
12:44 < jnewbery> If the answer is 'no', then I'll proceed. If the answer is 'yes', then I'll stop.
12:44 < jonatack> jnewbery: it doesn't look like a slog to review. more a question of priority and opportunity cost. review pings are piling up atm.
12:44 < jeremyrubin> I don't have any.
12:44 < jeremyrubin> (objections or reasons not to)
12:44 < jeremyrubin> I think jnewbery is only interested in technical objections.
12:45 < jeremyrubin> He has 4 strong reviewers who will spend time on it.
12:45 < jnewbery> jeremyrubin: I also like individual function handlers. Smaller chunks of code are easier to review/understand and hide less bugs.
12:45 < jnewbery> but that wasn't really my main motivation here
12:45 < jnewbery> (also easier to test)
12:45 < jeremyrubin> But it's a question of if anyone has any technical problems with this move, e.g., conflicting work
12:45 < cfields> jnewbery: only one I can think of is: it may reveal a tangled mess that takes more effort than expected to untangle. But you kinda have to work through it to determine that.
12:46 < jamesob> moving big swathes of code creates rebase burden for everyone
12:46 < jnewbery> cfields: working through a tangled mess is good work. I've done it before :)
12:46 < luke-jr> rebase burden will happen no matter what PRs do it
12:47 < luke-jr> helpful refactors may reduce it in the long run though
12:47 < jnewbery> better encapsulated code is good medicine: more rebase pain now, for much less rebase pain forever after it's done
12:47 < luke-jr> ^
12:48 < jnewbery> I didn't expect this topic to be so heated :)
12:48 < jeremyrubin> jnewbery: new around here are ya?
12:48 < jnewbery> It sounds like there aren't any fundamental objections
12:48 < sipa> i think it only looks that way because the people here aren't familiar with the concrete implications
12:48 < sipa> so we have to talk in generalities
12:49 < sipa> it's probably best left to discussion on the PR?
12:49 < jnewbery> sipa: yes. For specifics we can use the PR.
12:49 < jnewbery> just wanted to make sure there were no high-level reasons why we shouldn't even consider it
12:50 < jeremyrubin> Any other 'quick' topics :)
12:51 < jamesob> haha
12:51 < luke-jr> lol
12:53 < wumpus> #endmeeting
12:53 < lightningbot> Meeting ended Thu Aug 13 19:53:03 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:53 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.html
12:53 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.txt
12:53 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.log.html
12:53 < sipa> lunch?
12:53 < luke-jr> more like dinner
12:54 < dongcarl> tea time!
12:54 < jamesob> luke-jr: what, do you go to bed around 7pm?
12:54 < jonatack> jnewbery: in the absence of strong reasons against, the code looks ~ok to me
12:54 < sipa> dongcarl: havin a yasmine tea at this exact moment
12:54 < luke-jr> jamesob: I don't eat dinner in bed
12:54 < jonatack> jamesob: i do
12:54 < jnewbery> jonatack: thanks :)
12:54 < jamesob> I'm envious
12:55 < dongcarl> sipa: Out of red bull?
12:55  * dongcarl ducks
12:56 < sipa> dongcarl: nope.
12:59 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:00 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:01 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
13:09 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 246 seconds]
13:10 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
13:12 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection]
13:17 -!- watersnake1 [~christian@24.61.159.12] has joined #bitcoin-core-dev
13:25 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Remote host closed the connection]
13:26 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev
14:00 -!- [RuCTFE]tswr [~RuCTFE]ts@185.244.214.217] has quit []
14:02 -!- lightlike [~lightlike@p200300c7ef191700552fb2a9e7e2b18e.dip0.t-ipconnect.de] has quit [Quit: Leaving]
14:14 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
14:21 -!- SukhE1 [~SukhE@s91904426.blix.com] has joined #bitcoin-core-dev
14:25 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 246 seconds]
14:27 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
14:30 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
14:36 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Remote host closed the connection]
14:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:58 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4d0366b47dd...609ce2d0da49
14:58 < bitcoin-git> bitcoin/master f110b7c Sebastian Falbesoner: rpc: document returned error fields as optional if applicable
14:58 < bitcoin-git> bitcoin/master 609ce2d Samuel Dobson: Merge #19644: rpc: document returned error fields as optional if applicabl...
14:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:58 < bitcoin-git> [bitcoin] meshcollider merged pull request #19644: rpc: document returned error fields as optional if applicable (master...20200802-rpc-document_errors_fields_as_optional) https://github.com/bitcoin/bitcoin/pull/19644
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:05 -!- norou [c7e5fa76@199.229.250.118] has joined #bitcoin-core-dev
15:11 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
15:18 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
15:32 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 256 seconds]
15:39 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
15:40 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
15:49 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:59 -!- vasild_ is now known as vasild
16:06 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 240 seconds]
16:13 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
16:14 -!- norou [c7e5fa76@199.229.250.118] has quit [Remote host closed the connection]
16:14 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 265 seconds]
16:17 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:17 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
16:20 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 246 seconds]
16:21 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
16:32 -!- T3 [~T3@173.231.109.130] has quit [Ping timeout: 240 seconds]
16:54 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 256 seconds]
17:00 -!- SukhE1 [~SukhE@s91904426.blix.com] has quit []
17:05 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
17:20 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev
17:22 -!- conman1 [~conman@77.243.177.38] has joined #bitcoin-core-dev
17:41 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 264 seconds]
17:41 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
17:57 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 264 seconds]
18:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
18:04 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
18:08 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
18:10 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds]
18:15 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Read error: Connection reset by peer]
18:17 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
18:18 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
18:25 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 256 seconds]
18:32 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
18:37 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 264 seconds]
18:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
18:43 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
18:59 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
19:10 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 260 seconds]
19:17 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
19:50 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds]
19:51 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
19:53 -!- Netsplit *.net <-> *.split quits: Davterra, arowser_, face
19:54 -!- Netsplit over, joins: btc_thc
19:54 -!- Netsplit *.net <-> *.split quits: victorSN, Eliel, Anduck, ensign, kakobrekla, da2ce7, darosior, thrasher
19:56 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
19:57 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
19:57 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
19:58 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
19:59 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
19:59 -!- face [~face@80.72.82.160.coresnet.bg] has joined #bitcoin-core-dev
19:59 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev
19:59 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev
19:59 -!- ensign [~ensign@integer.musalbas.com] has joined #bitcoin-core-dev
19:59 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
19:59 -!- thrasher [~thrasher@unaffiliated/thrasher] has joined #bitcoin-core-dev
19:59 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev
19:59 -!- kakobrekla [~kako@unaffiliated/kakobrekla] has joined #bitcoin-core-dev
19:59 -!- Eliel [~jojkaart@163.172.153.251] has joined #bitcoin-core-dev
20:00 -!- conman1 [~conman@77.243.177.38] has quit []
20:14 -!- watersnake1 [~christian@24.61.159.12] has quit [Quit: Leaving.]
20:16 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Remote host closed the connection]
20:17 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-dev
20:21 -!- Raccoon [~Raccoon@194.35.233.173] has joined #bitcoin-core-dev
20:22 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
20:22 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
20:44 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Ping timeout: 265 seconds]
20:46 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
20:57 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
20:58 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
21:11 -!- T3 [~T3@173.231.109.130] has quit [Read error: Connection reset by peer]
21:11 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-dev
21:12 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
21:17 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 264 seconds]
21:41 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
21:42 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
21:52 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Quit: leaving]
21:58 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
21:59 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
21:59 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
22:00 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
22:09 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 240 seconds]
22:09 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
22:10 -!- arowser [~arowser1@192.69.88.248] has quit [Ping timeout: 264 seconds]
22:16 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
22:16 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
22:16 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 246 seconds]
22:16 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
22:30 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has joined #bitcoin-core-dev
22:30 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
22:30 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit]
22:33 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
22:36 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev
22:43 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds]
22:45 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #bitcoin-core-dev
22:47 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
22:47 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]
22:48 -!- MarcoFalke [~none@198.12.116.246] has quit [Quit: ZNC 1.7.1 - https://znc.in]
22:49 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev
22:49 -!- Cory [~Cory@unaffiliated/cory] has quit [Read error: No route to host]
22:49 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
22:49 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Read error: Connection reset by peer]
22:50 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev
22:50 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: No Ping reply in 180 seconds.]
22:50 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
22:52 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
22:53 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
22:56 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev
22:57 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 264 seconds]
23:00 -!- Raccoon [~Raccoon@194.35.233.173] has quit []
23:01 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
23:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
23:05 -!- arowser [~arowser1@192.69.88.248] has quit [Ping timeout: 260 seconds]
23:05 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has joined #bitcoin-core-dev
23:11 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
23:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:12 < bitcoin-git> [bitcoin] fanquake closed pull request #18153: doc/release-process: Restore and update PPA note (master...doc_ppa_202002) https://github.com/bitcoin/bitcoin/pull/18153
23:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:18 -!- arowser [~arowser1@192.69.88.248] has quit [Read error: Connection reset by peer]
23:19 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
23:20 -!- mikeyman77 [~mikeyman7@89.47.234.28] has joined #bitcoin-core-dev
23:22 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
23:23 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:24 < bitcoin-git> [bitcoin] fanquake closed pull request #17311: build: macOS fix background.svg (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17311
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
23:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:33 < bitcoin-git> [bitcoin] fanquake closed pull request #18133: Fix various edge case bugs in QValidatedLineEdit (master...bugfix_qvalidlineedit) https://github.com/bitcoin/bitcoin/pull/18133
23:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:38 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-dev
23:41 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
23:41 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
23:47 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:47 < bitcoin-git> [bitcoin] fanquake closed pull request #17877: qt, refactor: Make BitcoinUnits::Unit a scoped enum (master...20200105-scoped-enums) https://github.com/bitcoin/bitcoin/pull/17877
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:47 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
23:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:51 < bitcoin-git> [bitcoin] fanquake closed pull request #17659: qt: Do not block GUI thread in RPCConsole (master...20191203-nonblocking-rpcconsole) https://github.com/bitcoin/bitcoin/pull/17659
23:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:53 < fanquake> Does anyone actually use the gitian-build.py script with the --pull option? If so, can you take a look at #18336.
23:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18336 | script: Fix gitian-build.py --pull option by hebasto · Pull Request #18336 · bitcoin/bitcoin · GitHub
23:53 < fanquake> I don't think I've ever used that script.
23:59 -!- arowser [~arowser1@192.69.88.248] has quit [Ping timeout: 246 seconds]
--- Log closed Fri Aug 14 00:00:49 2020