--- Log opened Fri Aug 14 00:00:49 2020 00:01 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev 00:02 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 00:03 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 00:03 -!- arowser [~arowser1@192.69.88.248] has quit [Read error: Connection reset by peer] 00:04 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 00:06 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 265 seconds] 00:08 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds] 00:13 -!- lukedashjr is now known as luke-jr 00:16 < hebasto> fanquake: it's an easy and convenient way to make gitian build to test someone's pr 00:17 < hebasto> if --pull option is not used by other developers, it should me removed rather keeping in broken state 00:17 < fanquake> hebasto: thanks. I'm aware of what it does. Just want someone that actually uses it to look over your changes. 00:18 < fanquake> When I gitian build I generally just call gbuild directly. i.e: https://github.com/fanquake/core-review/tree/master/gitian-building#once-off-builds 00:22 < hebasto> this feature was introduced in #13765 00:22 < gribble> https://github.com/bitcoin/bitcoin/issues/13765 | contrib: add gitian build support for github pull request by ken2812221 · Pull Request #13765 · bitcoin/bitcoin · GitHub 00:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Quit: leaving] 00:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/609ce2d0da49...31760bb7c9f3 00:28 < bitcoin-git> bitcoin/master fa459bd MarcoFalke: rpc: Treat all args after a hidden arg as hidden as well 00:28 < bitcoin-git> bitcoin/master fa89ca9 MarcoFalke: refactor: Use C++11 range based for loops to simplify rpc code 00:28 < bitcoin-git> bitcoin/master fa50bdc MarcoFalke: rpc: Limit echo to 10 args 00:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:28 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19528: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) (master...2007-rpcMiscAssert) https://github.com/bitcoin/bitcoin/pull/19528 00:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 00:34 -!- face [~face@80.72.82.160.coresnet.bg] has quit [Ping timeout: 256 seconds] 00:36 -!- arowser [~arowser1@192.69.88.248] has quit [Ping timeout: 256 seconds] 00:41 -!- T3 [~T3@173.231.109.130] has quit [Read error: Connection reset by peer] 00:41 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-dev 00:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:44 < bitcoin-git> [bitcoin] fanquake opened pull request #19716: build: Qt 5.15.x (master...qt_5_15_x) https://github.com/bitcoin/bitcoin/pull/19716 00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:47 -!- T3 [~T3@173.231.109.130] has quit [Read error: Connection reset by peer] 00:48 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 01:00 -!- jonatack [~jon@134.19.179.147] has joined #bitcoin-core-dev 01:01 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 01:04 < jonatack> mini-nudge: #17204 has 3 acks 01:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub 01:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:05 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31760bb7c9f3...c0b170696432 01:05 < bitcoin-git> bitcoin/master e7448d6 Fabian Jahr: wallet: Don't override signing errors 01:05 < bitcoin-git> bitcoin/master c0b1706 fanquake: Merge #19568: Wallet should not override signing errors 01:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:05 < bitcoin-git> [bitcoin] fanquake merged pull request #19568: Wallet should not override signing errors (master...err_override) https://github.com/bitcoin/bitcoin/pull/19568 01:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:05 < jonatack> #19455 has 3 acks as well 01:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub 01:06 -!- face [~face@80.72.82.160.coresnet.bg] has joined #bitcoin-core-dev 01:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 01:12 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Ping timeout: 246 seconds] 01:23 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 01:24 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:25 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev 01:29 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 01:29 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has joined #bitcoin-core-dev 01:32 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Ping timeout: 240 seconds] 01:32 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 01:45 -!- jonatack [~jon@134.19.179.147] has quit [Ping timeout: 256 seconds] 01:47 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 01:49 < wumpus> jonasschnelli: thanks will take a look 01:50 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 01:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 01:59 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 02:00 -!- mikeyman77 [~mikeyman7@89.47.234.28] has quit [] 02:19 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 02:20 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-buhwceikvfquyquo] has quit [Quit: Connection closed for inactivity] 02:20 -!- vladan1 [~vladan@178.162.204.238] has joined #bitcoin-core-dev 02:22 -!- tryphe_ is now known as tryphe 02:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:22 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) (master...2008-rpcMisc) https://github.com/bitcoin/bitcoin/pull/19717 02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:26 -!- arowser [~arowser1@192.69.88.248] has quit [Ping timeout: 264 seconds] 02:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:29 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b170696432...dabab06a1a1a 02:29 < bitcoin-git> bitcoin/master 8d32d20 Jon Atack: test: consider generate covered in _get_uncovered_rpc_commands() 02:29 < bitcoin-git> bitcoin/master 92d94ff Jon Atack: rpc: print useful help and error message for generate 02:29 < bitcoin-git> bitcoin/master f0aa8ae Jon Atack: test: add rpc_generate functional test 02:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:30 < bitcoin-git> [bitcoin] laanwj merged pull request #19455: rpc generate: print useful help and error message (master...rpc-generate-helpful-error_message) https://github.com/bitcoin/bitcoin/pull/19455 02:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:49 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:50 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has quit [Quit: Pavlenex] 02:51 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 02:52 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 02:53 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:54 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dabab06a1a1a...4d4bd5ed7474 02:54 < bitcoin-git> bitcoin/master e629d07 Pieter Wuille: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code 02:54 < bitcoin-git> bitcoin/master dca2863 Jon Atack: test: ensure OP_1NEGATE satisfies BIP62 minimal push rule 02:54 < bitcoin-git> bitcoin/master 4d4bd5e Wladimir J. van der Laan: Merge #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in s... 02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:55 < bitcoin-git> [bitcoin] laanwj merged pull request #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) (master...201910_1negate_rebase) https://github.com/bitcoin/bitcoin/pull/17204 02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:01 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has joined #bitcoin-core-dev 03:01 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 03:09 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 03:12 -!- andreacab [~andreacab@2a02:1205:5078:21a0:7c1e:8828:a8bb:6827] has joined #bitcoin-core-dev 03:13 -!- andreacab [~andreacab@2a02:1205:5078:21a0:7c1e:8828:a8bb:6827] has quit [Remote host closed the connection] 03:14 -!- andreacab [~andreacab@2a02:1205:5078:21a0:7c1e:8828:a8bb:6827] has joined #bitcoin-core-dev 03:17 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 03:18 -!- Donavon55Shanaha [~Donavon55@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:19 -!- andreacab [~andreacab@2a02:1205:5078:21a0:7c1e:8828:a8bb:6827] has quit [Ping timeout: 260 seconds] 03:23 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Ping timeout: 264 seconds] 03:24 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 03:31 < wumpus> fanquake: no, I've never used that option, from what I remember, let's see 03:31 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 03:32 < wumpus> oh gitian-build not github-merge, no, I must shamefully admit have used that script one or twice for testing, I still have my own age-old gitian build script 03:33 < hebasto> it seems everyone uses its own self-crafted gitian build script :D 03:34 < wumpus> it has always been "oh it will work for now, no need to switch around scripts, this release we're going to switch to something else than gitian, right 😳 03:39 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 03:43 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 03:43 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Quit: Lost terminal] 03:44 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Ping timeout: 240 seconds] 03:46 < jonatack> i've basically been using fanquake's guide, slightly adapted for linux 03:49 -!- Donavon55Shanaha [~Donavon55@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 03:50 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 03:51 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 03:51 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 03:54 -!- davec [~davec@24.243.240.159] has joined #bitcoin-core-dev 03:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:59 -!- vasild_ is now known as vasild 04:00 < hebasto> how to conditionally skip a benchmark in nanobench framework? 04:20 < wumpus> maybe something with -filter= ? 04:20 < wumpus> it seems more suitable for running a subset than excluding a benchmark but still, depending on the regex subset supported it should be possible 04:21 < hebasto> wumpus: https://github.com/bitcoin/bitcoin/pull/18011#issuecomment-674026621 04:22 < wumpus> ok 04:23 -!- davec [~davec@24.243.240.159] has quit [Ping timeout: 256 seconds] 04:23 < wumpus> apparently I misinterpeted your questino in exactly the same way 04:24 < hebasto> sorry for misleading 04:24 -!- davec [~davec@24.243.240.159] has joined #bitcoin-core-dev 04:27 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has quit [Quit: Pavlenex] 04:28 < wumpus> I'm happy that Martinus still sticks around to provide support 04:29 < hebasto> very kind of him 04:37 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev 04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:44 < bitcoin-git> [bitcoin] hebasto opened pull request #19718: build, test: Add missed gcov files to 'make clean' (master...200814-gcno) https://github.com/bitcoin/bitcoin/pull/19718 04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:53 -!- promag [~promag@87-196-81-37.net.novis.pt] has joined #bitcoin-core-dev 04:54 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 05:00 -!- vladan1 [~vladan@178.162.204.238] has quit [] 05:07 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Remote host closed the connection] 05:08 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-dev 05:09 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Ping timeout: 256 seconds] 05:12 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Ping timeout: 240 seconds] 05:13 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 265 seconds] 05:16 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 256 seconds] 05:17 -!- kljasdfvv [~flack@p200300d46f11fb00214f95f247068b9d.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 05:20 -!- mattl1 [~mattl@217.146.82.202] has joined #bitcoin-core-dev 05:24 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 05:25 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-dev 05:25 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 05:39 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 05:44 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has joined #bitcoin-core-dev 05:45 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has quit [Client Quit] 05:51 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 05:52 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 05:55 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has joined #bitcoin-core-dev 05:55 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has quit [Client Quit] 05:57 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-lfkajrnzfrbhubex] has joined #bitcoin-core-dev 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d4bd5ed7474...1a43cd3f747f 05:59 < bitcoin-git> bitcoin/master 35cd2da Hennadii Stepanov: test: Fix 'make cov' with clang 05:59 < bitcoin-git> bitcoin/master 1a43cd3 MarcoFalke: Merge #19709: test: Fix 'make cov' with clang 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19709: test: Fix 'make cov' with clang (master...200813-lcov) https://github.com/bitcoin/bitcoin/pull/19709 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:01 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 06:01 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds] 06:05 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:06 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:06 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:06 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:07 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:07 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:07 -!- promag [~promag@87-196-81-37.net.novis.pt] has quit [Remote host closed the connection] 06:08 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:08 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 06:08 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:10 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:10 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:11 -!- Highway62 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 06:11 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:12 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:12 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:12 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds] 06:12 -!- Highway62 is now known as Highway61 06:13 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:13 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:14 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:14 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 06:15 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 06:22 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:23 -!- Highway62 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 06:24 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds] 06:24 -!- Highway62 is now known as Highway61 06:25 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 06:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19719: build: Add Werror=range-loop-analysis (master...2008-buildLoopErr) https://github.com/bitcoin/bitcoin/pull/19719 06:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:30 -!- mattl1 [~mattl@217.146.82.202] has quit [Remote host closed the connection] 06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:40 < bitcoin-git> [bitcoin] jonatack opened pull request #19720: test: bip157 p2p_blockfilters configuration options (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/19720 06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:46 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:47 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in] 06:48 -!- promag [~promag@87-196-81-37.net.novis.pt] has joined #bitcoin-core-dev 07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:02 < bitcoin-git> [bitcoin] adamjonas opened pull request #19721: doc: comment out unused MSG_FILTERED_WITNESS_BLOCK (master...2020_8_MSG_FILTERED_WITNESS_BLOCK_comment) https://github.com/bitcoin/bitcoin/pull/19721 07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:03 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:04 -!- alorente [~alorente@178.239.168.171] has joined #bitcoin-core-dev 07:06 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 07:06 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:09 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 07:13 -!- promag [~promag@87-196-81-37.net.novis.pt] has quit [Remote host closed the connection] 07:24 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Quit: ERC (IRC client for Emacs 26.3)] 07:24 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 07:25 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 07:30 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev 07:35 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 07:36 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 07:37 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 07:45 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Ping timeout: 240 seconds] 07:50 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has joined #bitcoin-core-dev 07:52 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 07:54 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 07:55 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 07:56 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 07:56 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:00 -!- alorente [~alorente@178.239.168.171] has quit [] 08:01 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev 08:09 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:10 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 08:10 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 08:11 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 08:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 08:17 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has joined #bitcoin-core-dev 08:19 -!- watersnake1 [~christian@24.61.159.12] has joined #bitcoin-core-dev 08:21 -!- watersnake1 [~christian@24.61.159.12] has quit [Client Quit] 08:35 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 08:47 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 08:48 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 08:48 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 08:55 -!- theGrg [~theGrg@s91904426.blix.com] has joined #bitcoin-core-dev 09:04 -!- fox2p [~fox2p@ec2-3-211-34-208.compute-1.amazonaws.com] has quit [Ping timeout: 256 seconds] 09:07 -!- fox2p [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has joined #bitcoin-core-dev 09:07 < jonatack> perhaps ban "Jssdr" for this spammy comment: https://github.com/bitcoin/bitcoin/issues/2086#issuecomment-674142837 09:09 < jonatack> and another one: https://github.com/bitcoin/bitcoin/issues/2086#issuecomment-674142837 09:10 < jonatack> sorry, https://github.com/bitcoin/bitcoin/issues/19161#issuecomment-674144469 09:36 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Ping timeout: 260 seconds] 09:58 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 10:01 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Remote host closed the connection] 10:04 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 10:05 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 10:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 10:15 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 240 seconds] 10:20 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 10:23 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 10:23 -!- fox2p [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has quit [Ping timeout: 256 seconds] 10:24 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 10:26 -!- fox2p [~fox2p@ec2-52-202-219-151.compute-1.amazonaws.com] has joined #bitcoin-core-dev 10:32 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 10:38 -!- K4TJANG [4daa085b@gateway/web/cgi-irc/kiwiirc.com/ip.77.170.8.91] has joined #bitcoin-core-dev 10:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 10:50 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has quit [Changing host] 10:50 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev 10:58 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 11:00 -!- theGrg [~theGrg@s91904426.blix.com] has quit [] 11:05 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 11:07 -!- Pavlenex [~Thunderbi@80.67.10.139.adsl.inet-telecom.org] has quit [Quit: Pavlenex] 11:08 < luke-jr> a shame that we're finally getting real progress toward splitting out the GUI, and now univalue is being pulled into it :x 11:09 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-dev 11:15 -!- watersnake1 [~christian@24.61.159.12] has joined #bitcoin-core-dev 11:20 -!- reallll is now known as belcher 11:21 -!- srimech1 [~srimech@217.146.82.202] has joined #bitcoin-core-dev 11:30 -!- Davterra [~Davterra@89.45.90.22] has quit [Quit: Leaving] 11:37 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Quit: Highway61] 11:40 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 11:43 -!- PaulTro__ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 11:47 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Ping timeout: 256 seconds] 11:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:54 < bitcoin-git> [bitcoin] torhte opened pull request #19722: [test] Add test for getblockheader verboseness (master...test-gbh) https://github.com/bitcoin/bitcoin/pull/19722 11:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:58 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 11:58 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 12:00 < meshcollider> #startmeeting 12:00 < lightningbot> Meeting started Fri Aug 14 19:00:14 2020 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < achow101> hi 12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr 12:00 < meshcollider> jeremyrubin emilengler jonatack hebasto jb55 12:00 < fjahr> hi 12:01 < meshcollider> Any topics this week? 12:02 < achow101> any wallet PRs in need of review? 12:02 < achow101> that are reasonably close to being merged? 12:02 < kanzure> hi 12:03 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 12:03 < fjahr> I think #14582 is interesting but long forgotten 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/14582 | wallet: always do avoid partial spends if fees are within a specified range by kallewoof · Pull Request #14582 · bitcoin/bitcoin · GitHub 12:03 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 12:03 < instagibbs> hi 12:04 -!- MasterdonX [~masterdon@198.204.231.150] has quit [Ping timeout: 260 seconds] 12:04 < fjahr> enough concept ACK now I think and a tested ACK from me so not super close but still 12:04 < meshcollider> achow101: time to review-beg for your coin selection PRs? 12:05 < jonatack> hi 12:05 < achow101> meshcollider: yep 12:05 < achow101> if sqlite is too big/scary to review, how about coin selection, almost as scary! 12:05 -!- MasterdonX [~masterdon@37.120.212.76] has joined #bitcoin-core-dev 12:05 < achow101> #17458 is close to being merged. 3 ACKs 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/17458 | Refactor OutputGroup effective value calculations and filtering to occur within the struct by achow101 · Pull Request #17458 · bitcoin/bitcoin · GitHub 12:06 < achow101> #17331 is next up in that stack 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub 12:07 < meshcollider> #16841 is also nearly rtm 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/16841 | Replace GetScriptForWitness with GetScriptForDestination by meshcollider · Pull Request #16841 · bitcoin/bitcoin · GitHub 12:09 < achow101> yes, getting that in would be nice 12:09 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 12:10 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 12:10 < meshcollider> Anything else anyone wants to discuss? Perhaps #19700 vs #19671 ? 12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/19671 | wallet: Remove -zapwallettxes by achow101 · Pull Request #19671 · bitcoin/bitcoin · GitHub 12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/19700 | wallet: Replace -zapwallettxes with wallet tool command by achow101 · Pull Request #19700 · bitcoin/bitcoin · GitHub 12:11 < achow101> 19700 feels way too involved for something that is barely used 12:11 < achow101> i prefer removing -zapwallettxes outright 12:12 < meshcollider> But jonasschnelli just reviewed it, does that mean he prefers it? 12:12 < achow101> good question 12:12 < meshcollider> people need to say "I prefer this one or this one" 12:13 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 12:13 < meshcollider> Well I don't think there is enough people online to discuss it much 12:14 < achow101> I think it's also reasonable to reintroduce it in the wallettool if people complain about it being gone 12:14 < meshcollider> Yes it doesn't need to be immediate if it's moving to the tool anyway 12:15 < meshcollider> #action Please take a look at those two PRs and comment your preference ^ 12:16 < meshcollider> I guess that's all for this week 12:16 < meshcollider> #endmeeting 12:16 < lightningbot> Meeting ended Fri Aug 14 19:16:07 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:16 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-14-19.00.html 12:16 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-14-19.00.txt 12:16 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-14-19.00.log.html 12:16 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 12:19 -!- watersnake1 [~christian@24.61.159.12] has quit [Quit: Leaving.] 12:19 -!- watersnake1 [~christian@24.61.159.12] has joined #bitcoin-core-dev 12:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 12:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 12:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:37 -!- snq [~random@84.17.61.213] has joined #bitcoin-core-dev 12:39 -!- snkey [~random@84.17.61.213] has joined #bitcoin-core-dev 12:39 -!- snkey [~random@84.17.61.213] has quit [Remote host closed the connection] 12:40 -!- snq [~random@84.17.61.213] has quit [Client Quit] 12:52 < jonasschnelli> Meshcollider: as for zaptx. I slightly prefer to keep the functionality (in an expert CLI tool). But no strong opinion. 12:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:53 < jonasschnelli> I remember some situation where this „sledge hammer“ rescued some stuck (non rbf) transactions. 12:53 < achow101> jonasschnelli: abandontransaction does that now 12:53 < jonasschnelli> abandontx may help... but it’s more complicated 12:54 < achow101> and removeprunedfunds as a slightly smaller sledgehammer 12:54 < jonasschnelli> I agree. I see it more as a function we could drag along for a while. 12:54 < jonasschnelli> Shouldn’t hurt 12:55 < achow101> I'd agree if we didn't have to drag along the metadata keeping part 12:55 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Quit: ZNC 1.8.0 - https://znc.in] 12:55 < jonasschnelli> Yeah... that’s a point. 12:55 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:56 < bitcoin-git> [bitcoin] sdaftuar opened pull request #19723: Ignore unknown messages before VERACK (master...2020-08-feature-negotiation) https://github.com/bitcoin/bitcoin/pull/19723 12:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:57 < jonasschnelli> As said. No strong opinion. 12:57 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-dev 13:00 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 13:01 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 13:13 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:20 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 13:21 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 13:27 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:28 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:39 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 13:58 -!- roconnor [~roconnor@host-45-58-247-78.dyn.295.ca] has quit [Ping timeout: 246 seconds] 14:00 -!- srimech1 [~srimech@217.146.82.202] has quit [] 14:15 -!- PaulTro__ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 14:17 < achow101> #16841 RTM? 14:18 < gribble> https://github.com/bitcoin/bitcoin/issues/16841 | Replace GetScriptForWitness with GetScriptForDestination by meshcollider · Pull Request #16841 · bitcoin/bitcoin · GitHub 14:21 -!- Hande [~Hande@89.47.234.28] has joined #bitcoin-core-dev 14:38 -!- Guest3 [~textual@114.23.246.137] has joined #bitcoin-core-dev 14:53 -!- Guest3 [~textual@114.23.246.137] has quit [Quit: irc client] 14:54 -!- Guest3 [~textual@114.23.246.137] has joined #bitcoin-core-dev 14:59 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 15:11 -!- fox2p [~fox2p@ec2-52-202-219-151.compute-1.amazonaws.com] has quit [Ping timeout: 246 seconds] 15:13 -!- fox2p [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has joined #bitcoin-core-dev 15:18 -!- Guest3 [~textual@114.23.246.137] has quit [Quit: irc client] 15:19 -!- kotare [~textual@114.23.246.137] has joined #bitcoin-core-dev 15:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:23 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #19724: [net] Cleanup connection type- followups (master...2020-08-conn-refactor-followups) https://github.com/bitcoin/bitcoin/pull/19724 15:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 15:30 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 15:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 15:52 -!- kotare [~textual@114.23.246.137] has quit [Quit: irc client] 15:53 -!- kotare [~kotare@114.23.246.137] has joined #bitcoin-core-dev 15:54 -!- kotare [~kotare@114.23.246.137] has quit [Client Quit] 15:54 -!- kotare [~kotare@114.23.246.137] has joined #bitcoin-core-dev 15:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:59 -!- vasild_ is now known as vasild 16:02 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:06 < fanquake> achow101: 👍 16:07 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 16:10 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Remote host closed the connection] 16:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 16:16 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 16:21 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 260 seconds] 16:23 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 16:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:33 -!- kotare [~kotare@114.23.246.137] has quit [Quit: irc client] 16:38 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:40 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:45 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/30dd562fd2c5...f269165edc03 16:45 < bitcoin-git> bitcoin/master 7d07e86 Andrew Chow: Use real value when calculating OutputGroup value 16:45 < bitcoin-git> bitcoin/master 9adc2f8 Andrew Chow: Refactor OutputGroups to handle effective values, fees, and filtering 16:45 < bitcoin-git> bitcoin/master f269165 Samuel Dobson: Merge #17458: Refactor OutputGroup effective value calculations and filter... 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:45 -!- promag [~promag@87.196.72.90] has joined #bitcoin-core-dev 16:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:46 < bitcoin-git> [bitcoin] meshcollider merged pull request #17458: Refactor OutputGroup effective value calculations and filtering to occur within the struct (master...cleanup-outputgroups) https://github.com/bitcoin/bitcoin/pull/17458 16:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:53 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 16:55 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:00 -!- Hande [~Hande@89.47.234.28] has quit [] 17:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:20 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f269165edc03...a0e75bd31dff 17:20 < bitcoin-git> bitcoin/master 642ad31 Russell Yanofsky: Add loadwallet and createwallet RPC load_on_startup options 17:20 < bitcoin-git> bitcoin/master a0e75bd Samuel Dobson: Merge #15937: Add loadwallet and createwallet load_on_startup options 17:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:22 < bitcoin-git> [bitcoin] meshcollider merged pull request #15937: Add loadwallet and createwallet load_on_startup options (master...pr/walset) https://github.com/bitcoin/bitcoin/pull/15937 17:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:22 -!- jackalope [~jackalope@178.239.168.171] has joined #bitcoin-core-dev 17:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:25 < bitcoin-git> [bitcoin] fanquake closed pull request #18992: qt: AddressBookPage - Hide non PKHash-Addresses and improve GUI messages for signing address book (master...202005-sign-message-ui) https://github.com/bitcoin/bitcoin/pull/18992 17:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:27 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 17:27 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 17:36 -!- Davterra [~Davterra@89.45.90.48] has joined #bitcoin-core-dev 17:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:55 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a0e75bd31dff...d052f5e6b79b 17:55 < bitcoin-git> bitcoin/master b887060 MeshCollider: Replace usage of GetScriptForWitness with GetScriptForDestination 17:55 < bitcoin-git> bitcoin/master fec8336 MeshCollider: Remove GetScriptForWitness function 17:55 < bitcoin-git> bitcoin/master 7966aa4 MeshCollider: Add variables for repeated scripts 17:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:55 -!- promag [~promag@87.196.72.90] has quit [Remote host closed the connection] 17:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:56 < bitcoin-git> [bitcoin] fanquake merged pull request #16841: Replace GetScriptForWitness with GetScriptForDestination (master...201909_remove_getscriptforwitness) https://github.com/bitcoin/bitcoin/pull/16841 17:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:58 -!- arowser [~arowser1@192.69.88.248] has quit [Ping timeout: 246 seconds] 17:59 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 18:18 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 18:22 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 240 seconds] 18:30 -!- K4TJANG [4daa085b@gateway/web/cgi-irc/kiwiirc.com/ip.77.170.8.91] has quit [Quit: Connection closed] 18:31 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 18:31 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 18:34 -!- kotare [~kotare@114.23.246.137] has joined #bitcoin-core-dev 18:56 -!- veleiro [~user@fsf/member/veleiro] has joined #bitcoin-core-dev 18:58 -!- kotare [~kotare@114.23.246.137] has quit [Quit: zzz] 19:02 -!- kotare [~kotare@114.23.246.137] has joined #bitcoin-core-dev 19:10 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 19:15 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 19:16 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:16 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d052f5e6b79b...4cde97374d5c 19:16 < bitcoin-git> bitcoin/master 6cb8771 Hennadii Stepanov: build: Add missed gcov files to 'make clean' 19:16 < bitcoin-git> bitcoin/master 4cde973 fanquake: Merge #19718: build: Add missed gcov files to 'make clean' 19:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:16 < bitcoin-git> [bitcoin] fanquake merged pull request #19718: build: Add missed gcov files to 'make clean' (master...200814-gcno) https://github.com/bitcoin/bitcoin/pull/19718 19:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:19 -!- watersnake1 [~christian@24.61.159.12] has quit [Quit: Leaving.] 19:20 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 19:21 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 244 seconds] 19:21 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 19:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 19:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:26 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #19725: [RPC] Add connection type to getpeerinfo (master...2020-08-getpeerinfo-conn-type) https://github.com/bitcoin/bitcoin/pull/19725 19:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:32 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 19:34 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:35 -!- tryphe_ is now known as tryphe 19:40 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 19:43 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 260 seconds] 19:47 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 264 seconds] 19:49 -!- kotare [~kotare@114.23.246.137] has quit [Quit: zzz] 19:49 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 264 seconds] 19:55 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 19:58 -!- peltre [sid268329@gateway/web/irccloud.com/x-uoadrinbctfvhdaw] has quit [Ping timeout: 272 seconds] 20:00 -!- jackalope [~jackalope@178.239.168.171] has quit [] 20:02 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 260 seconds] 20:02 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-kfbpqcvdpetzfvqw] has quit [Ping timeout: 240 seconds] 20:03 -!- nejon [sid38993@gateway/web/irccloud.com/x-xbiueewagouxsopq] has quit [Ping timeout: 272 seconds] 20:04 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 20:04 -!- GoldmanSats_ [sid428607@gateway/web/irccloud.com/x-jsdnoqgcxqwxudlx] has quit [Ping timeout: 244 seconds] 20:04 -!- drbrule [sid395654@gateway/web/irccloud.com/x-vlbhiwiacuanrtcq] has quit [Ping timeout: 244 seconds] 20:04 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-mouxatqhtdlynzvz] has quit [Ping timeout: 272 seconds] 20:05 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 20:06 -!- fanquake [sid369002@gateway/web/irccloud.com/x-gchstckizgcdxruc] has quit [Ping timeout: 246 seconds] 20:06 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 20:09 -!- kotare [~kotare@114.23.246.137] has joined #bitcoin-core-dev 20:09 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 265 seconds] 20:12 -!- kotare_ [~kotare@114.23.246.137] has joined #bitcoin-core-dev 20:12 -!- drbrule [sid395654@gateway/web/irccloud.com/x-ibdtyuuhgnierdgm] has joined #bitcoin-core-dev 20:12 -!- fanquake [sid369002@gateway/web/irccloud.com/x-lklkaxvdxuyioacy] has joined #bitcoin-core-dev 20:13 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-sijmrsuplnwiposl] has joined #bitcoin-core-dev 20:13 -!- kotare_ [~kotare@114.23.246.137] has quit [Client Quit] 20:15 -!- kotare [~kotare@114.23.246.137] has quit [Ping timeout: 240 seconds] 20:15 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 20:17 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-sijmrsuplnwiposl] has quit [Ping timeout: 272 seconds] 20:19 -!- drbrule [sid395654@gateway/web/irccloud.com/x-ibdtyuuhgnierdgm] has quit [Ping timeout: 272 seconds] 20:20 -!- fanquake [sid369002@gateway/web/irccloud.com/x-lklkaxvdxuyioacy] has quit [Ping timeout: 244 seconds] 20:20 -!- paxed1 [~paxed@178.162.204.238] has joined #bitcoin-core-dev 20:23 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 244 seconds] 20:23 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-aqazanlcsasaeurf] has joined #bitcoin-core-dev 20:24 -!- fanquake [sid369002@gateway/web/irccloud.com/x-gmsxsfstdzsulgeg] has joined #bitcoin-core-dev 20:24 -!- drbrule [sid395654@gateway/web/irccloud.com/x-wsixavohwtctgxzt] has joined #bitcoin-core-dev 20:27 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 20:27 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 20:28 -!- nejon [sid38993@gateway/web/irccloud.com/x-brtbkbmtkonriipw] has joined #bitcoin-core-dev 20:29 -!- GoldmanSats_ [sid428607@gateway/web/irccloud.com/x-bjgpubviiayoylxc] has joined #bitcoin-core-dev 20:31 -!- peltre [sid268329@gateway/web/irccloud.com/x-nytfjnuxesrlmope] has joined #bitcoin-core-dev 20:32 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-jferurwjzkjcmwcg] has joined #bitcoin-core-dev 20:34 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 20:49 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 260 seconds] 20:55 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.9] 20:59 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 21:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 21:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:02 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 21:05 -!- fox2p [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has quit [Ping timeout: 264 seconds] 21:08 -!- fox2p [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has joined #bitcoin-core-dev 21:13 -!- fox2p_ [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has joined #bitcoin-core-dev 21:13 -!- fox2p [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 21:14 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 260 seconds] 21:16 -!- fox2p [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has joined #bitcoin-core-dev 21:17 -!- fox2p_ [~fox2p@cpe-66-108-40-125.nyc.res.rr.com] has quit [Ping timeout: 256 seconds] 21:27 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 21:35 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 244 seconds] 21:47 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 21:48 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 22:05 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 22:19 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 22:23 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 240 seconds] 22:34 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 22:35 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 22:51 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 22:52 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 22:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:53 < bitcoin-git> [bitcoin] dhruv opened pull request #19727: test: Removing unused classes from p2p_leak.py (master...test-p2p-leak) https://github.com/bitcoin/bitcoin/pull/19727 22:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:57 < bitcoin-git> [bitcoin] sipa opened pull request #19728: Increase the ip address relay branching factor for unreachable networks (master...202008_increase_addr_branching) https://github.com/bitcoin/bitcoin/pull/19728 22:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:00 -!- paxed1 [~paxed@178.162.204.238] has quit [] 23:02 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has quit [Quit: Leaving] 23:06 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 23:09 -!- arowser [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 23:10 -!- arowser [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 23:11 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:21 -!- SRV_DW20 [~SRV_DW20@217.146.82.202] has joined #bitcoin-core-dev 23:37 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 256 seconds] 23:37 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has joined #bitcoin-core-dev 23:56 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev --- Log closed Sat Aug 15 00:00:22 2020