--- Log opened Fri Aug 28 00:00:01 2020 00:00 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 00:00 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 272 seconds] 00:00 -!- jonatack [~jon@37.164.15.34] has joined #bitcoin-core-dev 00:00 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 00:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 00:04 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 00:06 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 00:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:09 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/89a6bb924571...aee9d2306ad1 00:09 < bitcoin-git> bitcoin/0.19 2ea826c Suhas Daftuar: Add txids with non-standard inputs to reject filter 00:09 < bitcoin-git> bitcoin/0.19 52c3bec Gregory Sanders: test addition of unknown segwit spends to txid reject filter 00:09 < bitcoin-git> bitcoin/0.19 aee9d23 Jonas Schnelli: Merge #19681: 0.19: Add txids with non-standard inputs to reject filter 00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:09 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #19681: 0.19: Add txids with non-standard inputs to reject filter (0.19...2020-08-reject-unknown-wit-0.19) https://github.com/bitcoin/bitcoin/pull/19681 00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:22 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has joined #bitcoin-core-dev 00:25 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Ping timeout: 264 seconds] 00:26 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 00:34 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 00:35 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9ca6:af14:2fd6:b79f] has quit [Remote host closed the connection] 00:35 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9ca6:af14:2fd6:b79f] has joined #bitcoin-core-dev 00:35 -!- eugene99 [43f725ba@cpe-67-247-37-186.nyc.res.rr.com] has joined #bitcoin-core-dev 00:36 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:1dfd:ce35:e04e:8101] has joined #bitcoin-core-dev 00:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9ca6:af14:2fd6:b79f] has quit [Ping timeout: 244 seconds] 00:42 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:1dfd:ce35:e04e:8101] has quit [Remote host closed the connection] 00:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:43 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19629: refactor: Keep mempool interface in validation (master...2007-nomem) https://github.com/bitcoin/bitcoin/pull/19629 00:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:45 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 00:55 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:55 < MarcoFalke> gwillen: Are you aware of git range-diff ? This helps re-reviewing a fixed up version of the changes, and it "hides" any rebases that happened in between. 00:59 < sipa> MarcoFalke: TIL 00:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 01:01 < MarcoFalke> Well, it can also be used to review rebases and see what manual changes were needed to rebase. 01:02 < aj> oops, looking at rust-bitcoin and misread "macro_rules!" as "marco_rules!" 01:02 < MarcoFalke> Though, it doesn't work for large rewrites... In which case you are better of reviewing from scratch anyway 01:02 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 244 seconds] 01:03 < MarcoFalke> macro fake 01:04 < sipa> in c++ most uses of marcos have been replaced with templates, thankfully 01:17 -!- sr_gi [~sr_gi@static-75-213-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 01:20 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 01:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has joined #bitcoin-core-dev 01:27 < vasild> Has it been considered before importing an external library into bitcoin core as a git submodule? 01:30 < vasild> I am trying to add a stripped version of crypto++ - just the bits that do sha3-256, but it is all tied together by internal dependencies, so the process may end up importing e.g. 80% of the library source 01:36 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 01:36 -!- openstackstatus1 [~openstack@178.239.168.171] has quit [Remote host closed the connection] 01:36 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 01:39 < MarcoFalke> Which dependency is tor using? 01:41 -!- eugene99 [43f725ba@cpe-67-247-37-186.nyc.res.rr.com] has quit [Ping timeout: 245 seconds] 01:42 < vasild> let me see... 01:43 -!- jeremyrubin [~jr@2601:645:c200:f539:10b:1840:c70a:412a] has quit [Ping timeout: 240 seconds] 01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:43 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19826: Pass mempool reference to chainstate constructor (master...2008-valMemRef) https://github.com/bitcoin/bitcoin/pull/19826 01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:44 -!- eugene70 [43f725ba@cpe-67-247-37-186.nyc.res.rr.com] has joined #bitcoin-core-dev 01:44 < sipsorcery> vasild: it may not be of any use but this is the repo I used as a basis for a keccak hash https://github.com/ethereum/ethash/tree/master/src/libethash 01:45 < sipsorcery> I only ended up needing two classes and 4 headers and no external dependencies 01:45 -!- IPGlider [~IPGlider@45.76.34.219] has joined #bitcoin-core-dev 01:46 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 01:52 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 260 seconds] 01:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:58 < vasild> MarcoFalke: tor could use openssl as an external dependency or src/ext/keccak-tiny 01:59 < MarcoFalke> well, then copy src/ext/keccak-tiny for now ;) 02:00 < vasild> https://gitlab.torproject.org/legacy/trac/-/issues/17783 02:04 -!- kexkey [~kexkey@89.36.78.166] has quit [Ping timeout: 265 seconds] 02:07 -!- jonatack [~jon@37.164.15.34] has quit [Read error: Connection reset by peer] 02:22 -!- krazyj [~krazyj@77.243.177.38] has joined #bitcoin-core-dev 02:22 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 02:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has quit [Remote host closed the connection] 02:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has joined #bitcoin-core-dev 02:29 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has quit [Ping timeout: 240 seconds] 02:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 02:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:33 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19827: init: Disallow negation of blockversion (master...2008-parseBoolBlockVersion) https://github.com/bitcoin/bitcoin/pull/19827 02:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:35 < wumpus> vasild: I woudl suggest finding a stand-alone implementation of SHA3, a reminder: it does not need to be efficient 02:35 < wumpus> we're not going to take up a subtree of submodule just for this 02:36 < wumpus> MarcoFalke: exactly, a tiny implementation (as far as possible for something like Keccak) is preferred here 02:37 < vasild> I gave up with crypto++ after it turned out that it is not possible to take just sha3.h and sha3.cpp from its implementation (I don't want to do any modificatoins of those imported files) 02:38 < vasild> looking at https://github.com/coruus/keccak-tiny now 02:39 < wumpus> sure, I understand you don't want to end up maintaining this, but I wouldn't say small modifications (e.g. type names) are a problem to fit it better in our repository 02:39 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 02:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:39 < wumpus> nice 02:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:41 < vasild> I also added a wrapper class SHA3_256 that has the same interface as our existing hashers: Write(), Finalize() and Reset() methods. 02:42 < wumpus> awesome, it's good to be consistent about that 02:42 < vasild> yeah, would also help if we decide to ditch whatever we have imported and import something else 02:43 < fanquake> That certainly looks better than random Tor code, git submodules, OpenSSL or other shared libs 02:43 < wumpus> exactly 02:43 < vasild> :-) 02:43 < wumpus> we were getting scared for a bit 02:43 < vasild> fear not! :-D 02:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has joined #bitcoin-core-dev 02:46 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 02:54 < kallewoof> Weirdly, one of my linux machines complains that ./optional.h:24 ('static auto& nullopt = boost::none;') is unused in like 40+ places; it looks correct, but none of my other machines give me that warning no matter what flags I try (the specified -Wunused-variable is already present, I think)... 03:18 -!- Jaren26Bogisich [~Jaren26Bo@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:22 < wumpus> isn't *const* missing? 03:22 < wumpus> or constexpr 03:24 < wumpus> it doesn't look right if you can assign something else to nullopt, and also, this is likely the reason you get a warning when including the file and not using nullopt 03:26 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 03:32 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 03:32 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 03:34 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 244 seconds] 03:37 -!- Jaren26Bogisich [~Jaren26Bo@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 258 seconds] 03:37 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 03:41 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has quit [Remote host closed the connection] 03:41 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has joined #bitcoin-core-dev 03:42 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has quit [Remote host closed the connection] 03:42 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has joined #bitcoin-core-dev 03:46 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has quit [Ping timeout: 240 seconds] 03:46 -!- cato_ [~cato@gateway/tor-sasl/alec] has quit [Remote host closed the connection] 03:51 -!- cato_ [~cato@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 03:58 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 260 seconds] 03:59 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:59 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 04:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 04:09 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 04:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 04:15 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has joined #bitcoin-core-dev 04:19 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has quit [Ping timeout: 240 seconds] 04:42 -!- roconnor [~roconnor@host-184-164-25-9.dyn.295.ca] has joined #bitcoin-core-dev 04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:46 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/862fde88be70...4326515f01d7 04:46 < bitcoin-git> bitcoin/master df53688 Carl Dong: chain: Remove UB CChain comparison 04:46 < bitcoin-git> bitcoin/master 4326515 fanquake: Merge #19822: chain: Fix CChain comparison UB by removing it (it was unuse... 04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:46 < bitcoin-git> [bitcoin] fanquake merged pull request #19822: chain: Fix CChain comparison UB by removing it (it was unused) (master...2020-08-chain-comparison-UB) https://github.com/bitcoin/bitcoin/pull/19822 04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:50 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has joined #bitcoin-core-dev 04:54 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:450e:20bd:d6b:9c75] has quit [Ping timeout: 244 seconds] 05:00 -!- krazyj [~krazyj@77.243.177.38] has quit [] 05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:03 < bitcoin-git> [bitcoin] promag opened pull request #19828: wallet, refactor: Remove duplicate map lookups in GetAddressBalances (master...2020-08-getaddressbalances) https://github.com/bitcoin/bitcoin/pull/19828 05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:22 -!- DocScrutinizer [~DocScruti@s91904426.blix.com] has joined #bitcoin-core-dev 05:22 -!- DocScrutinizer is now known as Guest2955 05:30 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:33 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has joined #bitcoin-core-dev 05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:37 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4326515f01d7...1dac4dcf088f 05:37 < bitcoin-git> bitcoin/master 9034f6e Hennadii Stepanov: Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations 05:37 < bitcoin-git> bitcoin/master 1dac4dc fanquake: Merge #19758: Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR an... 05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:37 < bitcoin-git> [bitcoin] fanquake merged pull request #19758: Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations (master...200818-tsa) https://github.com/bitcoin/bitcoin/pull/19758 05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:38 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has quit [Ping timeout: 272 seconds] 05:55 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 05:55 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:04 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:04 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Quit: Leaving] 06:04 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:05 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 06:06 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:06 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:07 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:07 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 06:07 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:11 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:11 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev 06:11 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:12 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:12 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:13 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:13 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:19 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:19 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:20 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:24 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1dac4dcf088f...22acd36d5365 06:24 < bitcoin-git> bitcoin/master c91b241 Jake Leventhal: Updated outdated help command for getblocktemplate (fixes #19625) 06:24 < bitcoin-git> bitcoin/master 22acd36 Wladimir J. van der Laan: Merge #19646: doc: Updated outdated help command for getblocktemplate 06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:25 < bitcoin-git> [bitcoin] laanwj merged pull request #19646: doc: Updated outdated help command for getblocktemplate (master...fix-outdated-getblocktemplate-help) https://github.com/bitcoin/bitcoin/pull/19646 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:29 -!- kljasdfvv [~flack@p200300d46f11fb0008365d1f8671b886.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 06:30 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:40 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:40 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:51 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:51 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:53 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 06:53 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 06:53 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:08 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 07:08 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 07:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 07:13 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev 07:28 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Quit: WeeChat 2.9] 07:28 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev 07:29 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Client Quit] 07:32 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev 07:33 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 07:34 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 07:36 -!- Pavlenex [~Thunderbi@178.220.106.96] has joined #bitcoin-core-dev 07:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:51 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22acd36d5365...9632b7edc748 07:51 < bitcoin-git> bitcoin/master d3e8adf Sebastian Falbesoner: util: remove c-string interfaces for DecodeBase58{Check} 07:51 < bitcoin-git> bitcoin/master 9632b7e Wladimir J. van der Laan: Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}... 07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:52 < bitcoin-git> [bitcoin] laanwj merged pull request #19739: refactor: remove c-string interfaces for DecodeBase58{Check} (master...20200811-util-remove-cstring-decodebase58) https://github.com/bitcoin/bitcoin/pull/19739 07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:00 -!- Guest2955 [~DocScruti@s91904426.blix.com] has quit [] 08:02 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 08:03 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 08:09 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 08:20 -!- Pavlenex1 [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19827: init: Disallow negation of blockversion (master...2008-parseBoolBlockVersion) https://github.com/bitcoin/bitcoin/pull/19827 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:22 -!- atiti [~atiti@94.229.74.91] has joined #bitcoin-core-dev 08:22 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 08:22 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 08:22 -!- troygior1hev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev 08:24 -!- Pavlenex [~Thunderbi@178.220.106.96] has quit [Ping timeout: 246 seconds] 08:24 -!- Pavlenex1 is now known as Pavlenex 08:25 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 240 seconds] 08:27 -!- xurzua [~xurzua@181.74.31.104] has joined #bitcoin-core-dev 08:28 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 08:29 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 08:32 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 272 seconds] 08:32 -!- kexkey [~kexkey@89.36.78.166] has joined #bitcoin-core-dev 08:32 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 08:35 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 08:39 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 08:46 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 08:53 -!- atiti [~atiti@94.229.74.91] has quit [Ping timeout: 240 seconds] 08:53 -!- xurzua [~xurzua@181.74.31.104] has quit [Quit: xurzua] 08:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:53 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9632b7edc748...5edef20a65f0 08:53 < bitcoin-git> bitcoin/master 7b6d0f1 Raúl Martínez (RME): Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messa... 08:53 < bitcoin-git> bitcoin/master 5edef20 MarcoFalke: Merge #19797: net: Remove old check for 3-byte shifted IP addresses from p... 08:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:54 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19797: net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19797 08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:56 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has joined #bitcoin-core-dev 08:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5edef20a65f0...ca30d34cf94b 08:56 < bitcoin-git> bitcoin/master 4227a8e Hennadii Stepanov: qt: Make "Create new receiving address" default unconditionally 08:56 < bitcoin-git> bitcoin/master 4ec49f8 Hennadii Stepanov: qt: Leverage the default "Create new receiving address" button 08:56 < bitcoin-git> bitcoin/master ca30d34 MarcoFalke: Merge bitcoin-core/gui#39: Add visual accenting for the 'Create new receiv... 08:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:57 -!- hiNikolay [b9a5a0d1@185.165.160.209] has joined #bitcoin-core-dev 09:01 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has quit [Ping timeout: 272 seconds] 09:03 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 09:03 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 09:08 -!- troygior1hev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Quit: leaving] 09:14 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 09:15 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 09:18 -!- jeremyrubin [~jr@2601:645:c200:f539:10b:1840:c70a:412a] has joined #bitcoin-core-dev 09:30 -!- wjp1 [~wjp@195.181.170.239] has joined #bitcoin-core-dev 09:37 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 09:40 -!- yancy [~root@li1543-67.members.linode.com] has quit [Ping timeout: 256 seconds] 09:40 -!- vincenzopalazzo [~vincent@host-79-26-113-47.retail.telecomitalia.it] has joined #bitcoin-core-dev 09:42 -!- Pavlenex1 [~Thunderbi@178.220.106.96] has joined #bitcoin-core-dev 09:42 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Read error: Connection reset by peer] 09:42 -!- Pavlenex1 is now known as Pavlenex 10:00 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 10:00 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 10:03 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 240 seconds] 10:03 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 10:03 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 10:03 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 10:08 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 10:09 -!- Pavlenex [~Thunderbi@178.220.106.96] has quit [Quit: Pavlenex] 10:09 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 10:17 -!- Pavlenex [~Thunderbi@178.220.106.96] has joined #bitcoin-core-dev 10:30 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 10:32 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 10:32 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 10:33 -!- Pavlenex [~Thunderbi@178.220.106.96] has quit [Quit: Pavlenex] 10:33 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 10:43 < jnewbery> wumpus: #19607 may be ready for merge if you're happy with it 10:43 < gribble> https://github.com/bitcoin/bitcoin/issues/19607 | [p2p] Add Peer struct for per-peer data in net processing by jnewbery · Pull Request #19607 · bitcoin/bitcoin · GitHub 10:50 -!- dkrm [~dkrm@2001:41d0:8:3f7b::1] has joined #bitcoin-core-dev 10:51 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 10:56 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:57 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has joined #bitcoin-core-dev 11:00 -!- wjp1 [~wjp@195.181.170.239] has quit [] 11:02 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has quit [Ping timeout: 272 seconds] 11:08 < wumpus> jnewbery: let's see! 11:15 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 11:16 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 11:21 -!- frank001 [~frank001@185.163.110.125] has joined #bitcoin-core-dev 11:24 < jonatack> maybe #19405 too 11:24 < gribble> https://github.com/bitcoin/bitcoin/issues/19405 | rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo` by jonatack · Pull Request #19405 · bitcoin/bitcoin · GitHub 11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:29 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ca30d34cf94b...1cf73fb8eba3 11:29 < bitcoin-git> bitcoin/master aba0335 John Newbery: [net processing] Remove CNodeState.name 11:29 < bitcoin-git> bitcoin/master 7cd4159 John Newbery: [net processing] Add Peer 11:29 < bitcoin-git> bitcoin/master 1f96d2e John Newbery: [net processing] Move misbehavior tracking state to Peer 11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:30 < bitcoin-git> [bitcoin] laanwj merged pull request #19607: [p2p] Add Peer struct for per-peer data in net processing (master...2020-07-peer) https://github.com/bitcoin/bitcoin/pull/19607 11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:35 -!- twistedline [~twisted@2601:14d:8500:26c0:4cd4:a5d4:63e1:828f] has joined #bitcoin-core-dev 11:35 -!- twistedline [~twisted@2601:14d:8500:26c0:4cd4:a5d4:63e1:828f] has quit [Changing host] 11:35 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 11:40 < jonatack> Looks like merging doesn't remove a PR from Chasing Concept ACK in https://github.com/bitcoin/bitcoin/projects/8 11:40 < jonatack> :) 11:41 < jonatack> at least, not automatically 11:43 < sipa> better Concept ACK is quickly 11:46 < luke-jr> lol 11:50 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 12:00 < meshcollider> jonatack: indeed, same with high priority and everything, still need to manually remove after merge 12:00 < meshcollider> #startmeeting 12:00 < lightningbot> Meeting started Fri Aug 28 19:00:12 2020 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr 12:00 < meshcollider> jeremyrubin emilengler jonatack hebasto jb55 12:00 < provoostenator> hi 12:00 < achow101> hi 12:00 < meshcollider> Topics this week? 12:01 < provoostenator> No topics from me. I rebased a bunch of things. 12:02 < meshcollider> There are a few PRs that need review (from myself included) at the moment 12:02 < kanzure> hi 12:02 < achow101> just waiting on some reviews 12:02 < provoostenator> And just got back from vacation, so will do more review soon(tm) 12:02 < luke-jr> just a few? :P 12:02 < meshcollider> Always a few :) 12:02 < achow101> soon(tm) 12:03 < meshcollider> So hopefully we can tick off some bigger things this upcoming week 12:03 < provoostenator> Yeah, SQLite, Taproot wallet, OP_SECURE_THE_BAG support, should be doable. 12:04 < meshcollider> :D 12:04 < achow101> don't forget hardware wallets 12:04 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 12:05 < provoostenator> Can we get fast rescan while we're at it? 12:05 < sipa> paypal integration? 12:05 < provoostenator> I keep forgetting to disable debug mode when I open ancient wallets 12:05 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 12:06 < jonatack> hi 12:06 < provoostenator> Or maybe just a way to turn off debug mode without recompiling :-) 12:07 < achow101> I'd like to shill for #19619 12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/19619 | Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp by ryanofsky · Pull Request #19619 · bitcoin/bitcoin · GitHub 12:07 -!- Pavlenex [~Thunderbi@178.220.106.96] has joined #bitcoin-core-dev 12:07 < meshcollider> achow101: I am mid-way through reviewing that 12:07 < achow101> as that's a requirement for sqlite wallets now 12:07 -!- Pavlenex [~Thunderbi@178.220.106.96] has quit [Client Quit] 12:08 < meshcollider> But Marco's comment needs addressing anyway 12:08 < sipa> provoostenator: what is debug mode? 12:09 < provoostenator> --enable-debug 12:09 < provoostenator> Which slows rescan down enourmously 12:10 < achow101> I think phantomcircuit had something for rescanning on the block filters 12:10 < achow101> or was working on something for that 12:10 < provoostenator> I think MarcoFalke had a PR, but closed it. 12:10 < provoostenator> Indeed using filters 12:10 < provoostenator> There were some hairy issues around refilling the keypool and updating the filters. 12:11 < jonatack> I plan to get to the #11413 follow-ups soon, e.g. tests, cleanups, and universal explicit feerate argument for RPCs. Needed before feature freeze. 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub 12:11 < jonatack> RN we're overriding conf_target, which is a little confusing/scary 12:11 < provoostenator> jonatack: nice, feel free to tag me on it 12:11 < jonatack> will do 12:12 < meshcollider> Yeah, #15845 12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/15845 | wallet: Fast rescan with BIP157 block filters by MarcoFalke · Pull Request #15845 · bitcoin/bitcoin · GitHub 12:12 < provoostenator> Also let me know if there's anything in #16378 that needs changing for your vision of universal fee rates. 12:12 < jonatack> provoostenator: enable-debug slows down everything by ~half for me anyway 12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/16378 | The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub 12:12 < provoostenator> More like 10x for rescan 12:13 < provoostenator> But I can never be bothered to stop. 12:13 < jonatack> provoostenator: mentioned that PR to moneyball recently, will review/test it 12:13 < meshcollider> Ok so basically #action review lots! 12:13 < achow101> just review every PR tagged wallet 12:14 < jonatack> (ultimate send rpc) 12:14 < meshcollider> #endmeeting 12:14 < lightningbot> Meeting ended Fri Aug 28 19:14:22 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:14 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-28-19.00.html 12:14 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-28-19.00.txt 12:14 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-28-19.00.log.html 12:14 < provoostenator> One reason I made that PR is that people didn't like overloading arguments like conf_target even more 12:14 < jonatack> I should review 16378 asap actually 12:15 < jnewbery> thanks wumpus! 12:21 -!- hiNikolay [b9a5a0d1@185.165.160.209] has quit [Remote host closed the connection] 12:21 < achow101> wen miniscript? 12:22 < sipa> i'll get back to it some time; too many other things to work on right now 12:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 12:51 -!- eugene70 [43f725ba@cpe-67-247-37-186.nyc.res.rr.com] has quit [Remote host closed the connection] 13:04 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 13:26 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 13:27 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 13:29 -!- Anduck [~Anduck@unaffiliated/anduck] has quit [Quit: leaving] 13:30 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 13:31 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 13:34 -!- eugene72 [43f725ba@cpe-67-247-37-186.nyc.res.rr.com] has joined #bitcoin-core-dev 13:43 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has joined #bitcoin-core-dev 13:45 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 13:48 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has quit [Ping timeout: 260 seconds] 13:49 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:52 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 14:00 -!- frank001 [~frank001@185.163.110.125] has quit [] 14:01 -!- eugene72 [43f725ba@cpe-67-247-37-186.nyc.res.rr.com] has quit [Quit: Ping timeout (120 seconds)] 14:02 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 14:06 -!- eugene71 [43f725ba@cpe-67-247-37-186.nyc.res.rr.com] has joined #bitcoin-core-dev 14:10 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 14:11 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 14:11 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 14:21 -!- ferringb [~ferringb@89.47.234.28] has joined #bitcoin-core-dev 14:28 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 14:30 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 14:34 -!- dkrm [~dkrm@2001:41d0:8:3f7b::1] has quit [Ping timeout: 272 seconds] 14:47 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Remote host closed the connection] 14:48 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 14:57 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:05 -!- eugene71 [43f725ba@cpe-67-247-37-186.nyc.res.rr.com] has quit [Ping timeout: 245 seconds] 15:08 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 15:17 -!- jeremyrubin [~jr@2601:645:c200:f539:10b:1840:c70a:412a] has quit [Ping timeout: 240 seconds] 15:26 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 15:26 < phantomcircuit> achow101, i have something but kept getting frustrated because the organization of the gcs block filter stuff just seems wrong, it's really hard to extend without h4x 15:27 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 15:29 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 15:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has joined #bitcoin-core-dev 15:45 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 15:46 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:a9ec:4da6:bcca:eafc] has joined #bitcoin-core-dev 15:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:691f:fe9f:df18:31d9] has quit [Ping timeout: 272 seconds] 15:55 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 15:56 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 15:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:58 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 16:00 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 16:01 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 16:19 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:a9ec:4da6:bcca:eafc] has quit [Ping timeout: 244 seconds] 16:22 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 16:22 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 16:31 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 16:32 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 16:33 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 240 seconds] 16:47 -!- jeremyrubin [~jr@c-24-4-56-108.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 16:50 < ariard> sdaftuar: we may have another slight improvement to eviction logic after #19670, if our slots are full we actually reject inbound connection from past IsDiscouraged peers 16:50 < gribble> https://github.com/bitcoin/bitcoin/issues/19670 | Protect localhost and block-relay-only peers from eviction by sdaftuar · Pull Request #19670 · bitcoin/bitcoin · GitHub 16:50 < ariard> but we don't pick them up as prioritized candidates for eviction if they're already connected to us and we get a new inbound 16:54 < ariard> as a first heuristic we could iterate on all IsDiscouraged and randomly pick out for eviction, thus biasing towards not-known-misbehaving peers 16:57 < sipa> ariard: discouraged peers have m_prefer_evict set, which goes into the eviction logic 17:00 -!- ferringb [~ferringb@89.47.234.28] has quit [] 17:02 < ariard> sipa: right, in fact that's already heuristic "If any remaining peers are preferred for eviction consider only them", thanks 17:14 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 17:17 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 17:22 -!- suriro [~suriro@89.47.234.28] has joined #bitcoin-core-dev 17:29 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer] 17:29 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 17:39 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has quit [Ping timeout: 240 seconds] 17:43 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 17:57 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 240 seconds] 18:15 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 18:15 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:16 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 18:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds] 18:20 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 18:21 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 18:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:10 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 19:11 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 19:19 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 264 seconds] 19:19 -!- cato_ [~cato@gateway/tor-sasl/alec] has quit [Ping timeout: 240 seconds] 19:20 -!- cato_ [~cato@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 19:39 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 19:39 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 20:00 -!- suriro [~suriro@89.47.234.28] has quit [] 20:01 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 20:02 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 20:03 -!- sr_gi [~sr_gi@static-75-213-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 20:03 -!- sr_gi [~sr_gi@static-75-213-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 20:16 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:a9ec:4da6:bcca:eafc] has joined #bitcoin-core-dev 20:16 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 20:19 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 20:21 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:a9ec:4da6:bcca:eafc] has quit [Ping timeout: 272 seconds] 20:22 -!- mmalecki [~mmalecki@195.181.170.239] has joined #bitcoin-core-dev 20:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:22 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 21:23 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 21:56 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 21:57 -!- wallet42_ [sid154231@gateway/web/irccloud.com/x-hwhlmefxzyxrngtu] has quit [Ping timeout: 240 seconds] 21:58 -!- wallet42_ [sid154231@gateway/web/irccloud.com/x-wpjdpdpszehscbap] has joined #bitcoin-core-dev 22:00 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 22:01 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 240 seconds] 22:01 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-pliusfrdjxnwtarg] has quit [Ping timeout: 240 seconds] 22:01 -!- bosma [sid103570@gateway/web/irccloud.com/x-hicmnupxclcgisdf] has quit [Ping timeout: 240 seconds] 22:01 -!- ppisati [~ppisati@net-188-153-155-31.cust.vodafonedsl.it] has quit [Ping timeout: 240 seconds] 22:01 -!- ppisati [~ppisati@net-188-153-155-31.cust.vodafonedsl.it] has joined #bitcoin-core-dev 22:01 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Ping timeout: 240 seconds] 22:01 -!- endogenic [sid145991@gateway/web/irccloud.com/x-mqzyltwqpijjztli] has quit [Ping timeout: 240 seconds] 22:02 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-zkcrfwbsceojwwxo] has joined #bitcoin-core-dev 22:02 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 240 seconds] 22:02 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 240 seconds] 22:02 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-lumihbwcgnigcxnv] has quit [Ping timeout: 240 seconds] 22:02 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 22:03 -!- dviola [~diego@189.7.69.189] has joined #bitcoin-core-dev 22:03 -!- bosma [sid103570@gateway/web/irccloud.com/x-ntiubfsbexnojyqr] has joined #bitcoin-core-dev 22:04 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-uewaaigdwwnbtdke] has joined #bitcoin-core-dev 22:04 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 22:05 -!- endogenic [sid145991@gateway/web/irccloud.com/x-noejfuqaahakdrff] has joined #bitcoin-core-dev 22:05 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 22:08 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 22:11 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev 22:11 -!- kexkey [~kexkey@89.36.78.166] has quit [Ping timeout: 240 seconds] 22:12 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 22:18 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:a9ec:4da6:bcca:eafc] has joined #bitcoin-core-dev 22:18 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 22:18 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 22:22 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:a9ec:4da6:bcca:eafc] has quit [Ping timeout: 272 seconds] 22:24 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 22:25 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 22:52 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 22:52 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 22:53 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 23:00 -!- mmalecki [~mmalecki@195.181.170.239] has quit [] 23:22 -!- zacts [~zacts@195.181.170.239] has joined #bitcoin-core-dev 23:22 -!- zacts is now known as Guest6822 23:26 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has quit [Ping timeout: 244 seconds] 23:27 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 23:28 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 23:31 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 23:39 -!- melande2 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 23:40 -!- melande2 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev --- Log closed Sat Aug 29 00:00:02 2020