--- Log opened Thu Sep 17 00:00:21 2020 00:03 < jonatack> kallewoof: i suppose signetchallenge, as that's how all the others are (except reindex-chainstate that uses lispy kebab-case) 00:05 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 00:05 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 00:05 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:37d7:55fb:4d37:ffc2:715b] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:06 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 00:06 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 00:09 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has joined #bitcoin-core-dev 00:12 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds] 00:17 < gleb> What's the real expectation between blocksonly-mode/block-relay-only-conns and RELAY permission? If a blocksonly-node assignes the permission to a peer, this peer *is allowed* to relay transactions (we won't disconnect them like we do without permission). However, in practice, they would never do, because blocksonly-node tells them not to 00:17 < gleb> (fRelay=false in the VERSION message). 00:17 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:37d7:55fb:4d37:ffc2:715b] has joined #bitcoin-core-dev 00:18 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 00:18 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 00:22 -!- bcremer [~bcremer@184.75.223.227] has quit [Ping timeout: 265 seconds] 00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:24 < bitcoin-git> [bitcoin] ajtowns closed pull request #15502: p2p: Speed up initial connection to p2p network (master...201902-trytoavoiddns) https://github.com/bitcoin/bitcoin/pull/15502 00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:28 -!- sky54521 [771c4a8f@119.28.74.143] has joined #bitcoin-core-dev 00:28 -!- sky54521 [771c4a8f@119.28.74.143] has quit [Max SendQ exceeded] 00:28 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 00:31 -!- go11111111111 [~go1111111@104.156.98.86] has quit [Ping timeout: 272 seconds] 00:34 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has joined #bitcoin-core-dev 00:51 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has quit [Remote host closed the connection] 00:51 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has joined #bitcoin-core-dev 00:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:59 < bitcoin-git> [bitcoin] robot-dreams opened pull request #19967: test: Replace (dis)?connect_nodes globals with TestFramework methods (master...connect-nodes) https://github.com/bitcoin/bitcoin/pull/19967 00:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:02 -!- AstroDroid [~AstroDroi@84.39.117.57] has joined #bitcoin-core-dev 01:02 -!- jonatack [~jon@37.166.18.142] has joined #bitcoin-core-dev 01:03 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 01:03 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 01:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:21 -!- jonatack [~jon@37.166.18.142] has quit [Ping timeout: 240 seconds] 01:22 -!- jonatack [~jon@213.152.162.181] has joined #bitcoin-core-dev 01:29 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has quit [Remote host closed the connection] 01:30 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 01:30 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has joined #bitcoin-core-dev 01:30 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 01:33 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-ypxkleafjqnhwvqq] has joined #bitcoin-core-dev 01:34 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:34 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has quit [Ping timeout: 272 seconds] 01:51 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has quit [Ping timeout: 246 seconds] 01:54 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 01:54 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 01:58 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has joined #bitcoin-core-dev 02:00 -!- AstroDroid [~AstroDroi@84.39.117.57] has quit [] 02:00 -!- bosch [7a94fe5f@122-148-254-95.sta.wbroadband.net.au] has joined #bitcoin-core-dev 02:04 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 02:04 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 02:05 -!- kexkey [~kexkey@89.36.78.166] has quit [Ping timeout: 272 seconds] 02:07 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 02:07 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has joined #bitcoin-core-dev 02:07 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 02:09 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 02:09 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 02:17 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 02:17 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 02:21 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 02:21 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 02:22 -!- blardo [~blardo@185.244.214.216] has joined #bitcoin-core-dev 02:23 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 02:23 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 02:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 02:29 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 02:30 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has quit [Remote host closed the connection] 02:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has joined #bitcoin-core-dev 02:36 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has quit [Ping timeout: 272 seconds] 02:47 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:37d7:55fb:4d37:ffc2:715b] has quit [Ping timeout: 240 seconds] 02:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:50 -!- dom0 [5dc185d5@p5dc185d5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 02:54 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 02:59 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 258 seconds] 03:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 03:06 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 03:06 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 03:08 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 03:08 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:10 -!- cato_ [~cato@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 03:11 -!- cato__ [~cato@gateway/tor-sasl/alec] has quit [Remote host closed the connection] 03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:14 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 03:14 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 03:14 -!- S3RK [~s3rk@47.246.66.112] has quit [Read error: Connection reset by peer] 03:15 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 03:18 -!- Earnest18Hilll [~Earnest18@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:34 < bitcoin-git> [bitcoin] robot-dreams opened pull request #19968: doc: make it easier to work out size of bloom filter (master...bloom-doc) https://github.com/bitcoin/bitcoin/pull/19968 03:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:35 -!- jonatack [~jon@213.152.162.181] has quit [Ping timeout: 256 seconds] 03:43 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 03:43 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 04:05 -!- Earnest18Hilll [~Earnest18@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 04:06 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 04:06 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 04:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:15 < bitcoin-git> [bitcoin] robot-dreams closed pull request #19967: test: Replace (dis)?connect_nodes globals with TestFramework methods (master...connect-nodes) https://github.com/bitcoin/bitcoin/pull/19967 04:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:15 < bitcoin-git> [bitcoin] robot-dreams reopened pull request #19967: test: Replace (dis)?connect_nodes globals with TestFramework methods (master...connect-nodes) https://github.com/bitcoin/bitcoin/pull/19967 04:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:16 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 04:16 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 04:19 -!- jonatack [~jon@37.166.18.142] has joined #bitcoin-core-dev 04:25 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 272 seconds] 04:43 -!- MrPaz [~paz@24.14.251.223] has joined #bitcoin-core-dev 04:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 04:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:57 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 04:57 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 05:00 -!- blardo [~blardo@185.244.214.216] has quit [] 05:10 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 05:10 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 05:11 < sdaftuar_> gleb: if A sends B a version message where frelaytxes=false, that means that B should not announce transactions to A 05:11 < sdaftuar_> it does not mean that A will not announce transactions to B 05:11 -!- sdaftuar_ is now known as sdaftuar 05:12 < sdaftuar> the reason that is in the protocol is to support light-clients that might need a window of time to send over a bloom filter to B, to avoid their bandwidth being flooded in between sending a version and sending the filter 05:12 < sdaftuar> (i believe) 05:13 < sdaftuar> we piggy-backed off that functionality being present when -blocksonly mode was added 05:13 < sdaftuar> and then again when block-relay-only peers were added 05:18 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 05:21 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:21 < gleb> sdaftuar: That's a different thing, I'm talking about sending txs from B->A. It should not announce transactions, and we will disconnect if they do. Except the case if we re-allow it with RELAY permission 05:22 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 05:22 -!- Jayflux [~Jayflux@192.145.126.115] has joined #bitcoin-core-dev 05:22 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 05:22 < gleb> Then it's allowed to send transactions B->A and A will process them just fine. 05:23 < gleb> But node B running Bitcoin Core currently doesn't employ this ability, because it doesn't know it's permitted. 05:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has joined #bitcoin-core-dev 05:37 -!- bosch [7a94fe5f@122-148-254-95.sta.wbroadband.net.au] has quit [Remote host closed the connection] 05:39 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 05:44 -!- twistedline__ [~twisted@2601:14d:8500:26c0:d035:95da:7f6a:5bb7] has quit [Remote host closed the connection] 05:44 -!- twistedline__ [~twisted@2601:14d:8500:26c0:ec79:4a83:de6e:1f2] has joined #bitcoin-core-dev 05:44 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 05:49 < sdaftuar> gleb: ah i see 05:49 < sdaftuar> so in general B has no way of knowing that A has given it those permissions 05:49 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds] 05:51 < sdaftuar> hmm. what happens if you connect to a node that is running in blocksonly mode? 05:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 06:05 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 06:05 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev 06:07 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:07 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:08 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:08 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:09 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:09 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:09 -!- Jayflux [~Jayflux@192.145.126.115] has quit [Ping timeout: 272 seconds] 06:10 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:10 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:12 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:12 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:12 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Quit: melande1] 06:13 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:13 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:16 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:16 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:17 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:17 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:18 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:18 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:19 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:20 -!- jonatack [~jon@37.166.18.142] has quit [Read error: Connection reset by peer] 06:21 -!- jonatack [~jon@37.166.18.142] has joined #bitcoin-core-dev 06:22 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:37d7:b93e:60af:b75b:c0ef] has joined #bitcoin-core-dev 06:23 -!- Kiminuo [~mix@141.98.103.116] has quit [Ping timeout: 272 seconds] 06:28 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has quit [Remote host closed the connection] 06:29 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has joined #bitcoin-core-dev 06:30 -!- MaddinSM [~MaddinSM@185.204.1.185] has joined #bitcoin-core-dev 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:31 < bitcoin-git> [bitcoin] Sjors opened pull request #19969: Send RPC touch-ups (master...2020/09/send_touchups) https://github.com/bitcoin/bitcoin/pull/19969 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:33 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:c876:707:79b9:6ab4] has quit [Ping timeout: 272 seconds] 06:38 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:38 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:55 -!- kexkey [~kexkey@89.36.78.166] has joined #bitcoin-core-dev 07:00 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:02 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 07:05 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 07:06 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:22 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3982:d6a5:97f:ef6c] has joined #bitcoin-core-dev 07:22 -!- jonatack [~jon@37.166.18.142] has quit [Read error: Connection reset by peer] 07:27 < gleb> sdaftuar: I don't think there's any difference? 07:32 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 244 seconds] 07:37 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3982:d6a5:97f:ef6c] has quit [Remote host closed the connection] 07:38 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3982:d6a5:97f:ef6c] has joined #bitcoin-core-dev 07:39 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:41 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 07:42 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3982:d6a5:97f:ef6c] has quit [Ping timeout: 244 seconds] 07:43 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:37d7:b93e:60af:b75b:c0ef] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:44 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 08:00 -!- MaddinSM [~MaddinSM@185.204.1.185] has quit [] 08:00 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 08:00 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 08:02 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 08:02 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 08:06 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:07 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:37d7:b93e:60af:b75b:c0ef] has joined #bitcoin-core-dev 08:15 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 08:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 08:20 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 08:22 -!- jMCg [~jMCg@195.140.213.38] has joined #bitcoin-core-dev 08:24 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 08:24 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 08:24 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 08:24 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 272 seconds] 08:30 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 08:30 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 08:30 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 08:30 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 08:33 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:37d7:b93e:60af:b75b:c0ef] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:33 -!- TheRec_ [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 08:34 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 08:34 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 08:34 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 08:46 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev 08:49 -!- Sleepnbum [~george@45.131.192.105] has joined #bitcoin-core-dev 08:55 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 08:55 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 08:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 09:00 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 09:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:04 -!- dom0 [5dc185d5@p5dc185d5.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 09:09 -!- Kiminuo [~mix@141.98.103.116] has joined #bitcoin-core-dev 09:09 -!- isis_ is now known as isis 09:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 09:24 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 09:24 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 09:26 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 09:26 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 09:26 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 272 seconds] 09:27 -!- real_or_random [~real_or_r@173.249.7.254] has quit [Quit: ZNC 1.7.5 - https://znc.in] 09:29 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #bitcoin-core-dev 09:33 -!- Highway62 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 09:35 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 272 seconds] 09:35 -!- Highway62 is now known as Highway61 09:54 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 10:01 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 10:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 10:09 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 272 seconds] 10:10 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 10:16 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:17 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 10:19 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 10:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:26 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev 10:29 < sipa> #proposedmeetingtopic Size limit for data-driven unit tests 10:42 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 240 seconds] 10:43 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 272 seconds] 10:47 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:50 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 10:52 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 10:55 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 10:57 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 11:00 -!- jMCg [~jMCg@195.140.213.38] has quit [] 11:00 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 11:01 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 258 seconds] 11:07 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 11:21 -!- csslayer1 [~csslayer@195.206.169.184] has joined #bitcoin-core-dev 11:31 -!- lightlike [~lightlike@p200300c7ef180800ecf815c55fa62b87.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:35 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 11:35 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 11:38 < ryanofsky> #proposedmeetingtopic https://github.com/bitcoin-core/bitcoin-devwiki/wiki/AssertLockHeld-PRs 11:38 -!- Sleepnbum [~george@45.131.192.105] has quit [Quit: Leaving] 11:45 < wumpus> many topics today! 11:45 < sipa> all short ones, i hope 11:50 < jonatack> we covered the torv3 transition a bit yesterday at https://bitcoincore.reviews/19845#l-270, feel free to drop if no need to re-discuss 11:51 < wumpus> true, i'll move it last in that case 11:54 < vasild> I have an excellent idea about renaming sendaddrv2 to a generic capabilities and making it possible to include various options inside it. Like capabilities(send me addrv2, I participate in gossip, whatnot, my favorite color is blue) 11:55 < vasild> "excellent"... until somebody shoots it down :) 11:57 < wumpus> things like that were proposed before, though never in the for of a BIP afaik, but I think that's out of scope of BIP155 11:58 < wumpus> I think it'd be good to keep sendaddrv2's prameters restricted to things concerning, well, network addresses and address gossiping 11:58 < vasild> I agree it is out of scope, but I also think "I participate in gossip" is out of scope for bip155, if we consider that its purpose is to support larger than 16 byte addresses 11:58 < sipa> wumpus: agree 11:58 < sipa> vasild: maybe... 11:59 < wumpus> the deadlines for 0.21 are also getting closer, in case that's what you were aiming for 12:00 < vasild> yeah 12:00 < wumpus> vasild: well at least it's still close enough, proposing a general capability message is a can of worms 12:00 < jnewbery> moot time 12:00 < sipa> hi. 12:00 < vasild> I was just thinking - if we make it sendaddrv2(your address is X, I participate in gossip) we may as well s/sendaddr/capabilities/ :) 12:00 < wumpus> it also brings back the discussion of when to send it, for example, for a lot of capabilities you'd want to know them at connection time and not at some point later 12:01 < wumpus> #startmeeting 12:01 < lightningbot> Meeting started Thu Sep 17 19:01:00 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:01 < jnewbery> hi 12:01 < sipa> vasild: i would really avoid doing anything that's unrelated to addr relay 12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james 12:01 < sipa> just risks expanding the scope unboundedly 12:01 < wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2 12:01 < achow101> hi 12:01 < wumpus> we have a lot of topics for today, so let's start quickly 12:01 < provoostenator> hi 12:01 < jonatack> bonsoir 12:01 < meshcollider> hi 12:01 < jb55> greetings 12:01 < wumpus> #topic High priority for review 12:01 < luke-jr> hi 12:01 < vasild> sipa: wumpus: ok 12:01 < kanzure> hi 12:01 < michaelfolkson> hi 12:01 < jonasschnelli> hi 12:01 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 12 blockers, 1 bugfix, 2 chasing concept ACK 12:02 < sipa> can i have #19953 ? 12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub 12:02 < wumpus> signet should be close to mergable, I hope we can get that one at least in for 0.21 12:03 < wumpus> PSA: the release schedule deadlines for 0.21 start october 1: https://github.com/bitcoin/bitcoin/issues/18947 12:03 < provoostenator> #16546 is next in line for hardware wallet support 12:03 < wumpus> sipa: sure 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub 12:04 < wumpus> provoostenator: sipa: added 12:04 < luke-jr> wumpus: let's put #11082 back in? 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub 12:05 < luke-jr> although it looks like I already have 2 there, the ramifications of missing 0.21 with this is pretty annoying 12:05 < wumpus> I'm still not sure about the writable configuration files (didn't we have two conflicting systems now?) but in any case, added 12:05 < wumpus> not the time to have that discussion now 12:05 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 272 seconds] 12:05 < wumpus> #topic Endomorphism optimization in libsecp256k1 (sipa) 12:06 < vasild> I have never seen such dual configs in any other software... 12:06 < sipa> hi! 12:06 < sipa> this is mostly a short announcement so it doesn't cause any surprise 12:07 < sipa> libsecp256k1 started out as an experiment to see how much secp256k1 EC operations could be made by using the GLV endomorphism optimization, which it was specifically designed to support, but not actually implemented anywhere 12:07 < luke-jr> vasild: that's kinda the point; it reduces to one config format 12:07 < fjahr> hi 12:07 < sipa> as it turned out that there is some risk it is encumbered by a patent, the GLV optimization was made optional, and defaults to off (and has been off in every bitcoin core release) 12:08 < sipa> it looks like that patent is expiring on september 25th, and blockstream had a patent attorney verify that (i'm happy to share their findings, if anyone cares) 12:08 < wumpus> yay! 12:08 < cfields> wooo! 12:08 < luke-jr> sipa: how sure can we be that it can't break consensus? 12:08 < sipa> so the plan is to switch it to default on after that date, or even rip out the non-GLV code 12:08 < sipa> luke-jr: good question 12:09 < luke-jr> is it provable? :x 12:09 < sipa> libsecp256k1' CI has always tested with both endomorphism enabled and disabled 12:09 < sipa> including our exhaustive tests, which are probably as close to a mathemetical proof we can get for real software - at least for some aspects 12:10 < sipa> fwiw, that's a test where the library is compiled with a slightly different curve equation that makes it trivially insecure, and only leaves 12 valid private/public keys 12:10 < sipa> and in that mode, we can test literally every combination of signature/pubkey/private key 12:11 < wumpus> nice 12:11 < sipa> so i think that given that, it shouldn't be any more invasive than regular code changes to libsecp256k1 12:11 < luke-jr> has it been proven on a mathematical level? (not saying it's a problem if not, just asking) 12:12 < sipa> luke-jr: for some parts of the code we have actual proofs (some hand-written, some automatic); though admittedly not the part touched by the endomorphism 12:12 < wumpus> I think he means in mathetmatical theory, not so much the specific code 12:12 < luke-jr> right 12:13 < sipa> wumpus: for the group arithmetic, there is a transliteration of the C code to python, which is then symbolically executed and can be automatically proven correct 12:13 -!- guest534543 [~mix@193.9.112.252] has joined #bitcoin-core-dev 12:13 < provoostenator> Very cool, somewhat scary, but how much of a speedup is this? 12:13 < sipa> the conversion from C to Python (or its semantics) of course aren't, but the algorithms at a slightly higher level are proven 12:13 < wumpus> sipa: that's a very interesting approach 12:13 < sipa> provoostenator: 27% for ecdsa verification 12:13 < provoostenator> Ok, that's worth some code review time alright. 12:13 < wumpus> very hard to say no to that :) 12:14 < sipa> well 12:14 < sipa> arguably, libsecp256k1 originally _only_ had the GLV mode 12:14 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 272 seconds] 12:14 < sipa> the mode where GLV was disabled (which is now default) was added later 12:14 < wumpus> yes it was added out of patent concerns 12:15 < sipa> yes 12:15 < sipa> but all changes since 2013 have always kept both GLV and non-GLV working, and tested 12:15 < meshcollider> Interesting, I didn't know that 12:15 < luke-jr> was the GLV mode ever released in Core? 12:15 < wumpus> no 12:15 < sipa> luke-jr: it's a compile time option, and it was never enabled in (default) builds of core 12:16 < sipa> you could always enable it yourself with --enable-endomorphism 12:16 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 12:16 < luke-jr> right, not sure how many people actually did that tho :p 12:16 < wumpus> some people did it for benchmarking at times 12:16 -!- Kiminuo [~mix@141.98.103.116] has quit [Ping timeout: 260 seconds] 12:16 < wumpus> apart from that, dunno 12:16 < sipa> luke-jr: i assume nobody 12:16 < vasild> If there are concernts, what about doing all calculus in both and comparing they produce the same result? 12:17 < luke-jr> we do have a USE flag for it in Gentoo, but no metrics on usage 12:17 < sipa> vasild: that's arguably what the unit tests are doing 12:17 < sipa> if they differed, at least one would fail 12:17 < luke-jr> vasild: you mean in real-world use? what's the point? 12:17 < meshcollider> sipa: why not just test it out on all secp256k1 keys to make sure ;) 12:17 < sipa> meshcollider: that's what the exhaustive test mode does 12:17 < luke-jr> meshcollider: :D 12:18 < vasild> I mean, in real life, in production, for e.g. 6 months. But I am not suggesting that, just saying "if there are concerns" :) 12:18 < sipa> vasild: i believe that is pointless 12:18 < vasild> ok, I can't judge 12:18 < sipa> due to the cryptographic nature of things, actual correct _random_ usage is never going to trigger an edge case if one existed 12:18 < luke-jr> I think you could just build with it enabled, and do a full sync 12:18 < wumpus> trying completely random input is very likely not going to find anything 12:18 < wumpus> right 12:18 < luke-jr> if anything deviates, the sync should fail, right? 12:19 < sipa> luke-jr: in theory it could be accepting invalid signatures, which wouldn't be caught by such a test 12:19 < sipa> though again, this is true for every change to the cryptographic code 12:19 < luke-jr> sipa: but vasild's suggestion wouldn't detect that either 12:19 < sipa> luke-jr: indeed 12:19 < sipa> the exhaustive test likely would though 12:19 < sipa> or at least, has a reasonable chance to - it depends on the nature of the hypothetical bug 12:20 < sipa> https://patents.google.com/patent/US7110538B2/en 12:20 < wumpus> I'd assume you have 100% code coverage of that code in the test? (not that that proves anything, of course, but at least all paths are being exercised) 12:21 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 12:21 < sipa> wumpus: i believe we have code coverage of everything that isn't impossible to reach, but i'll go verify that 12:22 < wumpus> sipa: thanks! 12:22 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Read error: Connection reset by peer] 12:22 < sipa> so, expect a libsecp256k1 update shortly after september 25th 12:22 < wumpus> thanks for the announcement sipa, let's move to next topic 12:22 < sipa> discussion on testing and whatnot can still happen in the PR 12:22 < sipa> that's all from me 12:23 < jnewbery> that's great news sipa! 12:23 < wumpus> #topic How should signet params be prefixed? (kallewoof) 12:23 < wumpus> basically my comment here https://github.com/bitcoin/bitcoin/pull/18267#discussion_r488814952 12:23 < jonatack> i suppose signetchallenge, as that's how all the others are, except reindex-chainstate that uses lispy kebab-case 12:24 < wumpus> I didn't like _ in command line parameters, - would be ok-ish with me (because it matches the - symbol at the beginning), but our convention seems to be to just concatentate 12:24 < sipa> it looks like all 3 styles are used; there is -rpcpport, there is -reindex-chainstate, there is -output_csv (to bench) 12:24 < sipa> my preference is the first (just squeeze things), but apart from that i don't care, and i don't think it's worth much discussion time :) 12:24 < wumpus> _ is definitely the worst to me at least, it's harder to type too 12:25 < luke-jr> why not -signet= 12:25 < wumpus> I do think it is good to be consistent and come up with a standard way also for future arguments 12:25 < achow101> traditionally we just stick them together without any separator, so just do that? 12:25 < wumpus> luke-jr: because there may be other signet arguments in the future 12:26 < sipa> there are several alredy 12:26 < wumpus> and it's more consistent with -regtest -testnet to have it as a boolean anyhow 12:26 < wumpus> yes 12:26 < wumpus> achow101: +1 12:27 < jnewbery> ACK squeezecase 12:27 < wumpus> okay, the sentiment here seems to be clear, if no one else is going to weigh in, we're going to next topic 12:28 < wumpus> #topic Size limit for data-driven unit tests (sipa) 12:28 < sipa> hi! 12:29 < luke-jr> o hai thar sipa? 12:29 < sipa> in #19953 i've recently added a unit test with randomly-generated transaction validation success/failure cases, minimized using the fuzzing framework (it's not an actual fuzzer, all input is generated by a python script, but just minimized using the fuzz build) 12:29 < gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub 12:29 < sipa> which i think is an interesting approach as it permits getting the kind of coverage you get by running the python functional test for days... weeks... 12:30 < sipa> it's 250 kB now, which seems in line with some of the other tests we have 12:30 < sipa> but i could extend this to test more things, and in particular more validation flags 12:30 < luke-jr> does that create a dep on fuzzing stuff for normal tests? :x 12:30 < sipa> luke-jr: nope, just a json file 12:30 < sipa> with the output of the whole fuzzing procedure 12:31 < luke-jr> aha 12:31 < sipa> anyway, trying to extend this, using the same approach, leaves me with things in the 1-2 MB range 12:31 < wumpus> I think we should be careful to not add too much data for tests to the repository, git is not that great for bulk data storage, though 250kB seems fine to me 12:31 < sipa> and i was wondering if that's acceptable 12:31 < sipa> there are many more tradeoffs possible, which can reduce that - or extend it - in exchange for coverage/development time 12:32 < sipa> but if people are like "1 MB is just fine", that would simplify things 12:32 < wumpus> another drawback of large files is that it generates huge diffs, and this isn't really reviewable 12:32 < jonasschnelli> I guess the runtime memory requirements are unchanged for that? 12:32 < sipa> jonasschnelli: yes, it's just a (very simple) unit test 12:32 < wumpus> jonasschnelli: yes, it's only used at test time 12:32 < sipa> it's also 1 MB of json which is presumably compressed quite a bit by git 12:32 < cfields> sipa: does it compress at all in git? 12:32 < vasild> the json contains ascii hex, what if we save it in binary? would be 2x reduce 12:32 < cfields> hah 12:33 < wumpus> but as it's part of a unit test it also can't easily be moved to another repository like the fuzz dataset one 12:33 < sipa> vasild: yes, possible - but if git compresses it already in a similar degree, leaving it in a more readable form has advantages 12:33 < luke-jr> is there a reason not to just make this part of the fuzzer build? 12:34 < sipa> luke-jr: it's not a fuzzer 12:34 < sipa> you can't run it as a fuzzer 12:34 < sipa> (it would immediately fail, as it's not testing random inputs) 12:34 < vasild> sipa: right, I guess disk space when checked out is irrelevant for such sizes 12:34 < luke-jr> sipa: but can't the 250k be generated at test-time? 12:35 < sipa> luke-jr: it took me days 12:35 < luke-jr> hmm 12:35 < sipa> (of CPU time) 12:35 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 12:35 < luke-jr> a special make target? 12:35 < sipa> it's nondeterministic 12:35 < jnewbery> is https://github.com/bitcoin-core/qa-assets used for test assets? 12:35 < jonasschnelli> +1 12:35 < wumpus> jnewbery: yes, that's what I meant, the only thing is that it takes an extra step then 12:35 < sipa> luke-jr: to be clear, this is a test that _already_ runs as a functional test, but only for 1 minute 12:36 < wumpus> someone who wants to read the test also needs that erpository checked out -- not a problem for the CI at leat 12:36 < sipa> luke-jr: the approach to extract a very-good-coverage unit test from it makes it a bit more accessible and reusable, and gives the same coverage as running the functional test 1000s of times 12:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:36 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 12:36 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 12:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:37 < sipa> wumpus: that's reasonable, i guess 12:37 < sipa> skip the test if the json file isn't found 12:37 < sipa> or something like that 12:37 < wumpus> sipa: yes, sounds fair to me 12:38 * luke-jr glares at boost for not supporting skips still (last I checked) 12:38 < wumpus> though there are already some ~250kB json files in the repo, for the tests, I don't think one more is that bad... but let's not make a habit out of it, and also, you're planning to add more data in the future 12:38 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:38 < ryanofsky> I like the qa assetts idea. Skipping the test if input not found is also similar to what we do for backwards compatibility tests 12:38 < sipa> luke-jr: "return true;" works great 12:38 < wumpus> yes 12:38 < luke-jr> sipa: except it gives the impression it passed? 12:38 < ryanofsky> No objection to 250kb either, though 12:39 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 260 seconds] 12:39 < sipa> luke-jr: "make check" also doesn't run the fuzz tests; does that give the impression they passed? :) 12:39 < sipa> there could be a "notice: qa-assets not found, so large data-driven tests are skipped" 12:39 < luke-jr> sipa: boost explicitly says the tests pass.. 12:40 < sipa> luke-jr: in aggregate 12:40 < luke-jr> sipa: individually 12:40 < luke-jr> sipa: this is a problem for another test already IIRC 12:40 < wumpus> ok, I think we've given sipa quite some input on this for now, decision doesn't need to be made in the meeting, only ~20 minutes left, and 1 or 2 topics 12:40 < wumpus> #topic AssertLockHeld PRs (ryanofsky) 12:40 < ryanofsky> Debug lockerorder test is a test that passes if skipped, but minor one 12:41 < ryanofsky> For AssertLockHeld PRs, I just wanted to advertise wiki page https://github.com/bitcoin-core/bitcoin-devwiki/wiki/AssertLockHeld-PRs 12:41 < ryanofsky> If anyone is interested in AssertLockHeld improvements but confused by the multiple PRs, page summarizes them 12:41 < sipa> ryanofsky: thanks for that 12:42 < jonatack> ryanofsky: v nice 12:42 * sipa is quite overwhelmed by it 12:42 < wumpus> yes good to have an overview 12:42 < ryanofsky> Sure, that's all I have for the topic 12:42 < wumpus> what would "WeaklyAssertLockHeld" do compared to the normal assert? 12:43 < vasild> indeed! (confusing name) 12:43 < ryanofsky> They both do the same thing at runtime, which is why my preference is to have one assert instead of two 12:44 < sipa> and the difference is that one also does a compile-check (if supported) and the other doesn't? 12:44 < wumpus> it sounds really weird to me a lock is held or not :) 12:44 < ryanofsky> But if we can't have one assert, there are cases where the stronger assert isn't accepted at compile time and you need to use the weaker one 12:44 < vasild> btw, one of the clang people suggested that we don't annotate AssertLockHeld() with any compile time attributes and leave it pure run time. 12:44 < wumpus> oh, like that 12:45 < luke-jr> I don't get why one would use Assert* instead of EXCLUSIVE_LOCKS_REQUIRED 12:45 < luke-jr> outside of perhaps a conditional 12:45 < wumpus> it's an assertion that existed way before the lock annotations did 12:46 < sipa> lock annotations also only work in clang 12:46 < wumpus> ouch 12:46 < luke-jr> oh :/ 12:46 < sipa> and can't be used for some of the more complex cases, i assume 12:46 < vasild> luke-jr: runtime asserts work always, compile time _warnings_ - only for clang and if you compile with --enable-werror and if clang does not have bugs etc 12:46 < ryanofsky> luke-jr, infrequently there are cases where the compile can't know EXCLUSIVE_LOCKS_REQUIRED is satisfied and you have to tell it that 12:46 < sipa> vasild: well, they only work in -DDEBUG_LOCKORDER mode, which you don't want to use for production :) 12:46 < ryanofsky> that is what assert is useful for 12:47 < sipa> so they're overlapping but one is not a subset of the other, in terms of what they can detect 12:47 < ryanofsky> the other thing assert is useful for (i don't think very useful) is when compile time checks are unavailable or disabled or buggy 12:47 < wumpus> apparently they're clang only so they're often not available 12:48 < wumpus> i'm fairly sure most people compile with gcc, at least on linux 12:48 < ryanofsky> right but they run on CI 12:49 < ryanofsky> and if you are compiling with gcc, you have to enable run time checks and execute the code and hope an assert is hit to see any benefit from it 12:49 < wumpus> yes 12:49 < vasild> having CI as the sole protection seems uncomfortable to me - it does not run manual tests 12:49 < vasild> developers do on their machines 12:50 < luke-jr> ideally all tests would exist in the automated form ;) 12:50 < ryanofsky> vasild, compile time checks check correctness at compile time they have no effect on runtime generated code 12:50 < wumpus> i wonder how many developers are compiling with DEBUG_LOCKORDER anyway, well probably those that are working on locking changes do 12:50 < ryanofsky> there's 0 benefit to compiling with compiling checks and then running bitcoind locally 12:51 < vasild> wumpus: it is enabled bug --enable-debug 12:51 < vasild> by 12:51 < wumpus> yes 12:51 < sipa> "Bitcoin Core developer claims enabling debugging introduces bug" 12:52 < vasild> "fixes the bug by disabling debugging" 12:52 < luke-jr> src/Makefile:CXXFLAGS = -Wthread-safety-analysis -DDEBUG_LOCKORDER -O1 -ggdb -Wall -Werror=thread-safety-analysis -fsanitize=undefined 12:52 < luke-jr> apparently I am 12:52 < jonatack> I debug-build with clang on some PRs 12:52 < wumpus> ok if we still want to discuss torv3, we'll have to switch topics now 12:52 < luke-jr> mind you, I never use dev code for mainnet 12:53 * luke-jr wonders when a 1 hour limit was set in the first place :P 12:53 < wumpus> because it's good to keep meetings short 12:53 < wumpus> #topic torv2->torv3 transition, schedule, process (jonatack) 12:53 < jonatack> Per this Tor ML post https://lists.torproject.org/pipermail/tor-dev/2020-June/014365.html 12:53 < jonatack> Tor v2 was deprecated the day before yesterday (September 15, 2020) with 0.4.4.x and will be obsoleted in 0.4.6.x (July 15, 2021) 12:53 < jonatack> Tor v2 is expected to be completely disabled in Tor client stable versions on October 15, 2021 12:54 < wumpus> previous discussion from the review meeting yesterday: https://bitcoincore.reviews/19845#l-270 12:54 < luke-jr> is this a network-level change, or just dependency change? 12:54 < luke-jr> ie, does Tor v2 stop working for old versions too? 12:54 < jonatack> a half-dozen of us are running nodes with tor v3 services ATM 12:54 < sipa> luke-jr: i assume it will, due to network infrastructing updating to versions that don't support torv2 anymore 12:54 < vasild> luke-jr: they say torv2 is going to be removed from the source code of Tor 12:54 < jonatack> using #19954 / aka PR 19031 12:55 < gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: make a TORv3 hidden service instead of TORv2 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub 12:55 < wumpus> luke-jr: that's not entirely clear to me; but I assume they'll shut down the directory authorities etc for torv2 too 12:55 < jonatack> "We will release new Tor client stable versions for all supported series that will disable v2." 12:55 < jonatack> on Oct 15 2021 per https://blog.torproject.org/v2-deprecation-timeline 12:56 < jonatack> "This effectively means that from today (July 2nd, 2020), the Internet has around 16 months to migrate from v2 to v3 once and for all." 12:56 < sipa> that sounds like torv2 will stop working in oct 2021 12:56 < vasild> they probably realize that if they leave torv2 working, there will be still people using it after 10 years 12:56 < wumpus> let's try to get basic (if we can't get all) torv3 support into 0.21.0 12:57 < sipa> wumpus: seems doable 12:57 < jonatack> we're ~5 commits away 12:57 < wumpus> better to have things prepared in time than to wait for last minute 12:57 < jonatack> 19845 + 19954 i believe 12:57 < wumpus> yea it's not too much anymore 12:58 < vasild> http://www.erisian.com.au/bitcoin-core-dev/log-2020-09-16.html#l-243 12:58 < sipa> wumpus: also, ack bip155 changes, as those need to be stable before 0.21 if we want it :) 12:58 < jonatack> at first, will nodes gossip both v2 and v3? 12:58 < wumpus> sipa: yes 12:58 < wumpus> jonatack: i think that would make sense 12:59 < sipa> agree 12:59 < vasild> stopping gossip of torv2 we can consider after Oct 2021 12:59 < jonatack> sgtm 12:59 < wumpus> maybe it should support the case where tor refuses to create a v2 service, to be future proof 12:59 < wumpus> e.g. not make that a fatal error 13:00 < sipa> is anything in torcontrol a fatal error? 13:00 < vasild> in 19954 we only ever try to create torv3 service 13:00 < jonatack> atm 19954 only rumours v3? 13:00 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 13:01 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 13:01 < wumpus> sipa: not for bitcoind entirely, but any error will stop it from going forward in torcontrol 13:01 < vasild> "atm 19954 only rumours v3?" - no, it would rumor (gossip) both torv2 and torv3 13:01 < wumpus> great! 13:02 < wumpus> #endmeeting 13:02 < lightningbot> Meeting ended Thu Sep 17 20:02:15 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 13:02 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-09-17-19.01.html 13:02 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-09-17-19.01.txt 13:02 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-09-17-19.01.log.html 13:02 < jonatack> right, but only v3 service not v2? 13:02 < vasild> 19954 is only about when bitcoin core creates a tor hidden service automatically via the tor control connection -- it would start creating torv3 with that PR 13:02 < jonatack> i certainly only see a v3 local address with 19954 13:03 < luke-jr> I prefer to add features, and remove others, in separate PRs ;) 13:03 < sipa> luke-jr: fwiw, perhaps i misunderstood your question earlier; the concept of the endomorphism optimization is easy to prove (it's a standard result in algebraic geometry) - so we know that if implemented correctly, it works 13:03 < luke-jr> sipa: great, that's what I meant 13:04 < jonatack> vasild: ok i'll look into what happens with the proxy and 19954 13:04 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection] 13:04 < sipa> luke-jr: in slightly more detail, it's similar to how we know that -(x,y) = (x,-y) for elliptic curve points 13:05 < luke-jr> >implying I understand EC :p 13:05 < sipa> luke-jr: "negating a point negates the Y coordinate" 13:05 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 13:05 < sipa> does that sounds familiar? 13:05 < luke-jr> no 13:05 < sipa> ok! 13:06 < sipa> luke-jr: you know how compressed public keys consist of 0x02 or 0x03, followed by 32 bytes X coordinate? 13:06 < luke-jr> sure 13:07 < michaelfolkson> With my untrained eye Signet and Tor v3 both seem to be a rush to get in for October. What is the history of new features like that needing updates in minor versions because they weren't fully cooked for the major version they were part of? 13:07 < sipa> luke-jr: the 0x02 indicates whether the Y coordinate is odd or even; that works because for every point, a point with the same X coordinate but opposite Y coordinate exists (and modulo p, negating changes odd to even and the other way around) 13:08 < luke-jr> sipa: btw don't feel like you need to explain it to me - I'm sure if I read through gmax's educational material I'd understand 13:08 < sipa> ok 13:09 < luke-jr> michaelfolkson: for software in general, there's a general idea that .0 will have bugs :P 13:09 < michaelfolkson> Haven't seen any gmax educational material teaching EC. Any links?! 13:09 < michaelfolkson> Ok luke-jr. So it is kind of expected that Signet and Tor might need to be cleaned up in minor versions 13:10 < wumpus> michaelfolkson: it's often been done 13:10 < vasild> michaelfolkson: so far torv3 has been going very steadily (no rush so far) 13:10 < luke-jr> michaelfolkson: crap, I think I lost it 13:11 -!- lightlike [~lightlike@p200300c7ef180800ecf815c55fa62b87.dip0.t-ipconnect.de] has quit [Quit: Leaving] 13:11 < michaelfolkson> Yeah definitely not so far vasild. Just projecting forward 13:11 < vasild> that does not mean it is not going to be rushed from here :) 13:11 < wumpus> we've had much more rushed things in .0 major releases, signet and torv3 have been going on for a while and don't seem super hurried 13:12 < sipa> right, there is a difference between prioritizing and rushing 13:12 < wumpus> obviously I didn't mean "it needs to be in 0.21 at all costs", that's not how our releases work 13:12 < luke-jr> michaelfolkson: I think it was once under https://people.xiph.org/~greg/ which is now 404 :/ 13:12 < michaelfolkson> Ah ok never mind. Thanks for looking luke-jr 13:12 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 13:13 < michaelfolkson> And then to stir the pot, ideally we would have Signet in 0.21 to encourage Taproot testing on Signet? 13:13 < wumpus> signet is entirely opt-in, it's not that bad if it's still somewhat experimental, the important thing is that it doesn't break non-signet use 13:14 < michaelfolkson> No because it woulds still need to be a custom Signet for Taproot testing 13:14 < michaelfolkson> And the 0.21 release will be the default Signet (hopefully) 13:14 < sipa> taproot can be soft-forked into signet if the signers decide so 13:15 < wumpus> the Tor changes should definitely be correct in one go, it would be really bad to break Tor support, but we have a lot of interest and testing for that so I'm not too afraid 13:16 < michaelfolkson> Ok so (hopefully) Signet in 0.21 and then Taproot could be soft forked into Signet by the signers in a minor release or the next major Core release? 13:16 < sipa> kallewoof, aj: would it be useful to have different terms between signet (as in the bitcoind mode that enables signet configuration/rules) and signet (the default global testnet run by you two) 13:16 -!- Aden_ [~dinodev@41.107.37.2] has joined #bitcoin-core-dev 13:17 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds] 13:17 < michaelfolkson> Soft forking Signet for Taproot testing should be a given. That obviously doesn't mean anything in terms of a final community decision on Taproot activation etc for mainnet 13:18 -!- csslayer1 [~csslayer@195.206.169.184] has quit [Remote host closed the connection] 13:19 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 13:19 < aj> sipa: "default signet", "custom signets" are the terms to distinguish the the one kallewoof and i sign from what anyone else might set up 13:20 < sipa> aj: that sounds embarassingly sane 13:20 < michaelfolkson> I think I proposed "main signet" lol 13:22 -!- isis is now known as isis_ 13:23 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 13:24 < michaelfolkson> What is your latest thinking on updating proposed soft forks for mainnet that are already on Signet aj? Still effective hard forks? 13:26 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 13:26 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 260 seconds] 13:29 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:29 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 256 seconds] 13:36 -!- davidfischer [~davidfisc@193.56.252.210] has joined #bitcoin-core-dev 13:37 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 13:37 < aj> michaelfolkson: updates to not-activated-on-testnet/mainnet or not-merged-to-master consensus changes might well be hard forks from vN to v(N+1) (or commit xxxxx^ to xxxxx), question is just how to deal with that 13:40 < aj> ryanofsky: "AJA" is precisely "2A" except calling it "LOCK_ALREADY_HELD" instead of "WeaklyAssertLock" 13:40 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:42 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 260 seconds] 13:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:44 < elichai2> luke-jr: fwiw I'm running with endomorphism for at least a year while updating each release and IBDing with assumevalid=0 13:44 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 13:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:46 < instagibbs> elichai2, "hello, policia?".gif 13:46 < instagibbs> what was the overall difference? 13:47 < elichai2> I didn't test the differences actually, but I think I got something like ~4 hours for full ibd with assumevalid=0 last time, I should retry without redownloading 13:48 < elichai2> But my point was about "is anyone using this" and "sync will fail if it's wrong" :) 13:48 < elichai2> Hehe yeah I'm sure they wanna sue me for patent infringement lol 13:50 -!- guest534543 [~mix@193.9.112.252] has quit [Ping timeout: 240 seconds] 13:50 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 13:50 < elichai2> (about the topic, it might be a bit late but I personally would love to see those ifdefs on endo being removed :) I think it will even potentially increase the security of the code because of less preprocessor complexity and compile options) 13:57 * jonatack elichai2 hears an early-morning knock at the door 13:58 < jonatack> elichai2: pretty cool that you've been testing it. i wondered what that was, TIL 13:59 < elichai2> Yeah it's a great perf boost :) 14:00 -!- davidfischer [~davidfisc@193.56.252.210] has quit [] 14:00 < jonatack> my 4 cores of cpu will be happy about that 14:00 < instagibbs> IIRC the endomorphism was the inspiration for libsecp 14:00 < instagibbs> sipa tried it out then got rabbit holed 14:00 < sipa> instagibbs: yes, read meeting log from today :) 14:01 < elichai2> I'm also testing with libgmp although that will hopefully won't be needed anymore very soon🙏 14:06 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 14:07 -!- promag [~promag@31.22.203.71] has joined #bitcoin-core-dev 14:10 -!- someone235 [uid419897@gateway/web/irccloud.com/x-doyaeoqhkgktaqek] has joined #bitcoin-core-dev 14:12 -!- rc_423 [~r_423@2605:a000:1611:8f5e:b0b0:a5f0:8baa:a289] has joined #bitcoin-core-dev 14:15 -!- ghjkhjkhjk [25b7d044@37.183.208.68] has joined #bitcoin-core-dev 14:15 -!- ghjkhjkhjk [25b7d044@37.183.208.68] has quit [Remote host closed the connection] 14:22 -!- izaki [~izaki@217.146.82.202] has joined #bitcoin-core-dev 14:22 -!- izaki is now known as Guest55194 14:22 -!- Kiminuo [~mix@193.9.112.252] has joined #bitcoin-core-dev 14:28 < jonatack> vasild: Ok now have the node advertising both torv2 and torv3 local addresses...just needed to set proxy=127.0.0.1:9050 rather than letting bitcoin core create a tor HS automatically, as you mentioned 14:29 < jonatack> (d'oh--and all good) 14:31 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 14:32 < jonatack> i'm fairly confident with respect to PR 19845. will move on to proper review of 19954. 14:34 -!- Aden_ [~dinodev@41.107.37.2] has quit [Quit: Leaving] 14:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 14:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 14:36 -!- rc_423 [~r_423@2605:a000:1611:8f5e:b0b0:a5f0:8baa:a289] has quit [Remote host closed the connection] 14:37 -!- rc_423 [~r_423@2605:a000:1611:8f5e:b0b0:a5f0:8baa:a289] has joined #bitcoin-core-dev 14:38 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 14:47 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 15:04 -!- rc_423 [~r_423@2605:a000:1611:8f5e:b0b0:a5f0:8baa:a289] has quit [Remote host closed the connection] 15:05 -!- rc_423 [~r_423@2605:a000:1611:8f5e:b0b0:a5f0:8baa:a289] has joined #bitcoin-core-dev 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:12 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 15:14 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 15:17 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 260 seconds] 15:25 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 15:27 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has quit [Ping timeout: 244 seconds] 15:38 < aj> hm, would it be crazy to allow - and/or _ in config options the same way gmail allows . in addresses? ie just treat -signet-challenge and -signetchallenge (and -s-i-g-n-e-t-c-h-a-l-l-e-n-g-e) as aliases? i find squeezecase a pain to read 15:39 * sipa suggests: spaces 15:40 < sipa> ./src/bitcoind "-signet challenge=51" 15:41 < sipa> aj: we already allow - and -- for everything, i think 15:45 -!- sr_gi [~sr_gi@static-240-45-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 15:45 -!- sr_gi [~sr_gi@static-240-45-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 15:46 -!- promag [~promag@31.22.203.71] has quit [Remote host closed the connection] 15:48 < luke-jr> aj: might be exploitable 15:48 < luke-jr> "just run the Fun Draw Transaction RPC" 15:48 < luke-jr> (not command line, but there may be comparable cases now or in the future) 15:49 < sipa> -fun roll loops 15:50 -!- Highway62 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 15:52 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 272 seconds] 15:52 -!- Highway62 is now known as Highway61 15:53 < aj> luke-jr: you could do that exploit already 15:54 < luke-jr> ? 15:54 < luke-jr> oh, maybe, but it's a lot more problematic if you make it explicitly innocent 15:54 < aj> luke-jr: "just run the Fun Draw Transaction RPC -fundrawtransaction" 15:54 < luke-jr> -fun-draw-transaction is a lot more dangerous than -fundrawtransaction IMO 15:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:06 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 260 seconds] 16:08 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 16:39 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 17:00 -!- Guest55194 [~izaki@217.146.82.202] has quit [] 17:01 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 17:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:04 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/be3af4f31089...652c45fdbbd5 17:04 < bitcoin-git> bitcoin/master 1bee1e6 Andrew Chow: Do not create default wallet 17:04 < bitcoin-git> bitcoin/master d26f064 Andrew Chow: Tell users how to load or create a wallet when no wallet is loaded 17:04 < bitcoin-git> bitcoin/master 652c45f Samuel Dobson: Merge #15454: Remove the automatic creation and loading of the default wal... 17:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:06 < bitcoin-git> [bitcoin] meshcollider merged pull request #15454: Remove the automatic creation and loading of the default wallet (master...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/15454 17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 17:07 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 258 seconds] 17:09 < yanmaani> aj: A bit of overengineering, but couldn't you have acceptable "spacing positions" for each arg 17:10 < yanmaani> so you specify something like ("sig" SEP "net" SEP "challenge"), and all 4 combinations are valid 17:10 < yanmaani> signetchallenge, signet-challenge, sig-net-challenge, sig-netchallenge 17:13 < aj> yanmaani: code could specify "signet-challenge" and bitcoind could allow you to drop the "-"s i guess 17:15 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 17:16 < yanmaani> that might be the smart way, yeah. Take "sig-net-challenge", clean both strings of hyphens, check map membership, then ensure hyphenation is valid 17:20 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 272 seconds] 17:20 -!- phyll1s_work [~phyll1s_w@178.162.209.171] has joined #bitcoin-core-dev 17:21 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 272 seconds] 17:21 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 17:29 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:32 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 17:35 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 260 seconds] 17:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 17:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 17:45 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has joined #bitcoin-core-dev 17:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 18:06 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 18:06 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 18:06 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 18:15 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 18:18 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 18:18 -!- face_ [~face@207.154.206.50] has joined #bitcoin-core-dev 18:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 18:19 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Remote host closed the connection] 18:19 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 240 seconds] 18:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 18:19 -!- face [~face@207.154.206.50] has quit [Ping timeout: 240 seconds] 18:19 -!- wraithm_ [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 18:21 -!- TallTim [~TallTim@216.15.20.214] has quit [Ping timeout: 264 seconds] 18:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:24 -!- TallTim [~TallTim@216.15.20.214] has joined #bitcoin-core-dev 18:31 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:33 -!- da39a3ee5e6b4b0d [~textual@171.5.162.140] has joined #bitcoin-core-dev 18:35 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 18:35 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 18:35 < kallewoof> I switched to squeezecase and pushed change, FWIW. (Re-)review would be glorious. https://github.com/bitcoin/bitcoin/pull/18267 18:49 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 18:49 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 18:50 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:51 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:53 -!- roconnor [~roconnor@host-184-164-25-9.dyn.295.ca] has joined #bitcoin-core-dev 18:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds] 18:55 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 18:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 18:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:02 -!- phyll1s_work [~phyll1s_w@178.162.209.171] has quit [Remote host closed the connection] 19:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 19:16 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 19:22 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 272 seconds] 19:31 -!- TheCavalry [~TheCavalr@89.47.234.28] has joined #bitcoin-core-dev 19:33 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 19:34 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 19:42 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 19:55 -!- sr_gi [~sr_gi@static-240-45-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 19:55 -!- sr_gi [~sr_gi@static-240-45-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 20:00 -!- TheCavalry [~TheCavalr@89.47.234.28] has quit [] 20:21 -!- Barras2 [~Barras2@178.162.209.171] has joined #bitcoin-core-dev 21:01 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 21:01 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 21:07 -!- go121212 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev 21:10 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 272 seconds] 21:17 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 21:22 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 21:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:26 < bitcoin-git> [bitcoin] ajtowns opened pull request #19970: sync.h: fix LockAssertion error reporting (master...202009-lockassertion) https://github.com/bitcoin/bitcoin/pull/19970 21:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:41 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 21:43 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 22:02 -!- rc_423 [~r_423@2605:a000:1611:8f5e:b0b0:a5f0:8baa:a289] has quit [Remote host closed the connection] 22:03 -!- rc_423 [~r_423@2605:a000:1611:8f5e:b0b0:a5f0:8baa:a289] has joined #bitcoin-core-dev 22:20 -!- Kiminuo [~mix@193.9.112.252] has quit [Ping timeout: 272 seconds] 22:34 -!- MrPaz [~paz@24.14.251.223] has quit [Ping timeout: 260 seconds] 22:52 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 22:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 23:00 -!- Barras2 [~Barras2@178.162.209.171] has quit [] 23:03 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 23:03 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 23:15 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 23:16 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 23:18 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 23:18 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 23:18 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 23:20 -!- kierra [~kierra@178.162.209.171] has joined #bitcoin-core-dev 23:23 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 23:25 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 23:25 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 23:33 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 23:39 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 23:42 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 23:52 -!- hubsen [5908769d@telia-590876-157.connect.netcom.no] has joined #bitcoin-core-dev 23:53 -!- mmitech___ [sid446259@gateway/web/irccloud.com/x-yblscorrqaflefvt] has quit [Ping timeout: 240 seconds] 23:53 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-kglqdbvrlpwzgiep] has quit [Ping timeout: 240 seconds] 23:53 -!- prusnak [sid403625@gateway/web/irccloud.com/x-nficguliffcrpcdy] has quit [Ping timeout: 240 seconds] 23:53 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-jbmsvpbdwjifqtfc] has quit [Ping timeout: 244 seconds] 23:53 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-pqrwxarkdevoptxj] has quit [Ping timeout: 260 seconds] 23:53 -!- eragmus [sid136308@gateway/web/irccloud.com/x-kxppluajzpecjptn] has quit [Ping timeout: 260 seconds] 23:53 -!- bosma [sid103570@gateway/web/irccloud.com/x-hselhmhmagecemyu] has quit [Ping timeout: 260 seconds] 23:53 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-kkwvhggdkzeaxpvx] has quit [Ping timeout: 260 seconds] 23:53 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-rhxfdwunesihigbv] has quit [Ping timeout: 260 seconds] 23:53 -!- hugohn [sid304114@gateway/web/irccloud.com/x-ybcpgnhejhwlosqh] has quit [Ping timeout: 260 seconds] 23:53 -!- digi_james [sid281632@gateway/web/irccloud.com/x-cziqtxzbhovrsgzp] has quit [Ping timeout: 240 seconds] 23:53 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-autkyjremysgupge] has quit [Ping timeout: 240 seconds] 23:53 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-jkeelzewuuuzwtst] has quit [Ping timeout: 240 seconds] 23:53 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-moqnytbtaisiruva] has joined #bitcoin-core-dev 23:53 -!- amiti [sid373138@gateway/web/irccloud.com/x-iosqyikylgfmviel] has quit [Ping timeout: 244 seconds] 23:53 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-jdxpnzlgkdkqppxf] has quit [Ping timeout: 244 seconds] 23:53 -!- someone235 [uid419897@gateway/web/irccloud.com/x-doyaeoqhkgktaqek] has quit [Ping timeout: 272 seconds] 23:53 -!- endogenic [sid145991@gateway/web/irccloud.com/x-ctvfpmqbadyrpuua] has quit [Ping timeout: 272 seconds] 23:53 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-sxynjjfrpruooghr] has quit [Ping timeout: 240 seconds] 23:53 -!- drbrule [sid395654@gateway/web/irccloud.com/x-tngpbubfdzzoidop] has quit [Ping timeout: 260 seconds] 23:53 -!- mariorz [sid490@gateway/web/irccloud.com/x-pounbcusubmaptop] has quit [Ping timeout: 260 seconds] 23:53 -!- jamesob [sid180710@gateway/web/irccloud.com/x-msxrcsfqcftqvufi] has quit [Ping timeout: 260 seconds] 23:53 -!- michagogo [sid14316@wikia/Michagogo] has quit [Ping timeout: 240 seconds] 23:54 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 23:54 -!- mmitech___ [sid446259@gateway/web/irccloud.com/x-qwhocxhinatjwyah] has joined #bitcoin-core-dev 23:55 -!- prusnak [sid403625@gateway/web/irccloud.com/x-fxisbvxyftpvqwzu] has joined #bitcoin-core-dev 23:55 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 23:55 -!- drbrule [sid395654@gateway/web/irccloud.com/x-iplpgvawjbrmytpt] has joined #bitcoin-core-dev 23:55 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-jfhvdegiyxwignla] has joined #bitcoin-core-dev 23:56 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-kmodawzjplmhfcoq] has joined #bitcoin-core-dev 23:56 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-pktfucgoqepinnex] has joined #bitcoin-core-dev 23:56 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 23:56 -!- digi_james [sid281632@gateway/web/irccloud.com/x-onkyiigagbyecwyz] has joined #bitcoin-core-dev 23:56 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-jztlveruhsdeitzk] has joined #bitcoin-core-dev 23:56 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-yxshwdtkyhrjyuzz] has joined #bitcoin-core-dev 23:56 -!- bosma [sid103570@gateway/web/irccloud.com/x-rlakjruhpsdwwbtm] has joined #bitcoin-core-dev 23:56 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-emezvqtpooboqkzz] has joined #bitcoin-core-dev 23:56 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-apgijbxtfimtgopk] has joined #bitcoin-core-dev 23:56 -!- someone235 [uid419897@gateway/web/irccloud.com/x-ifwordclkczzxtio] has joined #bitcoin-core-dev 23:56 -!- mariorz [sid490@gateway/web/irccloud.com/x-orjbzcfugnqiwymd] has joined #bitcoin-core-dev 23:57 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 23:57 -!- amiti [sid373138@gateway/web/irccloud.com/x-mcmwfoccfuelamyz] has joined #bitcoin-core-dev 23:57 -!- endogenic [sid145991@gateway/web/irccloud.com/x-joucasbuvmgxjdgf] has joined #bitcoin-core-dev 23:58 -!- michagogo [sid14316@wikia/Michagogo] has joined #bitcoin-core-dev --- Log closed Fri Sep 18 00:00:22 2020