--- Log opened Wed Sep 23 00:00:26 2020 00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/b1291b2e8fc3...821989382557 00:03 < bitcoin-git> bitcoin/master fa2ad5d MarcoFalke: test: Run signet test even when wallet was not compiled 00:03 < bitcoin-git> bitcoin/master 77771a0 MarcoFalke: refactor: Remove SignetTxs::m_valid and use optional instead 00:03 < bitcoin-git> bitcoin/master fae0548 MarcoFalke: fuzz: Remove needless guard 00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:03 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19993: refactor: Signet fixups (master...2009-signetFixups) https://github.com/bitcoin/bitcoin/pull/19993 00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:05 -!- jonatack [~jon@37.164.9.222] has quit [Ping timeout: 260 seconds] 00:05 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9966:2e66:e682:ecb1] has quit [Remote host closed the connection] 00:06 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9966:2e66:e682:ecb1] has joined #bitcoin-core-dev 00:21 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has joined #bitcoin-core-dev 00:22 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:36 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9966:2e66:e682:ecb1] has quit [Remote host closed the connection] 00:36 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9966:2e66:e682:ecb1] has joined #bitcoin-core-dev 00:39 < vasild> luke-jr: https://github.com/bitcoin/bips/pull/907 can be merged? It has 4 ACKs, including from the BIP author (wumpus). 00:41 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9966:2e66:e682:ecb1] has quit [Ping timeout: 272 seconds] 00:57 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds] 00:58 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:06 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 240 seconds] 01:09 -!- jonatack_ [~jon@213.152.162.181] has joined #bitcoin-core-dev 01:09 -!- jonatack_ [~jon@213.152.162.181] has quit [Client Quit] 01:12 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad0a:7f5e:18c2:fa27] has joined #bitcoin-core-dev 01:19 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 01:20 -!- jonatack [~jon@213.152.162.181] has joined #bitcoin-core-dev 01:23 -!- kljasdfvv [~flack@p200300d46f0c7600c5edd51d4a58354d.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 01:25 < wumpus> yes, it should be merged 01:25 -!- kljasdfvv [~flack@p200300d46f0c76006d1c92f0f2432694.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:29 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad0a:7f5e:18c2:fa27] has quit [Remote host closed the connection] 01:30 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad0a:7f5e:18c2:fa27] has joined #bitcoin-core-dev 01:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:33 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 01:34 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad0a:7f5e:18c2:fa27] has quit [Ping timeout: 260 seconds] 02:00 -!- mrd [~mrd@185.244.214.216] has quit [] 02:03 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 02:04 -!- kexkey [~kexkey@89.36.78.166] has quit [Ping timeout: 258 seconds] 02:10 -!- devnewton [~devnewton@84.39.117.57] has joined #bitcoin-core-dev 02:13 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 02:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 02:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 02:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds] 02:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:38 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Remote host closed the connection] 02:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 02:43 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 240 seconds] 02:53 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 02:54 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 02:55 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 03:03 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:06 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:12 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 03:16 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 03:18 -!- Rose52Denesik [~Rose52Den@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:18 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 03:21 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 03:25 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 03:25 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 03:27 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 03:28 < jnewbery> backport #19606 reliably fails the appveyor build 03:28 < gribble> https://github.com/bitcoin/bitcoin/issues/19606 | Backport wtxid relay to v0.20 by jnewbery · Pull Request #19606 · bitcoin/bitcoin · GitHub 03:28 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 03:28 < jnewbery> Error is "ERROR: Qt binary download did not match the expected hash.". Is there some fix we need to backport to 0.20? 03:28 -!- Rose52Denesik [~Rose52Den@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds] 03:29 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 03:29 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 03:30 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 03:31 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 03:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Remote host closed the connection] 03:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 03:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 03:55 < aj> jnewbery: i think that's an appveyor caching bug that just happens occassionally, and goes away about a day later? not sure 04:03 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 04:09 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 04:10 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 04:10 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 04:10 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 04:16 < wumpus> oh no not appveyor caching problems again, I'm not aware of any recent patches in that regard no 04:17 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 04:23 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 04:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 260 seconds] 04:28 < wumpus> taking a look 04:32 -!- MrPaz [~paz@24.14.251.223] has joined #bitcoin-core-dev 04:33 < wumpus> the last appveyor-related commit we backported to 0.20 was 961e667600441c35845fcb36b120500c813cd3ed, which removed most of the caching. There have been two other commits since: 3ec8f4c080eab61563f11659c5f1370a34b77dc5 and a104caeb4008a6e0726ba604ece6f53549110354. 04:34 < wumpus> the first changes the version of VC used to the previous version, the other changes it back to the current one (as well as updates VCPKG_COMMIT_ID) 04:35 < wumpus> I guess you could try backporting the combination of those (e.g. keep the VC version the same butchange VCPKG_COMMIT_ID), the reason to do it was unrelated to qt though 04:35 < wumpus> but maybe it influences that too I don't know 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:48 < bitcoin-git> [bitcoin] practicalswift opened pull request #20001: net: Use default proxy server (127.0.0.1:9050) if -proxy is specified without arguments (instead of continuing without proxy server) (master...use-localhost-instead-of-silently-skipping-proxy) https://github.com/bitcoin/bitcoin/pull/20001 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:48 < bitcoin-git> [bitcoin] jonatack opened pull request #20002: net, rpc, cli: expose CNetAddr::GetNetClass in getpeerinfo, use in -netinfo (master...getpeerinfo-GetNetClass) https://github.com/bitcoin/bitcoin/pull/20002 04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:55 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/821989382557...9e217f5a6f08 04:56 < bitcoin-git> bitcoin/master 1b615e6 Gregory Sanders: zmq test: Actually make reorg occur 04:56 < bitcoin-git> bitcoin/master e76fc2b Gregory Sanders: Add 'sequence' zmq publisher to track all block (dis)connects, mempool del... 04:56 < bitcoin-git> bitcoin/master 68c3c7e Gregory Sanders: Add functional tests for zmq sequence topic and mempool sequence logic 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:56 < bitcoin-git> [bitcoin] laanwj merged pull request #19572: ZMQ: Create "sequence" notifier, enabling client-side mempool tracking (master...zmq_sequence_all) https://github.com/bitcoin/bitcoin/pull/19572 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:58 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer] 05:00 -!- devnewton [~devnewton@84.39.117.57] has quit [] 05:04 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 05:06 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 05:08 -!- jonatack [~jon@213.152.162.181] has quit [Ping timeout: 260 seconds] 05:10 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 05:21 -!- hoobop1 [~hoobop@185.244.214.216] has joined #bitcoin-core-dev 05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:33 < bitcoin-git> [bitcoin] practicalswift closed pull request #20001: net: Use proxy server 127.0.0.1 if -proxy is specified without arguments (instead of continuing without proxy server) (master...use-localhost-instead-of-silently-skipping-proxy) https://github.com/bitcoin/bitcoin/pull/20001 05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:34 < bitcoin-git> [bitcoin] practicalswift opened pull request #20003: net: Print error message if -proxy is specified without arguments (instead of continuing without proxy server) (master...error-on-empty-proxy) https://github.com/bitcoin/bitcoin/pull/20003 05:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:36 < jnewbery> aj wumpus: thanks! I'll try adding those commits to the backport PR. If it fixes the issue then I'll open a PR to backport them separately. 05:37 < vasild> What are the benefits of configuring the tor hidden service in torrc instead of leaving bitcoind to automatically create it via tor-control? 05:40 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:40 < wumpus> vasild: I don't know, it was the old way to do it, but I don't see much benefit--apart from transparency from the sysadmin side maybe (less moving parts, all configuration in one place), if you're configuring Tor for other things too 05:41 < wumpus> jnewbery: ok, hope it helps 05:41 < wumpus> vasild: in any case that's very much an edge case 05:42 < vasild> hmm, if configured via torrc then bitcoind need not be supplied with tor-control auth 05:42 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 05:43 < vasild> these tor-control credentials can do much more to the tor daemon than ask it to create a hidden service - shutdown or arbirary change of the configuration (like editing torrc) 05:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 05:46 < wumpus> right 05:46 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 240 seconds] 05:49 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 05:49 < vasild> so, maybe not giving tor-control auth to bitcoind could be considered as a benefit 05:50 < wumpus> yes, for advanced users 05:51 < wumpus> I still think creating an onion service automatically is a good default though 05:52 < wumpus> when bitcoind has those permissions 05:52 < wumpus> but the manual way should keep being supported, if that's what you mean 05:53 < vasild> just some thoughts wrt #19991 05:53 < gribble> https://github.com/bitcoin/bitcoin/issues/19991 | net: Use alternative port for incoming Tor connections by hebasto · Pull Request #19991 · bitcoin/bitcoin · GitHub 05:55 < vasild> hebasto: so, I think that if the option to specify the bind address is added to 19991 (and this also supplied to ADD_ONION of course), then 19991 will supersede #19043 05:55 < gribble> https://github.com/bitcoin/bitcoin/issues/19043 | torcontrol: add -tortarget config by MDrollette · Pull Request #19043 · bitcoin/bitcoin · GitHub 05:56 < hebasto> vasild: going to implement it 05:57 < vasild> -onionservicetarget=addr:port hmm, that is just another bind + a tag "anything incoming to this addr:port is incoming tor" 05:57 < vasild> right? 05:57 < hebasto> right 05:59 < vasild> what about extending the -bind=addr:port option to something like -bind=addr:port[=tor], for example: -bind=1.2.3.4:8333 -bind=1.2.3.4:8334=tor 05:59 < vasild> instead of adding a new option -onionservicetarget= ? 06:04 < wumpus> making it an attribute makes sense 06:05 < wumpus> (of the bind) 06:06 < vasild> I don't know yet how i2p works, but if it works in a similar way (the i2p daemon connects to us, like in tor) then for i2p that would mean just recognizing =i2p in addition to recognizing =tor, instead of adding new option -i2pservicetarget=addr:port 06:07 < wumpus> right, it's elegant way to think about it and allows for extensibility 06:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 06:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 06:22 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 06:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:40 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20004: test: Add signet witness commitment section parse tests (master...2009-testSignetParse) https://github.com/bitcoin/bitcoin/pull/20004 06:40 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev 06:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:50 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 06:53 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 06:53 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 06:57 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 07:14 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 07:14 -!- Nebraskka [~Nebraskka@51.83.249.56] has quit [Quit: Good day old chaps] 07:14 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 07:15 -!- Nebraskka [~Nebraskka@51.83.249.56] has joined #bitcoin-core-dev 07:22 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 07:25 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 07:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:38 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9e217f5a6f08...8235dca6210d 07:38 < bitcoin-git> bitcoin/master 73f71e1 Hennadii Stepanov: refactor: Use explicit function type instead of template 07:38 < bitcoin-git> bitcoin/master ab2a442 Hennadii Stepanov: Replace LockAssertion with a proper thread safety annotations 07:38 < bitcoin-git> bitcoin/master 0bd1184 Hennadii Stepanov: Remove unused LockAssertion struct 07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:38 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19979: Replace LockAssertion with AssertLockHeld, remove LockAssertion (master...200919-tsa) https://github.com/bitcoin/bitcoin/pull/19979 07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 07:54 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 07:55 -!- kexkey [~kexkey@89.36.78.166] has joined #bitcoin-core-dev 08:00 -!- hoobop1 [~hoobop@185.244.214.216] has quit [] 08:17 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 256 seconds] 08:21 -!- flukiluke [~flukiluke@s91904426.blix.com] has joined #bitcoin-core-dev 08:25 -!- Murch [murch@2a01:4f8:141:1272::2] has joined #bitcoin-core-dev 08:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:11 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 09:24 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:19 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 10:25 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 10:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 10:39 -!- belcher_ is now known as belcher 10:44 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 10:45 < sipa> #addmeetingtopic GCC memcmp bug in version 9 and 10 10:45 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 11:00 -!- flukiluke [~flukiluke@s91904426.blix.com] has quit [] 11:02 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer] 11:02 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev 11:03 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer] 11:04 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev 11:04 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer] 11:06 < jnewbery> #proposedmeetingtopic what sipa just said 11:07 < sipa> ah, that 11:07 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 11:08 -!- t420babe [~t420babe@70.23.53.206] has joined #bitcoin-core-dev 11:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8235dca6210d...5e14fafb316e 11:12 < bitcoin-git> bitcoin/master fa14f57 MarcoFalke: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet) 11:12 < bitcoin-git> bitcoin/master 5e14faf MarcoFalke: Merge #19994: Assert that RPCArg names are equal to CRPCCommand ones (net,... 11:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19994: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet) (master...2009-rpcAssertNames) https://github.com/bitcoin/bitcoin/pull/19994 11:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:22 -!- MasterGruntR75 [~MasterGru@s91904426.blix.com] has joined #bitcoin-core-dev 11:24 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:31 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5e14fafb316e...43305e9810e4 11:31 < bitcoin-git> bitcoin/master 7a89f2e Hennadii Stepanov: build: Fix target name 11:31 < bitcoin-git> bitcoin/master 43305e9 MarcoFalke: Merge #19868: build: Fix target name 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:31 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19868: build: Fix target name (master...200904-make) https://github.com/bitcoin/bitcoin/pull/19868 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:32 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 11:36 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/43305e9810e4...1b313cacc99a 11:37 < bitcoin-git> bitcoin/master 4668ded Carl Dong: validation: Move ~CMainCleanup logic to ~BlockManager 11:37 < bitcoin-git> bitcoin/master 74f73c7 Carl Dong: validation: Pass in chainman to UnloadBlockIndex 11:37 < bitcoin-git> bitcoin/master f8d4975 Carl Dong: validation: Move PruneOneBlockFile to BlockManager 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:37 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19927: validation: Reduce direct g_chainman usage (master...2020-09-reduce-g_chainman-usage) https://github.com/bitcoin/bitcoin/pull/19927 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:42 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Remote host closed the connection] 11:42 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 11:43 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 11:45 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 11:47 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 11:48 < instagibbs> anyone else getting noise on unit tests? "Error: Specified -walletdir "/tmp/test_bitcoin/1600886453_943311758/tempdir/path_does_not_exist" does not exist" 11:48 < instagibbs> sounds like it's part of the test, but pretty noisy to print it :shrug: 11:59 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 11:59 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 12:01 < sipa> hi 12:04 < sipa> oh, oops, i thought it was thursday 12:10 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:14 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 12:19 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 260 seconds] 12:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 12:22 < sipa> MarcoFalke: any reason why qa-assets can't be cloned with --depth=1 or so? 12:22 < sipa> that would avoid pulling in all of its history 12:23 -!- Althea-told-me [~Thunderbi@193.27.13.179] has joined #bitcoin-core-dev 12:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 12:32 -!- Althea-told-me [~Thunderbi@193.27.13.179] has quit [Quit: Althea-told-me] 12:32 -!- Althea-told-me [~Thunderbi@193.27.13.179] has joined #bitcoin-core-dev 12:44 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 12:50 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-dev 12:52 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 13:02 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 13:07 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 13:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 13:17 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 13:26 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 13:29 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 13:49 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-jferurwjzkjcmwcg] has quit [Ping timeout: 246 seconds] 13:49 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-wsyptzydclrzzolx] has quit [Ping timeout: 240 seconds] 13:49 -!- hugohn [sid304114@gateway/web/irccloud.com/x-lapnxcvmvfrikkev] has quit [Ping timeout: 240 seconds] 13:49 -!- mariorz [sid490@gateway/web/irccloud.com/x-orjbzcfugnqiwymd] has quit [Ping timeout: 240 seconds] 13:50 -!- eragmus [sid136308@gateway/web/irccloud.com/x-vrymgoqrceiyzzjc] has quit [Ping timeout: 240 seconds] 13:50 -!- hebasto [sid449604@gateway/web/irccloud.com/x-inkbofgpoucfhdwo] has quit [Ping timeout: 244 seconds] 13:50 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-yxshwdtkyhrjyuzz] has quit [Ping timeout: 260 seconds] 13:50 -!- fjahr [sid374480@gateway/web/irccloud.com/x-iivtmbwrteacwior] has quit [Ping timeout: 260 seconds] 13:50 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-oqmudmeotuswblda] has quit [Ping timeout: 260 seconds] 13:50 -!- nejon [sid38993@gateway/web/irccloud.com/x-rgsolqonvnynybwk] has quit [Ping timeout: 260 seconds] 13:50 -!- ajonas [sid385278@gateway/web/irccloud.com/x-mlutywotlnjlafij] has quit [Ping timeout: 244 seconds] 13:50 -!- noganoo [sid146237@gateway/web/irccloud.com/x-rhuxdnmmohpnyfcd] has quit [Ping timeout: 244 seconds] 13:51 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-wnueoswdnvefglqa] has quit [Ping timeout: 260 seconds] 13:51 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-ocdalhxrivpycxzh] has quit [Ping timeout: 260 seconds] 13:51 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-qcyhrfrvemkspetz] has quit [Ping timeout: 260 seconds] 13:51 -!- fanquake [sid369002@gateway/web/irccloud.com/x-zgkshntuzwgmxpna] has quit [Ping timeout: 260 seconds] 13:51 -!- schmidty [sid297174@gateway/web/irccloud.com/x-vndlzyxlrfxusond] has quit [Ping timeout: 260 seconds] 13:51 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-xlvlfnqcloecnoox] has quit [Ping timeout: 244 seconds] 13:51 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-dvrdckbjkiosvizr] has joined #bitcoin-core-dev 13:51 -!- hugohn [sid304114@gateway/web/irccloud.com/x-ppgcterfmqohuynp] has joined #bitcoin-core-dev 13:51 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-xovyljecjiorysif] has joined #bitcoin-core-dev 13:51 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-jztlveruhsdeitzk] has quit [Ping timeout: 260 seconds] 13:51 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-kmodawzjplmhfcoq] has quit [Ping timeout: 260 seconds] 13:51 -!- ccook [sid271969@gateway/web/irccloud.com/x-stwdzfbzkhamweuz] has quit [Ping timeout: 260 seconds] 13:51 -!- arik__ [sid402902@gateway/web/irccloud.com/x-vhpvqqrvkgeinrje] has quit [Ping timeout: 260 seconds] 13:51 -!- hebasto [sid449604@gateway/web/irccloud.com/x-nmyxppcrtsegfhzd] has joined #bitcoin-core-dev 13:52 -!- mariorz [sid490@gateway/web/irccloud.com/x-wkmfzeeukktdqwlr] has joined #bitcoin-core-dev 13:52 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-rebgtlkvrvslbhur] has quit [Ping timeout: 260 seconds] 13:52 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-lcbrjrhmdourgpbv] has joined #bitcoin-core-dev 13:52 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-wnlspemeqyaimtwd] has joined #bitcoin-core-dev 13:52 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-yjzhntzazsrvnsic] has joined #bitcoin-core-dev 13:52 -!- nejon [sid38993@gateway/web/irccloud.com/x-vprgmbnilwrjraki] has joined #bitcoin-core-dev 13:52 -!- schmidty [sid297174@gateway/web/irccloud.com/x-wtlquklqywhsmnee] has joined #bitcoin-core-dev 13:52 -!- ajonas [sid385278@gateway/web/irccloud.com/x-blhtyvkkpughnfdg] has joined #bitcoin-core-dev 13:52 -!- noganoo [sid146237@gateway/web/irccloud.com/x-tstpzkidlvrfkekb] has joined #bitcoin-core-dev 13:52 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-lynikbyizhcluhrt] has joined #bitcoin-core-dev 13:52 -!- arik__ [sid402902@gateway/web/irccloud.com/x-dufswnhqahookplf] has joined #bitcoin-core-dev 13:52 -!- eragmus [sid136308@gateway/web/irccloud.com/x-nmamwrvumjbmamst] has joined #bitcoin-core-dev 13:52 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-zenthftorqfsiqbx] has joined #bitcoin-core-dev 13:53 -!- ccook [sid271969@gateway/web/irccloud.com/x-kopgruyubcrpcijv] has joined #bitcoin-core-dev 13:53 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-qhaqdejzwhbltqcs] has joined #bitcoin-core-dev 13:53 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-bhhwaubtuqwzpkpo] has joined #bitcoin-core-dev 13:53 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-unnbpixjhavixzyf] has joined #bitcoin-core-dev 13:53 -!- fjahr [sid374480@gateway/web/irccloud.com/x-jpyhlxsbrpmdqpct] has joined #bitcoin-core-dev 13:53 -!- fanquake [sid369002@gateway/web/irccloud.com/x-eksnczgmxnivlsca] has joined #bitcoin-core-dev 13:54 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-tpmykjnomyazgkuv] has joined #bitcoin-core-dev 13:56 -!- qubenix [~qubenix@66.172.11.228] has quit [Quit: quit] 13:58 -!- qubenix [~qubenix@66.172.11.228] has joined #bitcoin-core-dev 14:00 -!- MasterGruntR75 [~MasterGru@s91904426.blix.com] has quit [] 14:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:06 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 14:06 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 14:13 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 14:16 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 14:20 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 14:21 -!- rah1 [~rah@184.75.221.203] has joined #bitcoin-core-dev 14:22 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:30 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 264 seconds] 14:46 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 14:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:49 < bitcoin-git> [bitcoin] sanket1729 opened pull request #20006: Fix misleading error message: Clean stack rule (master...clean_stk) https://github.com/bitcoin/bitcoin/pull/20006 14:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:52 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:12 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 15:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 15:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:31 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 15:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 15:41 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 15:47 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 15:50 -!- arik__ [sid402902@gateway/web/irccloud.com/x-dufswnhqahookplf] has quit [Ping timeout: 240 seconds] 15:50 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-lcbrjrhmdourgpbv] has quit [Ping timeout: 240 seconds] 15:50 -!- drbrule [sid395654@gateway/web/irccloud.com/x-iplpgvawjbrmytpt] has quit [Ping timeout: 244 seconds] 15:50 -!- prusnak [sid403625@gateway/web/irccloud.com/x-fxisbvxyftpvqwzu] has quit [Ping timeout: 244 seconds] 15:50 -!- felixweis [sid154231@gateway/web/irccloud.com/x-ssguchidvcelwjsp] has quit [Ping timeout: 244 seconds] 15:50 -!- dburkett [sid411344@gateway/web/irccloud.com/x-cdapfbharqmwkpvr] has quit [Ping timeout: 244 seconds] 15:50 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-nazzxpuuebwvxkyz] has quit [Ping timeout: 244 seconds] 15:50 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-lynikbyizhcluhrt] has quit [Ping timeout: 260 seconds] 15:50 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-yjzhntzazsrvnsic] has quit [Ping timeout: 260 seconds] 15:50 -!- mariorz [sid490@gateway/web/irccloud.com/x-wkmfzeeukktdqwlr] has quit [Ping timeout: 260 seconds] 15:50 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-jfhvdegiyxwignla] has quit [Ping timeout: 240 seconds] 15:50 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-unnbpixjhavixzyf] has quit [Ping timeout: 240 seconds] 15:50 -!- nejon [sid38993@gateway/web/irccloud.com/x-vprgmbnilwrjraki] has quit [Ping timeout: 240 seconds] 15:50 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-blfjoxusrhpawecr] has quit [Ping timeout: 246 seconds] 15:50 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-xovyljecjiorysif] has quit [Read error: Connection reset by peer] 15:50 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-thnklnleujaidjtm] has quit [Read error: Connection reset by peer] 15:50 -!- ajonas [sid385278@gateway/web/irccloud.com/x-blhtyvkkpughnfdg] has quit [Read error: Connection reset by peer] 15:50 -!- Lexyon____ [sid402723@gateway/web/irccloud.com/x-dvnhpaqmhwugpssx] has quit [Read error: Connection reset by peer] 15:50 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-tpmykjnomyazgkuv] has quit [Read error: Connection reset by peer] 15:50 -!- hebasto [sid449604@gateway/web/irccloud.com/x-nmyxppcrtsegfhzd] has quit [Read error: Connection reset by peer] 15:50 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-qhaqdejzwhbltqcs] has quit [Ping timeout: 240 seconds] 15:50 -!- ccook [sid271969@gateway/web/irccloud.com/x-kopgruyubcrpcijv] has quit [Ping timeout: 240 seconds] 15:50 -!- bosma [sid103570@gateway/web/irccloud.com/x-rlakjruhpsdwwbtm] has quit [Ping timeout: 240 seconds] 15:50 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-pktfucgoqepinnex] has quit [Ping timeout: 240 seconds] 15:50 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-oefffcmvqxljcnys] has quit [Ping timeout: 240 seconds] 15:50 -!- Galvas [uid459296@gateway/web/irccloud.com/x-zxegmahwkbniadtz] has quit [Ping timeout: 240 seconds] 15:50 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-rpqnqyqggmvfkivo] has quit [Ping timeout: 240 seconds] 15:50 -!- eragmus [sid136308@gateway/web/irccloud.com/x-nmamwrvumjbmamst] has quit [Ping timeout: 260 seconds] 15:50 -!- schmidty [sid297174@gateway/web/irccloud.com/x-wtlquklqywhsmnee] has quit [Ping timeout: 260 seconds] 15:51 -!- noganoo [sid146237@gateway/web/irccloud.com/x-tstpzkidlvrfkekb] has quit [Ping timeout: 272 seconds] 15:52 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 260 seconds] 15:52 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-zenthftorqfsiqbx] has quit [Ping timeout: 260 seconds] 15:52 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-kpdvjymxhonijrzi] has joined #bitcoin-core-dev 15:52 -!- hebasto [sid449604@gateway/web/irccloud.com/x-quytyjemkudizcwx] has joined #bitcoin-core-dev 15:52 -!- mariorz [sid490@gateway/web/irccloud.com/x-pytzedgibesjqzxy] has joined #bitcoin-core-dev 15:52 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-bhhwaubtuqwzpkpo] has quit [Ping timeout: 272 seconds] 15:52 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-wnlspemeqyaimtwd] has quit [Ping timeout: 272 seconds] 15:52 -!- eragmus [sid136308@gateway/web/irccloud.com/x-ufktpsgvqqtrmyha] has joined #bitcoin-core-dev 15:52 -!- prusnak [sid403625@gateway/web/irccloud.com/x-wviwjrvoaokompmb] has joined #bitcoin-core-dev 15:52 -!- schmidty [sid297174@gateway/web/irccloud.com/x-bmbajaexrxbnkati] has joined #bitcoin-core-dev 15:52 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-bfidmlipaqyrhoha] has joined #bitcoin-core-dev 15:52 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-kkledzgokmpscoeu] has joined #bitcoin-core-dev 15:53 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 15:53 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-cqnuomelphiostpl] has joined #bitcoin-core-dev 15:53 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-wqgiasczlqvkocbw] has joined #bitcoin-core-dev 15:53 -!- Lexyon____ [sid402723@gateway/web/irccloud.com/x-edcgvowhxfuypovd] has joined #bitcoin-core-dev 15:53 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-sswuueloqcmejcew] has joined #bitcoin-core-dev 15:53 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-ofdvvlddimyjsrwj] has joined #bitcoin-core-dev 15:54 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-pxrxxwvvwcicqstf] has joined #bitcoin-core-dev 15:54 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-duevvwtgqwppemdr] has joined #bitcoin-core-dev 15:54 -!- felixweis [sid154231@gateway/web/irccloud.com/x-epboyqvosgbrdlkk] has joined #bitcoin-core-dev 15:54 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-orjtvsxyrbvwkkno] has joined #bitcoin-core-dev 15:54 -!- Galvas [sid459296@gateway/web/irccloud.com/x-xctslzasbdoehkez] has joined #bitcoin-core-dev 15:54 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-ctsnhdchvjbfordc] has joined #bitcoin-core-dev 15:54 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-wosvtnolrypjpate] has joined #bitcoin-core-dev 15:54 -!- noganoo [sid146237@gateway/web/irccloud.com/x-lndzsjrtpgyyqgax] has joined #bitcoin-core-dev 15:55 -!- ajonas [sid385278@gateway/web/irccloud.com/x-rvvemjovccufccmc] has joined #bitcoin-core-dev 15:55 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-chhwdxnrzsjrcqfx] has joined #bitcoin-core-dev 15:55 -!- fjahr [sid374480@gateway/web/irccloud.com/x-jpyhlxsbrpmdqpct] has quit [Ping timeout: 258 seconds] 15:55 -!- nejon [sid38993@gateway/web/irccloud.com/x-kbfxvlckknwchrfq] has joined #bitcoin-core-dev 15:55 -!- arik__ [sid402902@gateway/web/irccloud.com/x-fnzqjefnrwihqrzf] has joined #bitcoin-core-dev 15:55 -!- drbrule [sid395654@gateway/web/irccloud.com/x-ogdudpwfmbcjqaew] has joined #bitcoin-core-dev 15:55 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-ejycevbpmtskdskl] has joined #bitcoin-core-dev 15:56 -!- dburkett [sid411344@gateway/web/irccloud.com/x-xcwpgfnojiydssfg] has joined #bitcoin-core-dev 15:56 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-dgvryhwztdjphrwc] has joined #bitcoin-core-dev 15:56 -!- ccook [sid271969@gateway/web/irccloud.com/x-abbzbqxxavkyjthy] has joined #bitcoin-core-dev 15:56 -!- fjahr [sid374480@gateway/web/irccloud.com/x-xxhgfjymcdjzupvi] has joined #bitcoin-core-dev 15:56 -!- bosma [sid103570@gateway/web/irccloud.com/x-ucfnvwbnuqmjqgnp] has joined #bitcoin-core-dev 15:57 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-cwafqdlzlyzhhyhc] has joined #bitcoin-core-dev 15:58 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-ofdvvlddimyjsrwj] has quit [Ping timeout: 256 seconds] 15:58 -!- mariorz [sid490@gateway/web/irccloud.com/x-pytzedgibesjqzxy] has quit [Ping timeout: 256 seconds] 16:00 -!- mariorz [sid490@gateway/web/irccloud.com/x-okuxzqxscoxvtwkx] has joined #bitcoin-core-dev 16:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 16:06 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 16:07 -!- pinheadm_ [~pinheadmz@104.140.52.123] has joined #bitcoin-core-dev 16:08 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 16:10 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 256 seconds] 16:11 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 16:11 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 16:11 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-lrokbsurnqtoyeht] has joined #bitcoin-core-dev 16:11 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Disconnected by services] 16:11 -!- tralfaz is now known as davterra 16:12 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-ddjuquxerbxnlpyu] has joined #bitcoin-core-dev 16:13 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 16:16 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 16:21 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 16:40 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 16:40 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 16:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:49 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 16:55 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:55 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-bxvhpqzkrscwvoog] has quit [Ping timeout: 260 seconds] 17:00 -!- rah1 [~rah@184.75.221.203] has quit [] 17:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 17:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 17:12 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 17:12 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 17:13 -!- pinheadm_ [~pinheadmz@104.140.52.123] has quit [Ping timeout: 272 seconds] 17:15 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 17:22 -!- nirik-fre [~nirik-fre@184.75.221.203] has joined #bitcoin-core-dev 17:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 17:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 17:38 -!- nirik-fre [~nirik-fre@184.75.221.203] has quit [Ping timeout: 260 seconds] 17:43 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 17:47 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 17:48 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 17:54 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 260 seconds] 17:54 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 17:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:02 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 18:03 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 18:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 18:31 -!- xchg [~xchg@s91904426.blix.com] has joined #bitcoin-core-dev 18:43 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 18:48 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds] 19:21 -!- Althea-told-me [~Thunderbi@193.27.13.179] has quit [Quit: Althea-told-me] 19:22 < luke-jr> FWIW, I just had a 0.13 wallet go corrupt (so sipa's instance probably wasn't a regression) 19:29 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 19:30 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 19:32 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-btdjauxcaymhdeld] has joined #bitcoin-core-dev 19:46 < luke-jr> anyone know off-hand what GCC we use in gitian builds? :x 19:48 < sipa> linux builds use bionic, so GCC 7 i believe 19:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 19:51 < luke-jr> sipa: do you happen to know this bug in detail enough, to be able to reasonably tell if we would be affected at all? 19:53 < luke-jr> I suppose the only way to be _sure_ would be to do a before/after build using GCC master and master minus 1 19:53 < sipa> luke-jr: affected, i think yes - in particular the cnetaddr code may incorrectly classify IP addresses 19:53 < sipa> i'll look deeper into whether that is actually an issue 19:54 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] 20:00 -!- xchg [~xchg@s91904426.blix.com] has quit [] 20:00 < luke-jr> it would be funny if compilers turned memcmp(…) > -2 and memcmp(…) < 2 into a constant 1 <.< 20:01 < sipa> actually, looking at the code in 0.20, and my understanding of the bug, i don't see why it wouldn't make IsIPv4() return true for literally every address 20:03 < sipa> so i'm probably misunderstanding the bug 20:07 < luke-jr> h mm 20:09 < roconnor> Based on my limited experimation it does seem limited to cases where the static array begins with 0. 20:09 < roconnor> Though I don't really understand why. 20:09 < sipa> that happens to be the case for the IsIPv4 code 20:11 < luke-jr> is it constexpr? 20:12 < sipa> it should be 20:12 < luke-jr> FWIW it looks like the fix is a clean apply to 10.2, so I'm doing a before/after build 20:12 < sipa> what fix? to what? 20:13 < luke-jr> https://gcc.gnu.org/git/?p=gcc.git;a=patch;h=d5803b9876b3d11c93d1a10fabb3fbb1c4a14bd6;hp=3e99ed65cbedf7a6c0abb9cd63c191326995fd34 20:13 < sipa> https://github.com/bitcoin/bitcoin/blob/v0.20.1/src/netaddress.cpp#L12 and https://github.com/bitcoin/bitcoin/blob/v0.20.1/src/netaddress.cpp#L127 20:13 < luke-jr> sipa: I'm building Knots with 10.2 and then 10.2 patched with the fix, then comparing to see if anything changed 20:14 < sipa> ah, good idea 20:14 < roconnor> Does IsIPv4 always return true? 20:15 < luke-jr> I guess if it only affects a minority of nodes, it could and we might not notice? 20:15 < sipa> this test should fail: https://github.com/bitcoin/bitcoin/blob/v0.20.1/src/test/netbase_tests.cpp#L53 20:16 < sipa> (is IsIPv6() calls !IsIPv4() && ...) 20:16 < luke-jr> hrm 20:19 < luke-jr> doh, was building with LLVM 20:19 * luke-jr starts over quickly 20:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:24 < bitcoin-git> [bitcoin] ajtowns closed pull request #19970: sync.h: fix LockAssertion error reporting (master...202009-lockassertion) https://github.com/bitcoin/bitcoin/pull/19970 20:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:30 < roconnor> https://github.com/bitcoin/bitcoin/blob/0.20/src/netaddress.cpp#L237 also. ... assuming that IsIPv4 somehow isn't always returning true. 20:31 < roconnor> Though that test file does seem to be run. 20:47 -!- sr_gi [~sr_gi@static-80-160-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 20:47 -!- sr_gi [~sr_gi@static-80-160-230-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 20:57 -!- gholms1 [~gholms@217.146.82.202] has joined #bitcoin-core-dev 20:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 21:09 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 260 seconds] 21:09 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 21:28 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Ping timeout: 240 seconds] 21:30 -!- dermoth [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev 21:43 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 21:47 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 22:12 -!- ossifrage_ [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 22:13 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 22:14 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev 22:15 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 265 seconds] 22:32 -!- tralfaz is now known as davterra 22:34 -!- MrPaz [~paz@24.14.251.223] has quit [Ping timeout: 258 seconds] 22:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:00 -!- gholms1 [~gholms@217.146.82.202] has quit [] 23:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 23:12 -!- jonatack [~jon@82.102.27.171] has joined #bitcoin-core-dev 23:21 -!- sdx23 [~sdx23@178.239.168.171] has joined #bitcoin-core-dev 23:21 -!- sdx23 is now known as Guest48547 23:28 -!- gloriazhao [uid453516@gateway/web/irccloud.com/x-ffjydwauyyunhkvq] has quit [Quit: Connection closed for inactivity] 23:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 23:35 -!- balbirs [~balbirs__@ozlabs.org] has quit [Quit: ZNC 1.7.5+deb1 - https://znc.in] 23:35 -!- balbirs [~balbirs__@ozlabs.org] has joined #bitcoin-core-dev 23:50 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has joined #bitcoin-core-dev 23:55 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6d30:6d6a:a16a:519c] has quit [Ping timeout: 272 seconds] --- Log closed Thu Sep 24 00:00:27 2020