--- Log opened Fri Oct 09 00:00:41 2020 00:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 00:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:14 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20103: test: Enable mocktime RPC for all test chains (master...2010-testMockAllChains) https://github.com/bitcoin/bitcoin/pull/20103 00:14 < vasild> hi 00:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:17 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20112: test: Speed up wallet_resendwallettransactions with mockscheduler RPC (master...2010-testFasterMock) https://github.com/bitcoin/bitcoin/pull/20112 00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:18 < sipa> vasild: morning 00:18 < vasild> evening :) 00:18 < vasild> (for you) 00:19 < vasild> is it on purpose that WriteCompactSize() can write big numbers, but ReadCompactSize() cannot read them? 00:22 < sipa> vasild: i think in the compactsize-is-only-for-sizes setting we used to have, the issue just didn't occur 00:22 < sipa> as it's not possible to have such a big object to begin with 00:22 < vasild> yeah, so writecompactsize was never called with big numbers 00:23 < sipa> indeed 00:23 < sipa> (and the usage in bip152 is restricted to 16-bit numbers, which obviously won't have any problems) 00:23 < vasild> I will steal that commit https://github.com/sipa/bitcoin/commit/6edfab492aa67e421af556728c1b8b4d17826b80 00:27 < vasild> I am just curous - any idea what are those high service flags 0x800043d and 0x800000d that cannot be a result of bitwise-or-ing NODE_* flags? 00:27 < vasild> of course any peer is free to claim whatever they want in their service flags, including 0xfffff... 00:28 < sipa> some high bits are used for private extensions 00:28 < sipa> not sure what this is 00:28 < vasild> ok 00:29 < hebasto> sipa: good idea to rename CompactSize 00:29 < sipa> vasild: what software/user agent reports these? 00:29 < vasild> I did not record that 00:30 < vasild> just added printf() in CAddress::unserialize to see what is coming in from the network 00:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:34 < vasild> now I did -addnode=62.107.200.30:8333 to see the user agent 00:34 < sipa> they're uninteresting 00:35 < sipa> my dns seed crawler sees them too 00:35 < sipa> but they're from a variaety of innocently-loking user agents 00:35 < vasild> but now getnetworkinfo shows 00:35 < vasild> "addr": "62.107.200.30:8333", 00:35 < vasild> "services": "000000000000040d", 00:35 < vasild> :-O 00:35 < sipa> hmm 00:35 -!- jonatack [~jon@213.152.162.99] has joined #bitcoin-core-dev 00:35 < vasild> yeah, and innocent "subver": "/Satoshi:0.20.1/", 00:36 < sipa> are they being rumoured with this bit set... but then not reported in the version message? 00:36 < hebasto> could this hurt the network? 00:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 00:38 < vasild> sipa: must be that or something else I am missing 00:38 < sipa> i don't think so 00:38 < vasild> I just saw: 00:38 < vasild> CAddress::unser: time=1602210665, services=67109901, addr=178.128.96.96:8333 00:38 < vasild> from my printf 00:38 < vasild> shutdown, restart with -addnode=178.128.96.96:8333 00:38 < vasild> and getpeerinfo: "addr": "178.128.96.96:8333", 00:39 < vasild> "services": "000000000000000d", 00:40 < vasild> we don't do any "filter away any unknown service bits before displaying in getpeerinfo, right? 00:41 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 00:41 < sipa> vasild: i don't think so 00:43 < vasild> just for reference, here is my dummy printf() in CAddress unserialize: https://bpa.st/JYYA 00:45 < sipa> looks right 00:48 < vasild> ok, assuming they get gossiped with the flags but are later not present in the version message when we actually connect 00:49 < sipa> perhaps some broken software is relaying them with that bit set 00:50 < vasild> wumpus: just to confirm - yes, 0.20 would start on a 0.21-modified-peers.dat as if that file was not present, I also think it is ok. Except the obscure/scary deserialize error messages 00:50 < sipa> perhaps we can give a nicer error message in the future for upgrades 00:50 < sipa> but for old software it's too late 00:50 < vasild> given I will be modifying #19954 I will add one line at the start of unserialize to check if the version is too high 00:51 < gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub 00:51 < vasild> exactly 00:51 < vasild> and print something like "detected file format of peers.dat from the future: 4, I can only understand up to 3, starting operation as if peers.dat is empty" 00:52 < hebasto> sipa: if their software is broken should we discourage those peers? 00:54 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection] 00:55 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 00:55 < vasild> maybe a honest/legit/unbroken peer is just relaying some shi^H^Hstuff that was given to him by a broken/malicious guy 00:55 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has joined #bitcoin-core-dev 00:56 < vasild> we don't want to flag the legit peer as misbehaving 00:56 < hebasto> right 00:56 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has quit [Remote host closed the connection] 00:56 < vasild> or also those high service bits could have some purpose, I guess, it is not certain that they are due to broken or malicious software 00:56 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has joined #bitcoin-core-dev 00:57 * hebasto "hidden service" :D 00:58 < vasild> did somebody develop a decentralized instant message chat application using bitcoin p2p network, sneaking the data via the service bits? 00:59 < MarcoFalke> it would be good to log the peer that sent the high bits 00:59 < sipa> MarcoFalke: unfortunately, they're most likely not the ones who introduced it 01:00 < vasild> what happens if a node receives via gossip the same address:port but with different service bits? 01:01 < MarcoFalke> does addrman correct the service bits when a version msg is received? 01:01 < vasild> that too! 01:01 < sipa> they get OR'ed together 01:01 < sipa> but i hope that on an actual connection, it's overwritten 01:02 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 01:02 < vasild> they get OR'ed :( so a node cannot correct his by re-advertising it regularly. Once somebody adds some high bits to his addr:port, it is over. 01:02 < sipa> we should fix that 01:03 < sipa> whatever we receive from the node itself should be written exactly into addrman 01:03 < vasild> change to "newer one overwrites old one"? 01:03 < sipa> i think OR'ing makes sense for rumoured addr messages 01:04 < vasild> I agree that if we connect directly then whatever the peer says is to overwrite the other stuff 01:04 < sipa> but if we receive information from the IP itself (on an outgoing connection), it should overwrite 01:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:04 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 01:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 01:13 < jonatack> catching up with the discussion... yes, the issue I reported is the DB:deserialise error messages and peers.dat being recreated; bitcoind operates fine otherwise. We can't fix the older software, but we can communicate the situation clearly to users (and hopefully fix it henceforth). 01:16 < wumpus> sipa: it's more of a warning message anyway isn't it, people that don't regaularly check the log won't even notice it 01:16 < wumpus> vasild: thanks for confirming, I think there's no problem in that case at all 01:17 < wumpus> if you say "error" I was expecting some kind of emergency shutdown, that *would* be scary, it simply saying that it's unable to load the file and start from scratch isn't scary as such 01:18 < vasild> y 01:18 < jonatack> well, anyone who greps the past log for errors will see 01:18 < jonatack> ERROR: DeserializeDB: Deserialize or I/O error - ReadCompactSize(): size too large: iostream error 01:18 < jonatack> Invalid or missing peers.dat; recreating 01:18 < wumpus> yes 01:19 < vasild> I though jonatack's disk has developed bad sectors :-D 01:19 < jonatack> that allcaps screaming ERROR is a bit worrisome :D 01:19 < vasild> thought 01:19 < wumpus> I agree it could have been avoided with a version marker 01:20 < wumpus> jonatack: that's nothing, those errors used to appear for malformed incoming *network packets* 01:20 < wumpus> ERRORS i mean 01:21 < wumpus> debug.log used to be one big file full of screaming :) 01:21 < jonatack> hehe 01:21 < jonatack> the halloween release 01:22 < wumpus> change the bitcoin logo for a 🎃 01:23 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 01:23 < jonatack> fewer color change proposals :) 01:25 < fanquake> orange.bikeshed.com 01:32 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-dev 01:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has quit [Remote host closed the connection] 01:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has joined #bitcoin-core-dev 01:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:43 -!- Klox048093 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev 01:43 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Remote host closed the connection] 01:44 -!- Klox04809 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer] 01:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 01:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has quit [Ping timeout: 272 seconds] 01:55 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has joined #bitcoin-core-dev 01:55 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has quit [Remote host closed the connection] 01:55 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has joined #bitcoin-core-dev 02:00 -!- BartK [~BartK@195.140.213.38] has quit [] 02:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:03 < vasild> jonatack: https://github.com/bitcoin/bitcoin/pull/19954#discussion_r502280047 "I test if my suggestions compile before making them"... and I did not test that it does not compile before I replied :-/ 02:04 < vasild> I guess it compiles because stream is a pointer which remains unmodified (the pointer itself) after the call to stream->ignore() 02:04 -!- kexkey [~kexkey@37.120.205.214] has quit [Ping timeout: 240 seconds] 02:04 < vasild> but anyway, semantically we do modify the state of the stream by the ignore() call, so I dont think it should be tagged with const 02:06 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has quit [Remote host closed the connection] 02:06 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has joined #bitcoin-core-dev 02:08 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:a599:af32:7f4e:31bd] has joined #bitcoin-core-dev 02:10 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dc97:9ef6:ea93:f7db] has quit [Ping timeout: 240 seconds] 02:21 -!- tw1sted1 [~tw1sted@184.75.221.3] has joined #bitcoin-core-dev 02:22 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:a599:af32:7f4e:31bd] has quit [Remote host closed the connection] 02:24 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:75a3:65b9:94dd:6adc] has joined #bitcoin-core-dev 02:26 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:75a3:65b9:94dd:6adc] has quit [Remote host closed the connection] 02:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:75a3:65b9:94dd:6adc] has joined #bitcoin-core-dev 02:27 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 02:29 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 02:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:75a3:65b9:94dd:6adc] has quit [Ping timeout: 260 seconds] 02:33 < jonatack> vasild: no worries, it's an edge case question, was just to learn 02:35 < vasild> jonatack: my reasoning is "if a method changes the object in a way that can be observed from outside, then it should not be const" 02:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d1a4:55c6:bd1d:ed86] has joined #bitcoin-core-dev 02:39 < jonatack> right. looking at it led me to https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#con2-by-default-make-member-functions-const and http://www.cplusplus.com/forum/general/12087/ 02:40 < jonatack> am re-reviewing 19954 02:44 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Quit: Leaving] 02:46 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 02:47 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 02:52 -!- tw1sted1 [~tw1sted@184.75.221.3] has quit [Ping timeout: 272 seconds] 03:00 < jonatack> vasild: nice, in my testing the patch has fixed the DB deserialize errors and peers.dat messages 03:01 < vasild> \o/ 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:03 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/380705ef4f00...6854dbdc88d7 03:03 < bitcoin-git> bitcoin/master 2dc79c4 Hennadii Stepanov: doc: Update and improve files.md 03:03 < bitcoin-git> bitcoin/master 6854dbd fanquake: Merge #20076: doc: Update and improve files.md 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:03 < bitcoin-git> [bitcoin] fanquake merged pull request #20076: doc: Update and improve files.md (master...201004-files) https://github.com/bitcoin/bitcoin/pull/20076 03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:05 < jonatack> vasild: restarting on, say, 0.18.1, I see "ERROR: DeserializeDB: Deserialize or I/O error - CAutoFile::read: end of file: iostream error" and "Invalid or missing peers.dat; recreating", as we mention in the new release notes, but not on 19954 after `cp onion_private_key onion_v3_private_key` 03:06 < jonatack> \o/ indeed :) 03:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 03:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:08 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6854dbdc88d7...12a1c3ad1a43 03:08 < bitcoin-git> bitcoin/master 99992e7 MarcoFalke: doc: Collect release-notes snippets 03:08 < bitcoin-git> bitcoin/master faa0847 MarcoFalke: doc: Add release notes for #20101 03:08 < bitcoin-git> bitcoin/master 12a1c3a fanquake: Merge #20107: doc: Collect release-notes snippets 03:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:09 < bitcoin-git> [bitcoin] fanquake merged pull request #20107: doc: Collect release-notes snippets (master...2010-docRelSnip) https://github.com/bitcoin/bitcoin/pull/20107 03:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:18 -!- Imogene64Boyer [~Imogene64@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d1a4:55c6:bd1d:ed86] has quit [Remote host closed the connection] 03:21 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d1a4:55c6:bd1d:ed86] has joined #bitcoin-core-dev 03:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d1a4:55c6:bd1d:ed86] has quit [Ping timeout: 260 seconds] 03:27 -!- ericholscher [~ericholsc@178.162.212.214] has joined #bitcoin-core-dev 03:28 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 03:44 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 03:45 -!- Imogene64Boyer [~Imogene64@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 03:45 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 03:46 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:bdd5:5003:a287:79bb] has joined #bitcoin-core-dev 03:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:bdd5:5003:a287:79bb] has quit [Remote host closed the connection] 03:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:bdd5:5003:a287:79bb] has joined #bitcoin-core-dev 03:55 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 03:56 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:bdd5:5003:a287:79bb] has quit [Remote host closed the connection] 03:58 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has joined #bitcoin-core-dev 04:02 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-fylzqmvccqunwfgv] has quit [Quit: killed] 04:02 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-biesaxxhmagppqbd] has quit [Quit: killed] 04:02 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-dsrpqyjinutvbkkl] has quit [Quit: killed] 04:02 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-fhfpacbiodkcgmso] has quit [Quit: killed] 04:02 -!- rcrtn32002[m] [crtn32002m@gateway/shell/matrix.org/x-pggfffuycocsrezw] has quit [Quit: killed] 04:02 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-ycfalefqrnczphvq] has quit [Quit: killed] 04:02 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-fcmvsdxyqekvmuzf] has quit [Quit: killed] 04:02 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-hdzbzqdiosxgrnnv] has quit [Quit: killed] 04:02 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-gpqibzfoiyliswbi] has quit [Quit: killed] 04:06 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 04:07 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 04:09 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 04:09 -!- rcrtn32002[m] [crtn32002m@gateway/shell/matrix.org/x-yvpognpwkvvutwrk] has joined #bitcoin-core-dev 04:12 -!- TallTim [~TallTim@216.15.20.214] has quit [Quit: Textual IRC Client: www.textualapp.com] 04:22 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has quit [Remote host closed the connection] 04:23 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has joined #bitcoin-core-dev 04:26 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-zydmlpbfrafyahbn] has joined #bitcoin-core-dev 04:26 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-tzemrjvzsabwqtlm] has joined #bitcoin-core-dev 04:26 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-oeomhefeyifncioi] has joined #bitcoin-core-dev 04:26 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-etfjimblzxcavkyd] has joined #bitcoin-core-dev 04:26 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-zkkubkjpeviadhrg] has joined #bitcoin-core-dev 04:26 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-mgtozbmeouhttmpg] has joined #bitcoin-core-dev 04:26 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-wjdwwkwbaltmzekx] has joined #bitcoin-core-dev 04:26 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-vqhhqrhyrgetyuqc] has joined #bitcoin-core-dev 04:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has quit [Ping timeout: 240 seconds] 04:27 -!- vincenzopalazzo [~vincent@mob-109-119-23-10.net.vodafone.it] has joined #bitcoin-core-dev 04:30 -!- jonatack [~jon@213.152.162.99] has quit [Ping timeout: 258 seconds] 04:32 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has joined #bitcoin-core-dev 04:33 -!- opsec_x122 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev 04:34 -!- Netsplit *.net <-> *.split quits: noganoo, mariorz, jeremyrubin, dergoegge, opsec_x12, ericholscher, hsmiths 04:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:39 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 04:40 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 04:40 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-jzdktyxxskljzfdk] has joined #bitcoin-core-dev 04:40 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-pczrdzoxvqofogjr] has joined #bitcoin-core-dev 04:40 -!- mariorz [sid490@gateway/web/irccloud.com/x-jqjfzpvuedgznaeu] has joined #bitcoin-core-dev 04:40 -!- noganoo [sid146237@gateway/web/irccloud.com/x-dhagbkzxrshmzhyq] has joined #bitcoin-core-dev 04:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:40 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection] 04:41 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 04:42 -!- opsec_x122 is now known as opsec_x12 04:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has quit [Remote host closed the connection] 04:46 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 04:46 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 04:47 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 04:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 04:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:52 -!- promag [~promag@188.251.225.32] has quit [Ping timeout: 240 seconds] 04:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 04:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:53 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 04:57 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 04:57 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 05:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:21 -!- dholbach [~dholbach@195.140.213.38] has joined #bitcoin-core-dev 05:21 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 05:26 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 05:26 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:27 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 05:27 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 05:33 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 05:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 05:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:37 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 05:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:45 -!- gloriazhao [uid453516@gateway/web/irccloud.com/x-tiwtubynovndgvvr] has quit [Quit: Connection closed for inactivity] 05:49 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 05:53 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 05:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 05:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 06:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 06:07 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 06:09 < achow101> #proposedwalletmeetingtopic: wallet.dat vs wallet.sqlite 06:11 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 06:11 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 06:16 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 06:18 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:30 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 06:34 -!- Klox0480931 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev 06:35 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 272 seconds] 06:35 -!- Klox048093 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer] 06:36 < hebasto> gh silently fails to "Load more..." of "52 hidden items" on #19988 ( 06:36 < gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub 07:01 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:01 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:05 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 07:06 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:07 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:09 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 07:11 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 07:29 < jonatack> hebasto: saw the same yesterday, i gave up trying to see the discussion :/ 07:36 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has joined #bitcoin-core-dev 07:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 07:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:40 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has quit [Remote host closed the connection] 07:40 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has joined #bitcoin-core-dev 08:00 -!- dholbach [~dholbach@195.140.213.38] has quit [] 08:01 -!- kexkey [~kexkey@89.36.78.246] has joined #bitcoin-core-dev 08:03 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has quit [Remote host closed the connection] 08:03 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has joined #bitcoin-core-dev 08:05 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:f040:868b:a3f2:9626] has joined #bitcoin-core-dev 08:06 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 08:07 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 08:07 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:154d:4bed:82d0:1be6] has quit [Ping timeout: 260 seconds] 08:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 08:10 < vasild> gh censorship! 08:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 08:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 08:18 < michaelfolkson> I don't see how Core is still managed on GitHub in 10 years personally. But will be a massive headache whenever it does move. Ideally done when things are quiet (not with a potential soft fork on the horizon) 08:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 08:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:33 < jonatack> ISTM that GitHub is now starting to hide ACKs and re-ACKs as "one similar comment" 08:38 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 08:39 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:39 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:f040:868b:a3f2:9626] has quit [Remote host closed the connection] 08:40 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f040:868b:a3f2:9626] has joined #bitcoin-core-dev 08:43 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 08:44 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 08:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f040:868b:a3f2:9626] has quit [Ping timeout: 260 seconds] 08:49 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 08:55 -!- kers [~kers@178.162.212.214] has joined #bitcoin-core-dev 08:56 -!- vincenzopalazzo [~vincent@mob-109-119-23-10.net.vodafone.it] has quit [Quit: Leaving] 08:59 < wumpus> I'm not sure moving is that much of a headache, many projects have done this, it's just that the only thing after github that makes sense is self-hosting something like gitlab or gitea, which has quite a lot issues of its own, e.g. who hosts the instance 09:02 < wumpus> I have a weird issue on my freebsd node: it kept making outgoing connections at a rate of ~2 per second, the whole log is full of it, and it wasn't accepting any new blocks. I hope it's not a problem with the TorV3 PR. 09:03 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 09:03 < wumpus> also, it segfaulted on shutdown (I can't reproduce this, unfortunately, so don't have a traceback) 09:03 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev 09:03 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev 09:03 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 09:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:09 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 09:10 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 09:12 < sipa> wumpus: ugh 09:14 < wumpus> 2020-10-09T15:06:40Z New outbound peer connected: version: 70015, blocks=651964, peer=1018923 (full-relay) 09:14 < wumpus> that peer id says enough I think 09:15 < jonatack> wumpus: huh. i have not been seeing that issue with 19954 (on debian) 09:15 < wumpus> it's not happening on my other TorV3 node though so there's no clear correlation 09:16 < wumpus> jonatack: right, it might be a local issue for that node 09:16 < wumpus> currently building plain master 09:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 09:24 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 09:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:28 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 246 seconds] 09:31 -!- roconnor [~roconnor@host-45-78-205-7.dyn.295.ca] has joined #bitcoin-core-dev 09:32 < luke-jr> wumpus: I'm not sure self-hosting is really an improvement over GitHub, aside from the platform presumably being free software 09:33 < luke-jr> the goal is probably a decentralised system, but that doesn't exist yet afaik 09:34 < vasild> there were some attempts to make decentralized alternative of github 09:34 < wumpus> luke-jr: it's an improvement in that we'd have direct control over the software, so it can't say, start hiding consecutive ACKs behind our back 09:34 < vasild> wumpus: I have this sysctl on fbsd: kern.corefile=/coredumps/%U.%N.%P.core 09:35 < wumpus> vasild: good idea 09:35 < vasild> and /coredumps has 1777 perms so that anybody can plant files in it 09:35 < luke-jr> wumpus: whoever is hosting can, whether that's GitHub or ⁇? 09:35 < wumpus> luke-jr: sure, but if it's one of us they're likely going to be more recentive to these kind of complaints than a big corporation 09:36 < vasild> ulimit -c is "unlimited" but I don't think I configured that myself, maybe it is the default 09:36 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 09:36 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 09:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 09:37 < wumpus> same here, it even said in dmesg that it had dumped core but couldn't find the core file 09:37 < sipa> it dumped Core 09:37 < luke-jr> they tend to be big files 09:38 < vasild> does bitcoind change the working directory at startup? to ~/.bitcoin? or to the root /? 09:38 < wumpus> sipa: heh 09:38 < wumpus> vasild: no, it doesn't 09:38 < wumpus> thinking of it, probably daemonize() does though 09:38 < vasild> so the core should probably in the current directory where you started it 09:38 < luke-jr> I know Linux is capable of dumping core into a gdb process directly 09:39 < wumpus> yes, daemon() changes the working directory to /, it has no write access there, so I guess it just lost it 09:43 < wumpus> I've set vasild's sysctl parameter now so next time it should go to /coredumps/ 09:44 < vasild> mkdir /coredumps && chmod 1777 /coredumps 09:45 < sipa> comic relief: https://twitter.com/real_or_random/status/1314596135395262467 09:45 < vasild> remember to rm /coredumps/* periodically because it grows and grows over time ;) 09:46 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f040:868b:a3f2:9626] has joined #bitcoin-core-dev 09:47 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 09:47 < vasild> wumpus: but if dmesg says something like "pid 94776 (conftest), jid 0, uid 0: exited on signal 11 (core dumped) 09:47 < vasild> with "(core dumped)" at the end then it must be somewhere 09:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f040:868b:a3f2:9626] has quit [Remote host closed the connection] 09:50 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f040:868b:a3f2:9626] has joined #bitcoin-core-dev 09:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 09:53 < wumpus> vasild: I couldn't find it at least, but, I 'make clean'ed so deleted the binary by now so I guess there's no point even if I still found it 09:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 09:53 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 09:54 < luke-jr> hmm 09:54 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f040:868b:a3f2:9626] has quit [Ping timeout: 272 seconds] 09:54 < luke-jr> does C undefined behaviour extend to compile time? 09:54 < luke-jr> can the compiler explode the system when you try to compile it? 09:55 < sipa> luke-jr: no 09:55 < sipa> (afaik) 09:56 < wumpus> don't give compiler authors any ideas 09:58 < luke-jr> nuts, could have submitted a patch to GCC to erase everything when it encounters mem* 09:58 < luke-jr> XD 09:58 < luke-jr> wumpus: hey, at least I didn't suggest telemetrics on UB? 10:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 10:01 < wumpus> the most disappointing thing about the whole C UB sitution is how little, historically, C compilers have attempted to detect and reject it, I mean if mem* is only reserved for system functions, fair enough, but make it an error or warning. 10:01 < wumpus> but no they really like their random explosions :) 10:02 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 10:04 < sipa> the reason i suspect is that they don't want programs to misbehave if memslartbartfast suddenly becomes a new standard library function in C2043, and your code is already using it 10:06 < luke-jr> they probably would prefer a C22 compiler is C99-compatible too 10:07 < luke-jr> by making mem* UB, a C22 memfoo doesn't break C99 code 10:08 < luke-jr> (same thing, but from another angle) 10:09 < sipa> i guess a better alternative would be to have a way for the STL to declare "reserved but unused" name patterns to the compiler, so it can error if you use a reserved name, rather than needing to resort to the super-heavy "UB" hammer 10:09 < wumpus> looks like I have the same problem again after merging 19954: my node keeps making outgoing connections, but never gets any blocks 10:10 < sipa> hmm 10:10 < sipa> this looks familiar 10:10 < wumpus> somehow it's dropping all outgoing connections immediately, it stays at 1-3 10:10 < sipa> Murch: do you remember someone on bitcoin SE complaining about similar behavior? 10:10 < wumpus> it does succesfully accept incoming connections but that doesn't help 10:11 < luke-jr> wumpus: to clarify, you mean without 19954 it was okay? 10:11 < wumpus> luke-jr: yes, without that it seemed to be okay 10:11 < wumpus> it did receive a few blocks 10:12 < wumpus> but no crash at shutdown this time 10:13 < wumpus> but it does look like 19954 is the problem, will try again without that 10:13 < sipa> oh, ok 10:13 < sipa> in that case what i remember seeing must have been unrelated 10:13 < wumpus> probably, unless this triggers a similar condition 10:14 < wumpus> I did already try deleting peers.dat 10:16 < achow101> anyone ever see "corrupted size vs. prev_size in fastbins" on stderr before? it's showing up on a change to sqlite wallet that I'm working on 10:18 < sipa> achow101: i wouldn't know what prev_size or fastbins are 10:18 < wumpus> googling it, it's a glibc heap corruption error 10:18 < achow101> it seems to be coming out of libc 10:18 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 10:18 < wumpus> but to answer your questino, no, I've never seen it 10:19 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 10:19 < achow101> great.. 10:19 < luke-jr> valgrind it 10:20 < achow101> good idea 10:23 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 10:28 < roconnor> very early on, the glasgow haskell compiler had an infamous bug where it would delete the source file if you tried to compile it and it had a type error. 10:28 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer] 10:29 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 10:32 < luke-jr> XD 10:37 < sipa> roconnor: type errors are *really* frowned upon 10:41 < achow101> ah, I had a double free 10:43 < sipa> achow101: see youtube link above 10:44 < achow101> heh 10:49 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 10:51 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 10:51 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 10:51 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 10:59 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 11:00 -!- kers [~kers@178.162.212.214] has quit [] 11:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 11:05 -!- jonatack [~jon@213.152.162.15] has joined #bitcoin-core-dev 11:22 -!- ButterflyOfFire [~Butterfly@185.163.110.116] has joined #bitcoin-core-dev 11:27 -!- GankMove [~GankMove@dsl-lprbng11-54f88d-13.dhcp.inet.fi] has quit [Quit: GankMove] 11:31 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds] 11:34 < wumpus> gah, the peer keeps disconnectiong outgoing connections without logging the reason at all (even with debug=net) 11:35 < sipa> wumpus: and just with #19954 ? 11:35 < gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub 11:35 < wumpus> sipa: yes 11:35 < wumpus> without it, it makes outgoing connections succesfully 11:36 < sipa> bizarre, and ungood 11:37 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:38 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 11:40 < Murch> sipa: I don't remember any recent posts to that effect. 11:44 < wumpus> curiously it even happens with listen=0 11:46 < wumpus> well maybe not so curiously because it's about outgoing connections but at least it's not the tor bind stuff itself that interferes 11:47 -!- ares_ [~ares@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 11:50 < jonatack> wumpus: when did the issue start? since the latest 19954 pushes? 11:51 < wumpus> jonatack: I think so, do we have a previous version of the PR somewhere? 11:51 < wumpus> I'm pretty sure this node was running with TORv3 succesfully at some point 11:52 < wumpus> will try to bisect the commits 11:53 < jonatack> there were a couple of important changes this week: on tuesday and today, iirc 11:53 < wumpus> first I'll try testing the branch itself instead of the branch merged on top of master 11:54 < wumpus> to rule out a silent merge conflict 11:56 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 11:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:57 < bitcoin-git> [bitcoin] jonatack opened pull request #20115: cli: -netinfo quick updates/fixups and release note (master...netinfo-fixups) https://github.com/bitcoin/bitcoin/pull/20115 11:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:00 < meshcollider> #startmeeting 12:00 < lightningbot> Meeting started Fri Oct 9 19:00:07 2020 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < achow101> hi\ 12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr 12:00 < meshcollider> jeremyrubin emilengler jonatack hebasto jb55 kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2 12:00 < jonatack> hi 12:00 < hebasto> hi 12:00 < meshcollider> 2:09 AM #proposedwalletmeetingtopic: wallet.dat vs wallet.sqlite 12:01 < meshcollider> #topic wallet.dat vs wallet.sqlite 12:01 < achow101> for sqlite wallets, there's been an ongoing question of whether the sqlite wallet files should be named wallet.dat or wallet.sqlite 12:02 < hebasto> what are pros and cons of each approach? 12:03 < achow101> the PR currently implements wallet.dat. ryanofsky has been arguing for wallet.sqlite in his review comments 12:03 < achow101> i wanted to hear what everyone else thinks 12:03 < Murch> hello 12:03 < hebasto> I've just started to review that pr, so have no opinion 12:03 < achow101> for wallet.dat, the arguments are to maintain backwards compatibility with external documentation and tooling, as well as not causing a problem with a specific downgrade scenario 12:04 < meshcollider> Yeah calling it wallet.dat has the advantage that automatic backup scripts, etc. will continue working fine, and also that users are already conditioned to protecting wallet.dat files 12:04 < achow101> for wallet.sqlite, it's a clearer naming convention, follows sqlite naming convention, and can't be confused with bdb 12:05 < jonatack> hm, good arguments for both 12:05 < achow101> wallet.sqlite also avoids a different set of compatibility prolems 12:05 < sipa> yeah, i'm very much in the middle 12:06 < sipa> some of the naming conventions and expectations around them were already broken when we moved to per-wallet directories 12:06 < sipa> and i don't recall that causing many issues for users 12:06 < achow101> relevant commens. for wallet.dat: https://github.com/bitcoin/bitcoin/pull/19077#issuecomment-705180018 for wallet.sqlite: https://github.com/bitcoin/bitcoin/pull/19077#pullrequestreview-504980287 12:06 < sipa> though, the specific "wallet.dat must be protected with your life" filename convention remained 12:06 < luke-jr> meshcollider: it is already wrong and risks corruption to copy wallet.dat directly 12:06 < fjahr> hi 12:07 < hebasto> if users adopted per-wallet dir, we could expect such adoption for .sqlite 12:07 < sipa> luke-jr: it doesn't if you do it while bitcoind is shut down 12:07 < meshcollider> luke-jr: that doesn't stop users doing it 12:07 < luke-jr> meshcollider: breaking such scripts would be an advantage to renaming 12:07 < sipa> luke-jr: i couldn't disagree more with that 12:07 < luke-jr> a possible issue is restoring though 12:07 < achow101> luke-jr: but breaking such scripts would probably result in backups not being made, which is dangerous 12:07 -!- ares_ [~ares@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 12:08 < luke-jr> achow101: most likely would result in errors instead of possibly-corrupt backups 12:08 < achow101> I would be surprised if said scripts failed in a way that was obvious to the person running it 12:08 < luke-jr> O.o 12:08 < sipa> luke-jr: i agree that we should discourage bad practice, but (a) not by making decisions that can actually cause people to lose money and (b) i disagree this is unsupported - it's only supported when bitcoind is not running though 12:08 < meshcollider> And there are also other tools I imagine, not just backup scripts, which look for wallet.dat by default 12:08 < luke-jr> if a cronjob fails, typically you get an email 12:09 < luke-jr> sipa: at least some versions would reuslt in corruption even if bitcoind exited cleanly 12:09 < achow101> luke-jr: fwiw I have a system backup cronjob and I don't know when/if it fails until I check the logs, and that happens maybe once every 6 months 12:09 < sipa> how so? 12:09 < luke-jr> sipa: we used to not flush/close the db 12:09 < luke-jr> achow101: you should fix that :p 12:09 < sipa> luke-jr: i believe that was very briefly the case, in ancient times 12:09 < achow101> luke-jr: right, but that's an example of a backup script failing and the user not knowing 12:10 < luke-jr> I suppose people doing backups wrong, are also likely to do error notifications wrong 12:10 < sipa> people will do lots of things wrong 12:10 < sipa> doesn't mean we shouldn't do a best effort to avoid them losing money 12:10 < luke-jr> but wallet.dat are currently in a dedicated directory 12:10 < luke-jr> there's no need for that for sqlite, right? 12:11 < sipa> that's a good question 12:11 < achow101> luke-jr: yes, but I think it would be more confusing to users if we stopped doing that 12:11 < sipa> hmm 12:11 < jonatack> modulo the risk of users losing money if renamed, a risk i don't feel competent to evaluate, i tend to agree with ryanofsky's arguments 12:12 < sipa> to me, that'd be one of the advantages of sqlite... not needing a directory for every wallet anymore 12:12 < luke-jr> btw, even if it's wallet.sqlite, it's not like we're renaming without the user knowing 12:13 < luke-jr> wouldn't you expect anyone setting up a backup script to check that it works when they create the wallet, at least once? :P 12:13 < achow101> luke-jr: not necessarily. they'd need to read the release notes, and who the hell does that? 12:13 < luke-jr> achow101: you're seriously suggesting automatically transforming BDB to sqlite? 12:14 < luke-jr> without user interaction? 12:14 < achow101> luke-jr: there's no transformation 12:14 < achow101> what I mean is that sqlite would be default for descriptor wallets, but the only way you would know that is to read the release notes 12:14 < luke-jr> ok, so wallet.dat would remain wallet.dat even if new wallets are wallet.sqlite… 12:14 < achow101> existing wallets are unaffected 12:15 < luke-jr> so the only way someone should lose data is if they never check for a successful backup ever.. 12:15 < achow101> sipa: I suppose that getting rid of the wallet directory thing would solve both of these problems 12:15 < luke-jr> or maybe are backing up numerous wallets and expect newly created ones automatically included 12:16 < achow101> luke-jr: when we get around to implementing bdb to sqlite migration, there could be problems there with the rename 12:17 < luke-jr> achow101: but we get the chance to tell users when they opt into it 12:17 < achow101> true 12:17 < luke-jr> a reason not to rename: acting on file extensions has been kindof deprecated for a long time? 12:18 < achow101> there's also the problems with restoring, and that one downgrade case where a new wallet.dat is made 12:19 < meshcollider> IMO we should get rid of individual directories for sqlite, I don't think that would be confusing 12:21 < achow101> meshcollider: that still has the backup and restore problems, although not the downgrade one if we name the file as the wallet name 12:26 < achow101> any other comments on this topic? 12:27 < meshcollider> Did this help make a decision ;) 12:27 < achow101> not really 12:27 < fjahr> I'm undecided as well, sorry 12:28 < achow101> I'll experiment with a no wallet directory approach and see how big the diff is 12:28 < meshcollider> Yeah that sounds good 12:28 < meshcollider> Any other topics then? 12:29 < jonatack> fjahr: at some point, sometime, we should maybe discuss #18418 12:29 < gribble> https://github.com/bitcoin/bitcoin/issues/18418 | wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100 by fjahr · Pull Request #18418 · bitcoin/bitcoin · GitHub 12:30 < jonatack> perhaps Murch can look at it 12:30 < jonatack> (just a thought, no need to duscuss now) 12:30 < fjahr> Yeah, thanks, I guess at the moment nobody has time but maybe in 2 weeks 12:32 < meshcollider> Ok let's discuss it next time then :) 12:32 < meshcollider> #endmeeting 12:32 < lightningbot> Meeting ended Fri Oct 9 19:32:38 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:32 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-09-19.00.html 12:32 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-09-19.00.txt 12:32 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-09-19.00.log.html 12:32 < jonatack> o/ 12:32 < meshcollider> Thanks all 12:33 < meshcollider> \o 12:37 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 12:58 < luke-jr> btw, I wonder if creating a wallet is really the right response to not finding one named :P 13:02 < roconnor> In a different program I complained where running an obviously read-only operation would create a new file if the required file didn't exist. 13:02 < achow101> luke-jr: it definitely isn't and we should remove that behavior 13:06 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 13:06 -!- [\\\] [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 13:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 13:25 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 13:30 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 13:31 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:34 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 14:00 -!- ButterflyOfFire [~Butterfly@185.163.110.116] has quit [] 14:02 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 14:03 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 14:21 -!- wright [~wright@217.146.82.202] has joined #bitcoin-core-dev 14:31 -!- brianhoffman [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has joined #bitcoin-core-dev 14:32 -!- brianhoffman_ [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has quit [Ping timeout: 256 seconds] 14:37 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds] 14:41 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 14:54 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 15:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 15:21 < sipa> wumpus: any progress? 15:51 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 15:56 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 15:59 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 16:02 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 264 seconds] 16:04 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 258 seconds] 16:05 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 16:09 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 16:23 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 16:34 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:34 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 16:39 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 272 seconds] 16:47 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 16:47 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 16:52 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 16:58 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 17:00 -!- wright [~wright@217.146.82.202] has quit [] 17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:22 -!- Jordack [~Jordack@178.162.212.214] has joined #bitcoin-core-dev 17:35 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 17:35 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 17:36 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-btdjauxcaymhdeld] has quit [Ping timeout: 260 seconds] 17:36 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ymbjzimilbdxsocu] has joined #bitcoin-core-dev 17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:58 < bitcoin-git> [bitcoin] leozz37 opened pull request #20116: Implemented GitHub Actions workflow for MacOS and Ubuntu (master...github-actions) https://github.com/bitcoin/bitcoin/pull/20116 17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:02 < yanmaani> I'm getting weird errors while building Bitcoin Core, but everything seems to work fine 18:02 < yanmaani> > /usr/bin/ld: error: leveldb/libleveldb.a(libleveldb_a-crc32c.o): 18:02 < yanmaani> for what seems to be every .o file 18:02 < yanmaani> didn't find anything about it on the Internet. Is this a known issue? 18:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:14 < bitcoin-git> [bitcoin] fanquake closed pull request #20116: Implemented GitHub Actions workflow for MacOS and Ubuntu (master...github-actions) https://github.com/bitcoin/bitcoin/pull/20116 18:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:17 < sipa> vasild: i was wrong; when making an outbound connection, we overwrite the addrman services with the peer's reported ones 18:17 < sipa> see CAddrMan::SetServices 18:27 -!- gloriazhao [uid453516@gateway/web/irccloud.com/x-buutjriyeafbzadq] has joined #bitcoin-core-dev 18:28 -!- gloriazhao is now known as glozow 18:30 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 18:32 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Client Quit] 18:37 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 18:37 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Disconnected by services] 18:37 -!- tralfaz is now known as davterra 19:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 19:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 19:23 < Murch> jonatack: okay, put it on my list 19:25 < fanquake> Murch: I just put something on your list 19:31 < Murch> sorry, I meant that I had put it on my list. I realize now that the conjugations of this particular irregular word make my brevity particularly misleading 19:32 < sipa> lalalala http://ncf.idallen.com/english.html 19:33 < Murch> Yes, let's all learn Esperanto or Klingon 19:33 < Murch> Although, this had nothing to do with homophones or irregular pronunciation :p 19:34 < sipa> put and put are arguably homophones 19:35 < Murch> more importantly for my communication mishap, they're homonyms 19:35 < fanquake> Murch: I wasn't trying to correct your spelling hah, I meant I'd just tagged you in #20040. 19:35 < gribble> https://github.com/bitcoin/bitcoin/issues/20040 | wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping by achow101 · Pull Request #20040 · bitcoin/bitcoin · GitHub 19:36 < Murch> fanquake: I thank ye kindly! 19:36 < achow101> moar refactor 19:42 < fanquake> I've passed on more feedback to GitHub, now that we're seeing even more comment related issues: https://0bin.net/paste/9HgV-Dyl#sZlLldWLuSFQGiT1-yYS5ikMyCIIkRLd5lK3fuAD/ql & https://imgur.com/a/mUVsDSX. 19:56 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 20:00 -!- Jordack [~Jordack@178.162.212.214] has quit [] 20:00 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 20:01 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 20:05 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 258 seconds] 20:21 -!- paxed1 [~paxed@185.204.1.185] has joined #bitcoin-core-dev 20:40 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 20:42 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 20:51 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 20:51 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 21:07 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 21:10 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds] 21:12 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 21:49 < tryphe> sipa, such a great piece 21:49 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 21:54 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 265 seconds] 22:05 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds] 22:06 < tryphe> or how about white night, wight knight 22:08 < tryphe> or white knight and wight night :D 22:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 22:10 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 22:13 -!- neo_1 [~neo@2a01:e35:2efd:9150:3d84:11f2:ecb6:fe24] has joined #bitcoin-core-dev 22:17 -!- paxed1 [~paxed@185.204.1.185] has quit [Remote host closed the connection] 22:19 -!- neo_1 [~neo@2a01:e35:2efd:9150:3d84:11f2:ecb6:fe24] has quit [Ping timeout: 272 seconds] 22:19 -!- neo_1 [~neo@lun34-1-82-239-217-21.fbx.proxad.net] has joined #bitcoin-core-dev 22:31 -!- OldMiner [~OldMiner@s91904426.blix.com] has joined #bitcoin-core-dev 22:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 23:00 -!- OldMiner [~OldMiner@s91904426.blix.com] has quit [] 23:13 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:895a:e478:4d4b:2637] has joined #bitcoin-core-dev 23:17 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 23:21 -!- ramsey1 [~ramsey@84.39.117.57] has joined #bitcoin-core-dev 23:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:29 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 23:29 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 23:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:895a:e478:4d4b:2637] has quit [Remote host closed the connection] 23:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:895a:e478:4d4b:2637] has joined #bitcoin-core-dev 23:39 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 23:39 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 23:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:895a:e478:4d4b:2637] has quit [Ping timeout: 260 seconds] 23:48 -!- b10c_ [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Quit: leaving] 23:48 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #bitcoin-core-dev 23:49 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Client Quit] 23:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] --- Log closed Sat Oct 10 00:00:42 2020