--- Log opened Sat Oct 10 00:00:42 2020 00:16 < wumpus> sipa: no, not really since last night, it seems to be a curious case of miscompilation, I still have a broken binary but can't reproduce it anymore when building even exactly the same commit. Things have been working since. 00:18 < wumpus> my only guess is a hardware problem or a weird bug with FreeBSD's clang 8-derived compiler. The binaries are sufficiently different too, it's not like there's a few bytes different so it's easy to compare. 00:19 < sipa> okay 00:19 < sipa> i couldn't reproduce it either 00:19 < sipa> but i don't know the exact circumstancs 00:20 < sipa> if you can't even reproduce it with the same commit (and same peers.dat?), i guess we'll need to assume it was a very local problem 00:20 < wumpus> in any csae, if anyone still wants to figure it out, I two binaries built from the same commit, one with the issue one without 00:20 < sipa> the binaries differ? 00:21 < wumpus> yes, very significantly 00:21 < wumpus> stripped size is the same but everything is in a different place 00:21 < sipa> different compiler/compileflags? 00:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 00:22 < wumpus> no, not intentially at least 00:23 < wumpus> might have been some cruft in the build dir, who knows... the curious thing is that it happened with 19954 and not without though. I still can't explain that. 00:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:24 < wumpus> but I don't think it's anything to worry about for that PR 00:27 < wumpus> (no, peers.dat nor anything in the data directory is at fault, it only depends on what binary is run) 00:30 < sipa> ok 00:31 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 00:35 < wumpus> I guess it will always remain a mystery, running that particular binary still has the same issue: every outgoing peer is disconnected quickly (usually after sending feefilter), no reason logged in debug.log 00:39 < wumpus> (correction: *always after "sending feefilter (8 bytes) peer=X" there's "disconnecting peer=X", sometimes with "Cleared nodestate for peer=X" in between*) 00:39 < sipa> anything interesting if you run in valgrind? 00:41 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 00:41 < wumpus> havne't tried that yet 00:45 < wumpus> it could be thinking that every outgong connection is a feeler connection, it's the only fDisconnect I could find without associated NET logging so quickly 00:46 < wumpus> I wonder what level of debug information FreeBSSD toolchain adds by default 00:49 < wumpus> given that there's 95MB of size difference between the stripped binary and the plain one, quite a lot would be my guess 00:49 < wumpus> could try setting some breakpoints 01:26 -!- Processus42 [~leo@unaffiliated/processus42] has quit [Quit: ZNC 1.7.2 - https://znc.in] 01:26 -!- _0x0ff [~potatoe_f@2001:bc8:47b0:123::1] has quit [Quit: into the offlines] 01:26 -!- Processus42 [~leo@unaffiliated/processus42] has joined #bitcoin-core-dev 01:27 -!- _0x0ff [~potatoe_f@163.172.166.225] has joined #bitcoin-core-dev 01:45 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 01:45 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Disconnected by services] 01:45 -!- tralfaz is now known as davterra 01:49 -!- jonatack [~jon@213.152.162.15] has quit [Ping timeout: 240 seconds] 01:49 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 01:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:54 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 256 seconds] 01:58 < wumpus> sipa: ... okay ... after finally figuring out how to set a hardware memory breakpoint on an atomic value (to see when fDisconnect changes), I discovered something shocking: two parts of the program have different CNode layouts 01:58 < wumpus> sipa: there's an off-by-one where pfrom.fSuccessfullyConnected = true; happens to set pfrom.fDisconnected = true ... 02:00 -!- ramsey1 [~ramsey@84.39.117.57] has quit [] 02:00 < wumpus> sipa: so it's clear, a miscompile! I think a stale .o file somehow as linked in, I have --disable-dependency-tracing as it wouldn't build on FreeBSD otherwise 02:04 -!- kexkey [~kexkey@89.36.78.246] has quit [Ping timeout: 256 seconds] 02:07 < wumpus> vasild: phew, we can ignore the issue, https://github.com/bitcoin/bitcoin/pull/19954#issuecomment-705504702 02:14 < wumpus> anyhow happy I got to the bottom of this, a "silent link issue" must be one of the most evil things I've ever debugged 02:15 < hebasto> wumpus: great to know it 02:17 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 02:17 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 02:21 -!- MartinAS1 [~MartinAS@178.162.212.214] has joined #bitcoin-core-dev 02:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 02:27 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 02:29 -!- jonatack [~jon@37.166.6.124] has joined #bitcoin-core-dev 02:34 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 02:51 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds] 02:54 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 02:54 -!- jonatack [~jon@37.166.6.124] has quit [Ping timeout: 272 seconds] 02:56 -!- jonatack [~jon@213.152.161.170] has joined #bitcoin-core-dev 02:58 -!- neo_1 [~neo@lun34-1-82-239-217-21.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 02:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 03:05 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:08 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds] 03:09 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:13 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 03:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:18 -!- Retta31Goodwin [~Retta31Go@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 03:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:32 -!- jonatack [~jon@213.152.161.170] has quit [Quit: jonatack] 03:36 -!- neo_1 [~neo@2a01:cb1d:84aa:2d00:a9d:6d55:588b:94ce] has joined #bitcoin-core-dev 03:55 -!- kljasdfvv [~flack@p200300d46f015200242699c3026ca4ef.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 03:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 04:13 -!- kljasdfvv [~flack@p200300d46f01520048ddb023080d5fef.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:31 -!- kljasdfvv [~flack@p200300d46f01520048ddb023080d5fef.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 04:34 -!- Pavlenex1 [~Thunderbi@109-92-118-36.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev 04:35 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 265 seconds] 04:35 -!- Pavlenex1 is now known as Pavlenex 04:36 -!- Pavlenex1 [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 04:40 -!- Pavlenex [~Thunderbi@109-92-118-36.dynamic.isp.telekom.rs] has quit [Ping timeout: 256 seconds] 04:41 < vasild> sipa: right, so we overwrite the service flags when we outbound-connect to a peer from the received version message, and via gossip we | the flags together if we already have an entry for that addr:port 04:42 < vasild> wumpus: ccache? 04:42 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 04:43 -!- reallll is now known as belcher 04:43 -!- Pavlenex1 [~Thunderbi@141.98.103.251] has quit [Ping timeout: 272 seconds] 04:44 < wumpus> vasild: no, lack of dependency tracking inside automake 04:45 < vasild> this is what I wrote to hebasto just a few days ago when discussing #18750: "long time ago I ran into some obscure compilation issues and after long debugging I figured out that it is due to ccache and I have never been using it after that!" 04:45 < gribble> https://github.com/bitcoin/bitcoin/issues/18750 | build: optionally skip external warnings by vasild · Pull Request #18750 · bitcoin/bitcoin · GitHub 04:45 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:46 -!- Pavlenex1 [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 04:46 < vasild> wumpus: "I have --disable-dependency-tracing as it wouldn't build on FreeBSD otherwise" -- hmm, I don't use that option and it compiles just fine 04:48 < vasild> wen cmake? 04:49 < vasild> :-D 04:49 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 265 seconds] 04:49 -!- Pavlenex1 is now known as Pavlenex 04:54 -!- Retta31Goodwin [~Retta31Go@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds] 04:57 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 05:00 -!- MartinAS1 [~MartinAS@178.162.212.214] has quit [] 05:10 < fanquake> hopefully no time soon 05:10 < fanquake> We’ve got lots more important things to deal with than swapping build systems, and god forbid we have to maintain two at once. 05:13 < wumpus> vasild: you are probably following the new, better build instructions for freebsd that tack on MAKE=gmake instead 05:13 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 05:14 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 05:15 < vasild> wumpus: I run ./autogen.sh && ./configure && gmake 05:16 < wumpus> all build systems have their own set of warts using cmake would just switch one for the other 05:16 < wumpus> vasild: that doesn't work for me 05:17 < wumpus> (and for many other people it doesn't either which is why that is in the build instructions) 05:18 < wumpus> might be a automake/autoconf version thing but in any case I'm not very interested in debugging that now :-) 05:18 < vasild> I saw some mentions of build failures and --disable-dependency-tracing but never bothered to study that, especially that it works for me :) 05:18 < vasild> I mean build works for me without --disable-dependency-tracing 05:18 < wumpus> disabling dependency tracking will result in madness and insanity don't do it, override MAKE intead 05:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:22 -!- justmay1 [~justmay@178.239.168.171] has joined #bitcoin-core-dev 05:46 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:46 -!- ares_ [~ares@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 05:46 -!- ares_ [~ares@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 05:53 -!- MasterdonX [~masterdon@37.120.212.76] has quit [Ping timeout: 256 seconds] 05:57 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 06:44 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 06:44 -!- rc_423_ [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 06:46 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Ping timeout: 240 seconds] 06:49 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 07:00 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 07:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:07 -!- ZAQfx [~fx@unaffiliated/zaqfx] has joined #bitcoin-core-dev 07:08 -!- jonatack [~jon@185.206.225.51] has joined #bitcoin-core-dev 07:13 -!- ZAQfx [~fx@unaffiliated/zaqfx] has quit [Quit: Leaving] 07:37 -!- ZAQfx [~fx@unaffiliated/zaqfx] has joined #bitcoin-core-dev 07:46 < ariard> vasild: I'm still not understanding how a BIP155 node is supposed to discover the list of network IDs supported by its BIP155-peers ? 07:47 < ariard> for now the table is hardcoded but I assume it will be extended in the future 07:50 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev 07:50 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev 08:00 -!- justmay1 [~justmay@178.239.168.171] has quit [] 08:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 08:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:03 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 08:09 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 08:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:15 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 272 seconds] 08:22 -!- hollowleviathan1 [~hollowlev@185.163.110.116] has joined #bitcoin-core-dev 08:22 -!- hollowleviathan1 is now known as Guest982 08:24 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 08:30 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 08:30 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 08:30 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 08:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds] 08:38 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 08:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:10 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev 09:10 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev 09:12 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 09:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 09:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:22 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 09:26 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 246 seconds] 09:46 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 09:53 -!- Shabra [~piopio@37.161.221.124] has joined #bitcoin-core-dev 09:53 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection] 09:53 -!- Shabra [~piopio@37.161.221.124] has quit [Client Quit] 09:54 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 10:23 < hebasto> sipa: could protecting `m_txrequest` with its own mutex rather with `cs_main` be safe and provide more concurrency? 10:24 < sipa> hebasto: no, because all call sites already hold cs_main 10:24 < hebasto> sipa: ok, thanks 10:24 < sipa> it's also pointless, as net_processing is inherently single-threaded (there is only one message handler thread) 10:25 < sipa> i think net_processing should move to its own locks, instead of cs_main, but that's a larger scope thing, and doing that for just m_txrequest doesn't provide benefits until the rest of the file can make use of it 10:25 < hebasto> then why protecting `m_txrequest` at all? 10:26 < sipa> ? 10:26 < hebasto> if the only thread has access 10:26 < sipa> because we don't want to introduce bugs 10:27 < sipa> if the code is perfect, all thread annotations/checks are wasted effort 10:27 < sipa> we could also delete all tests ;) 10:28 < hebasto> no, please :) 10:28 < sipa> it isn't the case that only one thread has access - it's that (i assume!) in the current code, only one thread actually accesses it 10:29 < hebasto> re "i think net_processing should move to its own locks, instead of cs_main" agree 10:32 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds] 10:59 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 11:00 -!- Guest982 [~hollowlev@185.163.110.116] has quit [] 11:22 -!- litenull [~litenull@185.204.1.185] has joined #bitcoin-core-dev 11:38 -!- roconnor [~roconnor@host-45-78-205-7.dyn.295.ca] has quit [Ping timeout: 265 seconds] 12:02 -!- [\\\] [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 246 seconds] 12:03 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 12:06 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 12:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 12:16 -!- belcher_ is now known as belcher 12:17 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 12:18 -!- ZAQfx [~fx@unaffiliated/zaqfx] has quit [Read error: Connection reset by peer] 12:22 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 265 seconds] 12:29 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:40 -!- rc_423_ [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 13:12 < stevenroose> is there any protocol rule limiting future env type identifiers to 32 bytes? 13:12 < stevenroose> or can it in principle be any length? 13:13 < sipa> "env type identifiers" ? 13:14 < stevenroose> inv* 13:15 < stevenroose> from the inventory messages 13:15 < stevenroose> txid, wtixd, block hash, ... 13:15 < stevenroose> sipa: ^ 13:15 < stevenroose> all current ones are some variant of sha256 hash, but I'm not sure if that's a hard rule 13:17 < sipa> no, they're just 32-bit numbers 13:17 < stevenroose> I mean CInv is currently hash256, so Core would refuse any future inv variants that are > 32 bytes. perhaps that's enough to make sure it won't every be any other length 13:17 < sipa> the current protocol defines a CInv as 32-bit type + 256-bit value 13:17 < stevenroose> key thanks 13:18 < sipa> there isn't even a way to convey anything else 13:18 < sipa> it's not like the "CInv value length" is sent anywhere 13:19 < sipa> a negotiated protocol change could modify that of course 13:21 < stevenroose> ah good point there is no length indicator, hadn't thought about that 13:23 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 13:28 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 272 seconds] 13:37 < jonatack> stevenroose: until very recently, CInv type was implemented as an int and was changed to uint32_t in #19818 13:37 < gribble> https://github.com/bitcoin/bitcoin/issues/19818 | p2p: change `CInv::type` from `int` to `uint32_t`, fix UBSan warning by jonatack · Pull Request #19818 · bitcoin/bitcoin · GitHub 13:37 < jonatack> though it was documented as uint32_t in https://en.bitcoin.it/wiki/Protocol_documentation#Inventory_Vectors 13:37 < jonatack> and in https://btcinformation.org/en/developer-reference#data-messages 13:39 < stevenroose> jonatack: awesome :) yeah in rust-bitcoin it's been a u32 always AFAIK, but I was confused, my question didn't make much sense because as Pieter pointed out, the inv message can only have 32-byte hashes as there is no way to convey items of other lengths 13:39 < jonatack> (by MagicalTux and harding, respectively) 13:50 < luke-jr> jonatack: on all supported platforms, int is 32-bit 13:59 < jonatack> luke-jr: right (https://en.cppreference.com/w/cpp/language/types), recent change was signedness 14:00 -!- litenull [~litenull@185.204.1.185] has quit [] 14:02 -!- awesome_doge [dc873721@gateway/web/cgi-irc/kiwiirc.com/ip.220.135.55.33] has joined #bitcoin-core-dev 14:04 -!- awesome_doge [dc873721@gateway/web/cgi-irc/kiwiirc.com/ip.220.135.55.33] has quit [Client Quit] 14:06 < luke-jr> not sure it matters :P 14:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:21 -!- gchaix [~gchaix@185.204.1.185] has joined #bitcoin-core-dev 14:24 -!- awesome_doge [dc873721@gateway/web/cgi-irc/kiwiirc.com/ip.220.135.55.33] has joined #bitcoin-core-dev 14:26 -!- awesome_doge [dc873721@gateway/web/cgi-irc/kiwiirc.com/ip.220.135.55.33] has quit [Client Quit] 14:34 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-lagmtdtadzeipmap] has joined #bitcoin-core-dev 14:37 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 14:39 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 14:50 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 15:03 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 15:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 15:07 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:12 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 256 seconds] 15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:49 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 15:53 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 16:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 16:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:25 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 16:30 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 16:31 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 16:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 16:35 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 272 seconds] 16:38 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 17:00 -!- gchaix [~gchaix@185.204.1.185] has quit [] 17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:02 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:06 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 17:12 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 265 seconds] 17:20 -!- patryk [~patryk@195.206.169.184] has joined #bitcoin-core-dev 17:47 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 17:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:52 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/12a1c3ad1a43...0b2abaa666d6 17:52 < bitcoin-git> bitcoin/master 1d3ec2a Pieter Wuille: Support bypassing range check in ReadCompactSize 17:52 < bitcoin-git> bitcoin/master 201a459 Vasil Dimov: net: CAddress & CAddrMan: (un)serialize as ADDRv2 17:52 < bitcoin-git> bitcoin/master 353a3fd Vasil Dimov: net: advertise support for ADDRv2 via new message 17:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:52 < bitcoin-git> [bitcoin] fanquake merged pull request #19954: Complete the BIP155 implementation and upgrade to TORv3 (master...torv3) https://github.com/bitcoin/bitcoin/pull/19954 17:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:17 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 18:53 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 18:56 < luke-jr> sigh, spent a few hours debugging #20118 only to find it's because the fix in #5872 I did years ago never got merged -.- 18:57 < gribble> https://github.com/bitcoin/bitcoin/issues/20118 | BITCOIN_SUBDIR_TO_INCLUDE no longer works · Issue #20118 · bitcoin/bitcoin · GitHub 18:57 < gribble> https://github.com/bitcoin/bitcoin/issues/5872 | configure: BITCOIN_SUBDIR_TO_INCLUDE: Improve compatibility with paths including space and multiline cpp output by luke-jr · Pull Request #5872 · bitcoin/bitcoin · GitHub 18:58 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds] 18:59 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 272 seconds] 19:25 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev 19:32 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 19:40 -!- peppecerami [505e797a@host-80-94-121-122.ip.retelit.it] has joined #bitcoin-core-dev 19:41 -!- peppecerami [505e797a@host-80-94-121-122.ip.retelit.it] has quit [Remote host closed the connection] 19:41 -!- peppecerami [505e797a@host-80-94-121-122.ip.retelit.it] has joined #bitcoin-core-dev 19:50 -!- peppecerami [505e797a@host-80-94-121-122.ip.retelit.it] has quit [Ping timeout: 245 seconds] 20:00 -!- patryk [~patryk@195.206.169.184] has quit [] 20:23 -!- solitonmedic [~tougou@cpe-68-174-133-242.nyc.res.rr.com] has joined #bitcoin-core-dev 20:32 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 20:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 20:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:41 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 20:55 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 20:55 -!- openstackstatus1 [~openstack@84.39.117.57] has joined #bitcoin-core-dev 20:57 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 21:16 -!- tralfaz is now known as davterra 21:23 -!- michagogo [sid14316@wikia/Michagogo] has quit [Ping timeout: 240 seconds] 21:25 -!- michagogo [sid14316@wikia/Michagogo] has joined #bitcoin-core-dev 21:48 -!- rabidus_ [~rabidus@81-175-144-89.bb.dnainternet.fi] has joined #bitcoin-core-dev 21:48 -!- rabidus [~rabidus@81-175-144-89.bb.dnainternet.fi] has quit [Ping timeout: 240 seconds] 21:49 -!- awesome_doge1 [awesome-do@gateway/shell/matrix.org/x-jcmhapuepomzeyee] has joined #bitcoin-core-dev 21:52 -!- fanquake_ [sid369002@gateway/web/irccloud.com/x-hhjwpoqkkctrgveh] has joined #bitcoin-core-dev 21:54 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-lagmtdtadzeipmap] has quit [Ping timeout: 240 seconds] 21:54 -!- fanquake [sid369002@gateway/web/irccloud.com/x-mlmfxisownwkerez] has quit [Ping timeout: 240 seconds] 21:54 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 240 seconds] 21:54 -!- fanquake_ is now known as fanquake 21:54 -!- drbrule [sid395654@gateway/web/irccloud.com/x-qzclcwgouytxdizk] has quit [Ping timeout: 240 seconds] 21:54 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 240 seconds] 21:55 -!- sturles [~sturles@ulrik.uio.no] has joined #bitcoin-core-dev 21:55 -!- sturles [~sturles@ulrik.uio.no] has quit [Changing host] 21:55 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 21:56 -!- drbrule [sid395654@gateway/web/irccloud.com/x-gvmrwhzqddqcyzbg] has joined #bitcoin-core-dev 21:59 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 22:14 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 22:14 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 23:00 -!- openstackstatus1 [~openstack@84.39.117.57] has quit [] 23:21 -!- simonbusborg [~simonbusb@84.39.117.57] has joined #bitcoin-core-dev --- Log closed Sun Oct 11 00:00:43 2020