--- Log opened Thu Oct 22 00:00:54 2020 00:03 < kallewoof> Signet miner now running master. Haven't tested it, but I think this means taproot is activated on signet now 00:05 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 00:05 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 272 seconds] 00:07 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 00:19 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 00:25 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has joined #bitcoin-core-dev 00:40 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 00:43 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has joined #bitcoin-core-dev 00:47 -!- IPGlider [~IPGlider@45.76.34.219] has quit [Quit: Ping timeout (120 seconds)] 00:47 -!- IPGlider [~IPGlider@45.76.34.219] has joined #bitcoin-core-dev 00:48 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds] 00:48 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has quit [Ping timeout: 256 seconds] 00:51 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 00:51 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 00:57 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds] 00:58 -!- jonatack [~jon@37.170.172.122] has joined #bitcoin-core-dev 01:02 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 258 seconds] 01:03 -!- jonatack [~jon@37.170.172.122] has quit [Ping timeout: 264 seconds] 01:04 -!- jonatack [~jon@213.152.161.69] has joined #bitcoin-core-dev 01:06 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:10 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has joined #bitcoin-core-dev 01:11 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Quit: Leaving] 01:15 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has quit [Ping timeout: 256 seconds] 01:16 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has quit [Ping timeout: 240 seconds] 01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dda18e7310a2...1cb4e339f978 01:16 < bitcoin-git> bitcoin/master 5aadd4b Prayank: Convert amounts from float to decimal 01:16 < bitcoin-git> bitcoin/master 1cb4e33 MarcoFalke: Merge #20039: test: Convert amounts from float to decimal 01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:16 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20039: test: Convert amounts from float to decimal (master...floatdecimal) https://github.com/bitcoin/bitcoin/pull/20039 01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:21 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has joined #bitcoin-core-dev 01:28 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has quit [Ping timeout: 265 seconds] 01:31 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 01:31 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 01:32 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:32 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 01:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 01:36 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 256 seconds] 01:39 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:48 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 01:55 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 260 seconds] 01:58 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 02:00 -!- Suntop1 [~Suntop@84.39.117.57] has quit [] 02:00 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 02:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1cb4e339f978...7012db2a6bcd 02:04 < bitcoin-git> bitcoin/master fa3af2c MarcoFalke: test: Fix intermittent issue in p2p_feefilter 02:05 < bitcoin-git> bitcoin/master fa5a91a MarcoFalke: test: Fix typo (one tx is enough) in p2p_feefilter 02:05 < bitcoin-git> bitcoin/master 7012db2 MarcoFalke: Merge #20176: test: Fix intermittent issue in p2p_feefilter 02:05 -!- kexkey [~kexkey@37.120.205.214] has quit [Ping timeout: 264 seconds] 02:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:05 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20176: test: Fix intermittent issue in p2p_feefilter (master...2010-testFixIntIssue) https://github.com/bitcoin/bitcoin/pull/20176 02:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:05 < gwillen> /win goto sully 02:05 < gwillen> whoops, heh 02:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:13 -!- belcher_ is now known as belcher 02:18 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 02:18 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 02:19 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Ping timeout: 265 seconds] 02:22 -!- noirin [~noirin@217.146.82.202] has joined #bitcoin-core-dev 02:23 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds] 02:42 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 02:47 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 02:47 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 02:49 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has joined #bitcoin-core-dev 02:52 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 02:56 -!- jonatack [~jon@213.152.161.69] has quit [Ping timeout: 260 seconds] 02:58 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 02:58 -!- jonatack [~jon@37.170.192.187] has joined #bitcoin-core-dev 03:03 -!- TallTim [~TallTim@208-107-234-198-dynamic.midco.net] has quit [Ping timeout: 272 seconds] 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:13 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 03:15 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has quit [Ping timeout: 272 seconds] 03:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:19 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 03:19 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 03:24 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds] 03:50 -!- wxss [~user@mail.deeplinkmedia.com] has quit [Quit: leaving] 03:51 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 258 seconds] 03:51 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 03:52 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 03:57 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 260 seconds] 04:18 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has joined #bitcoin-core-dev 04:18 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 04:19 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:19 < bitcoin-git> [bitcoin] jnewbery opened pull request #20217: net: Remove g_relay_txes (master...2020-10-remove-grelaytxes) https://github.com/bitcoin/bitcoin/pull/20217 04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:32 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 04:32 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 04:55 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev 05:00 -!- noirin [~noirin@217.146.82.202] has quit [] 05:03 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 05:04 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 05:05 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 05:13 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 05:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7012db2a6bcd...88271184e822 05:20 < bitcoin-git> bitcoin/master fa299ac MarcoFalke: test: Speed up wallet_resendwallettransactions test with mockscheduler RPC 05:20 < bitcoin-git> bitcoin/master 8827118 MarcoFalke: Merge #20112: test: Speed up wallet_resendwallettransactions with mocksche... 05:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:20 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20112: test: Speed up wallet_resendwallettransactions with mockscheduler RPC (master...2010-testFasterMock) https://github.com/bitcoin/bitcoin/pull/20112 05:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:20 -!- jonatack [~jon@37.170.192.187] has quit [Read error: Connection reset by peer] 05:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:21 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20218: test: Suppress MaybeCompactWalletDB data race (master...2010-testSuppWalletRace) https://github.com/bitcoin/bitcoin/pull/20218 05:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:21 -!- wez [~wez@154.13.1.56] has joined #bitcoin-core-dev 05:22 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 05:22 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 05:27 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 258 seconds] 05:35 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has quit [Ping timeout: 264 seconds] 05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:37 < bitcoin-git> [bitcoin] luke-jr closed pull request #20204: Wallet: Generate UUID for SQLite wallets (master...sqlite_wallet_uuid) https://github.com/bitcoin/bitcoin/pull/20204 05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:40 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has joined #bitcoin-core-dev 05:53 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 05:58 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 265 seconds] 06:05 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 06:21 -!- visage_ [~visage_@unaffiliated/visage/x-6658724] has joined #bitcoin-core-dev 06:29 -!- MichealJackson [c3d69d22@195.214.157.34] has joined #bitcoin-core-dev 06:31 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 06:31 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving] 06:31 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 06:31 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 06:32 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 06:33 -!- MichealJackson [c3d69d22@195.214.157.34] has quit [Remote host closed the connection] 06:34 -!- AdulrunaRedviva [c3d69d22@195.214.157.34] has joined #bitcoin-core-dev 06:35 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: No route to host] 06:35 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 06:37 -!- wxss [~user@mail.deeplinkmedia.com] has quit [Quit: leaving] 06:44 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 06:44 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 06:46 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 06:46 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 06:47 -!- jonatack [~jon@37.170.192.187] has joined #bitcoin-core-dev 06:50 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 07:18 -!- IGHOR [~quassel@176.121.4.135] has quit [Read error: Connection reset by peer] 07:19 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 07:24 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 07:27 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Quit: Leaving] 07:33 -!- TallTim [~TallTim@208-107-234-198-dynamic.midco.net] has joined #bitcoin-core-dev 07:35 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 07:35 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 07:35 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 07:36 -!- itsjustme [51523d71@d51523d71.access.telenet.be] has joined #bitcoin-core-dev 07:37 -!- kabaum [~kabaum@ua-84-216-128-14.bbcust.telenor.se] has quit [Ping timeout: 272 seconds] 07:43 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 07:49 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection] 07:49 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 07:54 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 07:56 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 07:56 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 07:58 -!- itsjustme [51523d71@d51523d71.access.telenet.be] has quit [Remote host closed the connection] 08:00 -!- wez [~wez@154.13.1.56] has quit [] 08:01 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 256 seconds] 08:01 -!- mdrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has quit [Quit: bye] 08:04 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 265 seconds] 08:05 -!- AdulrunaRedviva [c3d69d22@195.214.157.34] has quit [Remote host closed the connection] 08:07 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 08:17 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 08:20 -!- MTennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 08:22 -!- greylica [~greylica@195.140.213.38] has joined #bitcoin-core-dev 08:22 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 256 seconds] 08:28 -!- tralfaz [~davterra@static-198-54-131-40.cust.tzulo.com] has joined #bitcoin-core-dev 08:28 -!- tralfaz is now known as davterra 08:29 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 08:35 -!- MTennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving] 08:35 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:36 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 08:42 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 246 seconds] 08:42 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 08:42 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 08:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:07 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Ping timeout: 260 seconds] 09:08 -!- dermoth [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev 09:23 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 09:27 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 09:27 -!- jonatack [~jon@37.170.192.187] has quit [Read error: Connection reset by peer] 09:28 -!- jonatack [~jon@37.170.192.187] has joined #bitcoin-core-dev 09:32 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:36 -!- glozow [uid453516@gateway/web/irccloud.com/x-fxxpjkisyjlwfgty] has joined #bitcoin-core-dev 09:42 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:57 < bitcoin-git> [bitcoin] jonatack opened pull request #20220: rpc, test, doc: explicit feerate follow-ups (master...explicit-feerate-follow-ups) https://github.com/bitcoin/bitcoin/pull/20220 09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:04 < bitcoin-git> [bitcoin] hebasto opened pull request #20221: net: compat.h related cleanup (master...201022-compat) https://github.com/bitcoin/bitcoin/pull/20221 10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:06 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 10:19 -!- jonatack [~jon@37.170.192.187] has quit [Ping timeout: 260 seconds] 10:19 -!- Ga1aCt1Cz00__ [~Ga1aCt1Cz@95.90.215.210] has joined #bitcoin-core-dev 10:22 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@2a02:810a:8d40:5ebc:2143:af3d:c6b2:a825] has quit [Ping timeout: 272 seconds] 10:40 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 10:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:50 < bitcoin-git> [bitcoin] ellemouton opened pull request #20222: refactor: CTxMempool constructor clean up (master...ctxmempool_refactor) https://github.com/bitcoin/bitcoin/pull/20222 10:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:57 -!- mdrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has joined #bitcoin-core-dev 11:00 -!- greylica [~greylica@195.140.213.38] has quit [] 11:09 -!- jonatack [~jon@213.152.161.170] has joined #bitcoin-core-dev 11:14 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 11:16 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 11:22 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 11:22 -!- pdurbin1 [~pdurbin@139.28.218.148] has joined #bitcoin-core-dev 11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:23 < bitcoin-git> [bitcoin] achow101 opened pull request #20223: Drop the leading 0 from the version number (master...drop-leading-0) https://github.com/bitcoin/bitcoin/pull/20223 11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:33 -!- davterra [~davterra@static-198-54-131-40.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 11:41 < dongcarl> Anyone know of a way to get the DEBUG_LOG out from Travis? Or is it unobtainable? 11:48 -!- landakram [~mark@2601:642:100:33e0:95d3:ff07:906c:1395] has joined #bitcoin-core-dev 11:50 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 11:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 11:57 -!- landakram [~mark@2601:642:100:33e0:95d3:ff07:906c:1395] has quit [Ping timeout: 260 seconds] 11:57 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 11:59 < wumpus> #startmeeting 11:59 < lightningbot> Meeting started Thu Oct 22 18:59:23 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:59 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:59 < kanzure> hi 11:59 < jnewbery> hello 11:59 < emzy> hi 11:59 < hebasto> hi 11:59 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james 11:59 < wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2 12:00 < sipa> hi 12:00 < jonatack> hi 12:00 < jonasschnelli> hi 12:00 < wumpus> no topics have been proposed yet in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 12:00 < wumpus> any last-minute ones? 12:01 < sipa> yay for all the work that made it into 0.21 12:01 < jnewbery> +1 12:01 < wumpus> yes!!! 12:01 < achow101> hi 12:01 < michaelfolkson> 21.0 not 0.21 12:01 < achow101> michaelfolkson: not yet 12:01 < michaelfolkson> haha 12:02 < wumpus> #topic 0.21 milestone 12:02 < wumpus> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.21.0 12:02 < emzy> I have a DNSSEC setup for dnsseed. Not directly bitcoin core related. 12:02 < wumpus> I think this is the high priority for review now 12:03 < fjahr> hi 12:03 < hebasto> is any way to label with 0.21 milestone prs from the https://github.com/bitcoin-core/gui ? 12:03 < wumpus> the planned date for the branch split-off and rc1 is 2020-11-01 12:04 < wumpus> hebasto: there are no milestones there? 12:04 < wumpus> we probably need to create them then 12:05 < hebasto> wumpus: no milestones at all 12:05 < wumpus> emzy: would DNSSEC help there? 12:06 < wumpus> I guess it would hide what results are returned from the DNS seed to the public internet 12:06 < emzy> wumpus: was for the last-minute topic list. 12:06 < jonatack> perhaps #20220 which has fixes for 0.21 and on which the #19543 work is building 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/20220 | wallet, rpc, test: explicit feerate follow-ups by jonatack · Pull Request #20220 · bitcoin/bitcoin · GitHub 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub 12:06 < wumpus> that's ok, you weren't clear about it being a proposed topic 12:07 < emzy> wumpus: it is mainly to add DNSSEC to the sipa seeds. 12:08 < wumpus> jonatack: ok added 12:08 < emzy> wumpus: not hiding insted signing. 12:08 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds] 12:08 < achow101> maybe #20205 should be added 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub 12:09 < wumpus> right, DNSSEC authenticates it doesn't encrypt, my bad 12:09 < wumpus> achow101: is that a bugfix? 12:09 < achow101> wumpus: luke-jr argues it is. 12:10 < achow101> something about sqlite wallets need unique ids too to not cause problems in the future 12:10 < wumpus> you might want to mention this in the PR description, it is currently unclear about the why of the change, in any case, added 12:11 < wumpus> hebasto: we definitely need to add the milestones there then 12:11 < jonasschnelli> hebasto: I just created the milestones 12:11 < hebasto> jonasschnelli: thanks! 12:11 < wumpus> jonasschnelli: perfect, thanks! 12:12 < hebasto> jonasschnelli: possible candidates for 0.21 https://github.com/users/hebasto/projects/5 12:12 < wumpus> okay, moving to emzy's topic 12:13 < wumpus> #topic DNSSEC setup for dnsseed 12:13 < emzy> Ok. All new here for me to attend.. :) 12:13 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:14 < emzy> This is the issue https://github.com/bitcoin/bitcoin/issues/19714 12:14 < wumpus> #19714 12:14 < gribble> https://github.com/bitcoin/bitcoin/issues/19714 | ops: Enable DNSSEC on all Bitcoin DNS Seed domain names · Issue #19714 · bitcoin/bitcoin · GitHub 12:15 < emzy> It's about having DNSSEC on all dnsseeds. Sipas implementation has no dnssec so I made a setup to run it behind a Bind9 12:15 -!- TallTim [~TallTim@208-107-234-198-dynamic.midco.net] has quit [Ping timeout: 260 seconds] 12:15 < emzy> The howto to set it up is here: https://github.com/sipa/bitcoin-seeder/pull/85 12:16 < wumpus> neat 12:16 < jonasschnelli> nice emzy. Thanks 12:16 < jonasschnelli> Will it only work with bind? 12:16 < jonasschnelli> Would there be the chance to get it working it djbdns? 12:16 < emzy> Someone needs to check it. I hope it is compleate. 12:16 < sipa> emzy: i'll read in more detail later, but how big a batch of IPs does it serve at any point in time? 12:16 < emzy> jonasschnelli: if djbdns allows dynamic updates. Yes. 12:17 < sipa> (as in, how many get extracted from the seeder and pushed into zonefiles) 12:17 < emzy> sipa: it clones the responce from your seeder. 12:17 < sipa> but a response only has 20 or so IP addresses 12:17 < emzy> maybe better say caches it. 12:17 < sipa> i hope it's not serving the same 20 for a whole day? 12:18 < emzy> no 1h 12:18 < sipa> if there was a way to load more of them into the zone file at once, would bind serve random subsets? 12:18 < emzy> could be changed. but the ttl on the sipa seeder is also 1h 12:19 < sipa> emzy: yes, but per request - every ISP gets different results 12:19 < emzy> ah I see. 12:19 < michaelfolkson> practicalswift wants to avoid a "bind monoculture". What are the concerns with that? 12:20 < emzy> I could also request every minute or so. But every time it needs to be signed. So it can't be every request different. 12:20 < luke-jr> wumpus: 20205 is a bugfix because otherwise sqlite wallets lack a unique id which bdb has provided until now 12:21 -!- TallTim [~TallTim@208-107-234-198-dynamic.midco.net] has joined #bitcoin-core-dev 12:21 < emzy> michaelfolkson: there is still the dnsseed from bluematt 12:21 < sipa> emzy: your doc has a cronjob in cron.daily 12:21 < sipa> is that something else? 12:21 < wumpus> luke-jr: this unique id is there to detect loading the same wallet twice? 12:21 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:22 < sipa> emzy: i think bluematt's dnsseed also uses bind 12:22 < emzy> sipa: thats wrong. I will fix that. 12:22 < luke-jr> wumpus: to identify the same wallet even if renamed/moved/backedup/etc 12:22 < sipa> emzy: if you'd load say 100 IP addresses in the zone file instead, would everyone get those 100 IPs on every request? 12:22 < emzy> sipa: wrong in my documentation. My seed has it in crom.hourly 12:22 < emzy> sipa: yes 12:22 < wumpus> luke-jr: right 12:22 < luke-jr> wumpus: we *can* use it for a warning of loading it twice, but thats only one use case 12:23 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has joined #bitcoin-core-dev 12:23 < sipa> also 20025 doesn't actually prevent loading twice; it just adds an ID (iirc) 12:23 < wumpus> luke-jr: but I thought that was the one that was critical 12:23 < luke-jr> wumpus: my prune locks pr is an example of another use case 12:23 < sipa> wumpus: it was for BDB, due to environments being unable to load same db twice 12:24 < achow101> wumpus: loading duplicate sqlite wallets is not a problem. it's only an issue with bdb due to environment caching stuff 12:24 < wumpus> oh 12:24 < sipa> wumpus: in sqlite wallets there is no such constraint, but it may be useful at an application level 12:24 < michaelfolkson> Ah there have been past vulnerabilities in BIND 12:24 < sipa> there is also no use for that currently in the codebase, but adding one is harder if old wallets don't have unique ids 12:24 < sipa> i'm not convinced it's very urgent, but it does seem harmless to add one 12:25 < luke-jr> achow101: it can still be a problem due tio metadata divergence 12:25 < sipa> (correct me if i'm wrong on any of this) 12:25 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 12:25 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 12:25 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:26 < sipa> luke-jr: it may be undesirable at an application level (though ryanofsky seems to disagree with that), but that's different from BDB which has an actual problem with it 12:26 < wumpus> I think adding it cannot hurt in any case and it might come in useful 12:26 < sipa> yeah 12:27 < luke-jr> sipa: yes imo we should at least warn but thats another pr 12:28 < sipa> luke-jr: seems reasonable to me 12:28 < luke-jr> going from error to silently fine is not very good ux imo 12:28 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:29 < bitcoin-git> [bitcoin] sushant-varanasi opened pull request #20224: doc: CI system link added, clarity increased (squashed into a single commit) (master...master) https://github.com/bitcoin/bitcoin/pull/20224 12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:29 < sipa> well, sqlite wallets are new; anything supported for them is whatever we declare is supported 12:29 < luke-jr> well "silently fine *except* you may end up with divergent metadatat" :p 12:29 < sipa> release notes can state in which ways they are different from bdb wallets, which may include support for loading multiple copies 12:29 < sipa> right 12:29 < sipa> i agree with at least warning 12:30 < luke-jr> sipa: ideally users dont care about underlying db 12:31 < luke-jr> (sorry laggy irc today) 12:31 < wumpus> any other topics? 12:31 < achow101> changing the version number scheme? 12:32 < wumpus> #topic Change version number scheme (achow101) 12:32 < achow101> it's about that time of year again to have users complain about our version numbers 12:32 < wumpus> I don't really feel strongly about it either way but a ok with it 12:32 < michaelfolkson> Good blog post from achow101 on moving to sqlite https://achow101.com/2020/10/0.21-wallets 12:33 < achow101> so #20223 drops the leading 0. 12:33 < luke-jr> lets keep semver at least… 12:33 < gribble> https://github.com/bitcoin/bitcoin/issues/20223 | Drop the leading 0 from the version number by achow101 · Pull Request #20223 · bitcoin/bitcoin · GitHub 12:33 < achow101> and makes our major version number actually the major version 12:33 < sipa> concept ack 12:33 < sipa> nobody really treats our 0 as a major version 12:33 < achow101> and maybe people will stop asking for 1.0 12:34 < luke-jr> I'd rather just bump 0 to 1 12:34 < achow101> this should also be a purely cosmetic change since CLIENT_VERSION doesn't change 12:34 < luke-jr> why not? 12:35 < achow101> 1000000 * 0 is still 0 12:35 < sipa> luke-jr: i'm afraid that'd be misinterpreted as an actual major step in development 12:35 < wumpus> it also wouldn't solve anything 12:35 < wumpus> besides 'there is a zero at the beginning' 12:35 < sipa> which i don't think this is; it's correcting for the fact that in practice our minor version number has turned into a conceptual major version 12:35 < luke-jr> sipa: 1.21? 12:36 < wumpus> yes, that is the issue 12:36 < sipa> luke-jr: and what would be next one be? 2.0 or 1.22? 12:36 < achow101> luke-jr: but that 1 is meaningless like 0 is now 12:36 < sipa> (the "next" one as in what would otherwise become 0.22) 12:36 < wumpus> having a static 1 at the beginning would be the same as a 0 12:36 < wumpus> right 12:36 < sipa> wumpus: indeed 12:37 < luke-jr> sipa: I don't agree… major versions rarely reach 20+… 12:37 < luke-jr> sipa: next could be 1.22 or 2.0 depending non what we think its significance is 12:37 < luke-jr> on* 12:37 < michaelfolkson> Could cause some limited confusion with references to previous 0. versions 12:37 < jonatack> I found the versioning mildly unusual at first, nevertheless am unsure it's worth fixing at this point 12:37 < wumpus> that's not how it works with our project 12:37 < achow101> luke-jr: and yet here we are with a version number that's ostensibly major at 21 12:38 < wumpus> we don't judge significance of versions and have a fixed release schedule 12:38 < luke-jr> achow101: but it really isnt 12:38 < emzy> I feel having a high number in front of the dot is more marketing related. 12:38 < wumpus> if we change the version scheme it should be to better reflect what we're actually doing 12:38 < michaelfolkson> Replace questions on when 1.0 with questions on what happened from 0.21 to 22.0 12:38 < achow101> luke-jr: we call it a major release.. 12:38 < wumpus> not what other projects are doing 12:39 < luke-jr> bugfixes increment the 3rd int 12:39 < achow101> michaelfolkson: but that's way easier to explain 12:39 < sipa> luke-jr: if we'd actually also switch to releases that are based on magnitude of changes, but i don't think that's what we're doing 12:39 < sipa> our numbers are already just an indication of time 12:39 < luke-jr> magnitude would only determine 2.0 vs 1.22 12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:40 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/88271184e822...9453fbf5a022 12:40 < bitcoin-git> bitcoin/master 6ed4bca Hennadii Stepanov: qt: Wrap tooltips in the intro window 12:40 < bitcoin-git> bitcoin/master 9453fbf Jonas Schnelli: Merge #20: Wrap tooltips in the intro window 12:40 < luke-jr> it's not like versions are the release schedule 12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:41 -!- qubenix [~qubenix@66.172.11.228] has quit [Quit: quit] 12:41 < wumpus> we do not classify versions by magnitude, the whole reason for proposing to remove the 0. would be to get rid of that illusion (for some people) once and for all 12:41 < achow101> luke-jr: there are software with high major versions. e.g. pip 12:41 < wumpus> firefo 12:41 < sipa> https://bitcoincore.org/en/lifecycle/ 12:41 < achow101> chrome 12:41 < sipa> Bitcoin Core releases are versioned as follows: 0.MAJOR.MINOR, and release candidates are suffixed with rc1, rc2 etc. 12:41 < sipa> We aim to make a major release every 6-7 months. 12:42 < luke-jr> wumpus: well thats what versions are for 12:42 -!- qubenix [~qubenix@66.172.11.228] has joined #bitcoin-core-dev 12:42 < wumpus> luke-jr: not in this project 12:42 < luke-jr> sigh 12:43 < luke-jr> then everything should be 1.x forever 12:43 < achow101> then that's just as meaningless 12:43 < sipa> that's no better than 0.x forever 12:44 < achow101> and then we'll get questions about for when 2.0 12:44 < wumpus> going in circles now 12:44 < luke-jr> either we should classify or not… -.- 12:44 < wumpus> we don't and we won't, the only proposal is to remove a useless 0. that pretty much everyone already leaves out anyway 12:45 < achow101> do we want it for this release or the next? 12:45 < luke-jr> it's not useless and people leaving it off should stop so long as it's there 12:45 < wumpus> this is too late for 0.21 imo 12:45 < wumpus> I don't see any reason to push this last minute 12:46 < achow101> sure 12:46 < sipa> luke-jr: they won't stop given that it's meaningless 12:46 < sipa> our versioning scheme is literally 0.MAJOR.MINOR; the 0. serves no function 12:46 < fjahr> Major versions means breaking API changes. If we say breaking API changes are breaking consensus changes in Bitcoin wouldn't it make sense to keep 0.x until we have to do a hardfork? I know that's not how people think of the versioning but I think that would make sense. 12:47 < luke-jr> fjahr: Core and Bitcoin are different things 12:47 < wumpus> no, the versioning ahs nothing to do with forks and hardforks 12:47 < wumpus> luke-jr: exactly 12:47 < sipa> firefox's versioning scheme is not based on which HTML version they support 12:47 < fjahr> ok 12:48 < michaelfolkson> I thought it was an interesting idea fjahr 12:48 < achow101> fjahr: then we'd be on version 5 or something like that with the changes satoshi made early on 12:48 < luke-jr> sipa: its really 0.minor.bugfixi 12:48 < sipa> luke-jr: it's on our site 12:48 < luke-jr> then the site is wrong 12:48 < achow101> luke-jr: we refer to every 0.x release as a major release 12:49 < luke-jr> so 21.0.bugfix,l 22.0.bugfix? 12:49 < luke-jr> looks silly imo but at least it can make some sense2… 12:50 < michaelfolkson> Ditching the zero assumes we will *never* have a use for it. Any reason for redundancy here however fanciful? 12:50 < emzy> luke-jr: there was a 0.19.0.1 12:50 < luke-jr> emzy: I'm aware 12:50 < sipa> michaelfolkson: that's exactly the problem 12:50 < sipa> michaelfolkson: nobody has an answer to the question "what would constitute something worthy of a 1.x release" 12:51 < luke-jr> ? 12:51 < luke-jr> we should really be past 1.0 12:51 < sipa> yes, we do a major release every 6-7 months! 12:52 < michaelfolkson> If the redundancy is entirely unnecessary for all possible future scenarios I think get rid of it. Just so this discussion doesn't keep coming up (assuming there are no downsides other than a little user confusion) 12:52 < luke-jr> if its not major enough to get 1.0, it's not major ;) 12:53 < sipa> luke-jr: circular reasoning gets us nowhere 12:53 < wumpus> michaelfolkson: I agree 12:53 < luke-jr> sipa: circular? 12:53 < luke-jr> 1.0 is no more importwant that 22.0 12:53 < wumpus> michaelfolkson: that would be the only reason to do it, really, in the end it's just a number and doesn't matter that much, there's no strong reason to change anything 12:54 < achow101> luke-jr: 1.0 has a meaning to dumb humans 12:54 < luke-jr> if we can't do 1.0 because its not important enough, it shoouldnt be 22.0 either 12:54 < achow101> 1.0 is a magic number even if it shouldn't be 12:54 < sipa> i think none of this matters 12:54 < luke-jr> it won't be 2 years later 12:55 < sipa> our release process is around time-based releases, and our version numbers _are_ time-based too 12:56 < sipa> however much you'd like that to be different, the number X in 0.X.Y doesn't mean anything else but "the series of stable releases forked off at a point in time depending on X" 12:56 < luke-jr> then do a calendar version like Ubuntu? :/ 12:56 < luke-jr> I prefer semver, but at least we should use some stabdard… 12:56 < wumpus> 5 minutes to go 12:56 < sipa> it doesn't convey magnitude of changes, and without substantial changes to our release process, they won't be 12:56 < achow101> luke-jr: i'd honestly prefer a calendar version, but dropping 0 is the simplest and least confusing change to make 12:57 < sipa> luke-jr: firefox? chrome? 12:57 < emzy> achow101: +1 12:57 < luke-jr> actually this is our one chance to switch to calendar cleanly 12:57 < achow101> luke-jr: ikr. I proposed that for 0.20 12:58 < luke-jr> sipa: nt for bugfixes 13:01 < wumpus> #endmeeting 13:01 < lightningbot> Meeting ended Thu Oct 22 20:01:06 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 13:01 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-22-18.59.html 13:01 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-22-18.59.txt 13:01 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-22-18.59.log.html 13:01 < jonatack> Wallet meeting tomorrow? 13:01 < jonasschnelli> Oh no. I think I messed up my first GUI repository merge. Made it the "wrong way" (so messed up bitcoin/bitcoin). 13:01 < jonatack> #walletmeetingtopic standardize feerate unit on sat/vB (or sat/kvB... or sat/sipa...) 13:01 < jonasschnelli> Unsure how to proceed now... 13:02 < jonasschnelli> I probably messed up the SHA512 tree. 13:02 < achow101> jonatack: yes 13:03 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 258 seconds] 13:04 < michaelfolkson> Where can you see the topics for these meetings? 13:04 < jonatack> achow101: 👌 c u there 13:05 < jonasschnelli> wumpus: do you have an idea how to correct my latest merge: https://github.com/bitcoin/bitcoin/commits/master? 13:05 < jonasschnelli> I guess a force push is a no go ... :| 13:05 < achow101> michaelfolkson: http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt and http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 13:05 < michaelfolkson> Thanks achow101 13:06 < achow101> jonasschnelli: it doesn't seem that messed up except the commit message is wrong 13:06 < wumpus> jonasschnelli: let me see 13:06 < jonasschnelli> achow101: Yes. It's just the commit message 13:07 < jonasschnelli> (which includes the Tree-SHA512) 13:09 < wumpus> so the only thing wrong is the PR # in the commit message? 13:09 < wumpus> the Tree-SHA256, signature looks to be ok 13:10 < wumpus> and you did intend to merge this? 13:10 < wumpus> if so, I don't think this warrants a force push no 13:10 < jonasschnelli> wumpus: yes. It was an intentional merge. I just used the github-merge tool the wrong way 13:11 < jonasschnelli> wumpus: Oh. Right. The SHA512 should be right as it is the same in the GUI repository 13:11 < jonasschnelli> It is then just the title... which I think is bad but probably not worth a force push 13:13 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 13:13 < luke-jr> sipa: Chromium's version is 4 ints, with bugfixes apparently the 4th; Firefox's are 3 ints, with bugfixes apparently the 3rd; both with marketting-specific inflated major versions 13:14 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 13:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:15 < yanmaani> Does the Bitcoin Core RPC use HTTP 2.0? Is there any way to query it asynchronously? 13:15 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 13:15 < yanmaani> (other than making a new thread for each connection or using a thread pool) 13:15 < luke-jr> if we're going to switch to calendar, we should just rename 0.21 to 20.11 for a clean continuity 13:16 < luke-jr> yanmaani: that is entirely up to your RPC interface.. 13:22 < achow101> luke-jr: I think our versioning pretty closely resembles firefox's actually 13:23 < achow101> I also don't understand chrome's 13:24 < achow101> the inflated versioning is only because they make releases every 2 months 13:25 < luke-jr> achow101: IIRC they did a huge skip a few years ago 13:26 < luke-jr> https://en.wikipedia.org/wiki/Firefox_version_history suggests I'm wrong 13:27 < achow101> luke-jr: all I remember is that firefox just wasn't relevant for a while 13:27 < luke-jr> they had a 33.1, but otherwise it looks like almost all their minor versions are 0 13:28 < achow101> 68 has a bunch of minor releases 13:28 < achow101> seems like they primarily use minor versions for the esr releases 13:32 < luke-jr> I guess that makes sense 13:33 < luke-jr> I assume not for just fixes 13:33 < luke-jr> major.0.bugfix leaves the door open if anyone wants to do some kind of backports-only interim releases 13:34 < achow101> .. all of our minor releases are backports only 13:34 < luke-jr> bugfixes only 13:34 < luke-jr> which is the 3rd int 13:34 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:35 < achow101> firefox esr releases are only bug and security fixes only 13:38 < luke-jr> well, that's not a standard use for int 2 13:48 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 13:54 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 13:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 13:55 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 13:56 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds] 14:00 -!- pdurbin1 [~pdurbin@139.28.218.148] has quit [] 14:00 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 14:06 -!- filchef [~filchef@212.104.97.177] has quit [Read error: Connection reset by peer] 14:06 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 14:07 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 14:10 < yanmaani> luke-jr: You could release 0.21 now, keep it through 2021, and then have 0.22 be the 2022 release as well. You don't have to do it retroactively 14:10 < yanmaani> Wht do you mean 'my RPC interface'? Caller is whatever, but does the server support HTTP 2.0? 14:11 < meshcollider> yanmaani: we release ~twice per year not just once 14:12 < yanmaani> meshcollider: well just stop doing that then :) 14:12 < yanmaani> have minor versions be 'month of release' after say June 2021 14:14 < luke-jr> yanmaani: HTTP 1.0 can be done async just fine 14:14 < luke-jr> sync vs async is entirely your JSON-RPC interface/library 14:15 < yanmaani> luke-jr: Yes but I'll have to start more connections 14:15 < luke-jr> so? 14:15 < yanmaani> If I want to make 10 requests that take 100ms of wall-clock time each, then I'll need to open 1 connection with HTTP 2.0 and 10 with HTTP 1.0 14:15 < yanmaani> It's more implementation work, and probably slightly more resource intensive 14:16 < luke-jr> it's less because you don't need the logic to determine when you need more connections :P 14:17 < luke-jr> less impl work* 14:17 < yanmaani> And because I need to keep the state of which sockets are blocked. 14:17 < luke-jr> or just open a connection per request *shrug* 14:18 < yanmaani> yep. How much resources does it take to open say 100 threads? 14:18 < luke-jr> well, you can always do it async ;) 14:18 < yanmaani> send to threads[rand() % 100], hope for the best 14:18 < yanmaani> gotta keep them open too 14:19 < yanmaani> like does it just need a few MB of RAM, or something more? 14:19 < luke-jr> anyway, Core uses libevent for the HTTP server 14:19 -!- jmp-TOK1 [~jmp-TOK@84.39.117.57] has joined #bitcoin-core-dev 14:19 < luke-jr> yanmaani: there is nothing to stop a single thread from managing many connections each with one request 14:19 < yanmaani> with evhttp? 14:20 < luke-jr> yes 14:20 < yanmaani> I mean thread in bitcoind 14:20 < luke-jr> ah 14:20 < yanmaani> there's a setting "RPC threads", default was 4 on my machine 14:21 < luke-jr> well, if you have N requests you want to run simultaneously, you're going to have N threads Core side to do it 14:21 < yanmaani> Does it gain you anything to have >N connections then? 14:21 < luke-jr> probably not, just a matter of what's easier for you to do 14:22 < yanmaani> and what's the performance cost in spinning up a gazillion threads? 14:22 < luke-jr> if you don't mind them running in sequence, you might consider batching 14:22 < yanmaani> yeah, I might just do that, have a separate piece of code exposing an async API and then just have a queue + thread pool monstrosity hidden behind there 14:23 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 14:42 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection] 14:42 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 14:47 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 14:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 14:51 -!- worc3131 [~quassel@2a02:c7f:c026:9500:a0d2:b9d1:42a4:69b4] has quit [Ping timeout: 272 seconds] 14:53 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:53 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:53 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 14:53 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 14:53 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 14:53 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:53 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 14:53 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 14:55 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Read error: Connection reset by peer] 14:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:57 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 15:02 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 15:59 -!- glozow [uid453516@gateway/web/irccloud.com/x-fxxpjkisyjlwfgty] has quit [Quit: Connection closed for inactivity] 16:03 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 16:08 < yanmaani> Would a PR to add an option to make Bitcoin Core crash/quit if an incorrect RPC password attempt is made be welcomed? 16:15 < luke-jr> yanmaani: I think I would ACK it as an option 16:15 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer] 16:15 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev 16:17 < yanmaani> cool 16:18 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 16:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 16:32 < luke-jr> yanmaani: keep in mind it could become a DoS risk 16:35 < yanmaani> luke-jr: That's the point, to degrade a security risk to a DoS risk 16:35 < yanmaani> "oops I exposed my RPC port, my money is gone" -> "oops I exposed my RPC port, I'll have to restart my node" 16:36 < luke-jr> right 16:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:48 < bitcoin-git> [bitcoin] fanquake closed pull request #20215: doc: CI system link added, clarity increased (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20215 16:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:00 -!- jmp-TOK1 [~jmp-TOK@84.39.117.57] has quit [] 17:12 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 17:19 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 17:21 -!- edunham1 [~edunham@178.239.168.171] has joined #bitcoin-core-dev 17:42 -!- landakram [~mark@2601:642:100:33e0:38bd:cc14:7348:4a22] has joined #bitcoin-core-dev 17:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:46 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 17:46 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 18:47 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 18:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:53 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds] 19:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:11 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9453fbf5a022...9af7c1993b35 19:11 < bitcoin-git> bitcoin/master 56a461f Sebastian Falbesoner: wallet: fix buffer over-read in SQLite file magic check 19:11 < bitcoin-git> bitcoin/master 9af7c19 fanquake: Merge #20216: wallet: fix buffer over-read in SQLite file magic check 19:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:12 < bitcoin-git> [bitcoin] fanquake merged pull request #20216: wallet: fix buffer over-read in SQLite file magic check (master...20201022-wallet-fix-sqlite-magic-buffer-overread) https://github.com/bitcoin/bitcoin/pull/20216 19:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:42 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 19:46 -!- landakram [~mark@2601:642:100:33e0:38bd:cc14:7348:4a22] has quit [Ping timeout: 260 seconds] 20:00 -!- edunham1 [~edunham@178.239.168.171] has quit [] 20:06 -!- Ga1aCt1Cz00__ [~Ga1aCt1Cz@95.90.215.210] has quit [Read error: Connection reset by peer] 20:07 -!- visage_ [~visage_@unaffiliated/visage/x-6658724] has quit [Quit: Textual IRC Client: www.textualapp.com] 20:22 -!- johanna [~johanna@178.239.168.171] has joined #bitcoin-core-dev 20:23 -!- prayank [~andr0irc@2405:205:252d:96c1:8d70:955c:c207:9d3a] has joined #bitcoin-core-dev 20:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:39 -!- prayank [~andr0irc@2405:205:252d:96c1:8d70:955c:c207:9d3a] has quit [Read error: Connection reset by peer] 20:41 -!- prayank [~andr0irc@2405:205:252d:96c1:8d70:955c:c207:9d3a] has joined #bitcoin-core-dev 20:43 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 20:58 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 21:02 -!- prayank [~andr0irc@2405:205:252d:96c1:8d70:955c:c207:9d3a] has quit [Read error: Connection reset by peer] 21:10 -!- prayank [~andr0irc@2405:205:252d:96c1:8d70:955c:c207:9d3a] has joined #bitcoin-core-dev 21:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 21:16 -!- a5m0 [~a5m0@unaffiliated/a5m0] has quit [Remote host closed the connection] 21:21 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 21:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:32 < bitcoin-git> [bitcoin] S3RK opened pull request #20226: wallet, rpc: add listdescriptors command (master...listdescriptors) https://github.com/bitcoin/bitcoin/pull/20226 21:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:00 -!- johanna [~johanna@178.239.168.171] has quit [] 23:09 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 23:11 -!- prayank23 [~andr0irc@2402:8100:206c:c2a2:476:659b:692f:1bea] has joined #bitcoin-core-dev 23:16 -!- prayank [~andr0irc@2405:205:252d:96c1:8d70:955c:c207:9d3a] has quit [Ping timeout: 260 seconds] 23:23 -!- prayank23 [~andr0irc@2402:8100:206c:c2a2:476:659b:692f:1bea] has quit [Ping timeout: 260 seconds] 23:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:46 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 23:56 -!- kephra [~kephra@178.239.168.171] has joined #bitcoin-core-dev --- Log closed Fri Oct 23 00:00:55 2020