--- Log opened Sat Nov 21 00:00:23 2020
00:05 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has quit [Quit: Pavlenex]
00:14 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev
00:14 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev
00:20 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has quit [Quit: Pavlenex]
00:29 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
00:29 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
00:32 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:41 < fanquake> achow101: if you wanted  to run a test build, I have a branch here that seems to achieve the same thing as 20436, but maybe slightly less "nasty": https://github.com/fanquake/bitcoin/commits/no_echo_fix_clang_qt_determinism_backported
00:50 < wumpus> O3 is the default?
00:52 < wumpus> the highest optimization level also has the highest risk of exposing compiler issues, wouldn't mind turning down the whole thing to O2
00:56 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 272 seconds]
00:57 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5] has joined #bitcoin-core-dev
00:58 -!- jonatack [~jon@213.152.161.69] has joined #bitcoin-core-dev
00:58 -!- Kiminuo [~mix@141.98.103.124] has joined #bitcoin-core-dev
01:13 -!- Kiminuo [~mix@141.98.103.124] has quit [Ping timeout: 260 seconds]
01:13 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
01:16 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev
01:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:17 -!- rm95 [bcd265d8@188.210.101.216] has joined #bitcoin-core-dev
01:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:18 < fanquake> wumpus: I haven’t looked at the qt code, but yes apparently so.
01:22 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has quit [Quit: Pavlenex]
01:41 < wumpus> fanquake: but making it macos scoped is a good idea at least I guess
01:44 < wumpus> it looks like mypy is not running on the python scripts in contrib/devtools in the CI
01:44 < wumpus> my glaring mistake in read_symbols in #20434 just passed (I've tried with mypy locally and did complain there)
01:45 < gribble> https://github.com/bitcoin/bitcoin/issues/20434 | contrib: Parse ELF directly for symbol and security checks by laanwj · Pull Request #20434 · bitcoin/bitcoin · GitHub
01:46 < wumpus> not a very important concern but I guess if we have these type specifications and don't check them they'll be out of whack complately in no time
01:50 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]
01:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
01:51 < fanquake> wumpus: yea I added most of the annotations, but we never hooked up a linter. Probably worth it now that you're writing pixie from scratch
01:53 < wumpus> I've tried to change the linter to mypy all .py files it gives a weird error about a duplicate module 'test_runner' (which should be allowed they're in different directories), so I see why it's only enabled for specific paths
01:54 < wumpus> aha it needs to be run per package you can't just run it over the whole tree https://github.com/python/mypy/issues/4008
01:55 < wumpus> fair enough I'll just add contrib/devtools though there are some more things that need to be fixed before it passes (not caused by my PR)
01:56 < wumpus> and I don't even have type annotations in pixie itself yet
01:57 -!- rm95 [bcd265d8@188.210.101.216] has quit [Remote host closed the connection]
01:57 < fanquake> I'm happy to fix up anything else in there
02:00 < wumpus> two in circular-dependencies and one in security-check.py to do with macos: https://0bin.net/paste/TbGa7dzE#1zLWR4E0d6EA04YtkIEq5Ss3ZuGUljw7Hru9PxEkvMZ
02:00 < gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
02:03 < fanquake> cool
02:09 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
02:14 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 246 seconds]
02:38 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
02:38 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
02:38 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
02:38 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
02:51 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
02:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
03:02 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
03:09 < wumpus> gah adding type hints to pixie turns out to kind of annoying as all the structures are dynamically generated, so you get all kinds of errors like error: "Symbol" has no attribute "st_name"
03:10 < wumpus> and adding manual hints for all of those would make the code three times longer or so, which feels like fighting python instead of using it
03:20 -!- Alford35Ebert [~Alford35E@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:21 < fanquake> Oh nooo
03:32 < wumpus> I'm thinking of something quite evil: are the __annotations__ ordered? if so, I could do it the other way around and generate the Structs() from them by defining the various Elf integer types, this would even make the code more similar to elf.h
03:34 < wumpus> nah don't know if I'm actually gonig to do it, I think the code is fine as-is, could just add a workaround to ElfRecord for mypy to ignore it
03:36 < wumpus> _base = None  # type: Any
03:36 < wumpus> class ELFRecord(_base):
03:36 < wumpus> tada
03:42 < fanquake> hehe
03:42 < fanquake> Any is the get out of jail free card
03:46 < wumpus> fwiw it *does seem* __annotations__ is guaranteed to be ordered as in the definitions so you can use type annotations for defining ordered records https://stackoverflow.com/questions/64444638/is-the-order-of-entries-in-class-annotations-consistent-with-their-definitio
04:03 < wumpus> inheriting from types.SimpleNamespace works too
04:04 < wumpus> much less ugly
04:05 < wumpus> and you get a sensible __repr__ for free, yippie
04:33 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
04:33 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
04:44 -!- noganoo [sid146237@gateway/web/irccloud.com/x-gaeqrijscqapsoic] has quit [Read error: Connection reset by peer]
04:44 -!- noganoo [sid146237@gateway/web/irccloud.com/x-jiqyxyrhvhhqazvk] has joined #bitcoin-core-dev
05:01 -!- OldMiner [~OldMiner@178.162.212.214] has quit [Remote host closed the connection]
05:07 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
05:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
05:13 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:16 -!- eugene-f_ [~eugene_ff@2604:2000:1383:472b:2133:f154:b78a:8f9d] has quit [Remote host closed the connection]
05:20 < wumpus> pushed the mypy annotations; modern python is pretty neat, I may still do the annotation-based structure generation but we already went a long way from parsing the humongous elfread output to this, I think what would be nice is tests that it works for the range of architectures we support, although the guix/gitian run will help at least a bit there
05:22 < fanquake> wumpus: sounds good. Looking forward to having a review
05:22 < fanquake> This new code should be must nicer going forward
05:22 -!- robbiet480 [~robbiet48@178.162.212.214] has joined #bitcoin-core-dev
05:22 -!- belcher_ is now known as belcher
05:24 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has joined #bitcoin-core-dev
05:28 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:2133:f154:b78a:8f9d] has joined #bitcoin-core-dev
05:30 < wumpus> fanquake: thanks!
05:32 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:34 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
05:35 -!- Kiminuo [~mix@141.98.103.124] has joined #bitcoin-core-dev
05:35 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:38 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
05:47 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:47 < wumpus> oh apparently there is typing.Annotated / PEP 593 to do exactly what I wanted to do (e.g. for annotate fields as struct types, it even has a hypothetical 'struct2' as exmple), buuut it's python 3.9+ 🤦 
05:49 < wumpus> I'll leave it for a future TODO
05:49 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:49 -!- vadorovsky__ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
05:50 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
05:52 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
05:52 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
05:53 -!- robbiet480 [~robbiet48@178.162.212.214] has quit [Remote host closed the connection]
05:54 < wumpus> let's see if I can create a lxc environment with alll the cross compilers and create some testing for the symbols/versions detection
05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:56 < bitcoin-git> [bitcoin] fanquake opened pull request #20440: build: fix determinism issue when building qt with Clang 8 (master...no_echo_fix_clang_qt_determinism) https://github.com/bitcoin/bitcoin/pull/20440
05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:57 < fanquake> That's enough Qt for one Saturday. Good chance we wont even use that patch heh
05:59 < wumpus> nice! yeah I still think the most effortless and straightforward "fix" seems be to bite the bullet and use llvm 9, but, dunno what the risks of being out of whack with apple's compiler entail really
06:00 < fanquake> Yea, that's probably what we'll end  up doing for 22.0. Don't think we want to be swapping compilers last minute pre-release though.
06:00 < wumpus> well it's rc1 :)
06:01 < fanquake> the first of many perhaps
06:01 < wumpus> that's what I mean, we don't actually have a release yet, rc1 can be considered non-existent so rc2 is rc1
06:01 < wumpus> effectively
06:27 -!- EricYuzo [~EricYuzo@84.39.117.57] has joined #bitcoin-core-dev
06:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
06:36 -!- Alford35Ebert [~Alford35E@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
06:41 -!- miketwenty1 [~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com] has joined #bitcoin-core-dev
07:14 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:29 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:30 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
08:10 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
08:20 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
08:21 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:22 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
08:25 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:34 < achow101> fanquake: I have a third solution. I have a patch to qt_intersect_spans that doesn't trigger the bug in llvm. I did 40 or so gitian builds overnight and they all get the same result. https://github.com/achow101/bitcoin/tree/0.21-qpainter-fix
08:39 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
08:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:47 < bitcoin-git> [bitcoin] achow101 opened pull request #20447: depends: Patch qt_intersect_spans to avoid non-deterministic behavior in LLVM 8 (master...0.21-qpainter-fix) https://github.com/bitcoin/bitcoin/pull/20447
08:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:48 < luke-jr> can't we patch or wrap LLVM instead? what's to stop us from accidentally hitting this in our own code in 22.0?
08:48 < luke-jr> or do we expect LLVM to backport a fix by then?
08:49 < achow101> luke-jr: I think the plan is to bump to LLVM 9 which fixes this problem
08:49 < luke-jr> i c
08:50 < luke-jr> I guess that makes sense - probbly need it for macOS ARM too
08:52 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
08:52 -!- miketwenty1 [~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com] has quit [Ping timeout: 246 seconds]
08:58 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
09:06 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
09:15 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev
09:17 < jonatack> wait, are we all supposed to submit a qt proposal? i missed the memo :D
09:20 < jonatack> (great work though)
09:47 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
09:55 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
09:56 < wumpus> gah ubuntu bionic gcc-8 with -Wl,-z,separate-code seems to make a printf hello world program about 4MB (from 8kB without), did we notice any size ballooning for bitcoin? (no such problem for gcc 9.3 on focal)
10:00 < wumpus> looks like it aligns the separated sections to increments of 2MB (and actually stores the zeroes) instead of the page size, only for x86_64 though not other architectures
10:06 < wumpus> bitcoind x86_64-linux-gnu went from 9.9M to 15M from 0.20.1 to 0.21.0rc1 ... I doubt this is actual code growth, will check another arch just to be sure
10:06 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has quit [Quit: Pavlenex]
10:07 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
10:07 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:10 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
10:11 < wumpus> for comparison: aarch64 went from 9.1M to 11M in the same span
10:11 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds]
10:11 < wumpus> doesn't seem really worrying anyway but I just noticed
10:13 < wumpus> it's more visible, relatively, for bitcoin-cli which went from 2.8M to 4.6M for x86_64 and 1.8M to 1.9M for aarch64
10:13 < wumpus> at least it's zeroes so it compresses very well in the tar.gz :-)
10:17 < jonatack> bitcoin-cli did see additions of -netinfo and -generate, but wow o_O
10:24 < wumpus> I don't think it matters for memory usage in practice, paging operating systems are never going to read the empty, unreferenced pages; the virtual memory usage doesn't matter on 64 bit; it's just more disk space
10:24  * jonatack thinks back to when software was delivered with constraints of 4/16/48 KB of RAM
10:25 < wumpus> heh the times entire games fit into that
10:25 < jonatack> exactly
10:25 < wumpus> and to realize that on average, compilers became *better* at optimizing since then
10:26 < luke-jr> abstractions tend to break those optimisations tho
10:27 < wumpus> right
10:44 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev
10:50 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has quit [Quit: Pavlenex]
10:50 < luke-jr> I'm confused about unloadwallet's intended behaviour. It looks broken.
10:50 < luke-jr> it appears that if the RPC request specifies a wallet, AND a wallet is named in the param, it errors even if those two match?
10:51 -!- Kiminuo [~mix@141.98.103.124] has quit [Ping timeout: 256 seconds]
10:51 < luke-jr> I can see erroring if they differ, but even then the error message doesn't make sense for that scenario
10:51 < luke-jr> and the docs don't help
10:57 < jonatack> Hm, with unloadwallet I see the log printing "Releasing wallet"... but then no confirmation when the operation is completed, nor if it was successful.
10:59 -!- pescador [~pescador@unaffiliated/pescador] has joined #bitcoin-core-dev
10:59 < jonatack> and the rpc result object only says "warning": "". i guess this can be improved to be more reassuring for users with funds.
11:01 < luke-jr> hrm, probabyl warning should be null or absent
11:02 < jonatack> i'd not show a warning field unless there was a warning to display, and otherwise print "result": "Wallet xyz was successfully unloaded."
11:03 < jonatack> like with the upgradewallet fixes PR tagged for 0.21 
11:04 < jonatack> it's easy to add, if you're fixing things...happy to review if you do
11:04 < jonatack> (i agree with you)
11:05 -!- Talkless [~Talkless@m83-179-8-120.cust.tele2.lt] has joined #bitcoin-core-dev
11:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
11:11 < jonatack> even better, a "wallet_name": string field and a "result": "Wallet successfully unloaded.", see #20403
11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/20403 | wallet: upgradewallet fixes, improvements, test coverage by jonatack · Pull Request #20403 · bitcoin/bitcoin · GitHub
11:15 -!- larryruane [uid473749@gateway/web/irccloud.com/x-ebpadwqlxrootpws] has quit [Quit: Connection closed for inactivity]
11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:15 < bitcoin-git> [bitcoin] luke-jr opened pull request #20448: RPC/Wallet: unloadwallet: Allow specifying wallet_name param matching RPC request, and document behaviour (master...unloadwallet_namematch) https://github.com/bitcoin/bitcoin/pull/20448
11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:19 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
11:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:28 < bitcoin-git> [bitcoin] achow101 opened pull request #20449: build: Fix Windows installer build (master...fix-gitian-installers) https://github.com/bitcoin/bitcoin/pull/20449
11:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:37 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:43 -!- vadorovsky__ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
11:56 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has joined #bitcoin-core-dev
12:02 -!- pescador [~pescador@unaffiliated/pescador] has quit [Remote host closed the connection]
12:06 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
12:11 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
12:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
12:29 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds]
12:36 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
12:38 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
12:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
12:50 -!- queip [~queip@unaffiliated/rezurus] has quit [Excess Flood]
12:51 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
12:55 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Quit: brb]
12:56 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
13:37 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:37 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
14:06 -!- eugene-f_ [~eugene_ff@2604:2000:1383:472b:3cf1:242e:7a1a:9714] has joined #bitcoin-core-dev
14:10 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:2133:f154:b78a:8f9d] has quit [Ping timeout: 264 seconds]
14:11 -!- Talkless [~Talkless@m83-179-8-120.cust.tele2.lt] has quit [Quit: Konversation terminated!]
14:23 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]
14:35 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:45 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Read error: Connection reset by peer]
14:46 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
15:14 -!- brianddk [47875d9c@71-135-93-156.lightspeed.hstntx.sbcglobal.net] has joined #bitcoin-core-dev
15:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
15:54 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has joined #bitcoin-core-dev
15:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
16:05 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]
16:05 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]
16:19 < fanquake> wumpus: I did mention binary size increase in https://github.com/bitcoin/bitcoin/pull/19525#issue-449279147. Maybe time to merge #18605 heh
16:19 < gribble> https://github.com/bitcoin/bitcoin/issues/18605 | build: Link time garbage collection by fanquake · Pull Request #18605 · bitcoin/bitcoin · GitHub
16:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:22 < sipa> fanquake: good idea
16:28 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
16:29 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
16:37 < achow101> I would expect a non-negligible part of binary size increase from 0.20 to 0.21 would be the inclusion of sqlite
16:37 < sipa> oh!
16:39 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection]
16:39 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
16:40 < fanquake> wumpus / sipa: can probably block MONIMAKER365
16:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5] has joined #bitcoin-core-dev
16:41 < sipa> fanquake: done
16:57 < brianddk> Anyone happen to have a copy of bitcoin-0.1.2.rar for some history research I'm working on.  Last sightings of it were in 2009 and 2010 on sourceforge.  2009: http://web.archive.org/web/20091127010808/http://sourceforge.net/projects/bitcoin/files, 2010:
16:57 < brianddk> http://web.archive.org/web/20101210071124/http://sourceforge.net:80/projects/bitcoin/files/Bitcoin/
16:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
17:03 < brianddk> I already have v0.1.0 and v0.1.3 : http://web.archive.org/web/20101210071124/http://sourceforge.net:80/projects/bitcoin/files/Bitcoin/ just missing v0.1.2.  I realize it was recalled, and that these clients before 0.8.1 are non-functional, It's just a free time hobby..
17:04 -!- EricYuzo [~EricYuzo@84.39.117.57] has quit [Remote host closed the connection]
17:04 < sipa> brianddk: due to the march 2013 bdb locks issue?
17:04 < sipa> you can work around that
17:05 < sipa> stuff before 0.2.10 is harder, as the network protocol changed
17:05 < sipa> you'll need a bridge node for those
17:05 -!- eugene-f_ [~eugene_ff@2604:2000:1383:472b:3cf1:242e:7a1a:9714] has quit [Remote host closed the connection]
17:06 < brianddk> I suppose, I'm just trying to learn the codebase from a historical perspective.  Maybe not the best, but it seems interesting.
17:06 < brianddk> at least to me.
17:06 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:3cf1:242e:7a1a:9714] has joined #bitcoin-core-dev
17:09 < brianddk> sipa, yeah, it was my impression the the 03-2013 issue required all clients to upgrade to 0.8.1, but I may be reading that wrong: http://web.archive.org/web/20130515133440/http://sourceforge.net/projects/bitcoin/files/Bitcoin/bitcoin-0.8.1
17:10 < sipa> you can manually configure higher limits
17:10 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:3cf1:242e:7a1a:9714] has quit [Ping timeout: 260 seconds]
17:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
17:16 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 256 seconds]
17:20 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:7807:7941:a0b9:69c0] has joined #bitcoin-core-dev
17:25 -!- dscho [~dscho@84.39.117.57] has joined #bitcoin-core-dev
17:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
17:34 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:38 -!- vasild_ is now known as vasild
17:39 -!- tralfaz [~davterra@94.198.42.213] has joined #bitcoin-core-dev
17:41 -!- davterra [~davterra@static-198-54-129-60.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
17:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:12 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
18:26 < fanquake> achow101: should have done 42 just to be completely sure
18:30 < achow101> fanquake: it was 44 or something like that. It was supposed to be 50 but I woke up before they were all done
18:49 < fanquake> CHECKS: Dict[str, List[Tuple[str, Callable[[Any], bool]]]] = {...
18:49 < fanquake> probably getting a bit heavy with the type annotations
18:51 < achow101> you might want to look into type aliases
18:52 < fanquake> I think I'll just leave these out for now. This is more a case of the type annotation being more confusing than just looking at the code
18:52 < fanquake> Will take a look at aliases though
18:52 < sipa> looks super readable compared to C++ types ;)
18:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5] has joined #bitcoin-core-dev
18:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
19:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:28 < gwillen> you can also change more things to Any if you want to make it more concise (at the expense of precision), but I also find it fairly readable :-)
19:30 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:36 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]
19:39 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
19:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:43 < bitcoin-git> [bitcoin] fanquake opened pull request #20451: lint: run mypy over contrib/devtools (master...contrib_devtools_mypy) https://github.com/bitcoin/bitcoin/pull/20451
19:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:06 < luke-jr> sipa: higher limits won't enforce the softforked lower lock limit, though
20:06 < luke-jr> so for 3 months (March-May), upgrading to 0.8.1 *was* necessary for full node security
20:06 < luke-jr> well, or a backport I guess
20:06 < luke-jr> (not sure if we had a backport)
20:07 < sipa> luke-jr: that's true
20:08 < sipa> though if you just wanted it to just sync with the full chain, only validating the rules that existed at the time, it's possible
20:21 -!- brianddk [47875d9c@71-135-93-156.lightspeed.hstntx.sbcglobal.net] has quit [Remote host closed the connection]
20:22 < fanquake> wumpus: re binary size. You are correct that they have grown, some quite significantly: https://github.com/bitcoin/bitcoin/pull/18605#issuecomment-731696286. I re-run some builds for 18605.
20:33 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]
20:42 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
20:43 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
20:45 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5] has joined #bitcoin-core-dev
20:51 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
20:55 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 260 seconds]
21:12 -!- tralfaz [~davterra@94.198.42.213] has quit [Ping timeout: 264 seconds]
21:31 -!- jonatack [~jon@213.152.161.69] has quit [Ping timeout: 240 seconds]
21:35 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
21:40 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
21:45 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
21:54 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 246 seconds]
22:00 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
22:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:31 < bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/816132e6eb23...e9a1c9fbdea9
22:31 < bitcoin-git> bitcoin/master 49473ef fanquake: build: convert "echo" usage into a patch in qt package
22:31 < bitcoin-git> bitcoin/master fdde4c7 fanquake: build: pass XCODE_VERSION through to qt macOS cross compile conf
22:31 < bitcoin-git> bitcoin/master bfd7e33 fanquake: build: remove plugin_no_soname from mac qt qmake.conf
22:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:31 < bitcoin-git> [bitcoin] fanquake merged pull request #19867: build: document and cleanup Qt hacks (master...document_remaining_sed) https://github.com/bitcoin/bitcoin/pull/19867
22:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:52 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:00 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has joined #bitcoin-core-dev
23:03 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has quit [Client Quit]
23:09 -!- davterra [~davterra@68.235.43.92] has joined #bitcoin-core-dev
23:37 -!- Pavlenex [~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev
23:42 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
23:45 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
--- Log closed Sun Nov 22 00:00:24 2020