--- Log opened Sat Nov 28 00:00:29 2020
00:20 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
00:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
00:37 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
00:49 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
00:52 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e2ff5e7b35d7...1ae5758981de
01:16 < bitcoin-git> bitcoin/master 89bdad5 Luke Dashjr: RPC/Wallet: unloadwallet: Allow specifying wallet_name param matching RPC ...
01:16 < bitcoin-git> bitcoin/master 1ae5758 MarcoFalke: Merge #20448: RPC/Wallet: unloadwallet: Allow specifying wallet_name param...
01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:17 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20448: RPC/Wallet: unloadwallet: Allow specifying wallet_name param matching RPC endpoint wallet (master...unloadwallet_namematch) https://github.com/bitcoin/bitcoin/pull/20448
01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-dev
01:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:41 < bitcoin-git> [gui] MarcoFalke merged pull request #138: unlock encrypted wallet "OK" button bugfix (master...qt-unlock-wallet-ok-enabled-bugfix) https://github.com/bitcoin-core/gui/pull/138
01:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ae5758981de...854b36cfa2ef
01:42 < bitcoin-git> bitcoin/master 8008ef7 Michael Dietz: qt: unlock wallet "OK" button bugfix
01:42 < bitcoin-git> bitcoin/master 854b36c MarcoFalke: Merge bitcoin-core/gui#138: unlock encrypted wallet "OK" button bugfix
01:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:02 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
02:04 -!- kexkey [~kexkey@static-198-54-132-121.cust.tzulo.com] has quit [Ping timeout: 260 seconds]
02:06 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
02:07 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 240 seconds]
02:11 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
02:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:23 < jonatack> miketwenty1: maybe this guide can be helpful. a number of people have been using it to do it for the first time and i use it: https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md
02:28 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Read error: Connection reset by peer]
02:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Read error: Connection reset by peer]
02:28 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev
02:29 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-dev
02:33 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Remote host closed the connection]
02:33 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev
02:38 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
02:42 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 260 seconds]
02:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
02:59 -!- gdude2002 [~gdude2002@139.28.218.148] has quit [Remote host closed the connection]
03:01 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:6533:cce:4b19:27da] has joined #bitcoin-core-dev
03:06 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:6533:cce:4b19:27da] has quit [Ping timeout: 264 seconds]
03:06 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
03:09 < hebasto> miketwenty1: and the convenient `gitian-build.py` script is still useful :D
03:10 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
03:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:18 -!- Chaya62Greenfeld [~Chaya62Gr@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:19 -!- jwheare1 [~jwheare@185.204.1.185] has joined #bitcoin-core-dev
03:27 -!- Chaya62Greenfeld [~Chaya62Gr@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
03:29 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex]
03:30 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:2835:3332:3b69:3421] has joined #bitcoin-core-dev
03:33 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:2835:3332:3b69:3421] has quit [Remote host closed the connection]
03:33 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:2835:3332:3b69:3421] has joined #bitcoin-core-dev
03:44 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:2835:3332:3b69:3421] has quit [Remote host closed the connection]
03:51 -!- eugene-ff [~eugene_ff@cpe-67-247-37-186.nyc.res.rr.com] has joined #bitcoin-core-dev
03:53 -!- eugene-f_ [~eugene_ff@2604:2000:1383:472b:1194:ec4e:d1a3:4149] has joined #bitcoin-core-dev
03:56 -!- eugene-ff [~eugene_ff@cpe-67-247-37-186.nyc.res.rr.com] has quit [Ping timeout: 264 seconds]
03:58 -!- eugene-f_ [~eugene_ff@2604:2000:1383:472b:1194:ec4e:d1a3:4149] has quit [Ping timeout: 264 seconds]
04:07 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
04:10 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
04:17 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
04:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
04:39 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
04:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:44 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 260 seconds]
04:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:05 -!- miketwenty1 [~miketwent@ec2-23-21-194-211.compute-1.amazonaws.com] has quit [Remote host closed the connection]
05:06 -!- miketwenty1 [~miketwent@ec2-52-207-61-44.compute-1.amazonaws.com] has joined #bitcoin-core-dev
05:07 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:08 < miketwenty1> jonatack: i saw you tweet from a couple days ago and followed you .. good stuff I have indeed looked at your repo.. you as well have gbuild / mv commands in your guide. iirc. behasto: Seems the only manual step for python-build.py is being able to verify signed builds? or is there a way to run it through python-build.py without using gbuild directly?
05:10 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
05:15 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has joined #bitcoin-core-dev
05:21 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:23 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
05:23 < hebasto> miketwenty1: https://github.com/bitcoin-core/docs/blob/master/gitian-building.md#initial-gitian-setup
05:25 < hebasto> I've been using `gitian-build.py` for years without manual running `gbuild`
05:26 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
05:27 < hebasto> it is not ideal for testing pulls (see dedicated prs in the repo), but it works flawlessly for the tagged releases.
05:29 < miketwenty1> hebasto: then maybe im not understanding something or something is failing silently on my side after the build is done.. in your inputs dir does it create the version file and the non version file? -> gitian-builder/inputs/bitcoin-win-unsigned.tar.gz
05:29 -!- miketwenty1 [~miketwent@ec2-52-207-61-44.compute-1.amazonaws.com] has quit [Remote host closed the connection]
05:33 < hebasto> miketwenty1: if you have an issue with the `gitian-build.py` script, don't hesitate to open an issue, and provide your system info and steps to reproduce the issue. It would help much.
05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
05:38 -!- miketwenty1 [~miketwent@ec2-23-21-194-211.compute-1.amazonaws.com] has joined #bitcoin-core-dev
05:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
05:39 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
06:08 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds]
06:09 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
06:23 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:d1b8:1c24:4de2:e43c] has joined #bitcoin-core-dev
06:30 -!- Dan37 [ac3a16a4@172.58.22.164] has joined #bitcoin-core-dev
06:37 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
06:41 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds]
06:42 -!- Dan37 [ac3a16a4@172.58.22.164] has quit [Remote host closed the connection]
06:42 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:45 -!- mmmmmmmmm2 [6b4dd861@mobile-107-77-216-97.mobile.att.net] has joined #bitcoin-core-dev
06:51 -!- mmmmmmmmm2 [6b4dd861@mobile-107-77-216-97.mobile.att.net] has quit [Remote host closed the connection]
07:18 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
07:18 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
07:19 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
07:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
07:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
07:46 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
07:50 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 240 seconds]
07:57 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
08:04 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev
08:20 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
08:39 -!- miketwenty1 [~miketwent@ec2-23-21-194-211.compute-1.amazonaws.com] has quit [Remote host closed the connection]
08:50 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
08:50 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
08:50 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
08:52 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
09:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/854b36cfa2ef...7ae86b3c6845
09:08 < bitcoin-git> bitcoin/master 3ebde21 Amiti Uttarwar: [test] Fix wait condition in disconnect_p2ps
09:08 < bitcoin-git> bitcoin/master 7ae86b3 MarcoFalke: Merge #20522: [test] Fix sync issue in disconnect_p2ps
09:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20522: [test] Fix sync issue in disconnect_p2ps  (master...2020-11-disconnect-p2ps) https://github.com/bitcoin/bitcoin/pull/20522
09:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:15 -!- cryptapus_ is now known as cryptapus
09:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds]
09:27 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
09:27 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving]
09:30 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:56 < bitcoin-git> [bitcoin] theStack opened pull request #20523: zmq: deduplicate 'sequence' publisher message creation/sending (master...20201128-zmq-refactor-dedup_sequence_msg_sending) https://github.com/bitcoin/bitcoin/pull/20523
09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
10:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
10:28 -!- dhruvm [~noreply@c-73-158-59-66.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:30 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
10:30 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
10:31 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has joined #bitcoin-core-dev
10:35 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has quit [Ping timeout: 246 seconds]
10:51 -!- tido [6c1abe76@pool-108-26-190-118.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
10:59 -!- jwheare1 [~jwheare@185.204.1.185] has quit [Remote host closed the connection]
10:59 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has joined #bitcoin-core-dev
11:03 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has quit [Ping timeout: 240 seconds]
11:25 -!- marcoagner [~user@2001:8a0:b968:4500:24b0:8c6a:7172:9a81] has quit [Read error: Connection reset by peer]
11:25 -!- marcoagner [~user@2001:8a0:b968:4500:24b0:8c6a:7172:9a81] has joined #bitcoin-core-dev
11:26 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
11:26 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev
11:28 -!- tido [6c1abe76@pool-108-26-190-118.bstnma.fios.verizon.net] has quit [Remote host closed the connection]
11:40 -!- marcoagner [~user@2001:8a0:b968:4500:24b0:8c6a:7172:9a81] has quit [Read error: Connection reset by peer]
11:40 -!- marcoagner [~user@2001:8a0:b968:4500:24b0:8c6a:7172:9a81] has joined #bitcoin-core-dev
11:43 -!- McStone [~CES@pub151248194093.dh-hfc.datazug.ch] has joined #bitcoin-core-dev
11:51 -!- Mlpearc [~Mlpearc@178.162.212.214] has joined #bitcoin-core-dev
12:15 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
12:17 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
12:33 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds]
12:33 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:35 < bitcoin-git> [bitcoin] jnewbery opened pull request #20524: [test] Move MIN_VERSION_SUPPORTED to p2p.py (master...2020-11-subversion-string) https://github.com/bitcoin/bitcoin/pull/20524
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:43 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
12:56 < andytoshi> kallewoof: i'm looking again at implementing bip-322 and i see a bunch of pain points. do you think we could get on a phone call or something and go over things? 
12:56 < andytoshi> i think i'd like to meaningfully change the BIP but maybe you're tired of doing that
12:58 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
13:23 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
13:33 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has joined #bitcoin-core-dev
13:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
13:37 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has quit [Ping timeout: 260 seconds]
13:54 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection]
13:54 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
13:55 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
13:56 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
14:00 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:01 < jonatack> i'm scratching my head on why many CAmount "in" parameters to functions are being passed as reference to const rather than by value... CAmount is int64_t, a cheaply-copied type
14:02 < jonatack> e.g. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines.html#Rf-in
14:02 < jonatack> maybe 64-bits isn't considered cheap
14:03 < sipa> 64 bits is definitely cheap
14:04 < sipa> generally things up to two pointers worth in size is consodered cheaply copyable
14:04 < jonatack> sipa: yes. thank you
14:05 < jonatack> " two or three words (doubles, pointers, references) are usually best passed by value. When copying is cheap, nothing beats the simplicity and safety of copying, and for small objects (up to two or three words) it is also faster than passing by reference because it does not require an extra indirection to access from the function."
14:08 < achow101> it might be that people just forget that CAmount is really an int64
14:09 -!- belcher_ is now known as belcher
14:10 < sipa> yeah
14:10 < jonatack> maybe they thought oh, it's not a built-in type, so...
14:17 < sipa> well one of the motivations for adding it in the first place was a freicoin contributor who needed the ability to replace it with a not-so-simple type
14:18 < hebasto> someday CAmount could be a not typedef to int64
14:18 < sipa> (most of that didn't make it in, only the typedef did)
14:20 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
14:20 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
14:23 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
14:24 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
14:34 < jonatack> ah interesting
14:38 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Quit: skyikot]
14:55 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
14:59 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds]
15:10 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
15:13 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
15:20 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
15:20 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
15:21 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has joined #bitcoin-core-dev
15:26 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has quit [Ping timeout: 264 seconds]
15:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
16:05 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
16:05 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
16:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
17:03 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has joined #bitcoin-core-dev
17:32 -!- promag___ [~promag@188.250.84.129] has quit [Ping timeout: 264 seconds]
17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:37 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
17:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:38 -!- vasild_ is now known as vasild
17:40 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
17:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]
17:52 -!- mickey86 [68c2dcef@104.194.220.239] has joined #bitcoin-core-dev
18:02 -!- Mlpearc [~Mlpearc@178.162.212.214] has quit [Remote host closed the connection]
18:04 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has quit [Ping timeout: 256 seconds]
18:04 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:06 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
18:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
18:18 -!- mickey86 [68c2dcef@104.194.220.239] has quit [Remote host closed the connection]
18:20 -!- Zao_ [~Zao_@185.204.1.185] has joined #bitcoin-core-dev
18:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
18:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
19:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 265 seconds]
19:04 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev
19:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
19:31 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
19:32 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
19:47 -!- jesseposner [~jp@2601:643:8980:bfd2:29df:a2cb:6f55:8d6d] has quit [Ping timeout: 260 seconds]
19:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
19:50 -!- mol_ [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer]
19:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
19:55 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
19:57 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
20:06 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
20:13 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds]
20:16 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:d1b8:1c24:4de2:e43c] has quit [Ping timeout: 264 seconds]
20:29 < andytoshi> i also tend to think of passing const references as a way to be assured that the variable won't change throughout the body of the function. somehow i tend to forget that you can make normal objects be const too
20:30 < andytoshi> i think in general it's non-idiomatic for some reason to make local variables const, and this sometimes leads to people overusing references just so they can get constness
20:31 < sipa> a const reference actually doesn't guarantee it can't change throughout the body of the function; it only means it can't be modified through that reference/variable/pointer
20:32 < andytoshi> i also forget this, which is a much more dangerous thing to forget
20:32 < sipa> it also makes const way less useful then it could be
20:32 < sipa> both for programmers and for the compiler
20:32 < sipa> as the compiler can't assume a const reference can't change
20:32 < sipa> but it can assume that a const variable itself won't change - that's actually UB
20:33 < andytoshi> heh, that's a good observation .. makes it all the more strange that people tend not to const local variables
20:34 < sipa> if you have a local variable and no reference to it is passed to another function, it doesn't matter for performance reasons really, the compiler can figure out on its own that nothing changes it
20:36 < sipa> "it only means it can't be modified through that reference/variable/pointer" <- actually even that is wrong
20:36 < sipa> iirc the rule is that as long as any non-const reference anywhere to an object exists, it can be modified (including by casting the constness away from a const reference to it)
20:37 < sipa> which in practice means that only actually const objects can be assumed to not change
20:43 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
20:43 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
20:45 -!- miketwenty1 [~miketwent@ec2-52-207-61-44.compute-1.amazonaws.com] has joined #bitcoin-core-dev
21:05 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
21:06 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
21:13 -!- reallll [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
21:14 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
21:17 -!- Zao_ [~Zao_@185.204.1.185] has quit [Remote host closed the connection]
21:30 -!- Mlpearc [~Mlpearc@84.39.117.57] has joined #bitcoin-core-dev
21:42 -!- miketwenty1 [~miketwent@ec2-52-207-61-44.compute-1.amazonaws.com] has quit [Remote host closed the connection]
21:43 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has joined #bitcoin-core-dev
21:47 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has quit [Ping timeout: 260 seconds]
21:55 -!- miketwenty1 [~miketwent@ec2-35-172-206-57.compute-1.amazonaws.com] has joined #bitcoin-core-dev
22:12 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
22:15 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
22:24 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
22:28 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Quit: I'm out.]
22:29 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev
22:36 -!- miketwenty1 [~miketwent@ec2-35-172-206-57.compute-1.amazonaws.com] has quit [Remote host closed the connection]
22:37 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has joined #bitcoin-core-dev
22:41 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has quit [Ping timeout: 260 seconds]
22:52 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
23:03 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
23:17 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
23:35 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
23:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
23:57 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has joined #bitcoin-core-dev
--- Log closed Sun Nov 29 00:00:30 2020