--- Log opened Mon Dec 07 00:00:38 2020
00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d0ca394596cf...1a04f45fe967
00:10 < bitcoin-git> bitcoin/master 1816327 Hennadii Stepanov: p2p: Put disconnecting logs into BCLog::NET category
00:10 < bitcoin-git> bitcoin/master 1a04f45 MarcoFalke: Merge #19832: p2p: Put disconnecting logs into BCLog::NET category
00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19832: p2p: Put disconnecting logs into BCLog::NET category (master...200829-log) https://github.com/bitcoin/bitcoin/pull/19832
00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:15 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 256 seconds]
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:17 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1a04f45fe967...eab63b971d5f
00:17 < bitcoin-git> bitcoin/master 73dc19a João Barbosa: rpc, refactor: Avoid duplicate set lookup in gettxoutproof
00:17 < bitcoin-git> bitcoin/master 52fc399 João Barbosa: rpc: Reject empty txids in gettxoutproof
00:17 < bitcoin-git> bitcoin/master eab63b9 Jonas Schnelli: Merge #19847: rpc, refactor: Avoid duplicate set lookup in gettxoutproof
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:18 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #19847: rpc, refactor: Avoid duplicate set lookup in gettxoutproof (master...2020-08-gettxoutproof) https://github.com/bitcoin/bitcoin/pull/19847
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:20 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev
00:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
00:28 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
00:36 -!- ironmarx [~ironmarx@178.239.168.171] has quit [Remote host closed the connection]
01:04 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:09 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eab63b971d5f...31438cc8184f
01:09 < bitcoin-git> bitcoin/master c23f6f8 Jonas Schnelli: Add depends qt fix for ARM macs
01:09 < bitcoin-git> bitcoin/master 31438cc Wladimir J. van der Laan: Merge #20482: Add depends qt fix for ARM macs
01:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:10 < bitcoin-git> [bitcoin] laanwj merged pull request #20482: Add depends qt fix for ARM macs (master...2020/11/qt_mac_arm) https://github.com/bitcoin/bitcoin/pull/20482
01:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:44 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev
01:51 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.9]
01:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:52 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31438cc8184f...f3e17686b37a
01:52 < bitcoin-git> bitcoin/master 6690adb Tyler Chambers: Warn when binaries are built from a dirty branch.
01:52 < bitcoin-git> bitcoin/master f3e1768 Wladimir J. van der Laan: Merge #20468: build: warn when generating man pages for binaries built fro...
01:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:52 < bitcoin-git> [bitcoin] laanwj merged pull request #20468: build: warn when generating man pages for binaries built from a dirty branch (master...fix-20412) https://github.com/bitcoin/bitcoin/pull/20468
01:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:58 -!- schulzemic [ada@gateway/vpn/mullvad/schulzemic] has joined #bitcoin-core-dev
02:04 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has quit [Ping timeout: 260 seconds]
02:07 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:07 < bitcoin-git> [bitcoin] laanwj closed pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:07 < bitcoin-git> [bitcoin] laanwj reopened pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:17 < elichai2> hebasto: are you going to port `std::to_array`?
02:18 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
02:19 -!- greypw [~greypw@unaffiliated/greypw] has quit [Quit: I'll be back!]
02:20 -!- greypw [~greypw@unaffiliated/greypw] has joined #bitcoin-core-dev
02:21 -!- greypw [~greypw@unaffiliated/greypw] has quit [Client Quit]
02:23 -!- greypw [~greypw@unaffiliated/greypw] has joined #bitcoin-core-dev
02:23 < theStack> pp
02:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:24 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20588: Remove unused and confusing CTransaction constructor (master...2012-txConstructor) https://github.com/bitcoin/bitcoin/pull/20588
02:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #bitcoin-core-dev
02:44 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
02:46 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
02:51 < wumpus> nice
02:57 < hebasto> elichai2: no
03:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:18 -!- Dorothea44Rice [~Dorothea4@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:23 -!- Dorothea44Rice [~Dorothea4@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds]
03:25 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has quit [Read error: Connection reset by peer]
03:27 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #bitcoin-core-dev
03:46 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has quit [Quit: K-Lined]
03:47 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev
03:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #bitcoin-core-dev
03:51 -!- schulzemic [ada@gateway/vpn/mullvad/schulzemic] has quit [Quit: Konversation terminated!]
03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:51 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f3e17686b37a...00f4dcd5520e
03:51 < bitcoin-git> bitcoin/master fa0f415 MarcoFalke: net: Assume that SetCommonVersion is called at most once per peer
03:51 < bitcoin-git> bitcoin/master 00f4dcd MarcoFalke: Merge #20138: net: Assume that SetCommonVersion is called at most once per...
03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20138: net: Assume that SetCommonVersion is called at most once per peer (master...2010-netVersionOnlyOnce) https://github.com/bitcoin/bitcoin/pull/20138
03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:59 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex]
04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/00f4dcd5520e...03b1db611495
04:02 < bitcoin-git> bitcoin/master 03bfeee Antoine Poinsot: interface: remove unused estimateSmartFee method from node
04:02 < bitcoin-git> bitcoin/master 86ff2cf Antoine Poinsot: Remove the remaining fee estimation globals
04:02 < bitcoin-git> bitcoin/master e8ea6ad Antoine Poinsot: init: don't create a CBlockPolicyEstimator if we don't relay transactions
04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18766: Disable fee estimation in blocksonly mode (by removing the fee estimates global) (master...disable_feeest_blocksonly) https://github.com/bitcoin/bitcoin/pull/18766
04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:29 < hebasto> jonasschnelli: https://bitcoinbuilds.org/ reports about two builds for the same master head. Is it intended?
04:40 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
04:41 -!- kljasdfvv [~flack@p200300d46f24de007f9b1b51e45d0773.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
04:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:50 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex]
04:51 < jonasschnelli> hebasto: yes. For now.
04:51 < jonasschnelli> one is the GUI repo one the main
04:51 < jonasschnelli> It's currently like this because the GUI repo has bitcoinbuilds integerated
04:51 < jonasschnelli> But I will fix this soon
04:56 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:04 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-yslbdkfqtjhgwjcu] has quit [Ping timeout: 264 seconds]
05:05 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ulqcremawialdixq] has joined #bitcoin-core-dev
05:05 -!- kwm [~kwm@185.204.1.185] has joined #bitcoin-core-dev
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:10 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03b1db611495...5c4911e7e752
05:10 < bitcoin-git> bitcoin/master fa8abdc MarcoFalke: rpc: Use FeeModes doc helper in estimatesmartfee
05:10 < bitcoin-git> bitcoin/master 5c4911e Wladimir J. van der Laan: Merge #20568: doc: Use FeeModes doc helper in estimatesmartfee
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:10 < bitcoin-git> [bitcoin] laanwj merged pull request #20568: doc: Use FeeModes doc helper in estimatesmartfee (master...2012-rpcDocFee) https://github.com/bitcoin/bitcoin/pull/20568
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:10 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:14 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:26 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
05:28 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
05:34 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
05:34 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:35 -!- vasild_ is now known as vasild
05:37 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Quit: ZNC - http://znc.in]
05:37 -!- core-meetingbot [~meetingbo@2a01:4f9:2a:2510::2] has quit [Remote host closed the connection]
05:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:18 -!- davec [~davec@072-183-054-196.res.spectrum.com] has quit [Ping timeout: 264 seconds]
06:44 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #bitcoin-core-dev
06:49 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:52 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
06:55 -!- chip-XXI [~multimedi@pop.92-184-116-43.mobile.abo.orange.fr] has joined #bitcoin-core-dev
07:01 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has joined #bitcoin-core-dev
07:10 -!- miketwen_ [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
07:14 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has quit [Ping timeout: 260 seconds]
07:16 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
07:20 < vasild> sipa: wumpus: wrt sending sendaddrv2 and the difference between the code and the BIP, I opened https://github.com/bitcoin/bips/pull/1043 to change the BIP.
07:20 < vasild> maybe changing the code to conform to the BIP also makes sense (except maybe it is too late in rc cycle)
07:22 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Quit: May the Shwartz be with you]
07:26 -!- greypw [~greypw@unaffiliated/greypw] has quit [Quit: I'll be back!]
07:28 -!- greypw [~greypw@unaffiliated/greypw] has joined #bitcoin-core-dev
07:31 < wumpus> vasild: thanks, yes, that probably makes most sense
07:35 < vasild> Lets pick a random number N between 10 and 50 and send sendaddrv2 after receiving N messages from the peer.
07:37 < wumpus> maybe send it out of band by entangling a qubit
07:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:38 < vasild> :-D
07:39 < wumpus> in a way I like signaling the different extensions in the same way, instead of setting on a different one for each one which seems like a jumble
07:40 < wumpus> that said this yea shouldn't have come up so late
07:42 < vasild> wumpus: what about doing that in 0.21.1?
07:42 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:42 < wumpus> right now, addrv2 is is no releases, so we can still change everything, once it's in 0.21.0 release, compatibility is an issu
07:43 < vasild> 0.21.0 <-> 0.21.1 would work just fine
07:43 < vasild> I mean - it really does not matter when sendaddrv2 is being sent and anything would work
07:44 < wumpus> that's good
07:45 < vasild> right now bitcoin core is the only implementation that exists, I guess. I would be a problem if another implementation arrives that expects sendaddrv2 at a certain time and is upset otherwise
07:46 < vasild> (unnecessary strict)
07:47 < vasild> What about changing the BIP to "sendaddrv2 can be sent at any time"?
07:48 < wumpus> I prefer being specific in the BIP
07:48 < wumpus> and possible more lenient in the implementation
07:48 < vasild> ok
07:49 < wumpus> I also think that establishing this during some negotiation phase is a good idea, instead of it being possible to switch it any time during a connection
07:51 < vasild> it just does not make sense to flip it after exchanging 47 messages
07:52 -!- ostgote [52a4b46b@107.180.164.82.customer.cdi.no] has joined #bitcoin-core-dev
07:59 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving]
07:59 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
08:00 -!- roconnor [~roconnor@host-45-58-200-239.dyn.295.ca] has joined #bitcoin-core-dev
08:06 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
08:08 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has joined #bitcoin-core-dev
08:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
08:13 -!- belcher_ is now known as belcher
08:13 < wumpus> it doesn't, but if it's specified in the BIP that it's not allowed then implementations don't have to take it into account, which might allow for optimizations that wouldn't be possible if it's possible to switch at any time
08:14 -!- ostgote [52a4b46b@107.180.164.82.customer.cdi.no] has quit [Ping timeout: 245 seconds]
08:14 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
08:22 < wumpus> also, it makes it possible to recognize peers that don't support addrv2 for sure, e.g. for a future time where addrv1 becomes phased out
08:25 < vasild> right
08:27 < vasild> actually, if we want to recognize peers that don't support addrv2 we must mandate that sendaddrv2 is sent before sending some message X, so that we would know that if we receive X from the peer without sendaddrv2 before that, then that peer does not support it
08:31 < vasild> I guess that is an extra argument to do it before sending verack (like wtxidrelay)
08:39 < MarcoFalke> Looks like we'll need to work on other bugfixes #20579 , so I'd also argue to move sendaddrv2 to pre-verack
08:39 < gribble> https://github.com/bitcoin/bitcoin/issues/20579 | invalid transaction decoding · Issue #20579 · bitcoin/bitcoin · GitHub
08:45 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
08:47 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds]
08:53 -!- chip-XXI [~multimedi@pop.92-184-116-43.mobile.abo.orange.fr] has quit [Ping timeout: 240 seconds]
08:53 < sipa> wumpus: want me to change my PR to send sendaddrv2 before sending verack?
08:55 -!- belcher_ is now known as belcher
09:02 < wumpus> sipa: thanks, yes imo
09:08 < vasild> updated https://github.com/bitcoin/bips/pull/1043 - "send sendaddrv2 berfore sending verack"
09:12 < vasild> woho! managed to connect two nodes via i2p and they both see their i2p addresses: https://bpa.st/RK3Q
09:13 < wumpus> vasild: that's awesome! i should install i2p some time and join in the experiments
09:14 < sipa> vasild: very nice
09:17 < vasild> unlike tor we can see who is connecting to us, and while it is cheap to generate i2p addresses and banning i2p bad actors makes little sense (because they can generate new address) -- we are sure that the guy connecting to us has the private key that corresponds to that address
09:18 < vasild> ie no stealing of addresses
09:18 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-mkskgzjzxiflwrdp] has joined #bitcoin-core-dev
09:22 -!- glozow [uid453516@gateway/web/irccloud.com/x-ismhzanbxqycgvwi] has joined #bitcoin-core-dev
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:31 < bitcoin-git> [bitcoin] BitcoinTsunami opened pull request #20591: wallet, bugfix: fix ComputeTimeSmart function during rescanning process. fixes #20181 (master...fix-computetimesmart) https://github.com/bitcoin/bitcoin/pull/20591
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:35 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:37 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
09:43 < jonatack> vasild: i have i2p running (and sent a patch a while back in your PR to update -netinfo for it), lmk if you want to try to connect to each other  
09:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
09:49 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex]
09:50 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
09:54 -!- davec [~davec@072-183-054-196.res.spectrum.com] has joined #bitcoin-core-dev
10:14 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 246 seconds]
10:26 < jnewbery> vasild wumpus: someone should send an update to the mailing list to notify people that the BIP is being changed. I'm happy to do that, but I don't want to step on your toes if you'd prefer to do it yourselves. Let me know which you'd prefer.
10:26 < sdaftuar> sipa: if we're going to receive a sendaddrv2 before verack, can we delay advertising our local address until after receiving verack as well?  that would be nice to have in 0.20 to help with torv3 address propagation, though we may have so many obstacles on that front that perhaps not required
10:27 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
10:28 < sdaftuar> the issue i've observed right now is that my torv3 node often sends its initial address advertisement before receiving a sendaddrv2, which means the initial self-advertisement is lost serialization fails, and it can be days before the bloom filter rolls over so that we can try again
10:28 < sdaftuar> when serialization fails*
10:28 < sipa> sdaftuar: hmm, i see no downside really, except changing more at the last minute
10:28 < sipa> i'll open a PR; it's useful even if it doesn't go into 0.21
10:28 < sdaftuar> thanks!
10:29 < jnewbery> sdaftuar: I don't see any problem with sending our self-announcement after receiving the verack. Seems like a good change
10:30 < wumpus> jnewbery: I'm ok with you doing that thanks
10:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:31 < bitcoin-git> [bitcoin] jonatack opened pull request #20592: p2p:  update wtxidrelay documentation per BIP339 (master...update-wtxid-documentation-per-BIP339) https://github.com/bitcoin/bitcoin/pull/20592
10:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:31 < jnewbery> I think sending the getaddr should also be sent after receiving the verack
10:32 < sdaftuar> i think it just needs to be sent after sending our own verack?
10:33 < sdaftuar> doesn't matter whether a peer sends us a sendaddrv2 or not, i mean
10:33 < jnewbery> Indeed, but keeping that functionality together as a block seems easiest
10:33 < sipa> indeed; i think we should just make sure it arrives at the receiver after our potential sendadrv2
10:33 < sdaftuar> Indeed!
10:33 < jnewbery> ha
10:44 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds]
10:49 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
11:02 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
11:03 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
11:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
11:06 < wumpus> yes
11:15 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 272 seconds]
11:17 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex]
11:20 < sipa> sdaftuar: i don't think any code changes are needed; SendMessages (which handles both local address announcement and actual sending out of the addr messages) doesn't run until fSuccessfullyConnected is true
11:21 < sipa> which means it can only run after verack is received
11:22 < sdaftuar> Oh, right!
11:23 < sdaftuar> nice 
11:23 < sdaftuar> thanks for checking that
11:24 < sipa> i started adding "if (pto->fSuccessfullyConnected) {" in a few places, and then noticed the function starts with "if (!pto->fSuccessfullyConnected) return true;"
11:25 < sdaftuar> i kept getting confused that PushAddress doesn't actually cause an addr message to go out immediately
11:25 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
11:26 < sdaftuar> so i was thinking we needed to move the code in our ::VERSION handler to wait to invoke that until after verack, but there is indeed no need to do so
11:27 < sipa> oh wait
11:27 < sipa> there is a PushAddress in the version handling too
11:27 < sdaftuar> yes that's fine though
11:27 < sipa> that needs changing
11:27 < sdaftuar> as all it does is queue up an addr to go out later
11:27 < sdaftuar> in SendMessages, as you point out
11:28 < sipa> no, because PushAddress itself will filter the addr if it's not v1 compatible
11:28 < sdaftuar> no, that happens in serialization, i'm pretty sure
11:29 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Client Quit]
11:29 < sdaftuar> oh!
11:29 < sdaftuar> i missed the if at the top of that function
11:29 < sdaftuar> you are right
11:29 < sipa> lol
11:30 < sipa> is it even useful to do local addr announcement inside version handling?
11:30 < sipa> the SendMessages code will do it automatically
11:30 < sdaftuar> i had a question for you along those lines!
11:30 < sdaftuar> it looked to me like there was special code designed to figure out which "local" address to use, that is different from AdvertiseLocal
11:30 < sdaftuar> and i wondered whether that was important
11:31 < sdaftuar> otherwise, it seems redundant with the initial AdvertiseLocal we do the firs ttime we run SendMessages for a peer
11:31 < sdaftuar> (because we initialize the first local advertisement time to 0, i think)
11:32 < sipa> there are some differences between the two
11:33 < sipa> but the initial version-based local addr relay doesn't set m_next_local_addr_send
11:33 < sdaftuar> right, so we invoke AdvertiseLocal immediately anyway
11:33 < sipa> so from reading the code, i would think that most normal connections will get the local addr twice
11:33 < sdaftuar> which might advertise a different address, but i don't know the circumstances that would happen
11:33 < sdaftuar> no, because of the bloom filter
11:33 < sipa> oh, it'll be deduplicated i guess
11:34 < sipa> it also meams that addr relay of torv3 will mostly work without code changes
11:34 < sdaftuar> the first will get squelched, and the second will work?
11:34 < sipa> yeah
11:34 < sipa> at least under the conditions that the SendMessages one triggers
11:35 < sdaftuar> that does seem to be true.  pretty gross though!
11:35 < sdaftuar> that does make the change for 0.21 to move this to pre-verack to be extra good i think
11:36 < sipa> indeed
11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:38 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c4911e7e752...d38feb6134e2
11:38 < bitcoin-git> bitcoin/master fa275e1 MarcoFalke: test: Fix intermittent feature_taproot issue
11:38 < bitcoin-git> bitcoin/master d38feb6 Wladimir J. van der Laan: Merge #20535: test: Fix intermittent feature_taproot issue
11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:38 < sipa> for a future change we may want to look at merging these two local addr announcement code paths
11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:38 < bitcoin-git> [bitcoin] laanwj merged pull request #20535: test: Fix intermittent feature_taproot issue (master...2011-testTapInt) https://github.com/bitcoin/bitcoin/pull/20535
11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:39 < sdaftuar> sipa: agreed
11:41 < sipa> hmm, GETADDR wipes the vAddrToSend list
11:42 < sipa> so if that arrives at the wrong time, our self-announcement would be dropped?
11:43 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has joined #bitcoin-core-dev
11:47 < sdaftuar> that's only an issue for inbound peers right?
11:48 < sdaftuar> and we wouldn't push our address to them anyway in the version handler
11:49 < sipa> ah, good point
11:51 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
11:55 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
12:01 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
12:05 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has quit [Changing host]
12:05 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev
12:06 < jonasschnelli> wumpus: I tried to update the crc32c subtree but it looks like our subtree has a commit unknown to upstream (https://github.com/bitcoin/bitcoin/commit/2e1819311a59fb5cb26e3ca50a510bfe01358350)
12:06 < jonasschnelli> (I'd like to update it due to apple arm support commit)
12:08 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Quit: ZNC - http://znc.in]
12:08 < sipa> jonasschnelli: looking
12:08 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has joined #bitcoin-core-dev
12:08 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has quit [Changing host]
12:08 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev
12:09 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Remote host closed the connection]
12:09 < sipa> oh that was the initial subtree
12:10 < wumpus> it's not https://github.com/bitcoin-core/crc32c ?
12:10 < sipa> oh!
12:10 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has joined #bitcoin-core-dev
12:11 < sipa> yes, it is
12:11 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has quit [Changing host]
12:11 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev
12:12 < wumpus> (there's some commit in there to prevent subtreeing a whole bunch of google test stuff and such)
12:12 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:13 < wumpus> jonasschnelli: I think you missed it, see https://github.com/bitcoin-core/crc32c
12:14 < sipa> it merges cleanly with google crc32c master, if you ignore the files we deleted in our local copy
12:14 < jonasschnelli> wumpus: ah.. I didn't know we have a fork... was looking at google/crc32c
12:14 < sipa> jonasschnelli: i can update if you want
12:14 < jonasschnelli> plz.
12:14 -!- Guyver2_ is now known as Guyver2
12:14 < jonasschnelli> Your commit/PR is also missing in master
12:15 < wumpus> which one?
12:15 < jonasschnelli> I'm mostly interested in the latest commit (https://github.com/google/crc32c)
12:15 < jonasschnelli> wumpus: https://github.com/google/crc32c/commit/2e97ab26b1321b655d29c5d1d4b9e9055ff7543f
12:15 < sipa> jonasschnelli: we use the "bitcoin-fork" branch i think
12:16 < wumpus> I doubt these changes would be merged upstream
12:16 -!- davterra [~davterra@static-198-54-131-92.cust.tzulo.com] has quit [Remote host closed the connection]
12:16 < jonasschnelli> I only saw that sipas "Fix (unused) ReadUint64LE for BE machines (#41)" is newer than our latest crc32c subtree
12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/41 | Display version in help by mhanne · Pull Request #41 · bitcoin/bitcoin · GitHub
12:17 < wumpus> yes, bitcoin-fork is the branch we use
12:18 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
12:18 < jonasschnelli> Related to that though different: I think commit https://github.com/bitcoin/bitcoin/commit/330cb33985d0ce97c20f4a0f0bbda0fbffe098d4 did had no effect
12:18 < jonasschnelli> (no-one spotted it though)
12:19 < wumpus> heh sipa committed to upstream crc32s but not to our fork
12:19 < jonasschnelli> heh
12:19 < wumpus> jonasschnelli: it had no effect? not even for uclibc?
12:19 < jonasschnelli> he betrayed us
12:19 < jonasschnelli> wumpus: I don't think so
12:20 < jonasschnelli> Because of a missing AC_DEFINE for HAVE_STRONG_GETAUXVAL
12:20 < wumpus> I'm really confused now, the change makes sense though in itself I think
12:20 < jonasschnelli> We only set it as CPPFLAG for the crc32 code
12:20 < jonasschnelli> The change makes sense,... but I would really wonder if that would work
12:20 -!- davterra [~davterra@static-198-54-131-92.cust.tzulo.com] has joined #bitcoin-core-dev
12:20 < wumpus> better to check presence of specific checks than __linux__
12:21 < sipa> https://github.com/bitcoin-core/crc32c/pull/1
12:21 < wumpus> I couldn't check, I guess that's the problem with obscure platforms
12:21 < jonasschnelli> indeed
12:21 < sipa> 12:19:05 < wumpus> heh sipa committed to upstream crc32s but not to our fork   <-  where did i commit?
12:22 < sipa> jonasschnelli: plz test if it actually works with bitcoin core before acking :)
12:22 < sipa> it's untested
12:22 < jonasschnelli> its just the fork! ;)
12:22 < wumpus> https://github.com/bitcoin-core/crc32c/pull/1/commits/2e97ab26b1321b655d29c5d1d4b9e9055ff7543f
12:22 < jonasschnelli> I'll test the PR you'll do on the main repository. :)
12:23 < sipa> oh, lol
12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:44 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #20594: Fix getauxval calls in randomenv.cpp (master...2020/12/getauxval) https://github.com/bitcoin/bitcoin/pull/20594
12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:56 < sipa> jonasschnelli: have you verified that it's actually using crc hardware accel?
12:57 < jonasschnelli> I saw that it uses the codepath defined in crc32c_arm64.cc
12:57 < sipa> iok, great
12:58 < jonasschnelli> I also wrote a similar patch before I figured out someone wrote that already upstream
13:04 < wumpus> i'm really confused by #20594
13:04 < gribble> https://github.com/bitcoin/bitcoin/issues/20594 | Fix getauxval calls in randomenv.cpp by jonasschnelli · Pull Request #20594 · bitcoin/bitcoin · GitHub
13:05 < wumpus> i mean usually you check that some feature is available *or* that you're compiling for the OS that the feature is on
13:05 < wumpus> now you're doing both!
13:05 < jonasschnelli> yeah.. I see.
13:06 < wumpus> i feel that's wrong, you shouldn't even detect getauxval on macos
13:06 < jonasschnelli> wumpus: the problem is the weak-link check...
13:06 < jonasschnelli> I probably have to fix that.
13:06 < jonasschnelli> But how would you fix that when weak-linking on macOS works (nature of weak linking)
13:06 < wumpus> i think that would be possible, though agree that weak-linking makes checking difficult
13:06 < wumpus> yes
13:07 < jonasschnelli> I think at least the weak linking symbol HAVE_WEAK_GETAUXVAL needs a && __linux__
13:07 < wumpus> you could move the __linux__ to the weak check in configure.ac
13:07 < wumpus> yes
13:07 < jonasschnelli> indeed. That would be cleaner
13:07 < wumpus> android has __linux__ right?
13:07 < jonasschnelli> AFAIK
13:07 < wumpus> (fwiw the weak check is there for android)
13:08 < wumpus> pretty sure too
13:08 < jonasschnelli> Yes. That part was added for android
13:10 < wumpus> for the strong check it shouldn't matter, though it's interesting that it seems to be specialized to ARM
13:11 < wumpus> getauxval(AT_HWCAP) doesn't really need arm_acle.h nor arm_neon.h, it's also a thing on many other architectures such as RISC-V
13:12 < wumpus> but that's out of scope for your fix I guess
13:12 < wumpus> it's not relevant to us as long as we're not using special instruction sets onthose platforms
13:12 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
13:13 < jonasschnelli> wumpus: It looks like they using getauxval to detect whether the intrinsics are supported.
13:14 < wumpus> that makes sense
13:15 < wumpus> the meaning of bits in getauxval(AT_HWCAP) is specific per CPU architecture
13:15 < wumpus> it's a nice way to detect if certain instruction sets are supported, better than say—the brute force way of trying then catching SIGILL
13:16 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
13:17 < wumpus> (which more or less works, is used by openssl, but is especially annoying when running a binary in a debugger, it will always trap on that)
13:18 < wumpus> (and then people report that as the problem instead of the real issue)
13:18 < jonasschnelli> wumpus: why doesn't __get_cpuid work in this case?
13:18 < jonasschnelli> like with sse4.2
13:18 < wumpus> that only exists on i?86 and x86_64
13:18 < jonasschnelli> ah... I see.
13:18 < wumpus> no other architecture has that information available to user space from the CPU directly
13:19 < sipa> cpuid also doesn't tell you whether support in enabled for certain CPU features, only if it's present
13:19 < wumpus> right
13:19 < jonasschnelli> #20594 should now be cleaner
13:19 < sipa> AVX2 for example requires the OS to have enabled support (as it needs to save/restore the extra registers)
13:20 < gribble> https://github.com/bitcoin/bitcoin/issues/20594 | Fix getauxval calls in randomenv.cpp by jonasschnelli · Pull Request #20594 · bitcoin/bitcoin · GitHub
13:21 < wumpus> jonasschnelli: lgtm now
13:23 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:33 < wumpus> sipa: TIL
13:35 < wumpus> I wonder if x86 has HWCAPS bits as well, I guess it does
13:36 < sipa> wumpus: see src/crypto/sha256.cpp's AVXEnabled()
13:36 < wumpus> only HWCAP2_RING3MWAIT it seems nothing relevant?
13:38 < jnewbery> sipa sdaftuar: you may want to review #19843
13:38 < gribble> https://github.com/bitcoin/bitcoin/issues/19843 | Refactoring and minor improvement for self-advertisements by naumenkogs · Pull Request #19843 · bitcoin/bitcoin · GitHub
13:39 < wumpus> sipa: xgetbv, ok, yes wouldn't have guessed that
14:02 -!- Netsplit *.net <-> *.split quits: jesseposner, awesome_doge, midnight, dergoegge
14:06 -!- chip-XXI [~multimedi@pop.92-184-104-195.mobile.abo.orange.fr] has joined #bitcoin-core-dev
14:06 -!- chip-XXI [~multimedi@pop.92-184-104-195.mobile.abo.orange.fr] has quit [Remote host closed the connection]
14:23 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
14:25 -!- einyx [einyx@fsf/member/einyx] has quit [Ping timeout: 260 seconds]
14:25 -!- einyx [einyx@fsf/member/einyx] has joined #bitcoin-core-dev
14:26 -!- kwm [~kwm@185.204.1.185] has quit [Remote host closed the connection]
14:30 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-cpuxjdlyceersvau] has joined #bitcoin-core-dev
14:30 -!- jesseposner [~jp@2601:643:8980:bfd2:1401:d5c:a187:3181] has joined #bitcoin-core-dev
14:33 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-witaeypfsoxnjlkc] has joined #bitcoin-core-dev
14:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:39 < bitcoin-git> [bitcoin] sipa opened pull request #20595: Improve heuristic hex decoding (master...202012_fancy_tx_hex_decode) https://github.com/bitcoin/bitcoin/pull/20595
14:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:46 -!- jaekwon [~jaekwon@185.163.110.125] has joined #bitcoin-core-dev
14:51 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:59 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d38feb6134e2...1a9fa4c5ba27
14:59 < bitcoin-git> bitcoin/master 65273fa Suhas Daftuar: Clear m_addr_known before our periodic self-advertisement
14:59 < bitcoin-git> bitcoin/master 1a9fa4c Wladimir J. van der Laan: Merge #20561: p2p: periodically clear m_addr_known
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:59 < bitcoin-git> [bitcoin] laanwj merged pull request #20561: p2p: periodically clear m_addr_known (master...2020-12-moar-addrz) https://github.com/bitcoin/bitcoin/pull/20561
14:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:10 < hebasto> what if p2p protocol will  have a new rule -- "during handshaking, i.e. before verack, unknown messages from peers are allowed without subsequent sender peer disconnection"; it will allow feature negotiation. Another new rule -- "node is free in its behaviour in case of receiving unknown message after verack, i.e. it can drop message and/or disconnect peer". This suggestion seem a good tradeoff with other 
15:10 < hebasto> implementations with a strong basement for future features.
15:13 < sipa> hebasto: i think you're preaching to the choir here
15:13 < sipa> the opposition to that idea was on the bitcoin-dev mailing list
15:14 < wumpus> you're definitely preaching to the choire here, I haven't heard any objection to 'allowing' unknown messages at all here
15:16 < wumpus> the title 'heuristic hex decoding' sounded really weird to me
15:17 < sipa> wumpus: any suggestion?
15:17 < wumpus> sipa: I don't mean I have a problem with it, it just sounded funny
15:17 < sipa> ah, ok
15:19 < wumpus> I guess because it was not immediately clear to me it was about transactions
15:20 < wumpus> yes better :)
15:21 < hebasto> sipa> Pieter Wuille hebasto: 01:13:58 the opposition to that idea was on the bitcoin-dev mailing list -- mind point out?
15:22 < sipa> hebasto: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2020-August/018084.html and the whole thread that follows
15:22 < hebasto> thanks!
15:23 < hebasto> oh, I've read that many times :)
15:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:24 < hebasto> maybe, should read it again
15:36 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has quit [Ping timeout: 256 seconds]
15:37 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
15:51 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
15:56 < sipa> jnewbery, sdaftuar: so it seems we currently send our own address (a) once, for outbound non-blockonly connections (b) periodically for non-blockonly connections after IBD is done
16:03 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
16:04 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has joined #bitcoin-core-dev
16:08 < sipa> https://github.com/bitcoin/bitcoin/pull/19843#discussion_r537930294
16:15 -!- jonatack [~jon@213.152.161.170] has quit [Quit: jonatack]
16:16 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
16:18 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
16:20 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
16:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
16:27 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:28 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
16:30 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
16:50 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
16:51 -!- einyx [einyx@fsf/member/einyx] has quit [Ping timeout: 264 seconds]
16:59 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has quit [Ping timeout: 256 seconds]
17:00 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has joined #bitcoin-core-dev
17:01 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
17:12 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 272 seconds]
17:12 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
17:13 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Remote host closed the connection]
17:13 -!- twistedline [~twisted@2601:14d:8500:a77d:558c:6632:8f65:ec9e] has joined #bitcoin-core-dev
17:13 -!- twistedline [~twisted@2601:14d:8500:a77d:558c:6632:8f65:ec9e] has quit [Changing host]
17:13 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
17:17 -!- glozow [uid453516@gateway/web/irccloud.com/x-ismhzanbxqycgvwi] has quit [Quit: Connection closed for inactivity]
17:24 -!- tryphe_ is now known as tryphe
17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:35 -!- vasild_ is now known as vasild
17:39 -!- twistedline_ [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has joined #bitcoin-core-dev
17:40 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
17:40 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Read error: Connection reset by peer]
17:41 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:58 < bitcoin-git> [bitcoin] RandyMcMillan opened pull request #20597: bug fix: bitcoind -h & -version output logic fixes issue #20596 (master...bitcoind-h-logic) https://github.com/bitcoin/bitcoin/pull/20597
17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:00 -!- openoms [~quassel@91.132.136.76] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
18:00 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
18:00 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
18:01 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
18:01 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev
18:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:08 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Quit: ZNC - http://znc.in]
18:09 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has joined #bitcoin-core-dev
18:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
18:17 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-mkskgzjzxiflwrdp] has quit [Quit: Connection closed for inactivity]
18:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has joined #bitcoin-core-dev
18:25 -!- twistedline_ [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has quit [Ping timeout: 256 seconds]
18:28 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Ping timeout: 240 seconds]
18:29 -!- IPGlider [~IPGlider@45.76.34.219] has quit [Ping timeout: 256 seconds]
18:33 -!- IPGlider [~IPGlider@45.76.34.219] has joined #bitcoin-core-dev
18:34 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev
18:44 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
18:48 -!- davterra [~davterra@static-198-54-131-92.cust.tzulo.com] has quit [Quit: Leaving]
18:51 -!- infernix [~nix@unaffiliated/infernix] has quit [Ping timeout: 264 seconds]
19:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:28 < bitcoin-git> [bitcoin] RandyMcMillan closed pull request #20597: bug fix: bitcoind -h & -version output logic fixes issue #20596 (master...bitcoind-h-logic) https://github.com/bitcoin/bitcoin/pull/20597
19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
20:28 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
20:28 -!- davterra [~davterra@static-198-54-131-124.cust.tzulo.com] has joined #bitcoin-core-dev
20:30 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-vkbfbgweuceqamve] has joined #bitcoin-core-dev
20:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
20:36 -!- infernix [~nix@unaffiliated/infernix] has joined #bitcoin-core-dev
21:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:08 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 240 seconds]
21:09 -!- twistedline [~twisted@2601:14d:8500:a77d:558c:6632:8f65:ec9e] has joined #bitcoin-core-dev
21:09 -!- twistedline [~twisted@2601:14d:8500:a77d:558c:6632:8f65:ec9e] has quit [Changing host]
21:09 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
21:17 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 256 seconds]
21:17 -!- twistedline_ [~twisted@2601:14d:8500:a77a:558c:6632:8f65:ec9e] has joined #bitcoin-core-dev
21:20 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 264 seconds]
21:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has joined #bitcoin-core-dev
21:29 -!- twistedline_ [~twisted@2601:14d:8500:a77a:558c:6632:8f65:ec9e] has quit [Remote host closed the connection]
21:29 -!- twistedline_ [~twisted@2601:14d:8500:a77d:558c:6632:8f65:ec9e] has joined #bitcoin-core-dev
21:47 < vasild> jnewbery: I am ok with you doing the announcement wrt bip155 change
21:47 < vasild> Thanks!
21:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:16 -!- jaekwon [~jaekwon@185.163.110.125] has quit [Remote host closed the connection]
22:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
22:46 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
23:00 -!- tss1 [~tss@185.204.1.185] has joined #bitcoin-core-dev
23:22 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds]
23:26 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has quit [Changing host]
23:26 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev
23:50 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
23:53 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
23:53 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
23:54 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
23:54 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
23:54 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
--- Log closed Tue Dec 08 00:00:39 2020