--- Log opened Thu Dec 10 00:00:43 2020 00:01 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 00:03 < az0re> What is the proper way to get the amount of a CTxIn? 00:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:05 < bitcoin-git> [bitcoin] jarolrod opened pull request #20610: doc: update for NetBSD 9.1, add GUI Build Instructions (master...netbsd-docs) https://github.com/bitcoin/bitcoin/pull/20610 00:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:08 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Ping timeout: 240 seconds] 00:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38176dc66523...c8fdbb46bd92 00:13 < bitcoin-git> bitcoin/master 904d875 Andrew Poelstra: configure: output notice that test binary is disabled by fuzzing 00:13 < bitcoin-git> bitcoin/master c8fdbb4 MarcoFalke: Merge #20609: configure: output notice that test binary is disabled by fuz... 00:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609 00:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:40 < jonasschnelli> curios to know: why do we have nPruneAfterHeight (a minimum height for pruning)? 00:40 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 00:45 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 00:48 < az0re> Alternatively, how should I get a CTxOut from a COutPoint (e.g., from CTxIn::prevout)? 00:51 -!- dachary1 [~dachary@217.146.82.202] has quit [Ping timeout: 256 seconds] 00:56 -!- instagibbs [~greg@061093103011.ctinets.com] has quit [Ping timeout: 258 seconds] 00:58 < sipa> az0re: look it up in the UTXO set 00:58 < az0re> ELI5 please :) 00:59 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 00:59 < az0re> To be more specific, how best to do it from within validation.cpp? 01:00 < az0re> (I am new to the Bitcoin codebase and would appreciate some tips on the most relevant data structures) 01:00 -!- instagibbs [~greg@061093103011.ctinets.com] has joined #bitcoin-core-dev 01:03 -!- jonatack [~jon@109.232.227.138] has quit [Remote host closed the connection] 01:03 < aj> az0re: there's a "gettxout" rpc call, you could look at how it's implemented in rpc/blockchain.cpp; or similar for "getrawtransaction" if you want to lookup the blockchain rather than the utxo set 01:03 < az0re> OK roger that I'll check them out 01:03 < az0re> Thanks 01:04 -!- jonatack [~jon@109.232.227.138] has joined #bitcoin-core-dev 01:07 < az0re> Actually I think Consensus::CheckTxInputs() did the trick for me. Looks like I need a CCoinsViewCache, then get a Coin from it with CCoinsViewCache::AccessCoin(), and can get the CTxOut from Coin::out 01:09 < sipa> az0re: yeah, pretty much 01:10 < sipa> where to get that cache depends on the context 01:10 < sipa> if you need to include mempool UTXOs as well it's a bitndifferent 01:11 < az0re> Hmmm... 01:12 < sipa> the gettxout RPC supports both with and without mempool 01:13 < sipa> so you can use that as an example 01:13 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has quit [Ping timeout: 258 seconds] 01:13 -!- alorente [~alorente@s91904426.blix.com] has joined #bitcoin-core-dev 01:16 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 01:20 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 240 seconds] 01:23 < az0re> I see, thanks 01:23 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:25 -!- mrostecki [mrostecki@nat/suse/x-wasokcvpgafclwxo] has joined #bitcoin-core-dev 01:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:47 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev 01:56 < jonasschnelli> MarcoFalke: functional tests: when calling assert_start_raises_init_error, the node checks for a few seconds for an RPC connection (bitcoind started, waiting for RPC to come up). Would it be possible to detect a shutdown and init error rather then polling RPC? 01:56 < jonasschnelli> (would save some seconds) 02:04 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has quit [Ping timeout: 258 seconds] 02:06 < wumpus> it's definitely possible to detect with subprocess that the child processes exited 02:07 < wumpus> or wait for it to exit, even with a timeout 02:16 < jonasschnelli> hmm... our testframework calls "if self.process.poll() is not None:"... I guess that should detect the halted process 02:16 < jonasschnelli> (but it doesn't) 02:16 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 02:16 < jonasschnelli> or it does but the timeout is too large 02:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:17 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20611: Move TX_MAX_STANDARD_VERSION to policy (master...2012-mvTxStandardVersion) https://github.com/bitcoin/bitcoin/pull/20611 02:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:17 < jonasschnelli> it's a race 02:18 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 02:19 < wumpus> dunno--fwiw there's .poll() which polls if the process is still running and .wait(timeout) that waits 02:21 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 265 seconds] 02:21 < wumpus> the preferable thing, if no RPC interaction is neccesary, would be to wait, no need for periodic polling 02:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:22 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c8fdbb46bd92...eb53c03b3680 02:22 < bitcoin-git> bitcoin/master 39c42c4 Pieter Wuille: Improve heuristic hex transaction decoding 02:22 < bitcoin-git> bitcoin/master 0f949cd Pieter Wuille: Add regression test for incorrect decoding 02:22 < bitcoin-git> bitcoin/master eb53c03 Wladimir J. van der Laan: Merge #20595: Improve heuristic hex transaction decoding 02:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:23 < wumpus> when any kind of RPC interaction is necessary there's no other option than to poll until it becomes available, there's no way to asynchronously be notified that 'RPC is up' 02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:23 < bitcoin-git> [bitcoin] laanwj merged pull request #20595: Improve heuristic hex transaction decoding (master...202012_fancy_tx_hex_decode) https://github.com/bitcoin/bitcoin/pull/20595 02:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:23 < wumpus> (maybe there should be) 02:23 < wumpus> although honestly I have no idea how to fit that best into the POSIX process model 02:25 < wumpus> hm I guess bitcoind could print some token to stdout / stderr that is detected by the connected parent process and taken as signal that RPC is running 02:26 < wumpus> alternatively it'd be possible to pass, say, in an additional file descriptor for signaling but that probably gets too fiddly 02:29 -!- promag_ is now known as promag 02:29 < promag> fanquake: ping? 02:29 < MarcoFalke> jonasschnelli: removing the rpc polling from assert_start_raises_init_error is a good idea 02:30 < MarcoFalke> we have intermittent issues due to that 02:30 < fanquake> promag: hi 02:30 < MarcoFalke> removing rpc from the equation should make everything more stable, but I am not sure how easy it is to implement 02:30 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:30 < MarcoFalke> if `assert_start_raises_init_error` fails, you'll have to use the rpc to use "stop" 02:31 < jonasschnelli> MarcoFalke: Agree. Though I'm not touching it for now. Happy if someone wants to take a closer look. 02:31 < MarcoFalke> or are the nodes shut down with SIGKILL? I don't remember 02:31 < promag> fanquake: I have an issue, not sure how to proceed. see https://github.com/icota/bitcoin/commit/683710e072eb90296ae5a57f53bce7cac799fc41 02:31 < jonasschnelli> I don't think that we test for SIGKILL 02:31 < promag> fanquake: I'll comment there 02:32 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev 02:33 < MarcoFalke> Everything ready for rc3? 02:34 < MarcoFalke> Who is doing the backports? Happy to do them if no one is working on it yet 02:34 < MarcoFalke> fanquake: wumpus: ^ 02:34 < fanquake> MarcoFalke: I was just waiting for the last few merges. Happy for you to do if you want. I’m afk for an hour or so 02:35 < fanquake> Promag: thanks, I’ll take a look tonight 02:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:39 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612 02:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:39 < MarcoFalke> done ^ 02:45 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-zdbkvysnmfxkmryf] has quit [Quit: Connection closed for inactivity] 02:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 02:54 < wumpus> MarcoFalke: I think we don't use the signals in the RPC tests because windows; I guess though it could start polling RPC only after the process didn't shut down as expected after a certain timeout 02:54 < wumpus> MarcoFalke: thanks 02:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:01 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eb53c03b3680...dcff2ee1fbf4 03:01 < bitcoin-git> bitcoin/master faefa5d MarcoFalke: log: Clarify that failure to write fee_estimates.dat is non-fatal 03:01 < bitcoin-git> bitcoin/master fa0d835 MarcoFalke: log: Clarify that failure to read fee_estimates.dat is non-fatal 03:01 < bitcoin-git> bitcoin/master dcff2ee Wladimir J. van der Laan: Merge #20589: log: Clarify that failure to read/write fee_estimates.dat is... 03:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:01 < bitcoin-git> [bitcoin] laanwj merged pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589 03:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:03 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection] 03:03 < hebasto> promag: did you try https://github.com/icota/bitcoin/commit/683710e072eb90296ae5a57f53bce7cac799fc41#commitcomment-44988208 ? 03:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:05 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dcff2ee1fbf4...e20b488395c1 03:05 < bitcoin-git> bitcoin/master 34c80d9 Wladimir J. van der Laan: test: Add option to git-subtree-check to do full check, add help 03:05 < bitcoin-git> bitcoin/master e20b488 Wladimir J. van der Laan: Merge #20567: test: Add option to git-subtree-check to do full check, add ... 03:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:05 < bitcoin-git> [bitcoin] laanwj merged pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567 03:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:05 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev 03:10 < promag> hebasto: thanks, will try it 03:14 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Client Quit] 03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:31 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613 03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 03:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 03:44 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:54 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e20b488395c1...8e1f9d62731c 03:54 < bitcoin-git> bitcoin/master 206f74e João Barbosa: Support make src/bitcoin-node and src/bitcoin-gui 03:54 < bitcoin-git> bitcoin/master 8e1f9d6 Wladimir J. van der Laan: Merge #20549: Support make src/bitcoin-node and src/bitcoin-gui 03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:54 < bitcoin-git> [bitcoin] laanwj merged pull request #20549: Support make src/bitcoin-node and src/bitcoin-gui (master...2020-12-make-bitcoin-node) https://github.com/bitcoin/bitcoin/pull/20549 03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:56 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:56 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 04:03 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 04:03 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:19 < bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1f9d62731c...86f20071931b 04:19 < bitcoin-git> bitcoin/master c96d1f6 Hennadii Stepanov: build, refactor: Check that Homebrew's qt5 package is actually installed 04:19 < bitcoin-git> bitcoin/master ee7b84e Hennadii Stepanov: build: Use Homebrew's sqlite package if it is available 04:19 < bitcoin-git> bitcoin/master c932e0d Hennadii Stepanov: doc: Update wallet database installation guide for macOS 04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:19 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #20527: build: Do not ignore Homebrew's SQLite on macOS (master...201129-sqlite) https://github.com/bitcoin/bitcoin/pull/20527 04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:23 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 04:36 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 04:38 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev 04:48 -!- Pavlenex1 [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 04:49 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Ping timeout: 240 seconds] 04:49 -!- Pavlenex1 is now known as Pavlenex 04:53 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 05:04 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 05:10 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 05:11 < hebasto> promag: the combined branch for qml static builds https://github.com/hebasto/bitcoin/commits/201210-qml 05:15 -!- pergaminho [~Cleber@189.26.121.248] has joined #bitcoin-core-dev 05:26 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 05:28 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 256 seconds] 05:33 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev 05:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:35 -!- vasild_ is now known as vasild 05:39 < sdaftuar> MarcoFalke: can you tell me your thoughts on how close #19858 is to be merged? 3 PRs that conflict with it have been merged since it was acked 4 times, so i'm trying to rebase and get re-review before this happens again 05:39 < gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub 05:40 < sdaftuar> but if it will be a while i can hold off on pestering people 05:40 < MarcoFalke> sdaftuar: I explictly held back on merging the conflicting prs. I simply didn't get the notification last night from GitHub that you rebased it 05:41 < sdaftuar> ah, thanks for the effort 05:41 < sdaftuar> so i should go ahead then with my rebase and re-pester plan 05:41 < MarcoFalke> Yes, I think the re-ACKs shouldn't be too difficult 05:41 < MarcoFalke> Not sure why no one has re-ACKed it in the last 9 days 05:42 < sdaftuar> gleb reacked last night 05:42 < sdaftuar> or this morning i guess 05:45 < sdaftuar> MarcoFalke: if you do think it close, would you mind commenting on the PR that you think it would be ready for merge once it gets some re-acks? so that other reviewers know their time will be well spent getting it across the finihs line 05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:45 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86f20071931b...b76abae387b9 05:45 < bitcoin-git> bitcoin/master 32045bb wodry: [doc] Tidy up Tor doc (more stringent) 05:45 < bitcoin-git> bitcoin/master b76abae Wladimir J. van der Laan: Merge #20587: [doc] Tidy up Tor doc (more stringent) 05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:45 < sdaftuar> (after i rbease and repush anyway) 05:45 < MarcoFalke> sdaftuar: Ok, I'll leave a comment 05:45 < sdaftuar> thank you! 05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:45 < bitcoin-git> [bitcoin] laanwj merged pull request #20587: [doc] Tidy up Tor doc (more stringent) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20587 05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:49 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo] 05:51 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:51 < bitcoin-git> [bitcoin] Sjors opened pull request #20614: util: RunCommandParseJSON followups (master...2020/12/build-aux) https://github.com/bitcoin/bitcoin/pull/20614 05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:53 -!- alorente [~alorente@s91904426.blix.com] has quit [Remote host closed the connection] 05:55 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 06:02 -!- v4hn [~v4hn@178.162.212.214] has joined #bitcoin-core-dev 06:07 -!- roconnor [~roconnor@host-45-58-200-239.dyn.295.ca] has joined #bitcoin-core-dev 06:07 < promag> hebasto: does the branch work for you? 06:09 < hebasto> promag: `make -C depends qt HOST=x86_64-apple-darwin18` ends with `Caching qt...` that means ok. Have you a problem with it? 06:10 < promag> did it build qt quick controls? 06:11 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 06:12 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 06:13 < hebasto> checking... 06:13 < queip> the "score" field in getnetworkinfo, what does it actually mean? we are confused about it trying to provide support to user in #bitcoin . Could RPC help xxx command include short explanation for the outputed JSON fields for most commands? 06:14 < promag> hebasto: do you have qml/QtQuick/Controls.2 dir in the build dir? 06:16 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 06:18 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:19 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20615: cirrus: Schedule one task with paid credits for faster CI feedback (master...2012-ciFasterFeedback) https://github.com/bitcoin/bitcoin/pull/20615 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:23 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 265 seconds] 06:26 < hebasto> promag: sorry (took my wrong branch), missed staging commands, updating... 06:33 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 06:33 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Read error: Connection reset by peer] 06:33 < hebasto> promag: please check updated branch 06:33 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 06:33 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 06:36 < hebasto> promag: I think `libqtquick2plugin.a` is that what we want, right? 06:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 06:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 06:40 < hebasto> also built `libQt5Quick.a` `libQt5Qml.a` 06:43 < promag> I think its missing qt quick controls lib 06:45 < promag> hebasto: the thing is we must run qmake on qtquickcontrols after qtquick install 06:46 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 06:50 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:50 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 06:53 < hebasto> hmm, why `make -C depends HOST=x86_64-apple-darwin18` (in my branch) ends without any problem with all required static libraries built? 06:53 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 06:54 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:54 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Ping timeout: 256 seconds] 06:57 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 06:59 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 06:59 < promag> hebasto: not sure, but the suspect is "../qtbase/bin/qmake qtquickcontrols2.pro -o Makefile" 07:00 < promag> that qmake doesn't find qtquick 07:02 < sdaftuar> vasild: i am trying to restart the appveyor test in #19763, but i think maybe someone cancelled the build? i'm a bit confused 07:02 < gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub 07:03 < vasild> I did not cancel it, maybe it got confused somehow by my push of a previous commit? 07:03 < hebasto> promag: for which platform are you trying to build depends? 07:03 < sdaftuar> i will try again 07:03 < promag> hebasto: for my host, macos 07:04 < hebasto> which macos version? 07:08 -!- peterrizzo_ [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 07:09 < sdaftuar> vasild: ok i'm out of my depth on trying to get the appveyor or cirrus-ci builds to re-run 07:12 < vasild> sdaftuar: if nothing else works, I can always make some minor whitespace change and re-push, but lets wait for all to complete first and see if somebody will have a better idea 07:13 < sdaftuar> yeah, sounds good 07:15 -!- davterra [~davterra@static-198-54-131-156.cust.tzulo.com] has quit [Quit: Leaving] 07:22 -!- peterrizzo_ [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo_] 07:31 < promag> hebasto: Some of the required modules (qtHaveModule(quick)) are not available. \n Skipped. 07:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:35 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 07:35 < hebasto> promag: thanks! I see this message on Big Sur. 07:36 < promag> not on linux? 07:39 < hebasto> on linux too (( 07:41 < promag> ok good, at least we are on the same page :D 07:41 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 07:42 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 07:45 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:46 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:48 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 07:48 -!- miketwen_ [~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com] has joined #bitcoin-core-dev 07:50 < promag> fanquake: cfields: do you see problems using qt single archive instead of separate modules? 07:50 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 246 seconds] 07:51 < promag> download a bigger archive VS more complicated build script 08:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 08:12 < ariard> sdaftuar: jonatack and I just re-ack #19858 but please ping again if there is a new rebase to deal with it, this PR has been in limbo for too long :) 08:12 < gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub 08:13 < sdaftuar> ariard: thank you! 08:15 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Ping timeout: 260 seconds] 08:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 08:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 08:29 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 08:34 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 08:34 -!- kexkey [~kexkey@static-198-54-132-141.cust.tzulo.com] has joined #bitcoin-core-dev 08:36 < jonatack> I don't recall being able to restart appveyor, it always seemed more like a "game over, re-push to replay" thing. The cirrus builds can be restarted...ISTM they restart on their own after a while (unsure) 08:39 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 08:42 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:43 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 08:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 09:04 -!- jesseposner [~jp@2601:643:8980:bfd2:1401:d5c:a187:3181] has quit [Remote host closed the connection] 09:08 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 09:13 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 09:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:33 < bitcoin-git> [bitcoin] lontivero opened pull request #20616: Check CJDNS address is valid (master...validate-cjdns-addresses) https://github.com/bitcoin/bitcoin/pull/20616 09:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:35 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b76abae387b9...da957cd62ecc 09:41 < bitcoin-git> bitcoin/master fa918dd MarcoFalke: test: Use Popen.wait instead of RPC in assert_start_raises_init_error 09:41 < bitcoin-git> bitcoin/master da957cd MarcoFalke: Merge #20613: test: Use Popen.wait instead of RPC in assert_start_raises_i... 09:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:41 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613 09:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:42 -!- pergaminho [~Cleber@189.26.121.248] has quit [Quit: Saindo] 09:46 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev 09:46 -!- kvaciral [~kvaciral@212.8.251.11] has joined #bitcoin-core-dev 09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:58 < bitcoin-git> [bitcoin] ariard opened pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617 09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:19 < bitcoin-git> [bitcoin] laanwj pushed 12 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/aa4b8ebfecdd...3fee499bc3af 10:19 < bitcoin-git> bitcoin/0.21 9e80688 Pieter Wuille: Don't send 'sendaddrv2' to pre-70016 software 10:19 < bitcoin-git> bitcoin/0.21 bead935 Pieter Wuille: Send and require SENDADDRV2 before VERACK 10:19 < bitcoin-git> bitcoin/0.21 06c8423 Jon Atack: wallet, bugfix: allow send to take string fee rate values 10:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:19 < bitcoin-git> [bitcoin] laanwj merged pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612 10:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:21 < MarcoFalke> \o/ 10:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:21 < bitcoin-git> [bitcoin] hebasto closed pull request #19882: depends: Export variables from make to environment explicitly (master...200905-build) https://github.com/bitcoin/bitcoin/pull/19882 10:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:21 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 10:22 < sipa> are they (final rc3) backports, or final (rc3) backports? 10:22 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 10:22 < MarcoFalke> hopefully both 10:23 -!- Guyver2_ is now known as Guyver2 10:26 < luke-jr> XD 10:33 < wumpus> i deleted the en_GB translation on transifex; it contained all kinds of junk, e.g. a pasted shell transcript, some French messages, and so on. Besides that it seems kind of pointless in the first place. 10:35 < wumpus> sipa: final for rc3 at least, i plan to tag rc3 soon after 10:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:45 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/3fee499bc3af...e6d0fa3ef6f6 10:45 < bitcoin-git> bitcoin/0.21 e6d0fa3 Wladimir J. van der Laan: gui: pre-rc3 translations update 10:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:46 < wumpus> no manual page changes and no English translation changes this time 10:46 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 10:56 -!- glozow [uid453516@gateway/web/irccloud.com/x-eaaqhhyeagrjdhwm] has joined #bitcoin-core-dev 11:01 < hebasto> meeting? 11:01 < luke-jr> .. 11:02 < wumpus> #startmeeting 11:02 < jnewbery> hi 11:02 < achow101> hi 11:02 < hebasto> hi 11:02 < kanzure> hi 11:02 < wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/e6d0fa3ef6f6...9ae536d3684e 11:02 < bitcoin-git> bitcoin/0.21 9ae536d Wladimir J. van der Laan: build: Bump RC to rc3 11:02 < wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:02 < promag> hi 11:02 < wumpus> no proposed topics for this week on http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 11:02 < jb55> hi 11:02 < wumpus> does anyone have last minute things they'd like to discuss? 11:03 < Murch> hi 11:03 < michaelfolkson> hi 11:03 < jonasschnelli> hi 11:03 < Murch> I'm sure achow101 would love if someone besides be would take a glance at #20040 11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/20040 | wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping by achow101 · Pull Request #20040 · bitcoin/bitcoin · GitHub 11:04 < Murch> *besides me 11:04 < jonatack> hi 11:04 < wumpus> is already in the high prioroty for review 11:04 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-oeyqoxzpfotwpgrr] has joined #bitcoin-core-dev 11:04 < wumpus> #topic High priority for review 11:04 < jonatack> Murch: +1 11:04 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 11:05 < wumpus> anything to add/remove or that is ready for merge? 11:05 < MarcoFalke> anything holding back a 0.19 and 0.20 release? 11:05 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 11:05 < wumpus> FWIW I added #19858 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub 11:06 < achow101> MarcoFalke: still waiting for #19740 for 0.20 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/19740 | [0.20] wallet: Simplify and fix CWallet::SignTransaction by achow101 · Pull Request #19740 · bitcoin/bitcoin · GitHub 11:06 < sdaftuar> wumpus: thanks! 11:06 < jonatack> maybe #20546 for me 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub 11:07 < MarcoFalke> achow101: merged 11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:07 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/75bf23d8613a...953dddbd2058 11:07 < bitcoin-git> bitcoin/0.20 2d48d7d Andrew Chow: Simplify and fix CWallet::SignTransaction 11:07 < bitcoin-git> bitcoin/0.20 6a326cf Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged 11:07 < bitcoin-git> bitcoin/0.20 953dddb MarcoFalke: Merge #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction 11:07 < MarcoFalke> thanks for the test btw 11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:07 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740 11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:07 < wumpus> jonatack: added 11:07 < jonatack> wumpus: merci 11:08 < wumpus> no idea about 0.19 and 0.20, but I'll tag 0.21.0rc3 after the meeting 11:10 < wumpus> if the other branches are ready for tagging just say so 11:12 < wumpus> okay, any other topics? 11:12 < wumpus> seems to be a short meeting 11:12 < sipa> 21 million decananoversions! 11:13 < wumpus> hehe, a new version unit 11:13 < sipa> 21M versionsats? 11:13 < wumpus> better than versionbits *ducks* 11:14 < sipa> hahaha 11:14 < wumpus> #endmeeting 11:14 < luke-jr> wut 11:14 < jonatack> :D 11:14 * Murch watches joke pass over his head 11:14 < MarcoFalke> wumpus: yes, I think 0.19 and 0.20 are ready for tag as well 11:15 < aj> 100 versionsats per versionbit then? 11:15 < wumpus> seems the bot wandered off again 11:15 < jonasschnelli> My fault... 11:15 < wumpus> Murch: yes a bit of a inside joke there was some discussion about bitcoin units again on twitter 11:16 < jonatack> we start using sats, suddenly there's a push for bits 11:16 -!- core-meetingbot [~meetingbo@2a01:4f9:2a:2510::2] has joined #bitcoin-core-dev 11:16 < Murch> Must have missed it ^^ 11:17 < jonasschnelli> ping core-meetingbot 11:18 < luke-jr> jonatack: not for feerate I think? 11:19 < sipa> i missed that push too; i just found it funny due to name confusion with BIP9's versionbits 11:19 < jonatack> luke-jr: i don't think so? Murch: easy to miss, bits means a few other things already 11:19 < wumpus> MarcoFalke: ok! 11:19 < Murch> luke-jr: Can't wait for bits per kilovirtualbyte :~ 11:20 < Murch> or bits per kilosipa 11:20 < Murch> haha 11:20 < Murch> jonatack: That's my biggest gripe with it 11:23 < jonasschnelli> ping core-meetingbot 11:24 < sipa> bad bot 11:25 < jonasschnelli> wait wait 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:25 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/5baaea4410a1...5f2f304cbec9 11:25 < bitcoin-git> bitcoin/0.19 5f2f304 Wladimir J. van der Laan: build: Bump version to 0.19.2rc1 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:25 < jonasschnelli> now 11:25 < jonasschnelli> ping core-meetingbot 11:25 * jonasschnelli hmm... 11:26 < jonasschnelli> #startmeeting 11:26 < core-meetingbot> Meeting started Thu Dec 10 19:26:15 2020 UTC. The chair is jonasschnelli. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 11:26 < core-meetingbot> Available commands: action commands idea info link nick 11:26 < jonasschnelli> #endmeeting 11:26 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 11:26 < core-meetingbot> Meeting ended Thu Dec 10 19:26:18 2020 UTC. 11:26 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-10-19.26.moin.txt 11:26 * jonasschnelli fixed... 11:26 < promag> achow101: regarding https://bitcoin.stackexchange.com/questions/54230/any-plans-for-bitcoin-core-app-to-integrate-hardware-wallet-support#comment95782_54618 how would bitcoin core support hww in android for instance? 11:27 < achow101> promag: no idea 11:27 < jonasschnelli> sorry... the bots server had to restart recently and did not automatically identify via NickServ. That's why it was muted. 11:27 < wumpus> jonasschnelli: thanks! 11:27 < jonasschnelli> The todays meeting was though recorded: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-04-19.01.moin.txt 11:27 < jonasschnelli> (the bot was just muted) 11:27 < wumpus> jonasschnelli: oh good! 11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:27 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/953dddbd2058...2808593b7c8c 11:27 < bitcoin-git> bitcoin/0.20 2808593 Wladimir J. van der Laan: build: Bump version to 0.20.2rc1 11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:28 < jonasschnelli> ahm... wait. No. It wasn't 11:28 < jonasschnelli> That was last weeks. 11:28 < jonasschnelli> shouldn't happen again 11:29 < wumpus> promag: depends on how the wallet connects to the host I suppose? host USB is supported on some android devices (since 3.1, I see) 11:29 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Ping timeout: 240 seconds] 11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:30 < bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc3 11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:31 < wumpus> ^^ 11:32 < achow101> yay 3 things to build 11:32 < wumpus> triple-combo tag (but for 0.20 and 0.19 I still have to do manual page updates and translations) 11:32 < wumpus> that was a no-op for 0.21 this rc 11:33 < wumpus> well the translations wasn't 11:36 -!- core-meetingbot [~meetingbo@2a01:4f9:2a:2510::2] has quit [Quit: 2019.02.23] 11:36 -!- core-meetingbot [~meetingbo@2a01:4f9:2a:2510::2] has joined #bitcoin-core-dev 11:37 < sipa> i've been out of the loop for gitian building for a few years, but have a good setup now 11:37 < sipa> where do i start? i'm on ubuntu 11:37 < jonasschnelli> sipa: https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md 11:38 < jonasschnelli> then probably: ./gitian-build.py --setup (see https://github.com/bitcoin-core/docs/blob/master/gitian-building.md) 11:39 < luke-jr> :o 11:40 < sipa> so i'd create a debian VM, and run gitian inside that (with LXC?) 11:41 < wumpus> that's what i have 11:41 < sipa> ok 11:42 < jonatack> https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md 11:42 < jonasschnelli> sipa: I run LXC directly on a physical debian host 11:42 < jonasschnelli> (I guess you can do the same with ubuntu?) 11:42 < wumpus> if you already run debian you could skip the outer VM, but, I generally don't want to pollute the physical host with all kind of stuff 11:43 < jonasschnelli> Yes. Agree that this makes sense. 11:43 < sipa> i assume you can do the gpg signing outside the VM? 11:43 < wumpus> (though LXC isn't that bad) 11:43 < wumpus> yes 11:44 < jonasschnelli> sipa: yes. I also GPG sign "outside" 11:45 < jonasschnelli> (on a different computer) 11:45 < wumpus> I have my own script to fetch the assert files from the VM and sign them with (w gpg2 --detach-sign), don't know if there's a standard way to do it nowadays 11:45 < sipa> how much disk space would you need for the VM? 11:45 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 11:46 < jonasschnelli> 15G Aug 11 08:51 base-bionic-amd64 11:46 < jonasschnelli> + some small stuff 11:46 < sipa> cool 11:46 < wumpus> it needs to write the output somewhere too but yes 11:47 < jonasschnelli> You'll also need the macOS SDK (grab it from bitcoincore.org, check the travis files for the URL) 11:47 < wumpus> I assigned 40GB to it 11:48 < hebasto> sipa: https://bitcoincore.org/depends-sources/sdks/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers.tar.gz 11:48 < wumpus> it's preferable to extract the SDK using the instructions from an actual Apple download, especially if you have a mac yourself, but yeah most people simply grab it 11:49 < sipa> i don't have any apple hardware 11:49 < sipa> but you can do the extraction from linux, right? 11:50 < jonasschnelli> I think you can 11:50 < jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction 11:50 < jonasschnelli> you need an Apple ID though. :) 11:51 < luke-jr> sipa: you may want more than 15 GB for caches 11:51 < luke-jr> unless you wipe them 11:52 < sipa> ok, gave it 50 G 11:52 < luke-jr> I have 16 GB of caches alone XD 11:52 < wumpus> definitely if you keep the caches for old branches around 11:53 < luke-jr> hebasto: it's not technically legal for us to distribute that btw 11:53 < wumpus> FWIW I usually delete the caches for every major/minor release, building the depends takes somewhat longer but it's rare enough, and there are some other steps that take a long time too 11:54 < wumpus> and it wouldn't be the first time that solves a determinism issue 11:54 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 11:56 < jonasschnelli> bb8c59034420709cdbae2e47ec1a1dce03c68ab4142ff3b67a23c415e6557be1 bitcoin-0.21.0rc3-osx-unsigned.dmg 11:56 < wumpus> it's especially for the linux build that caching really helps, qt for all those platforms 11:57 < luke-jr> jonasschnelli: wow fast 11:58 < jonasschnelli> luke-jr: macOS builds are fast (my script does that first): https://bitcoin.jonasschnelli.ch/gitian/build/358 12:00 < luke-jr> i c 12:00 < luke-jr> I think mine does Windows, Linux, macOS 12:00 * luke-jr wonders if we ought to s/osx/macos/ 12:00 < luke-jr> or even just mac 12:00 < sipa> especially with the latest release being XI and not X anymore 12:00 < jonasschnelli> luke-jr: I looked into it. But I guess it's not really worth it. 12:01 < jonasschnelli> sipa: its 10.16 and 11 (internally!) 12:01 < sipa> jonasschnelli: i know 12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:01 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/2808593b7c8c...a4bc4c1f79d7 12:01 < bitcoin-git> bitcoin/0.20 98c9d79 Wladimir J. van der Laan: gui: Pre-rc1 translations update 12:01 < bitcoin-git> bitcoin/0.20 a4bc4c1 Wladimir J. van der Laan: doc: Update manual pages pre-rc1 12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:03 < wumpus> luke-jr: renaming files is kind of annoying, as the file names are hardcoded in all kinds of places and scripts, also not sure it's worth it for something that doesn't generate any ambiguity 12:06 < sipa> jonasschnelli: i created an apple id, but it says i'm not allowed to download the xcode files 12:07 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 12:07 < jonasschnelli> sipa: have you used the link from the docs? 12:07 < jonasschnelli> I guess that one is old/invalid 12:07 < jonasschnelli> Maybe go here: https://developer.apple.com/download/more/ 12:07 < jonasschnelli> (maybe directly here: https://download.developer.apple.com/Developer_Tools/Xcode_12.2/Xcode_12.2.xip) 12:08 < sipa> is it ok to use a later version? 12:08 < jonasschnelli> oh.. wait. you need to older version 12:08 < jonasschnelli> maybe that one: https://download.developer.apple.com/Developer_Tools/Xcode_11.3.1/Xcode_11.3.1.xip? 12:08 < jonasschnelli> (download works for me) 12:10 < sipa> i need to sign up for the developer program 12:10 < sipa> which is $99 a year 12:10 < sipa> ?? 12:10 < achow101> sipa: it shouldn't be required, but I don't remember which links to go to 12:11 < jonasschnelli> No. You don't need that 12:11 < jonasschnelli> You only need the 99$ programm if you want to deploy apps 12:11 < jonasschnelli> sipa: just click harder,... you'll find it 12:12 < sipa> Sorry, you cannot view this page. 12:12 < sipa> he Apple ID you signed in with does not have permission to view this page. 12:12 < sipa> If you’re currently a member of the Apple Developer Program, you or your Account Holder may need to update your account by agreeing to the latest license agreement in order to access this page. To view your current membership status and benefits, visit your account. 12:13 < jonasschnelli> sipa: let me try to create a new account.. 12:13 < jonasschnelli> Have you verified your email and all that stuff? 12:13 < sipa> https://developer.apple.com/services-account/download?path=/Developer_Tools/Xcode_11.3.1/Xcode_11.3.1.xip 12:13 < sipa> that works! 12:15 -!- kexkey_ [~kexkey@static-198-54-132-93.cust.tzulo.com] has joined #bitcoin-core-dev 12:16 < jonasschnelli> sipa: Yes. Should work. I just created a new account. 12:16 < jonasschnelli> works 12:17 < jonasschnelli> You may need to agree to some terms etc. 12:17 -!- kexkey [~kexkey@static-198-54-132-141.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 12:17 < wumpus> let's update the URL in the doc 12:18 < sipa> jonasschnelli: it's downloading, and i didn't do anything else :) 12:19 < luke-jr> yeah.. I had to jump through some hoops to find it too 12:20 < jonasschnelli> I guess that doc is outdated? https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-mac-os-sdk.md 12:21 < jonasschnelli> The link should still be valid: https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction 12:21 < jonasschnelli> I guess you'll get a 403 if you are not logged in our haven't accepted the terms, etc. 12:21 < achow101> I think you need to already be logged in for the link to work 12:21 < sipa> jonasschnelli: yeah the link there works 12:22 < sipa> the previous one you gave didn't 12:22 < jonasschnelli> its the same. :) 12:22 < jonatack> "if it doesn't work, just click harder" :D ...that should go in the doc 12:22 < jonasschnelli> I just dbl-checked 12:22 < sipa> no it isn't 12:22 < jonasschnelli> jonasschnelli: hah 12:22 < sipa> https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction has the wrong URL 12:22 < sipa> https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-mac-os-sdk.md has the right one 12:22 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:23 < sipa> they're literally not the same URL 12:23 < achow101> sipa: the one in contrib/macdeploy works for me if I'm already logged in 12:23 < sipa> i'm logged in 12:23 < achow101> it's also the link that you get from the website and search for the sdk manually 12:24 < sipa> wait 12:24 < sipa> now the other one works too 12:24 < sipa> ok, i give up! 12:24 < jonasschnelli> sipa: the one you wrote last (gitian-building-mac-os-sdk.md) is outdated IMO 12:24 < jonasschnelli> As I said. Click harder. :) 12:24 < jonasschnelli> jonatack: heh.. :) 12:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 12:24 < sipa> my conspiracy theory is that the first URL starts working as soon as you try the second one 12:24 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev 12:25 < achow101> it's never easy with apple stuff 12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:25 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/5f2f304cbec9...e301a9fde351 12:25 < bitcoin-git> bitcoin/0.19 f8d2a04 Wladimir J. van der Laan: gui: Pre-rc1 translations update 12:25 < bitcoin-git> bitcoin/0.19 e301a9f Wladimir J. van der Laan: doc: Pre-rc1 manual pages update 12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:26 < jamesob> Argh, missed the meeting again. 12:26 < gleb> jamesob: same here, just managed to join :) 12:26 < jamesob> Can I review/merge beg for #19806? This one's been hanging out for a while 12:26 < gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub 12:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:27 < bitcoin-git> [bitcoin] laanwj pushed tag v0.19.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.19.2rc1 12:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:27 < bitcoin-git> [bitcoin] laanwj pushed tag v0.20.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.20.2rc1 12:27 < jamesob> gleb: timezones man, they're rough 12:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 12:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 12:30 < wumpus> now everyone can build their favorite branch 12:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 12:32 < achow101> I sure hope we don't have any non-determinism 12:34 < wumpus> if so, especially for 0.19, deciding to forego the gitian build at all would be a valid choice 12:35 < wumpus> the current (possibly final) state of the branch is tagged, that was kind of the point, people can build it from source if they want 12:43 < jonasschnelli> achow101: 0.21.0rc3 macOS sigs are up (hash matches with yours and hebasto's): https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.21 12:50 -!- zakkdev [~textual@89.107.6.72] has joined #bitcoin-core-dev 12:52 < achow101> waiting for one more windows sig 12:53 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 12:53 < jonasschnelli> achow101: https://bitcoin.jonasschnelli.ch/gitian/build/358 12:53 < jonasschnelli> (commit soon as linux is done) 12:53 < jonasschnelli> e72a9059a206a822fc02d7d304992a23acb9355fbf7b3b94353839075532bd5f bitcoin-0.21.0rc3-win-unsigned.tar.gz 13:00 -!- proofofkeags_ [~proofofke@2601:280:c280:e500:105f:32aa:c59e:2130] has joined #bitcoin-core-dev 13:03 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 240 seconds] 13:10 < achow101> gitian builders: 0.21.0rc3 sigs are up 13:18 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:18 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo] 13:18 < luke-jr> achow101: why? those sigs aren't supposed to be created until 3 gitian builds match 13:18 < luke-jr> right now there's ZERO in the repo.. 13:18 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 13:20 < luke-jr> where are you guys seeing sigs? :/ 13:20 < hebasto> luke-jr: https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.21 13:20 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 13:20 < luke-jr> hebasto: right, those aren't supposed to exist until there are 3 matching gitian sigs 13:21 < luke-jr> but the gitian.sigs repo is empty afaict 13:21 < luke-jr> (well, empty of rc3) 13:21 -!- chri_eb [~chris@gateway/tor-sasl/chrieb/x-28824719] has joined #bitcoin-core-dev 13:22 < hebasto> yes, repo is empty; but hashes from achow101 jonasschnelli and me are the same, right? 13:22 < achow101> luke-jr: prs are there 13:22 < luke-jr> can't verify without the PGP sigs on them 13:22 < luke-jr> achow101: ah 13:22 < hebasto> luke-jr: right 13:24 < luke-jr> only see achow101 and hebasto? 13:25 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo] 13:26 < achow101> luke-jr: jonasschnelli results are at https://bitcoin.jonasschnelli.ch/gitian/build/358 13:26 -!- glozow [uid453516@gateway/web/irccloud.com/x-eaaqhhyeagrjdhwm] has quit [Quit: Connection closed for inactivity] 13:26 -!- peterrizzo_ [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 13:27 < luke-jr> not signed 13:27 < luke-jr> oh,. they are 13:27 < luke-jr> gotta scroll down 13:28 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:43 < wumpus> pushed sigs too 13:44 < sipa> building! 13:45 < luke-jr> mine is on riscv, so almost done 13:45 < luke-jr> (turns out my order is win, osx, linux) 13:50 -!- v4hn [~v4hn@178.162.212.214] has quit [Remote host closed the connection] 13:58 -!- JackSparrow [~JackSparr@s91904426.blix.com] has joined #bitcoin-core-dev 14:01 < theStack> fwiw, the contrib/gitian-build.py script with docker worked like a charm for me, no need for a vm 14:02 -!- proofofkeags__ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev 14:05 -!- proofofkeags_ [~proofofke@2601:280:c280:e500:105f:32aa:c59e:2130] has quit [Ping timeout: 260 seconds] 14:13 -!- jesseposner [~jp@2601:643:8980:bfd2:4ca5:5aef:8068:2da7] has joined #bitcoin-core-dev 14:23 -!- zakkdev [~textual@89.107.6.72] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:24 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 14:24 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 14:27 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 14:27 -!- btc_thc [annalee@kosher.marriageiguana.com] has quit [Ping timeout: 246 seconds] 14:29 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 14:29 -!- btc_thc [annalee@kosher.marriageiguana.com] has joined #bitcoin-core-dev 14:31 -!- proofofkeags_ [~proofofke@2601:280:c280:e500:1901:898e:ac68:17ca] has joined #bitcoin-core-dev 14:32 -!- proofofkeags__ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Read error: Connection reset by peer] 14:33 -!- proofofkeags__ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev 14:35 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 14:36 -!- proofofkeags_ [~proofofke@2601:280:c280:e500:1901:898e:ac68:17ca] has quit [Ping timeout: 258 seconds] 14:38 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 14:50 -!- kvaciral [~kvaciral@212.8.251.11] has quit [Quit: Lost terminal] 15:03 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 15:04 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 15:04 < luke-jr> theStack: docker IS a VM… 15:05 < sipa> luke-jr: i think he means he didn't need yet another VM around it 15:08 -!- jonatack [~jon@109.232.227.138] has quit [Ping timeout: 246 seconds] 15:09 -!- jonatack [~jon@213.152.186.24] has joined #bitcoin-core-dev 15:12 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 264 seconds] 15:19 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 15:19 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:24 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 15:24 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 15:25 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 15:25 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:25 -!- twistedline__ [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has quit [Read error: Connection reset by peer] 15:30 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 15:30 -!- proofofkeags_ [~proofofke@2601:280:c280:e500:7f46:e633:cdc5:9df4] has joined #bitcoin-core-dev 15:30 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 15:30 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:30 < bitcoin-git> [gui] luke-jr opened pull request #149: Intro: Have user choose assumevalid (master...intro_assumevalid) https://github.com/bitcoin-core/gui/pull/149 15:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:30 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 15:31 < luke-jr> hebasto: promag: care to re-review https://github.com/bitcoin-core/gui/pull/125 - 2 ACKs, would be nice to get it in so I can move on to https://github.com/bitcoin-core/gui/pull/149 :P 15:32 -!- proofofkeags__ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds] 15:34 -!- jonatack [~jon@213.152.186.24] has quit [Quit: jonatack] 15:36 < theStack> luke-jr: not really, it shares the kernel with the host 15:37 -!- proofofkeags_ [~proofofke@2601:280:c280:e500:7f46:e633:cdc5:9df4] has quit [Remote host closed the connection] 15:40 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 15:42 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Read error: Connection reset by peer] 15:43 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 15:46 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 15:48 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 15:48 < sipa> ok, i have the unsigned binaries, they match 15:49 < sipa> i'm running gitian-build.py --sign now, but it seems it's building the linux binaries again? 15:54 < sipa> oh, i'm silly 15:54 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 15:55 < sipa> -b == --build 15:57 < luke-jr> theStack: so do many VMs 15:57 < luke-jr> sipa: lol 15:57 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Remote host closed the connection] 15:57 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 15:58 < theStack> luke-jr: there are tons of articles explaining the differences between containers and vms... feel free to redefine terms for yourself though 15:59 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds] 16:00 -!- jonatack [~jon@213.152.186.40] has joined #bitcoin-core-dev 16:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 16:10 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 16:10 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 16:14 < luke-jr> my gitians all match, pushed 16:15 -!- chri_eb [~chris@gateway/tor-sasl/chrieb/x-28824719] has quit [Ping timeout: 240 seconds] 16:15 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 16:15 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 16:15 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds] 16:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 16:15 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 16:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 16:15 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Ping timeout: 240 seconds] 16:15 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 16:15 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:15 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds] 16:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 16:17 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Ping timeout: 272 seconds] 16:17 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has joined #bitcoin-core-dev 16:20 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 16:23 -!- chri_eb [~chris@gateway/tor-sasl/chrieb/x-28824719] has joined #bitcoin-core-dev 16:23 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 16:24 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 16:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 16:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 16:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 16:24 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 16:26 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 16:27 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 16:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 16:32 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 16:32 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 16:36 < achow101> why did we keep changing the sdk? 16:36 < achow101> *macOS sdk 16:37 < achow101> 0.19 is 10.11, 0.20 is 10.14, and 0.21 is long_xcode_name 16:38 -!- twistedline_ [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has joined #bitcoin-core-dev 16:38 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 258 seconds] 16:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:45 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:46 < fanquake> achow: just to piss everyone off 16:46 < fanquake> sipa: welcome back to the gitian building world 16:48 < sipa> :) 16:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:49 < bitcoin-git> [bitcoin] dongcarl opened pull request #20619: guix: Quality of life improvements (master...2020-12-guix-fixups) https://github.com/bitcoin/bitcoin/pull/20619 16:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:50 -!- peterrizzo_ [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo_] 16:57 -!- promag_ [~promag@92.250.103.147] has joined #bitcoin-core-dev 16:59 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 260 seconds] 17:01 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 17:01 -!- promag_ [~promag@92.250.103.147] has quit [Read error: Connection reset by peer] 17:06 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev 17:09 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds] 17:18 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev 17:20 -!- twistedline_ [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has quit [Read error: Connection reset by peer] 17:20 -!- twistedline_ [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has joined #bitcoin-core-dev 17:30 -!- peterrizzo_ [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 17:34 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 17:36 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-ucsaxcwppqjkhsjq] has quit [Quit: Connection closed for inactivity] 17:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:46 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/da957cd62ecc...736eb4d80838 17:46 < bitcoin-git> bitcoin/master c5e3e74 Hennadii Stepanov: sync: Improve CheckLastCritical() 17:46 < bitcoin-git> bitcoin/master cb23fe0 Hennadii Stepanov: [skip ci] sync: Check precondition in LEAVE_CRITICAL_SECTION() macro 17:46 < bitcoin-git> bitcoin/master e1e68b6 Hennadii Stepanov: test: Fix inconsistent lock order in wallet_tests/CreateWallet 17:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:46 < bitcoin-git> [bitcoin] fanquake merged pull request #19982: test: Fix inconsistent lock order in wallet_tests/CreateWallet (master...200920-leave-cs) https://github.com/bitcoin/bitcoin/pull/19982 17:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:46 < fanquake> I assume now that we are using cirrus, adding things like [skip ci] to commit messages is pointless ? 17:47 < fanquake> I never really saw the point of doing it anyways 17:47 < andytoshi> travis still runs some lints that check every commit 17:48 < fanquake> Yea. Although hopefully that is going away shortly: #20467 17:48 < gribble> https://github.com/bitcoin/bitcoin/issues/20467 | Move travis linter job to cirrus · Issue #20467 · bitcoin/bitcoin · GitHub 17:49 < fanquake> I think someone else could jump in and take that on if they wanted, given it's been 2 weeks 17:50 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 17:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:57 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 256 seconds] 18:04 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 18:05 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving] 18:17 -!- miketwen_ [~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com] has quit [Ping timeout: 264 seconds] 18:35 < fanquake> Someone could also port the Travis check in the gitian.sigs repo to Cirrus (if we want to keep it). That should be very easy 18:54 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:56 -!- twistedline_ [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has quit [Remote host closed the connection] 18:57 -!- twistedline_ [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has joined #bitcoin-core-dev 18:58 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 19:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 19:14 -!- twistedline_ [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has quit [Ping timeout: 264 seconds] 19:19 -!- twistedline [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has joined #bitcoin-core-dev 19:19 -!- twistedline [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has quit [Changing host] 19:19 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 19:23 -!- peterrizzo_ [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo_] 19:42 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Read error: Connection reset by peer] 19:44 -!- twistedline [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has joined #bitcoin-core-dev 19:44 -!- twistedline [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has quit [Changing host] 19:44 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 20:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 20:02 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection] 20:03 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 20:49 -!- JackSparrow [~JackSparr@s91904426.blix.com] has quit [Remote host closed the connection] 21:09 -!- gac410 [~gac410@178.162.212.214] has joined #bitcoin-core-dev 21:33 -!- ryanofsky [russ@jumpy.yanofsky.org] has quit [Quit: ZNC 1.7.5 - https://znc.in] 21:35 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has quit [Remote host closed the connection] 21:35 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:36 -!- ryanofsky [~russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev 21:39 -!- harding [~quassel@newmail.dtrt.org] has joined #bitcoin-core-dev 22:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 22:01 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 22:05 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:f950:50c:999:2b9d] has joined #bitcoin-core-dev 23:30 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 23:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:f950:50c:999:2b9d] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:40 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds] 23:43 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:f950:50c:999:2b9d] has joined #bitcoin-core-dev 23:46 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev --- Log closed Fri Dec 11 00:00:43 2020