--- Log opened Thu Dec 17 00:00:48 2020
00:05 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1811e488d53b...6f2ca726ce2e
00:06 < bitcoin-git> bitcoin/master 739d390 Dhruv Mehta: ci: Move linter task to cirrus
00:06 < bitcoin-git> bitcoin/master 4045a67 Dhruv Mehta: ci: Use cpu=1 for linter
00:06 < bitcoin-git> bitcoin/master 6f2ca72 MarcoFalke: Merge #20658: ci: Move linter task to cirrus
00:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:07 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20658: ci: Move linter task to cirrus (master...linter-on-cirrus) https://github.com/bitcoin/bitcoin/pull/20658
00:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:28 < jonasschnelli> sipa: ChaCha20::Crypt is the same if I do ChaCha20::Keystream and then manually xor the message with the keystream? I somehow are confused about x0 ^= ReadLE32(m + 0); (since this writes back to the state?)
00:29 < jonasschnelli> I debugged it and it is indeed the same just the x0 ^= confuses me
00:31 < sipa> yes
00:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:35 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20680: ci: Only use credits for pull requests to the main repo (master...2012-ciCredits) https://github.com/bitcoin/bitcoin/pull/20680
00:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:54 -!- instagibbs [~greg@061093103011.ctinets.com] has joined #bitcoin-core-dev
00:55 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:01 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f2ca726ce2e...8452f922d211
01:01 < bitcoin-git> bitcoin/master 5c3eaf9 Fabian Jahr: doc: Add warnings for http interfaces limitations
01:01 < bitcoin-git> bitcoin/master 8452f92 MarcoFalke: Merge #19050: doc: Add warning for rest interface limitation
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:01 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19050: doc: Add warning for rest interface limitation (master...rest_fd) https://github.com/bitcoin/bitcoin/pull/19050
01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:13 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
01:13 -!- muoitran [76c811dd@118.200.17.221] has joined #bitcoin-core-dev
01:21 -!- muoitran [76c811dd@118.200.17.221] has quit [Remote host closed the connection]
01:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
01:26 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.254.151] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:33 -!- raf [d203558e@210.3.85.142] has joined #bitcoin-core-dev
01:33 -!- raf [d203558e@210.3.85.142] has quit [Remote host closed the connection]
01:40 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
01:42 -!- RusAlex [~Chel@unaffiliated/rusalex] has quit [Ping timeout: 240 seconds]
01:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8452f922d211...83abd6b126c2
01:42 < bitcoin-git> bitcoin/master facf5e3 MarcoFalke: ci: Only use credits for pull requests to the main repo
01:42 < bitcoin-git> bitcoin/master 83abd6b MarcoFalke: Merge #20680: ci: Only use credits for pull requests to the main repo
01:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:43 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20680: ci: Only use credits for pull requests to the main repo (master...2012-ciCredits) https://github.com/bitcoin/bitcoin/pull/20680
01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:43 -!- RusAlex [~Chel@unaffiliated/rusalex] has joined #bitcoin-core-dev
01:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:54 < bitcoin-git> [gui] MarcoFalke merged pull request #153: Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format (master...const_max_digits) https://github.com/bitcoin-core/gui/pull/153
01:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/83abd6b126c2...d0e76b5050a2
01:55 < bitcoin-git> bitcoin/master 198fff8 Luke Dashjr: GUI: Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format
01:55 < bitcoin-git> bitcoin/master d0e76b5 MarcoFalke: Merge bitcoin-core/gui#153: Define MAX_DIGITS_BTC for magic number in Bitc...
01:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:59 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
02:05 -!- kexkey [~kexkey@static-198-54-132-94.cust.tzulo.com] has quit [Ping timeout: 268 seconds]
02:11 < wumpus> MarcoFalke: i think we should leave it for 0.21.1
02:11 < wumpus> MarcoFalke: focus on what is really critical for 0.21.0 and just get it out of the door
02:13 < wumpus> if it's a regression it needs to be fixed in a rc, otherwise let's make it wait for 0.21.1
02:23 < wumpus> regarding Qt5 and Qt6 i think we should aim to be compatible with both in the forseeable future
02:24 < hebasto> as Qt4 and Qt5 were?
02:24 < wumpus> the transition period for Qt4/Qt5 was pretty long as well and I don't expect it to be different this time. I don't know how difficult this is in practice though.
02:24 < wumpus> correct!
02:31 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 260 seconds]
02:34 < wumpus> please, if you write md documents (especially install instructions) keep them readable in the terminal; preferably don't use HTML, "Dependency Options" in depends/README.md is hard to read when viewing it in "less" or "vim"
02:37 -!- potato [~Thunderbi@240d:1a:3d4:7d00:e8f9:dc3f:1a8d:3976] has quit [Quit: potato]
02:40 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
02:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:40 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d0e76b5050a2...7ef6b1c51d4a
02:40 < bitcoin-git> bitcoin/master e1765d8 Jon Atack: doc: update tor.md address examples from onion v2 to v3
02:40 < bitcoin-git> bitcoin/master dc8a591 Jon Atack: doc: add tor.md section on how to get tor info via bitcoind
02:40 < bitcoin-git> bitcoin/master a34eceb Jon Atack: doc: update -externalip documentation in tor.md
02:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:41 < bitcoin-git> [bitcoin] laanwj merged pull request #19961: doc: tor.md updates (master...update-tor-md) https://github.com/bitcoin/bitcoin/pull/19961
02:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:42 < wumpus> going to file a PR to reformat it
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:43 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20083: p2p: Disconnect, not discourage, misbehaving NODE_BLOOM peers (master...2010-p2pBloomPeer) https://github.com/bitcoin/bitcoin/pull/20083
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:44 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 260 seconds]
02:50 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
02:53 -!- mrostecki [mrostecki@nat/suse/x-rgficojmxnxsfgtc] has joined #bitcoin-core-dev
02:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:53 < bitcoin-git> [bitcoin] laanwj opened pull request #20681: doc: Convert depends options list from html to markdown (master...2020_12_dependdoc) https://github.com/bitcoin/bitcoin/pull/20681
02:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:00 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ef6b1c51d4a...f0913f2f950c
03:00 < bitcoin-git> bitcoin/master 0c41c10 Suhas Daftuar: doc: Remove shouty enums in net_processing comments
03:00 < bitcoin-git> bitcoin/master f0913f2 Wladimir J. van der Laan: Merge #20677: doc: Remove shouty enums in net_processing comments
03:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:00 < bitcoin-git> [bitcoin] laanwj merged pull request #20677: doc: Remove shouty enums in net_processing comments (master...2020-12-remove-shouty-enums) https://github.com/bitcoin/bitcoin/pull/20677
03:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:03 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:03 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20682: ci: Install missing lint packages (master...2012-testDel) https://github.com/bitcoin/bitcoin/pull/20682
03:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:07 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
03:07 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404] has joined #bitcoin-core-dev
03:08 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 268 seconds]
03:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:10 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0913f2f950c...cfbfd389f6dd
03:10 < bitcoin-git> bitcoin/master 010eed3 Adam Jonas: doc: warn that incoming conns are unlikely when not using default ports
03:10 < bitcoin-git> bitcoin/master cfbfd38 Wladimir J. van der Laan: Merge #20668: doc: warn that incoming conns are unlikely when not using de...
03:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:11 < bitcoin-git> [bitcoin] laanwj merged pull request #20668: doc: warn that incoming conns are unlikely when not using default ports (master...121520-non-standard-port-doc) https://github.com/bitcoin/bitcoin/pull/20668
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:14 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
03:14 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
03:14 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
03:18 -!- Della9Cole [~Della9Col@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:23 -!- Della9Cole [~Della9Col@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
03:35 -!- vincenzopalazzo [~vincent@2001:b07:6474:9d49:7de2:ea26:22ca:4ba0] has joined #bitcoin-core-dev
03:55 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
03:56 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
03:57 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Read error: Connection reset by peer]
04:01 -!- davterra [~davterra@89.45.90.100] has joined #bitcoin-core-dev
04:02 -!- davterra [~davterra@89.45.90.100] has quit [Client Quit]
04:02 -!- davterra [~davterra@89.45.90.100] has joined #bitcoin-core-dev
04:03 -!- davterra [~davterra@89.45.90.100] has quit [Remote host closed the connection]
04:05 -!- davterra [~davterra@89.45.90.100] has joined #bitcoin-core-dev
04:05 -!- davterra [~davterra@89.45.90.100] has quit [Remote host closed the connection]
04:10 -!- davterra [~davterra@86.106.143.148] has joined #bitcoin-core-dev
04:11 -!- davterra [~davterra@86.106.143.148] has quit [Remote host closed the connection]
04:11 -!- davterra [~davterra@86.106.143.148] has joined #bitcoin-core-dev
04:12 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
04:14 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
04:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:17 -!- davterra [~davterra@86.106.143.148] has quit [Remote host closed the connection]
04:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:25 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20683: test: Fix restart node race (master...2012-testNodeStart) https://github.com/bitcoin/bitcoin/pull/20683
04:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:28 < MarcoFalke> Makefile.am:335: warning: .INTERMEDIATE was already defined in condition !BUILD_DARWIN, which is included in condition TRUE ...
04:28 < MarcoFalke> looks like a new warning
04:29 < hebasto> MarcoFalke: ^ testing a fix already
04:30 < wumpus> haven't seen it yet but that doesn't sound good
04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:30 < bitcoin-git> [bitcoin] hebasto opened pull request #20684: build: Define .INTERMEDIATE target once only (master...201217-target) https://github.com/bitcoin/bitcoin/pull/20684
04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:33 -!- davterra [~davterra@86.106.143.174] has joined #bitcoin-core-dev
04:36 -!- davterra [~davterra@86.106.143.174] has quit [Remote host closed the connection]
04:45 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
04:49 < hebasto> wumpus: i'm confused by your https://github.com/bitcoin/bitcoin/pull/20678#issuecomment-747406247 -- did you ack for explicit mention of autoconf?
04:49 < jonasschnelli> Yeah. I guess wumpus ACK was slipped in too fast
04:49 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
04:49 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:50 < bitcoin-git> [bitcoin] vasild opened pull request #20685: Add I2P support using I2P SAM (master...i2p_sam) https://github.com/bitcoin/bitcoin/pull/20685
04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:51 < bitcoin-git> [bitcoin] vasild closed pull request #20254: Add I2P support using statically configured destinations (master...i2p_static) https://github.com/bitcoin/bitcoin/pull/20254
04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:56 < wumpus> hebasto: wait, I misunderstood your commen
04:56 < hebasto> wumpus: sorry for my misleading comment
04:56 < wumpus> np, thanks for mentioning it here, retracted my ACK
04:59 -!- Legousk [~Henkie@178-84-68-9.dynamic.upc.nl] has joined #bitcoin-core-dev
05:00 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:09 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
05:09 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
05:17 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
05:25 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
05:33 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404] has joined #bitcoin-core-dev
05:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:36 -!- vasild_ is now known as vasild
05:37 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404] has quit [Client Quit]
05:38 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
05:44 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:46 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404] has joined #bitcoin-core-dev
05:48 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
05:49 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
05:51 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:52 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:53 -!- instagibbs [~greg@061093103011.ctinets.com] has quit [Ping timeout: 268 seconds]
05:55 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 268 seconds]
05:56 < hebasto> wumpus: MarcoFalke: please remove spam https://github.com/bitcoin/bitcoin/pull/20658#issuecomment-747452862
05:56 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 268 seconds]
05:59 < wumpus> hebasto: done
05:59 -!- instagibbs [~greg@061093103011.ctinets.com] has joined #bitcoin-core-dev
06:02 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
06:06 < hebasto> wumpus: thanks
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:06 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cfbfd389f6dd...af4ce674dafa
06:06 < bitcoin-git> bitcoin/master cc3044c pox: fix misleading comment about call to non-existing function
06:06 < bitcoin-git> bitcoin/master af4ce67 Wladimir J. van der Laan: Merge #20635: fix misleading comment about call to non-existing function
06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:07 < bitcoin-git> [bitcoin] laanwj merged pull request #20635: fix misleading comment about call to non-existing function (master...master) https://github.com/bitcoin/bitcoin/pull/20635
06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/af4ce674dafa...143bd108ed66
06:19 < bitcoin-git> bitcoin/master e1e7a90 Andrew Chow: wallettool: Add dump command
06:19 < bitcoin-git> bitcoin/master a88c320 Andrew Chow: wallettool: Add createfromdump command
06:19 < bitcoin-git> bitcoin/master 23cac24 Andrew Chow: tests: Test bitcoin-wallet dump and createfromdump
06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:20 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19137: wallettool: Add dump and createfromdump commands (master...dumpwalletrecords) https://github.com/bitcoin/bitcoin/pull/19137
06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:23 -!- lontivero [~lontivero@186.183.49.164] has joined #bitcoin-core-dev
06:24 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
06:26 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
06:38 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
06:41 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
06:41 < wumpus> I'm testing #18077, I have NAT-PMP enabled on my router but get "natpmp: The gateway does not support NAT-PMP."
06:41 < gribble> https://github.com/bitcoin/bitcoin/issues/18077 | net: Add NAT-PMP port forwarding support by hebasto · Pull Request #18077 · bitcoin/bitcoin · GitHub
06:41 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
06:42 < hebasto> which router?
06:42 < wumpus> my policy allows mapping high ports 1024-65535, denies the rest, but this should be enough for bitcoin
06:42 < wumpus> Turris Omnia
06:42 < wumpus> openWRT-ish
06:43 < hebasto> what in openwrt log?
06:43 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 264 seconds]
06:45 < wumpus> I don't see anything related in the log, will try if I can enable verbose logging somehow
06:46 < wumpus> OOHH never mind I think I have it
06:46 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
06:47 < hebasto> natpmp connection?
06:49 < jonasschnelli> Review bag for https://github.com/bitcoin/bitcoin/pull/20273 (concept ACK/NACK). Helps me to decide if I should drag that PR along. I really like the functionality of nested commands in CLI.
06:50 < wumpus> unfortunately still not, but found one setting that was blocking it from working
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [gui] goums opened pull request #154: qt: Colorize icons on macOS for Dark mode support (master...macos_color_icons) https://github.com/bitcoin-core/gui/pull/154
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:54 < wumpus> in any case it's probably not a problem with your code; i don't see anything upnp related in the log, for some reason it doesn't seem to be launching
07:02 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection]
07:03 -!- miketwenty1 [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has joined #bitcoin-core-dev
07:05 < wumpus> was this problem: https://forum.turris.cz/t/upnp-server-not-running/9544/2
07:06 < wumpus> 2020-12-17T15:06:10Z natpmp: Port mapping successful. External address = x.x.x.x:18444
07:06 < wumpus> nice!
07:07 < hebasto> \o/
07:08 < vasild> what a strange address, is this some porn site?
07:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:11 < bitcoin-git> [bitcoin] lontivero closed pull request #20662: Allow setting I2P addresses (master...set-i2p) https://github.com/bitcoin/bitcoin/pull/20662
07:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:14 < wumpus> heh :)
07:16 -!- lontivero [~lontivero@186.183.49.164] has quit [Ping timeout: 240 seconds]
07:22 < wumpus> besides the router issue I first had -nolisten enabled, so it was forwarding the port but it wasn't actually open :-)
07:29 -!- lontivero [~lontivero@186.183.49.4] has joined #bitcoin-core-dev
07:45 < wumpus> it's slightly unexpected that natpmp.h doesn't have constants for OK return values so we need to use hardcoded magic values like '12'
07:45 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
08:01 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds]
08:01 -!- kexkey [~kexkey@static-198-54-132-110.cust.tzulo.com] has joined #bitcoin-core-dev
08:04 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 268 seconds]
08:04 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
08:20 -!- miketwenty1 [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has quit [Remote host closed the connection]
08:22 -!- miketwen_ [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has joined #bitcoin-core-dev
08:31 < wumpus> #proposedmeetingtopic rc4 status, macos codesigning fix
08:31 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
08:32 < wumpus> #proposedmeetingtopic no meetings 2020-12-24 & 2020-12-31
08:39 < vasild> https://calendar.google.com/calendar/u/0/embed?src=11pqvdgpd99nlibf9ba861vu8s@group.calendar.google.com&ctz=Europe/Vienna -- this shows p2p meeting on Dec 29, needs to be updated (but I cant)
08:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
08:52 < dhruvm> I am trying to run a full node with everything else blocked using iptables: https://pastebin.com/rre3eQQR With that setup, bitcoind is not able to establish any peers (10k+ in peers.dat). What am I missing?
08:56 -!- miketwen_ [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has quit [Remote host closed the connection]
09:11 -!- miketwenty1 [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has joined #bitcoin-core-dev
09:13 < wumpus> vasild: is that my calender? will take a look
09:13 < vasild> wumpus: I don't know, it is linked from here: https://bitcoincore.org/en/meetings/ "Meeting times are also listed on this Google calendar"
09:15 < wumpus> vasild: i've deleted it
09:16 < vasild> Thanks!
09:16 < wumpus> there's still a bitcoin core wallet meeting on jan 1, probably also not going to be?
09:16 < vasild> yeah :)
09:25 -!- Kade20Goldner [~Kade20Gol@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
09:30 -!- Kade20Goldner [~Kade20Gol@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
09:37 -!- belcher_ is now known as belcher
09:37 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:46 -!- Guest58575 [~ds@185.204.1.185] has quit [Remote host closed the connection]
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:50 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/143bd108ed66...190d3d8a75d2
09:50 < bitcoin-git> bitcoin/master 7b6887e Wladimir J. van der Laan: doc: Convert depends options list from html to markdown
09:50 < bitcoin-git> bitcoin/master 190d3d8 Wladimir J. van der Laan: Merge #20681: doc: Convert depends options list from html to markdown
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:50 < bitcoin-git> [bitcoin] laanwj merged pull request #20681: doc: Convert depends options list from html to markdown (master...2020_12_dependdoc) https://github.com/bitcoin/bitcoin/pull/20681
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:56 -!- lontivero [~lontivero@186.183.49.4] has quit [Ping timeout: 260 seconds]
10:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:00 < bitcoin-git> [bitcoin] sdaftuar closed pull request #20676: Replace m_tx_relay/nullptr checks in net_processing.cpp (master...2020-12-refactor-m_tx_relay) https://github.com/bitcoin/bitcoin/pull/20676
10:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:07 -!- pleia21 [~pleia2@185.103.96.147] has joined #bitcoin-core-dev
10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:07 < bitcoin-git> [bitcoin] jonatack opened pull request #20686: fuzz, refactor: replace CNode code with fuzz/util.h::ConsumeNode() (master...net-fuzzer-ConsumeNode) https://github.com/bitcoin/bitcoin/pull/20686
10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:14 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
10:15 -!- miketwen_ [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
10:16 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
10:17 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
10:18 -!- miketwe__ [~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com] has joined #bitcoin-core-dev
10:18 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
10:18 -!- miketwenty1 [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds]
10:19 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
10:21 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:21 -!- miketwen_ [~miketwent@136.55.84.49] has quit [Ping timeout: 260 seconds]
10:26 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
10:29 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Ping timeout: 260 seconds]
10:30 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
10:31 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Client Quit]
10:36 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
10:37 -!- lontivero [~lontivero@186.183.48.62] has joined #bitcoin-core-dev
10:40 -!- dkrm [~dkrm@2001:41d0:8:3f7b::1] has quit [Remote host closed the connection]
10:41 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
10:41 -!- dkrm [~dkrm@2001:41d0:8:3f7b::1] has joined #bitcoin-core-dev
10:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:43 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20687: wallet: Add missing check for -descriptors wallet tool option (master...2012-walletToolSqlite) https://github.com/bitcoin/bitcoin/pull/20687
10:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:44 -!- lontivero [~lontivero@186.183.48.62] has quit [Ping timeout: 268 seconds]
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/190d3d8a75d2...b7136c11ab64
10:48 < bitcoin-git> bitcoin/master 23d8f34 Jon Atack: fuzz: replace CNode code with fuzz/util.h::ConsumeNode()
10:48 < bitcoin-git> bitcoin/master b7136c1 MarcoFalke: Merge #20686: fuzz, refactor: replace CNode code with fuzz/util.h::Consume...
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:48 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20686: fuzz, refactor: replace CNode code with fuzz/util.h::ConsumeNode() (master...net-fuzzer-ConsumeNode) https://github.com/bitcoin/bitcoin/pull/20686
10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:52 < bitcoin-git> [bitcoin] mjdietzx opened pull request #20688: test: run mempool_compatibility.py even with wallet disabled (master...mempool-compatibility-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20688
10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:58 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-jmnycirzwyuntfua] has joined #bitcoin-core-dev
11:00 < wumpus> #startmeeting
11:00 < core-meetingbot> Meeting started Thu Dec 17 19:00:21 2020 UTC.  The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
11:00 < core-meetingbot> Available commands: action commands idea info link nick
11:00 < jonasschnelli> hi
11:00 < hebasto> hi
11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:00 < bitcoin-git> [bitcoin] theStack opened pull request #20689: contrib: replace binary verification script verify.sh with python rewrite (master...202012-contrib-replace-verify-binaries-script-with-python) https://github.com/bitcoin/bitcoin/pull/20689
11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:00 < wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
11:00 < wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
11:00 < jonatack> hi
11:00 < sdaftuar> hi
11:00 < achow101> hi
11:01 < provoostenator> hi
11:01 < fjahr> hi
11:01 < jamesob> hi
11:01 < wumpus> one proposed meeting for this week: rc4 status, macos codesigning fix (wumpus)
11:01 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
11:02 < wumpus> the other is more a PSA: i don't think it makes sense to do meetings 2020-12-24 & 2020-12-31, so the next one will be in 2021!
11:02 < jonasschnelli> agree
11:02 < meshcollider> hi
11:02 < achow101> ack
11:03 < wumpus> #topic High priority for review
11:03 < core-meetingbot> topic: High priority for review
11:03 < sipa> hi
11:03 < jonasschnelli> I have added #15946
11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
11:03 < jonasschnelli> (to hiprio)
11:03 < wumpus> https://github.com/bitcoin/bitcoin/projects/8  10 blockers, 2 chasing concept ACK
11:03 < wumpus> jonasschnelli: ok
11:04 < wumpus> otherwise, anything to add/remove or that is ready for merge?
11:04 < jonatack> can drop #20546, i'll likely break it down into smaller ones
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
11:04 < jonasschnelli> #15946 is basically an lnd stopper for pruned peers
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
11:06 < dongcarl> hi
11:06 -!- lontivero [~lontivero@186.141.225.115] has joined #bitcoin-core-dev
11:06 < wumpus> jonasschnelli: ok, removed
11:06 < jonatack> jamesob: fjahr: reviewing your hi-prios atm 
11:06 < wumpus> I mean jonatack*
11:06 < sdaftuar> #14053 -- is that still chasing concept ACK? i haven't followed the discussion but i htink it's been in that state for a long time
11:06 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Quit: ZNC 1.8.1 - https://znc.in]
11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14053 | Add address-based index (attempt 4?) by marcinja · Pull Request #14053 · bitcoin/bitcoin · GitHub
11:07 < wumpus> I think we can drop that
11:09 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
11:09 < wumpus> there's no discussion there by any actual contributors to the project
11:09 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
11:09 < sdaftuar> it seems it had many concept acks early on (2 years ago)
11:10 < fjahr> it has a lot of interest from the wider community
11:10 < jonatack> iirc it's desired by the community but unsustainable long-term (haven't looked in a long time but we did a review club on it)
11:10 < wumpus> I still think an address index over the entire block chain is bad idea and becomes a worse idea the more the thing grows, software that relies on that is broken
11:10 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
11:11 < sdaftuar> i thought it was just an index on the utxo set.  it's indexing the whole blockchain?
11:11 < sipa> yes
11:11 < sdaftuar> ohh i see
11:11 < wumpus> it's the whole block chain I think? utxo index would make more sense to me
11:11 < fjahr> If people are against it, they should NACK it
11:11 < jonasschnelli> the eralier attemps where just for the utxo set, right?
11:11 < wumpus> fjahr: I have nacked similar things for years, if people keep digigng it up I lose the energy for that
11:12 < jonasschnelli> a complete index seems out of scope IMO
11:13 < jonatack> i soft-nacked it https://github.com/bitcoin/bitcoin/pull/14053#pullrequestreview-340041837
11:13 < wumpus> yes, there have been attemps for indexes over only the UTXO set, but they didn't make it in either for some reason (dunno why, maybe the author just gave up)
11:13 < sipa> it's a difficult question... (IMO) people shouldn't be building infrastructure that relies on having such an index, but if they're going to do it anyway, it's perhaps not any worse to have in bitcoin core
11:13 < MarcoFalke> It is no worse than -txindex
11:13 < sipa> txindex is terrible too
11:13 < sipa> but we can't just drop it
11:13 < wumpus> yes, it's just as worse as txindex
11:14 < fjahr> wumpus: understandable, maybe there should be some kind of "permanent concept NACK" if enough people agree so nobody puts effort into putting into core anymore, maybe there is a way there for a project that works closely with core
11:14 < aj> isn't that just a good reason for both addrindex and txindex to be optional and default off?
11:14 < wumpus> fjahr: I mean I have no interest in blocking something if people really want it, but I'm not going to be part of it
11:14 < wumpus> fjahr: and apparently a lot of contributors think like that
11:14 < jonasschnelli> #20664 is something that allows (very) slow address scanning at a fraction of disk space
11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
11:15 < jonasschnelli> (with blockfilters)
11:15 < sipa> aj: yeah, maybe
11:15 < MarcoFalke> I won't use addrindex myself, but the whole point of ./src/indexes/ was to make it easier to add (crappy) indexes
11:15 < sipa> it's not like our resistance (or reluctance) to add something like that has stopped people from using it
11:16 < jonasschnelli> Sure. But there are dedicated projects like Electrs doing it on a pretty good level
11:16 < sipa> yes
11:16 < jonasschnelli> Which is basically project modularization
11:16 < jonasschnelli> They can use their optimized DB (rocksDB in that case)
11:16 < wumpus> yeah https://github.com/bitcoin/bitcoin/pull/14053#issuecomment-744015971
11:16 < sipa> MarcoFalke does have a point
11:17 < jonasschnelli> If we are going to merge it, people will build on top of it and maintenance/traffic goes into our project
11:17 < wumpus> no need to compete with dedicated projects whose whole point is to optimize this
11:17 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
11:17 < wumpus> bitcoin core is not a blob that needs to absorb the entire bitcoin ecosystem
11:17 < MarcoFalke> It would be nice if indexes could be attached to bitcoin core at runtime (external modules), but we are not there yet
11:17 < wumpus> jonasschnelli: indeed
11:17 < jonasschnelli> Adding a complete address index is against the project modularization.
11:17 < wumpus> it's scope creep
11:17 < jonasschnelli> I think adding more interfaces to allow "better" interaction would be the way to go
11:17 < sipa> at least the argument of it being invasive validation code changes doesn't apply anymore
11:17 < wumpus> and there are already solutions for it
11:18 < MarcoFalke> bitcoin-tx is scope creep as well (playing devils advocate)
11:18 < wumpus> MarcoFalke: well, external programs exist for it, it's supposedly possible
11:18 < jonasschnelli> I also see (and feel) the point that it would be "handy" to have it "in one box". But long term, it might a bad idea
11:18 < MarcoFalke> https://github.com/bitcoin-core/btcdeb is also scope creep
11:19 < wumpus> well then people could make a bitcoin core + electrs bundle, for example
11:19 < wumpus> there's lots of systems like docker that allow shipping multiple software that works together in one box
11:19 < sipa> my primary objection is "nobody should be using this"
11:19 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
11:20 < wumpus> MarcoFalke: that's literally a separate repository though :)
11:20 < sipa> but if people are going to use this anyway, and it can be added without being too invasive, and being optional... from a code maintenance perspective i don't have that much problems with it
11:20 < jonasschnelli> I guess there are reasons to use it,... if your backend servers hundreds of wallets and if you want instance seed-backup restores
11:20 < MarcoFalke> It is still a repo in our org ;)
11:20 < jonasschnelli> *instant
11:20 < wumpus> MarcoFalke: I don't have a problem with it being in the org
11:20 < jonasschnelli> Yes.
11:20 < wumpus> just not everything needs to be part of the bitcoin core repostiory
11:21 < jonasschnelli> The address index could be outside our repo and I think it would be fine
11:21 < jonasschnelli> Maybe similar like the guy... but ideally process separated from the beginning.
11:21 < jonasschnelli> *GUI
11:21 < wumpus> let's fork electrs into bitcoin-core then :)
11:21 < jonasschnelli> :/
11:22 < aj> txindex is slightly helpful for speeding up our own RPCs (getrawtransaction), i don't think there's a similar rationale for needing an integrated addrindex?
11:23 < sipa> getrawtransactionsbyaddress, an RPC that very unhelpfully always reports the "RPC does not exist" error right now
11:24 < MarcoFalke> how does txindex speed things up?
11:24 < jonasschnelli> why is an index for the utxo set not enoght?
11:24 < jonasschnelli> If you want the spent history, use blockfilters
11:26 < sipa> i commented
11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:27 < bitcoin-git> [bitcoin] sdaftuar opened pull request #20690: Clean up logging of outbound connection type (master...2020-12-clean-up-outbound-logging) https://github.com/bitcoin/bitcoin/pull/20690
11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:27 < aj> MarcoFalke: compared to looping over every historical block and checking blockfilters, it's O(log(txs)) vs O(blocks)
11:27 < wumpus> it will just be the same discussion again that's been done many times over the years i expect
11:28 < jamesob> jonatack: thanks!
11:28 < jamesob> I have some feedback from wumpus to address I think
11:28 < fjahr> jonasschnelli: I think such a combo is worth exploring
11:29 < jonasschnelli> fjahr: look at #20664 (for performance analysis)
11:29 < gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
11:29 < sipa> so when rc4 topic?
11:29 < fjahr> jonasschnelli: will do
11:30 < wumpus> #topic rc4 status, macos codesigning fix (wumpus)
11:30 < core-meetingbot> topic: rc4 status, macos codesigning fix (wumpus)
11:31 < wumpus> I saw there are two parellel workarounds for the rc3 macos signing issue
11:31 < sipa> so we have two possible (temporary?) fixes for macos codesigning, #20638 and #20644
11:31 < gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
11:31 < gribble> https://github.com/bitcoin/bitcoin/issues/20644 | Add patch to make codesign_allocate compatible with Apples by sipa · Pull Request #20644 · bitcoin/bitcoin · GitHub
11:31 < wumpus> we'll probably want to choose one
11:31 < sipa> i think both are fine
11:31 < sipa> and if achow101's python codesigner works, all of this will be obsolete
11:32 < sipa> s/if/when/ - no pressure
11:32 < jonasschnelli> heh
11:32 < wumpus> but that's more of a long-run solution
11:32 < achow101> it's coming along slowly
11:32 < jonasschnelli> achow101: no pressure,.. but will it be ready for an rc4? :)
11:32 < achow101> I might have a PoC tomorrow
11:33 < jonasschnelli> Maybe for 0.21 we should use the existing solutions and use 0.22 (+backport) for achow101 signing tool
11:33 < wumpus> I don't think it's a good idea to introduce something like that between rcs
11:33 < sipa> yeah, not really relevant in this discussion; we can just pick one; my PR makes our codesign compatible with Apple's (to the extent that we know, but it can always change); achow's works around the issue (by predicting some things the Apple code will do)
11:33 < sipa> jonasschnelli: seems reasonable
11:33 < wumpus> unless there is no other workable option, of course
11:33 < jonasschnelli> sipa's PR is an easier fix and maybe less risky?
11:33 < jonasschnelli> (if we going to drop it anyways)
11:34 < achow101> I think sipa's PR potentially has other side effects that we haven't discovered
11:34 < sipa> well, the signature validates
11:34 < achow101> since it modifies cctools and we use more than just codesign_allocate in it
11:34 < jonasschnelli> sipa: it only needs to work for rc4 and final release
11:34 < sipa> hmm, do we?
11:34 < jonasschnelli> (oh... and maybe for 0.20.2)
11:34 < sipa> what else from cctools do we use?
11:35 < achow101> pagestuff, but it doesn't seem to be effected
11:35 < dongcarl> I believe we use it as our binutils
11:36 < dongcarl> For macOS targets
11:36 < sipa> the changed function only affects codesign_allocate, lipo, bitcode_strip, and segedit
11:36 < achow101> I thought we used some of the tools for building but I'm not sure
11:36 < sipa> anyway, no strong feelings
11:36 < dongcarl> I don't think we use any of the other ones sipa just listed, need to double check tho
11:36 < sipa> and no point spending much time on this
11:37 < achow101> well, at least during testing we didn't find any other problems, so it's probably fine
11:39 < wumpus> ok
11:39 < jonasschnelli> I propose to merge #20644 and do rc4 and 0.20.2rc1. Then wait for achow101 signing tool to have a stable long term fix
11:39 < gribble> https://github.com/bitcoin/bitcoin/issues/20644 | Add patch to make codesign_allocate compatible with Apples by sipa · Pull Request #20644 · bitcoin/bitcoin · GitHub
11:40 < jonasschnelli> (then revert 20644)
11:40 < wumpus> so let's try merging sipa's patch and do rc4, if that runs into unexpected issues, try the other one?
11:40 < jonasschnelli> sure
11:40 < achow101> ack
11:40 < jonasschnelli> ack
11:40 < sipa> also #20646 in rc4 or not?
11:40 < gribble> https://github.com/bitcoin/bitcoin/issues/20646 | p2p: ignore post-verack sendaddrv2 instead of disconnecting by jonatack · Pull Request #20646 · bitcoin/bitcoin · GitHub
11:40 < sipa> as pointed out, it makes little sense if it doesn't go in 0.21
11:40 < wumpus> sipa: I don't think people even agree about doing it
11:41 -!- proofofkeags [~proofofke@2601:280:c280:e500:7ed6:f476:4ff8:2b87] has joined #bitcoin-core-dev
11:42 < sipa> yeah
11:42 < aj> it has three acks and a +/- 0?
11:42 < wumpus> my ACK is more of a 'I don't disagree with doing this and the code change looks correct'
11:43 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
11:44 < luke-jr> .
11:45 < MarcoFalke> ...
11:45 < aj> i don't think i have anything to add that's not already in the pr
11:46 < wumpus> same
11:46 < MarcoFalke> someone should flip a coin
11:46 < wumpus> if we're not sure it's better to err on the side of not making a code change
11:47 < aj> Jackielove4u spend 2h the other night debugging test failures because of it, likewise it broke syncing signet, i don't really see why this is a coin toss
11:47 < wumpus> especially if it's a merge-and-rush-into-rc4-last-minute thing
11:48 < sipa> aj: ah, other report of someone hit by it?
11:49 < aj> sipa: had bitcoin-qt and bitcoind refusing to connect, didn't realise bitcoin-qt was still rc2
11:49 < jonatack> i'm ambivalent, but it seems safer to ignore instead of disconnect if we're in doubt. the signet thing, and also a year ago we had to pull a release
11:49 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
11:49 < jonatack> and anything else we haven't hit related to it
11:50 < wumpus> 0.21.0 has had many of those 'we need to decide this last minute' and it doesn't make me comfortable
11:50 < MarcoFalke> The signet sync is already fixed, so merging the pull won't change that
11:50 < jonatack> wumpus: i empathize
11:50 < aj> wumpus: there were a lot of big merges just before freeze
11:51 < wumpus> MarcoFalke: great!
11:51 < luke-jr> maybe we need more time between freeze and rc1? (though I dislike the duration)
11:52 < luke-jr> perhaps branch at freeze and tag rc1 weeks afterward?
11:52 < wumpus> that's just more backporting work
11:52 < MarcoFalke> luke-jr: That'd mean too much work backporting
11:52 < jonasschnelli> luke-jr: most stuff appears in rcs.. :/
11:52 < MarcoFalke> Also, most rc issues are build system issues
11:52 < wumpus> jonasschnelli: bugs appearing and fixed in rcs is completely normal and expected, what bothers me is these kind of last minute protocol handling changes
11:53 < MarcoFalke> So you won't find them before the tag
11:53 < jonasschnelli> wumpus: indeed.
11:53 < jonasschnelli> Although, ignoring them is also no option
11:53 < wumpus> jonasschnelli: well if MarcoFalke says the signet sync issue is fixed
11:53 < jonasschnelli> MarcoFalke: good point
11:53 < sipa> well it's fixed for people who update
11:54 < sipa> no?
11:54 < sipa> that was already the case
11:54 < aj> the original issue was people running rc3 couldn't sync from the non-tor seed node
11:54 < MarcoFalke> sipa: The seed node was on rc2, so a user updating to rc3 *broke* it
11:54 < sipa> ah i see
11:54 < sipa> ok, fair point
11:55 < MarcoFalke> *pre-rc2 (not sure if it was actually rc2)
11:55 < aj> that node is now updated, so now anyone running rc2 and earlier can't sync from it instead
11:55 < MarcoFalke> aj: Correct
11:55 < aj> i think the seed node was a previous version of #19937
11:55 < gribble> https://github.com/bitcoin/bitcoin/issues/19937 | signet mining utility by ajtowns · Pull Request #19937 · bitcoin/bitcoin · GitHub
11:55 < sipa> so it's not really signet-specific anymore... the question is just whether gratuitous disconnection of existing old nodes is worth slightly better observability of people implementing the protocol incorrectly
11:55 < MarcoFalke> aj: Though, that seems like a feature (telling people to upgrade from non-supported versions)
11:56 < aj> MarcoFalke: telling people to upgrade sure, but this is just "it fails for no apparent reason"
11:56 < wumpus> there isn't any released node that will be disconnected right?
11:56 < sipa> wumpus: correct
11:57 < wumpus> I mean if you implement the ignoring someone might spent hours debugging why addrv2 doesn't work
11:57 < sipa> it was affecting signet disproportionally because of course all signet nodes were running pre-release code
11:57 < wumpus> sometimes I wish we still had the reject message
11:57 < MarcoFalke> the reject message was replaced by -debug=net
11:58 < wumpus> it could send an error to the peer before disconnecting, or in general when not accepting it
11:58 < sipa> wumpus: maybe, but if they're trying to make it work is "why am i getting addr and not addrv2?" really that different from "why am i being disconnected?"
11:58 < aj> it would have been nice if there was this much resistance to #20564 :-/
11:58 < gribble> https://github.com/bitcoin/bitcoin/issues/20564 | Dont send sendaddrv2 to pre-70016 software, and send before verack by sipa · Pull Request #20564 · bitcoin/bitcoin · GitHub
11:58 < sipa> aj: later and later in the process, more and more resistance...
11:58 < wumpus> aj: that was also a reluctant ACK for me
11:58 < luke-jr> aj: test != mainnet
12:00 < wumpus> but that was about mainnet software, and actual releases of alternative clients
12:00 < aj> sipa: pretty easy to have a BCLog::NET debug message of either "Ignoring SENDADDRV2 received after VERACK" or "SENDADDRV2 received after VERACK; disconnecting" -- we have neither of those atm, also for WTXIRELAY
12:00 < sipa> aj: yeah, that would be a good idea
12:00 < wumpus> yes, would make sense to add that
12:01 < aj> i have a patch to add it, but was waiting for the sendaddrv2 to get fixed (or, i guess, nacked)
12:02 < wumpus> it's time to end the meeting
12:02 < jonatack> disconnection was added pretty late in the 20564 review process
12:02 < aj> luke-jr: i guess i don't really agree. the whole point of a test net is to catch breakage first; if you catch breakage on the testnet and then go "oh, it's just broken on the testnet, it'll be fine on mainnet" that kind of defeats the purpose imo
12:02 < jonatack> (i didn't disagree with it, just observing)
12:03 < wumpus> #endmeeting
12:03 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:03 < core-meetingbot> Meeting ended Thu Dec 17 20:03:03 2020 UTC.  
12:03 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-17-19.00.moin.txt
12:03 < jonasschnelli> \o
12:03 < luke-jr> aj: not when the breakage is triaged to not affect mainnet
12:03 < aj> luke-jr: Jackiewhatever's problems were on mainnet, aiui
12:03 < sipa> it affects mainnet in exactly the same way, just proportionally less badly
12:04 < wumpus> i honestly don't know either but changing the behavior from disconnect to ignore for a temporary signet issue which is already fixed just feels redundant to me, I agree with jnewbery there
12:04 < wumpus> it's not even a temporary workaround
12:04 < MarcoFalke> jup, this would be permanent
12:04 < MarcoFalke> [20:55] <sipa> so it's not really signet-specific anymore... the question is just whether gratuitous disconnection of existing old nodes is worth slightly better observability of people implementing the protocol incorrectly
12:04 < jonatack> wumpus: right, it's not about fixing signet, nor temporary 
12:05 < aj> why would it be permanent?
12:05 < aj> if disconnecting now is okay, ignoring now and disconnecting in the future is also okay
12:05 < wumpus> so in the long term observability of implementing the protocol incorrectly is probably the more important concern
12:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:06 < bitcoin-git> [bitcoin] hebasto opened pull request #20691: ci, doc: Travis CI features and mentions cleanup (master...201217-travis) https://github.com/bitcoin/bitcoin/pull/20691
12:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:08 < bitcoin-git> [bitcoin] hebasto closed pull request #20357: ci: Use travis_fold on Travis CI only (master...201109-travis) https://github.com/bitcoin/bitcoin/pull/20357
12:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:08 < aj> wumpus: logging that you're ignoring the message because it's out of order seems to capture that?
12:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
12:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:09 < jonatack> aj: yes, i like that
12:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:11 < wumpus> aj: yes, though less clearly, the peer being disconnected would prompt an investigation immediately
12:12 < wumpus> I agree it needs to be logged whether disconnecting or not
12:13 < aj> wumpus: i'm not sure that's true; there's plenty of old nodes on mainnet that the peer would connect to; if you're paying enough attention to realise you're not connected to any 0.21 nodes, you're probably also paying enough attention to realise you're not getting any addrv2 info
12:15 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:15 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
12:15 < wumpus> there's also the consistency argument, why would wtxid disconnect you but not sendaddrv2
12:16 < wumpus> the main reason that I was in favor of changing sendaddrv2 to be sent between version and verack in the first place is because it could be handled the same as other messages
12:17 < aj> wumpus: because wtxid's spec didn't change the way sendaddrv2 did
12:17 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Client Quit]
12:17 < wumpus> bitcoin core is clearly the only client implementing sendaddrv2
12:17 < aj> wumpus: wtxid gets to do it because there was no cost and a slight benefit; sendaddrv2 has a slight cost so shouldn't
12:18 < wumpus> for now at least
12:18 < sipa> there is another difference: ignoring a sendaddrv2 doesn't violate the BIP; ignoring a wtxidrelay does
12:18 < aj> wumpus: though i'd much rather wtxid not do it either if the alternative is "it's okay to break our own software if it didn't make it into a release"
12:19 < wumpus> so there was no reason changing the spec was problematic, if it was, then we wouldn't haev done the last minute change in the first place, and heck may be that would have been better, I'm so tired ofthis
12:21 < wumpus> sendaddrv2 was only (in the old version) in the master and a pre-release for a short time, if that means we need to support that implemenation forever that would be kind of bad
12:22 < aj> the PR already isn't supporting it, it's just not disconnecting it either
12:23 < MarcoFalke> aj: If it is not permanent, how would you decide when to revert it back to disconnect?
12:23 < aj> you could add an `if (GetTime() > 1623961389) fDisconnect = true;` now if you wanted, or add it back later. but the benefit of disconnecting versus just putting a log message seems super trivial
12:24 < Jackielove4u> aj: 21:03:56 <aj> luke-jr: Jackiewhatever's problems were on mainnet, aiui
12:24 < Jackielove4u> my problems were on mainnet AND testnet
12:24 < Jackielove4u> however we can drop that PR
12:24 < luke-jr> we ignore other invalid messages, I'm not sure why it's preferable to disconnect this one
12:25 < aj> MarcoFalke: i'd guess when 0.21.1 is out and there are almost no 0.20.99 and perhaps 21.99 nodes on the network for objective measures; 6-12 months after the last unreleased code that used it for hand-wavey
12:25 < Jackielove4u> wumpus: 20:56:20 <wumpus> there isn't any released node that will be disconnected right?
12:25 < Jackielove4u> this is correct
12:27 < aj> MarcoFalke: if it was timebased you could make that decision today by sticking the GetTime() comparison in, but i don't see any reason why you'd need to make that decision now
12:29 < wumpus> jonasschnelli: it looks like you added #15946 to high prio for review but didn't move it to any column, I guess it should be in "blockers"?
12:29 < gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
12:29 < jonasschnelli> oh. yes
12:29 < wumpus> ok done
12:29 < jonasschnelli> thanks!
12:31 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:34 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:35 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7136c11ab64...816314ef0f7b
12:35 < bitcoin-git> bitcoin/master a4118c6 Pieter Wuille: Add patch to make codesign_allocate compatible with Apple's
12:35 < bitcoin-git> bitcoin/master 816314e Wladimir J. van der Laan: Merge #20644: Add patch to make codesign_allocate compatible with Apple's
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:35 < bitcoin-git> [bitcoin] laanwj merged pull request #20644: Add patch to make codesign_allocate compatible with Apple's (master...202012_codesign_allocate_segalign) https://github.com/bitcoin/bitcoin/pull/20644
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:36 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
12:39 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
12:41 < MarcoFalke> Backported that to #20669 
12:41 < gribble> https://github.com/bitcoin/bitcoin/issues/20669 | [0.21] final rc4 backports by MarcoFalke · Pull Request #20669 · bitcoin/bitcoin · GitHub
12:44 < wumpus> thanks so all that blocks rc4 is a decision on #20646 now
12:44 < gribble> https://github.com/bitcoin/bitcoin/issues/20646 | p2p: ignore post-verack sendaddrv2 instead of disconnecting by jonatack · Pull Request #20646 · bitcoin/bitcoin · GitHub
12:45 -!- Pavlenex [~Thunderbi@178.220.45.157] has joined #bitcoin-core-dev
12:46 < jonatack> gah, i'm really sorry
12:46  * jonatack contemplates moving to siberia
12:46 -!- Pavlenex [~Thunderbi@178.220.45.157] has quit [Client Quit]
12:47 < aj> jonatack: afaik, they have irc and access to github in siberia
12:47 < wumpus> heh i feel the same way often
12:48 < jonatack> heh, teheran then
12:49 < sipa> joking aside, going on vacation to places without decent internet access has helped me relax...
12:51 < hebasto> some places in Siberia were science centers...
12:54 < jonatack> hebasto: i spent a winter in (near) siberia actually, the former prisoners were the intelligentsia of the day
12:54 < sipa> jonatack: cool (literally and figuratively)
12:54 < jonatack> was in the area between perm, magnitogorsk, yekaterinburg & irkutsk
12:55 < hebasto> it's quite a big region
12:55 < jonatack> yes
12:56 < jonatack> (if we add aj's logging, 20646 isn't the last PR)
12:56 < sipa> jonatack: i know some of those names from the boardgame "risk"!
12:57 < jonatack> sipa: maybe next coredev?
12:57 < hebasto> hehe
12:57 < sipa> jonatack: ehm... perm <-> irkutsk is 3000 km
12:57 < sipa> do i have that right?
12:58 -!- Legousk [~Henkie@178-84-68-9.dynamic.upc.nl] has quit [Ping timeout: 264 seconds]
12:59 < hebasto> sipa: correct
12:59 < jonatack> right, perm isn't siberia yet...yeah it's big, flying between the cities the tupolevs took off and landed in a foot of snow, the pilots flew wearing only socks, shoes off in the cockpit
12:59 < wumpus> jonatack: fine with including that but in contrast to 20644, logging isn't urgent to get into a rc
12:59 < wumpus> 20646
13:00 < aj> logging's useful for master, not rc
13:00 < sipa> yeah, someone testing protocol support against bitcoin core will likely use master anyway
13:00 < sipa> or the latest release at least; not random old nodes on the network
13:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:03 < bitcoin-git> [bitcoin] mjdietzx opened pull request #20692: test: run mempool_resurrect.py even with wallet disabled (master...mempool-resurrect-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20692
13:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:13 < jonatack> makes sense
13:20 -!- lontivero [~lontivero@186.141.225.115] has quit [Read error: Connection reset by peer]
13:24 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
13:26 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
13:49 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #bitcoin-core-dev
14:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:26 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving]
14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:31 < bitcoin-git> [bitcoin] glowang closed pull request #19297: [test] WIP: rewrite generate() in test_node to gain determinism in test data (master...2020/05/21/rewrite_generate_in_testnode) https://github.com/bitcoin/bitcoin/pull/19297
14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:47 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
15:04 -!- lontivero [~lontivero@186.183.49.45] has joined #bitcoin-core-dev
15:05 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:24 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: No Ping reply in 180 seconds.]
15:26 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
15:27 -!- miketwe__ [~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com] has quit [Remote host closed the connection]
15:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:37 < bitcoin-git> [gui] hebasto opened pull request #155: Fix checkbox layout in Create Wallet dialog (master...201218-i3) https://github.com/bitcoin-core/gui/pull/155
15:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:37 -!- miketwenty1 [~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com] has joined #bitcoin-core-dev
15:41 < jeremyrubin> if anyone is curious to mess around, I put a CTV + Taproot signet up
15:41 < jeremyrubin> signetchallenge=512102946e8ba8eca597194e7ed90377d9bbebc5d17a9609ab3e35e706612ee882759351ae
15:42 < jeremyrubin> addnode 50.18.75.225:38333 "onetry"
15:42 < jeremyrubin> fork: https://github.com/JeremyRubin/bitcoin/tree/checktemplateverify-signet
15:42 < jeremyrubin> you shouldn't need the fork running to connect i think?
15:43 -!- viraltaco_ [~taco@unaffiliated/d-b/x-8688605] has joined #bitcoin-core-dev
15:43 < viraltaco_> Hi
15:44 < viraltaco_> Does anyone know why the mempool is so large and the fees so high (Pretty sure those two events are correlated) 
15:44 -!- pleia21 [~pleia2@185.103.96.147] has quit [Remote host closed the connection]
15:44 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: No Ping reply in 180 seconds.]
15:45 < viraltaco_> Did Segwit fail? :( should we use BSV? (jk)
15:45 < jeremyrubin> viraltaco_: prolly wrong chan to discuss this in?
15:46 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
15:46 < jeremyrubin> afaict fees don't seem crazy rn tho?
15:47 < viraltaco_> Well, I don't know. This is really a question about how transactions are handled. 
15:47 < viraltaco_> They're not that high, but the mempool keeps growing :( 
15:47 < sipa> #bitcoin please
16:04 -!- dgilmore1 [~dgilmore@185.163.110.125] has joined #bitcoin-core-dev
16:14 -!- miketwenty1 [~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com] has quit []
16:26 -!- viraltaco_ [~taco@unaffiliated/d-b/x-8688605] has quit [Ping timeout: 260 seconds]
16:30 -!- palazzovincenzo [~vincent@93-35-218-68.ip56.fastwebnet.it] has joined #bitcoin-core-dev
16:31 -!- palazzovincenzo [~vincent@93-35-218-68.ip56.fastwebnet.it] has quit [Client Quit]
16:33 -!- vincenzopalazzo [~vincent@2001:b07:6474:9d49:7de2:ea26:22ca:4ba0] has quit [Ping timeout: 268 seconds]
16:52 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
17:06 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:c08c:a5a2:10fd:4192] has joined #bitcoin-core-dev
17:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds]
17:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:13 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:c08c:a5a2:10fd:4192] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:17 -!- proofofkeags [~proofofke@2601:280:c280:e500:7ed6:f476:4ff8:2b87] has quit [Remote host closed the connection]
17:17 -!- proofofkeags [~proofofke@2601:280:c280:e500:61e1:6028:89f5:9f90] has joined #bitcoin-core-dev
17:22 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:c08c:a5a2:10fd:4192] has joined #bitcoin-core-dev
17:23 -!- proofofkeags [~proofofke@2601:280:c280:e500:61e1:6028:89f5:9f90] has quit [Ping timeout: 268 seconds]
17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:36 -!- vasild_ is now known as vasild
17:36 -!- instagibbs [~greg@061093103011.ctinets.com] has quit [Ping timeout: 265 seconds]
17:36 -!- instagibbs [~greg@061093103011.ctinets.com] has joined #bitcoin-core-dev
17:53 -!- pentium2000 [~while@dsl-50-5-16-66.fuse.net] has joined #bitcoin-core-dev
17:53 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 272 seconds]
17:57 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving]
18:10 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Remote host closed the connection]
18:10 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
18:17 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection]
18:17 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
18:28 -!- lontivero [~lontivero@186.183.49.45] has quit [Quit: Leaving]
18:29 -!- dgilmore1 [~dgilmore@185.163.110.125] has quit [Remote host closed the connection]
18:37 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
18:45 -!- rabidus_ [~rabidus@dsl-olubng12-54fa17-92.dhcp.inet.fi] has joined #bitcoin-core-dev
18:48 -!- rabidus [~rabidus@dsl-olubng12-54fa0c-1.dhcp.inet.fi] has quit [Ping timeout: 260 seconds]
18:49 -!- RISCi_ATOM1 [~RISCi_ATO@84.39.117.57] has joined #bitcoin-core-dev
19:20 -!- AndGee [~AndGee1@2603-6011-cd02-9d53-3828-a03d-228e-2834.res6.spectrum.com] has joined #bitcoin-core-dev
19:24 -!- AndGee [~AndGee1@2603-6011-cd02-9d53-3828-a03d-228e-2834.res6.spectrum.com] has quit [Quit: Leaving]
19:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
19:37 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
20:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
20:13 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
20:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
20:17 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection]
20:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
20:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
21:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
21:51 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
21:52 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
21:57 -!- instagibbs [~greg@061093103011.ctinets.com] has quit [Ping timeout: 268 seconds]
22:02 -!- instagibbs [~greg@061093103011.ctinets.com] has joined #bitcoin-core-dev
22:06 -!- instagibbs [~greg@061093103011.ctinets.com] has quit [Ping timeout: 240 seconds]
22:18 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
22:23 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds]
22:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/816314ef0f7b...9b28bd73a33b
22:33 < bitcoin-git> bitcoin/master 09d105e Hennadii Stepanov: ci: Drop travis_fold feature as Travis CI is no longer used
22:33 < bitcoin-git> bitcoin/master 95487b0 Hennadii Stepanov: doc: Drop mentions of Travis CI as it is no longer used
22:33 < bitcoin-git> bitcoin/master 9b28bd7 MarcoFalke: Merge #20691: ci, doc: Travis CI features and mentions cleanup
22:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:34 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20691: ci, doc: Travis CI features and mentions cleanup (master...201217-travis) https://github.com/bitcoin/bitcoin/pull/20691
22:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9b28bd73a33b...b27104dc5276
22:57 < bitcoin-git> bitcoin/master fa7dde1 MarcoFalke: wallet: Pass ArgsManager into ExecuteWalletToolFunc instead of using global
22:57 < bitcoin-git> bitcoin/master faf8f61 MarcoFalke: test: Add missing check for is_sqlite_compiled
22:57 < bitcoin-git> bitcoin/master fae32f2 MarcoFalke: wallet: Add missing check for -descriptors wallet tool option
22:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20687: wallet: Add missing check for -descriptors wallet tool option (master...2012-walletToolSqlite) https://github.com/bitcoin/bitcoin/pull/20687
22:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:01 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
23:10 -!- Legousk [~Henkie@178-84-68-9.dynamic.upc.nl] has joined #bitcoin-core-dev
23:13 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
23:13 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
23:14 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
23:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:c08c:a5a2:10fd:4192] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
23:17 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
23:39 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
23:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:55 < bitcoin-git> [gui] MarcoFalke merged pull request #155: Fix checkbox layout in Create Wallet dialog (master...201218-i3) https://github.com/bitcoin-core/gui/pull/155
23:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b27104dc5276...3dd3f7c0af7e
23:55 < bitcoin-git> bitcoin/master e71b656 Hennadii Stepanov: qt: Align layout of checkboxes
23:55 < bitcoin-git> bitcoin/master 3dd3f7c MarcoFalke: Merge bitcoin-core/gui#155: Fix checkbox layout in Create Wallet dialog
23:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
23:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
--- Log closed Fri Dec 18 00:00:52 2020