--- Log opened Sun Dec 20 00:00:51 2020
00:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
00:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:18 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:30 -!- einyx [einyx@fsf/member/einyx] has joined #bitcoin-core-dev
00:30 -!- einyx_ [einyx@fsf/member/einyx] has quit [Ping timeout: 240 seconds]
01:18 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
02:00 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
02:05 -!- kexkey [~kexkey@static-198-54-132-106.cust.tzulo.com] has quit [Ping timeout: 256 seconds]
02:59 -!- aj [aj@cerulean.erisian.com.au] has quit [Ping timeout: 264 seconds]
03:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
03:03 -!- KKND [b3376b54@179.55.107.84] has joined #bitcoin-core-dev
03:10 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
03:10 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
03:19 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
03:19 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
03:24 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
03:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
03:42 -!- marcoagner [~user@2001:8a0:b968:4500:24b0:8c6a:7172:9a81] has quit [Ping timeout: 272 seconds]
03:43 -!- marcoagner [~user@bl6-202-153.dsl.telepac.pt] has joined #bitcoin-core-dev
04:01 < wumpus> achow101: that's so awesome, congrats!!!
04:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:07 < bitcoin-git> [bitcoin] hebasto closed pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717
04:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:37 -!- atiti [~atiti@178.162.209.171] has quit [Remote host closed the connection]
04:42 < jonasschnelli> ach
04:42 -!- jessepos_ [~jp@c-73-15-111-74.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
04:42 < jonasschnelli> achow101: great work!
04:42 < jonasschnelli> Are there any risks (compared to the Apple Tool)? I can test the signature on some older macOS VMs.
04:44 -!- jessepos_ [~jp@c-73-15-111-74.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
04:45 -!- jessepos_ [~jp@2601:645:200:162f:342a:5665:95d7:2a51] has joined #bitcoin-core-dev
04:45 -!- jesseposner [~jp@2601:645:200:162f:c485:a1f9:c55:8d3e] has quit [Ping timeout: 260 seconds]
04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:46 < bitcoin-git> [bitcoin] jonatack opened pull request #20729: p2p: standardize on outbound-{full, block}-relay connection type naming (master...outbound-connection-type-naming) https://github.com/bitcoin/bitcoin/pull/20729
04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:58 -!- peterpomade [~peterpoma@178.162.209.171] has joined #bitcoin-core-dev
05:01 -!- rc_423_ [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
05:01 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
05:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:11 -!- filchef [~filchef@211.178.57.143] has joined #bitcoin-core-dev
05:11 -!- filchef|2 [~filchef@211.178.57.143] has joined #bitcoin-core-dev
05:11 -!- filchef|3 [~filchef@211.178.57.143] has joined #bitcoin-core-dev
05:12 -!- filchef|4 [~filchef@211.178.57.143] has joined #bitcoin-core-dev
05:12 -!- filchef0 [~filchef@211.178.57.143] has joined #bitcoin-core-dev
05:12 -!- filchef7 [~filchef@211.178.57.143] has joined #bitcoin-core-dev
05:14 -!- filchef4 [~fiilchef@211.178.57.143] has joined #bitcoin-core-dev
05:15 -!- filchef [~filchef@211.178.57.143] has quit [Ping timeout: 240 seconds]
05:15 -!- filchef|2 [~filchef@211.178.57.143] has quit [Ping timeout: 240 seconds]
05:15 -!- filchef|3 [~filchef@211.178.57.143] has quit [Ping timeout: 240 seconds]
05:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
05:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
05:16 -!- filchef|4 [~filchef@211.178.57.143] has quit [Ping timeout: 268 seconds]
05:16 -!- filchef0 [~filchef@211.178.57.143] has quit [Ping timeout: 265 seconds]
05:17 -!- filchef7 [~filchef@211.178.57.143] has quit [Ping timeout: 240 seconds]
05:19 -!- filchef4 [~fiilchef@211.178.57.143] has quit [Ping timeout: 264 seconds]
05:21 < wumpus> i think the main risk is "it doesn't work on some OS", testing is important in any case
05:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:36 -!- vasild_ is now known as vasild
05:49 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
05:49 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
05:53 -!- peterpomade [~peterpoma@178.162.209.171] has quit [Remote host closed the connection]
06:00 -!- jesseposner [~jp@2601:645:200:162f:e82d:660f:e599:af19] has joined #bitcoin-core-dev
06:04 -!- jessepos_ [~jp@2601:645:200:162f:342a:5665:95d7:2a51] has quit [Ping timeout: 260 seconds]
06:05 -!- jessepos_ [~jp@2601:645:200:162f:4ff:4055:54dc:4523] has joined #bitcoin-core-dev
06:08 -!- jesseposner [~jp@2601:645:200:162f:e82d:660f:e599:af19] has quit [Ping timeout: 268 seconds]
06:09 -!- jesseposner [~jp@2601:645:200:162f:704f:362b:c5bf:ffce] has joined #bitcoin-core-dev
06:12 -!- jessepos_ [~jp@2601:645:200:162f:4ff:4055:54dc:4523] has quit [Ping timeout: 260 seconds]
06:12 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving]
06:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
06:19 -!- jessepos_ [~jp@2601:645:200:162f:15dd:4797:3a66:7f5b] has joined #bitcoin-core-dev
06:23 -!- jesseposner [~jp@2601:645:200:162f:704f:362b:c5bf:ffce] has quit [Ping timeout: 268 seconds]
06:25 -!- Michael26 [7d3b9770@cm125-59-151-112.hkcable.com.hk] has joined #bitcoin-core-dev
06:27 -!- Michael26 [7d3b9770@cm125-59-151-112.hkcable.com.hk] has quit [Remote host closed the connection]
06:32 -!- MasterdonX [~masterdon@45.9.249.248] has quit [Remote host closed the connection]
06:32 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
06:33 -!- kik1 [~kik1@195.140.213.38] has joined #bitcoin-core-dev
06:38 -!- MasterdonX [~masterdon@45.9.249.244] has joined #bitcoin-core-dev
06:44 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
07:26 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:32 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:35 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
07:49 -!- jesseposner [~jp@2601:645:200:162f:a5c4:bc64:5efb:cb78] has joined #bitcoin-core-dev
07:52 -!- jessepo__ [~jp@2601:645:200:162f:1c3f:95cc:4147:b3b5] has joined #bitcoin-core-dev
07:52 -!- jessepos_ [~jp@2601:645:200:162f:15dd:4797:3a66:7f5b] has quit [Ping timeout: 260 seconds]
07:55 -!- jesseposner [~jp@2601:645:200:162f:a5c4:bc64:5efb:cb78] has quit [Ping timeout: 260 seconds]
07:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
08:00 -!- jesseposner [~jp@2601:645:200:162f:ac3a:46a4:d17:1f9f] has joined #bitcoin-core-dev
08:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
08:03 -!- jessepo__ [~jp@2601:645:200:162f:1c3f:95cc:4147:b3b5] has quit [Ping timeout: 260 seconds]
08:12 -!- jessepos_ [~jp@2601:645:200:162f:996d:e767:d8aa:ac23] has joined #bitcoin-core-dev
08:15 -!- jesseposner [~jp@2601:645:200:162f:ac3a:46a4:d17:1f9f] has quit [Ping timeout: 264 seconds]
08:24 -!- kexkey [~kexkey@static-198-54-132-106.cust.tzulo.com] has joined #bitcoin-core-dev
08:36 -!- jesseposner [~jp@2601:645:200:162f:a829:c4c0:a0cf:7b18] has joined #bitcoin-core-dev
08:40 -!- jessepos_ [~jp@2601:645:200:162f:996d:e767:d8aa:ac23] has quit [Ping timeout: 260 seconds]
08:57 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
09:16 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
09:21 < achow101> i suppose there could be risk in having the private key being handled by python code
09:21 < achow101> the whole thing currently has to be run on an online computer too for the timestamping part to work
09:22 < achow101> although I suppose it could be split into 2 steps; the timestamp doesn't require private key access. however I don't know if MacOS will not like the signing time and the timestamp to be too far apart
09:25 < sipa> you just need to know when the timestamp time is going to be, right?
09:27 < achow101> i guess so
09:34 < sipa> ideally the signer works without private key, so there is no risk of exposing anything secret ,;)
09:36 < achow101> hah. I did find a segfault in codesign though... I think it was a null dereference.
09:37 -!- jessepos_ [~jp@2601:645:200:162f:5c62:ae00:ddd8:e13e] has joined #bitcoin-core-dev
09:41 -!- jesseposner [~jp@2601:645:200:162f:a829:c4c0:a0cf:7b18] has quit [Ping timeout: 268 seconds]
09:43 -!- jesseposner [~jp@2601:645:200:162f:7c79:6e90:8a28:e48b] has joined #bitcoin-core-dev
09:46 -!- jessepos_ [~jp@2601:645:200:162f:5c62:ae00:ddd8:e13e] has quit [Ping timeout: 260 seconds]
09:49 -!- jessepos_ [~jp@2601:645:200:162f:49b:2f5b:7015:2a4b] has joined #bitcoin-core-dev
09:52 -!- jesseposner [~jp@2601:645:200:162f:7c79:6e90:8a28:e48b] has quit [Ping timeout: 260 seconds]
09:54 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:57 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
10:06 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds]
10:07 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
10:11 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
10:12 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
10:24 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
10:25 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
10:27 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
10:27 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
10:29 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
10:32 < achow101> jonasschnelli: if you would like to try using signapple to sign, it should work with our detached-sig-create.sh script as a drop in replacement for codesign
10:33 < achow101> you would only need to change that script to call signapple instead of codesign
10:44 < jonasschnelli> achow101: can you post the link again of your tool?
10:44 < achow101> https://github.com/achow101/signapple
10:45 < jonasschnelli> I probably need to test it tomorrow,... getting late here.
10:45 < achow101> no rush
10:48 < jonasschnelli> ModuleNotFoundError: No module named 'setuptools'
10:48 < achow101> how do you not have setuptools?
10:48 < jonasschnelli> (while calling pip3 install -e .)
10:48 < jonasschnelli> dunno
10:48 < jonasschnelli> Requirement already satisfied: setuptools in /usr/local/lib/python3.9/site-packages (50.3.2)
10:48 < jonasschnelli> ?
10:48 < achow101> ??
10:50 < jonasschnelli> its again python mix (brew vs local)
10:52 < achow101> I updated the docs to list out the dependencies so you can install them one by one
10:53 < achow101> also the tool still uses codesign_allocate but we can use the open source one rather than the mac one
10:55 < jonasschnelli> achow101: for your info. I tried to verify a random app,... told me "Exception: Unknown blob entry type 4096"
10:55 < achow101> interesting
10:56 < achow101> it definitely works for verifying our previous releases
10:56 < jonasschnelli> (that app had two binaries in their .app package, ... I specified the binary directly)
10:56 < jonasschnelli> Yes. Verifying RC2 works.
10:57 < jonasschnelli> Will try to sign rc3 with the tool tomorrow.
10:57 < achow101> yeah, that error is because there it is using "alternate CodeDirectory array" which I haven't figured out how to verify yet
10:57 < jonasschnelli> Nice work... achow101: you'll get the hacker-badge! at the next coredev.tech
11:04 -!- jesseposner [~jp@2601:645:200:162f:3445:8a6f:3157:5bd7] has joined #bitcoin-core-dev
11:05 -!- jessepos_ [~jp@2601:645:200:162f:49b:2f5b:7015:2a4b] has quit [Ping timeout: 260 seconds]
11:07 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
11:34 < achow101> a guy sent me some psbts that he said core created but nothing could deserialize. I'm looking at them now and it seems like there are a few places where some random bytes are being put in that just don't belong there
11:34 < achow101> any ideas on how that could happen?
11:37 < sipa> what kind of bytes?
11:37 < sipa> where?
11:38 < achow101> in one of the txids in the global tx, about 2/3 of the way through, there's a d0 that does not belong
11:38 < achow101> everything before, and everything after, matches an expected txid. and if we ignore the length, everything else would deserialize as expected, until we hit another random byte
11:39 < sipa> inside the txid?
11:39 < achow101> yep
11:39 < sipa> that makes no sense...
11:39 < achow101> I'm thinking this is a case of memory corruption
11:40 < sipa> i don't see what else could cause corruption _inside_ a txid
11:45 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
11:46 -!- belcher_ is now known as belcher
11:52 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]
12:04 < achow101> another has corruption inside a value
12:05 < achow101> i've asked him to try using another computer with the same wallets
12:15 -!- jessepos_ [~jp@2601:645:200:162f:35f8:7ffe:c75b:4679] has joined #bitcoin-core-dev
12:19 -!- jesseposner [~jp@2601:645:200:162f:3445:8a6f:3157:5bd7] has quit [Ping timeout: 268 seconds]
12:21 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:30 -!- krakisiri [~sirikosir@80.72.89.153.coresnet.bg] has joined #bitcoin-core-dev
12:32 -!- jesseposner [~jp@2601:645:200:162f:c034:e34f:db07:5fd9] has joined #bitcoin-core-dev
12:35 -!- siropushselski [~sirikosir@80.72.89.153.coresnet.bg] has quit [Ping timeout: 268 seconds]
12:36 -!- jessepos_ [~jp@2601:645:200:162f:35f8:7ffe:c75b:4679] has quit [Ping timeout: 260 seconds]
12:45 -!- jeremyrubin [~jr@2607:fb90:46a:1b35:300e:3023:6b28:256b] has joined #bitcoin-core-dev
12:46 -!- jessepos_ [~jp@2601:645:200:162f:d111:66c1:9f1:fad4] has joined #bitcoin-core-dev
12:49 -!- jesseposner [~jp@2601:645:200:162f:c034:e34f:db07:5fd9] has quit [Ping timeout: 264 seconds]
13:00 -!- jesseposner [~jp@2601:645:200:162f:6d69:4487:bc60:3cb9] has joined #bitcoin-core-dev
13:03 -!- jessepos_ [~jp@2601:645:200:162f:d111:66c1:9f1:fad4] has quit [Ping timeout: 260 seconds]
13:11 -!- acceleratesats [2fe8ad2b@047-232-173-043.res.spectrum.com] has joined #bitcoin-core-dev
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:22 < bitcoin-git> [bitcoin] benthecarman opened pull request #20731: rpc: Add missing description of vout in getrawtransaction help text (master...fix-getrawtransaction-help-text) https://github.com/bitcoin/bitcoin/pull/20731
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:29 -!- jessepos_ [~jp@2601:645:200:162f:61ae:c80f:b84:f2d3] has joined #bitcoin-core-dev
13:29 -!- acceleratesats [2fe8ad2b@047-232-173-043.res.spectrum.com] has quit [Remote host closed the connection]
13:29 -!- jeremyrubin [~jr@2607:fb90:46a:1b35:300e:3023:6b28:256b] has quit [Ping timeout: 260 seconds]
13:32 -!- jesseposner [~jp@2601:645:200:162f:6d69:4487:bc60:3cb9] has quit [Ping timeout: 268 seconds]
13:42 -!- seberm [~seberm@ip4-83-240-4-221.cust.nbox.cz] has joined #bitcoin-core-dev
13:43 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
13:44 -!- miketwen_ [~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com] has joined #bitcoin-core-dev
13:44 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Read error: Connection reset by peer]
13:47 -!- kik1 [~kik1@195.140.213.38] has quit [Remote host closed the connection]
13:48 -!- jeremyrubin [~jr@c-24-4-205-116.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:49 -!- glozow [uid453516@gateway/web/irccloud.com/x-prfquogpwohdqhqk] has joined #bitcoin-core-dev
14:21 < phantomcircuit> fanquake, after investigating more this seems unrelated to the hardening options, rather just clang-7 cant build master at all (for some reason?)
14:23 < phantomcircuit> actually CC=clang CXX=clang++ ./configure --with-incompatible-bdb --disable-hardening worked
14:23 < phantomcircuit> so it is the hardening, but im not sure which part of it
14:27 -!- jessepos_ [~jp@2601:645:200:162f:61ae:c80f:b84:f2d3] has quit [Quit: Textual IRC Client: www.textualapp.com]
14:27 -!- jesseposner [~jp@2601:645:200:162f:61ae:c80f:b84:f2d3] has joined #bitcoin-core-dev
14:28 < phantomcircuit> fanquake, iono removing the fcf-protection line entirely fixes the issue
14:28 < phantomcircuit> so maybe the check isnt' working?
14:31 < fanquake> I looked at the logs you posted on the PR and that option wasn’t being used.
14:32 < phantomcircuit> fanquake, i can build with clang, with that commented out, but not with --enable-fuzz
14:34 < fanquake> Ok, but the fuzzing build error is different right?
14:35 < phantomcircuit> it's the same error
14:35 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection]
14:35 < phantomcircuit> fanquake, the change you made works on the condition that --enable-fuzz isn't set, the failure is seemingly identical though
14:36 < phantomcircuit> so your pr is an improvement, but there's still an issue if that makes sense
14:36 < phantomcircuit> it's hard to bisect why without rebasing the original pr out, but there's enough commits since that doing that is not trivial at all
14:36 < fanquake> how is "/usr/bin/ld: error: ... <corrupt x86 feature size: 0x8>" the same as "multiple definition of `ConsumeNode(FuzzedDataProvider&)'; test/fuzz/fuzz-addition_overflow.o:/home/bitcoin/bitcoin/src/./test/fuzz/util.h:290: first defined here"
14:37 < fanquake> I understand there is still  an error. However it is not the same one that is being fixed by my PR
14:38 < phantomcircuit> fanquake, i guess im mixing up failures in my head, you're right those are different
14:40 -!- jessepos_ [~jp@2601:645:200:162f:9992:e657:beb2:1d22] has joined #bitcoin-core-dev
14:42 < fanquake> No worries. What you're seeing now could be the same as what was reported here: https://github.com/bitcoin/bitcoin/pull/20560#issuecomment-748339644
14:44 -!- jesseposner [~jp@2601:645:200:162f:61ae:c80f:b84:f2d3] has quit [Ping timeout: 260 seconds]
14:47 -!- brianhoffman [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has quit [Quit: brianhoffman]
14:48 < phantomcircuit> fanquake, yeah looks like it
14:51 -!- brianhoffman [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has joined #bitcoin-core-dev
15:13 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds]
15:14 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
15:18 < phantomcircuit> fanquake, yeah that was it
15:22 < phantomcircuit> fanquake, thanks
15:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:22 < bitcoin-git> [bitcoin] pstratem opened pull request #20733: inline non-member functions with body in fuzzing headers (master...2020-12-20-fuzz-inline) https://github.com/bitcoin/bitcoin/pull/20733
15:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:24 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
15:25 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
15:26 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
15:30 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
15:31 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
15:33 -!- jesseposner [~jp@2601:645:200:162f:1cc2:e8a:4d4d:b133] has joined #bitcoin-core-dev
15:35 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
15:36 -!- jessepos_ [~jp@2601:645:200:162f:9992:e657:beb2:1d22] has quit [Ping timeout: 264 seconds]
15:46 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
15:46 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
15:50 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
15:57 -!- jessepos_ [~jp@2601:645:200:162f:ed56:3007:95ba:e24] has joined #bitcoin-core-dev
16:00 -!- jesseposner [~jp@2601:645:200:162f:1cc2:e8a:4d4d:b133] has quit [Ping timeout: 260 seconds]
16:22 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
16:22 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
16:25 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
16:26 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
16:30 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
16:31 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
16:35 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
16:36 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
16:40 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
16:41 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
16:42 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Client Quit]
16:44 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
16:45 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
16:46 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-jmnycirzwyuntfua] has quit [Read error: Connection reset by peer]
16:46 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-dequyziutcuulwgj] has quit [Read error: Connection reset by peer]
16:46 -!- hebasto [sid449604@gateway/web/irccloud.com/x-fadcirbhpzvcfezz] has quit [Read error: Connection reset by peer]
16:46 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-nwtcnthiphocmngz] has quit [Read error: Connection reset by peer]
16:46 -!- fjahr [sid374480@gateway/web/irccloud.com/x-kgzulwjjzuyevisv] has quit [Ping timeout: 264 seconds]
16:46 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
16:46 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-fpkuvfihnixtfrzh] has quit [Read error: Connection reset by peer]
16:46 -!- mariorz [sid490@gateway/web/irccloud.com/x-dmlbtukjehcjydsc] has quit [Read error: Connection reset by peer]
16:46 -!- endogenic [sid145991@gateway/web/irccloud.com/x-mpexyroazklhiktg] has quit [Read error: Connection reset by peer]
16:46 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
16:47 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
16:47 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-ctuvkgeuixnjotzd] has joined #bitcoin-core-dev
16:47 -!- mariorz [sid490@gateway/web/irccloud.com/x-mbaxojievlhfaoqu] has joined #bitcoin-core-dev
16:47 -!- endogenic [sid145991@gateway/web/irccloud.com/x-zsvxjvojfdwmmpdw] has joined #bitcoin-core-dev
16:47 -!- fjahr [sid374480@gateway/web/irccloud.com/x-rtehnbkvgybyoxca] has joined #bitcoin-core-dev
16:47 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-ysbahwcxgcdkusfr] has joined #bitcoin-core-dev
16:48 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-idlonhvwyelzvqug] has joined #bitcoin-core-dev
16:48 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-hzyrokkuuarumpaa] has joined #bitcoin-core-dev
16:48 -!- hebasto [sid449604@gateway/web/irccloud.com/x-oldodgjijocmrifk] has joined #bitcoin-core-dev
16:57 -!- Netsplit *.net <-> *.split quits: wxss, victorSN, dr-orlovsky, cfields, meshcollider, pingwindyktator, StopAndDecrypt, jonatack, greypw, dermoth,  (+7 more, use /NETSPLIT to show all of them)
17:10 -!- glozow [uid453516@gateway/web/irccloud.com/x-prfquogpwohdqhqk] has quit [Quit: Connection closed for inactivity]
17:15 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
17:15 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
17:17 -!- Netsplit over, joins: dr-orlovsky, jeremyrubin, jonatack, gleb, darosior, meshcollider, ctrlbreak, cfields, StopAndDecrypt, wxss (+7 more)
17:32 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:36 -!- vasild_ is now known as vasild
17:39 -!- KKND [b3376b54@179.55.107.84] has quit [Ping timeout: 245 seconds]
17:40 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
17:43 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
17:43 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
17:54 -!- JohnnyBitcoin [~JohnnyBit@ool-45712dcc.dyn.optonline.net] has joined #bitcoin-core-dev
18:23 -!- miketwenty1 [~miketwent@ec2-54-208-86-252.compute-1.amazonaws.com] has joined #bitcoin-core-dev
18:27 -!- miketwen_ [~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com] has quit [Ping timeout: 268 seconds]
18:28 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds]
18:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:45 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
18:47 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
19:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:21 -!- krakisiri [~sirikosir@80.72.89.153.coresnet.bg] has quit [Read error: Connection reset by peer]
19:21 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
19:21 -!- krakisiri [~sirikosir@80.72.89.153.coresnet.bg] has joined #bitcoin-core-dev
19:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
19:24 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 240 seconds]
19:24 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds]
19:25 < phantomcircuit> with the fuzzing data in qa-assets do i just want to submit all of the files libFuzz added?
19:26 < sipa> yeah
19:28 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds]
19:29 < phantomcircuit> sipa, so just like git add . in qa-assets and submit a pr?
19:29 < sipa> yeah, is it a lot?
19:29 < sipa> you may want to minimize it first
19:31 < phantomcircuit> sipa, it's more than doubled the process_message directory
19:31 < phantomcircuit> that's why im asking lol
19:32 < sipa> how many files?
19:32 < sipa> how long did you run it lol
19:33 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
19:33 < phantomcircuit> sipa, not very long but i have uh lots of cores
19:34 < sipa> in cpu years then
19:34 < phantomcircuit> 234:54.14 * 32
19:35 < phantomcircuit> i think that's minutes seconds milliseconds?
19:36 < sipa> oh, that's not much
19:42 < phantomcircuit> yeah but i have 22k process_message files vs the 8k that was there before
19:42 < phantomcircuit> im reading the libFuzzer docs but i haven't gotten to compacting them yet
19:45 < sipa> did you use the test/fuzz/test_runner.py script?
19:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:47 < bitcoin-git> [bitcoin] fanquake closed pull request #16169: omnilayerDevelop88 (0.18...develop) https://github.com/bitcoin/bitcoin/pull/16169
19:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:48 < phantomcircuit> sipa, no
19:48 < sipa> fanquake: wow where did you find that?
19:49 < phantomcircuit> sipa, 2019
19:49 < fanquake> sipa: was looking at PRs tagged as backports, and that was one. 2nd PR like that recently that has just  "appeared "
19:50 < sipa> phantomcircuit: so, create a new directory $NEWDIR, fill it with just the qa-assets' seeds for the process_message fuzzer, and then run FUZZ=process_message ./src/test/fuzz/fuzz -merge=1 -use_value_profile=1 $NEWDIR $DIRWITHYOURNEWSEEDS
19:51 < luke-jr> >_<
19:52 < fanquake> I opened an issue with GitHub ~5 days ago asking why it was happening. No reply from them yet.
20:00 < phantomcircuit> sipa, hmm so by default this is just putting the new test cases into the same directory, copying the qa-assets seeds is to prevent them from being deemed duplicates right (i saw your comment on the github issue about merging)
20:01 < phantomcircuit> i'd probably need to have a separate copy of them for that to really work i guess (although through git magic i guess i do)
20:02 < sipa> phantomcircuit: when fuzzing, did you start with the existing qa-assets, and fuzzed on top, or did you start from scratch?
20:02 < phantomcircuit> sipa, i started with the existing qa-assets
20:05 < sipa> ok
20:09 < phantomcircuit> sipa, having clearly not read enough about this, is the the sanest way to use cpu time, or should i use new seeds and merge them into the corpus?
20:11 < phantomcircuit> or should i copy the corpus, fuzz on the corpus and then merge back
20:12 < sipa> i'd do the last
20:16 < phantomcircuit> sipa, btw test_runner.py runs each test just once by default
20:16 < phantomcircuit> which i guess makes sense for actually running them
20:16 < phantomcircuit> but for fuzzing isn't super useful i think
20:18 < phantomcircuit> oh i see --generate
20:25 < phantomcircuit> sipa, ok this is working nicely i think
20:49 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
21:03 < phantomcircuit> sipa, ok it takes a very long time to do the merge lol
21:06 < sipa> phantomcircuit: it'll run every seed from both inputs once to determine their coverage
21:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:16 < phantomcircuit> sipa, i also have a bunch of 'slow-unit-' files
21:19 -!- jesseposner [~jp@2601:645:200:162f:30e7:b32e:18ab:9a91] has joined #bitcoin-core-dev
21:23 -!- jessepos_ [~jp@2601:645:200:162f:ed56:3007:95ba:e24] has quit [Ping timeout: 260 seconds]
21:23 < phantomcircuit> sipa, interestingly some of the tests run through 100,000 runs really fast and others do not, i guess that makes sense though
21:31 -!- JohnnyBitcoin [~JohnnyBit@ool-45712dcc.dyn.optonline.net] has quit [Ping timeout: 240 seconds]
22:00 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
22:07 -!- sirikreaki [~sirikosir@80.72.89.153.coresnet.bg] has joined #bitcoin-core-dev
22:08 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
22:08 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
22:11 -!- krakisiri [~sirikosir@80.72.89.153.coresnet.bg] has quit [Ping timeout: 240 seconds]
22:17 -!- robbiet480 [~robbiet48@185.103.96.147] has joined #bitcoin-core-dev
22:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
22:34 -!- miketwenty1 [~miketwent@ec2-54-208-86-252.compute-1.amazonaws.com] has quit [Remote host closed the connection]
22:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:46 < bitcoin-git> [bitcoin] hebasto opened pull request #20734: build: Make platform-specific targets available for proper platform builds only (master...201221-targets) https://github.com/bitcoin/bitcoin/pull/20734
22:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:05 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
23:09 < jonasschnelli> achow101: for the codesign test,... should I set the env var CODESIGN_ALLOCATE to the binary we have in the tar.gz (the oss one)?
23:09 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 240 seconds]
23:09 < achow101> jonasschnelli: yeah
23:10 < sipa> the same codesign_allocate as will be used to attach the sig
23:10 < sipa> achow101: would it make sense for your tool to also do the attaching?
23:11 < achow101> sipa: yes, I plan on adding detaching and attaching options to it
23:11 < achow101> just need to figure out how to format the detached sig
23:11 < sipa> cool!
23:11 < sipa> i expect that will be easy compared to everything else you've done
23:11 < achow101> yes, it's mostly just a design decision
23:12 < achow101> and whether we want to maintain compatibility with the current process
23:12 < sipa> achow101: the actual codesign tool also has a detached format
23:12 < achow101> sipa: it can't be attached to a binary
23:12 < achow101> although maybe with some modifications it could
23:12 < sipa> ah
23:13 < achow101> the main problem is the separate CodeResources file. but codesign's detach option embeds that in the signature. I'll have to see if it's possible to do that in the embedded signature so that we don't have to deal with multiple files
23:14 < sipa> jonasschnelli: if you're going to try with rc3, use the codesign tool from the gitian build (without my recent patch)
23:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f1dbf92ff047...e9efb64a0772
23:14 < bitcoin-git> bitcoin/master d8b9cec Patrick Strateman: inline non-member functions with body in fuzzing headers
23:14 < bitcoin-git> bitcoin/master e9efb64 MarcoFalke: Merge #20733: inline non-member functions with body in fuzzing headers
23:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20733: inline non-member functions with body in fuzzing headers (master...2020-12-20-fuzz-inline) https://github.com/bitcoin/bitcoin/pull/20733
23:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:16 < jonasschnelli> sipa: ? ... I'm going to use achow101 codesign tool,.. not?
23:16 < jonasschnelli> I'll use the codesign_allocate tools from the rc3 (non modified)
23:16 < jonasschnelli> achow101: how should I modify the sign command?
23:16 < jonasschnelli> ${CODESIGN} -f --file-list ${TEMPLIST} "$@" "${BUNDLE}" (will not work)
23:17 < sipa> jonasschnelli: sorry, codesign_allocate tool
23:17 < jonasschnelli> sipa: yes. I'm using the non modified rc3 version
23:17 < achow101> jonasschnelli: are you up to date? I pushed some commits earlier today that added -f --file-list options so it should work
23:18 < jonasschnelli> achow101: no. I'm not up to date then.
23:20 < jonasschnelli> achow101: I'm at 56e5493,... ./detached-sig-create.sh -s "Bitcoin" gives me "codesign.py: error: argument command: invalid choice: 'sign.temp/signatures.txt' (choose from 'verify', 'sign', 'dump')"
23:20 < achow101> oh yeah
23:20 < achow101> ${CODESIGN} sign -f --file-list ${TEMPLIST} "$@" "${BUNDLE}"
23:20 < achow101> should work
23:21 < jonasschnelli> achow101: codesign.py: error: unrecognized arguments: -s
23:22 < jonasschnelli> set -x tell me: /Users/jonasschnelli/Documents/bitcoin/signapple/codesign.py sign -f --file-list sign.temp/signatures.txt -s Bitcoin dist/Bitcoin-Qt.app
23:22 < jonasschnelli> achow101: how do I pass the identity to your tool?
23:22 < achow101> ah, so it can't fetch the cert from MacOS's keychain. you need to export it as a .p12 and give the path, no -s
23:22 < achow101> there's instructions in docs/certificates.md
23:23 < jonasschnelli> -h is out of date. :)
23:23  * jonasschnelli reading...
23:23 < achow101> updating documentation is not a strong suit
23:27 < jonasschnelli> achow101: after entering the .p12 password (your tool) I'm getting FileNotFoundError: [Errno 2] No such file or directory: '/Users/jonasschnelli/Desktop/bitcoin-0.21.0rc3-osx-unsigned/dist/Bitcoin-Qt.app/Contents/_CodeSignature/CodeResources'
23:27 < jonasschnelli> My execution is: ${CODESIGN} sign /Users/jonasschnelli/Desktop/mycert.p12 -f --file-list ${TEMPLIST} "$@" "${BUNDLE}"
23:28 < jonasschnelli> (I'll remove the -s and removed the help/parameter-check in detached-sig-create)
23:29 < achow101> does that file exist after the tool fails?
23:29 < jonasschnelli> achow101: nope... there is no _CodeSignature folder
23:32 < achow101> strange
23:32 < achow101> can you make the directory and try again?
23:32 < jonasschnelli> ok
23:32 < jonasschnelli> no change
23:33 < achow101> hmm
23:33 < achow101> I'll try on my mac tomorrow
23:33 < jonasschnelli> sure... I'll debug it a bit
23:34 < achow101> the relevant functiosn for that are _build_resources and _set_code_res_hash in signapple/sign.py
23:36 < jonasschnelli> _set_code_res_hash only hashes the file,.. (which is not there)
23:45 -!- proofofkeags_ [~proofofke@174-29-3-187.hlrn.qwest.net] has quit [Ping timeout: 268 seconds]
--- Log closed Mon Dec 21 00:00:05 2020