--- Log opened Tue Dec 22 00:00:52 2020
00:04 < jonasschnelli> success: using codesign_allocate from cctools-927.0.2_6 (throught MacPorts) works!
00:04 < sipa> yay!
00:05 < jonasschnelli> As for the next steps: how do we pack codesign_allocate into the bitcoin-osx-unsigned.tar.gz?
00:05 < jonasschnelli> (i mean the macOS version)
00:05 < sipa> we don't need to, i think?
00:05 < jonasschnelli> Or shall we imply that the macOS code signature needs to be done on Linux?
00:05 < sipa> you just did one on osx just fine?
00:06 < jonasschnelli> Yeah... but using macports and installing cctools might not be stable in the long run
00:06 < jonasschnelli> probably okay for now
00:07 < sipa> i guess we can add an osx cctools in there
00:07 < jonasschnelli> But I foresee this as a pitfall when someone else builds MacOS signatures in future
00:07 < sipa> my point is more that it doesn't need to be reproducibly built
00:07 < jonasschnelli> yes. Thats right.
00:07 < sipa> it just needs to do the right thing, and we'll know when it doesn't
00:07 < jonasschnelli> Agree. Either we document it well or we make achow101 codesign fail when not using the cctools alloc
00:08 < sipa> or even nicer would be incorporating the allocate tool into the signer
00:08  * jonasschnelli pokes achow101 (he might not like that)
00:09 < jonasschnelli> but hey,... finally we can sing on linux. I bet there are a ton of other projects interested in that
00:09 < sipa> we talked about it here a few days ago
00:09 < sipa> iirc he wasn"t planning on adding the allocate part, or at least not at firsr
00:10 < jonasschnelli> The missing codesign_allocate part would probably also be a great source of failue/debugging if other projects starting to use this tool
00:10 < jonasschnelli> (not that this is the scope)
00:11 < jonasschnelli> however, impressive work achow101!
00:17 -!- jnewbery [~john@164.90.178.190] has quit [Ping timeout: 256 seconds]
00:17 -!- jnewbery [~john@164.90.178.190] has joined #bitcoin-core-dev
00:17 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Remote host closed the connection]
00:17 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev
00:18 < sipa> jonasschnelli: for rc4 you'll actually probably just want to use the macos allocate tool
00:19 < sipa> since rc4 has my patch that makes its cctools act like the macos one
00:19 < jonasschnelli> Yes. Sure. Your fix.
00:19 < sipa> ideally you'd use a macos build of the patched cctools
00:19 < jonasschnelli> I mean no fix on Mac
00:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:19 < sipa> but in all likelihood, the apple one will just work
00:19 < jonasschnelli> Ah.. I tried without (rc3) and it worked...
00:20 < jonasschnelli> I’ll do a testrun with rc4 before publishing the sigs
00:20 < jonasschnelli> (With the apple one)
00:21 < sipa> rc3 used unpatched cctools in its attacher
00:21 < sipa> so you need to use unpatched cctools at signing time too
00:23 < jonasschnelli> sipa: Yes. I tested your fix (patched cctools in attacher) with official_apple tool on signer. Which worked. I guess we can do this also for rc4?
00:25 < sipa> what build did you test?
00:27 < jonasschnelli> Rc3
00:28 < jonasschnelli> Nope... sry. Master
00:28 < sipa> ah yes, master, that makes sense
00:28 < jonasschnelli> But since we backported your fix. It should behave identical (in terms of signing)
00:28 < jonasschnelli> (Rc4)
00:29 < sipa> yup
00:48 -!- lz [cac05003@202.192.80.3] has quit [Ping timeout: 245 seconds]
00:51 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:03 -!- flack [~flack@p200300d46f24de00ce7a6ba684b2a133.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:04 -!- flack [~flack@p200300d46f24de00ce7a6ba684b2a133.dip0.t-ipconnect.de] has quit [Client Quit]
01:04 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de00ce7a6ba684b2a133.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:06 -!- abraham [~abraham@45.91.22.224] has quit [Quit: abraham]
01:12 -!- jonatack [~jon@213.152.162.154] has quit [Quit: jonatack]
01:16 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
01:21 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds]
01:21 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:21 -!- jonatack [~jon@213.152.161.30] has joined #bitcoin-core-dev
01:28 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat]
01:31 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
01:32 -!- proofofkeags_ [~proofofke@174-29-3-187.hlrn.qwest.net] has joined #bitcoin-core-dev
01:32 -!- proofofkeags [~proofofke@174-29-3-187.hlrn.qwest.net] has quit [Remote host closed the connection]
01:56 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 265 seconds]
02:05 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has quit [Ping timeout: 272 seconds]
02:14 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
02:26 -!- bosma [sid103570@gateway/web/irccloud.com/x-vyqfzrgivozqwuhm] has joined #bitcoin-core-dev
02:28 -!- eragmus [sid136308@gateway/web/irccloud.com/x-dcfwmxguedopunaj] has joined #bitcoin-core-dev
02:30 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-kcpafitmewgluevi] has joined #bitcoin-core-dev
02:31 -!- tylerchambers [sid477594@gateway/web/irccloud.com/x-dlbubescdmengbml] has joined #bitcoin-core-dev
02:31 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-jhzugnblbuxavtfw] has joined #bitcoin-core-dev
02:54 -!- jeremyrubin [~jr@2601:645:c200:14:d16a:4949:3622:4cc0] has quit [Ping timeout: 268 seconds]
03:03 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de00ce7a6ba684b2a133.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
03:04 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 240 seconds]
03:05 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 240 seconds]
03:06 -!- dviola [~diego@187.39.20.240] has joined #bitcoin-core-dev
03:07 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev
03:08 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de008fed52e96cd39bec.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f4ac48d30a84...209974d379e5
03:13 < bitcoin-git> bitcoin/master e3d2ba7 practicalswift: fuzz: Update FuzzedDataProvider.h from upstream (LLVM)
03:13 < bitcoin-git> bitcoin/master 209974d MarcoFalke: Merge #20740: fuzz: Update FuzzedDataProvider.h from upstream (LLVM)
03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20740: fuzz: Update FuzzedDataProvider.h from upstream (LLVM) (master...bump-FuzzedDataProvider.h) https://github.com/bitcoin/bitcoin/pull/20740
03:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:17 < vasild> practicalswift is not on IRC?
03:18 < hebasto> vasild: no (he wrote me an email)
03:18 < vasild> ok
03:19 -!- user____ [~user@mail.deeplinkmedia.com] has quit [Quit: leaving]
03:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:40 < jnewbery> wumpus MarcoFalke: I think #19829 might be RFM (5 ACKs at various times from MarcoFalke, jonatack, hebasto, sipa, Sjors; reACKs on the latest branch from MarcoFalke, jonatack, Sjors)
03:40 < gribble> https://github.com/bitcoin/bitcoin/issues/19829 | net processing: Move block inventory state to net_processing by jnewbery · Pull Request #19829 · bitcoin/bitcoin · GitHub
03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:46 < bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/209974d379e5...df127ecede80
03:46 < bitcoin-git> bitcoin/master 717a374 John Newbery: [net processing] Improve documentation for Peer destruction/locking
03:46 < bitcoin-git> bitcoin/master 77a2c2f John Newbery: [net processing] Move nStartingHeight to Peer
03:46 < bitcoin-git> bitcoin/master 78040f9 John Newbery: [net processing] Rename nStartingHeight to m_starting_height
03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:46 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19829: net processing: Move block inventory state to net_processing (master...2020-08-blocks-in-peer) https://github.com/bitcoin/bitcoin/pull/19829
03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:46 < jnewbery> thanks Marco!
04:10 -!- flukiluke1 [~flukiluke@217.146.82.202] has quit [Remote host closed the connection]
04:29 -!- Betelgeuse1 [~Betelgeus@185.204.1.185] has joined #bitcoin-core-dev
04:36 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de008fed52e96cd39bec.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
04:40 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de00c549028b86996237.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
05:23 -!- SiNoNe_aCid [~acid@ppp-2-85-248-171.home.otenet.gr] has joined #bitcoin-core-dev
05:24 -!- SiNoNe_aCid [~acid@ppp-2-85-248-171.home.otenet.gr] has left #bitcoin-core-dev []
05:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:36 -!- vasild_ is now known as vasild
05:40 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
06:20 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
06:20 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
06:20 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:28 < bitcoin-git> [bitcoin] fanquake opened pull request #20744: [POC] Use std::filesystem. Remove Boost Filesystem & System (master...use_std_filesystem) https://github.com/bitcoin/bitcoin/pull/20744
06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:29 -!- sirikreaki [~sirikosir@80.72.89.153.coresnet.bg] has quit [Quit: Leaving]
06:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:30 < bitcoin-git> [bitcoin] fanquake closed pull request #19245: Replace boost::filesystem with std::filesystem (master...feature/2020-06-replace-boost-filesystem-with-cpp17-filesystem) https://github.com/bitcoin/bitcoin/pull/19245
06:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20744: [POC] Use std::filesystem. Remove Boost Filesystem & System (master...use_std_filesystem) https://github.com/bitcoin/bitcoin/pull/20744
06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:45 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #20744: [POC] Use std::filesystem. Remove Boost Filesystem & System (master...use_std_filesystem) https://github.com/bitcoin/bitcoin/pull/20744
06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:45 -!- miketwen_ [~miketwent@ec2-54-208-86-252.compute-1.amazonaws.com] has joined #bitcoin-core-dev
07:36 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has joined #bitcoin-core-dev
07:36 < bitcoin-git> [bitcoin] hebasto opened pull request #20745: qa: Correct epoll_ctl data race suppression (master...201222-epoll) https://github.com/bitcoin/bitcoin/pull/20745
07:36 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has left #bitcoin-core-dev []
07:51 -!- cyclopes2011 [47ab551d@pool-71-171-85-29.clppva.fios.verizon.net] has joined #bitcoin-core-dev
07:52 -!- kexkey [~kexkey@static-198-54-132-154.cust.tzulo.com] has joined #bitcoin-core-dev
07:53 -!- cyclopes2011 [47ab551d@pool-71-171-85-29.clppva.fios.verizon.net] has quit [Remote host closed the connection]
07:58 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
08:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]
08:02 -!- belcher_ is now known as belcher
08:18 -!- Betelgeuse1 [~Betelgeus@185.204.1.185] has quit [Remote host closed the connection]
08:33 -!- brimstone1 [~brimstone@185.204.1.185] has joined #bitcoin-core-dev
08:37 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
08:38 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:51 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
08:52 -!- Henry151 [~bishop@ns3007530.ip-151-80-44.eu] has quit [Ping timeout: 258 seconds]
08:53 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
08:53 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Disconnected by services]
08:53 < achow101> jonasschnelli: I would have liked to do the allocate within the tool too, but to do so would essentially require writing a mach-o parser and that was just too much additional work. unfortunately macholib is not sufficient and I couldn't find another library
08:53 -!- tralfaz is now known as davterra
08:54 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
08:55 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de00c549028b86996237.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:55 -!- Henry151 [~bishop@ns3007530.ip-151-80-44.eu] has joined #bitcoin-core-dev
08:55 < jonasschnelli> achow101: I think its fine. Lets just document it well because otherwise the sigs attachment fail.
08:55 -!- miketwen_ [~miketwent@ec2-54-208-86-252.compute-1.amazonaws.com] has quit [Ping timeout: 246 seconds]
08:55 < achow101> sure
08:55 < jonasschnelli> Maybe we can add a simple script to contrib/ that builds code_allocate on mac
08:55 < jonasschnelli> I really dislike depending on macports
08:56 < achow101> could do that
08:56 < jonasschnelli> That would be awesome
08:56 < jonasschnelli> Also,.. I would expect that your tool gets attention from other projects too
08:57 < jonasschnelli> Its really a missing step in distribution (especially iOS, not sure if it works there as well).
08:58 < achow101> I acutally find a codesigning tool for iOS: https://github.com/appknox/isign
08:58 < achow101> It might work on MacOS too, but I didn't check. only found this after writing most of my code
08:59 < achow101> since iOS also uses MachO bundles, it shouldn't be too hard to do both. but I also have no way to test because I can't make iOS builds without an iPhone
09:24 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/df127ecede80...9286b1cbce78
09:24 < bitcoin-git> bitcoin/master d71e29e Hennadii Stepanov: qa: Correct epoll_ctl data race suppression
09:24 < bitcoin-git> bitcoin/master 9286b1c MarcoFalke: Merge #20745: qa: Correct epoll_ctl data race suppression
09:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20745: qa: Correct epoll_ctl data race suppression (master...201222-epoll) https://github.com/bitcoin/bitcoin/pull/20745
09:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20746: test (master...2012-tempDel) https://github.com/bitcoin/bitcoin/pull/20746
09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20746: test (master...2012-tempDel) https://github.com/bitcoin/bitcoin/pull/20746
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:31 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
09:35 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
09:35 -!- csknk [~csknk@unaffiliated/csknk] has quit [Client Quit]
09:37 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 246 seconds]
09:40 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
09:43 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 264 seconds]
09:44 -!- jeremyrubin [~jr@2601:645:c200:14:d16a:4949:3622:4cc0] has joined #bitcoin-core-dev
09:51 -!- Anduck [~anduck@unaffiliated/anduck] has joined #bitcoin-core-dev
09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:54 < bitcoin-git> [bitcoin] jnewbery opened pull request #20747: net processing: Remove dropmessagestest (master...2020-12-dropmessagestest) https://github.com/bitcoin/bitcoin/pull/20747
09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:54 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 272 seconds]
10:06 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
10:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:18 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20748: test: Add race:SendZmqMessage tsan suppression (master...2012-ciSuppZmq) https://github.com/bitcoin/bitcoin/pull/20748
10:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:25 < bitcoin-git> [bitcoin] dongcarl opened pull request #20749: [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex (master...2020-09-libbitcoinruntime-v4) https://github.com/bitcoin/bitcoin/pull/20749
10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:32 -!- while [~while@dsl-50-5-16-66.fuse.net] has joined #bitcoin-core-dev
10:32 -!- while [~while@dsl-50-5-16-66.fuse.net] has quit [Read error: Connection reset by peer]
10:34 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
10:35 -!- StopAndDecrypt_ [~StopAndDe@82.102.23.218] has joined #bitcoin-core-dev
10:36 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 260 seconds]
10:38 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
10:43 -!- StopAndDecrypt_ [~StopAndDe@82.102.23.218] has quit [Ping timeout: 256 seconds]
10:46 < hebasto> achow101 "I acutally find a codesigning tool for iOS: https://github.com/appknox/isign" -- if that tool work, should we maintain own tool in long run?
10:51 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:53 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
11:04 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 264 seconds]
11:05 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
11:14 -!- miketwen_ [~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com] has joined #bitcoin-core-dev
11:14 < phantomcircuit> MarcoFalke, are there rules about what should be pr'd to qa-assets?
11:15 < phantomcircuit> (other than them being merged
11:15 < phantomcircuit> )
11:17 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 240 seconds]
11:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:36 < bitcoin-git> [bitcoin] dongcarl opened pull request #20750: [Bundle 2/n] Prune g_chainman usage in mempool-related validation functions (master...2020-09-reduce-validation-mempool-ccsactiveglobal-usage) https://github.com/bitcoin/bitcoin/pull/20750
11:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:36 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
11:39 -!- Chlorine_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
11:42 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 246 seconds]
11:48 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 272 seconds]
11:49 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
11:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
12:00 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:01 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
12:02 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
12:07 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
12:11 -!- Anduck [~anduck@unaffiliated/anduck] has quit [Quit: Reconnecting]
12:12 -!- Anduck [~anduck@unaffiliated/anduck] has joined #bitcoin-core-dev
12:39 -!- Pippo65 [97152375@151.21.35.117] has joined #bitcoin-core-dev
12:42 -!- Pippo65 [97152375@151.21.35.117] has quit [Remote host closed the connection]
12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9286b1cbce78...98de9eb1aa84
12:57 < bitcoin-git> bitcoin/master 3e15712 Hennadii Stepanov: Update TSan suppressions
12:57 < bitcoin-git> bitcoin/master 98de9eb MarcoFalke: Merge #19983: Drop some TSan suppressions
12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19983: Drop some TSan suppressions (master...200920-supp) https://github.com/bitcoin/bitcoin/pull/19983
12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:58 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
13:39 < achow101> hebasto: maintaining our own tool at least lets us target it to our specific needs
13:39 < achow101> e.g. I can make it produced detached sigs that we can attach with the same tool
13:45 -!- jesseposner [~jp@c-73-15-111-74.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
13:45 -!- jesseposner [~jp@2601:645:200:162f:da9:1617:a616:f7bc] has joined #bitcoin-core-dev
13:46 -!- filchef [~filchef@89.253.179.83] has joined #bitcoin-core-dev
13:52 < luke-jr> achow101: could jsut as well PR that feature to the existing one..
13:52 < achow101> it seems unmaintained
13:52 < luke-jr> :/
13:53 < achow101> it's forked from an archived repo, but that repo has a bunch of forks so I can't tell which one is "real"
13:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
14:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection]
14:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
14:43 -!- GonnaSellSomeCoo [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
14:47 -!- GonnaSellSomeCoo [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has quit [Client Quit]
14:47 -!- pbarry_ [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
14:47 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
15:05 -!- pbarry_ [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
15:13 -!- pbarry_ [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
15:15 -!- pbarry_ [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has quit [Client Quit]
15:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:50 -!- greypw [~greypw@unaffiliated/greypw] has quit [Quit: I'll be back!]
15:50 -!- greypw [~greypw@unaffiliated/greypw] has joined #bitcoin-core-dev
15:55 < justinmoon> Can anyone share docker or vagrant setups for the gitian build? Been following these docs and I imagine we could automate this more https://github.com/bitcoin-core/docs/blob/master/gitian-building.md ...
16:02 -!- glozow [uid453516@gateway/web/irccloud.com/x-mfttzpvimjezxnps] has joined #bitcoin-core-dev
16:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:09 < sipa> justinmoon: sorry, no experience with docker
16:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
16:13 -!- filchef [~filchef@89.253.179.83] has quit [Read error: Connection reset by peer]
16:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
16:15 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
16:18 < jonatack> justinmoon: https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md
16:18 < jonatack> (it's docker-based)
16:19 < phantomcircuit> MarcoFalke, btw https://github.com/bitcoin-core/qa-assets/pull/37
16:19 < phantomcircuit> that's actually merged
16:41 < justinmoon> jonatack: perfect, thanks
16:51 -!- jonatack [~jon@213.152.161.30] has quit [Ping timeout: 264 seconds]
16:53 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
16:57 -!- jesseposner [~jp@2601:645:200:162f:da9:1617:a616:f7bc] has quit [Ping timeout: 260 seconds]
16:57 -!- jessepos_ [~jp@c-73-15-111-74.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
17:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:28 -!- miketwen_ [~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com] has quit [Ping timeout: 246 seconds]
17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:36 -!- vasild_ is now known as vasild
17:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
17:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:59 -!- roconnor [~roconnor@host-45-78-199-13.dyn.295.ca] has joined #bitcoin-core-dev
18:27 -!- instagibbs [~greg@061093103011.ctinets.com] has joined #bitcoin-core-dev
18:28 -!- instagibbs [~greg@061093103011.ctinets.com] has quit [Client Quit]
18:36 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Remote host closed the connection]
19:07 -!- jessepos_ [~jp@c-73-15-111-74.hsd1.ca.comcast.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
19:07 -!- jesseposner [~jp@2601:645:200:162f:1507:39f0:b918:b6c4] has joined #bitcoin-core-dev
19:18 -!- brimstone1 [~brimstone@185.204.1.185] has quit [Remote host closed the connection]
19:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:13 < bitcoin-git> [bitcoin] pstratem opened pull request #20751: [fuzzing] Use subprocess.Popen call directly, remove use of thread pool. (master...2020-12-22-fuzz-test-runner) https://github.com/bitcoin/bitcoin/pull/20751
20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:46 < bitcoin-git> [bitcoin] pstratem opened pull request #20752: [fuzzer] generate new seeds in an infinite loop with random parameters (master...2020-12-fuzz-test-runner-infinite-generate) https://github.com/bitcoin/bitcoin/pull/20752
20:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:48 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
20:48 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
20:53 < phantomcircuit> sipa, ^ those seem to work nicely
20:57 < sipa> mutate_depth uniformly up to 15, wow
20:57 < sipa> i haven't experimented with that, but assumed that the default of 5 was pretty good
20:59 < sipa> phantomcircuit: i believe it also makes sense to vary the -max_len parameter
20:59 < sipa> giving proportionally more time to short inputs seems to help
21:00 < phantomcircuit> sipa, there's already a strong bias towards smaller inputs with another parameter which is uhhh
21:01 < phantomcircuit> len_control
21:03 < phantomcircuit> i might need to upstream to clang a change to the max_total_time behaviour, for process_message even with 300 seconds it exits after like 100 tests
21:04 < sipa> phantomcircuit: another possibility is just not starting with the full corpus, but just a random subset of limited size
21:06 < sipa> phantomcircuit: the len_control isn't useful for us i think... yes, you want short and long, but you don't want that within one run... we run so long that hopefully there is good coverage on all lengths already
21:06 < phantomcircuit> oh i forgot to add a sleep to the loop
21:06 < phantomcircuit> heh
21:07 < phantomcircuit> sipa, right so random max_len between like 100 and 4,000,000 ?
21:07 < sipa> by default max_len is 4096
21:07 < sipa> and len_control is on
21:07 < phantomcircuit> uh no by default it guesses based on the corpus
21:07 < phantomcircuit> which for process_message ends up being >1MiB
21:07 < sipa> oh, ok, but if the corpus has nothing big, it's set to 4096 afaik
21:08 < phantomcircuit> INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1007323 bytes
21:08 < sipa> longer term i think we want an absolutely max_len configured for every target
21:08 < phantomcircuit> it's based on what's n the corpus and afaict the only way for it to grow is to have lots of things which are near the max and restart the process
21:09 < phantomcircuit> it'll then guess that max_len should be longer and bump it
21:19 < phantomcircuit> sipa, yeah agree, i suggested upto 4MiB since that's the largest valid network message, i think?
21:27 < sipa> but fuzzing with such large inputs is super slow
21:28 < sipa> so i think you want the max_len parameter exponentially distributed between say 64 and 4096 for most targets, and maybe forna few exceptions with a higher max
21:35 < phantomcircuit> 2 ** random.randint(1,12)
21:35 < phantomcircuit> maybe?
21:35 < phantomcircuit> actually that starts too small
21:36 < phantomcircuit> 2 ** random.randint(6,12)
21:40 < sipa> math.round(2.0 ** random.uniform(6.0, 12.0)) ?
21:41 < phantomcircuit> does the max length need to be uniformly within the range? 
21:42 < phantomcircuit> maybe just powers of 2 is ok?
21:46 < sipa> that's not uniform
21:47 < phantomcircuit> sipa, ?
21:50 -!- glozow [uid453516@gateway/web/irccloud.com/x-mfttzpvimjezxnps] has quit [Quit: Connection closed for inactivity]
21:50 < sipa> 2**random.uniform is exponential, not uniform
21:56 < phantomcircuit> sipa, oh no i mean like instead of powers of 2 that will also be values inbetween
21:56 < phantomcircuit> it's still distributed exponentially
21:59 < sipa> yeah, why restrict to just powers of 2? :)
21:59 < sipa> (no strong opinion, i'm sure it's all fine)
22:02 < phantomcircuit> btw the largest corpus i have is now for the bloom_filter and asmap tests which is interesting
22:02 < phantomcircuit> i think the process message one just explodes trying to load it's corpus actually
22:03 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
22:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
22:41 < phantomcircuit> sipa, yeah i tried specifying -runs instead of -max_total_time and im running into the problem i thought i would
22:41 < phantomcircuit> all the processes are now expensive things to run cause they sort of clog up the works
23:04 -!- jessepos_ [~jp@2601:645:200:162f:b9d5:4819:405c:7ac5] has joined #bitcoin-core-dev
23:06 -!- jesseposner [~jp@2601:645:200:162f:1507:39f0:b918:b6c4] has quit [Ping timeout: 258 seconds]
23:37 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 260 seconds]
23:54 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 268 seconds]
--- Log closed Wed Dec 23 00:00:55 2020