--- Log opened Sun Jan 03 00:00:04 2021 00:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 00:18 < wumpus> provoostenator: i don't know, but we can't postpone rc4 indefinitely on it 00:18 < wumpus> we could have some release out and have something for people to test for weeks now, but the discussion on those takes indefinitely 00:22 < sipa> let's just get rc4 out 00:24 < aj> wumpus: if it's not going in, nack it as not being important enough a fix to justify a change? (if it is important enough to justify a change, merging it seems obvious?) 00:25 < aj> wumpus: (i think it's important enough; but obviously lots of people are dubious, and if someone has to make a call, might as well be a maintainer?) 01:17 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has joined #bitcoin-core-dev 01:36 < wumpus> aj: I have already given my opinion on it 01:36 < wumpus> I don't necesaarily want to push that 01:39 < wumpus> but yes I think the change is unnecessary 01:40 < wumpus> and in that case it's probably better to err on the side of not doing it, that said, if this blocks the release forever it'd be kind of sad 01:45 < wumpus> I really think it's time to do the rc 01:47 < wumpus> looking at #18947, 0.21 has slipped exactly a month now 01:47 < gribble> https://github.com/bitcoin/bitcoin/issues/18947 | Release schedule for 0.21.0 · Issue #18947 · bitcoin/bitcoin · GitHub 01:47 < wumpus> this is fairly normal 01:48 < wumpus> i'm not sure this should delay the 0.22.0 release schedule as well 02:03 < aj> wumpus: hmm, i appreciate the "I don't necessarily want to push that" but I also feel like "I think the change is unnecessary" should be more of a nack (concept nack? -0.5? im-not-merging-but-someone-else-might?) than a "~0" and a "review ACK"? it seems like everyone's waiting for someone else to nack it so they don't have to? 02:03 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 02:04 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:16 < wumpus> "review ACK" means i think the code is correct in doing what it is stated to do 02:17 < wumpus> as for #20648, it can wait 02:17 < gribble> https://github.com/bitcoin/bitcoin/issues/20648 | chainparams: Add default fixed seeds for signet by MarcoFalke · Pull Request #20648 · bitcoin/bitcoin · GitHub 02:24 -!- RootDet [~Rootdet@unaffiliated/rootdet] has joined #bitcoin-core-dev 02:24 -!- RootDet [~Rootdet@unaffiliated/rootdet] has left #bitcoin-core-dev [] 02:32 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds] 02:34 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 02:35 -!- jonatack [~jon@88.124.242.136] has quit [Client Quit] 02:35 < wumpus> thinking of it somewhat more, I don't think minor signet-specific issues like this should really hold up a release 02:49 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 02:52 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:57 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has joined #bitcoin-core-dev 02:57 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has quit [Client Quit] 03:00 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 264 seconds] 03:01 -!- jonatack [~jon@213.152.162.99] has joined #bitcoin-core-dev 03:15 -!- jonatack [~jon@213.152.162.99] has quit [Quit: jonatack] 03:15 -!- jonatack [~jon@213.152.162.99] has joined #bitcoin-core-dev 03:18 -!- Garth63Schuster [~Garth63Sc@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:30 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has joined #bitcoin-core-dev 03:39 < fanquake> agree 03:45 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has joined #bitcoin-core-dev 03:49 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has quit [Client Quit] 03:55 -!- schulzemic [~ada@193.27.14.104] has joined #bitcoin-core-dev 04:18 -!- Matt_P [~Matt_P@185.204.1.185] has joined #bitcoin-core-dev 04:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:22 -!- Garth63Schuster [~Garth63Sc@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 04:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:26 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 04:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:42 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/ac125e960f31...93ce429f0e6a 04:42 < bitcoin-git> bitcoin/0.21 93ce429 Wladimir J. van der Laan: qt: Pre-rc4 translations update 04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:43 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/93ce429f0e6a...212525337eda 04:43 < bitcoin-git> bitcoin/0.21 2125253 Wladimir J. van der Laan: build: Bump RC to rc4 04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:49 -!- Talkless [~Talkless@m90-135-158-94.cust.tele2.lt] has joined #bitcoin-core-dev 05:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has joined #bitcoin-core-dev 05:03 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has joined #bitcoin-core-dev 05:06 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 05:14 -!- davterra [~davterra@86.106.143.77] has joined #bitcoin-core-dev 05:23 -!- Talkless [~Talkless@m90-135-158-94.cust.tele2.lt] has quit [Quit: Konversation terminated!] 05:25 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has quit [Ping timeout: 258 seconds] 05:28 -!- davterra [~davterra@86.106.143.77] has quit [Ping timeout: 260 seconds] 05:31 -!- schulzemic [~ada@193.27.14.104] has quit [Quit: Konversation terminated!] 05:34 -!- davterra [~davterra@23.226.131.131] has joined #bitcoin-core-dev 05:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 05:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:11 < michaelfolkson> I'm thinking of making it clearer in the fuzzing docs that fuzzing beginners should start with libFuzzer based on these Google recommendations https://github.com/google/fuzzing/blob/master/docs/intro-to-fuzzing.md#fuzzing-tools 06:11 < michaelfolkson> Does anyone do any fuzzing currently with Honggfuzz, AFL? 06:12 < michaelfolkson> Apparently AFL isn't well maintained according to that Google doc 06:13 < michaelfolkson> I guess libFuzzer being first in our fuzzing doc is a subtle recommendation by itself https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md 06:13 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:23 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has joined #bitcoin-core-dev 06:35 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 06:37 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 06:44 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 06:57 -!- rex4539 [~rex4539@8.40.29.14] has quit [] 07:10 < MarcoFalke> ACK on rc4 tag 07:10 < MarcoFalke> #20648 isn't meant for rc4 and it only has one explict review ACK 07:10 < gribble> https://github.com/bitcoin/bitcoin/issues/20648 | chainparams: Add default fixed seeds for signet by MarcoFalke · Pull Request #20648 · bitcoin/bitcoin · GitHub 07:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:19 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/212525337eda...e6ad8a6220bf 07:19 < bitcoin-git> bitcoin/0.21 e6ad8a6 Wladimir J. van der Laan: doc: Generate manual pages for 0.21.0rc4 07:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:48 < bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc4: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc4 07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:49 < wumpus> ^^ 08:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:00 < bitcoin-git> [bitcoin] jonatack closed pull request #20723: p2p: improve logging in EvictExtraOutboundPeers() (master...improve-EvictExtraOutboundPeers-logging) https://github.com/bitcoin/bitcoin/pull/20723 08:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:02 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 08:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Read error: Connection reset by peer] 08:02 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Read error: Connection reset by peer] 08:02 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Read error: Connection reset by peer] 08:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer] 08:02 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Write error: Connection reset by peer] 08:02 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Read error: Connection reset by peer] 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:05 < bitcoin-git> [bitcoin] jonatack closed pull request #20546: policy, wallet, refactor: check for non-representable CFeeRates (master...non-representable-CFeeRate-check) https://github.com/bitcoin/bitcoin/pull/20546 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:07 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 08:08 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 08:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 08:08 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 08:08 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 08:09 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 08:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 08:12 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 08:18 < michaelfolkson> You're not making it easy to get quick Concept ACKs jonatack with descriptions like "following up on #19858 (comment)." and not making it clear what is covered by the PR and what is covered by the series of PRs 08:18 < gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub 08:19 < michaelfolkson> Easy to give a quick Concept ACK when the description is better quality 08:19 < michaelfolkson> Otherwise needs some digging on behalf of the reviewer 08:21 < michaelfolkson> PR #20546 has a good PR description 08:21 < gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub 08:28 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 08:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20839: fuzz: Avoid extraneous copy of input data, using Span<> (master...2101-fuzzSpan) https://github.com/bitcoin/bitcoin/pull/20839 08:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:41 -!- davterra [~davterra@23.226.131.131] has quit [Remote host closed the connection] 08:42 -!- davterra [~davterra@23.226.131.131] has joined #bitcoin-core-dev 08:42 -!- davterra [~davterra@23.226.131.131] has quit [Read error: Connection reset by peer] 08:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:52 < bitcoin-git> [bitcoin] ppyordanov closed pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836 08:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:52 < jonatack> idk if the pull descriptions are the issue. i stand by the work and am sad to close, but better to work on things reviewers are enthusiastic about...you do the work because you believe in it; after that you turn it over to reviewers and it's up to them. 08:53 < jonatack> there's a book about it, "review is a harsh mistress" (heinlein, 1966 :)) 08:54 < michaelfolkson> Well I'm telling you at least from my perspective a good PR description makes a Concept ACK very quick and easy :) 08:55 < michaelfolkson> The more digging required, the more friction and the unlikelier it is to get quick Concept ACKs. That's my hypothesis anyway 08:58 < jonatack> michaelfolkson: hm, with the title "p2p: improve logging in EvictExtraOutboundPeers" and the diff being only 9 lines, i reckoned more description wasn't required on that one 08:59 < jonatack> maybe could have added more though, idk 08:59 < jonatack> onward and upward 09:03 < michaelfolkson> It is the problem it is solving rather than the solution only being 9 lines 09:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:10 < bitcoin-git> [bitcoin] ppyordanov reopened pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836 09:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:24 -!- andytosh1 [~apoelstra@wpsoftware.net] has quit [Changing host] 09:24 -!- andytosh1 [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 09:24 -!- andytosh1 is now known as andytoshi 09:26 -!- brianhoffman [~brianhoff@pool-151-200-246-97.washdc.fios.verizon.net] has left #bitcoin-core-dev [] 09:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c3765ad7cee...6e70674cda65 09:28 < bitcoin-git> bitcoin/master 0dade91 fanquake: fuzz: remove no-longer-necessary packages from fuzzbuzz config 09:28 < bitcoin-git> bitcoin/master 6e70674 MarcoFalke: Merge #20781: fuzz: remove no-longer-necessary packages from fuzzbuzz conf... 09:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20781: fuzz: remove no-longer-necessary packages from fuzzbuzz config (master...cleanup_fuzzbuzz) https://github.com/bitcoin/bitcoin/pull/20781 09:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e70674cda65...2dab2d239a47 09:30 < bitcoin-git> bitcoin/master efaf80e Michael Dietz: fuzz: check that certain script TxoutType are nonstandard 09:30 < bitcoin-git> bitcoin/master 2dab2d2 MarcoFalke: Merge #20765: fuzz: check that certain script TxoutType are nonstandard 09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:30 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20765: fuzz: check that certain script TxoutType are nonstandard (master...test-fuzz-is-nonstandard) https://github.com/bitcoin/bitcoin/pull/20765 09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:54 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in] 09:59 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 10:00 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 10:00 -!- davterra [~davterra@23.226.131.131] has joined #bitcoin-core-dev 10:00 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:07 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2dab2d239a47...9a2400b57558 10:07 < bitcoin-git> bitcoin/master fad140e MarcoFalke: test: Set correct nValue for multi-op-return policy check 10:07 < bitcoin-git> bitcoin/master 9a2400b MarcoFalke: Merge #20760: test: Set correct nValue for multi-op-return policy check 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20760: test: Set correct nValue for multi-op-return policy check (master...2012-testNValue) https://github.com/bitcoin/bitcoin/pull/20760 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:20 -!- unauvum [~unauvum@134.122.10.34] has joined #bitcoin-core-dev 10:32 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev 10:41 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 10:41 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:42 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20800: Revert "Don't send 'sendaddrv2' to pre-70016 software" (master...2012-netRevertSendaddrv2Workaround) https://github.com/bitcoin/bitcoin/pull/20800 10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:45 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has quit [Remote host closed the connection] 10:52 -!- virtu_ [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 10:52 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:52 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16398: rpc: testmempoolaccept for list of transactions (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/16398 10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:53 < bitcoin-git> [bitcoin] jonatack closed pull request #20483: wallet: deprecate feeRate in fundrawtransaction/walletcreatefundedpsbt (master...deprecate-feeRate-options) https://github.com/bitcoin/bitcoin/pull/20483 10:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:56 < bitcoin-git> [bitcoin] jonatack closed pull request #20240: script: fix linter error in test runner (master...fix-python-linter-error) https://github.com/bitcoin/bitcoin/pull/20240 10:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:57 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:00 < bitcoin-git> [gui] hebasto opened pull request #176: Fix TxViewDelegate layout (master...210103-delegate) https://github.com/bitcoin-core/gui/pull/176 11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 11:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 11:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 11:15 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 11:24 -!- heyitsrama [~heyitsram@c-24-6-105-253.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:27 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds] 11:27 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 11:45 -!- filchef [~filchef@89.253.179.83] has joined #bitcoin-core-dev 11:51 -!- df3fjf [~df3fjf@gateway/tor-sasl/jd3i33j] has joined #bitcoin-core-dev 11:58 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 260 seconds] 12:01 -!- df3fjf [~df3fjf@gateway/tor-sasl/jd3i33j] has quit [Quit: leaving] 12:06 -!- heyitsrama [~heyitsram@c-24-6-105-253.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 12:07 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:24 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:29 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 12:44 < andytoshi> is there a way to call `getblock` and not receive witness data? would a PR to add this be accepted? 12:47 < luke-jr> the RPC? there probably shouldn't be 12:47 < sipa> you can run with -rpcserialversion=0 if you really need to 12:53 -!- samuel-pedraza [47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243] has joined #bitcoin-core-dev 13:07 < andytoshi> oh that's a neat trick sipa, i might do that 13:08 < andytoshi> ok luke-jr if there's gonna be opposition i won't bother 13:08 < andytoshi> but it kinda annoying to haul all that witness data around if i'm not even gonna use it 13:09 < luke-jr> andytoshi: why haul it? just strip at your first hop? 13:09 < luke-jr> or rather, why get the raw block at all if you don't want that? :P 13:11 < andytoshi> luke-jr: i am the first hop, i'm pulling this data over localhost into an indexer, which is just scanning for TXOs that it cares about 13:11 < andytoshi> and inputs 13:11 < andytoshi> i guess if i were to drop the witness data at parse-time in the indexer, the perf hit from that would probabyl not be measurable 13:12 < luke-jr> right, I would expect that's the case 13:12 < luke-jr> libblkmaker has some cheap code to drop it IIRC 13:12 < andytoshi> thanks, i'll check it out 13:14 < phantomcircuit> andytoshi, add an rpc to use the block filters on a set of elements? 13:14 < luke-jr> someone has a PR for that already 13:15 < luke-jr> seems like it'd be less efficient tho 13:15 < andytoshi> luke-jr: i think it would be more efficient than what i'm doing -- i'm asking Core to serialize whole blocks, send it to a nother process, and then i'm filtering there ... if i could ask Core to just do the filtering that should be way faster 13:16 < andytoshi> i'll track down that PR and test it 13:17 < luke-jr> #20664 13:17 < gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub 13:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 13:23 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 13:27 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:35 < andytoshi> thanks! yeah this looks like exactly what i want 13:36 < phantomcircuit> luke-jr, unfortunately that's going to be using the existing block filters, which means recalculating the hash for each block 13:36 < luke-jr> phantomcircuit: ? 13:37 < sipa> phantomcircuit: not really an issue if you're only ever going to scan the last few blocks 13:38 < phantomcircuit> sipa, i mean andytoshi's original approach isn't really either 13:54 -!- tralfaz [~davterra@23.226.131.132] has joined #bitcoin-core-dev 13:57 -!- davterra [~davterra@23.226.131.131] has quit [Ping timeout: 246 seconds] 13:59 -!- davterra [~davterra@23.226.131.131] has joined #bitcoin-core-dev 13:59 -!- tralfaz [~davterra@23.226.131.132] has quit [Read error: Connection reset by peer] 14:01 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 246 seconds] 14:02 -!- filchef [~filchef@89.253.179.83] has quit [Read error: Connection reset by peer] 14:20 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:22 -!- Matt_P [~Matt_P@185.204.1.185] has quit [Remote host closed the connection] 14:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:23 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:28 -!- tralfaz [~davterra@23.226.131.131] has joined #bitcoin-core-dev 14:29 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 14:31 -!- davterra [~davterra@23.226.131.131] has quit [Ping timeout: 256 seconds] 14:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 14:35 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev 14:42 -!- greylica [~greylica@139.28.218.148] has joined #bitcoin-core-dev 15:20 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:23 -!- user__ [~davterra@ool-2f14817b.dyn.optonline.net] has joined #bitcoin-core-dev 15:24 -!- davterra [~davterra@23.226.131.131] has joined #bitcoin-core-dev 15:25 -!- tralfaz [~davterra@23.226.131.131] has quit [Ping timeout: 256 seconds] 15:28 -!- user__ [~davterra@ool-2f14817b.dyn.optonline.net] has quit [Ping timeout: 272 seconds] 15:29 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 15:51 -!- tralfaz [~davterra@23.226.131.155] has joined #bitcoin-core-dev 15:54 -!- davterra [~davterra@23.226.131.131] has quit [Ping timeout: 272 seconds] 16:01 -!- samuel-pedraza [47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243] has quit [Quit: Connection closed] 16:11 -!- davterra [~davterra@23.226.131.131] has joined #bitcoin-core-dev 16:13 -!- tralfaz [~davterra@23.226.131.155] has quit [Ping timeout: 272 seconds] 16:15 -!- tralfaz [~davterra@23.226.131.131] has joined #bitcoin-core-dev 16:17 -!- davterra [~davterra@23.226.131.131] has quit [Read error: Connection reset by peer] 16:28 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 16:29 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:30 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has joined #bitcoin-core-dev 16:53 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 16:54 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 17:00 -!- tralfaz [~davterra@23.226.131.131] has quit [Quit: Leaving] 17:06 < sipa> phantomcircuit: did you see my suggestion here: https://github.com/bitcoin/bitcoin/pull/20752#discussion_r549248791 ? 17:08 -!- samuel-pedraza [47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243] has joined #bitcoin-core-dev 17:14 < phantomcircuit> sipa, i hadn't i've been otherwise occupied 17:15 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 17:17 < phantomcircuit> sipa, yeah that was going to be my adjustment, add a parameter that sets the runtime in wall clock time, (0 being forever) 17:17 < phantomcircuit> also realized it should be displaying the output from each subprocess before they finish but that gets really messy so i was thinking about how to handle that 17:18 < sipa> right 17:18 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 17:18 < phantomcircuit> afl just writes output from the subprocesses to logfiles which i guess is an option but also kind of hackey 17:18 < phantomcircuit> i dont really have a better idea atm though 17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 17:36 -!- vasild_ is now known as vasild 17:39 < phantomcircuit> sipa, any ideas? 17:40 < sipa> just send them to stderr? 17:40 < sipa> or do you need to intercept them from python somehow? 17:40 < phantomcircuit> the python script can read the output continuously and then write to whatever 17:41 < phantomcircuit> writing directly to stderr is really confusing though cause none of the debug lines have any context 17:41 < sipa> ah you want to add a prefix to indicate which fuzzer it's from? 17:41 < phantomcircuit> i could write the PID but for long runs they won't be unique 17:42 < phantomcircuit> i guess i could just assign each fuzzing process a longer than pid random id 17:42 < sipa> i don't understand what the problem is or what you're trying to do 17:42 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer] 17:43 < phantomcircuit> sipa, it's just really confusing to have all the debug output from the fuzzers writing to stderr interleaved, but also it's not helpful to have it all buffered until the process exits 17:43 < phantomcircuit> i guess that's pretty nitpickey 17:46 < sipa> well give each some incrementally assigned id + description string (with the fuzz target name + config, if any part of it is variable) 17:49 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 258 seconds] 18:29 -!- matthewfreeze [ae7e34c0@174-126-52-192.cpe.sparklight.net] has joined #bitcoin-core-dev 18:31 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:32 -!- davterra [~davterra@23.226.131.131] has joined #bitcoin-core-dev 18:32 -!- davterra [~davterra@23.226.131.131] has quit [Remote host closed the connection] 18:34 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds] 19:10 -!- matthewfreeze [ae7e34c0@174-126-52-192.cpe.sparklight.net] has quit [Remote host closed the connection] 19:16 * fanquake descending into typo/spelling hell 19:17 < luke-jr> fanqauke: hi 19:22 < fanquake> 😢 19:43 -!- hidrodo [76c811dd@118.200.17.221] has joined #bitcoin-core-dev 19:57 < aj> fanquake: posting the blogs? 20:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:06 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9a2400b57558...f52f427b8eec 20:06 < bitcoin-git> bitcoin/master a0022f1 Sebastian Falbesoner: test: bump codespell linter version to 2.0.0 20:06 < bitcoin-git> bitcoin/master da289a6 Sebastian Falbesoner: lint: update list of spelling linter false positives 20:06 < bitcoin-git> bitcoin/master f3ba916 Sebastian Falbesoner: lint: ignore gitian keys file for spelling linter 20:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:06 < bitcoin-git> [bitcoin] fanquake merged pull request #20817: lint: update list of spelling linter false positives, bump to codespell 2.0.0 (master...201212-lint-update-spelling-false-positives) https://github.com/bitcoin/bitcoin/pull/20817 20:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:09 < fanquake> aj: nah. That sounds much more productive 20:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:37 < bitcoin-git> [bitcoin] fanquake closed pull request #20810: doc: Update URLs to HTTPS where necessary (master...https-urls) https://github.com/bitcoin/bitcoin/pull/20810 20:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:38 < bitcoin-git> [bitcoin] fanquake closed pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836 20:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:48 -!- hidrodo [76c811dd@118.200.17.221] has quit [Remote host closed the connection] 21:04 -!- mj_node [~mj_node@202.187.154.51] has joined #bitcoin-core-dev 21:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 21:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 21:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 21:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:48 -!- ant0x00 [df4676e2@223.70.118.226] has joined #bitcoin-core-dev 21:49 -!- ant0x00 [df4676e2@223.70.118.226] has quit [Remote host closed the connection] 21:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:59 < bitcoin-git> [bitcoin] fanquake closed pull request #20762: doc: Fix some typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20762 21:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:07 < bitcoin-git> [bitcoin] fanquake opened pull request #20842: docs: consolidate typo & url fixing (master...consolidate_typo_fixing) https://github.com/bitcoin/bitcoin/pull/20842 22:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 22:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 22:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 22:27 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:29 -!- samuel-pedraza [47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243] has quit [Quit: Connection closed] 22:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving] 22:36 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 22:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.238.173] has joined #bitcoin-core-dev 22:56 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 23:08 -!- mj_node [~mj_node@202.187.154.51] has quit [Quit: Leaving] 23:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 23:33 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 23:41 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 23:42 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 23:59 < jonasschnelli> achow101, sipa: for the 0.21.0rc4 mac signatures,... does it matter if I use the apple codesign_allocate tool for the signature? AFAIK that worked with sipas fix. --- Log closed Mon Jan 04 00:00:05 2021