--- Log opened Mon Jan 04 00:00:05 2021 00:04 < sipa> jonasschnelli: as far as we know, our (now patched) cctools codesign_allocate tool works identical to Apple's 00:04 < jonasschnelli> ok 00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f52f427b8eec...bc8ada1c1534 00:09 < bitcoin-git> bitcoin/master fa749fb MarcoFalke: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback 00:09 < bitcoin-git> bitcoin/master bc8ada1 MarcoFalke: Merge #20736: rpc: Replace boost::variant with std::variant for RPCArg.m_f... 00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20736: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (master...2012-rpcStdVariant) https://github.com/bitcoin/bitcoin/pull/20736 00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 00:26 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:26 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving] 00:34 -!- virtu_ is now known as virtu 00:40 < jonasschnelli> sipa: we have to clear the depende cache to make your patch work,.. right? Getting an invalid signature 00:40 < jonasschnelli> (but I have the same hash as the others,... maybe no-one cleared the cache?) 00:40 < jonasschnelli> trying with empty cache 00:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:44 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.238.173] has quit [Quit: My MacBook has gone to sleep. ZZZzzz鈥 00:46 -!- DeadWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 00:48 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:49 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 00:49 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has quit [Quit: Quit] 00:49 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds] 00:49 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev 00:50 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has joined #bitcoin-core-dev 00:51 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 00:52 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 01:03 < jonasschnelli> no.. it was't the cache 01:05 < jonasschnelli> getting invalid macOS signature 01:06 < jonasschnelli> What I did: 01:06 < jonasschnelli> - Built 0.21.0rc4 gitian macOS 01:06 < jonasschnelli> - Verified bitcoin-0.21.0rc4-osx-unsigned.tar.gz, got the correct 10ae57ee735cd2a894a75165082c384769da3b634eca9346b1d20585e1edfd0c 01:07 < jonasschnelli> Created the signature: ./detached-sig-create.sh -s "Bitcoin" 01:07 < jonasschnelli> used the signature to gbuild the signer: ./bin/gbuild --num-make 6 -j11 --memory 5000 --url bitcoin=/home/jonasschnelli/gitian/bitcoin --commit signature=v0.21.0rc4 01:08 < jonasschnelli> https://bitcoin.jonasschnelli.ch/bitcoin-osx-signed-rc4-invalid.dmg (invalid signature) 01:09 < jonasschnelli> https://bitcoin.jonasschnelli.ch/signature-osx-rc4-invalid.tar.gz (the detached signature) 01:09 < jonasschnelli> achow101, sipa ^ 01:10 < jonasschnelli> (I upgraded to macOS 11 and updated XCode since I tested sipas fix on master) 01:10 < sipa> oh 01:10 < sipa> so things may have changed again... 01:11 < sipa> can you use achow"s signer and patched-cctools' codesign_allocate instead? 01:11 < jonasschnelli> I try that later on 01:11 < jonasschnelli> I'm not sure if the upgrade to macOS 11 did cause this) 01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:11 < bitcoin-git> [bitcoin] hebasto closed pull request #20824: build: Do not set _FORTIFY_SOURCE if it causes compiler warnings (master...210101-fortify) https://github.com/bitcoin/bitcoin/pull/20824 01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:16 < sipa> jonasschnelli: well, it seems likely 01:16 < sipa> maybe they "fixed" the issue we encountered earlier... 01:26 < jonasschnelli> That would mean rc3 would sign valid 01:27 < sipa> right 01:54 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:57 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de007b18ce44cd8d51bd.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 02:03 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:07 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 268 seconds] 02:08 -!- belcher_ is now known as belcher 02:13 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 3.0] 02:18 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds] 02:19 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 02:33 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:71ff:303a:4980:438c] has joined #bitcoin-core-dev 02:34 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 256 seconds] 02:35 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 02:46 -!- greylica [~greylica@139.28.218.148] has quit [Remote host closed the connection] 02:53 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 03:07 -!- LoRez1 [~LoRez@185.204.1.185] has joined #bitcoin-core-dev 03:18 -!- Marquise70Rice [~Marquise7@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:31 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 03:32 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 03:32 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 03:32 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 03:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:33 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20844: test: Add sanitizer suppressions for AMD EPYC CPUs (master...2101-testEpycSan) https://github.com/bitcoin/bitcoin/pull/20844 03:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:36 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:143:71ff:303a:4980:438c] has quit [Read error: Connection reset by peer] 03:48 -!- Marquise70Rice [~Marquise7@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 03:53 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 03:53 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 03:53 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 03:53 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 03:55 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 03:56 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 03:56 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 03:56 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 04:01 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de007b18ce44cd8d51bd.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 04:02 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de00bc904d4378a56acd.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:12 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has joined #bitcoin-core-dev 04:16 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 04:16 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 04:27 < jonasschnelli> signing rc3 gives me also an invalid signature 04:28 < jonasschnelli> (apple didn't fix the codesign_allocate difference in 11.16 then) 04:33 < jonasschnelli> achow101: can you also try to sign rc4 with your dummy certificate? Just to see if the error is on my end. 04:34 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 04:34 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 04:43 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 04:48 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 04:49 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 04:50 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 04:52 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 04:53 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 04:54 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 05:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 05:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:19 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 05:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has quit [Quit: My MacBook has gone to sleep. ZZZzzz鈥 05:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 05:36 -!- vasild_ is now known as vasild 05:40 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 05:41 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 05:55 < jonasschnelli> achow101, sipa: still getting invalid signatures. I tried using achow101't signapple tool, which worked locally, but attaching rc4 sig does not work (invalid sig). I guess this is due to sipas patch? 06:06 -!- qwertzlcoatl [~qwertzlco@unaffiliated/qwertzlcoatl] has joined #bitcoin-core-dev 06:10 -!- qwertzlcoatl [~qwertzlco@unaffiliated/qwertzlcoatl] has quit [Client Quit] 06:12 < jonasschnelli> I'm also getting an invalid signature (rc4) when using achow101 tool, then apply the signature with the codesign_allocate binary from rc3. 06:15 < jonasschnelli> https://bitcoin.jonasschnelli.ch/valid_0.21.0rc4_sig_signapple.zip (contains the signature.tar.gz as well as binary that has a valid signature) 06:20 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:29 < MarcoFalke> jonasschnelli: Can you sign rc3 with the achow101 tool? 06:30 < MarcoFalke> rc3 doesn't have the sipa patch 06:30 < jonasschnelli> MarcoFalke. Let em try 06:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 06:35 < jonasschnelli> MarcoFalke: yes. Signing rc3 works with achow101 tool. 06:35 < MarcoFalke> So let's just rever the sipa patch for rc5? 06:37 < jonasschnelli> I think so. Though switching to an new signing tool between rc's is not ideal but I don't see a different solution 06:38 < jonasschnelli> I'll try rc4 again... but I'm pretty sure I haven't made a mistake 06:38 < MarcoFalke> you could downgrade your mac? ;) 06:38 < jonasschnelli> I could,... or use a VM of my older state. 06:39 < jonasschnelli> But somehow I don't think it is the reason 06:40 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has joined #bitcoin-core-dev 06:40 < jonasschnelli> I try now on macOS 10.12.2 06:41 < jonasschnelli> (a VM is have ready) 06:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:43 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20845: net: Log to net debug in MaybeDiscourageAndDisconnect except for noban and manual peers (master...2101-netLogDisconnect) https://github.com/bitcoin/bitcoin/pull/20845 06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:45 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-bamhammylzdpvfhb] has quit [Ping timeout: 260 seconds] 06:46 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has quit [Ping timeout: 260 seconds] 06:47 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-fqmqdesvfbargkli] has joined #bitcoin-core-dev 06:49 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection] 06:49 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has joined #bitcoin-core-dev 06:51 -!- Nee [5cc1aa0d@port-92-193-170-13.dynamic.as20676.net] has joined #bitcoin-core-dev 06:57 < jonasschnelli> sipa: I used a macOS 10.12 (older) VM and signed the 0.21.0rc4 there. Getting also an invalid signature after attaching the sig back in gitian. 06:59 < jonasschnelli> I tripple-checked bitcoin-0.21.0rc4-osx-unsigned.tar.gz that it contains your patch (verifiable here: https://bitcoin.jonasschnelli.ch/gitian/builds/388/build_osx.log) 07:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:09 < bitcoin-git> [bitcoin] benthecarman opened pull request #20846: Add benthecarman to keys.txt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20846 07:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:19 < bitcoin-git> [bitcoin] darosior opened pull request #20847: gitian-keys: add darosior's key (master...darosior_gpg_key) https://github.com/bitcoin/bitcoin/pull/20847 07:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:26 -!- murr4y [ali@38.95.231.35.bc.googleusercontent.com] has quit [Remote host closed the connection] 07:26 -!- murr4y [ali@38.95.231.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 07:28 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.8.2 - https://znc.in] 07:29 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:35 < bitcoin-git> [bitcoin] theStack opened pull request #20848: Add gitian PGP key for theStack (master...add_gitian_pgp_key_for_theStack) https://github.com/bitcoin/bitcoin/pull/20848 07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:37 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has joined #bitcoin-core-dev 07:37 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has quit [Client Quit] 07:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has joined #bitcoin-core-dev 07:39 -!- lightlike [~lightlike@p200300c7ef0f030055ccb2e7ff848937.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 07:42 -!- jespada [~jespada@90.254.245.49] has joined #bitcoin-core-dev 07:48 < wumpus> oh noo not more macos signing issues 馃槩 07:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has quit [Quit: My MacBook has gone to sleep. ZZZzzz鈥 07:58 < jonasschnelli> wumpus: sadly,... but I tripple checked everything. I guess sipas patch does not work for rc4 (it did for master a while ago when I tested it) 07:58 < jonasschnelli> I'd like achow101 and sipa to confirm that its not working and we might need to switch to achow101 signapple tool for rc5 (revert sipas codesign_allocate patch) 08:00 < MarcoFalke> Could you also check if rc1 on the 0.19 and 0.20 branch work 08:00 < MarcoFalke> I think they haven't been released either 08:01 < wumpus> jonasschnelli: if using achow101's tool makes the process more reliable I'm all for that tbh 08:02 < wumpus> it feels more like gambling than engineering at this point :) 08:03 < wumpus> MarcoFalke: yea I think it makes sense to be sure we can do this reliably, then move on with the other releaes, instead of spreading out the experimentation over multiple branches 08:04 < MarcoFalke> if it works, we can close #20738 and #20739 08:04 < gribble> https://github.com/bitcoin/bitcoin/issues/20738 | [0.20] final rc2 backports by MarcoFalke 路 Pull Request #20738 路 bitcoin/bitcoin 路 GitHub 08:04 < gribble> https://github.com/bitcoin/bitcoin/issues/20739 | [0.19] final rc2 backports by MarcoFalke 路 Pull Request #20739 路 bitcoin/bitcoin 路 GitHub 08:09 < wumpus> you mean merge? 08:09 < wumpus> (there's more in there than the macos signing) 08:10 < MarcoFalke> only some minor doc fixups in the 0.20 one 08:14 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev 08:14 < BlueMatt> is it expected that new versions of core (0.20.1, I guess?) will send tx invs even if you set fRelay to false in the version message and never send a filter? 08:15 < BlueMatt> I suddenly see a *ton* of nodes violating fRelay 08:15 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has joined #bitcoin-core-dev 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] marcinja closed pull request #14053: Add address-based index (attempt 4?) (master...add-address-index) https://github.com/bitcoin/bitcoin/pull/14053 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:24 < jonatack> BlueMatt: hm, iirc no except bloom filterload/clear 08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:25 < bitcoin-git> [bitcoin] vasild opened pull request #20849: net: disconnect peers by address without using a subnet (master...disconnect_by_subnet_fix) https://github.com/bitcoin/bitcoin/pull/20849 08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:28 < BlueMatt> oh, nevermind 08:35 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:39 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20850: [0.21] final rc5 backports (0.21...2101-21rc5) https://github.com/bitcoin/bitcoin/pull/20850 08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:44 < wumpus> that's fast for final rc5 backports :) 08:45 < wumpus> does this mean we should just give up rc4? 08:45 < MarcoFalke> probably, heh 08:46 < luke-jr> XD 08:46 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 08:47 < vasild> There is a similar issue as #20849 in banman: BanMan::Ban(const CNetAddr& net_addr, ...) { CSubNet sub_net(net_addr); Ban(sub_net, ... 08:47 < gribble> https://github.com/bitcoin/bitcoin/issues/20849 | net: disconnect peers by address without using a subnet by vasild 路 Pull Request #20849 路 bitcoin/bitcoin 路 GitHub 08:47 < wumpus> it's a bit absurd, we really shouldn't have waited that long to do rc4 08:49 < MarcoFalke> it slipped the pre-holiday window. If the release doesn't go out before Dec 14th, it is best to wait till January 08:49 < wumpus> would have found this new signing issue so much faster 08:49 < MarcoFalke> Ok, that is true 08:49 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has quit [Quit: My MacBook has gone to sleep. ZZZzzz鈥 08:49 < vasild> jonatack: when I extended CNetAddr to support longer-than-16-bytes addresses (as part of bip155) I also changed CSubNet to only handle ipv4 and ipv6 addresses - because it contains char netmask[16]; it makes no sense to apply it to e.g. 32 byte torv3 address 08:50 < jonatack> If help docs are eligible for 0.21.0rc5, #20829 targets 0.21 and has a couple acks 08:50 < MarcoFalke> (was referring to the -final tag) 08:50 < gribble> https://github.com/bitcoin/bitcoin/issues/20829 | doc: add -netinfo help by jonatack 路 Pull Request #20829 路 bitcoin/bitcoin 路 GitHub 08:50 < jonatack> vasild: yes, thank you, that occurred to me right after checking git blame 08:50 < vasild> In general, subnetting only makes sense for ipv4 and ipv6 08:51 < wumpus> it makes sense for none of the other networks that we support at least 08:52 < vasild> but I failed to verify the callers of the constructor CSubNet(CNetAddr&) which used to create one-host-subnet before and would also "work" for torv2 addresses (in the code before bip155) by matching a single address 08:52 < wumpus> good to catch that before the release 08:53 < vasild> MarcoFalke: found the issue somehow :) 08:53 < MarcoFalke> It is not super critical, but still a nice to have fix 08:53 < wumpus> yes 08:53 < achow101> jonasschnelli: can you upload codesign's result? 08:53 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 08:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has joined #bitcoin-core-dev 08:54 -!- davterra [~davterra@23.226.131.155] has joined #bitcoin-core-dev 08:54 -!- davterra [~davterra@23.226.131.155] has quit [Remote host closed the connection] 08:54 < vasild> fixing banman will not be as easy as https://github.com/bitcoin/bitcoin/issues/20849 08:54 < achow101> given that the signapple result is giving a vmsize of 0x7b000, I think apple fixed codesign_allocate 08:54 < vasild> because banman uses "std::map" - it only bans subnets 08:56 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has left #bitcoin-core-dev ["Ex-Chat"] 09:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has quit [Quit: My MacBook has gone to sleep. ZZZzzz鈥 09:04 -!- kexkey [~kexkey@static-198-54-132-155.cust.tzulo.com] has joined #bitcoin-core-dev 09:09 < vasild> I am inclined to restore the "nonsensical" subnetting of non-IPv[46] networks by assuming one-host-subnet for those 09:09 < vasild> banman only knows how to ban subnets and also de/serializes to disk CSubNet objects 09:11 < achow101> jonasschnelli: it seems that codesign_allocate has changed back to what we were expecting it to do 09:11 < vasild> ideally banman should have a list of banned subnets (CSubNet) + a list of banned hosts (CNetAddr), but that would mean changing the disk format of the banlist 09:12 < sipa> vasild: is this something we need to fix for 0.21? 09:12 < sipa> i assume so? 09:12 < vasild> yes, I guess so, otherwise we don't know how to ban non-ipv46 addresses 09:13 < MarcoFalke> If the fix is too involved, we can document it as known bug and fix in 0.21.1 09:13 < vasild> allowing CSubNet of non-ip addresses seems like a smaller change than banman disk format 09:13 < sipa> it"s not like banning tor addresses means much, as they can't occur on incoming connections 09:13 < vasild> that's right 09:14 < MarcoFalke> jup, it is even more a "just nice to have" fix 09:14 < sipa> what happens if you try? 09:14 < jonasschnelli> achow101: I also tried with MacOS 10.12 (can upload that as well). I鈥檓 afk for 2h,... will upload more later. 09:14 < vasild> banlist.dat + banhosts.dat - have two separate lists and two separate files (not changing the format of banlist.dat), what about that? 09:15 < sipa> vasild: shouldn't be needed 09:15 < sipa> vasild: there was also some desire to support banning by ASN 09:15 < sipa> which will require further changes anyway 09:15 < vasild> sipa: if you try to ban a tor address it would store an invalid CSubNet in banman which matches nothing, e.g. the address will not be banned 09:16 < sipa> ok, not terrible... i'm ok with either 09:16 < sipa> if it's easy to restore csubnet support for other networks, that seems like reasonable (temporary) fix 09:16 < sipa> we can also leave it be 09:17 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.8.2 - https://znc.in] 09:18 < achow101> jonasschnelli: I think codesign and codesign_allocate versions aren't tied to the os version 09:19 < achow101> at least codesign_allocate is part of some xcode command line developer tools package 09:19 < sipa> jonasschnelli: i can't explain why signing with applesign doesn't work though, unless you also used codesign_allocate from apple.for thaf 09:19 < sipa> * for that 09:20 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 09:25 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.8.2 - https://znc.in] 09:25 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 09:32 < wumpus> vasild: sounds like the most generic solution to me, to define that a 'subnet' for other networks is always a single address, and keep the rest of the code the same 09:33 < wumpus> otherwise you'd have essentially to change all the code using subnets to be CSubnet-or-separate-address 09:33 < achow101> sipa: I think jonasschnelli used the macports codesign_allocate which will now behave differently to our codesign_allocate 09:34 < sipa> gah 09:34 < sipa> wumpus: indeed 09:35 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:35 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de00bc904d4378a56acd.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:50 < achow101> sipa, jonasschnelli: If I revert the patch to cctools, I am able to attach the signature and get a valid result 09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:50 < bitcoin-git> [bitcoin] vasild opened pull request #20852: net: allow CSubNet of non-IP networks (master...non_ip_subnets) https://github.com/bitcoin/bitcoin/pull/20852 09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:50 < sipa> achow101: then why did jonasschnelli' rc3 signing fail too? 09:51 < sipa> still, let's revert my patch 09:51 < sipa> it shouldn't be needed anymore in the longer term anyway with applesign (using matching cctools/macports is probably easiest for codesign_allocate) 09:51 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 09:52 < achow101> sipa: jonasschnelli may have done it incorrectly. Properly getting the detached-sig-apply.sh script to use the right codesign_allocate is slightly tricky 09:53 < achow101> I did it wrong a few times before I figured out I needed to re-pack the tarball with the correct codesign_allocate as the script will unpack it again itself 09:53 < sipa> ah, ok! 09:53 < vasild> wumpus: indeed, here it is: https://github.com/bitcoin/bitcoin/pull/20852 09:54 < achow101> sipa: I think this problem just highlights the fact that signapple needs to implement this allocation stuff too 09:54 < achow101> but modifying macho bins to insert another load command seems to be non-trivial 09:54 < vasild> "if it's easy to restore csubnet support for other networks, that seems like reasonable (temporary) fix" -- sipa, done in ^ it is maybe not too complicated 09:55 < sipa> vasild: looks reasonable, will review in more detail 09:55 < vasild> ok :) 09:55 * vasild afk 09:57 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Quit: The Lounge - https://thelounge.chat] 10:01 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 10:01 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Remote host closed the connection] 10:05 < achow101> I think if we are going to use signapple instead of codesign, then we should build codesign_allocate for mac and include it in the tarball. That way we don't rely on the signer to remember to use macports 10:05 < sipa> achow101: yeah 10:05 < sipa> good idea 10:05 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 10:05 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Remote host closed the connection] 10:05 -!- pergaminho [~Cleber@189.26.121.248] has joined #bitcoin-core-dev 10:05 < achow101> at least until I implement allocation 10:06 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev 10:07 -!- samuel-pedraza [a5169307@gateway/web/cgi-irc/kiwiirc.com/ip.165.22.147.7] has joined #bitcoin-core-dev 10:07 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection] 10:08 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 10:08 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Client Quit] 10:09 -!- niftynei_ is now known as niftynei 10:09 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 10:10 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has joined #bitcoin-core-dev 10:10 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Client Quit] 10:11 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 10:11 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Remote host closed the connection] 10:12 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 10:12 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Remote host closed the connection] 10:15 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 10:27 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 256 seconds] 10:33 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 10:43 < jonasschnelli> sipa: jonasschnelli may have done it incorrectly. Properly getting the detached-sig-apply.sh script to use the right codesign_allocate is slightly tricky 10:44 < jonasschnelli> ^ the codesign_allocate is part of the bitcoin-0.21.0rc3-osx-unsigned.tar.gz? right? 10:44 < jonasschnelli> the detached-sig-apply.sh takes the binary in bitcoin-0.21.0rc3-osx-unsigned.tar.gz, right? 10:45 < sipa> hmm yes, i would expect it to 10:46 < jonasschnelli> As for rc4: i tried on macOS 11, verified the hash of bitcoin-0.21.0rc4-osx-unsigned.tar.gz (matched the others), verified the patched codesign_allocate, signed locally, verified the signed app (ok), gbuilt the signer with the created signature (failed) 10:47 < jonasschnelli> I also tried by signing on a macOS 10.12 (relative old) VM. Same result. 10:47 < jonasschnelli> (codesign was already installed, I think that binary is not part of XCode) 10:48 -!- davterra [~davterra@23.226.131.131] has joined #bitcoin-core-dev 10:49 < jonasschnelli> [18:19:06] jonasschnelli: i can't explain why signing with applesign doesn't work though, unless you also used codesign_allocate from apple.for thaf 10:50 < jonasschnelli> ^ achow101 applesign tool only worked on rc3 AFAIK 10:50 -!- samuel-pedraza [a5169307@gateway/web/cgi-irc/kiwiirc.com/ip.165.22.147.7] has quit [Quit: Connection closed] 10:52 < jonasschnelli> I think if we are going to use signapple instead of codesign, then we should build codesign_allocate for mac and include it in the tarball. That way we don't rely on the signer to remember to use macports 10:53 < jonasschnelli> ^ absolutely agree. Otherwise we'd likely end up again with a invalid signature. Another option would be to verify the signature before committing (or at least refuse to finalise the signed dmg if it is invalid). 10:53 < achow101> jonasschnelli: did you repack the tarball after changing codesign_allocate? 10:53 < jonasschnelli> achow101: rc3 has the unpatched codesign_allocate,.. right? 10:54 < achow101> yes 10:54 < jonasschnelli> achow101: I have tested rc4 with a manually copied codesign_allocate from rc3 (manually copy during gbuild) 10:54 -!- mably [uid99779@gateway/web/irccloud.com/x-hfgkgvehibzegecx] has joined #bitcoin-core-dev 10:55 < achow101> how did you manually copy it? 10:55 < achow101> I tested by just running the apply script locally without gitian 10:55 < jonasschnelli> fiddled with the gitian .yml 10:55 < achow101> ah 10:55 < achow101> so detached-sig-apply.sh will untar the unsigned.tar.gz again and use the codesign_allocate it finds when it does that 10:56 < jonasschnelli> I added a step to copy/overwrite the codesign_allocate taken from inputs/ in the yml 10:56 < sipa> this all sounds very error prone, so hard to draw any conclusions 10:56 < achow101> so gitian-osx-signer.yml will untar it. then it runs detached-sig-apply.sh which untars it again into another dir and uses the stuff from that second one 10:57 < jonasschnelli> https://gist.githubusercontent.com/jonasschnelli/d744d3946ebe18ec64a46510d5cff967/raw/49de1f5e2de9a3ead2e7fcd2a1ccfc10eb6ead40/gistfile1.txt 10:58 < jonasschnelli> I placed codesign_allocate_ow in inputs to test with a codesign_allocate without the patch from sipa (rc3) 10:58 < jonasschnelli> Its all very error prone, ... I agree sipa 10:58 < sipa> let's revert my patch for rc5 10:58 < jonasschnelli> Just tell me what I should test and i'll provide you with all the files 10:59 < jonasschnelli> achow101's applesign works fine for rc3 10:59 < jonasschnelli> we might want to use it for rc5, yes 11:00 < jonasschnelli> achow101: in case you want to inspect the macOS 11 created signature for rc4 (that won't produce a valid signature with sipas patch during attach): https://bitcoin.jonasschnelli.ch/signature-osx-rc4-invalid.tar.gz 11:01 < MarcoFalke> did someone check rc1 on 0.19 and 0.20 ? 11:01 < jonasschnelli> Creating the signature for rc4 is not very error prone 11:01 < MarcoFalke> Just to make sure and not run into issues there as well 11:01 < jonasschnelli> MarcoFalke: yes. We should also test those. 11:03 < sipa> jonasschnelli: because this is all presumably due to alignment issues, there is a 50% chance that a given binary will just work, regardless of what approach is used 11:03 < jonasschnelli> I do a testrun with 0.19.2rc1 11:03 < jonasschnelli> sipa: I also have the feeling its that 11:04 < sipa> so we can't conclude that something will work because it has worked for another version in the past (absent better inspection of course0 11:06 < achow101> jonasschnelli: my point is that your change to the gitian .yml doesn't work because it doesn't change codesign_allocate for the second untar that the apply script does 11:08 < achow101> sipa: we do know that macOS codesign_allocate has reverted back to rounding to 0x1000 since the vmsize on rc4 is 0x7b000 11:09 < sipa> achow101: ah ok 11:10 < jonasschnelli> achow101: I guess you're right (my gitian [not]fix). 11:10 -!- Nee [5cc1aa0d@port-92-193-170-13.dynamic.as20676.net] has quit [Remote host closed the connection] 11:11 < achow101> jonasschnelli: yeah, it's very unintuitive. I made the same mistake several times when trying to test that 11:12 < jonasschnelli> So... I'll try again to test rc4 without sipas patch (with apples codesign) 11:12 < jonasschnelli> I might need to rebundle the tar file with the rc3 codesign_allocate 11:12 < achow101> you have to 11:12 < jonasschnelli> or set the CODESIGN_ALLOCATE env in gitian 11:12 < jonasschnelli> (would that work achow101?) 11:13 < jonasschnelli> since detached-sig-apply.sh L34 11:13 < achow101> that might work 11:13 < achow101> I hadn't considered that 11:14 < jonasschnelli> will do that test asap (tomorrow) 11:26 < jonasschnelli> achow101, sipa: rc4 without sipas patch works (with native apple codesign) 11:26 < jonasschnelli> I guess the whole fixing was a unnecessary roundtrip 11:26 < achow101> at least it tells us we can't trust apple 11:26 < jonasschnelli> heh... indeed 11:34 < sipa> ok great to hear 11:35 < jonasschnelli> 0.19.2rc1 works also (with apples macOS 11 codesign) 11:35 < jonasschnelli> If there would just be a way to check the version of apples codesign tool 11:36 < jonasschnelli> however,... it got fixed by apple... suckers! 11:36 < achow101> too bad they don't seem to put their version numbers anywhere 11:39 < jonasschnelli> MarcoFalke: there is nothing open for 0.19.2. Is there even need for a rc2? 11:43 < jonasschnelli> achow101: I pushed the 0.19.2rc1 sig (your turn for windows and tagging) 11:51 -!- bjr [630a55a2@99-10-85-162.lightspeed.stlsmo.sbcglobal.net] has joined #bitcoin-core-dev 12:03 < wumpus> oh so this was one of those cases where 'just wait' was the correct solution, but we had no idea whether Apple saw it as a problem at all 12:03 < wumpus> let alone urgent enough to fix so quickly 12:03 < sipa> maybe some of our twitter ramblings got noticed :) 12:04 < sipa> or maybe they knew about it since a long time, and it only now got addressed 12:04 < wumpus> right you never know who was paying attention 12:10 -!- bjr [630a55a2@99-10-85-162.lightspeed.stlsmo.sbcglobal.net] has quit [Remote host closed the connection] 12:14 < luke-jr> wumpus: thoughts on release notes encouraging upgrading sooner rather than later to demonstrate a minimum lower bound on upgrade time for Taproot? 12:15 < luke-jr> ie, "upgrade asap to help prove we can deploy Taproot faster safely" 12:15 < luke-jr> (not limited to wumpus responding :P) 12:19 -!- pinheadm_ [~pinheadmz@68.161.139.178] has joined #bitcoin-core-dev 12:20 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:22 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Ping timeout: 256 seconds] 12:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 12:29 < wumpus> luke-jr: no problem with that, but i'm not convinced that will give very useful information, how comparable is updating to a major version versus updating to a softfork 12:32 < wumpus> jonasschnelli: sure, we could tag 0.19.2 final, though i guess it still needs release notes? 12:32 < wumpus> doc/release-notes.md currently even speaks of 0.19.1 12:34 < luke-jr> wumpus: well, that's the idea - to try to get closer to the latter by asking users to upgrade as if it weree 12:34 < wumpus> I can update that, and the authors/changelog, but if dunno anyone wants to write anything else 12:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:47 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #20854: [mempool] Remove unnecessary try-block (master...2021-01-load-mempool-cleanup) https://github.com/bitcoin/bitcoin/pull/20854 12:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:48 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-dev 12:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:49 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/e301a9fde351...33cbedef28eb 12:49 < bitcoin-git> bitcoin/0.19 33cbede Wladimir J. van der Laan: doc: Update release notes for 0.19.2 12:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:50 -!- pinheadm_ [~pinheadmz@68.161.139.178] has quit [Ping timeout: 246 seconds] 12:54 < wumpus> ok, release notes updated ^^ time to tag 0.19.2 final? 12:56 -!- pinheadm_ [~pinheadmz@68.161.139.178] has joined #bitcoin-core-dev 12:56 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Ping timeout: 256 seconds] 12:57 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Ping timeout: 264 seconds] 12:58 < luke-jr> wumpus et al: I added a paragraph to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.21.0-Release-Notes-Draft 13:08 -!- pergaminho [~Cleber@189.26.121.248] has quit [Quit: Saindo] 13:09 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:17 -!- lightlike [~lightlike@p200300c7ef0f030055ccb2e7ff848937.dip0.t-ipconnect.de] has quit [Quit: Leaving] 13:25 -!- LoRez1 [~LoRez@185.204.1.185] has quit [Remote host closed the connection] 13:44 -!- leoburd [~leoburd@84.39.116.180] has joined #bitcoin-core-dev 14:16 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 14:24 -!- randy-waterhouse [~kiwigb@180.149.231.156] has joined #bitcoin-core-dev 14:38 -!- randy-waterhouse [~kiwigb@180.149.231.156] has quit [Quit: Leaving.] 14:39 -!- randy-waterhouse [~kiwigb@180.149.231.156] has joined #bitcoin-core-dev 14:43 -!- mably [uid99779@gateway/web/irccloud.com/x-hfgkgvehibzegecx] has quit [Quit: Connection closed for inactivity] 14:57 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 14:58 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 15:10 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 15:11 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 16:03 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 16:06 -!- IGHOR [~quassel@176.121.4.135] has quit [Read error: No route to host] 16:08 -!- randy-waterhouse [~kiwigb@180.149.231.156] has quit [Quit: Leaving.] 16:10 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 16:25 -!- jespada [~jespada@90.254.245.49] has quit [Ping timeout: 272 seconds] 16:27 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 16:28 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 16:28 -!- jespada [~jespada@90.254.245.49] has joined #bitcoin-core-dev 16:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:39 < bitcoin-git> [bitcoin] sipa opened pull request #20855: Revert "Add patch to make codesign_allocate compatible with Apple's" (master...202101_revert_codesign_allocate_hack) https://github.com/bitcoin/bitcoin/pull/20855 16:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:40 < achow101> gitian builders: 0.19.2rc1 sigs pushed 16:45 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 3.0] 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:45 < bitcoin-git> [bitcoin] fanquake closed pull request #20739: [0.19] final rc2 backports (0.19...2012-19rc2) https://github.com/bitcoin/bitcoin/pull/20739 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 17:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408] has joined #bitcoin-core-dev 17:10 < fanquake> achow101: MISMATCH 17:11 < achow101> god damnit 17:11 < achow101> where? 17:11 < fanquake> macOS 0.19.2rc1 17:12 < fanquake> 07672b57e4d8adb438e9dc33a180dd062afb6b260077f9a991645ce7b397dd6b bitcoin-osx-signed.dmg 17:12 < fanquake> 3fef8ec626dfdd719ce265c279c25cc92c927aa2f11d4bc93cefd480f085cb5a bitcoin-osx-signed.dmg 17:12 < sipa> how dis possible 17:12 < sipa> the unsigned step matches? 17:13 < achow101> The one that MacOS likes the signature for is the correct one 17:16 < achow101> https://github.com/achow101/bitcoin/releases/tag/v0.19.2rc1 has all of my results if you want to dig 17:27 < fanquake> just rebuilding 17:27 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 17:28 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 17:36 -!- vasild_ is now known as vasild 17:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:40 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc8ada1c1534...8b6acaca2ff7 17:40 < bitcoin-git> bitcoin/master 729e1d1 Sebastian Falbesoner: Add gitian PGP key for theStack 17:40 < bitcoin-git> bitcoin/master 8b6acac fanquake: Merge #20848: Add gitian PGP key for theStack 17:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:40 < bitcoin-git> [bitcoin] fanquake merged pull request #20848: Add gitian PGP key for theStack (master...add_gitian_pgp_key_for_theStack) https://github.com/bitcoin/bitcoin/pull/20848 17:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:47 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8b6acaca2ff7...8d6715666d24 17:47 < bitcoin-git> bitcoin/master 50a6f8f benthecarman: Add benthecarman to keys.txt 17:47 < bitcoin-git> bitcoin/master 8d67156 fanquake: Merge #20846: Add benthecarman to keys.txt 17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:47 < bitcoin-git> [bitcoin] fanquake merged pull request #20846: Add benthecarman to keys.txt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20846 17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 18:01 -!- DeadWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:01 -!- DeadWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:11 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving] 18:12 -!- davterra [~davterra@23.226.131.131] has quit [Remote host closed the connection] 18:13 < fanquake> achow101: all good after a rebuild. I must have had a bad input sitting around or something. .dmg mounts, app launches fine etc. 18:13 < achow101> phew 18:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:18 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d6715666d24...ff6adac5f461 18:18 < bitcoin-git> bitcoin/master d825a39 Antoine Poinsot: gitian-keys: add darosior's key 18:18 < bitcoin-git> bitcoin/master ff6adac fanquake: Merge #20847: gitian-keys: add darosior's key 18:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:19 < bitcoin-git> [bitcoin] fanquake merged pull request #20847: gitian-keys: add darosior's key (master...darosior_gpg_key) https://github.com/bitcoin/bitcoin/pull/20847 18:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:20 -!- DeadWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:20 -!- DeadWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:27 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:30 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 18:35 -!- IGHOR [~quassel@176.121.4.135] has quit [Read error: No route to host] 18:39 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 18:53 -!- unauvum [~unauvum@134.122.10.34] has quit [Ping timeout: 260 seconds] 18:57 -!- unauvum [~unauvum@134.122.10.34] has joined #bitcoin-core-dev 19:22 -!- leoburd [~leoburd@84.39.116.180] has quit [Remote host closed the connection] 19:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:41 -!- hoobop1 [~hoobop@s91904426.blix.com] has joined #bitcoin-core-dev 21:06 < jonasschnelli> 0.20.2rc1 macOS signatures are invalid (local test) 21:10 * sipa erupts in an apple-demon dispelling chant 21:16 < sipa> pom pom pom pom pom 21:17 < jonasschnelli> 0.20.2rc2 attaching the signature with codesign_allocate WITH sipas patch works 21:18 < jonasschnelli> so apple has not fixed it... 21:18 < jonasschnelli> trying now with a signatue done on macOS 10.12 21:22 < jonasschnelli> wild thought: what if we instead of detaching and attaching the macOS sig, we stuff the complete signed binary through the "signer" gitian step and just verify nothing else expect the signature has changed? lame? 21:24 < sipa> that requires a way to remove the signature, and get back to the original unsigned binary 21:24 < sipa> i don't know if there is a reliable way of doing so, and if there is... it still needs codesign_allocate 21:25 < jonasschnelli> sipa: something like hashing the binary "up to the signature"? 21:26 < sipa> yes, but it hashes the binary _after_ running codesign_allocate 21:27 < sipa> which modifies loading instructions in the binary... not something you can easily ignore 21:27 < jonasschnelli> sipa: my idea was to just use pagestuff to get the signature position, then hash the signed binary (without the signature) and hash the unsigned binary and compare 21:27 < jonasschnelli> sipa: yes.. I think that won't work 21:27 < sipa> that won't work 21:27 < sipa> you need to hash the unsigned binary _after_ codesign_allocate 21:27 < jonasschnelli> bah 21:28 < sipa> which gets us back to square one, because the whole problem is recreating the same codesign_allocate step at attaching time 21:28 < jonasschnelli> jup 21:31 < jonasschnelli> testing 0.20.2rc1 now with achow101's signer 21:32 < jonasschnelli> works 21:32 < jonasschnelli> I'm just going to push that signature 21:44 < jonasschnelli> gitian builders: 0.20.2rc1 sigs pushed 21:46 < jonasschnelli> current state: 0.19.2rc1 and 0.20.2rc1 are signed (with achow101's tool), 0.21.0rc4 can't be signed deterministically (needs revert of sipas patch) 21:49 < jonasschnelli> achow101: I think compiling codesign_allocate for macOS should be easy, I just compiled out depends package native_cctools locally on my mac (https://github.com/tpoechtrager/cctools-port/) 21:51 < jonasschnelli> I think we just need to crosscompile that package as well and extract the codesign_allocate and place it in the tarball (and modify the detach-sig-create script to make use of it [as well as required the signapple changes]) 21:51 < jonasschnelli> probably name it x86_64-apple-darwin11-codesign_allocate 21:52 < sipa> yeah, i think that's pretty much it 21:54 < achow101> I haven't figured out how to cross compile cctools 21:55 < achow101> but that may be because my knowledge of build systems is slightly lacking 21:55 < jonasschnelli> achow101: https://github.com/tpoechtrager/cctools-port/#install-cctools-and-ld64 21:55 < jonasschnelli> I'll give it a try later 21:55 < achow101> I tried it and got a linux binary out ... 21:56 < sipa> i think you can summon some knowledge about cross compilation here 21:56 < sipa> let me try 21:57 < sipa> *dongcarl* 21:59 < achow101> codesign_allocate can remove a signature, but it doesn't reduce the vmsize so it's unhelpful 22:02 < jonasschnelli> since only the macOS signer needs the codesign_allocate, we could also place a quick build script into the tarball (fetch the cctools/libtapi, compile) 22:02 < jonasschnelli> (might be the cleaner solution and doesn't delay the dependency build) 22:10 < aj> sipa: (a cross compiler you say? that's what you get when you have too many syntax errors right?) 22:17 -!- DeadWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 22:47 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 22:47 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 22:52 < achow101> I wonder if there's some way to add a detached sig to the OS detached sigs db at install time 22:53 < achow101> then we wouldn't have to attach the sig to the binary, just make the installer thing put the sig in the right place on the os for us 22:54 < achow101> too bad a dmg isn't actually an installer 22:59 -!- Cory [~Cory@unaffiliated/cory] has quit [Read error: Connection reset by peer] 23:05 < jonasschnelli> achow101: that would require a custom script (installer) which would require a codesignature as well. 23:05 < jonasschnelli> achow101: do you see any downsides in just using your tool? 23:08 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 23:08 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 23:09 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 23:17 < achow101> The downside is that I have to maintain it lol 23:29 < jonasschnelli> achow101: good point. :) 23:37 -!- DeadWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 23:47 < sipa> it's not like apple ever changes anything about their codesignijg infrastructure, right? ;) 23:53 < jonasschnelli> well... 23:56 < jonasschnelli> is Apples codesign using apples /usr/bin/codesign_allocate or does it handle the allocation internally? 23:57 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev --- Log closed Tue Jan 05 00:00:06 2021